Timeline



Apr 18, 2019:

9:26 PM Changeset in webkit [244450] by Fujii Hironori
  • 6 edits in trunk/Source/WebCore

Implement KeyedDecoderGeneric and KeyedEncoderGeneric
https://bugs.webkit.org/show_bug.cgi?id=186410

Reviewed by Don Olmstead.

Implemented KeyedDecoderGeneric and KeyedEncoderGeneric by using
WTF::Persistence::Decoder and WTF::Persistence::Encoder.

No new tests. Covered by existing tests.

  • PlatformWin.cmake: Added KeyedDecoderGeneric.cpp and

KeyedEncoderGeneric.cpp, and removed KeyedDecoderCF.cpp and
KeyedEncoderCF.cpp for WinCairo port.

  • platform/generic/KeyedDecoderGeneric.cpp:
  • platform/generic/KeyedDecoderGeneric.h:
  • platform/generic/KeyedEncoderGeneric.cpp:
  • platform/generic/KeyedEncoderGeneric.h:
9:18 PM Changeset in webkit [244449] by megan_gardner@apple.com
  • 2 edits in trunk/LayoutTests

Update autoscroll test to lift at the end and be less flakey
https://bugs.webkit.org/show_bug.cgi?id=197084

Test not lifting at the end caused issues for other tests.
Also the positions were a bit too exact and caused the
test to be flakey. These new positions should result in more consistent
behaviour.

Reviewed by Tim Horton.

  • fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html:
8:28 PM Changeset in webkit [244448] by Ross Kirsling
  • 4 edits in trunk

[WinCairo] Non-unified build fails to link Tools
https://bugs.webkit.org/show_bug.cgi?id=196866

Reviewed by Fujii Hironori.

.:

  • Source/cmake/OptionsWin.cmake:

Build WebCore as an object library when unified builds are disabled
(and we haven't explicitly asked to build it as a shared library).
This is necessary for two reasons:

  • Non-unified WebCore.lib is too large for the MSVC linker to create (>4GB).
  • Some WebCore object files are not actually used, but DumpRenderTree and TestRunnerInjectedBundle still expect that their symbols will be re-exported via WebKit[Legacy].

Source/WebCore:

  • CMakeLists.txt:

Drive-by fix -- don't disable string pooling when building WebCoreTestSupport.
(This should have been part of r235203.)

7:36 PM Changeset in webkit [244447] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit

Deprecate WebKit2 plug-in support.
<rdar://problem/43812306> and https://bugs.webkit.org/show_bug.cgi?id=197080

Reviewed by Andy Estes.

  • UIProcess/API/Cocoa/WKPreferences.h:
  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences encodeWithCoder:]):
(-[WKPreferences initWithCoder:]):
(-[WKPreferences javaEnabled]):
(-[WKPreferences setJavaEnabled:]):
(-[WKPreferences plugInsEnabled]):
(-[WKPreferences setPlugInsEnabled:]):

7:25 PM Changeset in webkit [244446] by commit-queue@webkit.org
  • 18 edits in trunk

Unreviewed, rolling out r244434.
https://bugs.webkit.org/show_bug.cgi?id=197089

caused 1 API test failure (Requested by zalan on #webkit).

Reverted changeset:

"Regression (r244291): Broken API Test
AutoLayoutRenderingProgressRelativeOrdering"
https://bugs.webkit.org/show_bug.cgi?id=196948
https://trac.webkit.org/changeset/244434

5:12 PM Changeset in webkit [244445] by don.olmstead@sony.com
  • 2 edits in trunk/Source/WebCore

[CMake] Make WebCore headers copies
https://bugs.webkit.org/show_bug.cgi?id=182512
<rdar://problem/37510435>

Unreviewed build fix.

Add new header from r244440.

  • Headers.cmake:
4:52 PM WikiStart edited by wilander@apple.com
Added link to the Ad Click Attribution draft spec under Planning. (diff)
4:48 PM ad-click-attribution-draft-spec created by wilander@apple.com
Initial commit.
4:38 PM Changeset in webkit [244444] by wenson_hsieh@apple.com
  • 12 edits in trunk

Add new compatibility mode API on WKNavigation
https://bugs.webkit.org/show_bug.cgi?id=197069
<rdar://problem/50025800>

Reviewed by Tim Horton.

Source/WebKit:

Adds a new property on WKNavigation.

  • Shared/WebCompatibilityMode.h:

Drive-by fix: make this enum class 8 bits wide.

  • UIProcess/API/APINavigation.h:

(API::Navigation::setEffectiveCompatibilityMode):
(API::Navigation::effectiveCompatibilityMode const):

Add a new member variable to API::Navigation.

  • UIProcess/API/Cocoa/WKNavigation.h:
  • UIProcess/API/Cocoa/WKNavigation.mm:
  • UIProcess/API/Cocoa/WKWebpagePreferences.mm:
  • UIProcess/API/Cocoa/WKWebpagePreferencesInternal.h:

Add various hooks into WebKitAdditions.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

Set API::Navigation's effective compatibility mode.

(WebKit::WebPageProxy::effectiveCompatibilityModeAfterAdjustingPolicies):

Renamed and refactored this method to return the effective compatibility mode, chosen while adjusting website
policies.

(WebKit::WebPageProxy::adjustPoliciesForCompatibilityMode): Deleted.

  • UIProcess/WebPageProxy.h:

Tools:

Add a block property for -didCommitNavigation to TestNavigationDelegate.

  • TestWebKitAPI/cocoa/TestNavigationDelegate.h:
  • TestWebKitAPI/cocoa/TestNavigationDelegate.mm:

(-[TestNavigationDelegate webView:didCommitNavigation:]):

4:20 PM Changeset in webkit [244443] by don.olmstead@sony.com
  • 39 edits
    2 adds in trunk

[CMake] Make WebCore headers copies
https://bugs.webkit.org/show_bug.cgi?id=182512
<rdar://problem/37510435>

Reviewed by Alex Christensen.

Source/WebCore:

The header copying is moved to a target WebCorePrivateFrameworkHeaders. This target was
originally Windows only but now this is enabled for all CMake based ports.

Enumerated all headers within WebCore that are used for WebKit(Legacy), tools and
tests. Shared headers are within Headers.cmake while port and platform specific headers
are in their respective CMake files. Listing out all headers is preferred because globbing
will break the build whenever a file is added.

All include directories within the WebCore source tree are now PRIVATE. They were
modified to use WebCore_PRIVATE_INCLUDE_DIRECTORIES. They will not propagate to other targets
which will prevent erroneous includes in targets dependent on WebCore.

  • CMakeLists.txt:
  • Headers.cmake: Added.
  • PlatformAppleWin.cmake:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:
  • PlatformPlayStation.cmake:
  • PlatformWPE.cmake:
  • PlatformWin.cmake:
  • PlatformWinCairo.cmake:
  • platform/Cairo.cmake:
  • platform/Curl.cmake:
  • platform/FreeType.cmake:
  • platform/GStreamer.cmake:
  • platform/HolePunch.cmake:
  • platform/ImageDecoders.cmake:
  • platform/Soup.cmake: Added.
  • platform/TextureMapper.cmake:

Source/WebKit:

WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. This revealed
problems with WebKit's usage of WebCore headers. All include directories directly
referencing the WebCore source tree we're removed from the CMake files. Any includes
of WebCore headers using "*.h" were modified to <WebCore/*.h>

Removed generation of forwarding headers for WebCore using the perl script.

  • CMakeLists.txt:
  • NetworkProcess/curl/NetworkDataTaskCurl.h:
  • PlatformWPE.cmake:
  • PlatformWin.cmake:
  • Scripts/generate-forwarding-headers.pl:
  • UIProcess/API/glib/WebKitUserContentFilterStore.cpp:
  • UIProcess/API/wpe/WebKitColorPrivate.h:
  • UIProcess/WebsiteData/win/WebsiteDataStoreWin.cpp:
  • UIProcess/win/PageClientImpl.cpp:

Source/WebKitLegacy:

Added WebCorePrivateFrameworkHeaders as a dependency of WebKitLegacy for all
ports.

WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. This revealed
problems with WebKit's usage of WebCore headers. All include directories directly
referencing the WebCore source tree we're removed from the CMake files.

  • CMakeLists.txt:
  • PlatformWin.cmake:

Tools:

Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
ports.

WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
of WebCore headers using "*.h" were modified to <WebCore/*.h>

  • DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
  • DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
  • DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
  • DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/PlatformWin.cmake:
  • TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
  • TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
  • WebKitTestRunner/win/PlatformWebViewWin.cpp:
3:42 PM Changeset in webkit [244442] by justin_fan@apple.com
  • 48 edits in trunk

Source/WebCore:
[Web GPU] Implement API default values
https://bugs.webkit.org/show_bug.cgi?id=197032

Reviewed by Myles C. Maxfield.

Add default values and 'required' qualifiers recently merged to the WebGPU API.

WebGPU tests specifying these default values have been updated to rely on them for functionality.

  • Modules/webgpu/GPUBindGroupLayoutBinding.idl:
  • Modules/webgpu/GPUBindGroupLayoutDescriptor.idl:
  • Modules/webgpu/GPUBlendDescriptor.idl:
  • Modules/webgpu/GPUBufferDescriptor.idl:
  • Modules/webgpu/GPUColor.idl:
  • Modules/webgpu/GPUColorStateDescriptor.idl:
  • Modules/webgpu/GPUDepthStencilStateDescriptor.idl:
  • Modules/webgpu/GPUExtent3D.idl:
  • Modules/webgpu/GPUInputStateDescriptor.idl:
  • Modules/webgpu/GPUOrigin3D.h:
  • Modules/webgpu/GPUOrigin3D.idl:
  • Modules/webgpu/GPURequestAdapterOptions.idl:
  • Modules/webgpu/GPUTextureDescriptor.idl:
  • Modules/webgpu/GPUVertexAttributeDescriptor.idl:
  • Modules/webgpu/GPUVertexInputDescriptor.idl:
  • Modules/webgpu/WebGPUBindGroupBinding.idl:
  • Modules/webgpu/WebGPUBindGroupDescriptor.idl:
  • Modules/webgpu/WebGPUBufferBinding.h:
  • Modules/webgpu/WebGPUBufferBinding.idl:
  • Modules/webgpu/WebGPUCommandEncoder.idl:
  • Modules/webgpu/WebGPUPipelineDescriptorBase.idl:
  • Modules/webgpu/WebGPUPipelineLayoutDescriptor.idl:
  • Modules/webgpu/WebGPUPipelineStageDescriptor.idl:
  • Modules/webgpu/WebGPURenderPassDescriptor.idl:
  • Modules/webgpu/WebGPURenderPipelineDescriptor.cpp:

(WebCore::WebGPURenderPipelineDescriptor::tryCreateGPURenderPipelineDescriptor const):

  • Modules/webgpu/WebGPURenderPipelineDescriptor.h:
  • Modules/webgpu/WebGPURenderPipelineDescriptor.idl:
  • Modules/webgpu/WebGPUShaderModuleDescriptor.idl:
  • platform/graphics/gpu/GPUBlendDescriptor.h:
  • platform/graphics/gpu/GPUColorStateDescriptor.h:
  • platform/graphics/gpu/GPUCommandBuffer.h:
  • platform/graphics/gpu/GPUDepthStencilStateDescriptor.h:
  • platform/graphics/gpu/GPURenderPassDescriptor.h:
  • platform/graphics/gpu/GPURenderPipelineDescriptor.h:

(WebCore::GPURenderPipelineDescriptor::GPURenderPipelineDescriptor):

  • platform/graphics/gpu/GPURequestAdapterOptions.h:
  • platform/graphics/gpu/GPUTextureDescriptor.h:
  • platform/graphics/gpu/GPUVertexAttributeDescriptor.h:
  • platform/graphics/gpu/GPUVertexInputDescriptor.h:
  • platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:

(WebCore::convertRenderPipelineDescriptor):
(WebCore::trySetFunctionsForPipelineDescriptor):

LayoutTests:
[WebGPU] Implement API default values
https://bugs.webkit.org/show_bug.cgi?id=197032

Reviewed by Myles C. Maxfield.

Update WebGPU tests to use default values wherever applicable.

  • webgpu/bind-groups.html:
  • webgpu/blend-triangle-strip.html:
  • webgpu/blit-commands.html:
  • webgpu/buffer-command-buffer-races.html:
  • webgpu/buffer-resource-triangles.html:
  • webgpu/color-write-mask-triangle-strip.html:
  • webgpu/compute-squares.html:
  • webgpu/depth-enabled-triangle-strip.html:
  • webgpu/draw-indexed-triangles.html:
  • webgpu/js/webgpu-functions.js:

(createBasicDepthTexture):

  • webgpu/texture-triangle-strip.html:
  • webgpu/textures-textureviews.html:
  • webgpu/vertex-buffer-triangle-strip.html:
  • webgpu/whlsl.html:
3:26 PM Changeset in webkit [244441] by Chris Dumez
  • 4 edits in trunk/Source

[iOS] Improve detection of when web views go to background / foreground
https://bugs.webkit.org/show_bug.cgi?id=197035
<rdar://problem/45281182>

Reviewed by Tim Horton.

Source/WebKit:

Improve detection of when web views go to background / foreground on iOS.

  • UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker): Deleted.
(WebKit::ApplicationStateTracker::~ApplicationStateTracker): Deleted.
(WebKit::ApplicationStateTracker::applicationDidEnterBackground): Deleted.
(WebKit::ApplicationStateTracker::applicationDidFinishSnapshottingAfterEnteringBackground): Deleted.
(WebKit::ApplicationStateTracker::applicationWillEnterForeground): Deleted.

Source/WTF:

Add build time flag.

  • wtf/FeatureDefines.h:
3:16 PM Changeset in webkit [244440] by jer.noble@apple.com
  • 41 edits
    2 copies
    2 adds in trunk/Source

Refactoring: Pull all fullscreen code out of Document and into its own helper class
https://bugs.webkit.org/show_bug.cgi?id=197017

Reviewed by Eric Carlson.

Source/WebCore:

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::matchesFullScreenPseudoClass):
(WebCore::matchesFullScreenAnimatingFullScreenTransitionPseudoClass):
(WebCore::matchesFullScreenDocumentPseudoClass):
(WebCore::matchesFullScreenControlsHiddenPseudoClass):

  • dom/Document.cpp:

(WebCore::Document::removedLastRef):
(WebCore::Document::prepareForDestruction):
(WebCore::Document::nodeChildrenWillBeRemoved):
(WebCore::Document::nodeWillBeRemoved):
(WebCore::isAttributeOnAllOwners): Deleted.
(WebCore::Document::fullScreenIsAllowedForElement const): Deleted.
(WebCore::Document::requestFullScreenForElement): Deleted.
(WebCore::Document::webkitCancelFullScreen): Deleted.
(WebCore::Document::webkitExitFullscreen): Deleted.
(WebCore::Document::webkitFullscreenEnabled const): Deleted.
(WebCore::unwrapFullScreenRenderer): Deleted.
(WebCore::Document::webkitWillEnterFullScreen): Deleted.
(WebCore::Document::webkitDidEnterFullScreen): Deleted.
(WebCore::Document::webkitWillExitFullScreen): Deleted.
(WebCore::Document::webkitDidExitFullScreen): Deleted.
(WebCore::Document::setFullScreenRenderer): Deleted.
(WebCore::Document::dispatchFullScreenChangeEvents): Deleted.
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Deleted.
(WebCore::Document::fullScreenElementRemoved): Deleted.
(WebCore::Document::adjustFullScreenElementOnNodeRemoval): Deleted.
(WebCore::Document::isAnimatingFullScreen const): Deleted.
(WebCore::Document::setAnimatingFullScreen): Deleted.
(WebCore::Document::areFullscreenControlsHidden const): Deleted.
(WebCore::Document::setFullscreenControlsHidden): Deleted.
(WebCore::Document::clearFullscreenElementStack): Deleted.
(WebCore::Document::popFullscreenElementStack): Deleted.
(WebCore::Document::pushFullscreenElementStack): Deleted.
(WebCore::Document::addDocumentToFullScreenChangeEventQueue): Deleted.

  • dom/Document.h:

(WebCore::Document::fullscreenManager):
(WebCore::Document::webkitIsFullScreen const): Deleted.
(WebCore::Document::webkitFullScreenKeyboardInputAllowed const): Deleted.
(WebCore::Document::webkitCurrentFullScreenElement const): Deleted.
(WebCore::Document::webkitCurrentFullScreenElementForBindings const): Deleted.
(WebCore::Document::fullScreenRenderer const): Deleted.
(WebCore::Document::webkitFullscreenElement const): Deleted.
(WebCore::Document::webkitFullscreenElementForBindings const): Deleted.

  • dom/Document.idl:
  • dom/DocumentFullscreen.h:

(WebCore::DocumentFullscreen::webkitFullscreenEnabled):
(WebCore::DocumentFullscreen::webkitFullscreenElement):
(WebCore::DocumentFullscreen::webkitExitFullscreen):
(WebCore::DocumentFullscreen::webkitIsFullScreen):
(WebCore::DocumentFullscreen::webkitFullScreenKeyboardInputAllowed):
(WebCore::DocumentFullscreen::webkitCurrentFullScreenElement):
(WebCore::DocumentFullscreen::webkitCancelFullScreen):

  • dom/DocumentFullscreen.idl:
  • dom/Element.cpp:

(WebCore::Element::webkitRequestFullscreen):

  • dom/EventPath.cpp:

(WebCore::shouldEventCrossShadowBoundary):

  • dom/FullscreenManager.cpp: Added.

(WebCore::isAttributeOnAllOwners):
(WebCore::FullscreenManager::FullscreenManager):
(WebCore::FullscreenManager::fullscreenIsAllowedForElement const):
(WebCore::FullscreenManager::requestFullscreenForElement):
(WebCore::FullscreenManager::cancelFullscreen):
(WebCore::FullscreenManager::requestExitFullscreen):
(WebCore::FullscreenManager::exitFullscreen):
(WebCore::FullscreenManager::isFullscreenEnabled const):
(WebCore::unwrapFullscreenRenderer):
(WebCore::FullscreenManager::willEnterFullscreen):
(WebCore::FullscreenManager::didEnterFullscreen):
(WebCore::FullscreenManager::willExitFullscreen):
(WebCore::FullscreenManager::didExitFullscreen):
(WebCore::FullscreenManager::setFullscreenRenderer):
(WebCore::FullscreenManager::dispatchFullscreenChangeEvents):
(WebCore::FullscreenManager::dispatchFullscreenChangeOrErrorEvent):
(WebCore::FullscreenManager::fullscreenElementRemoved):
(WebCore::FullscreenManager::adjustFullscreenElementOnNodeRemoval):
(WebCore::FullscreenManager::isAnimatingFullscreen const):
(WebCore::FullscreenManager::setAnimatingFullscreen):
(WebCore::FullscreenManager::areFullscreenControlsHidden const):
(WebCore::FullscreenManager::setFullscreenControlsHidden):
(WebCore::FullscreenManager::clear):
(WebCore::FullscreenManager::emptyEventQueue):
(WebCore::FullscreenManager::clearFullscreenElementStack):
(WebCore::FullscreenManager::popFullscreenElementStack):
(WebCore::FullscreenManager::pushFullscreenElementStack):
(WebCore::FullscreenManager::addDocumentToFullscreenChangeEventQueue):

  • dom/FullscreenManager.h: Added.

(WebCore::FullscreenManager::document):
(WebCore::FullscreenManager::document const):
(WebCore::FullscreenManager::topDocument const):
(WebCore::FullscreenManager::page const):
(WebCore::FullscreenManager::frame const):
(WebCore::FullscreenManager::documentElement const):
(WebCore::FullscreenManager::hasLivingRenderTree const):
(WebCore::FullscreenManager::pageCacheState const):
(WebCore::FullscreenManager::scheduleFullStyleRebuild):
(WebCore::FullscreenManager::fullscreenElement const):
(WebCore::FullscreenManager::isFullscreen const):
(WebCore::FullscreenManager::isFullscreenKeyboardInputAllowed const):
(WebCore::FullscreenManager::currentFullscreenElement const):
(WebCore::FullscreenManager::fullscreenRenderer const):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::isFullscreen const):
(WebCore::HTMLMediaElement::isStandardFullscreen const):
(WebCore::HTMLMediaElement::enterFullscreen):
(WebCore::HTMLMediaElement::exitFullscreen):

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::canShowControlsManager const):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):

  • inspector/agents/InspectorDOMAgent.cpp:
  • page/EventHandler.cpp:

(WebCore::EventHandler::isKeyEventAllowedInFullScreen const):
(WebCore::EventHandler::internalKeyEvent):

  • page/Page.cpp:

(WebCore::Page::setFullscreenControlsHidden):

  • rendering/RenderFullScreen.cpp:

(WebCore::RenderFullScreen::wrapNewRenderer):
(WebCore::RenderFullScreen::wrapExistingRenderer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::isDescendantOfFullScreenLayer):

  • rendering/updating/RenderTreeBuilder.h:
  • rendering/updating/RenderTreeBuilderInline.cpp:

(WebCore::RenderTreeBuilder::Inline::splitInlines):

  • rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::createRenderer):

  • style/StyleSharingResolver.cpp:

(WebCore::Style::SharingResolver::canShareStyleWithElement const):

  • testing/Internals.cpp:

(WebCore::Internals::webkitWillEnterFullScreenForElement):
(WebCore::Internals::webkitDidEnterFullScreenForElement):
(WebCore::Internals::webkitWillExitFullScreenForElement):
(WebCore::Internals::webkitDidExitFullScreenForElement):
(WebCore::Internals::isAnimatingFullScreen const):

Source/WebKit:

  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::willEnterFullScreen):
(WebKit::WebFullScreenManager::didEnterFullScreen):
(WebKit::WebFullScreenManager::willExitFullScreen):
(WebKit::WebFullScreenManager::didExitFullScreen):
(WebKit::WebFullScreenManager::setAnimatingFullScreen):
(WebKit::WebFullScreenManager::requestExitFullScreen):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:

(webkit_dom_document_webkit_cancel_fullscreen):
(webkit_dom_document_webkit_exit_fullscreen):
(webkit_dom_document_get_webkit_is_fullscreen):
(webkit_dom_document_get_webkit_fullscreen_keyboard_input_allowed):
(webkit_dom_document_get_webkit_current_fullscreen_element):
(webkit_dom_document_get_webkit_fullscreen_element):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):

Source/WebKitLegacy/mac:

  • DOM/DOMDocument.mm:

(-[DOMDocument webkitIsFullScreen]):
(-[DOMDocument webkitFullScreenKeyboardInputAllowed]):
(-[DOMDocument webkitCurrentFullScreenElement]):
(-[DOMDocument webkitFullscreenEnabled]):
(-[DOMDocument webkitFullscreenElement]):
(-[DOMDocument webkitCancelFullScreen]):
(-[DOMDocument webkitExitFullscreen]):

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::createWindow):

  • WebCoreSupport/WebKitFullScreenListener.mm:

(-[WebKitFullScreenListener webkitWillEnterFullScreen]):
(-[WebKitFullScreenListener webkitDidEnterFullScreen]):
(-[WebKitFullScreenListener webkitWillExitFullScreen]):
(-[WebKitFullScreenListener webkitDidExitFullScreen]):

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController enterFullScreen:]):
(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
(-[WebFullScreenController requestExitFullScreen]):
(-[WebFullScreenController exitFullScreen]):
(-[WebFullScreenController finishedExitFullScreenAnimation:]):
(-[WebFullScreenController _manager]):

  • WebView/WebView.mm:

(-[WebView _didStartProvisionalLoadForFrame:]):

Source/WebKitLegacy/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::createWindow):

  • WebView.cpp:

(WebView::fullScreenClientWillEnterFullScreen):
(WebView::fullScreenClientDidEnterFullScreen):
(WebView::fullScreenClientWillExitFullScreen):
(WebView::fullScreenClientDidExitFullScreen):

3:07 PM Changeset in webkit [244439] by jer.noble@apple.com
  • 11 edits
    2 adds in trunk

Add support for parsing FairPlayStreaming PSSH boxes.
https://bugs.webkit.org/show_bug.cgi?id=197064

Reviewed by Eric Carlson.

Source/WebCore:

API Tests: ISO.ISOFairPlayStreamingPsshBox

Add a new set of ISOBox classes for parsing the contents of a FairPlayStreaming PSSH box,
and add support for this new box to CDMFairPlayStreaming.

Drive-by fix: add an explicit include for MainThread.h to LibWebRTCProviderCocoa.cpp.

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FourCC.h:
  • platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:

(WebCore::CDMPrivateFairPlayStreaming::cencName):
(WebCore::fairPlaySystemID):
(WebCore::extractSchemeAndKeyIdFromCenc):
(WebCore::CDMPrivateFairPlayStreaming::extractKeyIDsCenc):
(WebCore::CDMPrivateFairPlayStreaming::sanitizeCenc):
(WebCore::validInitDataTypes):
(WebCore::CDMFactory::platformRegisterFactories):

  • platform/graphics/avfoundation/CDMFairPlayStreaming.h:
  • platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.cpp: Added.

(WebCore::ISOFairPlayStreamingPsshBox::fairPlaySystemID):
(WebCore::ISOFairPlayStreamingInfoBox::parse):
(WebCore::ISOFairPlayStreamingKeyRequestInfoBox::parse):
(WebCore::ISOFairPlayStreamingKeyAssetIdBox::parse):
(WebCore::ISOFairPlayStreamingKeyContextBox::parse):
(WebCore::ISOFairPlayStreamingKeyVersionListBox::parse):
(WebCore::ISOFairPlayStreamingKeyRequestBox::parse):
(WebCore::ISOFairPlayStreamingInitDataBox::parse):
(WebCore::ISOFairPlayStreamingPsshBox::parse):

  • platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h: Added.
  • platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:

Source/WTF:

  • wtf/Platform.h:

Tools:

  • TestWebKitAPI/Tests/WebCore/ISOBox.cpp:

(TestWebKitAPI::TEST):

2:57 PM Changeset in webkit [244438] by megan_gardner@apple.com
  • 2 edits in trunk/Source/WebKit

Update UIKit when a cut causes a selection change
https://bugs.webkit.org/show_bug.cgi?id=197047
<rdar://problem/36311563>

Reviewed by Wenson Hsieh.

We need to let UIKit know when a cut causes a selection change (always),
so that is can appropriately update the button on the keyboard bar.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cutForWebView:]):

2:49 PM Changeset in webkit [244437] by bfulgham@apple.com
  • 6 edits in trunk

InjectedBundle parameters often need initialization function called before unarchiving
https://bugs.webkit.org/show_bug.cgi?id=189709
<rdar://problem/44573653>

Reviewed by Ryosuke Niwa.

Source/WebKit:

Handle the case where the InjectedBundle parameters do not successfully decode because they contain
an unexpected class from the embedding program. If this happens, try decoding the bundle parameters
after the bundle initialiation function runs, which gives the embedding program the opportunity to
register additional classes that are safe for serialization.

Extend WKWebProcessPlugIn with a method that returns the names of any custom classes that need
to be serialized by the InjectedBundle.

Create a new 'decodeBundleParameters' method that contains the logic that used to live in 'initialize'.
Revise 'initialize' to call this new method.

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::initialize): Use the new method.
(WebKit::InjectedBundle::decodeBundleParameters): Added.
(WebKit::InjectedBundle::setBundleParameters): Use 'decodeObjectOfClasses' with the more complete
'classesForCoder' method to unarchive the passed bundle parameters, rather than the
NSDictionary-specific method, since InjectedBundles often encode other types of objects, and the
NSDictionary object may itself hold other kinds of objects.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:

(WebKit::WKWebProcessPlugIn::additionalClassesForParameterCoder): Added.

Tools:

  • TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:

(-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.

2:45 PM Changeset in webkit [244436] by sihui_liu@apple.com
  • 30 edits
    3 adds in trunk

Blob type cannot be stored correctly in IDB when IDBObjectStore has autoIncrement and keyPath options
https://bugs.webkit.org/show_bug.cgi?id=196128
<rdar://problem/49562115>

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Updated test expectations to PASS.

  • web-platform-tests/IndexedDB/nested-cloning-large-expected.txt:
  • web-platform-tests/IndexedDB/nested-cloning-large-multiple-expected.txt:
  • web-platform-tests/IndexedDB/nested-cloning-small-expected.txt:

Source/WebCore:

If a key is auto-generated, it should become a property of the value object. Network process would perform the
key injection by deserializing IDBValue into script value, setting the property, serializing the result and
storing it in a database record. But network process does not have a JSDOMGlobalObject, so it would fail to
deserialize types including Blob and File.

To solve this issue, we move the key injection to web process and let network process store the original value
it gets. In this case, when web process asks for some value, network process should return key, value and key
path so that web process can decide whether it should perform a key injection before returning the result. Note
that the auto-generated key would always be stored as the key in a ObjectStore record.

Test: storage/indexeddb/modern/objectstore-autoincrement-types.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::setGetResult):

  • Modules/indexeddb/IDBCursor.h:

(WebCore::IDBCursor::primaryKeyPath):

  • Modules/indexeddb/IDBGetAllResult.cpp:

(WebCore::IDBGetAllResult::isolatedCopy):
(WebCore::IDBGetAllResult::addKey):
(WebCore::IDBGetAllResult::addValue):
(WebCore::IDBGetAllResult::keys const):
(WebCore::IDBGetAllResult::values const):
(WebCore::IDBGetAllResult::allBlobFilePaths const):
(WebCore::isolatedCopyOfVariant): Deleted.

  • Modules/indexeddb/IDBGetAllResult.h: Introduce an IDBKeyPath parameter. Also replace Variant with two Vectors,

because we only needed to store either key or value before, and now the stored value could be incomplete.
(WebCore::IDBGetAllResult::IDBGetAllResult):
(WebCore::IDBGetAllResult::keyPath const):
(WebCore::IDBGetAllResult::encode const):
(WebCore::IDBGetAllResult::decode):

  • Modules/indexeddb/IDBGetResult.cpp:

(WebCore::IDBGetResult::setValue):

  • Modules/indexeddb/IDBGetResult.h:

(WebCore::IDBGetResult::IDBGetResult):
(WebCore::IDBGetResult::keyPath const):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::setResult):
(WebCore::IDBRequest::setResultToStructuredClone):

  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::didGetAllRecordsOnServer):
(WebCore::IDBTransaction::didGetRecordOnServer):

  • Modules/indexeddb/server/MemoryIDBBackingStore.cpp:

(WebCore::IDBServer::MemoryIDBBackingStore::getRecord):

  • Modules/indexeddb/server/MemoryIndex.cpp:

(WebCore::IDBServer::MemoryIndex::getResultForKeyRange const):
(WebCore::IDBServer::MemoryIndex::getAllRecords const):

  • Modules/indexeddb/server/MemoryIndexCursor.cpp:

(WebCore::IDBServer::MemoryIndexCursor::currentData):

  • Modules/indexeddb/server/MemoryObjectStore.cpp:

(WebCore::IDBServer::MemoryObjectStore::updateIndexesForPutRecord):
(WebCore::IDBServer::MemoryObjectStore::populateIndexWithExistingRecords):
(WebCore::IDBServer::MemoryObjectStore::getAllRecords const):

  • Modules/indexeddb/server/MemoryObjectStoreCursor.cpp:

(WebCore::IDBServer::MemoryObjectStoreCursor::currentData):

  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::updateOneIndexForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::cachedStatementForGetAllObjectStoreRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllIndexRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetIndexRecordForOneKey):
(WebCore::IDBServer::SQLiteIDBBackingStore::openCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):

  • Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::currentData):

  • Modules/indexeddb/server/SQLiteIDBCursor.h:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd): Remove the key injection from network process.
UniqueIDBDatabase stores any value it gets from IDBClient.

  • Modules/indexeddb/shared/IDBResultData.cpp:

(WebCore::IDBResultData::getResultRef):

  • Modules/indexeddb/shared/IDBResultData.h:
  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::injectIDBKeyIntoScriptValue): If property is read-only, set would fail and injectKeyIntoResult would
return null, but we expect it to return result as long as the property value is the same as target. Therefore,
we can add an early return here.

(WebCore::createKeyPathArray):
(WebCore::generateIndexKeyForValue): We used to generate IndexKey from value stored in database but now the
value gets stored does not include auto-generated key, as we remove the key injection from network process. In
this case if the IDBIndex has the same key path as the auto-generated key, IndexKey would be failed to create
for it cannot extract auto-generated key from value. Since the auto-generated key would always be the key in
database record, we could use value of that key when we find a match in key path.

(WebCore::deserializeIDBValueWithKeyInjection): If the key path in the result is single entry, the key is
probably auto-generated, so we could inject the result key into the result value unconditionally.

  • bindings/js/IDBBindingUtilities.h:
  • bindings/js/JSIDBCursorWithValueCustom.cpp:

(WebCore::JSIDBCursorWithValue::value const):

  • bindings/js/JSIDBRequestCustom.cpp:

(WebCore::JSIDBRequest::result const):

LayoutTests:

  • storage/indexeddb/modern/objectstore-autoincrement-types-expected.txt: Added.
  • storage/indexeddb/modern/objectstore-autoincrement-types.html: Added.
  • storage/indexeddb/modern/resources/objectstore-autoincrement-types.js: Added.

(prepareDatabase.event.target.onsuccess):
(prepareDatabase):
(compare):
(runGetTest):
(runGetAllTest):
(get store):
(testSteps):

2:20 PM Changeset in webkit [244435] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r244155): pressing down expands folders in trees
https://bugs.webkit.org/show_bug.cgi?id=197051
<rdar://problem/50006414>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype.selectionControllerPreviousSelectableItem):
(WI.TreeOutline.prototype.selectionControllerNextSelectableItem):
Skip hidden items when traversing the tree.

  • UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline.prototype.ondelete):
Reveal all items about to be deleted so that the above change won't skip any siblings.

2:12 PM Changeset in webkit [244434] by Alan Bujtas
  • 18 edits in trunk

Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
https://bugs.webkit.org/show_bug.cgi?id=196948
<rdar://problem/49927131>

Reviewed by Tim Horton.

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::autoSizeIfEnabled):

  • page/FrameView.h:

Source/WebKit:

Move intrinsicContentSizeDidChange out of DrawingArea. Intrinsic content size is a layout concept and
after r244291 there's no reason to have it in DrawingArea.

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::didUpdateGeometry):
(WebKit::DrawingAreaProxy::intrinsicContentSizeDidChange): Deleted.

  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeIntrinsicContentSize):
(WebKit::WebPageProxy::setViewLayoutSize):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::intrinsicContentSizeDidChange): Deleted.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::intrinsicContentSizeDidChange): Deleted.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updateIntrinsicContentSizeIfNeeded):
(WebKit::WebPage::dispatchDidReachLayoutMilestone):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::updateIntrinsicContentSizeIfNeeded): Deleted.

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:

(TEST):
The expected order of incoming events is

  1. didInvalidateIntrinsicContentSize
  2. didFirstLayout

At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
(and remember, all we care about is ordering).

1:44 PM Changeset in webkit [244433] by sbarati@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove useConcurrentBarriers option
https://bugs.webkit.org/show_bug.cgi?id=197066

Reviewed by Michael Saboff.

This isn't a helpful option as it will lead us to crash when using the
concurrent GC.

  • dfg/DFGStoreBarrierClusteringPhase.cpp:
  • dfg/DFGStoreBarrierInsertionPhase.cpp:
  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::barrierStoreLoadFence):

  • runtime/Options.h:
1:26 PM Changeset in webkit [244432] by krollin@apple.com
  • 2 edits in trunk/Source/WebKitLegacy

Move MiG .def files into their own "Copy files" build step
https://bugs.webkit.org/show_bug.cgi?id=196982

Reviewed by Alex Christensen.

WebKitLegacy's MiG files need to be processed differently from the
other files in the "Copy Headers" build phase, so move them into their
own "Copy Files" build phase. This arrangement removes them from any
post-processing performed on the main group of headers.

  • WebKitLegacy.xcodeproj/project.pbxproj:
12:16 PM Changeset in webkit [244431] by Ryan Haddad
  • 6 edits in trunk

Unreviewed, rolling out r244299.

Breaks internal tests.

Reverted changeset:

"InjectedBundle parameters often need initialization function
called before unarchiving"
https://bugs.webkit.org/show_bug.cgi?id=189709
https://trac.webkit.org/changeset/244299

11:12 AM Changeset in webkit [244430] by timothy@apple.com
  • 4 edits
    2 deletes in trunk/LayoutTests

Unreviewed test gardening.

  • css-dark-mode/older-systems/color-scheme-css-expected.txt: Rebaselined.
  • css-dark-mode/older-systems/color-scheme-meta-expected.txt: Rebaselined.
  • fast/css/style-enumerate-properties.html: Updated count to work on Windows.
  • platform/mac-highsierra/css-dark-mode/prefers-color-scheme-picture-element-expected.txt: Removed.
  • platform/mac-sierra/css-dark-mode/prefers-color-scheme-picture-element-expected.txt: Removed.
10:48 AM Changeset in webkit [244429] by ysuzuki@apple.com
  • 6 edits
    1 add in trunk

[WTF] StringBuilder should set correct m_is8Bit flag when merging
https://bugs.webkit.org/show_bug.cgi?id=197053

Reviewed by Saam Barati.

JSTests:

  • stress/merge-string-builder-in-dfg.js: Added.

(foo):

Source/WTF:

When appending StringBuilder to the other StringBuilder, we have a path that does not set m_is8Bit flag correctly.
This patch correctly sets this flag. And we also change 0 to nullptr when we are using 0 as a pointer.

  • wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::appendUninitializedSlow):
(WTF::StringBuilder::append):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::append):
(WTF::StringBuilder::characters8 const):
(WTF::StringBuilder::characters16 const):
(WTF::StringBuilder::clear):

Tools:

  • TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

(TestWebKitAPI::TEST):

9:44 AM Changeset in webkit [244428] by Shawn Roberts
  • 17 edits
    8 deletes in trunk

Unreviewed manual rollout of r244248 and r244409
Causing assertion failures on Mac WK2 Debug builds
https://bugs.webkit.org/show_bug.cgi?id=195623
Source/WebCore:

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::prefetchIfNeeded):

  • loader/ResourceLoadInfo.cpp:

(WebCore::toResourceType):

  • loader/ResourceLoadInfo.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequestInternal):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

Source/WebKit:

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::lowMemoryHandler):

  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::prefetchCache): Deleted.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didReceiveBuffer):
(WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):
(WebKit::NetworkResourceLoader::isCrossOriginPrefetch const): Deleted.

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/cache/PrefetchCache.cpp: Removed.
  • NetworkProcess/cache/PrefetchCache.h: Removed.
  • Shared/WebPreferences.yaml:
  • Sources.txt:
  • WebKit.xcodeproj/project.pbxproj:

LayoutTests:

  • http/tests/cache/link-prefetch-main-resource-expected.txt: Removed.
  • http/tests/cache/link-prefetch-main-resource-iframe-expected.txt: Removed.
  • http/tests/cache/link-prefetch-main-resource-iframe.html: Removed.
  • http/tests/cache/link-prefetch-main-resource.html: Removed.
  • http/tests/cache/resources/prefetched-main-resource-iframe.php: Removed.
  • http/tests/cache/resources/prefetched-main-resource.php: Removed.
  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
9:34 AM Changeset in webkit [244427] by Devin Rousso
  • 4 edits in trunk/Source

Web Inspector: Canvas: enable WebGL2 for inspector page
https://bugs.webkit.org/show_bug.cgi?id=196932
<rdar://problem/49916213>

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction._prototypeForType):
(WI.RecordingAction.prototype.process.getContent):
Add additional checks for ImageBitmapRenderingContext and WebGLRenderingContext.

Source/WebKit:

  • WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::WebInspectorUI):

9:31 AM Changeset in webkit [244426] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Tile update problems in iframe after scrolling page too soon after load
https://bugs.webkit.org/show_bug.cgi?id=197057
<rdar://problem/49913663>

Reviewed by Simon Fraser.

We end up destroying FrameHosting scrolling node when we shouldn't.

No test, despite attempts I couldn't get this state to stick. The problem is that in
most cases the destroying scrolling node gets immediately recreated and connected again.
Getting into testably buggy state requires some very specific layer tree configuration update.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):

Test the right thing.

9:24 AM Changeset in webkit [244425] by Ryan Haddad
  • 4 edits in branches/safari-607-branch/Tools

Cherry-pick r240301. rdar://problem/49984116

[iOS] Multiple WKWebViewAutofillTests are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=189165
<rdar://problem/47433765>

Reviewed by Tim Horton.

These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
process in sufficient to ensure that any previous action that blurred the focused element in the web process
would make its way to the UI process by the time the layer tree commit is finished.

However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
will fail because it asks for -_autofillContext too early.

To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
is handled in the UI process.

  • TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:

Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
input session.

(-[AutofillTestView textInputHasAutofillContext]):

Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.

  • TestWebKitAPI/cocoa/TestWKWebView.h:
  • TestWebKitAPI/cocoa/TestWKWebView.mm: (nextInputSessionChangeCount):

Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
This includes changing the focused element from one to another.

(-[TestWKWebView initWithFrame:configuration:addToWindow:]):
(-[TestWKWebView didStartFormControlInteraction]):
(-[TestWKWebView didEndFormControlInteraction]):
(-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):

Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
(2) changing focus between elements that require input sessions, and (3) changing focus from an input session
that doesn't require an input session to one that doesn't.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@240301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:51 AM Changeset in webkit [244424] by graouts@webkit.org
  • 2 edits in trunk/LayoutTests

[Mac] Unreviewed test gardening.

The test imported/w3c/web-platform-tests/pointerevents/pointerevent_mouse_pointercapture_in_frame.html is flaky on bots.

  • platform/mac/TestExpectations:
6:31 AM Changeset in webkit [244423] by graouts@webkit.org
  • 9 edits
    1 add in trunk

[Pointer Events WPT] Unskip imported/w3c/web-platform-tests/pointerevents/pointerevent_lostpointercapture_for_disconnected_node.html
https://bugs.webkit.org/show_bug.cgi?id=197004

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/pointerevents/pointerevent_lostpointercapture_for_disconnected_node-expected.txt: Added.

Source/WebCore:

We need to release pointer capture when an element that has pointer capture is disconnected from the DOM.

  • dom/Element.cpp:

(WebCore::Element::removedFromAncestor): Notify the PointerCaptureController that an element was disconnected.

  • dom/PointerEvent.cpp:

(WebCore::PointerEvent::create): Broaden createPointerCancelEvent() to take in an event type so that we may use it to create a
lostpointercapture event as well.
(WebCore::PointerEvent::createPointerCancelEvent): Deleted.

  • dom/PointerEvent.h:
  • page/PointerCaptureController.cpp:

(WebCore::PointerCaptureController::elementWasRemoved): Check whether the provided element matches one of the target overrides recorded
in the map of captured pointer IDs.
(WebCore::PointerCaptureController::pointerEventWasDispatched): This block of code was actually useless in this location, the new code
added in elementWasRemoved() performs the actions that the spec text mandates.
(WebCore::PointerCaptureController::cancelPointer): Replace the call to createPointerCancelEvent() with one to create().

  • page/PointerCaptureController.h:

LayoutTests:

  • platform/mac/TestExpectations:
12:30 AM Changeset in webkit [244422] by ysuzuki@apple.com
  • 2 edits in trunk/Source/bmalloc

Unreviewed, fix build failure
https://bugs.webkit.org/show_bug.cgi?id=195938

Including <array>.

  • bmalloc/AvailableMemory.cpp:

Apr 17, 2019:

11:41 PM Changeset in webkit [244421] by graouts@webkit.org
  • 9 edits
    1 add in trunk

[Pointer Events WPT] Unskip imported/w3c/web-platform-tests/pointerevents/pointerevent_on_event_handlers.html
https://bugs.webkit.org/show_bug.cgi?id=197006

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/pointerevents/pointerevent_on_event_handlers-expected.txt: Added.

Source/WebCore:

Add support for on* HTML attributes and JS properties for pointer events.

  • dom/GlobalEventHandlers.idl:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::createEventHandlerNameMap):

LayoutTests:

  • js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/mac-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/mac/TestExpectations:
11:39 PM Changeset in webkit [244420] by Fujii Hironori
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening for WinCairo port

Following tests expected to fail but passed constantly.

  • css3/masking/clip-path-inset-corners.html
  • fast/box-shadow/box-shadow-with-zero-radius.html
  • storage/indexeddb/database-odd-names.html
  • storage/indexeddb/lazy-index-population.html
  • platform/wincairo/TestExpectations: Unmarked them.
10:01 PM Changeset in webkit [244419] by mitz@apple.com
  • 9 copies
    1 add in releases/Apple/Safari Technology Preview 80

Added a tag for Safari Technology Preview release 80.

8:43 PM Changeset in webkit [244418] by Devin Rousso
  • 5 edits in trunk/Source/WebKit

Web Inspector: InspectorFrontendHost::inspectionLevel returns wrong value for inspector3
https://bugs.webkit.org/show_bug.cgi?id=197044

Reviewed by Joseph Pecoraro.

  • UIProcess/WebInspectorUtilities.h:
  • UIProcess/WebInspectorUtilities.cpp:

(WebKit::trackInspectorPage):
(WebKit::untrackInspectorPage):
Determine the level of the inspector page by looking to see if the page being inspected is
in the inspector page map. If so, we must be inspecting an inspector page and should use
that inspector page's inspection level as the value to increment.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createFrontendPage):

  • UIProcess/RemoteWebInspectorProxy.cpp:

(WebKit::RemoteWebInspectorProxy::createFrontendPageAndWindow):

6:16 PM Changeset in webkit [244417] by kocsen_chung@apple.com
  • 28 edits in tags/Safari-608.1.17

Revert r244228. rdar://problem/49999041

6:06 PM Changeset in webkit [244416] by kocsen_chung@apple.com
  • 1 copy in tags/Safari-608.1.17

Tag Safari-608.1.17.

6:02 PM Changeset in webkit [244415] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

[iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
https://bugs.webkit.org/show_bug.cgi?id=197028
<rdar://problem/49985290>

Reviewed by Wenson Hsieh.

  • TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:

(TEST):
Liberal application of waitForNextPresentationUpdate works around a race
where if the page rapidly changes its viewport arguments (or an API client
rapidly changes its viewport arguments), we'd get stuck thinking that the
user had intentionally zoomed the page, and stop resetting the initial scale.
This deserves a separate bug, but no need to keep the test failing while
we think about it.

5:42 PM Changeset in webkit [244414] by timothy_horton@apple.com
  • 5 edits in trunk/Source

Adopt different scroll view flashing SPI
https://bugs.webkit.org/show_bug.cgi?id=197043
<rdar://problem/49996476>

Reviewed by Wenson Hsieh.

Source/WebKit:

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/ios/WKKeyboardScrollingAnimator.mm:

(-[WKKeyboardScrollViewAnimator scrollToContentOffset:animated:]):

Source/WTF:

  • wtf/Platform.h:
4:55 PM Changeset in webkit [244413] by timothy@apple.com
  • 7 edits in trunk

Standardize the <meta name="color-scheme"> separator.
https://bugs.webkit.org/show_bug.cgi?id=193931

Reviewed by Simon Fraser.

Source/WebCore:

Drop support for comma as a valid seperator in <meta name="color-scheme"> to
match the proposal being tracked by: https://github.com/whatwg/html/issues/4504

Tests: css-dark-mode/color-scheme-meta.html

css-dark-mode/older-syntax/supported-color-schemes-meta.html

  • dom/Document.cpp:

(WebCore::isColorSchemeSeparator): Drop support for comma.

LayoutTests:

  • css-dark-mode/color-scheme-meta-expected.txt:
  • css-dark-mode/color-scheme-meta.html:
  • css-dark-mode/older-syntax/supported-color-scheme-meta-expected.txt:
  • css-dark-mode/older-syntax/supported-color-schemes-meta.html:
4:47 PM Changeset in webkit [244412] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Navigating to resource sometimes shows different resource
https://bugs.webkit.org/show_bug.cgi?id=195978
<rdar://problem/49043191>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/NavigationSidebarPanel.js:

(WI.NavigationSidebarPanel.prototype.cancelRestoringState):
Reset _pendingViewStateCookie so _checkElementsForPendingViewStateCookie could exit early.

  • UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel.prototype.initialLayout):
(WI.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
(WI.ResourceSidebarPanel.prototype._createMainFrameTreeElement):
Don't try to change content view on initialLayout.

4:37 PM Changeset in webkit [244411] by Joseph Pecoraro
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: CPU Usage Timeline - Include # of Network Requests in the Statistics section
https://bugs.webkit.org/show_bug.cgi?id=197039
<rdar://problem/49996299>

Reviewed by Timothy Hatcher.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/CPUTimelineView.js:

(WI.CPUTimelineView.prototype.initialLayout):
(WI.CPUTimelineView.prototype._computeStatisticsData):
(WI.CPUTimelineView.prototype._clearStatistics):
Add the number of network requests started in the selected range.

4:33 PM Changeset in webkit [244410] by timothy_horton@apple.com
  • 6 edits
    1 add in trunk

REGRESSION (r241988): Switching tabs is slow
https://bugs.webkit.org/show_bug.cgi?id=197037
<rdar://problem/49951473>

Reviewed by Simon Fraser.

Source/WebKit:

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForDidUpdateActivityState):
r241988 changed to wait for a WebPageProxy message to a given DrawingArea ID,
but WebPageProxy messages are identified by their WebPageProxy ID.
Revert that one change. The rest of the patch looks OK.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.

(TEST):

  • TestWebKitAPI/cocoa/TestWKWebView.h:
  • TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView addToTestWindow]):
Add a test that hangs without this fix.

4:29 PM Changeset in webkit [244409] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Link prefetch not useful for top-level navigation
https://bugs.webkit.org/show_bug.cgi?id=195623

Patch by Rob Buis <rbuis@igalia.com> on 2019-04-17
Reviewed by Alex Christensen.

Fix macOS and iOS Debug WK2 bots ASSERTS after r367404, by simply
not sending the DidReceiveResponse message.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):

4:15 PM Changeset in webkit [244408] by timothy@apple.com
  • 24 edits
    4 copies
    12 moves
    4 adds
    3 deletes in trunk

Rename supported-color-schemes to color-scheme.
https://bugs.webkit.org/show_bug.cgi?id=197016
rdar://problem/49980259

Reviewed by Simon Fraser.

Source/WebCore:

Changed supported-color-schemes to color-scheme to follow the spec changes
being tracked by: https://github.com/w3c/csswg-drafts/issues/3807

The old supported-color-schemes is now an alias of color-scheme for compatibility.

Tests: css-dark-mode/color-scheme-css-parse.html

css-dark-mode/color-scheme-css.html
css-dark-mode/color-scheme-meta.html
css-dark-mode/color-scheme-priority.html
css-dark-mode/color-scheme-scrollbar.html
css-dark-mode/older-syntax/supported-color-schemes-css.html
css-dark-mode/older-syntax/supported-color-schemes-meta.html
css-dark-mode/older-systems/color-scheme-css.html
css-dark-mode/older-systems/color-scheme-meta.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):

  • css/CSSProperties.json:
  • css/CSSValueKeywords.in:
  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::updateColorScheme):
(WebCore::StyleBuilderConverter::convertColorScheme):
(WebCore::StyleBuilderConverter::updateSupportedColorSchemes): Deleted.
(WebCore::StyleBuilderConverter::convertSupportedColorSchemes): Deleted.

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueColorScheme):
(WebCore::StyleBuilderCustom::applyValueSupportedColorSchemes): Deleted.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyMatchedProperties):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeColorScheme):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::consumeSupportedColorSchemes): Deleted.

  • dom/Document.cpp:

(WebCore::processColorSchemeString):
(WebCore::Document::processColorScheme):
(WebCore::Document::useDarkAppearance const):
(WebCore::processColorSchemes): Deleted.
(WebCore::Document::processSupportedColorSchemes): Deleted.

  • dom/Document.h:
  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):

  • page/FrameView.cpp:

(WebCore::FrameView::rendererForColorScheme const):
(WebCore::FrameView::useDarkAppearance const):
(WebCore::FrameView::styleColorOptions const):
(WebCore::FrameView::rendererForSupportedColorSchemes const): Deleted.

  • page/FrameView.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::rareInheritedDataChangeRequiresRepaint):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::colorScheme const):
(WebCore::RenderStyle::setHasExplicitlySetColorScheme):
(WebCore::RenderStyle::hasExplicitlySetColorScheme const):
(WebCore::RenderStyle::setColorScheme):
(WebCore::RenderStyle::initialColorScheme):
(WebCore::RenderStyle::NonInheritedFlags::operator== const):
(WebCore::RenderStyle::supportedColorSchemes const): Deleted.
(WebCore::RenderStyle::setHasExplicitlySetSupportedColorSchemes): Deleted.
(WebCore::RenderStyle::hasExplicitlySetSupportedColorSchemes const): Deleted.
(WebCore::RenderStyle::setSupportedColorSchemes): Deleted.
(WebCore::RenderStyle::initialSupportedColorSchemes): Deleted.

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleColorScheme.h: Renamed from Source/WebCore/rendering/style/StyleSupportedColorSchemes.h.

(WebCore::StyleColorScheme::StyleColorScheme):
(WebCore::StyleColorScheme::operator== const):
(WebCore::StyleColorScheme::operator!= const):
(WebCore::StyleColorScheme::isAuto const):
(WebCore::StyleColorScheme::isOnly const):
(WebCore::StyleColorScheme::colorScheme const):
(WebCore::StyleColorScheme::add):
(WebCore::StyleColorScheme::contains const):
(WebCore::StyleColorScheme::setAllowsTransformations):
(WebCore::StyleColorScheme::allowsTransformations const):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):

  • rendering/style/StyleRareInheritedData.h:

Source/WebInspectorUI:

  • UserInterface/Views/Main.css:

(:root):

LayoutTests:

  • css-dark-mode/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt.
  • css-dark-mode/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css.html.
  • css-dark-mode/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt.
  • css-dark-mode/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes.html.
  • css-dark-mode/color-scheme-parse-expected.txt: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes-expected.txt.
  • css-dark-mode/color-scheme-parse.html: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes.html.
  • css-dark-mode/color-scheme-priority-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority-expected.txt.
  • css-dark-mode/color-scheme-priority.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority.html.
  • css-dark-mode/color-scheme-scrollbar-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar-expected.txt.
  • css-dark-mode/color-scheme-scrollbar.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar.html.
  • css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt.
  • css-dark-mode/older-syntax/supported-color-schemes-css.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css.html.
  • css-dark-mode/older-syntax/supported-color-schemes-meta-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt.
  • css-dark-mode/older-syntax/supported-color-schemes-meta.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes.html.
  • css-dark-mode/older-systems/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css-expected.txt
  • css-dark-mode/older-systems/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css.html.
  • css-dark-mode/older-systems/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-expected.txt.
  • css-dark-mode/older-systems/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes.html.
  • fast/css/style-enumerate-properties.html: Updated property count.
4:06 PM Changeset in webkit [244407] by Truitt Savell
  • 7 edits
    1 delete in trunk

Unreviewed, rolling out r244400.

Caused testing to exit early with assertionon Debug WK2

Reverted changeset:

"UI↔Web deadlock when printing with a JavaScript alert
visible"
https://bugs.webkit.org/show_bug.cgi?id=196839
https://trac.webkit.org/changeset/244400

3:51 PM Changeset in webkit [244406] by justin_fan@apple.com
  • 4 edits in trunk

[Web GPU] GPUComputePassEncoder::dispatch number of thread groups, not grid size
https://bugs.webkit.org/show_bug.cgi?id=196984

Reviewed by Myles C. Maxfield.

Source/WebCore:

Test: Updated compute-squares.html.

  • platform/graphics/gpu/cocoa/GPUComputePassEncoderMetal.mm:

(WebCore::GPUComputePassEncoder::dispatch):

LayoutTests:

  • webgpu/compute-squares.html: One thread group is enough to process the data in a single pass.
3:47 PM Changeset in webkit [244405] by beidson@apple.com
  • 9 edits
    1 add in trunk

Link clicks in PDFs shouldn't send referrer headers.
<rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980

Reviewed by Tim Horton.

Source/WebKit:

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::clickedLink):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):

Source/WebKitLegacy/ios:

  • WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):

Source/WebKitLegacy/mac:

  • WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.

(putPDFBytesCallback):
(emptyReleaseInfoCallback):
(createPDFWithLinkToURL):
(TEST):

3:41 PM Changeset in webkit [244404] by aestes@apple.com
  • 4 edits in trunk/Source

[iOS] Support multiple file selection in UIDocumentPickerViewController
https://bugs.webkit.org/show_bug.cgi?id=197014
<rdar://problem/49963514>

Reviewed by Tim Horton.

Source/WebCore:

  • platform/LocalizedStrings.h:

Exported multipleFileUploadText().

Source/WebKit:

  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _showDocumentPickerMenu]):
Allowed multiple file selection in our UIDocumentPickerViewController when
_allowMultipleFiles is YES.

(displayStringForDocumentsAtURLs):
(-[WKFileUploadPanel documentPicker:didPickDocumentsAtURLs:]):
Changed to support multiple file selection. When more than one file is selected, use
WebCore::multipleFileUploadText() as the display string.

3:10 PM Changeset in webkit [244403] by achristensen@apple.com
  • 6 edits in trunk/Source/WebKit

Make WebCompiledContentRuleListData non-default-constructible, move its nonserialized member to API::ContentRuleList
https://bugs.webkit.org/show_bug.cgi?id=197033

Reviewed by Tim Horton.

This is just cleanup that makes the code nicer without changing behavior.

  • Shared/WebCompiledContentRuleListData.cpp:

(WebKit::WebCompiledContentRuleListData::encode const):
(WebKit::WebCompiledContentRuleListData::decode):

  • Shared/WebCompiledContentRuleListData.h:

(WebKit::WebCompiledContentRuleListData::WebCompiledContentRuleListData):

  • UIProcess/API/APIContentRuleList.h:
  • UIProcess/API/APIContentRuleListStore.cpp:

(API::createExtension):

2:47 PM Changeset in webkit [244402] by wilander@apple.com
  • 16 edits
    4 copies
    4 adds in trunk

Add prioritization of ad click conversions and cleaning of sent ad click conversions
https://bugs.webkit.org/show_bug.cgi?id=196934
<rdar://problem/49917773>

Reviewed by Chris Dumez.

Source/WebCore:

Tests: http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html

http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html
http/tests/adClickAttribution/second-conversion-with-higher-priority.html
http/tests/adClickAttribution/second-conversion-with-lower-priority.html

  • loader/AdClickAttribution.cpp:

(WebCore::AdClickAttribution::hasHigherPriorityThan const):

Added to facilitate priority comparison between two attributions.

  • loader/AdClickAttribution.h:

(WebCore::AdClickAttribution::Destination::Destination):

Added a WTF::HashTableDeletedValueType constructor and changed the copy constructor to
a move constructor.

(WebCore::AdClickAttribution::isEmpty const):

Source/WebKit:

In this description, by "pair" I mean { AdClickAttribution::Source, AdClickAttribution::Destination }.

This patch adds handling of prioritization of conversions according to these rules:

  • If we have a matching unconverted attribution, convert it. This consumes the conversion.
  • If we have no previously converted attribution for this pair, just store.
  • If we have a previously converted attribution for this pair, replace it if the new one has higher priority.
  • If we had no matching unconverted attribution but do have a previously converted attribution for this

pair, re-convert the previously converted attribution to make sure the highest priority gets set.

This handling is in part done by dividing the previous m_adClickAttributionMap into
m_unconvertedAdClickAttributionMap and m_convertedAdClickAttributionMap, which now use a std::pair
as key instead of a nested HashMap.

This patch also changes AdClickAttributionManager::firePendingConversionRequests() so that it now
removes attributions which have been sent out.

Finally, AdClickAttributionManager::clear() no longer clears m_conversionBaseURLForTesting and
m_isRunningTest since doing so caused test flakiness. It is now up to the test case that sets these
members to also clear them when done.

  • NetworkProcess/AdClickAttributionManager.cpp:

(WebKit::AdClickAttributionManager::storeUnconverted):
(WebKit::AdClickAttributionManager::convert):
(WebKit::AdClickAttributionManager::firePendingConversionRequests):
(WebKit::AdClickAttributionManager::clear):
(WebKit::AdClickAttributionManager::toString const):
(WebKit::AdClickAttributionManager::setConversionURLForTesting):
(WebKit::AdClickAttributionManager::ensureDestinationMapForSource): Deleted.
(WebKit::AdClickAttributionManager::store): Deleted.

  • NetworkProcess/AdClickAttributionManager.h:

(WebKit::AdClickAttributionManager::AdClickAttributionManager):
(WebKit::AdClickAttributionManager::setConversionURLForTesting): Deleted.

  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::storeAdClickAttribution):

LayoutTests:

  • http/tests/adClickAttribution/attribution-conversion-through-cross-site-image-redirect-expected.txt:
  • http/tests/adClickAttribution/attribution-conversion-through-image-redirect-with-priority-expected.txt:
  • http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority-expected.txt:
  • http/tests/adClickAttribution/resources/getConversionData.php:
  • http/tests/adClickAttribution/resources/redirectToConversion.php:
  • http/tests/adClickAttribution/second-attribution-converted-with-higher-priority-expected.txt: Added.
  • http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html: Added.
  • http/tests/adClickAttribution/second-attribution-converted-with-lower-priority-expected.txt: Added.
  • http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html: Added.
  • http/tests/adClickAttribution/second-conversion-with-higher-priority-expected.txt: Added.
  • http/tests/adClickAttribution/second-conversion-with-higher-priority.html: Added.
  • http/tests/adClickAttribution/second-conversion-with-lower-priority-expected.txt: Added.
  • http/tests/adClickAttribution/second-conversion-with-lower-priority.html: Added.
  • http/tests/adClickAttribution/send-attribution-conversion-request-expected.txt:
  • http/tests/adClickAttribution/send-attribution-conversion-request.html:
  • http/tests/adClickAttribution/store-ad-click-attribution-expected.txt:
2:35 PM Changeset in webkit [244401] by sbarati@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Remove deprecated JSScript SPI
https://bugs.webkit.org/show_bug.cgi?id=194909
<rdar://problem/48283499>

Reviewed by Keith Miller.

  • API/JSAPIGlobalObject.mm:

(JSC::JSAPIGlobalObject::moduleLoaderFetch):

  • API/JSScript.h:
  • API/JSScript.mm:

(+[JSScript scriptWithSource:inVirtualMachine:]): Deleted.
(fillBufferWithContentsOfFile): Deleted.
(+[JSScript scriptFromASCIIFile:inVirtualMachine:withCodeSigning:andBytecodeCache:]): Deleted.
(+[JSScript scriptFromUTF8File:inVirtualMachine:withCodeSigning:andBytecodeCache:]): Deleted.
(-[JSScript setSourceURL:]): Deleted.

  • API/JSScriptInternal.h:
  • API/tests/testapi.mm:

(testFetch):
(testFetchWithTwoCycle):
(testFetchWithThreeCycle):
(testLoaderResolvesAbsoluteScriptURL):
(testImportModuleTwice):
(-[JSContextFileLoaderDelegate context:fetchModuleForIdentifier:withResolveHandler:andRejectHandler:]):

1:20 PM Changeset in webkit [244400] by timothy_horton@apple.com
  • 7 edits
    1 add in trunk

UI↔Web deadlock when printing with a JavaScript alert visible
https://bugs.webkit.org/show_bug.cgi?id=196839
<rdar://problem/49157642>

Reviewed by Andy Estes.

Source/WebKit:

  • Platform/IPC/Connection.cpp:

(IPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(IPC::Connection::sendSyncReply):
(IPC::Connection::dispatchSyncMessage):

  • Platform/IPC/Connection.h:

(IPC::Connection::hasOutstandingOutgoingSynchronousReplies const):
Keep track of whether we owe the other side of the connection any
delayed sync replies.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _webViewPrintFormatter]):
Most actions one can take with a _WKWebViewPrintFormatter involve
synchronously messaging the Web Content process with an infinite timeout.
Doing so while the Web Content process is awaiting a reply to a deferred-reply
synchronous message (like, say, an alert()) results in an app-destroying deadlock.
Instead of that, return a nil _WKWebViewPrintFormatter, indicating to the client
that we can't print right now.

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _wk_pageCountForPrintFormatter:]):
(-[WKContentView _wk_printedDocument]):
The above isn't sufficient, though, because a sync message could arrive and
be handled between creation and use of the _WKWebViewPrintFormatter.
So, we also bail with a zero page count and null CGPDFDocument immediately
before we would send a sync message to the Web Content process. Clients
handle this less gracefully (e.g. showing a zero page PDF), but it is
very rare compared to the above case.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.

(-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

1:01 PM Changeset in webkit [244399] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: imported recordings aren't processed when the navigation sidebar is collapsed
https://bugs.webkit.org/show_bug.cgi?id=196921
<rdar://problem/49910815>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype.initialLayout):

12:59 PM Changeset in webkit [244398] by Joseph Pecoraro
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Extension scripts with parse errors do not show up in Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=196996
<rdar://problem/47054804>

Reviewed by Devin Rousso.

  • UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager.prototype.scriptDidFail):
Create a LocalScript that can be linked to but ignore it
if we already have a Resource for the URL.

  • UserInterface/Protocol/DebuggerObserver.js:

(WI.DebuggerObserver.prototype.scriptFailedToParse):
Let DebuggerManager potentially create a script for this.

  • UserInterface/Models/Script.js:

(WI.Script):
Local scripts provide a null id and id is not required below.

12:54 PM Changeset in webkit [244397] by wenson_hsieh@apple.com
  • 3 edits in trunk/LayoutTests

REGRESSION (r244220): fast/forms/ios/inputmode-change-update-keyboard.html times out
https://bugs.webkit.org/show_bug.cgi?id=197027
<rdar://problem/49959227>

Reviewed by Megan Gardner.

Recently, r244220 added a mechanism to disconnect or connect the hardware keyboard from layout tests; adopt this
to fix several tests that require the software keyboard to be present.

  • fast/events/autoscroll-when-input-is-offscreen.html:
  • fast/forms/ios/inputmode-change-update-keyboard.html:
12:50 PM Changeset in webkit [244396] by jer.noble@apple.com
  • 2 edits in trunk

Automatically use ccache when available for Makefile builds
https://bugs.webkit.org/show_bug.cgi?id=197020

Reviewed by Alex Christensen.

  • Makefile.shared:
12:46 PM Changeset in webkit [244395] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKitLegacy

Unreviewed, rolling out r244386.
https://bugs.webkit.org/show_bug.cgi?id=197031

Causing build failures on several internal builders (Requested
by ShawnRoberts on #webkit).

Reverted changeset:

"Move MiG .def files into their own "Copy files" build step"
https://bugs.webkit.org/show_bug.cgi?id=196982
https://trac.webkit.org/changeset/244386

12:28 PM Changeset in webkit [244394] by Devin Rousso
  • 2 edits in trunk/Source/WebCore

AX: AccessibilityObject::parentObject() doesn't need to be pure virtual
https://bugs.webkit.org/show_bug.cgi?id=197026
<rdar://problem/49448209>

Reviewed by Timothy Hatcher.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::parentObject const):

12:13 PM Changeset in webkit [244393] by graouts@webkit.org
  • 8 edits
    127 adds
    9 deletes in trunk/LayoutTests

[Pointer Events WPT] Update WPT tests and provide macOS testdriver
https://bugs.webkit.org/show_bug.cgi?id=197011
<rdar://problem/49976553>

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

We update the WPT tests from the latest state of the WPT GitHub repository and provide a testdriver to dispatch mouse events on macOS.

  • web-platform-tests/payment-request/payment-request-canmakepayment-method.https-expected.txt: Update expectations now that an (incomplete)

test driver is available.

  • web-platform-tests/pointerevents/META.yml:
  • web-platform-tests/pointerevents/compat/pointerevent_touch-action_two-finger_interaction-manual.html: Added.
  • web-platform-tests/pointerevents/extension/idlharness.window-expected.txt: Removed.
  • web-platform-tests/pointerevents/extension/idlharness.window.html: Removed.
  • web-platform-tests/pointerevents/extension/pointerevent_coalesced_events_attributes-manual.html: Added.
  • web-platform-tests/pointerevents/extension/pointerevent_constructor.html:
  • web-platform-tests/pointerevents/extension/pointerevent_getCoalescedEvents_when_pointerlocked-manual.html: Added.
  • web-platform-tests/pointerevents/extension/pointerevent_getPredictedEvents_when_pointerlocked-manual.html: Added.
  • web-platform-tests/pointerevents/extension/pointerevent_pointerrawmove-manual.html: Added.
  • web-platform-tests/pointerevents/extension/pointerevent_pointerrawmove_in_pointerlock-manual.html: Added.
  • web-platform-tests/pointerevents/extension/pointerevent_predicted_events_attributes-manual.html: Added.
  • web-platform-tests/pointerevents/extension/pointerevent_touch-action-pan-down-css_touch-manual.html: Added.
  • web-platform-tests/pointerevents/extension/pointerevent_touch-action-pan-left-css_touch-manual.html: Added.
  • web-platform-tests/pointerevents/extension/pointerevent_touch-action-pan-right-css_touch-manual.html: Added.
  • web-platform-tests/pointerevents/extension/pointerevent_touch-action-pan-up-css_touch-manual.html: Added.
  • web-platform-tests/pointerevents/extension/w3c-import.log: Removed.
  • web-platform-tests/pointerevents/html/pointerevent_drag_interaction-manual.html: Added.
  • web-platform-tests/pointerevents/idlharness.window-expected.txt: Removed.
  • web-platform-tests/pointerevents/idlharness.window.html: Removed.
  • web-platform-tests/pointerevents/pointerevent_attributes_hoverable_pointers-manual-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_attributes_hoverable_pointers-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_attributes_nohover_pointers-manual-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_attributes_nohover_pointers-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_boundary_events_at_implicit_release_hoverable_pointers-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_boundary_events_at_implicit_release_hoverable_pointers.html: Added.
  • web-platform-tests/pointerevents/pointerevent_boundary_events_in_capturing-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_capture_mouse-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_capture_mouse.html: Added.
  • web-platform-tests/pointerevents/pointerevent_capture_suppressing_mouse-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_change-touch-action-onpointerdown_touch.html: Added.
  • web-platform-tests/pointerevents/pointerevent_click_during_capture-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_click_during_capture.html: Added.
  • web-platform-tests/pointerevents/pointerevent_disabled_form_control-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_element_haspointercapture-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_element_haspointercapture_release_pending_capture-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_fractional_coordinates-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_lostpointercapture_for_disconnected_node.html: Added.
  • web-platform-tests/pointerevents/pointerevent_lostpointercapture_is_first.html: Added.
  • web-platform-tests/pointerevents/pointerevent_mouse_capture_change_hover-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_mouse_capture_change_hover.html: Added.
  • web-platform-tests/pointerevents/pointerevent_mouse_pointercapture_in_frame-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_mouse_pointercapture_in_frame.html: Added.
  • web-platform-tests/pointerevents/pointerevent_mouse_pointercapture_inactivate_pointer-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_mouse_pointercapture_inactivate_pointer.html: Added.
  • web-platform-tests/pointerevents/pointerevent_multiple_primary_pointers_boundary_events-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_on_event_handlers-expected.txt: Removed.
  • web-platform-tests/pointerevents/pointerevent_pointerId_scope-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_pointercancel_touch.html: Added.
  • web-platform-tests/pointerevents/pointerevent_pointerenter_does_not_bubble-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_pointerenter_does_not_bubble.html: Added.
  • web-platform-tests/pointerevents/pointerevent_pointerleave_after_pointercancel_touch.html: Added.
  • web-platform-tests/pointerevents/pointerevent_pointerleave_descendant_over-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_pointerleave_descendant_over.html: Added.
  • web-platform-tests/pointerevents/pointerevent_pointerleave_descendants-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_pointerleave_descendants.html: Added.
  • web-platform-tests/pointerevents/pointerevent_pointerleave_does_not_bubble-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_pointerleave_does_not_bubble.html: Added.
  • web-platform-tests/pointerevents/pointerevent_pointerleave_pen-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_pointermove-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_pointermove.html: Added.
  • web-platform-tests/pointerevents/pointerevent_pointermove_isprimary_same_as_pointerdown-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_pointermove_isprimary_same_as_pointerdown.html: Added.
  • web-platform-tests/pointerevents/pointerevent_pointermove_on_chorded_mouse_button-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_pointermove_on_chorded_mouse_button.html: Added.
  • web-platform-tests/pointerevents/pointerevent_pointerout_after_pointercancel_touch.html: Added.
  • web-platform-tests/pointerevents/pointerevent_pointerout_pen.html: Added.
  • web-platform-tests/pointerevents/pointerevent_pointerout_received_once-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_pointerout_received_once.html: Added.
  • web-platform-tests/pointerevents/pointerevent_releasepointercapture_events_to_original_target-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_releasepointercapture_invalid_pointerid-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_releasepointercapture_invalid_pointerid.html: Added.
  • web-platform-tests/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch.html: Added.
  • web-platform-tests/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse.html: Added.
  • web-platform-tests/pointerevents/pointerevent_releasepointercapture_release_right_after_capture-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_root_computed_style-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_root_computed_style.html: Added.
  • web-platform-tests/pointerevents/pointerevent_root_hit_test-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_root_hit_test.html: Added.
  • web-platform-tests/pointerevents/pointerevent_sequence_at_implicit_release_on_click-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_sequence_at_implicit_release_on_drag-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_setpointercapture_disconnected-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_setpointercapture_disconnected.html: Added.
  • web-platform-tests/pointerevents/pointerevent_setpointercapture_inactive_button_mouse-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_setpointercapture_inactive_button_mouse.html: Added.
  • web-platform-tests/pointerevents/pointerevent_setpointercapture_invalid_pointerid-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_setpointercapture_invalid_pointerid.html: Added.
  • web-platform-tests/pointerevents/pointerevent_setpointercapture_override_pending_capture_element-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_setpointercapture_relatedtarget-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_setpointercapture_relatedtarget.html: Added.
  • web-platform-tests/pointerevents/pointerevent_setpointercapture_to_same_element_twice-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_support.js:
  • web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_click-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_click.html: Added.
  • web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt: Added.
  • web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-auto-css_touch.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-button-test_touch-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-keyboard-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-mouse-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-none-css_touch-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-rotated-divs_touch-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-span-test_touch-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html: Added.
  • web-platform-tests/pointerevents/pointerevent_touch-action-table-test_touch-manual.html: Added.
  • web-platform-tests/pointerevents/pointerlock/pointerevent_coordinates_when_locked.html: Added.
  • web-platform-tests/pointerevents/pointerlock/pointerevent_movementxy-manual.html: Added.
  • web-platform-tests/pointerevents/pointerlock/pointerevent_movementxy_when_locked-manual.html: Added.
  • web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_after_pointercapture-manual.html: Added.
  • web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture-manual.html: Added.
  • web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_in_pointerlock-manual.html: Added.
  • web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-manual.html: Added.
  • web-platform-tests/pointerevents/pointerlock/resources/pointerevent_pointermove_in_pointerlock-iframe.html: Added.
  • web-platform-tests/pointerevents/pointerlock/resources/w3c-import.log: Removed.
  • web-platform-tests/pointerevents/resources/pointerevent_mouse_pointercapture-iframe.html: Added.
  • web-platform-tests/pointerevents/resources/pointerevent_mouse_pointercapture_inactivate_pointer-iframe.html: Added.
  • web-platform-tests/pointerevents/resources/pointerevent_pointerrawmove_in_pointerlock-iframe.html: Added.
  • web-platform-tests/pointerevents/resources/w3c-import.log: Removed.
  • web-platform-tests/pointerevents/w3c-import.log: Removed.
  • web-platform-tests/resources/testdriver-actions.js: Added.
  • web-platform-tests/resources/testdriver-vendor.js: Added.

(logDebug):
(dispatchMouseActions):
(window.test_driver_internal.action_sequence):

  • web-platform-tests/resources/testdriver.js: Added.

LayoutTests:

  • platform/mac-wk1/imported/w3c/web-platform-tests/pointerevents/pointerevent_boundary_events_at_implicit_release_hoverable_pointers-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/pointerevents/pointerevent_mouse_capture_change_hover-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/pointerevents/pointerevent_mouse_pointercapture_in_frame-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/pointerevents/pointerevent_setpointercapture_relatedtarget-expected.txt: Added.
  • platform/mac/TestExpectations:
11:57 AM Changeset in webkit [244392] by Alan Bujtas
  • 6 edits
    2 adds in trunk

[ContentChangeObserver] Use aria role as a hint whether a tap should result in a synthetic click
https://bugs.webkit.org/show_bug.cgi?id=196988
<rdar://problem/49955328>

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/events/touch/ios/content-observation/tap-on-input-looking-div-with-role.html

  • accessibility/AccessibilityObject.h:

Source/WebKit:

Tapping on elements with cretain aria role attributes should trigger synthetic click the same way it does on form control elements.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::isAriaRoleForImmediateClick):
(WebKit::nodeAlwaysRequiresClick):
(WebKit::WebPage::handleSyntheticClick):

LayoutTests:

  • fast/events/touch/ios/content-observation/tap-on-input-looking-div-with-role-expected.txt: Added.
  • fast/events/touch/ios/content-observation/tap-on-input-looking-div-with-role.html: Added.
11:49 AM Changeset in webkit [244391] by achristensen@apple.com
  • 6 edits in trunk/Source/WebCore

WebSocketHandshake should not know about a Document
https://bugs.webkit.org/show_bug.cgi?id=196468

Reviewed by Tim Horton.

I'll need to move WebSocketHandshake to the NetworkProcess for rdar://problem/46287028
It currently uses the Document pointer for 3 things:

  1. To get the user agent, which we can pass in as a creation parameter.
  2. To get the origin, which we can also pass in as a creation parameter.
  3. To get cookies for the web inspector. We can pass in a functor instead and have the inspector provide cookies itself.
  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::clientHandshakeRequest):

  • Modules/websockets/WebSocketChannel.h:

(WebCore::WebSocketChannel::document):

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::WebSocketHandshake):
(WebCore::WebSocketHandshake::clientHandshakeMessage const):
(WebCore::WebSocketHandshake::clientHandshakeRequest const):
(WebCore::WebSocketHandshake::clientOrigin const): Deleted.
(WebCore::WebSocketHandshake::clientHandshakeCookieRequestHeaderFieldProxy const): Deleted.
(WebCore::WebSocketHandshake::clearDocument): Deleted.

  • Modules/websockets/WebSocketHandshake.h:
  • inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::enable):

11:28 AM Changeset in webkit [244390] by achristensen@apple.com
  • 107 edits in trunk

WKRetainPtr's adoption constructor should be private
https://bugs.webkit.org/show_bug.cgi?id=197019

Reviewed by Tim Horton.

Source/WebKit:

RefPtr and RetainPtr have already done this. It makes us use nicer syntax.

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetDownloadClient):

  • UIProcess/API/cpp/WKRetainPtr.h:

(WebKit::WKRetainPtr::WKRetainPtr):
(WebKit::adoptWK):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dumpFramesAsText):

  • TestWebKitAPI/InjectedBundleController.cpp:

(TestWebKitAPI::InjectedBundleController::initialize):

  • TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createContextWithInjectedBundle):
(TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
(TestWebKitAPI::Util::createContextForInjectedBundleTest):
(TestWebKitAPI::Util::toWK):

  • TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionBasic::initialize):

  • TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionNoCache::initialize):

  • TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:

(TestWebKitAPI::didRemoveFrameFromHierarchyCallback):

  • TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:

(TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):

  • TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/Find.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/FindMatches.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/Geolocation.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:

(TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):

  • TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:

(TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
(TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):

  • TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:

(TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):

  • TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:

(TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):

  • TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:

(TestWebKitAPI::loadAlternateHTMLString):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:

(TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):

  • TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:

(TestWebKitAPI::buildAndPerformTest):

  • TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/UserMedia.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):

  • TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(TEST):

  • TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:

(TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::getMenuItemTitleCallback):
(WTR::createMouseMessageBody):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::mouseForceClick):
(WTR::EventSendingController::startAndCancelMouseForceClick):
(WTR::EventSendingController::mouseForceDown):
(WTR::EventSendingController::mouseForceUp):
(WTR::EventSendingController::mouseForceChanged):
(WTR::EventSendingController::leapForward):
(WTR::EventSendingController::scheduleAsynchronousClick):
(WTR::createKeyDownMessageBody):
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::scheduleAsynchronousKeyDown):
(WTR::EventSendingController::mouseScrollBy):
(WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
(WTR::EventSendingController::continuousMouseScrollBy):
(WTR::EventSendingController::addTouchPoint):
(WTR::EventSendingController::updateTouchPoint):
(WTR::EventSendingController::setTouchModifier):
(WTR::EventSendingController::setTouchPointRadius):
(WTR::EventSendingController::touchStart):
(WTR::EventSendingController::touchMove):
(WTR::EventSendingController::touchEnd):
(WTR::EventSendingController::touchCancel):
(WTR::EventSendingController::clearTouchPoints):
(WTR::EventSendingController::releaseTouchPoint):
(WTR::EventSendingController::cancelTouchPoint):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didCreatePage):
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::didReceiveMessageToPage):
(WTR::InjectedBundle::booleanForKey):
(WTR::InjectedBundle::done):
(WTR::InjectedBundle::dumpToStdErr):
(WTR::InjectedBundle::outputText):
(WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
(WTR::InjectedBundle::postAddChromeInputField):
(WTR::InjectedBundle::postRemoveChromeInputField):
(WTR::InjectedBundle::postFocusWebView):
(WTR::InjectedBundle::postSetBackingScaleFactor):
(WTR::InjectedBundle::postSetWindowIsKey):
(WTR::InjectedBundle::postSetViewSize):
(WTR::InjectedBundle::postSimulateWebNotificationClick):
(WTR::InjectedBundle::postSetAddsVisitedLinks):
(WTR::InjectedBundle::setGeolocationPermission):
(WTR::InjectedBundle::setMockGeolocationPosition):
(WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
(WTR::InjectedBundle::isGeolocationProviderActive const):
(WTR::InjectedBundle::imageCountInGeneralPasteboard const):
(WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
(WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
(WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
(WTR::InjectedBundle::setCustomPolicyDelegate):
(WTR::InjectedBundle::setHidden):
(WTR::InjectedBundle::setCacheModel):
(WTR::InjectedBundle::shouldProcessWorkQueue const):
(WTR::InjectedBundle::processWorkQueue):
(WTR::InjectedBundle::queueBackNavigation):
(WTR::InjectedBundle::queueForwardNavigation):
(WTR::InjectedBundle::queueLoad):
(WTR::InjectedBundle::queueLoadHTMLString):
(WTR::InjectedBundle::queueReload):
(WTR::InjectedBundle::queueLoadingScript):
(WTR::InjectedBundle::queueNonLoadingScript):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::frameToStr):
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::dumpFrameDescriptionSuitableForTestResult):
(WTR::dumpFrameScrollPosition):
(WTR::dumpDescendantFrameScrollPositions):
(WTR::dumpFrameText):
(WTR::dumpDescendantFramesText):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::shouldDumpPixels const):
(WTR::TestRunner::setDumpPixels):
(WTR::TestRunner::whatToDump const):
(WTR::TestRunner::setWhatToDump):
(WTR::TestRunner::setWaitUntilDone):
(WTR::TestRunner::shouldWaitUntilDone const):
(WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
(WTR::TestRunner::shouldDumpFrameLoadCallbacks):
(WTR::TestRunner::clearAllDatabases):
(WTR::TestRunner::setIDBPerOriginQuota):
(WTR::TestRunner::originsWithApplicationCache):
(WTR::TestRunner::setCanOpenWindows):
(WTR::TestRunner::setXSSAuditorEnabled):
(WTR::TestRunner::setMediaDevicesEnabled):
(WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
(WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
(WTR::TestRunner::setCustomUserAgent):
(WTR::TestRunner::setWebAPIStatisticsEnabled):
(WTR::TestRunner::setModernMediaControlsEnabled):
(WTR::TestRunner::setWebGL2Enabled):
(WTR::TestRunner::setWritableStreamAPIEnabled):
(WTR::TestRunner::setReadableByteStreamAPIEnabled):
(WTR::TestRunner::setEncryptedMediaAPIEnabled):
(WTR::TestRunner::setAllowsAnySSLCertificate):
(WTR::TestRunner::setPluginsEnabled):
(WTR::TestRunner::setValueForUser):
(WTR::TestRunner::setAudioResult):
(WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
(WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
(WTR::TestRunner::setAlwaysAcceptCookies):
(WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
(WTR::TestRunner::isDoingMediaCapture const):
(WTR::TestRunner::queueLoad):
(WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
(WTR::TestRunner::setHandlesAuthenticationChallenges):
(WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
(WTR::TestRunner::setShouldLogDownloadCallbacks):
(WTR::TestRunner::setAuthenticationUsername):
(WTR::TestRunner::setAuthenticationPassword):
(WTR::TestRunner::secureEventInputIsEnabled const):
(WTR::TestRunner::setBlockAllPlugins):
(WTR::TestRunner::setPluginSupportedMode):
(WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
(WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
(WTR::TestRunner::setNavigationGesturesEnabled):
(WTR::TestRunner::setIgnoresViewportScaleLimits):
(WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
(WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
(WTR::TestRunner::terminateNetworkProcess):
(WTR::TestRunner::terminateServiceWorkerProcess):
(WTR::TestRunner::runUIScript):
(WTR::TestRunner::setStatisticsDebugMode):
(WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
(WTR::TestRunner::setStatisticsLastSeen):
(WTR::TestRunner::setStatisticsPrevalentResource):
(WTR::TestRunner::setStatisticsVeryPrevalentResource):
(WTR::TestRunner::dumpResourceLoadStatistics):
(WTR::TestRunner::isStatisticsPrevalentResource):
(WTR::TestRunner::isStatisticsVeryPrevalentResource):
(WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
(WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
(WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
(WTR::TestRunner::setStatisticsHasHadUserInteraction):
(WTR::TestRunner::isStatisticsHasHadUserInteraction):
(WTR::TestRunner::setStatisticsGrandfathered):
(WTR::TestRunner::isStatisticsGrandfathered):
(WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
(WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
(WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
(WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
(WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
(WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
(WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
(WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
(WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
(WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
(WTR::TestRunner::statisticsUpdateCookieBlocking):
(WTR::TestRunner::statisticsSubmitTelemetry):
(WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
(WTR::TestRunner::setStatisticsIsRunningTest):
(WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
(WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
(WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
(WTR::TestRunner::setStatisticsGrandfatheringTime):
(WTR::TestRunner::setStatisticsMaxStatisticsEntries):
(WTR::TestRunner::setStatisticsPruneEntriesDownTo):
(WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
(WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
(WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
(WTR::TestRunner::statisticsDeleteCookiesForHost):
(WTR::TestRunner::setStatisticsCacheMaxAgeCap):
(WTR::TestRunner::statisticsResetToConsistentState):
(WTR::TestRunner::setStorageAccessAPIEnabled):
(WTR::TestRunner::getAllStorageAccessEntries):
(WTR::TestRunner::addMockMediaDevice):
(WTR::TestRunner::clearMockMediaDevices):
(WTR::TestRunner::removeMockMediaDevice):
(WTR::TestRunner::resetMockMediaDevices):
(WTR::TestRunner::connectMockGamepad):
(WTR::TestRunner::disconnectMockGamepad):
(WTR::TestRunner::setMockGamepadDetails):
(WTR::TestRunner::setMockGamepadAxisValue):
(WTR::TestRunner::setMockGamepadButtonValue):
(WTR::TestRunner::removeAllSessionCredentials):
(WTR::TestRunner::clearDOMCache):
(WTR::TestRunner::clearDOMCaches):
(WTR::TestRunner::hasDOMCache):
(WTR::TestRunner::domCacheSize):
(WTR::TestRunner::setAllowStorageQuotaIncrease):
(WTR::TestRunner::getApplicationManifestThen):
(WTR::TestRunner::injectUserScript):
(WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
(WTR::TestRunner::setWebAuthenticationMockConfiguration):
(WTR::TestRunner::addTestKeyToKeychain):
(WTR::TestRunner::cleanUpKeychain):
(WTR::TestRunner::keyExistsInKeychain):
(WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
(WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
(WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
(WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
(WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
(WTR::TestRunner::setAdClickAttributionConversionURLForTesting):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
(WTR::parseStringTestHeaderValueAsRelativePath):
(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::runTest):
(WTR::TestController::didReceiveLiveDocumentsList):
(WTR::TestController::didReceiveMessageFromInjectedBundle):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestController::didFinishNavigation):
(WTR::TestController::didReceiveAuthenticationChallenge):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestInvocation::uiScriptDidComplete):
(WTR::TestInvocation::didReceiveAllStorageAccessEntries):

  • WebKitTestRunner/WebNotificationProvider.cpp:

(WTR::WebNotificationProvider::closeWebNotification):

  • WebKitTestRunner/WorkQueueManager.cpp:

(WTR::ScriptItem::ScriptItem):
(WTR::WorkQueueManager::queueLoad):
(WTR::WorkQueueManager::queueLoadHTMLString):

11:09 AM Changeset in webkit [244389] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Fix crash during teardown of PingLoad
https://bugs.webkit.org/show_bug.cgi?id=197024
<rdar://problem/49973077>

Reviewed by Jer Noble.

  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::initialize):
Early return if weakThis is null.

11:04 AM Changeset in webkit [244388] by wenson_hsieh@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION (r243926): [iOS] Release assertion when computing editor state during an overflow scroll triggered by layout
https://bugs.webkit.org/show_bug.cgi?id=197012
<rdar://problem/49908848>

Reviewed by Simon Fraser.

Source/WebKit:

We hit the release assertion due to the following sequence of events:

  • Dispatch a queued event (in this case, a scroll event)
  • Invoke the scroll event listener, which modifies layout in some way
  • This scrolls an overflow scrollable container under the scope of layout
  • Overflow scrolling then calls didChangeSelection and triggers an editor state update, which updates layout

In the case where the selection is in the main frame, we bail early due to the check for recursive layout (i.e.
frameView->layoutContext().isInRenderTreeLayout()). However, in the case where the selection is inside a
subframe, we end up skipping past this check, since the subframe's FrameView isn't currently laying out, and so
we end up hitting the release assertion underneath the early return.

To fix this, simply defer editor state updates due to overflow scrolling until the next remote layer tree commit
instead of computing and sending the information immediately. While this only defers editor state updates during
overflow scrolling, <rdar://problem/47258878> tracks making editor state updates deferred in the general case.

Test: editing/selection/overflow-scroll-while-selecting-text.html

  • WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:

(WebKit::WebEditorClient::overflowScrollPositionChanged):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didChangeOverflowScrollPosition):
(WebKit::WebPage::didChangeSelection):
(WebKit::WebPage::didChangeSelectionOrOverflowScrollPosition):

  • WebProcess/WebPage/WebPage.h:

LayoutTests:

Adds a new layout test to exercise the crash.

  • editing/selection/overflow-scroll-while-selecting-text-expected.txt: Added.
  • editing/selection/overflow-scroll-while-selecting-text.html: Added.
10:59 AM Changeset in webkit [244387] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for iOSMac after r244223.

  • platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::routeSharingPolicy const): Add ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END
around AVAudioSessionRouteSharingPolicyLongForm use.

10:58 AM Changeset in webkit [244386] by krollin@apple.com
  • 2 edits in trunk/Source/WebKitLegacy

Move MiG .def files into their own "Copy files" build step
https://bugs.webkit.org/show_bug.cgi?id=196982

Reviewed by Alex Christensen.

WebKitLegacy's MiG files need to be processed differently from the
other files in the "Copy Headers" build phase, so move them into their
own "Copy Files" build phase. This arrangement removes them from any
post-processing performed on the main group of headers.

  • WebKitLegacy.xcodeproj/project.pbxproj:
10:57 AM Changeset in webkit [244385] by krollin@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove JSCBuiltins.cpp from Copy Headers phase
https://bugs.webkit.org/show_bug.cgi?id=196981
<rdar://problem/49952133>

Reviewed by Alex Christensen.

JSCBuiltins.cpp is not a header and so doesn't need to be in the Copy
Headers phase. Checking its history, it seems to have been added
accidentally at the same time that JSCBuiltins.h was added.

10:41 AM Changeset in webkit [244384] by achristensen@apple.com
  • 2 edits in trunk/Tools

Add a comment to make my test from r244139 less mysterious.
https://bugs.webkit.org/show_bug.cgi?id=196744

As suggested by Darin Adler.

  • TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:

(-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):

10:28 AM Changeset in webkit [244383] by achristensen@apple.com
  • 2 edits in trunk/LayoutTests

[Mac iOS WK2] Layout Test http/tests/resourceLoadStatistics/ping-to-prevalent-resource.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=196974

Reviewed by Brady Eidson.

  • http/tests/resourceLoadStatistics/ping-to-prevalent-resource.html:

Make test do one thing at a time to avoid race conditions.
Clean up state on the server after test is finished to prevent corrupting future test state.

10:03 AM Changeset in webkit [244382] by Chris Dumez
  • 32 edits
    1 copy
    1 add in trunk

Remember device orientation permission for the duration of the browsing session
https://bugs.webkit.org/show_bug.cgi?id=196992
<rdar://problem/49946067>

Reviewed by Alex Christensen.

Source/WebCore:

Use DeviceOrientationOrMotionPermissionState type more consistently in the code base
instead of bool or Optional<bool>. Added "Prompt" value to this enumeration which is the
default state and which indicates we should ask the client.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/DeviceOrientationAndMotionAccessController.cpp:

(WebCore::DeviceOrientationAndMotionAccessController::DeviceOrientationAndMotionAccessController):
(WebCore::DeviceOrientationAndMotionAccessController::shouldAllowAccess):

  • dom/DeviceOrientationAndMotionAccessController.h:

(WebCore::DeviceOrientationAndMotionAccessController::accessState const):

  • dom/DeviceOrientationOrMotionEvent.cpp:

(WebCore::DeviceOrientationOrMotionEvent::requestPermission):

  • dom/DeviceOrientationOrMotionPermissionState.h:
  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::deviceOrientationAndMotionAccessState const):
(WebCore::DocumentLoader::setDeviceOrientationAndMotionAccessState):

  • page/ChromeClient.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::isAllowedToAddDeviceMotionOrientationListener const):

Source/WebKit:

Implement caching of device orientation permission decisions on the WebDeviceOrientationAndMotionAccessController,
which is owned by the WebsiteDataStore. This way, if we already prompted the user of a given origin, we will
remember the previous decision for the duration of the session and not prompt again.

  • Shared/WebsitePoliciesData.cpp:

(WebKit::WebsitePoliciesData::encode const):
(WebKit::WebsitePoliciesData::decode):

  • Shared/WebsitePoliciesData.h:
  • UIProcess/API/APIWebsitePolicies.cpp:

(API::WebsitePolicies::copy const):
(API::WebsitePolicies::data):

  • UIProcess/API/APIWebsitePolicies.h:
  • UIProcess/API/Cocoa/WKWebpagePreferences.mm:

(toDeviceOrientationOrMotionPermissionState):
(-[WKWebpagePreferences _setDeviceOrientationAndMotionAccessPolicy:]):
(toWKWebsiteDeviceOrientationAndMotionAccessPolicy):
(-[WKWebpagePreferences _deviceOrientationAndMotionAccessPolicy]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::shouldAllowDeviceOrientationAndMotionAccess):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.cpp: Added.

(WebKit::WebDeviceOrientationAndMotionAccessController::shouldAllowDeviceOrientationAndMotionAccess):
(WebKit::WebDeviceOrientationAndMotionAccessController::deviceOrientationPermission const):

  • UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.h: Copied from Source/WebCore/dom/DeviceOrientationAndMotionAccessController.h.
  • UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::deviceOrientationAndMotionAccessController):

  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::shouldAllowDeviceOrientationAndMotionAccess):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::shouldAllowDeviceOrientationAndMotionAccess):

  • WebProcess/WebPage/WebPage.h:

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:

(-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
(TEST):

9:47 AM Changeset in webkit [244381] by jer.noble@apple.com
  • 2 edits in trunk/Source/WTF

Enable HAVE_AVFOUNDATION_VIDEO_OUTPUT on PLATFORM(IOSMAC)
https://bugs.webkit.org/show_bug.cgi?id=196994
<rdar://problem/44158331>

Reviewed by Alex Christensen.

  • wtf/Platform.h:
9:22 AM Changeset in webkit [244380] by Ryan Haddad
  • 2 edits in branches/safari-607-branch/Tools

Cherry-pick r242819. rdar://problem/49979209

Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
https://bugs.webkit.org/show_bug.cgi?id=195137
<rdar://problem/48810307>

Reviewed by Eric Carlson.

  • TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: (TestWebKitAPI::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@242819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:20 AM Changeset in webkit [244379] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
https://bugs.webkit.org/show_bug.cgi?id=196675

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-app/ews/views/submittoews.py:

(SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py

9:10 AM Changeset in webkit [244378] by Alan Bujtas
  • 41 edits in trunk/LayoutTests

[iOS] Unreviewed gardening.

2 single taps in fast loading subsequent tests are recognized as double tap. Turn off double taps for content observation tests.

  • fast/events/touch/ios/content-observation/0ms-delay-0ms-transition-on-mousemove.html:
  • fast/events/touch/ios/content-observation/0ms-transition-on-touch-start.html:
  • fast/events/touch/ios/content-observation/100ms-delay-10ms-transition-on-mousemove.html:
  • fast/events/touch/ios/content-observation/100ms-transition-on-touch-start.html:
  • fast/events/touch/ios/content-observation/10ms-delay-0ms-transition-on-mousemove.html:
  • fast/events/touch/ios/content-observation/10ms-delay-0ms-transition-on-touch-start.html:
  • fast/events/touch/ios/content-observation/10ms-delay-transition-on-touch-start-with-non-0px-end.html:
  • fast/events/touch/ios/content-observation/10ms-delay-transition-on-touch-start.html:
  • fast/events/touch/ios/content-observation/350ms-hover-intent.html:
  • fast/events/touch/ios/content-observation/400ms-hover-intent.html:
  • fast/events/touch/ios/content-observation/click-instead-of-hover-simple.html:
  • fast/events/touch/ios/content-observation/clickable-content-is-inside-a-container.html:
  • fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html:
  • fast/events/touch/ios/content-observation/hover-when-style-change-is-async.html:
  • fast/events/touch/ios/content-observation/hover-while-loading-subframe.html:
  • fast/events/touch/ios/content-observation/iframe-is-shown-on-hover.html:
  • fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html:
  • fast/events/touch/ios/content-observation/move-content-from-offscreen.html:
  • fast/events/touch/ios/content-observation/new-content-covers-tap-target.html:
  • fast/events/touch/ios/content-observation/non-visible-becomes-visible-and-gains-new-renderer.html:
  • fast/events/touch/ios/content-observation/non-visible-content-gains-new-renderer.html:
  • fast/events/touch/ios/content-observation/opacity-change-happens-on-mousemove-with-opacity-and-left.html:
  • fast/events/touch/ios/content-observation/opacity-change-happens-on-mousemove-with-transition.html:
  • fast/events/touch/ios/content-observation/opacity-change-happens-on-mousemove.html:
  • fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart-with-transition.html:
  • fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart.html:
  • fast/events/touch/ios/content-observation/remove-subframe-while-observing.html:
  • fast/events/touch/ios/content-observation/stuck-with-hover-state.html:
  • fast/events/touch/ios/content-observation/style-recalc-schedule-and-force-relalc.html:
  • fast/events/touch/ios/content-observation/tap-on-input-type-button-element.html:
  • fast/events/touch/ios/content-observation/tap-on-input-type-text-element.html:
  • fast/events/touch/ios/content-observation/transition-on-touch-start-and-remove.html:
  • fast/events/touch/ios/content-observation/visibility-change-after-touch-end.html:
  • fast/events/touch/ios/content-observation/visibility-change-happens-at-the-second-timer.html:
  • fast/events/touch/ios/content-observation/visibility-change-happens-on-timer-hops.html:
  • fast/events/touch/ios/content-observation/visibility-change-happens-while-in-mousemoved.html:
  • fast/events/touch/ios/content-observation/visibility-change-is-max-height-change.html:
  • fast/events/touch/ios/content-observation/visibility-change-on-touch-start-simple.html:
  • fast/events/touch/ios/content-observation/visibility-change-with-image-content.html:
  • fast/events/touch/ios/content-observation/visible-content-gains-new-renderer.html:
5:59 AM WebKitGTK/2.24.x edited by Adrian Perez de Castro
(diff)
3:11 AM Changeset in webkit [244377] by commit-queue@webkit.org
  • 6 edits
    1 copy
    2 moves
    7 adds
    2 deletes in trunk

XMLHttpRequest has the wrong fallback encoding
https://bugs.webkit.org/show_bug.cgi?id=191741

Patch by Rob Buis <rbuis@igalia.com> on 2019-04-17
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Update improved test expectations and sync unsupported-encodings.any.js and
replacement-encodings.any.js tests.

  • web-platform-tests/encoding/replacement-encodings.any-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/encoding/replacement-encodings-expected.txt.
  • web-platform-tests/encoding/replacement-encodings.any.html: Added.
  • web-platform-tests/encoding/replacement-encodings.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/encoding/replacement-encodings.html.
  • web-platform-tests/encoding/replacement-encodings.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/encoding/replacement-encodings-expected.txt.
  • web-platform-tests/encoding/replacement-encodings.any.worker.html: Added.
  • web-platform-tests/encoding/unsupported-encodings-expected.txt: Removed.
  • web-platform-tests/encoding/unsupported-encodings.any-expected.txt: Added.
  • web-platform-tests/encoding/unsupported-encodings.any.html: Added.
  • web-platform-tests/encoding/unsupported-encodings.any.js: Added.
  • web-platform-tests/encoding/unsupported-encodings.any.worker-expected.txt: Added.
  • web-platform-tests/encoding/unsupported-encodings.any.worker.html: Added.
  • web-platform-tests/encoding/unsupported-encodings.html: Removed.
  • web-platform-tests/xhr/overridemimetype-edge-cases.window-expected.txt:
  • web-platform-tests/xhr/responsetext-decoding-expected.txt:

Source/WebCore:

Allow overriding the response charset as specified here:
https://xhr.spec.whatwg.org/#final-charset

Behavior matches Firefox and Chrome.

Tests: imported/w3c/web-platform-tests/encoding/replacement-encodings.any.html

imported/w3c/web-platform-tests/encoding/replacement-encodings.any.worker.html
imported/w3c/web-platform-tests/encoding/unsupported-encodings.any.html
imported/w3c/web-platform-tests/encoding/unsupported-encodings.any.worker.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::finalResponseCharset const):
(WebCore::XMLHttpRequest::createDecoder const):

  • xml/XMLHttpRequest.h:
2:21 AM Changeset in webkit [244376] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Update the test result of resize-observer/eventloop.html.
https://bugs.webkit.org/show_bug.cgi?id=197001

Patch by Cathie Chen <cathiechen@igalia.com> on 2019-04-17
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

  • web-platform-tests/resize-observer/eventloop-expected.txt:

LayoutTests:

Since 177484 has landed, the order of requestAnimationFrame and resizeobserver callback is right.
No need to mark eventloop.html as flaky.

12:36 AM Changeset in webkit [244375] by graouts@webkit.org
  • 2 edits in trunk/Source/WebCore

Opt Google Maps into simulated mouse events dispatch quirk
https://bugs.webkit.org/show_bug.cgi?id=196965
<rdar://problem/49934766>

Reviewed by Dean Jackson.

Use the correct Google Maps path.

  • page/Quirks.cpp:

(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

12:33 AM Changeset in webkit [244374] by graouts@webkit.org
  • 2 edits in trunk/Source/WebCore

Opt flipkart.com into simulated mouse events dispatch quirk
https://bugs.webkit.org/show_bug.cgi?id=196961
<rdar://problem/49648520>

Reviewed by Dean Jackson.

  • page/Quirks.cpp:

(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

12:30 AM Changeset in webkit [244373] by graouts@webkit.org
  • 2 edits in trunk/Source/WebCore

Opt MSN.com into simulated mouse events dispatch quirk
https://bugs.webkit.org/show_bug.cgi?id=196960
<rdar://problem/49403260>

Reviewed by Dean Jackson.

  • page/Quirks.cpp:

(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

Apr 16, 2019:

11:16 PM Changeset in webkit [244372] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

ScalableImageDecoder: don't forcefully decode image data when querying frame completeness, duration
https://bugs.webkit.org/show_bug.cgi?id=191354
<rdar://problem/46123406>

Reviewed by Michael Catanzaro.

ScalableImageDecoder::frameIsCompleteAtIndex() should only check the
index validity and, if the index is valid, check for completeness of the
corresponding frame. ScalableImageDecoder::frameDurationAtIndex() should
also only retrieve duration for already-complete frames, or expand the
default 0-second value according to the flashing-protection rule when
the target frame is not yet complete.

Both methods avoid calling ScalableImageDecoder::frameBufferAtIndex()
as that method goes on and decodes image data to determine specific
information. The ImageSource class that's querying this information
doesn't anticipate this, and doesn't handle the increased memory
consumption of the decoded data, leaving MemoryCache in the blind about
the image resource's actual amount of consumed memory. ImageSource can
instead gracefully handle any incomplete frame by marking the decoding
status for this frame as only partial.

  • platform/image-decoders/ScalableImageDecoder.cpp:

(WebCore::ScalableImageDecoder::frameIsCompleteAtIndex const):
(WebCore::ScalableImageDecoder::frameHasAlphaAtIndex const):
(WebCore::ScalableImageDecoder::frameDurationAtIndex const):

9:45 PM Changeset in webkit [244371] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit

[iOSMac] Use UIDocumentPickerViewController for picking files
https://bugs.webkit.org/show_bug.cgi?id=196999
<rdar://problem/49961414>

Reviewed by Tim Horton.

  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _showDocumentPickerMenu]):
Changed to present a UIDocumentPickerViewController on iOSMac.

(-[WKFileUploadPanel documentPicker:didPickDocumentsAtURLs:]):
(-[WKFileUploadPanel documentPicker:didPickDocumentAtURL:]):
Replaced a deprecated delegate method implementation.

8:34 PM Changeset in webkit [244370] by wenson_hsieh@apple.com
  • 25 edits
    2 adds in trunk

[iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
https://bugs.webkit.org/show_bug.cgi?id=196919
<rdar://problem/41630459>

Reviewed by Tim Horton.

Source/WebKit:

Adds modern WebKit support for -dontDismiss by implementing a couple of new platform hooks. Covered by a new
layout test: editing/selection/ios/selection-after-changing-text-with-callout-menu.html.

  • Platform/spi/ios/UIKitSPI.h:

Declare the private -dontDismiss property of UIMenuItem.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView willFinishIgnoringCalloutBarFadeAfterPerformingAction]):

Additionally teach the web view (not just the content view) to respond to the hook. This matters in the case
where the WebKit client (most notably, Mail) overrides WKWebView methods to define custom actions in the menu
controller. This scenario is exercised by the new layout test.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView willFinishIgnoringCalloutBarFadeAfterPerformingAction]):

If an action was performed where callout bar fading was ignored, then in WebKit, don't allow selection changes
to fade the callout bar until after the next remote layer tree commit.

(-[WKContentView _updateChangedSelection:]):

Stop suppressing selection updates when showing B/I/U controls, now that we can properly honor the -dontDismiss
property. This was originally introduced in <rdar://problem/15199925>, presumably to ensure that B/I/U buttons
(which have -dontDismiss set to YES) don't trigger selection change and end up dismissing themselves; however,
if triggering B/I/U actually changes the selection rects, this also means that the selection rects on-screen
would be stale after triggering these actions. This effect is most noticeable when bolding text.

(-[WKContentView shouldAllowHidingSelectionCommands]):

Tools:

Add iOS support for several new testing hooks. See below for more detail.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::isDismissingMenu const):

Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
dismissing. We consider the menu to be dismissing in between the -WillHide and -DidHide notifications sent
by UIKit when dismissing the callout bar (i.e. UIMenuController).

  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::isDismissingMenu const):

  • TestRunnerShared/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setAllowedMenuActions):

Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
"Copy", or "Paste"). In the case of the custom actions installed via installCustomMenuAction, we instead match
against the name of the custom action.

(WTR::TestRunner::installCustomMenuAction):

Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
takes the name of the action (which appears in a button in the callout bar), whether the action should cause
the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
triggered.

(WTR::TestRunner::performCustomMenuAction):

Invoked when the custom menu action is triggered.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::installCustomMenuAction):
(WTR::TestController::setAllowedMenuActions):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::performCustomMenuAction):

Add plumbing to call back into the injected bundle when performing the custom action.

  • WebKitTestRunner/TestInvocation.h:
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::installCustomMenuAction):
(WTR::TestController::setAllowedMenuActions):

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView initWithFrame:configuration:]):
(-[TestRunnerWKWebView becomeFirstResponder]):
(-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):

Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
in the Mail app on iOS.

(-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
(-[TestRunnerWKWebView setAllowedMenuActions:]):
(-[TestRunnerWKWebView resetCustomMenuAction]):
(-[TestRunnerWKWebView performCustomAction:]):
(-[TestRunnerWKWebView canPerformAction:withSender:]):
(-[TestRunnerWKWebView _willHideMenu]):
(-[TestRunnerWKWebView _didHideMenu]):

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetStateToConsistentValues):

Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
if specified.

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::isDismissingMenu const):

LayoutTests:

Add a new iOS layout test that installs a custom, non-dismissing action in the callout menu that enlarges text.
The test then activates this custom menu item and checks that the selection rects after triggering this custom
action are updated, and the callout bar is still showing.

  • editing/selection/ios/selection-after-changing-text-with-callout-menu-expected.txt: Added.
  • editing/selection/ios/selection-after-changing-text-with-callout-menu.html: Added.

This test additionally suppresses all callout bar menu items except for the custom "Embiggen" action, to ensure
that the "Embiggen" option can be tapped from the layout test without having to navigate callout bar items by
tapping on the "Next" and "Show styles" buttons. This latter approach is very challenging to make reliable in
automation; when navigating submenus in the callout bar, the next button can't be tapped until the current
callout bar transition animation is complete, but there's no delegate method invoked or notification posted when
this happens.

  • resources/ui-helper.js:

(window.UIHelper.isShowingMenu):
(window.UIHelper.isDismissingMenu):
(window.UIHelper.rectForMenuAction):
(window.UIHelper.async.chooseMenuAction):

Additionally add a few more UIHelper methods.

(window.UIHelper):

7:56 PM Changeset in webkit [244369] by Ross Kirsling
  • 4 edits in trunk/Source

Unreviewed non-unified build fix after r244307.

Source/WebCore:

  • page/DiagnosticLoggingClient.h:

Source/WebKit:

  • WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.h:
6:41 PM Changeset in webkit [244368] by megan_gardner@apple.com
  • 9 edits in trunk

Allow sharing from imageSheet on an image document
https://bugs.webkit.org/show_bug.cgi?id=196891
<rdar://problem/25377386>

Reviewed by Tim Horton.

Source/WebKit:

Allow sharing from an image sheet generated from an image document
by storing the image URL and using it as a fallback for the URL.
Store it as an image on WKElementAction to not accidentally trigger
any actions that should actually be associated with pure URLs.

  • UIProcess/API/Cocoa/_WKActivatedElementInfo.h:
  • UIProcess/API/Cocoa/_WKActivatedElementInfo.mm:

(-[_WKActivatedElementInfo _initWithInteractionInformationAtPosition:]):
(-[_WKActivatedElementInfo _initWithType:URL:imageURL:location:title:ID:rect:image:]):
(-[_WKActivatedElementInfo _initWithType:URL:imageURL:location:title:ID:rect:image:userInfo:]):
(-[_WKActivatedElementInfo imageURL]):
(-[_WKActivatedElementInfo _initWithType:URL:location:title:ID:rect:image:]): Deleted.
(-[_WKActivatedElementInfo _initWithType:URL:location:title:ID:rect:image:userInfo:]): Deleted.

  • UIProcess/API/Cocoa/_WKActivatedElementInfoInternal.h:
  • UIProcess/API/Cocoa/_WKElementAction.mm:

(+[_WKElementAction _elementActionWithType:customTitle:assistant:]):

  • UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant defaultActionsForImageSheet:]):
(-[WKActionSheetAssistant showLinkSheet]):

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _showAttachmentSheet]):
(-[WKContentView _dataForPreviewItemController:atPosition:type:]):
(-[WKContentView _presentedViewControllerForPreviewItemController:]):

Tools:

Test to make sure that the correct imageURL is extracted from an image element.

  • TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:

(TestWebKitAPI::TEST):

6:32 PM Changeset in webkit [244367] by wenson_hsieh@apple.com
  • 4 edits in trunk/Source/WebKit

[Cocoa] Add a way for Apple-internal clients to opt into recommended compatibility mode
https://bugs.webkit.org/show_bug.cgi?id=196977
<rdar://problem/49871194>

Reviewed by Tim Horton.

Add a helper method to query whether the navigation client should bypass policy safeguards when determining the
recommended compatibility mode. We bypass policy safeguards in Cocoa platforms if the navigation delegate
implements the new navigation delegate API.

  • UIProcess/API/APINavigationClient.h:

(API::NavigationClient::shouldBypassCompatibilityModeSafeguards const):

  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::shouldBypassCompatibilityModeSafeguards const):

6:27 PM Changeset in webkit [244366] by stephan.szabo@sony.com
  • 4 edits in trunk/Source

[PlayStation] Update port for system library changes
https://bugs.webkit.org/show_bug.cgi?id=196978

Reviewed by Ross Kirsling.

Source/JavaScriptCore:

  • shell/playstation/Initializer.cpp:

Add reference to new posix compatibility library.

Source/WTF:

  • wtf/PlatformPlayStation.cmake:

Remove reference to deleted system library

5:33 PM Changeset in webkit [244365] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

-[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
https://bugs.webkit.org/show_bug.cgi?id=196991
<rdar://problem/45507423>

Reviewed by Brent Fulgham.

The credentials are stored in the Network process. To enable fetching credentials from the Network process,
a proper process access type needs to be set for the credential Website data type.

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::computeNetworkProcessAccessTypeForDataFetch):

5:18 PM Changeset in webkit [244364] by commit-queue@webkit.org
  • 4 edits in trunk

REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
https://bugs.webkit.org/show_bug.cgi?id=196995

Patch by Alex Christensen <achristensen@webkit.org> on 2019-04-16
Reviewed by Brady Eidson.

Source/WebKit:

Always call CompletionHandlers. Otherwise things hang or assert.
I added an API test that asserts without this change so we don't regress this again.

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::clearAllCaches):
(WebKit::CacheStorage::Engine::clearCachesForOrigin):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:

(TEST):

4:44 PM Changeset in webkit [244363] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Worker imported scripts not showing up in Open Quickly dialog if inspector open after workers exist
https://bugs.webkit.org/show_bug.cgi?id=196986

Reviewed by Devin Rousso.

  • UserInterface/Views/OpenResourceDialog.js:

(WI.OpenResourceDialog.prototype._addScriptsForTarget):
We were unnecessary skipping Scripts that do not have a sourceURL but do
have a URL, which ends up being Worker populated scripts.

4:29 PM Changeset in webkit [244362] by jer.noble@apple.com
  • 2 edits in trunk/Source/WTF

Enable HAVE_AVKIT on PLATFORM(IOSMAC)
https://bugs.webkit.org/show_bug.cgi?id=196987

Reviewed by Tim Horton.

  • wtf/Platform.h:
4:07 PM Changeset in webkit [244361] by Chris Dumez
  • 14 edits
    1 add in trunk

URL set by document.open() is not communicated to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=196941
<rdar://problem/49237544>

Reviewed by Geoff Garen.

Source/WebCore:

Notify the FrameLoaderClient whenever an explicit open was done and provide it with
the latest document URL.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didExplicitOpen):

  • loader/FrameLoaderClient.h:

Source/WebKit:

Whenever the UIProcess is notified of an explicit document.open() call, update the
PageLoadState to make sure the URL is up-to-date. Also make sure the page / process
knows it committed a load (i.e. It is no longer showing the initially empty document).

  • UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::didExplicitOpen):

  • UIProcess/PageLoadState.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didExplicitOpenForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidExplicitOpen):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

Add API test coverage.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
  • TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:

(-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(TEST):

3:43 PM Changeset in webkit [244360] by Chris Dumez
  • 4 edits
    2 adds in trunk/Source

Show prompt for device orientation access if the client does not implement the corresponding API delegate
https://bugs.webkit.org/show_bug.cgi?id=196971
<rdar://problem/49945840>

Reviewed by Alex Christensen.

Show prompt for device orientation access if the client does not implement the corresponding
API delegate, instead of rejecting access by default.

  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::shouldAllowDeviceOrientationAndMotionAccess):

  • UIProcess/Cocoa/WKOrientationAccessAlert.h: Added.
  • UIProcess/Cocoa/WKOrientationAccessAlert.mm: Added.

(WebKit::presentOrientationAccessAlert):

  • WebKit.xcodeproj/project.pbxproj:
2:35 PM Changeset in webkit [244359] by wilander@apple.com
  • 3 edits in trunk/LayoutTests

Set test conditions closer to conversion redirect in LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html
https://bugs.webkit.org/show_bug.cgi?id=196983
<rdar://problem/49952679>

Unreviewed test gardening.

  • http/tests/adClickAttribution/resources/redirectToConversion.php:
  • http/tests/adClickAttribution/send-attribution-conversion-request.html:
2:28 PM Changeset in webkit [244358] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r238168) Web Inspector: <iframe src=...> request does not show up in Network Tab
https://bugs.webkit.org/show_bug.cgi?id=193505
<rdar://problem/47325957>

Reviewed by Devin Rousso.

  • UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype._handleFrameWasAdded):
Handle new frames by adding the frame's main resource.

1:52 PM Changeset in webkit [244357] by jonlee@apple.com
  • 5 edits in trunk

[MotionMark] The text "kkkj" is causing Firefox console warning: unreachable code after return statement
https://bugs.webkit.org/show_bug.cgi?id=196814

Reviewed by Wenson Hsieh.

  • MotionMark/resources/extensions.js:

(subtract.subtract.sampleY):
Websites/browserbench.org:

  • MotionMark1.1/resources/extensions.js:

(subtract.subtract.sampleY):

1:39 PM Changeset in webkit [244356] by Alan Bujtas
  • 2 edits in trunk/Source/WebKit

REGRESSION(r243557)[ContentChangeObserver] Need to double tap text formatting elements in MS Word web app
https://bugs.webkit.org/show_bug.cgi?id=196975
<rdar://problem/49489849>

Reviewed by Simon Fraser.

This patch ensures that we always proceed with synthetic click on form elements.

Covered by existing tests.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick):

1:32 PM Changeset in webkit [244355] by timothy@apple.com
  • 4 edits in trunk/Source

FrameView base background color always starts white.
https://bugs.webkit.org/show_bug.cgi?id=196976

Reviewed by Beth Dakin.

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::setBaseBackgroundColor): Bail early if the base background
color did not change.

Source/WebKit:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Set m_backgroundColor before calling
WebFrame::createWithCoreMainFrame so the call to create the FrameView
for the empty page in transitionToCommittedForNewPage() gets
the correct color from WebPage.

12:53 PM Changeset in webkit [244354] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'this._contentViewContainer.currentContentView.selectionPathComponents')
https://bugs.webkit.org/show_bug.cgi?id=196936
<rdar://problem/49917789>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/HeapAllocationsTimelineView.js:

(WI.HeapAllocationsTimelineView.prototype.showHeapSnapshotTimelineRecord):
(WI.HeapAllocationsTimelineView.prototype.get navigationItems):
(WI.HeapAllocationsTimelineView.prototype.get selectionPathComponents):
Drive-by: when selecting a record, force it to be visible before selecting it, as otherwise
the selection events won't be fired.

  • UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:

(WI.HeapAllocationsTimelineOverviewGraph.prototype.layout):
Drive-by: ensure that clicking on a [S] heap snapshot record icon actually selects the record.

12:48 PM Changeset in webkit [244353] by Devin Rousso
  • 67 edits in trunk

Unprefix -webkit-sticky
https://bugs.webkit.org/show_bug.cgi?id=196962
<rdar://problem/40903458>

Reviewed by Simon Fraser.

Source/WebCore:

Updated existing tests.

This change doesn't modify functionality, only exposing a new unprefixed CSS value.

  • css/CSSProperties.json:
  • css/CSSValueKeywords.in:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator PositionType const):

  • css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::convertPositionStyle):

Source/WebInspectorUI:

Replace all -webkit-sticky with sticky.

  • UserInterface/Models/CSSKeywordCompletions.js:
  • UserInterface/Views/AuditTestCaseContentView.css:

(.content-view-container > .content-view.audit-test-case > header):

  • UserInterface/Views/AuditTestGroupContentView.css:

(.content-view.audit-test-group.contains-test-case > header):

  • UserInterface/Views/ChangesDetailsSidebarPanel.css:

(.changes-panel .resource-section > .header):

  • UserInterface/Views/DetailsSection.css:

(.details-section > .header):

  • UserInterface/Views/NetworkDetailView.css:

(.network-detail .navigation-bar):

  • UserInterface/Views/SettingsTabContentView.css:

(.content-view.settings .navigation-bar):

  • UserInterface/Views/Table.css:

(.table > .header):

LayoutTests:

  • compositing/layer-creation/no-compositing-for-sticky.html:
  • editing/pasteboard/copy-paste-converts-sticky.html:
  • editing/pasteboard/copy-paste-converts-sticky-expected.txt:
  • fast/block/positioning/fixed-container-with-sticky-parent.html:
  • fast/block/sticky-position-containing-block-crash.html:
  • fast/css/sticky/inflow-sticky.html:
  • fast/css/sticky/inline-sticky-abspos-child.html:
  • fast/css/sticky/inline-sticky.html:
  • fast/css/sticky/multiple-layers-sticky-crash.html:
  • fast/css/sticky/parsing-position-sticky-expected.txt:
  • fast/css/sticky/remove-inline-sticky-crash.html:
  • fast/css/sticky/remove-sticky-crash.html:
  • fast/css/sticky/replaced-sticky.html:
  • fast/css/sticky/resources/parsing-position-sticky.js:
  • fast/css/sticky/sticky-as-positioning-container.html:
  • fast/css/sticky/sticky-both-sides.html:
  • fast/css/sticky/sticky-bottom-overflow-padding.html:
  • fast/css/sticky/sticky-left-percentage.html:
  • fast/css/sticky/sticky-left.html:
  • fast/css/sticky/sticky-margins.html:
  • fast/css/sticky/sticky-overflowing.html:
  • fast/css/sticky/sticky-side-margins.html:
  • fast/css/sticky/sticky-stacking-context.html:
  • fast/css/sticky/sticky-stacking-context-expected.html:
  • fast/css/sticky/sticky-table-row-top.html:
  • fast/css/sticky/sticky-table-thead-top.html:
  • fast/css/sticky/sticky-top-margins.html:
  • fast/css/sticky/sticky-top-overflow-container-overflow.html:
  • fast/css/sticky/sticky-top-overflow.html:
  • fast/css/sticky/sticky-top-zoomed.html:
  • fast/css/sticky/sticky-top-zoomed-expected.html:
  • fast/css/sticky/sticky-top.html:
  • fast/css/sticky/sticky-writing-mode-horizontal-bt.html:
  • fast/css/sticky/sticky-writing-mode-vertical-lr.html:
  • fast/css/sticky/sticky-writing-mode-vertical-rl.html:
  • fast/multicol/newmulticol/table-section-crash.html:
  • fast/scrolling/ios/reconcile-layer-position-recursive.html:
  • fast/scrolling/rtl-scrollbars-sticky-document-2.html:
  • fast/scrolling/rtl-scrollbars-sticky-document.html:
  • fast/scrolling/rtl-scrollbars-sticky-iframe-2.html:
  • fast/scrolling/rtl-scrollbars-sticky-iframe.html:
  • fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html:
  • fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html:
  • fast/scrolling/sticky-to-fixed.html:
  • legacy-animation-engine/fast/multicol/newmulticol/table-section-crash.html:
  • scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html:
  • svg/text/select-text-inside-non-static-position.html:
  • tiled-drawing/scrolling/sticky/negative-scroll-offset.html:
  • tiled-drawing/scrolling/sticky/sticky-horizontal.html:
  • tiled-drawing/scrolling/sticky/sticky-layers.html:
  • tiled-drawing/scrolling/sticky/sticky-vertical.html:
12:46 PM Changeset in webkit [244352] by rmorisset@apple.com
  • 4 edits in trunk/Source

[WTF] holdLock should be marked WARN_UNUSED_RETURN
https://bugs.webkit.org/show_bug.cgi?id=196922

Reviewed by Keith Miller.

Source/JavaScriptCore:

There was one case where holdLock was used and the result ignored.
From a comment that was deleted in https://bugs.webkit.org/attachment.cgi?id=328438&action=prettypatch, I believe that it is on purpose.
So I brought back a variant of the comment, and made the ignoring of the return explicit.

  • heap/BlockDirectory.cpp:

(JSC::BlockDirectory::isPagedOut):

Source/WTF:

  • wtf/Locker.h:
12:37 PM Changeset in webkit [244351] by Devin Rousso
  • 2 edits
    3 deletes in trunk/Source/WebInspectorUI

Web Inspector: remove unused WI.DOMTreeDataGrid
https://bugs.webkit.org/show_bug.cgi?id=196958
<rdar://problem/49931383>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/DOMTreeDataGrid.css: Removed.
  • UserInterface/Views/DOMTreeDataGrid.js: Removed.
  • UserInterface/Views/DOMTreeDataGridNode.js: Removed.
  • UserInterface/Main.html:
12:02 PM Changeset in webkit [244350] by Devin Rousso
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Storage: values truncated in Local/Session table
https://bugs.webkit.org/show_bug.cgi?id=178318
<rdar://problem/34998581>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/DataGrid.js:

(WI.DataGrid):
(WI.DataGrid.prototype._copyTextForDataGridNode):

  • UserInterface/Views/TimelineDataGrid.js:

(WI.TimelineDataGrid):
Refactor WI.DataGrid constructor to allow for more optional arguments.
Introduce a new optional argument copyCallback that can be used to override the text that
would be copied for any WI.DataGridNode in any column.

  • UserInterface/Views/DOMStorageContentView.js:

(WI.DOMStorageContentView):
(WI.DOMStorageContentView.prototype.itemAdded):
(WI.DOMStorageContentView.prototype.itemUpdated):
(WI.DOMStorageContentView.prototype._populate):
(WI.DOMStorageContentView.prototype._dataGridCopy): Added.
Save the full non-truncated value as part of the WI.DataGridNode's data. When copying,
use the full non-truncated value instead of what was shown in the DOM.

11:51 AM Changeset in webkit [244349] by don.olmstead@sony.com
  • 7 edits in trunk

[CMake] Set WTF_SCRIPTS_DIR
https://bugs.webkit.org/show_bug.cgi?id=196917

Reviewed by Konstantin Tokarev.

.:

Define WTF_SCRIPTS_DIR in WebKitFS.cmake and use that within the WEBKIT_COMPUTE_SOURCES
macro. This allows it to be overridden by a port such as the AppleWin internal build.

  • Source/cmake/OptionsAppleWin.cmake:
  • Source/cmake/OptionsWinCairo.cmake:
  • Source/cmake/WebKitFS.cmake:
  • Source/cmake/WebKitMacros.cmake:

Source/WTF:

Use WTF_SCRIPTS_DIR for copying the unified sources script.

  • wtf/CMakeLists.txt:
11:32 AM Changeset in webkit [244348] by kocsen_chung@apple.com
  • 8 edits
    1 add in tags/Safari-607.2.4.1/Source

Apply patch. rdar://problem/49836497

11:27 AM Changeset in webkit [244347] by kocsen_chung@apple.com
  • 7 edits in tags/Safari-607.2.4.1/Source

Versioning.

11:25 AM Changeset in webkit [244346] by wilander@apple.com
  • 2 edits in trunk/LayoutTests

Increase timeout threshold in http/tests/adClickAttribution/send-attribution-conversion-request.html to address flakiness
https://bugs.webkit.org/show_bug.cgi?id=196970
<rdar://problem/49945327>

Unreviewed test gardening.

  • http/tests/adClickAttribution/send-attribution-conversion-request.html:

Increased test timeout from 2 seconds to 4.

11:19 AM Changeset in webkit [244345] by Joseph Pecoraro
  • 3 edits in trunk/LayoutTests

Unreviewed test gardening, rebaseline HAR test after r244294.

  • http/tests/inspector/network/har/har-page-expected.txt:
  • http/tests/inspector/network/har/har-page.html:

Update for stricter SameSite parsing.

11:11 AM Changeset in webkit [244344] by Shawn Roberts
  • 3 edits in trunk/LayoutTests

media/W3C/video/events/event_progress_manual.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=177663

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations: Updating test expectations
11:07 AM Changeset in webkit [244343] by kocsen_chung@apple.com
  • 1 copy in tags/Safari-607.2.4.1

New tag.

11:01 AM Changeset in webkit [244342] by Alan Coon
  • 7 edits in tags/Safari-608.1.16.100/Source

Versioning.

10:55 AM Changeset in webkit [244341] by Alan Coon
  • 1 copy in tags/Safari-608.1.16.100

New tag.

10:47 AM Changeset in webkit [244340] by Alan Coon
  • 7 edits in tags/Safari-608.1.16.200/Source

Versioning.

10:45 AM Changeset in webkit [244339] by Alan Coon
  • 1 delete in tags/Safari-608.1.16.1.200

Delete tag.

10:44 AM Changeset in webkit [244338] by Alan Coon
  • 1 copy in tags/Safari-608.1.16.200

New tag.

10:41 AM Changeset in webkit [244337] by Alan Coon
  • 1 copy in tags/Safari-608.1.16.1.200

New tag.

10:40 AM Changeset in webkit [244336] by Alan Coon
  • 1 delete in tags/Safari-608.1.16.200

Delete tag.

10:36 AM Changeset in webkit [244335] by Alan Coon
  • 1 copy in tags/Safari-608.1.16.200

New tag.

10:18 AM Changeset in webkit [244334] by kocsen_chung@apple.com
  • 7 edits in branches/safari-607-branch/Source

Versioning.

9:46 AM Changeset in webkit [244333] by Ryan Haddad
  • 2 edits in trunk/Source/WebKit

Unreviewed, fix the build with recent SDKs.

  • UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(WebKit::WKWebViewState::store):

9:46 AM Changeset in webkit [244332] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations: Correct a typo in bug URL.
9:28 AM Changeset in webkit [244331] by commit-queue@webkit.org
  • 14 edits
    1 delete in trunk

Unreviewed, rolling out r244321.
https://bugs.webkit.org/show_bug.cgi?id=196968

Causing all WK2 Debug builds to exit early after Assertion
failures. (Requested by ShawnRoberts on #webkit).

Reverted changeset:

"URL set by document.open() is not communicated to the
UIProcess"
https://bugs.webkit.org/show_bug.cgi?id=196941
https://trac.webkit.org/changeset/244321

8:58 AM Changeset in webkit [244330] by caitp@igalia.com
  • 8 edits in trunk

[JSC] Filter DontEnum properties in ProxyObject::getOwnPropertyNames()
https://bugs.webkit.org/show_bug.cgi?id=176810

Reviewed by Saam Barati.

JSTests:

Add tests for the DontEnum filtering, and variations of other tests
take the DontEnum-filtering path.

  • stress/proxy-own-keys.js:

(i.catch):
(set assert):
(set add):
(let.set new):
(get let):

Source/JavaScriptCore:

This adds conditional logic following the invariant checks, to perform
filtering in common uses of getOwnPropertyNames.

While this would ideally only be done in JSPropertyNameEnumerator, adding
the filtering to ProxyObject::performGetOwnPropertyNames maintains the
invariant that the EnumerationMode is properly followed.

This was originally rolled out in r244020, as DontEnum filtering code
in ObjectConstructor.cpp's ownPropertyKeys() had not been removed. It's
now redundant due to being handled in ProxyObject::getOwnPropertyNames().

  • runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::reset):

  • runtime/ProxyObject.cpp:

(JSC::ProxyObject::performGetOwnPropertyNames):

Source/WebCore:

Previously, there was a comment here indicating uncertainty of whether it
was necessary to filter DontEnum properties explicitly or not. It turns
out that it was necessary in the case of JSC ProxyObjects.

This patch adds DontEnum filtering for ProxyObjects, however we continue
to explicitly filter them in JSDOMConvertRecord, which needs to use the
property descriptor after filtering. This change prevents observably
fetching the property descriptor twice per property.

  • bindings/js/JSDOMConvertRecord.h:
8:16 AM EnvironmentVariables edited by Philippe Normand
(diff)
2:41 AM Changeset in webkit [244329] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening

  • platform/gtk/TestExpectations:

media/media-controls-accessibility.html times out since r244182.

1:03 AM Changeset in webkit [244328] by graouts@webkit.org
  • 4 edits
    2 adds in trunk

[iOS] Redundant pointer events causes material design buttons to flush twice
https://bugs.webkit.org/show_bug.cgi?id=196914
<rdar://problem/49571860>

Reviewed by Dean Jackson.

Source/WebCore:

Test: pointerevents/ios/pointer-event-order.html

Do not dispatch pointer events for mouse events on iOS since we're already dispatching them when processing touch events.

  • dom/Element.cpp:

(WebCore::Element::dispatchMouseEvent):

LayoutTests:

Add a new test that listens to all pointer event types as well as click, which forces the dispatch of compatibility mouse events
along with the click which would trigger duplicated pointer events prior to the source changes.

To ensure the new test added runs smoothly with a preceeding test that also uses ui.tap(), we add a delay to guarantee that no
double-taps are seen rather two successive single taps.

  • pointerevents/ios/pointer-event-order-expected.txt: Added.
  • pointerevents/ios/pointer-event-order.html: Added.
  • pointerevents/utils.js:

(const.ui.new.UIController.prototype.tap):

Apr 15, 2019:

11:57 PM Changeset in webkit [244327] by Joseph Pecoraro
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: DOM Nodes should not show $0 when selected in Console area
https://bugs.webkit.org/show_bug.cgi?id=196953

Reviewed by Devin Rousso.

  • UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView):
Enable showing the last selected element.

  • UserInterface/Views/DOMTreeOutline.js:

Make parameters explicit. Drop "selectable" which was always true.
And add a new option for adding a class name.

  • UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom.show-last-selected li.last-selected > span::after):
(.tree-outline.dom.show-last-selected:focus li.last-selected > span::after):
Only show the "= $0" for a DOM tree that has enabled showing the last selected element.

  • UserInterface/Views/FormattedValue.css:

(.formatted-node > .tree-outline.dom li.selected .selection-area):
Don't show the selection-area for a console formatted node.

11:22 PM Changeset in webkit [244326] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit

Web Inspector: CRASH when reopening tab with docked inspector on crashed page
https://bugs.webkit.org/show_bug.cgi?id=196954
<rdar://problem/48716433>

Reviewed by Ryosuke Niwa.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):

9:24 PM Changeset in webkit [244325] by wilander@apple.com
  • 7 edits in trunk

Add a query string nonce to LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html to address flakiness
https://bugs.webkit.org/show_bug.cgi?id=196955

Source/WebCore:

Unreviewed test gardening. The WebCore change is only in a dedicated
test function.

No new tests. Existing test updated.

  • loader/AdClickAttribution.cpp:

(WebCore::AdClickAttribution::urlForTesting const):

Now preserves the query string in the test URL.

LayoutTests:

Unreviewed test gardening.

  • http/tests/adClickAttribution/resources/conversionFilePath.php:
  • http/tests/adClickAttribution/resources/conversionReport.php:
  • http/tests/adClickAttribution/resources/getConversionData.php:
  • http/tests/adClickAttribution/send-attribution-conversion-request.html:
7:41 PM Changeset in webkit [244324] by sbarati@apple.com
  • 23 edits
    1 add in trunk

Modify how we do SetArgument when we inline varargs calls
https://bugs.webkit.org/show_bug.cgi?id=196712
<rdar://problem/49605012>

Reviewed by Michael Saboff.

JSTests:

  • stress/get-stack-wrong-type-when-inline-varargs.js: Added.

(foo):

Source/JavaScriptCore:

When we inline varargs calls, we guarantee that the number of arguments that
go on the stack are somewhere between the "mandatoryMinimum" and the "limit - 1".
However, we can't statically guarantee that the arguments between these two
ranges was filled out by Load/ForwardVarargs. This is because in the general
case we don't know the argument count statically.

However, we used to always emit SetArgumentDefinitely up to "limit - 1" for
all arguments, even when some arguments aren't guaranteed to be in a valid
state. Emitting these SetArgumentDefinitely were helpful because they let us
handle variable liveness and OSR exit metadata. However, when we converted
to SSA, we ended up emitting a GetStack for each such SetArgumentDefinitely.

This is wrong, as we can't guarantee such SetArgumentDefinitely nodes are
actually looking at a range of the stack that are guaranteed to be initialized.
This patch introduces a new form of SetArgument node: SetArgumentMaybe. In terms
of OSR exit metadata and variable liveness tracking, it behaves like SetArgumentDefinitely.

However, it differs in a couple key ways:

  1. In ThreadedCPS, GetLocal(@SetArgumentMaybe) is invalid IR, as this implies

you might be loading uninitialized stack. (This same rule applies when you do
the full data flow reachability analysis over CPS Phis.) If someone logically
wanted to emit code like this, the correct node to emit would be GetArgument,
not GetLocal. For similar reasons, PhantomLocal(@SetArgumentMaybe) is also
invalid IR.

  1. To track liveness, Flush(@SetArgumentMaybe) is valid, and is the main user

of SetArgumentMaybe.

  1. In SSA conversion, we don't lower SetArgumentMaybe to GetStack, as there

should be no data flow user of SetArgumentMaybe.

SetArgumentDefinitely guarantees that the stack slot is initialized.
SetArgumentMaybe makes no such guarantee.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleVarargsInlining):

  • dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::freeUnnecessaryNodes):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlock):
(JSC::DFG::CPSRethreadingPhase::propagatePhis):
(JSC::DFG::CPSRethreadingPhase::computeIsFlushed):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGCommon.h:
  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::endBasicBlock):

  • dfg/DFGLiveCatchVariablePreservationPhase.cpp:

(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlockForTryCatch):

  • dfg/DFGMaximalFlushInsertionPhase.cpp:

(JSC::DFG::MaximalFlushInsertionPhase::treatRegularBlock):
(JSC::DFG::MaximalFlushInsertionPhase::treatRootBlock):

  • dfg/DFGMayExit.cpp:
  • dfg/DFGNode.cpp:

(JSC::DFG::Node::hasVariableAccessData):

  • dfg/DFGNodeType.h:
  • dfg/DFGPhantomInsertionPhase.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValidate.cpp:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

7:12 PM Changeset in webkit [244323] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r243672.
https://bugs.webkit.org/show_bug.cgi?id=196952

[JSValue release] should be thread-safe (Requested by
yusukesuzuki on #webkit).

Reverted changeset:

"[JSC] JSWrapperMap should not use Objective-C Weak map
(NSMapTable with NSPointerFunctionsWeakMemory) for
m_cachedObjCWrappers"
https://bugs.webkit.org/show_bug.cgi?id=196392
https://trac.webkit.org/changeset/243672

7:03 PM Changeset in webkit [244322] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
https://bugs.webkit.org/show_bug.cgi?id=196948

Reviewed by Zalan Bujtas.

  • TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:

(TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.

7:01 PM Changeset in webkit [244321] by Chris Dumez
  • 14 edits
    1 add in trunk

URL set by document.open() is not communicated to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=196941
<rdar://problem/49237544>

Reviewed by Geoffrey Garen.

Source/WebCore:

Notify the FrameLoaderClient whenever an explicit open was done and provide it with
the latest document URL.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didExplicitOpen):

  • loader/FrameLoaderClient.h:

Source/WebKit:

Whenever the UIProcess is notified of an explicit document.open() call, update the
PageLoadState to make sure the URL is up-to-date. Also make sure the page / process
knows it committed a load (i.e. It is no longer showing the initially empty document).

  • UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::didExplicitOpen):

  • UIProcess/PageLoadState.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didExplicitOpenForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidExplicitOpen):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

Add API test coverage.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
  • TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:

(-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(TEST):

6:55 PM Changeset in webkit [244320] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix logic flow for error log
https://bugs.webkit.org/show_bug.cgi?id=196933

Patch by Eike Rathke <erack@redhat.com> on 2019-04-15
Reviewed by Alexey Proskuryakov.

Missing block braces logged an error always, not just
if (actionIfInvalid == Complain).

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::isSafeToLoadURL):

6:43 PM Changeset in webkit [244319] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Stop using hyphenationFactor
https://bugs.webkit.org/show_bug.cgi?id=196949
<rdar://problem/49779594>

Patch by Alex Christensen <achristensen@webkit.org> on 2019-04-15
Reviewed by Geoffrey Garen.

  • UIProcess/Cocoa/WKSafeBrowsingWarning.mm:

(-[WKSafeBrowsingTextView initWithAttributedString:forWarning:]):
I added this use of hyphenationFactor in r241124 but the other changes in that revision make the use of hyphenationFactor redundant.
There is a reason to remove it in the radar.

6:43 PM Changeset in webkit [244318] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: update sheet rect whenever inspector window size changes
https://bugs.webkit.org/show_bug.cgi?id=196942
<rdar://problem/49920241>

Reviewed by Joseph Pecoraro.

  • UserInterface/Base/Main.js:

(WI.contentLoaded):
(WI._windowResized):
(WI._updateSheetRect): Added.

6:26 PM Changeset in webkit [244317] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Forward declare WKWebView in _WKDiagnosticLoggingDelegate.h

  • UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:

This fixes builds where _WKDiagnosticLoggingDelegate.h is the only WebKit header included, such as my work on rdar://problem/35175989

6:19 PM Changeset in webkit [244316] by yoshiaki.jitsukawa@sony.com
  • 2 edits in trunk/Source/bmalloc

Unreviewed. Build fix after r244244.

  • Source/bmalloc/bmalloc/AvailableMemory.cpp
5:51 PM Changeset in webkit [244315] by mmaxfield@apple.com
  • 9 edits
    1 add in trunk

[Cocoa] FontPlatformData objects aren't cached at all when using font-family:system-ui
https://bugs.webkit.org/show_bug.cgi?id=196846
<rdar://problem/49499971>

Reviewed by Simon Fraser and Darin Adler.

PerformanceTests:

  • Layout/system-ui-rebuild-emoji.html: Added.

Source/WebCore:

When adding the special codepath for system-ui to behave as an entire list of fonts rather than a single item,
I never added a cache for the FontPlatformData objects that codepath creates. The non-system-ui codepath already
has a cache in fontPlatformDataCache() in FontCache.cpp.

This patch causes a 16.8x performance improvement on the attached benchmark.

Test: PerformanceTests/Layout/system-ui-rebuild-emoji.html

  • page/cocoa/MemoryReleaseCocoa.mm:

(WebCore::platformReleaseMemory):

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::invalidateFontCache):

  • platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:

(WebCore::FontFamilySpecificationKey::FontFamilySpecificationKey):
(WebCore::FontFamilySpecificationKey::operator== const):
(WebCore::FontFamilySpecificationKey::operator!= const):
(WebCore::FontFamilySpecificationKey::isHashTableDeletedValue const):
(WebCore::FontFamilySpecificationKey::computeHash const):
(WebCore::FontFamilySpecificationKeyHash::hash):
(WebCore::FontFamilySpecificationKeyHash::equal):
(WebCore::fontMap):
(WebCore::clearFontFamilySpecificationCoreTextCache):
(WebCore::FontFamilySpecificationCoreText::fontRanges const):

  • platform/graphics/cocoa/FontFamilySpecificationCoreText.h:
  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
(WebCore::safeCFEqual): Deleted.

Source/WTF:

  • wtf/RetainPtr.h:

(WTF::safeCFEqual):
(WTF::safeCFHash):

5:39 PM Changeset in webkit [244314] by sbarati@apple.com
  • 3 edits
    1 add in trunk

SafeToExecute for GetByOffset/GetGetterByOffset/PutByOffset is using the wrong child for the base
https://bugs.webkit.org/show_bug.cgi?id=196945
<rdar://problem/49802750>

Reviewed by Filip Pizlo.

JSTests:

  • stress/get-by-offset-should-use-correct-child.js: Added.

(foo.bar):
(foo):

Source/JavaScriptCore:

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

5:28 PM Changeset in webkit [244313] by rmorisset@apple.com
  • 7 edits
    1 add in trunk

DFG should be able to constant fold Object.create() with a constant prototype operand
https://bugs.webkit.org/show_bug.cgi?id=196886

Reviewed by Yusuke Suzuki.

JSTests:

Note that this new benchmark does not currently see a speedup with inlining removed.
The reason is that we do not yet have inline caching for Object.create(), we only optimize it when the DFG can see statically the prototype being passed.

  • microbenchmarks/object-create-constant-prototype.js: Added.

(test):

Source/JavaScriptCore:

It is a fairly simple and limited patch, as it only works when the DFG can prove the exact object used as prototype.
But when it applies it can be a significant win:

Baseline Optim

object-create-constant-prototype 3.6082+-0.0979 1.6947+-0.0756 definitely 2.1292x faster
object-create-null 11.4492+-0.2510 ? 11.5030+-0.2402 ?
object-create-unknown-object-prototype 15.6067+-0.1851 ? 15.7500+-0.2322 ?
object-create-untyped-prototype 8.8873+-0.1240 ? 8.9806+-0.1202 ? might be 1.0105x slower
<geometric> 8.6967+-0.1208 7.2408+-0.1367 definitely 1.2011x faster

The only subtlety is that we need to to access the StructureCache concurrently from the compiler thread (see https://bugs.webkit.org/show_bug.cgi?id=186199)
I solved this with a simple lock, taken when the compiler thread tries to read it, and when the main thread tries to modify it.
I expect it to be extremely low contention, but will watch the bots just in case.
The lock is taken neither when the main thread is only reading the cache (it has no-one to race with), nor when the GC purges it of dead entries (it does not free anything while a compiler thread is in the middle of a phase).

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • runtime/StructureCache.cpp:

(JSC::StructureCache::createEmptyStructure):
(JSC::StructureCache::tryEmptyObjectStructureForPrototypeFromCompilerThread):

  • runtime/StructureCache.h:
5:02 PM Changeset in webkit [244312] by Devin Rousso
  • 15 edits
    2 adds in trunk

Web Inspector: fake value descriptors for promises add a catch handler, preventing "rejectionhandled" events from being fired
https://bugs.webkit.org/show_bug.cgi?id=196484
<rdar://problem/49114725>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Only add a catch handler when the promise is reachable via a native getter and is known to
have rejected. A non-rejected promise doesn't need a catch handler, and any promise that
isn't reachable via a getter won't actually be reached, as InjectedScript doesn't call any
functions, instead only getting the function object itself.

  • inspector/InjectedScriptSource.js:

(InjectedScript.prototype._propertyDescriptors.createFakeValueDescriptor):

  • inspector/JSInjectedScriptHost.h:
  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::isPromiseRejectedWithNativeGetterTypeError): Added.

  • inspector/JSInjectedScriptHostPrototype.cpp:

(Inspector::JSInjectedScriptHostPrototype::finishCreation):
(Inspector::jsInjectedScriptHostPrototypeFunctionIsPromiseRejectedWithNativeGetterTypeError): Added.

  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::setNativeGetterTypeError): Added.
(JSC::ErrorInstance::isNativeGetterTypeError const): Added.

  • runtime/Error.h:

(JSC::throwVMGetterTypeError): Added.

  • runtime/Error.cpp:

(JSC::createGetterTypeError): Added.
(JSC::throwGetterTypeError): Added.
(JSC::throwDOMAttributeGetterTypeError):

Source/WebCore:

Test: inspector/runtime/promise-native-getter.html

Mark errors created from getters as being isNativeGetterTypeError.

  • bindings/js/JSDOMExceptionHandling.cpp:

(WebCore::throwGetterTypeError):
(WebCore::rejectPromiseWithGetterTypeError):
(WebCore::rejectPromiseWithThisTypeError):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::makeGetterTypeErrorForBuiltins):

  • bindings/js/JSDOMPromiseDeferred.h:
  • bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::createRejectedPromiseWithTypeError):

  • Modules/streams/WritableStream.js:

(getter.closed):
(getter.ready):

LayoutTests:

  • inspector/runtime/promise-native-getter.html: Added.
  • inspector/runtime/promise-native-getter-expected.txt: Added.
5:00 PM Changeset in webkit [244311] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Unreviewed, fix typo in a comment.

  • UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel.prototype.performSearch):

5:00 PM Changeset in webkit [244310] by dean_johnson@apple.com
  • 3 edits in trunk/Tools

Using Tools/Scripts/clean-webkit should not install requests
https://bugs.webkit.org/show_bug.cgi?id=196940

Reviewed by Lucas Forschler.

  • Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers

existing, depending on the path autoinstalled is run through.

  • Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's

needed.
(Port.configuration_for_upload):
(Port.commits_for_upload):

4:53 PM Changeset in webkit [244309] by rmorisset@apple.com
  • 51 edits in trunk/Source/JavaScriptCore

B3::Value should have different kinds of adjacency lists
https://bugs.webkit.org/show_bug.cgi?id=196091

Reviewed by Filip Pizlo.

The key idea of this optimization is to replace the Vector<Value*, 3> m_children in B3::Value (40 bytes on 64-bits platform) by one of the following:

  • Nothing (0 bytes)
  • 1 Value* (8 bytes)
  • 2 Value* (16 bytes)
  • 3 Value* (24 bytes)
  • A Vector<Value*, 3>

after the end of the Value object, depending on the kind of the Value.
So for example, when allocating an Add, we would allocate an extra 16 bytes into which to store 2 Values.
This would halve the memory consumption of Const64/Const32/Nop/Identity and a bunch more kinds of values, and reduce by a more moderate amount the memory consumption of the rest of non-varargs values (e.g. Add would go from 72 to 48 bytes).

A few implementation points:

  • Even if there is no children, we must remember to allocate at least enough space for replaceWithIdentity to work later. It needs sizeof(Value) (for the object itself) + sizeof(Value*) (for the pointer to its child)
  • We must make sure to destroy the vector whenever we destroy a Value which is VarArgs
  • We must remember how many elements there are in the case where we did not allocate a Vector. We cannot do it purely by relying on the kind, both for speed reasons and because Return can have either 0 or 1 argument in B3 Thankfully, we have an extra byte of padding to use in the middle of B3::Value
  • In order to support clone(), we must have a separate version of allocate, which extracts the opcode from the to-be-cloned object instead of from the call to the constructor
  • Speaking of which, we need a special templated function opcodeFromConstructor, because some of the constructors of subclasses of Value don't take an explicit Opcode as argument, typically because they match a single one.
  • To maximize performance, we provide specialized versions of child/lastChild/numChildren/children in the subclasses of Value, skipping checks when the actual type of the Value is already known. This is done through the B3_SPECIALIZE_VALUE_FOR_... defined at the bottom of B3Value.h
  • In the constructors of Value, we convert all extra children arguments to Value* eagerly. It is not required for correctness (they will be converted when put into a Vector<Value*> or a Value* in the end), but it helps limit an explosion in the number of template instantiations.
  • I moved DeepValueDump::dump from the .h to the .cpp, as there is no good reason to inline it, and recompiling JSC is already slow enough

(JSC::B3::ArgumentRegValue::cloneImpl const): Deleted.

  • b3/B3ArgumentRegValue.h:
  • b3/B3AtomicValue.cpp:

(JSC::B3::AtomicValue::AtomicValue):
(JSC::B3::AtomicValue::cloneImpl const): Deleted.

  • b3/B3AtomicValue.h:
  • b3/B3BasicBlock.h:
  • b3/B3BasicBlockInlines.h:

(JSC::B3::BasicBlock::appendNewNonTerminal): Deleted.

  • b3/B3CCallValue.cpp:

(JSC::B3::CCallValue::appendArgs):
(JSC::B3::CCallValue::cloneImpl const): Deleted.

  • b3/B3CCallValue.h:
  • b3/B3CheckValue.cpp:

(JSC::B3::CheckValue::cloneImpl const): Deleted.

  • b3/B3CheckValue.h:
  • b3/B3Const32Value.cpp:

(JSC::B3::Const32Value::cloneImpl const): Deleted.

  • b3/B3Const32Value.h:
  • b3/B3Const64Value.cpp:

(JSC::B3::Const64Value::cloneImpl const): Deleted.

  • b3/B3Const64Value.h:
  • b3/B3ConstDoubleValue.cpp:

(JSC::B3::ConstDoubleValue::cloneImpl const): Deleted.

  • b3/B3ConstDoubleValue.h:
  • b3/B3ConstFloatValue.cpp:

(JSC::B3::ConstFloatValue::cloneImpl const): Deleted.

  • b3/B3ConstFloatValue.h:
  • b3/B3ConstPtrValue.h:

(JSC::B3::ConstPtrValue::opcodeFromConstructor):

  • b3/B3FenceValue.cpp:

(JSC::B3::FenceValue::FenceValue):
(JSC::B3::FenceValue::cloneImpl const): Deleted.

  • b3/B3FenceValue.h:
  • b3/B3MemoryValue.cpp:

(JSC::B3::MemoryValue::MemoryValue):
(JSC::B3::MemoryValue::cloneImpl const): Deleted.

  • b3/B3MemoryValue.h:
  • b3/B3MoveConstants.cpp:
  • b3/B3PatchpointValue.cpp:

(JSC::B3::PatchpointValue::cloneImpl const): Deleted.

  • b3/B3PatchpointValue.h:

(JSC::B3::PatchpointValue::opcodeFromConstructor):

  • b3/B3Procedure.cpp:
  • b3/B3Procedure.h:
  • b3/B3ProcedureInlines.h:

(JSC::B3::Procedure::add):

  • b3/B3SlotBaseValue.cpp:

(JSC::B3::SlotBaseValue::cloneImpl const): Deleted.

  • b3/B3SlotBaseValue.h:
  • b3/B3StackmapSpecial.cpp:

(JSC::B3::StackmapSpecial::forEachArgImpl):
(JSC::B3::StackmapSpecial::isValidImpl):

  • b3/B3StackmapValue.cpp:

(JSC::B3::StackmapValue::append):
(JSC::B3::StackmapValue::StackmapValue):

  • b3/B3StackmapValue.h:
  • b3/B3SwitchValue.cpp:

(JSC::B3::SwitchValue::SwitchValue):
(JSC::B3::SwitchValue::cloneImpl const): Deleted.

  • b3/B3SwitchValue.h:

(JSC::B3::SwitchValue::opcodeFromConstructor):

  • b3/B3UpsilonValue.cpp:

(JSC::B3::UpsilonValue::cloneImpl const): Deleted.

  • b3/B3UpsilonValue.h:
  • b3/B3Value.cpp:

(JSC::B3::DeepValueDump::dump const):
(JSC::B3::Value::~Value):
(JSC::B3::Value::replaceWithIdentity):
(JSC::B3::Value::replaceWithNopIgnoringType):
(JSC::B3::Value::replaceWithPhi):
(JSC::B3::Value::replaceWithJump):
(JSC::B3::Value::replaceWithOops):
(JSC::B3::Value::replaceWith):
(JSC::B3::Value::invertedCompare const):
(JSC::B3::Value::returnsBool const):
(JSC::B3::Value::cloneImpl const): Deleted.

  • b3/B3Value.h:

(JSC::B3::DeepValueDump::dump const): Deleted.

  • b3/B3ValueInlines.h:

(JSC::B3::Value::adjacencyListOffset const):
(JSC::B3::Value::cloneImpl const):

  • b3/B3VariableValue.cpp:

(JSC::B3::VariableValue::VariableValue):
(JSC::B3::VariableValue::cloneImpl const): Deleted.

  • b3/B3VariableValue.h:
  • b3/B3WasmAddressValue.cpp:

(JSC::B3::WasmAddressValue::WasmAddressValue):
(JSC::B3::WasmAddressValue::cloneImpl const): Deleted.

  • b3/B3WasmAddressValue.h:
  • b3/B3WasmBoundsCheckValue.cpp:

(JSC::B3::WasmBoundsCheckValue::WasmBoundsCheckValue):
(JSC::B3::WasmBoundsCheckValue::cloneImpl const): Deleted.

  • b3/B3WasmBoundsCheckValue.h:

(JSC::B3::WasmBoundsCheckValue::accepts):
(JSC::B3::WasmBoundsCheckValue::opcodeFromConstructor):

  • b3/testb3.cpp:

(JSC::B3::testCallFunctionWithHellaArguments):
(JSC::B3::testCallFunctionWithHellaArguments2):
(JSC::B3::testCallFunctionWithHellaArguments3):
(JSC::B3::testCallFunctionWithHellaDoubleArguments):
(JSC::B3::testCallFunctionWithHellaFloatArguments):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::call):

4:48 PM Changeset in webkit [244308] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Heap: don't use recursion when calculating root paths
https://bugs.webkit.org/show_bug.cgi?id=196890
<rdar://problem/49870751>

Reviewed by Joseph Pecoraro.

  • UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:

(HeapSnapshot.prototype.shortestGCRootPath):
(HeapSnapshot.prototype._determineGCRootPaths):
(HeapSnapshot.prototype._gcRootPathes.visitNode): Deleted.
(HeapSnapshot.prototype._gcRootPathes): Deleted.

4:48 PM Changeset in webkit [244307] by achristensen@apple.com
  • 25 edits in trunk

Add a DiagnosticLogging method taking an arbitrary dictionary of values.
https://bugs.webkit.org/show_bug.cgi?id=196773

Source/WebCore:

Patch by Jer Noble <jer.noble@apple.com> on 2019-04-15
Reviewed by Alex Christensen.

  • page/DiagnosticLoggingClient.h:

Source/WebKit:

Patch by Jer Noble <jer.noble@apple.com> on 2019-04-15
Reviewed by Alex Christensen.

In addition to adding the new logging delegate method (and piping everything into it),
add a new APIObject class to represent a signed integer.

  • Shared/API/APINumber.h:
  • Shared/API/APIObject.h:
  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

  • Shared/Cocoa/WKNSNumber.mm:

(-[WKNSNumber dealloc]):
(-[WKNSNumber objCType]):
(-[WKNSNumber getValue:]):
(-[WKNSNumber longLongValue]):
(-[WKNSNumber _apiObject]):

  • Shared/UserData.cpp:

(WebKit::UserData::encode):
(WebKit::UserData::decode):

  • UIProcess/API/APIDiagnosticLoggingClient.h:
  • UIProcess/API/C/WKPageDiagnosticLoggingClient.h:
  • UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:
  • UIProcess/Cocoa/DiagnosticLoggingClient.h:
  • UIProcess/Cocoa/DiagnosticLoggingClient.mm:

(WebKit::DiagnosticLoggingClient::logDiagnosticMessageWithValueDictionary):

  • UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::didReceiveMessage):

  • UIProcess/WebPageDiagnosticLoggingClient.cpp:

(WebKit::WebPageDiagnosticLoggingClient::logDiagnosticMessageWithValueDictionary):

  • UIProcess/WebPageDiagnosticLoggingClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::logDiagnosticMessageWithValueDictionary):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.cpp:

(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithValueDictionary):

  • WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.h:

Tools:

Reviewed by Jer Noble.

  • TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:

(-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
(TEST):

4:36 PM Changeset in webkit [244306] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

ews-build should clearly indicate flaky test failures
https://bugs.webkit.org/show_bug.cgi?id=196947

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/steps.py:

(AnalyzeAPITestsResults.analyzeResults):

4:15 PM Changeset in webkit [244305] by Alan Coon
  • 1 copy in tags/Safari-607.2.5

Tag Safari-607.2.5.

4:02 PM Changeset in webkit [244304] by Shawn Roberts
  • 2 edits in trunk/LayoutTests

storage/indexeddb/modern/gc-closes-database-private.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=194450

Unreviewed test gardening.

  • platform/win/TestExpectations: Updating test expectations
3:58 PM Changeset in webkit [244303] by Alan Coon
  • 2 edits
    3 adds in branches/safari-607-branch/Tools

Apply patch. rdar://problem/49788895

3:57 PM Changeset in webkit [244302] by dino@apple.com
  • 2 edits in trunk/Source/WebKit

Provide option to not create a longpress gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=196937
<rdar://problem/49918278>

Build fix for iOS platforms that don't have link preview.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):

3:35 PM Changeset in webkit [244301] by Shawn Roberts
  • 2 edits in trunk/LayoutTests

imported/w3c/web-platform-tests/hr-time/test_cross_frame_start.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196944

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations: Updating test expecations for flaky failure
3:23 PM Changeset in webkit [244300] by tzagallo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Bytecode cache should not encode the SourceProvider for UnlinkedFunctionExecutable's classSource
https://bugs.webkit.org/show_bug.cgi?id=196878

Reviewed by Saam Barati.

Every time we encode an (Unlinked)SourceCode, we encode its SourceProvider,
including the full source if it's a StringSourceProvider. This wasn't an issue,
since the SourceCode contains a RefPtr to the SourceProvider, and the Encoder
would avoid encoding the provider multiple times. With the addition of the
incremental cache, each UnlinkedFunctionCodeBlock is encoded in isolation, which
means we can no longer deduplicate it and the full program text was being encoded
multiple times in the cache.
As a work around, this patch adds a custom cached type for encoding the SourceCode
without its provider, and later injects the SourceProvider through the Decoder.

  • parser/SourceCode.h:
  • parser/UnlinkedSourceCode.h:

(JSC::UnlinkedSourceCode::provider const):

  • runtime/CachedTypes.cpp:

(JSC::Decoder::Decoder):
(JSC::Decoder::create):
(JSC::Decoder::provider const):
(JSC::CachedSourceCodeWithoutProvider::encode):
(JSC::CachedSourceCodeWithoutProvider::decode const):
(JSC::decodeCodeBlockImpl):

  • runtime/CachedTypes.h:
3:21 PM Changeset in webkit [244299] by bfulgham@apple.com
  • 6 edits in trunk

InjectedBundle parameters often need initialization function called before unarchiving
https://bugs.webkit.org/show_bug.cgi?id=189709
<rdar://problem/44573653>

Reviewed by Ryosuke Niwa.

Source/WebKit:

Handle the case where the InjectedBundle parameters do not successfully decode because they contain
an unexpected class from the embedding program. If this happens, try decoding the bundle parameters
after the bundle initialiation function runs, which gives the embedding program the opportunity to
register additional classes that are safe for serialization.

Extend WKWebProcessPlugIn with a method that returns the names of any custom classes that need
to be serialized by the InjectedBundle.

Create a new 'decodeBundleParameters' method that contains the logic that used to live in 'initialize'.
Revise 'initialize' to call this new method.

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::initialize): Use the new method.
(WebKit::InjectedBundle::decodeBundleParameters): Added.
(WebKit::InjectedBundle::setBundleParameters): Use 'decodeObjectOfClasses' with the more complete
'classesForCoder' method to unarchive the passed bundle parameters, rather than the
NSDictionary-specific method, since InjectedBundles often encode other types of objects, and the
NSDictionary object may itself hold other kinds of objects.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:

(WebKit::WKWebProcessPlugIn::additionalClassesForParameterCoder): Added.

Tools:

  • TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:

(-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.

3:06 PM Changeset in webkit [244298] by rmorisset@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

MarkedSpace.cpp is not in the Xcode workspace
https://bugs.webkit.org/show_bug.cgi?id=196928

Reviewed by Saam Barati.

2:58 PM Changeset in webkit [244297] by justin_fan@apple.com
  • 4 edits in trunk/Source/WebCore

Let WTF::convertSafely deduce types from arguments.

Reviewer's (Darin Adler) follow-up to https://bugs.webkit.org/show_bug.cgi?id=196793.

  • platform/graphics/gpu/cocoa/GPUBufferMetal.mm:

(WebCore::GPUBuffer::tryCreate):

  • platform/graphics/gpu/cocoa/GPUCommandBufferMetal.mm:

(WebCore::GPUCommandBuffer::copyBufferToTexture):
(WebCore::GPUCommandBuffer::copyTextureToBuffer):

  • platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:

(WebCore::trySetInputStateForPipelineDescriptor):

2:58 PM Changeset in webkit [244296] by dino@apple.com
  • 3 edits in trunk/Source/WebKit

Provide option to not create a longpress gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=196937
<rdar://problem/49918278>

Reviewed by Antoine Quint.

A WebKitAdditions file has changed name to WKContentViewInteractionWKInteraction.mm.

Add a property to toggle if we should add a long press gesture
recognizer.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(shouldUsePreviewForLongPress):
(-[WKContentView shouldUsePreviewForLongPress]):

2:55 PM Changeset in webkit [244295] by tzagallo@apple.com
  • 3 edits
    1 add in trunk

Incremental bytecode cache should not append function updates when loaded from memory
https://bugs.webkit.org/show_bug.cgi?id=196865

Reviewed by Filip Pizlo.

JSTests:

  • stress/bytecode-cache-shared-code-block.js: Added.

(b):
(program):

Source/JavaScriptCore:

Function updates hold the assumption that a function can only be executed/cached
after its containing code block has already been cached. This assumptions does
not hold if the UnlinkedCodeBlock is loaded from memory by the CodeCache, since
we might have two independent SourceProviders executing different paths of the
code and causing the same UnlinkedCodeBlock to be modified in memory.
Use a RefPtr instead of Ref for m_cachedBytecode in ShellSourceProvider to distinguish
between a new, empty cache and a cache that was not loaded and therefore cannot be updated.

  • jsc.cpp:

(ShellSourceProvider::ShellSourceProvider):

2:53 PM Changeset in webkit [244294] by Joseph Pecoraro
  • 5 edits in trunk

Web Inspector: SameSite parsing should be stricter
https://bugs.webkit.org/show_bug.cgi?id=196927
<rdar://problem/42291601>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

  • UserInterface/Models/Cookie.js:

(WI.Cookie.parseSameSiteAttributeValue):

LayoutTests:

  • inspector/unit-tests/cookie.html:
  • inspector/unit-tests/cookie-expected.txt:
2:49 PM Changeset in webkit [244293] by rniwa@webkit.org
  • 8 edits in trunk

Throw TypeError when custom element constructor returns a wrong element or tries to create itself
https://bugs.webkit.org/show_bug.cgi?id=196892

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Update the tests according to https://github.com/web-platform-tests/wpt/pull/16328.

  • web-platform-tests/custom-elements/upgrading/Node-cloneNode-expected.txt:
  • web-platform-tests/custom-elements/upgrading/Node-cloneNode.html:
  • web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element-expected.txt:
  • web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element.html:

Source/WebCore:

Throw TypeError instead of InvalidStateError for consistency. This updates WebKit's custom elements
implementation for https://github.com/whatwg/html/pull/4525.

Tests: imported/w3c/web-platform-tests/custom-elements/upgrading/Node-cloneNode.html

imported/w3c/web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element.html

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::upgradeElement):

  • bindings/js/JSHTMLElementCustom.cpp:

(WebCore::constructJSHTMLElement):

2:46 PM Changeset in webkit [244292] by don.olmstead@sony.com
  • 12 edits in trunk

[CMake] WebCore derived sources should only be referenced inside WebCore
https://bugs.webkit.org/show_bug.cgi?id=196904

Reviewed by Konstantin Tokarev.

.:

Override WebCore_DERIVED_SOURCES_DIR for WinCairo.

  • Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

Use WebCore_DERIVED_SOURCES_DIR instead of DERIVED_SOURCES_WEBCORE_DIR.

  • CMakeLists.txt:
  • PlatformGTK.cmake:
  • PlatformWin.cmake:
  • WebCoreMacros.cmake:

Source/WebCore/PAL:

Specify PAL_DERIVED_SOURCES_DIR as a private include directory.

  • pal/CMakeLists.txt:
  • pal/PlatformWin.cmake:

Source/WebKit:

Remove reference to DERIVED_SOURCES_WEBCORE_DIR in PlatformMac.cmake.

  • PlatformMac.cmake:
2:34 PM Changeset in webkit [244291] by Alan Bujtas
  • 10 edits in trunk/Source/WebKit

DrawingArea should only capture painting related milestones
https://bugs.webkit.org/show_bug.cgi?id=196926
<rdar://problem/48003845>

Reviewed by Tim Horton.

While dispatching layout milestones (mixture of layout and painting items), the associated drawing areas should only capture the painting related milestones.
These captured milestones get dispatched later in the commit handler to ensure that they are not forwarded prematurely.
However the truly layout related milestones (e.g. DidFirstVisuallyNonEmptyLayout) should be dispatched right away with no delay.

  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::newlyReachedPaintingMilestones const):
(WebKit::RemoteLayerTreeTransaction::setNewlyReachedPaintingMilestones):
(WebKit::RemoteLayerTreeTransaction::newlyReachedLayoutMilestones const): Deleted.
(WebKit::RemoteLayerTreeTransaction::setNewlyReachedLayoutMilestones): Deleted.

  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode const):
(WebKit::RemoteLayerTreeTransaction::decode):

  • UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::addMilestonesToDispatch):
(WebKit::DrawingArea::dispatchDidReachLayoutMilestone): Deleted.

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:

(WebKit::RemoteLayerTreeDrawingArea::addMilestonesToDispatch):

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::dispatchDidReachLayoutMilestone): Deleted.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::dispatchDidReachLayoutMilestone):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(WebKit::TiledCoreAnimationDrawingArea::addMilestonesToDispatch):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::sendPendingNewlyReachedPaintingMilestones):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::sendPendingNewlyReachedLayoutMilestones): Deleted.
(WebKit::TiledCoreAnimationDrawingArea::dispatchDidReachLayoutMilestone): Deleted.

2:33 PM Changeset in webkit [244290] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: CPU Usage Timeline - Energy impact popover flickers
https://bugs.webkit.org/show_bug.cgi?id=196931
<rdar://problem/49569122>

Reviewed by Devin Rousso.

  • UserInterface/Views/CPUTimelineView.js:

(WI.CPUTimelineView.prototype.initialLayout):

2:30 PM Changeset in webkit [244289] by rniwa@webkit.org
  • 4 edits in trunk

HashTable::removeIf always shrinks the hash table by half even if there is nothing left
https://bugs.webkit.org/show_bug.cgi?id=196681

Reviewed by Darin Adler.

Source/WTF:

Made HashTable::removeIf shrink to the "best size", which is the least power of two bigger
than twice the key count as already used in the copy constructor.

  • wtf/HashTable.h:

(WTF::HashTable::computeBestTableSize): Extracted from the copy constructor.
(WTF::HashTable::shrinkToBestSize): Added.
(WTF::HashTable::removeIf): Use shrinkToBestSize instead of shrink.
(WTF::HashTable::HashTable):

Tools:

Added tests.

  • TestWebKitAPI/Tests/WTF/HashSet.cpp:

(WTF_HashSet.RemoveIf):
(WTF_HashSet.RemoveIfShrinkToBestSize):

2:10 PM Changeset in webkit [244288] by wilander@apple.com
  • 33 edits
    1 move
    6 adds
    1 delete in trunk

Send delayed Ad Click Attribution conversion requests to the click source
https://bugs.webkit.org/show_bug.cgi?id=196838
<rdar://problem/47650157>

Reviewed by Chris Dumez and Youenn Fablet.

Source/WebCore:

WebCore::AdClickAttribution now:

  • Sets m_earliestTimeToSend correctly based on WallTime::now().
  • Allows for a test override of the base URL for conversions.
  • Holds state for whether or not a conversion request has been sent.
  • Outputs m_earliestTimeToSend and m_conversion->hasBeenSent in toString().
  • Returns m_earliestTimeToSend as a result of a call to

convertAndGetEarliestTimeToSend() which used to be called setConversion().

Test: http/tests/adClickAttribution/send-attribution-conversion-request.html

  • loader/AdClickAttribution.cpp:

(WebCore::AdClickAttribution::convertAndGetEarliestTimeToSend):
(WebCore::AdClickAttribution::url const):
(WebCore::AdClickAttribution::urlForTesting const):
(WebCore::AdClickAttribution::markConversionAsSent):
(WebCore::AdClickAttribution::wasConversionSent const):
(WebCore::AdClickAttribution::toString const):
(WebCore::AdClickAttribution::setConversion): Deleted.

Renamed convertAndGetEarliestTimeToSend().

  • loader/AdClickAttribution.h:

(WebCore::AdClickAttribution::Conversion::Conversion):
(WebCore::AdClickAttribution::Conversion::encode const):
(WebCore::AdClickAttribution::Conversion::decode):

  • platform/Timer.h:

Now exports nextFireInterval.

Source/WebKit:

This patch schedules a conversion request with appropriate data going to the
click source as a result of an ad click conversion.

WebKit::AdClickAttributionManager makes use of existing WebKit::PingLoad
infrastructure to make the request. This will probably be reworked into a
dedicated load class further on.

New test infrastructure allows for an override of both the conversion URL
and the 24-48 hour timer.

  • NetworkProcess/AdClickAttributionManager.cpp: Added.

(WebKit::AdClickAttributionManager::ensureDestinationMapForSource):
(WebKit::AdClickAttributionManager::store):
(WebKit::AdClickAttributionManager::startTimer):

Convenience function to support test override.

(WebKit::AdClickAttributionManager::convert):

This function now sets the timer.

(WebKit::AdClickAttributionManager::fireConversionRequest):

Fire an individual request.

(WebKit::AdClickAttributionManager::firePendingConversionRequests):

This is the timer function that iterates over all pending attributions.

(WebKit::AdClickAttributionManager::clear):

Now clears the two new test settings members.

(WebKit::AdClickAttributionManager::toString const):

  • NetworkProcess/AdClickAttributionManager.h: Renamed from Source/WebKit/NetworkProcess/NetworkAdClickAttribution.h.

(WebKit::AdClickAttributionManager::AdClickAttributionManager):
(WebKit::AdClickAttributionManager::setPingLoadFunction):
(WebKit::AdClickAttributionManager::setOverrideTimerForTesting):
(WebKit::AdClickAttributionManager::setConversionURLForTesting):

  • NetworkProcess/NetworkAdClickAttribution.cpp: Renamed from Source/WebKit/NetworkProcess/NetworkAdClickAttribution.cpp.
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::storeAdClickAttribution):
(WebKit::NetworkProcess::dumpAdClickAttribution):
(WebKit::NetworkProcess::clearAdClickAttribution):
(WebKit::NetworkProcess::setAdClickAttributionOverrideTimerForTesting):
(WebKit::NetworkProcess::setAdClickAttributionConversionURLForTesting):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::setAdClickAttributionOverrideTimerForTesting):
(WebKit::NetworkSession::setAdClickAttributionConversionURLForTesting):

  • NetworkProcess/NetworkSession.h:
  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
(WebKit::m_blobFiles):
(WebKit::PingLoad::initialize):

The PingLoad constructor is now split in two to allow for construction
without a WebKit::NetworkConnectionToWebProcess object. The body of
the constructor was moved into the new initialize() function which is
shared between constructors.

  • NetworkProcess/PingLoad.h:
  • Sources.txt:

Removed NetworkProcess/NetworkAdClickAttribution.cpp and added
NetworkProcess/NetworkAdClickAttribution.cpp.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetAdClickAttributionOverrideTimerForTesting):
(WKPageSetAdClickAttributionConversionURLForTesting):

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::dumpAdClickAttribution): Deleted.
(WebKit::NetworkProcessProxy::clearAdClickAttribution): Deleted.

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dumpAdClickAttribution):
(WebKit::WebPageProxy::clearAdClickAttribution):
(WebKit::WebPageProxy::setAdClickAttributionOverrideTimerForTesting):
(WebKit::WebPageProxy::setAdClickAttributionConversionURLForTesting):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::dumpAdClickAttribution): Deleted.
(WebKit::WebProcessPool::clearAdClickAttribution): Deleted.

  • UIProcess/WebProcessPool.h:
  • WebKit.xcodeproj/project.pbxproj:

Tools:

This patch adds test infrastructure to override the default behavior in
WebKit::NetworkAdClickAttribution.

  • TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:

(TestWebKitAPI::TEST):

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::dumpAdClickAttribution):
(WTR::TestRunner::clearAdClickAttribution):
(WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
(WTR::TestRunner::setAdClickAttributionConversionURLForTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
(WTR::TestController::setAdClickAttributionConversionURLForTesting):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

  • http/tests/adClickAttribution/attribution-conversion-through-image-redirect-with-priority-expected.txt:
  • http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority-expected.txt:
  • http/tests/adClickAttribution/resources/conversionFilePath.php: Added.
  • http/tests/adClickAttribution/resources/conversionReport.php: Added.
  • http/tests/adClickAttribution/resources/getConversionData.php: Added.
  • http/tests/adClickAttribution/send-attribution-conversion-request-expected.txt: Added.
  • http/tests/adClickAttribution/send-attribution-conversion-request.html: Added.
1:44 PM Changeset in webkit [244287] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

mergeOSREntryValue is wrong when the incoming value does not match up with the flush format
https://bugs.webkit.org/show_bug.cgi?id=196918

Reviewed by Yusuke Suzuki.

r244238 lead to some debug failures because we were calling checkConsistency()
before doing fixTypeForRepresentation when merging in must handle values in
CFA. This patch fixes that.

However, as I was reading over mergeOSREntryValue, I realized it was wrong. It
was possible it could merge in a value/type outside of the variable's flushed type.
Once the flush format types are locked in, we can't introduce a type out of
that range. This probably never lead to any crashes as our profiling injection
and speculation decision code is solid. However, what we were doing is clearly
wrong, and something a fuzzer could have found if we fuzzed the must handle
values inside prediction injection. We should do that fuzzing:
https://bugs.webkit.org/show_bug.cgi?id=196924

  • dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::mergeOSREntryValue):

  • dfg/DFGAbstractValue.h:
  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::injectOSR):

1:39 PM Changeset in webkit [244286] by rmorisset@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Several structures and enums in the Yarr interpreter can be shrunk
https://bugs.webkit.org/show_bug.cgi?id=196923

Reviewed by Saam Barati.

YarrOp: 88 -> 80
RegularExpression: 40 -> 32
ByteTerm: 56 -> 48
PatternTerm: 56 -> 48

  • yarr/RegularExpression.cpp:
  • yarr/YarrInterpreter.h:
  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::YarrOp::YarrOp):

  • yarr/YarrParser.h:
  • yarr/YarrPattern.h:
1:29 PM Changeset in webkit [244285] by Devin Rousso
  • 3 edits in trunk/Source/JavaScriptCore

Web Inspector: REGRESSION(r244172): crash when trying to add extra domain while inspecting JSContext
https://bugs.webkit.org/show_bug.cgi?id=196925
<rdar://problem/49873994>

Reviewed by Joseph Pecoraro.

Move the logic for creating the InspectorAgent and InspectorDebuggerAgent into separate
functions so that callers can be guaranteed to have a valid instance of the agent.

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::frontendInitialized):
(Inspector::JSGlobalObjectInspectorController::appendExtraAgent):
(Inspector::JSGlobalObjectInspectorController::ensureInspectorAgent): Added.
(Inspector::JSGlobalObjectInspectorController::ensureDebuggerAgent): Added.
(Inspector::JSGlobalObjectInspectorController::createLazyAgents):

1:18 PM Changeset in webkit [244284] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-app] status-bubble should display position in queue
https://bugs.webkit.org/show_bug.cgi?id=196607

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble):
(StatusBubble._queue_position): Method to calculate patch's position in queue.

1:12 PM Changeset in webkit [244283] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-build] Do not run clean build by default on EWS builders
https://bugs.webkit.org/show_bug.cgi?id=196897

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/steps.py:

(ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing
untracked directories like WebKitBuild).
(CheckOutSource.init): Pass method=clean so that Buildbot clean the working directory. This does not remove
untracked files/directories (like WebKitBuild).

12:56 PM Changeset in webkit [244282] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r244268): Canvas: navigation sidebar no longer appears
https://bugs.webkit.org/show_bug.cgi?id=196920
<rdar://problem/49910618>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/ContentBrowserTabContentView.js:

(WI.ContentBrowserTabContentView.prototype.showNavigationSidebarPanel):
Now that we no longer call addSubview when adding a sidebar panel, we can't check to see
if parentSidebar has been set, as that is just an alias for parentView.

12:49 PM Changeset in webkit [244281] by Devin Rousso
  • 2 edits in trunk/Source/WebKit

WebDriver: Set Cookie endpoint does not correctly set subdomain cookies
https://bugs.webkit.org/show_bug.cgi?id=196872
<rdar://problem/49233240>

Reviewed by Joseph Pecoraro.

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::addSingleCookie):
Rather than try to "force" the cookie to be set on the current active URL, use the cookie
itself to figure out which domain it should be set on.

12:46 PM Changeset in webkit [244280] by Devin Rousso
  • 3 edits in trunk/LayoutTests

REGRESSION (r240644): Layout Test inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=194437
<rdar://problem/48008005>

Reviewed by Joseph Pecoraro.

  • inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:
  • inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt:
12:17 PM Changeset in webkit [244279] by Devin Rousso
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: DOMDebugger: move breakpoint storage to use WI.ObjectStore
https://bugs.webkit.org/show_bug.cgi?id=196231
<rdar://problem/49236864>

Reviewed by Joseph Pecoraro.

  • UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager):
(WI.DOMDebuggerManager.prototype.addDOMBreakpoint):
(WI.DOMDebuggerManager.prototype.removeDOMBreakpoint):
(WI.DOMDebuggerManager.prototype.removeDOMBreakpointsForNode):
(WI.DOMDebuggerManager.prototype.addEventBreakpoint):
(WI.DOMDebuggerManager.prototype.removeEventBreakpoint):
(WI.DOMDebuggerManager.prototype.addURLBreakpoint):
(WI.DOMDebuggerManager.prototype.removeURLBreakpoint):
(WI.DOMDebuggerManager.prototype._handleDOMBreakpointDisabledStateChanged):
(WI.DOMDebuggerManager.prototype._handleEventBreakpointDisabledStateChanged):
(WI.DOMDebuggerManager.prototype._handleURLBreakpointDisabledStateChanged):
(WI.DOMDebuggerManager.prototype._saveDOMBreakpoints): Deleted.
(WI.DOMDebuggerManager.prototype._saveEventBreakpoints): Deleted.
(WI.DOMDebuggerManager.prototype._saveURLBreakpoints): Deleted.

  • UserInterface/Models/DOMBreakpoint.js:

(WI.DOMBreakpoint.prototype.saveIdentityToCookie):
(WI.DOMBreakpoint.prototype.toJSON): Added.
(WI.DOMBreakpoint.prototype.get serializableInfo): Deleted.

  • UserInterface/Models/EventBreakpoint.js:

(WI.EventBreakpoint.prototype.saveIdentityToCookie):
(WI.EventBreakpoint.prototype.toJSON): Added.
(WI.EventBreakpoint.prototype.get serializableInfo): Deleted.

  • UserInterface/Models/URLBreakpoint.js:

(WI.URLBreakpoint.prototype.saveIdentityToCookie):
(WI.URLBreakpoint.prototype.toJSON): Added.
(WI.URLBreakpoint.prototype.get serializableInfo): Deleted.
Replace get serializableInfo with toJSON as required by WI.ObjectStore.

  • UserInterface/Base/ObjectStore.js:

(WI.ObjectStore._open):
Increment version.

11:58 AM Changeset in webkit [244278] by Devin Rousso
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: drag/drop over the sidebar should load an imported file in Canvas/Audit tab
https://bugs.webkit.org/show_bug.cgi?id=196873
<rdar://problem/49858190>

Reviewed by Timothy Hatcher.

  • UserInterface/Base/Main.js:

(WI.contentLoaded):
(WI._handleDragOver): Added.
(WI._handleDrop): Added.
(WI._dragOver): Deleted.

  • UserInterface/Views/AuditTabContentView.js:

(WI.AuditTabContentView):
(WI.AuditTabContentView.prototype.async handleFileDrop): Added.
(WI.AuditTabContentView.prototype._handleDragOver): Deleted.
(WI.AuditTabContentView.prototype._handleDrop): Deleted.

  • UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView):
(WI.CanvasTabContentView.prototype.async handleFileDrop): Added.
(WI.CanvasTabContentView.prototype._handleDragOver): Deleted.
(WI.CanvasTabContentView.prototype._handleDrop): Deleted.

  • UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView.prototype.async handleFileDrop): Added.
Check whether the current tab is able to handle a file drop, and if so, don't prevent the
drag from occuring. This now allows the user to drop anywhere on the Web Inspector area to
import files, so long as the relevant tab is currently selected.

  • UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.async processJSON): Added.
(WI.CanvasManager.prototype.processJSON): Deleted.

  • UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype.async processJSON): Added.
(WI.TimelineManager.prototype.processJSON): Deleted.
Make async to match other processJSON functions.

11:56 AM Changeset in webkit [244277] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Regression(r237903) Speedometer 2 is 1-2% regressed on iOS
https://bugs.webkit.org/show_bug.cgi?id=196841
<rdar://problem/45957016>

Reviewed by Myles C. Maxfield.

Speedometer 2 content does not use the text-underline-offset and text-decoration-thickness
features that were added in r237903 so I looked for behavior changes in the context of
Speedometer from r237903. I found that RenderStyle::changeAffectsVisualOverflow() started
returning true a lot more often after r237903. The reason is that r237903 dropped the
visualOverflowForDecorations() checks in this method and started returning true a lot
more as a result.

To restore previous behavior, this patch adds back the visualOverflowForDecorations() checks
that were dropped in r237903. I have verified that with this patch,
RenderStyle::changeAffectsVisualOverflow() returns true as many times as it used to before
r237903.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeAffectsVisualOverflow const):

11:54 AM Changeset in webkit [244276] by Said Abou-Hallawa
  • 3 edits
    2 adds in trunk

ASSERT fires when removing a disallowed clone from the shadow tree without reseting its corresponding element
https://bugs.webkit.org/show_bug.cgi?id=196895

Reviewed by Darin Adler.

Source/WebCore:

When cloning elements to the shadow tree of an SVGUseElement, the
corresponding element links are set from the clones to the originals.
Later some of the elements may be disallowed to exist in the shadow tree.
For example the SVGPatternElement is disallowed and has to be removed
even after cloning. The problem is the corresponding elements are not
reset to null. Usually this is not a problem because the removed elements
will be deleted and the destructor of SVGElement will reset the corresponding
element links. However in some cases, the cloned element is referenced
from another SVGElement, for example the target of a SVGTRefElement. In
this case the clone won't be deleted but it will be linked to the original
and the event listeners won't be copied from the original. When the
original is deleted, its event listeners have to be removed. The event
listeners of the clones also ave to be removed. But because the event
listeners of the original were not copied when cloning, the assertion in
SVGElement::removeEventListener() fires.

Test: svg/custom/use-disallowed-element-clear-corresponding-element.html

  • svg/SVGUseElement.cpp:

(WebCore::disassociateAndRemoveClones):

LayoutTests:

  • svg/custom/use-disallowed-element-clear-corresponding-element-expected.txt: Added.
  • svg/custom/use-disallowed-element-clear-corresponding-element.html: Added.
11:47 AM Changeset in webkit [244275] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Heap: logging an object from a snapshot shouldn't use the "special" style if the object is reachable
https://bugs.webkit.org/show_bug.cgi?id=196889
<rdar://problem/49870693>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:

(WI.HeapSnapshotInstanceDataGridNode.logHeapSnapshotNode):

11:34 AM Changeset in webkit [244274] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Debugger: deleting a special breakpoint should disable it
https://bugs.webkit.org/show_bug.cgi?id=196737
<rdar://problem/49740680>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/BreakpointTreeElement.js:

(WI.BreakpointTreeElement.prototype.ondelete):

11:27 AM Changeset in webkit [244273] by pvollan@apple.com
  • 3 edits in trunk/Tools

TestRunner::notifyDone() should be safely reentrant
https://bugs.webkit.org/show_bug.cgi?id=196898

Reviewed by Darin Adler.

It is currently possible that TestRunner::notifyDone() will call itself, since
notifyDone() will force a repaint, which can start executing JavaScript, which
may call notifyDone() again. This can lead to test failures and flakiness.
Fix this by setting the m_waitToDump flag before calling the dump() method.

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::notifyDone):
(TestRunner::forceImmediateCompletion):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::notifyDone):
(TestRunner::forceImmediateCompletion):

10:36 AM Changeset in webkit [244272] by bshafiei@apple.com
  • 1 edit in branches/safari-607-branch/Source/WebCore/platform/sql/SQLiteDatabase.cpp

Apply patch. rdar://problem/49308059

10:31 AM Changeset in webkit [244271] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: null is not an object (evaluating 'this.selectedTreeElement.reveal')
https://bugs.webkit.org/show_bug.cgi?id=196804
<rdar://problem/49800708>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline.prototype.update):

10:29 AM Changeset in webkit [244270] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: Can't find variable: WebGL2RenderingContext
https://bugs.webkit.org/show_bug.cgi?id=196874
<rdar://problem/49858912>

Reviewed by Timothy Hatcher.

  • UserInterface/Models/Recording.js:

(WI.Recording.prototype.createContext):

  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.prototype.process.getContent):

10:27 AM Changeset in webkit [244269] by Devin Rousso
  • 11 edits
    2 adds in trunk

Web Inspector: DOMDebugger: "Attribute Modified" breakpoints pause after the modification occurs for the style attribute
https://bugs.webkit.org/show_bug.cgi?id=196556
<rdar://problem/49570681>

Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector/dom-debugger/attribute-modified-style.html

  • css/PropertySetCSSStyleDeclaration.h:
  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::StyleAttributeMutationScope::~StyleAttributeMutationScope):
(WebCore::InlineCSSStyleDeclaration::willMutate): Added.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willInvalidateStyleAttr): Added.
(WebCore::InspectorInstrumentation::didInvalidateStyleAttr):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willInvalidateStyleAttrImpl): Added.
(WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):

  • inspector/agents/InspectorDOMAgent.h:
  • inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didInvalidateStyleAttr):

  • inspector/agents/InspectorDOMDebuggerAgent.h:
  • inspector/agents/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::willInvalidateStyleAttr): Added.
(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr): Deleted.

LayoutTests:

  • inspector/dom-debugger/attribute-modified-style.html: Added.
  • inspector/dom-debugger/attribute-modified-style-expected.txt: Added.
10:27 AM Changeset in webkit [244268] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: sidebar panels shouldn't be added as subviews unless visible
https://bugs.webkit.org/show_bug.cgi?id=196888
<rdar://problem/49870659>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/Sidebar.js:

(WI.Sidebar.prototype.insertSidebarPanel):
(WI.Sidebar.prototype.removeSidebarPanel):
(WI.Sidebar.prototype.set selectedSidebarPanel):

10:26 AM Changeset in webkit [244267] by Devin Rousso
  • 8 edits
    2 adds in trunk

Web Inspector: Elements: event listener change events should only be fired for the selected node and it's ancestors
https://bugs.webkit.org/show_bug.cgi?id=196887
<rdar://problem/49870627>

Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector/dom/event-listener-add-remove.html

inspector/dom/event-listener-inspected-node.html

  • inspector/agents/InspectorDOMAgent.h:
  • inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::setInspectedNode):
(WebCore::InspectorDOMAgent::didAddEventListener):
(WebCore::InspectorDOMAgent::willRemoveEventListener):

Source/WebInspectorUI:

  • UserInterface/Models/DOMNode.js:

(WI.DOMNode.prototype.getEventListeners):

LayoutTests:

  • inspector/dom/event-listener-inspected-node.html: Added.
  • inspector/dom/event-listener-inspected-node-expected.txt: Added.
  • inspector/dom/event-listener-add-remove.html:
  • inspector/dom/event-listener-add-remove-expected.txt:
10:24 AM Changeset in webkit [244266] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: replace all uses of this with WI in Main.js/Test.js
https://bugs.webkit.org/show_bug.cgi?id=196795
<rdar://problem/49796618>

Reviewed by Timothy Hatcher.

  • UserInterface/Base/Main.js:
  • UserInterface/Test/Test.js:
10:23 AM Changeset in webkit [244265] by Devin Rousso
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: Heap: snapshots taken manually don't appear in the list
https://bugs.webkit.org/show_bug.cgi?id=196900
<rdar://problem/49880278>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/HeapAllocationsTimelineView.js:

(WI.HeapAllocationsTimelineView):
(WI.HeapAllocationsTimelineView.prototype.layout):
(WI.HeapAllocationsTimelineView.prototype._importButtonNavigationItemClicked):
(WI.HeapAllocationsTimelineView.prototype._takeHeapSnapshotClicked):
Drive-by: only show heap snapshots for the selected range.

  • UserInterface/Views/TimelineView.js:
  • UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView):
(WI.TimelineRecordingContentView.prototype._handleTimelineViewNeedsEntireSelectedRange): Added.
Drive-by: taking (or importing) a heap snapshot should select the entire range so that the
new record will appear in the list of heap snapshots.

10:22 AM Changeset in webkit [244264] by Devin Rousso
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r244157): Timelines: ruler size appears wrong on first layout
https://bugs.webkit.org/show_bug.cgi?id=196901
<rdar://problem/49880539>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/View.js:

(WI.View.prototype._layoutSubtree):
Ensure that the forced override of the layout reason during the initial layout doesn't
affect subviews.

  • UserInterface/Views/ConsoleDrawer.js:

(WI.ConsoleDrawer.prototype.sizeDidChange): Added.
(WI.ConsoleDrawer.prototype.layout): Deleted.

  • UserInterface/Views/ConsolePrompt.js:

(WI.ConsolePrompt.prototype.sizeDidChange): Added.
(WI.ConsolePrompt.prototype.layout): Deleted.

  • UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView.prototype.sizeDidChange): Added.
(WI.DOMTreeContentView.prototype.layout):

  • UserInterface/Views/NavigationBar.js:

(WI.NavigationBar.prototype.sizeDidChange): Added.
(WI.NavigationBar.prototype.layout):
(WI.NavigationBar.prototype._updateContent): Added.
(WI.NavigationBar.prototype._updateContent.forceItemHidden): Added.
(WI.NavigationBar.prototype._updateContent.isDivider): Added.
(WI.NavigationBar.prototype._updateContent.calculateVisibleItemWidth): Added.
(WI.NavigationBar.prototype.layout.forceItemHidden): Deleted.
(WI.NavigationBar.prototype.layout.isDivider): Deleted.
(WI.NavigationBar.prototype.layout.calculateVisibleItemWidth): Deleted.

  • UserInterface/Views/TabBrowser.js:

(WI.TabBrowser.prototype.sizeDidChange): Added.
(WI.TabBrowser.prototype.layout): Deleted.
Move logic in layout to sizeDidChange where applicable.

10:12 AM Changeset in webkit [244263] by Shawn Roberts
  • 2 edits in trunk/LayoutTests

inspector/canvas/recording-webgl-snapshots.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196875

Unreviewed test gardening.

  • platform/mac/TestExpectations: Updating test expectations
10:06 AM Changeset in webkit [244262] by Shawn Roberts
  • 2 edits in trunk/LayoutTests

inspector/timeline/timeline-recording.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196915

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations: Updating test expectations for flaky failure
9:52 AM Changeset in webkit [244261] by Shawn Roberts
  • 2 edits in trunk/LayoutTests

Layout tests
inspector/heap/imported-snapshot.html
inspector/heap/snapshot.html are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=155607

Unreviewed test gardening

  • platform/mac/TestExpectations: Updating expectations for flaky failures
7:41 AM Changeset in webkit [244260] by Philippe Normand
  • 9 edits in trunk

[GTK][WPE] Add enable-media websetting
https://bugs.webkit.org/show_bug.cgi?id=196863

Reviewed by Michael Catanzaro.

Source/WebKit:

It can be useful for headless browsers, for instance. The setting is enabled by default.

  • Shared/WebPreferences.yaml:
  • UIProcess/API/glib/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_media):
(webkit_settings_set_enable_media):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
  • UIProcess/API/wpe/WebKitSettings.h:
  • UIProcess/API/wpe/docs/wpe-1.0-sections.txt:

Tools:

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings): Add test for the enable-media web-setting.

4:49 AM Changeset in webkit [244259] by graouts@webkit.org
  • 2 edits in trunk/Source/WebCore

Ensure iOS layout traits are used for media controls in modern compatibility mode
https://bugs.webkit.org/show_bug.cgi?id=196812
<rdar://problem/47460637>

Unreviewed. Speculative fix for test regressions on open-source bots.

  • Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype.get layoutTraits):

12:43 AM Changeset in webkit [244258] by bshafiei@apple.com
  • 1 edit in branches/safari-607-branch/Source/WebCore/platform/sql/SQLiteDatabase.cpp

Revert r243585. rdar://problem/49894388

12:43 AM Changeset in webkit [244257] by bshafiei@apple.com
  • 9 edits in branches/safari-607-branch/Source

Revert r244131. rdar://problem/49894388

12:43 AM Changeset in webkit [244256] by bshafiei@apple.com
  • 1 edit in branches/safari-607-branch/Source/WebKit/WebProcess/WebProcess.h

Revert r244137. rdar://problem/49894388

12:15 AM Changeset in webkit [244255] by bshafiei@apple.com
  • 2 edits in branches/safari-607-branch/Source/WebKit

Cherry-pick r243487. rdar://problem/49788895

Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
https://bugs.webkit.org/show_bug.cgi?id=196213

Patch by Alex Christensen <achristensen@webkit.org> on 2019-03-25
Reviewed by Geoff Garen.

Source/WebKit:

A release assertion added in r230225 was reachable. I reached it in a unit test that responds to a challenge
with a SecIdentityRef wrapped in an NSCredential.

  • Shared/cf/ArgumentCodersCF.cpp: (IPC::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:15 AM Changeset in webkit [244254] by bshafiei@apple.com
  • 8 edits
    1 add in branches/safari-607-branch/Source

Apply patch. rdar://problem/49836497

12:11 AM Changeset in webkit [244253] by graouts@webkit.org
  • 3 edits
    2 adds in trunk

Ensure iOS layout traits are used for media controls in modern compatibility mode
https://bugs.webkit.org/show_bug.cgi?id=196812
<rdar://problem/47460637>

Reviewed by Dean Jackson.

Source/WebCore:

Test: media/modern-media-controls/media-controller/ios/media-controller-ios-layout-traits-modern-compatibility-mode.html

Instead of looking at the UA string, check whether we support touches which is the correct indicator of whether we should
be using the iOS layout traits for media controls.

  • Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype.get layoutTraits):

LayoutTests:

Add a new test that enforces modern compatibility mode and checks that the iOS controls are used.

  • media/modern-media-controls/media-controller/ios/media-controller-ios-layout-traits-modern-compatibility-mode-expected.txt: Added.
  • media/modern-media-controls/media-controller/ios/media-controller-ios-layout-traits-modern-compatibility-mode.html: Added.

Apr 14, 2019:

11:25 PM Changeset in webkit [244252] by bshafiei@apple.com
  • 7 edits in branches/safari-607-branch/Source

Versioning.

9:47 PM Changeset in webkit [244251] by wenson_hsieh@apple.com
  • 2 edits in trunk/Tools

API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
https://bugs.webkit.org/show_bug.cgi?id=196905
<rdar://problem/49886096>

Reviewed by Tim Horton.

This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
delay timer, we end up with this sequence of events in the problematic (failure) case:

(a) [UI] Run script #1 (which calls HTMLAttachmentElement.getAttachmentIdentifier)

...IPC from UI to web process...

(b) [Web] Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer

...IPC from web to UI process...

(c) [UI] Invoke completion handler for script #1
(d) [UI] Run script #2 (which calls document.querySelector('img').attachmentIdentifier)

...IPC from UI to web process...

(e) [Web] Evaluate script #2 in the web process
(f) [Web] Zero-delay timer fires and dispatches attachment updates to the UI process

...which means that script #2 will complete before the UI process has received the attachment updates sent in
step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
#2 is run in step (e).

This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
the UI process by waiting on a script message posted by the web process, after attachment updates are
dispatched.

  • TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(TestWebKitAPI::TEST):

8:47 PM Changeset in webkit [244250] by Fujii Hironori
  • 2 edits in trunk/LayoutTests

[WinCairo][WKL] Unreviewed test gardening.

  • platform/wincairo-wk1/TestExpectations: Skip animation tests.
5:02 PM Changeset in webkit [244249] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
https://bugs.webkit.org/show_bug.cgi?id=196909

Reviewed by Wenson Hsieh.

  • TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(TestWebKitAPI::TEST):

1:52 PM Changeset in webkit [244248] by commit-queue@webkit.org
  • 17 edits
    8 adds in trunk

Link prefetch not useful for top-level navigation
https://bugs.webkit.org/show_bug.cgi?id=195623

Patch by Rob Buis <rbuis@igalia.com> on 2019-04-14
Reviewed by Youenn Fablet.

Source/WebCore:

Cache cross-domain top-level prefetches in a dedicated cache and not in the
memory cache. Ignore prefetches for content extension checks.

Tests: http/tests/cache/link-prefetch-main-resource-iframe.html

http/tests/cache/link-prefetch-main-resource.html

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::prefetchIfNeeded):

  • loader/ResourceLoadInfo.cpp:

(WebCore::toResourceType):

  • loader/ResourceLoadInfo.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequestInternal):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

Source/WebKit:

Cache cross-domain top-level prefetches in a dedicated cache. When a navigation
to the same url is done within a threshold (5 seconds), reuse the
prefetch cache entry, move it to the disk cache and navigate to
the url, meaning no extra network trip is needed. When not used within
the threshold period, the prefetch entry will be erased using a timer.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::lowMemoryHandler):

  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::prefetchCache):

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didReceiveBuffer):
(WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):
(WebKit::NetworkResourceLoader::isCrossOriginPrefetch const):

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/cache/PrefetchCache.cpp: Added.

(WebKit::PrefetchCache::Entry::Entry):
(WebKit::PrefetchCache::PrefetchCache):
(WebKit::PrefetchCache::~PrefetchCache):
(WebKit::PrefetchCache::clear):
(WebKit::PrefetchCache::take):
(WebKit::PrefetchCache::store):
(WebKit::PrefetchCache::sessionPrefetchMap const):
(WebKit::PrefetchCache::clearExpiredEntries):

  • NetworkProcess/cache/PrefetchCache.h: Added.

(WebKit::PrefetchCache::Entry::response const):
(WebKit::PrefetchCache::Entry::releaseBuffer):

  • Shared/WebPreferences.yaml:
  • Sources.txt:
  • WebKit.xcodeproj/project.pbxproj:

LayoutTests:

Verify that prefetching a cross-domain top-level main resource
is cached in the prefetch cache and only loaded once, and that non
top-level prefetches keep the old behavior.

  • http/tests/cache/link-prefetch-main-resource-expected.txt: Added.
  • http/tests/cache/link-prefetch-main-resource-iframe-expected.txt: Added.
  • http/tests/cache/link-prefetch-main-resource-iframe.html: Added.
  • http/tests/cache/link-prefetch-main-resource.html: Added.
  • http/tests/cache/resources/prefetched-main-resource-iframe.php: Added.
  • http/tests/cache/resources/prefetched-main-resource.php: Added.
  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
1:14 PM Changeset in webkit [244247] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Extract UTI mapping and allow for additions
https://bugs.webkit.org/show_bug.cgi?id=196822
<rdar://problem/49822339>

Reviewed by Darin Adler

Post landing feedback on minimizing String constructors.

  • platform/network/mac/UTIUtilities.mm:

(WebCore::MIMETypeFromUTITree):
(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):

9:08 AM Changeset in webkit [244246] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit

[Cocoa] WKCustomProtocolLoader should store a WeakPtr to its LegacyCustomProtocolManagerProxy
https://bugs.webkit.org/show_bug.cgi?id=196893
<rdar://problem/48318983>

Reviewed by Anders Carlsson.

In addition to manually invalidating each WKCustomProtocolLoader's _customProtocolManagerProxy
pointer when the LegacyCustomProtocolManagerClient is invalidated, use a WeakPtr in case the
LegacyCustomProtocolManagerProxy is ever destroyed without first invalidating the client.
Also add null pointer checks to NSURLConnectionDelegate methods, which might be called after
the LegacyCustomProtocolManagerProxy has been destroyed.

  • UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm:

(-[WKCustomProtocolLoader initWithLegacyCustomProtocolManagerProxy:customProtocolID:request:]):
(-[WKCustomProtocolLoader cancel]):
(-[WKCustomProtocolLoader connection:didFailWithError:]):
(-[WKCustomProtocolLoader connection:didReceiveResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveData:]):
(-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]):
(-[WKCustomProtocolLoader connectionDidFinishLoading:]):
(WebKit::LegacyCustomProtocolManagerClient::startLoading):
(WebKit::LegacyCustomProtocolManagerClient::invalidate):
(-[WKCustomProtocolLoader customProtocolManagerProxyDestroyed]): Deleted.

  • UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h:
6:50 AM Changeset in webkit [244245] by don.olmstead@sony.com
  • 14 edits in trunk

[CMake] JavaScriptCore derived sources should only be referenced inside JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=196742

Reviewed by Konstantin Tokarev.

.:

Migrate to using JavaScriptCore_DERIVED_SOURCES_DIR instead of DERIVED_SOURCES_JAVASCRIPTCORE_DIR
to support moving the JavaScriptCore derived sources outside of a shared directory.
This is in support of the target oriented design refactoring.

WinCairo is explicitly overriding the value as a canary for this setup.

Also move JavaScriptCore_SCRIPTS_DIR to WebKitFS to remove logic setting it in other projects.

  • Source/PlatformWin.cmake:
  • Source/cmake/OptionsAppleWin.cmake:
  • Source/cmake/OptionsWinCairo.cmake:
  • Source/cmake/WebKitFS.cmake:

Source/JavaScriptCore:

Migrate to using JavaScriptCore_DERIVED_SOURCES_DIR instead of DERIVED_SOURCES_JAVASCRIPTCORE_DIR
to support moving the JavaScriptCore derived sources outside of a shared directory.

Also use JavaScriptCore_DERIVED_SOURCES_DIR instead of DERIVED_SOUCES_DIR.

  • CMakeLists.txt:

Source/WebCore:

Don't set JavaScriptCore_SCRIPTS_DIR now that it is set within WebKitFS.

  • CMakeLists.txt:

Source/WebDriver:

Don't set JavaScriptCore_SCRIPTS_DIR now that it is set within WebKitFS.

  • CMakeLists.txt:

Source/WebKit:

Don't set JavaScriptCore_SCRIPTS_DIR now that it is set within WebKitFS.

  • CMakeLists.txt:
  • PlatformWin.cmake:

Remove use of DERIVED_SOURCES_JAVASCRIPTCORE_DIR.

Note: See TracTimeline for information about the timeline view.