Timeline
Jun 29, 2020:
- 11:17 PM Changeset in webkit [263731] by
-
- 3 edits in trunk/LayoutTests
[GTK] Unreviewed test gardening. Failures happening in the EWS GTK-WK2 queue.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- 10:59 PM Changeset in webkit [263730] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed test gardening. Dump JS output of several canvas tests in stderr.
- platform/gtk/TestExpectations:
- 10:56 PM Changeset in webkit [263729] by
-
- 6 edits2 adds in trunk
[Web Animations] REGRESSION: Bootstrap Carousel component v4.1 regressed with Web Animations
https://bugs.webkit.org/show_bug.cgi?id=213376
<rdar://problem/64531242>
Reviewed by Dean Jackson.
Source/WebCore:
An older version of the Bootstrap CSS and JS library had a rather odd way to implement a completion callback
for a transition: it would register a "transitionend" event but also set a timeout of the transition's duration
and use whichever came first as a callback to run completion tasks for the transition.
Additionally, in that callback, it would set the transitioned value to the same computed value but using a different
specified value, for instance setting the "transform" CSS property to "translateX(0)" instead of "translateY(0)".
In our implementation this would make the completed transition repeat. Indeed, we would first incorrectly assume that
the transition was still "running" and not "finished", per the CSS Transitions spec terminology as we only update
that status when we update animations under Page::updateRendering(). We now update an existing transition's
status first in AnimationTimeline::updateCSSTransitionsForElementAndProperty().
Another issue is that when we considered the existing transition to be running, even though it was finished, we would
use the "timeline time at creation" to compute its current progress, which would yield situations where we computed
the before-change style to be the existing transition's current computed value, except that transition's progress was
0 since the "timeline time at creation" happens before the transition's resolved start time. We now only use the
"timeline time at creation" in the situations it was designed to be used: either when the transition has not yet had
a resolved start time, or its resolved start time is the current timeline time (ie. it was just set).
To be able to compare the transition's resolved start time and the current timeline time, we also updated the internal
start time getter and setter methods to use Seconds instead of double which is only needed for the JS bindings.
Test: webanimations/css-transition-retargeting-to-same-value-upon-completion-with-timeout.html
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):
- animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::bindingsStartTime const):
(WebCore::DeclarativeAnimation::setBindingsStartTime):
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::bindingsStartTime const):
(WebCore::WebAnimation::setBindingsStartTime):
(WebCore::WebAnimation::setStartTime):
(WebCore::WebAnimation::startTime const): Deleted.
- animation/WebAnimation.h:
(WebCore::WebAnimation::startTime const):
(WebCore::WebAnimation::bindingsStartTime const): Deleted.
LayoutTests:
Add a test that uses a timeout instead of a "transitionend" event to retarget a transition upon completion
to the same computed value but not the same specified value to check that we generate a transition that has
no visual effect.
- webanimations/css-transition-retargeting-to-same-value-upon-completion-with-timeout-expected.txt: Added.
- webanimations/css-transition-retargeting-to-same-value-upon-completion-with-timeout.html: Added.
- 10:55 PM Changeset in webkit [263728] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r263624): http/tests/quicklook/submit-form-blocked.html fails consistently
https://bugs.webkit.org/show_bug.cgi?id=213767
<rdar://problem/64893698>
Reviewed by Tim Horton.
This test loads a Word document (
.docx) in an iframe, and then taps a JavaScript link in the Word document
that creates a newformelement and attempts to submit it. The test requires a particular error message to be
logged to the console in order to pass (i.e. "Blocked form submission to '<URL>' because the form's frame is
sandboxed and the 'allow-forms' permission is not set.").
After r263624, this message is no longer logged, because the
formelement created by the Word document's
JavaScript link is disconnected from the DOM, and so we bail immediately inHTMLFormElement::submitwithout
ever getting to the security check.
To fix this and make it exercise what it was originally intended to test, we tweak the JavaScript link contained
within the Word document, such that it additionally appends the newly created form element to the document. This
is the modified (percent-decoded) JavaScript URL:
`
(function() {
var form = document.createElement("form");
document.body.appendChild(form);
form.action = "fail.html";
form.innerHTML = '<input type="hidden" name="secret" value="webkit">';
form.submit();
})();
`
This patch simply adds the third line (with the call to
document.body.appendChild).
- http/tests/quicklook/resources/submit-form-blocked.docx:
- http/tests/quicklook/submit-form-blocked.html:
Make sure we also hit-test to the link in the Word document by making the link much bigger, and adjusting the
touch location offset to match.
- 10:43 PM Changeset in webkit [263727] by
-
- 16 edits in trunk
JavaScript cannot be injected into iframes
<rdar://problem/54168946> and https://bugs.webkit.org/show_bug.cgi?id=213556
Reviewed by Geoff Garen.
Source/WebCore:
Covered by API tests.
- bindings/js/ExceptionDetails.h: Start a collection of "exception types" that will grow quickly, beginning with the specialized "missing frame" type.
Source/WebKit:
This adds a few mechanisms:
- Allows for WKUserScripts to have a target content world
- Allows "evaluateJavaScript" and "callAsyncJavaScript" to target a specific frame
- Allows for the completion handlers of those methods to be able to distinguish failure-due-to-missing-frame.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ExceptionDetails>::encode):
(IPC::ArgumentCoder<ExceptionDetails>::decode):
- Shared/WebCoreArgumentCoders.h:
- UIProcess/API/Cocoa/WKError.h:
- UIProcess/API/Cocoa/WKError.mm:
(localizedDescriptionForErrorCode):
- UIProcess/API/Cocoa/WKUserScript.h:
- UIProcess/API/Cocoa/WKUserScript.mm:
(-[WKUserScript initWithSource:injectionTime:forMainFrameOnly:]):
(-[WKUserScript initWithSource:injectionTime:forMainFrameOnly:inContentWorld:]):
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView evaluateJavaScript:inFrame:inContentWorld:completionHandler:]):
(-[WKWebView callAsyncJavaScript:arguments:inFrame:inContentWorld:completionHandler:]):
(nsErrorFromExceptionDetails):
(-[WKWebView _evaluateJavaScript:asAsyncFunction:withSourceURL:withArguments:forceUserGesture:inFrame:inWorld:completionHandler:]):
(-[WKWebView callAsyncJavaScript:arguments:inContentWorld:completionHandler:]): Deleted.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScript):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
- TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
(TEST):
(-[FramesMessageHandler userContentController:didReceiveScriptMessage:]):
- TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[WKWebView objectByCallingAsyncFunction:withArguments:error:]):
- 10:33 PM Changeset in webkit [263726] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out an accidental change from r263723.
- wtf/cf/RunLoopCF.cpp:
(WTF::RunLoop::TimerBase::timerFired):
- 10:10 PM Changeset in webkit [263725] by
-
- 2 edits in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Update baseline after r263673.
- platform/glib/accessibility/aria-hidden-negates-no-visibility-expected.txt:
- 9:39 PM Changeset in webkit [263724] by
-
- 24 edits in trunk/Source
Make _WKWebsiteDataStoreConfiguration SPI for HSTS storage to replace _WKProcessPoolConfiguration.hstsStorageDirectory
https://bugs.webkit.org/show_bug.cgi?id=213048
Patch by Alex Christensen <achristensen@webkit.org> on 2020-06-29
Reviewed by Youenn Fablet.
Source/WebCore/PAL:
- pal/spi/cf/CFNetworkSPI.h:
Source/WebKit:
This uses CFNetwork SPI introduced in rdar://problem/50109631 to allow HSTS storage per NSURLSession.
To be complete, I also deprecated our UI process HSTS state removal attempt SPIs, WKContextResetHSTSHosts and
WKContextResetHSTSHostsAddedAfterDate, which had their last use removed in rdar://problem/64220838.
I manually verified that this new SPI puts HSTS data in the specified location, and I also verified that HSTS
state querying and removal works with the new CFNetwork SPI as it did with the old one.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkSessionCreationParameters.cpp:
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):
- NetworkProcess/NetworkSessionCreationParameters.h:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::hostNamesWithHSTSCache const):
(WebKit::NetworkProcess::deleteHSTSCacheForHostNames):
(WebKit::NetworkProcess::clearHSTSCache):
(WebKit::NetworkProcess::getHostNamesWithHSTSCache): Deleted.
- NetworkProcess/cocoa/NetworkSessionCocoa.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::hstsStorage const):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::hostNamesWithHSTSCache const):
(WebKit::NetworkProcess::deleteHSTSCacheForHostNames):
(WebKit::NetworkProcess::clearHSTSCache):
(WebKit::NetworkProcess::getHostNamesWithHSTSCache): Deleted.
- UIProcess/API/C/mac/WKContextPrivateMac.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextResetHSTSHosts):
(WKContextResetHSTSHostsAddedAfterDate):
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
- UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
- UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:
(-[_WKWebsiteDataStoreConfiguration hstsStorageDirectory]):
(-[_WKWebsiteDataStoreConfiguration setHSTSStorageDirectory:]):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::privateBrowsingSession): Deleted.
(WebKit::WebProcessPool::resetHSTSHosts): Deleted.
(WebKit::WebProcessPool::resetHSTSHostsAddedAfterDate): Deleted.
- UIProcess/WebProcessPool.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
(WebKit::WebsiteDataStore::parameters):
- UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::resolvedHSTSStorageDirectory const):
- UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::copy const):
- UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
Source/WTF:
- wtf/PlatformHave.h:
- 9:25 PM Changeset in webkit [263723] by
-
- 5 edits in trunk/Source/WTF
[GTK] [Win] Build callOnMainThread on WTF::RunLoop rather than on a timer
https://bugs.webkit.org/show_bug.cgi?id=213694
Reviewed by Carlos Garcia Campos.
As of https://bugs.webkit.org/show_bug.cgi?id=213063, Darwin platforms
use the RunLoop. Let's match them for consistency, and to delete some
code.
- wtf/generic/MainThreadGeneric.cpp:
(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::MainThreadDispatcher::MainThreadDispatcher): Deleted.
(WTF::MainThreadDispatcher::schedule): Deleted.
(WTF::MainThreadDispatcher::fired): Deleted.
- wtf/glib/RunLoopSourcePriority.h:
- wtf/win/MainThreadWin.cpp:
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::ThreadingWindowWndProc): Deleted.
- 8:52 PM Changeset in webkit [263722] by
-
- 5 edits in trunk/Source/WebCore
Convert AppCache manifest parser over to using StringParsingBuffer
https://bugs.webkit.org/show_bug.cgi?id=213680
Reviewed by Darin Adler.
- Renames parseManifest to parseApplicationCacheManifest to differentiate between the manifest for the application cache and the "application manifest", which is a different thing entirely. Also renames the container struct from being called Manifest to ApplicationCacheManifest. (The file should be renamed as well, but will do that in a seperate pass).
- Update parser to return an Optional<ApplicationCacheManifest> rather than using bool + out parameter.
- Adopt readCharactersForParsing to replace unnecessary call to StringView::upconvertedCharacters().
- Adopt StringParsingBuffer and ParsingUtilities along with some refinements to the code to make the intent more clear.
- html/parser/ParsingUtilities.h:
(WebCore::skipUntil):
Fix formatting, putting the whole signature on one line.
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
Update for new parser function name and Optional return type.
- loader/appcache/ManifestParser.cpp:
(WebCore::isManifestWhitespace):
(WebCore::isManifestNewline):
(WebCore::isManifestWhitespaceOrNewline):
(WebCore::makeManifestURL):
(WebCore::parseApplicationCacheManifest):
- loader/appcache/ManifestParser.h:
Update parsing logic to use readCharactersForParsing (to avoid upconvesion) and rework
using StringParsingBuffer/ParsingUtilities to make things more clear.
- 8:35 PM Changeset in webkit [263721] by
-
- 2 edits in trunk/Source/WebKit
Adopt adjusted symbol image names
https://bugs.webkit.org/show_bug.cgi?id=213768
<rdar://problem/64472257>
Reviewed by Andy Estes.
- UIProcess/API/Cocoa/_WKElementAction.mm:
(+[_WKElementAction imageForElementActionType:]):
- 8:04 PM Changeset in webkit [263720] by
-
- 3 edits2 adds in trunk
[LFC][TFC] Adjust baseline when the table cell itself establishes an IFC
https://bugs.webkit.org/show_bug.cgi?id=213735
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/layoutformattingcontext/table-cell-baseline-offset-simple2.html
- layout/tableformatting/TableFormattingContextGeometry.cpp:
(WebCore::Layout::TableFormattingContext::Geometry::usedBaselineForCell):
LayoutTests:
- fast/layoutformattingcontext/table-cell-baseline-offset-simple2-expected.html: Added.
- fast/layoutformattingcontext/table-cell-baseline-offset-simple2.html: Added.
- 7:32 PM Changeset in webkit [263719] by
-
- 3 edits2 adds in trunk
[LFC][TFC] Adjust baseline offset for continuation
https://bugs.webkit.org/show_bug.cgi?id=213732
Reviewed by Antti Koivisto.
Source/WebCore:
Skip empty IFC generated for the "pre" part of the continuation (e.g. <span><div>text content</div></span>).
Test: fast/layoutformattingcontext/table-cell-baseline-offset-simple.html
- layout/tableformatting/TableFormattingContextGeometry.cpp:
(WebCore::Layout::TableFormattingContext::Geometry::usedBaselineForCell):
LayoutTests:
- fast/layoutformattingcontext/table-cell-baseline-offset-simple-expected.html: Added.
- fast/layoutformattingcontext/table-cell-baseline-offset-simple.html: Added.
- 6:59 PM Changeset in webkit [263718] by
-
- 9 edits in trunk
Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters
https://bugs.webkit.org/show_bug.cgi?id=213578
Patch by Guowei Yang <guowei_yang@apple.com> on 2020-06-29
.:
Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
Preparing to implement CoreImage backed filter rendering
Needs Compiler guards and experimental feature guard.
- Source/cmake/WebKitFeatures.cmake: added definition of CoreImage-accelerated filter rendering feature flag, ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER
Source/WebCore:
Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
Preparing to implement CoreImage backed filter rendering
Needs Compiler guards and experimental feature guard.
No tests are required because this is just a feature flag set up
- page/Settings.yaml: added default settings for the feature flag. Default value of the feature switch is off
Source/WebKit:
Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
Preparing to implement CoreImage backed filter rendering
Needs Compiler guards and experimental feature guard.
- Shared/WebPreferences.yaml: added feature flag definition
Source/WTF:
Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
Preparing to implement CoreImage backed filter rendering
Needs Compiler guards and experimental feature guard.
- wtf/PlatformEnableCocoa.h: Added definition of a feature flag, ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER
- wtf/PlatformUse.h: Added compiler guard #define USE_CORE_IMAGE 1 to indicate whether CoreImage code is visible to the compiler
- 6:49 PM Changeset in webkit [263717] by
-
- 2 edits in trunk/Source/WebCore
Fix build when !ENABLE(ACCESSIBILITY) after r263673
https://bugs.webkit.org/show_bug.cgi?id=213759
Reviewed by Chris Fleizach.
No new tests, build fix.
- accessibility/AXObjectCache.h:
- 6:36 PM Changeset in webkit [263716] by
-
- 1 copy in tags/Safari-610.1.18.20.2
Tag Safari-610.1.18.20.2.
- 6:34 PM Changeset in webkit [263715] by
-
- 8 edits in branches/safari-610.1.18.20-branch/Source
Versioning.
WebKit-610.1.18.20.2
- 6:33 PM Changeset in webkit [263714] by
-
- 4 edits in trunk/Tools
[TestExpectations] Remove --csv option
https://bugs.webkit.org/show_bug.cgi?id=213762
<rdar://problem/64913762>
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationLine.to_csv): Deleted.
- Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations.init): Remove --csv option.
(PrintExpectations._format_lines): Ditto.
(PrintBaselines.init): Ditto.
(PrintBaselines.execute): Ditto.
(PrintBaselines._print_baselines): Ditto.
- Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.run_test):
(PrintExpectationsTest.test_include):
(PrintBaselinesTest.test_basic):
(PrintBaselinesTest.test_multiple):
(PrintExpectationsTest.test_csv): Deleted.
(PrintBaselinesTest.test_csv): Deleted.
- 6:32 PM Changeset in webkit [263713] by
-
- 4 edits in trunk/Source/WebCore
Simplify Color's interface by removing isDark()
https://bugs.webkit.org/show_bug.cgi?id=213707
Reviewed by Darin Adler.
- Move Color::isDark to RenderThemeIOS.mm, its one client and rename it to useConvexGradient() to indicate what it is actually determining.
- platform/graphics/Color.cpp:
(WebCore::Color::isDark const): Deleted.
- platform/graphics/Color.h:
- rendering/RenderThemeIOS.mm:
(WebCore::useConvexGradient):
(WebCore::RenderThemeIOS::paintPushButtonDecorations):
(WebCore::RenderThemeIOS::paintFileUploadIconDecorations):
- 6:12 PM Changeset in webkit [263712] by
-
- 1 edit46 adds in trunk/PerformanceTests
New API benchmark
https://bugs.webkit.org/show_bug.cgi?id=213750
Reviewed by Saam Barati.
APIBench is a new benchmark suite to measure the performance of the JavaScriptCore API. It has 4 benchmarks:
- RichardsJS: This is imported from Octane and used as a reference so we know how fast the pure JS implementation runs.
- RichardsSwift: a Swift port of the benchmark, also used as reference for how fast the pure Swift implementation is.
- RichardsMostlyJS: As the name suggests, mostly the same the as the JS benchmark, but here the WorkerTask is implemented in Swift. The API is used to write to the packet being processed and talking to the scheduler.
- RichardsMostlySwift: inverse of the above. Mostly the same code from the Swift benchark, but here the WorkerTask is implemented in JavaScript. The API is used to run the JS version of the task and marshaling the Packet by using JSExport.
The benchmark can be built and run using the api-bench script, as following:
PerformanceTests/APIBench/api-bench WebKitBuild/Release
By default, it will build each of the benchmarks and run 5 iterations.
The score is calculated as 5000 / geomean([avg of RichardsMostlySwift, avg of RichardsMostlyJS]).
The script prints the average for the references and tests and the final score:
Results for /Volumes/Data/wk2/OpenSource/WebKitBuild/Release (5 iterations)
================================================================================
References:
RichardsJS: 14ms
RichardsSwift: 29ms
Tests:
RichardsMostlyJS: 218ms
RichardsMostlySwift: 315ms
Score: 19.0804
- APIBench/RichardsJS/RichardsJS.js: Added.
(runRichards):
(Scheduler):
(Scheduler.prototype.addIdleTask):
(Scheduler.prototype.addWorkerTask):
(Scheduler.prototype.addHandlerTask):
(Scheduler.prototype.addDeviceTask):
(Scheduler.prototype.addRunningTask):
(Scheduler.prototype.addTask):
(Scheduler.prototype.schedule):
(Scheduler.prototype.release):
(Scheduler.prototype.holdCurrent):
(Scheduler.prototype.suspendCurrent):
(Scheduler.prototype.queue):
(TaskControlBlock):
(TaskControlBlock.prototype.setRunning):
(TaskControlBlock.prototype.markAsNotHeld):
(TaskControlBlock.prototype.markAsHeld):
(TaskControlBlock.prototype.isHeldOrSuspended):
(TaskControlBlock.prototype.markAsSuspended):
(TaskControlBlock.prototype.markAsRunnable):
(TaskControlBlock.prototype.run):
(TaskControlBlock.prototype.checkPriorityAdd):
(TaskControlBlock.prototype.toString):
(IdleTask):
(IdleTask.prototype.run):
(IdleTask.prototype.toString):
(DeviceTask):
(DeviceTask.prototype.run):
(DeviceTask.prototype.toString):
(WorkerTask):
(WorkerTask.prototype.run):
(WorkerTask.prototype.toString):
(HandlerTask):
(HandlerTask.prototype.run):
(HandlerTask.prototype.toString):
(Packet):
(Packet.prototype.addTo):
(Packet.prototype.toString):
- APIBench/RichardsMostlyJS/RichardsMostlyJS.xcodeproj/project.pbxproj: Added.
- APIBench/RichardsMostlyJS/RichardsMostlyJS.xcodeproj/xcshareddata/xcschemes/RichardsMostlyJS.xcscheme: Added.
- APIBench/RichardsMostlyJS/RichardsMostlyJS/main.swift: Added.
(run(_:)):
(toString):
(WorkerTask.toString):
(WorkerTask.run(_:)):
- APIBench/RichardsMostlyJS/RichardsMostlyJS/richards.js: Added.
(runRichards):
(Scheduler):
(Scheduler.prototype.addIdleTask):
(Scheduler.prototype.addWorkerTask):
(Scheduler.prototype.addHandlerTask):
(Scheduler.prototype.addDeviceTask):
(Scheduler.prototype.addRunningTask):
(Scheduler.prototype.addTask):
(Scheduler.prototype.schedule):
(Scheduler.prototype.release):
(Scheduler.prototype.holdCurrent):
(Scheduler.prototype.suspendCurrent):
(Scheduler.prototype.queue):
(TaskControlBlock):
(TaskControlBlock.prototype.setRunning):
(TaskControlBlock.prototype.markAsNotHeld):
(TaskControlBlock.prototype.markAsHeld):
(TaskControlBlock.prototype.isHeldOrSuspended):
(TaskControlBlock.prototype.markAsSuspended):
(TaskControlBlock.prototype.markAsRunnable):
(TaskControlBlock.prototype.run):
(TaskControlBlock.prototype.checkPriorityAdd):
(TaskControlBlock.prototype.toString):
(IdleTask):
(IdleTask.prototype.run):
(IdleTask.prototype.toString):
(DeviceTask):
(DeviceTask.prototype.run):
(DeviceTask.prototype.toString):
(HandlerTask):
(HandlerTask.prototype.run):
(HandlerTask.prototype.toString):
(Packet):
(Packet.prototype.addTo):
(Packet.prototype.toString):
- APIBench/RichardsMostlySwift/RichardsMostlySwift.xcodeproj/project.pbxproj: Added.
- APIBench/RichardsMostlySwift/RichardsMostlySwift.xcodeproj/xcshareddata/xcschemes/RichardsMostlySwift.xcscheme: Added.
- APIBench/RichardsMostlySwift/RichardsMostlySwift/DeviceTask.swift: Added.
(DeviceTask.create(_:device:priority:)):
(DeviceTask.run(_:)):
- APIBench/RichardsMostlySwift/RichardsMostlySwift/HandlerTask.swift: Added.
(HandlerTask.device):
(HandlerTask.create(_:device:priority:queue:)):
(HandlerTask.run(_:)):
- APIBench/RichardsMostlySwift/RichardsMostlySwift/IdleTask.swift: Added.
(IdleTask.create(_:priority:)):
(IdleTask.run(_:)):
- APIBench/RichardsMostlySwift/RichardsMostlySwift/Packet.swift: Added.
(Packet.addTo(_:)):
- APIBench/RichardsMostlySwift/RichardsMostlySwift/Scheduler.swift: Added.
(waitCurrent):
(handle(_:)):
(Scheduler.schedule):
(Scheduler.add(_:)):
(Scheduler.release_(_:)):
(holdCurrent):
(queue(_:)):
(queueImpl(_:packet:)):
- APIBench/RichardsMostlySwift/RichardsMostlySwift/Task.swift: Added.
(Task.run(_:)):
(Task.release_):
(Task.hold):
(Task.wait):
(Task.resume):
(Task.takePacket):
(Task.checkPriorityAdd(_:packet:)):
- APIBench/RichardsMostlySwift/RichardsMostlySwift/WorkerTask.swift: Added.
(WorkerTask.create(_:priority:queue:)):
(WorkerTask.run(_:)):
- APIBench/RichardsMostlySwift/RichardsMostlySwift/main.swift: Added.
- APIBench/RichardsMostlySwift/RichardsMostlySwift/richards.js: Added.
(return.prototype.run):
- APIBench/RichardsMostlySwift/RichardsMostlySwift/richards.swift: Added.
(runRichards):
- APIBench/RichardsSwift/RichardsSwift.xcodeproj/project.pbxproj: Added.
- APIBench/RichardsSwift/RichardsSwift.xcodeproj/xcshareddata/xcschemes/RichardsSwift.xcscheme: Added.
- APIBench/RichardsSwift/RichardsSwift/DeviceTask.swift: Added.
(DeviceTask.create(_:device:priority:)):
(DeviceTask.run(_:)):
- APIBench/RichardsSwift/RichardsSwift/HandlerTask.swift: Added.
(HandlerTask.device):
(HandlerTask.create(_:device:priority:queue:)):
(HandlerTask.run(_:)):
- APIBench/RichardsSwift/RichardsSwift/IdleTask.swift: Added.
(IdleTask.create(_:priority:)):
(IdleTask.run(_:)):
- APIBench/RichardsSwift/RichardsSwift/Packet.swift: Added.
(Packet.addTo(_:)):
- APIBench/RichardsSwift/RichardsSwift/Scheduler.swift: Added.
(Scheduler.schedule):
(Scheduler.add(_:)):
(Scheduler.release(_:)):
(holdCurrent):
(waitCurrent):
(queue(_:)):
(handle(_:)):
(queueImpl(_:packet:)):
- APIBench/RichardsSwift/RichardsSwift/Task.swift: Added.
(Task.run(_:)):
(Task.release):
(Task.hold):
(Task.wait):
(Task.resume):
(Task.takePacket):
(Task.checkPriorityAdd(_:packet:)):
- APIBench/RichardsSwift/RichardsSwift/WorkerTask.swift: Added.
(WorkerTask.create(_:priority:queue:)):
(WorkerTask.run(_:)):
- APIBench/RichardsSwift/RichardsSwift/main.swift: Added.
- APIBench/RichardsSwift/RichardsSwift/richards.swift: Added.
(runRichards):
- APIBench/api-bench: Added.
- 6:06 PM Changeset in webkit [263711] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for imported/w3c/web-platform-tests/css/css-ui/text-overflow-005.html as it is passing.
https://bugs.webkit.org/show_bug.cgi?id=175290
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- 6:00 PM Changeset in webkit [263710] by
-
- 1 copy in tags/Safari-610.1.18.20.1
Tag Safari-610.1.18.20.1.
- 5:55 PM Changeset in webkit [263709] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for svg/batik/text/textEffect3.svg as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=213760
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- platform/mac/TestExpectations:
- 4:58 PM Changeset in webkit [263708] by
-
- 5 edits in trunk/LayoutTests
[iOS 14] A couple of tests in editing/selection/ios fail after <rdar://problem/60978283>
https://bugs.webkit.org/show_bug.cgi?id=213746
More work towards <rdar://problem/64808138>
Reviewed by Devin Rousso.
The UIKit change in <rdar://problem/60978283> adjusts text interaction behaviors such that a long press gesture
while editing makes a new caret selection, rather than a new word-granularity selection. Tweak a couple of
layout tests in editing/selection/ios that currently assume that long presses while editing will select a word.
- editing/selection/ios/select-text-in-existing-selection-expected.txt:
- editing/selection/ios/select-text-in-existing-selection.html:
This test verifies that the selection can be changed by making a long press inside an existing selection.
However, it now fails after the changes in <rdar://problem/60978283> because it expects the selected text to be
"jumped", but instead, the selection ends up being a caret inside the word "jumped". Tweak this test to verify
that the selection anchors' common ancestor node is the text node with the text "jumped" instead, to handle both
possibilities (where a long press selects a word vs. sets a caret selection).
- editing/selection/ios/selection-extends-into-overflow-area.html:
This test verifies the position and size of a ranged selection made inside content that visibly overflows its
parent container. It now fails because it tries to long press the word to make a selection; instead, use a
double tap gesture to make the word selection.
- resources/ui-helper.js:
(window.UIHelper.doubleTapElement):
Add a new helper method that double taps in the middle of the given element.
(window.UIHelper.callFunctionAndWaitForEvent):
Adjust this helper method to wait for the given function to resolve, if the given function returns a Promise.
- 4:32 PM Changeset in webkit [263707] by
-
- 10 edits2 adds in trunk
Video spills over PiP screen a little when using Picture in Picture
https://bugs.webkit.org/show_bug.cgi?id=213658
Reviewed by Eric Carlson.
Source/WebCore:
We need to provide video content dimensions instead of video element sizes to
AVPlayerController to make sure that the Picture-in-Picture window will have
the correct aspect ratio.
Test: media/picture-in-picture/picture-in-picture-window-aspect-ratio.html
- platform/ios/VideoFullscreenInterfaceAVKit.h:
- platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::setupFullscreen):
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(VideoFullscreenControllerContext::setUpFullscreen):
Source/WebKit:
Add the video content dimensions to the IPC message VideoFullscreenManagerProxy::SetupFullscreenWithID.
- UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
- UIProcess/Cocoa/VideoFullscreenManagerProxy.messages.in:
- UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::setupFullscreenWithID):
(WebKit::VideoFullscreenManagerProxy::setVideoDimensions):
(WebKit::VideoFullscreenManagerProxy::enterFullscreen):
- WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement):
LayoutTests:
- media/picture-in-picture/picture-in-picture-window-aspect-ratio-expected.txt: Added.
- media/picture-in-picture/picture-in-picture-window-aspect-ratio.html: Added.
- 4:31 PM Changeset in webkit [263706] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for svg/W3C-SVG-1.1/fonts-elem-01-t.svg and svg/W3C-SVG-1.1/fonts-elem-02-t.svg and svg/W3C-SVG-1.1/fonts-elem-03-b.svg and svg/W3C-SVG-1.1/fonts-elem-07-b.svg as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=188729
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- platform/mac/TestExpectations:
- 3:55 PM Changeset in webkit [263705] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, reverting r262004.
<rdar://problem/64540215>
Revert r262004 as it is not OK to have a data vault in
TMPDIR.
Reverted changeset:
"[WK2] WebKit abandons compiled sandbox profiles"
https://bugs.webkit.org/show_bug.cgi?id=212177
https://trac.webkit.org/changeset/262004
- 3:50 PM Changeset in webkit [263704] by
-
- 2 edits in branches/safari-610.1.18.20-branch/Source/WebKit
Cherry-pick r263699. rdar://problem/64707000
[iOS] Temporarily open up sandbox for mapping of Launch Services database
https://bugs.webkit.org/show_bug.cgi?id=213756
<rdar://problem/64707000>
Reviewed by Brent Fulgham.
Address review comments.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:50 PM Changeset in webkit [263703] by
-
- 2 edits in branches/safari-610.1.18.20-branch/Source/WebKit
Cherry-pick r263698. rdar://problem/64707000
[iOS] Temporarily open up sandbox for mapping of Launch Services database
https://bugs.webkit.org/show_bug.cgi?id=213756
<rdar://problem/64707000>
Reviewed by Brent Fulgham.
Temporarily open up sandbox for mapping of Launch Services database in the WebContent process on iOS.
This is just a short term fix, and access to the service will be closed again soon.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:47 PM Changeset in webkit [263702] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for media/media-source/media-source-abort-resets-parser.html as it is passing.
https://bugs.webkit.org/show_bug.cgi?id=213755
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- platform/mac/TestExpectations:
- 3:42 PM Changeset in webkit [263701] by
-
- 2 edits in trunk/LayoutTests
[iOS] webanimations/accelerated-animation-with-easing.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=213758
Unreviewed test gardening.
- platform/ios/TestExpectations: Mark test as flaky to speed up EWS.
- 3:40 PM Changeset in webkit [263700] by
-
- 69 edits in trunk
Remove ENABLE_STREAMS_API compilation flag
https://bugs.webkit.org/show_bug.cgi?id=213728
Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-06-29
Reviewed by Sam Weinig.
.:
- Source/cmake/OptionsFTW.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/tools/vsprops/FeatureDefines.props:
Source/JavaScriptCore:
test cases under Scripts/tests/builtins/ does not uses
this removed compilation flag. So we don't have to touch them in this change.
But they are confusable so I plan to fix them in bug 213733.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- Modules/fetch/FetchBody.cpp:
- Modules/fetch/FetchBody.h:
- Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::isDisturbed const):
(WebCore::FetchBodyOwner::isDisturbedOrLocked const):
(WebCore::FetchBodyOwner::blobLoadingSucceeded):
(WebCore::FetchBodyOwner::blobLoadingFailed):
(WebCore::FetchBodyOwner::blobChunk):
- Modules/fetch/FetchBodyOwner.h:
(WebCore::FetchBodyOwner::cancel):
- Modules/fetch/FetchBodySource.cpp:
- Modules/fetch/FetchBodySource.h:
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::BodyLoader::didSucceed):
(WebCore::FetchResponse::BodyLoader::didFail):
(WebCore::FetchResponse::BodyLoader::didReceiveData):
- Modules/fetch/FetchResponse.h:
- Modules/streams/ByteLengthQueuingStrategy.idl:
- Modules/streams/ByteLengthQueuingStrategy.js:
- Modules/streams/CountQueuingStrategy.idl:
- Modules/streams/CountQueuingStrategy.js:
- Modules/streams/ReadableByteStreamController.idl:
- Modules/streams/ReadableByteStreamController.js:
- Modules/streams/ReadableByteStreamInternals.js:
- Modules/streams/ReadableStream.idl:
- Modules/streams/ReadableStream.js:
- Modules/streams/ReadableStreamBYOBReader.idl:
- Modules/streams/ReadableStreamBYOBReader.js:
- Modules/streams/ReadableStreamBYOBRequest.idl:
- Modules/streams/ReadableStreamBYOBRequest.js:
- Modules/streams/ReadableStreamDefaultController.idl:
- Modules/streams/ReadableStreamDefaultController.js:
- Modules/streams/ReadableStreamDefaultReader.idl:
- Modules/streams/ReadableStreamDefaultReader.js:
- Modules/streams/ReadableStreamInternals.js:
- Modules/streams/ReadableStreamSink.cpp:
- Modules/streams/ReadableStreamSink.h:
- Modules/streams/ReadableStreamSink.idl:
- Modules/streams/ReadableStreamSource.cpp:
- Modules/streams/ReadableStreamSource.h:
- Modules/streams/ReadableStreamSource.idl:
- Modules/streams/StreamInternals.js:
- Modules/streams/WritableStream.idl:
- Modules/streams/WritableStream.js:
- Modules/streams/WritableStreamInternals.js:
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::isReadableByteStreamAPIEnabled):
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):
- bindings/js/JSReadableStreamSourceCustom.cpp:
- bindings/js/ReadableStreamDefaultController.cpp:
- bindings/js/ReadableStreamDefaultController.h:
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::writableStreamAPIEnabled const):
- testing/Internals.cpp:
- testing/Internals.h:
- testing/Internals.idl:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
- Shared/WebPreferences.yaml:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WTF:
- wtf/PlatformEnable.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 3:31 PM Changeset in webkit [263699] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Temporarily open up sandbox for mapping of Launch Services database
https://bugs.webkit.org/show_bug.cgi?id=213756
<rdar://problem/64707000>
Reviewed by Brent Fulgham.
Address review comments.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 3:25 PM Changeset in webkit [263698] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Temporarily open up sandbox for mapping of Launch Services database
https://bugs.webkit.org/show_bug.cgi?id=213756
<rdar://problem/64707000>
Reviewed by Brent Fulgham.
Temporarily open up sandbox for mapping of Launch Services database in the WebContent process on iOS.
This is just a short term fix, and access to the service will be closed again soon.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 3:22 PM WebInspectorCodingStyleGuide edited by
- (diff)
- 2:42 PM Changeset in webkit [263697] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for media/fullscreen-api-enabled-media-with-presentation-mode.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=172998
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- platform/mac-wk2/TestExpectations:
- 2:41 PM Changeset in webkit [263696] by
-
- 4 edits in trunk/Source/WebKit
Unreviewed, rebaseline messages.py tests.
- Scripts/MessageNames.cpp:
(IPC::description):
(IPC::receiverName):
(IPC::isValidMessageName):
- Scripts/MessageNames.h:
(WTF::isValidEnum):
- Scripts/test-superclassMessagesReplies.h:
- 2:39 PM Changeset in webkit [263695] by
-
- 3 edits in trunk/Source/WebKit
Crash in NetworkProcessProxy::getNetworkProcessConnection() lambda due to missing Optional<> value check
<https://webkit.org/b/213700>
<rdar://problem/64852903>
Reviewed by Darin Adler.
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::getGPUProcessConnection):
- Rename
connectionIdentifiertoidentifier. - Return early from the lamba if
identifierdoes not contain a value. - UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
- Ditto.
- 2:38 PM Changeset in webkit [263694] by
-
- 1 copy in tags/Safari-610.1.18.4
Tag Safari-610.1.18.4.
- 2:26 PM Changeset in webkit [263693] by
-
- 4 edits in trunk
[iOS] editing/selection/ios/select-text-after-changing-focus.html sometimes fails
https://bugs.webkit.org/show_bug.cgi?id=213745
Work towards <rdar://problem/64808138>
Reviewed by Tim Horton.
Source/WebKit:
This test first taps an input field to focus it, taps a button below the input field to focus the button and
dismiss the keyboard, and finally long presses to select a word below the button. On recent iOS 14 builds, this
test occasionally fails due to recent changes in UIKit that may cause the callout bar appearance callback to
fire after focusing the input field. If this happens, we end up showing the callout bar with a single option to
"Select All" (despite the field being empty), and the subsequent tap that's intended to hit the button instead
hit-tests to this callout bar item. The tests subsequently times out waiting for the keyboard to dismiss, which
never happens because the input field remains focused.
Showing the "Select All" callout bar option in empty text fields is inconsistent with the rest of the platform
(iOS), and appears to have been unintentionally introduced in iOS 12 by <https://trac.webkit.org/r231726>. While
it's still unknown which exact system changes caused this test to begin timing out, we can at least fix it by
addressing this existing regression in behavior.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canPerformActionForWebView:withSender:]):
Check
-hasContenthere, instead of just checking if the selection is a caret. Note that we don't need to check
whether the selection is none separately, since-hasContentwill always returnNOif there is no selection.
Tools:
See WebKit/ChangeLog for more details. If this test happens to be run after another test that has written
something to the pasteboard, it will still fail due to the callout menu showing up with the option to paste.
Mitigate this by clearing the contents of the system pasteboard between tests, such that content copied from
previous tests doesn't change the behavior of subsequent tests.
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetStateToConsistentValues):
- 2:12 PM Changeset in webkit [263692] by
-
- 1 copy in tags/Safari-610.1.15.52.2
Tag Safari-610.1.15.52.2.
- 1:56 PM Changeset in webkit [263691] by
-
- 8 edits in branches/safari-610.1.15.52-branch/Source
Versioning.
WebKit-610.1.15.52.2
- 1:51 PM Changeset in webkit [263690] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter.html as it is passing.
https://bugs.webkit.org/show_bug.cgi?id=177319
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- platform/mac/TestExpectations:
- 1:48 PM Changeset in webkit [263689] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for imported/w3c/web-platform-tests/webrtc/getstats.html as it is passing.
https://bugs.webkit.org/show_bug.cgi?id=172521
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- 1:31 PM Changeset in webkit [263688] by
-
- 25 edits in trunk/Source
Remove remaining makeSimpleColorFrom* variants
https://bugs.webkit.org/show_bug.cgi?id=213706
Reviewed by Darin Adler.
Source/WebCore:
Removed makeSimpleColorFromFloats and makeSimpleColorFromCMYKA.
- Updated callers that need to pass floats to use makeSimpleColor(SRGBA { ... });
- Updated callers that don't need to pass floats, mostly compile time constant SimpleColors to use makeSimpleColor(...), passing in 0-255 based component values.
- Updated callers of makeSimpleColorFromCMYKA to use makeSimpleColor(toSRGBA(CMYKA { ... })). This required adding CMYKA type to ColorTypes.h and moving conversion SRGBA to ColorUtilities with the other color conversion code.
- Added deduction guides for color types to allow component type deduction. This allows us to write:
function(SRGBA { redFloat, greenFloat, blueFloat, alphaFloat })
reather than the more cumbersome:
function(SRGBA<float> { redFloat, greenFloat, blueFloat, alphaFloat })
- Added operator==/operator!= for each color type. Only used by CMYKA at the moment, but generally useful, so added for all of them. For all types convertable to ColorComponents, the implementation uses the conversion to ColorComponents to avoid redundancy.
- html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::setStrokeColor):
(WebCore::CanvasRenderingContext2DBase::setFillColor):
Update to call new typed color based CanvasStyle functions.
(WebCore::CanvasRenderingContext2DBase::setShadow):
Use makeSimpleColor rather than makeSimpleColorFromFloats/makeSimpleColorFromCMYKA.
- html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
Replace constructors taking raw floats with ones taking typed colors (SRGBA<float>/CMYKA<float>)
to make it more clear what the parameters mean.
(WebCore::CanvasStyle::isEquivalentColor const):
Compare the cmyka components using new operator== implementation for CMYKA<float>.
(WebCore::CanvasStyle::isEquivalent const):
(WebCore::CanvasStyle::isEquivalentRGBA const): Deleted.
(WebCore::CanvasStyle::isEquivalentCMYKA const): Deleted.
Replace isEquivalentRGBA/isEquivalentCMYKA with overloaded isEquivalent.
(WebCore::CanvasStyle::applyStrokeColor const):
(WebCore::CanvasStyle::applyFillColor const):
Update for new names of CMYKA members.
- html/canvas/CanvasStyle.h:
Use SRGBA<float> and CMYKA<float> to simplify interfaces
- page/DebugPageOverlays.cpp:
- page/linux/ResourceUsageOverlayLinux.cpp:
(WebCore::ResourceUsageOverlay::platformInitialize):
Use makeSimpleColor rather than makeSimpleColorFromFloats, allowing for
constant expression creation of SimpleColors.
- platform/graphics/Color.cpp:
(WebCore::Color::lightened const):
(WebCore::Color::darkened const):
Use makeSimpleColor(SRGBA { ... }) rather than makeSimpleColorFromFloats.
(WebCore::Color::luminance const):
Fix comment.
(WebCore::blendWithoutPremultiply):
Use makeSimpleColor(...) rather than makeSimpleColorFromFloats.
- platform/graphics/ColorTypes.h:
(WebCore::operator==):
(WebCore::operator!=):
- Add deduction guides and operator==/operator!= for each color type.
- Add CMYKA type. No conversion to ColorComponents yet, as ColorComponents only works with 4 component colors, not ones with 5 like CMYKA.
- platform/graphics/ColorUtilities.cpp:
(WebCore::toSRGBA):
Move conversion from CMYKA to SRGBA from makeSimpleColorFromCMYKA to here.
- platform/graphics/ColorUtilities.h:
(WebCore::convertPrescaledToComponentByte):
(WebCore::convertToComponentByte):
Use std::round rather than std::lroundf, since it will have the same result
and it reads nicer.
- platform/graphics/SimpleColor.cpp:
(WebCore::makeSimpleColorFromCMYKA): Deleted.
- platform/graphics/SimpleColor.h:
(WebCore::makeSimpleColor):
(WebCore::makeSimpleColorFromFloats): Deleted.
- Removed makeSimpleColorFromFloats and makeSimpleColorFromCMYKA.
- Added constexpr overload of makeSimpleColor taking a const SRGBA<uint8_t>&.
- Fixed forward declaration of makeSimpleColor that was taking ColorComponents to actually take an SRGBA<float>, which is what the inline implementation actually takes.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::makeSimpleColorFromARGBCFArray):
- platform/graphics/cairo/GradientCairo.cpp:
(WebCore::interpolateColorStop):
- platform/graphics/cg/ColorCG.cpp:
(WebCore::makeSimpleColorFromCGColor):
- platform/graphics/win/PlatformContextDirect2D.cpp:
(WebCore::PlatformContextDirect2D::brushWithColor):
Use makeSimpleColor(SRGBA { ... }) rather than makeSimpleColorFromFloats.
- platform/graphics/mac/ColorMac.mm:
(WebCore::makeSimpleColorFromNSColor):
- platform/ios/ColorIOS.mm:
(WebCore::colorFromUIColor):
Use makeSimpleColor(SRGBA { ... }) rather than makeSimpleColorFromFloats. Casting to
float is needed, as the input types are CGFloat which is double in 64-bit environments
and won't automatically narrow with the new types.
- platform/ios/LegacyTileCache.mm:
(WebCore::LegacyTileCache::colorForGridTileBorder const):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::beginTransparencyLayers):
Use makeSimpleColor rather than makeSimpleColorFromFloats, allowing for
constant expression creation of SimpleColors.
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintCheckboxDecorations):
(WebCore::RenderThemeIOS::paintRadioDecorations):
(WebCore::RenderThemeIOS::paintMenuListButtonDecorations):
(WebCore::RenderThemeIOS::paintSystemPreviewBadge):
Use Color::black/Color::white.colorWithAlpha(...) rather than makeSimpleColorFromFloats,
allowing for constant expression creation of SimpleColors.
Source/WebKit:
- UIProcess/API/wpe/WebKitColor.cpp:
(webkitColorToWebCoreColor):
Use makeSimpleColor(SRGBA { ... }) rather than makeSimpleColorFromFloats.
- WebProcess/Inspector/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::showPaintRect):
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::drawRect):
Use makeSimpleColor rather than makeSimpleColorFromFloats, allowing for
constant expression creation of SimpleColors.
- 1:24 PM Changeset in webkit [263687] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for imported/w3c/web-platform-tests/css/css-values/ch-unit-004.html and imported/w3c/web-platform-tests/css/css-values/ch-unit-012.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=203333
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- 1:18 PM Changeset in webkit [263686] by
-
- 5 edits in branches/safari-610.1.18.20-branch
Cherry-pick r263630. rdar://problem/64903618
Revert r262654 because it caused <rdar://problem/64664156>.
Moreover it is no longer necessary as the embedding client
changes selection through a different SPI after focusing.
Source/WebKit:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView cleanUpInteraction]): (-[WKContentView _didCommitLoadForMainFrame]): (-[WKContentView _focusTextInputContext:placeCaretAt:completionHandler:]):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: (TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:15 PM Changeset in webkit [263685] by
-
- 8 edits in branches/safari-610.1.18.20-branch/Source
Versioning.
WebKit-610.1.18.20.1
- 1:09 PM Changeset in webkit [263684] by
-
- 2 edits in trunk/Tools
[Win] run-webkit-tests is failing to run DRT and WTR without --architecture x86_64
https://bugs.webkit.org/show_bug.cgi?id=213688
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/port/win.py:
(WinPort._port_flag_for_scripts):
(WinPort._build_path):
(WinPort._ntsd_location):
Replaced self.get_option('architecture') with self.architecture().
- 1:05 PM Changeset in webkit [263683] by
-
- 1 copy in branches/safari-610.1.18.20-branch
New branch.
- 12:56 PM Changeset in webkit [263682] by
-
- 1 copy in branches/safari-610.1.20-branch
New branch.
- 12:38 PM Changeset in webkit [263681] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-010.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=213737
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- platform/mac/TestExpectations:
- 12:28 PM Changeset in webkit [263680] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for imported/w3c/web-platform-tests/css/css-ui/outline-019.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=175288
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- 12:15 PM Changeset in webkit [263679] by
-
- 1 copy in tags/Safari-610.1.18.3.2
Tag Safari-610.1.18.3.2.
- 12:12 PM Changeset in webkit [263678] by
-
- 4 edits in branches/safari-610.1.18-branch/Source/ThirdParty/libwebrtc
Cherry-pick r263375. rdar://problem/64901603
libwebrtc fails to build on arm64
https://bugs.webkit.org/show_bug.cgi?id=213476
Reviewed by Maciej Stachowiak.
- Configurations/libvpx.xcconfig:
- Configurations/libwebrtc.xcconfig:
- Configurations/opus.xcconfig: Use architecture conditionals instead of SDK conditionals for code that is architecture-dependent.
Remove an macOS-version-dependent definition of EXCLUDED_SOURCE_FILE_NAMES
which is no longer used after r232665.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:11 PM Changeset in webkit [263677] by
-
- 8 edits in branches/safari-610.1.18-branch/Source
Versioning.
WebKit-610.1.18.4
- 12:11 PM Changeset in webkit [263676] by
-
- 2 edits in branches/safari-610.1.18.3-branch/Source/WebKit
Cherry-pick r263462. rdar://problem/64897984
Fix the build once RBSProcessLimitations.h is introduced
https://bugs.webkit.org/show_bug.cgi?id=213562
Reviewed by Wenson Hsieh.
- Platform/spi/ios/RunningBoardServicesSPI.h: We can't forward-declare Objective-C SPI if it actually exists without inspiring duplicate definition errors.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:08 PM Changeset in webkit [263675] by
-
- 8 edits in branches/safari-610.1.18.3-branch/Source
Versioning.
WebKit-610.1.18.3.2
- 12:07 PM Changeset in webkit [263674] by
-
- 6 edits in trunk/Source/JavaScriptCore
ConservativeRoots should mark any cell it finds an interior pointer to
https://bugs.webkit.org/show_bug.cgi?id=213686
Reviewed by Yusuke Suzuki.
Currently, if ConserativeRoots finds an interior pointer to a cell
it will only mark that cell if it's a butterfly of some
kind. However, this can cause problems if the C++ or B3 compilers
pre-compute the offset of some cell member they want to load from
after a call. If this happens and that interior pointer is the
only reference to the cell it can get collected while it is still
"alive".
A naive patch that doesn't return from
findGCObjectPointersForMarking after finding a live non-interior,
non-butterfly cell was a 2% regression on Speedometer2 and
JetStream2. So, this patch immediately returns after
marking some non-butterfly cell, which appears to have fixed the
regression locally. Given this was such a big regression (likely
from running MarkedBlock::isLive) more than once there's possibly
an optimization opportunity here. I filed
https://bugs.webkit.org/show_bug.cgi?id=213687 to investigate
further.
- heap/HeapCell.cpp:
(WTF::printInternal):
- heap/HeapCell.h:
(JSC::isJSCellKind):
(JSC::mayHaveIndexingHeader):
(JSC::hasInteriorPointers): Deleted.
- heap/HeapUtil.h:
(JSC::HeapUtil::findGCObjectPointersForMarking):
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::appendJSCellOrAuxiliary):
- runtime/VM.cpp:
(JSC::VM::VM):
- 11:54 AM Changeset in webkit [263673] by
-
- 9 edits2 adds in trunk
AX: aria-modal nodes wrapped in aria-hidden are not honored
https://bugs.webkit.org/show_bug.cgi?id=212849
<rdar://problem/64047019>
Reviewed by Zalan Bujtas.
Source/WebCore:
Test: accessibility/aria-modal-in-aria-hidden.html
If aria-modal was wrapped inside aria-hidden, we were still processing that as the modal node.
Fixing that uncovered a host of very finicky issues related to aria-modal.
- We were processing modal status immediately instead of after a delay, so visibility requirements were not correct.
- In handleModalChange: We were processing multiple modal nodes perhaps incorrectly (the spec doesn't account for multiple modal nodes).
- had to update a test to turn off modal status before adding a new modal node
- Changed the modal node to a WeakPtr
- In isNodeAriaVisible: We stopped processing for visibile with aria-hidden as soon as we hit a renderable block, but that means it won't account for nodes higher in the tree with aria-hidden.
- In handleAttributeChange: if aria-hidden changes, we should update modal status if needed.
- In focusModalNodeTimerFired: we need to verify the element is still live, otherwise it can lead to a crash.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::findModalNodes):
(WebCore::AXObjectCache::currentModalNode):
(WebCore::AXObjectCache::modalNode):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::deferModalChange):
(WebCore::AXObjectCache::focusModalNodeTimerFired):
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::handleModalChange):
(WebCore::AXObjectCache::prepareForDocumentDestruction):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::isNodeAriaVisible):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::handleModalChange):
(WebCore::AXObjectCache::deferModalChange):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::firstChild const):
(WebCore::AccessibilityRenderObject::lastChild const):
LayoutTests:
- accessibility/aria-hidden-negates-no-visibility-expected.txt:
- accessibility/aria-hidden-negates-no-visibility.html:
- accessibility/aria-modal-in-aria-hidden-expected.txt: Added.
- accessibility/aria-modal-in-aria-hidden.html: Added.
- accessibility/aria-modal.html:
- accessibility/mac/aria-modal-auto-focus.html:
- 11:48 AM Changeset in webkit [263672] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for imported/w3c/web-platform-tests/css/css-transitions/before-load-001.html as it is passing.
https://bugs.webkit.org/show_bug.cgi?id=203416
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- platform/mac/TestExpectations:
- 11:32 AM Changeset in webkit [263671] by
-
- 7 edits in trunk
Support MediaRecorder.onstart
https://bugs.webkit.org/show_bug.cgi?id=213720
Reviewed by Darin Adler.
Source/WebCore:
Fire start event if MediaRecorder.start is successful.
Do some WebIDL clean-up, in particular change timeSlice from long to unsigned long, as per spec.
Covered by added test.
- Modules/mediarecorder/MediaRecorder.cpp:
(WebCore::MediaRecorder::startRecording):
- Modules/mediarecorder/MediaRecorder.h:
- Modules/mediarecorder/MediaRecorder.idl:
LayoutTests:
- http/wpt/mediarecorder/MediaRecorder-start-timeSlice-expected.txt:
- http/wpt/mediarecorder/MediaRecorder-start-timeSlice.html:
- 11:27 AM Changeset in webkit [263670] by
-
- 5 edits in trunk/Source/WebKit
Send WebRTC packets received from network process to web process from a background thread
https://bugs.webkit.org/show_bug.cgi?id=213548
Reviewed by Eric Carlson.
Make LibWebRTCSocketClient take a ref to an IPC connection at creation time.
Use this connection from the RTC network thread to send received packets to improve performances.
Covered by existing tests.
- NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:
(WebKit::LibWebRTCSocketClient::LibWebRTCSocketClient):
(WebKit::LibWebRTCSocketClient::signalReadPacket):
(WebKit::LibWebRTCSocketClient::signalSentPacket):
(WebKit::LibWebRTCSocketClient::signalAddressReady):
(WebKit::LibWebRTCSocketClient::signalConnect):
(WebKit::LibWebRTCSocketClient::signalClose):
- NetworkProcess/webrtc/LibWebRTCSocketClient.h:
- NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::createSocket):
(WebKit::NetworkRTCProvider::createUDPSocket):
(WebKit::NetworkRTCProvider::createServerTCPSocket):
(WebKit::NetworkRTCProvider::createClientTCPSocket):
(WebKit::NetworkRTCProvider::wrapNewTCPConnection):
- NetworkProcess/webrtc/NetworkRTCProvider.h:
- 11:08 AM Changeset in webkit [263669] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for imported/w3c/web-platform-tests/css/css-scoping/stylesheet-title-001.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=213736
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- 10:53 AM Changeset in webkit [263668] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed test gardening. Garden tests failing on the EWS GTK-WK2 queue.
- platform/gtk/TestExpectations:
- 10:51 AM Changeset in webkit [263667] by
-
- 1 edit2 adds in trunk/LayoutTests
REGRESSION(r263626): 2 imported/w3c/web-platform-tests/cors/ tests failing constantly
https://bugs.webkit.org/show_bug.cgi?id=213729
Unreviewed test gardening.
Add baselines for Mojave.
- platform/mac-mojave/imported/w3c/web-platform-tests/cors/credentials-flag-expected.txt: Added.
- platform/mac-mojave/imported/w3c/web-platform-tests/cors/origin-expected.txt: Added.
- 10:30 AM Changeset in webkit [263666] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for imported/w3c/web-platform-tests/css/css-lists/counter-increment-inside-display-contents.html and imported/w3c/web-platform-tests/css/css-lists/counter-reset-inside-display-contents.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=213734
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- 10:23 AM Changeset in webkit [263665] by
-
- 7 edits1 copy in trunk/Source/WTF
[WTF] Add more StringView / ASCIILiteral helper functions and add ICUDeleter
https://bugs.webkit.org/show_bug.cgi?id=209774
Reviewed by Ross Kirsling and Darin Adler.
Add ICUDeleter for cleaner ICU object deletion.
Add ICU::majorVersion and ICU::minorVersion to switch the skeleton string in Intl.NumberFormat.
Add more features for ASCIILiteral.
This patch is part of https://bugs.webkit.org/show_bug.cgi?id=209774. I land it separately from
Intl.NumberFormat change to unlock the further Intl implementations using ICUDeleter.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/text/ASCIILiteral.h:
- wtf/text/StringView.cpp:
(WTF::codePointCompare):
- wtf/text/StringView.h:
(WTF::StringView::StringView):
- wtf/unicode/icu/ICUHelpers.cpp: Copied from Source/WTF/wtf/text/ASCIILiteral.h.
(WTF::ICU::version):
(WTF::ICU::majorVersion):
(WTF::ICU::minorVersion):
- wtf/unicode/icu/ICUHelpers.h:
(WTF::ICUDeleter::operator()):
- 10:21 AM Changeset in webkit [263664] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for imported/w3c/web-platform-tests/css/css-display/display-contents-button.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=213731
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- 9:37 AM Changeset in webkit [263663] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for imported/w3c/web-platform-tests/cors/preflight-failure.htm and imported/w3c/web-platform-tests/cors/status-async.htm as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=213730
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-29
- 9:32 AM Changeset in webkit [263662] by
-
- 2 edits in trunk/Source/WebCore
On load from back/forward cache, call checkCompleted() for ALL frames inside FrameLoader::commitProvisionalLoad()
https://bugs.webkit.org/show_bug.cgi?id=213657
Reviewed by Youenn Fablet.
On load from back/forward cache, call checkCompleted() for ALL frames inside FrameLoader::commitProvisionalLoad().
Previously, we were doing it for the main frame in FrameLoader::commitProvisionalLoad() and for subframes in
FrameLoader::open(). Doing it all in one place results in more understandable code and is less error-prone.
Note that calling checkCompleted() for subframes was new in r262221 and is covered by:
fast/history/multiple-back-forward-navigations.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::open):
- 7:38 AM Changeset in webkit [263661] by
-
- 3 edits in trunk/LayoutTests/imported/w3c
REGRESSION(r263626): 2 imported/w3c/web-platform-tests/cors/ tests failing constantly
https://bugs.webkit.org/show_bug.cgi?id=213729
Unreviewed, rebaseline a couple of cors tests after upstream resync in r263626.
- web-platform-tests/cors/credentials-flag-expected.txt:
- web-platform-tests/cors/origin-expected.txt:
- 7:22 AM Changeset in webkit [263660] by
-
- 2 edits in trunk/Tools
run-javascriptcore-tests: Support Apple Silicon running x86 processes
https://bugs.webkit.org/show_bug.cgi?id=213487
<rdar://problem/64606667>
Unreviewed infrastructure fix.
- Scripts/webkitdirs.pm:
(architecturesForProducts): Return architecutre(), not determineArchitecture().
- 5:15 AM Changeset in webkit [263659] by
-
- 8 edits in trunk
[css-flexbox] WebKit mistakenly lets pointer events (click/hover/etc) pass through flex items, if they have negative margin
https://bugs.webkit.org/show_bug.cgi?id=185771
Reviewed by Javier Fernandez.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-flexbox/hittest-overlapping-margin-expected.txt: Replaced FAIL by PASS expectation.
- web-platform-tests/css/css-flexbox/hittest-overlapping-order-expected.txt: Ditto.
Source/WebCore:
When multiple child elements of a flexbox overlap (for example, due to negative margins), the element drawn in the
foreground may not actually capture the hit if the element underneath it is hit-tested despite being occluded.
This is because painting of flexbox children is done in order modified document order instead of raw document order.
In order to achieve this we should inspect flex items in reverse order modified document order. As the OrderIterator
cannot go backwards, we cache the reverse order of items when doing the layout in order to have fast hit testing in
flexbox containers.
As this behaviour is different to the one implemented in RenderBlock a new virtual method to perform hit testing of children
was extracted from RenderBlock:nodeAtPoint() to a new method called RenderBlock::hitTestChildren. The RenderBlock
implementation is identical to the current one but flexbox containers overwrite it.
Two WPT flexbox hittests are passing now thanks to this patch.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hitTestChildren): Implementation of the new virtual method extracted from nodeAtPoint.
(WebCore::RenderBlock::nodeAtPoint): Moved code to hit test children to hitTestChildren()
- rendering/RenderBlock.h: Added hitTestChildren new virtual method.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::hitTestChildren): Implemented.
(WebCore::RenderFlexibleBox::layoutFlexItems): Cache the reverse of the order iterator to be used by hit testing.
- rendering/RenderFlexibleBox.h: Added hitTestChildren.
- 5:06 AM Changeset in webkit [263658] by
-
- 7 edits in trunk
[GStreamer] imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-immediately.https.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=213385
Reviewed by Philippe Normand.
Source/WebCore:
Add a way to release the decryption resources when the player
private is destroyed. That way we can release the secure memory
allocated by libgcrypt and allow for more tests to get, which
caused the crash.
Tests: imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-immediately.https.html.
- platform/encryptedmedia/CDMProxy.h:
(WebCore::CDMProxy::releaseDecryptionResources):
(WebCore::CDMInstanceSessionProxy::releaseDecryptionResources):
(WebCore::CDMInstanceProxy::releaseDecryptionResources):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
- platform/graphics/gstreamer/eme/CDMProxyClearKey.cpp:
(WebCore::CDMProxyClearKey::~CDMProxyClearKey):
(WebCore::CDMProxyClearKey::releaseDecryptionResources):
(WebCore::CDMProxyClearKey::closeGCryptHandle):
- platform/graphics/gstreamer/eme/CDMProxyClearKey.h:
LayoutTests:
- platform/glib/TestExpectations: Removed test from expectations.
- 5:06 AM Changeset in webkit [263657] by
-
- 3 edits1 add in trunk
[webkitpy] PHP7.4 support on Debian platforms
https://bugs.webkit.org/show_bug.cgi?id=213721
Reviewed by Carlos Garcia Campos.
Tools:
- Scripts/webkitpy/port/base.py:
(Port._debian_php_version):
LayoutTests:
- http/conf/debian-httpd-2.4-php7.4.conf: Added.
- 4:50 AM Changeset in webkit [263656] by
-
- 9 edits2 moves in trunk/Source/WebCore
[MSE][GStreamer] Rename MediaSourceGStreamer to MediaSourcePrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=213722
Reviewed by Xabier Rodriguez-Calvar.
It's about time to remove this FIXME:
FIXME: Should this be called MediaSourcePrivateGStreamer?
Yes, it should. Because it's a MediaSourcePrivate, and that is an
important fact. The MSE class diagram is confusing enough already,
let's fix this.
To rebase commits after this change use
git format-patchfirst to
get them in a patch format and then run:
sed -i 's|\<MediaSourceGStreamer\>|MediaSourcePrivateGStreamer|g' *.patch
This patch is a refactor that produces no behavior changes.
- platform/GStreamer.cmake:
- platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::sourceSetup):
- platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
- platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h:
- platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp: Renamed from Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceGStreamer.cpp.
(WebCore::MediaSourcePrivateGStreamer::open):
(WebCore::MediaSourcePrivateGStreamer::MediaSourcePrivateGStreamer):
(WebCore::MediaSourcePrivateGStreamer::~MediaSourcePrivateGStreamer):
(WebCore::MediaSourcePrivateGStreamer::addSourceBuffer):
(WebCore::MediaSourcePrivateGStreamer::removeSourceBuffer):
(WebCore::MediaSourcePrivateGStreamer::durationChanged):
(WebCore::MediaSourcePrivateGStreamer::markEndOfStream):
(WebCore::MediaSourcePrivateGStreamer::unmarkEndOfStream):
(WebCore::MediaSourcePrivateGStreamer::readyState const):
(WebCore::MediaSourcePrivateGStreamer::setReadyState):
(WebCore::MediaSourcePrivateGStreamer::waitForSeekCompleted):
(WebCore::MediaSourcePrivateGStreamer::seekCompleted):
(WebCore::MediaSourcePrivateGStreamer::sourceBufferPrivateDidChangeActiveState):
(WebCore::MediaSourcePrivateGStreamer::buffered):
(WebCore::MediaSourcePrivateGStreamer::logChannel const):
- platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.h: Renamed from Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceGStreamer.h.
- platform/graphics/gstreamer/mse/PlaybackPipeline.h:
- platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
(WebCore::SourceBufferPrivateGStreamer::create):
(WebCore::SourceBufferPrivateGStreamer::SourceBufferPrivateGStreamer):
- platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
- platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
- 4:50 AM Changeset in webkit [263655] by
-
- 9 edits2 adds in trunk
RTCDataChannel.bufferedAmount should stay the same even if channel is closed
https://bugs.webkit.org/show_bug.cgi?id=213698
Reviewed by Darin Adler.
Source/WebCore:
bufferedAmount was set back to zero when closing.
Instead, we should keep the value in RTCDataChannel and update it either when sending data
or being notified or some data getting sent.
Test: webrtc/datachannel/bufferedAmount-afterClose.html
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::bufferedAmountIsDecreasing):
- platform/mock/RTCDataChannelHandlerMock.h:
LayoutTests:
- webrtc/datachannel/bufferedAmount-afterClose-expected.txt: Added.
- webrtc/datachannel/bufferedAmount-afterClose.html: Added.
- 4:31 AM Changeset in webkit [263654] by
-
- 2 edits in trunk/Source/WebCore
checked overflow in WebCore::findClosestFont
https://bugs.webkit.org/show_bug.cgi?id=213719
<rdar://47765225>
Reviewed by David Kilzer.
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::findClosestFont):
If indexOfBestCapabilities doesn't find anything it returns notFound and indexing to the vector overflows.
- 3:54 AM Changeset in webkit [263653] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r262776): Leak of NSMutableURLRequest in -[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]
<https://webkit.org/b/213690>
<rdar://problem/64853619>
Reviewed by Anders Carlsson.
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
- Use RetainPtr<> for the mutable copy and autorelease the return value.
- 3:19 AM Changeset in webkit [263652] by
-
- 2 edits in trunk/Source/WebKit
[GTK] Dark mode for GTK themes that end with -Dark
https://bugs.webkit.org/show_bug.cgi?id=213465
Patch by Elliot <CheeseEBoi@mailo.com> on 2020-06-29
Reviewed by Carlos Garcia Campos.
WebKitGtk has support for automatic detection of dark mode when it comes to GTK themes with the "-dark" and
":dark" suffixes. However, when using GTK themes that end with "-Dark" or ":Dark", this is not the case. This
affects many themes like "Arc" and "Flat-Remix".
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::effectiveAppearanceIsDark const):
(WebKit::PageClientImpl::themeName const):
- 3:10 AM Changeset in webkit [263651] by
-
- 4 edits2 adds in trunk
MediaRecorder.start() Method is Ignoring the "timeslice" Parameter
https://bugs.webkit.org/show_bug.cgi?id=202233
<rdar://problem/55720555>
Reviewed by Eric Carlson.
Source/WebCore:
Use a timer to implement timeSlice parameter.
Schedule timer either when start is called or as part of requestData callback.
This should ensure that, if requestData is called by the application, the timer will be rescheduled appropriately.
Test: http/wpt/mediarecorder/MediaRecorder-start-timeSlice.html
- Modules/mediarecorder/MediaRecorder.cpp:
(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::startRecording):
(WebCore::MediaRecorder::requestData):
- Modules/mediarecorder/MediaRecorder.h:
LayoutTests:
- http/wpt/mediarecorder/MediaRecorder-start-timeSlice-expected.txt: Added.
- http/wpt/mediarecorder/MediaRecorder-start-timeSlice.html: Added.
- 2:50 AM Changeset in webkit [263650] by
-
- 2 edits in trunk/LayoutTests
Unreviewed WPE gardening. Addressing some timeouts and flaky failures.
- platform/wpe/TestExpectations:
- 2:38 AM Changeset in webkit [263649] by
-
- 6 edits in trunk/Tools
REGRESSION(r263625): [WPE][GTK] MiniBrowser output no longer includes stderr and stdout
https://bugs.webkit.org/show_bug.cgi?id=213696
Patch by Philippe Normand <pnormand@igalia.com> on 2020-06-29
Reviewed by Žan Doberšek.
This patch adds a new optional argument to Executive.run_command() to control stdout output.
By default the subprocess.PIPE value is used, to keep backward compatibility. Set the stdout
argument to None to display the output on the terminal tty.
The GTK and WPE run_minibrowser() implementations now use this new argument, along with
setting return_stderr to False to indicate we also want stderr displayed on the terminal
tty.
- Scripts/webkitpy/common/system/abstractexecutive.py:
(AbstractExecutive.run_command):
- Scripts/webkitpy/common/system/executive.py:
(Executive.run_command):
- Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive.run_command):
- Scripts/webkitpy/port/gtk.py:
(GtkPort.run_minibrowser):
- Scripts/webkitpy/port/wpe.py:
(WPEPort.run_minibrowser):
- 2:32 AM Changeset in webkit [263648] by
-
- 2 edits in trunk/Tools
REGRESSION(r263625): run-minibrowser --debug/--release options gone
https://bugs.webkit.org/show_bug.cgi?id=213697
Patch by Philippe Normand <pnormand@igalia.com> on 2020-06-29
Reviewed by Žan Doberšek.
- Scripts/webkitpy/minibrowser/run_webkit_app.py:
(main): Explicitely skip the --target option. Previous code was also skipping --release and
--debug options because theirdestis the same as with the --target option.
- 1:04 AM Changeset in webkit [263647] by
-
- 7 edits in trunk
window.location.replace with invalid urls should throw
https://bugs.webkit.org/show_bug.cgi?id=153121
Patch by Rob Buis <rbuis@igalia.com> on 2020-06-29
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Add a subtest to verify that location.replace throws SyntaxError if
the resulting url is not valid.
- web-platform-tests/html/browsers/history/the-location-interface/location_replace-expected.txt:
- web-platform-tests/html/browsers/history/the-location-interface/location_replace.html:
Source/WebCore:
Throw SyntaxError if the url resulting from the
location.replace operation is not valid.
Behavior matches Firefox and Chrome.
Tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_replace.html
[1] https://html.spec.whatwg.org/multipage/history.html#dom-location-replace
- page/Location.cpp:
(WebCore::Location::replace):
- page/Location.h:
- page/Location.idl:
- 1:00 AM Changeset in webkit [263646] by
-
- 1 edit2 adds in trunk/LayoutTests/imported/w3c
Add a new Web Platform Test in LayoutTest/imported/w3c/web-platform-tests/dom/ranges
https://bugs.webkit.org/show_bug.cgi?id=213667
Patch by Pinki Gyanchandani <pgyanchandani@apple.com> on 2020-06-29
Reviewed by Darin Adler.
Adding a Web Platfotm Test to test the handling of Ranges, when range is associated with a parentless node, and this parentless node moves to
new document.
This test has been provided by Darin Adler.
- web-platform-tests/dom/ranges/Range-adopt-test-expected.txt: Added.
- web-platform-tests/dom/ranges/Range-adopt-test.html: Added.
- 12:39 AM Changeset in webkit [263645] by
-
- 8 edits in trunk
[GTK][WPE] Add webkit_authentication_request_get_security_origin
https://bugs.webkit.org/show_bug.cgi?id=213596
Reviewed by Michael Catanzaro.
Source/WebKit:
Returns the security origin for the authentication protection space.
- UIProcess/API/glib/WebKitAuthenticationRequest.cpp:
(webkit_authentication_request_get_security_origin):
- UIProcess/API/gtk/WebKitAuthenticationRequest.h:
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
- UIProcess/API/wpe/WebKitAuthenticationRequest.h:
- UIProcess/API/wpe/docs/wpe-1.0-sections.txt:
Tools:
Update the unit tests to check the new API.
- TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
(testWebViewAuthenticationRequest):
(testWebViewAuthenticationProxy):
(testWebViewAuthenticationProxyHTTPS):
- 12:23 AM Changeset in webkit [263644] by
-
- 2 edits in trunk/Source/WebKit
[GTK4] Context menu is misaligned
https://bugs.webkit.org/show_bug.cgi?id=213703
Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2020-06-29
Reviewed by Carlos Garcia Campos.
Set halign on the context menu popover to the same value other context menus in GTK use,
like in GtkEntry.
- UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::createMenuWidget): Set halign for the context menu to 'start'.
Jun 28, 2020:
- 8:48 PM Changeset in webkit [263643] by
-
- 2 edits2 adds in trunk/LayoutTests
[GTK][WPE] Add baseline for imported/w3c/web-platform-tests/cors/credentials-flag.htm
Unreviewed test gardening.
The current baseline seems to be based on the Mojave results, where
the last two test cases fail. Let's add a glib baseline with a Pass
expectation with a link to the bug discussing the main expectation.
The added baseline mirrors the current WebKitGTK results from wpt.fyi,
with the two cookie failures.
- platform/glib/TestExpectations:
- platform/glib/imported/w3c/web-platform-tests/cors/credentials-flag-expected.txt: Added.
- 7:15 PM Changeset in webkit [263642] by
-
- 4 edits in trunk/LayoutTests
[GTK][WPE] Merge crypto expectations
Unreviwed test gardening.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- 6:16 PM Changeset in webkit [263641] by
-
- 4 edits in trunk/LayoutTests
[GTK][WPE] Move WebCryptoAPI expectations to glib
Unreviewed test gardening.
Some expectations in the glib file were being overriden by the generic
gtk one marking the tests as Slow.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- 5:03 PM Changeset in webkit [263640] by
-
- 5 edits2 adds in trunk
[LFC][TFC] Adjust table content vertical position to match vertical-align
https://bugs.webkit.org/show_bug.cgi?id=213692
Reviewed by Antti Koivisto.
Source/WebCore:
Child boxes (and runs) are always in the coordinate system of the containing block's border box.
The content box (where the child content lives) is inside the padding box, which is inside the border box.
In order to compute the child box top/left position, we need to know both the padding and the border offsets.
<div style="border: 2px solid green; padding-top: 10px;"><div></div></div>
The inner div's top left position is at [12px, 2px] (let's ignore margin collapsing for now).
Normally by the time we start positioning the child content, we already have computed borders and paddings for the containing block.
This is different with table cells where the final padding offset depends on the content height as we use
the padding box to vertically align the table cell content.
Let's adjust the child boxes and runs to match the new content box position.
Test: fast/layoutformattingcontext/table-cell-vertical-alignment-simple.html
- layout/displaytree/DisplayLineBox.h:
(WebCore::Display::LineBox::moveVertically):
- layout/displaytree/DisplayRun.h:
(WebCore::Display::Run::moveVertically):
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
LayoutTests:
- fast/layoutformattingcontext/table-cell-vertical-alignment-simple-expected.html: Added.
- fast/layoutformattingcontext/table-cell-vertical-alignment-simple.html: Added.
- 5:00 PM Changeset in webkit [263639] by
-
- 2 edits in trunk/Source/WebCore
[LFC][Painting] Use the table section as the paint container for table cells
https://bugs.webkit.org/show_bug.cgi?id=213693
Reviewed by Antti Koivisto.
The cell's containing block is the table box (skipping both the row and the section),
but it's positioned relative to the table section.
Let's skip the row and go right to the section box when painting the cells.
- layout/displaytree/DisplayPainter.cpp:
(WebCore::Display::absoluteDisplayBox):
- 3:49 PM Changeset in webkit [263638] by
-
- 11 edits in trunk
Improve error message for primitive callback interfaces
https://bugs.webkit.org/show_bug.cgi?id=213684
Reviewed by Darin Adler.
Source/WebCore:
This patch rewords TypeError message for non-object callback interfaces
because apart from function, an object with certain method is also allowed.
New error message matches Chrome and Firefox.
Tests: fast/dom/createNodeIterator-parameters.html
fast/dom/createTreeWalker-parameters.html
- bindings/js/JSDOMExceptionHandling.cpp:
(WebCore::throwArgumentMustBeObjectError):
- bindings/js/JSDOMExceptionHandling.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GetArgumentExceptionFunction):
- bindings/scripts/test/*: Updated.
LayoutTests:
- fast/dom/createNodeIterator-parameters-expected.txt:
- fast/dom/createNodeIterator-parameters.html:
- fast/dom/createTreeWalker-parameters-expected.txt:
- fast/dom/createTreeWalker-parameters.html:
- 2:36 PM Changeset in webkit [263637] by
-
- 4 edits in trunk
Setting url.search="??" (two questionmarks) has incorrect behavior
https://bugs.webkit.org/show_bug.cgi?id=170452
Patch by Rob Buis <rbuis@igalia.com> on 2020-06-28
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Update improved test result.
- web-platform-tests/url/url-setters-expected.txt:
Source/WebCore:
There is no need to strip leading "?" character since
URLParser expects it to be there. This differs from the
specification algorithm [1], which relies on state override,
which URLParser does not support.
Behavior matches Firefox and Chrome.
Test: imported/w3c/web-platform-tests/url/url-setters.html
[1] https://url.spec.whatwg.org/#dom-url-search
- html/URLDecomposition.cpp:
(WebCore::URLDecomposition::setSearch):
- 2:34 PM Changeset in webkit [263636] by
-
- 2 edits in trunk/Source/WebKit
Fix thread-safety issue in webProcessPoolHighDynamicRangeDidChangeCallback()
https://bugs.webkit.org/show_bug.cgi?id=213689
<rdar://problem/64443996>
Reviewed by Darin Adler.
webProcessPoolHighDynamicRangeDidChangeCallback() gets called on a background thread so we
need to make sure we dispatch to the main thread before we iterate over the process pools.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::webProcessPoolHighDynamicRangeDidChangeCallback):
- 1:55 PM Changeset in webkit [263635] by
-
- 77 edits in trunk
Rename initializeThreading to initialize
https://bugs.webkit.org/show_bug.cgi?id=213674
Reviewed by Mark Lam.
Source/JavaScriptCore:
- API/JSClassRef.cpp:
- API/JSContextRef.cpp:
(JSContextGroupCreate):
(JSGlobalContextCreate):
(JSGlobalContextCreateInGroup):
- API/JSObjectRef.cpp:
(JSClassCreate):
- API/JSStringRef.cpp:
(JSStringCreateWithCharacters):
(JSStringCreateWithUTF8CString):
(JSStringCreateWithCharactersNoCopy):
- API/JSStringRefCF.cpp:
(JSStringCreateWithCFString):
- API/tests/CompareAndSwapTest.cpp:
(testCompareAndSwap):
- API/tests/ExecutionTimeLimitTest.cpp:
(testExecutionTimeLimit):
- API/tests/FunctionOverridesTest.cpp:
(testFunctionOverrides):
- API/tests/MultithreadedMultiVMExecutionTest.cpp:
(startMultithreadedMultiVMExecutionTest):
- API/tests/PingPongStackOverflowTest.cpp:
(testPingPongStackOverflow):
- JavaScriptCore.order:
- assembler/testmasm.cpp:
(JSC::run):
- b3/air/testair.cpp:
(main):
- b3/testb3_1.cpp:
(main):
- dfg/testdfg.cpp:
(main):
- dynbench.cpp:
(main):
- inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::singleton):
- jsc.cpp:
(main):
(jscmain):
- runtime/InitializeThreading.cpp:
(JSC::initialize):
(JSC::initializeThreading): Deleted.
- runtime/InitializeThreading.h:
- runtime/JSCConfig.h:
- shell/playstation/TestShell.cpp:
(setupTestRun):
- testRegExp.cpp:
(main):
Source/WebCore:
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabase):
- WebCore.order:
- bindings/js/CommonVM.cpp:
(WebCore::commonVMSlow):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::initializeMainThread):
(WebCore::ScriptController::initializeThreading): Deleted.
- bindings/js/ScriptController.h:
- bridge/objc/WebScriptObject.mm:
(+[WebScriptObject initialize]):
- platform/cocoa/SharedBufferCocoa.mm:
(+[WebCoreSharedBufferData initialize]):
- platform/ios/wak/WebCoreThread.mm:
(RunWebThread):
Source/WebKit:
- Shared/API/c/WKString.cpp:
(WKStringCopyJSString):
- Shared/Cocoa/WebKit2InitializeCocoa.mm:
(WebKit::runInitializationCode):
- Shared/WebKit2Initialize.cpp:
(WebKit::InitializeWebKit2):
Source/WebKitLegacy/mac:
- History/WebBackForwardList.mm:
(+[WebBackForwardList initialize]):
- History/WebHistoryItem.mm:
(+[WebHistoryItem initialize]):
- Misc/WebCache.mm:
(+[WebCache initialize]):
- Misc/WebElementDictionary.mm:
(+[WebElementDictionary initialize]):
- Misc/WebIconDatabase.mm:
- Misc/WebStringTruncator.mm:
(+[WebStringTruncator initialize]):
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(+[WebHostedNetscapePluginView initialize]):
- Plugins/WebBaseNetscapePluginView.mm:
- Plugins/WebBasePluginPackage.mm:
(+[WebBasePluginPackage initialize]):
- Plugins/WebNetscapePluginView.mm:
(+[WebNetscapePluginView initialize]):
- WebCoreSupport/WebEditorClient.mm:
(+[WebUndoStep initialize]):
- WebCoreSupport/WebFrameLoaderClient.mm:
(+[WebFramePolicyListener initialize]):
- WebView/WebArchive.mm:
(+[WebArchivePrivate initialize]):
- WebView/WebDataSource.mm:
(+[WebDataSource initialize]):
- WebView/WebHTMLView.mm:
(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
- WebView/WebResource.mm:
(+[WebResourcePrivate initialize]):
- WebView/WebTextIterator.mm:
(+[WebTextIteratorPrivate initialize]):
- WebView/WebView.mm:
(+[WebView initialize]):
- WebView/WebViewData.mm:
(+[WebViewPrivate initialize]):
Source/WebKitLegacy/win:
- WebKitClassFactory.cpp:
(WebKitClassFactory::WebKitClassFactory):
- WebView.cpp:
(WebView::WebView):
Source/WTF:
Reasons:
(1) You need to call it even if you don't use threads.
(2) It initializes things unrelated to threads (like the PRNG).
(3) People seem to get confused about the relationship between
initializeThreading() and initializeMainThread(), and sometimes think
initializeThreading() is a superset. The opposite is true! I think the
confusion may come from "threading" being read as "all threading".
Some filenames still use the legacy name. We can fix that in post.
- benchmarks/ConditionSpeedTest.cpp:
(main):
- benchmarks/HashSetDFGReplay.cpp:
(main):
- benchmarks/LockFairnessTest.cpp:
(main):
- benchmarks/LockSpeedTest.cpp:
(main):
- wtf/MainThread.cpp:
(WTF::initializeMainThread):
- wtf/Threading.cpp:
(WTF::Thread::create):
(WTF::initialize):
(WTF::initializeThreading): Deleted.
- wtf/Threading.h:
(WTF::Thread::current):
Tools:
- TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
(ApplicationManifestParserTest::SetUp):
- TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
(TestWebKitAPI::ComplexTextControllerTest::SetUp):
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::ContentExtensionTest::SetUp):
- TestWebKitAPI/Tests/WebCore/StringUtilities.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
(TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
- TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
(WebKitTestServer::WebKitTestServer):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- 12:16 PM Changeset in webkit [263634] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Clean up visible position comparisons in WebPage::requestDocumentEditingContext()
https://bugs.webkit.org/show_bug.cgi?id=213701
Reviewed by Geoffrey Garen.
Use std::min and std::max when the result needs to be copied instead of doing the comparison
by hand to make the code a tiny bit more clear. Also, don't copy a VisiblePosition when doing
the min/max in-place. Both of these things are unlikely to effect code generation. If they do,
the latter makes things a tiny bit more efficient.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestDocumentEditingContext):
- 8:11 AM Changeset in webkit [263633] by
-
- 16 edits2 adds in trunk
MediaRecorder stopRecorder() returns empty Blob after first use
https://bugs.webkit.org/show_bug.cgi?id=212274
<rdar://problem/63601298>
Reviewed by Eric Carlson.
Source/WebCore:
Refactor code to create/destroy MediaRecorderPrivate on MediaRecorder start/stop.
This allows reusing a MediaRecorder after a stop and restarting with a clean state.
We introduce MediaRecorderPrivate::startRecording to do the initialization,
which allows to fix a potential ref cycle as part of the error callback handling.
Make some improvements to the platform implementation, in particular add default initialization to all fields.
Align the code using AudioConverterRef to what is done in AudioSampleDataSource.
Also call VTCompressionSessionInvalidate when destroying the VideoSampleBufferCompressor.
Test: http/wpt/mediarecorder/MediaRecorder-multiple-start-stop.html
- Modules/mediarecorder/MediaRecorder.cpp:
(WebCore::MediaRecorder::create):
(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::startRecording):
(WebCore::MediaRecorder::stopRecording):
(WebCore::MediaRecorder::requestData):
- Modules/mediarecorder/MediaRecorder.h:
- platform/mediarecorder/MediaRecorderPrivateMock.cpp:
(WebCore::MediaRecorderPrivateMock::fetchData):
- platform/mediarecorder/MediaRecorderPrivate.h:
(WebCore::MediaRecorderPrivate::startRecording):
- platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h:
- platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:
(WebCore::AudioSampleBufferCompressor::~AudioSampleBufferCompressor):
(WebCore::AudioSampleBufferCompressor::initAudioConverterForSourceFormatDescription):
(WebCore::AudioSampleBufferCompressor::attachPrimingTrimsIfNeeded):
(WebCore::AudioSampleBufferCompressor::gradualDecoderRefreshCount):
(WebCore::AudioSampleBufferCompressor::sampleBufferWithNumPackets):
(WebCore::AudioSampleBufferCompressor::processSampleBuffersUntilLowWaterTime):
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::MediaRecorderPrivateWriter::stopRecording):
- platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:
(WebCore::VideoSampleBufferCompressor::~VideoSampleBufferCompressor):
Source/WebKit:
Update implementation to do initialization as part of startRecording.
- GPUProcess/webrtc/RemoteMediaRecorderManager.cpp:
(WebKit::RemoteMediaRecorderManager::releaseRecorder):
Remove ASSERT as recorder creation in WebProcess is always ok while creation in GPUProcess may fail and m_recorders may not be populated.
- WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
(WebKit::MediaRecorderPrivate::MediaRecorderPrivate):
(WebKit::MediaRecorderPrivate::startRecording):
- WebProcess/GPU/webrtc/MediaRecorderPrivate.h:
LayoutTests:
- http/wpt/mediarecorder/MediaRecorder-multiple-start-stop-expected.txt: Added.
- http/wpt/mediarecorder/MediaRecorder-multiple-start-stop.html: Added.
- 4:49 AM Changeset in webkit [263632] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed GTK/WPE Debug build fix after r263589.
- Platform/Logging.h: Define a log category for Memory Pressure.
Jun 27, 2020:
- 10:26 PM Changeset in webkit [263631] by
-
- 3 edits2 adds in trunk
[LFC][IFC] Replaced inline boxes sit on the baseline with their margins
https://bugs.webkit.org/show_bug.cgi?id=213679
Reviewed by Antti Koivisto.
Source/WebCore:
Take the margin box into account when computing the top position of a baseline aligned replaced inline box.
Test: fast/layoutformattingcontext/replaced-box-with-margin-on-baseline.html
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::alignContentVertically):
LayoutTests:
- fast/layoutformattingcontext/replaced-box-with-margin-on-baseline-expected.html: Added.
- fast/layoutformattingcontext/replaced-box-with-margin-on-baseline.html: Added.
- 3:59 PM Changeset in webkit [263630] by
-
- 5 edits in trunk
Revert r262654 because it caused <rdar://problem/64664156>.
Moreover it is no longer necessary as the embedding client
changes selection through a different SPI after focusing.
Source/WebKit:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanUpInteraction]):
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView _focusTextInputContext:placeCaretAt:completionHandler:]):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
(TestWebKitAPI::TEST):
- 3:18 PM Changeset in webkit [263629] by
-
- 5 edits1 copy in trunk/Tools
compare-results should be able to parse multiple JSONs at once by merging them
https://bugs.webkit.org/show_bug.cgi?id=213685
Reviewed by Saam Barati.
This patch improves the compare-results script to enable it to
merge JSON output files. This is handy when running scripts by
hand where you'll get many a and b JSONs. To do the merging this
patch moves the logic of merge-result-jsons into a shared library.
compare-results can take multiple files sequentally or by passing
the '-a'/'-b' flags multiple times. e.g. `/compare-results -a
OG-1.json -a OG-2.json -a OG-3.json -a OG-4.json -b MC-1.json
MC-2.json MC-3.json MC-4.json` will behave as you'd expect;
combining all the OG JSONs and the MC JSONs before computing the
result.
Lastly, the benchmark_results script now can handle duplicates of
an aggregator in the aggregator list. This is useful because
otherwise the logic of merging JSONs is significantly more
complicated.
- Scripts/compare-results:
(getOptions):
(main):
- Scripts/merge-result-jsons:
(readJSONFile):
(deepAppend): Deleted.
(mergeJSONs): Deleted.
- Scripts/webkitpy/benchmark_runner/benchmark_json_merge.py: Copied from Tools/Scripts/merge-result-jsons.
(deepAppend):
(mergeJSONs):
- Scripts/webkitpy/benchmark_runner/benchmark_results.py:
(BenchmarkResults._aggregate_results_for_test):
(BenchmarkResults._lint_subtest_results):
- Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
- 3:14 PM Changeset in webkit [263628] by
-
- 11 edits2 adds in trunk
Fix missing exception check in createIDBKeyFromValue().
https://bugs.webkit.org/show_bug.cgi?id=213681
<rdar://problem/64804893>
Reviewed by Chris Dumez.
Source/WebCore:
Test: storage/indexeddb/missing-exception-check-in-IDBKey.html
Also fixed up miscellaneous other exception check related code to enable the
new test to run with exception check validation.
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
- bindings/js/JSDOMBindingSecurity.cpp:
(WebCore::BindingSecurity::shouldAllowAccessToDOMWindow):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::updateDocument):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::defineOwnProperty):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::initScriptForWindowProxy):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):
(GenerateOperationBodyDefinition):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectExcitingAttrGetter):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunctionBody):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionOverloadedMethodOverloadDispatcher):
- bridge/objc/WebScriptObject.mm:
(-[WebScriptObject _isSafeScript]):
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::injectInternalsObject):
LayoutTests:
- storage/indexeddb/missing-exception-check-in-IDBKey-expected.txt: Added.
- storage/indexeddb/missing-exception-check-in-IDBKey.html: Added.
- 12:31 PM Changeset in webkit [263627] by
-
- 4 edits1 add in trunk
iOS Safari incorrectly reports "AppleCoreMedia" as UA string
https://bugs.webkit.org/show_bug.cgi?id=213245
<rdar://problem/64471582>
Reviewed by Youenn Fablet.
Source/WebCore:
Tests: TestWebKitAPI.MediaLoading.UserAgentStringCRABS
TestWebKitAPI.MediaLoading.UserAgentStringHLS
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:request:]):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm: Added.
(TestWebKitAPI::parseUserAgent):
(TestWebKitAPI::TEST):
- 10:36 AM Changeset in webkit [263626] by
-
- 28 edits1 copy4 adds1 delete in trunk/LayoutTests
Update web-platform-tests/cors from upstream
https://bugs.webkit.org/show_bug.cgi?id=213668
Reviewed by Sam Weinig.
Update web-platform-tests/cors from upstream b076c305a256e7.
LayoutTests/imported/w3c:
- web-platform-tests/cors/*: Updated.
LayoutTests:
- tests-options.json:
- 10:00 AM Changeset in webkit [263625] by
-
- 6 edits1 copy3 adds in trunk/Tools
Migrate run-minibrowser to webkitpy
https://bugs.webkit.org/show_bug.cgi?id=213431
Patch by Philippe Normand <pnormand@igalia.com> on 2020-06-27
Reviewed by Jonathan Bedard.
The perl version was renamed to old-run-minibrowser and remains used by the Mac ports.
run-minibrowser is now a Python script hooking into webkitpy and the Port infrastructure.
Both WPE and GTK ports will now use the pure python implementation.
- Scripts/old-run-minibrowser: Copied from Tools/Scripts/run-minibrowser.
- Scripts/run-minibrowser:
- Scripts/webkitpy/minibrowser/run_minibrowser.py: Added.
(main):
(parse_args):
- Scripts/webkitpy/port/base.py:
(Port.run_minibrowser_arguments):
(Port):
(Port.run_minibrowser):
- Scripts/webkitpy/port/darwin.py:
(DarwinPort.environment_for_api_tests):
(DarwinPort):
(DarwinPort.run_minibrowser_arguments):
- Scripts/webkitpy/port/gtk.py:
(GtkPort.show_results_html_file):
(GtkPort.configuration_for_upload):
(GtkPort):
(GtkPort.run_minibrowser):
- Scripts/webkitpy/port/wpe.py:
(WPEPort.show_results_html_file):
(WPEPort.configuration_for_upload):
(WPEPort):
(WPEPort.run_minibrowser):
- 9:44 AM Changeset in webkit [263624] by
-
- 4 edits in trunk
Require <form> to be connected
https://bugs.webkit.org/show_bug.cgi?id=177356
Patch by Rob Buis <rbuis@igalia.com> on 2020-06-27
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Update improved test result.
- web-platform-tests/html/semantics/forms/form-submission-0/submission-checks.window-expected.txt:
Source/WebCore:
Implement step 1 of [1], i.e. do not submit form if it
is not connected.
Test: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/submission-checks.html
[1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#concept-form-submit
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submit):
- 9:20 AM Changeset in webkit [263623] by
-
- 9 edits in trunk/Source/WebCore
Log capture device information in case of getUserMedia failing to select a device
https://bugs.webkit.org/show_bug.cgi?id=213643
Reviewed by Eric Carlson.
Log constraints and device in case of a failing getUserMedia call.
No obserable change, logging addition.
- platform/mediastream/mac/CoreAudioCaptureDevice.cpp:
(WebCore::getDeviceInfo):
(WebCore::CoreAudioCaptureDevice::deviceClock):
- platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:
(WebCore::isValidCaptureDevice):
- platform/mediastream/MediaConstraints.cpp:
(WebCore::MediaConstraint::log const):
(WebCore::BooleanConstraint::logAsBoolean const):
(WebCore::DoubleConstraint::logAsDouble const):
(WebCore::IntConstraint::logAsInt const):
- platform/mediastream/MediaConstraints.h:
- platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::supportsSizeAndFrameRate):
(WebCore::RealtimeMediaSource::selectSettings):
- platform/mediastream/RealtimeMediaSourceCenter.cpp:
(WebCore::RealtimeMediaSourceCenter::validateRequestConstraints):
- platform/mediastream/RealtimeVideoCaptureSource.cpp:
(WebCore::RealtimeVideoCaptureSource::bestSupportedSizeAndFrameRate):
- platform/mediastream/VideoPreset.h:
(WebCore::VideoPreset::log const):
- 9:13 AM Changeset in webkit [263622] by
-
- 2 edits in trunk/Source/WebCore
Protect SWServer::claim from a registration without active worker
https://bugs.webkit.org/show_bug.cgi?id=213597
Reviewed by Chris Dumez.
SWServerWorker might be active while being terminated.
If terminated as part of SWServerRegistration::clear, the registration no longer has a service worker.
SWServer::claim should therefore check for registration active worker.
This is difficult to test as one needs to claim at the time the service worker is being terminated but not yet terminated.
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::claim):
- 9:08 AM Changeset in webkit [263621] by
-
- 32 edits7 adds in trunk/LayoutTests/imported/w3c
Update web-platform-tests/common from upstream
https://bugs.webkit.org/show_bug.cgi?id=213665
Reviewed by Sam Weinig.
Update web-platform-tests/common from upstream b076c305a256e7fb7.
- web-platform-tests/common/*: Updated.
- 9:07 AM Changeset in webkit [263620] by
-
- 2 edits in trunk/Source/WTF
Improve assertions in StringParsingBuffer
https://bugs.webkit.org/show_bug.cgi?id=213633
Reviewed by Darin Adler.
- wtf/text/StringParsingBuffer.h:
Address additional feedback and improve the assertions by making them more
clear and avoid potential overflows.
- 8:53 AM Changeset in webkit [263619] by
-
- 2 edits in trunk/Source/JavaScriptCore
BytecodeBasicBlock::addSuccessor should check if the successor already exists
https://bugs.webkit.org/show_bug.cgi?id=213670
Reviewed by Yusuke Suzuki.
It makes it nicer for algorithms using BytecodeGraph to not have to consider
whether or not there are duplicates in the successor list. Also, because of
this, bytecode liveness was doing extra work since it walked the successor list,
including any duplicates in it.
- bytecode/BytecodeBasicBlock.h:
(JSC::BytecodeBasicBlock::addSuccessor):
- 8:52 AM Changeset in webkit [263618] by
-
- 5 edits in trunk/Source/JavaScriptCore
Change bytecode dumping to dump the bytecode control flow graph
https://bugs.webkit.org/show_bug.cgi?id=213669
Reviewed by Yusuke Suzuki.
This makes the bytecode control flow graphs much easier to understand, and
puts bytecode dumping in more in line with how we dump other IRs.
The new dumps look like this:
`
foo#Ahf63N:[0x1035bc120->0x1035e5100, NoneFunctionCall, 36]: 13 instructions (0 16-bit instructions, 0 32-bit instructions, 1 instructions with metadata); 156 bytes (120 metadata bytes); 2 parameter(s); 8 callee register(s); 6 variable(s); scope at loc4
bb#1
[ 0] enter
[ 1] get_scope loc4
[ 3] mov loc5, loc4
[ 6] check_traps
[ 7] mov loc6, <JSValue()>(const0)
[ 10] mov loc6, Undefined(const1)
[ 13] mod loc7, arg1, Int32: 2(const2)
[ 17] jfalse loc7, 8(->25)
Successors: [ #3 #2 ]
bb#2
[ 20] mov loc6, Int32: 42(const3)
[ 23] jmp 5(->28)
Successors: [ #4 ]
bb#3
[ 25] mov loc6, Int32: 77(const4)
Successors: [ #4 ]
bb#4
[ 28] add loc7, arg1, loc6, OperandTypes(126, 126)
[ 34] ret loc7
Successors: [ ]
`
- bytecode/BytecodeDumper.cpp:
(JSC::dumpHeader):
(JSC::dumpFooter):
(JSC::CodeBlockBytecodeDumper<Block>::dumpBlock):
(JSC::CodeBlockBytecodeDumper<Block>::dumpGraph):
- bytecode/BytecodeDumper.h:
- bytecode/BytecodeGraph.h:
(JSC::BytecodeGraph::dump):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- 8:29 AM Changeset in webkit [263617] by
-
- 30 edits2 copies3 adds in trunk/Source/WebCore
Convert SVG related parsers over to using StringParsingBuffer
https://bugs.webkit.org/show_bug.cgi?id=213635
Reviewed by Darin Adler.
- Adopt StringParsingBuffer across SVG code.
- Remove UTF-16 upconversions in SVGAnimationElement, SVGFitToViewBox, SVGLengthList, SVGLengthValue, SVGNumberList, SVGParserUtilities, SVGPointList, SVGPreserveAspectRatioValue, SVGStringList, SVGTransformList, SVGTransformable and SVGViewSpec.
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
Export ParsingUtilities.h, which is now included by SVGParserUtilities.h
- Sources.txt:
Add implementation files for SVGLengthList, SVGNumberList, SVGPointList, SVGStringList
and SVGTransformList to hold large functions are unlikely to benefit from inlining.
- html/parser/ParsingUtilities.h:
(WebCore::skipCharactersExactly):
Add new skipCharactersExactly, which takes a c-array (NOT null-terminated) of characters
to compare against.
- svg/SVGAngleValue.cpp:
(WebCore::parseAngleType):
(WebCore::SVGAngleValue::setValueAsString):
Adopt StringParsingBuffer.
- svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::parseAttribute):
Adapt to new shared parseTransformType, which now returns an Optional and default to
SVG_TRANSFORM_UNKNOWN on parse failure as the old parseTransformType did.
- svg/SVGAnimationElement.cpp:
(WebCore::parseKeySplines):
Adopt StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters()
- svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseViewBox):
(WebCore::SVGFitToViewBox::parseViewBoxGeneric):
- svg/SVGFitToViewBox.h:
Adopt StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters()
- svg/SVGLengthList.cpp: Added.
(WebCore::SVGLengthList::parse):
(WebCore::SVGLengthList::valueAsString const):
- svg/SVGLengthList.h:
Adopt StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters(). Move parse and valueAsString out of line.
- svg/SVGLengthValue.cpp:
(WebCore::parseLengthType):
(WebCore::SVGLengthValue::construct):
(WebCore::SVGLengthValue::setValueAsString):
- svg/SVGLengthValue.h:
Adopt StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters()
- svg/SVGNumberList.cpp: Added.
(WebCore::SVGNumberList::parse):
(WebCore::SVGNumberList::valueAsString const):
- svg/SVGNumberList.h:
Adopt StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters(). Move parse and valueAsString out of line.
- svg/SVGParserUtilities.cpp:
(WebCore::genericParseNumber):
(WebCore::parseNumber):
(WebCore::genericParseArcFlag):
(WebCore::parseArcFlag):
(WebCore::parseNumberOptionalNumber):
(WebCore::parsePoint):
(WebCore::parseRect):
(WebCore::parseGlyphName):
(WebCore::parseUnicodeRange):
(WebCore::parseKerningUnicodeString):
(WebCore::genericParseFloatPoint):
(WebCore::parseFloatPoint):
- svg/SVGParserUtilities.h:
(WebCore::isSVGSpaceOrComma):
(WebCore::skipOptionalSVGSpaces):
(WebCore::skipOptionalSVGSpacesOrDelimiter):
(WebCore::skipString): Deleted.
Adopt StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters(). Move parse and valueAsString out of line.
- svg/SVGPathSource.h:
Add missing include, which is now needed do to removing unncessary includes in other files.
- svg/SVGPathStringSource.cpp:
(WebCore::SVGPathStringSource::SVGPathStringSource):
(WebCore::SVGPathStringSource::hasMoreData const):
(WebCore::SVGPathStringSource::moveToNextToken):
(WebCore::nextCommandHelper):
(WebCore::SVGPathStringSource::nextCommand):
(WebCore::SVGPathStringSource::parse):
(WebCore::SVGPathStringSource::parseSVGSegmentType):
(WebCore::SVGPathStringSource::parseMoveToSegment):
(WebCore::SVGPathStringSource::parseLineToSegment):
(WebCore::SVGPathStringSource::parseLineToHorizontalSegment):
(WebCore::SVGPathStringSource::parseLineToVerticalSegment):
(WebCore::SVGPathStringSource::parseCurveToCubicSegment):
(WebCore::SVGPathStringSource::parseCurveToCubicSmoothSegment):
(WebCore::SVGPathStringSource::parseCurveToQuadraticSegment):
(WebCore::SVGPathStringSource::parseCurveToQuadraticSmoothSegment):
(WebCore::SVGPathStringSource::parseArcToSegment):
(WebCore::parseSVGSegmentTypeHelper): Deleted.
- svg/SVGPathStringSource.h:
Adopt StringParsingBuffer. Replace existing set of unions with a single
union of StringParsingBuffers.
- svg/SVGPointList.cpp: Added.
(WebCore::SVGPointList::parse):
(WebCore::SVGPointList::valueAsString const):
- svg/SVGPointList.h:
Adopt StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters(). Move parse and valueAsString out of line.
- svg/SVGPreserveAspectRatioValue.cpp:
(WebCore::SVGPreserveAspectRatioValue::SVGPreserveAspectRatioValue):
(WebCore::SVGPreserveAspectRatioValue::parse):
(WebCore::SVGPreserveAspectRatioValue::parseInternal):
(WebCore::SVGPreserveAspectRatioValue::valueAsString const):
- svg/SVGPreserveAspectRatioValue.h:
Adopt StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters().
- svg/SVGStringList.cpp: Added.
(WebCore::SVGStringList::parse):
(WebCore::SVGStringList::valueAsString const):
- svg/SVGStringList.h:
Adopt StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters(). Move parse and valueAsString out of line.
- svg/SVGTransformList.cpp: Added.
(WebCore::SVGTransformList::consolidate):
(WebCore::SVGTransformList::concatenate const):
(WebCore::SVGTransformList::parseGeneric):
(WebCore::SVGTransformList::parse):
(WebCore::SVGTransformList::valueAsString const):
- svg/SVGTransformList.h:
Adopt StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters(). Move parse, valueAsString, consolidate and
concatenate out of line.
- svg/SVGTransformable.cpp:
(WebCore::parseTransformParamList):
(WebCore::parseTransformValueGeneric):
(WebCore::SVGTransformable::parseTransformValue):
(WebCore::parseTransformTypeGeneric):
(WebCore::SVGTransformable::parseTransformType):
(WebCore::SVGTransformable::parseAndSkipType): Deleted.
- svg/SVGTransformable.h:
Adopt StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters(). Unify parseTransformType implementations to all
use a single implementation and return an Optional<SVGTransformType>.
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::parseViewSpec):
- svg/SVGViewSpec.h:
Adopt StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters().
- svg/SVGZoomAndPan.cpp:
(WebCore::parseZoomAndPanGeneric):
(WebCore::SVGZoomAndPan::parseZoomAndPan):
- svg/SVGZoomAndPan.h:
Adopt StringParsingBuffer.
- 7:18 AM Changeset in webkit [263616] by
-
- 5 edits in trunk
[PlayStation] Update test runner for changes to Options and signing
https://bugs.webkit.org/show_bug.cgi?id=213650
Reviewed by Don Olmstead.
Source/JavaScriptCore:
- shell/playstation/Initializer.cpp: Load ICU library
- shell/playstation/TestShell.cpp: Update between test options reset
Tools:
- Scripts/webkitdirs.pm: Update extension for PlayStation binary
Jun 26, 2020:
- 11:17 PM Changeset in webkit [263615] by
-
- 4 edits3 adds in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Update test expectations after r263609.
- platform/glib/TestExpectations:
- platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.https.any-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_keys.https.any-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.https.worker-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/test_wrapKey_unwrapKey.https-expected.txt:
- 10:25 PM Changeset in webkit [263614] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rename beacon-redirect.window.html to beacon-redirect.sub.window.html in TestExpectations
This needed updating since the test got renamed upstream and we resync'd it recently in r263595.
- 10:21 PM Changeset in webkit [263613] by
-
- 2 edits13 deletes in trunk/LayoutTests
Unreviewed, drop tests that got renamed in r263598 when re-syncing WebCryptAPI tests.
LayoutTests/imported/w3c:
- web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.worker-expected.txt: Removed.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.worker.html: Removed.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker-expected.txt: Removed.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker.html: Removed.
LayoutTests:
- platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.worker-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.worker-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.https.worker-expected.txt: Removed.
- platform/mac/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.worker-expected.txt: Removed.
- platform/mac/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker-expected.txt: Removed.
- 10:14 PM Changeset in webkit [263612] by
-
- 1 edit2 deletes in trunk/LayoutTests/imported/w3c
Unreviewed, drop test that got renamed in r263595.
This test is now called beacon-redirect.sub.window.html.
- web-platform-tests/beacon/beacon-redirect.window-expected.txt: Removed.
- web-platform-tests/beacon/beacon-redirect.window.html: Removed.
- 10:09 PM Changeset in webkit [263611] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed, land iOS-specific baselines after WebCryptoAPI WPT tests resync in r263598.
- platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.worker-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker-expected.txt: Added.
- platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.https.worker-expected.txt: Added.
- 9:37 PM Changeset in webkit [263610] by
-
- 4 edits in trunk/Tools
[webkitpy] Allow callers to override the reported model (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=213677
<rdar://problem/64834043>
Reviewed by Dewei Zhu.
- Scripts/webkitpy/port/base.py:
(Port.configuration_for_upload): Set the model based on --model.
- Scripts/webkitpy/port/factory.py:
(configuration_options): Add --model option, drive-by fix for --architecture.
- Scripts/webkitpy/port/mac.py:
(MacPort.configuration_for_upload): --model overrides detected model.
- 9:20 PM Changeset in webkit [263609] by
-
- 2 edits in trunk/Source/WebKitLegacy/mac
WebSecurityOrigin needs to initialize the main thread
https://bugs.webkit.org/show_bug.cgi?id=213675
Reviewed by Tim Horton.
Safari uses WebSecurityOrigin stand-alone in unit tests.
(And any client can use WebSecurityOrigin without first using other
WebKit data types.)
- WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin initWithURL:]):
- 9:17 PM Changeset in webkit [263608] by
-
- 505 edits3 copies1 move51 adds20 deletes in trunk/JSTests
Update test262
https://bugs.webkit.org/show_bug.cgi?id=213676
Reviewed by Ross Kirsling.
Update and rebaseline expectations.
- test262/expectations.yaml:
- test262/harness/testBigIntTypedArray.js:
(testWithBigIntTypedArrayConstructors):
- test262/harness/testIntl.js:
- test262/harness/testTypedArray.js:
(testWithNonAtomicsFriendlyTypedArrayConstructors):
(testWithAtomicsFriendlyTypedArrayConstructors):
- test262/latest-changes-summary.txt:
- test262/test/annexB/built-ins/Function/createdynfn-no-line-terminator-html-close-comment-body.js:
- test262/test/built-ins/Array/prototype/indexOf/length-zero-returns-minus-one.js: Added.
(fromIndex.valueOf):
- test262/test/built-ins/Array/prototype/lastIndexOf/length-zero-returns-minus-one.js: Added.
(fromIndex.valueOf):
- test262/test/built-ins/Atomics/add/bigint/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/add/bigint/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/add/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/add/non-shared-int-views-throws.js: Added.
- test262/test/built-ins/Atomics/add/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/and/bigint/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/and/bigint/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/and/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/and/non-shared-int-views-throws.js: Added.
- test262/test/built-ins/Atomics/and/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/compareExchange/bigint/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/compareExchange/bigint/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/compareExchange/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/compareExchange/non-shared-int-views-throws.js: Added.
- test262/test/built-ins/Atomics/compareExchange/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/exchange/bigint/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/exchange/bigint/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/exchange/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/exchange/non-shared-int-views-throws.js: Added.
- test262/test/built-ins/Atomics/load/bigint/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/load/bigint/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/load/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/load/non-shared-int-views-throws.js: Added.
- test262/test/built-ins/Atomics/load/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/notify/bigint/non-shared-bufferdata-count-evaluation-throws.js: Added.
(const.poisoned.valueOf):
- test262/test/built-ins/Atomics/notify/bigint/non-shared-bufferdata-index-evaluation-throws.js: Added.
(const.poisoned.valueOf):
- test262/test/built-ins/Atomics/notify/bigint/non-shared-bufferdata-non-shared-int-views-throws.js: Added.
(const.poisoned.valueOf):
- test262/test/built-ins/Atomics/notify/bigint/non-shared-bufferdata-returns-0.js: Added.
- test262/test/built-ins/Atomics/notify/bigint/non-shared-bufferdata-throws.js: Removed.
- test262/test/built-ins/Atomics/notify/non-shared-bufferdata-count-evaluation-throws.js: Added.
(const.poisoned.valueOf):
- test262/test/built-ins/Atomics/notify/non-shared-bufferdata-index-evaluation-throws.js: Added.
(const.poisoned.valueOf):
- test262/test/built-ins/Atomics/notify/non-shared-bufferdata-non-shared-int-views-throws.js: Renamed from JSTests/test262/test/built-ins/Atomics/notify/non-shared-bufferdatate-non-shared-int-views.js.
- test262/test/built-ins/Atomics/notify/non-shared-bufferdata-returns-0.js: Added.
- test262/test/built-ins/Atomics/notify/non-shared-bufferdata-throws.js: Removed.
- test262/test/built-ins/Atomics/or/bigint/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/or/bigint/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/or/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/or/non-shared-int-views-throws.js: Added.
- test262/test/built-ins/Atomics/or/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/store/bigint/bad-range.js:
(testWithBigIntTypedArrayConstructors): Deleted.
- test262/test/built-ins/Atomics/store/bigint/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/store/bigint/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/store/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/store/non-shared-int-views-throws.js: Added.
- test262/test/built-ins/Atomics/store/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/sub/bigint/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/sub/bigint/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/sub/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/sub/non-shared-int-views-throws.js: Added.
- test262/test/built-ins/Atomics/sub/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/wait/bigint/non-shared-bufferdata-throws.js:
- test262/test/built-ins/Atomics/waitAsync/bigint/false-for-timeout.js:
- test262/test/built-ins/Atomics/waitAsync/bigint/good-views.js:
(async const):
- test262/test/built-ins/Atomics/waitAsync/bigint/negative-timeout.js:
(1.value.then):
- test262/test/built-ins/Atomics/waitAsync/bigint/null-for-timeout.js:
- test262/test/built-ins/Atomics/waitAsync/bigint/object-for-timeout.js:
- test262/test/built-ins/Atomics/waitAsync/bigint/true-for-timeout.js:
- test262/test/built-ins/Atomics/waitAsync/bigint/undefined-for-timeout.js:
- test262/test/built-ins/Atomics/waitAsync/bigint/value-not-equal.js:
- test262/test/built-ins/Atomics/waitAsync/false-for-timeout.js:
- test262/test/built-ins/Atomics/waitAsync/good-views.js:
(async const):
- test262/test/built-ins/Atomics/waitAsync/negative-timeout.js:
(then):
- test262/test/built-ins/Atomics/waitAsync/null-for-timeout.js:
- test262/test/built-ins/Atomics/waitAsync/object-for-timeout.js:
- test262/test/built-ins/Atomics/waitAsync/true-for-timeout.js:
- test262/test/built-ins/Atomics/waitAsync/undefined-for-timeout.js:
- test262/test/built-ins/Atomics/waitAsync/value-not-equal.js:
- test262/test/built-ins/Atomics/xor/bigint/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/xor/bigint/nonshared-int-views.js: Removed.
- test262/test/built-ins/Atomics/xor/non-shared-bufferdata.js: Added.
- test262/test/built-ins/Atomics/xor/non-shared-int-views-throws.js: Added.
- test262/test/built-ins/Atomics/xor/nonshared-int-views.js: Removed.
- test262/test/built-ins/NativeErrors/AggregateError/prototype/errors-absent-on-prototype.js: Added.
- test262/test/built-ins/NativeErrors/AggregateError/prototype/errors/invoked-as-accessor.js: Removed.
- test262/test/built-ins/NativeErrors/AggregateError/prototype/errors/invoked-as-func.js: Removed.
- test262/test/built-ins/NativeErrors/AggregateError/prototype/errors/length.js: Removed.
- test262/test/built-ins/NativeErrors/AggregateError/prototype/errors/name.js: Removed.
- test262/test/built-ins/NativeErrors/AggregateError/prototype/errors/prop-desc.js: Removed.
- test262/test/built-ins/NativeErrors/AggregateError/prototype/errors/return-from-iterable-errors.js: Removed.
- test262/test/built-ins/NativeErrors/AggregateError/prototype/errors/return-new-array-from-list.js: Removed.
- test262/test/built-ins/NativeErrors/AggregateError/prototype/errors/this-has-no-typedarrayname-internal.js: Removed.
- test262/test/built-ins/NativeErrors/AggregateError/prototype/errors/this-is-not-object.js: Removed.
- test262/test/built-ins/Object/defineProperties/15.2.3.7-2-18.js:
(catch):
- test262/test/built-ins/Promise/all/S25.4.4.1_A2.2_T1.js:
(then):
- test262/test/built-ins/Promise/all/S25.4.4.1_A7.2_T1.js:
(Promise.all.p1.then):
(p1.then):
(then):
- test262/test/built-ins/Promise/all/S25.4.4.1_A8.1_T1.js:
(p1.then):
(p2.then):
- test262/test/built-ins/Promise/all/invoke-resolve-on-promises-every-iteration-of-custom.js:
(values.then):
- test262/test/built-ins/Promise/all/invoke-resolve-on-promises-every-iteration-of-promise.js:
(Promise.all.values.then):
- test262/test/built-ins/Promise/all/invoke-resolve-on-values-every-iteration-of-promise.js:
(Promise.all.values.then):
- test262/test/built-ins/Promise/allSettled/invoke-resolve-on-promises-every-iteration-of-custom.js:
(values.then):
- test262/test/built-ins/Promise/allSettled/invoke-resolve-on-promises-every-iteration-of-promise.js:
(Promise.allSettled.values.then):
- test262/test/built-ins/Promise/allSettled/invoke-resolve-on-values-every-iteration-of-promise.js:
(Promise.allSettled.values.then):
- test262/test/built-ins/Promise/allSettled/resolved-immed.js:
(then):
- test262/test/built-ins/Promise/allSettled/resolved-sequence-extra-ticks.js:
(Promise.allSettled.p1.then):
(p1.then):
(then):
- test262/test/built-ins/Promise/allSettled/resolved-sequence-mixed.js:
(p1.catch):
(p3.then):
(p2.then):
(p3.catch):
- test262/test/built-ins/Promise/allSettled/resolved-sequence-with-rejections.js:
(p1.catch):
(p2.then):
(p2.catch):
- test262/test/built-ins/Promise/allSettled/resolved-sequence.js:
(p1.then):
(p2.then):
- test262/test/built-ins/Promise/any/invoke-resolve-on-promises-every-iteration-of-custom.js:
(values.then):
- test262/test/built-ins/Promise/any/invoke-resolve-on-promises-every-iteration-of-promise.js:
(Promise.any.values.then):
- test262/test/built-ins/Promise/any/invoke-resolve-on-values-every-iteration-of-custom.js:
(values.then):
- test262/test/built-ins/Promise/any/invoke-resolve-on-values-every-iteration-of-promise.js:
(Promise.any.values.then):
- test262/test/built-ins/Promise/any/invoke-then-on-promises-every-iteration.js:
(Promise.any.promises.then):
- test262/test/built-ins/Promise/any/resolved-sequence-extra-ticks.js:
(Promise.any.p1.then):
(p1.then):
(then):
- test262/test/built-ins/Promise/any/resolved-sequence-mixed.js:
(p1.catch):
(p3.then):
(p2.then):
(p3.catch):
- test262/test/built-ins/Promise/any/resolved-sequence-with-rejections.js:
(p1.catch):
(p2.then):
(p2.catch):
- test262/test/built-ins/Promise/any/resolved-sequence.js:
(p1.then):
(p2.then):
- test262/test/built-ins/Promise/prototype/finally/rejected-observable-then-calls.js:
(then):
- test262/test/built-ins/Promise/prototype/finally/rejection-reason-no-fulfill.js:
(then):
- test262/test/built-ins/Promise/prototype/finally/rejection-reason-override-with-throw.js:
(then):
- test262/test/built-ins/Promise/prototype/finally/resolution-value-no-override.js:
(then):
- test262/test/built-ins/Promise/prototype/finally/resolved-observable-then-calls.js:
(then):
- test262/test/built-ins/Promise/prototype/then/S25.4.4_A1.1_T1.js:
(then):
- test262/test/built-ins/Promise/prototype/then/S25.4.4_A2.1_T1.js:
(then):
- test262/test/built-ins/Promise/prototype/then/S25.4.4_A2.1_T2.js:
(then):
- test262/test/built-ins/Promise/prototype/then/S25.4.4_A2.1_T3.js:
(Promise.resolve.then):
- test262/test/built-ins/Promise/prototype/then/S25.4.5.3_A5.1_T1.js:
(p.then):
(Promise.resolve.then):
- test262/test/built-ins/Promise/prototype/then/S25.4.5.3_A5.2_T1.js:
(p.then):
(Promise.resolve.then):
- test262/test/built-ins/Promise/prototype/then/S25.4.5.3_A5.3_T1.js:
(Promise.resolve.then):
- test262/test/built-ins/Promise/race/S25.4.4.3_A6.1_T1.js:
(p.then):
(Promise.resolve.then):
(then):
- test262/test/built-ins/Promise/race/S25.4.4.3_A6.2_T1.js:
(Promise.resolve.then):
(then):
- test262/test/built-ins/Promise/race/S25.4.4.3_A7.1_T1.js:
(p.then):
(Promise.resolve.then):
(then):
- test262/test/built-ins/Promise/race/S25.4.4.3_A7.1_T2.js:
(p.then):
(Promise.resolve.then):
(then):
- test262/test/built-ins/Promise/race/S25.4.4.3_A7.1_T3.js:
(p.then):
(Promise.resolve.then):
(then):
- test262/test/built-ins/Promise/race/S25.4.4.3_A7.2_T1.js:
(Promise.resolve.then):
(then):
- test262/test/built-ins/Promise/race/invoke-resolve-on-promises-every-iteration-of-custom.js: Copied from JSTests/test262/test/built-ins/Promise/all/invoke-resolve-on-promises-every-iteration-of-custom.js.
(Custom):
(Custom.resolve):
(Promise.resolve):
(values.then):
- test262/test/built-ins/Promise/race/invoke-resolve-on-promises-every-iteration-of-promise.js: Copied from JSTests/test262/test/built-ins/Promise/all/invoke-resolve-on-promises-every-iteration-of-promise.js.
(Promise.resolve):
(Promise.race.values.then):
- test262/test/built-ins/Promise/race/invoke-resolve-on-values-every-iteration-of-promise.js: Copied from JSTests/test262/test/built-ins/Promise/all/invoke-resolve-on-values-every-iteration-of-promise.js.
(Promise.resolve):
(Promise.race.values.then):
- test262/test/built-ins/Promise/race/reject-from-same-thenable.js: Added.
(Constructor.reject):
(Constructor.resolve):
(let.a.then):
- test262/test/built-ins/Promise/race/resolve-element-function-extensible.js: Added.
(let.thenable.then):
(NotPromise):
(NotPromise.resolve):
- test262/test/built-ins/Promise/race/resolve-element-function-name.js: Added.
(let.thenable.then):
(NotPromise):
(NotPromise.resolve):
- test262/test/built-ins/Promise/race/resolve-element-function-nonconstructor.js: Added.
(let.thenable.then):
(NotPromise):
(NotPromise.resolve):
- test262/test/built-ins/Promise/race/resolve-element-function-prototype.js: Added.
(let.thenable.then):
(NotPromise):
(NotPromise.resolve):
- test262/test/built-ins/Promise/race/resolve-from-same-thenable.js: Added.
(Constructor.resolve):
(let.a.then):
- test262/test/built-ins/Promise/race/resolve-ignores-late-rejection-deferred.js: Added.
(let.lateRejector.then):
- test262/test/built-ins/Promise/race/resolve-ignores-late-rejection.js: Added.
(let.resolver.then):
(let.lateRejector.then):
- test262/test/built-ins/Promise/race/resolved-sequence-extra-ticks.js: Added.
(a.then):
(then):
- test262/test/built-ins/Promise/race/resolved-sequence-mixed.js: Added.
(Promise.all.a.catch):
(c.then):
(b.then):
(catch):
- test262/test/built-ins/Promise/race/resolved-sequence-with-rejections.js: Added.
(Promise.all.a.catch):
(b.catch):
- test262/test/built-ins/Promise/race/resolved-sequence.js: Added.
(Promise.all.a.then):
(b.then):
- test262/test/built-ins/Promise/race/resolved-then-catch-finally.js: Added.
(let.b.Promise.resolve.string_appeared_here.then):
(let.c.Promise.reject.string_appeared_here.then):
(let.f.Promise.resolve.string_appeared_here.finally):
(let.g.Promise.reject.string_appeared_here.finally):
- test262/test/built-ins/Promise/resolve/S25.4.4.5_A3.1_T1.js:
(thenable.then):
(p1.then):
- test262/test/built-ins/Promise/resolve/S25.Promise_resolve_foreign_thenable_2.js:
(thenable.then):
(p.then):
- test262/test/intl402/DateTimeFormat/constructor-options-fractionalSecondDigits-valid.js:
(valueOf):
- test262/test/intl402/NumberFormat/constructor-order.js:
- test262/test/intl402/NumberFormat/constructor-unit.js:
(string_appeared_here.new.Intl.NumberFormat):
- test262/test/intl402/NumberFormat/prototype/format/numbering-systems.js:
(digitList.of.Object.entries):
- test262/test/language/expressions/class/elements/after-same-line-gen-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/after-same-line-gen-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/after-same-line-gen-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/after-same-line-gen-rs-static-async-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/after-same-line-method-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/after-same-line-method-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/after-same-line-method-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/after-same-line-method-rs-static-async-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-computed-names.js:
(prototype.C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-computed-symbol-names.js:
(prototype.C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-grammar-privatename-identifier-semantics-stringvalue.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-literal-names-asi.js:
(prototype.C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-literal-names.js:
(prototype.C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-private-field-usage.js:
(prototype.C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-private-method-getter-usage.js:
(prototype.C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-private-method-usage.js:
(prototype.C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-private-names.js:
(prototype.C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-field-identifier-initializer.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-field-identifier.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-private-getter-alt.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-private-getter.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-private-method-alt.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-private-method.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-private-setter-alt.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-private-setter.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-privatename-identifier-alt.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-privatename-identifier-initializer-alt.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-privatename-identifier-initializer.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-privatename-identifier.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-async-generator-method-privatename-identifier-alt.js:
(C.get return):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-async-generator-method-privatename-identifier.js:
(C):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-async-method-privatename-identifier-alt.js:
(C.async return):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-async-method-privatename-identifier.js:
(C):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-generator-method-privatename-identifier.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-method-privatename-identifier-alt.js:
(prototype.C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-method-privatename-identifier.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-privatename-identifier-alt-by-classname.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-privatename-identifier-alt.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-privatename-identifier-by-classname.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-privatename-identifier-initializer-alt-by-classname.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-privatename-identifier-initializer-alt.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-privatename-identifier-initializer.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-privatename-identifier.js:
(C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-static-private-fields.js:
(prototype.C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-static-private-methods-with-fields.js:
(prototype.C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-static-private-methods.js:
(prototype.C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-gen-string-literal-names.js:
(prototype.C.m.next.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-computed-names.js:
(prototype.C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-computed-symbol-names.js:
(prototype.C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-grammar-privatename-identifier-semantics-stringvalue.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-literal-names-asi.js:
(prototype.C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-literal-names.js:
(prototype.C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-private-field-usage.js:
(prototype.C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-private-method-getter-usage.js:
(prototype.C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-private-method-usage.js:
(prototype.C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-private-names.js:
(prototype.C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-field-identifier-initializer.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-field-identifier.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-private-getter-alt.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-private-getter.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-private-method-alt.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-private-method.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-private-setter-alt.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-private-setter.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-privatename-identifier-alt.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-privatename-identifier-initializer-alt.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-privatename-identifier-initializer.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-privatename-identifier.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-async-generator-method-privatename-identifier-alt.js:
(C.get return):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-async-generator-method-privatename-identifier.js:
(C):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-async-method-privatename-identifier-alt.js:
(C.async return):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-async-method-privatename-identifier.js:
(C):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-generator-method-privatename-identifier.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-method-privatename-identifier-alt.js:
(prototype.C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-method-privatename-identifier.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-privatename-identifier-alt-by-classname.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-privatename-identifier-alt.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-privatename-identifier-by-classname.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-privatename-identifier-initializer-alt-by-classname.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-privatename-identifier-initializer-alt.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-privatename-identifier-initializer.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-privatename-identifier.js:
(C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-static-private-fields.js:
(prototype.C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-static-private-methods-with-fields.js:
(prototype.C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-static-private-methods.js:
(prototype.C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-async-method-string-literal-names.js:
(prototype.C.m.then):
- test262/test/language/expressions/class/elements/after-same-line-static-gen-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/after-same-line-static-gen-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/after-same-line-static-gen-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/after-same-line-static-gen-rs-static-async-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/after-same-line-static-method-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/after-same-line-static-method-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/after-same-line-static-method-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/after-same-line-static-method-rs-static-async-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/multiple-definitions-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/multiple-definitions-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/multiple-definitions-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/multiple-definitions-rs-static-async-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/multiple-stacked-definitions-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/multiple-stacked-definitions-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/multiple-stacked-definitions-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/multiple-stacked-definitions-rs-static-async-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/new-no-sc-line-method-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/new-no-sc-line-method-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/new-no-sc-line-method-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/new-no-sc-line-method-rs-static-async-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/new-sc-line-gen-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/new-sc-line-gen-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/new-sc-line-gen-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/new-sc-line-gen-rs-static-async-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/new-sc-line-method-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/new-sc-line-method-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/new-sc-line-method-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/new-sc-line-method-rs-static-async-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/private-methods/prod-private-async-generator.js:
(ctorPromise.then):
- test262/test/language/expressions/class/elements/private-methods/prod-private-async-method.js:
(ctorPromise.then):
- test262/test/language/expressions/class/elements/regular-definitions-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/regular-definitions-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/regular-definitions-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/regular-definitions-rs-static-async-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/same-line-async-gen-computed-names.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-computed-symbol-names.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-grammar-privatename-identifier-semantics-stringvalue.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-literal-names-asi.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-literal-names.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-private-field-usage.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-private-method-getter-usage.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-private-method-usage.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-private-names.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-field-identifier-initializer.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-field-identifier.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-private-getter-alt.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-private-getter.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-private-method-alt.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-private-method.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-private-setter-alt.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-private-setter.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-privatename-identifier-alt.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-privatename-identifier-initializer-alt.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-privatename-identifier-initializer.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-privatename-identifier.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-async-generator-method-privatename-identifier-alt.js:
(assertions):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-async-generator-method-privatename-identifier.js:
(c.m.next.then.assertions):
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-async-method-privatename-identifier-alt.js:
(c.m.next.then.assertions):
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-async-method-privatename-identifier.js:
(c.m.next.then.assertions):
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-generator-method-privatename-identifier.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-method-privatename-identifier-alt.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-method-privatename-identifier.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-privatename-identifier-alt-by-classname.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-privatename-identifier-alt.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-privatename-identifier-by-classname.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-privatename-identifier-initializer-alt-by-classname.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-privatename-identifier-initializer-alt.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-privatename-identifier-initializer.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-rs-static-privatename-identifier.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-static-private-fields.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-static-private-methods-with-fields.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-static-private-methods.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-gen-string-literal-names.js:
(c.m.next.then):
- test262/test/language/expressions/class/elements/same-line-async-method-computed-names.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-computed-symbol-names.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-grammar-privatename-identifier-semantics-stringvalue.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-literal-names-asi.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-literal-names.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-private-field-usage.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-private-method-getter-usage.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-private-method-usage.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-private-names.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-field-identifier-initializer.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-field-identifier.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-private-getter-alt.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-private-getter.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-private-method-alt.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-private-method.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-private-setter-alt.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-private-setter.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-privatename-identifier-alt.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-privatename-identifier-initializer-alt.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-privatename-identifier-initializer.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-privatename-identifier.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-async-generator-method-privatename-identifier-alt.js:
(assertions):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-async-generator-method-privatename-identifier.js:
(c.m.then.assertions):
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-async-method-privatename-identifier-alt.js:
(c.m.then.assertions):
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-async-method-privatename-identifier.js:
(c.m.then.assertions):
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-generator-method-privatename-identifier.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-method-privatename-identifier-alt.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-method-privatename-identifier.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-privatename-identifier-alt-by-classname.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-privatename-identifier-alt.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-privatename-identifier-by-classname.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-privatename-identifier-initializer-alt-by-classname.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-privatename-identifier-initializer-alt.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-privatename-identifier-initializer.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-rs-static-privatename-identifier.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-static-private-fields.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-static-private-methods-with-fields.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-static-private-methods.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-async-method-string-literal-names.js:
(c.m.then):
- test262/test/language/expressions/class/elements/same-line-gen-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/same-line-gen-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/same-line-gen-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/same-line-gen-rs-static-async-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/same-line-method-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/same-line-method-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/same-line-method-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/same-line-method-rs-static-async-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/wrapped-in-sc-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/wrapped-in-sc-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/expressions/class/elements/wrapped-in-sc-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/expressions/class/elements/wrapped-in-sc-rs-static-async-method-privatename-identifier.js:
- test262/test/language/expressions/optional-chaining/eval-optional-call.js: Added.
- test262/test/language/statements/class/elements/after-same-line-gen-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/after-same-line-gen-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/after-same-line-gen-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/after-same-line-gen-rs-static-async-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/after-same-line-method-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/after-same-line-method-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/after-same-line-method-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/after-same-line-method-rs-static-async-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-computed-names.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-computed-symbol-names.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-grammar-privatename-identifier-semantics-stringvalue.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-literal-names-asi.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-literal-names.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-private-field-usage.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-private-method-getter-usage.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-private-method-usage.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-private-names.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-field-identifier-initializer.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-field-identifier.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-private-getter-alt.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-private-getter.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-private-method-alt.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-private-method.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-private-setter-alt.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-private-setter.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-privatename-identifier-alt.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-privatename-identifier-initializer-alt.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-privatename-identifier-initializer.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-privatename-identifier.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-async-generator-method-privatename-identifier-alt.js:
(C.get return):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-async-generator-method-privatename-identifier.js:
(C):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-async-method-privatename-identifier-alt.js:
(C.async return):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-async-method-privatename-identifier.js:
(C):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-generator-method-privatename-identifier.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-method-privatename-identifier-alt.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-method-privatename-identifier.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-privatename-identifier-alt-by-classname.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-privatename-identifier-alt.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-privatename-identifier-by-classname.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-privatename-identifier-initializer-alt-by-classname.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-privatename-identifier-initializer-alt.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-privatename-identifier-initializer.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-privatename-identifier.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-static-private-fields.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-static-private-methods-with-fields.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-static-private-methods.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-gen-string-literal-names.js:
(C.m.next.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-computed-names.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-computed-symbol-names.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-grammar-privatename-identifier-semantics-stringvalue.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-literal-names-asi.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-literal-names.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-private-field-usage.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-private-method-getter-usage.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-private-method-usage.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-private-names.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-field-identifier-initializer.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-field-identifier.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-private-getter-alt.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-private-getter.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-private-method-alt.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-private-method.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-private-setter-alt.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-private-setter.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-privatename-identifier-alt.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-privatename-identifier-initializer-alt.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-privatename-identifier-initializer.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-privatename-identifier.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-async-generator-method-privatename-identifier-alt.js:
(C.get return):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-async-generator-method-privatename-identifier.js:
(C):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-async-method-privatename-identifier-alt.js:
(C.async return):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-async-method-privatename-identifier.js:
(C):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-generator-method-privatename-identifier.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-method-privatename-identifier-alt.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-method-privatename-identifier.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-privatename-identifier-alt-by-classname.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-privatename-identifier-alt.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-privatename-identifier-by-classname.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-privatename-identifier-initializer-alt-by-classname.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-privatename-identifier-initializer-alt.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-privatename-identifier-initializer.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-rs-static-privatename-identifier.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-static-private-fields.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-static-private-methods-with-fields.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-static-private-methods.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-async-method-string-literal-names.js:
(C.m.then):
- test262/test/language/statements/class/elements/after-same-line-static-gen-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/after-same-line-static-gen-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/after-same-line-static-gen-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/after-same-line-static-gen-rs-static-async-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/after-same-line-static-method-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/after-same-line-static-method-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/after-same-line-static-method-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/after-same-line-static-method-rs-static-async-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/multiple-definitions-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/multiple-definitions-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/multiple-definitions-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/multiple-definitions-rs-static-async-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/multiple-stacked-definitions-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/multiple-stacked-definitions-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/multiple-stacked-definitions-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/multiple-stacked-definitions-rs-static-async-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/new-no-sc-line-method-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/new-no-sc-line-method-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/new-no-sc-line-method-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/new-no-sc-line-method-rs-static-async-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/new-sc-line-gen-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/new-sc-line-gen-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/new-sc-line-gen-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/new-sc-line-gen-rs-static-async-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/new-sc-line-method-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/new-sc-line-method-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/new-sc-line-method-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/new-sc-line-method-rs-static-async-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/private-methods/prod-private-async-generator.js:
(ctorPromise.then):
- test262/test/language/statements/class/elements/private-methods/prod-private-async-method.js:
(ctorPromise.then):
- test262/test/language/statements/class/elements/regular-definitions-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/regular-definitions-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/regular-definitions-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/regular-definitions-rs-static-async-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/same-line-async-gen-computed-names.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-computed-symbol-names.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-grammar-privatename-identifier-semantics-stringvalue.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-literal-names-asi.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-literal-names.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-private-field-usage.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-private-method-getter-usage.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-private-method-usage.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-private-names.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-field-identifier-initializer.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-field-identifier.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-private-getter-alt.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-private-getter.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-private-method-alt.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-private-method.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-private-setter-alt.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-private-setter.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-privatename-identifier-alt.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-privatename-identifier-initializer-alt.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-privatename-identifier-initializer.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-privatename-identifier.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-async-generator-method-privatename-identifier-alt.js:
(C.get return):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-async-generator-method-privatename-identifier.js:
(C):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-async-method-privatename-identifier-alt.js:
(C.async return):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-async-method-privatename-identifier.js:
(C):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-generator-method-privatename-identifier.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-method-privatename-identifier-alt.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-method-privatename-identifier.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-privatename-identifier-alt-by-classname.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-privatename-identifier-alt.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-privatename-identifier-by-classname.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-privatename-identifier-initializer-alt-by-classname.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-privatename-identifier-initializer-alt.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-privatename-identifier-initializer.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-rs-static-privatename-identifier.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-static-private-fields.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-static-private-methods-with-fields.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-static-private-methods.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-gen-string-literal-names.js:
(c.m.next.then):
- test262/test/language/statements/class/elements/same-line-async-method-computed-names.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-computed-symbol-names.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-grammar-privatename-identifier-semantics-stringvalue.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-literal-names-asi.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-literal-names.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-private-field-usage.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-private-method-getter-usage.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-private-method-usage.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-private-names.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-field-identifier-initializer.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-field-identifier.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-private-getter-alt.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-private-getter.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-private-method-alt.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-private-method.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-private-setter-alt.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-private-setter.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-privatename-identifier-alt.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-privatename-identifier-initializer-alt.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-privatename-identifier-initializer.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-privatename-identifier.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-async-generator-method-privatename-identifier-alt.js:
(C.get return):
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-async-generator-method-privatename-identifier.js:
(C):
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-async-method-privatename-identifier-alt.js:
(C.async return):
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-async-method-privatename-identifier.js:
(C):
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-generator-method-privatename-identifier.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-method-privatename-identifier-alt.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-method-privatename-identifier.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-privatename-identifier-alt-by-classname.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-privatename-identifier-alt.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-privatename-identifier-by-classname.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-privatename-identifier-initializer-alt-by-classname.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-privatename-identifier-initializer-alt.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-privatename-identifier-initializer.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-rs-static-privatename-identifier.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-static-private-fields.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-static-private-methods-with-fields.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-static-private-methods.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-async-method-string-literal-names.js:
(c.m.then):
- test262/test/language/statements/class/elements/same-line-gen-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/same-line-gen-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/same-line-gen-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/same-line-gen-rs-static-async-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/same-line-method-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/same-line-method-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/same-line-method-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/same-line-method-rs-static-async-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/wrapped-in-sc-rs-static-async-generator-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/wrapped-in-sc-rs-static-async-generator-method-privatename-identifier.js:
- test262/test/language/statements/class/elements/wrapped-in-sc-rs-static-async-method-privatename-identifier-alt.js:
- test262/test/language/statements/class/elements/wrapped-in-sc-rs-static-async-method-privatename-identifier.js:
- test262/test/language/statements/for-await-of/async-gen-decl-dstr-array-elem-init-yield-expr.js:
- test262/test/language/statements/for-await-of/async-gen-decl-dstr-array-elem-nested-array-yield-expr.js:
- test262/test/language/statements/for-await-of/async-gen-decl-dstr-array-elem-nested-obj-yield-expr.js:
- test262/test262-Revision.txt:
- 6:16 PM Changeset in webkit [263607] by
-
- 2 edits in trunk/Source/WebKit
Crash at WebKit: 62-[WKContentView(WKInteraction) resignFirstResponderForWebView]_block_invoke
<https://webkit.org/b/213666>
<rdar://problem/64238661>
Reviewed by Darin Adler.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView resignFirstResponderForWebView]):
- Speculative fix to return early if there are no queued key events available by the time the block runs.
- 5:13 PM Changeset in webkit [263606] by
-
- 7 edits2 moves in trunk/LayoutTests/imported/w3c
Resync web-platform-tests/WebIDL from upstream
https://bugs.webkit.org/show_bug.cgi?id=213539
Reviewed by Sam Weinig.
Resync web-platform-tests/WebIDL from upstream 1001bb6b2d6b9.
- web-platform-tests/WebIDL/ecmascript-binding/class-string-iterator-prototype-object.any-expected.txt:
- web-platform-tests/WebIDL/ecmascript-binding/class-string-iterator-prototype-object.any.js:
(test):
- web-platform-tests/WebIDL/ecmascript-binding/class-string-iterator-prototype-object.any.worker-expected.txt:
- web-platform-tests/WebIDL/ecmascript-binding/class-string-named-properties-object.window-expected.txt:
- web-platform-tests/WebIDL/ecmascript-binding/class-string-named-properties-object.window.js:
- web-platform-tests/WebIDL/idlharness-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/WebIDL/interfaces-expected.txt.
- web-platform-tests/WebIDL/idlharness.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/WebIDL/interfaces.html.
- web-platform-tests/WebIDL/w3c-import.log:
- 4:58 PM Changeset in webkit [263605] by
-
- 60 edits1 copy16 moves24 adds in trunk/LayoutTests
Update web-platform-tests/content-security-policy from upstream
https://bugs.webkit.org/show_bug.cgi?id=213664
Reviewed by Darin Adler.
Update web-platform-tests/content-security-policy from upstream b076c305a256e7fb7.
LayoutTests/imported/w3c:
- resources/resource-files.json:
- web-platform-tests/content-security-policy/*: Updated.
LayoutTests:
- tests-options.json:
- 4:56 PM Changeset in webkit [263604] by
-
- 1 copy in tags/Safari-610.1.18.3
Tag Safari-610.1.18.3.
- 4:44 PM Changeset in webkit [263603] by
-
- 8 edits in branches/safari-610.1.18-branch/Source
Versioning.
WebKit-610.1.18.3
- 4:41 PM Changeset in webkit [263602] by
-
- 1 delete in branches/safari-610.1.18.0-branch
Delete branch.
- 4:38 PM Changeset in webkit [263601] by
-
- 3 edits2 adds in trunk
CRASH: incompatible downcast<> operation in SourceBufferPrivateAVFObjC::setCDMInstance()
https://bugs.webkit.org/show_bug.cgi?id=213660
<rdar://problem/63831593>
Reviewed by Eric Carlson.
Source/WebCore:
Test: platform/mac/media/encrypted-media/fps-clearkey-crash.html
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::setCDMInstance):
LayoutTests:
- platform/mac/media/encrypted-media/fps-clearkey-crash-expected.txt: Added.
- platform/mac/media/encrypted-media/fps-clearkey-crash.html: Added.
- 4:37 PM Changeset in webkit [263600] by
-
- 1 copy in branches/safari-610.1.18.0-branch
New branch.
- 4:34 PM Changeset in webkit [263599] by
-
- 1 delete in branches/safari-610.1.18.10-branch
Delete tag.
- 4:32 PM Changeset in webkit [263598] by
-
- 43 edits5 copies1 move19 adds31 deletes in trunk/LayoutTests
Update web-platform-tests/WebCryptoAPI from upstream
https://bugs.webkit.org/show_bug.cgi?id=213662
Reviewed by Darin Adler.
Update web-platform-tests/WebCryptoAPI from upstream b076c305a256e7.
LayoutTests/imported/w3c:
- web-platform-tests/WebCryptoAPI/*: Updated.
LayoutTests:
- platform/mac/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.worker-expected.txt:
- platform/mac/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker-expected.txt:
- platform/mac/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.https.worker-expected.txt:
- platform/mac/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https-expected.txt:
- 4:26 PM Changeset in webkit [263597] by
-
- 3 edits2 adds in trunk
[LFC][BFC] Add support for <center>
https://bugs.webkit.org/show_bug.cgi?id=213649
Reviewed by Antti Koivisto.
Source/WebCore:
Adjust the margin box to center the block content (this is very similar to [style="margin-left: auto; margin-right: auto;"]).
Test: fast/layoutformattingcontext/center-alignment-with-block-content-simple.html
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
LayoutTests:
- fast/layoutformattingcontext/center-alignment-with-block-content-simple-expected.html: Added.
- fast/layoutformattingcontext/center-alignment-with-block-content-simple.html: Added.
- 4:23 PM Changeset in webkit [263596] by
-
- 1 copy in branches/safari-610.1.18.10-branch
New branch.
- 4:07 PM Changeset in webkit [263595] by
-
- 10 edits1 move5 adds in trunk/LayoutTests/imported/w3c
Update web-platform-tests/beacon from upstream
https://bugs.webkit.org/show_bug.cgi?id=213663
Reviewed by Darin Adler.
Update web-platform-tests/beacon from upstream b076c305a256e7fb7.
- web-platform-tests/beacon/*: Updated.
- 3:33 PM Changeset in webkit [263594] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for imported/w3c/canvas/2d.line.cap.round.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=138676
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-26
- 3:29 PM Changeset in webkit [263593] by
-
- 1 copy in tags/Safari-610.1.15.51.6
Tag Safari-610.1.15.51.6.
- 3:09 PM Changeset in webkit [263592] by
-
- 9 edits in trunk/Tools
[webkitpy] Automatically detect hw architecture for supporting Apple Silicon
https://bugs.webkit.org/show_bug.cgi?id=213653
<rdar://problem/64817656>
Rubber-stamped by Aakash Jain.
- Scripts/webkitpy/common/config/ews.json: iOS has the correct defaults, no need to override them.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo):
(PlatformInfo.architecture): Retrieve the current system's architecture.
- Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.init):
(MockPlatformInfo.architecture):
- Scripts/webkitpy/port/base.py:
(Port.init): Remove 'did_override_architecture', should be implied by architecture compared with DEFAULT_ARCHITECTURE.
(Port.architecture): Return the architecture specified by the user, if it exists.
(Port.set_architecture): Remove 'did_override_architecture'.
- Scripts/webkitpy/port/factory.py:
(configuration_options): Add --arm and --architecture flags.
- Scripts/webkitpy/port/mac.py:
(MacPort): Add arm64 to supported architectures.
(MacPort.architecture): Convert arm64e to arm64, check the host's architecture.
(MacPort._build_driver_flags): Always specify the build architecture since it may be x86_64 or arm64.
- Scripts/webkitpy/port/mac_unittest.py:
(MacTest.test_64bit):
(MacTest):
(MacTest.test_arm):
(MacTest.test_default):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.run_command): Remove did_override_architecture.
- 3:00 PM Changeset in webkit [263591] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Layout tests sometimes assert under -[WKContentView hasContent]
https://bugs.webkit.org/show_bug.cgi?id=213656
<rdar://problem/64818648>
Reviewed by Tim Horton.
Make it safe to invoke
-[WKContentView hasContent]when post-layout data is not present, and there is no
ranged or caret selection. Some editing layout tests on iOS tend to hit the post-layout data assertion due to
the callout bar presentation callback firing while we reset the test harness to a consistent state (and spin the
runloop while doing so).
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView hasContent]):
- 2:57 PM Changeset in webkit [263590] by
-
- 2 edits in trunk/LayoutTests
Remove expectations for imported/w3c/canvas/2d.gradient.linear.transform.1.html and imported/w3c/canvas/2d.gradient.linear.transform.2.html and imported/w3c/canvas/2d.gradient.linear.transform.3.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=170757
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-26
- platform/mac/TestExpectations:
- 2:53 PM Changeset in webkit [263589] by
-
- 2 edits in trunk/Source/WebKit
[GTK][WPE] Fix the matching of an empty value in getCgroupControllerPath() when only cgroupsV2 hierarchy is found
https://bugs.webkit.org/show_bug.cgi?id=213646
Reviewed by Adrian Perez de Castro.
- UIProcess/linux/MemoryPressureMonitor.cpp:
(WebKit::getCgroupFile):
(WebKit::getCgroupControllerPath):
(WebKit::systemMemoryUsedAsPercentage):
- 2:45 PM Changeset in webkit [263588] by
-
- 15 edits4 deletes in trunk
Unreviewed, reverting r263511, r263514, and r263565.
r263511 caused MediaRecorder test crashes on internal testers.
Reverted changesets:
"MediaRecorder stopRecorder() returns empty Blob after first
use"
https://bugs.webkit.org/show_bug.cgi?id=212274
https://trac.webkit.org/changeset/263511
"Unreviewed iOS build fix after r263511."
https://trac.webkit.org/changeset/263514
"MediaRecorder.start() Method is Ignoring the "timeslice"
Parameter"
https://bugs.webkit.org/show_bug.cgi?id=202233
https://trac.webkit.org/changeset/263565
- 2:24 PM Changeset in webkit [263587] by
-
- 1 copy in tags/Safari-610.1.18.2
Tag Safari-610.1.18.2.
- 2:19 PM Changeset in webkit [263586] by
-
- 1 copy in tags/Safari-610.1.18.3.1
Tag Safari-610.1.18.3.1.
- 2:18 PM Changeset in webkit [263585] by
-
- 4 edits in branches/safari-610.1.18.3-branch/Source/WTF
Cherry-pick r263524. rdar://problem/64814318
WTF::callOnMainThread should not require the main runloop to be initialized
https://bugs.webkit.org/show_bug.cgi?id=213612
<rdar://problem/64446028>
Reviewed by Yusuke Suzuki.
When using JavaScriptCore as a framework, the WTF main runloop is never initialized. However,
the inspector uses CFString wrappers, which usecallOnMainThreadwhen deallocating the
underlying string. For now, we bring back the oldJSWTFMainThreadCallerto ensure we have
a way of dispatching to the main thread, even when the main runloop hasn't been initialized.
- wtf/RunLoop.cpp: (WTF::RunLoop::mainIfExists):
- wtf/RunLoop.h:
- wtf/cocoa/MainThreadCocoa.mm: (-[JSWTFMainThreadCaller call]): (WTF::initializeMainThreadPlatform): (WTF::scheduleDispatchFunctionsOnMainThread):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:13 PM Changeset in webkit [263584] by
-
- 8 edits in branches/safari-610.1.18.3-branch/Source
Versioning.
WebKit-610.1.18.3.1
- 2:11 PM Changeset in webkit [263583] by
-
- 2 edits in trunk/Tools
[Big Sur] Handle baseline search path (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=213639
<rdar://problem/64789480>
Unreviewed follow-up fix.
- Scripts/webkitpy/port/mac.py:
(MacPort.default_baseline_search_path): Copy reference version by value, not by reference.
- 2:11 PM Changeset in webkit [263582] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for imported/w3c/canvas/2d.gradient.interpolate.solid.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=174015
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-26
- platform/mac/TestExpectations:
- 1:58 PM Changeset in webkit [263581] by
-
- 11 edits in trunk/Source/WebCore
Convert ContentSecurityPolicy related parsers over to using StringParsingBuffer
https://bugs.webkit.org/show_bug.cgi?id=213631
Reviewed by Darin Adler.
- Adopt StringParsingBuffer across CSP code.
- Remove UTF-16 upconversions in ContentSecurityPolicy, ContentSecurityPolicyDirectiveList, ContentSecurityPolicyMediaListDirective and ContentSecurityPolicySourceList.
- html/parser/ParsingUtilities.h:
(WebCore::isNotASCIISpace):
(WebCore::skipExactly):
(WebCore::characterPredicate):
(WebCore::skipUntil):
(WebCore::skipExactlyIgnoringASCIICase):
Add overloads for each helper that take a StringParsingBuffer.
- loader/ResourceCryptographicDigest.cpp:
(WebCore::parseHashAlgorithmAdvancingPosition):
Convert to use an Optional return value rather than outparameter + bool.
(WebCore::parseCryptographicDigestImpl):
(WebCore::parseCryptographicDigest):
(WebCore::parseEncodedCryptographicDigestImpl):
(WebCore::parseEncodedCryptographicDigest):
- loader/ResourceCryptographicDigest.h:
Use StringParsingBuffer rather than raw pointers for parsing.
- loader/SubresourceIntegrity.cpp:
(WebCore::splitOnSpaces):
(WebCore::parseIntegrityMetadata):
Use StringParsingBuffer and readCharactersForParsing rather than raw pointers for parsing.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
Use StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters().
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::isDirectiveNameCharacter):
(WebCore::isDirectiveValueCharacter):
(WebCore::ContentSecurityPolicyDirectiveList::parse):
(WebCore::ContentSecurityPolicyDirectiveList::parseDirective):
(WebCore::ContentSecurityPolicyDirectiveList::parseReportURI):
(WebCore::ContentSecurityPolicyDirectiveList::setCSPDirective):
(WebCore::ContentSecurityPolicyDirectiveList::applySandboxPolicy):
(WebCore::ContentSecurityPolicyDirectiveList::setUpgradeInsecureRequests):
(WebCore::ContentSecurityPolicyDirectiveList::setBlockAllMixedContentEnabled):
(WebCore::ContentSecurityPolicyDirectiveList::addDirective):
- page/csp/ContentSecurityPolicyDirectiveList.h:
Use StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters(). Also switch to using Optional for return values
rather than outparameter + bool. To make things read more cleanly, package up name
and value pair into a new ParsedDirective struct that can be passed around more easily.
- page/csp/ContentSecurityPolicyMediaListDirective.cpp:
(WebCore::isMediaTypeCharacter):
(WebCore::ContentSecurityPolicyMediaListDirective::parse):
Use StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters().
- page/csp/ContentSecurityPolicySourceList.cpp:
(WebCore::isSourceCharacter):
(WebCore::isHostCharacter):
(WebCore::isPathComponentCharacter):
(WebCore::isSchemeContinuationCharacter):
(WebCore::isNotColonOrSlash):
(WebCore::isSourceListNone):
(WebCore::ContentSecurityPolicySourceList::parse):
(WebCore::ContentSecurityPolicySourceList::parseSource):
(WebCore::ContentSecurityPolicySourceList::parseScheme):
(WebCore::ContentSecurityPolicySourceList::parseHost):
(WebCore::ContentSecurityPolicySourceList::parsePath):
(WebCore::ContentSecurityPolicySourceList::parsePort):
(WebCore::isNonceCharacter):
(WebCore::ContentSecurityPolicySourceList::parseNonceSource):
(WebCore::ContentSecurityPolicySourceList::parseHashSource):
- page/csp/ContentSecurityPolicySourceList.h:
Use StringParsingBuffer and readCharactersForParsing to replace unnecessary call to
StringView::upconvertedCharacters(). Also switch to using Optional for return values
rather than outparameter + bool. To make things read more cleanly, package up source
return values into structs that can be more easily returned / passed around.
- 1:52 PM Changeset in webkit [263580] by
-
- 4 edits in trunk/Source/WTF
Re-land r262863
https://bugs.webkit.org/show_bug.cgi?id=213654
Reviewed by Tadeu Zagallo.
r263575 should fix the crash we saw.
- wtf/cocoa/MainThreadCocoa.mm:
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
(-[JSWTFMainThreadCaller call]): Deleted.
- 1:41 PM Changeset in webkit [263579] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for https://results.webkit.org/?suite=layout-tests&test=imported%2Fmozilla%2Fsvg%2Fdynamic-textPath-02.svg as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=213655
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-26
- 1:16 PM Changeset in webkit [263578] by
-
- 6 edits2 adds in trunk
Content sometimes missing in nested scrollers with border-radius
https://bugs.webkit.org/show_bug.cgi?id=213580
<rdar://problem/64460373>
Reviewed by Zalan Bujtas.
Source/WebCore:
RenderLayer::clipToRect() has a special case for clips involving border-radius,
involving an ancestor tree walk which applies the rounded clips.
When inside composited overflow, don't include the border-radius from the scroller since
that does its own clipping.
Test: compositing/clipping/nested-overflow-with-border-radius.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderLayer.h:
LayoutTests:
- compositing/clipping/nested-overflow-with-border-radius-expected.html: Added.
- compositing/clipping/nested-overflow-with-border-radius.html: Added.
- compositing/hidpi-compositing-layer-with-tile-layers-on-subpixel-position-expected.html:
- compositing/hidpi-compositing-layer-with-tile-layers-on-subpixel-position.html: Tweak the colors and radii to make failures on this test more obvious.
- 1:00 PM Changeset in webkit [263577] by
-
- 1 copy in branches/safari-610.1.18.3-branch
New branch.
- 12:43 PM Changeset in webkit [263576] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 ] REGRESSION: webrtc/video-autoplay1.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=213652
Unreviewed test gardening
- platform/mac-wk2/TestExpectations:
- 12:28 PM Changeset in webkit [263575] by
-
- 48 edits in trunk
Initializing the main thread should initialize the main run loop
https://bugs.webkit.org/show_bug.cgi?id=213637
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- JavaScriptCore.order: Removed some defunct stuff.
- shell/playstation/TestShell.cpp:
(setupTestRun): Merged initializeThreading call with
initializeMainThread call because initializeMainThread is a superset.
Source/WebCore:
- platform/ios/wak/WebCoreThread.mm:
(RunWebThread): Removed call to initializeMainThread() because the main
thread calls it before starting the web thread, so it's a no-op. (And if
it were an op, it would be broken.)
(StartWebThread): Merged RunLoop::initializeMain and initializeThreading
into initializeMainThread.
Source/WebDriver:
- WebDriverService.cpp:
(WebDriver::WebDriverService::run):
Source/WebKit:
- Shared/Cocoa/WebKit2InitializeCocoa.mm:
(WebKit::runInitializationCode):
(WebKit::InitializeWebKit2):
- Shared/WebKit2Initialize.cpp:
(WebKit::InitializeWebKit2):
Source/WebKitLegacy/mac:
- History/WebBackForwardList.mm:
(+[WebBackForwardList initialize]):
- History/WebHistoryItem.mm:
(+[WebHistoryItem initialize]):
- Misc/WebCache.mm:
(+[WebCache initialize]):
- Misc/WebElementDictionary.mm:
(+[WebElementDictionary initialize]):
- Misc/WebIconDatabase.mm:
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(+[WebHostedNetscapePluginView initialize]):
- Plugins/WebBaseNetscapePluginView.mm:
- Plugins/WebBasePluginPackage.mm:
(+[WebBasePluginPackage initialize]):
- Plugins/WebNetscapePluginView.mm:
(+[WebNetscapePluginView initialize]):
- WebCoreSupport/WebEditorClient.mm:
(+[WebUndoStep initialize]):
- WebCoreSupport/WebFrameLoaderClient.mm:
(+[WebFramePolicyListener initialize]):
- WebView/WebArchive.mm:
(+[WebArchivePrivate initialize]):
- WebView/WebDataSource.mm:
(+[WebDataSource initialize]):
- WebView/WebHTMLView.mm:
(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
- WebView/WebResource.mm:
(+[WebResourcePrivate initialize]):
- WebView/WebTextIterator.mm:
(+[WebTextIteratorPrivate initialize]):
- WebView/WebView.mm:
(+[WebView initialize]):
- WebView/WebViewData.mm:
(+[WebViewPrivate initialize]):
Source/WebKitLegacy/win:
- WebView.cpp:
(WebView::WebView):
Source/WTF:
Previously, some code initialized one, some the other, and some both;
and some code tried to initialize more than once; and some code tried
to initialize in ways that would crash but luckily got pre-empted by
other code that had already initialized.
In addition to general confusion, this setup made it subtly high stakes
to call certain functions, like callOnMainThread or
RunLoop::main().dispatch(), because they might crash if the right
initialization had not been performed.
Let's fix that.
- wtf/MainThread.cpp:
(WTF::initializeMainThread): Removed defunct comment about
initializeMainThreadToProcessMainThread. Shrank scope of initializeKey.
- wtf/RunLoop.cpp:
(WTF::RunLoop::initializeMain): Don't call initializeMainThread anymore
because it calls us now. No need for a store fence since we run on the
main thread and we don't store anything.
(WTF::RunLoop::initializeWeb): Upgrade to RELEASE_ASSERT.
- wtf/RunLoop.h: Removed incorrect comment. (Fascinating to wonder when
it became incorrect.)
Tools:
Updated TestWebKitAPI to stop using RunLoop::initializeMain directly.
- TestWebKitAPI/Tests/WTF/RefPtr.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/RunLoop.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
(ApplicationManifestParserTest::SetUp):
- TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
(TestWebKitAPI::ComplexTextControllerTest::SetUp):
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::ContentExtensionTest::SetUp):
- TestWebKitAPI/Tests/WebCore/DNS.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
(TestWebKitAPI::TEST_F):
- TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
(initializeInAppBrowserPrivacyTestSettings):
- TestWebKitAPI/TestsController.cpp:
(TestWebKitAPI::TestsController::TestsController):
- WebKitTestRunner/TestController.cpp:
(TestController::initialize):
- 12:26 PM Changeset in webkit [263574] by
-
- 8 edits in branches/safari-610.1.15.51-branch/Source
Versioning.
WebKit-610.1.15.51.6
- 12:26 PM Changeset in webkit [263573] by
-
- 2 edits in trunk/Source/WebCore
Fix for crash in AXIsolatedObject::relativeFrame.
https://bugs.webkit.org/show_bug.cgi?id=213363
Reviewed by Chris Fleizach.
Covered by existing testss.
Between the time an isolated object dispatches the method to the main
thread and the time the lambda is executed, the isolated object is
detached and hence its object ID becomes invalid. Thus, trying to get
the associated AX object results in an assert/crash.
- accessibility/isolatedtree/AXIsolatedObject.h:
- 12:20 PM Changeset in webkit [263572] by
-
- 3 edits in trunk/Source/WebCore
Access to AXIsolatedTree:m_readerThreadNodeMap should happen only on the secondary AX thread.
https://bugs.webkit.org/show_bug.cgi?id=213575
Reviewed by Chris Fleizach.
After calling AXObjectCache::initializeSecondaryAXThread, there may
still be some client requests coming in on the main thread. Thus
AXIsolatedTree::applyPendingchanges and nodeForID can be called on the
main thread. Since these two methods access the member variable
m_readerThreadNodeMap which should be accessed only on the secondary AX
thread, we now check for this condition and bail out if needed.
- accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::nodeForID const):
(WebCore::AXIsolatedTree::applyPendingChanges):
- accessibility/isolatedtree/AXIsolatedTree.h: Reordered private methods
above member variables to comply with WebKit coding conventions,
pointed out by Darin Adler in review for https://bugs.webkit.org/show_bug.cgi?id=213435.
- 11:07 AM Changeset in webkit [263571] by
-
- 5 edits in trunk/Source/WebCore
Fix for crash in accessibility/roles-exposed.html in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=213648
Reviewed by Chris Fleizach.
LayoutTest: accessibility/roles-exposed.html.
- In layout tests, when AXObjectCache::notificationPostTimerFired is
triggered, and we try to update the isolated tree, some of the
underlying objects may already be gone. So this change ensure we don't
try to update an isolated object that corresponds to an already detached
live object.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::cacheAndInitializeWrapper): Sanity check.
- accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::addChildren): m_renderer can be null
when trying to update the isolated tree.
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored const):
Parent object may be gone when trying to update the isolated tree.
- accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateChildrenIDs):
(WebCore::AXIsolatedTree::generateSubtree):
(WebCore::AXIsolatedTree::updateChildren):
- 10:37 AM Changeset in webkit [263570] by
-
- 5 edits in trunk/Source/WebKit
[iOS] Network process is crashing when launching TJMaxx app due to invalid NetworkProcess::DestroySession IPC message
https://bugs.webkit.org/show_bug.cgi?id=213625
<rdar://problem/64737890>
Reviewed by Alex Christensen.
The app is calling [WKWebsiteDataStore init] despite the method being marked as unavailable in
WKWebsiteDataStore.h. As a result, they end up with a WKWebsiteDataStore object whose internal
_websiteDataStore is bad because its constructor was never called. When [WKWebsiteDataStore dealloc]
gets called later own, it calls the ~WebsiteDataStore() destructor for _websiteDataStore but its
m_sessionID is 0 because we never called the constructor. This causes us to send a
NetworkProcess::DestroySession IPC with a sessionID that is 0, which is not valid so the
NetworkProcess crashes.
To address the issue, we now provide an implementation of [WKWebsiteDataStore init] which raises an
exception, behind a linked-on-after check. To keep the app working, [WKWebsiteDataStore init] returns
a new ephemeral data store until rebuilt with the new SDK.
- UIProcess/API/Cocoa/WKWebsiteDataStore.h:
Mark "new" as unavailable, otherwise [WKWebsiteDataStore new] builds.
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore init]):
Raise an exception with latest SDK, a new ephemeral data store otherwise.
- UIProcess/Cocoa/VersionChecks.h:
Add linked-on-after check.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::~WebsiteDataStore):
Add a release assertion to make sure that m_sessionID is always valid when the destructor is called.
- 10:18 AM Changeset in webkit [263569] by
-
- 4 edits in trunk/Tools
run-javascriptcore-tests: Support Apple Silicon running x86 processes
https://bugs.webkit.org/show_bug.cgi?id=213487
<rdar://problem/64606667>
Reviewed by Saam Barati.
- Scripts/run-javascriptcore-tests:
(configurationForUpload): Add --architecture flag.
(runTest): Run test suite with specific architecture.
(runJSCStressTests): Pass architecture to run-jsc-stress-tests.
- Scripts/run-jsc-stress-tests: Add --force-architecture flag.
- Scripts/webkitdirs.pm:
(determineNativeArchitecture): Add function to determine machine's native architecture.
(determineArchitecture): Leverage the nativeArchitecture instead of hard-coding simulator
architectures.
(architecturesForProducts): Determine the architectures supported by a given build.
(nativeArchitecture): Return nativeArchitecture.
- 10:16 AM Changeset in webkit [263568] by
-
- 3 edits in trunk/Source/WebKit
[WinCairo] Cannot build without resource load statistics
https://bugs.webkit.org/show_bug.cgi?id=213534
Reviewed by Don Olmstead.
Build fix for !ENABLE(RESOURCE_LOAD_STATISTICS)
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
- 10:00 AM Changeset in webkit [263567] by
-
- 4 edits2 adds in trunk
Add a test to verify that async clipboard API write access is granted when copying in subframes
https://bugs.webkit.org/show_bug.cgi?id=213581
Reviewed by Darin Adler.
Source/WebKitLegacy/mac:
- WebView/WebView.mm:
(-[WebView _executeCoreCommandByName:value:]):
Adjust the behavior of this SPI to trigger the editing command in the focused frame, rather than always the
mainframe. This matches the behavior ofWKBundlePageExecuteEditingCommand, and is also consistent with
user-triggered editing commands.
LayoutTests:
Add a new test to verify that clipboard write access is granted when copying in a subframe.
- editing/async-clipboard/clipboard-write-in-copy-event-handler-in-subframe-expected.txt: Added.
- editing/async-clipboard/clipboard-write-in-copy-event-handler-in-subframe.html: Added.
- platform/win/TestExpectations:
- 9:51 AM Changeset in webkit [263566] by
-
- 2 edits in trunk/LayoutTests
Change expectations to http/tests/webarchive/test-css-url-encoding-shift-jis.html and
http/tests/webarchive/test-css-url-encoding-utf-8.html and
http/tests/webarchive/test-css-url-encoding.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=82665
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-26
- platform/mac/TestExpectations:
- 9:49 AM Changeset in webkit [263565] by
-
- 4 edits2 adds in trunk
MediaRecorder.start() Method is Ignoring the "timeslice" Parameter
https://bugs.webkit.org/show_bug.cgi?id=202233
<rdar://problem/55720555>
Reviewed by Eric Carlson.
Source/WebCore:
Use a timer to implement timeSlice parameter.
Schedule timer either when start is called or as part of requestData callback.
This should ensure that, if requestData is called by the application, the timer will be rescheduled appropriately.
Test: http/wpt/mediarecorder/MediaRecorder-start-timeSlice.html
- Modules/mediarecorder/MediaRecorder.cpp:
(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::startRecording):
(WebCore::MediaRecorder::requestData):
- Modules/mediarecorder/MediaRecorder.h:
LayoutTests:
- http/wpt/mediarecorder/MediaRecorder-start-timeSlice-expected.txt: Added.
- http/wpt/mediarecorder/MediaRecorder-start-timeSlice.html: Added.
- 9:44 AM Changeset in webkit [263564] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: (it != m_map.end()) in TreeScopeOrderedMap::remove
https://bugs.webkit.org/show_bug.cgi?id=213611
<rdar://problem/64493506>
Reviewed by Geoffrey Garen.
Source/WebCore:
In function HTMLImageElement::parseAttribute(), empty name attribute is considered valid
which makes the function skip handling of subsequent name changes. Modified the check of
name attribute so only non-empty name is considered valid. This code change is to match
<https://trac.webkit.org/changeset/262360>.
Test: fast/images/img-change-name-assert.html
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
LayoutTests:
Added a regression test for the crash.
- fast/images/img-change-name-assert-expected.txt: Added.
- fast/images/img-change-name-assert.html: Added.
- 9:41 AM Changeset in webkit [263563] by
-
- 6 edits in trunk
Text manipulation should observe adjacent elements with new renderer together
https://bugs.webkit.org/show_bug.cgi?id=213333
Reviewed by Geoffrey Garen.
Source/WebCore:
TextManipulationController only keeps track of manipulated Elements. For other types of Node, like Text,
TextManipulationController does not mark them as manipulated and may manipulate it again. r263132 tried to solve
the problem by marking Element with only manipulated children as manipulated, but it did not iterate all
children of Element. So, if one Element has children in different paragraphs, it may fail to mark the Element
manipulated. See updated test.
To fix this issue completely, TextManipulationController now tracks all manipulated Nodes, so it can skip the
manipulated Nodes during observation.
For elements with new renderer, TextManipulationController observes them one by one. However, adjacent elements
can be in the same paragraph, if there is no delimiter in their text, and should be observed together. To solve
this problem, TextManipulationController now starts observing from the common ancestor of these elements. If a
Node in range is manipulated, split the paragrph there. This makes sure content in paragraph is not manipulated.
Relevant test is updated for this new behavior.
Tests: TextManipulation.StartTextManipulationFindNewlyDisplayedParagraph
TextManipulation.CompleteTextManipulationAvoidExtractingManipulatedTextAfterManipulation
- dom/Node.cpp:
(WebCore::Node::~Node):
- editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::observeParagraphs):
(WebCore::TextManipulationController::didCreateRendererForElement):
(WebCore::TextManipulationController::scheduleObservationUpdate):
(WebCore::TextManipulationController::updateInsertions):
(WebCore::TextManipulationController::replace):
(WebCore::TextManipulationController::removeNode):
(WebCore::makePositionTuple): Deleted.
(WebCore::makeHashablePositionRange): Deleted.
- editing/TextManipulationController.h:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):
- 9:38 AM Changeset in webkit [263562] by
-
- 3 edits in trunk/Source/WebCore
Clean up some PaintBehavior-related code in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=213634
Reviewed by Sam Weinig.
Move the computation of paintBehavior into a lambda, and share the flags between
normal painting and mask painting.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderLayer.h:
- 9:31 AM Changeset in webkit [263561] by
-
- 3 edits in trunk/Tools
[Big Sur] Handle baseline search path
https://bugs.webkit.org/show_bug.cgi?id=213639
<rdar://problem/64789480>
Rubber-stamped by Aakash Jain.
- Scripts/webkitpy/port/mac.py:
(MacPort):
(MacPort.default_baseline_search_path): Break infinite loop for major version bump.
- Scripts/webkitpy/port/mac_unittest.py:
(MacTest.test_big_sur_baseline_search_path): Test Big Sur baseline search path.
- 8:58 AM Changeset in webkit [263560] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-main-frame.html and http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-worker.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=160445
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-26
- platform/mac-wk2/TestExpectations:
- 8:12 AM Changeset in webkit [263559] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] REGRESSON: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/intrinsic_sizes.htm is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=213645
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 8:05 AM Changeset in webkit [263558] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for http/tests/media/hls/video-cookie.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=213644
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-26
- platform/mac/TestExpectations:
- 7:44 AM Changeset in webkit [263557] by
-
- 2 edits in trunk/Tools
generate-jsc-bundle should fail if passed an invalid remote-config-file parameter
https://bugs.webkit.org/show_bug.cgi?id=213615
Reviewed by Žan Doberšek.
Raise an exception if the parameter passed as remote-config-file is not a file.
- Scripts/generate-jsc-bundle:
(main):
- 6:36 AM Changeset in webkit [263556] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Initialize m_currentState and m_oldState
https://bugs.webkit.org/show_bug.cgi?id=213604
Reviewed by Eric Carlson.
MediaPlayerPrivateGStreamer was not initializing m_currentState and
m_oldState, causing them to be checked e.g. updateStates() while they
still contain garbage.
Because the biggest uninitialized usage is a != comparison, in
practice things still worked, but that's still a bug. I detected the
bug after seeing this in the logs:
playbin3SendSelectStreamsIfAppropriate:<media-player-0> Checking if to send SELECT_STREAMS, m_waitingForStreamsSelectedEvent = false, haveDifferentStreamIds = false, m_currentState = UNKNOWN!(-8421505)... shouldSendSelectStreams = false
This patch fixes a slight memory error which doesn't alter
TestExpectations.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 2:38 AM Changeset in webkit [263555] by
-
- 2 edits in trunk/Tools
Add myself to contributors.json
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
Jun 25, 2020:
- 10:48 PM Changeset in webkit [263554] by
-
- 3 edits1 add in trunk/LayoutTests
[GTK] Unreviewed test gardening. Update baselines after r263550.
- platform/gtk/editing/deleting/smart-delete-paragraph-005-expected.txt: Added.
- platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.png:
- platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt:
- 10:20 PM Changeset in webkit [263553] by
-
- 2 edits in trunk/Tools
[Big Sur] Regression tests fail to run due to failed assert: self._os_version.major == 10
https://bugs.webkit.org/show_bug.cgi?id=213639
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/port/mac.py:
(MacPort.init): Remove the assert since it is no longer valid.
- 10:03 PM Changeset in webkit [263552] by
-
- 4 edits1 delete in trunk
Unreviewed, reverting r263537.
https://bugs.webkit.org/show_bug.cgi?id=213640
Broke watchOS and tvOS builds
Reverted changeset:
"iOS Safari incorrectly reports "AppleCoreMedia" as UA string"
https://bugs.webkit.org/show_bug.cgi?id=213245
https://trac.webkit.org/changeset/263537
- 9:36 PM Changeset in webkit [263551] by
-
- 5 edits in trunk/Source/WebKit
WKHTTPCookieStore.setCookie should flush the cookies to disk before calling completion handler when we are using the UIProcess's default cookie storage
https://bugs.webkit.org/show_bug.cgi?id=213636
Patch by Alex Christensen <achristensen@webkit.org> on 2020-06-25
Reviewed by Brady Eidson.
This fixes a race condition that many, many third party developers run into, causing them to not be logged in when they thought they did.
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::saveCookies):
- UIProcess/API/APIHTTPCookieStore.cpp:
(API::HTTPCookieStore::setCookies):
(API::HTTPCookieStore::registerForNewProcessPoolNotifications):
(API::HTTPCookieStore::flushDefaultUIProcessCookieStore):
- UIProcess/API/APIHTTPCookieStore.h:
- UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm:
(API::HTTPCookieStore::flushDefaultUIProcessCookieStore):
- 9:17 PM Changeset in webkit [263550] by
-
- 3 edits2 adds in trunk
[Inline] Overlapping content when margin-right is present
https://bugs.webkit.org/show_bug.cgi?id=213629
<rdar://problem/64391403>
Reviewed by Simon Fraser.
Source/WebCore:
- computeInlineDirectionPositionsForSegment loops through the Bidi runs and computes their logical widths.
- Text measuring needs the current logical left position in order to compute the run width properly (e.g tab size)
- The current logical left includes margins, boders and paddings (e.g <span style="margin: 100px;">text content</span> 'text content' starts at 100px -ignore the line offset for now)
- The BiDi loop jumps over empty inline containers (e.g. text<span style="border: 10px solid green"></span>content) and it lacks the information to be able to resolve nested inline containers.
This patch pre-computes the spacing offset for each InlineTextBox so that we could use it later to compute the logical left position for the text measuring.
<span style="margin-right: 1px">[1]<span style="margin: 2px">[2]</span>[3]</span>[4]
[1] -> 0px offset
[2] -> 2px offset
[3] -> 4px offset
[4] -> 5px offset
Test: fast/inline/incorrect-tab-position.html
- rendering/ComplexLineLayout.cpp:
(WebCore::ComplexLineLayout::computeInlineDirectionPositionsForSegment):
LayoutTests:
- fast/inline/incorrect-tab-position-expected.html: Added.
- fast/inline/incorrect-tab-position.html: Added.
- 7:47 PM Changeset in webkit [263549] by
-
- 2 edits in trunk/Source/WebKit
Upstream date/time picker style
https://bugs.webkit.org/show_bug.cgi?id=213630
Reviewed by Wenson Hsieh.
- UIProcess/ios/forms/WKDateTimeInputControl.mm:
(-[WKDateTimePicker datePickerStyle]):
- 6:03 PM Changeset in webkit [263548] by
-
- 6 edits in trunk
REGRESSION(r256166, r260596) WKNavigationAction.request.allHTTPHeaderFields needs to contain User-Agent and Accept
https://bugs.webkit.org/show_bug.cgi?id=213626
<rdar://problem/62374208>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-06-25
Reviewed by Darin Adler.
Source/WebCore:
Those two revisions seemed to just subtly move things around, but they caused API-breaking changes that caused real problems.
This effectively reverts the parts of those changes that caused the breakages.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::addExtraFieldsToRequest):
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::acceptHeaderValueFromType):
(WebCore::acceptHeaderValueFromType): Deleted.
- loader/cache/CachedResourceRequest.h:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(TEST):
- 5:10 PM Changeset in webkit [263547] by
-
- 5 edits in trunk/Source/WebKit
Unreviewed, reverting r263545.
Patch will need refining
Reverted changeset:
"[iOS] Network process is crashing when launching TJMaxx app
due to invalid NetworkProcess::DestroySession IPC message"
https://bugs.webkit.org/show_bug.cgi?id=213625
https://trac.webkit.org/changeset/263545
- 4:50 PM Changeset in webkit [263546] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION(r263035): stress/get-prototype-of.js broken on s390x
https://bugs.webkit.org/show_bug.cgi?id=213307
Reviewed by Ross Kirsling.
Structure::m_outOfLineTypeFlags is uint16_t. If we access this field as 32bit field, we have different value in big endian architectures.
Since we do not have half-size-load branch instructions, we should load this uint16_t value vialoadh(which zero-extends the loaded value)
and perform branch onto that value.
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::emitLoadPrototype):
- llint/LowLevelInterpreter64.asm:
- 4:43 PM Changeset in webkit [263545] by
-
- 5 edits in trunk/Source/WebKit
[iOS] Network process is crashing when launching TJMaxx app due to invalid NetworkProcess::DestroySession IPC message
https://bugs.webkit.org/show_bug.cgi?id=213625
<rdar://problem/64737890>
Reviewed by Geoffrey Garen.
The app is calling [WKWebsiteDataStore init] despite the method being marked as unavailable in
WKWebsiteDataStore.h. As a result, they end up with a WKWebsiteDataStore object whose internal
_websiteDataStore is bad because its constructor was never called. When [WKWebsiteDataStore dealloc]
gets called later own, it calls the ~WebsiteDataStore() destructor for _websiteDataStore but its
m_sessionID is 0 because we never called the constructor. This causes us to send a
NetworkProcess::DestroySession IPC with a sessionID that is 0, which is not valid so the
NetworkProcess crashes.
To address the issue, we now provide an implementation of [WKWebsiteDataStore init] which returns nil
behind a linked-on-after check (since this crashes the app). To keep the app working,
[WKWebsiteDataStore init] returns the default data store until rebuilt with the new SDK. Note that
I tried returning a new ephemeral data store instead but this was getting the app in a bad state.
- UIProcess/API/Cocoa/WKWebsiteDataStore.h:
Mark "new" as unavailable, otherwise [WKWebsiteDataStore new] builds.
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore init]):
Return nil with latest SDK, the default data store otherwise.
- UIProcess/Cocoa/VersionChecks.h:
Add linked-on-after check.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::~WebsiteDataStore):
Add a release assertion to make sure that m_sessionID is always valid when the destructor is called.
- 4:30 PM Changeset in webkit [263544] by
-
- 6 edits in trunk/Source/WebCore
Convert the PaintLayerFlag enum to an enum class
https://bugs.webkit.org/show_bug.cgi?id=213624
Reviewed by Zalan Bujtas.
Convert enum PaintLayerFlag to an enum class.
- html/shadow/MediaControlTextTrackContainerElement.cpp:
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintOverlayScrollbars):
(WebCore::paintForFixedRootBackground):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerWithEffects):
(WebCore::RenderLayer::paintLayerContentsAndReflection):
(WebCore::RenderLayer::filtersForPainting const):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
(WebCore::RenderLayerBacking::paintFlagsForLayer const):
- rendering/RenderReplica.cpp:
(WebCore::RenderReplica::paint):
- 4:27 PM Changeset in webkit [263543] by
-
- 4 edits in branches/safari-610.1.18-branch/Source/WebKit
Cherry-pick r263525. rdar://problem/64778764
Allow service workers for web browsers
https://bugs.webkit.org/show_bug.cgi?id=213573
<rdar://problem/64712630>
Reviewed by Brent Fulgham.
Allows applications with the full web-browser entitlement to use
service workers.
- NetworkProcess/ios/NetworkProcessIOS.mm: (WebKit::NetworkProcess::parentProcessHasServiceWorkerEntitlement const):
- UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _setupPageConfiguration:]):
- WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::parentProcessHasServiceWorkerEntitlement const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:27 PM Changeset in webkit [263542] by
-
- 4 edits in branches/safari-610.1.18-branch/Source/WTF
Cherry-pick r263524. rdar://problem/64778728
WTF::callOnMainThread should not require the main runloop to be initialized
https://bugs.webkit.org/show_bug.cgi?id=213612
<rdar://problem/64446028>
Reviewed by Yusuke Suzuki.
When using JavaScriptCore as a framework, the WTF main runloop is never initialized. However,
the inspector uses CFString wrappers, which usecallOnMainThreadwhen deallocating the
underlying string. For now, we bring back the oldJSWTFMainThreadCallerto ensure we have
a way of dispatching to the main thread, even when the main runloop hasn't been initialized.
- wtf/RunLoop.cpp: (WTF::RunLoop::mainIfExists):
- wtf/RunLoop.h:
- wtf/cocoa/MainThreadCocoa.mm: (-[JSWTFMainThreadCaller call]): (WTF::initializeMainThreadPlatform): (WTF::scheduleDispatchFunctionsOnMainThread):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:27 PM Changeset in webkit [263541] by
-
- 2 edits in branches/safari-610.1.18-branch/Source/WebCore
Cherry-pick r263521. rdar://problem/64778782
App-bound domain service worker registrations should be limited
https://bugs.webkit.org/show_bug.cgi?id=213601
<rdar://problem/64717589>
Reviewed by Brent Fulgham.
Limit number of service worker registrations for app-bound domains.
The current proposal is 3, but this could be changed in the future.
No new tests, currently TestWebKitAPI is unable to test failed
service worker registration (test will timeout). Confirmed behavior
manually.
- workers/service/server/SWServer.cpp: (WebCore::SWServer::validateRegistrationDomain):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:22 PM Changeset in webkit [263540] by
-
- 8 edits in branches/safari-610.1.18-branch/Source
Versioning.
WebKit-610.1.18.2
- 3:44 PM Changeset in webkit [263539] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for http/tests/cookies/third-party-cookie-relaxing.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=213620
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-25
- platform/mac/TestExpectations:
- 3:41 PM Changeset in webkit [263538] by
-
- 3 edits4 adds in trunk
[iOS] Event region briefly missing editable element after typing second character in question field on discussions.apple.com
https://bugs.webkit.org/show_bug.cgi?id=213618
<rdar://problem/62656131>
Reviewed by Simon Fraser.
Source/WebCore:
Ensure the event region is updated for the foreground layer, if there is one. The foreground layer paints
into a different backing and so will not be included in normal layer paint (i.e. RenderLayer::paintLayer()
will bail out). A "z-index: -1" can create such a layer. An element with "z-index: -1" is above the
background, but below other content. Although the original reported bug was only concerned about the
editable region the fix is applicable to all regions tracked by EventRegion. I included a test for touch-action
region too.
Tests: editing/editable-region/text-field-inside-composited-negative-z-index-layer.html
pointerevents/ios/touch-action-none-relative-inside-composited-negative-z-index-layer.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateEventRegion):
LayoutTests:
Add some tests.
- editing/editable-region/text-field-inside-composited-negative-z-index-layer-expected.txt: Added.
- editing/editable-region/text-field-inside-composited-negative-z-index-layer.html: Added.
- pointerevents/ios/touch-action-none-relative-inside-composited-negative-z-index-layer-expected.txt: Added.
- pointerevents/ios/touch-action-none-relative-inside-composited-negative-z-index-layer.html: Added.
- 3:39 PM Changeset in webkit [263537] by
-
- 4 edits1 add in trunk
iOS Safari incorrectly reports "AppleCoreMedia" as UA string
https://bugs.webkit.org/show_bug.cgi?id=213245
<rdar://problem/64471582>
Reviewed by Youenn Fablet.
Source/WebCore:
Tests: TestWebKitAPI.MediaLoading.UserAgentStringCRABS
TestWebKitAPI.MediaLoading.UserAgentStringHLS
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:request:]):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm: Added.
(TestWebKitAPI::parseUserAgent):
(TestWebKitAPI::TEST):
- 3:39 PM Changeset in webkit [263536] by
-
- 2 edits in branches/safari-609.3.5.1-branch/Source/WebCore
Revert r263522. rdar://problem/64763027
- 3:25 PM Changeset in webkit [263535] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed. Fixing misspellings of 'position'.
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::smartDeleteParagraphSpacers):
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
- rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleText):
- 3:15 PM Changeset in webkit [263534] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk2 Debug ] imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getContributingSources.https.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=213621
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 3:12 PM Changeset in webkit [263533] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r260800): Null Ptr Deref READ @ WTF::Optional<WTF::Seconds>::clear
https://bugs.webkit.org/show_bug.cgi?id=213543
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-06-25
Reviewed by Darin Adler.
Make the test asynchronous since it involves a rAF callback.
- fast/rendering/iframe-window-animation-modifies-iframe-srcdoc-crash.html:
- 3:11 PM Changeset in webkit [263532] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for fast/writing-mode/english-bt-text-with-spelling-marker.html and fast/writing-mode/english-rl-text-with-spelling-marker.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=213619
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-25
- platform/mac-wk2/TestExpectations:
- 3:03 PM Changeset in webkit [263531] by
-
- 8 edits in trunk
[iOS] -_requestTextInputContextsInRect cannot find empty Quip spreadsheet title
https://bugs.webkit.org/show_bug.cgi?id=213564
<rdar://problem/59355847>
Reviewed by Simon Fraser.
Source/WebCore:
Special case for a focused editable inline element that has no line box, which is
what the Quip spreadsheet title can become if its contents are deleted. The engine
optimizes to avoid creating lines and line boxes for empty inlines, hit testing,
and painting them. It's complicated to patch all this up with a 100% correct
solution without forcing more line box creation. So, just add a special case.
- page/Page.cpp:
(WebCore::Page::editableElementsInRect const): Add the root editable element of
the focused element to the result set if its rect intersects the search rect. Note
that its rect can be empty e.g. <span contenteditable="true"></span>. So, I use
a new function on FloatRect to perform the intersection test. I also updated the
ASSERT() to also use this new function. This was not necessary, but I did it to
future the proof this code should hit testing one day return empty inlines.
- platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::inclusivelyIntersects const): Added.
(WebCore::FloatRect::intersects const): While I was in this file I fixed up a comment
in this function to be more precise.
- platform/graphics/FloatRect.h:
Source/WebKit:
Check if the search rect intersects the interaction rect, even if it's empty, so long as
there is an assisted element. If there isn't an assisted element just do what we do now.
Otherwise, if the interaction rect is empty then this means the focused element is an
empty inline and it's not tracked in the editable region (see WebCore ChangeLog entry for
more details). In this case, just ask the web process directly to find the contexts.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _requestTextInputContextsInRect:completionHandler:]):
Tools:
Add some tests.
- TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
(TestWebKitAPI::TEST):
- 2:19 PM Changeset in webkit [263530] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix the macOS 11 build after r263519
- rendering/RenderThemeMac.mm:
(WebCore::createAttachmentPlaceholderImage):
- 2:13 PM Changeset in webkit [263529] by
-
- 7 edits2 adds in trunk
Add a new templated string type to help write more idiomatic parsing code
https://bugs.webkit.org/show_bug.cgi?id=213588
Reviewed by Darin Adler.
Source/WTF:
Introduce StringParsingBuffer<CharType>, a new class in the String class family
designed to be used by parsing code. It's designed to be used with the helper
function, readCharactersForParsing, and for the user to write the parsing code
in a way that will work for both latin1 and UTF-16 inputs. Most usage will likely
follow something like the following form
{
...
auto parsedResult = readCharactersForParsing(stringishObjectToParse, [](auto parsingBuffer) {
while (parsingBuffer.hasCharactersRemaining()) {
if (*parsingBuffer == foo) {
...
}
}
...
return parsedResult
});
...
}
API tests added.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
Add StringParsingBuffer.h
- wtf/Forward.h:
Forward declare StringParsingBuffer.
- wtf/text/StringParsingBuffer.h:
Added.
Tools:
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/StringParsingBuffer.cpp: Added.
(TestWebKitAPI::TEST):
Added new tests for new class.
- 1:57 PM Changeset in webkit [263528] by
-
- 3 edits4 adds in trunk
Cannot delete last line of Mail Message
https://bugs.webkit.org/show_bug.cgi?id=213536
<rdar://problem/63420928>
Reviewed by Wenson Hsieh.
Source/WebCore:
LayoutTests/editing/deleting/smart-delete-paragraph-005.html
The smart paragraph deletion code did not take into account that
the previous blank line could be the start of editable content without
a paragraph before it. If this was the case, the deletion code backed up
too far, and the delete command failed. This case should be handled
in the same way that the deleting the last paragraph in editable content is
handled, by checking if we are already at the beginning of the editable
content when expanding the selection for smart paragraph deletion.
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::smartDeleteParagraphSpacers):
LayoutTests:
- editing/deleting/smart-delete-paragraph-005.html:
- 1:37 PM Changeset in webkit [263527] by
-
- 13 edits2 adds in trunk
Text manipulation should exclude text rendered using icon-only fonts
https://bugs.webkit.org/show_bug.cgi?id=213446
<rdar://problem/63734298>
Reviewed by Myles Maxfield.
Source/WebCore:
See below for more details.
Test: TextManipulation.StartTextManipulationExcludesTextRenderedAsIcons
- editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::shouldExcludeNodeBasedOnStyle):
(WebCore::TextManipulationController::parse):
Augment token exclusion rules so that we're able to exclude certain text nodes from text manipulation, based on
their style (more specifically, based on their font family). Ask the text node's primary font if it is likely to
be used only for rendering icons, and cache the result in TextManipulationController to avoid running the
heuristic an excessive number of times for each font that appears in the document. We currently only run this
for the node's primary font when initiating translation, though we may want to change this in the future so that
node exclusion is recomputed when the primary font of a node changes.
Note that in the case where an icon font fails to load, we won't exclude the text node from translation,
since the primary font will be a fallback. This is intentional, since the node would appear in the document as
normally rendered text (rather than icons), which should be translated.
- editing/TextManipulationController.h:
- platform/graphics/Font.cpp:
(WebCore::Font::isProbablyOnlyUsedToRenderIcons const):
- platform/graphics/Font.h:
- platform/graphics/FontPlatformData.cpp:
(WebCore::FontPlatformData::familyName const):
- platform/graphics/FontPlatformData.h:
- platform/graphics/cocoa/FontCocoa.mm:
(WebCore::Font::isProbablyOnlyUsedToRenderIcons const):
Add a heuristic to detect whether a platform font should be excluded from text manipulation. For now, we only
return true if we suspect that this font is an "icon-only" font (for instance, the "Material Icons" font). We
guess that a font is *probably* an icon-only font if the font supports only characters from the basic or PUA
unicode planes, and the glyph bounds for the set of supported non-control basic latin characters are all empty.
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::familyName const):
Add a platform
familyName()helper method onFontPlatformData. On Cocoa platforms, this wraps a call to
CTFontCopyFamilyName.
Tools:
Add a new API test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/Ahem.ttf: Added.
- TestWebKitAPI/Tests/WebKitCocoa/SpaceOnly.otf: Added.
- TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):
- 1:28 PM Changeset in webkit [263526] by
-
- 1 copy in tags/Safari-609.3.5.0.2
Tag Safari-609.3.5.0.2.
- 1:04 PM Changeset in webkit [263525] by
-
- 4 edits in trunk/Source/WebKit
Allow service workers for web browsers
https://bugs.webkit.org/show_bug.cgi?id=213573
<rdar://problem/64712630>
Reviewed by Brent Fulgham.
Allows applications with the full web-browser entitlement to use
service workers.
- NetworkProcess/ios/NetworkProcessIOS.mm:
(WebKit::NetworkProcess::parentProcessHasServiceWorkerEntitlement const):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setupPageConfiguration:]):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::parentProcessHasServiceWorkerEntitlement const):
- 12:38 PM Changeset in webkit [263524] by
-
- 4 edits in trunk/Source/WTF
WTF::callOnMainThread should not require the main runloop to be initialized
https://bugs.webkit.org/show_bug.cgi?id=213612
<rdar://problem/64446028>
Reviewed by Yusuke Suzuki.
When using JavaScriptCore as a framework, the WTF main runloop is never initialized. However,
the inspector uses CFString wrappers, which usecallOnMainThreadwhen deallocating the
underlying string. For now, we bring back the oldJSWTFMainThreadCallerto ensure we have
a way of dispatching to the main thread, even when the main runloop hasn't been initialized.
- wtf/RunLoop.cpp:
(WTF::RunLoop::mainIfExists):
- wtf/RunLoop.h:
- wtf/cocoa/MainThreadCocoa.mm:
(-[JSWTFMainThreadCaller call]):
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
- 12:32 PM Changeset in webkit [263523] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSCell constructor needs to ensure that the passed in structure is still alive.
https://bugs.webkit.org/show_bug.cgi?id=213593
<rdar://problem/64597573>
Reviewed by Yusuke Suzuki.
Note that in the initializer list of the
JSCell(VM&, Structure*)constructor,
we are only using values inside the passed in structure but not necessarily the
structure pointer itself. All these values are contained inside Structure::m_blob.
Note also that this constructor is an inline function. Hence, the compiler may
choose to pre-compute the address of structure->m_blob and discard the structure
pointer itself.
Here's an example:
0x10317a21e <+1054>: movq 0x18(%rsp), %rdx rdx:vm = &vm
0x10317a223 <+1059>: addq $0x8, %r13 r13 = &structure.m_blob <== pre-compute address of m_blob !!!
r13 previously contained the structure pointer.
Now, there's no more references to the structure base address.
0x10317a227 <+1063>: leaq 0x48(%rdx), %rdi arg0:heap = &vm.heap
0x10317a22b <+1067>: movl $0x10, %edx arg2:size = 16.
0x10317a230 <+1072>: movq %rdi, 0x28(%rsp)
0x10317a235 <+1077>: xorl %esi, %esi arg1:deferralContext = 0
0x10317a237 <+1079>: callq 0x10317ae60 call JSC::allocateCell<JSC::JSArray> <== Can GC here !!!
0x10317a23c <+1084>: movq %rax, %rbx rbx:cell = rax:allocation result.
...
0x10317a253 <+1107>: movl (%r13), %eax eax = m_blob.structureID <== Use pre-computed m_blob address here.
There's a chance that the GC may run while allocating this cell. In the event
that the structure is newly instantiated just before calling this constructor,
there may not be any other references to it. As a result, the structure may get
collected before the cell is even constructed. To avoid this possibility, we need
to ensure that the structure pointer is still alive by the time this constructor
is called.
I am not committing any tests for this issue because the test cases relies on:
- Manually forcing an O3 ASan Release build.
- Not running jsc with --useDollarVM=1. Note: the JSC test harness automatically adds --useDollarVM=1 for all test runs.
- Memory being allocated in a specific order. The recent Bitmap FreeList change enabled this issue to manifest. The old linked list FreeList implementation would have hidden the issue.
- Adding some logging code can also make the issue stop manifesting.
In short, the test cases will not detect any regression even if we commit them
because the existing automatic regression test runs will not have the necessary
conditions for reproducing the issue. The tests are also somewhat fragile where
any changes in memory layout may stop the issue from manifesting in an observable
way.
- runtime/JSCellInlines.h:
(JSC::JSCell::JSCell):
- 11:21 AM Changeset in webkit [263522] by
-
- 2 edits in branches/safari-609.3.5.1-branch/Source/WebCore
Apply patch. rdar://problem/64763027
- 11:16 AM Changeset in webkit [263521] by
-
- 2 edits in trunk/Source/WebCore
App-bound domain service worker registrations should be limited
https://bugs.webkit.org/show_bug.cgi?id=213601
<rdar://problem/64717589>
Reviewed by Brent Fulgham.
Limit number of service worker registrations for app-bound domains.
The current proposal is 3, but this could be changed in the future.
No new tests, currently TestWebKitAPI is unable to test failed
service worker registration (test will timeout). Confirmed behavior
manually.
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::validateRegistrationDomain):
- 11:01 AM Changeset in webkit [263520] by
-
- 8 edits in branches/safari-609.3.5.1-branch/Source
Versioning.
WebKit-609.3.5.1.4
- 10:39 AM Changeset in webkit [263519] by
-
- 5 edits in trunk/Source/WebCore
Upstream macOS 11 additions to RenderThemeMac.mm and ThemeMac.mm
https://bugs.webkit.org/show_bug.cgi?id=213608
<rdar://problem/64758299>
Reviewed by Darin Adler.
Replace WebKitAdditions imports with the imported code. No change in behavior.
- css/html.css:
(input::-webkit-contacts-auto-fill-button):
- platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::supportsLargeFormControls):
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::createAttachmentPlaceholderImage):
(WebCore::RenderThemeMac::extraDefaultStyleSheet): Deleted.
Remove the override for extraDefaultStyleSheet altogether, since this was only used to temporarily hide the new
contact AutoFill button appearance from open source WebKit.
- 10:37 AM Changeset in webkit [263518] by
-
- 2 edits in trunk/Tools
[ews] Share more bots between EWS builder and testers
https://bugs.webkit.org/show_bug.cgi?id=213521
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/config.json:
- 10:16 AM Changeset in webkit [263517] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Unreviewed, fix a ChangeLog typo that was checked in with r263515.
- 10:09 AM Changeset in webkit [263516] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for WebXR enabled non-OpenXR builds.
- platform/xr/openxr/PlatformXROpenXR.cpp:
(PlatformXR::Instance::Impl::enumerateApiLayerProperties const): Guard method with USE_OPENXR.
(PlatformXR::Instance::Impl::enumerateInstanceExtensionProperties const): Ditto.
(PlatformXR::Instance::Impl::Impl): Guard method body with USE_OPENXR.
(PlatformXR::Instance::Impl::~Impl): Ditto.
- 9:59 AM Changeset in webkit [263515] by
-
- 2 edits in trunk/LayoutTests
:wq2020-06-25 Karl Rackler <Karl Rackler>
Remove expectation for fast/dynamic/window-resize-scrollbars-test.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=213602
Unreviewed test gardening.
- platform/wk2/TestExpectations:
- 9:55 AM Changeset in webkit [263514] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed iOS build fix after r263511.
- platform/mediastream/MediaStreamPrivate.h:
- 9:47 AM Changeset in webkit [263513] by
-
- 2 edits in trunk/Tools
[ews] Improve handling of invalid changelog
https://bugs.webkit.org/show_bug.cgi?id=213609
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/tool/steps/validatereviewer.py:
(ValidateReviewer.run):
- 9:43 AM Changeset in webkit [263512] by
-
- 2 edits in trunk/LayoutTests
Narrow expectation for fast/inline/break-between-nobr.html as it is passing for Catalina.
https://bugs.webkit.org/show_bug.cgi?id=213607
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-25
- platform/mac/TestExpectations:
- 8:58 AM Changeset in webkit [263511] by
-
- 14 edits2 adds in trunk
MediaRecorder stopRecorder() returns empty Blob after first use
https://bugs.webkit.org/show_bug.cgi?id=212274
<rdar://problem/63601298>
Reviewed by Eric Carlson.
Source/WebCore:
Refactor code to create/destroy MediaRecorderPrivate on MediaRecorder start/stop.
This allows reusing a MediaRecorder after a stop and restarting with a clean state.
We introduce MediaRecorderPrivate::startRecording to do the initialization,
which allows to fix a potential ref cycle as part of the error callback handling.
Make some improvements to the platform implementation, in particular add default initialization to all fields.
Align the code using AudioConverterRef to what is done in AudioSampleDataSource.
Also call VTCompressionSessionInvalidate when destroying the VideoSampleBufferCompressor.
Test: http/wpt/mediarecorder/MediaRecorder-multiple-start-stop.html
- Modules/mediarecorder/MediaRecorder.cpp:
(WebCore::MediaRecorder::create):
(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::startRecording):
(WebCore::MediaRecorder::stopRecording):
(WebCore::MediaRecorder::requestData):
- Modules/mediarecorder/MediaRecorder.h:
- platform/mediarecorder/MediaRecorderPrivate.h:
(WebCore::MediaRecorderPrivate::startRecording):
- platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h:
- platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:
(WebCore::AudioSampleBufferCompressor::~AudioSampleBufferCompressor):
(WebCore::AudioSampleBufferCompressor::initAudioConverterForSourceFormatDescription):
(WebCore::AudioSampleBufferCompressor::attachPrimingTrimsIfNeeded):
(WebCore::AudioSampleBufferCompressor::gradualDecoderRefreshCount):
(WebCore::AudioSampleBufferCompressor::sampleBufferWithNumPackets):
(WebCore::AudioSampleBufferCompressor::processSampleBuffersUntilLowWaterTime):
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::MediaRecorderPrivateWriter::stopRecording):
- platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:
(WebCore::VideoSampleBufferCompressor::~VideoSampleBufferCompressor):
Source/WebKit:
Update implementation to do initialization as part of startRecording.
- GPUProcess/webrtc/RemoteMediaRecorderManager.cpp:
(WebKit::RemoteMediaRecorderManager::releaseRecorder):
Remove ASSERT as recorder creation in WebProcess is always ok while creation in GPUProcess may fail and m_recorders may not be populated.
- WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
(WebKit::MediaRecorderPrivate::MediaRecorderPrivate):
(WebKit::MediaRecorderPrivate::startRecording):
- WebProcess/GPU/webrtc/MediaRecorderPrivate.h:
LayoutTests:
- http/wpt/mediarecorder/MediaRecorder-multiple-start-stop-expected.txt: Added.
- http/wpt/mediarecorder/MediaRecorder-multiple-start-stop.html: Added.
- 8:40 AM Changeset in webkit [263510] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for fast/history/page-cache-indexed-closed-db.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=213606
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-25
- 8:19 AM Changeset in webkit [263509] by
-
- 4 edits2 adds in trunk
[LFC][TFC] Use the flexing value as the base for the available horizontal space distribution
https://bugs.webkit.org/show_bug.cgi?id=213599
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/layoutformattingcontext/table-min-max-flex-distribution-simple.html
- layout/tableformatting/TableLayout.cpp:
(WebCore::Layout::TableFormattingContext::TableLayout::distributedHorizontalSpace):
LayoutTests:
- fast/layoutformattingcontext/table-fixed-width-with-max-distribution.html:
- fast/layoutformattingcontext/table-min-max-flex-distribution-simple-expected.html: Added.
- fast/layoutformattingcontext/table-min-max-flex-distribution-simple.html: Added.
- 8:03 AM Changeset in webkit [263508] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for fast/canvas/canvas-blending-fill-style.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=213598
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-25
- platform/mac/TestExpectations:
- 7:27 AM Changeset in webkit [263507] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: (r262432): [ iOS wk2 ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=212696
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 6:42 AM Changeset in webkit [263506] by
-
- 4 edits2 adds in trunk
REGRESSION (r260360): easing curves are broken on JS-originated animations
https://bugs.webkit.org/show_bug.cgi?id=213495
<rdar://problem/64649747>
Reviewed by Darin Adler.
Source/WebCore:
Prior to Web Animations, there was no way for an animation to set an animation-wide timing function while
also setting a per-keyframe timing function. As such GraphicsLayerCA would sometimes decide to set the
timing function on keyframes or on the entire CAAnimation. However, we can no longer do this with Web
Animations where an animation can set an animation-wide timing function and also keyframe-specific
timing functions.
In this patch we create CAKeyframeAnimation objects for any animation that has at least two keyframes
if Web Animations are enabled, whereas the legacy code path requires at least three keyframes. We allow
PlatformCAAnimation::setTimingFunction() to be called in the Web Animations code path only under
GraphicsLayerCA::setupAnimation() while leaving the only call sites in place only for the legacy code
path.
Finally, we modify GraphicsLayerCA::timingFunctionForAnimationValue() to only ever return a keyframe-
specific timing function or fall back to a default linear timing function in the Web Animations code
path, leaving the function to behave the same way as it used to in the legacy code path.
Test: webanimations/accelerated-animation-with-easing.html
- platform/animation/TimingFunction.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::isKeyframe):
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
LayoutTests:
Add a new test that checks that various ways of setting the easing timing function on a JS-originated
animation always yield the same visible animation behavior.
- webanimations/accelerated-animation-with-easing-expected.html: Added.
- webanimations/accelerated-animation-with-easing.html: Added.
- 6:09 AM Changeset in webkit [263505] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, WPE Debug build fix after r263503.
- platform/xr/openxr/PlatformXROpenXR.cpp:
(PlatformXR::OpenXRDevice::OpenXRDevice): Use m_instance instead of m_impl->xrInstance().
- 6:02 AM Changeset in webkit [263504] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Don't invalidate MainThreadNotifier until the streaming threads are joined
https://bugs.webkit.org/show_bug.cgi?id=213197
Reviewed by Xabier Rodriguez-Calvar.
~MediaPlayerPrivateGStreamer() used to call m_notifier->invalidate()
before setting the pipeline to NULL state. This caused a race where
the streaming threads could post a task to the MainThreadNotifier
between these two events and cause a crash in
ASSERT(m_isValid.load()) -- that is, the notifier was used while
invalidated.
Fixing this is actually easy. ~MediaPlayerPrivateGStreamer() is always
run from the main thread, so no MainThreadNotifier tasks will be run
before the destructor is complete. By moving the
m_notifier->invalidate() call to after the pipeline has been set to
NULL (and therefore all streaming threads torn down) we are ensuring
no more taks will be posted, and since the MainThreadNotifier is
invalidated by that point, already posted tasks will not be run.
The race fixed by this patch is rare and wide-arching, so this patch
doesn't introduce TestExpectations changes, but it should avoid
further crashes like the ones reported in the Bugzilla issue attached.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
- 3:49 AM Changeset in webkit [263503] by
-
- 6 edits in trunk/Source/WebCore
[WebXR] Check device orientation support when requesting a reference space
https://bugs.webkit.org/show_bug.cgi?id=213519
Reviewed by Carlos Garcia Campos.
When requesting a local reference space the specs mandate us to check whether or not the device
supports orientation tracking. This was not implemented in the OpenXR backend, so we were unconditionally
returning true.
The OpenXR devices now properly check whether or not orientation tracking is initialized. We took the chance
to refactor a bit the OpenXR backend moving all the device initialization code to the OpenXRDevice class.
The current tests already check this functionality.
- Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::referenceSpaceIsSupported const): Call supportsOrientationTracking() on device.
- platform/xr/PlatformXR.h:
(PlatformXR::Device::supportsOrientationTracking const): Added.
- platform/xr/openxr/PlatformXROpenXR.cpp:
(PlatformXR::Instance::enumerateImmersiveXRDevices): Just create the OpenXR device, it will automatically
initialize itself.
(PlatformXR::OpenXRDevice::OpenXRDevice): Get XrSystem and XrInstance as parametters.
(PlatformXR::OpenXRDevice::collectSupportedSessionModes): Moved from Instance::Impl.
(PlatformXR::Instance::Impl::collectSupportedSessionModes): Deleted.
- platform/xr/openxr/PlatformXROpenXR.h:
- testing/WebFakeXRDevice.h: Mark the SimulatedXRDevice as supporting orientation tracking.
- 3:16 AM Changeset in webkit [263502] by
-
- 3 edits in trunk/LayoutTests
Make video-inside-flex-item.html more robust
https://bugs.webkit.org/show_bug.cgi?id=213549
Reviewed by Simon Fraser.
The tests initially landed in r263389 and was later modified in r263436 because it was flaky
in some configurations. The latter fixed most of the flakiness but in the debug bots which
were consistently showing test failures. The problem was that the slowness of debug bots
was causing different layout behaviours and thus retrieving different measurements.
Fix the flackiness by adding an additional layer of robustness. The test now waits for the "loadeddata"
video event before entering into fullscreen mode. Video is properly sized now and we can
bring exact size comparisons back.
- fullscreen/video-inside-flex-item-expected.txt:
- fullscreen/video-inside-flex-item.html:
- 2:53 AM Changeset in webkit [263501] by
-
- 2 edits in trunk
[GTK] Enable WEB_API_STATISTICS
https://bugs.webkit.org/show_bug.cgi?id=213592
Reviewed by Carlos Garcia Campos.
- Source/cmake/OptionsGTK.cmake:
