Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Aug 28, 2020:

11:57 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

10:13 PM Changeset in webkit [266321] by Ryan Haddad

• 24 edits in branches/safari-610.1.28.0-branch/LayoutTests/imported/w3c/web-platform-tests/webaudio

Cherry-pick r266315. rdar://problem/67367072

Rebaseline WebAudio test results
<rdar://problem/67367072>

1. r265824 changed what error message is. (This is unavoidable since the kind of thrown error is changed (JS side error v.s. JS error thrown from C++), and this needs to be done to fix the reported webpage’s issue).
2. This error is recorded as expect files in various WebAudio WPT test if the tested WebAudio constructors are not implemented.
3. After that branch cut, a lot of WebAudio constructors are newly implemented, which removes this error messages from expect files.
4. r265824 is landed after these WebAudio patches. So it does not include rebaseline for these WebAudio WPT tests (since it is no longer including that error messages).
5. But in that branch, these WebAudio patches are not cherry-picked. This means that error message is still recorded in WPT expect files.
6. So, we just need to update these expect files, or cherry-pick these WebAudio patches. And I think updating expect files is the way to go.

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-610.1.28.1-branch@266315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:30 PM Changeset in webkit [266320] by Lauro Moura

• 2 edits
  4 adds
  1 delete in trunk/LayoutTests

[WPE] Gardening and rebaselining

Unreviewed test gardening.

• platform/wpe/TestExpectations:
• platform/wpe/imported/w3c/web-platform-tests/html/editing/dnd/datastore/datatransfer-constructor-001-expected.txt:

Added with specific failure due to DRAG_SUPPORT not enabled.

• platform/wpe/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw-manual.https-expected.txt: Removed.

7:32 PM Changeset in webkit [266319] by Chris Dumez

• 26 edits in trunk

Update PannerNode to support k-rate automation of its AudioParams
​https://bugs.webkit.org/show_bug.cgi?id=215901

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-equalpower-stereo-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-position-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-stereo-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/test-pannernode-automation-expected.txt:

Source/WebCore:

Update PannerNode to support k-rate automation of its AudioParams.

This patch is based on Chromium's implementation and the following
change in particular:

• ​https://chromium-review.googlesource.com/c/chromium/src/+/2096786

No new tests, rebaselined existing tests.

• Modules/webaudio/AudioListener.cpp:

(WebCore::AudioListener::AudioListener):
(WebCore::AudioListener::hasSampleAccurateValues const):
(WebCore::AudioListener::shouldUseARate const):
(WebCore::AudioListener::updateValuesIfNeeded):
(WebCore::AudioListener::positionXValues):
(WebCore::AudioListener::positionYValues):
(WebCore::AudioListener::positionZValues):
(WebCore::AudioListener::forwardXValues):
(WebCore::AudioListener::forwardYValues):
(WebCore::AudioListener::forwardZValues):
(WebCore::AudioListener::upXValues):
(WebCore::AudioListener::upYValues):
(WebCore::AudioListener::upZValues):
Add functions to retrieve sample accurate values from the AudioListener's
AudioParams. Those values are cached for performance.

(WebCore::AudioListener::setPosition):
Call AudioParam::setValueAtTime(value, now) instead of
AudioParam::setValue(), as per:

• ​https://www.w3.org/TR/webaudio/#dom-audiolistener-setposition

(WebCore::AudioListener::setOrientation):
Call AudioParam::setValueAtTime(value, now) instead of
AudioParam::setValue(), as per:

• ​https://www.w3.org/TR/webaudio/#dom-audiolistener-setorientation

• Modules/webaudio/AudioListener.h:
• Modules/webaudio/AudioListener.idl:

Update IDL to indicate that setPosition() / setOrientation() may now
throw exceptions.

• Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateFinalValues):
If we're not sample accurate, make sure we duplicate the first element of
|values| to other elements. Some WPT tests kept failing without this change.

• Modules/webaudio/AudioParam.h:
• Modules/webaudio/AudioParamTimeline.h:

(WebCore::AudioParamTimeline::hasValues const):
Add more constness.

• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::process):
(WebCore::PannerNode::processSampleAccurateValues):
Add support for k-rate automation of PannerNode's AudioParams.

(WebCore::PannerNode::hasSampleAccurateValues const):
(WebCore::PannerNode::shouldUseARate const):
(WebCore::PannerNode::setPanningModel):

(WebCore::PannerNode::setPosition):
Call AudioParam::setValueAtTime(value, now) instead of
AudioParam::setValue(), as per:

• ​https://www.w3.org/TR/webaudio/#dom-pannernode-setposition

(WebCore::PannerNode::setOrientation):
Call AudioParam::setValueAtTime(value, now) instead of
AudioParam::setValue(), as per:

• ​https://www.w3.org/TR/webaudio/#dom-pannernode-setorientation

(WebCore::PannerNode::setDistanceModel):
(WebCore::PannerNode::setRefDistance):
(WebCore::PannerNode::setMaxDistance):
(WebCore::PannerNode::setRolloffFactor):
(WebCore::PannerNode::setConeOuterGain):
(WebCore::PannerNode::setConeOuterAngle):
(WebCore::PannerNode::setConeInnerAngle):
(WebCore::PannerNode::setChannelCount):
(WebCore::PannerNode::setChannelCountMode):
(WebCore::PannerNode::calculateAzimuthElevation):
(WebCore::PannerNode::azimuthElevation):
(WebCore::PannerNode::calculateDistanceConeGain):
(WebCore::PannerNode::distanceConeGain):

• Modules/webaudio/PannerNode.h:
• Modules/webaudio/PannerNode.idl:
• platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::calculateDesiredGain):
(WebCore::EqualPowerPanner::panWithSampleAccurateValues):

• platform/audio/EqualPowerPanner.h:
• platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::panWithSampleAccurateValues):

• platform/audio/HRTFPanner.h:
• platform/audio/Panner.h:

LayoutTests:

Unskip a few tests that should no longer be flaky since they are now passing.

• TestExpectations:

7:26 PM Changeset in webkit [266318] by ysuzuki@apple.com

• 6 edits in trunk

[JSC] new import.meta() is acceptable
​https://bugs.webkit.org/show_bug.cgi?id=215915

Reviewed by Ross Kirsling.

JSTests:

• stress/modules-syntax-error.js:
• stress/modules-syntax.js:
• test262/expectations.yaml:

Source/JavaScriptCore:

new import.meta() is valid in terms of syntax while it throws runtime error.
We should accept this code, while new import() is not correct syntax.

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseMemberExpression):

6:39 PM Changeset in webkit [266317] by Devin Rousso

• 40 edits
  2 adds in trunk

Web Inspector: Audit: should be able to create/edit imported audits
​https://bugs.webkit.org/show_bug.cgi?id=215555
<rdar://problem/67255483>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Extend the existing audit edit mode (which previously only let audits be disabled/deleted)
to also allow other JSON properties of audits to be added/edited/removed, meaning that
audits can now be completely created/configured from within the Web Inspector UI. \(o.o)/

• UserInterface/Models/AuditTestBase.js:

(WI.AuditTestBase):
(WI.AuditTestBase.prototype.set name): Added.
(WI.AuditTestBase.prototype.set description): Added.
(WI.AuditTestBase.prototype.get supports): Added.
(WI.AuditTestBase.prototype.set supports): Added.
(WI.AuditTestBase.prototype.get setup): Added.
(WI.AuditTestBase.prototype.set setup): Added.
(WI.AuditTestBase.prototype.set disabled):
(WI.AuditTestBase.prototype.get editable): Added.
(WI.AuditTestBase.prototype.get default): Added.
(WI.AuditTestBase.prototype.markAsDefault): Added.
(WI.AuditTestBase.prototype.get topLevelTest): Added.
(WI.AuditTestBase.prototype.async runSetup): Added.
(WI.AuditTestBase.prototype.async start()):
(WI.AuditTestBase.prototype.stop()):
(WI.AuditTestBase.prototype.async clone): Added.
(WI.AuditTestBase.remove): Added.
(WI.AuditTestBase.saveIdentityToCookie):
(WI.AuditTestBase.toJSON):
(WI.AuditTestBase.prototype.determineIfSupported): Added.
(WI.AuditTestBase.prototype.updateSupported): Added.
(WI.AuditTestBase.prototype.updateResult): Added.
(WI.AuditTestBase.prototype.set supported): Deleted.
(WI.AuditTestBase.async setup): Deleted.
(WI.AuditTestBase.prototype.async setup): Deleted.

• UserInterface/Models/AuditTestGroup.js:

(WI.AuditTestGroup):
(WI.AuditTestGroup.prototype.addTest): Added.
(WI.AuditTestGroup.prototype.removeTest): Added.
(WI.AuditTestGroup.prototype.clearResult):
(WI.AuditTestGroup.prototype.async run):
(WI.AuditTestGroup.prototype.determineIfSupported): Added.
(WI.AuditTestGroup.prototype.updateSupported): Added.
(WI.AuditTestGroup.prototype.updateResult): Added.
(WI.AuditTestGroup.prototype._checkDisabled): Added.
(WI.AuditTestGroup.prototype._handleTestCompleted):
(WI.AuditTestGroup.prototype._handleTestDisabledChanged):
(WI.AuditTestGroup.prototype._handleTestSupportedChanged): Added.
(WI.AuditTestGroup.prototype._handleTestChanged): Added.
(WI.AuditTestGroup.prototype.get supported): Deleted.
(WI.AuditTestGroup.prototype.set supported): Deleted.
(WI.AuditTestGroup.prototype.get disabled): Deleted.
(WI.AuditTestGroup.prototype.set disabled): Deleted.
(WI.AuditTestGroup.prototype._updateResult): Deleted.
(WI.AuditTestGroup.prototype._updateResult): Deleted.

• UserInterface/Models/AuditTestCase.js:

(WI.AuditTestCase):
(WI.AuditTestCase.stringifyFunction): Added.
(WI.AuditTestCase.prototype.set test): Added.
(WI.AuditTestCase.prototype.async run):
Allow additional JSON keys to be changed in the UI:

• name
• description
• supports (ensure that changes recalculate whether the audit is actually supported)
• setup
• (groups) tests (via separate add and remove functions)
• (test cases) the actual test function

These properties are expected to only change in edit mode.

• UserInterface/Models/AuditTestResultBase.js:

(WI.AuditTestResultBase.prototype.get disabled): Added.
(WI.AuditTestResultBase.prototype.get editable): Added.
Audit results are never disabled and not editable.

• UserInterface/Controllers/AuditManager.js:

(WI.AuditManager):
(WI.AuditManager.prototype.set editing):
(WI.AuditManager.async start):
(WI.AuditManager.prototype.async start):
(WI.AuditManager.prototype.stop):
(WI.AuditManager.prototype.async processJSON):
(WI.AuditManager.prototype.loadStoredTests):
(WI.AuditManager.prototype.async addTest): Added.
(WI.AuditManager.prototype.removeTest):
(WI.AuditManager.prototype._addDefaultTests):
(WI.AuditManager.prototype._addDefaultTests.removeWhitespace):
(WI.AuditManager.prototype._addTest): Deleted.
(WI.AuditManager.prototype._topLevelTestForTest): Deleted.
Add helper functions and events for when the audit manager running mode changes to update UI.
Also add another default test that demonstrates the supports JSON key.

• UserInterface/Views/AuditNavigationSidebarPanel.js:

(WI.AuditNavigationSidebarPanel.prototype.showDefaultContentView):
(WI.AuditNavigationSidebarPanel.prototype.willDismissPopover): Added.
(WI.AuditNavigationSidebarPanel.prototype.initialLayout):
(WI.AuditNavigationSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
(WI.AuditNavigationSidebarPanel.prototype._addTest):
(WI.AuditNavigationSidebarPanel.prototype._addResult):
(WI.AuditNavigationSidebarPanel.prototype._updateControlNavigationItems): Added.
(WI.AuditNavigationSidebarPanel.prototype._updateEditNavigationItems): Added.
(WI.AuditNavigationSidebarPanel.prototype._handleAuditManagerEditingChanged):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditManagerRunningStateChanged): Added.
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestAdded):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestCompleted):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestRemoved):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestScheduled):
(WI.AuditNavigationSidebarPanel.prototype._treeSelectionDidChange):
(WI.AuditNavigationSidebarPanel.prototype._handleStartStopButtonNavigationItemClicked):
(WI.AuditNavigationSidebarPanel.prototype._handleCreateButtonNavigationItemClicked): Added.
(WI.AuditNavigationSidebarPanel.prototype._updateStartStopButtonNavigationItemState): Deleted.
(WI.AuditNavigationSidebarPanel.prototype._updateEditButtonNavigationItemState): Deleted.

• UserInterface/Views/AuditNavigationSidebarPanel.css:

(.sidebar > .panel.navigation.audit .edit-audits:not(.disabled):active): Added.
(.sidebar > .panel.navigation.audit .edit-audits:not(.disabled).activated): Added.
(.sidebar > .panel.navigation.audit .edit-audits:not(.disabled).activated:active): Added.
(.sidebar > .panel.navigation.audit .edit-audits.disabled): Added.
(.content-view.audit .message-text-view .navigation-item-help:is(.start-editing-audits, .stop-editing-audits) .navigation-bar): Added.
(.content-view.tab.audit .content-view > .audit-version): Added.
(.content-view.tab.audit .content-view .reference-page-link-container): Added.
(body[dir=ltr] .content-view.tab.audit .content-view .reference-page-link-container): Added.
(body[dir=rtl] .content-view.tab.audit .content-view .reference-page-link-container): Added.
(.sidebar > .panel.navigation.audit > .content .edit-audits:not(.disabled):active): Deleted.
(.sidebar > .panel.navigation.audit > .content .edit-audits:not(.disabled).activated): Deleted.
(.sidebar > .panel.navigation.audit > .content .edit-audits:not(.disabled).activated:active): Deleted.
(.sidebar > .panel.navigation.audit > .content .edit-audits.disabled): Deleted.
(.finish-editing-audits-placeholder.message-text-view .navigation-item-help .navigation-bar): Deleted.
(.audit-version): Deleted.
Move the "Edit" toggle to be next to the filter bar so that it's always visible. Replace the
"[|>] Start" button with a "[+] Create" button when in edit mode, which adds a new audit at
the top-level.

• UserInterface/Views/AuditTestContentView.js:

(WI.AuditTestContentView):
(WI.AuditTestContentView.get navigationItems):
(WI.AuditTestContentView.get supportsSave):
(WI.AuditTestContentView.prototype.createNameElement): Added.
(WI.AuditTestContentView.prototype.createDescriptionElement): Added.
(WI.AuditTestContentView.prototype.createControlsTableElement): Added.
(WI.AuditTestContentView.prototype.layout):
(WI.AuditTestContentView.prototype.shown):
(WI.AuditTestContentView.prototype.hidden):
(WI.AuditTestContentView.prototype.handleResultChanged):
(WI.AuditTestContentView.prototype.showStoppingPlaceholder):
(WI.AuditTestContentView.prototype.showNoResultPlaceholder):
(WI.AuditTestContentView.prototype.showNoResultDataPlaceholder):
(WI.AuditTestContentView.prototype.showFilteredPlaceholder):
(WI.AuditTestContentView.prototype._updateExportNavigationItems): Added.
(WI.AuditTestContentView.prototype._updateSupportsInputState): Added.
(WI.AuditTestContentView.prototype._createSetupEditor): Added.
(WI.AuditTestContentView.prototype._handleEditorKeydown): Added.
(WI.AuditTestContentView.prototype._handleExportTestButtonNavigationItemClicked): Added.
(WI.AuditTestContentView.prototype._handleExportResultButtonNavigationItemClicked): Added.
(WI.AuditTestContentView.prototype._handleTestDisabledChanged): Added.
(WI.AuditTestContentView.prototype._handleTestSupportedChanged): Added.
(WI.AuditTestContentView.prototype._handleEditingChanged): Added.
(WI.AuditTestContentView.prototype._updateExportButtonNavigationItemState): Deleted.
(WI.AuditTestContentView.prototype._handleExportButtonNavigationItemClicked): Deleted.

• UserInterface/Views/AuditTestContentView.css:

(.content-view.audit-test:is(.unsupported, .disabled):not(.manager-editing)): Added.
(.content-view.audit-test.manager-editing .editor:not(:empty)): Added.
(.content-view.audit-test.manager-editing :is(.content-view.audit-test, header) .editor:not(:empty)): Added.
(.content-view.audit-test .CodeMirror): Added.
(.content-view.audit-test > header :is(.name, .description):not([contenteditable])): Added.
(.content-view.audit-test.manager-editing > header :is(.name, .description)[contenteditable]): Added.
(.content-view.audit-test.manager-editing > header .name[contenteditable]:empty): Added.
(.content-view.audit-test.manager-editing > header .name[contenteditable]:empty:before): Added.
(.content-view.audit-test.manager-editing > header .description[contenteditable]:empty:before): Added.
(.content-view.audit-test:not(.manager-editing) > header .description:empty): Added.
(.content-view.audit-test:not(.manager-editing) > header .description:empty, .content-view.audit-test:not(.manager-editing) > header table.controls): Added.
(.content-view.audit-test > header table.controls, .content-view.audit-test > header table.controls > tr > td): Added.
(.content-view.audit-test > header table.controls > tr > th): Added.
(.content-view.audit-test > header table.controls > tr.supports input[type="number"]): Added.
(.content-view.audit-test > header table.controls > tr.supports .warning): Added.
(.content-view.audit-test > header table.controls > tr.supports .warning:not(:empty)::before ): Added.
(.content-view.audit-test > header table.controls > tr.setup .editor): Added.
(.content-view.audit-test > section > .message-text-view > :is(progress, .indeterminate-progress-spinner)): Added.
(@media (prefers-color-scheme: dark) .content-view.audit-test > header table.controls > tr > th): Added.
Create helper functions for subclasses that simplify creating the editing UI. When in edit
mode, add contenteditable to the name/description and inputs for supports/setup.

• UserInterface/Views/AuditTestGroupContentView.js:

(WI.AuditTestGroupContentView):
(WI.AuditTestGroupContentView.prototype.willDismissPopover): Added.
(WI.AuditTestGroupContentView.prototype.createControlsTableElement): Added.
(WI.AuditTestGroupContentView.prototype.initialLayout):
(WI.AuditTestGroupContentView.prototype.layout):
(WI.AuditTestGroupContentView.prototype.shown):
(WI.AuditTestGroupContentView.prototype.hidden):
(WI.AuditTestGroupContentView.prototype.showRunningPlaceholder):
(WI.AuditTestGroupContentView.prototype._updateClassList): Added.
(WI.AuditTestGroupContentView.prototype._updateLevelScopeBar):
(WI.AuditTestGroupContentView.prototype._addTest): Added.
(WI.AuditTestGroupContentView.prototype._handleTestGroupTestAdded): Added.
(WI.AuditTestGroupContentView.prototype._handleTestGroupTestRemoved): Added.

• UserInterface/Views/AuditTestGroupContentView.css:

(.content-view.audit-test-group > section > .audit-test-group > header): Added.
(.content-view.audit-test-group.contains-test-case > header):
(.content-view.audit-test-group > section > .audit-test-group.contains-test-case > header): Added.
(.content-view.audit-test-group.contains-test-case + .audit-test-group.contains-test-case, .content-view.audit-test-group + .content-view.audit-test-case): Added.
(.content-view.audit-test-group.contains-test-case + .audit-test-group.contains-test-case): Deleted.
When in edit mode, add buttons for removing the audit and adding a new sub-audit (using the
new WI.CreateAuditPopover popover).

• UserInterface/Views/AuditTestCaseContentView.js:

(WI.AuditTestCaseContentView):
(WI.AuditTestCaseContentView.prototype.initialLayout):
(WI.AuditTestCaseContentView.prototype.layout):
(WI.AuditTestCaseContentView.prototype.showRunningPlaceholder):

• UserInterface/Views/AuditTestCaseContentView.css:

(.content-view-container > .content-view.audit-test-case): Added.
(.content-view-container > .content-view.audit-test-case > header):
(.content-view-container > .content-view.audit-test-case.manager-editing > header h1 > img): Added.
(.content-view-container > .content-view.audit-test-case > section > :not(.message-text-view, .editor):first-child): Added.
(.content-view-container > .content-view.audit-test-case > section): Added.
(.content-view-container > .content-view.audit-test-case > section, .content-view-container > .content-view.audit-test-case > section :is(.editor, .CodeMirror)): Added.
(.content-view.audit-test-case.manager-editing.disabled:not(.editable) > header h1 > img): Added.
(.content-view.audit-test-case > section > :not(.message-text-view, .editor)): Added.
(.content-view.audit-test-case > section > :not(.message-text-view, .editor):last-child): Added.
(.content-view.audit-test-case > section > :not(.message-text-view, .editor) + :not(.message-text-view, .editor)): Added.
(@media (prefers-color-scheme: dark) .content-view.audit-test-case.manager-editing > header h1 > img): Added.
(.content-view-container > .content-view.audit-test-case > section > :not(.message-text-view):first-child): Deleted.
(.content-view.audit-test-case > section > :not(.message-text-view)): Deleted.
(.content-view.audit-test-case > section > :not(.message-text-view):last-child): Deleted.
(.content-view.audit-test-case > section > :not(.message-text-view) + :not(.message-text-view)): Deleted.
(.content-view.audit-test-case > section .CodeMirror): Deleted.
When in edit mode, replace the icon with a (X) to remove the audit and show a CodeMirror
instance to allow editing the content.

• UserInterface/Views/AuditTreeElement.js:

(WI.AuditTreeElement):
(WI.AuditTreeElement.expandedSettingKey): Added.
(WI.AuditTreeElement.prototype.onattach):
(WI.AuditTreeElement.prototype.ondelete):
(WI.AuditTreeElement.prototype.canSelectOnMouseDown): Added.
(WI.AuditTreeElement.prototype.populateContextMenu):
(WI.AuditTreeElement.prototype._handleTestNameChanged): Added.
(WI.AuditTreeElement.prototype._handleTestSupportedChanged): Added.
(WI.AuditTreeElement.prototype._handleTestGroupTestAdded): Added.

• UserInterface/Views/AuditTreeElement.css:

(.tree-outline .item.audit:matches(.test-case, .test-group):not(.unsupported, .manager-active):hover > .status > img): Added.
(body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.audit:matches(.test-case, .test-group):not(.unsupported, .manager-active).selected:hover > .status > img, body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.audit.test-case.selected > .status > .indeterminate-progress-spinner, body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.audit.test-group.selected > .status > progress): Added.
(.tree-outline .item.audit:not(:hover) > .status > img.show-on-hover, .tree-outline .item.audit.test-group.expanded:not(.unsupported, .editing-audits):not(:hover) > .status): Added.
(.tree-outline .item.audit.manager-active > .status > img.show-on-hover, .tree-outline .item.audit.manager-active > .status > img.show-on-hover, .tree-outline .item.audit.test-group.expanded:not(.editing-audits):hover > .status > :not(img), .tree-outline .item.audit.test-group-result.expanded > .status, .tree-outline .item.audit.unsupported + .children .item.audit.unsupported > .status > img): Added.
(@media (prefers-color-scheme: dark) .tree-outline .item.audit:matches(.test-case, .test-group):not(.unsupported, .manager-active):hover > .status > img): Added.
(.tree-outline .item.audit:matches(.test-case, .test-group):not(.unsupported, .manager-active) > .status:hover > img): Deleted.
(.tree-outline .item.audit > .status:not(:hover) > img.show-on-hover, .tree-outline .item.audit.test-group.expanded:not(.unsupported, .editing-audits) > .status:not(:hover)): Deleted.
(.tree-outline .item.audit.manager-active > .status > img.show-on-hover, .tree-outline .item.audit.test-group.expanded:not(.editing-audits) > .status:hover > :not(img), .tree-outline .item.audit.test-group-result.expanded > .status, .tree-outline .item.audit.unsupported + .children .item.audit.unsupported > .status > img): Deleted.
Add context menu items for duplicating/deleting tests when in edit mode. Adjust the label
and disabled state of existing context menu items for clarity.

• UserInterface/Views/CreateAuditPopover.js: Added.

(WI.CreateAuditPopover):
(WI.CreateAuditPopover.prototype.get audit):
(WI.CreateAuditPopover.prototype.show):
(WI.CreateAuditPopover.prototype.dismiss.const.testFunction):
(WI.CreateAuditPopover.prototype.dismiss):
(WI.CreateAuditPopover.prototype._presentOverTargetElement):

• UserInterface/Views/CreateAuditPopover.css: Added.

(.popover .create-audit-content):
(.popover .create-audit-content > .editor-wrapper):
(.popover .create-audit-content > .editor-wrapper > .reference-page-link):
New popover for creating an audit:

[<select> of group or test case] [<input> for name] (?)

• UserInterface/Views/Main.css:

(.navigation-item-help > .navigation-bar):
(.message-text-view > .navigation-item-help + .navigation-item-help): Added.
Add styles for when multiple navigation help items are used in the same message text view.

• UserInterface/Views/Variables.css:

(:root):
(@media (prefers-color-scheme: dark) :root):
Add --filter-invert to light mode too.

• UserInterface/Base/Utilities.js:

(HTMLInputElement.prototype.autosize):

• UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView):
(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureInputElementSize):
(WI.CanvasOverviewContentView.get recordingAutoCaptureInputMargin): Deleted.

• UserInterface/Views/CanvasOverviewContentView.css:

(.navigation-bar > .item.canvas-recording-auto-capture > label > input):
(.navigation-bar > .item.canvas-recording-auto-capture > label > input::-webkit-inner-spin-button): Deleted.
Create a helper function for autosizing an <input>.

• UserInterface/Views/AuditTabContentView.js:

(WI.AuditTabContentView):
(WI.AuditTabContentView.prototype.initialLayout):
Remove the back/foward arrows as they can get into an inconsistent state when editing.
Drive-by: update the drop zone text for clarity.

• UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel.prototype.showDefaultContentView):
Drive-by: add period to help text.

• UserInterface/Main.html:
• Localizations/en.lproj/localizedStrings.js:

LayoutTests:

• inspector/model/auditTestGroup.html:
• inspector/model/auditTestGroup-expected.txt:

Add tests that check how disabled and supported (via supports) is propagated in groups.

• inspector/audit/run.html:
• inspector/audit/run-expected.txt:

Add tests for WebInspectorAudit before Audit.setup is called.

• inspector/audit/manager-start-setup.html:

Renaming function call.

• inspector/audit/basic-async.html:
• inspector/audit/basic-boolean.html:
• inspector/audit/basic-debugger.html:
• inspector/audit/basic-error.html:
• inspector/audit/basic-object.html:
• inspector/audit/basic-promise.html:
• inspector/audit/basic-string.html:
• inspector/audit/basic-timeout.html:
• inspector/audit/run-resources.html:

Drive-by: remove InspectorTest.debug().

6:36 PM Changeset in webkit [266316] by ysuzuki@apple.com

• 2 edits in branches/safari-610.1.28.1-branch/LayoutTests/platform

Remove WebAudio Failure entries from TestExpectations
<rdar://problem/67367072>

Unreviewed, rebaselined after r266315.

6:31 PM Changeset in webkit [266315] by ysuzuki@apple.com

• 24 edits in branches/safari-610.1.28.1-branch/LayoutTests/imported/w3c/web-platform-tests/webaudio

Rebaseline WebAudio test results
<rdar://problem/67367072>

1. r265824 changed what error message is. (This is unavoidable since the kind of thrown error is changed (JS side error v.s. JS error thrown from C++), and this needs to be done to fix the reported webpage’s issue).
2. This error is recorded as expect files in various WebAudio WPT test if the tested WebAudio constructors are not implemented.
3. After that branch cut, a lot of WebAudio constructors are newly implemented, which removes this error messages from expect files.
4. r265824 is landed after these WebAudio patches. So it does not include rebaseline for these WebAudio WPT tests (since it is no longer including that error messages).
5. But in that branch, these WebAudio patches are not cherry-picked. This means that error message is still recorded in WPT expect files.
6. So, we just need to update these expect files, or cherry-pick these WebAudio patches. And I think updating expect files is the way to go.

5:27 PM Changeset in webkit [266314] by timothy_horton@apple.com

• 4 edits in trunk

Sites built with flambe.js don't work with trackpad on iPad
​https://bugs.webkit.org/show_bug.cgi?id=215954

Reviewed by Wenson Hsieh.

Source/WebKit:

New API Test: iOSMouseSupport.MouseTimestampTimebase

• UIProcess/ios/WKMouseGestureRecognizer.mm:

(-[WKMouseGestureRecognizer createMouseEventWithType:]):
Use the timestamp property on UITouch instead of GSCurrentEventTimestamp().
This property is in the same units as mach_absolute_time/MonotonicTime.
Previously, treating a monotonic time as wall time resulted in it getting clamped to 0,
breaking sites that depend on it.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:

(-[WKTestingHoverEvent locationInView:]):
(-[WKTestingTouch timestamp]):
(TEST):

5:21 PM Changeset in webkit [266313] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Debug event regions should paint the interactive region
​https://bugs.webkit.org/show_bug.cgi?id=215955

Reviewed by Tim Horton.

Interactive regions (EventRegion's region()) were not ever shown on macOS, even though
we use them for async-scrolling hit-testing. Fix RenderLayerBacking::paintDebugOverlays()
to always paint them if wheel event handler, or touch-action regions are enabled.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintDebugOverlays):

4:21 PM Changeset in webkit [266312] by eric.carlson@apple.com

• 3 edits in trunk/Source/WebCore

[macOS] AirPlay device name is wrong when playing to multiple devices
​https://bugs.webkit.org/show_bug.cgi?id=215952
<rdar://problem/66930799>

Reviewed by Jer Noble.

Tested manually because this requires a specific hardware setup.

• platform/graphics/avfoundation/MediaPlaybackTargetCocoa.mm:

(WebCore::MediaPlaybackTargetCocoa::deviceName const): If the AVOutputContext
supports multiple output devices, create the device name by concatenating the names
of all of the active output devices.

4:04 PM Changeset in webkit [266311] by weinig@apple.com

• 333 edits in trunk

[WebIDL] 'void' type is changing to 'undefined'
​https://bugs.webkit.org/show_bug.cgi?id=215514
<rdar://problem/67566201>

Reviewed by Darin Adler.

Update IDLs and IDL parsing / code generation for the switch from 'void' to 'undefined'.
Source/WebCore:

Also updates the parser to better match current WebIDL grammar, removing the special
'ReturnType' construction and just using 'Type' instead.

• Modules/applepay/ApplePaySession.idl:
• Modules/async-clipboard/Clipboard.idl:
• Modules/cache/DOMCache.idl:
• Modules/credentialmanagement/CredentialsContainer.idl:
• Modules/encryptedmedia/MediaKeySession.h:
• Modules/encryptedmedia/MediaKeySession.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeySession.idl:
• Modules/entriesapi/ErrorCallback.idl:
• Modules/entriesapi/FileCallback.idl:
• Modules/entriesapi/FileSystemDirectoryEntry.idl:
• Modules/entriesapi/FileSystemDirectoryReader.idl:
• Modules/entriesapi/FileSystemEntriesCallback.idl:
• Modules/entriesapi/FileSystemEntry.idl:
• Modules/entriesapi/FileSystemEntryCallback.idl:
• Modules/entriesapi/FileSystemFileEntry.idl:
• Modules/fetch/FetchHeaders.idl:
• Modules/geolocation/Geolocation.idl:
• Modules/geolocation/PositionCallback.idl:
• Modules/geolocation/PositionErrorCallback.idl:
• Modules/indexeddb/IDBCursor.idl:
• Modules/indexeddb/IDBDatabase.idl:
• Modules/indexeddb/IDBObjectStore.idl:
• Modules/indexeddb/IDBTransaction.idl:
• Modules/mediacontrols/MediaControlsHost.idl:
• Modules/mediarecorder/MediaRecorder.idl:
• Modules/mediasession/MediaSession.idl:
• Modules/mediasource/MediaSource.idl:
• Modules/mediasource/SourceBuffer.idl:
• Modules/mediastream/CanvasCaptureMediaStreamTrack.idl:
• Modules/mediastream/MediaStream.idl:
• Modules/mediastream/MediaStreamTrack.idl:
• Modules/mediastream/NavigatorMediaDevices.idl:
• Modules/mediastream/RTCDTMFSender.idl:
• Modules/mediastream/RTCDataChannel.idl:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCRtpSender.idl:
• Modules/mediastream/RTCRtpTransceiver.idl:
• Modules/notifications/Notification.idl:
• Modules/notifications/NotificationPermissionCallback.idl:
• Modules/paymentrequest/MerchantValidationEvent.idl:
• Modules/paymentrequest/PaymentRequest.idl:
• Modules/paymentrequest/PaymentRequestUpdateEvent.idl:
• Modules/paymentrequest/PaymentResponse.idl:
• Modules/pictureinpicture/DocumentPictureInPicture.idl:
• Modules/plugins/QuickTimePluginReplacement.idl:
• Modules/quota/StorageErrorCallback.idl:
• Modules/quota/StorageInfo.idl:
• Modules/quota/StorageQuota.idl:
• Modules/quota/StorageQuotaCallback.idl:
• Modules/quota/StorageUsageCallback.idl:
• Modules/remoteplayback/RemotePlayback.idl:
• Modules/speech/SpeechSynthesis.idl:
• Modules/streams/ReadableByteStreamController.idl:
• Modules/streams/ReadableStreamBYOBReader.idl:
• Modules/streams/ReadableStreamBYOBRequest.idl:
• Modules/streams/ReadableStreamDefaultController.idl:
• Modules/streams/ReadableStreamDefaultReader.idl:
• Modules/streams/ReadableStreamSink.idl:
• Modules/streams/ReadableStreamSource.idl:
• Modules/streams/TransformStreamDefaultController.idl:
• Modules/streams/WritableStreamDefaultController.idl:
• Modules/streams/WritableStreamDefaultWriter.idl:
• Modules/webaudio/AnalyserNode.idl:
• Modules/webaudio/AudioBuffer.idl:
• Modules/webaudio/AudioBufferCallback.idl:
• Modules/webaudio/AudioBufferSourceNode.idl:
• Modules/webaudio/AudioContext.idl:
• Modules/webaudio/AudioListener.idl:
• Modules/webaudio/AudioNode.idl:
• Modules/webaudio/AudioScheduledSourceNode.idl:
• Modules/webaudio/BiquadFilterNode.idl:
• Modules/webaudio/IIRFilterNode.idl:
• Modules/webaudio/OfflineAudioContext.idl:
• Modules/webaudio/OscillatorNode.idl:
• Modules/webaudio/PannerNode.idl:
• Modules/webaudio/WebKitAudioBufferSourceNode.idl:
• Modules/webaudio/WebKitAudioContext.idl:
• Modules/webaudio/WebKitAudioListener.idl:
• Modules/webaudio/WebKitAudioPannerNode.idl:
• Modules/webaudio/WebKitOscillatorNode.idl:
• Modules/webdatabase/Database.idl:
• Modules/webdatabase/DatabaseCallback.idl:
• Modules/webdatabase/SQLStatementCallback.idl:
• Modules/webdatabase/SQLTransaction.idl:
• Modules/webdatabase/SQLTransactionCallback.idl:
• Modules/webdatabase/SQLTransactionErrorCallback.idl:
• Modules/webgpu/WebGPUBuffer.idl:
• Modules/webgpu/WebGPUCommandEncoder.idl:
• Modules/webgpu/WebGPUComputePassEncoder.idl:
• Modules/webgpu/WebGPUDeviceErrorScopes.idl:
• Modules/webgpu/WebGPUProgrammablePassEncoder.idl:
• Modules/webgpu/WebGPUQueue.idl:
• Modules/webgpu/WebGPURenderPassEncoder.idl:
• Modules/webgpu/WebGPUTexture.idl:
• Modules/websockets/WebSocket.idl:
• Modules/webxr/WebXRSession.idl:
• Modules/webxr/WebXRSystem.idl:
• Modules/webxr/XRFrameRequestCallback.idl:
• Scripts/SettingsTemplates/InternalSettingsGenerated.idl.erb:
• animation/AnimationEffect.idl:
• animation/KeyframeEffect.idl:
• animation/WebAnimation.idl:
• bindings/IDLTypes.h:
• bindings/js/DOMPromiseProxy.h:
• bindings/scripts/CodeGenerator.pm:
• bindings/scripts/CodeGeneratorJS.pm:

(NeedsExplicitPropagateExceptionCall):
(GenerateCallbackImplementationContent):
(GenerateImplementationFunctionCall):
(GetBaseIDLType):

• bindings/scripts/IDLParser.pm:

(parseCallbackRest):
(parseAttributeOrOperationForStringifierOrStatic):
(parseOperation):
(parseSpecialOperation):
(parseMapLikeProperties):
(parseSetLikeProperties):
(parseSingleType):
(parseUnionMemberType):
(parseDistinguishableType):
(parseConstType):
(parsePrimitiveType):
(parseNonAnyType): Deleted.
(parseReturnType): Deleted.

• bindings/scripts/test/JS/JSTestCallbackFunctionWithThisObject.cpp:

(WebCore::JSTestCallbackFunctionWithThisObject::handleEvent):

• bindings/scripts/test/JS/JSTestCallbackFunctionWithThisObject.h:
• bindings/scripts/test/JS/JSTestCallbackFunctionWithTypedefs.cpp:

(WebCore::JSTestCallbackFunctionWithTypedefs::handleEvent):

• bindings/scripts/test/JS/JSTestCallbackFunctionWithTypedefs.h:
• bindings/scripts/test/JS/JSTestCallbackInterface.cpp:

(WebCore::JSTestCallbackInterface::callbackWithNoParam):
(WebCore::JSTestCallbackInterface::callbackWithArrayParam):
(WebCore::JSTestCallbackInterface::callbackWithSerializedScriptValueParam):
(WebCore::JSTestCallbackInterface::callbackWithStringList):
(WebCore::JSTestCallbackInterface::callbackWithBoolean):
(WebCore::JSTestCallbackInterface::callbackRequiresThisToPass):

• bindings/scripts/test/JS/JSTestCallbackInterface.h:
• bindings/scripts/test/JS/JSTestIterable.cpp:
• bindings/scripts/test/JS/JSTestNode.cpp:
• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::construct):
(WebCore::JSTestObjPrototype::finishCreation):
(WebCore::jsTestObjTestReadOnlyVoidPromiseAttributeGetter):
(WebCore::jsTestObjPrototypeFunctionUndefinedMethodBody):
(WebCore::jsTestObjPrototypeFunctionUndefinedMethod):
(WebCore::jsTestObjPrototypeFunctionUndefinedMethodWithArgsBody):
(WebCore::jsTestObjPrototypeFunctionUndefinedMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalPromiseBody):
(WebCore::jsTestObjPrototypeFunctionTestReturnsOwnPromiseAndPromiseProxyFunctionBody):
(WebCore::jsTestObjPrototypeFunctionVoidMethodBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionVoidMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgsBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): Deleted.

• bindings/scripts/test/JS/JSTestVoidCallbackFunction.cpp:

(WebCore::JSTestVoidCallbackFunction::handleEvent):

• bindings/scripts/test/JS/JSTestVoidCallbackFunction.h:
• bindings/scripts/test/TestCEReactions.idl:
• bindings/scripts/test/TestCallTracer.idl:
• bindings/scripts/test/TestCallbackFunctionWithThisObject.idl:
• bindings/scripts/test/TestCallbackFunctionWithTypedefs.idl:
• bindings/scripts/test/TestCallbackInterface.idl:
• bindings/scripts/test/TestDomainSecurity.idl:
• bindings/scripts/test/TestEnabledBySetting.idl:
• bindings/scripts/test/TestGlobalObject.idl:
• bindings/scripts/test/TestImplements.idl:
• bindings/scripts/test/TestIndexedSetterNoIdentifier.idl:
• bindings/scripts/test/TestIndexedSetterThrowingException.idl:
• bindings/scripts/test/TestIndexedSetterWithIdentifier.idl:
• bindings/scripts/test/TestJSBuiltinConstructor.idl:
• bindings/scripts/test/TestNamedAndIndexedSetterNoIdentifier.idl:
• bindings/scripts/test/TestNamedAndIndexedSetterThrowingException.idl:
• bindings/scripts/test/TestNamedAndIndexedSetterWithIdentifier.idl:
• bindings/scripts/test/TestNamedDeleterNoIdentifier.idl:
• bindings/scripts/test/TestNamedDeleterThrowingException.idl:
• bindings/scripts/test/TestNamedDeleterWithIdentifier.idl:
• bindings/scripts/test/TestNamedDeleterWithIndexedGetter.idl:
• bindings/scripts/test/TestNamedSetterNoIdentifier.idl:
• bindings/scripts/test/TestNamedSetterThrowingException.idl:
• bindings/scripts/test/TestNamedSetterWithIdentifier.idl:
• bindings/scripts/test/TestNamedSetterWithIndexedGetter.idl:
• bindings/scripts/test/TestNamedSetterWithIndexedGetterAndSetter.idl:
• bindings/scripts/test/TestNamedSetterWithOverrideBuiltins.idl:
• bindings/scripts/test/TestNamedSetterWithUnforgableProperties.idl:
• bindings/scripts/test/TestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.idl:
• bindings/scripts/test/TestNode.idl:
• bindings/scripts/test/TestObj.idl:
• bindings/scripts/test/TestOperationBase.idl:
• bindings/scripts/test/TestSerializedScriptValueInterface.idl:
• bindings/scripts/test/TestSupplemental.idl:
• bindings/scripts/test/TestTypedefs.idl:
• bindings/scripts/test/TestVoidCallbackFunction.idl:
• css/CSSKeyframesRule.idl:
• css/CSSMediaRule.idl:
• css/CSSPaintCallback.idl:
• css/CSSStyleDeclaration.idl:
• css/CSSStyleSheet.idl:
• css/CSSSupportsRule.idl:
• css/DOMCSSRegisterCustomProperty.idl:
• css/DeprecatedCSSOMPrimitiveValue.idl:
• css/FontFaceSet.idl:
• css/MediaList.idl:
• css/MediaQueryList.idl:
• css/WebKitCSSMatrix.idl:
• dom/AbortAlgorithm.idl:
• dom/AbortController.idl:
• dom/AbortSignal.idl:
• dom/CharacterData.idl:
• dom/ChildNode.idl:
• dom/CompositionEvent.idl:
• dom/CustomElementRegistry.idl:
• dom/CustomEvent.idl:
• dom/DOMStringMap.idl:
• dom/DataTransfer.idl:
• dom/DataTransferItem.idl:
• dom/DataTransferItemList.idl:
• dom/DeviceMotionEvent.idl:
• dom/DeviceOrientationEvent.idl:
• dom/Document.idl:
• dom/DocumentFullscreen.idl:
• dom/DocumentStorageAccess.idl:
• dom/Element.idl:
• dom/Event.idl:
• dom/EventListener.idl:
• dom/EventTarget.idl:
• dom/HashChangeEvent.idl:
• dom/IdleRequestCallback.idl:
• dom/KeyboardEvent.idl:
• dom/MessageEvent.idl:
• dom/MessagePort.idl:
• dom/MouseEvent.idl:
• dom/MutationCallback.idl:
• dom/MutationEvent.idl:
• dom/MutationObserver.idl:
• dom/Node.idl:
• dom/NodeIterator.idl:
• dom/ParentNode.idl:
• dom/Range.idl:
• dom/RequestAnimationFrameCallback.idl:
• dom/StringCallback.idl:
• dom/TextEvent.idl:
• dom/TouchEvent.idl:
• dom/UIEvent.idl:
• dom/WheelEvent.idl:
• fileapi/BlobCallback.idl:
• fileapi/FileReader.idl:
• html/DOMFormData.idl:
• html/DOMTokenList.idl:
• html/DOMURL.idl:
• html/HTMLButtonElement.idl:
• html/HTMLCanvasElement.idl:
• html/HTMLDialogElement.idl:
• html/HTMLElement.idl:
• html/HTMLFieldSetElement.idl:
• html/HTMLFormElement.idl:
• html/HTMLImageElement.idl:
• html/HTMLInputElement.idl:
• html/HTMLKeygenElement.idl:
• html/HTMLMarqueeElement.idl:
• html/HTMLMediaElement.idl:
• html/HTMLObjectElement.idl:
• html/HTMLOptionsCollection.idl:
• html/HTMLOrForeignElement.idl:
• html/HTMLOutputElement.idl:
• html/HTMLSelectElement.idl:
• html/HTMLTableElement.idl:
• html/HTMLTableRowElement.idl:
• html/HTMLTableSectionElement.idl:
• html/HTMLTextAreaElement.idl:
• html/HTMLVideoElement.idl:
• html/ImageBitmap.idl:
• html/MediaController.idl:
• html/URLSearchParams.idl:
• html/VoidCallback.idl:
• html/canvas/ANGLEInstancedArrays.idl:
• html/canvas/CanvasDrawImage.idl:
• html/canvas/CanvasDrawPath.idl:
• html/canvas/CanvasGradient.idl:
• html/canvas/CanvasImageData.idl:
• html/canvas/CanvasPath.idl:
• html/canvas/CanvasPathDrawingStyles.idl:
• html/canvas/CanvasPattern.idl:
• html/canvas/CanvasRect.idl:
• html/canvas/CanvasRenderingContext2D.idl:
• html/canvas/CanvasState.idl:
• html/canvas/CanvasText.idl:
• html/canvas/CanvasTransform.idl:
• html/canvas/CanvasUserInterface.idl:
• html/canvas/ImageBitmapRenderingContext.idl:
• html/canvas/OESVertexArrayObject.idl:
• html/canvas/OffscreenCanvasRenderingContext2D.idl:
• html/canvas/Path2D.idl:
• html/canvas/WebGL2RenderingContext.idl:
• html/canvas/WebGLDrawBuffers.idl:
• html/canvas/WebGLLoseContext.idl:
• html/canvas/WebGLRenderingContextBase.idl:
• html/track/TextTrack.idl:
• inspector/CommandLineAPIHost.idl:
• inspector/InspectorFrontendHost.idl:
• loader/appcache/DOMApplicationCache.idl:
• page/DOMSelection.idl:
• page/DOMWindow.idl:
• page/EventSource.idl:
• page/History.idl:
• page/IntersectionObserver.idl:
• page/IntersectionObserverCallback.idl:
• page/Location.idl:
• page/Navigator.idl:
• page/NavigatorIsLoggedIn.idl:
• page/NavigatorShare.idl:
• page/Performance.idl:
• page/PerformanceObserver.idl:
• page/PerformanceObserverCallback.idl:
• page/RemoteDOMWindow.idl:
• page/ResizeObserver.idl:
• page/ResizeObserverCallback.idl:
• page/UndoManager.idl:
• page/WindowOrWorkerGlobalScope.idl:
• plugins/DOMPluginArray.idl:
• storage/Storage.idl:
• storage/StorageEvent.idl:
• svg/SVGAngle.idl:
• svg/SVGAnimationElement.idl:
• svg/SVGFEDropShadowElement.idl:
• svg/SVGFEGaussianBlurElement.idl:
• svg/SVGFEMorphologyElement.idl:
• svg/SVGLength.idl:
• svg/SVGLengthList.idl:
• svg/SVGMarkerElement.idl:
• svg/SVGNumberList.idl:
• svg/SVGPathSegList.idl:
• svg/SVGPointList.idl:
• svg/SVGSVGElement.idl:
• svg/SVGStringList.idl:
• svg/SVGTextContentElement.idl:
• svg/SVGTransform.idl:
• svg/SVGTransformList.idl:
• testing/InternalSettings.idl:
• testing/Internals.idl:
• testing/MockCDMFactory.idl:
• testing/MockPageOverlay.idl:
• testing/MockPaymentCoordinator.idl:
• testing/ServiceWorkerInternals.idl:
• testing/TypeConversions.idl:
• testing/WebFakeXRDevice.idl:
• testing/WebFakeXRInputController.idl:
• testing/WebXRTest.idl:
• testing/XRSimulateUserActivationFunction.idl:
• workers/DedicatedWorkerGlobalScope.idl:
• workers/Worker.idl:
• workers/WorkerGlobalScope.idl:
• workers/service/ExtendableEvent.idl:
• workers/service/FetchEvent.idl:
• workers/service/ServiceWorker.idl:
• workers/service/ServiceWorkerClient.idl:
• workers/service/ServiceWorkerClients.idl:
• workers/service/ServiceWorkerContainer.idl:
• workers/service/ServiceWorkerGlobalScope.idl:
• workers/service/ServiceWorkerRegistration.idl:
• worklets/PaintWorkletGlobalScope.idl:
• worklets/Worklet.idl:
• xml/XMLHttpRequest.idl:
• xml/XSLTProcessor.idl:

Tools:

• DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:

(_generateImplementationFile):
(_returnExpression):

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
• WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

(_generateImplementationFile):
(_returnExpression):

• WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
• WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:

4:03 PM Changeset in webkit [266310] by Russell Epstein

• 1 copy in tags/Safari-609.4.1

Tag Safari-609.4.1.

4:02 PM Changeset in webkit [266309] by Alan Coon

• 1 copy in tags/Safari-610.1.28.1.5

Tag Safari-610.1.28.1.5.

3:58 PM Changeset in webkit [266308] by Alan Coon

• 8 edits in branches/safari-610.1.28.1-branch/Source

Revert "Versioning."

This reverts revision 266299.

3:58 PM Changeset in webkit [266307] by Alan Coon

• 16 edits
  2 adds in branches/safari-610.1.28.1-branch

Cherry-pick r266292. rdar://problem/67963517

Vertical scrolling gets stuck when a horizontal scroller is under the mouse (google search results)
​https://bugs.webkit.org/show_bug.cgi?id=215641
<rdar://problem/67430532>

Reviewed by Tim Horton.
Source/WebCore:

There are two parts to this fix. First, findEnclosingScrollableContainer() needs
to use the same vertical-biasing delta fixup that we use in other places, to bias towards
vertical scrolling.

Second, when we've determined that the main frame should perform the scroll and dispatch
the wheel event to the scrolling thread, we used to hit-test from scratch on the scrolling
thread and and try to send the event to a scroller which we already know should not handle
it. So pass along a target ScrollingNodeID, and start the scrolling thread handling from
that node.

Test: fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html

• page/FrameView.cpp: (WebCore::FrameView::wheelEvent):
• page/mac/EventHandlerMac.mm: (WebCore::findEnclosingScrollableContainer):
• page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::handleWheelEvent):
• page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::handleWheelEvent): (WebCore::ScrollingTree::handleWheelEventWithNode):
• page/scrolling/ScrollingTree.h:
• page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::handleWheelEventAfterMainThread):
• page/scrolling/ThreadedScrollingTree.h:
• page/scrolling/mac/ScrollingCoordinatorMac.h:
• page/scrolling/mac/ScrollingCoordinatorMac.mm: (WebCore::ScrollingCoordinatorMac::handleWheelEvent):
• page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp: (WebCore::ScrollingCoordinatorNicosia::handleWheelEvent):
• page/scrolling/nicosia/ScrollingCoordinatorNicosia.h:

LayoutTests:

After this change iframe-latch-small-deltas.html would time-out because WheelEventTestMonitor
would get stuck with a "content scrolling" defer region, due to begin/end wheel
events not getting both sent to the iframe. But the test was actually broken; logging shows
that it reset latching state anyway, and it's not testing the shipping configuration of
async iframe scrolling. So fix the test to use async iframe scrolling, and to avoid
rubber-banding, so that latching is not cleared due to elapsed time.

• fast/scrolling/latching/iframe-latch-small-deltas-expected.txt:
• fast/scrolling/latching/iframe-latch-small-deltas.html:
• fast/scrolling/mac/horizontal-overflow-trapping-small-deltas-expected.txt: Added.
• fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:58 PM Changeset in webkit [266306] by Alan Coon

• 4 edits
  2 adds in branches/safari-610.1.28.1-branch

Cherry-pick r266262. rdar://problem/67963578

Scrolling on select element doesn't work after scrolling the page
​https://bugs.webkit.org/show_bug.cgi?id=215900
Source/WebCore:

<rdar://problem/67766032>

Reviewed by Tim Horton.

The scrolling thread could use a node that was latched some time ago; we need to
check the freshness of the latched node before using it.

Test: fast/scrolling/latching/latching-stuck-to-main-page.html

• page/scrolling/ScrollingTreeLatchingController.cpp: (WebCore::ScrollingTreeLatchingController::receivedWheelEvent): (WebCore::ScrollingTreeLatchingController::latchedNodeForEvent const): (WebCore::ScrollingTreeLatchingController::latchedNodeIsRelevant const):
• page/scrolling/ScrollingTreeLatchingController.h:

LayoutTests:

Reviewed by Tim Horton.

• fast/scrolling/latching/latching-stuck-to-main-page-expected.txt: Added.
• fast/scrolling/latching/latching-stuck-to-main-page.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:58 PM Changeset in webkit [266305] by Alan Coon

• 7 edits
  2 adds in branches/safari-610.1.28.1-branch

Cherry-pick r266248. rdar://problem/67963534

Occasional crashes when restoring replaced text under Editor::changeBackToReplacedString
​https://bugs.webkit.org/show_bug.cgi?id=215892
<rdar://problem/67731156>

Reviewed by Tim Horton.

Source/WebCore:

While reverting the replaced string in Editor::changeBackToReplacedString, it's possible for text replacement
(Editor::replaceSelectionWithText) to cause the text checking paragraph range to become orphaned (if for no
reason other than the fact that arbitrary script can run in between). If this happens, then our attempts to
expand the checking range to paragraph boundaries underneath TextCheckingParagraph::paragraphRange will result
in a null dereference, since the boundary points computed underneath the expandToParagraphBoundary helper will
be nullopt.

Mitigate this (and any other potentially similar crashes) by making expandToParagraphBoundary robust in the
case where expanding to the start and end fails, and just fall back to returning the original text checking
range instead.

Test: editing/mac/input/change-back-to-replaced-string.html

• editing/Editor.h:
• editing/TextCheckingHelper.cpp: (WebCore::expandToParagraphBoundary):

See above for more details.

• testing/Internals.cpp: (WebCore::Internals::changeBackToReplacedString):
• testing/Internals.h:
• testing/Internals.idl:

Add a simple internal testing hook to change the currently selected text back to the given replaced string.

LayoutTests:

Add a layout test to exercise the crash.

• editing/mac/input/change-back-to-replaced-string-expected.txt: Added.
• editing/mac/input/change-back-to-replaced-string.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:57 PM Changeset in webkit [266304] by Alan Coon

• 5 edits
  2 adds in branches/safari-610.1.28.1-branch

Cherry-pick r266241. rdar://problem/67963565

REGRESSION (r263506): timing of CSS Animation on ​https://animate.style is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=215807
<rdar://problem/66770136>

Reviewed by Simon Fraser.

Source/WebCore:

Test: webanimations/accelerated-css-animation-with-easing.html

In r263506, we added a way for accelerated animations to adhere to both a timing function set on the
animation, affecting the timing of the entire animation, as well as a timing function set on individual
keyframes, affecting the timing of the animation in a given interval. Alas, this change broke handling
of timing functions with implicit animation-timing-function on keyframes.

That code change assumed that the Animation object ultimately passed to GraphicsLayerCA::setupAnimation()
would return the animation-wide timing function through Animation::timingFunction(). This was correct for
JS-originated animations, but not for CSS Animations, since that value was set based on the computed CSS
property animation-timing-function for the target element. However, that CSS property does not specify
the animation-wide timing function, but rather the default timing function to use for keyframes should
they fail to specify an explicit timing function.

To fix this, first, we ensure that the animation-wide timing function is set on the Animation object,
changing KeyframeEffect::backingAnimationForCompositedRenderer() to always generate an Animation object
based on the effect, divorcing itself from the Animation object created through CSS.

Then, we add a new member to Animation to specify the default timing function for keyframes, allowing
GraphicsLayerCA to use it to determine the timing function when building keyframes.

• animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const): Always generate an Animation object based on the effect's properties, also setting the new defaultTimingFunctionForKeyframes in the case of a CSS Animation object.
• platform/animation/Animation.h: (WebCore::Animation::defaultTimingFunctionForKeyframes const): (WebCore::Animation::setDefaultTimingFunctionForKeyframes):
• platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::animationHasStepsTimingFunction): Use the optional defaultTimingFunctionForKeyframes to determine whether a keyframe uses a steps timing function. (WebCore::GraphicsLayerCA::timingFunctionForAnimationValue): Use the optional defaultTimingFunctionForKeyframes to determine the timing function for a keyframe.

LayoutTests:

Add a new test that checks that a CSS Animation with implicit and explicit animation-timing-function
values behave the same when running accelerated.

• webanimations/accelerated-css-animation-with-easing-expected.html: Added.
• webanimations/accelerated-css-animation-with-easing.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:57 PM Changeset in webkit [266303] by Alan Coon

• 2 edits in branches/safari-610.1.28.1-branch/Source/WebKit

Cherry-pick r266240. rdar://problem/67963545

REGRESSION(r264710): Initializing the AVPlayer Obj-C class at process start up causes a regression in power-use tests
​https://bugs.webkit.org/show_bug.cgi?id=215861

Reviewed by Eric Carlson.

Calling +instancesRespondToSelector: will cause the underyling Obj-C class to be initialized, which in the case of
AVPlayer does a bunch of work which shows up on power-use tests. Because the API being checked for will always exist
in macOS 11, and that code is already protected by a HAVE(AVPLAYER_VIDEORANGEOVERRIDE) pragma, just return early
here without running the +instancesRespondToSelector: check.

• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::updatePageScreenProperties):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:57 PM Changeset in webkit [266302] by Alan Coon

• 3 edits
  3 adds in branches/safari-610.1.28.1-branch

Cherry-pick r266239. rdar://problem/67963554

REGRESSION (r258215): Title preview movie isn't displayed at www.thismmalife.com
​https://bugs.webkit.org/show_bug.cgi?id=215774
<rdar://problem/67707957>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-as-img-output-pts.html

Use CMSampleBufferGetOutputPresentationTimeStamp() for sample PTS.

• platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm: (WebCore::ImageDecoderAVFObjC::storeSampleBuffer):

LayoutTests:

• media/content/video-as-img.mp4: Added.
• media/video-as-img-output-pts-expected.txt: Added.
• media/video-as-img-output-pts.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:57 PM Changeset in webkit [266301] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[macOS] Fix iokit-get-properties sandbox violations
​https://bugs.webkit.org/show_bug.cgi?id=215925

Reviewed by Brent Fulgham.

Add iokit-property to WebContent sandbox that should have been a part of r266282.

• WebProcess/com.apple.WebProcess.sb.in:

3:53 PM Changeset in webkit [266300] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS ] Tests expectations changed as test passing but expected to fail
​https://bugs.webkit.org/show_bug.cgi?id=215786

Unreviewed test gardening.

• platform/mac/TestExpectations: corrections for BigSur+

3:37 PM Changeset in webkit [266299] by Russell Epstein

• 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.6

3:17 PM Changeset in webkit [266298] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ BigSur+ ] fast/images/image-controls-basic.html
<rdar://64947666>

Unreviewed test gardening.

• platform/mac/TestExpectations:

3:15 PM WebKitGTK/2.30.x edited by Adrian Perez de Castro

(diff)

3:09 PM Changeset in webkit [266297] by Adrian Perez de Castro

• 4 edits in trunk

[WPE] Enable Notifications support
​https://bugs.webkit.org/show_bug.cgi?id=215924

Reviewed by Philippe Normand.

.:

Enable web notifications support for the WPE port. The code is shared with the GTK
port, but as we do not try to find and enable libnotify the default implementation
is a stub: embedders can customize how to display notifications by connecting to
the WebKitWebView:show-notification signal. This way we do not add any additional
build dependencies.

• Source/cmake/OptionsWPE.cmake: Flip ENABLE_NOTIFICATIONS to ON.

LayoutTests:

• platform/wpe/TestExpectations: Update test expectations.

2:40 PM Changeset in webkit [266296] by Lauro Moura

• 3 edits in trunk/LayoutTests

[GTK][WPE] Gardening some failures.

Unreviewed test gardening.

• platform/glib/TestExpectations:
• platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt:

2:37 PM Changeset in webkit [266295] by Darin Adler

• 49 edits in trunk

Remove almost all the remaining uses of live ranges
​https://bugs.webkit.org/show_bug.cgi?id=215755

Reviewed by Sam Weinig.

Source/WebCore:

• accessibility/AXObjectCache.cpp:

(WebCore::characterOffsetsInOrder): Use documentOrder.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::misspellingRange const): Ditto.
(WebCore::rangeClosestToRange): Use characterCount. Also removed unnnecessary assertions
and special cases.
(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection const): Use documentOrder.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::documentBasedSelectedTextRange const): Use intersects.
Also use firstRange instead of toNormalizedRange.

• dom/Element.h: Export attachShadow so it can be used in unit tests.

• dom/Node.cpp:

(WebCore::depthInComposedTree): Renamed and changed to use parentInComposedTree
instead of parentOrShadowHostNode to handle cases involving assigned slots correctly.
(WebCore::commonInclusiveAncestorAndChildren): Ditto.
(WebCore::isSiblingSubsequent): Added assertions.
(WebCore::documentOrder): Add logic so shadow roots are ordered before the
other children of their hosts in cases that don't involve assigned slots.
Without this the results would be inconsistent based on the order of the
arguments passed to documentOrder.

• dom/Node.h: Added is_neq, is_lteq, and is_gteq for use with PartialOrdering,

matching the names and behavior from C++20.

• dom/Range.cpp: Removed unused CoordinateSpace.

(WebCore::Range::Range): Updated since RangeBoundaryPoint now uses references.
(WebCore::Range::updateDocument): Renamed from setDocument and changed so that
it maintains the invariants without requiring the caller pass any arguments.
Also updated for RangeBoundaryPoint anme changes.
(WebCore::Range::compareBoundaryPoints): Deleted.
(WebCore::checkForDifferentRootContainer): Deleted.
(WebCore::Range::setStart): Updated for checkNodeOffsetPair name change.
Removed too-complex code for moving between documents. Use documentOrder
instead of checkForDifferentRootContainer to check for start/end that have
incorrect order or no common ancestor. Use updateDocument.
(WebCore::Range::setEnd): Ditto.
(WebCore::Range::isPointInRange): Use isPointInRange that takes a SimpleRange.
Also updated for checkNodeOffsetPair name change.
(WebCore::Range::comparePoint const): Use documentOrder. Ditto.
(WebCore::Range::compareNode const): Use documentOrder.
(WebCore::top): Deleted.
(WebCore::Range::compareBoundaryPoints const): Deleted more overloads.
Kept only the one needed for bindings, and renamed it from
compareBoundaryPointsForBindings. Also fixed the implementatin to be simpler,
use documentOrder, and match the DOM specification more closely (without a
behavior change).
(WebCore::Range::boundaryPointsValid const): Deleted.
(WebCore::Range::intersectsNode const): Use intersects from SimpleRange.
Also don't raise exceptions.
(WebCore::lengthOfContentsInNode): Deleted. This gives the same result as
Node::length, but less efficiently.
(WebCore::Range::processContents): Updated since RangeBoundaryPoint now
uses references.
(WebCore::processContentsBetweenOffsets): Removed obsolete comment.
(WebCore::Range::toString const): Use intersectingNodes and
characterDataOffsetRange.
(WebCore::Range::text const): Deleted.
(WebCore::Range::detach): Moved to the header.
(WebCore::Range::checkNodeOffsetPair const): Rneamed from checkNodeWOffset.
(WebCore::Range::cloneRange): Use m_ownerDocument.
(WebCore::Range::setStartAfter): Tweaked coding style.
(WebCore::Range::setEndBefore): Ditto.
(WebCore::Range::setEndAfter): Ditto.
(WebCore::Range::selectNode): Ditto. Also removed unnecessary code to
call setDocument, since setStart takes care of that.
(WebCore::Range::selectNodeContents): Ditto.
(WebCore::Range::setStartBefore): Ditto.
(WebCore::Range::firstNode const): Deleted.
(WebCore::Range::pastLastNode const): Deleted.
(WebCore::Range::contains const): Deleted.
(WebCore::areRangesEqual): Deleted.
(WebCore::rangesOverlap): Deleted.
(WebCore::boundaryNodeChildrenChanged): Tweaked coding style and updated
since RangeBoundaryPoint uses a reference.
(WebCore::Range::nodeChildrenChanged): Use m_ownerDocument.
(WebCore::boundaryNodeChildrenWillBeRemoved): Removed unneeded code
to handle case where one of the children is the childBefore but the
node is not inside the container -- that case doesn't exist. Use
Node::contains.
(WebCore::Range::nodeChildrenWillBeRemoved): Use m_ownerDocument.
(WebCore::boundaryNodeWillBeRemoved): Simplify logic using
Range::contains.
(WebCore::Range::nodeWillBeRemoved): Use m_ownerDocument.
(WebCore::Range::parentlessNodeMovedToNewDocumentAffectsRange):
Updated since RangeBoundaryPoint uses a reference.
(WebCore::boundaryTextInserted): Ditto.
(WebCore::boundaryTextRemoved): Ditto.
(WebCore::boundaryTextNodesMerged): Ditto.
(WebCore::boundaryTextNodesSplit): Ditto.
(showTree): Removed call to boundaryPointsValid. That's checking something
the class already treats as an invariant, so it's obsolete code left from
long ago when we didn't have that implemented correctly.

• dom/Range.h: Reorganized the header to match the IDL file.

Removed ownerDocument, compareBoundaryPoints overloads other than the one
used from bindings, firstNode, pastLastNode, text, contains, areRangesEqual,
and rangesOverlap. Also updated since RangeBoundaryPoint::container is now
a reference. Moved detach function here to the header as an empty inline.

• dom/Range.idl: Changed start/endOffset to unsigned. Stopped using the

name compareBoundaryPointersForBindings. Updated intersectsNode to not
throw exceptions as called for in the DOM specification. Tweaked comments.

• dom/RangeBoundaryPoint.h: Changed constructor argument to a reference.

Renamed setToBeforeChild, setToAfterChild, setToStartOfNode, and setToEndOfNode
to setToBeforeNode, setToAfterNode, setToBeforeContents, setToAfterContents.
Merged ensureOffsetIsValid into the offset function. Changed m_containerNode
into a Ref<> and renamed it m_container. Removed clear.

• dom/SimpleRange.cpp:

(WebCore::isOffsetBeforeChild): Add logic so shadow roots are ordered after offset
0 but before offset 1 in their hosts in cases that don't involve assigned slots.
This is an arbitrary choice, but is consistent with how we order shadow roots before
other child nodes.
(WebCore::documentOrder): Use parentInComposedTree instead of parentOrShadowHostNode
to handle cases involving assigned slots correctly.
(WebCore::isPointInRange): Added.
(WebCore::documentOrder): Added.
(WebCore::contains): Added.
(WebCore::intersects): Added.
(WebCore::unionRange): Added.

• dom/SimpleRange.h: Updated for above.

• editing/Editing.cpp:

(WebCore::comparePositions): Use documentOrder.
(WebCore::isNodeVisiblyContainedWithin): Use contains.

• editing/Editor.cpp:

(WebCore::isFrameInRange): Use intersects.
(WebCore::Editor::scanSelectionForTelephoneNumbers): Use intersects.

• editing/EditorCommand.cpp:

(WebCore::unionRanges): Moved to SimpleRange.cpp, where it's now
implemented using documentOrder.
(WebCore::executeDeleteToMark): Updated name to unionRange.
(WebCore::executeSelectToMark): Ditto.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::respondToNodeModification): Use intersects.

• editing/mac/DictionaryLookupLegacy.mm:

(WebCore::selectionContainsPosition): Use isPointInRange.

• page/DOMSelection.cpp:

(WebCore::DOMSelection::extend): Use makeRefPtr and Node::length
to streamline the implementation.
(WebCore::DOMSelection::getRangeAt): Use makeBoundaryPointBeforeNode
and remove unneeded null check that's already covered above.
(WebCore::DOMSelection::addRange): Use intersects and unionRange.
(WebCore::DOMSelection::containsNode const): Use intersects and contains.
(WebCore::DOMSelection::isValidForPosition const): Use boolean logic.

• page/DragController.cpp:

(WebCore::DragController::draggableElement const): Use contains.
(WebCore::DragController::insertDroppedImagePlaceholdersAtCaret): Use intersects.

• page/EventHandler.cpp:

(WebCore::EventHandler::dispatchMouseEvent): Use contains.

• page/Page.cpp:

(WebCore::Page::findTextMatches): Use documentOrder.

• page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::findTelephoneNumberHighlightContainingSelectionHighlight):
Use contains.

• testing/Internals.cpp:

(WebCore::Internals::rangeAsText): Use plainText.
(WebCore::join): Added.
(WebCore::Internals::rangeAsTextUsingBackwardsTextIterator): Use a vector
that we reverse and join rather than inserting at the start of a string.
(WebCore::Internals::subrange): Added a call to updateLayout since text iterator
functions depend on the state of the render tree. Realized this was theoretically
needed because of Internals::rangeAsText.
(WebCore::Internals::rangeOfStringNearLocation): Ditto.

Source/WebKit:

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMRange.cpp:

(webkit_dom_range_compare_boundary_points): Update for rename of
compareBoundaryPointsForBindings.
(webkit_dom_range_intersects_node): Removed exception handling.
(webkit_dom_range_get_text): Use plainText.

• WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange initWithDocument:]): Tightened up into a one-liner.
(-[WKDOMRange text]): Use plainText.
(-[WKDOMRange textRects]): Stopped using Range::ownerDocument.

• WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::document): Stopped using
Range::ownerDocument.
(WebKit::InjectedBundleRangeHandle::boundingRectInWindowCoordinates const):
Ditto.
(WebKit::InjectedBundleRangeHandle::renderedImage): Ditto.
(WebKit::InjectedBundleRangeHandle::text const): Use plainText.

• WebProcess/WebPage/glib/WebPageGLib.cpp:

(WebKit::WebPage::getPlatformEditorState const): Use contains.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestDocumentEditingContext): Use intersects.

Source/WebKitLegacy/mac:

• DOM/DOMRange.mm:

(-[DOMRange text]): Use plainText.
(-[DOMRange compareBoundaryPoints:sourceRange:]): Update for rename of
compareBoundaryPointsForBindings.
(-[DOMRange intersectsNode:]): Removed raiseOnDOMError.

• DOM/DOMUIKitExtensions.mm:

(firstNodeAfter): Moved Range::firstNode here since it's the only remaining caller;
might need to keep legacy behavior depending on how this is used by UIKit.
(-[DOMRange firstNode]): Call firstNodeAfter.

• DOM/WebDOMOperations.mm:

(-[DOMRange markupString]): Stop using Range::ownerDocument.

Tools:

• TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp:

(TestWebKitAPI::TEST): Added test cases for node ordering involving non-user-agent
shadow tree. Added test case that showed the old "use node order if offsets are equal"
rule for boundary point ordering was wrong. Added tests for isPointInRange,
intersects, and contains functions.

2:35 PM Changeset in webkit [266294] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ BigSur+ ] fast/forms/hidpi-textfield-background-bleeding.html
<rdar://66295552>

Unreviewed test gardening.

• platform/mac/TestExpectations:

2:27 PM Changeset in webkit [266293] by Chris Dumez

• 9 edits in trunk

AudioParam.value setter should call setValueAtTime(value, now)
​https://bugs.webkit.org/show_bug.cgi?id=215946

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:

Source/WebCore:

AudioParam.value setter should call setValueAtTime(value, now), as per:

• ​https://www.w3.org/TR/webaudio/#dom-audioparam-value

No new tests, rebaselined existing tests.

• Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::valueForBindings const):
(WebCore::AudioParam::setValueForBindings):

• Modules/webaudio/AudioParam.h:
• Modules/webaudio/AudioParam.idl:

2:09 PM Changeset in webkit [266292] by Simon Fraser

• 16 edits
  2 adds in trunk

Vertical scrolling gets stuck when a horizontal scroller is under the mouse (google search results)
​https://bugs.webkit.org/show_bug.cgi?id=215641
<rdar://problem/67430532>

Reviewed by Tim Horton.
Source/WebCore:

There are two parts to this fix. First, findEnclosingScrollableContainer() needs
to use the same vertical-biasing delta fixup that we use in other places, to bias towards
vertical scrolling.

Second, when we've determined that the main frame should perform the scroll and dispatch
the wheel event to the scrolling thread, we used to hit-test from scratch on the scrolling
thread and and try to send the event to a scroller which we already know should not handle
it. So pass along a target ScrollingNodeID, and start the scrolling thread handling from
that node.

Test: fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html

• page/FrameView.cpp:

(WebCore::FrameView::wheelEvent):

• page/mac/EventHandlerMac.mm:

(WebCore::findEnclosingScrollableContainer):

• page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::handleWheelEvent):

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::handleWheelEvent):
(WebCore::ScrollingTree::handleWheelEventWithNode):

• page/scrolling/ScrollingTree.h:
• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::handleWheelEventAfterMainThread):

• page/scrolling/ThreadedScrollingTree.h:
• page/scrolling/mac/ScrollingCoordinatorMac.h:
• page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::handleWheelEvent):

• page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp:

(WebCore::ScrollingCoordinatorNicosia::handleWheelEvent):

• page/scrolling/nicosia/ScrollingCoordinatorNicosia.h:

LayoutTests:

After this change iframe-latch-small-deltas.html would time-out because WheelEventTestMonitor
would get stuck with a "content scrolling" defer region, due to begin/end wheel
events not getting both sent to the iframe. But the test was actually broken; logging shows
that it reset latching state anyway, and it's not testing the shipping configuration of
async iframe scrolling. So fix the test to use async iframe scrolling, and to avoid
rubber-banding, so that latching is not cleared due to elapsed time.

• fast/scrolling/latching/iframe-latch-small-deltas-expected.txt:
• fast/scrolling/latching/iframe-latch-small-deltas.html:
• fast/scrolling/mac/horizontal-overflow-trapping-small-deltas-expected.txt: Added.
• fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html: Added.

1:21 PM Changeset in webkit [266291] by Alan Bujtas

• 6 edits in trunk/Source/WebCore

No need to run full can-use-for (fast inline layout codepath) check on every style change.
​https://bugs.webkit.org/show_bug.cgi?id=215937
<rdar://problem/67951360>

Reviewed by Antti Koivisto.

Let's use the StyleDifference to figure out how extensive the can-use-for check should be.
We can certainly skip some relatively expensive content checks when we know that the style change only triggers repaint or positioned-movement-only changes.

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::canUseForAfterStyleChange):

• layout/integration/LayoutIntegrationLineLayout.h:
• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::styleDidChange):

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForAfterStyleChange):

• rendering/SimpleLineLayout.h:

1:21 PM Changeset in webkit [266290] by mmaxfield@apple.com

• 5 edits
  2 adds in trunk

[iOS] Vertical text's logical width calculation is stale from the previous height of the WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=215910

Reviewed by Simon Fraser.

Source/WebCore:

When there is vertical text (really: orthogonal flows) in the content, the available width of the vertical
text is the height of its containing block. However, the height of the containing block (indeed: all ancestors)
may be "auto", in which case the CSS spec says the available width of the element should be "the initial
containing block's size."[1]

Previously, we were using the FrameView's visibleHeight as this metric. However, the visibleHeight is calculated
asynchronously, after layout, after a round-trip from the Web Process to the UI Process and back to the Web
Process. Therefore, if content changes the WKWebView's size and the web view immediatey re-lays-out, this
visibleHeight metric is stale from whatever the previous height of the WKWebView was. In addition, the
visibleHeight metric isn't even supposed to be used inside layout; it's instead only supposed to be used for
things like position: fixed elements.

Instead, we should use FrameView::layoutSize(), which is set before layout to the size of the WKWebView. The
name even indicates that it should be used for layout purposes.

[1] ​https://drafts.csswg.org/css-writing-modes-4/#orthogonal-auto

Test: WebKit.OrthogonalFlowAvailableSize

• rendering/RenderBox.cpp:

(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight const):

• rendering/RenderView.cpp:

(WebCore::RenderView::availableLogicalHeight const):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit/OrthogonalFlowAvailableSize.mm: Added.

(TEST):

• TestWebKitAPI/Tests/WebKit/orthogonal-flow-available-size.html: Added.

11:52 AM Changeset in webkit [266289] by Chris Dumez

• 16 edits
  1 copy
  7 adds in trunk/LayoutTests/imported/w3c

Resync web-platform-tests/webaudio from upstream
​https://bugs.webkit.org/show_bug.cgi?id=215935

Reviewed by Sam Weinig.

Resync web-platform-tests/webaudio from upstream 37c7777f647d4383943.

• web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/constructor-allowed-to-start-expected.txt: Added.
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-overflow-expected.txt: Added.
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-periodicwave-interface/periodicWave-expected.txt: Added.
• web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:

11:37 AM Changeset in webkit [266288] by commit-queue@webkit.org

• 4 edits in trunk

Fix text-transform inheritance to ::marker
​https://bugs.webkit.org/show_bug.cgi?id=214359

Patch by Tyler Wilcock <Tyler Wilcock> on 2020-08-28
Reviewed by Darin Adler.

Per ​https://github.com/w3c/csswg-drafts/issues/4206, default ::marker
pseudoelement style to text-transform: none in the UA stylesheet to
avoid surprising effects from inheritance.

No tests added -- change is tested by existing WPTs.

• css/html.css:

(::marker):

11:33 AM Changeset in webkit [266287] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

REGRESSION(r266187): ARGUMENT BAD: WebIconUtilities.mm(138) : RetainPtr<UIImage> WebKit::iconForFile(NSURL *) file, [file isFileURL]
​https://bugs.webkit.org/show_bug.cgi?id=215931

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-28
Reviewed by Wenson Hsieh.

It's possible for JavaScript to make a filename that doesn't convert to a file URL, such as the empty string.
When this happens, we would've returned null for the icon later anyways, but adding a null check prevents an assertion.
Covered by 7 existing tests which would have hit that assertion.

• WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::createIconForFiles):

11:02 AM Changeset in webkit [266286] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Remove the system tracing from DisplayList::Replayer::replay()
​https://bugs.webkit.org/show_bug.cgi?id=215933

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-08-28
Reviewed by Simon Fraser.

Remove this expensive tracing point since it can affect the tracing of
the MotionMark Design test.

• platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::Replayer::replay):

11:02 AM Changeset in webkit [266285] by Russell Epstein

• 3 edits
  1 add in branches/safari-610-branch

Cherry-pick r266254. rdar://problem/67949890

GetByVal constant folding over a Double OutOfBoundsSaneChain array with no BytecodeUsesAsOther should constant fold to PNaN, not undefined
​https://bugs.webkit.org/show_bug.cgi?id=215894
<rdar://problem/67669696>

Reviewed by Michael Saboff and Keith Miller.

JSTests:

• stress/oob-sane-chain-double-constant-fold-to-PNaN.js: Added.

Source/JavaScriptCore:

GetByVals of the form { OutOfBoundsSaneChain, Double } where there are no
BytecodeUsesAsOther return PNaN for holes and OOB accesses, not jsUndefined().
The constant folding for this though was folding to jsUndefined(). I forgot
to update that code to constant fold to PNaN when I wrote the OutOfBoundsSaneChain
implementation.

• dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:31 AM Changeset in webkit [266284] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

Enable TransformStream by default
​https://bugs.webkit.org/show_bug.cgi?id=215891

Reviewed by Darin Adler.

• Shared/WebPreferences.yaml:

10:24 AM Changeset in webkit [266283] by youenn@apple.com

• 13 edits in trunk

initializeReadableStream should check for highWaterMark be undefined
​https://bugs.webkit.org/show_bug.cgi?id=215890

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/streams/transform-streams/backpressure.any-expected.txt:
• web-platform-tests/streams/transform-streams/backpressure.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/errors.any-expected.txt:
• web-platform-tests/streams/transform-streams/errors.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/reentrant-strategies.any-expected.txt:
• web-platform-tests/streams/transform-streams/reentrant-strategies.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/strategies.any-expected.txt:
• web-platform-tests/streams/transform-streams/strategies.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/terminate.any-expected.txt:
• web-platform-tests/streams/transform-streams/terminate.any.worker-expected.txt:

Source/WebCore:

Covered by updated tests.

• Modules/streams/ReadableStream.js:

(initializeReadableStream):

10:14 AM Changeset in webkit [266282] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[macOS] Fix iokit-get-properties sandbox violations
​https://bugs.webkit.org/show_bug.cgi?id=215925

Reviewed by Darin Adler.

A few iokit properties needs to be added to the WebContent process' sandbox after observing these being in use.

• WebProcess/com.apple.WebProcess.sb.in:

10:00 AM Changeset in webkit [266281] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Remove adopted node from TextManipulationController
​https://bugs.webkit.org/show_bug.cgi?id=215914

Reviewed by Wenson Hsieh.

Remove Node from TextManipulationController when it gets adopted to a new document.

• dom/Node.cpp:

(WebCore::Node::moveNodeToNewDocument):

9:47 AM Changeset in webkit [266280] by graouts@webkit.org

• 5 edits
  2 adds in trunk

REGRESSION (r263506): scale transform transitions won't overshoot
​https://bugs.webkit.org/show_bug.cgi?id=215826
<rdar://problem/67759310>

Reviewed by Simon Fraser.

Source/WebCore:

Test: webanimations/accelerated-css-transition-with-easing-y-axis-above-1.html

In r263506 we made a change where accelerated animations would set their animation-wide
timing functions using PlatformCAAnimation::setTimingFunction() instead of setting it
on individual keyframes. This change was required to support the unique ability of
JS-originated animations to specify both an animation-wide timing function as well as
per-keyframe timing functions.

In the case of CSS Transitions, this meant that instead of setting a per-keyframe timing
function, this change would set the animation-wide timing function since CSS Transitions
should map the transition-timing-function property to the "easing" property of the Animation
object exposed by the Web Animations API, not as the timing function of the single keyframe
interval.

However, this change surfaced a bug in Core Animation on macOS and iOS where a cubic-bezier()
timing function with y values above 1 get clipped when applied to a CAKeyframeAnimation using
the timingFunction property (singular) instead of the timingFunctions property (plural).

To work around this issue, we set Animation::property() on the generated Animation object passed
to GraphicsLayerCA to make it possible to detect when we're dealing with a CSS Transition and
set the timing function on the keyframe interval rather than on the animation itself.

Alas, this does not fix the case where a JS-originated animation will specify an animation-wide
timing function with a cubic-bezier() timing function with y values above 1. There is no known
workaround at this time for this case and this is covered by bug 215918.

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

LayoutTests:

Add a new test that checks that a CSS Transition using a cubic-bezier() timing function with
a y value beyond 1 does not get clipped.

• platform/win/TestExpectations:
• webanimations/accelerated-css-transition-with-easing-y-axis-above-1-expected.html: Added.
• webanimations/accelerated-css-transition-with-easing-y-axis-above-1.html: Added.

9:08 AM Changeset in webkit [266279] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS iOS ] compositing/video/poster.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215929

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

8:23 AM Changeset in webkit [266278] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk1 ] svg/custom/object-sizing.xhtml is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215926

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

8:21 AM Changeset in webkit [266277] by Jonathan Bedard

• 5 edits
  1 delete in trunk/Tools

[webkitcorepy] Move Timeout to webkitcorepy (Part 3)
​https://bugs.webkit.org/show_bug.cgi?id=215584
<rdar://problem/67270713>

Reviewed by Darin Adler.

• Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Use webkitcorepy's Timeout object.
• Scripts/webkitpy/common/timeout_context.py: Removed.
• Scripts/webkitpy/port/simulator_process.py: Use webkitcorepy's Timeout object.
• Scripts/webkitpy/webdriver_plt/liveplt.py: Ditto.
• Scripts/webkitpy/xcode/simulated_device.py: Ditto.

6:37 AM Changeset in webkit [266276] by Alan Bujtas

• 10 edits
  1 add in trunk/Source/WebCore

[LFC][IFC] Move inline alignment code to LineBox
​https://bugs.webkit.org/show_bug.cgi?id=215117

Reviewed by Antti Koivisto.

LineBox is responsible for aligning the runs both vertically and horizontally (LineContentAligner -> LineBox).
(Note that LineBox::m_runRectList is transitional and will eventually be converted to inline boxes.)

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):
(WebCore::Layout::HangingContent::width const): Deleted.
(WebCore::Layout::HangingContent::isConditional const): Deleted.
(WebCore::Layout::HangingContent::setIsConditional): Deleted.
(WebCore::Layout::HangingContent::expand): Deleted.
(): Deleted.
(WebCore::Layout::HangingContent::reset): Deleted.
(WebCore::Layout::LineContentAligner::inlineRectList const): Deleted.
(WebCore::Layout::LineContentAligner::formattingContext const): Deleted.
(WebCore::Layout::LineContentAligner::layoutState const): Deleted.
(WebCore::Layout::LineContentAligner::LineContentAligner): Deleted.
(WebCore::Layout::LineContentAligner::alignHorizontally): Deleted.
(WebCore::Layout::LineContentAligner::alignVertically): Deleted.
(WebCore::Layout::LineContentAligner::adjustBaselineAndLineHeight): Deleted.
(WebCore::Layout::LineContentAligner::collectHangingContent const): Deleted.

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::inlineRectList const):
(WebCore::Layout::LineBox::logicalBottom const):
(WebCore::Layout::LineBox::logicalRect const):
(WebCore::Layout::LineBox::scrollableOverflow const):
(WebCore::Layout::LineBox::formattingContext const):
(WebCore::Layout::LineBox::layoutState const):
(WebCore::Layout::LineBox::setLogicalHeight): Deleted.
(WebCore::Layout::LineBox::setLogicalWidth): Deleted.
(WebCore::Layout::LineBox::moveHorizontally): Deleted.
(WebCore::Layout::LineBox::expandHorizontally): Deleted.
(WebCore::Layout::LineBox::shrinkHorizontally): Deleted.
(WebCore::Layout::LineBox::expandVertically): Deleted.
(WebCore::Layout::LineBox::shrinkVertically): Deleted.
(WebCore::Layout::LineBox::isConsideredEmpty const): Deleted.
(WebCore::Layout::LineBox::setIsConsideredEmpty): Deleted.
(WebCore::Layout::LineBox::setIsConsideredNonEmpty): Deleted.
(WebCore::Layout::LineBox::LineBox): Deleted.
(WebCore::Layout::LineBox::resetAlignmentBaseline): Deleted.

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::lineLogicalWidth const):
(WebCore::Layout::LineBuilder::availableWidth const):

• layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineLayoutContext::close):

• layout/inlineformatting/LineLayoutContext.h:

1:46 AM Changeset in webkit [266275] by Chris Lord

• 21 edits in trunk

Add WebGL(2) context support to OffscreenCanvas
​https://bugs.webkit.org/show_bug.cgi?id=209809

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Rebaseline OffscreenCanvas tests after enabling WebGL contexts.

• web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.getcontext-expected.txt:
• web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.getcontext.worker-expected.txt:

Source/WebCore:

Enable WebGL contexts with OffscreenCanvas by making sure the required
settings are marshalled to workers and that any functionality that
doesn't require an HTMLCanvasElement uses CanvasBase instead.

No new tests, rebaselined existing test.

• html/CanvasBase.h:
• html/CustomPaintCanvas.cpp:

(WebCore::CustomPaintCanvas::clearCopiedImage const):

• html/CustomPaintCanvas.h:
• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::clearCopiedImage const):

• html/HTMLCanvasElement.h:
• html/OffscreenCanvas.cpp:

(WebCore::requiresAcceleratedCompositingForWebGL):
(WebCore::shouldEnableWebGL):
(WebCore::OffscreenCanvas::createContextWebGL):
(WebCore::OffscreenCanvas::getContext):

• html/OffscreenCanvas.h:
• html/OffscreenCanvas.idl:
• html/canvas/WebGL2RenderingContext.idl:
• html/canvas/WebGLRenderingContext.idl:
• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::markContextChanged):
(WebCore::WebGLRenderingContextBase::paintRenderingResultsToCanvas):

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

• workers/WorkerGlobalScope.h:

(WebCore::WorkerGlobalScope::acceleratedCompositingEnabled const):
(WebCore::WorkerGlobalScope::webGLEnabled const):

• workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):

• workers/WorkerThread.cpp:

(WebCore::WorkerParameters::isolatedCopy const):

• workers/WorkerThread.h:
• workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::ServiceWorkerThread):

Aug 27, 2020:

9:49 PM Changeset in webkit [266274] by Lauro Moura

• 13 edits in trunk/LayoutTests

[GLIB] Rebaseline websocket tests after r266230

Unreviewed test gardening.

• platform/glib/TestExpectations:
• platform/glib/http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-ok-with-http-version-beyond-1_1-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/invalid-encode-length-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/invalid-masked-frames-from-server-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/long-control-frame-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/long-invalid-header-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/network-process-crash-error-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/too-long-payload-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:

8:56 PM Changeset in webkit [266273] by Ryan Haddad

• 1 edit
  4 adds in trunk/LayoutTests

Unreviewed test gardening, add Windows baselines after r266228.

• platform/win/streams/reference-implementation/transform-stream-errors-expected.txt: Added.
• platform/win/streams/reference-implementation/transform-stream-expected.txt: Added.

8:24 PM Changeset in webkit [266272] by Lauro Moura

• 2 edits in trunk/Tools

REGRESSION(r266221) Layout tests step hanging due to slow WaveDiff comparison
​https://bugs.webkit.org/show_bug.cgi?id=215886

Reviewed by Darin Adler.

After r266221, a couple of webaudio tests generated WAV files with a
small difference in a large number of samples. This caused the
WaveDiff comparison to take too long.

While it works fine for small diffs, this ends up creating repeatedly
large strings for each concatenation, bringing the comparisons to a
halt.

Instead of relying on string concatenation, use a list to collect then
and only concat when actually retrieving the full string.

• Scripts/webkitpy/common/wavediff.py:

(WaveDiff.init):
(WaveDiff._diffParam):
(WaveDiff._diffSample):
(WaveDiff.diffText):

8:07 PM Changeset in webkit [266271] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

[LFC][IFC] LineBuilder:Run should not have vertical geometry
​https://bugs.webkit.org/show_bug.cgi?id=215068

Reviewed by Antti Koivisto.

Since LineBuilder only takes care of the horizontal ascpect of a run, LineBuilder::Run should only have logical left and width geometry.
The vertical geometry is computed as part of the content alignment phase in LineContentAligner (along with the final horizontal position
adjusted with the alignment).
This is still a transitional state (see InlineRunRectList m_runRectList) and all the line box related code will get moved to the LineBox class.
This patch also enables us to keep LineBuilder::Run const.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::LineContentAligner::inlineRectList const):
(WebCore::Layout::LineContentAligner::LineContentAligner):
(WebCore::Layout::LineContentAligner::alignHorizontally):
(WebCore::Layout::LineContentAligner::alignVertically):
(WebCore::Layout::LineContentAligner::adjustBaselineAndLineHeight):
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):
(WebCore::Layout::LineContentAligner::justifyRuns): Deleted.
(WebCore::Layout::LineContentAligner::runContentHeight const): Deleted.

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::visuallyCollapsePreWrapOverflowContent):
(WebCore::Layout::LineBuilder::TrimmableTrailingContent::addFullyTrimmableContent):
(WebCore::Layout::LineBuilder::TrimmableTrailingContent::addPartiallyTrimmableContent):
(WebCore::Layout::LineBuilder::Run::Run):
(WebCore::Layout::LineBuilder::Run::expand):
(WebCore::Layout::LineBuilder::Run::removeTrailingWhitespace):
(WebCore::Layout::LineBuilder::Run::setHorizontalExpansion):
(WebCore::Layout::m_textContent): Deleted.
(WebCore::Layout::LineBuilder::Run::setComputedHorizontalExpansion): Deleted.

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::Run::style const):
(WebCore::Layout::LineBuilder::Run::logicalWidth const):
(WebCore::Layout::LineBuilder::Run::logicalLeft const):
(WebCore::Layout::LineBuilder::Run::expansion const):
(WebCore::Layout::LineBuilder::Run::hasExpansionOpportunity const):
(WebCore::Layout::LineBuilder::Run::expansionOpportunityCount const):
(WebCore::Layout::LineBuilder::Run::hasTrailingWhitespace const):
(WebCore::Layout::LineBuilder::Run::trailingWhitespaceWidth const):
(WebCore::Layout::LineBuilder::Run::moveHorizontally):
(WebCore::Layout::LineBuilder::Run::shrinkHorizontally):
(WebCore::Layout::LineBuilder::Run::hasCollapsedTrailingWhitespace const):
(WebCore::Layout::LineBuilder::runs const):
(WebCore::Layout::LineBuilder::Run::logicalRect const): Deleted.
(WebCore::Layout::LineBuilder::Run::adjustLogicalTop): Deleted.
(WebCore::Layout::LineBuilder::Run::moveVertically): Deleted.
(WebCore::Layout::LineBuilder::Run::setLogicalHeight): Deleted.
(WebCore::Layout::LineBuilder::runs): Deleted.

7:56 PM Changeset in webkit [266270] by Chris Dumez

• 6 edits
  2 adds in trunk

AudioParam's minValue / maxValue are ignored
​https://bugs.webkit.org/show_bug.cgi?id=215905

Reviewed by Darin Adler.

Source/WebCore:

Clamp the AudioParam's values so that they are always in the
[minValue, maxValue] range.

Test: webaudio/audioparam-nominal-range.html

• Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::value):
(WebCore::AudioParam::setValue):
(WebCore::AudioParam::smooth):
(WebCore::AudioParam::calculateFinalValues):
(WebCore::AudioParam::calculateTimelineValues):

• Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::AudioParamTimeline::valuesForTimeRange):

• Modules/webaudio/AudioParamTimeline.h:
• Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

LayoutTests:

Import layout test coverage from Blink.

• webaudio/audioparam-nominal-range-expected.txt: Added.
• webaudio/audioparam-nominal-range.html: Added.

7:55 PM Changeset in webkit [266269] by rniwa@webkit.org

• 12 edits in trunk

Prevent infinite recursion when upgrading custom elements
​https://bugs.webkit.org/show_bug.cgi?id=206605

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaselined the test now that one more test case is passing.

• web-platform-tests/custom-elements/upgrading-expected.txt:

Source/WebCore:

This patch updates our implementation of the concept to upgrade an element [1] and related algorithms
to match the latest HTML5 specification. In particular, it incorporates the algorithmic change [2] to
prevent infinite recursion an element is re-inserted into a document tree inside its constructor.

The key code change is in JSCustomElementInterface::upgradeElement where this patch adds an early exit
when custom element is not "undefined" or "uncustomized" and the custom element state is set to "failed"
immediately before invoking the constructor. The rest of code changes deals with this "failed" state
appearing during upgrades and updates various debug assertions.

[1] ​https://html.spec.whatwg.org/multipage/custom-elements.html#concept-upgrade-an-element
[2] ​https://github.com/whatwg/html/pull/5126
[3] ​https://html.spec.whatwg.org/multipage/custom-elements.html#concept-try-upgrade

Test: imported/w3c/web-platform-tests/custom-elements/upgrading.html

• bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::constructElementWithFallback):
(WebCore::JSCustomElementInterface::upgradeElement): Implements the new behavior. Note that we still
need to clear the queue where we used to set the custom element state to "failed" to avoid memory leaks.

• dom/CustomElementReactionQueue.cpp:

(WebCore::CustomElementReactionQueue::hasJustUpgradeReaction const): Added.
(WebCore::CustomElementReactionQueue::enqueueElementUpgrade): Enqueue the element to the element queue
even if it had already been scheduled to upgrade previously. This makes the innermost attempt to upgrade
to succeed instead of the outermost. Also updated debug assertions.
(WebCore::CustomElementReactionQueue::tryToUpgradeElement): Renamed from enqueueElementUpgradeIfDefined
to match the spec's name [3]. Unlike the concept in the spec, this function doesn't get called when
the custom element state of the elemnt is either "undefined" or "uncustomized" to avoid unnecessary work.

• dom/CustomElementReactionQueue.h:

(WebCore::CustomElementReactionQueue::isEmpty const): Added.

• dom/CustomElementRegistry.cpp:

(WebCore::upgradeElementsInShadowIncludingDescendants):
(WebCore::CustomElementRegistry::upgrade):

• dom/Document.cpp:

(WebCore::createFallbackHTMLElement): Call setIsCustomElementUpgradeCandidate on a newly created since
we can no longer update node flags in enqueueToUpgrade

• dom/Element.cpp:

(WebCore::Element::insertedIntoAncestor):
(WebCore::Element::setIsFailedCustomElement): Removed the unused function argument.
(WebCore::Element::setIsFailedCustomElementWithoutClearingReactionQueue): Extracted from
setIsFailedCustomElement.
(WebCore::Element::clearReactionQueueFromFailedCustomElement): Ditto.
(WebCore::Element::enqueueToUpgrade): No longer updates node flags as this would clear "failed" state
from a custom element which is currently being upgraded and cause all sorts of issues.
(WebCore::Element::reactionQueue const): Updated debug assertions.

• dom/Element.h:

LayoutTests:

Removed the crash expectation from a test now that it's passing.

• TestExpectations:

7:32 PM Changeset in webkit [266268] by wilander@apple.com

• 15 edits in trunk/Source

Remove the feature flag for capped cookies set in 3rd-party CNAME cloaked HTTP responses and add ITP debug logging
​https://bugs.webkit.org/show_bug.cgi?id=215902
<rdar://problem/66699731>

Reviewed by Brent Fulgham.

This change removes the feature flag, effectively turning the feature on.
It also adds log output of cookie names that have been capped when ITP
Debug Mode is enabled.

Source/WebCore:

WebCore::NetworkStorageSession now has a member flag for ITP debug logging.

No new tests. This feature already has tests.

• page/Settings.yaml:
• platform/network/NetworkStorageSession.cpp:

(WebCore::NetworkStorageSession::setResourceLoadStatisticsDebugLoggingEnabled):
(WebCore::NetworkStorageSession::resourceLoadStatisticsDebugLoggingEnabled const):

New function to be able to conditionalize log output in the new feature.

• platform/network/NetworkStorageSession.h:

Source/WebKit:

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::setResourceLoadStatisticsDebugMode):

Now sets the flag in WebCore::NetworkStorageSession through the new function
WebCore::NetworkStorageSession::setResourceLoadStatisticsDebugLoggingEnabled().

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::resetParametersToDefaultValues):
(WebKit::NetworkProcess::setIsRunningResourceLoadStatisticsTest):

• NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::setFirstPartyHostCNAMEDomain):
(WebKit::NetworkSession::firstPartyHostCNAMEDomain):

• NetworkProcess/NetworkSession.h:

(WebKit::NetworkSession::setCNAMECloakingMitigationEnabled): Deleted.
(WebKit::NetworkSession::cnameCloakingMitigationEnabled const): Deleted.

• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::updateFirstPartyInfoForSession):
(WebKit::NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking):

• Shared/ResourceLoadStatisticsParameters.h:

(WebKit::ResourceLoadStatisticsParameters::encode const):
(WebKit::ResourceLoadStatisticsParameters::decode):

• Shared/WebPreferences.yaml:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):

• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::platformSetNetworkParameters):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::parameters):

7:00 PM Changeset in webkit [266267] by clopez@igalia.com

• 2 edits in trunk/Tools

[webkitpy] repository svn version is incorrect when working on a branch
​https://bugs.webkit.org/show_bug.cgi?id=215863

Reviewed by Jonathan Bedard.

When working on a SVN branch, the information pointed in the Revision field
doesn't reflect the last change on the branch, but the last change on trunk.
Instead of picking that changeset, pick the "Last Changed Rev" one that should
reflect the last change done in the current checkout (working directory).

• Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.svn_revision):

6:24 PM Changeset in webkit [266266] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

CSS Filter invert() and opacity() Implementation Should Use Linear Transfer Function for Clarity and Simplicity
​https://bugs.webkit.org/show_bug.cgi?id=215896

Simplify CSS filters, invert() and opacity() implementation by using "linear" transfer function,
instead of using a more confusing transfer function, "table". For invert(), the transfer function
is type="table" tableValues="[amount] (1 - [amount])", which is equivalent to a linear function
of slope 1 - 2 * [amount] and intercept [amount]; for opacity the transfer function is type="table" tableValues="0 [amount]"
which is equivalent to a linear transfer function of slope [amount] and intercept 0. This change will make the implementation
clearer and simpler.

Patch by Frank Yang <​guowei_yang@apple.com> on 2020-08-27
Reviewed by Myles C. Maxfield.

No new tests needed, using existing tests in css/filter-effects

• rendering/CSSFilter.cpp:

(WebCore::CSSFilter::build): Modified the implementation of invert() and opacity() so that they both use

a linear component transfer function instead of a more confusing table transfer function.

6:18 PM Changeset in webkit [266265] by Devin Rousso

• 22 edits in trunk

[iOS] provide a way to get previously inserted alternatives for the selected text
​https://bugs.webkit.org/show_bug.cgi?id=215816
<rdar://problem/66646042>

Reviewed by Darin Adler.

Source/WebCore:

• editing/cocoa/AlternativeTextUIController.h:
• editing/cocoa/AlternativeTextUIController.mm:

(WebCore::AlternativeTextUIController::alternativesForContext):
Return the raw NSTextAlternatives * and let the caller create the Vector<String> if they
need to so that callers that don't can use the actual NSTextAlternatives *.

• editing/Editor.h:
• editing/Editor.cpp:

(WebCore::Editor::applyDictationAlternative): Added.
(WebCore::Editor::applyDictationAlternativelternative): Deleted.

• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
Drive-by: fix typo.

Source/WebKit:

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView alternativesForSelectedText]):

• UIProcess/WebPageProxy.h:
• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::platformDictationAlternatives): Added.

• UIProcess/PageClient.h:
• UIProcess/Cocoa/PageClientImplCocoa.h:
• UIProcess/Cocoa/PageClientImplCocoa.mm:

(WebKit::PageClientImplCocoa::dictationAlternatives):
(WebKit::PageClientImplCocoa::platformDictationAlternatives): Added.
Provide a way to get the raw NSTextAlternatives * for a given WebCore::DictationContext.

• Shared/EditorState.h:
• Shared/EditorState.cpp:

(WebKit::EditorState::PostLayoutData::encode const):
(WebKit::EditorState::PostLayoutData::decode):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPlatformEditorState const):
Include a Vector<WebCore::DictationContext> as part of the EditorState that contains all
of the WebCore::DictationContext that exist in the currently selected range (or the range
of the word containing the cursor if nothing is selected).

• Platform/spi/ios/UIKitSPI.h:

Source/WebKitLegacy/mac:

• WebView/WebView.mm:

(-[WebView _dictationAlternatives:]):
Create a Vector<String> from the returned NSTextAlternatives * now that the member
WebCore::AlternativeTextUIController::alternativesForContext returns it.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/InsertTextAlternatives.mm:

(InsertTextAlternatives.Simple):

• TestWebKitAPI/ios/UIKitSPI.h:

5:27 PM Changeset in webkit [266264] by Alexey Shvayka

• 14 edits
  1 add in trunk

proto in object literal should perform SetPrototypeOf? directly
​https://bugs.webkit.org/show_bug.cgi?id=215769

Reviewed by Ross Kirsling.

JSTests:

• microbenchmarks/object-literal-underscore-proto-setter.js: Added.
• stress/syntax-checker-duplicate-underscore-proto.js:

Rewrite the test to ensure each eval() call throws a SyntaxError.

Source/JavaScriptCore:

To fix proto usage in object literals if Object.prototype.proto is overridden
or removed, this patch sets the Prototype? directly, aligning JSC with V8 and
SpiderMonkey. We are safe to skip method table lookups and cycle checks, as the
spec [1] calls SetPrototypeOf? on newly created (unreferenced) ordinary objects.

This change removes PropertyNode::PutType because its only purpose was to accomodate
proto in object literals. Since emitPutConstantProperty() handles static public
class fields, which don't need super binding, PropertyNode::isUnderscoreProtoSetter()
is extended to reject class properties.

This patch speeds up creating object literals with proto by 25%.

[1]: ​https://tc39.es/ecma262/#sec-__proto__-property-names-in-object-initializers (step 7.a)

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitDirectSetPrototypeOf):

1. Remove unused dst parameter to align with other put methods.
2. Remove divot* parameters as it's cumbersome to pass them through, and globalFuncSetPrototypeDirect() never throws anyway.

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitPutConstantProperty):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_putByIdDirect):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_putByIdDirectPrivate):
(JSC::ClassExprNode::emitBytecode):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::isUnderscoreProtoSetter const):

• parser/NodeConstructors.h:

(JSC::PropertyNode::PropertyNode):

• parser/Nodes.h:
• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseProperty):

• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createProperty):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncSetPrototypeDirect):

1. Ignore a prototype value of incorrect type as per spec [1], which is unobservable for call sites in ClassExprNode::emitBytecode().
2. Assert that JSObject::setPrototypeDirect() doesn't throw.

LayoutTests:

• js/script-tests/object-literal-direct-put.js:

4:48 PM Changeset in webkit [266263] by Chris Dumez

• 3 edits in trunk/Source/WebCore

AudioParam does not need to store its values as double
​https://bugs.webkit.org/show_bug.cgi?id=215903

Reviewed by Darin Adler.

AudioParam does not need to store its values as double. float precision is sufficient for
Web Audio values and we end up casting these values to float anyway.

• Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::AudioParam):
(WebCore::AudioParam::value):
(WebCore::AudioParam::smoothedValue):
(WebCore::AudioParam::smooth):
(WebCore::AudioParam::calculateFinalValues):
(WebCore::AudioParam::calculateTimelineValues):

• Modules/webaudio/AudioParam.h:

4:47 PM Changeset in webkit [266262] by Simon Fraser

• 4 edits
  2 adds in trunk

Scrolling on select element doesn't work after scrolling the page
​https://bugs.webkit.org/show_bug.cgi?id=215900
Source/WebCore:

<rdar://problem/67766032>

Reviewed by Tim Horton.

The scrolling thread could use a node that was latched some time ago; we need to
check the freshness of the latched node before using it.

Test: fast/scrolling/latching/latching-stuck-to-main-page.html

• page/scrolling/ScrollingTreeLatchingController.cpp:

(WebCore::ScrollingTreeLatchingController::receivedWheelEvent):
(WebCore::ScrollingTreeLatchingController::latchedNodeForEvent const):
(WebCore::ScrollingTreeLatchingController::latchedNodeIsRelevant const):

• page/scrolling/ScrollingTreeLatchingController.h:

LayoutTests:

Reviewed by Tim Horton.

• fast/scrolling/latching/latching-stuck-to-main-page-expected.txt: Added.
• fast/scrolling/latching/latching-stuck-to-main-page.html: Added.

4:43 PM Changeset in webkit [266261] by Chris Dumez

• 11 edits in trunk

Fix AudioParam.linearRampToValueAtTime() formula to match specification
​https://bugs.webkit.org/show_bug.cgi?id=215904

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing or now that they keep passing/failing with
slightly different values.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-linearRampToValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audiobuffersource-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-linearRampToValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-position-expected.txt:

Source/WebCore:

Fix AudioParam.linearRampToValueAtTime() formula to match specification:

• ​https://www.w3.org/TR/webaudio/#dom-audioparam-linearramptovalueattime

We were using a different formula to compute the value and this was causing us
to fail some web platform tests.

No new tests, rebaselined existing tests.

• Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

3:18 PM Changeset in webkit [266260] by aakash_jain@apple.com

• 2 edits in trunk/Tools

Ensure that email notifications are not sent for obsolete and r- patches
​https://bugs.webkit.org/show_bug.cgi?id=215867

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(BugzillaMixin.should_send_email): Method to check if patch is obsolete/r-.
(AnalyzeCompileWebKitResults): Inherit from BugzillaMixin.
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Check for patch state before sending email.
(AnalyzeLayoutTestsResults): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.

3:15 PM Changeset in webkit [266259] by Russell Epstein

• 1 copy in tags/Safari-610.2.2.4

Tag Safari-610.2.2.4.

2:48 PM Changeset in webkit [266258] by Russell Epstein

• 8 edits in branches/safari-610.2.2-branch/Source

Versioning.

WebKit-7610.2.2.4

2:32 PM Changeset in webkit [266257] by ysuzuki@apple.com

• 3 edits
  1 add in trunk

[JSC] setLength in Array#push could get very large length
​https://bugs.webkit.org/show_bug.cgi?id=215897
<rdar://problem/67859149>

Reviewed by Keith Miller.

JSTests:

• stress/array-push-more-than-max-size.js: Added.

(shouldBe):
(shouldThrow):

Source/JavaScriptCore:

Array#push can get length larger than UINT32_MAX. And in this case, we should throw a RangeError.
Before r266215, it was using putLength which throws an error. But it was replaced with setLength,
and JSC::setLength assumes that it never gets a length greater than UINT32_MAX by asserting. We
should fix it so that Array#push should thrown an error correctly.

• runtime/ArrayPrototype.cpp:

(JSC::setLength):

2:31 PM Changeset in webkit [266256] by aakash_jain@apple.com

• 3 edits in trunk/Tools

Send ews email notifications to myself
​https://bugs.webkit.org/show_bug.cgi?id=215815

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/send_email.py:

(send_email_to_patch_author): Send a copy of email notification to myself.

• BuildSlaveSupport/ews-build/master.cfg: Stop receiveing old style email notifications for build failures.

2:28 PM Changeset in webkit [266255] by Jonathan Bedard

• 2 edits
  6 adds in trunk/Tools

[webkitscmpy] Initial commit
​https://bugs.webkit.org/show_bug.cgi?id=215864
<rdar://problem/67827063>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitscmpy: Added.
• Scripts/libraries/webkitscmpy/MANIFEST.in: Added.
• Scripts/libraries/webkitscmpy/README.md: Added.
• Scripts/libraries/webkitscmpy/setup.py: Added.

(readme):

• Scripts/libraries/webkitscmpy/webkitscmpy: Added.
• Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Added.

(_maybe_add_webkitcorepy_path):

• Scripts/webkitpy/test/main.py:

(main): Add webkitscmpy to test-webkitpy.

2:16 PM Changeset in webkit [266254] by sbarati@apple.com

• 3 edits
  1 add in trunk

GetByVal constant folding over a Double OutOfBoundsSaneChain array with no BytecodeUsesAsOther should constant fold to PNaN, not undefined
​https://bugs.webkit.org/show_bug.cgi?id=215894
<rdar://problem/67669696>

Reviewed by Michael Saboff and Keith Miller.

JSTests:

• stress/oob-sane-chain-double-constant-fold-to-PNaN.js: Added.

Source/JavaScriptCore:

GetByVals of the form { OutOfBoundsSaneChain, Double } where there are no
BytecodeUsesAsOther return PNaN for holes and OOB accesses, not jsUndefined().
The constant folding for this though was folding to jsUndefined(). I forgot
to update that code to constant fold to PNaN when I wrote the OutOfBoundsSaneChain
implementation.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

2:10 PM Changeset in webkit [266253] by jh718.park@samsung.com

• 9 edits
  6 adds in trunk

Implement @supports selector().
​https://bugs.webkit.org/show_bug.cgi?id=199237

Reviewed by Antti Koivisto.

This feature allows authors to test if the browser supports the tested selector syntax.
The corresponding spec is ​https://drafts.csswg.org/css-conditional-4/#at-supports-ext.

And unknown -webkit- pseudo elements are not supported according to the spec,
​https://drafts.csswg.org/css-conditional-4/#support-definition-ext.

LayoutTests/imported/w3c:

• web-platform-tests/css/cssom/CSS-expected.txt:

Source/WebCore:

Tests: css3/conditional/w3c/at-supports-040.html

css3/conditional/w3c/at-supports-041.html
css3/conditional/w3c/at-supports-042.html

• css/CSSValueKeywords.in:
• css/parser/CSSParserImpl.h:

(WebCore::CSSParserImpl::context const):

• css/parser/CSSSelectorParser.cpp:

(WebCore::CSSSelectorParser::supportsComplexSelector):
(WebCore::CSSSelectorParser::containsUnknownWebKitPseudoElements):

• css/parser/CSSSupportsParser.cpp:

(WebCore::CSSSupportsParser::supportsCondition):
(WebCore::CSSSupportsParser::consumeCondition):
(WebCore::CSSSupportsParser::consumeNegation):
(WebCore::CSSSupportsParser::consumeSupportsFeatureOrGeneralEnclosed):
(WebCore::CSSSupportsParser::consumeSupportsSelectorFunction):
(WebCore::CSSSupportsParser::consumeConditionInParenthesis):
(WebCore::CSSSupportsParser::consumeDeclarationConditionOrGeneralEnclosed): Deleted.

• css/parser/CSSSupportsParser.h:

LayoutTests:

• css3/conditional/w3c/at-supports-040-expected.html: Added.
• css3/conditional/w3c/at-supports-040.html: Added.
• css3/conditional/w3c/at-supports-041-expected.html: Added.
• css3/conditional/w3c/at-supports-041.html: Added.
• css3/conditional/w3c/at-supports-042-expected.html: Added.
• css3/conditional/w3c/at-supports-042.html: Added.

2:02 PM Changeset in webkit [266252] by Simon Fraser

• 4 edits in trunk/Source/WebCore

ScrollLatchingState::previousWheelScrolledElement() is unused
​https://bugs.webkit.org/show_bug.cgi?id=215881

Reviewed by Zalan Bujtas.

Scroll latching's previousWheelScrolledElement() was unused. It was never set since
we never end up with a null wheelEventElement. This functionality has been retained
from ancient code with little understanding of its utility.

• page/EventHandler.cpp:

(WebCore::handleWheelEventInAppropriateEnclosingBox):
(WebCore::EventHandler::defaultWheelEventHandler):

• page/scrolling/ScrollLatchingState.cpp:

(WebCore::ScrollLatchingState::clear):
(WebCore::operator<<):
(WebCore::ScrollLatchingState::setPreviousWheelScrolledElement): Deleted.

• page/scrolling/ScrollLatchingState.h:

1:11 PM Changeset in webkit [266251] by keith_miller@apple.com

• 5 edits in trunk/Source/JavaScriptCore

structureOrNull should take VM instead of getting it from the marked block
​https://bugs.webkit.org/show_bug.cgi?id=215899

Reviewed by Yusuke Suzuki.

It's slightly faster use an existing VM over recomputing the address. It probably doesn't
happen to matter here for performance but it's good hygiene.

• API/tests/JSWrapperMapTests.mm:

(+[JSWrapperMapTests testStructureIdentity]):

• jit/JITOperations.cpp:
• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::structureOrNull const):
(JSC::JSValue::structureOrUndefined const): Deleted.

1:01 PM Changeset in webkit [266250] by ysuzuki@apple.com

• 4 edits in trunk/Source/JavaScriptCore

[JSC] Use auxiliary memory for JSBigInt storage
​https://bugs.webkit.org/show_bug.cgi?id=215876

Reviewed by Mark Lam.

This makes JSBigInt non-destructible cell. And it makes allocating JSBigInt from JIT easy.

• runtime/JSBigInt.cpp:

(JSC::JSBigInt::JSBigInt):
(JSC::JSBigInt::visitChildren):
(JSC::JSBigInt::createWithLength):
(JSC::JSBigInt::destroy): Deleted.

• runtime/JSBigInt.h:
• runtime/VM.cpp:

(JSC::VM::VM):

12:52 PM Changeset in webkit [266249] by stephan.szabo@sony.com

• 4 edits in trunk

[PlayStation] Build fix due to memmem not always being available.
​https://bugs.webkit.org/show_bug.cgi?id=215893

Unreviewed build fix

.:

• Source/cmake/OptionsPlayStation.cmake: Check for memmem

Source/WTF:

• wtf/PlatformHave.h: Don't always HAVE_MEMMEM on playstation

11:56 AM Changeset in webkit [266248] by Wenson Hsieh

• 7 edits
  2 adds in trunk

Occasional crashes when restoring replaced text under Editor::changeBackToReplacedString
​https://bugs.webkit.org/show_bug.cgi?id=215892
<rdar://problem/67731156>

Reviewed by Tim Horton.

Source/WebCore:

While reverting the replaced string in Editor::changeBackToReplacedString, it's possible for text replacement
(Editor::replaceSelectionWithText) to cause the text checking paragraph range to become orphaned (if for no
reason other than the fact that arbitrary script can run in between). If this happens, then our attempts to
expand the checking range to paragraph boundaries underneath TextCheckingParagraph::paragraphRange will result
in a null dereference, since the boundary points computed underneath the expandToParagraphBoundary helper will
be nullopt.

Mitigate this (and any other potentially similar crashes) by making expandToParagraphBoundary robust in the
case where expanding to the start and end fails, and just fall back to returning the original text checking
range instead.

Test: editing/mac/input/change-back-to-replaced-string.html

• editing/Editor.h:
• editing/TextCheckingHelper.cpp:

(WebCore::expandToParagraphBoundary):

See above for more details.

• testing/Internals.cpp:

(WebCore::Internals::changeBackToReplacedString):

• testing/Internals.h:
• testing/Internals.idl:

Add a simple internal testing hook to change the currently selected text back to the given replaced string.

LayoutTests:

Add a layout test to exercise the crash.

• editing/mac/input/change-back-to-replaced-string-expected.txt: Added.
• editing/mac/input/change-back-to-replaced-string.html: Added.

11:06 AM Changeset in webkit [266247] by Russell Epstein

• 5 edits
  4 adds in branches/safari-610.1.28.1-branch

Apply patch. rdar://problem/67877085

11:02 AM Changeset in webkit [266246] by Russell Epstein

• 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.5

10:28 AM Changeset in webkit [266245] by Antti Koivisto

• 3 edits
  2 adds in trunk

:host() pseudo-selector reported as :host in CSSStyleRule
​https://bugs.webkit.org/show_bug.cgi?id=207567
<rdar://problem/59365547>

Reviewed by Simon Fraser.

Source/WebCore:

Test case by ​jlo@logrocket.com

Test: fast/shadow-dom/css-scoping-host-serialization.html

• css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText const):

Serialize the function form of :host.

LayoutTests:

• fast/shadow-dom/css-scoping-host-serialization-expected.txt: Added.
• fast/shadow-dom/css-scoping-host-serialization.html: Added.

10:17 AM Changeset in webkit [266244] by sihui_liu@apple.com

• 4 edits in trunk

REGRESSION (r264790): IndexedDB may abort transactions of in-memory databases
​https://bugs.webkit.org/show_bug.cgi?id=215855
<rdar://problem/67418574>

Reviewed by Youenn Fablet.

Source/WebCore:

We don't abort transactions on in-memory database before process suspension because they don't hold database
file lock. Before r264790, only ephemeral session would use in-memory databases, so we only checked session. Now
persistent session also uses in-memory databases for third-party storage, so we need to add another check.

API test: IndexedDB.SuspendImminentlyForThirdPartyDatabases

• Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::stopDatabaseActivitiesOnMainThread):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm:

(postResult):
(catch):

10:13 AM Changeset in webkit [266243] by youenn@apple.com

• 9 edits in trunk

Fix propagation of errors in TransformStream
​https://bugs.webkit.org/show_bug.cgi?id=215888

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/streams/transform-streams/backpressure.any-expected.txt:
• web-platform-tests/streams/transform-streams/errors.any-expected.txt:
• web-platform-tests/streams/transform-streams/errors.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/strategies.any-expected.txt:
• web-platform-tests/streams/transform-streams/strategies.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/terminate.any-expected.txt:

Source/WebCore:

We were not passing the right values to the reject function of the promise capability.
Covered by rebased tests.

• Modules/streams/TransformStreamInternals.js:

(transformStreamDefaultControllerPerformTransform):
(transformStreamDefaultSinkWriteAlgorithm):
(transformStreamDefaultSinkCloseAlgorithm):

10:10 AM Changeset in webkit [266242] by keith_miller@apple.com

• 9 edits in trunk/Source/JavaScriptCore

OSR availability validation should run for any node with exitOK
​https://bugs.webkit.org/show_bug.cgi?id=215672

Reviewed by Saam Barati.

Currently we only validate OSR exit availability if a node would
say mayExit(graph, node) != DoesNotExit and the node is marked
as exitOK. However, it would be perfectly valid to insert a node
that exits anywhere we have a node marked exitOK. So with this
patch we now validate all places where it would ever be possible
to OSR exit.

Relaxing our criteria revealed a number of bugs however. Which I
will describe below in, IMO, increasing complexity/subtly.

First, we currently don't mark arity fixup during inlining as not
exitOK. However, since our arity code says its code origin is
OpEnter, we assume arity fixup has already happened.

Second, OpGetScope, should not mark its first argument as used
since it's not actually used. This is problematic because we could
have a loop where OpGetScope is the first bytecode, namely when
doing tail recursive inlining. If we were in that position, there
could be a local that was used at a merge point at the loop
backedge that had two MovHint defs from both predecessors. In DFG
IR this would look like:

BB#1:
@1: MovHint(Undefined, loc1)
...
Jump(#2)

BB#2:
... loc1 is live here in bytecode
@2: MovHint(@scopeObject, loc1)
@3: SetLocal(@scopeObject, loc1)
Branch(#3, #4) #4 is the successor of the tail call loop

BB#3:
@4 MovHint(Undefined, loc1)
...
Jump(#2)

When we do CPS conversion the MovHints at @1 and @4 will be seen
as different variables (there's no GetLocal). Then, after, during
SSA conversion we won't insert a phi connecting them, making the
argument to OpGetScope, in this case loc1, unrecoverable there are
conflicting nodes and the value isn't saved on the stack.

There were also issues with MovHintRemoval Phase but rather than
fix them we opted to just remove the phase as it didn't show any
performance impact. I'll describe the issues I found below for
completeness, however.

Third, MovHint removal phase had a bug where it would not mark
sections where a zombied MovHint has yet to be killed as not
exitOK. So in theory another phase could come along and insert an
exiting node there.

Fourth, MovHint removal phase had a second bug where a MovHint
that was not killed in the current block would be zombied, which
is wrong for SSA. It's wrong because the MovHinted value could
still be live for OSR exit in a successor block.

Lastly, this patch adds some new verbose options as well as the ability to
dump a DFG::BasicBlock without dereferencing it.

• bytecode/BytecodeUseDef.cpp:

(JSC::computeUsesForBytecodeIndexImpl):

• dfg/DFGBasicBlock.cpp:

(WTF::printInternal):

• dfg/DFGBasicBlock.h:
• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::inlineCall):

• dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::propagatePhis):

• dfg/DFGEpoch.h:

(JSC::DFG::Epoch::operator bool const):

• dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::OSRAvailabilityAnalysisPhase::run):

• dfg/DFGSSACalculator.cpp:

(JSC::DFG::SSACalculator::dump const):

10:02 AM Changeset in webkit [266241] by graouts@webkit.org

• 5 edits
  2 adds in trunk

REGRESSION (r263506): timing of CSS Animation on ​https://animate.style is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=215807
<rdar://problem/66770136>

Reviewed by Simon Fraser.

Source/WebCore:

Test: webanimations/accelerated-css-animation-with-easing.html

In r263506, we added a way for accelerated animations to adhere to both a timing function set on the
animation, affecting the timing of the entire animation, as well as a timing function set on individual
keyframes, affecting the timing of the animation in a given interval. Alas, this change broke handling
of timing functions with implicit animation-timing-function on keyframes.

That code change assumed that the Animation object ultimately passed to GraphicsLayerCA::setupAnimation()
would return the animation-wide timing function through Animation::timingFunction(). This was correct for
JS-originated animations, but not for CSS Animations, since that value was set based on the computed CSS
property animation-timing-function for the target element. However, that CSS property does not specify
the animation-wide timing function, but rather the default timing function to use for keyframes should
they fail to specify an explicit timing function.

To fix this, first, we ensure that the animation-wide timing function is set on the Animation object,
changing KeyframeEffect::backingAnimationForCompositedRenderer() to always generate an Animation object
based on the effect, divorcing itself from the Animation object created through CSS.

Then, we add a new member to Animation to specify the default timing function for keyframes, allowing
GraphicsLayerCA to use it to determine the timing function when building keyframes.

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const): Always generate an Animation
object based on the effect's properties, also setting the new defaultTimingFunctionForKeyframes in the
case of a CSS Animation object.

• platform/animation/Animation.h:

(WebCore::Animation::defaultTimingFunctionForKeyframes const):
(WebCore::Animation::setDefaultTimingFunctionForKeyframes):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::animationHasStepsTimingFunction): Use the optional defaultTimingFunctionForKeyframes to determine
whether a keyframe uses a steps timing function.
(WebCore::GraphicsLayerCA::timingFunctionForAnimationValue): Use the optional defaultTimingFunctionForKeyframes
to determine the timing function for a keyframe.

LayoutTests:

Add a new test that checks that a CSS Animation with implicit and explicit animation-timing-function
values behave the same when running accelerated.

• webanimations/accelerated-css-animation-with-easing-expected.html: Added.
• webanimations/accelerated-css-animation-with-easing.html: Added.

10:01 AM Changeset in webkit [266240] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION(r264710): Initializing the AVPlayer Obj-C class at process start up causes a regression in power-use tests
​https://bugs.webkit.org/show_bug.cgi?id=215861

Reviewed by Eric Carlson.

Calling +instancesRespondToSelector: will cause the underyling Obj-C class to be initialized, which in the case of
AVPlayer does a bunch of work which shows up on power-use tests. Because the API being checked for will always exist
in macOS 11, and that code is already protected by a HAVE(AVPLAYER_VIDEORANGEOVERRIDE) pragma, just return early
here without running the +instancesRespondToSelector: check.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::updatePageScreenProperties):

9:55 AM Changeset in webkit [266239] by jer.noble@apple.com

• 3 edits
  3 adds in trunk

REGRESSION (r258215): Title preview movie isn't displayed at www.thismmalife.com
​https://bugs.webkit.org/show_bug.cgi?id=215774
<rdar://problem/67707957>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-as-img-output-pts.html

Use CMSampleBufferGetOutputPresentationTimeStamp() for sample PTS.

• platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::ImageDecoderAVFObjC::storeSampleBuffer):

LayoutTests:

• media/content/video-as-img.mp4: Added.
• media/video-as-img-output-pts-expected.txt: Added.
• media/video-as-img-output-pts.html: Added.

9:48 AM Changeset in webkit [266238] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Unreviewed, add missing double quote in r266216.

• WebProcess/com.apple.WebProcess.sb.in:

9:46 AM Changeset in webkit [266237] by Kate Cheney

• 3 edits in trunk/Source/WebKit

syntax error in "DELETE FROM StorageAccessUnderTopFrameDomains"
​https://bugs.webkit.org/show_bug.cgi?id=215813
<rdar://problem/67743521>

Reviewed by Darin Adler.

Delete unnecessary code. ResourceLoadStatisticsDatabaseStore::clearExpiredUserInteractions()
is not needed. User interaction and storage access will be cleared for
expired statistics in
ResourceLoadStatisticsDatabaseStore::hasHadUnexpiredRecentUserInteraction(),
which exactly matches behavior in the memory store. If we clear the
expired statistics before setting the local var oldestUserInteraction,
then that var will likely always be equal to zero, and the check for
if (!parameters().isRunningTest && now - oldestUserInteraction < parameters().minimumTimeBetweenDataRecordsRemoval)
will always be false.

The only reason we did not notice this extra code is because the
SQLite query in clearExpiredUserInteractions() was incorrect, causing
an early return. So the function never worked properly. Fixing the
query revealed incorrect behavior.

No new tests, behavior should not change because this code was not
being run due to the SQLite error.

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::registrableDomainsToDeleteOrRestrictWebsiteDataFor):
(WebKit::ResourceLoadStatisticsDatabaseStore::findExpiredUserInteractions const): Deleted.
(WebKit::ResourceLoadStatisticsDatabaseStore::clearExpiredUserInteractions): Deleted.
(WebKit::ResourceLoadStatisticsDatabaseStore::statisticsExpirationTime const): Deleted.

9:41 AM Changeset in webkit [266236] by keith_miller@apple.com

• 5 edits in trunk/Source/JavaScriptCore

JSClassRef should work with JS class syntax.
​https://bugs.webkit.org/show_bug.cgi?id=215047

Reviewed by Darin Adler.

This is done by checking if value returned by the
callAsConstructor parameter to JSObjectMakeConstructor returns an
object allocated as the jsClass parameter. When that happens we
replace the prototype of the returned object with the prototype of
the new.target. Ideally we would have passed the derived classes
constructor from the beginning of our support for JS subclassing
but at this point that's probably not compatible with too many
applications.

• API/APICallbackFunction.h:

(JSC::APICallbackFunction::construct):

• API/JSObjectRef.h:
• API/tests/testapi.cpp:

(APIString::APIString):
(TestAPI::markedJSValueArrayAndGC):
(TestAPI::classDefinitionWithJSSubclass):
(testCAPIViaCpp):

• API/tests/testapi.mm:

(testObjectiveCAPI):

9:37 AM Changeset in webkit [266235] by Simon Fraser

• 4 edits in trunk/Source/WebCore

Remove startedGestureAtScrollLimit which is always false.

8:54 AM Changeset in webkit [266234] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Unreviewed, address review comments for r266221 that I missed before landing.

• Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):

• platform/audio/AudioUtilities.cpp:

(WebCore::AudioUtilities::timeToSampleFrame):

8:50 AM Changeset in webkit [266233] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GLIB] Skip some tests causing the suite to hang up

Unreviewed test gardening.

These two tests were making the entire suite to hang after r266221.

• platform/glib/TestExpectations:

8:42 AM Changeset in webkit [266232] by Antti Koivisto

• 4 edits in trunk

Step animations invalidate style on every rendering update whether or not they need to
​https://bugs.webkit.org/show_bug.cgi?id=215229
<rdar://problem/66636153>

Reviewed by Antoine Quint.

Source/WebCore:

Step timing functions with transforms try and fail to start accelerated which causes them to repeatedly schedule unnecessary rendering updates.

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::updateAcceleratedActions):

Step timing functions are never accelerated so don't bother trying to start them in accelerated state.
This is similar to treatmeant of unaccelerated properties.

LayoutTests:

• animations/steps-transform-rendering-updates-expected.txt:

6:42 AM Changeset in webkit [266231] by Alan Bujtas

• 8 edits in trunk/Source/WebCore

[LFC][IFC] Move LineBox out of LineBuilder
​https://bugs.webkit.org/show_bug.cgi?id=215048

Reviewed by Antti Koivisto.

Since none of the LineBox related operations (content alignment, line sizing etc) is done during line building,
we don't really need to construct a LineBox until after we finished placing all the runs on the current line.
It enables us to decouple the LineBuilder and the LineBox.
Let the LineBuilder place the runs and compute horizontal geometry, while LineBox takes care of the final alignment of those runs.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::LineContentAligner::adjustBaselineAndLineHeight):
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
(WebCore::Layout::InlineFormattingContext::constraintsForLine):
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::initialLineHeight const):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::halfLeadingMetrics):

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::open):
(WebCore::Layout::LineBuilder::clearContent):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::removeTrailingTrimmableContent):
(WebCore::Layout::LineBuilder::visuallyCollapsePreWrapOverflowContent):
(WebCore::Layout::LineBuilder::moveLogicalLeft):
(WebCore::Layout::LineBuilder::appendWith):
(WebCore::Layout::LineBuilder::appendNonBreakableSpace):
(WebCore::Layout::LineBuilder::appendInlineContainerEnd):
(WebCore::Layout::LineBuilder::appendTextContent):
(WebCore::Layout::LineBuilder::appendNonReplacedInlineBox):
(WebCore::Layout::LineBuilder::isRunVisuallyNonEmpty const):
(WebCore::Layout::LineBuilder::initialize): Deleted.
(WebCore::Layout::LineBuilder::clear): Deleted.
(WebCore::Layout::LineBuilder::isVisuallyNonEmpty const): Deleted.
(WebCore::Layout::LineBuilder::halfLeadingMetrics): Deleted.

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::setHasIntrusiveFloat):
(WebCore::Layout::LineBuilder::hasIntrusiveFloat const):
(WebCore::Layout::LineBuilder::isVisuallyEmpty const):
(WebCore::Layout::LineBuilder::contentLogicalWidth const):
(WebCore::Layout::LineBuilder::contentLogicalRight const):
(WebCore::Layout::LineBuilder::lineBox const): Deleted.
(WebCore::Layout::LineBuilder::lineBox): Deleted.

• layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineLayoutContext::layoutInlineContent):
(WebCore::Layout::LineLayoutContext::commitFloats):
(WebCore::Layout::LineLayoutContext::rebuildLine):

3:44 AM Changeset in webkit [266230] by youenn@apple.com

• 89 edits
  27 deletes in trunk/LayoutTests

Remove console logs from expected.txt files for some WebSocket tests
​https://bugs.webkit.org/show_bug.cgi?id=215848

Reviewed by Alex Christensen.

Some WebSocket tests show platform specific console log messages.
By removing them, we can keep one expected.txt file for all platforms.

• http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt:
• http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html:
• http/tests/websocket/tests/hybi/bad-handshake-crash-expected.txt:
• http/tests/websocket/tests/hybi/bad-handshake-crash.html:
• http/tests/websocket/tests/hybi/broken-utf8-expected.txt:
• http/tests/websocket/tests/hybi/broken-utf8.html:
• http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
• http/tests/websocket/tests/hybi/close-code-and-reason.html:
• http/tests/websocket/tests/hybi/closed-port-delay-expected.txt:
• http/tests/websocket/tests/hybi/closed-port-delay.html:
• http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt:
• http/tests/websocket/tests/hybi/compressed-control-frame.html:
• http/tests/websocket/tests/hybi/contentextensions/upgrade-expected.txt:
• http/tests/websocket/tests/hybi/contentextensions/upgrade-worker-expected.txt:
• http/tests/websocket/tests/hybi/contentextensions/upgrade-worker.html:
• http/tests/websocket/tests/hybi/contentextensions/upgrade.html:
• http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html:
• http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt:
• http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html:
• http/tests/websocket/tests/hybi/deflate-frame-set-bfinal.html:
• http/tests/websocket/tests/hybi/error-event-ready-state-non-existent-url-with-server-responding-404-expected.txt:
• http/tests/websocket/tests/hybi/error-event-ready-state-non-existent-url-with-server-responding-404.html:
• http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt:
• http/tests/websocket/tests/hybi/fragmented-control-frame.html:
• http/tests/websocket/tests/hybi/handshake-error-expected.txt:
• http/tests/websocket/tests/hybi/handshake-error.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-invalid-http-version-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-invalid-http-version.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-maxlength-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-maxlength.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-more-protocol-header-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-more-protocol-header.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-no-cr-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-no-cr.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-accept-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-accept.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-extensions-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-extensions.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-protocol-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-protocol.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-status-line-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-status-line.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-null-char-in-status-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-null-char-in-status.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null.html:
• http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header-expected.txt:
• http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header.html:
• http/tests/websocket/tests/hybi/handshake-ok-with-http-version-beyond-1_1-expected.txt:
• http/tests/websocket/tests/hybi/handshake-ok-with-http-version-beyond-1_1.html:
• http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt:
• http/tests/websocket/tests/hybi/interleaved-fragments.html:
• http/tests/websocket/tests/hybi/invalid-continuation-expected.txt:
• http/tests/websocket/tests/hybi/invalid-continuation.html:
• http/tests/websocket/tests/hybi/invalid-encode-length-expected.txt:
• http/tests/websocket/tests/hybi/invalid-encode-length.html:
• http/tests/websocket/tests/hybi/invalid-masked-frames-from-server-expected.txt:
• http/tests/websocket/tests/hybi/invalid-masked-frames-from-server.html:
• http/tests/websocket/tests/hybi/invalid-subprotocol-characters-expected.txt:
• http/tests/websocket/tests/hybi/invalid-subprotocol-characters.html:
• http/tests/websocket/tests/hybi/long-control-frame-expected.txt:
• http/tests/websocket/tests/hybi/long-control-frame.html:
• http/tests/websocket/tests/hybi/long-invalid-header-expected.txt:
• http/tests/websocket/tests/hybi/long-invalid-header.html:
• http/tests/websocket/tests/hybi/network-process-crash-error-expected.txt:
• http/tests/websocket/tests/hybi/network-process-crash-error.html:
• http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
• http/tests/websocket/tests/hybi/reserved-bits.html:
• http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt:
• http/tests/websocket/tests/hybi/reserved-opcodes.html:
• http/tests/websocket/tests/hybi/too-long-payload-expected.txt:
• http/tests/websocket/tests/hybi/too-long-payload.html:
• http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:
• http/tests/websocket/tests/hybi/workers/close-code-and-reason.html:
• platform/glib/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/broken-utf8-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/closed-port-delay-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/error-event-ready-state-non-existent-url-with-server-responding-404-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-error-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-invalid-http-version-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-maxlength-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-more-protocol-header-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-no-cr-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-accept-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-extensions-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-protocol-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-status-line-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-null-char-in-status-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header-expected.txt: Removed.
• platform/glib/http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt: Removed.

3:21 AM Changeset in webkit [266229] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Animation are invalidating too much
​https://bugs.webkit.org/show_bug.cgi?id=215849

Reviewed by Antoine Quint.

• animation/KeyframeEffect.cpp:

(WebCore::invalidateElement):

Changes due to animations can't affect sibling elements so we can use internal invalidation.

3:00 AM Changeset in webkit [266228] by youenn@apple.com

• 57 edits
  5 adds in trunk

Add support for TransformStream
​https://bugs.webkit.org/show_bug.cgi?id=215607

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/streams/idlharness.any-expected.txt:
• web-platform-tests/streams/idlharness.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/backpressure.any-expected.txt:
• web-platform-tests/streams/transform-streams/backpressure.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/errors.any-expected.txt:
• web-platform-tests/streams/transform-streams/errors.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/flush.any-expected.txt:
• web-platform-tests/streams/transform-streams/flush.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/general.any-expected.txt:
• web-platform-tests/streams/transform-streams/general.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/lipfuzz.any-expected.txt:
• web-platform-tests/streams/transform-streams/lipfuzz.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/patched-global.any-expected.txt:
• web-platform-tests/streams/transform-streams/patched-global.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/properties.any-expected.txt:
• web-platform-tests/streams/transform-streams/properties.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/reentrant-strategies.any-expected.txt:
• web-platform-tests/streams/transform-streams/reentrant-strategies.any.js:
• web-platform-tests/streams/transform-streams/reentrant-strategies.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/strategies.any-expected.txt:
• web-platform-tests/streams/transform-streams/strategies.any.worker-expected.txt:
• web-platform-tests/streams/transform-streams/terminate.any-expected.txt:
• web-platform-tests/streams/transform-streams/terminate.any.worker-expected.txt:

Source/WebCore:

Add initial implementation as JS built-ins as per spec.
Covered by rebased tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Headers.cmake:
• Modules/streams/ReadableStreamInternals.js:

(readableStreamDefaultControllerShouldCallPull):
(readableStreamDefaultControllerCallPullIfNeeded):

• Modules/streams/TransformStream.idl: Added.
• Modules/streams/TransformStream.js: Added.

(initializeTransformStream):
(getter.readable):
(writable):

• Modules/streams/TransformStreamDefaultController.idl: Added.
• Modules/streams/TransformStreamDefaultController.js: Added.

(initializeTransformStreamDefaultController):
(getter.desiredSize):
(enqueue):
(error):
(terminate):

• Modules/streams/TransformStreamInternals.js: Added.

(isTransformStream):
(isTransformStreamDefaultController):
(initializeTransformStream):
(transformStreamError):
(transformStreamErrorWritableAndUnblockWrite):
(transformStreamSetBackpressure):
(setUpTransformStreamDefaultController):
(setUpTransformStreamDefaultControllerFromTransformer):
(transformStreamDefaultControllerClearAlgorithms):
(transformStreamDefaultControllerEnqueue):
(transformStreamDefaultControllerError):
(transformStreamDefaultControllerPerformTransform):
(transformStreamDefaultSinkWriteAlgorithm):
(transformStreamDefaultSinkAbortAlgorithm):
(transformStreamDefaultSinkCloseAlgorithm):
(transformStreamDefaultSourcePullAlgorithm):

• Modules/streams/WritableStream.js:

(initializeWritableStream):

• Modules/streams/WritableStreamInternals.js:

(createWritableStream):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setTransformStreamAPIEnabled):
(WebCore::RuntimeEnabledFeatures::transformStreamAPIEnabled const):

Source/WebKit:

Add a runtime flag for TransformStream, off by default.

• Shared/WebPreferences.yaml:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Source/WebKitLegacy/mac:

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences transformStreamAPIEnabled]):
(-[WebPreferences setTransformStreamAPIEnabled:]):

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setWritableStreamAPIEnabled):
(WTR::TestRunner::setTransformStreamAPIEnabled):

• WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

Rebased tests now that TransformStream is defined.

• streams/reference-implementation/pipe-through-expected.txt:
• streams/reference-implementation/pipe-to-expected.txt:
• streams/reference-implementation/transform-stream-errors-expected.txt:
• streams/reference-implementation/transform-stream-expected.txt:

2:56 AM Changeset in webkit [266227] by Carlos Garcia Campos

• 12 edits in trunk/Source

[GTK] Include the run loop source name in frame rendering timeline
​https://bugs.webkit.org/show_bug.cgi?id=215847

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Include the given name in rendering frame record data.

• inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createRenderingFrameData):

• inspector/TimelineRecordFactory.h:
• inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):

Source/WebInspectorUI:

Show the frame name if present in timeline panel.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype._processRecord):

• UserInterface/Models/RenderingFrameTimelineRecord.js:

(WI.RenderingFrameTimelineRecord):
(WI.RenderingFrameTimelineRecord.prototype.get name):

• UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView.displayNameForRecord):

Source/WTF:

Pass the run loop source name to the observer.

• wtf/RunLoop.h:
• wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::notify):

1:25 AM Changeset in webkit [266226] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Drop unnecessary BufferPlaybackMode enum from AudioBufferSourceNode
​https://bugs.webkit.org/show_bug.cgi?id=215878

Reviewed by Youenn Fablet.

Drop unnecessary BufferPlaybackMode enum from AudioBufferSourceNode, only
one of the enum values is ever used.

No new tests, no web-facing behavior change.

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::startLater):
(WebCore::AudioBufferSourceNode::startPlaying):

• Modules/webaudio/AudioBufferSourceNode.h:

Aug 26, 2020:

11:46 PM Changeset in webkit [266225] by BJ Burg

• 4 edits in trunk/Source

Web Inspector: button for Inspector^{2 doesn't work without setting default for DeveloperExtrasEnabled
​https://bugs.webkit.org/show_bug.cgi?id=215828}

Reviewed by Devin Rousso.

Source/WebCore:

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::inspectInspector):
Explicitly set DeveloperExtrasEnabled for the Inspector
web view so that the Inspect context menu appears and
so the [2] button works as expected.

Source/WebInspectorUI:

Drive-by: because the Inspector^{2 button is text-only and has no
.name element, the '2' button does not become dimmed when the
window is inactive, unlike every other item in the tab bar.
Fix this by coloring the text-only button similar to tab labels.}

• UserInterface/Debug/Bootstrap.css:

(body.window-inactive .tab-bar > .navigation-bar .item.button.text-only):
(.tab-bar > .navigation-bar .item.button.text-only):
(.tab-bar > .navigation-bar .item.button.text-only:not(.selected):hover):
(.tab-bar > .navigation-bar .item.button.text-only:not(.disabled).selected):
(body.window-inactive .tab-bar > .navigation-bar .item.button.text-only:not(.disabled).selected >):

10:43 PM Changeset in webkit [266224] by Jonathan Bedard

• 7 edits
  1 delete in trunk/Tools

[webkitcorepy] Move Timeout to webkitcorepy (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=215584
<rdar://problem/67270713>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/timeout.py:

(Timeout.enter): Forward patch flag to disable context.
(Timeout.exit): Ditto.

• Scripts/webkitpy/common/timeout_context.py: Replace with webkitcorepy's Timeout object.

(Timeout): Deleted.

• Scripts/webkitpy/common/timeout_context_unittest.py: Removed.
• Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess._start): Opt-out of patching time.sleep().

• Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDevice.launch_app): Opt-out of patching time.sleep().

• glib/api_test_runner.py:

(TestRunner._run_google_test): Use specific Timeout exception.

10:27 PM Changeset in webkit [266223] by Alexey Shvayka

• 8 edits in trunk/Source

Use jsTypeofIsObject() in DFG AI and operationTypeOfIsObject()
​https://bugs.webkit.org/show_bug.cgi?id=144457

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch refactors jsTypeofIsObject(), leveraging fast path of isCallable(),
moves it to the header, and utilizes it in operationTypeOfIsObject() & DFG AI
(minding concurrency) to eliminate code duplication.

Also, removes orphaned slow_path_is_object declaration.

No behavior change, typeof microbenchmarks are neutral.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGOperations.cpp:
• runtime/CommonSlowPaths.h:
• runtime/Operations.cpp:

(JSC::jsTypeofIsObject): Deleted.

• runtime/Operations.h:

(JSC::jsTypeofIsObjectWithConcurrency):
(JSC::jsTypeofIsObject):

Source/WTF:

• wtf/TriState.h:

(WTF::invert):

9:36 PM Changeset in webkit [266222] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

[LFC][IFC] LineBuilder should not align the runs
​https://bugs.webkit.org/show_bug.cgi?id=215016

Reviewed by Antti Koivisto.

This is in preparation for moving alignment logic over to the LineBox.
LineBuilder is responsible for adding content to the line, but the final alignment will be done by the LineBox.
This works well with preferred width computation, where we use the LineBuilder to compute line width but we
don't really need to construct a LineBox (and no alignment is needed).

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::HangingContent::width const):
(WebCore::Layout::HangingContent::isConditional const):
(WebCore::Layout::HangingContent::setIsConditional):
(WebCore::Layout::HangingContent::expand):
(WebCore::Layout::HangingContent::reset):
(WebCore::Layout::LineContentAligner::formattingContext const):
(WebCore::Layout::LineContentAligner::layoutState const):
(WebCore::Layout::LineContentAligner::LineContentAligner):
(WebCore::Layout::LineContentAligner::alignHorizontally):
(WebCore::Layout::LineContentAligner::alignVertically):
(WebCore::Layout::LineContentAligner::justifyRuns):
(WebCore::Layout::LineContentAligner::adjustBaselineAndLineHeight):
(WebCore::Layout::LineContentAligner::collectHangingContent const):
(WebCore::Layout::LineContentAligner::runContentHeight const):
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::LineBuilder):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::removeTrailingTrimmableContent):
(WebCore::Layout::LineBuilder::isVisuallyNonEmpty const):
(WebCore::Layout::HangingContent::width const): Deleted.
(WebCore::Layout::HangingContent::isConditional const): Deleted.
(WebCore::Layout::HangingContent::setIsConditional): Deleted.
(WebCore::Layout::HangingContent::expand): Deleted.
(): Deleted.
(WebCore::Layout::HangingContent::reset): Deleted.
(WebCore::Layout::LineContentAligner::formattingContext const): Deleted.
(WebCore::Layout::LineContentAligner::layoutState const): Deleted.
(WebCore::Layout::LineContentAligner::LineContentAligner): Deleted.
(WebCore::Layout::LineContentAligner::alignHorizontally): Deleted.
(WebCore::Layout::LineContentAligner::alignVertically): Deleted.
(WebCore::Layout::LineContentAligner::justifyRuns): Deleted.
(WebCore::Layout::LineContentAligner::adjustBaselineAndLineHeight): Deleted.
(WebCore::Layout::LineContentAligner::collectHangingContent const): Deleted.
(WebCore::Layout::LineContentAligner::runContentHeight const): Deleted.

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::lineBox):
(WebCore::Layout::LineBuilder::runs):

• layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineLayoutContext::close):

• layout/inlineformatting/LineLayoutContext.h:

9:28 PM Changeset in webkit [266221] by Chris Dumez

• 19 edits in trunk

Add support for sub-sample accurate start for AudioBufferSourceNode
​https://bugs.webkit.org/show_bug.cgi?id=215868

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-playbackrate-zero-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-scheduling-expected.txt:

Source/WebCore:

Implement sub-sample accurate start for AudioBufferSourceNode.
Previously, if the start time was between sample boundaries, we would
start the output at the frame before the start time. This is actually
incorrect because we haven't actually started yet. We should start
the output at the next boundary, and interpolating the value based on
the true start time and the sample boundary.

This is based on the following Chromium changes:

• ​https://chromium-review.googlesource.com/c/chromium/src/+/1212270
• ​https://chromium-review.googlesource.com/c/chromium/src/+/1446869

No new tests, rebaselined existing test.

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::renderFromBuffer):

• Modules/webaudio/AudioBufferSourceNode.h:
• Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):

• Modules/webaudio/AudioScheduledSourceNode.h:
• Modules/webaudio/ConstantSourceNode.cpp:

(WebCore::ConstantSourceNode::process):

• Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::process):

• platform/audio/AudioUtilities.cpp:

(WebCore::AudioUtilities::timeToSampleFrame):

• platform/audio/AudioUtilities.h:

LayoutTests:

Update existing layout tests to reflect behavior change.

• platform/mac/webaudio/audiobuffersource-playbackrate-expected.wav:
• webaudio/gain-expected.wav:
• webaudio/resources/distance-model-testing.js:
• webaudio/resources/panner-model-testing.js:

8:57 PM Changeset in webkit [266220] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GLIB] Gardening some accessibility debug crashes

Unreviewed test gardening.

• platform/glib/TestExpectations:

8:43 PM Changeset in webkit [266219] by Chris Dumez

• 4 edits in trunk

Update DynamicsCompressorNode::process() to use AudioParam::finalValue()
​https://bugs.webkit.org/show_bug.cgi?id=215874

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:

Source/WebCore:

Update DynamicsCompressorNode::process() to use AudioParam::finalValue(). All of DynamicsCompressorNode
use k-rate (in fixed mode) so we should be using AudioParam::finalValue() unconditionally.

No new tests, rebaselined existing test.

• Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::process):

8:35 PM Changeset in webkit [266218] by Devin Rousso

• 3 edits in trunk/Source/WebCore

REGRESSION: touchbar controls don't reflect video state in fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=215873
<rdar://problem/66723354>

Reviewed by Eric Carlson.

• platform/mac/WebPlaybackControlsManager.h:
• platform/mac/WebPlaybackControlsManager.mm:

(-[WebPlaybackControlsManager setPlaying:]):
(-[WebPlaybackControlsManager isPlaying]):
Create an actual ivar _playing for holding the play/pause state. This is needed because
AVTouchBarScrubber uses KVO to update the state of the play/pause button whenever the
related video controller (in this case AVTouchBarPlaybackControlsControlling) changes
using an NSValueBinding. KVO needs an actual ivar in order to function properly.

8:21 PM Changeset in webkit [266217] by Ryan Haddad

• 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, reverting r266200.

Broke test for macOS

Reverted changeset:

"Unreviewed, rebaseline constant css-cascade test failure"
​https://trac.webkit.org/changeset/266200

6:58 PM Changeset in webkit [266216] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[macOS] Stop logging sandbox violations of com.apple.CoreDisplay.Notification
​https://bugs.webkit.org/show_bug.cgi?id=215869

Reviewed by Darin Adler.

On macOS, stop logging mach-lookup sandbox violations of com.apple.CoreDisplay.Notification for performance reasons.

No new tests, since there is no change in behavior. The service was already being denied in the sandbox.

• WebProcess/com.apple.WebProcess.sb.in:

6:55 PM Changeset in webkit [266215] by Alexey Shvayka

• 3 edits
  2 adds in trunk

Merge putLength() into setLength()
​https://bugs.webkit.org/show_bug.cgi?id=211279

Reviewed by Darin Adler and Saam Barati.

JSTests:

• microbenchmarks/array-shift-unshift-empty.js: Added.
• stress/array-setLength-on-proxy-error.js: Added.

Source/JavaScriptCore:

This patch:

1. Replaces all putLength() call sites with setLength(), saving two JSValue instantiations in arrayProtoFuncPop() and two in arrayProtoFuncShift().

2. Merges putLength() into setLength(), removing superfluous put() call for JSArray. Also, performs put() in strict mode to preserve the original error messages, like ones in ProxyObject::performPut().

3. Inlines performPop(), which avoided an extra index check and Identifier creation, as it was on the slow path anyway (note JSArray::pop() call).

This change advances provided setLength()-heavy microbenchmark by ~40%,
while existing Array tests are neutral.

• runtime/ArrayPrototype.cpp:

(JSC::setLength):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncUnShift):
(JSC::putLength): Deleted.

6:52 PM Changeset in webkit [266214] by Kate Cheney

• 19 edits in trunk/Source

Resource Load Statistics data summary does not report data which is held up in the web content process.
​https://bugs.webkit.org/show_bug.cgi?id=215822
<rdar://problem/66682044>

Reviewed by Chris Dumez.

Source/WebCore:

Send empty lambda when calling updateCentralStatisticsStore() because
in these cases we don't care about timing.

• loader/ResourceLoadObserver.h:

(WebCore::ResourceLoadObserver::updateCentralStatisticsStore):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::close):

• testing/Internals.cpp:

(WebCore::Internals::notifyResourceLoadObserver):

Source/WebKit:

No new tests, this fixes a timing bug that is flaky to reproduce, so I
was unable to write a test case. Non-regressed behavior is confirmed
with existing API testing.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):
Most of the time, the completion handler will be an empty function,
but we should handle it in the network process so we fix the
case where we wait to send the full data summary until the update has
finished.

(WebKit::WebResourceLoadStatisticsStore::aggregatedThirdPartyData):
Delete extra space.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::resourceLoadStatisticsUpdated):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::sendResourceLoadStatisticsDataImmediately):

• UIProcess/WebProcessPool.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::getResourceLoadStatisticsDataSummary):
Don't ask the network process for data until any lingering data
in the web content process has been sent first.

• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleResourceLoadStatisticsNotifyObserver):

• WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:

(WebKit::WebResourceLoadObserver::WebResourceLoadObserver):
(WebKit::WebResourceLoadObserver::~WebResourceLoadObserver):
(WebKit::WebResourceLoadObserver::updateCentralStatisticsStore):

• WebProcess/WebCoreSupport/WebResourceLoadObserver.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::flushResourceLoadStatistics):
(WebKit::WebProcess::sendResourceLoadStatisticsDataImmediately):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

6:47 PM Changeset in webkit [266213] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Make isIndex use MAX_ARRAY_INDEX
​https://bugs.webkit.org/show_bug.cgi?id=215872

Reviewed by Darin Adler.

It's already written in such a way where it relies on what MAX_ARRAY_INDEX
is defined as. But instead of MAX_ARRAY_INDEX, the function was hardcoding
MAX_ARRAY_INDEX + 1.

• runtime/Identifier.h:

(JSC::isIndex):

6:26 PM Changeset in webkit [266212] by rniwa@webkit.org

• 12 edits in trunk/Source/WebCore

Make it possible to create a WeakPtr to Node and use it store assigned nodes in SlotAssignment
​https://bugs.webkit.org/show_bug.cgi?id=215673
<rdar://problem/67440818>

Reviewed by Darin Adler.

This patch makes Node inherit from CanMakeWeakPtr<Node> and uses it in SlotAssignment's assignedNodes
and related member variables and functions.

No new tests since there should be no behavioral difference.

• dom/ComposedTreeIterator.cpp:

(WebCore::ComposedTreeIterator::traverseNextInShadowTree):
(WebCore::ComposedTreeIterator::advanceInSlot):

• dom/ComposedTreeIterator.h:

(WebCore::firstChildInComposedTreeIgnoringUserAgentShadow):
(WebCore::nextSiblingInComposedTreeIgnoringUserAgentShadow):

• dom/ContainerNode.h:
• dom/Node.h:
• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::assignedNodesForSlot):

• dom/ShadowRoot.h:
• dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::assignedNodesForSlot):
(WebCore::SlotAssignment::assignToSlot):

• dom/SlotAssignment.h:
• html/HTMLSlotElement.cpp:

(WebCore::HTMLSlotElement::assignedNodes const):
(WebCore::flattenAssignedNodes):
(WebCore:: const): Deleted.

• html/HTMLSlotElement.h:
• page/FocusController.cpp:

(WebCore::FocusNavigationScope::firstNodeInScope const):
(WebCore::FocusNavigationScope::lastNodeInScope const):

6:02 PM Changeset in webkit [266211] by Hector Lopez

• 2 edits in trunk/LayoutTests

REGRESSION: ASSERT NOT REACHED: WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree
​https://bugs.webkit.org/show_bug.cgi?id=215875

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

6:00 PM Changeset in webkit [266210] by Alexey Shvayka

• 7 edits in trunk/Source/JavaScriptCore

Use unsigned type for length of JSFunction
​https://bugs.webkit.org/show_bug.cgi?id=215870

Reviewed by Darin Adler.

Since the length value of a built-in function is its arity,
we can communicate it's always non-negative via method signatures.

No behavior change: length values redefined by user code are unaffected.

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::createFunctionThatMasqueradesAsUndefined):

• runtime/InternalFunction.h:
• runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC::JSFunction::finishCreation):

• runtime/JSFunction.h:
• runtime/JSNativeStdFunction.cpp:

(JSC::JSNativeStdFunction::finishCreation):
(JSC::JSNativeStdFunction::create):

• runtime/JSNativeStdFunction.h:

5:43 PM Changeset in webkit [266209] by Russell Epstein

• 8 edits in branches/safari-610-branch/Source

Versioning.

WebKit-7610.2.3

5:10 PM Changeset in webkit [266208] by clopez@igalia.com

• 6 edits in trunk/Tools

[GTK][WPE] Add bots for generating nightly bundle packages
​https://bugs.webkit.org/show_bug.cgi?id=215623

Reviewed by Aakash Jain.

This adds a new type of bots for GTK and WPE that runs nightly (once per day).
The goal of this bots its to build WebKit for a specific distribution (Ubuntu LTS and LTS-1)
and generate a bundle with the result of the build. The bundles are then uploaded to a
server for consumption on other CIs like WPT.

The MiniBrowser bundle targets a specific distribution, so each one of this new bots has to
run the generate-minibrowser-bundle step. However, the JSC bundle is distro-agnostic because
for JSC is possible to bundle all the system libraries (similar to a static build).
That means that we only need to run the step generate-jsc-bundle in one of the bots.
This step for generating the JSC bundle was previously executed in the bot
'GTK Linux 64-bit Release (Build)'. This patch moves it to one of this new added bots.

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/factories.py:

(BuildFactory):
(BuildFactory.init):
(TestFactory):
(TestFactory.init):
(BuildAndGenerateMiniBrowserBundleFactory):
(BuildAndGenerateMiniBrowserJSCBundleFactory):

• BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
• BuildSlaveSupport/build.webkit.org-config/steps.py:

(GenerateJSCBundle):
(GenerateMiniBrowserBundle):

• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

5:08 PM Changeset in webkit [266207] by Andres Gonzalez

• 8 edits in trunk

Buttons with aria-haspopup attribute are not exposed to accessibility clients as form controls.
​https://bugs.webkit.org/show_bug.cgi?id=215866

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/mac/search-predicate-element-count.html.

Buttons with aria-haspopup were not included in the search results for
client queries for form controls. Added buttons with aria-haspopup which
have role PopUpButton, to the list of roles returned as form controls.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isARIAInput): Re-wrote using a switch statement for clarity and maintainability.
(WebCore::AccessibilityObject::isARIAControl): Ditto.

• accessibility/AccessibilityObject.h:

Source/WebKit:

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick): isARIAControl false implies

isARIAInput false, thus removed the

isARIAInput call.

LayoutTests:

Expanded this test to include the case of buttons with aria-haspopup and
several other elements with ARIA roles that need to be retrieved when
clients search for input fields or form controls.

• accessibility/mac/search-predicate-element-count-expected.txt:
• accessibility/mac/search-predicate-element-count.html:

5:06 PM Changeset in webkit [266206] by commit-queue@webkit.org

• 7 edits
  4 adds in trunk

Leading white spaces should be ignored when parsing an SVG list property
​https://bugs.webkit.org/show_bug.cgi?id=215602

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-08-26
Reviewed by Sam Weinig.

Source/WebCore:

The SVG2.0 specs state that the CSS value definition syntax must be used
to define the syntax of the SVG attributes. The CSS syntax states that
leading and trailing spaces should be ignored when parsing the primitive
data types of all the SVG lists.

This has been inconsistency between WebKit and other browsers and within
WebKit itself. Parsing the attribute string of an SVGTransformList skips
the leading white spaces while the rest of the lists do not do that.

All the parsing methods should skip the leading white spaces before looping
to parse individual items. The last step of the loop is to skip the trailing
spaces and the delimiter which we do already.

Tests: svg/custom/feColorMatrix-values-leading-spaces.html

svg/dom/svg-list-properties-parser-leading-trailing-spaces.html

• svg/SVGLengthList.cpp:

(WebCore::SVGLengthList::parse):

• svg/SVGNumberList.cpp:

(WebCore::SVGNumberList::parse):

• svg/SVGStringList.cpp:

(WebCore::SVGStringList::parse):

• svg/SVGTransformList.cpp:

(WebCore::SVGTransformList::parseGeneric):

LayoutTests:

• svg/custom/feColorMatrix-values-leading-spaces-expected.html: Added.
• svg/custom/feColorMatrix-values-leading-spaces.html: Added.
• svg/dom/length-list-parser-expected.txt:
• svg/dom/svg-list-properties-parser-leading-trailing-spaces-expected.txt: Added.
• svg/dom/svg-list-properties-parser-leading-trailing-spaces.html: Added.

4:58 PM Changeset in webkit [266205] by Alan Coon

• 1 copy in tags/Safari-610.2.2.3

Tag Safari-610.2.2.3.

4:38 PM Changeset in webkit [266204] by Alan Coon

• 54 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266168. rdar://problem/67836301

REGRESSION (r265908): Crash under Blob::arrayBuffer() / Blob::text() in stress GC
​https://bugs.webkit.org/show_bug.cgi?id=215832
<rdar://problem/67741677>

Reviewed by Ryosuke Niwa.

Source/WebCore:

r265908 added support for Blob::arrayBuffer() / Blob::text() which are asynchronous operations
returning promises. The crash is due to the fact that the Blob's JS wrapper may get garbage
collected before the promise is settled.

To address the issue, this patch makes Blob an ActiveDOMObject and creates an
ActiveDOMObject::pendingActivity whenever there is a pending promise so that the JS wrapper
does not get garbage collected too early.

Test: fast/files/blob-text-gc.html

• Modules/async-clipboard/Clipboard.cpp: (WebCore::Clipboard::getType):
• Modules/async-clipboard/ClipboardImageReader.h: (WebCore::ClipboardImageReader::ClipboardImageReader):
• Modules/async-clipboard/ClipboardItem.cpp: (WebCore::ClipboardItem::blobFromString):
• Modules/async-clipboard/ClipboardItem.h:
• Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp: (WebCore::ClipboardItemBindingsDataSource::getType):
• Modules/async-clipboard/ios/ClipboardImageReaderIOS.mm: (WebCore::ClipboardImageReader::readBuffer):
• Modules/async-clipboard/mac/ClipboardImageReaderMac.mm: (WebCore::ClipboardImageReader::readBuffer):
• Modules/entriesapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::getFile):
• Modules/entriesapi/DOMFileSystem.h:
• Modules/entriesapi/FileSystemFileEntry.cpp: (WebCore::FileSystemFileEntry::file):
• Modules/entriesapi/FileSystemFileEntry.h:
• Modules/entriesapi/FileSystemFileEntry.idl:
• Modules/fetch/FetchBody.cpp: (WebCore::FetchBody::fromFormData):
• Modules/fetch/FetchBody.h:
• Modules/fetch/FetchBodyConsumer.cpp: (WebCore::blobFromData): (WebCore::packageFormData): (WebCore::resolveWithTypeAndData): (WebCore::FetchBodyConsumer::resolve): (WebCore::FetchBodyConsumer::takeAsBlob):
• Modules/fetch/FetchBodyConsumer.h:
• Modules/fetch/FetchBodyOwner.cpp: (WebCore::FetchBodyOwner::blob):
• Modules/mediarecorder/MediaRecorder.cpp: (WebCore::MediaRecorder::stopRecording): (WebCore::MediaRecorder::requestData):
• Modules/mediastream/RTCDataChannel.cpp: (WebCore::RTCDataChannel::didReceiveRawData):
• Modules/websockets/WebSocket.cpp: (WebCore::WebSocket::didReceiveBinaryData):
• Modules/websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
• bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal):
• dom/DataTransfer.cpp: (WebCore::DataTransfer::updateFileList): (WebCore::DataTransfer::items): (WebCore::DataTransfer::filesFromPasteboardAndItemList const): (WebCore::DataTransfer::files const):
• dom/DataTransfer.h:
• dom/DataTransfer.idl:
• dom/DataTransferItemList.cpp: (WebCore::DataTransferItemList::DataTransferItemList): (WebCore::DataTransferItemList::remove): (WebCore::DataTransferItemList::clear): (WebCore::DataTransferItemList::ensureItems const): (WebCore::DataTransferItemList::document const):
• dom/DataTransferItemList.h:
• dom/DataTransferItemList.idl:
• editing/WebCorePasteboardFileReader.cpp: (WebCore::WebCorePasteboardFileReader::readFilename): (WebCore::WebCorePasteboardFileReader::readBuffer):
• editing/WebCorePasteboardFileReader.h:
• editing/cocoa/WebContentReaderCocoa.mm: (WebCore::createFragmentForImageAttachment): (WebCore::replaceRichContentWithAttachments): (WebCore::createFragmentAndAddResources): (WebCore::sanitizeMarkupWithArchive): (WebCore::WebContentReader::readImage): (WebCore::attachmentForFilePath): (WebCore::attachmentForData):
• editing/markup.cpp: (WebCore::restoreAttachmentElementsInFragment):
• fileapi/Blob.cpp: (WebCore::Blob::Blob): (WebCore::Blob::loadBlob): (WebCore::Blob::activeDOMObjectName const):
• fileapi/Blob.h: (WebCore::Blob::create): (WebCore::Blob::deserialize): (WebCore::Blob::slice const):
• fileapi/Blob.idl:
• fileapi/File.cpp: (WebCore::File::createWithRelativePath): (WebCore::File::create): (WebCore::File::File): (WebCore::File::activeDOMObjectName const):
• fileapi/File.h:
• fileapi/File.idl:
• html/DOMFormData.cpp: (WebCore::DOMFormData::createFileEntry):
• html/DirectoryFileListCreator.cpp: (WebCore::FileInformation::isolatedCopy const): (WebCore::appendDirectoryFiles): (WebCore::gatherFileInformation): (WebCore::toFileList): (WebCore::DirectoryFileListCreator::start):
• html/DirectoryFileListCreator.h:
• html/FileInputType.cpp: (WebCore::FileInputType::appendFormData const): (WebCore::FileInputType::filesChosen):
• html/HTMLAttachmentElement.cpp: (WebCore::HTMLAttachmentElement::updateEnclosingImageWithData):
• html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toBlob):
• testing/Internals.cpp: (WebCore::Internals::createFile):
• testing/ServiceWorkerInternals.cpp: (WebCore::ServiceWorkerInternals::createOpaqueWithBlobBodyResponse):
• workers/service/context/ServiceWorkerFetch.cpp: (WebCore::ServiceWorkerFetch::dispatchFetchEvent):
• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createResponseBlob):

Source/WebKit:

• WebProcess/Automation/WebAutomationSessionProxy.cpp: (WebKit::WebAutomationSessionProxy::setFilesForInputFileUpload):

LayoutTests:

Add better test coverage.

• fast/files/blob-text-gc-expected.txt: Added.
• fast/files/blob-text-gc.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:38 PM Changeset in webkit [266203] by Alan Coon

• 34 edits in branches/safari-610-branch

Cherry-pick r266087. rdar://problem/67836301

Implement Request/Response consuming as FormData
​https://bugs.webkit.org/show_bug.cgi?id=215671

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-24
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/abort/general.any-expected.txt:
• web-platform-tests/fetch/api/abort/general.any.worker-expected.txt:
• web-platform-tests/fetch/api/request/request-consume-empty-expected.txt: This remaining failing test now fails similarly in all browsers.
• web-platform-tests/fetch/api/request/request-consume-expected.txt:
• web-platform-tests/fetch/api/request/request-init-002-expected.txt:
• web-platform-tests/fetch/api/response/response-consume-empty-expected.txt: This remaining failing test now fails similarly in all browsers.
• web-platform-tests/fetch/api/response/response-consume-expected.txt:
• web-platform-tests/fetch/api/response/response-error-from-stream-expected.txt: This change makes the formData failures in this file look like all the other failures in this file, which should be fixed together in a separate patch.
• web-platform-tests/fetch/api/response/response-init-002-expected.txt:
• web-platform-tests/url/urlencoded-parser.any-expected.txt:
• web-platform-tests/url/urlencoded-parser.any.worker-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https-expected.txt:

Source/WebCore:

Covered by many newly passing WPT tests, for most of which Safari was the only failing browser.

• Modules/fetch/FetchBody.cpp: (WebCore::FetchBody::formData): (WebCore::FetchBody::consume): (WebCore::FetchBody::consumeFormData):
• Modules/fetch/FetchBody.h:
• Modules/fetch/FetchBodyConsumer.cpp: (WebCore::formDataFromData): (WebCore::resolveWithTypeAndData): (WebCore::FetchBodyConsumer::resolve):
• Modules/fetch/FetchBodyConsumer.h:

Source/WebKit:

• WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: (WebKit::WebServiceWorkerFetchTaskClient::didReceiveFormDataAndFinish): Add a fast path that allows non-blob FormData responses from service workers to not hang. This part is covered by this layout test: imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https.html

Source/WTF:

In order to be compatible with other browsers, we need a verson of String::fromUTF8 that
uses U8_NEXT_OR_FFFD instead of U8_NEXT, but changing that across the board will break other things.
Leave everything else as it is, use templates and constexpr to not add any branches, but add
String::fromUTF8ReplacingInvalidSequences to allow me to make our FormData consuming compatible with other browsers.

• wtf/text/WTFString.cpp: (WTF::fromUTF8Helper): (WTF::String::fromUTF8): (WTF::String::fromUTF8ReplacingInvalidSequences):
• wtf/text/WTFString.h:
• wtf/unicode/UTF8Conversion.cpp: (WTF::Unicode::convertUTF8ToUTF16Impl): (WTF::Unicode::convertUTF8ToUTF16): (WTF::Unicode::convertUTF8ToUTF16ReplacingInvalidSequences):
• wtf/unicode/UTF8Conversion.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:38 PM Changeset in webkit [266202] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266176. rdar://problem/67836292

[Mac,EME] Netflix.com shows HDCP error for all streams
​https://bugs.webkit.org/show_bug.cgi?id=215825

Reviewed by Eric Carlson.

New API added to AVContentKeySession hits a sandbox restriction when run in the WebContent process, and the default
behavior when an error checking HDCP status is to report that the output is restricted, regardless of the displays
actual capabilities. To work around this behavior for now, pass in an empty displayID array, rather than the actual
displayID. This causes AVFoundation to do a "lowest common level of support" rather than a specific display check.
The upside is that this call no longer requires a connection to the WindowServer. The downside is that the
AVContentKeyRequest will report that its output is restricted if any non-HDCP compliant display is attached.

• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyStatuses const): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyRequestHasInsufficientProtectionForDisplayID const): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateProtectionStatusForDisplayID):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:21 PM Changeset in webkit [266201] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://67706887 (REGRESSION (r264950): [ iOS 13 WK2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure)
Rebaseline test, remove test expectation.

Unreviewed test gardening.

• platform/ios-13/TestExpectations:

4:12 PM Changeset in webkit [266200] by Karl Rackler

• 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline constant css-cascade test failure

• web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:

3:39 PM Changeset in webkit [266199] by Alan Coon

• 8 edits in branches/safari-610.2.2-branch/Source

Versioning.

WebKit-7610.2.2.3

3:34 PM Changeset in webkit [266198] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Avoid unnecessarily copying a Vector in WebCore::transformsForValue
​https://bugs.webkit.org/show_bug.cgi?id=215858

Reviewed by Tim Horton.

Avoid copying the Vector of TransformOperations in this helper function by directly appending newly created
transform operations to the given TransformOperations. This does, however, mean that we need to clear these
items in the case where conversion fails and we return false.

• css/TransformFunctions.cpp:

(WebCore::transformsForValue):

3:27 PM Changeset in webkit [266197] by Alan Coon

• 1 copy in tags/Safari-610.1.28.0.4

Tag Safari-610.1.28.0.4.

3:15 PM Changeset in webkit [266196] by Lauro Moura

• 3 edits
  2 copies
  1 add
  2 deletes in trunk/LayoutTests

[WPE][GTK] Gardening and rebaseline

Unreviewed test gardening.

Moving some GTK-specific baselines to GLIB and removing some uneeded
baselines (failure should be expected)

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Copied from LayoutTests/platform/glib/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt.
• platform/gtk/streams/pipe-to-expected.txt: Removed.
• platform/wpe/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Renamed from LayoutTests/platform/glib/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt.

3:14 PM Changeset in webkit [266195] by Alan Coon

• 1 copy in tags/Safari-610.2.2.2

Tag Safari-610.2.2.2.

3:03 PM Changeset in webkit [266194] by Aditya Keerthi

• 4 edits
  2 adds in trunk

[iOS] Disabled options in the multi-select picker should not be selectable
​https://bugs.webkit.org/show_bug.cgi?id=201458
<rdar://problem/55018179>

Reviewed by Wenson Hsieh.

Source/WebKit:

WKMultipleSelectPicker is displayed when a <select multiple> or a
<select> with an <optgroup> is activated. Due to <rdar://problem/18745253>,
group rows and disabled rows were selectable in the picker. r175266 added a
workaround for this issue, preventing group rows from being selectable.
However, the workaround did not account for disabled rows, which means that
it is possible to select disabled options in the multi-select picker.

To fix this behavior, the same fix that was applied to group rows is now
applied to disabled rows. pickerView:row:column:checked: resets the style
for the associated view if item.disabled is true.

Test: fast/forms/ios/disabled-options-in-multi-select-picker.html

• UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKMultipleSelectPicker pickerView:row:column:checked:]):

LayoutTests:

Added a test to verify that disabled options cannot be selected when the
multi-select picker is presented.

• fast/forms/ios/disabled-options-in-multi-select-picker-expected.txt: Added.
• fast/forms/ios/disabled-options-in-multi-select-picker.html: Added.
• platform/ipad/TestExpectations:

2:32 PM Changeset in webkit [266193] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r266074): cannot edit JavaScript breakpoints
​https://bugs.webkit.org/show_bug.cgi?id=215860

Reviewed by Brian Burg.

• UserInterface/Models/JavaScriptBreakpoint.js:

(WI.JavaScriptBreakpoint.prototype.get editable):

2:05 PM Changeset in webkit [266192] by Chris Dumez

• 10 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline flaky webaudio WPT tests.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

2:04 PM Changeset in webkit [266191] by Hector Lopez

• 2 edits in trunk/LayoutTests

rdar://67706887 (REGRESSION (r264950): [ iOS 13 WK2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure)

Unreviewed test gardening.

• platform/ios-13/TestExpectations:

2:01 PM Changeset in webkit [266190] by Jonathan Bedard

• 4 edits
  3 adds in trunk/Tools

[webkitcorepy] Standard Popen mocking API

​https://bugs.webkit.org/show_bug.cgi?id=215712
<rdar://problem/67501911>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitcorepy/README.md: Add mocks.Subprocess documentation.
• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/mocks/init.py: Export Subprocess, ProcessCompletion.
• Scripts/libraries/webkitcorepy/webkitcorepy/mocks/popen.py: Added.

(Popen): Mock Popen object (for both Python 2 and 3). This object extracts a ProcessCompletion object from the
mocked Subprocess stack and behaives according to the content of that object.

• Scripts/libraries/webkitcorepy/webkitcorepy/mocks/subprocess.py: Added.

(PopenBase): Base class to share code between Python 2 and 3 constructor.
(Popen): Mock Popen object (for both Python 2 and 3). This object extracts a ProcessCompletion object from the
mocked Subprocess stack and behaives according to the content of that object.

• Scripts/libraries/webkitcorepy/webkitcorepy/mocks/subprocess.py: Added.

(ProcessCompletion): Class which captures the result of a mock Popen call.
(Subprocess):
(Subprocess.CommandRoute): Object which routes a set of subprocess arguments to a specific ProcessCompletion or callback which
generates a ProcessCompletion.
(Subprocess.completion_generator_for): Given a file, search through the mocked Subprocess stack to find the
first completion for the provided file.
(Subprocess.completion_for): Extract file name from arguments, find the completion generator, and call
it with the provieded arguments, working directory and stdin.
(Subprocess.init):

• Scripts/libraries/webkitcorepy/webkitcorepy/tests/mocks/subprocess_unittest.py: Added.

(MockSubprocess):
(MockCheckOutput):
(MockCheckCall):
(MockRun):

1:42 PM Changeset in webkit [266189] by dino@apple.com

• 3 edits
  2 adds in trunk

Flickering on sedona.dev
​https://bugs.webkit.org/show_bug.cgi?id=215141

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/canvas/webgl/compositing-without-drawing.html

Our logic to determine if a canvas needs to be "repainted"
was over-zealous for WebGL. We were marking any context
that called draw commands as dirty, but they could in fact
be rendering to an offscreen texture/framebuffer. Then, when
it came time to composite, we'd happily swap buffers and
show something that had never been rendered to.

The fix is simply to ignore any of the dirtying notifications
when we are not bound to the default (canvas) framebuffer.

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver): Only
mark if we're rendering to the default framebuffer.

LayoutTests:

Test that serves an animation frame that touches
WebGL, but not in a way that requires a recomposite.

• fast/canvas/webgl/compositing-without-drawing-expected.html: Added.
• fast/canvas/webgl/compositing-without-drawing.html: Added.

1:32 PM Changeset in webkit [266188] by Alan Coon

• 1 copy in tags/Safari-610.1.28.1.4

Tag Safari-610.1.28.1.4.

1:18 PM Changeset in webkit [266187] by commit-queue@webkit.org

• 19 edits in trunk

Implement DataTransfer constructor and multipart form filename encoding as other browsers do
​https://bugs.webkit.org/show_bug.cgi?id=215837

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-26
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/FileAPI/file/send-file-form-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-iso-2022-jp.tentative-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-utf-8-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-windows-1252.tentative-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-x-user-defined.tentative-expected.txt:
• web-platform-tests/html/editing/dnd/datastore/datatransfer-constructor-001-expected.txt:
• web-platform-tests/html/editing/dnd/datastore/datatransfer-types-expected.txt:

This test still fails because of bindings issues. DataTransfer.types should apparently return
a cached JSValue that is updated whenever the contents change, which I don't think our bindings
generator can handle right now, so these tests are now failing in a different way.
I think that's fine because I think most uses of DataTransfer.types will just be checking the contents,
not whether its === to a stored reference like these tests do. We should fix this later.

• web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub-expected.txt:
• web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub.html:

Updated to successfully submit the form to a listening server in our test infrastructure,
so that we see PASS like we do now on wpt.live

• web-platform-tests/service-workers/service-worker/data-transfer-files.https-expected.txt:

Source/WebCore:

Covered by newly passing WPT tests that Chrome and Firefox both pass.

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::create):

• dom/DataTransfer.h:
• dom/DataTransfer.idl:
• platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::addFilenameToMultiPartHeader):

LayoutTests:

• fast/dom/dom-constructors-expected.txt:
• fast/dom/dom-constructors.html:

1:09 PM Changeset in webkit [266186] by Chris Dumez

• 22 edits
  11 adds in trunk

IIRFilterNode interface is not supported
​https://bugs.webkit.org/show_bug.cgi?id=215810

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

• web-platform-tests/webaudio/idlharness.https.window-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-basic-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-getFrequencyResponse-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/test-iirfilternode-expected.txt:

Source/WebCore:

Add support for IIRFilterNode interface:

• ​https://www.w3.org/TR/webaudio/#iirfilternode

The implementation is based on Chromium's.

No new tests, rebaselined existing tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/webaudio/AudioNode.cpp:

(WebCore::convertEnumerationToString):
(WebCore::AudioNode::disableOutputsIfNecessary):

• Modules/webaudio/AudioNode.h:
• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createIIRFilter):

• Modules/webaudio/BaseAudioContext.h:
• Modules/webaudio/BaseAudioContext.idl:
• Modules/webaudio/IIRDSPKernel.cpp: Added.

(WebCore::IIRDSPKernel::IIRDSPKernel):
(WebCore::IIRDSPKernel::getFrequencyResponse):
(WebCore::IIRDSPKernel::process):
(WebCore::IIRDSPKernel::reset):

• Modules/webaudio/IIRDSPKernel.h: Added.
• Modules/webaudio/IIRFilterNode.cpp: Added.

(WebCore::isFilterStable):
(WebCore::IIRFilterNode::create):
(WebCore::IIRFilterNode::IIRFilterNode):
(WebCore::IIRFilterNode::getFrequencyResponse):

• Modules/webaudio/IIRFilterNode.h: Added.
• Modules/webaudio/IIRFilterNode.idl: Added.
• Modules/webaudio/IIRFilterOptions.h: Added.
• Modules/webaudio/IIRFilterOptions.idl: Added.
• Modules/webaudio/IIRProcessor.cpp: Added.

(WebCore::IIRProcessor::IIRProcessor):
(WebCore::IIRProcessor::~IIRProcessor):
(WebCore::IIRProcessor::createKernel):
(WebCore::IIRProcessor::process):
(WebCore::IIRProcessor::getFrequencyResponse):

• Modules/webaudio/IIRProcessor.h: Added.
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• platform/audio/IIRFilter.cpp: Added.

(WebCore::evaluatePolynomial):
(WebCore::IIRFilter::IIRFilter):
(WebCore::IIRFilter::reset):
(WebCore::IIRFilter::process):
(WebCore::IIRFilter::getFrequencyResponse):
(WebCore::IIRFilter::tailTime):

• platform/audio/IIRFilter.h: Added.
• platform/graphics/ImageUtilities.h:

1:04 PM Changeset in webkit [266185] by Alan Coon

• 6 edits
  1 add in branches/safari-610.1.28.1-branch

Cherry-pick r265996. rdar://problem/67707045

[macOS] Web pages are not responding correctly to changes in "Reduce motion" setting
​https://bugs.webkit.org/show_bug.cgi?id=215664

Reviewed by Darin Adler.

Source/WebCore/PAL:

Declare "Reduce motion" preference key, as well as notification sent when the "Reduce motion" setting is changed.

• pal/spi/mac/HIServicesSPI.h:

Source/WebKit:

This happens because there is a race between the preference change and notification being received in the WebContent
process. This race is usually won by the notification, which then reads the wrong preference value when being handled.
This bug was introduced when access to the preference daemon was closed in the WebContent process, and preferences
were updated from the UI process. This patch addresses this issue by re-posting the notification when the preference
value is updated in the WebContent process.

API test: WebKit.AccessibilityReduceMotion

• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::reduceMotionPreferenceKey): (WebKit::dispatchSimulatedNotificationsForPreferenceChange):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit/AccessibilityReduceMotion.mm: Added. (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 PM Changeset in webkit [266184] by Alan Coon

• 3 edits
  2 adds in branches/safari-610.1.28.1-branch

Cherry-pick r265985. rdar://problem/67707039

REGRESSION (r263729): Carousel freezes on "fourth page"/fourth click on right arrow on netflix.com
​https://bugs.webkit.org/show_bug.cgi?id=215655
<rdar://problem/65845979>

Reviewed by Dean Jackson.

Source/WebCore:

On netflix.com, when clicking on the left and right arrows in each movie or TV show carousel, the page attempts
to animate to the next page of the carousel using a CSS transform transition. The logic applies transform and
transition CSS properties to a container div, and adds a transitionend event listener which the page
expects to be invoked when the animation is complete. While waiting for this transitionend event, the script
also sets a boolean flag that prevents the carousel from being advanced to any other page. However, after the
changes in r263729, the carousel gets into a state where transition and transform styles are set, but the
animation never begins, and thus, no subsequent transitionend event is observed. This causes the page to
believe that the carousel is indefinitely animating, so it never unsets the boolean flag, which results in the
carousel being permanently stuck.

This occurs because we now have logic in AnimationTimeline::updateCSSTransitionsForElementAndProperty that
moves the CSSTransition from the element's map of running transitions to the map of completed transitions in
the case where the corresponding WebAnimation is already in Finished state. However, consider the case where
there is no matching backing animation (i.e. matchingBackingAnimation is nullptr); for instance, this can
happen if the transition CSS property is set to none in the middle of the transitionend event, as demonstrated
in the new layout test. Before the change, we would've removed the CSSTransition from the map of running
transitions and canceled it, but now, we instead move it to the map of completed transitions, where it remains
until the next CSS transition update is triggered (which would potentially be indefinitely long!).

On netflix.com, this next CSS transition update happens the page attempts to advance the carousel. Since the old
CSSTransition is still in the "completed" transitions map, we end up returning true when checking
propertyInStyleMatchesValueForTransitionInMap, and consequently never attempt to create a new CSSTransition
and add it to the map of running transitions in step 1 of the algorithm. As described above, this causes the
carousel to get stuck in a bad state.

To fix this, we simply revert to pre-r263729 behavior in the case where the matching backing animation was
already removed, and allow step 3 of the algorithm to cancel the running animation and remove it altogether
instead of moving it into the element's completed transitions map.

Test: animations/animation-followed-by-two-transitions.html

• animation/AnimationTimeline.cpp: (WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):

LayoutTests:

Adds a layout test inspired by animation logic used in the broken carousel UI on netflix.com. This test can be
manually run by opening the test in a browser and verifying that the green square quickly slides across the
screen twice, and two transitionend events are observed in the process.

• animations/animation-followed-by-two-transitions-expected.txt: Added.
• animations/animation-followed-by-two-transitions.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:57 PM Changeset in webkit [266183] by Alan Coon

• 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.4

12:54 PM Changeset in webkit [266182] by eric.carlson@apple.com

• 2 edits in trunk/Tools

TestWebKitAPI.AudioRoutingArbitration.Deletion is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=215856
<rdar://problem/66950074>

Reviewed by Jer Noble.

This test deletes a video element by removing it from the DOM, and verifies that
arbitration status changes appropriately. Arbitration status isn't changed until
the element's destructor runs, and that doesn't happen until it is garbage collected
so force GC while waiting for the status to change.

• TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm:

(AudioRoutingArbitration::statusShouldBecomeEqualTo): Add optional parameter to force
GC while waiting for status to change.
(TEST_F):

12:44 PM Changeset in webkit [266181] by commit-queue@webkit.org

• 4 edits in trunk

Use endings from FilePropertyBag when constructing Blob data from the File
​https://bugs.webkit.org/show_bug.cgi?id=215857

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-26
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/FileAPI/file/File-constructor-endings-expected.txt:

Source/WebCore:

We had an unnecessary conversion function that converted one of the two properties of BlobPropertyBag (endings was missing).
Since FilePropertyBag inherits from BlobPropertyBag, just use the original FilePropertyBag to get both properties.

Covered by newly-passing WPT tests that Chrome and Firefox both pass.

• fileapi/File.cpp:

(WebCore::File::File):
(WebCore::convertPropertyBag): Deleted.

12:36 PM Changeset in webkit [266180] by ysuzuki@apple.com

• 6 edits in trunk

[JSC] Enable Intl.Segmenter
​https://bugs.webkit.org/show_bug.cgi?id=215854

Reviewed by Ross Kirsling.

JSTests:

• stress/intl-segmenter.js:
• test262/config.yaml:

Source/JavaScriptCore:

This is already stage-3 and all the features are implemented. Let's just enable it.

• runtime/IntlObject.cpp:

(JSC::IntlObject::finishCreation):

• runtime/OptionsList.h:

11:49 AM Changeset in webkit [266179] by Russell Epstein

• 5 edits
  4 adds in branches/safari-610.1.28.0-branch

Apply patch. rdar://problem/67812567

11:41 AM Changeset in webkit [266178] by ysuzuki@apple.com

• 8 edits
  1 add in trunk

[JSC] Add ASCII comparison fast path for IntlCollator
​https://bugs.webkit.org/show_bug.cgi?id=215798

Reviewed by Darin Adler, Ross Kirsling, and Saam Barati.

JSTests:

• stress/string-locale-compare-uca-ducet.js: Added.

(shouldBe):

• stress/string-localeCompare.js:

(data.sort):

Source/JavaScriptCore:

The idea behind this change is the following: ICU Collator's comparison is too slow. We should have fast path for ASCII strings when we know this equals to ICU Collator's result.
The problem is that even for ASCII strings, collation is super complicated!

1. Unicode defines Unicode Collation Algorithm (UCA). To perform collation, it uses collation element tables which defines weights on various levels per code point. UCA also offers the Default Unicode Collation Element Table (DUCET). This UCA with DUCET is used when using ICU Root Collator.
2. UCA collation consists of rules, which defines how collation works. And ICU locales define customized collations by adding special rules to that.
3. UCA behaves differently by using different options.

Based on that, our observation is that some of major locales are not defining additional rules in (2). This means that they behaves the same to UCA with DUCET.
This patch implements a simplified version of comparison which generates the same results for ASCII strings (excluding control characters) to UCA with DUCET. This fast path can be usable only when the following conditions are met.

1. The collator does not have additional rules to ICU Root Colator.
2. The collator is using default options.

These checks are very important since there are a lot of edge-case locales. For example,

1. th (Thai language) ignores punctuations (even including ASCII punctuations) by default. This is defined as ignore-punctuations option is enabled by default, so without (2)'s check, th comparison becomes wrong.
2. There are contraction concept (multiple letters behave as a single letter). "ch" letters are ordered interestingly in Czech language. So even in ASCII, Czech shows very interesting collation behavior.

So we cannot safely take this fast path without carefully querying the information to ICU.

This shows 37% improvement in JetStream2/cdjs in en-US environment.

• runtime/IntlCollator.cpp:

(JSC::IntlCollator::initializeCollator):
(JSC::IntlCollator::compareStrings const):
(JSC::canDoASCIIUCADUCETComparisonWithUCollator):
(JSC::IntlCollator::updateCanDoASCIIUCADUCETComparison const):
(JSC::IntlCollator::checkICULocaleInvariants):

• runtime/IntlCollator.h:
• runtime/IntlObject.cpp:

(JSC::intlCollatorAvailableLocales):

• runtime/IntlObject.h:
• runtime/IntlObjectInlines.h:

(JSC::canUseASCIIUCADUCETComparison):
(JSC::compareASCIIWithUCADUCET):

11:07 AM Changeset in webkit [266177] by youenn@apple.com

• 16 edits
  2 copies in trunk

Abort pipeTo based on AbortSignal
​https://bugs.webkit.org/show_bug.cgi?id=215448

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/streams/piping/abort.any-expected.txt:
• web-platform-tests/streams/piping/abort.any.worker-expected.txt:
• web-platform-tests/streams/piping/close-propagation-forward.any-expected.txt:
• web-platform-tests/streams/piping/close-propagation-forward.any.worker-expected.txt:
• web-platform-tests/streams/piping/error-propagation-forward.any-expected.txt:
• web-platform-tests/streams/piping/error-propagation-forward.any.worker-expected.txt:
• web-platform-tests/streams/piping/flow-control.any-expected.txt:
• web-platform-tests/streams/piping/flow-control.any.worker-expected.txt:

Source/WebCore:

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/streams/ReadableStreamInternals.js:

(readableStreamPipeToWritableStream):
(pipeToFinalize):

• Modules/streams/WritableStream.js:

(initializeWritableStream):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMGlobalObject.cpp:

(WebCore::makeDOMExceptionForBuiltins):
(WebCore::whenSignalAborted):
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

• bindings/js/WebCoreBuiltinNames.h:
• dom/AbortAlgorithm.h: Copied from Source/WebCore/dom/AbortSignal.idl.
• dom/AbortAlgorithm.idl: Copied from Source/WebCore/dom/AbortSignal.idl.
• dom/AbortSignal.cpp:

(WebCore::AbortSignal::whenSignalAborted):

• dom/AbortSignal.h:
• dom/AbortSignal.idl:

10:57 AM Changeset in webkit [266176] by jer.noble@apple.com

• 3 edits in trunk/Source/WebCore

[Mac,EME] Netflix.com shows HDCP error for all streams
​https://bugs.webkit.org/show_bug.cgi?id=215825

Reviewed by Eric Carlson.

New API added to AVContentKeySession hits a sandbox restriction when run in the WebContent process, and the default
behavior when an error checking HDCP status is to report that the output is restricted, regardless of the displays
actual capabilities. To work around this behavior for now, pass in an empty displayID array, rather than the actual
displayID. This causes AVFoundation to do a "lowest common level of support" rather than a specific display check.
The upside is that this call no longer requires a connection to the WindowServer. The downside is that the
AVContentKeyRequest will report that its output is restricted if any non-HDCP compliant display is attached.

• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyStatuses const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyRequestHasInsufficientProtectionForDisplayID const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateProtectionStatusForDisplayID):

10:53 AM Changeset in webkit [266175] by Russell Epstein

• 8 edits in branches/safari-610.1.28.0-branch/Source

Versioning.

WebKit-7610.1.28.0.4

10:43 AM Changeset in webkit [266174] by Russell Epstein

• 8 edits in branches/safari-610.2.2-branch/Source

Versioning.

WebKit-7610.2.2.2

10:40 AM Changeset in webkit [266173] by Oriol Brufau

• 4 edits
  2 adds in trunk

[css-grid] Set available column space before grid items prelayout
​https://bugs.webkit.org/show_bug.cgi?id=199648

Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

Import WPT test.

• web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-008-expected.html: Added.
• web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-008.html: Added.
• web-platform-tests/css/css-grid/alignment/self-baseline/w3c-import.log:

Source/WebCore:

Before running the grid track sizing algorithm, there is a prelayout
step which takes care of the baseline alignment of the items.
In order to do that, we estimate the size of the grid area, since we
have not calculated the final size yet.

The problem was that, when calculating this estimate, the available
column space had not been set yet. So if a column had a percentage track
sizing function, it would be treated as auto and the estimated size
would be wrong.

This patch sets the available column space so that we can resolve
percentage track sizing functions and get a more correct estimate.

Test: imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-008.html

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

10:34 AM Changeset in webkit [266172] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

Enable WritableStream by default
​https://bugs.webkit.org/show_bug.cgi?id=149842

Reviewed by Alex Christensen.

Implementation is now ready and is up to date with the latest specification.

• Shared/WebPreferences.yaml:

10:24 AM Changeset in webkit [266171] by Andres Gonzalez

• 4 edits in trunk/Source/WebCore

Code cleanup and consistent naming in AXIsolatedTree classes, no change in behavior.
​https://bugs.webkit.org/show_bug.cgi?id=215850

Reviewed by Chris Fleizach.

• Renamed AXIsolatedObject::m_attributeMap to m_propertyMap for naming

conssistency.

• typedef -> using
• Removed AXPropertyName::None, not used.
• Replaced AccessibilityIsolatedTreeMathMultiscriptPair alias with its

definition, shorter, clearer, and can be used for other property of the
same type.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::setMathscripts):
(WebCore::AXIsolatedObject::setProperty):
(WebCore::AXIsolatedObject::insertMathPairs):
(WebCore::AXIsolatedObject::mathPrescripts):
(WebCore::AXIsolatedObject::mathPostscripts):
(WebCore::AXIsolatedObject::intPointAttributeValue const):
(WebCore::AXIsolatedObject::objectAttributeValue const):
(WebCore::AXIsolatedObject::rectAttributeValue const):
(WebCore::AXIsolatedObject::vectorAttributeValue const):
(WebCore::AXIsolatedObject::optionSetAttributeValue const):
(WebCore::AXIsolatedObject::pairAttributeValue const):
(WebCore::AXIsolatedObject::uint64AttributeValue const):
(WebCore::AXIsolatedObject::urlAttributeValue const):
(WebCore::AXIsolatedObject::pathAttributeValue const):
(WebCore::AXIsolatedObject::colorAttributeValue const):
(WebCore::AXIsolatedObject::floatAttributeValue const):
(WebCore::AXIsolatedObject::doubleAttributeValue const):
(WebCore::AXIsolatedObject::unsignedAttributeValue const):
(WebCore::AXIsolatedObject::boolAttributeValue const):
(WebCore::AXIsolatedObject::stringAttributeValue const):
(WebCore::AXIsolatedObject::intAttributeValue const):

• accessibility/isolatedtree/AXIsolatedObject.h:
• accessibility/isolatedtree/AXIsolatedTree.h:

9:48 AM Changeset in webkit [266170] by ysuzuki@apple.com

• 9 edits in trunk

[JSC] Implement Intl.DateTimeFormat fractionalSecondDigits
​https://bugs.webkit.org/show_bug.cgi?id=215840

Reviewed by Ross Kirsling.

JSTests:

Test262 is showing wrong ordering of option property accesses compared to the latest PR.
Later, we should update Test262.

• stress/intl-datetimeformat.js:

(const.options.get second):
(const.options.get fractionalSecondDigits):
(const.options.get localeMatcher):
(const.options.get timeZoneName):
(const.options.get formatMatcher):

• test262/config.yaml:
• test262/expectations.yaml:

Source/JavaScriptCore:

This patch implements fractionalSecondDigits option for Intl.DateTimeFormat. If it is
specified, milliseconds in N digits are represented in the formatted output.
This extension is about to be merged into the spec[1]. SpiderMonkey and V8 support it,
and V8 shipped it without flags.

[1]: ​https://github.com/tc39/ecma402/pull/347

• builtins/DatePrototype.js:

(toLocaleString.toDateTimeOptionsAnyAll):
(toLocaleString):
(toLocaleTimeString.toDateTimeOptionsTimeTime):
(toLocaleTimeString):

• runtime/CommonIdentifiers.h:
• runtime/IntlDateTimeFormat.cpp:

(JSC::toDateTimeOptionsAnyDate):
(JSC::IntlDateTimeFormat::setFormatsFromPattern):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::resolvedOptions const):
(JSC::partTypeString):

• runtime/IntlDateTimeFormat.h:

9:46 AM Changeset in webkit [266169] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Move inline run alignment logic to a dedicated class
​https://bugs.webkit.org/show_bug.cgi?id=214527
<rdar://problem/66115796>

Reviewed by Antti Koivisto.

This is in preparation for moving line alignment logic to LineBox (LineBuilder will not going to be responsible for aligning runs on the line).

• layout/FormattingContext.h:
• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineContentAligner::formattingContext const):
(WebCore::Layout::LineContentAligner::layoutState const):
(WebCore::Layout::LineContentAligner::LineContentAligner):
(WebCore::Layout::LineContentAligner::alignHorizontally):
(WebCore::Layout::LineContentAligner::alignVertically):
(WebCore::Layout::LineContentAligner::justifyRuns):
(WebCore::Layout::LineContentAligner::adjustBaselineAndLineHeight):
(WebCore::Layout::LineContentAligner::collectHangingContent const):
(WebCore::Layout::LineContentAligner::runContentHeight const):
(WebCore::Layout::LineBuilder::LineBuilder):
(WebCore::Layout::LineBuilder::~LineBuilder):
(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::clear):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::alignContentVertically): Deleted.
(WebCore::Layout::LineBuilder::justifyRuns): Deleted.
(WebCore::Layout::LineBuilder::alignHorizontally): Deleted.
(WebCore::Layout::LineBuilder::collectHangingContent): Deleted.
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight): Deleted.
(WebCore::Layout::LineBuilder::runContentHeight const): Deleted.
(WebCore::Layout::LineBuilder::layoutState const): Deleted.
(WebCore::Layout::LineBuilder::root const): Deleted.

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::availableWidth const):
(WebCore::Layout::LineBuilder::contentLogicalRight const):
(WebCore::Layout::LineBuilder::logicalTop const): Deleted.
(WebCore::Layout::LineBuilder::logicalBottom const): Deleted.
(WebCore::Layout::LineBuilder::logicalLeft const): Deleted.
(WebCore::Layout::LineBuilder::logicalRight const): Deleted.
(WebCore::Layout::LineBuilder::logicalWidth const): Deleted.
(WebCore::Layout::LineBuilder::logicalHeight const): Deleted.
(WebCore::Layout::LineBuilder::baseline const): Deleted.

9:18 AM Changeset in webkit [266168] by Chris Dumez

• 54 edits
  2 adds in trunk

REGRESSION (r265908): Crash under Blob::arrayBuffer() / Blob::text() in stress GC
​https://bugs.webkit.org/show_bug.cgi?id=215832
<rdar://problem/67741677>

Reviewed by Ryosuke Niwa.

Source/WebCore:

r265908 added support for Blob::arrayBuffer() / Blob::text() which are asynchronous operations
returning promises. The crash is due to the fact that the Blob's JS wrapper may get garbage
collected before the promise is settled.

To address the issue, this patch makes Blob an ActiveDOMObject and creates an
ActiveDOMObject::pendingActivity whenever there is a pending promise so that the JS wrapper
does not get garbage collected too early.

Test: fast/files/blob-text-gc.html

• Modules/async-clipboard/Clipboard.cpp:

(WebCore::Clipboard::getType):

• Modules/async-clipboard/ClipboardImageReader.h:

(WebCore::ClipboardImageReader::ClipboardImageReader):

• Modules/async-clipboard/ClipboardItem.cpp:

(WebCore::ClipboardItem::blobFromString):

• Modules/async-clipboard/ClipboardItem.h:
• Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:

(WebCore::ClipboardItemBindingsDataSource::getType):

• Modules/async-clipboard/ios/ClipboardImageReaderIOS.mm:

(WebCore::ClipboardImageReader::readBuffer):

• Modules/async-clipboard/mac/ClipboardImageReaderMac.mm:

(WebCore::ClipboardImageReader::readBuffer):

• Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::getFile):

• Modules/entriesapi/DOMFileSystem.h:
• Modules/entriesapi/FileSystemFileEntry.cpp:

(WebCore::FileSystemFileEntry::file):

• Modules/entriesapi/FileSystemFileEntry.h:
• Modules/entriesapi/FileSystemFileEntry.idl:
• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::fromFormData):

• Modules/fetch/FetchBody.h:
• Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::blobFromData):
(WebCore::packageFormData):
(WebCore::resolveWithTypeAndData):
(WebCore::FetchBodyConsumer::resolve):
(WebCore::FetchBodyConsumer::takeAsBlob):

• Modules/fetch/FetchBodyConsumer.h:
• Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::blob):

• Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::stopRecording):
(WebCore::MediaRecorder::requestData):

• Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::didReceiveRawData):

• Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveBinaryData):

• Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readFile):
(WebCore::CloneDeserializer::readTerminal):

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::updateFileList):
(WebCore::DataTransfer::items):
(WebCore::DataTransfer::filesFromPasteboardAndItemList const):
(WebCore::DataTransfer::files const):

• dom/DataTransfer.h:
• dom/DataTransfer.idl:
• dom/DataTransferItemList.cpp:

(WebCore::DataTransferItemList::DataTransferItemList):
(WebCore::DataTransferItemList::remove):
(WebCore::DataTransferItemList::clear):
(WebCore::DataTransferItemList::ensureItems const):
(WebCore::DataTransferItemList::document const):

• dom/DataTransferItemList.h:
• dom/DataTransferItemList.idl:
• editing/WebCorePasteboardFileReader.cpp:

(WebCore::WebCorePasteboardFileReader::readFilename):
(WebCore::WebCorePasteboardFileReader::readBuffer):

• editing/WebCorePasteboardFileReader.h:
• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::createFragmentForImageAttachment):
(WebCore::replaceRichContentWithAttachments):
(WebCore::createFragmentAndAddResources):
(WebCore::sanitizeMarkupWithArchive):
(WebCore::WebContentReader::readImage):
(WebCore::attachmentForFilePath):
(WebCore::attachmentForData):

• editing/markup.cpp:

(WebCore::restoreAttachmentElementsInFragment):

• fileapi/Blob.cpp:

(WebCore::Blob::Blob):
(WebCore::Blob::loadBlob):
(WebCore::Blob::activeDOMObjectName const):

• fileapi/Blob.h:

(WebCore::Blob::create):
(WebCore::Blob::deserialize):
(WebCore::Blob::slice const):

• fileapi/Blob.idl:
• fileapi/File.cpp:

(WebCore::File::createWithRelativePath):
(WebCore::File::create):
(WebCore::File::File):
(WebCore::File::activeDOMObjectName const):

• fileapi/File.h:
• fileapi/File.idl:
• html/DOMFormData.cpp:

(WebCore::DOMFormData::createFileEntry):

• html/DirectoryFileListCreator.cpp:

(WebCore::FileInformation::isolatedCopy const):
(WebCore::appendDirectoryFiles):
(WebCore::gatherFileInformation):
(WebCore::toFileList):
(WebCore::DirectoryFileListCreator::start):

• html/DirectoryFileListCreator.h:
• html/FileInputType.cpp:

(WebCore::FileInputType::appendFormData const):
(WebCore::FileInputType::filesChosen):

• html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::updateEnclosingImageWithData):

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toBlob):

• testing/Internals.cpp:

(WebCore::Internals::createFile):

• testing/ServiceWorkerInternals.cpp:

(WebCore::ServiceWorkerInternals::createOpaqueWithBlobBodyResponse):

• workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::dispatchFetchEvent):

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createResponseBlob):

Source/WebKit:

• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::setFilesForInputFileUpload):

LayoutTests:

Add better test coverage.

• fast/files/blob-text-gc-expected.txt: Added.
• fast/files/blob-text-gc.html: Added.

5:08 AM Changeset in webkit [266167] by Andres Gonzalez

• 3 edits in trunk/Source/WebCore

When caching the AccessibilityText property in AXIsolatedObject, the Strings need to be isolatedCopied.
​https://bugs.webkit.org/show_bug.cgi?id=215834

Reviewed by Chris Fleizach.

The initialization of the AccessibilityText property in AXIsolatedObject::initializeAttributeData
wasn't isolatedCopying the Strings contained in the AccessibilityText structure.
Instead it was copying the String into a different structure. This patch
straightlines the caching of the AccessibilityText property by isolatedCopying
the original Strings. This simplifies the retrieval of this property
since there is no conversion to make in the AXIsolatedObject::accessibilityText
method.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData): isolatedCopies the
String in AccessibilityText.
(WebCore::AXIsolatedObject::accessibilityText const): No conversion
needed to retrieve the property.

• accessibility/isolatedtree/AXIsolatedTree.h:

Removed the AccessibilityIsolatedTreeText structure since it is not needed.

4:16 AM Changeset in webkit [266166] by youenn@apple.com

• 44 edits
  2 adds in trunk

enumerateDevices should expose audiooutput devices that are tied to an audio input device
​https://bugs.webkit.org/show_bug.cgi?id=215806

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/mediacapture-streams/MediaStreamTrack-getSettings.https-expected.txt:
• web-platform-tests/mediacapture-streams/MediaStreamTrack-getSettings.https.html:

Source/WebCore:

Add support for a speaker selection feature policy, as per ​https://w3c.github.io/mediacapture-output/#permissions-policy-integration.
Add support for speaker mock devices and for listing speakers on MacOS in CoreAudioCaptureDeviceManager.
Add support for groupId to group microphones and speakers for both mock audio manager and CoreAudioCaptureDeviceManager.
For mock speakers, we add two audiooutput devices that are related to a microphone and one audiooutput that is not related to any microphone.

Test: fast/mediastream/enumerate-speaker.html

• Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::MediaDevices):
(WebCore::checkSpeakerAccess):
(WebCore::toMediaDeviceInfoKind):
(WebCore::MediaDevices::refreshDevices):

• Modules/mediastream/MediaDevices.h:
• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::sourceCaptureState):
(WebCore::MediaStreamTrack::updateToPageMutedState):

• html/FeaturePolicy.cpp:

(WebCore::policyTypeName):
(WebCore::FeaturePolicy::parse):
(WebCore::FeaturePolicy::allows const):

• html/FeaturePolicy.h:
• page/Settings.yaml:
• platform/mediastream/CaptureDevice.h:

(WebCore::CaptureDevice::label const):
(WebCore::CaptureDevice::setGroupId):

• platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::getMediaStreamDevices):

• platform/mediastream/RealtimeMediaSourceFactory.h:
• platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:

(WebCore::GStreamerAudioCaptureSourceFactory::speakerDevices const):

• platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.h:
• platform/mediastream/mac/CoreAudioCaptureDevice.cpp:

(WebCore::CoreAudioCaptureDevice::create):
(WebCore::CoreAudioCaptureDevice::CoreAudioCaptureDevice):
(WebCore::CoreAudioCaptureDevice::relatedAudioDeviceIDs):

• platform/mediastream/mac/CoreAudioCaptureDevice.h:
• platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:

(WebCore::CoreAudioCaptureDeviceManager::captureDevices):
(WebCore::deviceHasOutputStreams):
(WebCore::getDefaultCaptureInputDevice):
(WebCore::hasDevice):
(WebCore::CoreAudioCaptureDeviceManager::refreshAudioCaptureDevices):

• platform/mediastream/mac/CoreAudioCaptureDeviceManager.h:
• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSourceFactory::speakerDevices const):

• platform/mediastream/mac/CoreAudioCaptureSource.h:
• platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp:

(WebCore::DisplayCaptureManagerCocoa::captureDeviceWithPersistentID):

• platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp:

(WebCore::DisplayCaptureSourceCocoa::create):

• platform/mock/MockMediaDevice.h:

(WebCore::MockSpeakerProperties::encode const):
(WebCore::MockSpeakerProperties::decode):
(WebCore::MockMediaDevice::isSpeaker const):
(WebCore::MockMediaDevice::captureDevice const):
(WebCore::MockMediaDevice::type const):
(WebCore::MockMediaDevice::speakerProperties const):
(WebCore::MockMediaDevice::encode const):
(WebCore::MockMediaDevice::decode):

• platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::defaultDevices):
(WebCore::deviceListForDevice):
(WebCore::toCaptureDevice):
(WebCore::createMockDevice):
(WebCore::MockRealtimeMediaSourceCenter::setDevices):
(WebCore::MockRealtimeMediaSourceCenter::addDevice):
(WebCore::MockRealtimeMediaSourceCenter::captureDeviceWithPersistentID):
(WebCore::MockRealtimeMediaSourceCenter::microphoneDevices):
(WebCore::MockRealtimeMediaSourceCenter::speakerDevices):
(WebCore::MockRealtimeMediaSourceCenter::videoDevices):

• platform/mock/MockRealtimeMediaSourceCenter.h:

Source/WebKit:

Introduce an experimental flag (off by default) to cover speaker selection, including exposing speaker devices to web pages.
Update UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList to only expose speakers that are tied to a microphone that is exposed.
This aligns with ​https://w3c.github.io/mediacapture-output/#privacy-obtaining-consent.

• GPUProcess/GPUConnectionToWebProcess.cpp:
• Shared/WebPreferences.yaml:
• UIProcess/API/C/WKMockMediaDevice.cpp:

(WKAddMockMediaDevice):

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetExposeSpeakersEnabled):
(WKPreferencesGetExposeSpeakersEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):

• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::isMicrophoneDevice):
(WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList):

• WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:

(WebKit::sourceTypeFromDeviceType):
(WebKit::RemoteRealtimeMediaSource::RemoteRealtimeMediaSource):
(WebKit::RemoteRealtimeMediaSource::~RemoteRealtimeMediaSource):

• WebProcess/cocoa/UserMediaCaptureManager.h:

Tools:

Enable experimental flag.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

• fast/mediastream/enumerate-speaker-expected.txt: Added.
• fast/mediastream/enumerate-speaker.html: Added.
• fast/mediastream/get-user-media-device-id.html:
• http/tests/media/media-stream/enumerate-devices-source-id.html:
• http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute-expected.txt:
• http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute.html:

Rewrite test to use testharness and ensure order of the iframe tests so that console messages are ordered.

• http/tests/media/media-stream/resources/enumerate-devices-iframe.html:

2:08 AM Changeset in webkit [266165] by Diego Pino Garcia

• 3 edits in trunk/Tools

[ews] Split JSC ARMv7 queue into separate builder and tester queue
​https://bugs.webkit.org/show_bug.cgi?id=215728

Reviewed by Aakash Jain.

This new bubble runs jscore-tests for JSC ARMv7 32-bit. The former
'jsc-armv7' bubble now reports about successful binary builds for the
same architecture.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble):

• BuildSlaveSupport/ews-build/config.json:

12:53 AM Changeset in webkit [266164] by Paulo Matos

• 2 edits in trunk/JSTests

Skip stress/array-species-create-should-handle-masquerader.js on MIPS

Unreviewed Gardening.

• stress/array-species-create-should-handle-masquerader.js:

12:51 AM Changeset in webkit [266163] by Diego Pino Garcia

• 2 edits
  2 adds in trunk/LayoutTests

[GTK] Unreviewed test gardening. Emit baseline after r266129.

Also mark two tests as time out flaky after r266118.

• platform/glib/TestExpectations:
• platform/gtk/streams/pipe-to-expected.txt: Added.

12:22 AM Changeset in webkit [266162] by youenn@apple.com

• 5 edits in trunk

pipeThrough should check for readableStream type
​https://bugs.webkit.org/show_bug.cgi?id=215497

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/streams/piping/pipe-through.any-expected.txt:
• web-platform-tests/streams/piping/pipe-through.any.worker-expected.txt:

Source/WebCore:

Covered by rebased tests.

• Modules/streams/ReadableStream.js:

(pipeThrough):

Aug 25, 2020:

11:26 PM Changeset in webkit [266161] by Diego Pino Garcia

• 17 edits in trunk/LayoutTests

[GTK] Update test expectations. Update baselines after r266118.

• platform/glib/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt:
• platform/gtk/css1/font_properties/font-expected.txt:
• platform/gtk/fast/css/font-face-multiple-faces-expected.txt:
• platform/gtk/fast/css/font-face-synthetic-bold-italic-expected.txt:
• platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
• platform/gtk/fast/invalid/junk-data-expected.txt:
• platform/gtk/fast/invalid/missing-end-tag-expected.txt:
• platform/gtk/fast/parser/xhtml-alternate-entities-expected.txt:
• platform/gtk/fast/xsl/xslt-extra-content-at-end-expected.txt:
• platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
• platform/gtk/svg/custom/bug45331-expected.txt:
• platform/gtk/svg/custom/junk-data-expected.txt:
• platform/gtk/svg/custom/missing-xlink-expected.txt:
• platform/gtk/svg/custom/path-bad-data-expected.txt:
• platform/gtk/svg/custom/use-font-face-crash-expected.txt:
• platform/gtk/svg/hixie/error/012-expected.txt:

11:15 PM Changeset in webkit [266160] by Fujii Hironori

• 4 edits in trunk/Source/WebCore

Move FreeType port's Font::platformWidthForGlyph and Font::platformBoundsForGlyph for Cairo port (WinCairo port)
​https://bugs.webkit.org/show_bug.cgi?id=215838

Reviewed by Carlos Garcia Campos.

WinCairo was using GDI API to implement
Font::platformWidthForGlyph and Font::platformBoundsForGlyph. This
is a problem for Cairo DirectWrite font backend (Bug 215259).
FreeType port has platform independent implementations which are
using Cairo API. Use them for WinCairo.

• platform/graphics/cairo/FontCairo.cpp:

(WebCore::Font::platformBoundsForGlyph const): Moved from SimpleFontDataFreeType.cpp.
(WebCore::Font::platformWidthForGlyph const): Ditto.

• platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformBoundsForGlyph const): Moved to FontCairo.cpp.
(WebCore::Font::platformWidthForGlyph const): Ditto.

• platform/graphics/win/SimpleFontDataCairoWin.cpp:

(WebCore::Font::platformBoundsForGlyph const): Deleted.
(WebCore::Font::platformWidthForGlyph const): Deleted.

10:17 PM Changeset in webkit [266159] by ysuzuki@apple.com

• 5 edits
  1 add in trunk

[JSC] FTL should use m_origin instead of m_node->origin since m_node can be nullptr
​https://bugs.webkit.org/show_bug.cgi?id=215833

Reviewed by Mark Lam.

JSTests:

• stress/ftl-entry-osr-exit-has-nullptr-node.js: Added.

(foo):

Source/JavaScriptCore:

While we are using m_node->origin, m_node can be nullptr (at the entry of the FTL function).
m_origin is always pointing appropriate origin. We should use it instead.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileToObjectOrCallObjectConstructor):
(JSC::FTL::DFG::LowerDFGToB3::compileToThis):
(JSC::FTL::DFG::LowerDFGToB3::compileValueAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueSub):
(JSC::FTL::DFG::LowerDFGToB3::compileValueMul):
(JSC::FTL::DFG::LowerDFGToB3::compileBinaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileStrCat):
(JSC::FTL::DFG::LowerDFGToB3::compileArithAddOrSub):
(JSC::FTL::DFG::LowerDFGToB3::compileArithClz32):
(JSC::FTL::DFG::LowerDFGToB3::compileValueDiv):
(JSC::FTL::DFG::LowerDFGToB3::compileValueMod):
(JSC::FTL::DFG::LowerDFGToB3::compileArithAbs):
(JSC::FTL::DFG::LowerDFGToB3::compileArithUnary):
(JSC::FTL::DFG::LowerDFGToB3::compileValuePow):
(JSC::FTL::DFG::LowerDFGToB3::compileArithRandom):
(JSC::FTL::DFG::LowerDFGToB3::compileArithRound):
(JSC::FTL::DFG::LowerDFGToB3::compileArithFloor):
(JSC::FTL::DFG::LowerDFGToB3::compileArithCeil):
(JSC::FTL::DFG::LowerDFGToB3::compileArithTrunc):
(JSC::FTL::DFG::LowerDFGToB3::compileArithSqrt):
(JSC::FTL::DFG::LowerDFGToB3::compileArithFRound):
(JSC::FTL::DFG::LowerDFGToB3::compileIncOrDec):
(JSC::FTL::DFG::LowerDFGToB3::compileValueNegate):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitNot):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitAnd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitOr):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitXor):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitRShift):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitLShift):
(JSC::FTL::DFG::LowerDFGToB3::compileGetById):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByValWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByValWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite):
(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsIsLockFree):
(JSC::FTL::DFG::LowerDFGToB3::compileDefineDataProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileDefineAccessorProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileGetIndexedPropertyStorage):
(JSC::FTL::DFG::LowerDFGToB3::compileGetPrototypeOf):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):
(JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorById):
(JSC::FTL::DFG::LowerDFGToB3::compilePutGetterSetterById):
(JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileDeleteById):
(JSC::FTL::DFG::LowerDFGToB3::compileDeleteByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayPush):
(JSC::FTL::DFG::LowerDFGToB3::compileArraySlice):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayIndexOf):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayPop):
(JSC::FTL::DFG::LowerDFGToB3::compilePushWithScope):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateActivation):
(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateDirectArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateScopedArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateClonedArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateArgumentsButterfly):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateRest):
(JSC::FTL::DFG::LowerDFGToB3::compileObjectKeysOrObjectGetOwnPropertyNames):
(JSC::FTL::DFG::LowerDFGToB3::compileObjectCreate):
(JSC::FTL::DFG::LowerDFGToB3::compileNewSymbol):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArray):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateThis):
(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray):
(JSC::FTL::DFG::LowerDFGToB3::compileToNumber):
(JSC::FTL::DFG::LowerDFGToB3::compileToNumeric):
(JSC::FTL::DFG::LowerDFGToB3::compileCallNumberConstructor):
(JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructorOrStringValueOf):
(JSC::FTL::DFG::LowerDFGToB3::compileToPrimitive):
(JSC::FTL::DFG::LowerDFGToB3::compileToPropertyKey):
(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):
(JSC::FTL::DFG::LowerDFGToB3::compileStringFromCharCode):
(JSC::FTL::DFG::LowerDFGToB3::compileMultiPutByOffset):
(JSC::FTL::DFG::LowerDFGToB3::compileGetGlobalThis):
(JSC::FTL::DFG::LowerDFGToB3::compileGetArgument):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
(JSC::FTL::DFG::LowerDFGToB3::compileSameValue):
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
(JSC::FTL::DFG::LowerDFGToB3::compileVarargsLength):
(JSC::FTL::DFG::LowerDFGToB3::compileLoadVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileForwardVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileSwitch):
(JSC::FTL::DFG::LowerDFGToB3::compileThrow):
(JSC::FTL::DFG::LowerDFGToB3::compileThrowStaticError):
(JSC::FTL::DFG::LowerDFGToB3::mapHashString):
(JSC::FTL::DFG::LowerDFGToB3::compileMapHash):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucket):
(JSC::FTL::DFG::LowerDFGToB3::compileSetAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileMapSet):
(JSC::FTL::DFG::LowerDFGToB3::compileTypeOfIsObject):
(JSC::FTL::DFG::LowerDFGToB3::compileIsCallable):
(JSC::FTL::DFG::LowerDFGToB3::compileIsConstructor):
(JSC::FTL::DFG::LowerDFGToB3::compileInByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileHasOwnProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileParseInt):
(JSC::FTL::DFG::LowerDFGToB3::compileInstanceOfCustom):
(JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileHasGenericProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileHasStructurePropertyImpl):
(JSC::FTL::DFG::LowerDFGToB3::compileGetDirectPname):
(JSC::FTL::DFG::LowerDFGToB3::compileGetPropertyEnumerator):
(JSC::FTL::DFG::LowerDFGToB3::compileToIndexString):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeCreateActivation):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckTraps):
(JSC::FTL::DFG::LowerDFGToB3::compileNewRegexp):
(JSC::FTL::DFG::LowerDFGToB3::compileSetFunctionName):
(JSC::FTL::DFG::LowerDFGToB3::compileStringReplace):
(JSC::FTL::DFG::LowerDFGToB3::compileLogShadowChickenTail):
(JSC::FTL::DFG::LowerDFGToB3::getArgumentsLength):
(JSC::FTL::DFG::LowerDFGToB3::getCurrentCallee):
(JSC::FTL::DFG::LowerDFGToB3::getArgumentsStart):
(JSC::FTL::DFG::LowerDFGToB3::compare):
(JSC::FTL::DFG::LowerDFGToB3::compileStringSlice):
(JSC::FTL::DFG::LowerDFGToB3::compileToLowerCase):
(JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithRadix):
(JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithValidRadixConstant):
(JSC::FTL::DFG::LowerDFGToB3::compileResolveScopeForHoistingFuncDeclInEval):
(JSC::FTL::DFG::LowerDFGToB3::compileResolveScope):
(JSC::FTL::DFG::LowerDFGToB3::compileGetDynamicVar):
(JSC::FTL::DFG::LowerDFGToB3::compilePutDynamicVar):
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOM):
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOMGetter):
(JSC::FTL::DFG::LowerDFGToB3::compileLoopHint):
(JSC::FTL::DFG::LowerDFGToB3::genericJSValueCompare):
(JSC::FTL::DFG::LowerDFGToB3::stringsEqual):
(JSC::FTL::DFG::LowerDFGToB3::allocateJSArray):
(JSC::FTL::DFG::LowerDFGToB3::boolify):
(JSC::FTL::DFG::LowerDFGToB3::equalNullOrUndefined):
(JSC::FTL::DFG::LowerDFGToB3::contiguousPutByValOutOfBounds):
(JSC::FTL::DFG::LowerDFGToB3::switchStringSlow):
(JSC::FTL::DFG::LowerDFGToB3::buildTypeOf):
(JSC::FTL::DFG::LowerDFGToB3::lazySlowPath):
(JSC::FTL::DFG::LowerDFGToB3::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::FTL::DFG::LowerDFGToB3::codeOriginDescriptionOfCallSite const):
(JSC::FTL::DFG::LowerDFGToB3::callCheck):
(JSC::FTL::DFG::LowerDFGToB3::appendOSRExit):

• jsc.cpp:

(runJSC):

• runtime/OptionsList.h:

10:09 PM Changeset in webkit [266158] by timothy_horton@apple.com

• 5 edits
  4 adds in trunk

Web Share API Level 2 functions even when its experimental feature flag is disabled
​https://bugs.webkit.org/show_bug.cgi?id=215831
<rdar://problem/67760687>

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/web-share/canShare-with-files-feature-disabled.html

fast/web-share/share-with-files-feature-disabled.html

We had a feature flag for Web Share API Level 2, but it isn't actually
consulted anywhere in the implementation.

• page/Navigator.cpp:

(WebCore::Navigator::canShare):
Rewrite canShare to be a bit more readable, and also to consult the Level 2 feature flag.

(WebCore::Navigator::share):
Since canShare (per the spec) will return true if we have files and other content,
even if files are not shareable, check the feature flag again before loading the files.

Source/WebKit:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showShareSheet):
If the Web Content process sends us files, but the Level 2 feature flag is disabled,
something fishy is happening, so fire a MESSAGE_CHECK.

LayoutTests:

• fast/web-share/canShare-with-files-feature-disabled-expected.txt: Added.
• fast/web-share/canShare-with-files-feature-disabled.html: Added.
• fast/web-share/share-with-files-feature-disabled-expected.txt: Added.
• fast/web-share/share-with-files-feature-disabled.html: Added.

Add some tests that ensure that disabling the feature actually works.

7:25 PM Changeset in webkit [266157] by rniwa@webkit.org

• 24 edits in trunk

HashMap<Ref<T>>::take should return RefPtr<T>
​https://bugs.webkit.org/show_bug.cgi?id=215830

Reviewed by Darin Adler.

Source/WebCore:

• Modules/indexeddb/client/IDBConnectionProxy.cpp:

(WebCore::IDBClient::IDBConnectionProxy::didGetAllDatabaseNamesAndVersions):

• accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::removeTreeForPageID):

• crypto/SubtleCrypto.cpp:

(WebCore::getPromise):

• dom/CustomElementRegistry.cpp:

(WebCore::CustomElementRegistry::addElementDefinition):

• dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::notifyFinished):

• inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::didRemoveDOMNode):

• page/PageOverlayController.cpp:

(WebCore::PageOverlayController::uninstallPageOverlay):

• workers/service/ServiceWorkerClients.cpp:

(WebCore::ServiceWorkerClients::claim):

• workers/service/context/ServiceWorkerThreadProxy.cpp:

(WebCore::ServiceWorkerThreadProxy::cancelFetch):

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::workerContextTerminated):

Source/WebKit:

• GPUProcess/media/RemoteAudioDestinationManager.cpp:

(WebKit::RemoteAudioDestinationManager::deleteAudioDestination):

• NetworkProcess/NetworkResourceLoadMap.cpp:

(WebKit::NetworkResourceLoadMap::take):

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::willClosePage):

• UIProcess/WebURLSchemeHandler.cpp:

(WebKit::WebURLSchemeHandler::taskCompleted):

• WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasGranted):
(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasDenied):

Source/WebKitLegacy/mac:

• WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::didCheckSucceed):

Source/WTF:

Updated the hash traits for Ref<T> to make HashMap<Ref<T>> and HashSet<Ref<T>>
return RefPtr<T> instad of Optional<Ref<T>>.

• wtf/HashTraits.h:

(WTF::RefHashTraits::take):

Tools:

• TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::TEST):

7:22 PM Changeset in webkit [266156] by Alan Bujtas

• 3 edits
  2 adds in trunk

Facebook post with lots of comments has cut off scrollbar, and can't scroll fully to the bottom (sticky)
​https://bugs.webkit.org/show_bug.cgi?id=215719
<rdar://problem/66411757>

Reviewed by Simon Fraser.

Source/WebCore:

While computing the scrollable overflow for inflow positioned (or transformed) renderers, we need to take their paint geometry into
account so that scrolling matches their final positions.
e.g.

<div style="width: 100px; height: 100px;"></div>
<div style="position: relative; top: -20; width: 50px; height: 50px;"></div>

While the inflow positioned block box is placed right below the previous sibling div, visually they overlap each other.
If these boxes happen to be in a scrollable container, the scrolling should be driven by the overlapping state (paint geometry) and not
by the layout geometry (where the 2 boxes are placed vertically after each other).

While stickily positioned boxes are also considered inflow positioned, their initial inflow layout positions contribute to the scrollable overflow
as they are not stationary boxes.

Test: fast/css/scrollable-overflow-with-sticky-positioning.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::layoutOverflowRectForPropagation const):

LayoutTests:

• fast/css/scrollable-overflow-with-sticky-positioning-expected.html: Added.
• fast/css/scrollable-overflow-with-sticky-positioning.html: Added.

6:31 PM Changeset in webkit [266155] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

[LFC][IFC] Do not move the runs out of the LineBuilder while closing the line
​https://bugs.webkit.org/show_bug.cgi?id=214790

Reviewed by Antti Koivisto.

Closing the line should not mean that the LineBuilder does not have the line runs anymore.
This is in preparation for moving alignment code from LineBuilder to LineBox.
(This patch also refactors InlineFormattingContext::lineLayout to make it less verbose.)

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::append):

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::runs const):

• layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineLayoutContext::layoutInlineContent):
(WebCore::Layout::LineLayoutContext::close):
(WebCore::Layout::LineLayoutContext::nextContentForLine):
(WebCore::Layout::LineLayoutContext::commitFloats):
(WebCore::Layout::LineLayoutContext::layoutLine): Deleted.

• layout/inlineformatting/LineLayoutContext.h:

(WebCore::Layout::LineLayoutContext::InlineItemRange::isEmpty const):
(WebCore::Layout::LineLayoutContext::InlineItemRange::size const):

5:28 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

5:08 PM Changeset in webkit [266154] by clopez@igalia.com

• 2 edits in trunk/Tools

[GTK][WPE] Add a script for generating MiniBrowser bundles (follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=215266

Unreviewed follow-up fix.

Ensure the install-dependencies script of the bundle calls apt-get update
before trying to install the system packages when --autoinstall is passed.

• Scripts/generate-bundle:

4:55 PM Changeset in webkit [266153] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://67764580 REGRESSION: [ BigSur ] 20 fast/ and tables/ tests are a constant failure

Unreviewed test gardening.

• platform/mac/TestExpectations:

4:33 PM Changeset in webkit [266152] by Alan Coon

• 1 copy in tags/Safari-610.1.28.0.3

Tag Safari-610.1.28.0.3.

3:46 PM Changeset in webkit [266151] by timothy_horton@apple.com

• 8 edits
  2 adds in trunk

Web Share API can share non-HTTP(S) URLs
​https://bugs.webkit.org/show_bug.cgi?id=215823
<rdar://problem/62083130>

Reviewed by Wenson Hsieh.

Source/WebCore:

Test: fast/web-share/share-disallows-file-urls.html

• page/Navigator.cpp:

(WebCore::shareableURLForShareData):
(WebCore::Navigator::canShare):
(WebCore::Navigator::share):
Factor out the code to complete and check the scheme of the URL.
Make canShare() return NO and share() fail for non-HTTP(S) or data: URLs.

Source/WebKit:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showShareSheet):
Ensure that only HTTP family or data: URLs are shared.

LayoutTests:

• fast/web-share/share-disallows-file-urls-expected.txt: Added.
• fast/web-share/share-disallows-file-urls.html: Added.
• fast/web-share/share-transient-activation-expired.html:
• fast/web-share/share-transient-activation.html:
• fast/web-share/share.html:

Add a test that ensures that sharing a non-HTTP-family URL fails,
and fix the existing tests to share HTTP-family URLs.

3:26 PM Changeset in webkit [266150] by commit-queue@webkit.org

• 18 edits in trunk/Tools

Remove unneeded HAVE(NETWORK_FRAMEWORK) macro
​https://bugs.webkit.org/show_bug.cgi?id=215824

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-25
Reviewed by Darin Adler.

This used to be needed for High Sierra support, which was before Network.framework was introduced.
Now, we can assume it is available on all Cocoa platforms.

• TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
• TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
• TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
• TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm:
• TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
• TestWebKitAPI/cocoa/HTTPServer.h:
• TestWebKitAPI/cocoa/HTTPServer.mm:
• TestWebKitAPI/config.h:

3:20 PM Changeset in webkit [266149] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

[Win] The layout test animations/steps-transform-rendering-updates.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=215827

Unreviewed test gardening.

• platform/win/TestExpectations:

3:08 PM Changeset in webkit [266148] by beidson@apple.com

• 5 edits
  3 adds in trunk

Font loads quickly followed by navigations may fail indefinitely
<rdar://problem/65560550> and ​https://bugs.webkit.org/show_bug.cgi?id=215435

Reviewed by Myles C. Maxfield.

Source/WebCore:

Second take at this.

Myles took the first swipe at this, but a conflict with SuspendableTimer caused issues
in the form of layout test asserts with
http/tests/security/navigate-when-restoring-cached-page.html

His original ChangeLog entry:

Font loads are coalesced using a zero-delay timer. However, that zero-delay timer
can fire while the page is in the middle of a navigation, which will cause the font
loads to fail. Then, the second page can request those same fonts, which are marked
as failed, and as such will never actually load/use the desired web font.

This patch just stops the zero-delay timer during navigations, and resumes it
when resuming the document. This means:

1. The second page in the above story will not see that the font has failed, or

even started, and will then re-request the font and load it successfully

2. If the user goes "back" to the previous page, the zero-delay timer is restarted,

the CachedFont realizes it's already succeeded, and the previous page is rendered
as expected.

Test: fast/loader/font-load-timer.html

---

Now the explanation of the failure it caused:
The font loading timer was a SuspendableTimer, which is an ActiveDOMObject.

An ActiveDOMObject was used to make sure the delayed font loads play well with the
page cache, which is still necessary.

But we also still need to suspend the timer manually when "stopLoading()" is called,
which doesn't play well with ActiveDOMObject's automatic suspend/resume.

My solution:

• Make the timer "just a normal timer"
• Make CSSFontSelector itself the ActiveDOMObject
• Let DocumentLoader explicitly pause the font load timer
• Rely on ActiveDOMObject to resume the timer

These keep the bug fixed and resolve the layout test ASSERT seen with
http/tests/security/navigate-when-restoring-cached-page.html

• css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::clearDocument):
(WebCore::CSSFontSelector::beginLoadingFontSoon):
(WebCore::CSSFontSelector::suspendFontLoadingTimer):
(WebCore::CSSFontSelector::fontLoadingTimerFired):
(WebCore::CSSFontSelector::stop):
(WebCore::CSSFontSelector::suspend):
(WebCore::CSSFontSelector::resume):
(WebCore::CSSFontSelector::beginLoadTimerFired): Deleted.

• css/CSSFontSelector.h:
• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoading):

LayoutTests:

1) The page has some content that has “font-family: WebFont” but there are no @font-face blocks on the page
2) In script, after the page has loaded, add an @font-face rule to the page with “font-family: WebFont” and some valid font URL
3) Synchronously, within the same turn of the run loop, trigger a synchronous layout of the element (using offsetWidth or something). This will add the font to the 0-delay time work list.
4) Synchronously, within the same turn of the run loop, navigate to a second page that doesn’t use the web font.
5) The second page waits some small-but-positive amount of time. This will cause the 0-delay timer to fire, but because the page is in the middle of navigating, the font load should fail.
6) The second page adds the same @font-face rule to itself using script. This should pull the same (failed) CachedResource object out of the memory cache.
7) Use the CSS Font Loading API to wait for the font load to complete
8) Make sure that the font is used on the second page (as a reference test). Today, the second page’s font load will fail because it pulled the failed font out of the memory cache. The test makes sure the second page’s font load succeeds.

• fast/loader/font-load-timer-expected.html: Added.
• fast/loader/font-load-timer.html: Added.
• fast/loader/resources/font-load-timer-navigation-destination.html: Added.

3:00 PM Changeset in webkit [266147] by Alan Coon

• 1 copy in tags/Safari-610.2.2.1

Tag Safari-610.2.2.1.

2:57 PM Changeset in webkit [266146] by Alan Coon

• 19 edits
  2 deletes in branches/safari-610.2.2-branch

Revert r265115. rdar://problem/67759082

2:51 PM Changeset in webkit [266145] by pvollan@apple.com

• 3 edits in trunk/Source/WTF

[Win] Assert failure under RunLoop::RunLoop
​https://bugs.webkit.org/show_bug.cgi?id=215812

Reviewed by Brent Fulgham.

The assert 'ASSERT(::IsWindow(m_runLoopMessageWindow))' under RunLoop::RunLoop will fail if the JSC API JSGlobalContextCreate*()
is being called by a client before WTF::initializeMainThread() has been called. The assertion fails because the method
RunLoop::registerRunLoopMessageWindowClass() has not been called yet, since it is only called when initializing the main thread.
This patch addresses this issue by making sure the window class has been registered before being referenced in RunLoop::RunLoopl
The method call is also removed from the main thread initialization, since the window class is only used in RunLoop::RunLoop,
making it sufficient to only be registered there. Also change the debug assert to a release assert, so we can catch similar
issues in release builds.

• wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform):

• wtf/win/RunLoopWin.cpp:

(WTF::RunLoop::registerRunLoopMessageWindowClass):
(WTF::RunLoop::RunLoop):

2:43 PM Changeset in webkit [266144] by Peng Liu

• 2 edits in trunk/Source/WebCore

When using airplay with Youtube, the Youtube tab becomes completely empty and is unresponsive for an extended period of time if we switch the tab
​https://bugs.webkit.org/show_bug.cgi?id=215821

Reviewed by Eric Carlson.

We should ignore the request to paint the current video frame when we are using airplay.
It is not necessary to do so, and -[AVAssetImageGenerator copyCGImageAtTime:actualTime:error:]
will block the web process for a long time if the video is airplaying.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):

2:34 PM Changeset in webkit [266143] by Megan Gardner

• 4 edits in trunk/Source

Trying to lookup when WebView is in a popover causes process to hang. Fix for Legacy WebView.
​https://bugs.webkit.org/show_bug.cgi?id=215792

Reviewed by Tim Horton.

Source/WebKit:

Update code based on Darin's suggestion for mirror fix in legacy webkit.

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):

Source/WebKitLegacy/mac:

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=214773 also needed in legacy WebView.
The Lookup framework does not populate the menus that it vends with the option to 'lookup'
words that are selected in popovers. WebKit should follow the pattern and not put the
item in the menu as Lookup is not able to handle this situation. Also if Lookup is disabled
via defaults, we should not show it in the menu.

• WebView/WebHTMLView.mm:

(customMenuFromDefaultItems):

2:22 PM Changeset in webkit [266142] by rniwa@webkit.org

• 8 edits in trunk

Resolve with the class used to define the Custom Element
​https://bugs.webkit.org/show_bug.cgi?id=215562

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-sync'ed the test with that in ​https://github.com/web-platform-tests/wpt/pull/25033.

• web-platform-tests/custom-elements/CustomElementRegistry-expected.txt:
• web-platform-tests/custom-elements/CustomElementRegistry.html:

Source/WebCore:

Implemented the new behavior to resolve customElements.whenDefined(~)
with the custom element's constructor when it's defined.

Test: imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry.html

• bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::JSCustomElementRegistry::define):
(WebCore::whenDefinedPromise):

• bindings/js/JSDOMPromiseDeferred.h:

(WebCore::DeferredPromise::resolveWithJSValue): Added.

• dom/CustomElementRegistry.cpp:

(WebCore::CustomElementRegistry::addElementDefinition): Made this return DeferredPromise.

• dom/CustomElementRegistry.h:

1:20 PM Changeset in webkit [266141] by clopez@igalia.com

• 4 edits in trunk

[WPE][Qt] Fix qt-wpe-minibrowser on Debian10
​https://bugs.webkit.org/show_bug.cgi?id=215730

Reviewed by Philippe Normand.

Source/WebKit:

QWheelEvent position is not available on Qt < 5.14. Use posF instead in that case.
Tested with Qt 5.11

No new tests, is a build fix.

• UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:

(WPEQtViewBackend::dispatchWheelEvent):

Tools:

When not running in flatpak the path to the qml directory is different.

• Scripts/run-qt-wpe-minibrowser:

12:09 PM Changeset in webkit [266140] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Fix read-after-free introduced in r266087
​https://bugs.webkit.org/show_bug.cgi?id=215671

• Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::packageFormData):
Keep the CString in scope while we are using it.

12:04 PM Changeset in webkit [266139] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS Mojave wk1 ] fast/layers/hidpi-transform-on-child-content-is-mispositioned.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215819

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

11:49 AM Changeset in webkit [266138] by Devin Rousso

• 3 edits
  3 adds in trunk

Web Inspector: breakpoint condition should be evaluated before the ignore count
​https://bugs.webkit.org/show_bug.cgi?id=215364
<rdar://problem/67310703>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Previously, when pausing, JSC::Breakpoint would check that it's ignoreCount before it
would even attempt to evaluate it's condition. This meant that a JSC::Breakpoint with
a condition of foo === 42 and an ignoreCount of 3 would ignore the first three
pauses and then only pause if foo === 42. This is likely contrary to the expectation of
most users (especially since the condition input is before the ignoreCount input in
the Web Inspector frontend UI) in that they would probably expect to ignore the first
three pauses if foo === 42.

• debugger/Breakpoint.cpp:

(JSC::Breakpoint::shouldPause):

LayoutTests:

• inspector/debugger/resources/condition-ignoreCount.js: Added.

(trigger): Added.

• inspector/debugger/setBreakpoint-condition-ignoreCount.html: Added.
• inspector/debugger/setBreakpoint-condition-ignoreCount-expected.txt: Added.

11:47 AM Changeset in webkit [266137] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS Release ] webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb32f-rgb-float.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215817

Unreviewed test gardening.

• platform/mac/TestExpectations:

11:46 AM Changeset in webkit [266136] by Andres Gonzalez

• 6 edits in trunk/Source/WebCore

Crash in WebCore::AccessibilityRenderObject::textUnderElement in isolated tree mode.
​https://bugs.webkit.org/show_bug.cgi?id=215790

Reviewed by Darin Adler.

This crash is happening in isolated tree mode because AXIsolatedObject::initializeAttributeData
is caching all properties of the object on a checked state changed notification.
In some cases like the web page in the bug report, not all properties
can be computed in the notification handler. In particular AccessibilityRenderObject::textUnderElement
does the following checks:

Renders referenced by accessibility objects could get destroyed, if TextIterator ends up triggering
style update/layout here. See also AXObjectCache::deferTextChangedIfNeeded().
ASSERT_WITH_SECURITY_IMPLICATION(!nodeDocument->childNeedsStyleRecalc());
ASSERT_WITH_SECURITY_IMPLICATION(!nodeDocument->view()->layoutContext().isInRenderTreeLayout());

This patch addresses this problem by only updating the checked state
property of the isolated object, instead of all properties, in the
checked state change notification.
This is also a performance enhancement since only the property that
changed is re-calculated. The same approach will be used for other properties.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::updateIsolatedTree): Checked state changed notifications
trigger an update of the corresponding isolated object's chekced state
instead of the creation of a new object and re-calculation of all cached properties.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::setProperty): Removed ASSERT since it is now
called in applyPendingChanges on the secondary thread.

• accessibility/isolatedtree/AXIsolatedObject.h: Moved the AXPropertyName

enumeration, the AttributeValueVariant and attribute map declarations
out of this header into AXIsolatedTree.h in order to be able to use them
in both classes.

• accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::updateNode): Removed unnecessary scope operator.
(WebCore::AXIsolatedTree::updateNodeCheckedState): Added.
(WebCore::AXIsolatedTree::applyPendingChanges): Added updating the pending
properties on the secondary thread.

• accessibility/isolatedtree/AXIsolatedTree.h: Moved to this header the declarations

that are now shared by AXIsolatedObject and AXIsolatedTree.

11:37 AM Changeset in webkit [266135] by Devin Rousso

• 2 edits in trunk/Tools

REGRESSION(r265601): invalid blame URL copied when include_revision is false
​https://bugs.webkit.org/show_bug.cgi?id=215796

Reviewed by Daniel Bates.

• CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py:

(CopyWebKitPermalinkCommand.permalink_for_path):
Always add ? to the URL before the revision and/or blame and have each have their own &.

11:07 AM Changeset in webkit [266134] by jer.noble@apple.com

• 4 edits
  1 add in trunk

[Mac] REGRESSION(r262322): Focusable elements are focused when exiting from video fullscreen mode.
​https://bugs.webkit.org/show_bug.cgi?id=215660
<rdar://problem/65263150>

Reviewed by Darin Adler.

Source/WebKit:

API Test: Fullscreen.Focus.

The default behavior of NSWindow is to change its -keyViewSelectionDirection to NSSelectingNext when activating
and changing the firstResponder. This causes WKWebView to change it's focus in response to becoming first responder.
The cheap fix is to ensure WKWebView is already the firstResponder when the window is activated. Then NSWindow won't
try to change the firstResponder in response to activation.

• UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/FullscreenFocus.mm: Added.

(-[FullscreenFocusUIDelegate _webViewDidEnterFullscreen:]):
(-[FullscreenFocusUIDelegate _webViewDidExitFullscreen:]):
(TestWebKitAPI::TEST):

11:06 AM Changeset in webkit [266133] by commit-queue@webkit.org

• 10 edits in trunk/Source

Clean up deprecated and unused SPI to set HSTS storage on ProcessPoolConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=215788

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-25
Reviewed by Chris Dumez.

Source/WebCore/PAL:

• pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

After rdar://problem/65047971 this is no longer needed because the replacement on WebsiteDataStoreConfiguration has been adopted.
The selector on _WKProcessPoolConfiguration had already been deprecated, and is left for now to allow easier debugging with OSes that use it still.

• NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

• NetworkProcess/NetworkProcessCreationParameters.h:
• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):

• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

• UIProcess/API/APIProcessPoolConfiguration.h:
• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration setHSTSStorageDirectory:]):
(-[_WKProcessPoolConfiguration hstsStorageDirectory]):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):

10:45 AM Changeset in webkit [266132] by Alan Coon

• 2 edits in branches/safari-610.2.2-branch/Source/WebKit

Cherry-pick r266099. rdar://problem/67742560

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::PDFPlugin::createScrollbar
<rdar://problem/67473335> and ​https://bugs.webkit.org/show_bug.cgi?id=215787

Reviewed by Tim Horton.

To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.

This is a speculative fix due to the aforementioned reproducibility issue.

• WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel): Check on the main thread whenever this is called, instead of when deciding to dispatch to the main thread. (WebKit::PDFPlugin::threadEntry): We can't do this check on the background thread when considering the dispatch to the main thread, as the flag might've changed by then. Let's *just* check it on the main thread. (WebKit::PDFPlugin::adoptBackgroundThreadDocument): We can't do the check on the background thread when (WebKit::PDFPlugin::updateScrollbars): This is where the crash itself is. All of the Obj-C code in here is safe to do after destroy(), up until the very end when we get into pluginView() derefencing. So it seems prudent to add another check here. (WebKit::PDFPlugin::documentDataDidFinishLoading): In addition to receivedNonLinearizedPDFSentinel and adoptBackgroundThreadDocument, this is the final of the (3) calls that end up calling installPDFDocument, so for added coverage it seems like a prudent place to add the check.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:45 AM Changeset in webkit [266131] by Alan Coon

• 3 edits
  2 adds in branches/safari-610.2.2-branch

Cherry-pick r265881. rdar://problem/67742375

REGRESSION(r265092): delegatesFocus causes WebKit to crash
​https://bugs.webkit.org/show_bug.cgi?id=215622

Reviewed by Youenn Fablet.

Source/WebCore:

The bug was caused by a missing nullptr check. Added it.

Test: fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html

• page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Added a nullptr check.

LayoutTests:

Added a regression test.

• fast/shadow-dom/delegates-focus-unsuccessfully-by-activation-expected.txt: Added.
• fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:41 AM Changeset in webkit [266130] by Alan Coon

• 8 edits in branches/safari-610.2.2-branch/Source

Versioning.

WebKit-7610.2.2.1

10:36 AM Changeset in webkit [266129] by youenn@apple.com

• 48 edits
  15 deletes in trunk

Refresh ReadableStream.pipeTo implementation up to spec
​https://bugs.webkit.org/show_bug.cgi?id=215415

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/response/response-stream-disturbed-by-pipe.any-expected.txt:
• web-platform-tests/fetch/api/response/response-stream-disturbed-by-pipe.any.worker-expected.txt:
• web-platform-tests/streams/idlharness.any-expected.txt:
• web-platform-tests/streams/idlharness.any.worker-expected.txt:
• web-platform-tests/streams/piping/abort.any-expected.txt:
• web-platform-tests/streams/piping/abort.any.worker-expected.txt:
• web-platform-tests/streams/piping/close-propagation-backward-expected.txt: Removed.
• web-platform-tests/streams/piping/close-propagation-backward.any-expected.txt:
• web-platform-tests/streams/piping/close-propagation-backward.any.worker-expected.txt:
• web-platform-tests/streams/piping/close-propagation-forward-expected.txt: Removed.
• web-platform-tests/streams/piping/close-propagation-forward.any-expected.txt:
• web-platform-tests/streams/piping/close-propagation-forward.any.worker-expected.txt:
• web-platform-tests/streams/piping/error-propagation-backward-expected.txt: Removed.
• web-platform-tests/streams/piping/error-propagation-backward.any-expected.txt:
• web-platform-tests/streams/piping/error-propagation-backward.any.worker-expected.txt:
• web-platform-tests/streams/piping/error-propagation-forward-expected.txt: Removed.
• web-platform-tests/streams/piping/error-propagation-forward.any-expected.txt:
• web-platform-tests/streams/piping/error-propagation-forward.any.worker-expected.txt:
• web-platform-tests/streams/piping/flow-control-expected.txt: Removed.
• web-platform-tests/streams/piping/flow-control.any-expected.txt:
• web-platform-tests/streams/piping/flow-control.any.worker-expected.txt:
• web-platform-tests/streams/piping/general-expected.txt: Removed.
• web-platform-tests/streams/piping/general.any-expected.txt:
• web-platform-tests/streams/piping/general.any.worker-expected.txt:
• web-platform-tests/streams/piping/multiple-propagation-expected.txt: Removed.
• web-platform-tests/streams/piping/multiple-propagation.any-expected.txt:
• web-platform-tests/streams/piping/multiple-propagation.any.worker-expected.txt:
• web-platform-tests/streams/piping/pipe-through-expected.txt: Removed.
• web-platform-tests/streams/piping/pipe-through.any-expected.txt:
• web-platform-tests/streams/piping/pipe-through.any.worker-expected.txt:
• web-platform-tests/streams/piping/then-interception.any-expected.txt:
• web-platform-tests/streams/piping/then-interception.any.worker-expected.txt:
• web-platform-tests/streams/piping/throwing-options.any-expected.txt:
• web-platform-tests/streams/piping/throwing-options.any.worker-expected.txt:
• web-platform-tests/streams/piping/transform-streams-expected.txt: Removed.
• web-platform-tests/streams/readable-streams/patched-global.any-expected.txt:
• web-platform-tests/streams/readable-streams/patched-global.any.worker-expected.txt:
• web-platform-tests/streams/readable-streams/reentrant-strategies.any-expected.txt:
• web-platform-tests/streams/readable-streams/reentrant-strategies.any.worker-expected.txt:

Source/WebCore:

Update pipeTo implementation as per specification.
Keep the old implementation if WritableStream is not enabled.

Covered by existing tests.

• Modules/streams/ReadableStream.js:

(pipeThrough):

• Modules/streams/ReadableStreamInternals.js:

(acquireReadableStreamDefaultReader):
(readableStreamPipeToWritableStream):
(pipeToLoop):
(pipeToErrorsMustBePropagatedForward):
(pipeToErrorsMustBePropagatedBackward):
(pipeToClosingMustBePropagatedForward):
(pipeToClosingMustBePropagatedBackward):
(pipeToShutdownWithAction):
(pipeToShutdown):

• Modules/streams/WritableStream.js:

(initializeWritableStream):

• bindings/js/JSDOMGlobalObject.cpp:

(WebCore::isWritableStreamAPIEnabled):
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

• bindings/js/WebCoreBuiltinNames.h:
• dom/AbortSignal.idl:

Tools:

Put console log in stderr as this makes some tests flaky otherwise.

• DumpRenderTree/TestOptions.cpp:

(shouldDumpJSConsoleLogInStdErr):

• WebKitTestRunner/TestOptions.cpp:

(WTR::shouldDumpJSConsoleLogInStdErr):

LayoutTests:

Re-enable piping tests.
Remove obsolete tests.

• TestExpectations:
• streams/readable-stream-pipeThrough-expected.txt:
• streams/readable-stream-pipeThrough.html:

Update according new API.

• streams/reference-implementation/pipe-to-expected.txt: Removed.
• streams/reference-implementation/pipe-to.html: Removed.
• streams/reference-implementation/pipe-through-expected.txt: Removed.
• streams/reference-implementation/pipe-through.html: Removed.
• streams/reference-implementation/pipe-to-options-expected.txt: Removed.
• streams/reference-implementation/pipe-to-options.html: Removed.
• streams/reference-implementation/readable-stream-templated-expected:

9:59 AM Changeset in webkit [266128] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS Debug ] inspector/console/queryInstances.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215814

Unreviewed test gardening.

• platform/mac/TestExpectations:

9:44 AM Changeset in webkit [266127] by commit-queue@webkit.org

• 4 edits in trunk

Add setting for lazy iframe loading
​https://bugs.webkit.org/show_bug.cgi?id=215566

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-25
Reviewed by Youenn Fablet.

Source/WebCore:

Add setting for lazy iframe loading, disabling it until
this feature is implemented.

• page/Settings.yaml:

LayoutTests:

Enable the lazy iframe loading setting in testharnessreport.js for the iframe lazy
loading WPT tests in html/semantics/embedded-content/the-iframe-element.

• resources/testharnessreport.js:

9:43 AM Changeset in webkit [266126] by Hector Lopez

• 2 edits in trunk/LayoutTests

macOS Debug ] webaudio/webaudio-gc.html is a flaky crash.

<rdar://problem/65571152>

Unreviewed test gardening.

• platform/mac/TestExpectations: correction

9:39 AM Changeset in webkit [266125] by Alan Bujtas

• 8 edits in trunk/Source/WebCore

[LFC][IFC] The initial alignment baseline is always set by the strut
​https://bugs.webkit.org/show_bug.cgi?id=214785

Reviewed by Antti Koivisto.

Let's just use the strut ascent as the initial alignment baseline.

• layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::root const):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
(WebCore::Layout::InlineFormattingContext::constraintsForLine):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::initialLineHeight const):
(WebCore::Layout::InlineFormattingContext::Quirks::lineHeightConstraints const): Deleted.

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::LineBox):

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::root const):

• layout/inlineformatting/InlineLineBuilder.h:

9:36 AM Changeset in webkit [266124] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] http/tests/websocket/construct-in-detached-frame.html is a flaky crash
<rdar://problem/61278051>

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations: corrected to skip

9:32 AM Changeset in webkit [266123] by Darin Adler

• 12 edits in trunk

REGRESSION (r266028): platform/ios/ios/fast/coordinates/range-client-rects.html
​https://bugs.webkit.org/show_bug.cgi?id=215772

Reviewed by Anders Carlsson.

Source/WebCore:

• dom/Range.cpp:

(WebCore::Range::getClientRects const): Call updateLayout since it's not safe
to start working with the render tree without updating it first. Not required
to fix this bug, but an obvious omission. Ideally should make a test to show
this is needed.
(WebCore::Range::getBoundingClientRect const): Ditto.

• dom/SimpleRange.cpp:

(WebCore::order): Added.
(WebCore::documentOrder): Removed bogus special case. Test case proving this is
wrong is coming in the next documentOrder-related patch. Not needed to fix this
bug, but seems dangerous to leave this in the tree the way it was.
(WebCore::firstIntersectingNodeWithDeprecatedZeroOffsetStartQuirk): Added.
(WebCore::IntersectingNodeIterator::IntersectingNodeIterator): Added.

• dom/SimpleRange.h: Added intersectingNodesWithDeprecatedZeroOffsetStartQuirk.

• rendering/RenderObject.cpp:

(WebCore::borderAndTextRects): Use intersectingNodesWithDeprecatedZeroOffsetStartQuirk
because this needs to get the set of nodes in a way that works for our incorrectly
formed selection ranges and includes the first element even when the range technically
starts inside that element. We need to fix those, but that's a big project that affects
a lot of editing code. For now, restoring the old quirk is expedient.
(WebCore::RenderObject::collectSelectionRectsInternal): Ditto.

LayoutTests:

• platform/ios-wk2/TestExpectations: Removed failure expectation.

• platform/ios/ios/fast/coordinates/element-client-rects-expected.txt:
• platform/ios/ios/fast/coordinates/element-client-rects.html:
• platform/ios/ios/fast/coordinates/range-client-rects-expected.txt:
• platform/ios/ios/fast/coordinates/range-client-rects.html:

Changed tests so it's easier to read their results by putting rectangles and
rectangle lists into strings instead of comparing one value per line.

• platform/ios/ios/fast/coordinates/resources/helpers.js:

(rectString): Added.
(rectStrings): Added.
(setExpectedClientRectValues): Deleted.
(verifyClientRect): Deleted.

9:30 AM Changeset in webkit [266122] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] http/tests/websocket/construct-in-detached-frame.html is a flaky crash
<rdar://problem/61278051>

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

9:15 AM Changeset in webkit [266121] by eric.carlson@apple.com

• 17 edits in trunk

[macOS] Update audio arbitration manager when audio transport changes
​https://bugs.webkit.org/show_bug.cgi?id=215781
<rdar://problem/65920613>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, updated AudioRoutingArbitration API test.

• platform/audio/AudioSession.cpp:

(WebCore::AudioSession::audioOutputDeviceChanged): Add empty method.
(WebCore::setIsPlayingToBluetoothOverride): Ditto.

• platform/audio/AudioSession.h:

• platform/audio/cocoa/MediaSessionManagerCocoa.h:
• platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::audioOutputDeviceChanged): Call AudioSession::audioOutputDeviceChanged.

• platform/audio/mac/AudioSessionMac.mm:

(WebCore::defaultDeviceTransportIsBluetooth): New.
(WebCore::AudioSession::audioOutputDeviceChanged): Clear m_private->playingToBluetooth
if bluetooth transport has changed since the last arbitration update.
(WebCore::AudioSession::setIsPlayingToBluetoothOverride): Allow override of bluetooth
transport for testing.
(WebCore::AudioSession::setCategory): Update routing arbitration if audio session category
or bluetooth transport changes.

• testing/Internals.cpp:

(WebCore::Internals::setIsPlayingToBluetoothOverride):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

• UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
• UIProcess/API/Cocoa/WKWebViewTesting.mm:

(-[WKWebView _audioRoutingArbitrationUpdateTime]):

• UIProcess/Media/AudioSessionRoutingArbitratorProxy.h:

(WebKit::AudioSessionRoutingArbitratorProxy::arbitrationUpdateTime const):

• UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm:

(WebKit::AudioSessionRoutingArbitratorProxy::beginRoutingArbitrationWithCategory):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm:

(AudioRoutingArbitration::statusShouldBecomeEqualTo): Add message string to help
debugging when the test fails.

• TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:

9:08 AM Changeset in webkit [266120] by youenn@apple.com

• 4 edits
  7 adds in trunk

Generated bindings for derived dictionaries are not regenerated when the base dictionary changes
​https://bugs.webkit.org/show_bug.cgi?id=181714

Reviewed by Darin Adler.

Source/WebCore:

Add dictionary file dependencies to SupplementalDependencies.dep.
We add the base dictionary IDL file as a dependency to the JS cpp file of the derived dictionary.
We do so if we detect that a dictionary is deriving from another and both dictionaries are in their own IDL file.

Covered by updated binding tests.

• bindings/scripts/preprocess-idls.pl:

(updateDictionaryDependencies):

• bindings/scripts/test/SupplementalDependencies.dep: Added.
• bindings/scripts/test/TestDerivedDictionary2.idl: Added.
• bindings/scripts/test/TestInheritedDictionary2.idl: Added.
• bindings/scripts/test/JS/JSTestDerivedDictionary2.cpp: Added.

(WebCore::convertDictionary<TestDerivedDictionary2>):
(WebCore::convertDictionaryToJS):
(WebCore::convertDictionary<TestDerivedDictionary2::Dictionary>):

• bindings/scripts/test/JS/JSTestDerivedDictionary2.h: Added.
• bindings/scripts/test/JS/JSTestInheritedDictionary2.cpp: Added.

(WebCore::convertDictionary<TestInheritedDictionary2>):
(WebCore::convertDictionaryToJS):

• bindings/scripts/test/JS/JSTestInheritedDictionary2.h: Added.

Tools:

Add regression testing coverage for the generation of the makefile dependency file.

• Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency):
(BindingsTests.detect_changes):
(BindingsTests):
(BindingsTests.detect_file_changes):
(BindingsTests.main):

9:06 AM Changeset in webkit [266119] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS Debug ] webaudio/webaudio-gc.html is a flaky crash.
<rdar://problem/65571152>

Unreviewed test gardening.

• platform/mac/TestExpectations:

9:03 AM Changeset in webkit [266118] by mmaxfield@apple.com

• 5 edits
  6 adds in trunk

Fonts lie about being monospaced
​https://bugs.webkit.org/show_bug.cgi?id=162546
<rdar://problem/28494654>

Reviewed by Darin Adler.

Source/WebCore:

When a font reports itself to be monospace, we use this as a
signal that we can perform width computations by assuming all
characters have the same width as the space character. However,
some fonts erroneously claim to be monospaced. We can't know
this ahead of time without measuring a bunch of characters at
font load time, which would be too slow, so even though the
optimization would be nice there is no practical way to do it
correctly. Firefox and Chrome both do not use this signal, so
therefore they both correctly render these fonts. We should
ignore this bit in the font as well. Also, CJK fonts generally
do not have this bit set (because they usually have at least
one character which is not fullwidth) so this isn't a concern
there.

Our Page Load Test shows this is not a performance regression.

Tests: fast/text/font-erroneous-monospace.html

fast/text/font-monospaced-lie.html

• rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache const):

LayoutTests:

Add two tests for fonts which claim to be monospaced but actually aren't.

• fast/text/font-erroneous-monospace-expected.html: Added.
• fast/text/font-erroneous-monospace.html: Added.
• fast/text/font-monospaced-lie-expected.txt: Added.
• fast/text/font-monospaced-lie.html: Added.
• fast/text/line-break-after-question-mark-expected.txt:
• fast/text/line-break-after-question-mark.html:
• fast/text/resources/Ahem-fixed-pitch.ttf: Added.
• fast/text/resources/AhemErroneousMonospace.ttf: Added.

8:58 AM Changeset in webkit [266117] by Alexey Shvayka

• 8 edits in trunk

Invalid early error for object literal method named "proto"
​https://bugs.webkit.org/show_bug.cgi?id=215760

Reviewed by Ross Kirsling.

JSTests:

• test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

According to Annex B [1], { __proto__: null, __proto__() {} } is a valid object literal as the second
__proto__ wasn't obtained from PropertyDefinition : PropertyName : AssignmentExpression production.
Currently, JSC throws an early SyntaxError, unlike V8 and SpiderMonkey.

Since a method needs super binding, the most straightforward fix would be adding SuperBinding field
to SyntaxChecker::Property and exposing it via an accessor. However, given that Property is a very
common structure, this approach would noticeably increase memory pressure during parsing.

Instead, this patch reworks SyntaxChecker::Property to accept isUnderscoreProtoSetter parameter,
removing optional name field, its accessor, and shouldCheckPropertyForUnderscoreProtoDuplicate(),
which reduces sizeof(SyntaxChecker::Property) by a factor of 8: from 16 to 2 bytes.
Also, this change avoids two extra makeNumericIdentifier() calls, speeding up numeric keys parsing.

This approach is feasible because "proto" is the only identifier-based early error for object
literals [2], with no such errors being added in upcoming stage 2-4 proposals.

Additionally, this patch removes strict / complete bool parameter from {parse,create}Property()
signatures as a) it was always true, b) is now unused, and c) strict mode can be checked via scope.

[1]: ​https://tc39.es/ecma262/#sec-__proto__-property-names-in-object-initializers
[2]: ​https://tc39.es/ecma262/#sec-object-initializer-static-semantics-early-errors

• parser/ASTBuilder.h:

(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::isUnderscoreProtoSetter const):
(JSC::ASTBuilder::getName const): Deleted.

• parser/Nodes.h:
• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parseGetterSetter):
(JSC::Parser<LexerType>::parseObjectLiteral):
(JSC::Parser<LexerType>::shouldCheckPropertyForUnderscoreProtoDuplicate): Deleted.

• parser/Parser.h:
• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::SyntaxChecker):
(JSC::SyntaxChecker::Property::Property):
(JSC::SyntaxChecker::Property::operator!):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::operatorStackPop):

8:48 AM Changeset in webkit [266116] by youenn@apple.com

• 28 edits
  5 adds in trunk

Add support for MediaRecorder bitrate options
​https://bugs.webkit.org/show_bug.cgi?id=214973

Reviewed by Eric Carlson.

Source/WebCore:

Pipe options to MediaRecorderPrivate constructor.
For the actual implementation, pass it down to VideoSampleBufferCompressor and AudioSampleBufferCompressor.
For AudioSampleBufferCompressor, we do not handle well some bit rates, so for now, we limit to specific values.

Tests: http/wpt/mediarecorder/MediaRecorder-audio-bitrate.html

http/wpt/mediarecorder/MediaRecorder-video-bitrate.html

• Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::create):
(WebCore::MediaRecorder::createMediaRecorderPrivate):
(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::startRecording):

• Modules/mediarecorder/MediaRecorder.h:
• Modules/mediarecorder/MediaRecorderProvider.cpp:

(WebCore::MediaRecorderProvider::createMediaRecorderPrivate):

• Modules/mediarecorder/MediaRecorderProvider.h:
• WebCore.xcodeproj/project.pbxproj:
• loader/EmptyClients.cpp:
• platform/mediarecorder/MediaRecorderPrivate.h:
• platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:

(WebCore::MediaRecorderPrivateAVFImpl::create):

• platform/mediarecorder/MediaRecorderPrivateAVFImpl.h:
• platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h:
• platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:

(WebCore::AudioSampleBufferCompressor::setBitsPerSecond):
(WebCore::AudioSampleBufferCompressor::outputBitRate const):
(WebCore::AudioSampleBufferCompressor::initAudioConverterForSourceFormatDescription):
Do not exit when not able to set bitrate as we still want to set m_maxOutputPacketSize.
In case of error in setting up the converter, clean it up so that we do not use a partially set up converter.

• platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
• platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::create):
(WebCore::MediaRecorderPrivateWriter::setOptions):

• platform/mediarecorder/cocoa/VideoSampleBufferCompressor.h:
• platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:

(WebCore::VideoSampleBufferCompressor::setBitsPerSecond):
(WebCore::setCompressionSessionProperty):
(WebCore::VideoSampleBufferCompressor::initCompressionSession):

• testing/Internals.cpp:

(WebCore::createRecorderMockSource):

Source/WebKit:

Serialize options when creating remote media recorder.

• GPUProcess/webrtc/RemoteMediaRecorder.cpp:

(WebKit::RemoteMediaRecorder::create):

• GPUProcess/webrtc/RemoteMediaRecorder.h:
• GPUProcess/webrtc/RemoteMediaRecorderManager.cpp:

(WebKit::RemoteMediaRecorderManager::createRecorder):

• GPUProcess/webrtc/RemoteMediaRecorderManager.h:
• GPUProcess/webrtc/RemoteMediaRecorderManager.messages.in:
• WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:

(WebKit::MediaRecorderPrivate::MediaRecorderPrivate):
(WebKit::MediaRecorderPrivate::startRecording):

• WebProcess/GPU/webrtc/MediaRecorderPrivate.h:
• WebProcess/GPU/webrtc/MediaRecorderProvider.cpp:

(WebKit::MediaRecorderProvider::createMediaRecorderPrivate):

• WebProcess/GPU/webrtc/MediaRecorderProvider.h:

LayoutTests:

• http/wpt/mediarecorder/MediaRecorder-audio-bitrate-expected.txt: Added.
• http/wpt/mediarecorder/MediaRecorder-audio-bitrate.html: Added.
• http/wpt/mediarecorder/MediaRecorder-video-bitrate-expected.txt: Added.
• http/wpt/mediarecorder/MediaRecorder-video-bitrate.html: Added.

8:46 AM Changeset in webkit [266115] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] media/W3C/video/events/event_order_canplay_canplaythrough.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215809

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

8:29 AM Changeset in webkit [266114] by commit-queue@webkit.org

• 25 edits in trunk/Source/WebCore

Use more enum classes in DateComponents
​https://bugs.webkit.org/show_bug.cgi?id=215544

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-25
Reviewed by Sam Weinig.

Make Type and SecondFormat enum classes since this is more readable
and allows us to have less includes in header files.

• html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::serializeWithComponents const):

• html/DateInputType.cpp:

(WebCore::DateInputType::dateType const):

• html/DateInputType.h:
• html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::dateType const):

• html/DateTimeLocalInputType.h:
• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::dateType const):

• html/HTMLInputElement.h:
• html/InputType.cpp:

(WebCore::InputType::dateType const):

• html/InputType.h:
• html/MonthInputType.cpp:

(WebCore::MonthInputType::dateType const):

• html/MonthInputType.h:
• html/TimeInputType.cpp:

(WebCore::TimeInputType::dateType const):

• html/TimeInputType.h:
• html/WeekInputType.cpp:

(WebCore::WeekInputType::dateType const):

• html/WeekInputType.h:
• platform/DateComponents.cpp:

(WebCore::DateComponents::parseMonth):
(WebCore::DateComponents::parseDate):
(WebCore::DateComponents::parseWeek):
(WebCore::DateComponents::parseTime):
(WebCore::DateComponents::parseDateTimeLocal):
(WebCore::DateComponents::setMillisecondsSinceEpochForDate):
(WebCore::DateComponents::setMillisecondsSinceEpochForDateTimeLocal):
(WebCore::DateComponents::setMillisecondsSinceEpochForMonth):
(WebCore::DateComponents::setMillisecondsSinceMidnight):
(WebCore::DateComponents::setMonthsSinceEpoch):
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):
(WebCore::DateComponents::millisecondsSinceEpochForTime const):
(WebCore::DateComponents::millisecondsSinceEpoch const):
(WebCore::DateComponents::monthsSinceEpoch const):
(WebCore::DateComponents::toStringForTime const):
(WebCore::DateComponents::toString const):

• platform/DateComponents.h:

(WebCore::DateComponents::DateComponents):
(WebCore::DateComponents::type const):

• platform/text/PlatformLocale.cpp:

(WebCore::Locale::formatDateTime):

• platform/text/PlatformLocale.h:
• platform/text/cocoa/LocaleCocoa.mm:

(WebCore::LocaleCocoa::formatDateTime):

• platform/text/ios/LocalizedDateCache.h:
• platform/text/ios/LocalizedDateCache.mm:

(WebCore::LocalizedDateCache::formatterForDateType):
(WebCore::LocalizedDateCache::maximumWidthForDateType):
(WebCore::LocalizedDateCache::createFormatterForType):
(WebCore::LocalizedDateCache::calculateMaximumWidth):

8:29 AM Changeset in webkit [266113] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] media/controls/forced-tracks-only.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215808

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

8:07 AM Changeset in webkit [266112] by commit-queue@webkit.org

• 8 edits in trunk/Source

[SOUP] Initialize HSTS storage directory from network session initialization
​https://bugs.webkit.org/show_bug.cgi?id=215802

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2020-08-25
Reviewed by Alex Christensen.

Source/WebCore:

Stop handling HSTS persistent storage as a global setting. SoupNetworkSession::setHSTSPersistentStorage() is no
longer static and it does what setupHSTSEnforcer() did but simplified. The session is now always created with a
memory enforcer that is only replaced by a persistent one when setHSTSPersistentStorage() is called on
non-ephemeral sessions.

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setHSTSPersistentStorage):
(WebCore::SoupNetworkSession::getHostNamesWithHSTSCache):
(WebCore::SoupNetworkSession::deleteHSTSCacheForHostNames):
(WebCore::SoupNetworkSession::clearHSTSCache):
(WebCore::hstsStorageDirectory): Deleted.
(WebCore::SoupNetworkSession::setupHSTSEnforcer): Deleted.

• platform/network/soup/SoupNetworkSession.h:

Source/WebKit:

Instead of network process initialization, since it's not actually a global setting.

• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess): Remove code to initialize HSTS storage.

• NetworkProcess/soup/NetworkSessionSoup.cpp:

(WebKit::NetworkSessionSoup::NetworkSessionSoup): Call SoupNetworkSession::setHSTSPersistentStorage() if the
path is not mpety.

• UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextConstructed): Remove the ode to set the HSTS storage directory as process pool configuration.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess): Initialize hstsStorageDirectory in default network session parameters.

7:35 AM Changeset in webkit [266111] by Philippe Normand

• 2 edits in trunk/Source/WebCore

Unreviewed, follow-up to r266109

• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcAllocateBuffersAndRenderAudio): The element clock can be null so we need
to check it before attempting to use it.

1:46 AM Changeset in webkit [266110] by Paulo Matos

• 3 edits in trunk/JSTests

Skip failing tests on MIPS for later investigation

Unreviewed Gardening.

• stress/intl-segmenter.js:
• stress/typedarray-functions-with-neutered.js:

1:13 AM Changeset in webkit [266109] by Philippe Normand

• 4 edits in trunk/Source/WebCore

[GStreamer][WebAudio] Fill in output timestamps
​https://bugs.webkit.org/show_bug.cgi?id=215703

Reviewed by Xabier Rodriguez-Calvar.

Set the output timestamp as the buffer PTS. The monotonic timestamp is retrieved using the
corresponding GLib API, offset'ed by the pipeline clock time (which always starts at 0).

• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcAllocateBuffersAndRenderAudio):

• platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):
(WTF::refGPtr<GstClock>):
(WTF::derefGPtr<GstClock>):

• platform/graphics/gstreamer/GRefPtrGStreamer.h:

1:11 AM Changeset in webkit [266108] by Diego Pino Garcia

• 3 edits
  1 copy
  5 deletes in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Updated hybi baselines after r266057.

• platform/glib/http/tests/websocket/tests/hybi/close-and-server-script-exception-expected.txt: Renamed from LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-expected.txt.
• platform/glib/http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/extensions-expected.txt:
• platform/gtk/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt: Removed.
• platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt: Removed.
• platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt: Removed.
• platform/gtk/http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt: Removed.
• platform/wpe/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt: Removed.
• platform/wpe/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt: Removed.
• platform/wpe/http/tests/websocket/tests/hybi/close-on-unload-expected.txt: Removed.
• platform/wpe/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt: Removed.

1:06 AM Changeset in webkit [266107] by ysuzuki@apple.com

• 13 edits
  1 add in trunk/Source/JavaScriptCore

[JSC] Add concurrency-aware version of isCallable / isConstructor to make it usable in DFG compiler
​https://bugs.webkit.org/show_bug.cgi?id=215746

Reviewed by Saam Barati.

This patch adds isCallableWithConcurrency and isConstructorWithConcurrency to JSCell, JSValue etc.
This can work even if it is called from concurrent compiler threads. We also add jsTypeStringForValueWithConcurrency
and jsTypeofIsFunctionWithConcurrency which are using the above WithConcurrency functionalities.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• runtime/Concurrency.h: Added.

(WTF::printInternal):

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):
(JSC::InternalFunction::getCallData):
(JSC::InternalFunction::getConstructData):

• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::isCallableWithConcurrency const):
(JSC::JSValue::isConstructorWithConcurrency const):

• runtime/JSCell.h:
• runtime/JSCellInlines.h:

(JSC::JSCell::isCallableWithConcurrency):
(JSC::JSCell::isConstructorWithConcurrency):
(JSC::JSCell::isCallable):
(JSC::JSCell::isConstructor):

• runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::getConstructData):

• runtime/NumberPrototype.cpp:

(JSC::throwVMToThisNumberError):

• runtime/Operations.cpp:

(JSC::jsTypeStringForValueWithConcurrency):
(JSC::jsTypeStringForValue): Deleted.

• runtime/Operations.h:

(JSC::jsTypeofIsFunctionWithConcurrency):
(JSC::jsTypeStringForValue):
(JSC::jsTypeofIsFunction):

12:45 AM Changeset in webkit [266106] by Alexey Shvayka

• 13 edits
  1 add in trunk

Implementation of the class "extends" clause incorrectly uses proto for setting prototypes
​https://bugs.webkit.org/show_bug.cgi?id=205848

Reviewed by Keith Miller.

JSTests:

• microbenchmarks/class-derived-creation.js: Added.
• test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

To prevent class extends from breaking if Object.prototype.proto is overridden
or removed, this patch replaces OpPutById bytecodes in ClassExprNode::emitBytecode()
with JSObject::setPrototypeDirect() invocations via OpCall.

Since the spec sets Prototype? values directly [1], we are safe to skip method
table lookups and cycle checks.

Although this approach adds 4 mov ops to emitted bytecode for class extends creation,
increasing instruction count to 35, I prefer it over introducing a slow path only op.
To avoid emitting 2 extra mov ops, globalFuncSetPrototypeDirect() uses thisRegister().

Aligns JSC with V8 and SpiderMonkey. Derived class creation microbenchmark is neutral.

[1]: ​https://tc39.es/ecma262/#sec-createbuiltinfunction (step 7)

• builtins/BuiltinNames.h:
• bytecode/BytecodeDumper.cpp:

(JSC::CodeBlockBytecodeDumper<Block>::dumpConstants): Fix typo.

• bytecode/LinkTimeConstant.h:
• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitSetPrototypeOf):

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/NodesCodegen.cpp:

(JSC::ClassExprNode::emitBytecode):

• parser/Nodes.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

12:42 AM Changeset in webkit [266105] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Unreviewed. Fix GTK/WPE build after r266103

• inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):

12:01 AM Changeset in webkit [266104] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Reintroduce several WPT css-content failing tests removed in r266094.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:

Aug 24, 2020:

11:15 PM Changeset in webkit [266103] by Carlos Garcia Campos

• 6 edits in trunk/Source

[GTK] Implement rendering frames timeline panel for GTK+ port
​https://bugs.webkit.org/show_bug.cgi?id=150392
<rdar://problem/23200510>

Reviewed by Brian Burg.

Source/WebCore:

Use new RunLoop API to observe the run loop events when the GLib event loop is used.

• inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):

• inspector/agents/InspectorTimelineAgent.h:

Source/WTF:

Add API to observe RunLoop events for GLib event loop implementation.

• wtf/RunLoop.h:
• wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::RunLoop): Use RunLoopSource struct and initialize the RunLoop.
(WTF::RunLoop::observe): Add the given observer to the set.
(WTF::RunLoop::notify): Notife observers of the given event.
(WTF::RunLoop::TimerBase::TimerBase): Use RunLoopSource struct and initialize the RunLoop.

10:04 PM Changeset in webkit [266102] by achristensen@apple.com

• 2 edits in trunk/Tools

Fix TLSVersion.DefaultBehavior on Mojave
​https://bugs.webkit.org/show_bug.cgi?id=215791

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

HTTPServer::Protocol::HttpsWithLegacyTLS uses tls_protocol_version_t, so this test times out on Mojave.
Enable it for newer OSes.

9:32 PM Changeset in webkit [266101] by keith_miller@apple.com

• 4 edits in trunk/Source/JavaScriptCore

DFG should always run CFG Simplification after Constant Folding.
​https://bugs.webkit.org/show_bug.cgi?id=215286

Reviewed by Robin Morisset.

We didn't do this originally because LICM, many years ago, was
unsound if the CFG didn't have exactly the right shape around
loops. This is no longer true so we don't have to worry about
changing the CFG anymore. While, this doesn't appear to be a
speedup on JetStream 2 CFG, probably because we'd eventually
simplify the graph in B3, CFG Simplification is very cheap and
make other DFG optimizations easier in the future.

Also, remove unecessary validation rule that no exitOKs can come
before any Phi nodes in DFG. This isn't required and fails after
merging two basic blocks where the latter block has a Phi.

• dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

• dfg/DFGValidate.cpp:

8:36 PM Changeset in webkit [266100] by commit-queue@webkit.org

• 4 edits in trunk/Tools

Make TLSVersion.DefaultBehavior more robust
​https://bugs.webkit.org/show_bug.cgi?id=215791

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-24
Reviewed by Darin Adler.

After r265573 sometimes it would assert, which is not a problem because it was failing the first connection
then succeeding the second connection as intended and as happens in the real internet.
Use HTTPServer which accepts a variable number of connections to keep the test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/cocoa/HTTPServer.h:
• TestWebKitAPI/cocoa/HTTPServer.mm:

(TestWebKitAPI::HTTPServer::respondWithChallengeThenOK):
(TestWebKitAPI::HTTPServer::respondWithOK):

7:44 PM Changeset in webkit [266099] by beidson@apple.com

• 2 edits in trunk/Source/WebKit

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::PDFPlugin::createScrollbar
<rdar://problem/67473335> and ​https://bugs.webkit.org/show_bug.cgi?id=215787

Reviewed by Tim Horton.

To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.

This is a speculative fix due to the aforementioned reproducibility issue.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel): Check on the main thread whenever this is called,

instead of when deciding to dispatch to the main thread.

(WebKit::PDFPlugin::threadEntry): We can't do this check on the background thread when considering the dispatch

to the main thread, as the flag might've changed by then. Let's *just* check it on the main thread.

(WebKit::PDFPlugin::adoptBackgroundThreadDocument): We can't do the check on the background thread when
(WebKit::PDFPlugin::updateScrollbars): This is where the crash itself is. All of the Obj-C code in here is

safe to do after destroy(), up until the very end when we get into pluginView() derefencing.
So it seems prudent to add another check here.

(WebKit::PDFPlugin::documentDataDidFinishLoading): In addition to receivedNonLinearizedPDFSentinel and

adoptBackgroundThreadDocument, this is the final of the (3) calls that end up calling installPDFDocument,
so for added coverage it seems like a prudent place to add the check.

7:03 PM Changeset in webkit [266098] by achristensen@apple.com

• 2 edits in trunk/LayoutTests/imported/w3c

Update iOS layout test results after r266087
​https://bugs.webkit.org/show_bug.cgi?id=215671

• web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker-expected.txt:

Apparently there's a newly passing test here, too.
I wonder why macOS isn't affected by this change.

7:00 PM Changeset in webkit [266097] by mmaxfield@apple.com

• 2 edits in trunk/LayoutTests

[macOS Big Sur] svg/W3C-I18N/tspan-direction-rtl.svg is failing
<rdar://problem/66861801>

Unreviewed test gardening.

platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed property svn:keywords.

6:53 PM Changeset in webkit [266096] by mmaxfield@apple.com

• 1 edit in trunk/LayoutTests/ChangeLog

[macOS Big Sur] svg/W3C-I18N/tspan-direction-rtl.svg is failing
<rdar://problem/66861801>

Unreviewed test gardening.

• platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed property svn:keywords.

6:51 PM Changeset in webkit [266095] by keith_miller@apple.com

• 22 edits
  2 deletes in trunk/Source/JavaScriptCore

Remove MovHintRemoval phase
​https://bugs.webkit.org/show_bug.cgi?id=215785

Reviewed by Saam Barati.

The MovHintRemoval phase doesn't play nicely with our OSR
Availability. Specifically, it needs to do a tricky dance where it
marks all the live ranges of the ZombieHints as not
exitOK. There's also an issue because we treated unused locals as
kill in this block, which is wrong for SSA when a MovHint is
used in another block. Since removing MovHintRemoval isn't a
performance regression, we are removing it rather than fixing bugs
related to it. Relatedly, since the only place we produce
ZombieHints is MovHintRemoval this patch also removes that node
type.

• Sources.txt:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGClobbersExitState.cpp:

(JSC::DFG::clobbersExitState):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGMayExit.cpp:
• dfg/DFGMovHintRemovalPhase.cpp: Removed.
• dfg/DFGMovHintRemovalPhase.h: Removed.
• dfg/DFGNode.h:

(JSC::DFG::Node::containsMovHint):
(JSC::DFG::Node::hasUnlinkedOperand):

• dfg/DFGNodeType.h:
• dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

• dfg/DFGPhantomInsertionPhase.cpp:
• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileMovHint):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGVarargsForwardingPhase.cpp:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::validateAIState):
(JSC::FTL::DFG::LowerDFGToB3::compileNode):

• runtime/OptionsList.h:

5:36 PM Changeset in webkit [266094] by Hector Lopez

• 5 edits in trunk/LayoutTests

[ macOS ] Tests expectations changed as test passing but expected to fail
​https://bugs.webkit.org/show_bug.cgi?id=215786

Unreviewed test gardening.

• TestExpectations:
• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:

5:26 PM Changeset in webkit [266093] by Alan Coon

• 8 edits in branches/safari-610.1.28.0-branch/Source

Versioning.

WebKit-7610.1.28.0.3

5:14 PM Changeset in webkit [266092] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://67706887 (REGRESSION (r264950): [ iOS 13 WK2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure)

Unreviewed test gardening.

• platform/ios-13/TestExpectations:

5:05 PM Changeset in webkit [266091] by keith_miller@apple.com

• 5 edits
  11 adds in trunk/JSTests

Update test262 (mid Aug 2020 edition)
​https://bugs.webkit.org/show_bug.cgi?id=215784

Rubber-stamped by Saam Barati and Yusuke Suzuki.

• test262/expectations.yaml:
• test262/latest-changes-summary.txt:
• test262/test/built-ins/String/prototype/split/limit-touint32-error.js: Added.

(ExpectedError):
(ExpectedError.prototype.toString):
(nonStringableSeparator.Symbol.toPrimitive):
(nonStringableSeparator.toString):
(nonStringableSeparator.valueOf):
(nonNumberableLimit.Symbol.toPrimitive):

• test262/test/built-ins/String/prototype/split/separator-tostring-error.js: Added.

(ExpectedError):
(ExpectedError.prototype.toString):
(nonStringableSeparator.toString):

• test262/test/built-ins/String/prototype/split/separator-undef-limit-zero.js:
• test262/test/built-ins/String/prototype/split/this-value-tostring-error.js: Added.

(ExpectedError):
(ExpectedError.prototype.toString):
(nonStringableReceiver.toString):
(splitter.Symbol.split):
(catch):
(nonStringableSeparator.Symbol.toPrimitive):
(nonStringableSeparator.toString):
(nonStringableSeparator.valueOf):

• test262/test/language/module-code/export-default-asyncfunction-declaration-binding-exists.js: Added.

(A):
(export.default.async A):

• test262/test/language/module-code/export-default-asyncfunction-declaration-binding.js: Added.

(export.default.async A):

• test262/test/language/module-code/export-default-asyncgenerator-declaration-binding-exists.js: Added.

(AG):
(export.default.async AG):

• test262/test/language/module-code/export-default-asyncgenerator-declaration-binding.js: Added.

(export.default.async AG):

• test262/test/language/module-code/export-default-function-declaration-binding-exists.js: Added.

(F):
(export.default.F):

• test262/test/language/module-code/export-default-function-declaration-binding.js: Added.

(export.default.F):

• test262/test/language/module-code/export-default-generator-declaration-binding-exists.js: Added.

(G):
(export.default.G):

• test262/test/language/module-code/export-default-generator-declaration-binding.js: Added.

(export.default.G):

• test262/test262-Revision.txt:

3:48 PM Changeset in webkit [266090] by Wenson Hsieh

• 4 edits in trunk

Unreviewed, fix the internal iOS 13.4 build

Source/WebKit:

The -_selectionClipRect SPI method isn't declared in any private headers on iOS 13.4 and prior. This isn't a
problem when building with a non-internal SDK since the SPI is declared in the !USE(APPLE_INTERNAL_SDK)
section in UIKitSPI.h, but on internal builds of iOS 13.4, this declaration is absent from both the internal
SDK and UIKitSPI.h.

To fix the build, simply declare it in the IPI section — once we stop supporting iOS 13.4 as a build target,
this can be moved back into the non-internal section only.

• Platform/spi/ios/UIKitSPI.h:

Tools:

See Source/WebKit/ChangeLog.

• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::clipSelectionViewRectToContentView):

3:46 PM Changeset in webkit [266089] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews] enable email notifications to patch authors for build or layout test failures on their patch
​https://bugs.webkit.org/show_bug.cgi?id=215776

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.analyzeResults): Send email notification to patch authors for build failure due to their patch.
(AnalyzeLayoutTestsResults.report_failure): Send email notification to patch authors for layout test failure.

3:45 PM Changeset in webkit [266088] by aakash_jain@apple.com

• 3 edits in trunk/Tools

[ews] set references header in email so as to group similar emails together
​https://bugs.webkit.org/show_bug.cgi?id=215777

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/send_email.py:

(send_email): Add support for setting references header.
(send_email_to_patch_author):
(send_email_to_bot_watchers):

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Set references header appropriately.
(ReRunWebKitTests.send_email_for_flaky_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_flaky_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_pre_existing_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.

3:36 PM Changeset in webkit [266087] by commit-queue@webkit.org

• 34 edits in trunk

Implement Request/Response consuming as FormData
​https://bugs.webkit.org/show_bug.cgi?id=215671

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-24
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/abort/general.any-expected.txt:
• web-platform-tests/fetch/api/abort/general.any.worker-expected.txt:
• web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:

This remaining failing test now fails similarly in all browsers.

• web-platform-tests/fetch/api/request/request-consume-expected.txt:
• web-platform-tests/fetch/api/request/request-init-002-expected.txt:
• web-platform-tests/fetch/api/response/response-consume-empty-expected.txt:

This remaining failing test now fails similarly in all browsers.

• web-platform-tests/fetch/api/response/response-consume-expected.txt:
• web-platform-tests/fetch/api/response/response-error-from-stream-expected.txt:

This change makes the formData failures in this file look like all the other failures in this file,
which should be fixed together in a separate patch.

• web-platform-tests/fetch/api/response/response-init-002-expected.txt:
• web-platform-tests/url/urlencoded-parser.any-expected.txt:
• web-platform-tests/url/urlencoded-parser.any.worker-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https-expected.txt:

Source/WebCore:

Covered by many newly passing WPT tests, for most of which Safari was the only failing browser.

• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::formData):
(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeFormData):

• Modules/fetch/FetchBody.h:
• Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::formDataFromData):
(WebCore::resolveWithTypeAndData):
(WebCore::FetchBodyConsumer::resolve):

• Modules/fetch/FetchBodyConsumer.h:

Source/WebKit:

• WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:

(WebKit::WebServiceWorkerFetchTaskClient::didReceiveFormDataAndFinish):
Add a fast path that allows non-blob FormData responses from service workers to not hang.
This part is covered by this layout test:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https.html

Source/WTF:

In order to be compatible with other browsers, we need a verson of String::fromUTF8 that
uses U8_NEXT_OR_FFFD instead of U8_NEXT, but changing that across the board will break other things.
Leave everything else as it is, use templates and constexpr to not add any branches, but add
String::fromUTF8ReplacingInvalidSequences to allow me to make our FormData consuming compatible with other browsers.

• wtf/text/WTFString.cpp:

(WTF::fromUTF8Helper):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8ReplacingInvalidSequences):

• wtf/text/WTFString.h:
• wtf/unicode/UTF8Conversion.cpp:

(WTF::Unicode::convertUTF8ToUTF16Impl):
(WTF::Unicode::convertUTF8ToUTF16):
(WTF::Unicode::convertUTF8ToUTF16ReplacingInvalidSequences):

• wtf/unicode/UTF8Conversion.h:

2:41 PM Changeset in webkit [266086] by commit-queue@webkit.org

• 24 edits in trunk/Source

Make _WKWebsiteDataStoreConfiguration SPI for HSTS storage to replace _WKProcessPoolConfiguration.hstsStorageDirectory
​https://bugs.webkit.org/show_bug.cgi?id=213048

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-24
Reviewed by Youenn Fablet.

Source/WebCore/PAL:

• pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

This uses CFNetwork SPI introduced in rdar://problem/50109631 to allow HSTS storage per NSURLSession.
To be complete, I also deprecated our UI process HSTS state removal attempt SPIs, WKContextResetHSTSHosts and
WKContextResetHSTSHostsAddedAfterDate, which had their last use removed in rdar://problem/64220838.

I manually verified that this new SPI puts HSTS data in the specified location, and I also verified that HSTS
state querying and removal works with the new CFNetwork SPI as it did with the old one.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkSessionCreationParameters.cpp:

(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):

• NetworkProcess/NetworkSessionCreationParameters.h:
• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::hostNamesWithHSTSCache const):
(WebKit::NetworkProcess::deleteHSTSCacheForHostNames):
(WebKit::NetworkProcess::clearHSTSCache):
(WebKit::NetworkProcess::getHostNamesWithHSTSCache): Deleted.

• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::hstsStorage const):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::hostNamesWithHSTSCache const):
(WebKit::NetworkProcess::deleteHSTSCacheForHostNames):
(WebKit::NetworkProcess::clearHSTSCache):
(WebKit::NetworkProcess::getHostNamesWithHSTSCache): Deleted.

• UIProcess/API/C/mac/WKContextPrivateMac.h:
• UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextResetHSTSHosts):
(WKContextResetHSTSHostsAddedAfterDate):

• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
• UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
• UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:

(-[_WKWebsiteDataStoreConfiguration hstsStorageDirectory]):
(-[_WKWebsiteDataStoreConfiguration setHSTSStorageDirectory:]):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::privateBrowsingSession): Deleted.
(WebKit::WebProcessPool::resetHSTSHosts): Deleted.
(WebKit::WebProcessPool::resetHSTSHostsAddedAfterDate): Deleted.

• UIProcess/WebProcessPool.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
(WebKit::WebsiteDataStore::parameters):

• UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::resolvedHSTSStorageDirectory const):

• UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:

(WebKit::WebsiteDataStoreConfiguration::copy const):

• UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:

Source/WTF:

• wtf/PlatformHave.h:

2:35 PM Changeset in webkit [266085] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ iOS wk2 Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-iframe-fetch-error-external-module.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215783

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

2:06 PM Changeset in webkit [266084] by Jon Davis

• 2 edits in trunk/Websites/webkit.org

Disable unused RPC services
​https://bugs.webkit.org/show_bug.cgi?id=215779

Reviewed by Alexey Proskuryakov.

• .htaccess:

12:26 PM Changeset in webkit [266083] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk1 ] fast/overflow/horizontal-scroll-after-back.html is a flaky timeout

​https://bugs.webkit.org/show_bug.cgi?id=215778

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

12:17 PM Changeset in webkit [266082] by emilio

• 12 edits in trunk

Support quotes:auto and fix quotes serialization.
​https://bugs.webkit.org/show_bug.cgi?id=215646

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-content/inheritance-expected.txt: Annotate progression.
• web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto.

Source/WebCore:

Tests: imported/w3c/web-platform-tests/css/css-content/inheritance.html

imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::Ref<CSSValue>valueForQuotes):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeQuotes):

• rendering/style/QuotesData.h:

(WebCore::QuotesData::size const):

• style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertQuotes):

LayoutTests:

• platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Annotate progression.
• platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto.
• platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto.

11:57 AM Changeset in webkit [266081] by Russell Epstein

• 8 edits in trunk/Source

Versioning.

WebKit-7611.1.1

11:53 AM Changeset in webkit [266080] by Jonathan Bedard

• 4 edits in trunk/Tools

[resultsdbpy] Fix pip package
​https://bugs.webkit.org/show_bug.cgi?id=215721
<rdar://problem/67518275>

Reviewed by Dewei Zhu.

• Scripts/libraries/resultsdbpy/MANIFEST.in: Add html and css.
• Scripts/libraries/resultsdbpy/resultsdbpy/init.py: Include submodules.
• Scripts/libraries/resultsdbpy/setup.py: Version bump.

11:44 AM Changeset in webkit [266079] by Russell Epstein

• 1 copy in branches/safari-610-branch

New branch.

11:44 AM Changeset in webkit [266078] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Release ] http/tests/workers/service/basic-install-event-waitUntil-reject.html is a flaky timeout

​https://bugs.webkit.org/show_bug.cgi?id=214997

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

11:40 AM Changeset in webkit [266077] by Devin Rousso

• 27 edits
  7 moves in trunk/Source

Web Inspector: rename ScriptDebugServer subclasses/methods
​https://bugs.webkit.org/show_bug.cgi?id=215363
<rdar://problem/67310441>

Reviewed by Brian Burg.

r266074 merged Inspector::ScriptDebugServer into JSC::Debugger. All subclasses and
functions should be renamed to match this change.

Source/JavaScriptCore:

• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• inspector/InspectorEnvironment.h:
• inspector/JSGlobalObjectDebugger.h: Renamed from Source/JavaScriptCore/inspector/JSGlobalObjectScriptDebugServer.h.
• inspector/JSGlobalObjectDebugger.cpp: Renamed from Source/JavaScriptCore/inspector/JSGlobalObjectScriptDebugServer.cpp.
• inspector/JSGlobalObjectInspectorController.h:
• inspector/JSGlobalObjectInspectorController.cpp:
• inspector/agents/InspectorAuditAgent.h:
• inspector/agents/InspectorAuditAgent.cpp:
• inspector/agents/InspectorDebuggerAgent.h:
• inspector/agents/InspectorDebuggerAgent.cpp:
• inspector/agents/InspectorRuntimeAgent.h:
• inspector/agents/InspectorRuntimeAgent.cpp:
• inspector/agents/InspectorScriptProfilerAgent.cpp:
• inspector/agents/JSGlobalObjectDebuggerAgent.cpp:
• inspector/remote/RemoteInspectionTarget.cpp:
• inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:

Source/WebCore:

• Headers.cmake:
• Sources.txt:
• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• inspector/InspectorController.h:
• inspector/InspectorController.cpp:
• inspector/PageDebugger.h: Renamed from Source/WebCore/inspector/PageScriptDebugServer.h.
• inspector/PageDebugger.cpp: Renamed from Source/WebCore/inspector/PageScriptDebugServer.cpp.
• inspector/mac/PageDebuggerMac.mm: Renamed from Source/WebCore/inspector/mac/PageScriptDebugServerMac.mm.
• inspector/WorkerDebugger.h: Renamed from Source/WebCore/inspector/WorkerScriptDebugServer.h.
• inspector/WorkerDebugger.cpp: Renamed from Source/WebCore/inspector/WorkerScriptDebugServer.cpp.
• inspector/WorkerInspectorController.h:
• inspector/WorkerInspectorController.cpp:
• inspector/agents/InspectorTimelineAgent.cpp:
• inspector/agents/page/PageDebuggerAgent.cpp:

11:13 AM Changeset in webkit [266076] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: remove legacy code for replacing the Resources Tab and Debugger Tab with the Sources Tab
​https://bugs.webkit.org/show_bug.cgi?id=205826

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WI.loaded):

11:06 AM Changeset in webkit [266075] by sihui_liu@apple.com

• 4 edits in trunk

Source/WebCore:
Text manipulation should not manipulate nodes out of paragraph range
​https://bugs.webkit.org/show_bug.cgi?id=215406

Reviewed by Wenson Hsieh.

TextManipulationController currently does not set correct start path for insertion. Therefore, it does not mark
the nodes on the start path but out of range correctly, and may change position of those nodes by mistake. For
example, in the newly added test, text node "zero" can be moved around even though it is not in range.

API test: TextManipulation.CompleteTextManipulationShouldOnlyChangeNodesInParagraphRange

• editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::replace):

Tools:
Text manipulationshould not manipulate nodes out of paragraph range
​https://bugs.webkit.org/show_bug.cgi?id=215406

Reviewed by Wenson Hsieh.

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

10:34 AM Changeset in webkit [266074] by Devin Rousso

• 107 edits
  1 copy
  3 adds
  4 deletes in trunk

Web Inspector: allow event breakpoints to be configured
​https://bugs.webkit.org/show_bug.cgi?id=215362
<rdar://problem/66932921>

Reviewed by Brian Burg.

Source/JavaScriptCore:

This allows developers to do things like:

• only pause when window.event.type is a certain value
• ignore the first N pauses
• evaluate JavaScript whenever an event listener is invoked without pausing

• inspector/protocol/DOM.json:

Add an options paramater to DOM.setBreakpointForEventListener to allow configuration.

• inspector/protocol/DOMDebugger.json:

Add an options paramater to DOMDebugger.setEventBreakpoint to allow configuration.

• debugger/Breakpoint.h:

(JSC::Breakpoint::id const): Added.
(JSC::Breakpoint::sourceID const): Added.
(JSC::Breakpoint::lineNumber const): Added.
(JSC::Breakpoint::columnNumber const): Added.
(JSC::Breakpoint::condition const): Added.
(JSC::Breakpoint::actions const): Added.
(JSC::Breakpoint::isAutoContinue const): Added.
(JSC::Breakpoint::resetHitCount): Added.
(JSC::Breakpoint::isLinked const): Added.
(JSC::Breakpoint::isResolved const): Added.
(JSC::BreakpointsList::~BreakpointsList): Deleted.

• debugger/Breakpoint.cpp: Added.

(JSC::Breakpoint::Action::Action): Added.
(JSC::Breakpoint::create): Added.
(JSC::Breakpoint::Breakpoint): Added.
(JSC::Breakpoint::link): Added.
(JSC::Breakpoint::resolve): Added.
(JSC::Breakpoint::shouldPause): Added.
Unify JSC::Breakpoint and Inspector::ScriptBreakpoint.

• debugger/DebuggerPrimitives.h:
• debugger/Debugger.h:
• debugger/Debugger.cpp:

(JSC::Debugger::Debugger):
(JSC::Debugger::addObserver): Added.
(JSC::Debugger::removeObserver): Added.
(JSC::Debugger::canDispatchFunctionToObservers const): Added.
(JSC::Debugger::dispatchFunctionToObservers): Added.
(JSC::Debugger::sourceParsed): Added.
(JSC::Debugger::toggleBreakpoint):
(JSC::Debugger::applyBreakpoints):
(JSC::Debugger::resolveBreakpoint):
(JSC::Debugger::setBreakpoint):
(JSC::Debugger::removeBreakpoint):
(JSC::Debugger::didHitBreakpoint): Added.
(JSC::Debugger::clearBreakpoints):
(JSC::Debugger::evaluateBreakpointCondition): Added.
(JSC::Debugger::evaluateBreakpointActions): Added.
(JSC::Debugger::schedulePauseAtNextOpportunity): Added.
(JSC::Debugger::cancelPauseAtNextOpportunity): Added.
(JSC::Debugger::schedulePauseForSpecialBreakpoint): Added.
(JSC::Debugger::cancelPauseForSpecialBreakpoint): Added.
(JSC::Debugger::continueProgram):
(JSC::Debugger::stepNextExpression):
(JSC::Debugger::stepIntoStatement):
(JSC::Debugger::stepOverStatement):
(JSC::Debugger::stepOutOfFunction):
(JSC::Debugger::pauseIfNeeded):
(JSC::Debugger::handlePause): Added.
(JSC::Debugger::exceptionOrCaughtValue): Added.
(JSC::Debugger::atExpression):
(JSC::Debugger::clearNextPauseState):
(JSC::Debugger::willRunMicrotask): Added.
(JSC::Debugger::didRunMicrotask): Added.
(JSC::Debugger::hasBreakpoint): Deleted.
(JSC::Debugger::setPauseOnNextStatement): Deleted.
Unify JSC::Debugger and Inspector::ScriptDebugServer to simplify breakpoint logic.
Introduce the concept of a "special breakpoint", which is essentially a JSC::Breakpoint
that is expected to pause at the next opportunity but isn't tied to a particular location.
As an example, whenever an event breakpoint is hit, instead of just pausing at the next
opportunity, the newly managed JSC::Breakpoint is used as a "special breakpoint", allowing
for it's configuration (ie.g. condition, ignore count, actions, auto-continue) to be used.

• inspector/agents/InspectorDebuggerAgent.h:
• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::objectGroupForBreakpointAction):
(Inspector::breakpointActionTypeForString): Added.
(Inspector::parseBreakpointOptions): Added.
(Inspector::InspectorDebuggerAgent::ProtocolBreakpoint::fromPayload): Added.
(Inspector::InspectorDebuggerAgent::ProtocolBreakpoint::ProtocolBreakpoint): Added.
(Inspector::InspectorDebuggerAgent::ProtocolBreakpoint::createDebuggerBreakpoint const): Added.
(Inspector::InspectorDebuggerAgent::ProtocolBreakpoint::matchesScriptURL const): Added.
(Inspector::InspectorDebuggerAgent::debuggerBreakpointFromPayload): Added.
(Inspector::InspectorDebuggerAgent::enable):
(Inspector::InspectorDebuggerAgent::disable):
(Inspector::InspectorDebuggerAgent::buildBreakpointPauseReason):
(Inspector::InspectorDebuggerAgent::handleConsoleAssert):
(Inspector::InspectorDebuggerAgent::didScheduleAsyncCall):
(Inspector::buildDebuggerLocation):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::didSetBreakpoint):
(Inspector::InspectorDebuggerAgent::resolveBreakpoint):
(Inspector::InspectorDebuggerAgent::removeBreakpoint):
(Inspector::InspectorDebuggerAgent::continueToLocation):
(Inspector::InspectorDebuggerAgent::schedulePauseAtNextOpportunity): Added.
(Inspector::InspectorDebuggerAgent::cancelPauseAtNextOpportunity): Added.
(Inspector::InspectorDebuggerAgent::schedulePauseForSpecialBreakpoint): Added.
(Inspector::InspectorDebuggerAgent::cancelPauseForSpecialBreakpoint): Added.
(Inspector::InspectorDebuggerAgent::pause):
(Inspector::InspectorDebuggerAgent::resume):
(Inspector::InspectorDebuggerAgent::didBecomeIdle):
(Inspector::InspectorDebuggerAgent::sourceMapURLForScript):
(Inspector::InspectorDebuggerAgent::didParseSource):
(Inspector::InspectorDebuggerAgent::willRunMicrotask):
(Inspector::InspectorDebuggerAgent::didRunMicrotask):
(Inspector::InspectorDebuggerAgent::didPause):
(Inspector::InspectorDebuggerAgent::breakpointActionSound):
(Inspector::InspectorDebuggerAgent::breakpointActionProbe):
(Inspector::InspectorDebuggerAgent::clearInspectorBreakpointState):
(Inspector::InspectorDebuggerAgent::clearDebuggerBreakpointState):
(Inspector::matches): Deleted.
(Inspector::buildObjectForBreakpointCookie): Deleted.
(Inspector::InspectorDebuggerAgent::breakpointActionsFromProtocol): Deleted.
(Inspector::InspectorDebuggerAgent::schedulePauseOnNextStatement): Deleted.
(Inspector::InspectorDebuggerAgent::cancelPauseOnNextStatement): Deleted.
Create a private ProtocolBreakpoint class that holds the data sent by the frontend. This
is necessary because breakpoints in the frontend have a potentially one-to-many relationship
with breakpoints in the backend, as the same script can be loaded many times on a page. Each
of those scripts is independent, however, and can execute differently, meaning that the same
breakpoint for each script also needs a different state (e.g. ignore count). As such, the
ProtocolBreakpoint is effectively a template that is actualized whenever a new script is
parsed that matches the URL of the ProtocolBreakpoint to create a JSC::Breakpoint that
is used by the JSC::Debugger. ProtocolBreakpoint also parses breakpoint configurations.

• inspector/InspectorEnvironment.h:
• inspector/JSGlobalObjectScriptDebugServer.h:
• inspector/JSGlobalObjectScriptDebugServer.cpp:

(Inspector::JSGlobalObjectScriptDebugServer::JSGlobalObjectScriptDebugServer):
(Inspector::JSGlobalObjectScriptDebugServer::attachDebugger):
(Inspector::JSGlobalObjectScriptDebugServer::detachDebugger):
(Inspector::JSGlobalObjectScriptDebugServer::runEventLoopWhilePaused):

• inspector/agents/InspectorAuditAgent.h:
• inspector/agents/InspectorAuditAgent.cpp:

(Inspector::InspectorAuditAgent::run):

• inspector/agents/InspectorRuntimeAgent.h:
• inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::setPauseOnExceptionsState):
(Inspector::InspectorRuntimeAgent::evaluate):
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::getPreview):
(Inspector::InspectorRuntimeAgent::getProperties):
(Inspector::InspectorRuntimeAgent::getDisplayableProperties):

• inspector/agents/InspectorScriptProfilerAgent.cpp:
• inspector/agents/JSGlobalObjectDebuggerAgent.h:

Replace Inspector::ScriptDebugServer with JSC::Debugger.

• runtime/JSMicrotask.cpp:

(JSC::JSMicrotask::run):
Drive-by: r248894 mistakenly omitted the call to notify the debugger that the microtask ran.

• inspector/ScriptBreakpoint.h: Removed.
• inspector/ScriptDebugListener.h: Removed.
• inspector/ScriptDebugServer.h: Removed.
• inspector/ScriptDebugServer.cpp: Removed.
• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:

Source/WebCore:

This allows developers to do things like:

• only pause when window.event.type is a certain value
• ignore the first N pauses
• evaluate JavaScript whenever an event listener is invoked without pausing

Tests: inspector/dom/breakpoint-for-event-listener.html

inspector/dom-debugger/event-animation-frame-breakpoints.html
inspector/dom-debugger/event-interval-breakpoints.html
inspector/dom-debugger/event-listener-breakpoints.html
inspector/dom-debugger/event-timeout-breakpoints.html

• inspector/agents/InspectorDOMAgent.h:
• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::setBreakpointForEventListener):
(WebCore::InspectorDOMAgent::removeBreakpointForEventListener):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
(WebCore::InspectorDOMAgent::breakpointForEventListener):
(WebCore::InspectorDOMAgent::hasBreakpointForEventListener): Deleted.

• inspector/agents/InspectorDOMDebuggerAgent.h:
• inspector/agents/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::disable):
(WebCore::InspectorDOMDebuggerAgent::mainFrameNavigated):
(WebCore::InspectorDOMDebuggerAgent::setEventBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willHandleEvent):
(WebCore::InspectorDOMDebuggerAgent::didHandleEvent):
(WebCore::InspectorDOMDebuggerAgent::willFireTimer):
(WebCore::InspectorDOMDebuggerAgent::didFireTimer):

• inspector/agents/page/PageDOMDebuggerAgent.h:
• inspector/agents/page/PageDOMDebuggerAgent.cpp:

(WebCore::PageDOMDebuggerAgent::disable):
(WebCore::PageDOMDebuggerAgent::mainFrameNavigated):
(WebCore::PageDOMDebuggerAgent::willFireAnimationFrame):
(WebCore::PageDOMDebuggerAgent::didFireAnimationFrame):
(WebCore::PageDOMDebuggerAgent::setAnimationFrameBreakpoint):

• inspector/agents/worker/WorkerDOMDebuggerAgent.h:
• inspector/agents/worker/WorkerDOMDebuggerAgent.cpp:

(WebCore::WorkerDOMDebuggerAgent::setAnimationFrameBreakpoint):
Keep a JSC::Breakpoint for each event breakpoint instead of a simple bool, allowing for
configuration when the breakpoint is first set. When any of these breakpoints are hit, pass
it to the JSC::Debugger as a "special breakpoint", which behaves the same as "pause ASAP"
but also supports a condition, an ignore count, actions, and auto-continue. Reset the hit
count for any of these "special breakpoints" that persist across Web Inspector sessions
when the main frame navigates.

• inspector/PageScriptDebugServer.h:
• inspector/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::PageScriptDebugServer):
(WebCore::PageScriptDebugServer::attachDebugger):
(WebCore::PageScriptDebugServer::detachDebugger):
(WebCore::PageScriptDebugServer::didPause):
(WebCore::PageScriptDebugServer::didContinue):
(WebCore::PageScriptDebugServer::runEventLoopWhilePaused):
(WebCore::PageScriptDebugServer::runEventLoopWhilePausedInternal):
(WebCore::PageScriptDebugServer::isContentScript const):
(WebCore::PageScriptDebugServer::reportException const):

• inspector/WorkerScriptDebugServer.h:
• inspector/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::attachDebugger):
(WebCore::WorkerScriptDebugServer::detachDebugger):
(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):
(WebCore::WorkerScriptDebugServer::reportException const):

• inspector/agents/page/PageDebuggerAgent.h:
• inspector/agents/page/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::sourceMapURLForScript):
Replace Inspector::ScriptDebugServer with JSC::Debugger.

• inspector/TimelineRecordFactory.h:
• inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createProbeSampleData):

• inspector/agents/InspectorTimelineAgent.h:
• inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::breakpointActionProbe):
Replace Inspector::ScriptBreakpoint with JSC::Breakpoint.

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didHandleEvent):
(WebCore::InspectorInstrumentation::didFireTimer):

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didHandleEventImpl):
(WebCore::InspectorInstrumentation::didFireTimerImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didFireAnimationFrameImpl):

• dom/EventTarget.cpp:

(WebCore::EventTarget::innerInvokeEventListeners):

• page/DOMTimer.cpp:

(WebCore::DOMTimer::fired):
When notifying Web Inspector that activity did occur, include all information previously
included when notifying Web Inspector that that activity was about to occur so that Web
Inspector can know whether a pause for the "special breakpoint" for that activity is still
scheduled and if so cancel it.

Source/WebInspectorUI:

This allows developers to do things like:

• only pause when window.event.type is a certain value
• ignore the first N pauses
• evaluate JavaScript whenever an event listener is invoked without pausing

• UserInterface/Models/Breakpoint.js:

(WI.Breakpoint):
(WI.Breakpoint.prototype.toJSON):
(WI.Breakpoint.prototype.get special): Added.
(WI.Breakpoint.prototype.get removable): Added.
(WI.Breakpoint.prototype.get editable): Added.
(WI.Breakpoint.prototype.set condition):
(WI.Breakpoint.prototype.get ignoreCount):
(WI.Breakpoint.prototype.set ignoreCount):
(WI.Breakpoint.prototype.get autoContinue):
(WI.Breakpoint.prototype.set autoContinue):
(WI.Breakpoint.prototype.get actions):
(WI.Breakpoint.prototype.get probeActions):
(WI.Breakpoint.prototype.cycleToNextMode):
(WI.Breakpoint.prototype.createAction):
(WI.Breakpoint.prototype.recreateAction):
(WI.Breakpoint.prototype.removeAction):
(WI.Breakpoint.prototype.clearActions):
(WI.Breakpoint.prototype.remove): Added.
(WI.Breakpoint.prototype.optionsToProtocol): Added.
(WI.Breakpoint.prototype.breakpointActionDidChange):
(WI.Breakpoint.fromJSON): Deleted.
(WI.Breakpoint.prototype.get sourceCodeLocation): Deleted.
(WI.Breakpoint.prototype.get contentIdentifier): Deleted.
(WI.Breakpoint.prototype.get scriptIdentifier): Deleted.
(WI.Breakpoint.prototype.get target): Deleted.
(WI.Breakpoint.prototype.get identifier): Deleted.
(WI.Breakpoint.prototype.set identifier): Deleted.
(WI.Breakpoint.prototype.get resolved): Deleted.
(WI.Breakpoint.prototype.set resolved): Deleted.
(WI.Breakpoint.prototype.saveIdentityToCookie): Deleted.
(WI.Breakpoint.prototype._isSpecial): Deleted.
(WI.Breakpoint.prototype._sourceCodeLocationLocationChanged): Deleted.
(WI.Breakpoint.prototype._sourceCodeLocationDisplayLocationChanged): Deleted.

• UserInterface/Models/DOMBreakpoint.js:

(WI.DOMBreakpoint):
(WI.DOMBreakpoint.fromJSON): Added.
(WI.DOMBreakpoint.prototype.remove): Added.
(WI.DOMBreakpoint.prototype.toJSON):
(WI.DOMBreakpoint.deserialize): Deleted.
(WI.DOMBreakpoint.prototype.get disabled): Deleted.
(WI.DOMBreakpoint.prototype.set disabled): Deleted.

• UserInterface/Models/EventBreakpoint.js:

(WI.EventBreakpoint):
(WI.EventBreakpoint.fromJSON): Added.
(WI.EventBreakpoint.prototype.get special): Added.
(WI.EventBreakpoint.prototype.get editable): Added.
(WI.EventBreakpoint.prototype.remove): Added.
(WI.EventBreakpoint.prototype.saveIdentityToCookie):
(WI.EventBreakpoint.prototype.toJSON):
(WI.EventBreakpoint.deserialize): Deleted.
(WI.EventBreakpoint.prototype.get disabled): Deleted.
(WI.EventBreakpoint.prototype.set disabled): Deleted.

• UserInterface/Models/JavaScriptBreakpoint.js: Copied from UserInterface/Models/Breakpoint.js.

(WI.JavaScriptBreakpoint):
(WI.JavaScriptBreakpoint.fromJSON):
(WI.JavaScriptBreakpoint.prototype.toJSON):
(WI.JavaScriptBreakpoint.prototype.get sourceCodeLocation):
(WI.JavaScriptBreakpoint.prototype.get contentIdentifier):
(WI.JavaScriptBreakpoint.prototype.get scriptIdentifier):
(WI.JavaScriptBreakpoint.prototype.get target):
(WI.JavaScriptBreakpoint.prototype.get special): Added.
(WI.JavaScriptBreakpoint.prototype.get removable): Added.
(WI.JavaScriptBreakpoint.prototype.get editable): Added.
(WI.JavaScriptBreakpoint.prototype.get identifier):
(WI.JavaScriptBreakpoint.prototype.set identifier):
(WI.JavaScriptBreakpoint.prototype.get resolved):
(WI.JavaScriptBreakpoint.prototype.set resolved):
(WI.JavaScriptBreakpoint.prototype.remove): Added.
(WI.JavaScriptBreakpoint.prototype.saveIdentityToCookie):
(WI.JavaScriptBreakpoint.prototype._isSpecial):
(WI.JavaScriptBreakpoint.prototype._sourceCodeLocationLocationChanged):
(WI.JavaScriptBreakpoint.prototype._sourceCodeLocationDisplayLocationChanged):

• UserInterface/Models/URLBreakpoint.js:

(WI.URLBreakpoint):
(WI.URLBreakpoint.fromJSON): Added.
(WI.URLBreakpoint.prototype.get special): Added.
(WI.URLBreakpoint.prototype.remove): Added.
(WI.URLBreakpoint.prototype.toJSON):
(WI.URLBreakpoint.deserialize): Deleted.
(WI.URLBreakpoint.prototype.get disabled): Deleted.
(WI.URLBreakpoint.prototype.set disabled): Deleted.
Rename WI.Breakpoint to WI.JavaScriptBreakpoint and use WI.Breakpoint as a new common
base class for all breakpoint types, allowing more logic to be shared (e.g. disabled state).
Additionally, breakpoints are now able to

• determine whether or not they're
  • special
  • removable
  • editable (i.e. configurable)
• remove themselves

without the caller needing to know what manager to consult with.

• UserInterface/Controllers/DOMManager.js:

(WI.DOMManager):
(WI.DOMManager.supportsEventListenerBreakpointConfiguration): Added.
(WI.DOMManager.prototype.setBreakpointForEventListener):
(WI.DOMManager.prototype.removeBreakpointForEventListener):
(WI.DOMManager.prototype._setEventBreakpoint): Added.
(WI.DOMManager.prototype._removeEventBreakpoint): Added.
(WI.DOMManager.prototype._handleEventBreakpointEditablePropertyChanged): Added.
(WI.DOMManager.prototype._handleEventBreakpointActionsChanged): Added.
(WI.DOMManager.prototype._updateEventBreakpoint): Deleted.
Keep track of configuration changes for specific listener breakpoints.

• UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager):
(WI.DOMDebuggerManager.prototype.initializeTarget):
(WI.DOMDebuggerManager.prototype.addDOMBreakpoint):
(WI.DOMDebuggerManager.prototype.removeDOMBreakpoint):
(WI.DOMDebuggerManager.prototype.addEventBreakpoint):
(WI.DOMDebuggerManager.prototype.removeEventBreakpoint):
(WI.DOMDebuggerManager.prototype.addURLBreakpoint):
(WI.DOMDebuggerManager.prototype.removeURLBreakpoint):
(WI.DOMDebuggerManager.prototype._commandArgumentsForEventBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._setEventBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._removeEventBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._handleEventBreakpointDisabledStateChanged): Added.
(WI.DOMDebuggerManager.prototype._handleEventBreakpointEditablePropertyChanged): Added.
(WI.DOMDebuggerManager.prototype._handleEventBreakpointActionsChanged): Added.
(WI.DOMDebuggerManager.prototype.isBreakpointSpecial): Deleted.
(WI.DOMDebuggerManager.prototype._updateEventBreakpoint): Deleted.
Keep track of configuration changes for special event breakpoints.
Store special event breakpoints inside WI.objectStores.eventBreakpoints.

• UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager):
(WI.DebuggerManager.prototype.addBreakpoint):
(WI.DebuggerManager.prototype.removeBreakpoint):
(WI.DebuggerManager.prototype.addProbesForBreakpoint): Added.
(WI.DebuggerManager.prototype.removeProbesForBreakpoint): Added.
(WI.DebuggerManager.prototype.updateProbesForBreakpoint): Added.
(WI.DebuggerManager.prototype._setBreakpoint):
(WI.DebuggerManager.prototype._breakpointEditablePropertyDidChange):
(WI.DebuggerManager.prototype._handleBreakpointActionsDidChange):
(WI.DebuggerManager.prototype.isBreakpointRemovable): Deleted.
(WI.DebuggerManager.prototype.isBreakpointSpecial): Deleted.
(WI.DebuggerManager.prototype.isBreakpointEditable): Deleted.
(WI.DebuggerManager.prototype._debuggerBreakpointActionType): Deleted.
(WI.DebuggerManager.prototype._debuggerBreakpointOptions): Deleted.
(WI.DebuggerManager.prototype._addProbesForBreakpoint): Deleted.
(WI.DebuggerManager.prototype._removeProbesForBreakpoint): Deleted.
(WI.DebuggerManager.prototype._updateProbesForBreakpoint): Deleted.
Replace WI.Breakpoint with WI.JavaScriptBreakpoint.
Probes now support WI.EventBreakpoint in addition to WI.JavaScriptBreakpoint.

• UserInterface/Controllers/BreakpointPopoverController.js:

(WI.BreakpointPopoverController.prototype.appendContextMenuItems):
(WI.BreakpointPopoverController.prototype._createPopoverContent):
Allow any breakpoint instead of only WI.JavaScriptBreakpoint.
Drive-by: the existing ignoreCount value wasn't being used to populate the <input>.

• UserInterface/Views/BreakpointTreeElement.js:

(WI.BreakpointTreeElement.prototype.ondelete):
(WI.BreakpointTreeElement.prototype.get listenerSet): Added.
(WI.BreakpointTreeElement.prototype.updateStatus): Added.
(WI.BreakpointTreeElement.prototype.updateTitles): Added.
(WI.BreakpointTreeElement.prototype.get breakpoint): Deleted.
(WI.BreakpointTreeElement.prototype.get filterableData): Deleted.
(WI.BreakpointTreeElement.prototype._updateTitles): Deleted.
(WI.BreakpointTreeElement.prototype._updateStatus): Deleted.
(WI.BreakpointTreeElement.prototype._breakpointLocationDidChange): Deleted.

• UserInterface/Views/BreakpointTreeElement.css:

(.item.breakpoint .status > .status-image):
(.item.breakpoint.paused .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.paused .icon): Added.
(.item.breakpoint .status > .status-image.resolved): Deleted.
(body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.breakpoint.selected .status > .status-image.resolved): Deleted.
(.item.breakpoint .subtitle.formatted-location): Deleted.
(.breakpoint-debugger-statement-icon .icon): Deleted.
(.breakpoint-exception-icon .icon): Deleted.
(.breakpoint-assertion-icon .icon): Deleted.
(.breakpoint-microtask-icon .icon): Deleted.
(.breakpoint-paused-icon .icon): Deleted.
(.breakpoint-generic-line-icon .icon): Deleted.
(.breakpoint-generic-line-icon .icon > span): Deleted.
(.data-updated.breakpoint-generic-line-icon .icon > span): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-debugger-statement-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-exception-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-assertion-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-microtask-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-paused-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-generic-line-icon .icon): Deleted.

• UserInterface/Views/DOMBreakpointTreeElement.js:

(WI.DOMBreakpointTreeElement):
(WI.DOMBreakpointTreeElement.prototype.onattach): Deleted.
(WI.DOMBreakpointTreeElement.prototype.ondetach): Deleted.
(WI.DOMBreakpointTreeElement.prototype.ondelete): Deleted.
(WI.DOMBreakpointTreeElement.prototype.onenter): Deleted.
(WI.DOMBreakpointTreeElement.prototype.onspace): Deleted.
(WI.DOMBreakpointTreeElement.prototype.populateContextMenu): Deleted.
(WI.DOMBreakpointTreeElement.prototype._statusImageElementClicked): Deleted.
(WI.DOMBreakpointTreeElement.prototype._statusImageElementFocused): Deleted.
(WI.DOMBreakpointTreeElement.prototype._statusImageElementMouseDown): Deleted.
(WI.DOMBreakpointTreeElement.prototype._toggleBreakpoint): Deleted.
(WI.DOMBreakpointTreeElement.prototype._updateStatus): Deleted.

• UserInterface/Views/DOMBreakpointTreeElement.css:

(.item.breakpoint.dom.subtree-modified:not(.paused) .icon): Added.
(.item.breakpoint.dom.attribute-modified:not(.paused) .icon): Added.
(.item.breakpoint.dom.node-removed:not(.paused) .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.dom.subtree-modified:not(.paused) .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.dom.attribute-modified:not(.paused) .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.dom.node-removed:not(.paused) .icon): Added.
(.breakpoint.dom.breakpoint-for-subtree-modified:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.dom.breakpoint-for-attribute-modified:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.dom.breakpoint-for-node-removed:not(.breakpoint-paused-icon) .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint.dom.breakpoint-for-subtree-modified:not(.breakpoint-paused-icon) .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint.dom.breakpoint-for-attribute-modified:not(.breakpoint-paused-icon) .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint.dom.breakpoint-for-node-removed:not(.breakpoint-paused-icon) .icon): Deleted.

• UserInterface/Views/EventBreakpointTreeElement.js:

(WI.EventBreakpointTreeElement):
(WI.EventBreakpointTreeElement.prototype.onattach): Deleted.
(WI.EventBreakpointTreeElement.prototype.ondetach): Deleted.
(WI.EventBreakpointTreeElement.prototype.ondelete): Deleted.
(WI.EventBreakpointTreeElement.prototype.onenter): Deleted.
(WI.EventBreakpointTreeElement.prototype.onspace): Deleted.
(WI.EventBreakpointTreeElement.prototype.populateContextMenu): Deleted.
(WI.EventBreakpointTreeElement.prototype._statusImageElementClicked): Deleted.
(WI.EventBreakpointTreeElement.prototype._statusImageElementFocused): Deleted.
(WI.EventBreakpointTreeElement.prototype._statusImageElementMouseDown): Deleted.
(WI.EventBreakpointTreeElement.prototype._toggleBreakpoint): Deleted.
(WI.EventBreakpointTreeElement.prototype._updateStatus): Deleted.

• UserInterface/Views/EventBreakpointTreeElement.css:

(.item.breakpoint.event.animation-frame:not(.paused) .icon): Added.
(.item.breakpoint.event.interval:not(.paused) .icon): Added.
(.item.breakpoint.event.listener:not(.paused) .icon): Added.
(.item.breakpoint.event.timeout:not(.paused) .icon): Added.
(@media(prefers-color-scheme: dark) .item.breakpoint.event.animation-frame:not(.paused) .icon): Added.
(@media(prefers-color-scheme: dark) .item.breakpoint.event.interval:not(.paused) .icon): Added.
(@media(prefers-color-scheme: dark) .item.breakpoint.event.listener:not(.paused) .icon): Added.
(@media(prefers-color-scheme: dark) .item.breakpoint.event.timeout:not(.paused) .icon): Added.
(.breakpoint.event.breakpoint-for-animation-frame:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.event.breakpoint-for-interval:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.event.breakpoint-for-listener:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.event.breakpoint-for-timeout:not(.breakpoint-paused-icon) .icon): Deleted.
(@media(prefers-color-scheme: dark) .breakpoint.event.breakpoint-for-animation-frame:not(.breakpoint-paused-icon) .icon): Deleted.
(@media(prefers-color-scheme: dark) .breakpoint.event.breakpoint-for-interval:not(.breakpoint-paused-icon) .icon): Deleted.
(@media(prefers-color-scheme: dark) .breakpoint.event.breakpoint-for-listener:not(.breakpoint-paused-icon) .icon): Deleted.
(@media(prefers-color-scheme: dark) .breakpoint.event.breakpoint-for-timeout:not(.breakpoint-paused-icon) .icon): Deleted.

• UserInterface/Views/JavaScriptBreakpointTreeElement.js: Copied from Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js.

(WI.JavaScriptBreakpointTreeElement):
(WI.JavaScriptBreakpointTreeElement.prototype.get filterableData):
(WI.JavaScriptBreakpointTreeElement.prototype.updateStatus): Added.
(WI.JavaScriptBreakpointTreeElement.prototype.updateTitles): Added.
(WI.JavaScriptBreakpointTreeElement.prototype._breakpointLocationDidChange):

• UserInterface/Views/JavaScriptBreakpointTreeElement.css: Copied from Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.css.

(.item.breakpoint.javascript .status > .status-image): Added.
(.item.breakpoint.javascript .status > .status-image.resolved): Added.
(body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.breakpoint.javascript.selected .status > .status-image.resolved): Added.
(.item.breakpoint.javascript .subtitle.formatted-location): Added.
(.item.breakpoint.javascript.line .icon): Added.
(.item.breakpoint.javascript.line .icon > span): Added.
(.data-updated.item.breakpoint.javascript.line .icon > span): Added.
(.item.breakpoint.javascript.debugger-statement .icon): Added.
(.item.breakpoint.javascript.exception .icon): Added.
(.item.breakpoint.javascript.assertion .icon): Added.
(.item.breakpoint.javascript.microtask .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.line .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.debugger-statement .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.exception .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.assertion .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.microtask .icon): Added.

• UserInterface/Views/URLBreakpointTreeElement.js:

(WI.URLBreakpointTreeElement):
(WI.URLBreakpointTreeElement.prototype.onattach): Deleted.
(WI.URLBreakpointTreeElement.prototype.ondetach): Deleted.
(WI.URLBreakpointTreeElement.prototype.ondelete): Deleted.
(WI.URLBreakpointTreeElement.prototype.onenter): Deleted.
(WI.URLBreakpointTreeElement.prototype.onspace): Deleted.
(WI.URLBreakpointTreeElement.prototype.populateContextMenu): Deleted.
(WI.URLBreakpointTreeElement.prototype._statusImageElementClicked): Deleted.
(WI.URLBreakpointTreeElement.prototype._statusImageElementFocused): Deleted.
(WI.URLBreakpointTreeElement.prototype._statusImageElementMouseDown): Deleted.
(WI.URLBreakpointTreeElement.prototype._toggleBreakpoint): Deleted.
(WI.URLBreakpointTreeElement.prototype._updateStatus): Deleted.

• UserInterface/Views/URLBreakpointTreeElement.css:

(.item.breakpoint.url .subtitle): Added.
(.item.breakpoint.url:not(.paused) .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.url:not(.paused) .icon): Added.
(.breakpoint.url .subtitle): Deleted.
(.breakpoint.url:not(.breakpoint-paused-icon) .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint.url:not(.breakpoint-paused-icon) .icon): Deleted.
Rename WI.BreakpointTreeElement to WI.JavaScriptBreakpointTreeElement and use
WI.BreakpointTreeElement as a new common base class for all breakpoint tree elements,
allowing more logic and styles to be shared (e.g. disabled state).

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype.closed):
(WI.SourcesNavigationSidebarPanel.prototype._insertDebuggerTreeElement):
(WI.SourcesNavigationSidebarPanel.prototype._compareJavaScriptBreakpointTreeElements): Added.
(WI.SourcesNavigationSidebarPanel.prototype._addBreakpoint):
(WI.SourcesNavigationSidebarPanel.prototype._removeAllBreakpoints):
(WI.SourcesNavigationSidebarPanel.prototype._breakpointsBeneathTreeElement):
(WI.SourcesNavigationSidebarPanel.prototype._addIssue):
(WI.SourcesNavigationSidebarPanel.prototype._updatePauseReasonSection):
(WI.SourcesNavigationSidebarPanel.prototype._handleTreeSelectionDidChange):
(WI.SourcesNavigationSidebarPanel.prototype._handleBreakpointElementAddedOrRemoved):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu.addToggleForSpecialEventBreakpoint):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu):
(WI.SourcesNavigationSidebarPanel.prototype._handleDebuggerObjectDisplayLocationDidChange):
(WI.SourcesNavigationSidebarPanel.prototype._compareBreakpointTreeElements): Deleted.

• UserInterface/Models/ProbeSet.js:

(WI.ProbeSet):
(WI.ProbeSet.prototype.createProbe):
(WI.ProbeSet.prototype.willRemove):

• UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype._processRecord):

• UserInterface/Views/ProbeSetDetailsSection.js:

(WI.ProbeSetDetailsSection):

• UserInterface/Views/ProbeDetailsSidebarPanel.js:

(WI.ProbeDetailsSidebarPanel.prototype.inspect):

• UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor):
(WI.SourceCodeTextEditor.prototype.close):
(WI.SourceCodeTextEditor.prototype.textEditorBreakpointAdded):

• UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView.prototype.get supplementalRepresentedObjects):
(WI.TextResourceContentView.prototype._probeSetsChanged):
Probes now support WI.EventBreakpoint in addition to WI.JavaScriptBreakpoint.

• UserInterface/Views/ContentView.js:

(WI.ContentView.createFromRepresentedObject):
(WI.ContentView.resolvedRepresentedObjectForRepresentedObject):
(WI.ContentView.isViewable):

• UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForSourceCode):
Replace WI.Breakpoint with WI.JavaScriptBreakpoint.

• UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView):
Replace WI.DOMBreakpoint with WI.Breakpoint.

• UserInterface/Views/EventListenerSectionGroup.js:

(WI.EventListenerSectionGroup):

• UserInterface/Views/EventListenerSectionGroup.css:

(.event-listener-section > .content input[type="checkbox"] + .go-to-arrow): Added.
(.event-listener-section > .content input[type="checkbox"]:not(:checked) + .go-to-arrow): Added.
Add a go-to arrow next to the Breakpoint checkbox that reveals the WI.EventBreakpoint in
the Sources Tab.

• UserInterface/Views/BreakpointActionView.js:

(WI.BreakpointActionView.prototype._appendActionButtonClicked):
Drive-by: minor code cleanup.

• UserInterface/Views/CallFrameTreeElement.js:

(WI.CallFrameTreeElement.prototype.populateContextMenu):
Drive-by: include source code location context menu items.

• UserInterface/Base/Setting.js:
• UserInterface/Main.html:
• UserInterface/Test.html:

LayoutTests:

• inspector/dom-debugger/resources/event-breakpoint-utilities.js:

(TestPage.registerInitializer.InspectorTest.EventBreakpoint.addBreakpointOptionsTestCases): Added.
(TestPage.registerInitializer.InspectorTest.EventBreakpoint.async teardown):
(TestPage.registerInitializer.InspectorTest.EventBreakpoint.createBreakpoint):
(TestPage.registerInitializer.InspectorTest.EventBreakpoint.removeBreakpoint):

• inspector/dom/breakpoint-for-event-listener.html:
• inspector/dom/breakpoint-for-event-listener-expected.txt:
• inspector/dom-debugger/event-animation-frame-breakpoints.html:
• inspector/dom-debugger/event-animation-frame-breakpoints-expected.txt:
• inspector/dom-debugger/event-interval-breakpoints.html:
• inspector/dom-debugger/event-interval-breakpoints-expected.txt:
• inspector/dom-debugger/event-listener-breakpoints.html:
• inspector/dom-debugger/event-listener-breakpoints-expected.txt:
• inspector/dom-debugger/event-timeout-breakpoints.html:
• inspector/dom-debugger/event-timeout-breakpoints-expected.txt:

Add tests for new event breakpoint configuration options.

• http/tests/inspector/debugger/debugger-test.js:

(TestPage.registerInitializer.InspectorTest.startTracingBreakpoints):

• http/tests/inspector/resources/probe-test.js:

(TestPage.registerInitializer.ProtocolTest.Probe.installTracingListeners):

• inspector/debugger/breakpoint-action-eval.html:
• inspector/debugger/breakpoint-action-log.html:
• inspector/debugger/breakpoint-columns.html:
• inspector/debugger/breakpoint-scope.html:
• inspector/debugger/debugger-stack-overflow.html:
• inspector/debugger/pause-reason.html:
• inspector/debugger/probe-manager-add-remove-actions.html:
• inspector/debugger/stepping/stepping-through-autoContinue-breakpoint.html:
• inspector/debugger/tail-deleted-frames-this-value.html:
• inspector/debugger/tail-recursion.html:
• inspector/worker/debugger-pause.html:
• inspector/worker/debugger-shared-breakpoint.html:

Update existing breakpoint tests to use new model objects.

10:32 AM Changeset in webkit [266073] by Hector Lopez

• 2 edits in trunk/LayoutTests

Regression (r266028): platform/ios/ios/fast/coordinates/range-client-rects.html
​https://bugs.webkit.org/show_bug.cgi?id=215772

Unreviewwed test gardening.

• platform/ios-wk2/TestExpectations:

10:31 AM Changeset in webkit [266072] by Devin Rousso

• 39 edits in trunk/Source

Web Inspector: remove "extra domains" concept now that domains can be added based on the debuggable type
​https://bugs.webkit.org/show_bug.cgi?id=201150
<rdar://problem/56545911>

Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/scripts/codegen/objc_generator_templates.py:
• inspector/augmentable/AugmentableInspectorController.h:

• inspector/JSGlobalObjectInspectorController.h:
• inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::registerAlternateAgent): Added.
(Inspector::JSGlobalObjectInspectorController::appendExtraAgent): Deleted.

• inspector/InspectorAgentRegistry.h:
• inspector/InspectorAgentRegistry.cpp:

(Inspector::AgentRegistry::appendExtraAgent): Deleted.

• inspector/protocol/Inspector.json:
• inspector/agents/InspectorAgent.h:
• inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::activateExtraDomain): Deleted.
(Inspector::InspectorAgent::activateExtraDomains): Deleted.

• inspector/scripts/tests/expected/command-targetType-matching-domain-debuggableType.json-result:
• inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
• inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
• inspector/scripts/tests/expected/definitions-with-mac-platform.json-result:
• inspector/scripts/tests/expected/domain-debuggableTypes.json-result:
• inspector/scripts/tests/expected/domain-targetType-matching-domain-debuggableType.json-result:
• inspector/scripts/tests/expected/domain-targetTypes.json-result:
• inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
• inspector/scripts/tests/expected/enum-values.json-result:
• inspector/scripts/tests/expected/event-targetType-matching-domain-debuggableType.json-result:
• inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:

Rebase protocol tests.

Source/WebInspectorUI:

• UserInterface/Base/Object.js:
• UserInterface/Protocol/InspectorObserver.js:

(WI.InspectorObserver.prototype.activateExtraDomains):

• UserInterface/Protocol/Target.js:

(WI.Target.prototype.activateExtraDomain):

• UserInterface/Controllers/AppController.js:

(WI.AppController.prototype.activateExtraDomains):

• UserInterface/Controllers/AnimationManager.js:

(WI.AnimationManager.prototype.activateExtraDomain):

• UserInterface/Controllers/ApplicationCacheManager.js:

(WI.ApplicationCacheManager.prototype.activateExtraDomain):

• UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.activateExtraDomain):

• UserInterface/Controllers/DOMStorageManager.js:

(WI.DOMStorageManager.prototype.activateExtraDomain):

• UserInterface/Controllers/DatabaseManager.js:

(WI.DatabaseManager.prototype.activateExtraDomain):

• UserInterface/Controllers/HeapManager.js:

(WI.HeapManager.prototype.activateExtraDomain):

• UserInterface/Controllers/IndexedDBManager.js:

(WI.IndexedDBManager.prototype.activateExtraDomain):

• UserInterface/Controllers/MemoryManager.js:

(WI.MemoryManager.prototype.activateExtraDomain):

• UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype._extraDomainsActivated):

• UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype.activateExtraDomain):

• UserInterface/Base/Main.js:

(WI.activateExtraDomains):

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype._handleExtraDomainsActivated):
Add compatibility comments.

• UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass):
(InspectorBackend.Domain):
Add FIXMEs.

10:30 AM Changeset in webkit [266071] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: remove legacy code for replacing the Canvas Tab with the Graphics Tab
​https://bugs.webkit.org/show_bug.cgi?id=205827

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WI.loaded):

10:24 AM Changeset in webkit [266070] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: Styles: don't show swatches for properties that aren't used/apply
​https://bugs.webkit.org/show_bug.cgi?id=215681

Reviewed by Brian Burg.

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._renderValue):

10:21 AM Changeset in webkit [266069] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: Styles: don't show non-inherited properties
​https://bugs.webkit.org/show_bug.cgi?id=215682

Reviewed by Brian Burg.

• UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get propertiesToRender):

10:17 AM Changeset in webkit [266068] by youenn@apple.com

• 1 edit
  4 adds in trunk/LayoutTests

Add a test showing the difference of behavior when closing a WebSocket connection between legacy WebSocket and NSURLSession WebSocket code paths
​https://bugs.webkit.org/show_bug.cgi?id=215766

Reviewed by Alex Christensen.

Add a test showing the difference of behavior at connection close time in python websocket script.
This behavior was previously covered in http/tests/websocket/tests/hybi/close-on-* tests.
The test is written so that Chrome, Firefox and NSURLSession WebSocket code path generate all PASS.
Legacy WebSocket code path generates one FAIL.

• http/tests/websocket/tests/hybi/close-and-exceptions_wsh.py: Added.
• http/tests/websocket/tests/hybi/close-and-server-script-exception-expected.txt: Added.
• http/tests/websocket/tests/hybi/close-and-server-script-exception.html: Added.
• http/tests/websocket/tests/hybi/resources/close-and-server-script-exception-iframe.html: Added.

10:13 AM Changeset in webkit [266067] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ iOS wk2 ] http/tests/websocket/tests/hybi/client-close-2.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215773

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

10:11 AM Changeset in webkit [266066] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: Styles: grey out properties that aren't used/apply
​https://bugs.webkit.org/show_bug.cgi?id=215680

Reviewed by Brian Burg.

• UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .name:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .name:not(:hover, .editing)): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing)): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .name:not(.editing), body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .value-container > .value:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .name:not(:hover, .editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .value-container > .value:not(:hover, .editing)): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing) .token-link, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing) .token-link): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing) .token-string, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing) .token-string): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing) .token-comment, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing) .token-comment): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .name:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .name:not(:hover, .editing)): Deleted.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing)): Deleted.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing) .token-link, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing) .token-link): Deleted.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing) .token-string, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing) .token-string): Deleted.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing) .token-comment, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing) .token-comment): Deleted.
Add additional :nots to existing rules to ensure that they don't conflict with a new rule
that changes the color of the .name/.value to grey when the property is not applied/used.

10:01 AM Changeset in webkit [266065] by Hector Lopez

• 2 edits in trunk/LayoutTests

webkit-test-runner: Add support for the reftest-wait class name
​https://bugs.webkit.org/show_bug.cgi?id=186045

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

9:51 AM Changeset in webkit [266064] by youenn@apple.com

• 2 edits in trunk/Source/ThirdParty/libwebrtc

Enable VP9D_SET_LOOP_FILTER_OPT for libvpx vp9 decoder
​https://bugs.webkit.org/show_bug.cgi?id=215765
<rdar://problem/67677285>

Reviewed by Eric Carlson.

Following ​https://webrtc-review.googlesource.com/c/src/+/177335 upstream, let's enable VP9D_SET_LOOP_FILTER_OPT for improved performances.

• Source/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:

9:25 AM Changeset in webkit [266063] by Aditya Keerthi

• 46 edits
  11 adds in trunk

[macOS] Show picker for date and datetime-local input types
​https://bugs.webkit.org/show_bug.cgi?id=214946

Reviewed by Darin Adler and Wenson Hsieh.

Source/WebCore:

Date and datetime-local input types require a calendar picker to be presented when activated.
Consequently, BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent was modified to
create a DateTimeChooser and display a calendar upon activation. This object is destroyed
when the element is blurred, hiding the calendar.

There is currently no picker UI for month, week, and time input types. As a result,
handleDOMActivateEvent is a no-op on those input types.

Wrote an encoder and decoder for DateTimeChooserParameters, so that the picker can be
created with the correct values.

Tests: fast/forms/date/date-show-hide-picker.html

fast/forms/datetimelocal/datetimelocal-show-hide-picker.html

• WebCore.xcodeproj/project.pbxproj:
• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
(WebCore::BaseChooserOnlyDateAndTimeInputType::elementDidBlur):
(WebCore::BaseChooserOnlyDateAndTimeInputType::isPresentingAttachedView const):
(WebCore::BaseChooserOnlyDateAndTimeInputType::didChooseValue):

• html/BaseChooserOnlyDateAndTimeInputType.h:
• html/HTMLInputElement.cpp:
• html/MonthInputType.cpp:

(WebCore::MonthInputType::handleDOMActivateEvent):

• html/MonthInputType.h:
• html/TimeInputType.cpp:

(WebCore::TimeInputType::handleDOMActivateEvent):

• html/TimeInputType.h:
• html/WeekInputType.cpp:

(WebCore::WeekInputType::handleDOMActivateEvent):

• html/WeekInputType.h:
• loader/EmptyClients.cpp:

(WebCore::EmptyChromeClient::createDateTimeChooser):

• loader/EmptyClients.h:
• page/Chrome.cpp:

(WebCore::Chrome::createDateTimeChooser):

• page/Chrome.h:
• page/ChromeClient.h:
• platform/DateTimeChooser.h:
• platform/DateTimeChooserClient.h:
• platform/DateTimeChooserParameters.h: Added.

(WebCore::DateTimeChooserParameters::encode const):
(WebCore::DateTimeChooserParameters::decode):

Source/WebKit:

Created WKDateTimePicker as a wrapper around NSDatePicker. The picker is
displayed in its own NSWindow, ensuring the view is always above the page.
WebPageProxy and WKDateTimePicker communicate through WebDateTimePickerMac,
in order for the picker to be initialized with the correct initial, minimum,
and maximum date, and so that the chosen date can be sent back to the
WebProcess.

Added IPC messages to enable communication between the UIProcess and the
WebProcess necessary for showing and hiding the picker.

• Sources.txt:
• SourcesCocoa.txt:
• UIProcess/PageClient.h:
• UIProcess/WebDateTimePicker.cpp: Added.

(WebKit::WebDateTimePicker::WebDateTimePicker):
(WebKit::WebDateTimePicker::~WebDateTimePicker):
(WebKit::WebDateTimePicker::endPicker):

• UIProcess/WebDateTimePicker.h: Added.
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showDateTimePicker):
(WebKit::WebPageProxy::endDateTimePicker):
(WebKit::WebPageProxy::didChooseDate):
(WebKit::WebPageProxy::didEndDateTimePicker):
(WebKit::WebPageProxy::closeOverlayedViews):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::createDateTimePicker):

• UIProcess/mac/PageClientImplMac.h:
• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::createDateTimePicker):

• UIProcess/mac/WebDateTimePickerMac.h: Added.
• UIProcess/mac/WebDateTimePickerMac.mm: Added.

(WebKit::WebDateTimePickerMac::create):
(WebKit::WebDateTimePickerMac::~WebDateTimePickerMac):
(WebKit::WebDateTimePickerMac::WebDateTimePickerMac):
(WebKit::WebDateTimePickerMac::endPicker):
(WebKit::WebDateTimePickerMac::showDateTimePicker):
(WebKit::WebDateTimePickerMac::didChooseDate):
(-[WKDateTimePickerWindow initWithContentRect:styleMask:backing:defer:]):
(-[WKDateTimePickerWindow canBecomeKeyWindow]):
(-[WKDateTimePickerWindow hasKeyAppearance]):
(-[WKDateTimePickerWindow shadowOptions]):
(-[WKDateTimePicker initWithParams:inView:]):
(-[WKDateTimePicker showPicker:]):
(-[WKDateTimePicker invalidate]):
(-[WKDateTimePicker didChooseDate:]):
(-[WKDateTimePicker dateFormatStringForType:]):

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createDateTimeChooser):

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebCoreSupport/WebDateTimeChooser.cpp: Added.

(WebKit::WebDateTimeChooser::WebDateTimeChooser):
(WebKit::WebDateTimeChooser::didChooseDate):
(WebKit::WebDateTimeChooser::didEndChooser):
(WebKit::WebDateTimeChooser::endChooser):
(WebKit::WebDateTimeChooser::showChooser):

• WebProcess/WebCoreSupport/WebDateTimeChooser.h: Added.
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setActiveDateTimeChooser):
(WebKit::WebPage::didChooseDate):
(WebKit::WebPage::didEndDateTimePicker):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Source/WebKitLegacy/mac:

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::createDateTimeChooser):

Tools:

Added isShowingDateTimePicker testing hook in order to enable testing of the visibility of
the picker.

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::isShowingDateTimePicker const):

• WebKitTestRunner/mac/UIScriptControllerMac.h:
• WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptControllerMac::isShowingDateTimePicker const):

LayoutTests:

Added tests to verify that the picker is correctly shown and hidden for date and
datetime-local input types.

• fast/forms/date/date-show-hide-picker-expected.txt: Added.
• fast/forms/date/date-show-hide-picker.html: Added.
• fast/forms/datetimelocal/datetimelocal-show-hide-picker-expected.txt: Added.
• fast/forms/datetimelocal/datetimelocal-show-hide-picker.html: Added.
• platform/ios/TestExpectations:
• resources/ui-helper.js:

(window.UIHelper.isShowingDateTimePicker):

9:22 AM Changeset in webkit [266062] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LFC][IFC] Rename LineBox::baseline to alignment baseline
​https://bugs.webkit.org/show_bug.cgi?id=214784

Reviewed by Antti Koivisto.

See ​https://www.w3.org/TR/css-inline-3/#alignment-baseline
Use the spec term. This helps to tell the dominant and the alignment baselines apart during line building.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::setAlignmentBaselineIfGreater):
(WebCore::Layout::LineBox::setAscentIfGreater):
(WebCore::Layout::LineBox::alignmentBaseline const):
(WebCore::Layout::LineBox::resetAlignmentBaseline):
(WebCore::Layout::LineBox::setBaselineIfGreater): Deleted.
(WebCore::Layout::LineBox::baseline const): Deleted.
(WebCore::Layout::LineBox::resetBaseline): Deleted.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::baseline const):

8:50 AM Changeset in webkit [266061] by Adrian Perez de Castro

• 7 edits in trunk/Source

Non-unified build fixes, late August 2020 edition
​https://bugs.webkit.org/show_bug.cgi?id=215768

Unreviewed build fix.

Source/WebCore:

No new tests needed.

• Modules/webaudio/StereoPannerNode.cpp: Add missing headers AudioNodeInput.h,

AudioNodeOutput.h, and wtf/IsoMallocInlines.h.

• bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::visitAdditionalChildren):
Add JSC:: namespace to SlotVisitor parameter type.

• dom/SimpleRange.cpp: Add missing ShadowRoot.h header.
• history/CachedPage.cpp: Add missing FrameLoaderClient.h header.

Source/WebKit:

• UIProcess/WebURLSchemeTask.cpp: Add missing SharedBufferDataReference.h header.

8:42 AM Changeset in webkit [266060] by Hector Lopez

• 2 edits in trunk/LayoutTests

WebGL conformance: Failures and Timeouts in suite 2.0.0/conformance2
​https://bugs.webkit.org/show_bug.cgi?id=189672

Unreviewed test gardening.

• platform/mac/TestExpectations:

8:02 AM Changeset in webkit [266059] by youenn@apple.com

• 12 edits in trunk/LayoutTests

http/tests/websocket/tests/hybi/close-on-* tests are not interoperable
​https://bugs.webkit.org/show_bug.cgi?id=215692

Reviewed by Darin Adler.

Before the patch, tests were not passing in Chrome, Firefox and NSURLSession WebSocket code path.
This was due to the fact the web socket script is using try/finally and the closure of the connection is not raising an exception
while it is for Chrome, Firefox and NSURLSession WebSocket code path.
Change the WebSocket server script to more reliably send the socket message at closing time of the connection.

• http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt:
• http/tests/websocket/tests/hybi/close-on-navigate-new-location.html:
• http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt:
• http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html:
• http/tests/websocket/tests/hybi/close-on-unload-expected.txt:
• http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt:
• http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html:
• http/tests/websocket/tests/hybi/close-on-unload.html:
• http/tests/websocket/tests/hybi/close-on-unload_wsh.py:

(web_socket_transfer_data):

• http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt:
• http/tests/websocket/tests/hybi/send-after-close-on-unload.html:

8:02 AM Changeset in webkit [266058] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk1 Debug ] inspector/animation/nameChanged.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=215767

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

7:57 AM Changeset in webkit [266057] by youenn@apple.com

• 7 edits in trunk

Cocoa WebSocketTask should expose WebSocket server extensions
​https://bugs.webkit.org/show_bug.cgi?id=215696

Reviewed by Darin Adler.

Source/WebKit:

Send back to WebProcess the value of server WebSocket extensions.

• NetworkProcess/cocoa/WebSocketTaskCocoa.mm:

(WebKit::WebSocketTask::didConnect):

LayoutTests:

Make the tests agnostic of using the legacy or standard deflate extension.
If using the standard deflate extensions, do not expect subparameters (this matches Chrome, Firefox and NSURLSession code path).

• http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt:
• http/tests/websocket/tests/hybi/deflate-frame-parameter.html:
• http/tests/websocket/tests/hybi/extensions-expected.txt:
• http/tests/websocket/tests/hybi/extensions.html:

7:50 AM Changeset in webkit [266056] by Alan Bujtas

• 12 edits in trunk/Source/WebCore

[LFC][IFC] Use the term 'baseline' to indicate alignment baseline
​https://bugs.webkit.org/show_bug.cgi?id=214779

Reviewed by Antti Koivisto.

This patch is in preparation for decoupling the line box and the root inline box geometry.
Inline boxes have ascent/descent pairs, while line boxes have inline boxes and a baseline.

• layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintInlineContent):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineHeightConstraints const):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::AscentAndDescent::height const):
(WebCore::Layout::LineBox::ascentAndDescent const):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::setBaselineIfGreater):
(WebCore::Layout::LineBox::setAscentIfGreater):
(WebCore::Layout::LineBox::setDescentIfGreater):
(WebCore::Layout::LineBox::baseline const):
(WebCore::Layout::LineBox::resetBaseline):
(WebCore::Layout::LineBox::InlineBox::Baseline::height const): Deleted.
(WebCore::Layout::LineBox::setBaselineOffsetIfGreater): Deleted.
(WebCore::Layout::LineBox::baselineOffset const): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::Baseline): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::setAscent): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::setDescent): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::reset): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::ascent const): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::descent const): Deleted.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::alignContentVertically):
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):
(WebCore::Layout::LineBuilder::halfLeadingMetrics):

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::baseline const):
(WebCore::Layout::LineBuilder::baselineOffset const): Deleted.

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::paint):

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraSpace):

• layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::usedBaselineForCell):

• layout/tableformatting/TableGrid.h:

(WebCore::Layout::TableGrid::Row::setBaseline):
(WebCore::Layout::TableGrid::Row::baseline const):
(WebCore::Layout::TableGrid::Cell::setBaseline):
(WebCore::Layout::TableGrid::Cell::baseline const):
(WebCore::Layout::TableGrid::Row::setBaselineOffset): Deleted.
(WebCore::Layout::TableGrid::Row::baselineOffset const): Deleted.
(WebCore::Layout::TableGrid::Cell::setBaselineOffset): Deleted.
(WebCore::Layout::TableGrid::Cell::baselineOffset const): Deleted.

• layout/tableformatting/TableLayout.cpp:

(WebCore::Layout::TableFormattingContext::TableLayout::distributedVerticalSpace):

6:10 AM Changeset in webkit [266055] by Carlos Garcia Campos

• 18 edits in trunk

Unreviewed. Fix GTK4 build

Source/WebCore:

• SourcesGTK.txt:
• platform/gtk/GtkUtilities.cpp:

(WebCore::monitorWorkArea):

• platform/gtk/GtkUtilities.h:
• platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenAvailableRect):

Source/WebKit:

• PlatformGTK.cmake:
• UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:

(webkitAuthenticationDialogInitialize):

• UIProcess/API/gtk/WebKitScriptDialogImpl.cpp:

(webkitScriptDialogImplConstructed):
(webkit_script_dialog_impl_class_init):

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseEvent):
(webkit_web_view_base_class_init):

• UIProcess/API/gtk/WebKitWebViewDialog.cpp:

(webkitWebViewDialogConstructed):
(webkitWebViewDialogSetChild):

• UIProcess/Inspector/gtk/WebKitInspectorWindow.cpp:

(webkit_inspector_window_init):

• UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:

(WebKit::WebDataListSuggestionsDropdownGtk::show):

• UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::bindAccessibilityTree):

• UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu):

Tools:

• MiniBrowser/gtk/BrowserSearchBox.c:
• MiniBrowser/gtk/BrowserWindow.c:

5:29 AM Changeset in webkit [266054] by commit-queue@webkit.org

• 4 edits in trunk

Make window.find not default the search string to undefined
​https://bugs.webkit.org/show_bug.cgi?id=215757

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-24
Reviewed by Darin Adler.

Source/WebCore:

Make window.find not default the search string to undefined, instead
use the null string. Before this change window.find() would find a
hit in a page containing the text string "undefined".

Test: fast/text/window-find.html

• page/DOMWindow.idl:

LayoutTests:

Add tests to verify window.find() does not use "undefined"
as text string. This also fixes the logic of the test to
not always output PASS at the end.

• fast/text/window-find.html:

2:55 AM Changeset in webkit [266053] by ysuzuki@apple.com

• 2 edits in trunk/JSTests

Unreviewed, ignore RangeErrors when ICU is too old

Since ICU version is different (very sad), some of tests can throw an error.

• stress/intl-language-tag.js:

(let.shouldThrow):
(let.shouldNotThrow):
(suppressErrors):
(vm.icuVersion):
(shouldThrow): Deleted.
(shouldNotThrow): Deleted.

2:26 AM Changeset in webkit [266052] by commit-queue@webkit.org

• 7 edits in trunk

RTCRtpSynchronizationSource.rtpTimestamp is not present
​https://bugs.webkit.org/show_bug.cgi?id=215722

Patch by Justin Uberti <​justin@uberti.name> on 2020-08-24
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Updated expectations file to indicate that tests checking for .rtpTimestamp now pass.

• LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt:

Source/WebCore:

Updated expected results in LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt.

• Modules/mediastream/RTCRtpContributingSource.idl:
• Modules/mediastream/RTCRtpContributingSource.idl:
• Modules/mediastream/RTCRtpSynchronizationSource.idl:

Minor modification to ensure JSRTCRtpSynchronizationSource.cpp gets regenerated.

• Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:

(WebCore::fillRTCRtpContributingSource):