Context Navigation

← Previous Period
Next Period →

Timeline

Sep 15, 2020:

11:33 PM Changeset in webkit [267137] by commit-queue@webkit.org

9 edits in trunk/Source

REGRESSION(r266677): ASSERTION FAILED in PaintFrequencyTracker::end()
https://bugs.webkit.org/show_bug.cgi?id=216591
<rdar://problem/68635418>

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-09-15
Reviewed by Simon Fraser.

Source/WebCore:

Make RenderLayer track the painting which is scheduled through
RenderingUpdateScheduler only. We can do this by (1) reseting Page::
m_renderingUpdateTimestamp at the end of Page::updateRendering() and (2)
making SinglePaintFrequencyTracking track the painting only if the
timestamp is not zero.

page/ChromeClient.h:

(WebCore::ChromeClient::timestampForPaintFrequencyTracking const): Deleted.

page/Page.cpp:

(WebCore::Page::updateRendering):

page/Page.h:

(WebCore::Page::renderingUpdateTimestamp const):
(WebCore::Page::lastRenderingUpdateTimestamp const): Deleted.

rendering/PaintFrequencyTracker.h:

(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateClipRects const):

Source/WebKit:

timestampForPaintFrequencyTracking() do not have to be in ChromeClient.
RenderLayer can access it through its page(). No need to special case
isSVGImageChromeClient() because we are going to track the painting that
goes through Page::updateRendering(). This means all the painting of the
SVG image RenderLayers will be tracked by the same timestamp. Currently
we do not support compositing inside the SVG image which means there is
only one RenderLayer per SVG image.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::timestampForPaintFrequencyTracking const): Deleted.

WebProcess/WebCoreSupport/WebChromeClient.h:

11:22 PM Changeset in webkit [267136] by commit-queue@webkit.org

4 edits in trunk

Fix lazy image load painting
https://bugs.webkit.org/show_bug.cgi?id=216554

Patch by Rob Buis <rbuis@igalia.com> on 2020-09-15
Reviewed by Darin Adler.

Source/WebCore:

Fix lazy image load painting, when LoadImmediately was introduced, it correctly
triggered the immediate load but after finishing the load there was no transition
to the finished lazy load state, causing the logic in RenderImage::paint to not
paint the finished load. This was not detected before since most lazy load WPT tests are
not pixel tests but rather test correct load events etc. (image-loading-subpixel-clip.html
is an exception since it is a reftest).

Test: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-subpixel-clip.html

loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):

LayoutTests:

The test image-loading-subpixel-clip.html now passes.

TestExpectations:

11:07 PM Changeset in webkit [267135] by sbarati@apple.com

3 edits
1 add in trunk

JSImmutableButterfly::get needs to return jsDoubleNumber for double arrays
https://bugs.webkit.org/show_bug.cgi?id=216589
<rdar://problem/68061245>

Reviewed by Yusuke Suzuki.

JSTests:

stress/jsimmutablebutterfly-get-must-return-double-boxed-value.js: Added.

Source/JavaScriptCore:

We are using JSImmutableButterfly::get in AI to constant fold GetByVal,
but we were failing to always return a boxed double value for double loads.
We were calling jsNumber instead of jsDooubleNumber. This is in contrast to
the runtime, which always returns a double boxed value. This would lead AI
to disagree with the runtime, and miscompile code.

runtime/JSImmutableButterfly.h:

(JSC::JSImmutableButterfly::get const):

9:43 PM Changeset in webkit [267134] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][FFC] 'display: flex' generates a flex container box that is block-level when placed in flow layout
https://bugs.webkit.org/show_bug.cgi?id=216596

Reviewed by Simon Fraser.

See https://www.w3.org/TR/css-flexbox-1/#flex-containers.

layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isBlockLevelBox const):

9:33 PM Changeset in webkit [267133] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC] Use isBlockBox() in Box::establishesBlockFormattingContext
https://bugs.webkit.org/show_bug.cgi?id=216595

Reviewed by Simon Fraser.

Let's use the Box::isBlockBox() function (now that we have it) to check if a box establishes a new BFC (this matches spec language now).

layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::establishesBlockFormattingContext const):

9:23 PM Changeset in webkit [267132] by ysuzuki@apple.com

7 edits
5 adds in trunk

[JSC] Cache UDateTimePatternGenerator
https://bugs.webkit.org/show_bug.cgi?id=213454

Reviewed by Ross Kirsling.

JSTests:

microbenchmarks/date-to-locale-date-string.js: Added.
microbenchmarks/date-to-locale-string.js: Added.
microbenchmarks/date-to-locale-time-string.js: Added.

Source/JavaScriptCore:

ICU udatpg_open function is particularly slow. As a result, 80~% of time is used by this function when calling Date#toLocaleString.
We should have last-used cache in VM, which covers major cases like, "One locale (possibly default locale) is used and continuously
use toLocaleString with that locale".

This significantly improves toLocaleString / toLocaleDateString / toLocaleTimeString performance.

ToT Patched

date-to-locale-string 392.0092+-0.6811 ^{87.3196+-3.1598} definitely 4.4894x faster
date-to-locale-date-string 377.9117+-7.8701 ^{70.4155+-3.6661} definitely 5.3669x faster
date-to-locale-time-string 373.1970+-3.0142 ^{67.3790+-2.8952} definitely 5.5388x faster

JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
runtime/IntlCache.cpp: Added.

(JSC::IntlCache::cacheSharedPatternGenerator):
(JSC::IntlCache::getBestDateTimePattern):

runtime/IntlCache.h: Added.

(JSC::IntlCache::getSharedPatternGenerator):

runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::initializeDateTimeFormat):

runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

(JSC::VM::intlCache):

8:10 PM Changeset in webkit [267131] by Aditya Keerthi

5 edits in trunk/Source

[macOS] Date pickers should respect the document's color scheme
https://bugs.webkit.org/show_bug.cgi?id=216514
<rdar://problem/68889548>

Reviewed by Tim Horton.

Source/WebCore:

Added the useDarkAppearance property to DateTimeChooserParameters, which
is based on Document::useDarkAppearance and the associated element's
computed style.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setupDateTimeChooserParameters):

platform/DateTimeChooserParameters.h:

(WebCore::DateTimeChooserParameters::encode const):
(WebCore::DateTimeChooserParameters::decode):

Source/WebKit:

Use the appearance property of NSWindow to ensure the appearance of the
contained NSDatePicker matches the value encoded in DateTimeChooserParameters.

UIProcess/mac/WebDateTimePickerMac.mm:

(-[WKDateTimePicker initWithParams:inView:]):

7:53 PM Changeset in webkit [267130] by ddkilzer@apple.com

10 edits
5 adds
1 delete in trunk

WebKit should support building with clang ThreadSanitizer enabled
<https://webkit.org/b/216318>
<rdar://problem/31615729>

Reviewed by Darin Adler.

This patch doesn't attempt to resolve every potential false
positive, but makes it easy to build WebKit with TSan enabled.

Makefile.shared:
Update to work with make [args] TSAN=YES.

Source/WTF:

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
Add ThreadSanitizerSupport.h to the project.

wtf/Compiler.h:
Define TSAN_ENABLED and SUPPRESS_TSAN macros.

wtf/Locker.h:

(WTF::Locker::~Locker):
(WTF::Locker::unlockEarly):
(WTF::Locker::operator=):
(WTF::Locker::lock):

Instrument lock/unlock methods for ThreadSanitizer.

wtf/ThreadSanitizerSupport.h: Add.

(AnnotateHappensBefore):
(AnnotateHappensAfter):

Declare TSan runtime functions needed to annotate WTF::Locker.

(TSAN_ANNOTATE_HAPPENS_BEFORE):
(TSAN_ANNOTATE_HAPPENS_AFTER):

Define macros used to call TSan runtime functions if TSan is enabled.

Tools:

Scripts/set-webkit-configuration:
Add support for --[no-]tsan switches.
Scripts/webkitdirs.pm:

(determineTSanIsEnabled):
(tsanIsEnabled):
(XcodeOptions):
(generateBuildSystemFromCMakeProject):

Add support for building with TSan enabled.

asan/asan.xcconfig: Rename to sanitizer/asan.xcconfig.
sanitizer/asan.xcconfig: Rename from asan/asan.xcconfig.
Extract common variables to sanitizer.xcconfig.
sanitizer/sanitizer.xcconfig: Add.
Extract common variables from asan.xcconfig.
sanitizer/tsan.xcconfig: Add.
Add support for TSan.

7:42 PM Changeset in webkit [267129] by Karl Rackler

2 edits in trunk/LayoutTests

Change test expectation description
rdar://68957822

Unreviewed test gardening.

platform/mac/TestExpectationsRosetta:

7:36 PM Changeset in webkit [267128] by Karl Rackler

2 edits in trunk/LayoutTests

REGRESSION: [ BigSur wk2 rosetta ] compositing/contents-scale/hidpi-compositing-layer-positioned-on-scaled-context.html is a flaky failure
rdar://68957822

Unreviewed test gardening.

platform/mac/TestExpectationsRosetta:

7:21 PM Changeset in webkit [267127] by Hector Lopez

2 edits in trunk/LayoutTests

[ BigSur+ ] webrtc/captureCanvas-webrtc-software-h264-high.html is a constant failure/timeout
<rdar://68957215>

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

6:37 PM Changeset in webkit [267126] by ysuzuki@apple.com

3 edits
1 move
1 delete in trunk/Source/WebCore

Delete LocaleToScriptMappingICU.cpp since it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=216592

Reviewed by Myles C. Maxfield.

All ports are using LocaleToScriptMappingDefault.cpp and nobody is using / building LocaleToScriptMappingICU.cpp.
Let's remove it and rename LocaleToScriptMappingDefault.cpp to LocaleToScriptMapping.cpp

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
platform/text/LocaleToScriptMapping.cpp: Renamed from Source/WebCore/platform/text/LocaleToScriptMappingDefault.cpp.
platform/text/LocaleToScriptMappingICU.cpp: Removed.

6:17 PM Changeset in webkit [267125] by commit-queue@webkit.org

3 edits
1 add in trunk

Check whether the iterator is callable in spread
https://bugs.webkit.org/show_bug.cgi?id=215974

Patch by HyeockJin Kim <kherootz@gmail.com> on 2020-09-15
Reviewed by Darin Adler.

JSTests:

stress/spread-array-iterator.js: Added.

(shouldThrowTypeError):
(shouldThrowExactly):
(f):
(C):

Source/JavaScriptCore:

builtins/IteratorHelpers.js:

(performIteration):

6:07 PM Changeset in webkit [267124] by Hector Lopez

3 edits in trunk/LayoutTests

[ macOS iOS ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections.html: Correction for test expectations
<rdar://68947198>

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations: to include wk1

5:57 PM Changeset in webkit [267123] by commit-queue@webkit.org

14 edits in trunk

Move local storage sync SPI from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216581

Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-15
Reviewed by Geoffrey Garen.

Source/WebKit:

This move is needed for https://bugs.webkit.org/show_bug.cgi?id=216041
We no longer need to sync the legacy private browsing storage because it is no longer used by WebKitTestRunner. Thank goodness.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::clearLegacyPrivateBrowsingLocalStorage): Deleted.

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
UIProcess/API/C/WKContext.cpp:

(WKContextSyncLocalStorage): Deleted.
(WKContextClearLegacyPrivateBrowsingLocalStorage): Deleted.

UIProcess/API/C/WKContextPrivate.h:
UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSyncLocalStorage):

UIProcess/API/C/WKWebsiteDataStoreRef.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::syncLocalStorage): Deleted.
(WebKit::WebProcessPool::clearLegacyPrivateBrowsingLocalStorage): Deleted.

UIProcess/WebProcessPool.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::syncLocalStorage):

UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

WebKitTestRunner/TestController.cpp:

(WTR::TestController::clearLocalStorage):
(WTR::TestController::syncLocalStorage):

5:54 PM Changeset in webkit [267122] by commit-queue@webkit.org

11 edits in trunk

Move service worker testing timeout setting from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216578

Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-15
Reviewed by Geoffrey Garen.

Source/WebKit:

This is needed for https://bugs.webkit.org/show_bug.cgi?id=216041

UIProcess/API/C/WKContext.cpp:

(WKContextSetServiceWorkerFetchTimeoutForTesting): Deleted.
(WKContextResetServiceWorkerFetchTimeoutForTesting): Deleted.

UIProcess/API/C/WKContext.h:
UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetServiceWorkerFetchTimeoutForTesting):
(WKWebsiteDataStoreResetServiceWorkerFetchTimeoutForTesting):

UIProcess/API/C/WKWebsiteDataStoreRef.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setServiceWorkerTimeoutForTesting): Deleted.
(WebKit::WebProcessPool::resetServiceWorkerTimeoutForTesting): Deleted.

UIProcess/WebProcessPool.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setServiceWorkerTimeoutForTesting):
(WebKit::WebsiteDataStore::resetServiceWorkerTimeoutForTesting):

UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::setServiceWorkerFetchTimeoutForTesting):

5:50 PM Changeset in webkit [267121] by Hector Lopez

3 edits in trunk/LayoutTests

[ macOS iOS wk2 ] media/media-continues-playing-after-replace-source.html is a flaky failure
<rdar://68952824>

Unreviewed test gardening.

platform/ios/TestExpectations:
platform/mac-wk2/TestExpectations:

5:22 PM Changeset in webkit [267120] by Fujii Hironori

11 edits
2 moves in trunk/Tools

[TestRunnerShared] Add a new class UIScriptControllerCommon to implement UIScriptController::windowIsKey and UIScriptController::setWindowIsKey
https://bugs.webkit.org/show_bug.cgi?id=216469

Reviewed by Darin Adler.

Even though UIScriptController class is defined in
TestRunnerShared, UIScriptController::windowIsKey and
UIScriptController::setWindowIsKey methods were defined in the
client modules DRT and WTR. I'd like to make TestRunnerShared a
stand-alone library which doesn't depend on DRT and WTR (Bug
216465).

Add a new class UIScriptControllerCommon to host the common
methods by renaming UIScriptController.cpp.

DumpRenderTree/CMakeLists.txt:
TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::windowIsKey const):
(WTR::UIScriptController::setWindowIsKey):

WebKitTestRunner/CMakeLists.txt:
WebKitTestRunner/UIScriptControllerCommon.cpp: Renamed from Tools/WebKitTestRunner/UIScriptController.cpp.

(WTR::UIScriptControllerCommon::windowIsKey const):
(WTR::UIScriptControllerCommon::setWindowIsKey):

WebKitTestRunner/UIScriptControllerCommon.h: Added.

(WTR::UIScriptControllerCommon::UIScriptControllerCommon):

WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:

(WTR::UIScriptControllerCocoa::UIScriptControllerCocoa):

WebKitTestRunner/gtk/UIScriptControllerGtk.h:

(WTR::UIScriptControllerGtk::UIScriptControllerGtk):

WebKitTestRunner/win/UIScriptControllerWin.h:

(WTR::UIScriptControllerWin::UIScriptControllerWin):

WebKitTestRunner/wpe/UIScriptControllerWPE.h:

5:15 PM Changeset in webkit [267119] by Alan Coon

17 edits in branches/safari-610.2.5.1-branch

Cherry-pick r266121. rdar://problem/68949249

[macOS] Update audio arbitration manager when audio transport changes
https://bugs.webkit.org/show_bug.cgi?id=215781
<rdar://problem/65920613>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, updated AudioRoutingArbitration API test.

platform/audio/AudioSession.cpp: (WebCore::AudioSession::audioOutputDeviceChanged): Add empty method. (WebCore::setIsPlayingToBluetoothOverride): Ditto.
platform/audio/AudioSession.h:

platform/audio/cocoa/MediaSessionManagerCocoa.h:
platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::audioOutputDeviceChanged): Call AudioSession::audioOutputDeviceChanged.

platform/audio/mac/AudioSessionMac.mm: (WebCore::defaultDeviceTransportIsBluetooth): New. (WebCore::AudioSession::audioOutputDeviceChanged): Clear m_private->playingToBluetooth if bluetooth transport has changed since the last arbitration update. (WebCore::AudioSession::setIsPlayingToBluetoothOverride): Allow override of bluetooth transport for testing. (WebCore::AudioSession::setCategory): Update routing arbitration if audio session category or bluetooth transport changes.

testing/Internals.cpp: (WebCore::Internals::setIsPlayingToBluetoothOverride):
testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
UIProcess/API/Cocoa/WKWebViewTesting.mm: (-[WKWebView _audioRoutingArbitrationUpdateTime]):

UIProcess/Media/AudioSessionRoutingArbitratorProxy.h: (WebKit::AudioSessionRoutingArbitratorProxy::arbitrationUpdateTime const):

UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm: (WebKit::AudioSessionRoutingArbitratorProxy::beginRoutingArbitrationWithCategory):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm: (AudioRoutingArbitration::statusShouldBecomeEqualTo): Add message string to help debugging when the test fails.
TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:13 PM Changeset in webkit [267118] by Alan Coon

8 edits in branches/safari-610.2.5.1-branch/Source

Versioning.

WebKit-7610.2.5.1.2

5:09 PM Changeset in webkit [267117] by Alan Coon

17 edits in branches/safari-610-branch

Cherry-pick r266121. rdar://problem/68949237

[macOS] Update audio arbitration manager when audio transport changes
https://bugs.webkit.org/show_bug.cgi?id=215781
<rdar://problem/65920613>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, updated AudioRoutingArbitration API test.

platform/audio/AudioSession.cpp: (WebCore::AudioSession::audioOutputDeviceChanged): Add empty method. (WebCore::setIsPlayingToBluetoothOverride): Ditto.
platform/audio/AudioSession.h:

platform/audio/cocoa/MediaSessionManagerCocoa.h:
platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::audioOutputDeviceChanged): Call AudioSession::audioOutputDeviceChanged.

platform/audio/mac/AudioSessionMac.mm: (WebCore::defaultDeviceTransportIsBluetooth): New. (WebCore::AudioSession::audioOutputDeviceChanged): Clear m_private->playingToBluetooth if bluetooth transport has changed since the last arbitration update. (WebCore::AudioSession::setIsPlayingToBluetoothOverride): Allow override of bluetooth transport for testing. (WebCore::AudioSession::setCategory): Update routing arbitration if audio session category or bluetooth transport changes.

testing/Internals.cpp: (WebCore::Internals::setIsPlayingToBluetoothOverride):
testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
UIProcess/API/Cocoa/WKWebViewTesting.mm: (-[WKWebView _audioRoutingArbitrationUpdateTime]):

UIProcess/Media/AudioSessionRoutingArbitratorProxy.h: (WebKit::AudioSessionRoutingArbitratorProxy::arbitrationUpdateTime const):

UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm: (WebKit::AudioSessionRoutingArbitratorProxy::beginRoutingArbitrationWithCategory):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm: (AudioRoutingArbitration::statusShouldBecomeEqualTo): Add message string to help debugging when the test fails.
TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:06 PM Changeset in webkit [267116] by mmaxfield@apple.com

4 edits in trunk/Source

[macOS Big Sur] CGFontRenderingGetFontSmoothingDisabled() is no longer useful
https://bugs.webkit.org/show_bug.cgi?id=216588
<rdar://problem/68657748>

Reviewed by Simon Fraser.

Source/WebCore:

No new tests because there is no behavior change.

platform/graphics/coretext/FontCascadeCoreText.cpp:

(WebCore::FontCascade::isSubpixelAntialiasingAvailable):

Source/WTF:

We can eliminate WebKit's use of it to eventually phase it out entirely.

wtf/PlatformHave.h:

4:51 PM Changeset in webkit [267115] by ysuzuki@apple.com

2 edits in trunk/JSTests

Unreviewed, skip construct-return-early-from-infinite-loop-for-fuzzer.js when JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=216406

We are not supporting returnEarlyFromInfiniteLoopsForFuzzing option for CLoop.

stress/construct-return-early-from-infinite-loop-for-fuzzer.js:

(vm.useJIT):

4:46 PM Changeset in webkit [267114] by Tadeu Zagallo

3 edits
1 add in trunk

Object allocation sinking forgets escaped nodes when structure changes
https://bugs.webkit.org/show_bug.cgi?id=216214
<rdar://problem/68518460>

Reviewed by Saam Barati.

JSTests:

stress/allocation-sinking-changing-structures.js: Added.

(main.v4.get v4):
(main):

Source/JavaScriptCore:

Consider the following program:

bb0:

a: NewObject
b: CreateActivation()
_: Branch(bb2, bb1)

bb1:

_: PutByOffset(a, 'x', 42)
_: PutStrucute(a, {x: 0})
_: Branch(bb2, bb1)

bb2:

_: CheckStructure(a, {x: 0})
_: PutClosureVar(b, 0, Kill:a)
_: Branch(bb3, bb2)

bb3:

c: GetClosureVar(b, 0)
_: PutByOffset(global, 'y', c)
_: Return

Due to the order we visit the program, we'll visit bb2 before bb1. The first time we visit bb2, heapAtHead will be:

#@a: ObjectAllocation({})
#@b: ActivationAllocation()
@a => #@a
@b => #@b

Now CheckStructure would always fail, so it will escape @a and heapAtTail will be:

#@a: EscapedAllocation()
#@b: ActivationAllocation()
@a => #@a
@b => #@b

And after pruning:

#@b: ActivationAllocation()
@b => #@b

Now, we'll visit bb3 and then bb1. When we visit bb1 we'll set the structure {x: 0} for the #@a and eventually visit bb2 again. This time around CheckStructure will no longer escape @a, since the allocation has the right structure, and heapAtTail will be:

#@a: ObjectAllocation({x: 0})
#@b: ActivationAllocation(0: #@a)
@b => #@b

However, we now have to merge into bb3, which has heapAtHead:

#@b: ActivationAllocation()
@b => #@b

Since we can't add the extra field to the activation, we'll end up escaping @a at the edge and therefore pruning #@b, which will leave the heap for bb3 unchanged.
That's a problem, since PutClosureVar didn't see the escaped object, but GetClosureVar thinks it's escaped. The materialization for @a will be placed after the
PutClosureVar, at end of bb2, when the node is already dead. When computing the SSA defs, the PutByOffset at bb3 will then see @a (which at this point will be a
PhantomNewObject) instead of its materialization.

The issue happens because we don't allow allocations to add extra fields while merging, but we do allow adding new structures. This results in different decisions
being made about what escapes in CheckStructure and MultiGetByOffset. To avoid this problem, we track two sets of structures: structures and structuresForMaterialization.
The first is used for checks and should never grow while the second is used for materialization and is allowed to grow.

dfg/DFGObjectAllocationSinkingPhase.cpp:

4:38 PM Changeset in webkit [267113] by sbarati@apple.com

7 edits
1 add in trunk

CustomFunctionEquivalence PropertyCondition needs to check if the structure has the property
https://bugs.webkit.org/show_bug.cgi?id=216575
<rdar://problem/68286930>

Reviewed by Yusuke Suzuki.

JSTests:

stress/has-static-property-property-condition-needs-to-check-if-structure-has-property.js: Added.

(foo):

Source/JavaScriptCore:

The CustomFunctionEquivalence PropertyCondition would only return false to
isStillValidAssumingImpurePropertyWatchpoint if the Structure's static
property table was reified or if the static property table did not contain the
property. However, this missed the obvious case of where we store to this
property in normal object storage without reifying the static property table.
The fix here is simple: we first check if the Structure's property table
has this property, and if so, return false.

This patch also renames CustomFunctionEquivalence to HasStaticProperty to
better capture what we're doing.

bytecode/ObjectPropertyCondition.h:

(JSC::ObjectPropertyCondition::hasStaticProperty):
(JSC::ObjectPropertyCondition::customFunctionEquivalence): Deleted.

bytecode/ObjectPropertyConditionSet.cpp:

(JSC::ObjectPropertyConditionSet::hasOneSlotBaseCondition const):
(JSC::ObjectPropertyConditionSet::slotBaseCondition const):
(JSC::generateConditionsForPrototypePropertyHitCustom):

bytecode/PropertyCondition.cpp:

(JSC::PropertyCondition::dumpInContext const):
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
(JSC::PropertyCondition::validityRequiresImpurePropertyWatchpoint const):
(JSC::PropertyCondition::isStillValid const):
(JSC::PropertyCondition::isWatchableWhenValid const):
(WTF::printInternal):

bytecode/PropertyCondition.h:

(JSC::PropertyCondition::hasStaticProperty):
(JSC::PropertyCondition::hash const):
(JSC::PropertyCondition::operator== const):
(JSC::PropertyCondition::customFunctionEquivalence): Deleted.

tools/JSDollarVM.cpp:

(JSC::functionCreateStaticCustomValue):
(JSC::JSDollarVM::finishCreation):

4:34 PM Changeset in webkit [267112] by mmaxfield@apple.com

6 edits in trunk/Source/WebCore

[Apple Win] Migrate the first part of SimpleFontData{CG}Win.cpp to FontCoreText.cpp
https://bugs.webkit.org/show_bug.cgi?id=216525

Reviewed by Dean Jackson.

This migrates:

Font::isProbablyOnlyUsedToRenderIcons()
Font::platformSupportsCodePoint()
Font::determinePitch()
Font::platformBoundsForGlyph()
Font::platformPathForGlyph()
Font::applyTransforms()

from the old Windows CG codepath to the Core Text codepath. This patch unifies these functions
between the Apple Windows port and the macOS / iOS ports.

Covered by existing tests.

platform/graphics/Font.cpp:

(WebCore::Font::variantCapsSupportsCharacterForSynthesis const):
(WebCore::Font::platformSupportsCodePoint const): Deleted.

platform/graphics/coretext/FontCoreText.cpp:

(WebCore::Font::platformWidthForGlyph const): Move this up into the #if !PLATFORM(WIN) section.
We don't want to migrate this one just yet because it causes a significant number of test failures,
which require more investigation.
(WebCore::Font::determinePitch):
(WebCore::Font::isProbablyOnlyUsedToRenderIcons const):

platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::Font::platformBoundsForGlyph const): Deleted.
(WebCore::Font::platformPathForGlyph const): Deleted.

platform/graphics/win/SimpleFontDataCairoWin.cpp:

(WebCore::Font::determinePitch): The WinCairo port is the only port still using the non-CG Windows
implementation of this function, so we can just move it directly into the CairoWin-specific file.

platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::Font::determinePitch): Deleted.

4:33 PM Changeset in webkit [267111] by Karl Rackler

2 edits in trunk/LayoutTests

REGRESSION (r266634): [ BigSur wk2 ] fast/selectors/text-field-selection-window-inactive-stroke-color.html is a flaky image failure
rdar://68947260

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

4:21 PM Changeset in webkit [267110] by Peng Liu

2 edits in trunk/Source/WebKit

REGRESSION (r267053): ASSERTION FAILED: videoFullscreenManager->client() == &_videoFullscreenManagerProxyClient in [WKFullScreenWindowController _completedExitFullScreen]
https://bugs.webkit.org/show_bug.cgi?id=216571

Reviewed by Jer Noble.

It is possible that an element exits fullscreen before it completely enters
fullscreen. In that case, the client of VideoFullscreenManagerProxy is nullptr.

No new tests, fixing an assertion failure when running
TestWebKitAPI.WKWebViewCloseAllMediaPresentations.ElementFullscreen.

UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController _completedExitFullScreen]):

4:08 PM Changeset in webkit [267109] by Hector Lopez

3 edits in trunk/LayoutTests

[ macOS iOS ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections.html
<rdar://68947198>

Unreviewed test gardening.

platform/ios/TestExpectations:
platform/mac-wk2/TestExpectations:

3:56 PM Changeset in webkit [267108] by ysuzuki@apple.com

6 edits
1 add in trunk

[JSC] Apply Intl.DateTimeFormat hour-cycle correctly when timeStyle is used
https://bugs.webkit.org/show_bug.cgi?id=216521

Reviewed by Ross Kirsling.

JSTests:

JSTests/stress/intl-date-time-format-date-time-style-hour-cycle.js result is now matching against V8 and SpiderMonkey,
and this new behavior is more reasonable.

stress/intl-date-time-format-date-time-style-hour-cycle.js:

(shouldBe.o.format):
(shouldBe):

stress/intl-datetimeformat-hour-cycle.js: Added.

(shouldBe):
(throw.new.Error):

test262/expectations.yaml:

Source/JavaScriptCore:

When specifying timeStyle in Intl.DateTimeFormat, we need to check that the generated format also follows to the hourCycle / hour12 options
specified in the constructor. Because dayPeriod can be included automatically, just replacing symbols after generating a pattern can dump strange result.
For example, the generated one is something like "02:12:47 PM Coordinated Universal Time". And we adjust the pattern to make it "14:12:47 PM Coordinated Universal Time"
when hourCycle H23 / H24 is specified. But this looks strange since dayPeriod "PM" should not exist when using H23 / H24.

In this patch, we revise our hour-cycle handling in Intl.DateTimeFormat. We align our behavior to SpiderMonkey's one[1] rather than the spec's one: when hour12 is specified,
we will just use 'H' or 'h' skeleton and do not enforce hour-cycle after generating pattern in hour12 case. If hour12 is not specified, then we use 'h' or 'H' skeleton
symbols based on hour-cycle, and later we modify the pattern based on hour-cycle. If both are not offered, we use 'j' which allows ICU to pick preferable one.
This is slightly different behavior to the spec (hcDefault etc.) but the spec's behavior can cause a bit surprising result[2,3], and SpiderMonkey like behavior will be
integrated into the spec eventually[4].

[1]: https://github.com/tc39/ecma402/issues/402#issuecomment-623628320
[2]: https://github.com/tc39/ecma402/issues/402
[3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1045791
[4]: https://github.com/tc39/ecma402/pull/436

runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::setFormatsFromPattern):
(JSC::IntlDateTimeFormat::parseHourCycle):
(JSC::IntlDateTimeFormat::hourCycleFromPattern):
(JSC::IntlDateTimeFormat::replaceHourCycleInSkeleton):
(JSC::IntlDateTimeFormat::replaceHourCycleInPattern):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::hourCycleString):
(JSC::IntlDateTimeFormat::resolvedOptions const):
(JSC::IntlDateTimeFormat::createDateIntervalFormatIfNecessary):

runtime/IntlDateTimeFormat.h:

3:37 PM Changeset in webkit [267107] by Chris Dumez

5 edits in trunk

ScriptProcessorNode should throw when trying to change its channel count or channel count mode
https://bugs.webkit.org/show_bug.cgi?id=216583

Reviewed by Geoffrey Garen.

Source/WebCore:

ScriptProcessorNode should throw when trying to change its channel count or channel count mode:

No new tests, rebaselined existing test.

Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::setChannelCount):
(WebCore::ScriptProcessorNode::setChannelCountMode):

Modules/webaudio/ScriptProcessorNode.h:

LayoutTests:

Rebaseline test now that more checks are passing.

webaudio/dom-exceptions-expected.txt:

3:25 PM Changeset in webkit [267106] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

CRASH: Exception thrown from -[AVContentKeyRequest makeStreamingContentKeyRequestDataForApp:contentIdentifier:options:completionHandler:]
https://bugs.webkit.org/show_bug.cgi?id=216580
<rdar://problem/68866834>

Reviewed by Eric Carlson.

Protect against undocumented exceptions thrown from AVContentKeySession (and related) APIs by wrapping in @try/@catch blocks and firing
the correct failure callbacks if an exception is encountered.

platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequests):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):

3:05 PM Changeset in webkit [267105] by Chris Dumez

1 edit
2 adds in trunk/LayoutTests

Import webaudio/dom-exceptions.html layout test from Blink
https://bugs.webkit.org/show_bug.cgi?id=216579

Reviewed by Geoffrey Garen.

Import webaudio/dom-exceptions.html layout test from Blink to extend test coverage.

webaudio/dom-exceptions-expected.txt: Added.
webaudio/dom-exceptions.html: Added.

3:04 PM Changeset in webkit [267104] by Alan Coon

1 copy in tags/Safari-610.1.28.1.9

Tag Safari-610.1.28.1.9.

3:02 PM Changeset in webkit [267103] by Alan Coon

2 edits in branches/safari-610.1.28.1-branch/Source/WebKit

Cherry-pick r265930. rdar://problem/67364262

Fix null pointer crashes in network process after r265835

https://bugs.webkit.org/show_bug.cgi?id=215626

<rdar://problem/67268892>

Call the correct CompletionHandler. completionHandler has already been moved from at this point.
This crash was being hit in the test, but the test recovered from it.

NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:58 PM Changeset in webkit [267102] by ysuzuki@apple.com

4 edits in trunk

[JSC] Intl.Collator should take collation option
https://bugs.webkit.org/show_bug.cgi?id=216529

Reviewed by Ross Kirsling.

JSTests:

stress/intl-collator-co-extension.js:

(shouldThrow):

Source/JavaScriptCore:

This patch adds "collation" option to Intl.Collator. We are already getting consensus[1], and will be integrated into the spec.
Previously, passing "collation" is only available through "-u-co-" unicode extension in the passed locale. The proposal exposes
collation option as an option to Intl.Collator so that we can set it easily.
"collation" is used only when "usage" is "sort". "search" usage will filter out collation options since "search" itself is one of
the "collation" option.

[1]: https://github.com/tc39/ecma402/pull/459

runtime/IntlCollator.cpp:

(JSC::IntlCollator::sortLocaleData):
(JSC::IntlCollator::initializeCollator):

2:43 PM Changeset in webkit [267101] by Fujii Hironori

2 edits in trunk/Source/WebCore

preprocessor.pm: Use Cygwin::win_to_posix_path and Cygwin::posix_to_win_path instead of cygpath command
https://bugs.webkit.org/show_bug.cgi?id=216527

Reviewed by Darin Adler.

bindings/scripts/preprocessor.pm:

(applyPreprocessor): Use shellwords() to split the $preprocessor.
Use Cygwin Perl's builtin functions instead of spawning process.

2:41 PM Changeset in webkit [267100] by Hector Lopez

3 edits in trunk/LayoutTests

[ macOS iOS ] imported/w3c/web-platform-tests/css/css-flexbox/quirks-auto-block-size-with-percentage-item.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=216292

Unreviewed test gardening!.

platform/mac-wk1/TestExpectations: adjustment for Debug
platform/mac-wk2/TestExpectations: adjustment for Debug

2:28 PM Changeset in webkit [267099] by Alan Coon

8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.9

1:59 PM Changeset in webkit [267098] by weinig@apple.com

22 edits in trunk

Remove runtime setting for enabling/disabling the fetch API
https://bugs.webkit.org/show_bug.cgi?id=216519

Reviewed by Alex Christensen.

Remove runtime setting for enabling/disabling the fetch API. There is no
reason one needs to disable it now and it has been on by default for
a long enough time.

Source/WebCore:

Modules/fetch/FetchBody.idl:
Modules/fetch/FetchHeaders.idl:
Modules/fetch/FetchRequest.idl:
Modules/fetch/FetchResponse.idl:
Modules/fetch/WindowOrWorkerGlobalScopeFetch.idl:
page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setFetchAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::fetchAPIEnabled const): Deleted.

Source/WebKit:

Also cleans up WKPreferencesRefPrivate.h/WKPreferences.cpp to move all the obsolete
preferences to the bottom with a comment about removing them when possible.

Shared/WebPreferences.yaml:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesResetTestRunnerOverrides):
(WKPreferencesSetPrivateBrowsingEnabled):
(WKPreferencesGetPrivateBrowsingEnabled):
(WKPreferencesSetIgnoreViewportScalingConstraints):
(WKPreferencesGetIgnoreViewportScalingConstraints):
(WKPreferencesSetWebRTCLegacyAPIEnabled):
(WKPreferencesGetWebRTCLegacyAPIEnabled):
(WKPreferencesSetNewBlockInsideInlineModelEnabled):
(WKPreferencesGetNewBlockInsideInlineModelEnabled):
(WKPreferencesSetLongMousePressEnabled):
(WKPreferencesGetLongMousePressEnabled):
(WKPreferencesSetAntialiasedFontDilationEnabled):
(WKPreferencesGetAntialiasedFontDilationEnabled):
(WKPreferencesSetHixie76WebSocketProtocolEnabled):
(WKPreferencesGetHixie76WebSocketProtocolEnabled):
(WKPreferencesSetApplicationChromeModeEnabled):
(WKPreferencesGetApplicationChromeModeEnabled):
(WKPreferencesSetInspectorUsesWebKitUserInterface):
(WKPreferencesGetInspectorUsesWebKitUserInterface):
(WKPreferencesSetFetchAPIEnabled):
(WKPreferencesGetFetchAPIEnabled):

UIProcess/API/C/WKPreferencesRefPrivate.h:

Source/WebKitLegacy/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setFetchAPIEnabled:]):
(-[WebPreferences fetchAPIEnabled]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::fetchAPIEnabled):
(WebPreferences::setFetchAPIEnabled):

WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

DumpRenderTree/TestRunner.h:
DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

1:44 PM Changeset in webkit [267097] by Ryan Haddad

2 edits in trunk/Source/WebCore

Unreviewed, fix the build with recent SDKs.
rdar://68939059

platform/graphics/coretext/FontCascadeCoreText.cpp:

(WebCore::FontCascade::isSubpixelAntialiasingAvailable):

1:04 PM Changeset in webkit [267096] by Jonathan Bedard

2 edits
2 adds in trunk/Tools

[webkitscmpy] Add Contributor object
https://bugs.webkit.org/show_bug.cgi?id=216402

<rdar://problem/68702680>

Reviewed by Dewei Zhu.

Scripts/libraries/webkitscmpy/webkitscmpy/init.py:
Scripts/libraries/webkitscmpy/webkitscmpy/contributor.py: Added.

(Contributor): Object mapping a contributor by name to their associated email addresses.
(Contributor.clear): Clear the in-memory cache of Contributor objects.
(Contributor.from_scm_log): Find or generate a Contributor object given a commit log line from
an SCM tool.
(Contributor.init):
(Contributor.email): Return a single email for a Contributor.
(Contributor.repr):
(Contributor.hash):
(Contributor.cmp):
(Contributor.eq):
(Contributor.ne):
(Contributor.lt):
(Contributor.le):
(Contributor.gt):
(Contributor.ge):

Scripts/libraries/webkitscmpy/webkitscmpy/test/contributor_unittest.py: Added.

(TestContributor):
(TestContributor.test_git_log):
(TestContributor.test_svn_log):
(TestContributor.test_svn_patch_by_log):
(TestContributor.test_author_mapping):
(TestContributor.test_email_mapping):
(TestContributor.test_invalid_log):
(TestContributor.test_comparison):
(TestContributor.test_string_comparison):
(TestContributor.test_hash):
(TestContributor.test_sorting):

12:43 PM Changeset in webkit [267095] by weinig@apple.com

18 edits in trunk

Remove runtime setting for enabling/disabling custom elements
https://bugs.webkit.org/show_bug.cgi?id=216518

Reviewed by Tim Horton.

Remove runtime setting for enabling/disabling custom elements. There is no
reason one need to disable it now, and it has been on by default for
a long enough time.

Source/WebCore:

dom/CustomElementRegistry.idl:
dom/Document.cpp:

(WebCore::createUpgradeCandidateElement):

page/DOMWindow.idl:
page/Settings.yaml:

Source/WebKit:

Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setCustomElementsEnabled:]):
(-[WebPreferences customElementsEnabled]):

WebView/WebPreferencesPrivate.h:

Source/WebKitLegacy/win:

WebPreferences.cpp:

(WebPreferences::customElementsEnabled):
(WebPreferences::setCustomElementsEnabled):

WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

11:57 AM Changeset in webkit [267094] by Chris Dumez

3 edits in trunk/Source/WebCore

Improve thread-safety in ScriptProcessorNode implementation
https://bugs.webkit.org/show_bug.cgi?id=216555

Reviewed by Geoffrey Garen.

Improve thread-safety in ScriptProcessorNode implementation:

Use a Lock instead of a volatile bool to determine if the main thread is still busy firing the event.
Pass the doubleBufferIndex to the main thread by capturing it in the lambda instead of relying on a data member.

Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):
(WebCore::ScriptProcessorNode::fireProcessEvent):

Modules/webaudio/ScriptProcessorNode.h:

11:49 AM Changeset in webkit [267093] by Jonathan Bedard

7 edits in trunk/Tools

[webkitscmpy] Add default_branch for local SCM repositories
https://bugs.webkit.org/show_bug.cgi?id=216422
<rdar://problem/68735897>

Reviewed by Dewei Zhu.

Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git.default_branch): Query the local checkout for the default branch.
(Git):
(Git.branches): Strip "remotes/origin/" from branch names.

Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:

(Scm.default_branch):

Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:

(Svn.default_branch): The default svn branch is always 'trunk'.

Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:

(TestGit.test_branches):
(TestGit.test_tags):
(TestGit):
(TestGit.test_default_branch):

Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:

(TestSvn.test_tags):
(TestSvn):
(TestSvn.test_default_branch):

11:39 AM Changeset in webkit [267092] by Simon Fraser

4 edits in trunk

REGRESSION (r267002): ASSERTION FAILED:[ iOS wk2 Debug ] !HashTranslator::equal(KeyTraits::emptyValue(), key) on compositing/ios/overflow-scroll-update-overlap.html
https://bugs.webkit.org/show_bug.cgi?id=216520
<rdar://problem/68894931>

Reviewed by Tim Horton.

Source/WebKit:

Avoid hash lookups with zero nodeIDs.

WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:

(WebKit::RemoteScrollingCoordinator::isRubberBandInProgress const):
(WebKit::RemoteScrollingCoordinator::isUserScrollInProgress const):
(WebKit::RemoteScrollingCoordinator::isScrollSnapInProgress const):

LayoutTests:

platform/ios-wk2/TestExpectations:

11:25 AM Changeset in webkit [267091] by achristensen@apple.com

14 edits in trunk

Move WKContextClearCachedCredentials SPI to WKWebsiteDataStoreClearCachedCredentials
https://bugs.webkit.org/show_bug.cgi?id=216513

Reviewed by Chris Dumez.

Source/WebKit:

The credentials are owned by session anyways.
This is needed for https://bugs.webkit.org/show_bug.cgi?id=216041

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::clearCachedCredentials):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
UIProcess/API/C/WKContext.cpp:

(WKContextClearCachedCredentials): Deleted.

UIProcess/API/C/WKContextPrivate.h:
UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreClearCachedCredentials):

UIProcess/API/C/WKWebsiteDataStoreRef.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::clearCachedCredentials):

UIProcess/WebProcessPool.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::clearCachedCredentials):

UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

11:07 AM Changeset in webkit [267090] by achristensen@apple.com

20 edits in trunk

Remove unused plumbing for setting whether the storage access API is enabled
https://bugs.webkit.org/show_bug.cgi?id=216516

Reviewed by Youenn Fablet.

Source/WebCore:

Sending a boolean from the process pool to the network process has been superceded by a preference in WebPreferences.yaml.
The boolean sent to the network process was not even used any more.

platform/network/NetworkStorageSession.h:
platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::setStorageAccessAPIEnabled): Deleted.

Source/WebKit:

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

NetworkProcess/NetworkProcessCreationParameters.h:
NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
(WebKit::NetworkProcess::setStorageAccessAPIEnabled): Deleted.

UIProcess/API/C/WKContext.cpp:

(WKContextSetStorageAccessAPIEnabled): Deleted.

UIProcess/API/C/WKContext.h:
UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetStorageAccessAPIEnabled): Deleted.

UIProcess/API/C/WKCookieManager.h:
UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _isStorageAccessAPIEnabled]): Deleted.
(-[WKProcessPool _setStorageAccessAPIEnabled:]): Deleted.

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setStorageAccessAPIEnabled): Deleted.

UIProcess/WebProcessPool.h:

Tools:

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

10:04 AM Changeset in webkit [267089] by weinig@apple.com

10 edits
2 copies
1 add
6 deletes in trunk/Source/WebCore

[WebIDL] Update Fetch IDLs to use WindowOrWorkerGlobalScope partial mixin
https://bugs.webkit.org/show_bug.cgi?id=216524

Reviewed by Darin Adler.

Move global fetch() function definition from DOMWindowFetch.idl & WorkerGlobalScopeFetch.idl
to single WindowOrWorkerGlobalScopeFetch.idl, matching the spec.

Also cleanup some comments in other Fetch related IDLs.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/fetch/DOMWindowFetch.cpp: Removed.
Modules/fetch/DOMWindowFetch.h: Removed.
Modules/fetch/DOMWindowFetch.idl: Removed.
Modules/fetch/FetchRequest.idl:
Modules/fetch/FetchRequestInit.idl:
Modules/fetch/FetchResponse.idl:
Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp: Added.

(WebCore::WindowOrWorkerGlobalScopeFetch::fetch):

Modules/fetch/WindowOrWorkerGlobalScopeFetch.h: Added.
Modules/fetch/WindowOrWorkerGlobalScopeFetch.idl: Added.
Modules/fetch/WorkerGlobalScopeFetch.cpp: Removed.
Modules/fetch/WorkerGlobalScopeFetch.h: Removed.
Modules/fetch/WorkerGlobalScopeFetch.idl: Removed.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:

9:28 AM Changeset in webkit [267088] by commit-queue@webkit.org

14 edits in trunk

Move WebSocket TLS bypass SPI from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216509

Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-15
Reviewed by Youenn Fablet.

Source/WebKit:

After https://bugs.webkit.org/show_bug.cgi?id=216041 we will be unable to determine which WebsiteDataStore's
NetworkProcess to add the TLS bypass to, so we need to move the SPI to the WebsiteDataStore object. This breaks
off a piece of that large change into a small, easy-to-review change.

UIProcess/API/C/WKContext.cpp:

(WKContextSetAllowsAnySSLCertificateForWebSocketTesting): Deleted.

UIProcess/API/C/WKContextPrivate.h:
UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetAllowsAnySSLCertificateForWebSocketTesting):

UIProcess/API/C/WKWebsiteDataStoreRef.h:
UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _allowAnyTLSCertificateForWebSocketTesting]): Deleted.

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setAllowsAnySSLCertificateForWebSocket): Deleted.

UIProcess/WebProcessPool.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setAllowsAnySSLCertificateForWebSocket):

UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

WebKitTestRunner/TestController.cpp:

(WTR::TestController::setAllowsAnySSLCertificate):

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::setAllowsAnySSLCertificate):

9:16 AM Changeset in webkit [267087] by Alan Bujtas

3 edits
1 add in trunk/Source/WebCore

[LFC] Move Layout::Rect to a dedicated file
https://bugs.webkit.org/show_bug.cgi?id=216553

Reviewed by Antti Koivisto.

WebCore.xcodeproj/project.pbxproj:
layout/layouttree/LayoutBoxGeometry.h:

(WebCore::Layout::Rect::expandHorizontally): Deleted.
(WebCore::Layout::Rect::expandVertically): Deleted.
(WebCore::Layout::Rect::intersects const): Deleted.
(WebCore::Layout::Rect::invalidateTop): Deleted.
(WebCore::Layout::Rect::invalidateLeft): Deleted.
(WebCore::Layout::Rect::invalidateWidth): Deleted.
(WebCore::Layout::Rect::invalidateHeight): Deleted.
(WebCore::Layout::Rect::hasValidPosition const): Deleted.
(WebCore::Layout::Rect::hasValidSize const): Deleted.
(WebCore::Layout::Rect::hasValidGeometry const): Deleted.
(WebCore::Layout::Rect::Rect): Deleted.
(WebCore::Layout::Rect::invalidatePosition): Deleted.
(WebCore::Layout::Rect::setHasValidPosition): Deleted.
(WebCore::Layout::Rect::setHasValidSize): Deleted.
(WebCore::Layout::Rect::top const): Deleted.
(WebCore::Layout::Rect::left const): Deleted.
(WebCore::Layout::Rect::bottom const): Deleted.
(WebCore::Layout::Rect::right const): Deleted.
(WebCore::Layout::Rect::topLeft const): Deleted.
(WebCore::Layout::Rect::bottomRight const): Deleted.
(WebCore::Layout::Rect::size const): Deleted.
(WebCore::Layout::Rect::width const): Deleted.
(WebCore::Layout::Rect::height const): Deleted.
(WebCore::Layout::Rect::setTopLeft): Deleted.
(WebCore::Layout::Rect::setTop): Deleted.
(WebCore::Layout::Rect::setLeft): Deleted.
(WebCore::Layout::Rect::setWidth): Deleted.
(WebCore::Layout::Rect::setHeight): Deleted.
(WebCore::Layout::Rect::setSize): Deleted.
(WebCore::Layout::Rect::shiftLeftTo): Deleted.
(WebCore::Layout::Rect::shiftRightTo): Deleted.
(WebCore::Layout::Rect::shiftTopTo): Deleted.
(WebCore::Layout::Rect::shiftBottomTo): Deleted.
(WebCore::Layout::Rect::moveHorizontally): Deleted.
(WebCore::Layout::Rect::moveVertically): Deleted.
(WebCore::Layout::Rect::expand): Deleted.
(WebCore::Layout::Rect::clone const): Deleted.
(WebCore::Layout::Rect::operator LayoutRect const): Deleted.

layout/layouttree/LayoutGeometryRect.h: Added.

7:55 AM Changeset in webkit [267086] by svillar@igalia.com

4 edits in trunk

[css-flexbox] Indefinite flex-basis percentage should cause height to be ignored
https://bugs.webkit.org/show_bug.cgi?id=210077

Reviewed by Darin Adler.

Source/WebCore:

If flex-basis is a percentage of an indefinite height we should ignore
what height specifies and treat it and as height:auto.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::cacheChildMainSize): Cache the intrinsic height of the child when
flex-basis is a percentage of an indefinite length.

LayoutTests:

TestExpectations: Removed flex-basis-010.html which is passing now.

7:35 AM Changeset in webkit [267085] by Aditya Keerthi

2 edits in trunk/Source/WebKit

[macOS] Update date picker appearance to match system date pickers
https://bugs.webkit.org/show_bug.cgi?id=216517
<rdar://problem/68890678>

Reviewed by Wenson Hsieh.

System date pickers in macOS do not use NSVisualEffectView. Instead, use
a solid background view with three rounded corners.

UIProcess/mac/WebDateTimePickerMac.mm:

(-[WKDateTimePickerWindow initWithContentRect:styleMask:backing:defer:]):
(-[WKDateTimePickerBackdropView drawRect:]):
(-[WKDateTimePicker initWithParams:inView:]):

7:24 AM Changeset in webkit [267084] by Diego Pino Garcia

3 edits
1 move
2 adds
2 deletes in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Update baselines and expectations after r267083.

platform/glib/TestExpectations:
platform/glib/fast/text/justify-ideograph-leading-expansion-expected.png: Updated after r267010.
platform/glib/fast/text/justify-ideograph-leading-expansion-expected.txt: Renamed from LayoutTests/platform/wpe/fast/text/justify-ideograph-leading-expansion-expected.txt.
platform/gtk/fast/repaint/spanner-with-margin-expected.txt: Updated after r266818.
platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.png: Removed.
platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.txt: Removed.

4:36 AM Changeset in webkit [267083] by commit-queue@webkit.org

50 edits in trunk

Convert runtime flag to setting for lazy image loading
https://bugs.webkit.org/show_bug.cgi?id=215610

Patch by Rob Buis <rbuis@igalia.com> on 2020-09-15
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Remove the webkit-test-runner directive additions done to the lazy image loading tests.
The new expected results are improvements.

web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/disconnected-image-loading-lazy.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-eager.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-2-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-crossorigin-change.sub.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-001.sub-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-002.sub-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-script-disabled-iframe.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multicol.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-relevant-mutations-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-srcset-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/move-element-and-scroll.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-below-viewport-image-loading-lazy.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-image-loading-lazy.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html:

Source/WebCore:

Convert runtime flag to setting for lazy image loading. Settings are
preferred over RuntimeEnabledFeatures as they are not global singletons
and are automatically accessible in layout tests via InternalSettingsGenerated.

loader/ImageLoader.cpp:

Source/WebKit:

Remove lazy image loading runtime flag.

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLazyImageLoadingEnabled): Deleted.
(WKPreferencesGetLazyImageLoadingEnabled): Deleted.

UIProcess/API/C/WKPreferencesRefPrivate.h:

Tools:

Remove lazy image loading runtime flag.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Update test expectations and adjust the tests in http/tests/lazyload/ to
enable the setting. Fow WK1 list more tests that should be skipped.

TestExpectations:
http/tests/lazyload/attribute.html:
http/tests/lazyload/js-image.html:
http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html:
http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html:
http/tests/lazyload/lazy.html:
http/tests/lazyload/resources/lazy-load-in-iframe.html:
platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
platform/mac-wk1/TestExpectations:
platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:

2:02 AM Changeset in webkit [267082] by commit-queue@webkit.org

2 edits in trunk/Tools

run-jsc-stress-tests: handle remotes that are down on startup
https://bugs.webkit.org/show_bug.cgi?id=216357

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-09-15
Reviewed by Yusuke Suzuki.

Previously, the GNU parallel runner would needlessly fail to run if a
remote host was down on startup, as it used forEachRemote for the
preparatory steps (which would instafail on error).

Change forEachRemote to (optionally) recover from failure by removing
the remote host from the array. This also handles the case where a
remote unexpectedly comes up during a test run (by not picking it up).

Scripts/run-jsc-stress-tests:

1:56 AM Changeset in webkit [267081] by youenn@apple.com

14 edits in trunk

End of media capture should not be reported before 3 seconds of the start of capture
https://bugs.webkit.org/show_bug.cgi?id=216415
Source/WebCore:

Reviewed by Eric Carlson.

Add a timer that allows taking a function and a delay as parameter.
Covered by added API test.

platform/Timer.h:

(WebCore::DeferrableTaskTimer::fired):
(WebCore::DeferrableTaskTimer::doTask):
(WebCore::DeferrableTaskTimer::cancel):

Source/WebKit:

<rdar://problem/68512358>

Reviewed by Eric Carlson.

Add support for delaying of end of capture notification to the application.
This allows to ensure that a capture indicator stays for long enough for the user to notice it.
A capture indicator should be visible to the user for at least three seconds.

A timer is scheduled when starting a capture and there is no ongoing capture.
As long as the timer is active, the capture state cannot be transitioned to no capture.
Other transitions are allowed.
Once the timer kicks in, any capture state update is done synchronously.
Ensure to update the capture state when the timer kicks in.

Note that even navigations will not allow transitioning the capture state sooner.
This is done to ensure a page does not try to capture one frame before navigating to another page.
In practice, very few pages should navigate quickly after starting capture.

UIProcess/API/C/WKPage.cpp:

(WKPageGetMediaState):
(WKPageSetMediaCaptureReportingDelayForTesting):

UIProcess/API/C/WKPagePrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _mediaCaptureState]):

UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
UIProcess/API/Cocoa/WKWebViewTesting.mm:

(-[WKWebView _mediaCaptureReportingDelayForTesting]):
(-[WKWebView _setMediaCaptureReportingDelayForTesting:]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updatePlayingMediaDidChange):
(WebKit::WebPageProxy::updateReportedMediaCaptureState):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::reportedMediaCaptureState const):
(WebKit::WebPageProxy::mediaCaptureReportingDelay const):
(WebKit::WebPageProxy::setMediaCaptureReportingDelay):

Tools:

Reviewed by Eric Carlson.

TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

(-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
Add a notCapturing boolean and wait for the notification before going back to the capturing page.
Decrease delay to 1 second to make the test run faster.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
Make sure to set media capture state delay to zero.

1:55 AM Changeset in webkit [267080] by jh718.park@samsung.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed. Remove the build warning below since r228533.
warning: ‘%40s’ directive argument is null [-Wformat-overflow=]

Since gcc which has version >= 9 is stricter about passing null string
pointers to printf-like functions, add null string pointer check
to fix the warning proactively.

jsc.cpp:

(runJSC):

12:13 AM Changeset in webkit [267079] by youenn@apple.com

9 edits in trunk/Source/WebKit

Enable VP9 in GPUProcess if page needs it
https://bugs.webkit.org/show_bug.cgi?id=216472

Reviewed by Eric Carlson.

In case a page is using GPUProcess for media, send the VP9 parameters to GPUProcess.
GPUProcess will enable VP9 decoders based on that input.
Covered by LayoutTests/media/vp9.html with GPU process enabled.

GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::enableVP9Decoders):

GPUProcess/GPUConnectionToWebProcess.h:
GPUProcess/GPUConnectionToWebProcess.messages.in:
GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::enableVP9Decoders):

GPUProcess/GPUProcess.h:
WebProcess/GPU/GPUProcessConnection.cpp:

(WebKit::GPUProcessConnection::updateParameters):

WebProcess/GPU/GPUProcessConnection.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):

Sep 14, 2020:

11:25 PM Changeset in webkit [267078] by Carlos Garcia Campos

6 edits in trunk/Source/WebDriver

REGRESSION(r266885): WebDriver is broken since r266885
https://bugs.webkit.org/show_bug.cgi?id=216477

Reviewed by Devin Rousso.

There are several issues introduced in r266885, most of them related to JSValue::get methods now returning an
optional. In some cases of boolean values, the optional is checked instead of the contained bool or the logic is
inverted. JSONValue::getString() is problematic too because it doesn't use optional, when you call getString()
and null is returned it could be because the property is not present in the object or because the property is
not a string. In several cases we need to know that so we need to first get the value and then call asString(9
instead of calling getString() directly.

Session.cpp:

(WebDriver::Session::handleUserPrompts): Check the value of isShowingJavaScriptDialog, not the optional.
(WebDriver::parseAutomationCookie): Check also the value of the session optional bool, not only the optional.

SessionHost.cpp:

(WebDriver::SessionHost::dispatchMessage): Only set the responseObject if the object is not empty.

WebDriverService.cpp:

(WebDriver::WebDriverService::newWindow): Unknown values of type hint are not an error.
(WebDriver::WebDriverService::deleteCookie): Fix indentation.
(WebDriver::processKeyAction): Empty key value is an error, not the opposite.

gtk/WebDriverServiceGtk.cpp:

(WebDriver::WebDriverService::platformValidateCapability const): Only fail if optional values are wrong type,
not if they are not present.

wpe/WebDriverServiceWPE.cpp:

(WebDriver::WebDriverService::platformValidateCapability const): Ditto.

10:57 PM Changeset in webkit [267077] by Fujii Hironori

2 edits in trunk/Source/WebCore

[WinCairo] Unreviewed debug build fix after r267073
https://bugs.webkit.org/show_bug.cgi?id=216448

platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::description const): Added.

10:52 PM Changeset in webkit [267076] by Alan Bujtas

38 edits
2 moves in trunk/Source/WebCore

[LFC] Layout::BoxGeometry rename, part II.
https://bugs.webkit.org/show_bug.cgi?id=216523

Reviewed by Simon Fraser.

Rename Layout::Geometry to Layout::BoxGeometry (so that later we can introduce Layout::LineGeometry and Layout::RunGeometry) and
make sure we don't use displayBox as a variable name in Layout namespace.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::computeBorderAndPadding):
(WebCore::Layout::FormattingContext::geometryForBox const):

layout/FormattingContext.h:
layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::staticVerticalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::staticHorizontalPositionForOutOfFlowPositioned const):

layout/FormattingContextQuirks.cpp:
layout/FormattingState.cpp:

(WebCore::Layout::FormattingState::boxGeometry):
(WebCore::Layout::FormattingState::displayBox): Deleted.

layout/FormattingState.h:
layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::layout):
(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):

layout/LayoutState.cpp:

(WebCore::Layout::LayoutState::geometryForRootBox):
(WebCore::Layout::LayoutState::ensureGeometryForBoxSlow):
(WebCore::Layout::LayoutState::geometryForRootLayoutBox): Deleted.
(WebCore::Layout::LayoutState::ensureDisplayBoxForLayoutBoxSlow): Deleted.

layout/LayoutState.h:

(WebCore::Layout::LayoutState::hasBoxGeometry const):
(WebCore::Layout::LayoutState::ensureGeometryForBox):
(WebCore::Layout::LayoutState::geometryForBox const):
(WebCore::Layout::Box::cachedGeometryForLayoutState const):
(WebCore::Layout::LayoutState::hasDisplayBox const): Deleted.
(WebCore::Layout::LayoutState::ensureGeometryForLayoutBox): Deleted.
(WebCore::Layout::LayoutState::geometryForLayoutBox const): Deleted.
(WebCore::Layout::Box::cachedDisplayBoxForLayoutState const): Deleted.

layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForBoxAndAncestors):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):

layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

layout/blockformatting/BlockFormattingContextQuirks.cpp:
layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::hasClearance const):

layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:

(WebCore::Layout::TableWrapperBlockFormattingContext::computeBorderAndPaddingForTableBox):
(WebCore::Layout::TableWrapperBlockFormattingContext::computeWidthAndMarginForTableBox):
(WebCore::Layout::TableWrapperBlockFormattingContext::computeHeightAndMarginForTableBox):

layout/display/DisplayLayerController.cpp:

(WebCore::Display::LayerController::prepareForDisplay):

layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintBoxDecoration):
(WebCore::Display::Painter::absoluteBoxGeometry):
(WebCore::Display::paintSubtree):
(WebCore::Display::collectPaintRootsAndContentRect):
(WebCore::Display::Painter::absoluteDisplayBox): Deleted.

layout/displaytree/DisplayPainter.h:
layout/floats/FloatAvoider.h:
layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForNonFloatingFloatAvoider const):
(WebCore::Layout::FloatingContext::append):
(WebCore::Layout::FloatingContext::absoluteBoxGeometryCoordinates const):
(WebCore::Layout::FloatingContext::absoluteDisplayBoxCoordinates const): Deleted.

layout/floats/FloatingContext.h:
layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::FloatItem::FloatItem):

layout/floats/FloatingState.h:

(WebCore::Layout::FloatingState::FloatItem::rectWithMargin const):
(WebCore::Layout::FloatingState::FloatItem::horizontalMargin const):
(WebCore::Layout::FloatingState::FloatItem::bottom const):

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::InlineFormattingContext::computeHorizontalMargin):
(WebCore::Layout::InlineFormattingContext::computeWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
(WebCore::Layout::InlineFormattingContext::createDisplayBoxesForLineContent): Deleted.

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineLineBox.h:
layout/inlineformatting/InlineLineBuilder.cpp:
layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::prepareFloatingState):

layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::setcachedGeometryForLayoutState const):
(WebCore::Layout::Box::setCachedDisplayBoxForLayoutState const): Deleted.

layout/layouttree/LayoutBox.h:
layout/layouttree/LayoutBoxGeometry.cpp: Renamed from Source/WebCore/layout/layouttree/LayoutGeometry.cpp.

(WebCore::Layout::BoxGeometry::BoxGeometry):
(WebCore::Layout::BoxGeometry::~BoxGeometry):
(WebCore::Layout::BoxGeometry::marginBox const):
(WebCore::Layout::BoxGeometry::borderBox const):
(WebCore::Layout::BoxGeometry::paddingBox const):
(WebCore::Layout::BoxGeometry::contentBox const):

layout/layouttree/LayoutBoxGeometry.h: Renamed from Source/WebCore/layout/layouttree/LayoutGeometry.h.

(WebCore::Layout::Rect::expandHorizontally):
(WebCore::Layout::Rect::expandVertically):
(WebCore::Layout::Rect::intersects const):
(WebCore::Layout::Rect::invalidateTop):
(WebCore::Layout::Rect::invalidateLeft):
(WebCore::Layout::Rect::invalidateWidth):
(WebCore::Layout::Rect::invalidateHeight):
(WebCore::Layout::Rect::hasValidPosition const):
(WebCore::Layout::Rect::hasValidSize const):
(WebCore::Layout::Rect::hasValidGeometry const):
(WebCore::Layout::Rect::Rect):
(WebCore::Layout::Rect::invalidatePosition):
(WebCore::Layout::Rect::setHasValidPosition):
(WebCore::Layout::Rect::setHasValidSize):
(WebCore::Layout::Rect::top const):
(WebCore::Layout::Rect::left const):
(WebCore::Layout::Rect::bottom const):
(WebCore::Layout::Rect::right const):
(WebCore::Layout::Rect::topLeft const):
(WebCore::Layout::Rect::bottomRight const):
(WebCore::Layout::Rect::size const):
(WebCore::Layout::Rect::width const):
(WebCore::Layout::Rect::height const):
(WebCore::Layout::Rect::setTopLeft):
(WebCore::Layout::Rect::setTop):
(WebCore::Layout::Rect::setLeft):
(WebCore::Layout::Rect::setWidth):
(WebCore::Layout::Rect::setHeight):
(WebCore::Layout::Rect::setSize):
(WebCore::Layout::Rect::shiftLeftTo):
(WebCore::Layout::Rect::shiftRightTo):
(WebCore::Layout::Rect::shiftTopTo):
(WebCore::Layout::Rect::shiftBottomTo):
(WebCore::Layout::Rect::moveHorizontally):
(WebCore::Layout::Rect::moveVertically):
(WebCore::Layout::Rect::expand):
(WebCore::Layout::Rect::clone const):
(WebCore::Layout::Rect::operator LayoutRect const):
(WebCore::Layout::BoxGeometry::bottom const):
(WebCore::Layout::BoxGeometry::right const):
(WebCore::Layout::BoxGeometry::bottomRight const):
(WebCore::Layout::BoxGeometry::size const):
(WebCore::Layout::BoxGeometry::width const):
(WebCore::Layout::BoxGeometry::height const):
(WebCore::Layout::BoxGeometry::isEmpty const):
(WebCore::Layout::BoxGeometry::rect const):
(WebCore::Layout::BoxGeometry::rectWithMargin const):
(WebCore::Layout::BoxGeometry::hasClearance const):
(WebCore::Layout::BoxGeometry::verticalBorder const):
(WebCore::Layout::BoxGeometry::horizontalBorder const):
(WebCore::Layout::BoxGeometry::contentBoxTop const):
(WebCore::Layout::BoxGeometry::contentBoxLeft const):
(WebCore::Layout::BoxGeometry::contentBoxBottom const):
(WebCore::Layout::BoxGeometry::contentBoxRight const):
(WebCore::Layout::BoxGeometry::paddingBoxTop const):
(WebCore::Layout::BoxGeometry::paddingBoxLeft const):
(WebCore::Layout::BoxGeometry::paddingBoxBottom const):
(WebCore::Layout::BoxGeometry::paddingBoxRight const):
(WebCore::Layout::BoxGeometry::paddingBoxHeight const):
(WebCore::Layout::BoxGeometry::paddingBoxWidth const):
(WebCore::Layout::BoxGeometry::borderBoxHeight const):
(WebCore::Layout::BoxGeometry::borderBoxWidth const):
(WebCore::Layout::BoxGeometry::marginBoxHeight const):
(WebCore::Layout::BoxGeometry::marginBoxWidth const):
(WebCore::Layout::BoxGeometry::verticalMarginBorderAndPadding const):
(WebCore::Layout::BoxGeometry::horizontalMarginBorderAndPadding const):
(WebCore::Layout::BoxGeometry::setHasPrecomputedMarginBefore):
(WebCore::Layout::BoxGeometry::moveHorizontally):
(WebCore::Layout::BoxGeometry::moveVertically):
(WebCore::Layout::BoxGeometry::move):
(WebCore::Layout::BoxGeometry::moveBy):
(WebCore::Layout::BoxGeometry::setHasClearance):
(WebCore::Layout::BoxGeometry::invalidateBorder):
(WebCore::Layout::BoxGeometry::invalidatePadding):
(WebCore::Layout::BoxGeometry::invalidatePrecomputedMarginBefore):
(WebCore::Layout::BoxGeometry::setHasValidTop):
(WebCore::Layout::BoxGeometry::setHasValidLeft):
(WebCore::Layout::BoxGeometry::setHasValidVerticalMargin):
(WebCore::Layout::BoxGeometry::setHasValidHorizontalMargin):
(WebCore::Layout::BoxGeometry::setHasValidBorder):
(WebCore::Layout::BoxGeometry::setHasValidPadding):
(WebCore::Layout::BoxGeometry::setHasValidContentHeight):
(WebCore::Layout::BoxGeometry::setHasValidContentWidth):
(WebCore::Layout::BoxGeometry::invalidateMargin):
(WebCore::Layout::BoxGeometry::top const):
(WebCore::Layout::BoxGeometry::left const):
(WebCore::Layout::BoxGeometry::topLeft const):
(WebCore::Layout::BoxGeometry::setTopLeft):
(WebCore::Layout::BoxGeometry::setTop):
(WebCore::Layout::BoxGeometry::setLeft):
(WebCore::Layout::BoxGeometry::setContentBoxHeight):
(WebCore::Layout::BoxGeometry::setContentBoxWidth):
(WebCore::Layout::BoxGeometry::contentBoxHeight const):
(WebCore::Layout::BoxGeometry::contentBoxWidth const):
(WebCore::Layout::BoxGeometry::setHorizontalMargin):
(WebCore::Layout::BoxGeometry::setVerticalMargin):
(WebCore::Layout::BoxGeometry::setBorder):
(WebCore::Layout::BoxGeometry::setPadding):
(WebCore::Layout::BoxGeometry::setVerticalPadding):
(WebCore::Layout::BoxGeometry::verticalMargin const):
(WebCore::Layout::BoxGeometry::horizontalMargin const):
(WebCore::Layout::BoxGeometry::marginBefore const):
(WebCore::Layout::BoxGeometry::marginStart const):
(WebCore::Layout::BoxGeometry::marginAfter const):
(WebCore::Layout::BoxGeometry::marginEnd const):
(WebCore::Layout::BoxGeometry::paddingTop const):
(WebCore::Layout::BoxGeometry::paddingLeft const):
(WebCore::Layout::BoxGeometry::paddingBottom const):
(WebCore::Layout::BoxGeometry::paddingRight const):
(WebCore::Layout::BoxGeometry::verticalPadding const):
(WebCore::Layout::BoxGeometry::horizontalPadding const):
(WebCore::Layout::BoxGeometry::borderTop const):
(WebCore::Layout::BoxGeometry::borderLeft const):
(WebCore::Layout::BoxGeometry::borderBottom const):
(WebCore::Layout::BoxGeometry::borderRight const):

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputLayoutBox):
(WebCore::Layout::outputLayoutTree):
(WebCore::Layout::showLayoutTree):

layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForSections):
(WebCore::Layout::TableFormattingContext::layoutCell):

layout/tableformatting/TableFormattingContextGeometry.cpp:
layout/tableformatting/TableLayout.cpp:
page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layoutUsingFormattingContext):

10:44 PM Changeset in webkit [267075] by Fujii Hironori

2 edits in trunk

[PlayStation] Enable ENABLE_SVG_FONTS
https://bugs.webkit.org/show_bug.cgi?id=216522

Reviewed by Don Olmstead.

Source/cmake/OptionsPlayStation.cmake:

10:17 PM Changeset in webkit [267074] by rniwa@webkit.org

16 edits in trunk/Source/WebCore

Element should not set an attribute inside its constructor
https://bugs.webkit.org/show_bug.cgi?id=216507

Reviewed by Wenson Hsieh.

Moved the code to add attributes from element constructors to respective ::create functions
since setting attributes could run code in parseAttribute some of which may try to store
"this" in Ref / RefPtr, which would not be safe before adoptRef is called.

No new tests since there should be no observable behavioral change.

dom/Element.cpp:

(WebCore::Element::setAttributeInternal): Added an assertion.

html/FileInputType.cpp:

(WebCore::UploadButtonElement::create):
(WebCore::UploadButtonElement::createForMultiple):
(WebCore::UploadButtonElement::createInternal): Extracted.
(WebCore::UploadButtonElement::UploadButtonElement):

html/HTMLKeygenElement.cpp:
html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::DateTimeEditElement):
(WebCore::DateTimeEditElement::create):

html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeHourFieldElement::DateTimeHourFieldElement):
(WebCore::DateTimeHourFieldElement::create):
(WebCore::DateTimeMeridiemFieldElement::DateTimeMeridiemFieldElement):
(WebCore::DateTimeMeridiemFieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeSymbolicMonthFieldElement::DateTimeSymbolicMonthFieldElement):
(WebCore::DateTimeSymbolicMonthFieldElement::create):
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement):
(WebCore::DateTimeYearFieldElement::create):

html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::create):
(WebCore::DetailsMarkerControl::DetailsMarkerControl):

html/shadow/MediaControlTextTrackContainerElement.cpp:

(WebCore::MediaControlTextTrackContainerElement::create):
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement):

html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::create):

html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlPlaceholderElement::TextControlPlaceholderElement):
(WebCore::TextControlPlaceholderElement::create):
(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
(WebCore::SearchFieldCancelButtonElement::create):

html/shadow/YouTubeEmbedShadowElement.cpp:

(WebCore::YouTubeEmbedShadowElement::create):
(WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):

html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::create): Moved from .h.
(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCueBox::initilaize): Added.

html/track/TextTrackCue.h:

(WebCore::TextTrackCueBox::create): Moved to cpp.

html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::create): Now calls initialize().

html/track/VTTCue.cpp:

(WebCore::VTTCueBox::create): Moved from .h. Now calls initialize().

html/track/VTTCue.h:

(WebCore::VTTCueBox::create): Moved to cpp.

9:19 PM Changeset in webkit [267073] by mmaxfield@apple.com

16 edits in trunk

[Apple Win] Migrate from FontPlatformDataWin.cpp to FontPlatformDataCoreText.cpp
https://bugs.webkit.org/show_bug.cgi?id=216448

Reviewed by Darin Adler.

Source/WebCore:

This is one of the steps toward migrating the Apple Win port off of CGFont and on to
CTFont. This patch removes the #if !PLATFORM(WIN) guard in FontPlatformDataCoreText.cpp
and deletes the old functions it used to be using. It fixes up the Core Text functions to
use ctFont() instead of font(), because font() returns the HFONT on Windows.

It also adds a new helper, platformOpenTypeTable(), because it looks like
CTFontCopyTable() sometimes fails, so we can use this function to fall back to using the
HFONT and the win32 API instead.

Covered by existing tests.

platform/graphics/FontPlatformData.cpp:
platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::ctFont const):
(WebCore::FontPlatformData::font const):

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::platformOpenTypeTable const):

platform/graphics/coretext/FontPlatformDataCoreText.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::registeredFont const):
(WebCore::FontPlatformData::ctFont const):
(WebCore::FontPlatformData::openTypeTable const):
(WebCore::FontPlatformData::description const):
(WebCore::FontPlatformData::familyName const):

platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):

platform/graphics/win/FontCustomPlatformData.h:

(WebCore::FontCustomPlatformData::FontCustomPlatformData):

platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):

platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::openTypeTable const):

platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::platformOpenTypeTable const):
(WebCore::FontPlatformData::openTypeTable const): Deleted.
(WebCore::FontPlatformData::description const): Deleted.

Source/WebCore/PAL:

pal/spi/win/CoreTextSPIWin.h:

LayoutTests:

These two tests are progressions.

platform/win/mathml/opentype/opentype-stretchy-expected.txt:
platform/win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:

8:42 PM Changeset in webkit [267072] by Hector Lopez

2 edits in trunk/LayoutTests

Added test and test expectation for constant crashes ar r267002
https://bugs.webkit.org/show_bug.cgi?id=216520

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

8:31 PM Changeset in webkit [267071] by Chris Dumez

3 edits
2 adds in trunk

Types of Panner.setPosition() / setOrientation() parameters should not be unrestricted float
https://bugs.webkit.org/show_bug.cgi?id=216508

Reviewed by Darin Adler.

Source/WebCore:

Types of Panner.setPosition() / setOrientation() parameters should not be unrestricted float:

https://www.w3.org/TR/webaudio/#pannernode

They should use float type so that we throw when passing values that are non-finite or not a number.

Test: webaudio/panner-node-exceptions.html

Modules/webaudio/PannerNode.idl:

LayoutTests:

Add layout test coverage.

webaudio/panner-node-exceptions-expected.txt: Added.
webaudio/panner-node-exceptions.html: Added.

8:27 PM Changeset in webkit [267070] by Hector Lopez

2 edits in trunk/LayoutTests

REGRESSION (r267002): ASSERTION FAILED:[ iOS wk2 Debug ] !HashTranslator::equal(KeyTraits::emptyValue(), key) on fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=216520

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

7:55 PM Changeset in webkit [267069] by weinig@apple.com

21 edits in trunk

Remove runtime setting for enabling/disabling ShadowDOM
https://bugs.webkit.org/show_bug.cgi?id=216511

Reviewed by Ryosuke Niwa.

Remove runtime setting for enabling/disabling ShadowDOM. There is no
reason one need to disable it now, and it has been on by default for
a long enough time.

Source/WebCore:

dom/Element.idl:
dom/Event.idl:
dom/Node.idl:
dom/ShadowRoot.idl:
dom/Slotable.idl:
html/HTMLSlotElement.idl:
page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setShadowDOMEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::shadowDOMEnabled const): Deleted.

Source/WebKit:

Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setShadowDOMEnabled:]):
(-[WebPreferences shadowDOMEnabled]):
(-[WebPreferences setVideoPluginProxyEnabled:]):
(-[WebPreferences isVideoPluginProxyEnabled]):
(-[WebPreferences setHixie76WebSocketProtocolEnabled:]):
(-[WebPreferences isHixie76WebSocketProtocolEnabled]):
(-[WebPreferences setDiskImageCacheEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::shadowDOMEnabled):
(WebPreferences::setShadowDOMEnabled):

WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

7:48 PM Changeset in webkit [267068] by Hector Lopez

2 edits in trunk/LayoutTests

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

7:17 PM Changeset in webkit [267067] by Simon Fraser

5 edits
3 adds in trunk

REGRESSION (Async overflow scroll): Code snippets on getkirby.com appear and disappear as content is scrolled
https://bugs.webkit.org/show_bug.cgi?id=216490
<rdar://problem/67018073>

Reviewed by Zalan Bujtas.
Source/WebCore:

The content in question had a z-order layer tree like this:

A (0,0) width=997 height=829 (layerID 20) {sc 2} RenderView

+ B (0,0) width=997 height=8 RenderBlock HTML class='no-js'

+ C (0,0) width=997 height=829 RenderFlexibleBox MAIN

n D (0,0) width=256 height=829 RenderFlexibleBox NAV class='left panel'

n E (0,0) width=256 height=829 (layerID 25) {sc 3} RenderBlock DIV class='scroller'

n F (256,0) width=741 height=829 RenderFlexibleBox ARTICLE class='main panel'

n G (0,0) width=741 height=829 (layerID 26) {sc 4} RenderBlock DIV class='scroller'

n H (0,-816) width=741 height=2810 RenderBlock DIV class='article-content'

+ I (0,0) width=256 height=1000 (layerID 27) overlap RenderBlock (relative positioned) DIV class='content'
+ J (10,300) width=721 height=202 (layerID 28) overlap RenderBlock (relative positioned) DIV class='relative-box'
+ K (10,802) width=721 height=202 (layerID 29) overlap RenderBlock (relative positioned) DIV class='relative-box'
+ L (10,1304) width=721 height=202 (layerID 30) overlap RenderBlock (relative positioned) DIV class='relative-box'
+ M (10,1806) width=721 height=202 (layerID 31) overlap RenderBlock (relative positioned) DIV class='relative-box'
+ M (10,2308) width=721 height=202 (layerID 32) overlap RenderBlock (relative positioned) DIV class='relative-box'

When layer 'G' is scrolled, the code would find the paint-order parent, F, which is normal-flow because it has overflow:hidden,
and would call setDescendantsNeedUpdateBackingAndHierarchyTraversal() on it. However, that doesn't go high enough, because
we need to update J-M since their ancestor clipping stacks have geometry that relies on the scroll position of G. If we don't
update that geometry, GraphicsLayers have an incorrect notion of what's visible, and we don't attach backing store.

The fix is to climb up to the stacking context B and call setDescendantsNeedUpdateBackingAndHierarchyTraversal() on it.

Test: compositing/scrolling/async-overflow-scrolling/nested-scrollers-backing-attachment.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

LayoutTests:

compositing/scrolling/async-overflow-scrolling/nested-scrollers-backing-attachment-expected.txt: Added.
compositing/scrolling/async-overflow-scrolling/nested-scrollers-backing-attachment.html: Added.

6:59 PM Changeset in webkit [267066] by Chris Dumez

8 edits in trunk

Type of AnalyserNode's attributes should not be unrestricted double
https://bugs.webkit.org/show_bug.cgi?id=216505

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing WPT test now that the exception message was improved.

web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:

Source/WebCore:

Type of AnalyserNode's attributes should not be unrestricted double. They should use double type
so that we throw when trying to set them to NaN or infinity values.

No new tests, updated existing test.

Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::setSmoothingTimeConstant):

Modules/webaudio/AnalyserNode.idl:

LayoutTests:

Extend layout test coverage.

webaudio/analyser-exception-expected.txt:
webaudio/analyser-exception.html:

6:59 PM Changeset in webkit [267065] by Chris Dumez

7 edits in trunk

Drop non-standard AudioBuffer.gain
https://bugs.webkit.org/show_bug.cgi?id=216510

Reviewed by Darin Adler.

Source/WebCore:

Drop non-standard AudioBuffer.gain:

https://www.w3.org/TR/webaudio/#AudioBuffer

Blink does not expose this attribute either.

No new tests, updated existing test.

Modules/webaudio/AudioBuffer.h:

(WebCore::AudioBuffer::gain const): Deleted.
(WebCore::AudioBuffer::setGain): Deleted.
(): Deleted.

Modules/webaudio/AudioBuffer.idl:
Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):

LayoutTests:

Extend layout test coverage.

webaudio/audiobuffer-expected.txt:
webaudio/audiobuffer.html:

6:29 PM Changeset in webkit [267064] by Aditya Keerthi

2 edits in trunk/Source/WebKit

[macOS] Do not dismiss date picker when a value is selected
https://bugs.webkit.org/show_bug.cgi?id=216515
<rdar://problem/68889944>

Reviewed by Darin Adler.

The calendar presented when activating a date input should not be
dismissed after the user selects a date. This matches the behavior
of date pickers in Calendar.app.

UIProcess/mac/WebDateTimePickerMac.mm:

(WebKit::WebDateTimePickerMac::didChooseDate):

6:27 PM Changeset in webkit [267063] by Peng Liu

2 edits in trunk/Source/WebCore/PAL

Clean up AVKitSPI.h
https://bugs.webkit.org/show_bug.cgi?id=216449

Unreviewed, a follow-up patch to fix build failures on watchOS.

pal/spi/cocoa/AVKitSPI.h:

6:25 PM Changeset in webkit [267062] by keith_miller@apple.com

3 edits
1 add in trunk

BytecodeParser should GetLocal op_ret's value even if it's unused by the caller
https://bugs.webkit.org/show_bug.cgi?id=216506

Reviewed by Mark Lam.

JSTests:

stress/osr-availability-should-see-unused-return-as-available.js: Added.

(foo):
(set isFinite):

Source/JavaScriptCore:

We have to unconditionally GetLocal operands each bytecode claims to use
regardless of true liveness. This is important to keep OSRAvailability simple.
However, op_ret would only GetLocal the return value if we knew the value
was going to be used by an inline caller.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

5:57 PM Changeset in webkit [267061] by Hector Lopez

2 edits in trunk/LayoutTests

Skip 2 imported/ tests on iOS after the changes in r266817
https://bugs.webkit.org/show_bug.cgi?id=186045

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

5:41 PM Changeset in webkit [267060] by Chris Dumez

6 edits in trunk

Drop smoothing logic from DelayDSPKernel::process()
https://bugs.webkit.org/show_bug.cgi?id=216504

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing or whose output has slightly changed.

web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt:

Source/WebCore:

Drop smoothing logic from DelayDSPKernel::process(). This is not as per specification and does not
match the behavior of Chromium. This is causing us to fail a WPT test.

No new tests, rebaselined existing test.

Modules/webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::DelayDSPKernel):
(WebCore::DelayDSPKernel::process):
(WebCore::DelayDSPKernel::reset):

Modules/webaudio/DelayDSPKernel.h:

5:40 PM Changeset in webkit [267059] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][FFC] Block box flex items establish block formatting contexts
https://bugs.webkit.org/show_bug.cgi?id=216502

Reviewed by Simon Fraser.

The display value of a flex item is blockified: if the specified display of an in-flow child of an element generating a flex container is an inline-level value, it computes to its block-level equivalent.
A block box that establishes an independent formatting context establishes a new block formatting context for its contents.

layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::establishesBlockFormattingContext const):
(WebCore::Layout::Box::isBlockBox const):

layout/layouttree/LayoutBox.h:

4:20 PM Changeset in webkit [267058] by Hector Lopez

2 edits in trunk/LayoutTests

[ macOS iOS wk2 ] http/tests/IndexedDB/storage-limit.https.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209189

Unreviewed test gardening.

platform/ios-wk2/TestExpectations: expectation update

4:17 PM Changeset in webkit [267057] by jer.noble@apple.com

11 edits
5 adds in trunk

[Cocoa,HDR] HLS streams with HDR variants will not select HDR.
https://bugs.webkit.org/show_bug.cgi?id=216203
<rdar://problem/67438626>

Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/media/hls/hls-hdr-switch.html

In r264710, we adopted a new API to set the preferred HDR mode for every AVPlayer created by an HTMLMediaElement. The
MediaPlayerPrivateAVFoundationObjC object will query its parent when it creates an AVPlayer, or the MediaPlayer will
tell the MediaPlayerPrivate... that the HDR mode changes if the AVPlayer is already created. However, in r264710, we
neglected to cache the new value of the preferred HDR mode, so subsequent queries will just return "Standard". This means
HDR mode will correctly be applied if it changes after the AVPlayer has been created, but not initially.

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::setPreferredDynamicRangeMode):

LayoutTests:

http/tests/media/hls/hls-hdr-switch-expected.txt: Added.
http/tests/media/hls/hls-hdr-switch.html: Added.
http/tests/media/resources/hls/green-bip.ts: Added.
http/tests/media/resources/hls/hdr.m3u8: Added.
http/tests/media/resources/hls/red-bip.ts: Added.
http/tests/media/resources/hls/test-live.php:

4:05 PM Changeset in webkit [267056] by Jonathan Bedard

3 edits in trunk/Tools

[webkitcorepy] AutoInstaller should work with HomeBrew Python
https://bugs.webkit.org/show_bug.cgi?id=216496
<rdar://problem/68864294>

Rubber-stamped by Brady Eidson.

Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.install): Set prefix to empty for HomeBrew python installs.

4:04 PM Changeset in webkit [267055] by Hector Lopez

3 edits in trunk/LayoutTests

[ macOS iOS Release ] imported/w3c/web-platform-tests/css/css-flexbox/quirks-auto-block-size-with-percentage-item.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=216292

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac-wk1/TestExpectations:

4:00 PM Changeset in webkit [267054] by Simon Fraser

33 edits
2 adds in trunk/Source/WebCore

[LFC] The result of layout should be Layout::Geometry, not Display::Box
https://bugs.webkit.org/show_bug.cgi?id=216497

Reviewed by Zalan Bujtas.

We should reserve things in the Display namespace for painting, so layout should emit
Layout::Geometry rather than Display::Boxes. So clone Display::Box to Layout::Geometry
and use Layout::Geometry everywhere that Display::Box was used.

Future patches will move painting ot use Display objects.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::geometryForBox const):

layout/FormattingContext.h:
layout/FormattingContextGeometry.cpp:

layout/FormattingContextQuirks.cpp:
layout/FormattingState.cpp:

(WebCore::Layout::FormattingState::displayBox):

layout/FormattingState.h:
layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::layout):
(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):

layout/LayoutState.cpp:

(WebCore::Layout::LayoutState::geometryForRootLayoutBox):
(WebCore::Layout::LayoutState::ensureDisplayBoxForLayoutBoxSlow):
(WebCore::Layout::LayoutState::displayBoxForRootLayoutBox): Deleted.

layout/LayoutState.h:

(WebCore::Layout::LayoutState::ensureGeometryForLayoutBox):
(WebCore::Layout::LayoutState::geometryForLayoutBox const):
(WebCore::Layout::Box::cachedDisplayBoxForLayoutState const):
(WebCore::Layout::LayoutState::ensureDisplayBoxForLayoutBox): Deleted.
(WebCore::Layout::LayoutState::displayBoxForLayoutBox const): Deleted.

layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

layout/blockformatting/BlockFormattingContextGeometry.cpp:
layout/blockformatting/BlockFormattingContextQuirks.cpp:
layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:
layout/display/DisplayLayerController.cpp:

(WebCore::Display::LayerController::prepareForDisplay):

layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintBoxDecoration):
(WebCore::Display::Painter::absoluteDisplayBox):
(WebCore::Display::collectPaintRootsAndContentRect):

layout/displaytree/DisplayPainter.h:
layout/floats/FloatAvoider.h:
layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::append):

layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::FloatItem::FloatItem):

layout/floats/FloatingState.h:

(WebCore::Layout::FloatingState::FloatItem::rectWithMargin const):
(WebCore::Layout::FloatingState::FloatItem::horizontalMargin const):

layout/inlineformatting/InlineLineBox.h:
layout/inlineformatting/InlineLineBuilder.cpp:
layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::prepareFloatingState):

layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::setCachedDisplayBoxForLayoutState const):

layout/layouttree/LayoutBox.h:
layout/layouttree/LayoutGeometry.cpp: Added.

(WebCore::Layout::Geometry::Geometry):
(WebCore::Layout::Geometry::~Geometry):
(WebCore::Layout::Geometry::marginBox const):
(WebCore::Layout::Geometry::borderBox const):
(WebCore::Layout::Geometry::paddingBox const):
(WebCore::Layout::Geometry::contentBox const):

layout/layouttree/LayoutGeometry.h: Added.

(WebCore::Layout::Rect::expandHorizontally):
(WebCore::Layout::Rect::expandVertically):
(WebCore::Layout::Rect::intersects const):
(WebCore::Layout::Rect::invalidateTop):
(WebCore::Layout::Rect::invalidateLeft):
(WebCore::Layout::Rect::invalidateWidth):
(WebCore::Layout::Rect::invalidateHeight):
(WebCore::Layout::Rect::hasValidPosition const):
(WebCore::Layout::Rect::hasValidSize const):
(WebCore::Layout::Rect::hasValidGeometry const):
(WebCore::Layout::Rect::Rect):
(WebCore::Layout::Rect::invalidatePosition):
(WebCore::Layout::Rect::setHasValidPosition):
(WebCore::Layout::Rect::setHasValidSize):
(WebCore::Layout::Rect::top const):
(WebCore::Layout::Rect::left const):
(WebCore::Layout::Rect::bottom const):
(WebCore::Layout::Rect::right const):
(WebCore::Layout::Rect::topLeft const):
(WebCore::Layout::Rect::bottomRight const):
(WebCore::Layout::Rect::size const):
(WebCore::Layout::Rect::width const):
(WebCore::Layout::Rect::height const):
(WebCore::Layout::Rect::setTopLeft):
(WebCore::Layout::Rect::setTop):
(WebCore::Layout::Rect::setLeft):
(WebCore::Layout::Rect::setWidth):
(WebCore::Layout::Rect::setHeight):
(WebCore::Layout::Rect::setSize):
(WebCore::Layout::Rect::shiftLeftTo):
(WebCore::Layout::Rect::shiftRightTo):
(WebCore::Layout::Rect::shiftTopTo):
(WebCore::Layout::Rect::shiftBottomTo):
(WebCore::Layout::Rect::moveHorizontally):
(WebCore::Layout::Rect::moveVertically):
(WebCore::Layout::Rect::expand):
(WebCore::Layout::Rect::clone const):
(WebCore::Layout::Rect::operator LayoutRect const):
(WebCore::Layout::Geometry::bottom const):
(WebCore::Layout::Geometry::right const):
(WebCore::Layout::Geometry::bottomRight const):
(WebCore::Layout::Geometry::size const):
(WebCore::Layout::Geometry::width const):
(WebCore::Layout::Geometry::height const):
(WebCore::Layout::Geometry::isEmpty const):
(WebCore::Layout::Geometry::rect const):
(WebCore::Layout::Geometry::rectWithMargin const):
(WebCore::Layout::Geometry::hasClearance const):
(WebCore::Layout::Geometry::verticalBorder const):
(WebCore::Layout::Geometry::horizontalBorder const):
(WebCore::Layout::Geometry::contentBoxTop const):
(WebCore::Layout::Geometry::contentBoxLeft const):
(WebCore::Layout::Geometry::contentBoxBottom const):
(WebCore::Layout::Geometry::contentBoxRight const):
(WebCore::Layout::Geometry::paddingBoxTop const):
(WebCore::Layout::Geometry::paddingBoxLeft const):
(WebCore::Layout::Geometry::paddingBoxBottom const):
(WebCore::Layout::Geometry::paddingBoxRight const):
(WebCore::Layout::Geometry::paddingBoxHeight const):
(WebCore::Layout::Geometry::paddingBoxWidth const):
(WebCore::Layout::Geometry::borderBoxHeight const):
(WebCore::Layout::Geometry::borderBoxWidth const):
(WebCore::Layout::Geometry::marginBoxHeight const):
(WebCore::Layout::Geometry::marginBoxWidth const):
(WebCore::Layout::Geometry::verticalMarginBorderAndPadding const):
(WebCore::Layout::Geometry::horizontalMarginBorderAndPadding const):
(WebCore::Layout::Geometry::setHasPrecomputedMarginBefore):
(WebCore::Layout::Geometry::moveHorizontally):
(WebCore::Layout::Geometry::moveVertically):
(WebCore::Layout::Geometry::move):
(WebCore::Layout::Geometry::moveBy):
(WebCore::Layout::Geometry::setHasClearance):
(WebCore::Layout::Geometry::invalidateBorder):
(WebCore::Layout::Geometry::invalidatePadding):
(WebCore::Layout::Geometry::invalidatePrecomputedMarginBefore):
(WebCore::Layout::Geometry::setHasValidTop):
(WebCore::Layout::Geometry::setHasValidLeft):
(WebCore::Layout::Geometry::setHasValidVerticalMargin):
(WebCore::Layout::Geometry::setHasValidHorizontalMargin):
(WebCore::Layout::Geometry::setHasValidBorder):
(WebCore::Layout::Geometry::setHasValidPadding):
(WebCore::Layout::Geometry::setHasValidContentHeight):
(WebCore::Layout::Geometry::setHasValidContentWidth):
(WebCore::Layout::Geometry::invalidateMargin):
(WebCore::Layout::Geometry::top const):
(WebCore::Layout::Geometry::left const):
(WebCore::Layout::Geometry::topLeft const):
(WebCore::Layout::Geometry::setTopLeft):
(WebCore::Layout::Geometry::setTop):
(WebCore::Layout::Geometry::setLeft):
(WebCore::Layout::Geometry::setContentBoxHeight):
(WebCore::Layout::Geometry::setContentBoxWidth):
(WebCore::Layout::Geometry::contentBoxHeight const):
(WebCore::Layout::Geometry::contentBoxWidth const):
(WebCore::Layout::Geometry::setHorizontalMargin):
(WebCore::Layout::Geometry::setVerticalMargin):
(WebCore::Layout::Geometry::setBorder):
(WebCore::Layout::Geometry::setPadding):
(WebCore::Layout::Geometry::setVerticalPadding):
(WebCore::Layout::Geometry::verticalMargin const):
(WebCore::Layout::Geometry::horizontalMargin const):
(WebCore::Layout::Geometry::marginBefore const):
(WebCore::Layout::Geometry::marginStart const):
(WebCore::Layout::Geometry::marginAfter const):
(WebCore::Layout::Geometry::marginEnd const):
(WebCore::Layout::Geometry::paddingTop const):
(WebCore::Layout::Geometry::paddingLeft const):
(WebCore::Layout::Geometry::paddingBottom const):
(WebCore::Layout::Geometry::paddingRight const):
(WebCore::Layout::Geometry::verticalPadding const):
(WebCore::Layout::Geometry::horizontalPadding const):
(WebCore::Layout::Geometry::borderTop const):
(WebCore::Layout::Geometry::borderLeft const):
(WebCore::Layout::Geometry::borderBottom const):
(WebCore::Layout::Geometry::borderRight const):

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputLayoutBox):
(WebCore::Layout::outputLayoutTree):
(WebCore::Layout::showLayoutTree):

layout/tableformatting/TableFormattingContext.cpp:
layout/tableformatting/TableFormattingContextGeometry.cpp:
layout/tableformatting/TableLayout.cpp:
page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layoutUsingFormattingContext):

3:39 PM Changeset in webkit [267053] by Peng Liu

12 edits in trunk/Source

Returning to element fullscreen from PiP is not stable under stress tests
https://bugs.webkit.org/show_bug.cgi?id=216287

Reviewed by Jer Noble.

Source/WebCore:

platform/cocoa/VideoFullscreenChangeObserver.h:

Delete prepareToExitFullscreen().

platform/ios/VideoFullscreenInterfaceAVKit.h:
platform/ios/VideoFullscreenInterfaceAVKit.mm:

(VideoFullscreenInterfaceAVKit::VideoFullscreenInterfaceAVKit):
(VideoFullscreenInterfaceAVKit::prepareForPictureInPictureStop):
(VideoFullscreenInterfaceAVKit::didStopPictureInPicture):
(VideoFullscreenInterfaceAVKit::stopPictureInPictureTimerFired):
(VideoFullscreenInterfaceAVKit::setReadyToStopPictureInPicture):
VideoFullscreenInterfaceAVKit expects an element enters fullscreen and figure out the
location and size of the video element after that, which will be used by AVKit for the
exiting picture-in-picture animation. However, the entering fullscreen may take a long
time and AVKit will start exiting picture-in-picture before the entering fullscreen
transition is done. We need to add protection for such a scenario. This patch adds
a timer (m_stopPictureInPictureTimer) for this purpose. This patch also makes sure
VideoFullscreenInterfaceAVKit will call didExitPictureInPicture() properly.

platform/ios/WebVideoFullscreenControllerAVKit.mm:

Delete prepareToExitFullscreen().

platform/mac/VideoFullscreenInterfaceMac.mm:

(WebCore::VideoFullscreenInterfaceMac::preparedToReturnToInline): This function
is not used on Mac.

Source/WebKit:

UIProcess/Cocoa/VideoFullscreenManagerProxy.h:

(WebKit::VideoFullscreenManagerProxyClient::~VideoFullscreenManagerProxyClient):
(WebKit::VideoFullscreenManagerProxy::setClient):
(WebKit::VideoFullscreenManagerProxy::client const):

UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenModelContext::didEnterPictureInPicture):
(WebKit::VideoFullscreenModelContext::didExitPictureInPicture):
(WebKit::VideoFullscreenModelContext::willEnterPictureInPicture):
(WebKit::VideoFullscreenManagerProxy::hasVideoInPictureInPictureDidChange):
(WebKit::VideoFullscreenManagerProxy::fullscreenMayReturnToInline):
(WebKit::VideoFullscreenModelContext::prepareToExitFullscreen): Deleted.
Add the interface VideoFullscreenManagerProxyClient, which is used by WKFullScreenWindowController
to implement the support of "returning to element fullscreen from PiP". Using VideoFullscreenModelClient
for that purpose is not a good idea because the instance observed by VideoFullscreenModelClient may be
destroyed when a video element is exiting picture-in-picture if we don't call
VideoFullscreenManagerProxy::addClientForContext() and VideoFullscreenManagerProxy::removeClientForContext()
properly.

UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController initWithWebView:]):
(-[WKFullScreenWindowController dealloc]):
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController _completedExitFullScreen]):
(-[WKFullScreenWindowController videoControlsManagerDidChange]):
(-[WKFullScreenWindowController prepareToExitPictureInPicture]):
(-[WKFullScreenWindowController didExitPictureInPicture]):
(-[WKFullScreenWindowController _videoFullscreenManager]):
(WKFullScreenWindowControllerVideoFullscreenModelClient::setParent): Deleted.
(WKFullScreenWindowControllerVideoFullscreenModelClient::setInterface): Deleted.
(WKFullScreenWindowControllerVideoFullscreenModelClient::interface const): Deleted.
(-[WKFullScreenWindowController willEnterPictureInPicture]): Deleted.
(-[WKFullScreenWindowController failedToEnterPictureInPicture]): Deleted.
Use VideoFullscreenManagerProxyClient instead of VideoFullscreenModelClient to implement
the support of "returning to element fullscreen from PiP" on iOS.
A user can "return to element fullscreen from PiP" by clicking the "return to fullscreen"
button on the PiP window, or by clicking the "fullscreen" button on the page. This patch
adds support for the latter case.

UIProcess/mac/WKFullScreenWindowController.h:
UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController initWithWindow:webView:page:]):
(-[WKFullScreenWindowController dealloc]):
(-[WKFullScreenWindowController videoControlsManagerDidChange]):
(-[WKFullScreenWindowController didExitPictureInPicture]):
(-[WKFullScreenWindowController windowDidEnterFullScreen:]):
(-[WKFullScreenWindowController _videoFullscreenManager]):
(WebKit::WKFullScreenWindowControllerVideoFullscreenModelClient::setParent): Deleted.
(WebKit::WKFullScreenWindowControllerVideoFullscreenModelClient::setInterface): Deleted.
(WebKit::WKFullScreenWindowControllerVideoFullscreenModelClient::interface const): Deleted.
Use VideoFullscreenManagerProxyClient instead of VideoFullscreenModelClient to implement the
support of "exiting fullscreen after entering PiP" on Mac. We may implement the support of
"returning to element fullscreen from PiP" on Mac in the future.

3:39 PM Changeset in webkit [267052] by aakash_jain@apple.com

3 edits in trunk/Tools

Add unit-tests for triggered_by key in ews config
https://bugs.webkit.org/show_bug.cgi?id=216487

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-build/loadConfig_unittest.py:

(ConfigDotJSONTest.get_config): Method to read config.json
(ConfigDotJSONTest.test_schduler_contains_valid_builder_name): Ensure that scheduler references a valid builder.
(ConfigDotJSONTest.test_single_builder_for_triggerable_scheduler): Ensure that every Triggerable scheduler references a single builder.
(ConfigDotJSONTest.test_incorrect_triggered_by): Ensure that triggered_by key is correct. Verify by matching that
the builder for the triggered_by scheduler actually triggers current builder.

BuildSlaveSupport/ews-build/steps_unittest.py:

(TestAnalyzeLayoutTestsResults.test_clean_tree_exceed_failure_limit_with_triggered_by):

3:30 PM Changeset in webkit [267051] by weinig@apple.com

6 edits
6 adds in trunk/Source/WebCore

[WebIDL] Move synthetic operation creation from IDLParser to CodeGeneratorJS
https://bugs.webkit.org/show_bug.cgi?id=216468

Reviewed by Chris Dumez.

Address FIXMEs in IDLParser by moving synthetic operation creation out of IDLParser
and into CodeGeneratorJS. Replace use of isIterable/isMapLike/isSetLike predicates
on IDLOperation and IDLAttribute with extended attributes, FromIterable,
ForwardToMapLike and ForwardToSetLike.

While this change completely removes all notion of operations/attributes from
IDLMapLike and IDLSetLike, IDLIterable retains an operations array, now only
used by CodeGeneratorJS, to avoid a larger refactoring of the code generation.
Eventually, it would be good to stop using AST level operations and attributes
to model these synthetic operations, and instead have the code generation
maintain a model that more closely resembles the ECMAScript output directly.

While here, also fix the issue that maplike and setlike were always overriding
set/clear/delete and add/clear/delete (respectively) where as WebIDL says they
should only add those if the interface doesn't already have members with those
names. Adds new tests for this behavior.

bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/IDLParser.pm:
bindings/scripts/test/BindingTestGlobalConstructors.idl:
bindings/scripts/test/JS/JSTestMapLikeWithOverriddenOperations.cpp: Added.
bindings/scripts/test/JS/JSTestMapLikeWithOverriddenOperations.h: Added.
bindings/scripts/test/JS/JSTestSetLikeWithOverriddenOperations.cpp: Added.
bindings/scripts/test/JS/JSTestSetLikeWithOverriddenOperations.h: Added.
bindings/scripts/test/SupplementalDependencies.dep:
bindings/scripts/test/TestMapLikeWithOverriddenOperations.idl: Added.
bindings/scripts/test/TestSetLikeWithOverriddenOperations.idl: Added.

3:20 PM Changeset in webkit [267050] by Alan Coon

1 copy in tags/Safari-610.2.5.1.1

Tag Safari-610.2.5.1.1.

3:17 PM Changeset in webkit [267049] by Alan Coon

6 edits in branches/safari-610-branch/Source

Cherry-pick r266932. rdar://problem/68881008

Fix undeclared identifier issue due to clashes in soft link headers
https://bugs.webkit.org/show_bug.cgi?id=216412

Reviewed by Geoffrey Garen.

Source/WebCore/PAL:

r266898 broke builds on certain SDKs. The reason for this is that it includes
MediaToolbox/FigPhoto.h, which transitively includes CoreMedia/CMTimePrivate.h. The latter
header has a bunch of inline code in certain SDKs which conflicts with the
CoreMediaSoftLink.h header. For instance, CoreMediaSoftLink.h redefines CMTimeCompare to
softLink_CoreMedia_CMTimeCompare, which messes up the inline code in the CMTimePrivate.h
header that references CMTimeCompare.

For now, we just avoid including FigPhoto.h altogether and use a constant. We'll clean this
up once we start weak linking rather than soft linking CoreMedia and MediaToolbox (216388).

pal/cocoa/MediaToolboxSoftLink.cpp:
pal/cocoa/MediaToolboxSoftLink.h:
pal/spi/cocoa/MediaToolboxSPI.h:

Source/WebKit:

Use the workaround constant kPALFigPhotoContainerFormat_JFIF instead of the enum value
kFigPhotoContainerFormat_JFIF.

WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:17 PM Changeset in webkit [267048] by Alan Coon

6 edits in branches/safari-610-branch

Cherry-pick r266901. rdar://problem/68881000

[Repaint] RenderLayerModelObject::styleWillChange may issue redundant repaint
https://bugs.webkit.org/show_bug.cgi?id=216374
<rdar://problem/68657490>

Reviewed by Simon Fraser.

Source/WebCore:

Move the repaintIncludingDescendants() calls to repaintBeforeStyleChange() to avoid redundant repaints on the same renderer.

rendering/RenderElement.cpp: (WebCore::RenderElement::repaintBeforeStyleChange):
rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::styleWillChange):

LayoutTests:

css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt:
platform/ios/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:17 PM Changeset in webkit [267047] by Alan Coon

10 edits
1 copy in branches/safari-610-branch/Source

Cherry-pick r266898. rdar://problem/68881029

Disable hardware JPEG decoding on x86 Mac
https://bugs.webkit.org/show_bug.cgi?id=216377

Reviewed by Geoff Garen.

Source/WebCore/PAL:

Add wrappers for a new MediaToolbox SPI that allows us to disable HW JPEG decoding.

PAL.xcodeproj/project.pbxproj:
pal/PlatformMac.cmake:
pal/cocoa/MediaToolboxSoftLink.cpp:
pal/cocoa/MediaToolboxSoftLink.h:

Source/WebKit:

In Big Sur, ImageIO uses hardware JPEG decoding automatically for certain JPEGs. This caused
a small regression in our battery life benchmark since the one-time setup cost for the
decoder (~20-30 ms per process) was higher than the per-decode win we got from the HW decoder.

For now, we're reverting to the Catalina behavior of not using hardware JPEG on x86 Macs by
calling a MediaToolbox SPI. (The tradeoffs for Apple Silicon are different so we use
ImageIO's default heuristics on that architecture.) We plan to revisit this decision once we
move to a GPUProcess world.

WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

Add macros to disable HW JPEG decoding on x86 Macs and indicate the presence of a new MediaToolbox SPI.
(The latter is to prevent unnecessary dlopen/dlsym calls since we soft-link MediaToolbox.)

wtf/PlatformEnableCocoa.h:
wtf/PlatformHave.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:17 PM Changeset in webkit [267046] by Alan Coon

7 edits in branches/safari-610-branch/Source

Cherry-pick r266844. rdar://problem/68880990

[Cocoa] PERF: Don't instantiate AVPlayer-based audio decoders or renderers if an element is initially muted.
https://bugs.webkit.org/show_bug.cgi?id=216299

Reviewed by Eric Carlson.

Source/WebCore:

When an AVPlayer is created, even if muted, it will still instantiate an audio decoder and renderer if the
AVAsset in the current player item has an audio track. Ostensibly, this is so that an unmute operation is
instantaneous, as it's merely applying a zero gain to the decoded audio. However for web content, there's
many autoplaying, muted <video> elements which may never be un-muted before being destroyed.

Implement a policy where, if an AVPlayer is initially muted, we adopt AVFoundation SPI to forcibly prevent
audio decoding and rendering until the first time the AVPlayer is unmuted. This means the first un-mute may
not be instantaneous, as an audio decoder will have to be created and fed before any audio is rendered.

There's some incorrect caching of mute state at the MediaPlayer level; so MediaPlayer and MPPAVFoundationObjC
can get their respective m_muted states out of sync. Make sure that HTMLMediaElement always sets muted state
after creating a MediaPlayer and that, respectively, MPPAVFoundationObjC always queries it's parent MediaPlayer's
mute state when it in turn is created.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createMediaPlayer):
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::setMuted):

Source/WebCore/PAL:

pal/spi/cocoa/AVFoundationSPI.h:

Source/WTF:

wtf/PlatformHave.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:17 PM Changeset in webkit [267045] by Alan Coon

24 edits in branches/safari-610-branch

Cherry-pick r266818. rdar://problem/68881035

[Repaint] RenderElement::setStyle may issue redundant repaint
https://bugs.webkit.org/show_bug.cgi?id=216324
<rdar://problem/68595896>

Reviewed by Simon Fraser.

Source/WebCore:

If we issue a repaint in ::styleWillChange, we should not need to re-issue it again in RenderElement::setStyle (see r266803 for details).

rendering/RenderElement.cpp: (WebCore::RenderElement::repaintBeforeStyleChange): (WebCore::RenderElement::setStyle):
rendering/RenderElement.h:

LayoutTests:

compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:
compositing/shared-backing/overflow-scroll/shared-layer-repaint-expected.txt:
fast/css-custom-paint/delay-repaint-expected.txt:
fast/images/async-image-multiple-clients-repaint-expected.txt:
fast/repaint/horizontal-bt-overflow-child-expected.txt:
fast/repaint/horizontal-bt-overflow-parent-expected.txt:
fast/repaint/horizontal-bt-overflow-same-expected.txt:
fast/repaint/mutate-non-visible-expected.txt:
fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt:
fast/repaint/overflow-flipped-writing-mode-table-expected.txt:
fast/repaint/spanner-with-margin-expected.txt:
fast/repaint/table-row-repaint-expected.txt:
fast/repaint/vertical-overflow-child-expected.txt:
fast/repaint/vertical-overflow-parent-expected.txt:
fast/repaint/vertical-overflow-same-expected.txt:
svg/transforms/svg-transform-foreign-object-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:17 PM Changeset in webkit [267044] by Alan Coon

27 edits in branches/safari-610-branch

Cherry-pick r266803. rdar://problem/68881014

[Repaint] styleWillChange may call repaint on the same renderer multiple times.
https://bugs.webkit.org/show_bug.cgi?id=216295
<rdar://problem/68538666>

Reviewed by Simon Fraser.

Source/WebCore:

RenderElement::styleWillChange is a virtual function. This function is called whenever the associated RenderStyle changes.
The subclass implementation (e.g. RenderBox::styleWillChange) calls the parent class to make sure the style change is covered properly.
Now in certain cases,

this may trigger multiple calls to repaint() (e.g one in each ::styleWillChange implementation)
paint invalidation requires absolute coordinates
geometry does not change during styleWillChange it could end up being redundant/unnecessarily expensive.

This patch moves all the style-will-change-requires-repaint logic to one single function so that we can limit the number of repaints.

rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange):
rendering/RenderElement.cpp: (WebCore::RenderElement::issueRepaintBeforeStyleChange): (WebCore::RenderElement::initializeStyle): (WebCore::RenderElement::setStyle): (WebCore::RenderElement::styleWillChange):
rendering/RenderElement.h:
rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::styleWillChange):

LayoutTests:

compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:
compositing/shared-backing/overflow-scroll/shared-layer-repaint-expected.txt:
fast/css-custom-paint/delay-repaint-expected.txt:
fast/images/async-image-multiple-clients-repaint-expected.txt:
fast/repaint/focus-ring-repaint-expected.txt:
fast/repaint/horizontal-bt-overflow-child-expected.txt:
fast/repaint/horizontal-bt-overflow-parent-expected.txt:
fast/repaint/horizontal-bt-overflow-same-expected.txt:
fast/repaint/mutate-non-visible-expected.txt:
fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt:
fast/repaint/overflow-flipped-writing-mode-table-expected.txt:
fast/repaint/table-row-repaint-expected.txt:
fast/repaint/vertical-overflow-child-expected.txt:
fast/repaint/vertical-overflow-parent-expected.txt:
fast/repaint/vertical-overflow-same-expected.txt:
svg/transforms/svg-transform-foreign-object-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:17 PM Changeset in webkit [267043] by Alan Coon

5 edits in branches/safari-610-branch/Source

Cherry-pick r266797. rdar://problem/68881018

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=216195

Reviewed by Simon Fraser.

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.

After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.

Source/WebCore:

platform/graphics/DisplayRefreshMonitor.cpp: (WebCore::DisplayRefreshMonitor::displayDidRefresh):
platform/graphics/DisplayRefreshMonitor.h: (WebCore::DisplayRefreshMonitor::shouldBeTerminated const):

Source/WebKit:

UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::addObserver): (WebKit::DisplayLink::removeObserver): (WebKit::DisplayLink::removeObservers): (WebKit::DisplayLink::displayLinkCallback): (WebKit::DisplayLink::hasObservers const): Deleted.
UIProcess/mac/DisplayLink.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:50 PM Changeset in webkit [267042] by achristensen@apple.com

20 edits in trunk

Move cookie flushing SPI from WKProcessPool to WKHTTPCookieStore
https://bugs.webkit.org/show_bug.cgi?id=216493

Reviewed by Chris Dumez.

Source/WebKit:

In order for https://bugs.webkit.org/show_bug.cgi?id=216041 to be possible, our interface for flushing cookies to disk can't be
on the WKProcessPool. It should be with the other cookie operations, in WKHTTPCookieStore.
AuxiliaryProcessProxy::sendWithAsyncReply takes care of the background assertion, so we remove that code from NetworkProcessProxy::syncAllCookies.
rdar://problem/68872711 tracks adoption in Safari, which I will land within an hour of landing this to avoid cookie regressions.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::syncAllCookies):
(WebKit::NetworkProcess::didSyncAllCookies): Deleted.

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::syncAllCookies):

UIProcess/API/APIHTTPCookieStore.cpp:

(API::HTTPCookieStore::syncCookies):

UIProcess/API/APIHTTPCookieStore.h:
UIProcess/API/Cocoa/WKHTTPCookieStore.mm:

(-[WKHTTPCookieStore _flushCookiesToDiskWithCompletionHandler:]):

UIProcess/API/Cocoa/WKHTTPCookieStorePrivate.h:
UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _syncNetworkProcessCookies]):

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::syncAllCookies):
(WebKit::NetworkProcessProxy::didSyncAllCookies): Deleted.

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::syncCookies):
(WebKit::WebProcessPool::syncNetworkProcessCookies): Deleted.

UIProcess/WebProcessPool.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::syncCookies):

UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(runWebsiteDataStoreCustomPaths):
(TEST):

2:40 PM Changeset in webkit [267041] by Peng Liu

3 edits in trunk/Source/WebCore/PAL

Clean up AVKitSPI.h
https://bugs.webkit.org/show_bug.cgi?id=216449

Reviewed by Darin Adler.

pal/spi/cocoa/AVFoundationSPI.h:

Remove a duplicated AVKit header file.

pal/spi/cocoa/AVKitSPI.h:

Organize header files (and definitions) in the following order:

General AVKit header files
General AVKit internal header files and definitions
Feature specific internal header files and definitions

2:30 PM Changeset in webkit [267040] by Alexey Shvayka

8 edits
1 add in trunk

Proxy's "ownKeys" trap result should not be sorted
https://bugs.webkit.org/show_bug.cgi?id=216227

Reviewed by Yusuke Suzuki.

JSTests:

microbenchmarks/object-get-own-property-symbols-on-large-array.js:
microbenchmarks/object-get-own-property-symbols.js:
microbenchmarks/reflect-own-keys.js: Added.
stress/proxy-own-keys.js: Fix incorrect assert.
test262/expectations.yaml: Mark 20 test cases as passing.

Source/JavaScriptCore:

Given that we can't know whether ownPropertyKeys() received property names from
userland Proxy's "ownKeys" trap, this patch moves symbols after strings sorting [1]
to Structure::getPropertyNamesFromStructure(), aligning observed property order
(via Proxy's "getOwnPropertyDescriptor" trap) with V8 and SpiderMonkey.

Also, removes sorting logic duplication in objectConstructorAssign().

This change is neutral on provided Reflect.ownKeys microbenchmark. Although property
name collection besides PropertyNameMode::StringsAndSymbols cases is unaffected,
Object.{keys,getOwnPropertySymbols} microbenchmarks regress by 6-12% due to
increased Structure::getPropertyNamesFromStructure() code size.

[1]: https://tc39.es/ecma262/#sec-ordinaryownpropertykeys (steps 3-4)

runtime/ObjectConstructor.cpp:

(JSC::objectConstructorAssign):
(JSC::ownPropertyKeys):

runtime/Structure.cpp:

(JSC::Structure::getPropertyNamesFromStructure):

2:00 PM Changeset in webkit [267039] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][FFC] Each in-flow child of a flex container becomes a flex item.
https://bugs.webkit.org/show_bug.cgi?id=216494

Reviewed by Simon Fraser.

...and flex items form independent formatting contexts for their content.

layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::establishesIndependentFormattingContext const):
(WebCore::Layout::Box::isFlexItem const):

layout/layouttree/LayoutBox.h:

1:51 PM Changeset in webkit [267038] by commit-queue@webkit.org

9 edits
2 copies in trunk/Source/WebInspectorUI

Web Inspector: Stop Recording in Timelines tab doesn't work reliably
https://bugs.webkit.org/show_bug.cgi?id=216416

Patch by Patrick Angle <Patrick Angle> on 2020-09-14
Reviewed by Devin Rousso.

Improved UX surrounding stopping recordings. In the Frames view, the interface now shows a "Stopping Recording
Timeline Data" message and disables the Stop Recording button as soon as the user has pressed the button to stop
recording. For all timeline views, the Record/Continue/Stop buttons in the top-right are replaced with an
indeterminate progress spinner while recording is being stopped to better indicate that all work has not
completed yet. Lastly, the recording head now stops at the moment recording was stopped. After we have finished
stopping the recording, the timeline is updated one more time to account for any records we receive after the
moment the user requested recording to stop, instead of continously updating during the stopping phase, which
made it appear that recording was instead continuing.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Main.html: Added IndeterminateProgressSpinnerNavigationItem.css and

IndeterminateProgressSpinnerNavigationItem.js.

UserInterface/Views/ButtonNavigationItem.css:

(.navigation-bar .item.button.image-only):

UserInterface/Views/IndeterminateProgressSpinnerNavigationItem.css: Added.

(.navigation-bar .item.indeterminate-progress-spinner):
(.navigation-bar .item.indeterminate-progress-spinner-item .indeterminate-progress-spinner):

UserInterface/Views/IndeterminateProgressSpinnerNavigationItem.js: Added.

(WI.IndeterminateProgressSpinnerNavigationItem):

UserInterface/Views/TextNavigationItem.js: Drive-by fix for misplaced assert.

(WI.TextNavigationItem):

UserInterface/Views/TimelineRecordingContentView.js: Don't advanced the recording head after the user requests

recording to stop.
(WI.TimelineRecordingContentView.prototype._updateTimes):
(WI.TimelineRecordingContentView.prototype._updateTimelineViewTimes):

UserInterface/Views/TimelineRecordingProgressView.js: Listen to the TimelineManager to show different messages

for Recording and Stopping, as well as disabling the Stop Recording button.
(WI.TimelineRecordingProgressView):
(WI.TimelineRecordingProgressView.prototype.set visible):
(WI.TimelineRecordingProgressView.prototype._updateState):
(WI.TimelineRecordingProgressView.prototype._handleTimelineCapturingStateChanged):

UserInterface/Views/TimelineTabContentView.js: Show a progress spinner while stopping recording.

(WI.TimelineTabContentView):
(WI.TimelineTabContentView.prototype._showRecordButton):
(WI.TimelineTabContentView.prototype._showRecordStoppingSpinner):
(WI.TimelineTabContentView.prototype._showContinueButton):
(WI.TimelineTabContentView.prototype._updateNavigationBarButtons):
(WI.TimelineTabContentView.prototype._handleTimelineCapturingStateChanged):

UserInterface/Views/Variables.css: New variable for navigation items with only an icon.

(:root):

1:48 PM Changeset in webkit [267037] by Alexey Shvayka

4 edits in trunk

ArraySetLength should coerce Value? before descriptor validation
https://bugs.webkit.org/show_bug.cgi?id=158791

Reviewed by Darin Adler.

JSTests:

test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

This patch:

Moves Value? coercion before descriptor validation as per spec [1], which fixes ASSERT() failure and aligns JSC with V8 & SpiderMonkey.

Prevents JSArray::setLengthWithArrayStorage() from throwing if the length is unchanged, even if it's read-only [2].

Refactors JSArray::defineOwnProperty() leveraging #2 to always perform setLength(), which greatly reduces the number of checks, branches, and setLengthWritable() calls.

Following the ArraySetLength spec steps precisely [1] would result in
more difficult-to-follow code because descriptor validation [2] is inlined
and Delete? failures are handled in setLength().

This change is performance-neutral as it doesn't affect JSArray::put(),
which was vetted to be spec-correct and is covered by test262 suite.

[1]: https://tc39.es/ecma262/#sec-arraysetlength (steps 3-4)
[2]: https://tc39.es/ecma262/#sec-validateandapplypropertydescriptor (step 7.a.ii)

runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::setLengthWithArrayStorage):

1:31 PM Changeset in webkit [267036] by Chris Dumez

6 edits in trunk

AudioDestinationCocoa should stop hardcoding the number of output channels to 2
https://bugs.webkit.org/show_bug.cgi?id=216491

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing test.

web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:

Source/WebCore:

Stop hardcoding the number of output channels in AudioDestinationCocoa and instead use the AudioDestinationNode's
number of output channels.

platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::AudioDestination::create):
(WebCore::AudioDestinationCocoa::AudioDestinationCocoa):
(WebCore::AudioDestinationCocoa::numberOfOutputChannels const):
(WebCore::AudioDestinationCocoa::setAudioStreamBasicDescription):
(): Deleted.

platform/audio/cocoa/AudioDestinationCocoa.h:
platform/mock/MockAudioDestinationCocoa.cpp:

(WebCore::MockAudioDestinationCocoa::MockAudioDestinationCocoa):

1:22 PM Changeset in webkit [267035] by Jonathan Bedard

3 edits in trunk/Tools

[webkitcorepy] Disable AutoInstaller with environment variable (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=216396
<rdar://problem/68680933>

Unreviewed follow-up fix.

r267019 accidently landed without the support of r267019.

Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(AutoInstall.enabled): Add False and No to the list of environment variables which resolve to 'False'.
(AutoInstall.set_directory): Use AutoInstall.log instead of print(...).

1:17 PM Changeset in webkit [267034] by Fujii Hironori

8 edits in trunk

[WinCairo][MediaFoundation] r264188 introduced linker warning: LNK4199: /DELAYLOAD:mf.dll ignored; no imports found from mf.dll
https://bugs.webkit.org/show_bug.cgi?id=214170

Reviewed by Alex Christensen.

Source/WebCore:

r264188 added the linker flag /DELAYLOAD:mf.dll to WebCore. It
introduced a lot of linker warnings for modules not using
MediaFoundation, for example WebKitWebProcess.exe,
MiniBrowserLib.dll, etc. The linker option should be applied only
to direct WebCore consumers, namely WebKit.dll, WebKit2.dll and
TestWebCore.exe.

Define a INTERFACE library, and link it explicitly with the direct
WebCore consumers.

PlatformWinCairo.cmake:

Source/WebKit:

PlatformWin.cmake:

Source/WebKitLegacy:

PlatformWin.cmake:

Tools:

TestWebKitAPI/PlatformWin.cmake:

1:09 PM Changeset in webkit [267033] by Hector Lopez

4 edits in trunk/LayoutTests

[ macOS iOS Debug ] imported/w3c/web-platform-tests/selection/*: 4 tests are flaky timeouts
https://bugs.webkit.org/show_bug.cgi?id=216492

Unreviewed test gardening..

platform/ios-wk2/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/mac/TestExpectations:

1:06 PM Changeset in webkit [267032] by sbarati@apple.com

3 edits
1 add in trunk

Remove bogus asserts in FTLLower that assume programs are compiled with sensible speculations
https://bugs.webkit.org/show_bug.cgi?id=216485
<rdar://problem/68562804>

Reviewed by Keith Miller.

JSTests:

stress/ftl-should-not-assume-speculations-are-sensible.js: Added.

(foo):

Source/JavaScriptCore:

We had an assert inside lowCell that if a value was not part of the JSValue
hashmap of values, then the type must not conform to being a cell. However,
consider a program like this:

`
x = ArithAdd(i32, i32) <-- x is an i32 here
if (b) {

Check(Cell:@x)
ArrayifyToStructure(@x, thingy)

}
<-- HERE
`

@x will live in FTLLower's i32 hashmap, but because of the AI rule for
ArrayifyToStructure, it will also have SpecCell in its type. This is totally
valid, and asserting that this isn't possible is wrong. (Obviously the above
speculation is stupid, as we will always exit at the Check, but it's valid IR.)

This patch removes this assertion from lowCell, and removes similar assertions
from other low* functions.

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lowInt32):
(JSC::FTL::DFG::LowerDFGToB3::lowInt52):
(JSC::FTL::DFG::LowerDFGToB3::lowCell):
(JSC::FTL::DFG::LowerDFGToB3::lowBoolean):
(JSC::FTL::DFG::LowerDFGToB3::lowDouble):

12:54 PM Changeset in webkit [267031] by Devin Rousso

4 edits in trunk/Source

Web Inspector: docking buttons don't work when already docked if window is too small
https://bugs.webkit.org/show_bug.cgi?id=216488
<rdar://problem/68242717>

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

UserInterface/Base/Main.js:

(WI.updateDockingAvailability):
(WI.updateDockedState):
(WI._updateDockNavigationItems):
Always be sure to update the docking navigation items when docking becomes unavailable
instead of just forcing Web Inspector to undock as if Web Inspector is already undocked
then none of the docking navigation items will be updated. This makes it so that the
docking navigation items are hidden when docking becomes unavailable while undocked.

Source/WebKit:

UIProcess/Inspector/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::attachAvailabilityChanged):
If Web Inspector is already attached, it can re-attach with a different configuration.

12:50 PM Changeset in webkit [267030] by Fujii Hironori

7 edits in trunk/Tools

[TestRunnerShared] Make UIScriptContext not directly call UIScriptController::create which are defined in DRT and WTR
https://bugs.webkit.org/show_bug.cgi?id=216470

Reviewed by Simon Fraser.

UIScriptContext constructor directly called
UIScriptController::create which are defined in DRT and WTR. I'd
like to make TestRunnerShared as a stand alone library which
doesn't depend on DRT and WTR (Bug 216465). Make UIScriptContext
take a factory function to create UIScriptController.

DumpRenderTree/TestRunner.cpp:

(TestRunner::runUIScript):

DumpRenderTree/TestRunner.h:
TestRunnerShared/UIScriptContext/UIScriptContext.cpp:

(UIScriptContext::UIScriptContext):

TestRunnerShared/UIScriptContext/UIScriptContext.h:
TestRunnerShared/UIScriptContext/UIScriptControllerShared.cpp:

(WTR::UIScriptController::create): Deleted.

WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::runUISideScript):

12:49 PM Changeset in webkit [267029] by Alexey Shvayka

7 edits in trunk

Make a few built-in methods throw if called as top-level functions
https://bugs.webkit.org/show_bug.cgi?id=216467

Reviewed by Darin Adler.

JSTests:

test262/expectations.yaml: Mark 10 test cases as passing.

Source/JavaScriptCore:

Non-strict userland functions substitute undefined & null this values
with the global object [1], while built-in functions do not [2].

This patch adds 5 missing toThis(globalObject, ECMAMode::strict()) calls,
preventing built-in methods from being called as top-level functions:

`
let {toString} = Error.prototype;
toString(); now throws TypeError
`

Aligns JSC with V8 and SpiderMonkey.
This change is performance-neutral due to DFG inlining of OpToThis.
All other callFrame->thisValue() usages were vetted to be spec-correct.

[1]: https://tc39.es/ecma262/#sec-ordinarycallbindthis (step 6.a.iii)
[2]: https://tc39.es/ecma262/#sec-built-in-function-objects-call-thisargument-argumentslist (step 10)

runtime/ArrayPrototype.cpp:

(JSC::createArrayIteratorObject):

runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToPrimitiveSymbol):
(JSC::dateProtoFuncToJSON):

runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

12:30 PM Changeset in webkit [267028] by Devin Rousso

3 edits in trunk/Source/JavaScriptCore

Web Inspector: REGRESSION(r266885): dyld: Symbol not found: ZN9Inspector17BackendDispatcher12sendResponseElON3WTF6RefPtrINS1_8JSONImpl6ObjectENS1_13DumbPtrTraitsIS4_EEEEb
https://bugs.webkit.org/show_bug.cgi?id=216486

Reviewed by Joseph Pecoraro.

inspector/InspectorBackendDispatcher.h:
inspector/InspectorBackendDispatcher.cpp:

(Inspector::BackendDispatcher::sendResponse):
Add back overloads removed in r266885 so that the symbols exist.

11:54 AM Changeset in webkit [267027] by dino@apple.com

8 edits in trunk/Source

Enable WebGL2 by default
https://bugs.webkit.org/show_bug.cgi?id=216464
<rdar://problem/68811378>

Reviewed by Sam Weinig.

Our WebGL2 implementation is in good enough shape that we should
enable it by default for broader testing.

Source/WebCore:

page/RuntimeEnabledFeatures.h:

Source/WebKit:

Remove "defaultWebGL2Enabled" since it wasn't being used anywhere.

Shared/WebPreferences.yaml:
Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultWebGL2Enabled): Deleted.

Shared/WebPreferencesDefaultValues.h:

Source/WebKitLegacy/mac:

WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

11:47 AM Changeset in webkit [267026] by Alan Bujtas

10 edits
5 adds in trunk/Source/WebCore

[LFC][FFC] Introduce flex formatting context
https://bugs.webkit.org/show_bug.cgi?id=216483

Reviewed by Antti Koivisto.

Add the basic class structure for the flex formatting context.
https://www.w3.org/TR/css-flexbox-1/

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::isFlexFormattingContext const):

layout/FormattingState.h:

(WebCore::Layout::FormattingState::isFlexFormattingState const):

layout/LayoutState.cpp:

(WebCore::Layout::LayoutState::establishedFormattingState const):
(WebCore::Layout::LayoutState::establishedFlexFormattingState const):
(WebCore::Layout::LayoutState::ensureFormattingState):
(WebCore::Layout::LayoutState::ensureFlexFormattingState):

layout/LayoutState.h:
layout/flexformatting/FlexFormattingContext.cpp: Added.

(WebCore::Layout::FlexFormattingContext::FlexFormattingContext):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContent):
(WebCore::Layout::FlexFormattingContext::computedIntrinsicWidthConstraints):

layout/flexformatting/FlexFormattingContext.h: Added.
layout/flexformatting/FlexFormattingState.cpp: Added.

(WebCore::Layout::FlexFormattingState::FlexFormattingState):
(WebCore::Layout::FlexFormattingState::~FlexFormattingState):

layout/flexformatting/FlexFormattingState.h: Added.
layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::establishesFormattingContext const):
(WebCore::Layout::Box::establishesFlexFormattingContext const):

layout/layouttree/LayoutBox.h:

(WebCore::Layout::Box::isFlexBox const):

11:39 AM Changeset in webkit [267025] by Simon Fraser

3 edits in trunk/Source/WebCore

First steps towards LFC painting in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=216466

Address post-landing comments: make two constructors explicit.

layout/display/DisplayLayerController.h:
layout/display/DisplayView.h:

11:26 AM Changeset in webkit [267024] by Simon Fraser

18 edits
2 copies
3 adds in trunk

First steps towards LFC painting in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=216466

Reviewed by Zalan Bujtas.

Source/WebCore:

Get LFC painting in WebKit2.

Display::LayerController() is intended to be a controller object that makes layerization
decisions; for now, it just creates some root layers and hooks them up via attachRootGraphicsLayer().
It also creates a GraphicsLayerClient that paints by calling LayoutContext::paint().

Display::View is responsible for the display of an LFC-rendered document. FrameView
has one, and the Display::View has a Display::LayerController(). The minimal hookup points are:

Page::doAfterUpdateRendering() tells each Display::View to prepareForDisplay(). This is where we'll do once-per-rendering layer updating.
FrameView::flushCompositingStateForThisFrame() tells the Display::View() to flush layers, which just passes through to Display::LayerController().

For now we just rely on the fact that Display::LayerController() calls attachRootGraphicsLayer()
after RenderLayerCompositor, replacing the root layer created by existing RenderLayerCompositor code.

CMakeLists.txt:
Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/LayoutState.h:

(WebCore::Layout::LayoutState::hasRoot const):

layout/display/DisplayLayerController.cpp: Added.

(WebCore::Display::LayerController::RootLayerClient::RootLayerClient):
(WebCore::Display::LayerController::RootLayerClient::notifyFlushRequired):
(WebCore::Display::LayerController::RootLayerClient::paintContents):
(WebCore::Display::LayerController::LayerController):
(WebCore::Display::LayerController::prepareForDisplay):
(WebCore::Display::LayerController::flushLayers):
(WebCore::Display::LayerController::visibleRectForLayerFlushing const):
(WebCore::Display::LayerController::scheduleRenderingUpdate):
(WebCore::Display::LayerController::ensureRootLayer):
(WebCore::Display::LayerController::setupRootLayerHierarchy):
(WebCore::Display::LayerController::updateRootLayerGeometry):
(WebCore::Display::LayerController::attachRootLayer):
(WebCore::Display::LayerController::graphicsLayerFactory const):

layout/display/DisplayLayerController.h: Added.

(WebCore::Display::LayerController::view const):
(WebCore::Display::LayerController::rootGraphicsLayer const):
(WebCore::Display::LayerController::contentLayer const):

layout/display/DisplayView.cpp: Copied from Source/WebCore/layout/displaytree/DisplayPainter.h.

(WebCore::Display::View::View):
(WebCore::Display::View::~View):
(WebCore::Display::View::frame const):
(WebCore::Display::View::page const):
(WebCore::Display::View::layoutState const):
(WebCore::Display::View::prepareForDisplay):
(WebCore::Display::View::flushLayers):

layout/display/DisplayView.h: Copied from Source/WebCore/layout/displaytree/DisplayPainter.h.

(WebCore::Display::View::frameView const):

layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::Painter::absoluteDisplayBox):
(WebCore::Display::paintSubtree):
(WebCore::Display::collectPaintRootsAndContentRect):
(WebCore::Display::absoluteDisplayBox): Deleted.

layout/displaytree/DisplayPainter.h:
layout/inlineformatting/InlineLineBuilder.cpp:
page/FrameView.cpp:

(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::existingDisplayView const):
(WebCore::FrameView::displayView):

page/FrameView.h:
page/Page.cpp:

(WebCore::Page::doAfterUpdateRendering):

platform/graphics/x11/PlatformDisplayX11.h: Denote Display as being in the global namespace.
platform/graphics/x11/XErrorTrapper.h:

(WebCore::XErrorTrapper::XErrorTrapper):

platform/graphics/x11/XUniquePtr.h:

LayoutTests:

Now that we actually paint with LFC, some tests fail because of missing features in
the very basic LFC paint path. Mark these as failures for now.

platform/mac-wk2/TestExpectations:

10:58 AM Changeset in webkit [267023] by Jonathan Bedard

3 edits in trunk/Tools

[webkitcorepy] Log autoinstall details even without a logger configured
https://bugs.webkit.org/show_bug.cgi?id=216480

Reviewed by Dewei Zhu.

Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.install): Use AutoInstall.log instead of logging.
(AutoInstall):
(AutoInstall.log): Check log to see if a logger is configured, if one is not,
output the message to stderr instead.

10:47 AM Changeset in webkit [267022] by aakash_jain@apple.com

8 edits in trunk/Tools

[EWS] Layout testers can go in an infinite RETRY loop when there are 30+ failures on trunk
https://bugs.webkit.org/show_bug.cgi?id=203698
<rdar://problem/66157544>

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-build/steps.py:

(ConfigureBuild.init): Added triggerred_by key.
(ConfigureBuild.start): Set triggers property only if it is not already set (by the build who triggerred this build).
(Trigger.init): Added include_revision parameter, it would be False while triggerring builder, so that builder
can use ToT instead of the specific revision.
Also added triggers, so that when the tester trigger the builder, it can explicitly specify only to trigger it back and
nothing else.
(Trigger.propertiesToPassToTriggers): Pass ews_revision and triggers properties to triggered builds appropriately.
(AnalyzeLayoutTestsResults.retry_build): Trigger the parent build if triggered_by is specified.

BuildSlaveSupport/ews-build/config.json: Added triggered_by key.
BuildSlaveSupport/ews-build/factories.py: Updated to handle triggered_by key.
BuildSlaveSupport/ews-build/loadConfig.py: Ditto.
BuildSlaveSupport/ews-build/loadConfig_unittest.py:
BuildSlaveSupport/ews-build/factories_unittest.py:
BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble): If the build is retried, ensure that the status-bubble is orange.
(StatusBubble._most_recent_failure_message): Display the retry message from analyze-layout-tests-results step in the status-bubble.

10:23 AM Changeset in webkit [267021] by youenn@apple.com

9 edits in trunk/Source/WebKit

RemoteAudioMediaStreamTrackRenderer should process its IPC messages from a background thread
https://bugs.webkit.org/show_bug.cgi?id=216474

Reviewed by Eric Carlson.

Register RemoteAudioMediaStreamTrackRendererManager as a thread message receiver
for both RemoteAudioMediaStreamTrackRenderer and RemoteAudioMediaStreamTrackRendererManager messages.
All processing is sent to a high priority work queue.
Given AudioMediaStreamTrackRendererUnit is not fully thread safe, we use a single WorkQueue for the whole GPUProcess.
All operations will happen in this thread, while in WebProcess, create/start/stop/release are main thread.

We no longer compile the generated RemoteAudioMediaStreamTrackRendererManager::didReceiveMessage
and instead implement our own version to handle manager and renderer messages.

Covered by WebRTC audio tests run with GPU process enabled.

GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::~GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::dispatchMessage):

GPUProcess/GPUConnectionToWebProcess.h:
GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::audioMediaStreamTrackRendererQueue):

GPUProcess/GPUProcess.h:
GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.cpp:

(WebKit::RemoteAudioMediaStreamTrackRendererManager::RemoteAudioMediaStreamTrackRendererManager):
(WebKit::RemoteAudioMediaStreamTrackRendererManager::~RemoteAudioMediaStreamTrackRendererManager):
(WebKit::RemoteAudioMediaStreamTrackRendererManager::close):
(WebKit::RemoteAudioMediaStreamTrackRendererManager::dispatchToThread):
(WebKit::RemoteAudioMediaStreamTrackRendererManager::didReceiveMessage):

GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.h:
SourcesCocoa.txt:

10:21 AM Changeset in webkit [267020] by weinig@apple.com

37 edits
1 copy
8 moves
6 adds
4 deletes in trunk

[WebIDL] Replace 'serializable' with '[Default] object toJSON()'
https://bugs.webkit.org/show_bug.cgi?id=216148
LayoutTests/imported/w3c:

<rdar://problem/68668407>

Reviewed by Eric Carlson.

Update results to account for now correctly returning DOMPoints,
rather than vanilla Objects, for the points in a DOMQuad when using
toJSON.

web-platform-tests/css/geometry/idlharness-expected.txt:
web-platform-tests/css/geometry/idlharness.worker-expected.txt:

Source/WebCore:

Reviewed by Eric Carlson.

Replace the 'serializable' keyword, which has been removed from WebIDL,
with its replacement, '[Default] object toJSON()'.

The new version is pretty similar, but has much less room for customization
in that you can no longer specify which attributes are included in the JSON
result. Rather, all attributes that qualify as having a 'JSON type' are included
for the interface itself and all ancestor interfaces. Interfaces that need more
control can provide their own toJSON operation with the [Default] extended
attribute.

This updates all the IDLs that used serializer to use the new [Default] except
RTCIceCandidate.idl, which is specified to have a custom toJSON that returns
a RTCIceCandidateInit, so that was implemented instead.

css/DOMMatrixReadOnly.idl:
dom/DOMPointReadOnly.idl:
dom/DOMQuad.idl:
dom/DOMRectReadOnly.idl:
page/PerformanceEntry.idl:
page/PerformanceResourceTiming.h:
page/PerformanceResourceTiming.idl:
page/PerformanceServerTiming.idl:
page/PerformanceTiming.idl:
Modules/mediastream/MediaDeviceInfo.idl:
Modules/mediastream/RTCIceCandidate.cpp:
Modules/mediastream/RTCIceCandidate.h:
Modules/mediastream/RTCIceCandidate.idl:
Modules/mediastream/RTCSessionDescription.idl:
Modules/paymentrequest/PaymentAddress.idl:
Modules/paymentrequest/PaymentResponse.idl:

Update IDLs replacing all use of serializer.

bindings/scripts/CodeGenerator.pm:

(InterfaceHasRegularToJSONOperation):
(IsJSONType):
(InheritsSerializable): Deleted.
(IsSerializableType): Deleted.
(IsSerializableAttribute): Deleted.

bindings/scripts/CodeGeneratorJS.pm:

(PrototypeOperationCount):
(GenerateHeader):
(GeneratePropertiesHashTable):
(GenerateImplementation):
(GenerateOperationDefinition):
(GenerateDefaultOperationDefinition):
(GenerateDefaultToJSONOperationDefinition):
(GetRuntimeEnabledStaticProperties):
(GenerateSerializerDefinition): Deleted.

bindings/scripts/IDLParser.pm:

(cloneOperation):
(parsePartialInterfaceMember):
(applyMemberList):
(parseSerializer): Deleted.
(parseSerializerRest): Deleted.
(parseSerializationPattern): Deleted.
(parseSerializationAttributes): Deleted.

bindings/scripts/IDLAttributes.json:

Add support for [Default] toJSON and remove support for serializer.

bindings/scripts/test/BindingTestGlobalConstructors.idl:
bindings/scripts/test/JS/JSTestDefaultToJSON.cpp: Added.
bindings/scripts/test/JS/JSTestDefaultToJSON.h: Added.
bindings/scripts/test/JS/JSTestGlobalObject.cpp:
bindings/scripts/test/JS/JSTestNode.cpp:
bindings/scripts/test/JS/JSTestNode.h:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/JS/JSTestSerialization.cpp: Removed.
bindings/scripts/test/JS/JSTestSerialization.h: Removed.
bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp: Removed.
bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.h: Removed.
bindings/scripts/test/JS/JSTestSerializationInherit.cpp: Removed.
bindings/scripts/test/JS/JSTestSerializationInherit.h: Removed.
bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp: Removed.
bindings/scripts/test/JS/JSTestSerializationInheritFinal.h: Removed.
bindings/scripts/test/SupplementalDependencies.dep:
bindings/scripts/test/TestDefaultToJSON.idl: Added.
bindings/scripts/test/TestDefaultToJSONIndirectInheritance.idl: Added.
bindings/scripts/test/TestDefaultToJSONInherit.idl: Added.
bindings/scripts/test/TestDefaultToJSONInheritFinal.idl: Added.
bindings/scripts/test/TestNode.idl:
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/TestSerialization.idl: Removed.
bindings/scripts/test/TestSerializationIndirectInheritance.idl: Removed.
bindings/scripts/test/TestSerializationInherit.idl: Removed.
bindings/scripts/test/TestSerializationInheritFinal.idl: Removed.

Update tests.

LayoutTests:

<rdar://problem/68668407>

Reviewed by Eric Carlson.

Update test and results to account for RTCIceCandidate.toJSON()
now returning RTCIceCandidateInit.

fast/mediastream/RTCIceCandidate-expected.txt:
fast/mediastream/RTCIceCandidate.html:

10:10 AM Changeset in webkit [267019] by Jonathan Bedard

3 edits in trunk/Tools

[webkitcorepy] Disable AutoInstaller with environment variable
https://bugs.webkit.org/show_bug.cgi?id=216396
<rdar://problem/68680933>

Reviewed by Dewei Zhu.

Scripts/libraries/webkitcorepy/webkitcorepy/init.py:
Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(AutoInstall):
(AutoInstall.enabled): Check DISABLE_WEBKITCOREPY_AUTOINSTALLER to see if the autoinstaller
has been explicitly disabled.
(AutoInstall.set_directory): Early exit if the autoinstaller is explicitly disabled.
(AutoInstall.find_module):
(AutoInstall.enable): Deleted.
(AutoInstall.disable): Deleted.

10:00 AM Changeset in webkit [267018] by Chris Dumez

13 edits in trunk

Some WebAudio tests give different output on different machines
https://bugs.webkit.org/show_bug.cgi?id=216371
<rdar://problem/68653909>

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline existing tests.

web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:

Source/WebCore:

Hardcode default sample rate for AudioContext to 44100 for WPT tests instead
of using the hardware sample rate. This allows some tests to output consistent
results on different machines.

No new tests, unskipped existing test.

Modules/webaudio/AudioContext.cpp:

(WebCore::defaultSampleRateForTesting):
(WebCore::AudioContext::setDefaultSampleRateForTesting):
(WebCore::AudioContext::create):

Modules/webaudio/AudioContext.h:

(WebCore::AudioContext::create):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setDefaultAudioContextSampleRate):

testing/InternalSettings.h:
testing/InternalSettings.idl:

LayoutTests:

TestExpectations:

Unskip test that should now have consistent results across machines.

resources/testharnessreport.js:

Hardcode default sample rate for AudioContext to 44100 for WPT tests instead
of using the hardware sample rate.

9:46 AM Changeset in webkit [267017] by sbarati@apple.com

3 edits
1 add in trunk

Don't assume byte code operands are uint32 JSValues
https://bugs.webkit.org/show_bug.cgi?id=216386

Reviewed by Yusuke Suzuki.

JSTests:

stress/dont-assume-bytecode-operand-is-uint32.js: Added.

(async foo):

Source/JavaScriptCore:

The slow path for enumerator_generic_pname was assuming that its input index operand
would always be a UInt32 JSValue boxed as int32. However, this assumption isn't true
because that value can have double format in the DFG, and remain in that format when
we exit from the DFG to baseline/LLInt code.

This was found via the widening number fuzzing agent.

I also audited two more places that seem like they suffer from the same issue,
and also switched them to using the asUInt32AsAnyInt function:

enumerator_structure_pname
create_rest

runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

9:22 AM Changeset in webkit [267016] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[CG] Cache the last status of the image encoded data
https://bugs.webkit.org/show_bug.cgi?id=216104

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-09-14
Reviewed by Youenn Fablet.

Cache the last status of the image encoded data such that early decisions
can be made without calling system functions.

platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoderCG::encodedDataStatus const):

platform/graphics/cg/ImageDecoderCG.h:

9:19 AM Changeset in webkit [267015] by Hector Lopez

2 edits in trunk/LayoutTests

[ macOS ] webanimations/accelerated-animation-easing-update-after-pause.html is a flaky ImageOnlyFailure
https://bugs.webkit.org/show_bug.cgi?id=216481

Unreviewed test gardening.

platform/mac/TestExpectations:

8:47 AM Changeset in webkit [267014] by Chris Dumez

15 edits
2 adds
4 deletes in trunk/Source/WebCore

Add proper support for AudioContextOptions.sampleRate
https://bugs.webkit.org/show_bug.cgi?id=216425

Reviewed by Eric Carlson.

Add proper support for AudioContextOptions.sampleRate. Previously, our AudioContext always ran
at the hardware's sampleRate, no matter what value was set for AudioContextOptions.sampleRate.

This patch is based on the following Chromium changes:

Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::createDestination):
When creating an AudioDestination, pass the requested AudioContext sample rate
instead of the hardware sample rate.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:

platform/audio/AudioFIFO.cpp: Removed.
platform/audio/AudioFIFO.h: Removed.
platform/audio/AudioPullFIFO.cpp: Removed.
platform/audio/AudioPullFIFO.h: Removed.
platform/audio/PushPullFIFO.cpp: Added.
platform/audio/PushPullFIFO.h: Added.

Replace AudioFIFO and AudioPullFIFO with a new PushPullFIFO replacement, similarly
to what was done in Chromium in:

https://codereview.chromium.org/2549093009

platform/audio/MultiChannelResampler.cpp:

(WebCore::MultiChannelResampler::MultiChannelResampler):

platform/audio/MultiChannelResampler.h:
platform/audio/SincResampler.cpp:

(WebCore::SincResampler::SincResampler):
(WebCore::SincResampler::updateRegions):
(WebCore::SincResampler::initializeKernel):
(WebCore::SincResampler::process):

platform/audio/SincResampler.h:

Add parameter to MultiChannelResampler & SincResampler to allow the client to specify
the size of the buffer in frames when the resampler calls AudioSourceProvider::provideInput()
to get input data. This is necessary because our WebAudio implementation uses a static
buffer size of 128 frames. This is similar to what was done in Chromium in:

https://codereview.chromium.org/14189035

platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::AudioDestinationCocoa::AudioDestinationCocoa):
(WebCore::AudioDestinationCocoa::setAudioStreamBasicDescription):
(WebCore::AudioDestinationCocoa::render):
(WebCore::AudioDestinationCocoa::provideInput):

platform/audio/cocoa/AudioDestinationCocoa.h:
Adopt PushPullFIFO to resolve the buffer size mismatch between the WebAudio engine and the callback function from the actual audio device, similarly to what was done in Chromium.
When the context's sample rate differs from the hardware sample rate, instantiate a MultiChannelResampler and use it in render() to do the resampling.

platform/audio/ios/AudioDestinationIOS.cpp:

(WebCore::AudioDestinationCocoa::configure):

platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestinationCocoa::configure):
Drop sampleRate parameter as it is no longer needed.

platform/mock/MockAudioDestinationCocoa.cpp:

(WebCore::MockAudioDestinationCocoa::tick):

8:44 AM Changeset in webkit [267013] by Peng Liu

3 edits in trunk/Source/WebCore/PAL

Unreviewed, reverting r267004.

The patch leads to build failures on macOS Catalina.

Reverted changeset:

"Clean up AVKitSPI.h"
https://bugs.webkit.org/show_bug.cgi?id=216449
https://trac.webkit.org/changeset/267004

8:30 AM Changeset in webkit [267012] by Hector Lopez

2 edits in trunk/LayoutTests

REGRESSION (r266634): fast/selectors/text-field-selection-stroke-color.html and fast/selectors/text-field-selection-window-inactive-stroke-color.html are flaky failures with pixel noise
https://bugs.webkit.org/show_bug.cgi?id=216394

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

8:28 AM Changeset in webkit [267011] by weinig@apple.com

14 edits
2 adds in trunk

[WebIDL] Split DOM Parsing related functions out of Element and ShadowRoot and into their own IDL files to match specs
https://bugs.webkit.org/show_bug.cgi?id=216461

Reviewed by Darin Adler.

Source/WebCore:

No behavior change, just cleaning up which IDL files DOM Parsing related operations
live to match specs.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
dom/Element.idl:
dom/ElementDOMParsing.idl: Added.
dom/InnerHTML.idl: Added.
dom/ShadowRoot.idl:

LayoutTests:

js/dom/dom-static-property-for-in-iteration-expected.txt:
platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
platform/ios-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
platform/mac-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:

Update for change in iteration order due to use of partial interfaces.

2:51 AM Changeset in webkit [267010] by Philippe Normand

10 edits
1 add in trunk

[Flatpak SDK] Migration to SDK 0.3 branch
https://bugs.webkit.org/show_bug.cgi?id=216073

Reviewed by Adrian Perez de Castro.

Tools:

As this new SDK branch is based on the FDO 20.08 SDK which breaks ABI, existing WebKit
builds done with the 0.2 branch will no longer be usable. Developers are advised to remove
their WebKitBuild/{GTK,WPE} local directories after updating to 0.3.

Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server): Since we now ship Mesa directly in the SDK we can easily
configure the prefix where DRI modules are installed. This is now the same as in the JHBuild
sysroot.

flatpak/flatpakutils.py:

(WebkitFlatpak.init): Bump to 0.3 branch. Also un-hardcode host platform architecture so
that we can more easily add aarch64 bots later.
(WebkitFlatpak._get_packages): The GL extension is no longer needed because Mesa is shipped
directly within our SDK now. Also install the rust extension, which is useful eg when doing
development with gst-build.

flatpak/webkit-bwrap: Add rustc path in PATH.

LayoutTests:

fast/xsl/resources/xslt-enc-cyr.xsl: Add name attribute in xsl templates, as mandated by the spec.
fast/xsl/resources/xslt-enc.xsl: Ditto.
fast/xsl/resources/xslt-enc16.xsl: Ditto.
fast/xsl/resources/xslt-text.xsl: Ditto.
platform/glib/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Added.
platform/glib/fast/xsl/xslt-processor-expected.txt: Added.

1:38 AM Changeset in webkit [267009] by Chris Lord

5 edits in trunk/Source/WebCore

CSS parsing-related singletons should only be used on the main thread
https://bugs.webkit.org/show_bug.cgi?id=216370

Reviewed by Darin Adler.

Mark some singletons that aren't safe to use off the main thread as
MainThreadNeverDestroyed instead of just NeverDestroyed.

No new tests because there is no behavior change.

css/CSSValuePool.cpp:

(WebCore::CSSValuePool::singleton):

css/parser/CSSParserContext.cpp:

(WebCore::strictCSSParserContext):

rendering/RenderThemeAdwaita.cpp:

(WebCore::RenderTheme::singleton):

rendering/RenderThemeGtk.cpp:

(WebCore::RenderTheme::singleton):

1:17 AM Changeset in webkit [267008] by mmaxfield@apple.com

7 edits
1 add
1 delete in trunk

[Apple Win] Migrate from CGFontGetGlyphsForUnichars() to CTFontGetGlyphsForCharacters()
https://bugs.webkit.org/show_bug.cgi?id=216446

Reviewed by Darin Adler.

Source/WebCore:

This patch is one of the steps to moving the Apple Win port from CGFont to CTFont.
This patch removes the #if !PLATFORM(WIN) guard from GlyphPageCoreText.cpp and deletes
the old functions it used to be using.

Covered by existing tests.

PlatformAppleWin.cmake:
platform/graphics/coretext/GlyphPageCoreText.cpp:
platform/graphics/win/GlyphPageTreeNodeCGWin.cpp: Removed. There's nothing left in the file.

LayoutTests:

Updating tests.

fast/text/flag-codepoint.html: The Windows emoji font draws slightly higher than the ascent. Update the test to be more robust.
platform/win/fast/css/font-face-opentype-expected.png: Added.
platform/win/fast/css/font-face-opentype-expected.txt:
platform/win/mathml/presentation/roots-expected.txt:

Sep 13, 2020:

5:00 PM Changeset in webkit [267007] by weinig@apple.com

76 edits in trunk/Source/WebCore

[WebIDL] Remove need for [MayThrowException] on constructors and legacy factory functions
https://bugs.webkit.org/show_bug.cgi?id=216442

Reviewed by Darin Adler.

Deduce implementation potentially throwing by using the existing overload of
toJSNewlyCreated that conditionally checks for exceptions based on the return
type. constexpr IsExceptionOr to maintain existing optimizations around conditional
calls to RETURN_IF_EXCEPTION.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):
Update code generation to output code that can handle constructors that return either
ExceptionOr or not. Maintain existing static assertion that the underlying return type
is a Ref<> using std::conditional_t predicated on IsExceptionOr and maintain the existing
optimization to not check for an exception after toJSNewlyCreated if one could not have
been made by again utilizing IsExceptionOr.

bindings/scripts/IDLAttributes.json:

Remove [LegacyFactoryFunctionMayThrowException] now that it is not needed.

Modules/applepay/ApplePaySession.idl:
Modules/encryptedmedia/legacy/WebKitMediaKeys.idl:
Modules/fetch/FetchHeaders.idl:
Modules/fetch/FetchRequest.idl:
Modules/fetch/FetchResponse.idl:
Modules/mediarecorder/MediaRecorder.idl:
Modules/mediastream/RTCIceCandidate.idl:
Modules/mediastream/RTCPeerConnection.idl:
Modules/paymentrequest/MerchantValidationEvent.idl:
Modules/paymentrequest/PaymentRequest.idl:
Modules/webaudio/AnalyserNode.idl:
Modules/webaudio/AudioBuffer.idl:
Modules/webaudio/AudioBufferSourceNode.idl:
Modules/webaudio/AudioContext.idl:
Modules/webaudio/BiquadFilterNode.idl:
Modules/webaudio/ChannelMergerNode.idl:
Modules/webaudio/ChannelSplitterNode.idl:
Modules/webaudio/ConstantSourceNode.idl:
Modules/webaudio/ConvolverNode.idl:
Modules/webaudio/DelayNode.idl:
Modules/webaudio/DynamicsCompressorNode.idl:
Modules/webaudio/GainNode.idl:
Modules/webaudio/IIRFilterNode.idl:
Modules/webaudio/MediaElementAudioSourceNode.idl:
Modules/webaudio/MediaStreamAudioDestinationNode.idl:
Modules/webaudio/MediaStreamAudioSourceNode.idl:
Modules/webaudio/OfflineAudioContext.idl:
Modules/webaudio/OscillatorNode.idl:
Modules/webaudio/PannerNode.idl:
Modules/webaudio/PeriodicWave.idl:
Modules/webaudio/StereoPannerNode.idl:
Modules/webaudio/WaveShaperNode.idl:
Modules/webaudio/WebKitAudioContext.idl:
Modules/webaudio/WebKitOfflineAudioContext.idl:
Modules/websockets/WebSocket.idl:
Modules/webxr/WebXRRigidTransform.idl:
Modules/webxr/WebXRWebGLLayer.idl:
animation/KeyframeEffect.idl:
css/DOMMatrix.idl:
css/DOMMatrixReadOnly.idl:
css/WebKitCSSMatrix.idl:
dom/StaticRange.idl:
dom/TextDecoder.idl:
dom/TextDecoderStreamDecoder.idl:
html/DOMURL.idl:
html/HTMLOptionElement.h:
html/HTMLOptionElement.idl:
html/ImageData.idl:
html/URLSearchParams.idl:
html/track/TextTrackCue.idl:
page/EventSource.idl:
page/IntersectionObserver.idl:
workers/Worker.idl:

Remove all uses of [LegacyFactoryFunctionMayThrowException] and [MayThrowException]
on constructors.

html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::createForLegacyFactoryFunction):
(WebCore::HTMLAudioElement::createForJSConstructor): Deleted.

html/HTMLAudioElement.h:
html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::createForLegacyFactoryFunction):
(WebCore::HTMLImageElement::createForJSConstructor): Deleted.

html/HTMLImageElement.h:
html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::createForLegacyFactoryFunction):
(WebCore::HTMLOptionElement::createForJSConstructor): Deleted.
Renamed createForJSConstructor to createForLegacyFactoryFunction to better
match current WebIDL terminology.

bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp:

(WebCore::JSExposedToWorkerAndWindowConstructor::construct):

bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::construct):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):

bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp:

(WebCore::JSTestLegacyFactoryFunctionLegacyFactoryFunction::construct):

bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::construct):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::construct):

bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):

bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:

(WebCore::constructJSTestOverloadedConstructorsWithSequence1):
(WebCore::constructJSTestOverloadedConstructorsWithSequence2):

bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:

(WebCore::JSTestPromiseRejectionEventConstructor::construct):

bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::construct):

bindings/scripts/test/TestLegacyFactoryFunction.idl:

Update tests/expectations.

4:55 PM Changeset in webkit [267006] by weinig@apple.com

2 edits in trunk/Source/WebCore

FIXME in MediaDevices.idl is incorrect
https://bugs.webkit.org/show_bug.cgi?id=216459

Reviewed by Anders Carlsson.

Modules/mediastream/MediaDevices.idl:

Remove FIXME about making MediaDevices an EventTarget subclass as it is a subclass
EventTarget.

4:50 PM Changeset in webkit [267005] by weinig@apple.com

2 edits in trunk/Source/WebCore

FIXME in MouseEventInit.idl is incorrect (we do support unsigned short buttons = 0)
https://bugs.webkit.org/show_bug.cgi?id=216460

Reviewed by Darin Adler.

dom/MouseEventInit.idl:

Removes incorrect FIXME, adds spec link, and updates formatting to match spec.

2:17 PM Changeset in webkit [267004] by Peng Liu

3 edits in trunk/Source/WebCore/PAL

Clean up AVKitSPI.h
https://bugs.webkit.org/show_bug.cgi?id=216449

Reviewed by Darin Adler.

pal/spi/cocoa/AVFoundationSPI.h:

Remove a duplicated AVKit header file.

pal/spi/cocoa/AVKitSPI.h:

Organize header files (and definitions) in the following order:

General AVKit header files
General AVKit internal header files and definitions
Feature specific internal header files and definitions

1:32 PM Changeset in webkit [267003] by Aditya Keerthi

13 edits
2 deletes in trunk/Source/WebCore

Consolidate BaseDateAndTimeInputType and BaseChooserOnlyDateAndTimeInputType
https://bugs.webkit.org/show_bug.cgi?id=216414

Reviewed by Devin Rousso.

BaseChooserOnlyDateAndTimeInputType is the only derived class of
BaseDateAndTimeInputType. Furthermore, with the introduction of editable
components, "ChooserOnly" no longer makes sense as a name for the
derived class. Consequently, all logic in BaseChooserOnlyDateAndTimeInputType
was moved into BaseDateAndTimeInputType, and the derived classes of the
"ChooserOnly" type now inherit BaseDateAndTimeInputType.

Also changed some methods from override to final, and made some protected
methods private, where possible.

No new tests, as there is no change in behavior.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
html/BaseChooserOnlyDateAndTimeInputType.cpp: Removed.
html/BaseChooserOnlyDateAndTimeInputType.h: Removed.
html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::DateTimeFormatValidator::visitField):
(WebCore::BaseDateAndTimeInputType::DateTimeFormatValidator::validateFormat):
(WebCore::BaseDateAndTimeInputType::~BaseDateAndTimeInputType):
(WebCore::BaseDateAndTimeInputType::isMouseFocusable const):
(WebCore::BaseDateAndTimeInputType::shouldHaveSecondField const):
(WebCore::BaseDateAndTimeInputType::shouldHaveMillisecondField const):
(WebCore::BaseDateAndTimeInputType::setValue):
(WebCore::BaseDateAndTimeInputType::handleDOMActivateEvent):
(WebCore::BaseDateAndTimeInputType::createShadowSubtree):
(WebCore::BaseDateAndTimeInputType::destroyShadowSubtree):
(WebCore::BaseDateAndTimeInputType::updateInnerTextValue):
(WebCore::BaseDateAndTimeInputType::hasCustomFocusLogic const):
(WebCore::BaseDateAndTimeInputType::attributeChanged):
(WebCore::BaseDateAndTimeInputType::elementDidBlur):
(WebCore::BaseDateAndTimeInputType::detach):
(WebCore::BaseDateAndTimeInputType::isPresentingAttachedView const):
(WebCore::BaseDateAndTimeInputType::handleKeydownEvent):
(WebCore::BaseDateAndTimeInputType::handleKeypressEvent):
(WebCore::BaseDateAndTimeInputType::handleKeyupEvent):
(WebCore::BaseDateAndTimeInputType::handleFocusEvent):
(WebCore::BaseDateAndTimeInputType::accessKeyAction):
(WebCore::BaseDateAndTimeInputType::didBlurFromControl):
(WebCore::BaseDateAndTimeInputType::didChangeValueFromControl):
(WebCore::BaseDateAndTimeInputType::isEditControlOwnerDisabled const):
(WebCore::BaseDateAndTimeInputType::isEditControlOwnerReadOnly const):
(WebCore::BaseDateAndTimeInputType::localeIdentifier const):
(WebCore::BaseDateAndTimeInputType::didChooseValue):
(WebCore::BaseDateAndTimeInputType::didEndChooser):
(WebCore::BaseDateAndTimeInputType::closeDateTimeChooser):

html/BaseDateAndTimeInputType.h:
html/DateInputType.cpp:

(WebCore::DateInputType::DateInputType):

html/DateInputType.h:
html/DateTimeLocalInputType.cpp:
html/DateTimeLocalInputType.h:
html/MonthInputType.h:
html/TimeInputType.cpp:

(WebCore::TimeInputType::TimeInputType):

html/TimeInputType.h:
html/WeekInputType.h:

1:30 PM Changeset in webkit [267002] by Simon Fraser

20 edits in trunk/Source

Overflow:scroll rubberbanding is interrupted by post-layout scrolling
https://bugs.webkit.org/show_bug.cgi?id=216463
<rdar://problem/67095741>

Reviewed by Darin Adler.

When rubberbanding overflow:scroll RenderLayer has an overscrolled scroll offset.
If RenderLayer::updateScrollInfoAfterLayout() happens when in this state, it can
clamp the scroll offset, causing the rubberband to collapse which interferes with
the user interaction. This happend on Gmail when composing a reply.

Fix by tracking the rubberbanding state in the scrolling tree, and having RenderLayer
query this state via the ScrollingCoordinator. RenderLayer::updateScrollInfoAfterLayout()
already tested isRubberBandInProgress(). This is similar to how isUserScrollInProgress()
and isScrollSnapInProgress() work.

This patch also fixes the tracking of rubberbanding state. Previously setMainFrameIsRubberBanding()
was just based on when the timer was started and stopped, which did not match the
implementation of ScrollController::isRubberBandInProgress(). Now ScrollController
correctly notifies its clients when the rubberbanding state changes by updating that
state whenever any of the conditions consulted in isRubberBandInProgressInternal() change.

Source/WebCore:

I tried to make tests for this, but the timing of wheel and scroll event delivery makes
reliable detection of interrupted rubberbands impossible in WebKitTestRunner.

page/FrameView.cpp:

(WebCore::FrameView::isRubberBandInProgress const):

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::isRubberBandInProgress const):

page/scrolling/AsyncScrollingCoordinator.h:
page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::isRubberBandInProgress const):

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::isRubberBandInProgressForNode):
(WebCore::ScrollingTree::setRubberBandingInProgressForNode):
(WebCore::ScrollingTree::isRubberBandInProgress): Deleted.
(WebCore::ScrollingTree::setMainFrameIsRubberBanding): Deleted.

page/scrolling/ScrollingTree.h:
page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::commitStateBeforeChildren):

page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::currentScrollPositionChanged):
(WebCore::ScrollingTreeFrameScrollingNodeMac::updateMainFramePinAndRubberbandState):

page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:
page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:

(WebCore::ScrollingTreeOverflowScrollingNodeMac::currentScrollPositionChanged):

page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::currentScrollPositionChanged):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::isRubberBandInProgress const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::didStopRubberbandSnapAnimation):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::rubberBandingStateChanged):

platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::notifyPositionChanged):

platform/cocoa/ScrollController.h:

(WebCore::ScrollControllerClient::rubberBandingStateChanged):

platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::handleWheelEvent):
(WebCore::ScrollController::snapRubberBandTimerFired):
(WebCore::ScrollController::scrollPositionChanged):
(WebCore::ScrollController::isRubberBandInProgress const):
(WebCore::ScrollController::stopSnapRubberbandTimer):
(WebCore::ScrollController::isRubberBandInProgressInternal const):
(WebCore::ScrollController::updateRubberBandingState):
(WebCore::ScrollController::updateGestureInProgressState):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::isRubberBandInProgress const):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):

Source/WebKit:

WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h:
WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:

(WebKit::RemoteScrollingCoordinator::isRubberBandInProgress const):
(WebKit::RemoteScrollingCoordinator::scrollingStateInUIProcessChanged):

12:18 PM Changeset in webkit [267001] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Create LineBox::InlineBox for [ContainerEnd] runs forced to the next line.
https://bugs.webkit.org/show_bug.cgi?id=216462

Reviewed by Antti Koivisto.

Normally the [container end] run forms a continous content with the runs in front of it
(there's no breaking opportunity between e.g the last text run and the [container end] run).
However in certain cases the [container end] run may be forced over to the next line.
e.g.
<span>the [container end] run is forced over to the next line<br></span>over here
runs: [container start][text run][line break run]<-new line->[container end][text run]

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::constructInlineBoxes):

11:47 AM Changeset in webkit [267000] by commit-queue@webkit.org

4 edits in trunk

Make CanvasRenderingContext2D functions parameters not default to undefined
https://bugs.webkit.org/show_bug.cgi?id=216438

Patch by Rob Buis <rbuis@igalia.com> on 2020-09-13
Reviewed by Sam Weinig.

Source/WebCore:

Some string parameters default to "undefined", however the code path is the same when
no default is given and implicitly a null string is passed, so remove the default
values.

html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

Adjust expected test result.

inspector/canvas/recording-2d-full-expected.txt:

11:13 AM Changeset in webkit [266999] by weinig@apple.com

31 edits in trunk/Source/WebCore

[WebIDL] Remove need for [MayThrowException] on indexed and named setters
https://bugs.webkit.org/show_bug.cgi?id=216441

Reviewed by Darin Adler.

Deduce implementation potentially throwing by introspecting the return
type of the setters implementation in a new helper, invokeFunctorPropagatingExceptionIfNecessary.
This allows us to remove another set of uses of [MayThrowException].

bindings/js/JSDOMConvertBase.h:
dom/ExceptionOr.h:

Move IsExceptionOr to ExceptionOr.h so it can be used more widely.

bindings/js/JSDOMExceptionHandling.h:

(WebCore::invokeFunctorPropagatingExceptionIfNecessary):
Add helper that invokes the passed in functor and calls propagateException
if the return type was an ExceptionOr<>. If the return type is not an
ExceptionOr<>, it just invokes the functor and returns.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateInvokeIndexedPropertySetter):
(GenerateInvokeNamedPropertySetter):
Update to call invokeFunctorPropagatingExceptionIfNecessary.

css/CSSStyleDeclaration.idl:
dom/DOMStringMap.idl:
storage/Storage.idl:
svg/SVGLengthList.idl:
svg/SVGNumberList.idl:
svg/SVGPathSegList.idl:
svg/SVGPointList.idl:
svg/SVGStringList.idl:
svg/SVGTransformList.idl:

Remove now unneeded [MayThrowException].

bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithLegacyOverrideBuiltIns.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.cpp:
bindings/scripts/test/TestIndexedSetterThrowingException.idl:
bindings/scripts/test/TestNamedAndIndexedSetterThrowingException.idl:
bindings/scripts/test/TestNamedSetterThrowingException.idl:

Update tests/expectations.

10:52 AM Changeset in webkit [266998] by weinig@apple.com

2 edits in trunk/Source/WebCore

Fix FIXME in XPathEvaluatorBase about using [NewObject]
https://bugs.webkit.org/show_bug.cgi?id=216458

Reviewed by Anders Carlsson.

xml/XPathEvaluatorBase.idl:

Address FIXME by applying [NewObject] to createExpression. The implementation already matches this.

10:21 AM Changeset in webkit [266997] by ap@apple.com

2 edits in trunk/Tools

Move block-spammers tool to python 3
https://bugs.webkit.org/show_bug.cgi?id=216457

Reviewed by Sam Weinig.

Scripts/block-spammers: Updated for new print() and translate() syntax, and

moved from raw_input() to input().

9:46 AM Changeset in webkit [266996] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][Tree building] Table rows may not have any children.
https://bugs.webkit.org/show_bug.cgi?id=216456

Reviewed by Antti Koivisto.

Cover the case when the table row has no children at all (call numberOfCellsPerRow.append() on evey row when needed).

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::buildTableStructure):

9:19 AM Changeset in webkit [266995] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Text run is at incorrect vertical position when parent inline box is stretched
https://bugs.webkit.org/show_bug.cgi?id=216453

Reviewed by Antti Koivisto.

Text runs don't necessarily start at the top of the parent inline box. When the inline box is
stretched by some other content (nested inline box or atomic inline-level box) the run is pushed down.
This patch computes the correct vertical position by using the inline box's baseline (text always sits on the baseline).

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::logicalRectForTextRun const):

9:18 AM Changeset in webkit [266994] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC] Fix showLayoutTree to show anonymous inline boxes
https://bugs.webkit.org/show_bug.cgi?id=215437

Reviewed by Antti Koivisto.

This patch also adds baseline and run content logging.

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputLayoutBox):
(WebCore::Layout::outputLayoutTree):

8:43 AM Changeset in webkit [266993] by Wenson Hsieh

9 edits in trunk

Add a key to the text manipulation userInfo dictionary indicating whether the translated item is on-screen
https://bugs.webkit.org/show_bug.cgi?id=216452
<rdar://problem/68785397>

Reviewed by Darin Adler.

Source/WebCore:

For debugging purposes, and also to provide a hint as to what text should be prioritized when translating
web pages, WebKit clients have requested a new field in the userInfo metadata dictionary associated with each
token that indicates whether or not a translation (i.e. text manipulation) token represents an element that is
currently on-screen. See below for more details.

Test: TextManipulation.StartTextManipulationExtractsUserInfo

editing/TextManipulationController.cpp:

(WebCore::tokenInfo):

Set the flag by checking whether or not the absolute bounding rect intersects with the visible content rect of
the enclosing frame. Note that since subframe content is currently never extracted for translation, we don't
need logic yet to recursively check that parent iframe elements are visible.

editing/TextManipulationController.h:

Add a new bool flag in ManipulationTokenInfo.

(WebCore::TextManipulationController::ManipulationTokenInfo::encode const):
(WebCore::TextManipulationController::ManipulationTokenInfo::decode):

Source/WebKit:

Add _WKTextManipulationTokenUserInfoVisibilityKey and set its value to the value of the isVisible member in
ManipulationTokenInfo. See WebCore ChangeLog for more details.

UIProcess/API/Cocoa/WKWebView.mm:

(createUserInfo):

UIProcess/API/Cocoa/_WKTextManipulationToken.h:
UIProcess/API/Cocoa/_WKTextManipulationToken.mm:

Tools:

Adjust an existing test so that it adds a fourth text paragraph with 2000px of top margin, and also
programmatically scrolls after loading the page so that only this last paragraph is visible. We expect the
metadata to indicate that none of the other tokens except this last one has a value of YES for
_WKTextManipulationTokenUserInfoVisibilityKey.

TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

5:07 AM Changeset in webkit [266992] by Philippe Normand

3 edits in trunk/Source/WebCore

Unreviewed, GTK/WPE EME build fixes after r266721

The Thunder decryptor changes were not tested before landing, this code path is not enabled
on any bot currently, hence requires manual testing.

platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp:

(protectionSystemId):
(cdmProxyAttached):
(decrypt):

platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.h:

2:45 AM Changeset in webkit [266991] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

Clean up LazyLoadImageObserver
https://bugs.webkit.org/show_bug.cgi?id=216435

Patch by Rob Buis <rbuis@igalia.com> on 2020-09-13
Reviewed by Darin Adler.

Clean up LazyLoadImageObserver to match LazyLoadFrameObserver, inspired by the
review of bug 215442. Specifically remove the friend declaration and create
function, rename m_lazyLoadImageObserver to make its use more clear and therefore
remove the comment about it.

dom/Document.cpp:

(WebCore::Document::lazyLoadImageObserver):

html/HTMLIFrameElement.cpp:
html/LazyLoadFrameObserver.cpp:

(WebCore::LazyLoadFrameObserver::observe):
(WebCore::LazyLoadFrameObserver::unobserve):
(WebCore::LazyLoadFrameObserver::intersectionObserver):
(WebCore::LazyLoadFrameObserver::isObserved const):

html/LazyLoadFrameObserver.h:
html/LazyLoadImageObserver.cpp:

(WebCore::LazyLoadImageObserver::unobserve):
(WebCore::LazyLoadImageObserver::intersectionObserver):
(WebCore::LazyLoadImageObserver::isObserved const):

html/LazyLoadImageObserver.h:

(WebCore::LazyLoadImageObserver::create): Deleted.

1:13 AM Changeset in webkit [266990] by Pablo Saavedra

4 edits in trunk/Source/WebKit

[GTK][WPE] Build fails when -DENABLE_SERVICE_WORKER=OFF
https://bugs.webkit.org/show_bug.cgi?id=216455

Unreviewed build fix.

UIProcess/API/glib/WebKitWebsiteData.cpp:

(recordContainsSupportedDataTypes):
(toWebKitWebsiteDataTypes):

UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

(toWebsiteDataTypes):

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):

Sep 12, 2020:

11:39 PM Changeset in webkit [266989] by commit-queue@webkit.org

4 edits
2 adds in trunk

Safely handle overly-long CSS variable values
https://bugs.webkit.org/show_bug.cgi?id=216407

Patch by Tyler Wilcock <Tyler Wilcock> on 2020-09-12
Reviewed by Darin Adler.

Source/WebCore:

Per spec, treat overly long CSS variable values as invalid.

https://drafts.csswg.org/css-variables/#long-variables

Test: fast/css/variables/invalidate-overly-long-variable-values.html

css/CSSVariableReferenceValue.cpp:

(WebCore::resolveVariableReference):
Return false for any variable values greater than maxSubstitutionTokens long.

css/CSSVariableReferenceValue.h:

Add maxSubstitutionTokens.

LayoutTests:

fast/css/variables/invalidate-overly-long-variable-values.html: Added.
fast/css/variables/invalidate-overly-long-variable-values-expected.html: Added.

11:21 PM Changeset in webkit [266988] by Darin Adler

18 edits
4 copies in trunk

Send TestRendered event after running a test but before dumping
https://bugs.webkit.org/show_bug.cgi?id=216428

Reviewed by Sam Weinig.

Tools:

DumpRenderTree/CMakeLists.txt: Added the new files and directories.
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Ditto.

DumpRenderTree/PlatformWin.cmake: Temporarily disable precompiled headers

on WinCairo since they were not working properly with JSBasics.cpp.

DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate readyToDumpState]): Added. Calls sendTestRenderedEvent.
(-[FrameLoadDelegate processWork:]): Call readyToDumpState.
(-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Ditto.

DumpRenderTree/win/FrameLoadDelegate.cpp:

(readyToDumpState): Added. Calls sendTestRenderedEvent.
(FrameLoadDelegate::processWork): Call readyToDumpState.
(FrameLoadDelegate::locationChangeDone): Ditto.

TestRunnerShared/Bindings/JSBasics.cpp: Added.

(WTR::JSValueMakeBooleanOrNull): Moved from JSWrappable.h.
(WTR::JSValueToNullableBoolean): Ditto.
(WTR::JSValueMakeStringOrNull): Ditto.
(WTR::createJSString): Ditto.
(WTR::makeValue): Ditto.
(WTR::objectProperty): Ditto.
(WTR::setProperty): Added. Sets a named property value to a boolean.
(WTR::call): Moved from JSWrappable.h.
(WTR::callConstructor): Added. Gets a global constructor and calls it.

TestRunnerShared/Bindings/JSBasics.h: Added. Declares the above functions.

TestRunnerShared/Bindings/JSWrappable.h:

(WTR::JSValueMakeBooleanOrNull): Deleted.
(WTR::JSValueToNullableBoolean): Deleted.
(WTR::JSValueMakeStringOrNull): Deleted.
(WTR::createJSString): Deleted.
(WTR::makeValue): Deleted.
(WTR::objectProperty): Deleted.
(WTR::call): Deleted.
(WTR::hasRefTestWaitAttribute): Deleted.

TestRunnerShared/Bindings/JSWrapper.h: Updated includes.

TestRunnerShared/ReftestFunctions.cpp: Added.

(WTR::sendTestRenderedEvent): Added. Creates and dispatches a TestRendered event.
(WTR::hasReftestWaitAttribute): Moved from JSWrappable.h and renamed to use a
lowercase T since that's how web-platform-tests names things.

TestRunnerShared/ReftestFunctions.h: Added. Declares the above functions.

WebKitTestRunner/CMakeLists.txt: Added the new files and directories.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::frameDidChangeLocation): Call sendTestRenderedEvent
before calling dumpAfterWaitAttributeIsRemoved.

WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added a

missing include of "config.h" to fix build failures I was seeing. An alternative,
since this is a Cocoa-only source file, would be to put config.h into a
precompiled prefix header.

WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Ditto.

WebKitTestRunner/PlatformWin.cmake: Temporarily disable precompiled headers

on WinCairo since they were not working properly with JSBasics.cpp.

WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added the new

files and directories.

LayoutTests:

platform/gtk/TestExpectations:
platform/mac/TestExpectations:

Unskip two tests that no longer time out since we are sending this event.

platform/win/TestExpectations:

Add a failure expectation for a test that has a couple non-green pixels.

9:55 PM Changeset in webkit [266987] by Darin Adler

6 edits in trunk/Source/WebCore

Fix root cause of problem with text replacements at the beginnings of sentences so we can remove the workaround
https://bugs.webkit.org/show_bug.cgi?id=216450

Reviewed by Tim Horton.

dom/SimpleRange.cpp:

(WebCore::compareByDocumentOrder): Added so we can use std::min/max.
(WebCore::unionRange): Refactored to use std::min/max.
(WebCore::intersection): Added.

dom/SimpleRange.h: Added intersection.

editing/Editor.cpp:

(WebCore::Editor::markMisspellingsAfterTypingToWord): Intersect with the sentence range,
since we don't have a guarantee that moving to the start of a word and end of a word
stays within the sentence since the word and sentence algorithms are not wholly consistent.
In such cases we would like to restrict our checking to the sentence. Another way to fix
this would be to change the behavior of the word and sentence boundary functions.
(WebCore::Editor::markAndReplaceFor): Remove the boolean "true" flags that we used to
trigger our workaround for the above.

editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingParagraph::automaticReplacementStart const): Removed the boolean
argument and the workaround code that runs when it's true.
(WebCore::TextCheckingParagraph::automaticReplacementLength const): Ditto.

editing/TextCheckingHelper.h: Removed the boolean arguments.

6:31 PM Changeset in webkit [266986] by Simon Fraser

18 edits in trunk/Source/WebCore

Replace formatForDebugger() which uses raw char* with debugDescription()
https://bugs.webkit.org/show_bug.cgi?id=216447

Reviewed by Darin Adler.

formatForDebugger() relied on raw char* and buffer lengths. Replace with debugDescription()
which returns a String, and is already a convention used in various classes.

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper debugDescriptionForTextMarker:]):
(formatForDebugger):

dom/Element.cpp:

(WebCore::Element::formatForDebugger const): Deleted.

dom/Element.h:
dom/Node.cpp:

(WebCore::Node::debugDescription const):
(WebCore::Node::formatForDebugger const): Deleted.

dom/Node.h:
dom/Position.cpp:

(WebCore::Position::debugDescription const):
(WebCore::Position::formatForDebugger const): Deleted.

dom/Position.h:
dom/Range.cpp:

(WebCore::Range::debugDescription const):
(WebCore::Range::formatForDebugger const): Deleted.

dom/Range.h:
dom/Text.cpp:

(WebCore::Text::formatForDebugger const): Deleted.

dom/Text.h:
editing/FrameSelection.cpp:

(WebCore::FrameSelection::debugDescription const):
(WebCore::FrameSelection::formatForDebugger const): Deleted.

editing/FrameSelection.h:
editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::debugDescription const):
(WebCore::VisiblePosition::formatForDebugger const): Deleted.

editing/VisiblePosition.h:
editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::debugDescription const):
(WebCore::VisibleSelection::formatForDebugger const): Deleted.

editing/VisibleSelection.h:

6:30 PM Changeset in webkit [266985] by Simon Fraser

5 edits in trunk/Source/WebCore

Use an OptionSet<> for LayoutBox::BaseTypeFlags
https://bugs.webkit.org/show_bug.cgi?id=216445

Reviewed by Darin Adler.

Use an OptionSet<> for LayoutBox::BaseTypeFlags.

layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::Box):

layout/layouttree/LayoutBox.h:

(WebCore::Layout::Box::isInitialContainingBlock const):
(WebCore::Layout::Box::isContainerBox const):
(WebCore::Layout::Box::isInlineTextBox const):
(WebCore::Layout::Box::isLineBreakBox const):
(WebCore::Layout::Box::isReplacedBox const):

layout/layouttree/LayoutContainerBox.cpp:

(WebCore::Layout::ContainerBox::ContainerBox):

layout/layouttree/LayoutContainerBox.h:

(WebCore::Layout::ContainerBox::ContainerBox):

4:44 PM Changeset in webkit [266984] by Darin Adler

8 edits
2 adds in trunk

REGRESSION (r266817): ASSERTION FAILED: injectedBundle.isTestRunning() on imported/w3c/web-platform-tests/service-workers/service-worker/svg-target-reftest.https.html
https://bugs.webkit.org/show_bug.cgi?id=216440

[GTK] imported/w3c/web-platform-tests/service-workers/service-worker/svg-target-reftest.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=210375

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/resources/svg-target-reftest-frame.html: Added.
web-platform-tests/service-workers/service-worker/resources/svg-target-reftest-001-frame.html: Added.

Somehow these files were missed in the web-platform-tests import, and they are both used by the
svg-target-reftest.https.html test.

web-platform-tests/service-workers/service-worker/svg-target-reftest.https-expected.html:

Updated the path in this expected result file. The test importer script should have done this;
not sure why it did not.

Tools:

Did some hardening of the reftest-wait mechanism in WebKitTestRunner.
We can later do the same in DumpRenderTree if the same problem comes up there,
but at this time I don't have a test that reproduces the issue there so not
changing it for now. Don't want to add speculative code without testing it.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::hasRefTestWaitAttribute): Changed to take a WKBundlePageRef instead of
a InjectedBundlePage&.
(WTR::dumpAfterWaitAttributeIsRemoved): Changed to take a WKBundlePageRef.
Added code to handle cases where an explicit dump occurs while we are waiting
for the attribute to be removed. Identify the page with the WKBundlePageRef,
which can be retained/released.
(WTR::InjectedBundlePage::frameDidChangeLocation): Check page for null
instead of indirectly checking by asking if the pageCount is 0. Also pass
a WKBundlePageRef in to dumpAfterWaitAttributeIsRemoved.

LayoutTests:

TestExpectations: Skip svg-target-reftest.https.html because it fails in

legacy WebKit and the symptom is a hang waiting for the reftest-wait attribute
to be removed. The failure is not new.

platform/gtk/TestExpectations: Removed expectation that this same test will

be flaky. The addition of reftest-wait support and the subresource along with
the bug fix to WebKitTestRunner should leave this passing and non-flaky on GTK.
Feel free to add this back if that proves wrong.

platform/wk2/TestExpectations: Expect a pass for this test. It's working fine

on modern WebKit.

4:11 PM Changeset in webkit [266983] by weinig@apple.com

9 edits in trunk/Source/WebCore

[WebIDL] Remove need for [MayThrowException] on named deleters
https://bugs.webkit.org/show_bug.cgi?id=216429

Reviewed by Darin Adler.

Deduce implementation potentially thowing by introspecting the return
type of the deleters implementation. This allows us to remove another
use of [MayThrowException].

bindings/js/JSDOMAbstractOperations.h:

(WebCore::performLegacyPlatformObjectDeleteOperation):
Add helper function to house shared implementation of the various
combinations of return types allowed.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateDeletePropertyCommon):
Convert the commented expectation that unnamed deleters return bool
or ExceptionOr<bool> into a static assertion and use the new helper
function to simplify code generation.

storage/Storage.idl:

Remove now unneeded [MayThrowException].

bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
bindings/scripts/test/TestNamedDeleterThrowingException.idl:

Update tests/expectations.

4:01 PM Changeset in webkit [266982] by mmaxfield@apple.com

13 edits in trunk

[Apple Win] Add a CTFont member to FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=216432

Reviewed by Darin Adler.

Include *CoreText.cpp files on the Apple Win port.

Source/cmake/OptionsAppleWin.cmake:

Source/WebCore:

This is the second step on the path to replacing the Apple Win port's use of CGFont with CTFont.
This patch adds m_ctFont to FontPlatformData, and makes FontPlatformData's constructors create
this object from their existing arguments. It also enables the USE(CORE_TEXT) flag on the Apple
Win port, but manually disables each of the USE(CORE_TEXT) sites on Windows, so there isn't any
behavior change just yet. The new member, m_ctFont, is therefore still unused in this patch. The
next steps will be replacing our current Apple Win font functions with their USE(CORE_TEXT)
counterparts, one-by-one. (Replacing them one-by-one is better than doing them all at once in a
giant mondo-patch.)

No new tests because there is no behavior change yet.

PlatformAppleWin.cmake:
platform/graphics/Font.cpp:
platform/graphics/FontCascade.cpp:
platform/graphics/FontPlatformData.cpp:
platform/graphics/FontPlatformData.h: The #defines are temporarily getting worse before they'll

be getting better. When this project is done, there will be fewer #defines, and this file will be
cleaner than it was when I started.
(WebCore::FontPlatformData::cgFont const):
(WebCore::FontPlatformData::ctFont const):

platform/graphics/coretext/FontCascadeCoreText.cpp:
platform/graphics/coretext/FontCoreText.cpp:
platform/graphics/coretext/FontPlatformDataCoreText.cpp:
platform/graphics/coretext/GlyphPageCoreText.cpp:
platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hash const):
(WebCore::FontPlatformData::platformIsEqual const):

3:10 PM Changeset in webkit [266981] by mmaxfield@apple.com

1 edit
1 delete in trunk/Source/WebCore

Remove dead code FontCascadeCGWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=216444

Reviewed by Darin Adler.

This file isn't actually referenced by any port's build system.
The Apple Win port uses FontCGWin.cpp instead, which defines the same symbols as this file.

No new tests because there is no behavior change.

platform/graphics/win/FontCascadeCGWin.cpp: Removed.

3:02 PM Changeset in webkit [266980] by Simon Fraser

4 edits in trunk/Source

Convert TextStream::FormattingFlags to an OptionSet<>
https://bugs.webkit.org/show_bug.cgi?id=216443

Reviewed by Darin Adler.
Source/WebCore:

Use an OptionSet<> for FormattingFlags.

rendering/RenderTreeAsText.cpp:

(WebCore::externalRepresentation):
(WebCore::counterValueForElement):

Source/WTF:

Use an OptionSet<> for FormattingFlags.

wtf/text/TextStream.h:

(WTF::TextStream::TextStream):
(WTF::TextStream::formattingFlags const):
(WTF::TextStream::setFormattingFlags):
(WTF::TextStream::hasFormattingFlag const):

12:30 PM Changeset in webkit [266979] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Simplify LineBox offset computation
https://bugs.webkit.org/show_bug.cgi?id=216434

Reviewed by Antti Koivisto.

This is still inline with the half leading logic where the ascent + descent (LineBox height) and the line spacing are
used to position the inline content.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computedLineLogicalRect const):

10:07 AM Changeset in webkit [266978] by Alan Bujtas

6 edits
2 adds in trunk

[LFC][IFC] Add support for non-root-inline-box line spacing
https://bugs.webkit.org/show_bug.cgi?id=216433

Reviewed by Antti Koivisto.

Source/WebCore:

While the LineBox vertically contains all the LineBox::InlineBoxes, its height value does not
include any line spacing (FontMetrics::lineSpacing).
Each LineBox::InlineBox may have a different line spacing value (this value is zero in many cases).
This patch collects line spacing values from the LineBox::InlineBoxes on the line and adjusts the final
line height value accordingly.

Test: fast/layoutformattingcontext/inline-box-with-line-spacing-simple.html

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computedLineLogicalRect const):

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::constructInlineBoxes):

layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::lineSpacing const):
(WebCore::Layout::LineBox::InlineBox::setLineSpacing):
(WebCore::Layout::LineBox::inlineBoxList const):

LayoutTests:

fast/layoutformattingcontext/inline-box-with-line-spacing-simple-expected.html: Added.
fast/layoutformattingcontext/inline-box-with-line-spacing-simple.html: Added.

3:37 AM Changeset in webkit [266977] by mmaxfield@apple.com

4 edits
4 copies
1 add
1 delete in trunk/Source/WebCore

Addressing feedback on r266936
https://bugs.webkit.org/show_bug.cgi?id=216431

Unreviewed.

I didn't follow the reviewer's advice thoroughly.

No new tests because there is no behavior change.

PlatformMac.cmake:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/coretext/FontCascadeCoreText.cpp: Renamed from Source/WebCore/platform/graphics/ct/FontCascadeCoreText.cpp.
platform/graphics/coretext/FontCoreText.cpp: Renamed from Source/WebCore/platform/graphics/ct/FontCoreText.cpp.
platform/graphics/coretext/FontPlatformDataCoreText.cpp: Renamed from Source/WebCore/platform/graphics/ct/FontPlatformDataCoreText.cpp.
platform/graphics/coretext/GlyphPageCoreText.cpp: Renamed from Source/WebCore/platform/graphics/ct/GlyphPageCoreText.cpp.

1:35 AM Changeset in webkit [266976] by commit-queue@webkit.org

23 edits
1 copy
1 add in trunk

Implement lazy iframe loading
https://bugs.webkit.org/show_bug.cgi?id=215442

Patch by Rob Buis <rbuis@igalia.com> on 2020-09-12
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update improved test result.

web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url-2.tentative-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url.tentative-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-load-event.tentative-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-multiple-times.tentative-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-referrerpolicy-change.sub.tentative-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-to-eager.tentative-expected.txt:

Source/WebCore:

Implement lazy iframe loading as specified [1, 2]. Lazy iframe loading
is controlled by the loading attribute on <iframe>. When the loading attribute is
not specified, the behavior is like before this patch, i.e. loading is eager.

This changes the way iframe attribute processing is handled as specified here [2].

This implementation relies on Intersection Observer and hence works on WK2 only.

[1] https://html.spec.whatwg.org/#attr-iframe-loading
[2] https://html.spec.whatwg.org/#process-the-iframe-attributes

Tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url-2.tentative.html

imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url.tentative.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-load-event.tentative.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-multiple-times.tentative.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-referrerpolicy-change.sub.tentative.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-to-eager.tentative.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::openURL):

html/HTMLFrameElementBase.h:

(WebCore::HTMLFrameElementBase::frameURL const):
(WebCore::HTMLFrameElementBase::setFrameURL):

html/HTMLFrameOwnerElement.h:

(WebCore::HTMLFrameOwnerElement::shouldLoadFrameLazily):
(WebCore::HTMLFrameOwnerElement::isLazyLoadObserverActive const):

html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseAttribute):
(WebCore::HTMLIFrameElement::referrerPolicy const):
(WebCore::HTMLIFrameElement::loadingForBindings const):
(WebCore::HTMLIFrameElement::setLoadingForBindings):
(WebCore::isFrameLazyLoadable):
(WebCore::HTMLIFrameElement::shouldLoadFrameLazily):
(WebCore::HTMLIFrameElement::isLazyLoadObserverActive const):
(WebCore::HTMLIFrameElement::loadDeferredFrame):
(WebCore::HTMLIFrameElement::lazyLoadFrameObserver):

html/HTMLIFrameElement.h:
html/HTMLIFrameElement.idl:
html/LazyLoadFrameObserver.cpp: Added.

(WebCore::LazyLoadFrameObserver::LazyLoadFrameObserver):
(WebCore::LazyLoadFrameObserver::observe):
(WebCore::LazyLoadFrameObserver::unobserve):
(WebCore::LazyLoadFrameObserver::intersectionObserver):
(WebCore::LazyLoadFrameObserver::isObserved const):

html/LazyLoadFrameObserver.h: Copied from Source/WebCore/html/canvas/WebGLCompressedTextureETC1.cpp.

(WebCore::LazyLoadFrameObserver::frameURL const):
(WebCore::LazyLoadFrameObserver::referrerPolicy const):

html/canvas/WebGLCompressedTextureETC1.cpp:
html/shadow/DateTimeFieldElement.cpp:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::preventsParentFromBeingComplete const):
(WebCore::FrameLoader::allChildrenAreComplete const):

loader/FrameLoader.h:

LayoutTests:

Unskip iframe-loading-lazy-to-eager.tentative.html and
disable lazy iframe loading tests for WK1.

TestExpectations:
platform/mac-wk1/TestExpectations:

12:09 AM Changeset in webkit [266975] by Carlos Garcia Campos

4 edits in trunk

[GTK] REGRESSION(r266815): Several GTK API tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=216361

Reviewed by Adrian Perez de Castro.

Source/WebInspectorUI:

Add missing trailing ';'.

UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

Tools:

Unskip tests that are now passing.

TestWebKitAPI/glib/TestExpectations.json:

12:07 AM Changeset in webkit [266974] by Carlos Garcia Campos

4 edits in trunk

[GTK] Timeouts after reftest-wait class enablement in r266817
https://bugs.webkit.org/show_bug.cgi?id=216397

Reviewed by Adrian Perez de Castro.

Tools:

Tests are timing out because dumpAfterWaitAttributeIsRemoved() is called recursively from a WebCore timer, not
allowing other sources with lower priority like display refresh monitor one to be run. This patch simply adds a
1 millisecond delay between dumpAfterWaitAttributeIsRemoved tries to allow other sources to be run in the main
loop.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::dumpAfterWaitAttributeIsRemoved):

LayoutTests:

Update expectations for tests that are now passing and failing.

platform/gtk/TestExpectations:

Sep 11, 2020:

10:56 PM Changeset in webkit [266973] by ysuzuki@apple.com

20 edits in trunk

[JSC] Canonicalize "true" unicode extension type value to ""
https://bugs.webkit.org/show_bug.cgi?id=216224

Reviewed by Ross Kirsling.

JSTests:

stress/intl-collator-co-extension.js:

(explicitTrueBeforeICU67): Deleted.

stress/intl-collator.js:

(shouldBe.testCollator.Intl.Collator):
(explicitTrueBeforeICU67): Deleted.

stress/intl-datetimeformat.js:
stress/intl-locale.js:
stress/intl-numberformat.js:
stress/intl-object.js:
stress/intl-pluralrules.js:
stress/intl-relativetimeformat.js:
test262/expectations.yaml:

Source/JavaScriptCore:

Unicode Technical Standard #35 defines that unicode extension type's "true" should be converged to "".
This patch implements it by extracting unicode extension subtags and replacing "true" to "".

runtime/IntlLocale.cpp:

(JSC::LocaleIDBuilder::toCanonical):
(JSC::IntlLocale::keywordValue const):
(JSC::IntlLocale::calendar):
(JSC::IntlLocale::caseFirst):
(JSC::IntlLocale::collation):
(JSC::IntlLocale::hourCycle):
(JSC::IntlLocale::numberingSystem):
(JSC::IntlLocale::numeric):

runtime/IntlLocale.h:
runtime/IntlLocalePrototype.cpp:

(JSC::IntlLocalePrototypeGetterCalendar):
(JSC::IntlLocalePrototypeGetterCaseFirst):
(JSC::IntlLocalePrototypeGetterCollation):
(JSC::IntlLocalePrototypeGetterHourCycle):
(JSC::IntlLocalePrototypeGetterNumberingSystem):

runtime/IntlObject.cpp:

(JSC::unicodeExtensionSubTags):
(JSC::canonicalizeUnicodeExtensionsAfterICULocaleCanonicalization):
(JSC::languageTagForLocaleID):
(JSC::resolveLocale):

runtime/IntlObject.h:
runtime/IntlObjectInlines.h:

(JSC::computeTwoCharacters16Code):

runtime/StringPrototype.cpp:

(JSC::computeTwoCharacters16Code): Deleted.

Source/WTF:

wtf/text/StringView.h:

(WTF::StringView::characterAt const):
(WTF::StringView::operator[] const):

10:54 PM Changeset in webkit [266972] by graouts@webkit.org

3 edits
2 adds in trunk

REGRESSION (r255383): Transition from email to password field on login.live.com stutters after going back and forth
https://bugs.webkit.org/show_bug.cgi?id=216368
<rdar://problem/67019460>

Reviewed by Simon Fraser.

Source/WebCore:

Ensure we repaint before disconnecting from the backing provider layer.

Test: compositing/animation/repaint-after-clearing-shared-backing.html

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):

LayoutTests:

compositing/animation/repaint-after-clearing-shared-backing-expected.html: Added.
compositing/animation/repaint-after-clearing-shared-backing.html: Added.

9:00 PM Changeset in webkit [266971] by sihui_liu@apple.com

3 edits in trunk/Tools

Assertion Failed: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion
https://bugs.webkit.org/show_bug.cgi?id=216376

Reviewed by Tim Horton.

After completing each task, we will end UIScript if there is no remaining task. We need to make sure task is
completed asynchronously, otherwise it may finish before other tasks in the same script are scheduled as
script ends early.

WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:

(WTR::UIScriptControllerCocoa::completeTaskAsynchronouslyAfterActivityStateUpdate):
(WTR::UIScriptControllerCocoa::removeViewFromWindow):
(WTR::UIScriptControllerCocoa::addViewToWindow):

8:49 PM Changeset in webkit [266970] by sihui_liu@apple.com

3 edits in trunk/LayoutTests

[ macOS wk2 Release ] fast/events/page-visibility-iframe-move-test.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=216424

Reviewed by Tim Horton.

Remove event handler after it's called, or it can be invoked at the wrong time and produce unexpected result.

fast/events/page-visibility-iframe-move-test-expected.txt:
fast/events/page-visibility-iframe-move-test.html:

8:28 PM Changeset in webkit [266969] by ysuzuki@apple.com

10 edits
1 add in trunk

[JSC] attribute-change transition should not pin Structure
https://bugs.webkit.org/show_bug.cgi?id=215528

Patch by Yusuke Suzuki <yusukesuzuki@slowstart.org> on 2020-09-11
Reviewed by Saam Barati.

JSTests:

stress/change-attribute-structure-transition.js: Added.

(shouldBe):
(sd.let.data.vm.getStructureTransitionList.let.result.return.result.kind):
(sd):
(shouldBe.JSON.stringify.sd):
(lastStructureID):
(shouldBe.JSON.stringify.Object.getOwnPropertyDescriptor):

Source/JavaScriptCore:

This patch avoids using pin in attribute-change transition. To achieve this, attribute-change transition is now fully supported
transition chain in forEachPropertyConcurrently etc.: we can retrieve properties with changed attributes correctly via traversing
transition chain. And we also support attribute-change transition in materializePropertyTable, so we do not need to pin structure.

The design largely mimics existing removePropertyTransition and addPropertyTransition. This patch also adds hasBeenDictionary()
check before adding structure to the transition so that we can avoid adding unnecessary structure entry to the transition table.

bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compilePutStructure):

jit/Repatch.cpp:

(JSC::tryCacheDeleteBy):

runtime/Structure.cpp:

(JSC::Structure::materializePropertyTable):
(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::addNewPropertyTransition):
(JSC::Structure::removePropertyTransitionFromExistingStructureImpl):
(JSC::Structure::removeNewPropertyTransition):
(JSC::Structure::attributeChangeTransitionToExistingStructure):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::nonPropertyTransitionSlow):
(JSC::Structure::attributeChange):

runtime/Structure.h:
runtime/StructureInlines.h:

(JSC::Structure::forEachPropertyConcurrently):
(JSC::Structure::attributeChange):
(JSC::Structure::attributeChangeWithoutTransition):

tools/JSDollarVM.cpp:

(JSC::JSDollarVMHelper::functionGetStructureTransitionList):

6:46 PM Changeset in webkit [266968] by Karl Rackler

2 edits in trunk/LayoutTests

REGRESSION: [ BigSur wk2 ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure
rdar://68743466

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

6:40 PM Changeset in webkit [266967] by Hector Lopez

2 edits in trunk/LayoutTests

Rebaseline after r266885
https://bugs.webkit.org/show_bug.cgi?id=216302

Unreviewed test gardening.

inspector/timeline/setInstruments-errors-expected.txt:

5:52 PM Changeset in webkit [266966] by Alan Coon

6 edits in branches/safari-610.2.5.1-branch

Cherry-pick r266901. rdar://problem/68740506

[Repaint] RenderLayerModelObject::styleWillChange may issue redundant repaint
https://bugs.webkit.org/show_bug.cgi?id=216374
<rdar://problem/68657490>

Reviewed by Simon Fraser.

Source/WebCore:

Move the repaintIncludingDescendants() calls to repaintBeforeStyleChange() to avoid redundant repaints on the same renderer.

rendering/RenderElement.cpp: (WebCore::RenderElement::repaintBeforeStyleChange):
rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::styleWillChange):

LayoutTests:

css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt:
platform/ios/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [266965] by Alan Coon

26 edits
1 copy
3 adds in branches/safari-610.2.5.1-branch

Cherry-pick r266846. rdar://problem/68740516

Don't create event regions when the page has no subscrollers
https://bugs.webkit.org/show_bug.cgi?id=216355
<rdar://problem/67900642>

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/scrolling/mac/event-region-subscroller-frame.html

fast/scrolling/mac/event-region-subscroller-overflow.html

Unless the page uses features like touch-action we don't need event regions for plain main frame scrolling.

page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::hasSubscrollers const):
page/scrolling/AsyncScrollingCoordinator.h:
page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::hasSubscrollers const):
page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): (WebCore::ScrollingStateScrollingNode::~ScrollingStateScrollingNode):
page/scrolling/ScrollingStateTree.h: (WebCore::ScrollingStateTree::scrollingNodeCount const): (WebCore::ScrollingStateTree::scrollingNodeAdded): (WebCore::ScrollingStateTree::scrollingNodeRemoved):

Count scrolling nodes in the state tree. It is updated during updateCompositingLayers, before event region generation.

rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const):

Don't maintain event region if there are no subscrollers and none of the other reasons were hit.

rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers):

Invalidate event regions if a subscroller appears.

(WebCore::RenderLayerCompositor::invalidateEventRegionForAllFrames):

rendering/RenderLayerCompositor.h:

LayoutTests:

Add overflow scrollers to some existing tests so they still generate event regions.

fast/scrolling/ios/border-radius-event-region-expected.txt:
fast/scrolling/ios/border-radius-event-region.html:
fast/scrolling/ios/event-region-float-expected.txt:
fast/scrolling/ios/event-region-float.html:
fast/scrolling/ios/event-region-pointer-events-expected.txt:
fast/scrolling/ios/event-region-pointer-events.html:
fast/scrolling/ios/event-region-scale-transform-shared-expected.txt:
fast/scrolling/ios/event-region-scale-transform-shared.html:
fast/scrolling/ios/event-region-translate-transform-shared-expected.txt:
fast/scrolling/ios/event-region-translate-transform-shared.html:
fast/scrolling/ios/event-region-visibility-hidden-expected.txt:
fast/scrolling/ios/event-region-visibility-hidden.html:
fast/scrolling/mac/border-radius-event-region-expected.txt:
fast/scrolling/mac/border-radius-event-region.html:
fast/scrolling/mac/event-region-subscroller-frame-expected.txt: Added.
fast/scrolling/mac/event-region-subscroller-frame.html: Added.
fast/scrolling/mac/event-region-subscroller-overflow-expected.txt: Added.
fast/scrolling/mac/event-region-subscroller-overflow.html: Copied from LayoutTests/fast/scrolling/ios/event-region-visibility-hidden.html.
fast/scrolling/mac/event-region-visibility-hidden-expected.txt:
fast/scrolling/mac/event-region-visibility-hidden.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [266964] by Alan Coon

24 edits in branches/safari-610.2.5.1-branch

Cherry-pick r266818. rdar://problem/68740533

[Repaint] RenderElement::setStyle may issue redundant repaint
https://bugs.webkit.org/show_bug.cgi?id=216324
<rdar://problem/68595896>

Reviewed by Simon Fraser.

Source/WebCore:

If we issue a repaint in ::styleWillChange, we should not need to re-issue it again in RenderElement::setStyle (see r266803 for details).

rendering/RenderElement.cpp: (WebCore::RenderElement::repaintBeforeStyleChange): (WebCore::RenderElement::setStyle):
rendering/RenderElement.h:

LayoutTests:

compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:
compositing/shared-backing/overflow-scroll/shared-layer-repaint-expected.txt:
fast/css-custom-paint/delay-repaint-expected.txt:
fast/images/async-image-multiple-clients-repaint-expected.txt:
fast/repaint/horizontal-bt-overflow-child-expected.txt:
fast/repaint/horizontal-bt-overflow-parent-expected.txt:
fast/repaint/horizontal-bt-overflow-same-expected.txt:
fast/repaint/mutate-non-visible-expected.txt:
fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt:
fast/repaint/overflow-flipped-writing-mode-table-expected.txt:
fast/repaint/spanner-with-margin-expected.txt:
fast/repaint/table-row-repaint-expected.txt:
fast/repaint/vertical-overflow-child-expected.txt:
fast/repaint/vertical-overflow-parent-expected.txt:
fast/repaint/vertical-overflow-same-expected.txt:
svg/transforms/svg-transform-foreign-object-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [266963] by Alan Coon

10 edits in branches/safari-610.2.5.1-branch/Source

Cherry-pick r266677. rdar://problem/68740526

[MotionMark] RenderLayer::paintLayerContents spends ~5% of the time in MonotonicTime::now() in Multiply
https://bugs.webkit.org/show_bug.cgi?id=216190

Reviewed by Darin Adler.

Source/WebCore:

In several of MotionMark's subtests (for instance, Multiply), we spent a large amount of time underneath
RenderLayer::paintLayerContents due to both the large number of layers and the need to frequently repaint
each layer (all of which are constantly being animated). Underneath this method, a nontrivial amount of time
(~5%) is then spent grabbing the system time via MonotonicTime::now().

We can avoid this extra work by instead using the timestamp of the last rendering update (before we started
painting), which we keep track of using a new member variable on Page. See below for more details, as well as
the WebKit2 ChangeLog.

page/ChromeClient.h: (WebCore::ChromeClient::timestampForPaintFrequencyTracking const):

Add a client hook to fetch the timestamp to use when tracking painting frequency. See the WebKit2 ChangeLog for
more details.

page/Page.cpp: (WebCore::Page::updateRendering):

Update m_lastRenderingUpdateTimestamp.

page/Page.h: (WebCore::Page::lastRenderingUpdateTimestamp const):
rendering/PaintFrequencyTracker.h:

Drive-by cleanup: narrow the PaintFrequency enum to bool width.

(WebCore::PaintFrequencyTracker::begin):
(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):

rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayerContents):

Call out to the client layer to return a timestamp for tracking painting frequency. By default, this is simply
the current time (MonotonicTime::now()), but ports (namely, WebKit2) may opt for a coarser granularity.

(WebCore::RenderLayer::simulateFrequentPaint):

rendering/RenderLayer.h:

Source/WebKit:

WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::timestampForPaintFrequencyTracking const):

In WebKit2, we can assume (with the exception of SVG pages) that we must've performed a rendering update prior
to tracking painting frequencies. As such, we can use the page's rendering update timestamp instead of the real
current time (MonotonicTime::now()).

Note that in WebKit1, it is possible for any client to force a synchronous paint of the page before the page has
performed a rendering update, which triggers assertions in SinglePaintFrequencyTracking::end(). As such, we
stick with MonotonicTime::now() in WebKit1.

WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [266962] by Alan Coon

8 edits
4 adds in branches/safari-610.2.5.1-branch

Cherry-pick r266443. rdar://problem/68740539

REGRESSION(r262366): MotionMark1.1 | macOS | Some devices | 1-3% overall regression
https://bugs.webkit.org/show_bug.cgi?id=215989
<rdar://problem/66845937>

Reviewed by Darin Adler.

Source/WebCore:

The new approach to compositing WebGL caused a slowdown in some
canvas performance tests. They were notifying the Document
of all drawing commands, even on 2d canvases that didn't need
to prepare before compositing.

The solution is to only add the Document as an observer
when necessary. This recovers the performance hit - measured
using the Canvas Lines MotionMark test.

Tests: fast/canvas/webgl/move-canvas-in-document-while-clean.html

fast/canvas/webgl/move-canvas-in-document.html

dom/Document.cpp: (WebCore::Document::prepareCanvasesForDisplayIfNeeded): Leave a FIXME indicating that we should try to avoid the copyToVector if we can ensure that the prepareForDisplay call will not mutate the HashSet.

html/CanvasBase.cpp: Remove some copyToVector calls. It should be fine to iterate over the HashSet for these notification functions. (WebCore::CanvasBase::notifyObserversCanvasChanged): (WebCore::CanvasBase::notifyObserversCanvasResized):

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): Don't add the Document as a canvas observer. Wait until we know it is a context that needs observing. (WebCore::HTMLCanvasElement::createContextWebGL): Now we can add it as an observer. (WebCore::HTMLCanvasElement::didMoveToNewDocument): Swap observation to the new Document. (WebCore::HTMLCanvasElement::insertedIntoAncestor): Ditto, but also be aware that we might be in a "dirty" state, and thus need to immediately tell the new document that the canvas needs preparation. (WebCore::HTMLCanvasElement::removedFromAncestor): Remove the observer. (WebCore::HTMLCanvasElement::needsPreparationForDisplay): Use a virtual function on the context instead of checking the type. (WebCore::HTMLCanvasElement::prepareForDisplay): Ditto.

html/canvas/CanvasRenderingContext.h: New virtual functions to avoid type checking in HTMLCanvasElement. (WebCore::CanvasRenderingContext::compositingResultsNeedUpdating const): (WebCore::CanvasRenderingContext::needsPreparationForDisplay const): (WebCore::CanvasRenderingContext::prepareForDisplay):

html/canvas/WebGLRenderingContextBase.cpp: Implementations of the virtual functions that tell HTMLCanvasElement that it needs to prepareForDisplay. (WebCore::WebGLRenderingContextBase::markContextChanged): (WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver): (WebCore::WebGLRenderingContextBase::didComposite):
html/canvas/WebGLRenderingContextBase.h:

LayoutTests:

fast/canvas/webgl/move-canvas-in-document-expected.html: Added.
fast/canvas/webgl/move-canvas-in-document-while-clean-expected.html: Added.
fast/canvas/webgl/move-canvas-in-document-while-clean.html: Added.
fast/canvas/webgl/move-canvas-in-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:50 PM Changeset in webkit [266961] by Karl Rackler

2 edits in trunk/LayoutTests

REGRESSION: [ BigSur wk2 ] http/tests/media/video-no-content-length-stall.html is a constant failure
rdar://68740987

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

5:20 PM Changeset in webkit [266960] by commit-queue@webkit.org

2 edits in trunk/Tools

Adding myself as committer
https://bugs.webkit.org/show_bug.cgi?id=216419

Patch by Frank Yang <guowei_yang@apple.com> on 2020-09-11
Reviewed by Myles C. Maxfield.

Adding myself as a committer.

Scripts/webkitpy/common/config/contributors.json:

adding committer status to my name.

5:18 PM Changeset in webkit [266959] by Alan Coon

1 edit in branches/safari-610.2.5.1-branch/Source/WebKit/UIProcess/mac/DisplayLink.cpp

Cherry-pick a build fix for r266771.

Unreviewed build fix for r266771. An include is missing which causes the build to fail flakily depending on the position of the cpp in the unified source file.

UIProcess/mac/DisplayLink.cpp:

4:54 PM Changeset in webkit [266958] by Ben Nham

1 edit in trunk/Source/WebKit/UIProcess/mac/DisplayLink.cpp

Unreviewed build fix for r266771. An include is missing which causes the build to fail flakily depending on the position of the cpp in the unified source file.

UIProcess/mac/DisplayLink.cpp:

4:46 PM Changeset in webkit [266957] by Russell Epstein

9 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266771. rdar://problem/68666453

Regression(r260614) Power usage has increased due to extra thread hopping
https://bugs.webkit.org/show_bug.cgi?id=216296
<rdar://problem/67719299>

Reviewed by Simon Fraser.

Power usage has increased after r260614 due to extra thread hopping. To recover,
we now process the DisplayWasRefreshed IPC to a background queue if there is
scrolling going on and responsiveness is thus critical. In the common case, where
the user is not scrolling, we keep processing the IPC on the main thread, like
before r260614. This avoids extra thread hopping and saves power.

UIProcess/WebPageProxy.cpp: (WebKit::ScrollingObserver::willSendWheelEvent): (WebKit::ScrollingObserver::ScrollingObserver): (WebKit::ScrollingObserver::singleton): (WebKit::WebPageProxy::sendWheelEvent):
UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::displayLinkCallback):
UIProcess/mac/DisplayLink.h: (WebKit::DisplayLink::setShouldSendIPCOnBackgroundQueue):
WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::notifyScrollingTreesDisplayWasRefreshed): (WebKit::EventDispatcher::displayWasRefreshed):
WebProcess/WebPage/EventDispatcher.h:
WebProcess/WebProcess.cpp: (WebKit::WebProcess::displayWasRefreshed):
WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:25 PM Changeset in webkit [266956] by aakash_jain@apple.com

3 edits in trunk/Tools

Disable gtk-api queue temporarily
https://bugs.webkit.org/show_bug.cgi?id=216411

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-build/config.json:
BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

4:19 PM Changeset in webkit [266955] by Karl Rackler

2 edits in trunk/LayoutTests

REGRESSION: [ BigSur < 20A2374 ] fast/images/animated-gif-loop-count.html is a constant image failure
rdar://68736735

Unreviewed test gardening.

platform/mac/TestExpectations:

3:43 PM Changeset in webkit [266954] by ysuzuki@apple.com

6 edits
2 adds in trunk

Serialization should have exception checks
https://bugs.webkit.org/show_bug.cgi?id=216399
<rdar://problem/68633776>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: js/dom/serialization-should-have-exception-check.html

IDL CodeGenerator missed appropriate exception checks in serialization code. This patch adds it.
In serialization we cannot throw an error currently. So we should ensure it with assertNoException().

bindings/scripts/CodeGeneratorJS.pm:

(GenerateSerializerDefinition):

bindings/scripts/test/JS/JSTestSerialization.cpp:

(WebCore::JSTestSerialization::serialize):

bindings/scripts/test/JS/JSTestSerializationInherit.cpp:

(WebCore::JSTestSerializationInherit::serialize):

bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:

(WebCore::JSTestSerializationInheritFinal::serialize):

LayoutTests:

js/dom/serialization-should-have-exception-check-expected.txt: Added.
js/dom/serialization-should-have-exception-check.html: Added.

3:24 PM Changeset in webkit [266953] by James Darpinian

7 edits
3 adds in trunk

[WebGL2] Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.webkit.org/show_bug.cgi?id=216010

Reviewed by Kenneth Russell.

Source/ThirdParty/ANGLE:

src/libANGLE/formatutils.cpp:

(gl::SizedHalfFloatRGTextureAttachmentSupport):
(gl::SizedHalfFloatRGBTextureAttachmentSupport):
(gl::SizedHalfFloatRGBRenderbufferSupport):
(gl::SizedHalfFloatRGBATextureAttachmentSupport):

Source/WebCore:

Added test webgl/2.0.0/conformance2/extensions/ext-color-buffer-half-float.html

html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
(WebCore::WebGL2RenderingContext::renderbufferStorageImpl):

LayoutTests:

webgl/2.0.0/conformance2/extensions/ext-color-buffer-half-float-expected.txt: Added.
webgl/2.0.0/conformance2/extensions/ext-color-buffer-half-float.html: Added.
webgl/2.0.0/conformance2/extensions/promoted-extensions-expected.txt:
webgl/2.0.0/resources/webgl_test_files/conformance2/extensions/ext-color-buffer-half-float.html: Added.
webgl/2.0.0/resources/webgl_test_files/conformance2/extensions/promoted-extensions.html:

3:05 PM Changeset in webkit [266952] by Russell Epstein

20 edits
3 adds in branches/safari-610-branch

Cherry-pick r266743. rdar://problem/68652752

iOS: <attachment>'s QuickLook thumbnails can appear squished
https://bugs.webkit.org/show_bug.cgi?id=216209
<rdar://problem/67817706>

Reviewed by Wenson Hsieh.

Source/WebCore:

Test: fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html

html/HTMLAttachmentElement.idl:
testing/Internals.cpp: (WebCore::Internals::attachmentThumbnailInfo):
testing/Internals.h:
testing/Internals.idl: Expose the attachment thumbnail size via Internals.

rendering/RenderThemeIOS.mm: (WebCore::RenderAttachmentInfo::RenderAttachmentInfo): Allow the thumbnail aspect ratio to vary, instead of assuming it is always square.

Source/WebKit:

UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::convertPlatformImageToBitmap): Propagate an image of the same aspect ratio that QuickLook provided, instead of squishing it to square.

UIProcess/QuickLookThumbnailLoader.mm: (-[WKQLThumbnailLoadOperation start]): Only request full thumbnails; we do not want the icon form, since <attachment> already has one without QuickLook's help; if we can't get a full thumbnail, we'll just leave it alone.

Tools:

TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
TestRunnerShared/UIScriptContext/UIScriptController.h: (WTR::UIScriptController::insertAttachmentForFilePath):
WebKitTestRunner/TestController.cpp: (WTR::TestController::currentTestURL const):
WebKitTestRunner/TestController.h:
WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: (WTR::UIScriptControllerCocoa::insertAttachmentForFilePath): Make it possible to insert an attachment wrapping a file on disk via UIScriptController.

LayoutTests:

fast/attachment/attachment-thumbnail-preserves-aspect-ratio-expected.txt: Added.
fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html: Added.
fast/attachment/resources/400x200-circle.png: Added.
platform/ios/fast/attachment/attachment-thumbnail-preserves-aspect-ratio-expected.txt: Added.
resources/ui-helper.js: (window.UIHelper.insertAttachmentForFilePath): Add a test that dumps the thumbnail size for a 400x200 attachment. We only run it on iOS, because on macOS, QuickLook always returns an image of the size we ask for (400x400), padded with whitespace, so the problem does not reproduce and the test doesn't work right there. On iOS, the result used to be 400x400 and now is 400x200.

I tried and failed to make a more useful test (a ref test, actually
testing the presentation) because it's quite hard to match the
native <attachment> painting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:01 PM Changeset in webkit [266951] by achristensen@apple.com

16 edits in trunk

Move _setCookieAcceptPolicy to WKHTTPCookieStore
https://bugs.webkit.org/show_bug.cgi?id=216375

Reviewed by Geoffrey Garen.

Source/WebCore:

platform/network/cocoa/HTTPCookieAcceptPolicyCocoa.h:

Source/WebKit:

It is only used by Safari, which I am changing along with this in rdar://problem/68659937
I need it to not be on the process pool for https://bugs.webkit.org/show_bug.cgi?id=216041
and because the cookie store's job is to manage cookie storage. The fact that it was on the process pool
is just a historical artifact of us trying to make it global.

WKContextUseTestingNetworkSession has had its important parts replaced by WKWebsiteDataStoreConfigurationSetTestingSessionEnabled
but it was still being used to determinte whether the UI process should persist the cookie accept policy. We don't need this
any more because we send a message to the network process and let it manage the cookie accept policy.

UIProcess/API/C/WKContext.cpp:

(WKContextUseTestingNetworkSession): Deleted.

UIProcess/API/C/WKContextPrivate.h:
UIProcess/API/Cocoa/WKHTTPCookieStore.mm:

(-[WKHTTPCookieStore _setCookieAcceptPolicy:completionHandler:]):

UIProcess/API/Cocoa/WKHTTPCookieStorePrivate.h:
UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _setCookieAcceptPolicy:]):

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::useTestingNetworkSession): Deleted.

UIProcess/WebProcessPool.h:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/CookieAcceptPolicy.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
WebKitTestRunner/TestController.cpp:

(WTR::TestController::generatePageConfiguration):

2:56 PM Changeset in webkit [266950] by Alan Coon

6 edits in branches/safari-610.2.5.1-branch/Source

Cherry-pick r266932. rdar://problem/68732136

Fix undeclared identifier issue due to clashes in soft link headers
https://bugs.webkit.org/show_bug.cgi?id=216412

Reviewed by Geoffrey Garen.

Source/WebCore/PAL:

r266898 broke builds on certain SDKs. The reason for this is that it includes
MediaToolbox/FigPhoto.h, which transitively includes CoreMedia/CMTimePrivate.h. The latter
header has a bunch of inline code in certain SDKs which conflicts with the
CoreMediaSoftLink.h header. For instance, CoreMediaSoftLink.h redefines CMTimeCompare to
softLink_CoreMedia_CMTimeCompare, which messes up the inline code in the CMTimePrivate.h
header that references CMTimeCompare.

For now, we just avoid including FigPhoto.h altogether and use a constant. We'll clean this
up once we start weak linking rather than soft linking CoreMedia and MediaToolbox (216388).

pal/cocoa/MediaToolboxSoftLink.cpp:
pal/cocoa/MediaToolboxSoftLink.h:
pal/spi/cocoa/MediaToolboxSPI.h:

Source/WebKit:

Use the workaround constant kPALFigPhotoContainerFormat_JFIF instead of the enum value
kFigPhotoContainerFormat_JFIF.

WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266949] by Alan Coon

10 edits
1 copy in branches/safari-610.2.5.1-branch/Source

Cherry-pick r266898. rdar://problem/68732160

Disable hardware JPEG decoding on x86 Mac
https://bugs.webkit.org/show_bug.cgi?id=216377

Reviewed by Geoff Garen.

Source/WebCore/PAL:

Add wrappers for a new MediaToolbox SPI that allows us to disable HW JPEG decoding.

PAL.xcodeproj/project.pbxproj:
pal/PlatformMac.cmake:
pal/cocoa/MediaToolboxSoftLink.cpp:
pal/cocoa/MediaToolboxSoftLink.h:

Source/WebKit:

In Big Sur, ImageIO uses hardware JPEG decoding automatically for certain JPEGs. This caused
a small regression in our battery life benchmark since the one-time setup cost for the
decoder (~20-30 ms per process) was higher than the per-decode win we got from the HW decoder.

For now, we're reverting to the Catalina behavior of not using hardware JPEG on x86 Macs by
calling a MediaToolbox SPI. (The tradeoffs for Apple Silicon are different so we use
ImageIO's default heuristics on that architecture.) We plan to revisit this decision once we
move to a GPUProcess world.

WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

Add macros to disable HW JPEG decoding on x86 Macs and indicate the presence of a new MediaToolbox SPI.
(The latter is to prevent unnecessary dlopen/dlsym calls since we soft-link MediaToolbox.)

wtf/PlatformEnableCocoa.h:
wtf/PlatformHave.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266948] by Alan Coon

7 edits in branches/safari-610.2.5.1-branch/Source

Cherry-pick r266844. rdar://problem/68732100

[Cocoa] PERF: Don't instantiate AVPlayer-based audio decoders or renderers if an element is initially muted.
https://bugs.webkit.org/show_bug.cgi?id=216299

Reviewed by Eric Carlson.

Source/WebCore:

When an AVPlayer is created, even if muted, it will still instantiate an audio decoder and renderer if the
AVAsset in the current player item has an audio track. Ostensibly, this is so that an unmute operation is
instantaneous, as it's merely applying a zero gain to the decoded audio. However for web content, there's
many autoplaying, muted <video> elements which may never be un-muted before being destroyed.

Implement a policy where, if an AVPlayer is initially muted, we adopt AVFoundation SPI to forcibly prevent
audio decoding and rendering until the first time the AVPlayer is unmuted. This means the first un-mute may
not be instantaneous, as an audio decoder will have to be created and fed before any audio is rendered.

There's some incorrect caching of mute state at the MediaPlayer level; so MediaPlayer and MPPAVFoundationObjC
can get their respective m_muted states out of sync. Make sure that HTMLMediaElement always sets muted state
after creating a MediaPlayer and that, respectively, MPPAVFoundationObjC always queries it's parent MediaPlayer's
mute state when it in turn is created.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createMediaPlayer):
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::setMuted):

Source/WebCore/PAL:

pal/spi/cocoa/AVFoundationSPI.h:

Source/WTF:

wtf/PlatformHave.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266947] by Alan Coon

27 edits in branches/safari-610.2.5.1-branch

Cherry-pick r266803. rdar://problem/68732086

[Repaint] styleWillChange may call repaint on the same renderer multiple times.
https://bugs.webkit.org/show_bug.cgi?id=216295
<rdar://problem/68538666>

Reviewed by Simon Fraser.

Source/WebCore:

RenderElement::styleWillChange is a virtual function. This function is called whenever the associated RenderStyle changes.
The subclass implementation (e.g. RenderBox::styleWillChange) calls the parent class to make sure the style change is covered properly.
Now in certain cases,

this may trigger multiple calls to repaint() (e.g one in each ::styleWillChange implementation)
paint invalidation requires absolute coordinates
geometry does not change during styleWillChange it could end up being redundant/unnecessarily expensive.

This patch moves all the style-will-change-requires-repaint logic to one single function so that we can limit the number of repaints.

rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange):
rendering/RenderElement.cpp: (WebCore::RenderElement::issueRepaintBeforeStyleChange): (WebCore::RenderElement::initializeStyle): (WebCore::RenderElement::setStyle): (WebCore::RenderElement::styleWillChange):
rendering/RenderElement.h:
rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::styleWillChange):

LayoutTests:

compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:
compositing/shared-backing/overflow-scroll/shared-layer-repaint-expected.txt:
fast/css-custom-paint/delay-repaint-expected.txt:
fast/images/async-image-multiple-clients-repaint-expected.txt:
fast/repaint/focus-ring-repaint-expected.txt:
fast/repaint/horizontal-bt-overflow-child-expected.txt:
fast/repaint/horizontal-bt-overflow-parent-expected.txt:
fast/repaint/horizontal-bt-overflow-same-expected.txt:
fast/repaint/mutate-non-visible-expected.txt:
fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt:
fast/repaint/overflow-flipped-writing-mode-table-expected.txt:
fast/repaint/table-row-repaint-expected.txt:
fast/repaint/vertical-overflow-child-expected.txt:
fast/repaint/vertical-overflow-parent-expected.txt:
fast/repaint/vertical-overflow-same-expected.txt:
svg/transforms/svg-transform-foreign-object-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266946] by Alan Coon

5 edits in branches/safari-610.2.5.1-branch/Source

Cherry-pick r266797. rdar://problem/68732167

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=216195

Reviewed by Simon Fraser.

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.

After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.

Source/WebCore:

platform/graphics/DisplayRefreshMonitor.cpp: (WebCore::DisplayRefreshMonitor::displayDidRefresh):
platform/graphics/DisplayRefreshMonitor.h: (WebCore::DisplayRefreshMonitor::shouldBeTerminated const):

Source/WebKit:

UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::addObserver): (WebKit::DisplayLink::removeObserver): (WebKit::DisplayLink::removeObservers): (WebKit::DisplayLink::displayLinkCallback): (WebKit::DisplayLink::hasObservers const): Deleted.
UIProcess/mac/DisplayLink.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266945] by Alan Coon

9 edits in branches/safari-610.2.5.1-branch/Source/WebKit

Cherry-pick r266771. rdar://problem/68732073

Regression(r260614) Power usage has increased due to extra thread hopping
https://bugs.webkit.org/show_bug.cgi?id=216296
<rdar://problem/67719299>

Reviewed by Simon Fraser.

Power usage has increased after r260614 due to extra thread hopping. To recover,
we now process the DisplayWasRefreshed IPC to a background queue if there is
scrolling going on and responsiveness is thus critical. In the common case, where
the user is not scrolling, we keep processing the IPC on the main thread, like
before r260614. This avoids extra thread hopping and saves power.

UIProcess/WebPageProxy.cpp: (WebKit::ScrollingObserver::willSendWheelEvent): (WebKit::ScrollingObserver::ScrollingObserver): (WebKit::ScrollingObserver::singleton): (WebKit::WebPageProxy::sendWheelEvent):
UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::displayLinkCallback):
UIProcess/mac/DisplayLink.h: (WebKit::DisplayLink::setShouldSendIPCOnBackgroundQueue):
WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::notifyScrollingTreesDisplayWasRefreshed): (WebKit::EventDispatcher::displayWasRefreshed):
WebProcess/WebPage/EventDispatcher.h:
WebProcess/WebProcess.cpp: (WebKit::WebProcess::displayWasRefreshed):
WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266944] by Alan Coon

6 edits in branches/safari-610.2.5.1-branch/Source/WebCore

Cherry-pick r266717. rdar://problem/68732093

Comparing styles with large but identical custom property maps is slow
https://bugs.webkit.org/show_bug.cgi?id=216241
<rdar://problem/67946605>

Reviewed by Darin Adler.

In a full style rebuild we lose sharing of equal StyleCustomPropertyDatas between the old and the new style.
Custom properties are usually defined in document element and this lack of sharing inherits to all elements.
Without sharing equality comparisons end up requiring deep comparisons, which can be slow if there are thousands of properties.

Fix by deduplicating identical property maps between the old the new style. All the descendants that inherit the properties will
now be cheap to compare.

The patch also contains some other basic custom property optimizations.

Going to full screen and back on youtube, this patch reduces time in the longest style update from ~460ms to ~90ms.

css/CSSCustomPropertyValue.cpp: (WebCore::CSSCustomPropertyValue::equals const):

Check for pointer equality first.

rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::deduplicateInheritedCustomProperties):

Deduplicate if the properties are equal but not shared.

(WebCore::RenderStyle::setInheritedCustomPropertyValue):
(WebCore::RenderStyle::setNonInheritedCustomPropertyValue):

Check if the value is already in the map before triggering copy-on-write.

rendering/style/RenderStyle.h: (WebCore::RenderStyle::setInheritedCustomPropertyValue): Deleted. (WebCore::RenderStyle::setNonInheritedCustomPropertyValue): Deleted.
style/StyleBuilder.cpp: (WebCore::Style::Builder::applyCustomProperty):

Don't create unnecesary copies of CSSCustomPropertyValue.

style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Try to deduplicate before comparing the styles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266943] by Alan Coon

6 edits in branches/safari-610.2.5.1-branch/Source

Cherry-pick r266710. rdar://problem/68732167

Unreviewed, reverting r266645.
https://bugs.webkit.org/show_bug.cgi?id=216251

Caused MotionMark regression

Reverted changeset:

"Move lazy DisplayLink tear down logic from the WebProcess to
the UIProcess"
https://bugs.webkit.org/show_bug.cgi?id=216195
https://trac.webkit.org/changeset/266645

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266942] by Alan Coon

6 edits in branches/safari-610.2.5.1-branch/Source

Cherry-pick r266645. rdar://problem/68732073

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=216195

Reviewed by Simon Fraser.

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.

After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.

Source/WebCore:

platform/graphics/DisplayRefreshMonitor.cpp: (WebCore::DisplayRefreshMonitor::displayDidRefresh):
platform/graphics/DisplayRefreshMonitor.h: (WebCore::DisplayRefreshMonitor::shouldBeTerminated const):

Source/WebKit:

UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::addObserver): (WebKit::DisplayLink::removeObserver): (WebKit::DisplayLink::removeObservers): (WebKit::DisplayLink::displayLinkCallback): (WebKit::DisplayLink::hasObservers const): Deleted.
UIProcess/mac/DisplayLink.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266941] by Alan Coon

8 edits
2 adds in branches/safari-610.2.5.1-branch

Cherry-pick r266403. rdar://problem/68732151

EventRegion paint should respect layer's foreground and background painting phases
https://bugs.webkit.org/show_bug.cgi?id=216031
<rdar://problem/67282372>

Reviewed by Simon Fraser.

Source/WebCore:

We are currently painting event region for the box background to the foreground layer, which can cause
foreground layer to wrongly catch scroll events. Similarly we are unnecessarily painting foreground for
layers that don't need it.

Test: fast/scrolling/mac/negative-z-index-overflow-scroll.html

rendering/PaintPhase.h:

Add two new event region specific PaintBehaviors for foreground and background paint. This essentially duplicates
foreground/background PaintPhases but since event region paint is itself a paint phase we can't use those.
This should be reconciled at some point.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents):

Add the background flag when painting contents as the descendant backgrounds are part of the layer foreground.

(WebCore::RenderBlock::paintObject):

Respect the new flags.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayerContents):

Setup the flags based on what we are supposed to be painting on this layer.

(WebCore::RenderLayer::collectEventRegionForFragments):

Flag filtering moves to paintLayerContents.

LayoutTests:

editing/editable-region/text-field-inside-composited-negative-z-index-layer-expected.txt:
fast/scrolling/mac/negative-z-index-overflow-scroll-expected.txt: Added.
fast/scrolling/mac/negative-z-index-overflow-scroll.html: Added.
pointerevents/ios/touch-action-none-relative-inside-composited-negative-z-index-layer-expected.txt:
pointerevents/ios/touch-action-region-backing-sharing-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266940] by Alan Coon

4 edits in branches/safari-610.2.5.1-branch

Cherry-pick r266232. rdar://problem/68732143

Step animations invalidate style on every rendering update whether or not they need to
https://bugs.webkit.org/show_bug.cgi?id=215229
<rdar://problem/66636153>

Reviewed by Antoine Quint.

Source/WebCore:

Step timing functions with transforms try and fail to start accelerated which causes them to repeatedly schedule unnecessary rendering updates.

animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::updateAcceleratedActions):

Step timing functions are never accelerated so don't bother trying to start them in accelerated state.
This is similar to treatmeant of unaccelerated properties.

LayoutTests:

animations/steps-transform-rendering-updates-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:47 PM Changeset in webkit [266939] by Russell Epstein

20 edits
3 deletes in branches/safari-610-branch

Revert r266881. rdar://problem/68652752

2:44 PM Changeset in webkit [266938] by Alan Coon

8 edits in branches/safari-610.2.5.1-branch/Source

Versioning.

WebKit-7610.2.5.1.1

2:14 PM Changeset in webkit [266937] by zhifei_fang@apple.com

2 edits in trunk/Tools

Strip Quotes for run-jsc-stress-tests --model arg
https://bugs.webkit.org/show_bug.cgi?id=216417

Reviewed by Jonathan Bedard.

Scripts/run-jsc-stress-tests:

1:27 PM Changeset in webkit [266936] by mmaxfield@apple.com

17 edits
2 copies
2 moves
3 adds in trunk/Source

[Cocoa] Migrate CoreText-specific code from *Cocoa.mm to *CoreText.cpp
https://bugs.webkit.org/show_bug.cgi?id=216400

Reviewed by Tim Horton.

Source/WebCore:

This is in preparation for sharing the CoreText code with the Apple Windows port.

This patch doesn't actually cause Windows to use this code yet. That will happen
in a series of subsequent patches. This patch is just the first stage.

There isn't any actual behavior change here - it's just moving code around between
files.

This patch also adds a new USE() flag: USE(CORE_TEXT). It migrates CoreText-specific
code from #if PLATFORM(COCOA) to #if USE(CORE_TEXT).

No new tests because there is no behavior change.

PlatformMac.cmake:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/Font.cpp:
platform/graphics/Font.h:
platform/graphics/FontCascade.cpp:
platform/graphics/FontCascade.h:
platform/graphics/FontPlatformData.cpp:
platform/graphics/FontPlatformData.h:
platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::showLetterpressedGlyphsWithAdvances):
(WebCore::FontCascade::isSubpixelAntialiasingAvailable): Deleted.
(WebCore::fillVectorWithHorizontalGlyphPositions): Deleted.
(WebCore::shouldUseLetterpressEffect): Deleted.
(WebCore::showGlyphsWithAdvances): Deleted.
(WebCore::setCGFontRenderingMode): Deleted.
(WebCore::FontCascade::drawGlyphs): Deleted.
(WebCore::FontCascade::primaryFontIsSystemFont const): Deleted.
(WebCore::FontCascade::fontForCombiningCharacterSequence const): Deleted.

platform/graphics/cocoa/FontCocoa.cpp: Added.

(WebCore::Font::platformDestroy):

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::hash const):
(WebCore::isSystemFont): Deleted.
(): Deleted.
(WebCore::FontPlatformData::FontPlatformData): Deleted.
(WebCore::FontPlatformData::registeredFont const): Deleted.
(WebCore::mapFontWidthVariantToCTFeatureSelector): Deleted.
(WebCore::cascadeToLastResortAttributesDictionary): Deleted.
(WebCore::cascadeToLastResortAndVariationsFontDescriptor): Deleted.
(WebCore::FontPlatformData::ctFont const): Deleted.
(WebCore::FontPlatformData::objectForEqualityCheck): Deleted.
(WebCore::FontPlatformData::objectForEqualityCheck const): Deleted.
(WebCore::FontPlatformData::openTypeTable const): Deleted.
(WebCore::FontPlatformData::description const): Deleted.
(WebCore::FontPlatformData::familyName const): Deleted.

platform/graphics/cocoa/SourceBufferParserWebM.cpp:
platform/graphics/ct/FontCascadeCoreText.cpp: Copied from Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm.

(WebCore::FontCascade::isSubpixelAntialiasingAvailable):
(WebCore::fillVectorWithHorizontalGlyphPositions):
(WebCore::shouldUseLetterpressEffect):
(WebCore::showGlyphsWithAdvances):
(WebCore::setCGFontRenderingMode):
(WebCore::FontCascade::drawGlyphs):
(WebCore::FontCascade::primaryFontIsSystemFont const):
(WebCore::FontCascade::fontForCombiningCharacterSequence const):

platform/graphics/ct/FontCoreText.cpp: Renamed from Source/WebCore/platform/graphics/cocoa/FontCocoa.mm.

(WebCore::Font::platformInit):
(WebCore::Font::platformCharWidthInit):
(WebCore::Font::platformCreateScaledFont const):
(WebCore::Font::applyTransforms const):

platform/graphics/ct/FontPlatformDataCoreText.cpp: Copied from Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm.

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::isSystemFont):
(WebCore::FontPlatformData::registeredFont const):
(WebCore::mapFontWidthVariantToCTFeatureSelector):
(WebCore::cascadeToLastResortAttributesDictionary):
(WebCore::cascadeToLastResortAndVariationsFontDescriptor):
(WebCore::FontPlatformData::ctFont const):
(WebCore::FontPlatformData::objectForEqualityCheck):
(WebCore::FontPlatformData::objectForEqualityCheck const):
(WebCore::FontPlatformData::openTypeTable const):
(WebCore::FontPlatformData::description const):
(WebCore::FontPlatformData::familyName const):

platform/graphics/ct/GlyphPageCoreText.cpp: Renamed from Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp.
platform/graphics/win/FontCascadeCGWin.cpp: Added.

(WebCore::FontCascade::setFontSmoothingLevel):
(WebCore::setCGFontSmoothingStyle):
(WebCore::FontCascade::setFontSmoothingStyle):
(WebCore::FontCascade::setFontSmoothingContrast):
(WebCore::clearTypeContrast):
(WebCore::FontCascade::systemFontSmoothingChanged):
(WebCore::FontCascade::setCGContextFontRenderingStyle):
(WebCore::renderingStyleForFont):
(WebCore::FontCascade::getPlatformGlyphAdvances):

Source/WebCore/PAL:

pal/spi/win/CoreTextSPIWin.h:

Source/WTF:

wtf/PlatformUse.h:

1:09 PM Changeset in webkit [266935] by Alan Coon

1 copy in branches/safari-610.2.5.1-branch

New branch.

12:05 PM Changeset in webkit [266934] by Devin Rousso

5 edits in trunk

REGRESSION(r266885): ASSERTION FAILED: Inspector::CSSBackendDispatcher::getInlineStylesForNode(long, RefPtr<JSON::Object> &&) !result.error().isEmpty()
https://bugs.webkit.org/show_bug.cgi?id=216409
<rdar://problem/68715815>

Reviewed by Brian Burg.

Source/WebCore:

Test: inspector/css/pseudo-element-matches-for-pseudo-element-node.html

inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getInlineStylesForNode):

LayoutTests:

TestExpectations:
platform/mac-wk2/TestExpectations:

12:04 PM Changeset in webkit [266933] by Alan Coon

9 edits in branches/safari-610-branch/Source/WebKit

Revert r266891. rdar://problem/68666453

11:54 AM Changeset in webkit [266932] by Ben Nham

6 edits in trunk/Source

Fix undeclared identifier issue due to clashes in soft link headers
https://bugs.webkit.org/show_bug.cgi?id=216412

Reviewed by Geoffrey Garen.

Source/WebCore/PAL:

r266898 broke builds on certain SDKs. The reason for this is that it includes
MediaToolbox/FigPhoto.h, which transitively includes CoreMedia/CMTimePrivate.h. The latter
header has a bunch of inline code in certain SDKs which conflicts with the
CoreMediaSoftLink.h header. For instance, CoreMediaSoftLink.h redefines CMTimeCompare to
softLink_CoreMedia_CMTimeCompare, which messes up the inline code in the CMTimePrivate.h
header that references CMTimeCompare.

For now, we just avoid including FigPhoto.h altogether and use a constant. We'll clean this
up once we start weak linking rather than soft linking CoreMedia and MediaToolbox (216388).

pal/cocoa/MediaToolboxSoftLink.cpp:
pal/cocoa/MediaToolboxSoftLink.h:
pal/spi/cocoa/MediaToolboxSPI.h:

Source/WebKit:

Use the workaround constant kPALFigPhotoContainerFormat_JFIF instead of the enum value
kFigPhotoContainerFormat_JFIF.

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

11:53 AM Changeset in webkit [266931] by jer.noble@apple.com

6 edits in trunk/Source

[iOS] Add Experimental setting to disable calling PID Inheritance API.
https://bugs.webkit.org/show_bug.cgi?id=216387
<rdar://problem/66286777>

Reviewed by Eric Carlson.

Source/WebCore:

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setDisableMediaExperiencePIDInheritance):
(WebCore::RuntimeEnabledFeatures::disableMediaExperiencePIDInheritance const):

page/Settings.yaml:
platform/audio/ios/MediaSessionHelperIOS.mm:

(MediaSessionHelperiOS::providePresentingApplicationPID):

Source/WebKit:

Shared/WebPreferences.yaml:

11:09 AM Changeset in webkit [266930] by Alan Bujtas

6 edits in trunk/Source/WebCore

styleDidChange functions should all check for nullptr oldStyle
https://bugs.webkit.org/show_bug.cgi?id=216410

Reviewed by Simon Fraser.

While some of these calls are protected by the StyleDifference value check (!StyleDifference::NewStyle), an unsafe code refactoring could result in null deref.

rendering/RenderElement.cpp:

(WebCore::RenderElement::styleDidChange):

rendering/RenderImage.cpp:

(WebCore::RenderImage::styleDidChange):

rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleDidChange):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::styleDidChange):

rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::styleDidChange):

10:33 AM Changeset in webkit [266929] by Kate Cheney

9 edits in trunk

Followup to Bug 215027: address comments to improve APP_BOUND_DOMAINS macro use
https://bugs.webkit.org/show_bug.cgi?id=216373
<rdar://problem/68645704>

Reviewed by Darin Adler.

Source/WebCore:

Separate out App-Bound Domain functions to avoid nested #if ENABLE()
macros, which are hard to read.

No new tests. Behavior confirmed by existing tests.

platform/network/NetworkStorageSession.h:

Source/WebKit:

Use a local variable to avoid awkward #if ENABLE() macro placement.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::swServerForSession):

Source/WTF:

Remove unnecessary default. All enable flags are off by default.

wtf/PlatformEnable.h:

LayoutTests:

Skip tests in platform/wk2/TestExpectations file to overwrite the
expectation that all resourceLoadStatistics tests pass on wk2. Then
unskip for the ios-wk2 specific platform.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:
platform/wk2/TestExpectations:

10:18 AM Changeset in webkit [266928] by Hector Lopez

3 edits in trunk/LayoutTests

REGRESSION(r266885): ASSERTION FAILED: Inspector::CSSBackendDispatcher::getInlineStylesForNode(long, RefPtr<JSON::Object> &&) !result.error().isEmpty()
https://bugs.webkit.org/show_bug.cgi?id=216409

Unreviewed test gardening.

TestExpectations:
platform/mac-wk2/TestExpectations:

9:54 AM Changeset in webkit [266927] by sihui_liu@apple.com

4 edits in trunk/Tools

REGRESSION(r266634): WKThumbnailViewResetsViewStateWhenUnparented is flaky
https://bugs.webkit.org/show_bug.cgi?id=216258
<rdar://problem/68515242>

Reviewed by Tim Horton.

r266634 makes activity state changes dispatched after existing CA transaction is committed, which delays update
of page state in web process.

TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/cocoa/TestWKWebView.h:
TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView waitUntilActivityStateUpdateDone]):

9:08 AM Changeset in webkit [266926] by weinig@apple.com

8 edits
10 adds in trunk/Source/WebCore

[WebIDL] Split supplemental interfaces out of Document
https://bugs.webkit.org/show_bug.cgi?id=216336

Reviewed by Darin Adler.

Split supplemental interfaces out of Document, adding/updating comments.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
animation/DocumentAnimations.idl: Added.
css/FontFaceSource.idl: Added.
dom/Document.idl:
dom/DocumentHTML.idl: Added.
dom/DocumentHTMLObsolete.idl: Added.
dom/DocumentPageVisibility.idl: Added.
dom/DocumentPointerLock.idl: Added.
dom/DocumentScrolling.idl: Added.
dom/DocumentSelection.idl: Added.
dom/DocumentUndoMananger.idl: Added.
xml/XPathEvaluator.idl:
xml/XPathEvaluatorBase.idl: Added.

9:07 AM Changeset in webkit [266925] by Alexey Shvayka

2 edits in trunk/JSTests

Update test262 to commit 323905b70e64
https://bugs.webkit.org/show_bug.cgi?id=216379

Unreviewed test gardening.

test262/expectations.yaml: Reset expectations for --debug.

8:42 AM Changeset in webkit [266924] by Adrian Perez de Castro

1 copy in releases/WPE WebKit/webkit-2.30.0

WPE WebKit 2.30.0

8:39 AM Changeset in webkit [266923] by Simon Fraser

8 edits
2 adds in trunk

REGRESSION (Async overflow scroll): Mouse wheel scrolling over an "always-on" overflow scrollbar doesn't work
https://bugs.webkit.org/show_bug.cgi?id=216381
<rdar://problem/68593743>

Reviewed by Antti Koivisto.

Source/WebCore:

The scrollbar and scroll corner layers need event regions and scrollingNodeIDs so that
we hit-test them via CA layers and find the right scrolling node.

Test: fast/scrolling/mac/mousewheel-over-scrollbar.html

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::RenderLayerBacking::updateEventRegion):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
(WebCore::RenderLayerBacking::setScrollingNodeIDForRole):

LayoutTests:

fast/scrolling/mac/border-radius-event-region-expected.txt:
fast/scrolling/mac/event-region-scrolled-contents-layer-expected.txt:
fast/scrolling/mac/event-region-subscroller-overflow-expected.txt:
fast/scrolling/mac/event-region-visibility-hidden-expected.txt:
fast/scrolling/mac/mousewheel-over-scrollbar-expected.txt: Added.
fast/scrolling/mac/mousewheel-over-scrollbar.html: Added.
fast/scrolling/mac/negative-z-index-overflow-scroll-expected.txt:

8:28 AM Changeset in webkit [266922] by Chris Dumez

5 edits in trunk

AudioContext does not start rendering until an AudioNode is constructed
https://bugs.webkit.org/show_bug.cgi?id=216393

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline test that is now passing.

web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/constructor-allowed-to-start-expected.txt:

Source/WebCore:

AudioContext does not start rendering until an AudioNode is constructed. This is not as per specification
and does not match Chrome's behavior.

Specification section is here:

https://www.w3.org/TR/webaudio/#dom-audiocontext-audiocontext

and says
"If the context is allowed to start, send a control message to start processing."

No new tests, rebaselined existing test.

Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::BaseAudioContext):

dom/Document.cpp:

(WebCore::Document::addMediaCanStartListener):

8:05 AM Changeset in webkit [266921] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] Make InlineBoxes grow vertically as they gain content
https://bugs.webkit.org/show_bug.cgi?id=216405

Reviewed by Antti Koivisto.

Construct InlineBoxes with zero height (even the root inline box starts empty in quirks mode) and make them grow as they gain text runs.
(This initial vertical geometry adjustment is different from the sizing in computeInlineBoxesLogicalHeight(). It is based on
the font metrics (triggered by text runs), while in computeInlineBoxesLogicalHeight inline boxes stretch their parent inline boxes.)
This will also turn into a more dynamic sizing when we start handling fallback fonts.

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::constructInlineBoxes):
(WebCore::Layout::LineBox::computeInlineBoxesLogicalHeight):
(WebCore::Layout::LineBox::alignInlineBoxesVerticallyAndComputeLineBoxHeight):

layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::fontMetrics const):
(WebCore::Layout::LineBox::InlineBox::setDescent):

8:00 AM Changeset in webkit [266920] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.30

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.30.0 release

Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

wpe/NEWS: Add release notes for 2.30.0

5:18 AM Changeset in webkit [266919] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Rename m_URL to m_frameURL
https://bugs.webkit.org/show_bug.cgi?id=216401

Patch by Rob Buis <rbuis@igalia.com> on 2020-09-11
Reviewed by Frédéric Wang.

Rename m_URL to m_frameURL since m_URL violates the style
checker and any patches that touch m_URL would have to deal
with this style check violation.

html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::canLoad const):
(WebCore::HTMLFrameElementBase::openURL):
(WebCore::HTMLFrameElementBase::setLocation):

html/HTMLFrameElementBase.h:

2:45 AM Changeset in webkit [266918] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.30.0

WebKitGTK 2.30.0

2:45 AM Changeset in webkit [266917] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.30

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.30.0 release

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

gtk/NEWS: Add release notes for 2.30.0

1:46 AM Changeset in webkit [266916] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore

Merge r266819 - [GTK][WPE] Support NTLM authentication
https://bugs.webkit.org/show_bug.cgi?id=122952

Reviewed by Adrian Perez de Castro.

Add SoupAuthNTLM feature to the session.

platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession):

1:46 AM Changeset in webkit [266915] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.30/Source/WebKit

Merge r266726 - [GTK] AcceleratedBackingStoreWayland might erroneously try to use SHM with older wpebackend-fdo
https://bugs.webkit.org/show_bug.cgi?id=216254

Patch by Mike Gorse <mgorse@suse.com> on 2020-09-08
Reviewed by Adrian Perez de Castro.

UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:

(WebKit::tryInitializeSHM): Return false for wpebackend-fdo < 1.7.0.

1:46 AM Changeset in webkit [266914] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.30/Source/WebKit

Merge r266702 - Build failure; cannot find seccomp.h
https://bugs.webkit.org/show_bug.cgi?id=216226

Patch by Mike Gorse <mgorse@suse.com> on 2020-09-07
Reviewed by Darin Adler.

No new tests (build fix only).

PlatformGTK.cmake: Add LIBSECCOMP_INCLUDE_DIRS to

WebKit_SYSTEM_INCLUDE_DIRECTORIES.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed