Timeline



Mar 18, 2021:

10:30 PM Changeset in webkit [274704] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Attempt to fix the macOS build after r274695.

  • platform/graphics/GraphicsContextGL.h:
  • testing/WebFakeXRDevice.cpp:
  • testing/WebFakeXRDevice.h:
9:57 PM Changeset in webkit [274703] by Simon Fraser
  • 9 edits
    9 copies in trunk

Roll over the ChangeLogs

9:45 PM Changeset in webkit [274702] by Lauro Moura
  • 17 edits
    1 add in trunk/LayoutTests

[GLIB] Gardening yet more consistent failures

Unreviewed test gardening.

  • platform/glib/TestExpectations:
  • platform/glib/webgl/webgl-allow-shared-expected.txt: Added with

webgl2 failures, to avoid missihg the webgl checks.

  • platform/gtk/TestExpectations: A bunch of ruby tests were marked as

very old failures but needed only to be rebaselined.

  • platform/gtk/fast/ruby/nested-ruby-expected.txt:
  • platform/gtk/fast/ruby/ruby-beforeafter-expected.txt:
  • platform/gtk/fast/ruby/ruby-empty-rt-expected.txt:
  • platform/gtk/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/gtk/fast/ruby/ruby-trailing-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-insert-text2-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-insert-text3-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-remove-rt1-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-remove-rt2-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-remove-text1-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-remove-text2-expected.txt:
  • platform/wpe/fast/ruby/rubyDOM-remove-rt1-expected.txt:
9:30 PM Changeset in webkit [274701] by mark.lam@apple.com
  • 2 edits in trunk/JSTests

JSTests/stress/heap-analyzer-taking-lock.js intermittently fails --verifyGC=true.
​https://bugs.webkit.org/show_bug.cgi?id=222947
rdar://75454308

Reviewed by Michael Saboff.

The issue was already fixed in ​https://bugs.webkit.org/show_bug.cgi?id=223241.
Removing skipped test option.

  • stress/heap-analyzer-taking-lock.js:
9:21 PM Changeset in webkit [274700] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Add a fast path for subdivideAndResolveStyle()
​https://bugs.webkit.org/show_bug.cgi?id=223480

Reviewed by Myles Maxfield.

Most of the time, InlineTextBox::paint() will be painting text runs with no marked text,
so optimize subdivideAndResolveStyle() for this case.

This removes 1.6% of the time in painting in the MotionMark Design subtest.

  • rendering/MarkedTextStyle.cpp:

(WebCore::subdivideAndResolveStyle):
(WebCore::coalesceAdjacentMarkedTexts): No need to do any work if there are zero or one
ranges.

9:20 PM Changeset in webkit [274699] by sbarati@apple.com
  • 4 edits
    1 add in trunk

JS->Wasm IC must save the tag registers if it uses them
​https://bugs.webkit.org/show_bug.cgi?id=223491
<rdar://66445108>

Reviewed by Yusuke Suzuki.

JSTests:

  • wasm/stress/save-tag-callee-saves-in-js-entrypoint-ic.js: Added.

(0x0b.WebAssembly.instantiate.wasm.then.e.const.mod.e.instance.exports.Test.prototype.get breakIt):
(0x0b.WebAssembly.instantiate.wasm.then.e.const.mod.e.instance.exports.Test):
(0x0b.WebAssembly.instantiate.wasm.then.e.const.obj.new.Test):

Source/JavaScriptCore:

It turns out, that when you use a callee save register, you should save it.

  • wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::usesTagRegisters const):
(JSC::WebAssemblyFunction::calleeSaves const):
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):
(JSC::WebAssemblyFunction::useTagRegisters const): Deleted.

  • wasm/js/WebAssemblyFunction.h:
7:56 PM Changeset in webkit [274698] by Aditya Keerthi
  • 8 edits in trunk

[iOS] Update strings and icons in the file upload panel
​https://bugs.webkit.org/show_bug.cgi?id=223463
<rdar://problem/74999459>

Reviewed by Tim Horton.

Source/WebCore:

  • en.lproj/Localizable.strings:

Removed unused string.

  • platform/LocalizedStrings.h:

WEBCORE_EXPORT the "Choose File" and "Choose Files" strings so that
they can be used in the WebKit layer.

Source/WebKit:

  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel currentAvailableActionTitles]):

Expose the new string for testing.

(-[WKFileUploadPanel _chooseFilesButtonLabel]):
(-[WKFileUploadPanel contextMenuInteraction:configurationForMenuAtLocation:]):

Use the "folder" SF symbol as the icon for the "Choose File" action.

LayoutTests:

Updated existing tests to use async/await rather than promise chaining,
and added new tests that exercise the "multiple" attribute on file
inputs.

  • fast/forms/ios/file-upload-panel-expected.txt:
  • fast/forms/ios/file-upload-panel.html:
7:37 PM Changeset in webkit [274697] by BJ Burg
  • 7 edits
    1 copy
    1 add in trunk/Source/WebKit

[Cocoa] Web Inspector: load inspector resources using a custom scheme handler
​https://bugs.webkit.org/show_bug.cgi?id=179904
<rdar://problem/10887211>

Reviewed by Geoff Garen.

Load WebInspectorUI resources via the inspector-resource:// scheme.
Moving off of ​file:// URLs will allow for a tighter sandbox and
will fix the longstanding issue that Web Inspector's settings are
part of the ​file:// scheme and cleared when Safari clears website data.

This also has the effect of resetting Web Inspector settings since
they are no longer associated with ​file:///.

Loading via this scheme is exercised by existing inspector tests.

  • SourcesCocoa.txt: Added new file.
  • WebKit.xcodeproj/project.pbxproj:
  • UIProcess/Inspector/mac/WKInspectorResourceURLSchemeHandler.h: Copied from Source/WebKit/WebProcess/Inspector/mac/WebInspectorUIMac.mm.
  • UIProcess/Inspector/mac/WKInspectorResourceURLSchemeHandler.mm: Added.

(-[WKInspectorResourceURLSchemeHandler webView:startURLSchemeTask:]):
Use a global concurrent queue and NSOperation / NSOperationQueue to support
reading files off the main queue.

(-[WKInspectorResourceURLSchemeHandler webView:stopURLSchemeTask:]):
Translate the request URL to a bundle resource URL, read the data, and send a response
with the file data. Return an error if the file could not be found or read.

  • UIProcess/Inspector/mac/WKInspectorViewController.h:
  • UIProcess/Inspector/mac/WKInspectorViewController.mm:

(-[WKInspectorViewController webViewConfiguration]):
(+[WKInspectorViewController URLForInspectorResource:]):
(-[WKInspectorViewController webView:decidePolicyForNavigationAction:decisionHandler:]):
Allow navigations to URIs with the inspector-resource:// scheme.

  • UIProcess/Inspector/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorTestPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
Updated.

  • WebProcess/Inspector/mac/WebInspectorUIMac.mm:

(WebKit::webInspectorUILocalizedStringsURL):
Updated.

7:23 PM Changeset in webkit [274696] by Wenson Hsieh
  • 2 edits in trunk/Tools

Add a test to exercise the crash in webkit.org/b/223417
​https://bugs.webkit.org/show_bug.cgi?id=223485

Reviewed by Tim Horton.

Add an API test that performs a hit-test just outside of the bounds of the WKWebView that contains a full-page
clickable element. This finds the element as the click target, but the hit-tested node is null.

  • TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:

(TestWebKitAPI::TEST):

6:27 PM Changeset in webkit [274695] by imanol
  • 25 edits
    6 adds in trunk

Implement WebXR Opaque Framebuffer
​https://bugs.webkit.org/show_bug.cgi?id=222607

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Update WebXR Opaque Framebuffer test expectations.

  • web-platform-tests/webxr/xrWebGLLayer_framebuffer_draw.https-expected.txt: Added.
  • web-platform-tests/webxr/xrWebGLLayer_opaque_framebuffer.https-expected.txt: Added.

Source/WebCore:

This patch adds a base XR layers API which is initially used by WebXRWebGLLayer, but
with the goal of supporting more types of layers in the future (see WebXR Layers spec).

Layers are connected to WebGL by using shared textures. In the case of WebXRWebGLLayer
it creates an Opaque Framebuffer that renders to the shared texture. XR runtimes supporting
double or triple buffering can send different shared textures each frame in the FrameData struct.
The texture for the current frame is attached in WebXRLayer::startFrame and prepared to send it back to the
VR compositor in WebXRLayer::endFrame().

Tested by the WebXR WPT tests.

  • Modules/webxr/WebXRLayer.h: add startFrame and endFrame pure virtual methods.
  • Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::onFrame): do not call RAFs if frameData.shouldRender is false.

  • Modules/webxr/WebXRSession.h: add device getter.
  • Modules/webxr/WebXRSystem.cpp:

(WebCore::WebXRSystem::DummyInlineDevice::requestFrame): always enable frameData.shouldRender flag.

  • Modules/webxr/WebXRSystem.h: Override new virtual functions.
  • Modules/webxr/WebXRViewport.h:

(WebCore::WebXRViewport::rect const): Add helper method.

  • Modules/webxr/WebXRWebGLLayer.cpp: Refactor resource initialization to create method.

(WebCore::WebXRWebGLLayer::create):
(WebCore::WebXRWebGLLayer::WebXRWebGLLayer):
(WebCore::m_isCompositionEnabled):
(WebCore::WebXRWebGLLayer::framebuffer const):
(WebCore::WebXRWebGLLayer::framebufferWidth const):
(WebCore::WebXRWebGLLayer::framebufferHeight const):
(WebCore::WebXRWebGLLayer::startFrame): Prepare Opaque Framebuffer for the start of next frame.
(WebCore::WebXRWebGLLayer::endFrame): Prepare Opaque Framebuffer for VR compositor submitFrame.
(WebCore::WebXRWebGLLayer::canvasResized): Move method

(WebCore::WebXROpaqueFramebuffer::create): Implement class to manage WebXR Opaque framebuffer.
(WebCore::WebXROpaqueFramebuffer::WebXROpaqueFramebuffer):
(WebCore::WebXROpaqueFramebuffer::~WebXROpaqueFramebuffer):
(WebCore::WebXROpaqueFramebuffer::startFrame): Attach shared texture for the current frame.
(WebCore::WebXROpaqueFramebuffer::endFrame): Flush and resolve multisampling if required.
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer): Allocate the Opaque framebuffer with requested attributes.

  • Modules/webxr/WebXRWebGLLayer.h: Add WebXROpaqueFramebuffer and handle members.

(WebCore::WebXROpaqueFramebuffer::handle const):
(WebCore::WebXROpaqueFramebuffer::framebuffer const):
(WebCore::WebXROpaqueFramebuffer::width const):
(WebCore::WebXROpaqueFramebuffer::height const):

  • Sources.txt: Add OpenXRLayer.cpp and OpenXRSwapchain.cpp.
  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getFramebufferAttachmentParameter): handle Opaque Framebuffers.

  • html/canvas/WebGLFramebuffer.cpp: Add members and methods required for Opaque Framebuffers.

(WebCore::WebGLFramebuffer::createOpaque):
(WebCore::WebGLFramebuffer::checkStatus const):

  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): handle Opaque Framebuffers.

  • html/canvas/WebGLRenderingContextBase.cpp: handle Opaque Framebuffers.

(WebCore::WebGLRenderingContextBase::deleteFramebuffer):
(WebCore::WebGLRenderingContextBase::framebufferRenderbuffer):
(WebCore::WebGLRenderingContextBase::framebufferTexture2D):

  • platform/xr/PlatformXR.h: Add method to submitFrame.

(PlatformXR::Device::submitFrame):

  • platform/xr/openxr/OpenXRLayer.cpp: Add class to manage OpenXR layers.

(PlatformXR::OpenXRLayer::OpenXRLayer):
(PlatformXR::OpenXRLayerProjection::create):
(PlatformXR::OpenXRLayerProjection::OpenXRLayerProjection):
(PlatformXR::OpenXRLayerProjection::startFrame):

  • platform/xr/openxr/OpenXRLayer.h: Added.

(PlatformXR::OpenXRLayer::handle):

  • platform/xr/openxr/OpenXRSwapchain.cpp: Add class to manage OpenXR swapchains

(PlatformXR::OpenXRSwapchain::create):
(PlatformXR::OpenXRSwapchain::OpenXRSwapchain):
(PlatformXR::OpenXRSwapchain::~OpenXRSwapchain):
(PlatformXR::OpenXRSwapchain::acquireImage):
(PlatformXR::OpenXRSwapchain::releaseImage):

  • platform/xr/openxr/OpenXRSwapchain.h: Added.
  • platform/xr/openxr/OpenXRUtils.h: Add helper log function

(PlatformXR::xrViewToPose): Use fabs instead of negation

  • platform/xr/openxr/PlatformXROpenXR.cpp:

(PlatformXR::OpenXRDevice::initializeTrackingAndRendering): create GraphicsContextGL for texture sharing.
(PlatformXR::OpenXRDevice::requestFrame): Prepare and fill layers if shouldRender is true.
(PlatformXR::OpenXRDevice::submitFrame): Implement submit layers to OpenXR
(PlatformXR::OpenXRDevice::createLayerProjection): Implement layer creation method
(PlatformXR::OpenXRDevice::deleteLayer): Implement layer deallocation
(PlatformXR::OpenXRDevice::collectEnabledFeatures const):
(PlatformXR::OpenXRDevice::resetSession): Deallocate layers and graphics context.

  • platform/xr/openxr/PlatformXROpenXR.h: Add Layers API
  • testing/WebFakeXRDevice.cpp:

(WebCore::SimulatedXRDevice::recommendedResolution): Increase size to avoid platform minimum FBO size errors
(WebCore::SimulatedXRDevice::initializeTrackingAndRendering): Create graphics context
(WebCore::SimulatedXRDevice::shutDownTrackingAndRendering): Release graphics context
(WebCore::SimulatedXRDevice::frameTimerFired): set up layers in frame data
(WebCore::SimulatedXRDevice::createLayerProjection): creates a texture for a layer.
(WebCore::SimulatedXRDevice::deleteLayer): releases the associated texture to a layer

  • testing/WebFakeXRDevice.h:

LayoutTests:

Update WebXR Opaque Framebuffer test expectations.

  • platform/wpe/TestExpectations:
6:15 PM Changeset in webkit [274694] by Diego Pino Garcia
  • 3 edits in trunk/LayoutTests

[GLIB] REGRESSION(r274273): fast/canvas/webgl/gl-teximage-imagebitmap.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=223297

Reviewed by Carlos Garcia Campos.

This test started failing in GTK after r274273. The test fails due to a pixel color difference of 1.
Change failing test to allow a tolerance of 1 when comparing expected and actual results.

  • fast/canvas/webgl/gl-teximage-imagebitmap-expected.txt:
  • fast/canvas/webgl/gl-teximage-imagebitmap.html:
6:02 PM Changeset in webkit [274693] by Russell Epstein
  • 2 edits in branches/safari-612.1.7-branch/Source/WebKit

Revert r274356. rdar://problem/75599898

5:25 PM Changeset in webkit [274692] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

Handle empty bound size during animated resizing
​https://bugs.webkit.org/show_bug.cgi?id=223446

Patch by Sihui Liu <​sihui_liu@appe.com> on 2021-03-18
Reviewed by Tim Horton.

We don't allow empty bounds in animated resizing: when that happens, we would cancel it. However, a set of
updates involving empty bounds can be merged to a valid update. For example, two changes of frame size
[1] (0, 0, 100, 100) => (0, 0, 0, 50) [2] (0, 0, 0, 50) => (0, 0, 50, 50) can be viewed as single change
(0, 0, 100, 100) => (0, 0, 50, 50), which is valid. We used to ask SPI clients to ensure each update is valid,
but sometimes the frame change is not under client's control. For example when client uses auto layout, empty
frame seems to be a valid mid product.

To handle this case, we can store the old bounds, and actually perform animated resizing on when new valid
bounds show up. For the example above, we would store (0, 0, 100, 100) on [1] and use it to resize from
(0, 0, 100, 100) to (0, 0, 50, 50) on [2].

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _processWillSwapOrDidExit]):
(-[WKWebView _updateVisibleContentRects]): If we still have stored old bounds in _updateVisibleContentRects, it
means they are not consumed in this cycle. In this case let's just cancel animated resizing and send out updates.
(-[WKWebView _cancelAnimatedResize]):
(-[WKWebView _didCompleteAnimatedResize]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):

5:08 PM Changeset in webkit [274691] by Adrian Perez de Castro
  • 3 edits in releases/WebKitGTK/webkit-2.30/Source/WebKit

Unreviewed non-unified build fixes

  • GPUProcess/media/RemoteMediaResourceLoader.cpp:
  • NetworkProcess/webrtc/NetworkRTCProvider.cpp:
4:56 PM Changeset in webkit [274690] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS wk2 Release ARM64 ] 3 http/wpt/beacon/cors/cors-preflight-blob are flakey text failures
​https://bugs.webkit.org/show_bug.cgi?id=223488

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Updating expectations to Pass Failure while tests are being reviewed.
4:46 PM Changeset in webkit [274689] by jiewen_tan@apple.com
  • 2 edits in trunk/Source/WebKit

Update Keychain queries according to internal needs
​https://bugs.webkit.org/show_bug.cgi?id=223424
rdar://75434045

Reviewed by Brent Fulgham.

Covered by manual tests.

  • UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(updateQuery):
(WebKit::LocalAuthenticatorInternal::getExistingCredentials):
(WebKit::LocalAuthenticator::clearAllCredentials):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):
(WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification):
(WebKit::LocalAuthenticator::receiveException const):
(WebKit::LocalAuthenticator::deleteDuplicateCredential const):
(shouldUseAlternateQuery): Deleted.
(alternateQueryForRPID): Deleted.

4:42 PM Changeset in webkit [274688] by Wenson Hsieh
  • 5 edits in trunk

Avoid copying item data when iterating in-process display lists
​https://bugs.webkit.org/show_bug.cgi?id=223471

Reviewed by Simon Fraser.

Source/WebCore:

As a performance optimization, in the case where display lists are built up without item buffer clients that are
responsible for encoding and decoding display list data, all display list items are constructed (and exist)
directly within the item buffer. In this scenario, there is no need to additionally decode or validate inline
items by copying them into a separate buffer, so we can simply skip this step and just use the memory address of
the item inside m_allocatedBuffers as the curren item handle when iterating through in-process display lists.

This skips almost all of the work done underneath DisplayList::iterator::updateCurrentItem() in the web
process on the Design subtest of MotionMark. Covered by existing API tests (one of which needs a slight
adjustment).

  • platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::iterator::atEnd const):
(WebCore::DisplayList::DisplayList::iterator::updateCurrentItem):
(WebCore::DisplayList::DisplayList::iterator::advance):

Rearrange this logic so that we only decode or copy out to a side buffer and perform validation in the case
where we have an item buffer client. Otherwise, we know that the items already exist inside the item buffer's
m_allocatedBuffers, so we can simply use the current memory address (m_cursor) as the item handle.

(WebCore::DisplayList::DisplayList::iterator::clearCurrentItem):

Only destroy the item at m_currentBufferForItem if it doesn't already exist in the display list's item buffer.
(that is, if the item buffer requires a reading client). The items within the item buffer are destroyed upon
clearing the DisplayList, so running this logic would result in a double-free.

(WebCore::DisplayList::DisplayList::iterator::moveToEnd):
(WebCore::DisplayList::DisplayList::iterator::moveCursorToStartOfCurrentBuffer):

  • platform/graphics/displaylists/DisplayList.h:

(WebCore::DisplayList::DisplayList::iterator::itemBuffer const):

Drive-by refactoring: add a helper method to grab the display list's ItemBuffer, and use it in several places
above.

Tools:

Adjust an existing API test that exercises inline display list item validation by assigning a reading client to
the display list.

  • TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:

(TestWebKitAPI::TEST):

Move the ReadingClient and WritingClient out of the scope of OutOfLineItemDecodingFailure, so that the
other API test (InlineItemValidationFailure) can also use it.

4:40 PM Changeset in webkit [274687] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, reverting r274669.
​https://bugs.webkit.org/show_bug.cgi?id=223487

Broke two debug layout tests

Reverted changeset:

"CSP headers can block default <video> controls"
​https://bugs.webkit.org/show_bug.cgi?id=223422
​https://trac.webkit.org/changeset/274669

4:39 PM Changeset in webkit [274686] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Avoid heap allocation under AudioParamTimeline::processSetTargetFollowedByRamp()
​https://bugs.webkit.org/show_bug.cgi?id=223477

Reviewed by Darin Adler.

Stop heap-allocating ParamEvent objects in AudioParamTimeline since they sometimes
get constructed on the audio thread.

  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::insertEvent):
(WebCore::AudioParamTimeline::cancelAndHoldAtTime):
(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::AudioParamTimeline::valuesForFrameRangeImpl):
(WebCore::AudioParamTimeline::processCancelValues):
(WebCore::AudioParamTimeline::processSetTargetFollowedByRamp):
(WebCore::AudioParamTimeline::handleCancelValues):
(WebCore::AudioParamTimeline::ParamEvent::createSetValueEvent):
(WebCore::AudioParamTimeline::ParamEvent::createLinearRampEvent):
(WebCore::AudioParamTimeline::ParamEvent::createExponentialRampEvent):
(WebCore::AudioParamTimeline::ParamEvent::createSetTargetEvent):
(WebCore::AudioParamTimeline::ParamEvent::createSetValueCurveEvent):
(WebCore::AudioParamTimeline::ParamEvent::createCancelValuesEvent):
(WebCore::AudioParamTimeline::hasValues const):

  • Modules/webaudio/AudioParamTimeline.h:

(WebCore::AudioParamTimeline::ParamEvent::ParamEvent):
(WebCore::AudioParamTimeline::ParamEvent::savedEvent):

4:38 PM Changeset in webkit [274685] by Diego Pino Garcia
  • 3 edits in trunk/Source/WebCore

[GTK][WPE][CMake] libCMS2 should be included only if guard USE_LCMS is defined
​https://bugs.webkit.org/show_bug.cgi?id=223340

Reviewed by Carlos Garcia Campos.

  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
4:29 PM Changeset in webkit [274684] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS Release Wk2 ARM64 ] inspector/css/modify-inline-style.html is a flakey text failure
​https://bugs.webkit.org/show_bug.cgi?id=223486

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Updating expectations to Pass Failure while test is reviewed.
4:22 PM Changeset in webkit [274683] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Crash under WebsiteDataStore::terminateNetworkProcess()
​https://bugs.webkit.org/show_bug.cgi?id=223482
<rdar://75326967>

Reviewed by Alex Christensen.

Calling WebProcessPool::terminateServiceWorkers() may destroy the WebProcessPool, which would
remove the WebProcessPool from the WebProcessPool::allProcessPools() vector we're iterating
on. To make this safe, I now copy the WebProcessPool into a separate vector and hold a RefPtr
to them. I now iterate over this new vector instead.

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::terminateNetworkProcess):

4:11 PM Changeset in webkit [274682] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Don't spend time painting transparent cell backgrounds
​https://bugs.webkit.org/show_bug.cgi?id=223459

Reviewed by Darin Adler.

We can bail early from RenderTableCell::paintBackgroundsBehindCell() if the style has
no background image, and the background color is transparent (the default).

Removes 2% of painting time in the MotionMark Design subtest.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell):

4:09 PM Changeset in webkit [274681] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS ARM 64 ] compositing/style-change/backface-visibility-change.htmlis a flakey image failure
​https://bugs.webkit.org/show_bug.cgi?id=223484

Unreviewed test gardening.

  • platform/mac/TestExpectations: Updated test expectations to PASS ImageOnlyFailure for Apple Silicon while test is reviewed.
3:59 PM Changeset in webkit [274680] by Nikita Vasilyev
  • 5 edits in trunk

Use 1000-based units for file sizes, per HIG
​https://bugs.webkit.org/show_bug.cgi?id=208190
<rdar://problem/71045696>

Reviewed by BJ Burg.

Source/WebInspectorUI:

  • UserInterface/Base/Utilities.js:
  • UserInterface/Views/ResourceSizesContentView.js:

(WI.ResourceSizesContentView.prototype._formattedSizeComponent):

LayoutTests:

  • inspector/unit-tests/number-utilities.html:
3:53 PM Changeset in webkit [274679] by Chris Dumez
  • 7 edits in trunk/Source/WebCore

Avoid heap allocation under PannerNode::processSampleAccurateValues()
​https://bugs.webkit.org/show_bug.cgi?id=223466

Reviewed by Darin Adler.

Make sure BaseAudioContext::m_listener gets initialized in the constructor
(on the main thread) instead of doing it lazily in the listener() getter
(which may get called on the audio thread).

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):
(WebCore::AudioContext::AudioContext):

  • Modules/webaudio/AudioContext.h:

(WebCore::AudioContext::AudioContext):

  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::BaseAudioContext):
(WebCore::WebCore::BaseAudioContext::listener):

  • Modules/webaudio/BaseAudioContext.h:

(WebCore::BaseAudioContext::BaseAudioContext):

  • Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::OfflineAudioContext):

  • Modules/webaudio/WebKitAudioContext.cpp:

(WebCore::WebKitAudioContext::WebKitAudioContext):

3:52 PM Changeset in webkit [274678] by timothy@apple.com
  • 4 edits in trunk/Source/WebCore

SpeechSynthesis should honor audioPlaybackRequiresUserGesture setting on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=223473
rdar://problem/75586456

Reviewed by Chris Fleizach.

  • Modules/speech/DOMWindowSpeechSynthesis.cpp:

(WebCore::DOMWindowSpeechSynthesis::speechSynthesis): Pass the document.

  • Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::create): Pass the document.
(WebCore::SpeechSynthesis::SpeechSynthesis): Set the initial m_restrictions based on document.audioPlaybackRequiresUserGesture().

  • Modules/speech/SpeechSynthesis.h:
3:42 PM Changeset in webkit [274677] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Avoid heap allocation under AudioWorkletNode::process()
​https://bugs.webkit.org/show_bug.cgi?id=223452

Reviewed by Darin Adler.

Always use arrays of size 128 (render quantum) for AudioParam values. We used to
dynamically choose between a size of 128 and 1 (when there is no automation
scheduled and the value is constant for the quantum). This avoids having to make
heap allocations on the audio thread, which are bad for performance.

Content (and existing AudioWorklet tests) can handle either size because the
specification says [1]:
"""
For each array, the array contains the computedValue of the parameter for all
frames in the render quantum. However, if no automation is scheduled during this
render quantum, the array MAY have length 1 with the array element being the
constant value of the AudioParam for the render quantum.
"""

Note that the specification uses "MAY" so this is not a requirement for us to use
an array of size 1 in such case. I also verified that Blink is never using an
array of size 1 either. They always use arrays of 128 (render quantum size) and
std::fill() them with the constant value when there is no automation. Our new
behavior is thus consistent with Blink.

[1] ​https://webaudio.github.io/web-audio-api/#audioworkletprocess-callback-parameters

  • Modules/webaudio/AudioWorkletNode.cpp:

(WebCore::AudioWorkletNode::initializeAudioParameters):
(WebCore::AudioWorkletNode::process):

3:24 PM Changeset in webkit [274676] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[WPE][GTK] Remove plugin process leftover arg from ProcessLauncher
​https://bugs.webkit.org/show_bug.cgi?id=223460

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-03-18
Reviewed by Adrian Perez de Castro.

Remove extra nullptr arg.

  • UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::ProcessLauncher::launchProcess):

3:09 PM Changeset in webkit [274675] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Protect frame before calling setPrinting
​https://bugs.webkit.org/show_bug.cgi?id=222664

Patch by Rob Buis <​rbuis@igalia.com> on 2021-03-18
Reviewed by Ryosuke Niwa.

Protect frame before calling setPrinting
since it could potentially delete the frame
through event handling.

  • page/PrintContext.cpp:

(WebCore::PrintContext::begin):

2:41 PM Changeset in webkit [274674] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add another email for myself in contributors.json
​https://bugs.webkit.org/show_bug.cgi?id=222700

Patch by Cameron McCormack <Cameron McCormack> on 2021-03-18
Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/config/contributors.json:
2:19 PM Changeset in webkit [274673] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Switch out of scheduled resource load mode only after async scripts have run
​https://bugs.webkit.org/show_bug.cgi?id=223464

Reviewed by Geoffrey Garen.

Async scripts may generate more resource loads that benefit from scheduling.

  • page/Page.cpp:

(WebCore::Page::prioritizeVisibleResources):

Also factor the mode transition into a lambda.

1:58 PM Changeset in webkit [274672] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Avoid heap allocation under BaseAudioContext::sourceNodeDidFinishPlayback()
​https://bugs.webkit.org/show_bug.cgi?id=223461

Reviewed by Jer Noble.

BaseAudioContext::sourceNodeDidFinishPlayback() was appending to a m_finishedSourceNodes
Vector, which would cause heap allocations on the audio thread. To avoid such heap
allocations (which are bad for performance), we now set a "isFinishedSourceNode" flag
on the AudioNode. When BaseAudioContext::derefFinishedSourceNodes(), it relies on
this new isFinishedSourceNode flag instead of using the m_finishedSourceNodes Vector.

  • Modules/webaudio/AudioNode.h:

(WebCore::AudioNode::isFinishedSourceNode const):
(WebCore::AudioNode::setIsFinishedSourceNode):

  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::~BaseAudioContext):
(WebCore::BaseAudioContext::uninitialize):
(WebCore::isFinishedSourceNode):
(WebCore::BaseAudioContext::derefFinishedSourceNodes):
(WebCore::BaseAudioContext::sourceNodeDidFinishPlayback):

  • Modules/webaudio/BaseAudioContext.h:
1:42 PM Changeset in webkit [274671] by Chris Gambrell
  • 21 edits
    1 add
    1 delete in trunk/LayoutTests

[ macOS Wk2 ] http/tests/security/contentSecurityPolicy/report-only-connect-src-xmlhttprequest-redirect-to-blocked.php is constantly text failing
​https://bugs.webkit.org/show_bug.cgi?id=223079
<rdar://problem/75323779>

Reviewed by Jonathan Bedard.

  • http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-redirect-to-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-redirect-to-blocked.html:
  • http/tests/security/contentSecurityPolicy/report-document-uri-after-blocked-redirect-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-document-uri-after-blocked-redirect.html:
  • http/tests/security/contentSecurityPolicy/report-only-connect-src-beacon-redirect-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-only-connect-src-beacon-redirect-blocked.php:
  • http/tests/security/contentSecurityPolicy/report-only-connect-src-xmlhttprequest-redirect-to-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-only-connect-src-xmlhttprequest-redirect-to-blocked.php:
  • http/tests/security/contentSecurityPolicy/resources/go-to-echo-report.py:
  • http/tests/security/contentSecurityPolicy/resources/redirect.pl:
  • http/tests/security/contentSecurityPolicy/resources/worker-importScript-redirect-cross-origin-allowed.py:
  • http/tests/security/contentSecurityPolicy/resources/worker-importScript-redirect-cross-origin-blocked.py:
  • http/tests/security/contentSecurityPolicy/resources/worker-xhr-allowed.py:
  • http/tests/security/contentSecurityPolicy/resources/worker-xhr-redirect-cross-origin-allowed.py:
  • http/tests/security/contentSecurityPolicy/resources/worker-xhr-redirect-cross-origin-blocked.py:
  • http/tests/security/contentSecurityPolicy/resources/xhr-redirect-not-allowed.pl: Removed.
  • http/tests/security/contentSecurityPolicy/resources/xhr-redirect-not-allowed.py: Added.
  • http/tests/security/no-javascript-refresh.py:
  • platform/mac-wk1/http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-redirect-to-blocked-expected.txt:
  • platform/mac-wk1/http/tests/security/contentSecurityPolicy/report-document-uri-after-blocked-redirect-expected.txt:
  • platform/win/http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-redirect-to-blocked-expected.txt:
  • platform/win/http/tests/security/contentSecurityPolicy/report-document-uri-after-blocked-redirect-expected.txt:
1:31 PM Changeset in webkit [274670] by Russell Epstein
  • 3 edits in branches/safari-612.1.7-branch/Source/WebCore

Cherry-pick r274669. Unreviewed build fix.

Fix a Catalyst build.

  • Modules/mediasession/MediaMetadata.h: (WebCore::MediaMetadata::artworkImage const):
  • testing/Internals.cpp: (WebCore::Internals::loadArtworkImage):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:26 PM Changeset in webkit [274669] by Devin Rousso
  • 3 edits in trunk/Source/WebCore

CSP headers can block default <video> controls
​https://bugs.webkit.org/show_bug.cgi?id=223422
<rdar://problem/41192193>

Reviewed by Antoine Quint.

Covered by existing tests.

  • Modules/modern-media-controls/controls/icon-service.js:

(IconService.prototype.imageForIconAndLayoutTraits):
In order for an <img> to skip CSP checks it must be isInUserAgentShadowTree before setting src.

  • Modules/modern-media-controls/main.js:

(createControls):
Provide the UA shadowRoot to the iconService so it can temporarily attach the <img>.

1:16 PM Changeset in webkit [274668] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS Wk2 ARM64 ] platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html is a flakey timeout
​https://bugs.webkit.org/show_bug.cgi?id=223474

Uneviewed test gardening.

  • platform/mac/TestExpectations: Updating test expectations to include Timeout for arm64 systems.
12:49 PM Changeset in webkit [274667] by achristensen@apple.com
  • 3 edits in trunk/Source/WebCore

Fix a Catalyst build.

  • Modules/mediasession/MediaMetadata.h:

(WebCore::MediaMetadata::artworkImage const):

  • testing/Internals.cpp:

(WebCore::Internals::loadArtworkImage):

12:47 PM Changeset in webkit [274666] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Kinetic iframe async scrolling does not work
​https://bugs.webkit.org/show_bug.cgi?id=223133

Patch by Alejandro G. Castro <​alex@igalia.com> on 2021-03-18
Reviewed by Carlos Garcia Campos.

Add a condition for the gtk port, it allows end of momentum wheel
events to be detected as a scrollable events, no matter of the
delta value. By definition of the API delta is going to be zero in
gtk end of momentum events according to:
​https://developer.gnome.org/gdk3/stable/gdk3-Events.html#gdk-event-is-scroll-stop-event

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::eventCanScrollContents const):

12:45 PM Changeset in webkit [274665] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS wk2 ARM64 ] fast/images/async-image-background-change.html is a flakey timeout
​https://bugs.webkit.org/show_bug.cgi?id=223469

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Updating test expectations to Pass Timeout while test is being reviewed.
12:23 PM Changeset in webkit [274664] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Avoid heap allocations under BiquadDSPKernel::updateCoefficientsIfNecessary()
​https://bugs.webkit.org/show_bug.cgi?id=223444

Reviewed by Darin Adler.

Use float[] instead of AudioFloatArray for local variables in updateCoefficientsIfNecessary()
in order to avoid doing heap allocations on the audio thread, for performance reasons.

  • Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::hasConstantValue):
(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):

12:09 PM Changeset in webkit [274663] by Russell Epstein
  • 2 edits in branches/safari-612.1.7-branch/Source/ThirdParty/ANGLE

Cherry-pick r274654. rdar://problem/75583447

'MTLLanguageVersion1_0' is unavailable on Catalyst
​https://bugs.webkit.org/show_bug.cgi?id=223392

Patch by Kyle Piddington <Kyle Piddington> on 2021-03-18
Reviewed by Jon Lee.

Disable switch case in catalyst builds

  • src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp: (GetOperatorString):
  • src/compiler/translator/TranslatorMetalDirect/ProgramPrelude.cpp:
  • src/libANGLE/renderer/metal/FrameBufferMtl.mm: (rx::FramebufferMtl::readPixels):
  • src/libANGLE/renderer/metal/mtl_utils.mm: (rx::mtl::GetUserSetOrHighestMSLVersion):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:09 PM Changeset in webkit [274662] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Update test expectations
​https://bugs.webkit.org/show_bug.cgi?id=223456

Unreviewed test gardening.

  • platform/win/TestExpectations:
12:07 PM Changeset in webkit [274661] by Russell Epstein
  • 1 copy in branches/safari-612.1.7-branch

New branch.

12:06 PM Changeset in webkit [274660] by dino@apple.com
  • 3 edits in trunk/Source/ThirdParty/ANGLE

Metal-ANGLE can ASSERT because MTL signal event code is compiled out
​https://bugs.webkit.org/show_bug.cgi?id=222859
<rdar://problem/75132180>

Reviewed by Ken Russell.

With the Metal backend enabled, the test
webgl/2.0.0/conformance2/state/gl-object-get-calls.html will
occasionally crash in mtl_command_buffer when it hits unreachable
code because ANGLE_MTL_EVENT_AVAILABLE hasn't been defined. This is
available on macOS 10.14 and above, so should be enabled.

At the same time, it doesn't make sense to call the method that has
unreachable code, so guard against that in mtl_command_buffer.

  • src/libANGLE/renderer/metal/mtl_command_buffer.mm:

(rx::mtl::CommandBuffer::setPendingEvents):

  • src/libANGLE/renderer/metal/mtl_common.h: Define ANGLE_MTL_EVENT_AVAILABLE.
12:05 PM Changeset in webkit [274659] by Russell Epstein
  • 8 edits in trunk/Source

Versioning.

WebKit-7612.1.8

11:52 AM Changeset in webkit [274658] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS Debug wk2 ARM64 ] ASSERTION FAILED: !m_deletionHasBegun /Volumes/Data/worker/bigsur-debug/build/WebKitBuild/Debug/usr/local/include/wtf/ThreadSafeRefCounted.h(58) : void WTF::ThreadSafeRefCountedBase::ref() const
​https://bugs.webkit.org/show_bug.cgi?id=223462

Uneviewed test gardening.

  • platform/mac-wk2/TestExpectations: Updating test expectations to Pass Crash while test is being reviewed.
11:48 AM Changeset in webkit [274657] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Avoid heap allocations under AudioSampleDataSource::pullSamplesInternal()
​https://bugs.webkit.org/show_bug.cgi?id=223449

Reviewed by Jer Noble.

AudioSampleDataSource::pullSamplesInternal() was doing heap allocations on the audio thread,
just for logging purposes (RunLoop::dispatch() & Function constructor do heap allocations).
Drop this logging to address the issue, after clearing this with Jer Noble.

  • platform/audio/cocoa/AudioSampleDataSource.mm:

(WebCore::AudioSampleDataSource::pullSamplesInternal):

11:45 AM Changeset in webkit [274656] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r271348): Console: message source code location is not vertically aligned with containing function name
​https://bugs.webkit.org/show_bug.cgi?id=223288
<rdar://problem/75498577>

Reviewed by Devin Rousso.

WebKit inline-block behavior changed in r271348 to match the spec more closely.

  • UserInterface/Views/ConsoleMessageView.css:

(.console-message-location.call-frame > .title):
Explicitly set vertical-align to match the behavior prior r271348.

11:36 AM Changeset in webkit [274655] by Amir Mark Jr.
  • 2 edits in trunk/LayoutTests

[ MacOS Wk1 ] http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html is a flakey failure
​https://bugs.webkit.org/show_bug.cgi?id=222563

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
11:18 AM Changeset in webkit [274654] by Ryan Haddad
  • 2 edits in trunk/Source/ThirdParty/ANGLE

'MTLLanguageVersion1_0' is unavailable on Catalyst
​https://bugs.webkit.org/show_bug.cgi?id=223392

Patch by Kyle Piddington <Kyle Piddington> on 2021-03-18
Reviewed by Jon Lee.

Disable switch case in catalyst builds

  • src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp:

(GetOperatorString):

  • src/compiler/translator/TranslatorMetalDirect/ProgramPrelude.cpp:
  • src/libANGLE/renderer/metal/FrameBufferMtl.mm:

(rx::FramebufferMtl::readPixels):

  • src/libANGLE/renderer/metal/mtl_utils.mm:

(rx::mtl::GetUserSetOrHighestMSLVersion):

11:17 AM Changeset in webkit [274653] by Wenson Hsieh
  • 3 edits in trunk/Source/WebKit

[iOS] editing/selection/character-granularity-rect.html fails on certain internal configurations after r274610
​https://bugs.webkit.org/show_bug.cgi?id=223447

Reviewed by Devin Rousso.

On versions of iOS where ENABLE(IMAGE_EXTRACTION) is defined but the system feature is disabled, this test
began failing after r274610. This is because the new image extraction deferral gesture now blocks text
interaction gestures, but the code to actually fail this deferring gesture (and thus, "lift" the deferring
gesture gate) is still behind the system flag. As a result, text interactions when the image extraction flag is
disabled will only begin after the touch ends.

This means that when selecting text via a long press, the text selection doesn't appear until lifting the touch
if image extraction is disabled. To fix this, we only enable this deferring gesture in the case where the system
feature is enabled.

  • UIProcess/ios/GestureRecognizerConsistencyEnforcer.mm:

(WebKit::GestureRecognizerConsistencyEnforcer::timerFired):

Additionally tweak the GestureRecognizerConsistencyEnforcer to only forcibly reset lingering unlifted gesture
recognizers if they are enabled.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setUpInteraction]):

11:14 AM Changeset in webkit [274652] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit

Don't delay conditional requests in resource load scheduler
​https://bugs.webkit.org/show_bug.cgi?id=223450

Reviewed by Geoffrey Garen.

  • NetworkProcess/NetworkLoadScheduler.cpp:

(WebKit::NetworkLoadScheduler::HostContext::schedule):

Conditional requests usually come back as 304s and don't slow other resource loads down.

11:11 AM Changeset in webkit [274651] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS wk2 ARM 64 ] storage/indexeddb/IDBObject-leak.html is a flakey text failure
​https://bugs.webkit.org/show_bug.cgi?id=223453

Uneviewed test gardeing.

  • platform/mac-wk2/TestExpectations: Updating test expectations to Pass Failure while test is being reviewed.
10:51 AM Changeset in webkit [274650] by Chris Dumez
  • 7 edits in trunk/Source/WebCore

Avoid heap allocation under PannerNode::pullInputs()
​https://bugs.webkit.org/show_bug.cgi?id=223445

Reviewed by Darin Adler.

PannerNode::pullInputs() was doing a heap allocation on the audio thread when
constructing a HashSet. It turns out that PannerNode::pullInputs() and
PannerNode::notifyAudioSourcesConnectedToNode() were not needed at all in
the modern PannerNode. They were only used to set the PannerNode on
AudioBufferSourceNodes so they could use its dopplerRate. However, the
dopplerRate was only a thing on the legacy WebKitAudioPannerNode. For the
modern PannerNode, there is no dopplerRate so we always end up using 1.0.

To address the issue, I thus completely removed PannerNode's pullInputs &
notifyAudioSourcesConnectedToNode(). I also updated AudioBufferSourceNode
to make it clear it uses a WebKitAudioPannerNode. Finally, I got rid of
the PannerNodeBase base class too since it is no longer needed.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::totalPitchRate):
(WebCore::AudioBufferSourceNode::setPannerNode):
(WebCore::AudioBufferSourceNode::clearPannerNode):
(WebCore::AudioBufferSourceNode::finish):

  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):

  • Modules/webaudio/PannerNode.h:
  • Modules/webaudio/WebKitAudioPannerNode.cpp:

(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):

  • Modules/webaudio/WebKitAudioPannerNode.h:
10:25 AM Changeset in webkit [274649] by Robert Jenner
  • 2 edits in trunk/LayoutTests

REGRESSION (r272842): [ BigSur Wk2 ] imported/w3c/web-platform-tests/media-source/mediasource-seekable.html is a flakey text failure
​https://bugs.webkit.org/show_bug.cgi?id=221965

Unreviewed test gardeing.

  • platform/mac-wk2/TestExpectations: Removing test expectation, as it appears that the test has been fixed.
9:49 AM Changeset in webkit [274648] by Truitt Savell
  • 25 edits
    6 deletes in trunk

Unreviewed, reverting r274644.

Broke internal Mac Builds

Reverted changeset:

"Implement WebXR Opaque Framebuffer"
​https://bugs.webkit.org/show_bug.cgi?id=222607
​https://commits.webkit.org/r274644

8:50 AM Changeset in webkit [274647] by Alexey Shvayka
  • 12 edits in trunk/Source/WebCore

[WebIDL] Don't generate setters for global constructor properties
​https://bugs.webkit.org/show_bug.cgi?id=222984

Reviewed by Alex Christensen.

r268710 fixed %Interface%.prototype.constructor to respect Set? receiver, yet
global constructor properties like window.HTMLElement are exposed to the same bug.

The reason why Object.create(window).HTMLElement = X performs correctly is that
JSObject::putInlineSlow() doesn't invoke JSProxy::put(), nor any other Set?
override, during prototype chain traversal. That is being fixed in #217916.

To avoid regressing on the above snippet, this change applies the similiar fix as
in r268710 to global constructor properties: a setter-less CustomValue that is
treated as data descriptor [1] by Set?.

Apart from altered receiver case, a patch for #217916 will also fix Enumerable?
property attribute to be preserved when original CustomValue property is replaced.

This change reduces WebCore --release binary size by 0.68% (548 KB).

Also, as a drive-by fix, utilizes IsDOMGlobalObject to simplify constructor getters
for all JSDOMGlobalObject subclasses.

No new tests, no behavior change.

[1] ​https://tc39.es/ecma262/#sec-ordinarysetwithowndescriptor (step 3.e.ii)

  • bindings/scripts/CodeGeneratorJS.pm:

(GetAttributeSetterName):
(GeneratePropertiesHashTable):
(GenerateImplementation):
(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):
(GenerateAttributeSetterDefinition):

  • bindings/scripts/test/JS/*: Updated.
8:43 AM Changeset in webkit [274646] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Use double division
​https://bugs.webkit.org/show_bug.cgi?id=223366

Patch by Rob Buis <​rbuis@igalia.com> on 2021-03-18
Reviewed by Zalan Bujtas.

Source/WebCore:

Use double instead of LayoutUnit division since
LayoutUnit resolution is not high enough to support
near-zero values.

Test: fast/css/aspect-ratio-division-crash.html

  • rendering/RenderBox.cpp:

(WebCore::inlineSizeFromAspectRatio):

  • rendering/RenderBox.h:

(WebCore::RenderBox::blockSizeFromAspectRatio):

LayoutTests:

Add test for this.

  • fast/css/aspect-ratio-division-crash-expected.txt: Added.
  • fast/css/aspect-ratio-division-crash.html: Added.
7:44 AM Changeset in webkit [274645] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

Nullptr crash in RenderStyle::shapeOutside()
​https://bugs.webkit.org/show_bug.cgi?id=221382

Patch by Frédéric Wang <​fwang@igalia.com> on 2021-03-18
Reviewed by Zalan Bujtas.

Source/WebCore:

Before bug 223041, it was possible to get dangling WeakPtr m_renderer on FloatingObject. This
patch adds debug ASSERT and more regression tests.

Tests: fast/block/float/float-pseudo-element-not-removed-crash.html

fast/block/float/float-pseudo-element-not-removed-2-crash.html

  • rendering/FloatingObjects.h: add nullcheck ASSERT for debug builds.

LayoutTests:

Add regression tests.

  • fast/block/float/float-pseudo-element-not-removed-crash-expected.txt: Added.
  • fast/block/float/float-pseudo-element-not-removed-crash.html: Added.
  • fast/block/float/float-pseudo-element-not-removed-crash2-expected.txt: Added.
  • fast/block/float/float-pseudo-element-not-removed-crash2.html: Added.
6:59 AM Changeset in webkit [274644] by imanol
  • 25 edits
    6 adds in trunk

Implement WebXR Opaque Framebuffer
​https://bugs.webkit.org/show_bug.cgi?id=222607

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Update WebXR Opaque Framebuffer test expectations.

  • web-platform-tests/webxr/xrWebGLLayer_framebuffer_draw.https-expected.txt: Added.
  • web-platform-tests/webxr/xrWebGLLayer_opaque_framebuffer.https-expected.txt: Added.

Source/WebCore:

This patch adds a base XR layers API which is initially used by WebXRWebGLLayer, but
with the goal of supporting more types of layers in the future (see WebXR Layers spec).

Layers are connected to WebGL by using shared textures. In the case of WebXRWebGLLayer
it creates an Opaque Framebuffer that renders to the shared texture. XR runtimes supporting
double or triple buffering can send different shared textures each frame in the FrameData struct.
The texture for the current frame is attached in WebXRLayer::startFrame and prepared to send it back to the
VR compositor in WebXRLayer::endFrame().

Tested by the WebXR WPT tests.

  • Modules/webxr/WebXRLayer.h: add startFrame and endFrame pure virtual methods.
  • Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::onFrame): do not call RAFs if frameData.shouldRender is false.

  • Modules/webxr/WebXRSession.h: add device getter.
  • Modules/webxr/WebXRSystem.cpp:

(WebCore::WebXRSystem::DummyInlineDevice::requestFrame): always enable frameData.shouldRender flag.

  • Modules/webxr/WebXRSystem.h: Override new virtual functions.
  • Modules/webxr/WebXRViewport.h:

(WebCore::WebXRViewport::rect const): Add helper method.

  • Modules/webxr/WebXRWebGLLayer.cpp: Refactor resource initialization to create method.

(WebCore::WebXRWebGLLayer::create):
(WebCore::WebXRWebGLLayer::WebXRWebGLLayer):
(WebCore::m_isCompositionEnabled):
(WebCore::WebXRWebGLLayer::framebuffer const):
(WebCore::WebXRWebGLLayer::framebufferWidth const):
(WebCore::WebXRWebGLLayer::framebufferHeight const):
(WebCore::WebXRWebGLLayer::startFrame): Prepare Opaque Framebuffer for the start of next frame.
(WebCore::WebXRWebGLLayer::endFrame): Prepare Opaque Framebuffer for VR compositor submitFrame.
(WebCore::WebXRWebGLLayer::canvasResized): Move method

(WebCore::WebXROpaqueFramebuffer::create): Implement class to manage WebXR Opaque framebuffer.
(WebCore::WebXROpaqueFramebuffer::WebXROpaqueFramebuffer):
(WebCore::WebXROpaqueFramebuffer::~WebXROpaqueFramebuffer):
(WebCore::WebXROpaqueFramebuffer::startFrame): Attach shared texture for the current frame.
(WebCore::WebXROpaqueFramebuffer::endFrame): Flush and resolve multisampling if required.
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer): Allocate the Opaque framebuffer with requested attributes.

  • Modules/webxr/WebXRWebGLLayer.h: Add WebXROpaqueFramebuffer and handle members.

(WebCore::WebXROpaqueFramebuffer::handle const):
(WebCore::WebXROpaqueFramebuffer::framebuffer const):
(WebCore::WebXROpaqueFramebuffer::width const):
(WebCore::WebXROpaqueFramebuffer::height const):

  • Sources.txt: Add OpenXRLayer.cpp and OpenXRSwapchain.cpp.
  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getFramebufferAttachmentParameter): handle Opaque Framebuffers.

  • html/canvas/WebGLFramebuffer.cpp: Add members and methods required for Opaque Framebuffers.

(WebCore::WebGLFramebuffer::createOpaque):
(WebCore::WebGLFramebuffer::checkStatus const):

  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): handle Opaque Framebuffers.

  • html/canvas/WebGLRenderingContextBase.cpp: handle Opaque Framebuffers.

(WebCore::WebGLRenderingContextBase::deleteFramebuffer):
(WebCore::WebGLRenderingContextBase::framebufferRenderbuffer):
(WebCore::WebGLRenderingContextBase::framebufferTexture2D):

  • platform/xr/PlatformXR.h: Add method to submitFrame.

(PlatformXR::Device::submitFrame):

  • platform/xr/openxr/OpenXRLayer.cpp: Add class to manage OpenXR layers.

(PlatformXR::OpenXRLayer::OpenXRLayer):
(PlatformXR::OpenXRLayerProjection::create):
(PlatformXR::OpenXRLayerProjection::OpenXRLayerProjection):
(PlatformXR::OpenXRLayerProjection::startFrame):

  • platform/xr/openxr/OpenXRLayer.h: Added.

(PlatformXR::OpenXRLayer::handle):

  • platform/xr/openxr/OpenXRSwapchain.cpp: Add class to manage OpenXR swapchains

(PlatformXR::OpenXRSwapchain::create):
(PlatformXR::OpenXRSwapchain::OpenXRSwapchain):
(PlatformXR::OpenXRSwapchain::~OpenXRSwapchain):
(PlatformXR::OpenXRSwapchain::acquireImage):
(PlatformXR::OpenXRSwapchain::releaseImage):

  • platform/xr/openxr/OpenXRSwapchain.h: Added.
  • platform/xr/openxr/OpenXRUtils.h: Add helper log function

(PlatformXR::xrViewToPose): Use fabs instead of negation

  • platform/xr/openxr/PlatformXROpenXR.cpp:

(PlatformXR::OpenXRDevice::initializeTrackingAndRendering): create GraphicsContextGL for texture sharing.
(PlatformXR::OpenXRDevice::requestFrame): Prepare and fill layers if shouldRender is true.
(PlatformXR::OpenXRDevice::submitFrame): Implement submit layers to OpenXR
(PlatformXR::OpenXRDevice::createLayerProjection): Implement layer creation method
(PlatformXR::OpenXRDevice::deleteLayer): Implement layer deallocation
(PlatformXR::OpenXRDevice::collectEnabledFeatures const):
(PlatformXR::OpenXRDevice::resetSession): Deallocate layers and graphics context.

  • platform/xr/openxr/PlatformXROpenXR.h: Add Layers API
  • testing/WebFakeXRDevice.cpp:

(WebCore::SimulatedXRDevice::recommendedResolution): Increase size to avoid platform minimum FBO size errors
(WebCore::SimulatedXRDevice::initializeTrackingAndRendering): Create graphics context
(WebCore::SimulatedXRDevice::shutDownTrackingAndRendering): Release graphics context
(WebCore::SimulatedXRDevice::frameTimerFired): set up layers in frame data
(WebCore::SimulatedXRDevice::createLayerProjection): creates a texture for a layer.
(WebCore::SimulatedXRDevice::deleteLayer): releases the associated texture to a layer

  • testing/WebFakeXRDevice.h:

LayoutTests:

Update WebXR Opaque Framebuffer test expectations.

  • platform/wpe/TestExpectations:
5:43 AM Changeset in webkit [274643] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.30.6

WebKitGTK 2.30.6

5:43 AM Changeset in webkit [274642] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.30

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.30.6 release

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

  • gtk/NEWS: Add release notes for 2.30.6.
5:07 AM Changeset in webkit [274641] by Carlos Garcia Campos
  • 11 edits in trunk

[WPE] Bump API version when building with libsoup3
​https://bugs.webkit.org/show_bug.cgi?id=223437

Reviewed by Adrian Perez de Castro.

.:

Use 1.1 as the API version when building with soup3.

  • Source/PlatformWPE.cmake:
  • Source/cmake/OptionsWPE.cmake:

Source/WebKit:

  • PlatformWPE.cmake: Use WPE_API_DOC_VERSION instead of WPE_API_VERSION for gtkdoc config files.
  • wpe/wpe-web-extension-uninstalled.pc.in: Add variable for libsoup version.
  • wpe/wpe-web-extension.pc.in: Ditto.
  • wpe/wpe-webkit-uninstalled.pc.in: Ditto.
  • wpe/wpe-webkit.pc.in: Ditto.

Tools:

Use WPE_API_DOC_VERSION instead of WPE_API_VERSION.

  • wpe/manifest.txt.in:
4:15 AM WebKitGTK/2.32.x edited by berto@igalia.com
(diff)
4:13 AM WebKitGTK/2.30.x edited by Carlos Garcia Campos
(diff)
4:12 AM Changeset in webkit [274640] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[SOUP] SOUP3 crashes inside soup_message_set_request_body
​https://bugs.webkit.org/show_bug.cgi?id=223236

Reviewed by Adrian Perez de Castro.

Make WebKitFormDataInputStream implement GPollableInputStream.

  • platform/network/soup/WebKitFormDataInputStream.cpp:

(webkitFormDataInputStreamNew):
(webkitFormDataInputStreamCanPoll):
(webkitFormDataInputStreamIsReadable):
(webkitFormDataInputStreamCreateSource):
(webkitFormDataInputStreamPollableInterfaceInit):

4:09 AM Changeset in webkit [274639] by Lauro Moura
  • 2 edits in trunk/Source/WebCore

[Nicosia] Backport cocoa fix for RTL sticky position from r273982
​https://bugs.webkit.org/show_bug.cgi?id=223395

Reviewed by Adrian Perez de Castro.

Fixes fast/css/sticky/sticky-in-rtl-overflow.html for WPE.

  • page/scrolling/nicosia/ScrollingTreeStickyNode.cpp:

(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):

4:04 AM Changeset in webkit [274638] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.30/Source/JavaScriptCore

Merge r271544 - [JSC] Clean up DFGPreciseLocalClobberize to avoid duplicate code
​https://bugs.webkit.org/show_bug.cgi?id=220670

Reviewed by Filip Pizlo.

This patch cleans up DFGPreciseLocalClobberize by extracting code to lambda to remove duplicate code.

  • dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

4:04 AM Changeset in webkit [274637] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.30/Source/JavaScriptCore

Merge r271144 - propertyNameEnumerator must check it can still take the fast path after getGenericPropertyNames
​https://bugs.webkit.org/show_bug.cgi?id=219957
<rdar://71156284>

Reviewed by Yusuke Suzuki.

We need to check if we still canAccessPropertiesQuicklyForEnumeration on
structureAfterGettingPropertyNames, since we might call out out to a proxy's
getPrototypeOf callback through getGenericPropertyNames.

  • runtime/JSPropertyNameEnumerator.h:

(JSC::propertyNameEnumerator):

4:04 AM Changeset in webkit [274636] by Carlos Garcia Campos
  • 5 edits
    3 adds in releases/WebKitGTK/webkit-2.30

Merge r270373 - iframe with sandbox=allow-top-navigation-by-user-activation can navigate top frame when the user interacts with an iframe from another origin
​https://bugs.webkit.org/show_bug.cgi?id=219413
<rdar://problem/64887657>

Reviewed by Geoffrey Garen.

Source/WebCore:

An iframe with sandbox=allow-top-navigation-by-user-activation can navigate the top frame when the user
interacts with an frame from another origin. This is not strict enough and does not match the behavior of
Chrome.

In Chrome, the user activation is only valid for the purpose of navigation if the user interacted with either:

  • The iframe triggering the navigation
  • A descendant iframe of the iframe triggering the navigation
  • A frame from the same origin as the iframe triggering the navigation

This patch aligns our behavior with Chrome's.

Test: http/tests/security/block-top-level-navigations-by-sandboxed-iframe-with-propagated-user-gesture.html

  • dom/Document.cpp:

(WebCore::Document::canNavigateInternal):

  • dom/UserGestureIndicator.cpp:

(WebCore::UserGestureToken::UserGestureToken):
(WebCore::UserGestureToken::isValidForDocument const):
(WebCore::UserGestureIndicator::processingUserGesture):

  • dom/UserGestureIndicator.h:

(WebCore::UserGestureToken::create):

LayoutTests:

Add layout test coverage.

  • http/tests/security/block-top-level-navigations-by-sandboxed-iframe-with-propagated-user-gesture-expected.txt: Added.
  • http/tests/security/block-top-level-navigations-by-sandboxed-iframe-with-propagated-user-gesture.html: Added.
  • http/tests/security/resources/navigate-top-level-frame-to-failure-page-via-message-handler.html: Added.
4:04 AM Changeset in webkit [274635] by Carlos Garcia Campos
  • 3 edits
    3 adds in releases/WebKitGTK/webkit-2.30

Merge r270367 - Block suspicious top level navigations by iframes even if sandbox=allow-top-navigation is specified
​https://bugs.webkit.org/show_bug.cgi?id=219408
<rdar://problem/71049726>

Reviewed by Geoffrey Garen.

Source/WebCore:

Block suspicious top level navigations by iframes even if sandbox=allow-top-navigation is specified,
when the parent of the sandboxed iframe is not first-party.

Test: http/tests/security/block-top-level-navigations-by-third-party-sandboxed-iframe.html

  • dom/Document.cpp:

(WebCore::Document::isNavigationBlockedByThirdPartyIFrameRedirectBlocking):

LayoutTests:

Add layout test coverage.

  • http/tests/security/block-top-level-navigations-by-third-party-sandboxed-iframe-expected.txt: Added.
  • http/tests/security/block-top-level-navigations-by-third-party-sandboxed-iframe.html: Added.
  • http/tests/security/resources/navigate-top-level-frame-to-failure-page-via-sandboxed-iframe.html: Added.
4:04 AM Changeset in webkit [274634] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.30

Merge r270321 - Update list of block ports according fetch spec
​https://bugs.webkit.org/show_bug.cgi?id=219154

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/request/request-bad-port.any-expected.txt:
  • web-platform-tests/fetch/api/request/request-bad-port.any.js:
  • web-platform-tests/fetch/api/request/request-bad-port.any.worker-expected.txt:
  • web-platform-tests/websockets/Create-blocked-port.any-expected.txt:
  • web-platform-tests/websockets/Create-blocked-port.any.js:
  • web-platform-tests/websockets/Create-blocked-port.any.worker-expected.txt:

Source/WTF:

  • wtf/URL.cpp:

(WTF::portAllowed):

4:04 AM Changeset in webkit [274633] by Carlos Garcia Campos
  • 16 edits
    3 adds in releases/WebKitGTK/webkit-2.30

Merge r270101 - Add support for RTCPeerConnection.onicecandidateerror event
​https://bugs.webkit.org/show_bug.cgi?id=169644

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/idlharness.https.window-expected.txt:

Source/WebCore:

Expose RTCPeerConnection.onicecandidateerror and use it for wrong STUN/TURN server URLs.
For that matter, add RTCPeerConnectionIceErrorEvent as per spec with a slight change to the init directory to keep the same terminology between event and init dictionary.

Covered by updated webrtc/stun-server-filtering.html test.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::iceServersFromConfiguration):
(WebCore::iceServersFromConfiguration): Deleted.

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCPeerConnectionIceErrorEvent.cpp: Added.

(WebCore::RTCPeerConnectionIceErrorEvent::create):
(WebCore::RTCPeerConnectionIceErrorEvent::RTCPeerConnectionIceErrorEvent):
(WebCore::RTCPeerConnectionIceErrorEvent::eventInterface const):

  • Modules/mediastream/RTCPeerConnectionIceErrorEvent.h: Added.
  • Modules/mediastream/RTCPeerConnectionIceErrorEvent.idl: Added.
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreBuiltinNames.h:
  • dom/EventNames.h:
  • dom/EventNames.in:

LayoutTests:

  • webrtc/rtcpeerconnection-error-messages-expected.txt:
  • webrtc/stun-server-filtering.html:
4:03 AM Changeset in webkit [274632] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore

Merge r267287 - Crash under WebCore::shouldResetFocusNavigationStartingNode()
​https://bugs.webkit.org/show_bug.cgi?id=216714
<rdar://problem/68132047>

Reviewed by Darin Adler.

Protect anchorElement in FrameView::scrollToFragmentInternal() to make sure
it stays alive until the time we pass it to setFocusNavigationStartingNode().

  • page/FrameView.cpp:

(WebCore::FrameView::scrollToFragmentInternal):

4:03 AM Changeset in webkit [274631] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.30

Merge r266798 - Make sure WKWebsiteDataStore operations reuse existing process pools even when all WKWebViews have closed.
<rdar://problem/62978295> and ​https://bugs.webkit.org/show_bug.cgi?id=216317

Reviewed by Geoffrey Garen.

Source/WebKit:

Covered by new API test.

When WebsiteDataStores are gathering all the NetworkProcesses they might need to message, they miss some
obvious candidates if there are no longer any related WKWebViews.

Fix that by tracking which sessions a NetworkProcess knows about.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::addSession):
(WebKit::NetworkProcessProxy::hasSession const):
(WebKit::NetworkProcessProxy::removeSession):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::isAssociatedProcessPool const):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:

(TestWebKitAPI::TEST):

3:10 AM Changeset in webkit [274630] by svillar@igalia.com
  • 2 edits in trunk/Source/WebCore

Invalidate RenderTreePosition's next sibling with display:contents
​https://bugs.webkit.org/show_bug.cgi?id=218578

Reviewed by Antti Koivisto.

When inserting elements in the tree from JS it might happen that the renderTreePosition() in the RenderTreeUpdater
caches a nextSibling() value which is only temporarily correct because we sequentially process the descendants of a
given root node in RenderTreeUpdater::updateRenderTree(). One of those potentially incorrect scenarios is when
using display:contents. We can detect those cases because we would leave a parent element in RenderTreeUpdater::popParent()
without changing renderingParent() and so without changing renderTreePosition(). Once we are in that situation we
must invalidate the cached position so the next sibling is recomputed.

  • rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::popParent): Invalidate the render tree position's next sibling if the parent element is not
the renderingParent().

2:49 AM Changeset in webkit [274629] by Carlos Garcia Campos
  • 14 edits in releases/WebKitGTK/webkit-2.30/Source

Merge r265623 - REGRESSION (r260684): Messages YouTube inline video: after Multitasking away and Back, Audio is heard but icon indicates "muted"
​https://bugs.webkit.org/show_bug.cgi?id=215453
<rdar://problem/66136673>

Reviewed by Tim Horton.

Source/WebCore:

r260684 silenced all JS events during the snapshot sequence that occurs whenever the user homes out of Safari.
This was meant to address compatibility with websites that did not expect various resize/orientationchange
events when homing out. However, the snapshot sequence is fairly long and this was causing us to silence JS
events which have nothing to do with the snapshot sequence, like window.postMessage()'s message events. This is
what caused this regression.

To address the issue, this patch basically reverts r260684 and deals with websites-compatibility issues via
less risky site-specific and event-specific quirks:

  • We silence Window resize events on nytimes.com to address <rdar://problem/59763843>.
  • We silence Window resize events and MediaQueryList change events on twitter.com to address <rdar://problem/58804852> and <rdar://problem/61731801>.
  • css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::evaluateAll):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::fireEventListeners):

  • page/FrameView.cpp:

(WebCore::FrameView::sendResizeEventIfNeeded):

  • page/Page.h:

(WebCore::Page::isTakingSnapshotsForApplicationSuspension const):
(WebCore::Page::setIsTakingSnapshotsForApplicationSuspension):
(WebCore::Page::shouldFireEvents const): Deleted.
(WebCore::Page::setShouldFireEvents): Deleted.

  • page/Quirks.cpp:

(WebCore::Quirks::shouldSilenceWindowResizeEvents const):
(WebCore::Quirks::shouldSilenceMediaQueryListChangeEvents const):

  • page/Quirks.h:

Source/WebKit:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setIsDoingSnapshotSequence):
(WebKit::WebPageProxy::setShouldFireEvents): Deleted.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKApplicationStateTrackingView.mm:

(-[WKApplicationStateTrackingView _willBeginSnapshotSequence]):
(-[WKApplicationStateTrackingView _didCompleteSnapshotSequence]):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setIsDoingSnapshotSequence):
(WebKit::WebPage::setShouldFireEvents): Deleted.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
2:49 AM Changeset in webkit [274628] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.30

Merge r272921 - [GTK] Need new user agent quirk for Google Docs and Google Drive
​https://bugs.webkit.org/show_bug.cgi?id=221845

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-02-16
Reviewed by Adrian Perez de Castro.

Source/WebCore:

Switch Google Docs to use a Chrome browser quirk instead of an Internet Explorer quirk.
Remove the Google Drive quirk altogether. Remove the Internet Explorer and Windows platform
quirks, which are no longer used. Retarget the Google Docs quirk to apply only to
docs.google.com because we no longer need to send the quirk to accounts.youtube.com for it
to be effective. Lastly, update Chrome and Firefox version strings for good measure.

  • platform/UserAgentQuirks.cpp:

(WebCore::urlRequiresChromeBrowser):
(WebCore::urlRequiresLinuxDesktopPlatform):
(WebCore::UserAgentQuirks::quirksForURL):
(WebCore::UserAgentQuirks::stringForQuirk):
(WebCore::urlRequiresInternetExplorerBrowser): Deleted.
(WebCore::urlRequiresWindowsPlatform): Deleted.

  • platform/glib/UserAgentGLib.cpp:

(WebCore::buildUserAgentString):

Tools:

  • TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
(TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
(TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
(TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
(TestWebKitAPI::TEST):
(TestWebKitAPI::assertUserAgentForURLHasInternetExplorerBrowserQuirk): Deleted.
(TestWebKitAPI::assertUserAgentForURLHasWindowsPlatformQuirk): Deleted.

2:29 AM Changeset in webkit [274627] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Pagination mode: Increase the amount of recursions allowed by RenderTable::layout()
​https://bugs.webkit.org/show_bug.cgi?id=218575

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2021-03-18
Reviewed by Zalan Bujtas.

In r219394 a recursion check was introduced to avoid infinite recursion when a section is always moved on
RenderTable::layout(). But sometimes it's needed to recurse more than once to layout the table when section move
due to the pagination. This patch limits the recursion level to the amount of sections in the table, instead of
just one.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTable.h:
2:18 AM Changeset in webkit [274626] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

ASSERTION FAILED: node.isConnected() in matchSlottedPseudoElementRules
​https://bugs.webkit.org/show_bug.cgi?id=221440

Patch by Frédéric Wang <​fwang@igalia.com> on 2021-03-18
Reviewed by Ryosuke Niwa.

ReplaceSelectionCommand::doApply() removes a <br> from an element and immediately calls
highestNodeToRemoveInPruning() on that element. The former operation may destroy the
element's renderer and confuses the latter operation. This happens in particular for a
<summary> element which ends up being removed from the tree. This in turn causes unexpected
issues such as a debug assertion failure in matchSlottedPseudoElementRules. To address that
problem, ensure the document is laid out before calling highestNodeToRemoveInPruning().
This patch also increases and improves use of RefPtr<Node>.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Use auto & makeRefPtr.
(WebCore::CompositeEditCommand::prune): Store local highestNodeToRemove variable in a RefPtr.
(WebCore::CompositeEditCommand::cleanupAfterDeletion): Store local node variable in a RefPtr.
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Store local parentNode variable in a RefPtr.

  • editing/Editing.cpp:

(WebCore::highestNodeToRemoveInPruning): Store local currentNode variable in a a RefPtr.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): Use auto & makeRefPtr. Store local odeToRemove variable in a RefPtr.
Ensure the document is laid out before calling highestNodeToRemoveInPruning.

2:11 AM Changeset in webkit [274625] by Devin Rousso
  • 2 edits in trunk/Source/WebCore

should always use all prerequisites for the ModernMediaControls.{js,css} rules in DerivedSources.make
​https://bugs.webkit.org/show_bug.cgi?id=223421

Reviewed by Yusuke Suzuki.

  • DerivedSources.make:

$? is a uniqued space-separated list of all prerequisites modified after the target was modified.
$^ is a uniqued space-separated list of all prerequisites regardless of when the target/prerequisite was modified.
We want to use the latter since we always want to cat all the JS/CSS files, not just the recently edited ones.

2:10 AM Changeset in webkit [274624] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK][l10n] Updated Polish translation of WebKitGTK for 2.32
​https://bugs.webkit.org/show_bug.cgi?id=223149

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2021-03-18
Rubber-stamped by Carlos Garcia Campos.

  • pl.po:
1:42 AM Changeset in webkit [274623] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

RTCRtpScriptTransformer::writable should check for m_backend
​https://bugs.webkit.org/show_bug.cgi?id=223373

Reviewed by Eric Carlson.

Covered by existing tests.

  • Modules/mediastream/RTCRtpScriptTransformer.cpp:

(WebCore::RTCRtpScriptTransformer::writable):
The writer can only start writing after readable is started, which means m_backend is set.
But the transformer may be cleared at which point m_backend is nullified but there might be some encoded frames in the pipe to be written.
Add a null check to fix this.

1:25 AM Changeset in webkit [274622] by youenn@apple.com
  • 9 edits in trunk

Geolocation API does not work in WKWebView with custom URL scheme handler
​https://bugs.webkit.org/show_bug.cgi?id=222861
Source/WebCore:

<rdar://problem/75394695>

Reviewed by Eric Carlson.

Covered by API tests.

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::shouldBlockGeolocationRequests):
Use Document::isSecureContext to validate whether the document is secure.
This is consistent with other APIs.

Source/WebKit:

<rdar://problem/75394695>

Reviewed by Eric Carlson.

Update geolocation prompt origin to match getUserMedia and show the app name instead of custom scheme origin.

  • UIProcess/Cocoa/MediaPermissionUtilities.mm:

(WebKit::alertMessageText):

Tools:

<rdar://problem/75394695>

Reviewed by Eric Carlson.

  • TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[GeolocationDelegate setValidationHandler:]):
(-[GeolocationDelegate _webView:requestGeolocationPermissionForFrame:decisionHandler:]):
(TEST):

LayoutTests:

Reviewed by Eric Carlson.

Validated that behavior is consistent with Chrome and Firefox.

  • http/tests/security/resources/geolocation-over-insecure-content.html:

Use internals API to mimick insecure context.

1:08 AM Changeset in webkit [274621] by youenn@apple.com
  • 3 edits in trunk/Source/WTF

Move camera GPU Process flag to experimental
​https://bugs.webkit.org/show_bug.cgi?id=223374

Reviewed by Eric Carlson.

  • Scripts/Preferences/WebPreferencesExperimental.yaml:
  • Scripts/Preferences/WebPreferencesInternal.yaml:
12:44 AM Changeset in webkit [274620] by cathiechen
  • 6 edits
    673 adds in trunk/LayoutTests

Import css/css-contain test from WPT
​https://bugs.webkit.org/show_bug.cgi?id=223254

Reviewed by Rob Buis.

LayoutTests/imported/w3c:

Import web-platform-tests/css/css-contain from upstream 868fe4c01aef5e27fedc51ea7d938cf556cffec2.

  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/css/css-contain/META.yml: Added.
  • web-platform-tests/css/css-contain/contain-animation-001-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-animation-001.html: Added.
  • web-platform-tests/css/css-contain/contain-chrome-thcrash-001-expected.txt: Added.
  • web-platform-tests/css/css-contain/contain-chrome-thcrash-001.html: Added.
  • web-platform-tests/css/css-contain/contain-content-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-content-001.html: Added.
  • web-platform-tests/css/css-contain/contain-content-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-content-002.html: Added.
  • web-platform-tests/css/css-contain/contain-content-003-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-content-003.html: Added.
  • web-platform-tests/css/css-contain/contain-content-004-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-content-004.html: Added.
  • web-platform-tests/css/css-contain/contain-content-011-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-content-011.html: Added.
  • web-platform-tests/css/css-contain/contain-crash.html: Added.
  • web-platform-tests/css/css-contain/contain-flexbox-outline-expected.txt: Added.
  • web-platform-tests/css/css-contain/contain-flexbox-outline.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-002-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-002.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-003-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-003.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-004-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-004.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-005-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-005.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-006-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-006.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-007-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-007.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-009-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-009.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-010-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-010.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-011-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-011.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-012-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-012.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-013-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-013.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-014-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-014.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-016-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-016.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-017-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-017.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-018-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-018.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-baseline-001-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-baseline-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-baseline-002-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-baseline-002.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-baseline-003-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-layout-baseline-003.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-baseline-004-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-baseline-004.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-baseline-005-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-baseline-005.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-breaks-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-breaks-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-breaks-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-breaks-002.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-button-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-button-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-cell-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-cell-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-cell-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-cell-002.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-containing-block-absolute-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-containing-block-absolute-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-containing-block-fixed-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-containing-block-fixed-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-flexbox-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-flexbox-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-formatting-context-float-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-formatting-context-float-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-formatting-context-margin-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-formatting-context-margin-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-grid-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-grid-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ifc-022-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ifc-022.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ignored-cases-ib-split-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ignored-cases-ib-split-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ignored-cases-no-principal-box-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ignored-cases-no-principal-box-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ignored-cases-no-principal-box-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ignored-cases-no-principal-box-002.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ignored-cases-no-principal-box-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ignored-cases-no-principal-box-003.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-independent-formatting-context-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-independent-formatting-context-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-independent-formatting-context-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-independent-formatting-context-002.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-independent-formatting-context-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-independent-formatting-context-003.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-013-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-013.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-014-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-014.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-015-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-015.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-016-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-016.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-017-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-017.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-018-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-018.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-019-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-019.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-020-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-ink-overflow-020.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-overflow-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-overflow-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-overflow-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-overflow-002.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-size-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-size-003.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-stacking-context-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-stacking-context-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-suppress-baseline-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-suppress-baseline-001.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-suppress-baseline-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-layout-suppress-baseline-002.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-002.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-004-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-004.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-005-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-005.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-006-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-006.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-007-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-007.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-008-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-008.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-009-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-paint-009.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-010-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-paint-010.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-011-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-paint-011.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-012-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-paint-012.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-014-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-014.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-015-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-015.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-016-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-016.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-017-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-017.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-018-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-018.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-019-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-019.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-020-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-020.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-021-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-021.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-022-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-022.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-023-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-paint-023.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-024-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-paint-024.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-025-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-025.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-047-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-047.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-048-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-paint-048.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-baseline-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-baseline-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-cell-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-cell-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-cell-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-cell-002.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-002.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-003.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-004-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-004.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-005-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-005.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-006-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-006.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-011-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-011.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-012-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-012.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-013-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-013.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-014-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-014.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-015-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-015.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-016-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-016.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-017-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-017.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-018-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-018.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-019-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-clip-019.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-containing-block-absolute-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-containing-block-absolute-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-containing-block-fixed-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-containing-block-fixed-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-formatting-context-float-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-formatting-context-float-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-formatting-context-margin-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-formatting-context-margin-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-ifc-011-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-ifc-011.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-ignored-cases-ib-split-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-ignored-cases-ib-split-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-ignored-cases-internal-table-001a-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-ignored-cases-internal-table-001a.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-ignored-cases-internal-table-001b-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-ignored-cases-internal-table-001b.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-ignored-cases-no-principal-box-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-ignored-cases-no-principal-box-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-ignored-cases-ruby-containing-block-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-ignored-cases-ruby-containing-block-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-ignored-cases-ruby-stacking-and-clipping-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-ignored-cases-ruby-stacking-and-clipping-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-independent-formatting-context-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-independent-formatting-context-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-independent-formatting-context-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-independent-formatting-context-002.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-independent-formatting-context-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-independent-formatting-context-003.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-size-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-size-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-size-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-size-002.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-size-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-size-003.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-stacking-context-001a-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-stacking-context-001a.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-stacking-context-001b-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-stacking-context-001b.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-table-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-table-001.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-table-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-paint-table-002.html: Added.
  • web-platform-tests/css/css-contain/contain-size-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-002.html: Added.
  • web-platform-tests/css/css-contain/contain-size-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-003.html: Added.
  • web-platform-tests/css/css-contain/contain-size-004-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-004.html: Added.
  • web-platform-tests/css/css-contain/contain-size-005-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-005.html: Added.
  • web-platform-tests/css/css-contain/contain-size-006-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-006.html: Added.
  • web-platform-tests/css/css-contain/contain-size-007-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-007.html: Added.
  • web-platform-tests/css/css-contain/contain-size-008-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-008.html: Added.
  • web-platform-tests/css/css-contain/contain-size-009-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-009.html: Added.
  • web-platform-tests/css/css-contain/contain-size-010-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-010.html: Added.
  • web-platform-tests/css/css-contain/contain-size-011-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-011.html: Added.
  • web-platform-tests/css/css-contain/contain-size-012-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-012.html: Added.
  • web-platform-tests/css/css-contain/contain-size-012b-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-012b.html: Added.
  • web-platform-tests/css/css-contain/contain-size-013-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-size-013.html: Added.
  • web-platform-tests/css/css-contain/contain-size-021-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-021.html: Added.
  • web-platform-tests/css/css-contain/contain-size-023-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-023.html: Added.
  • web-platform-tests/css/css-contain/contain-size-025-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-025.html: Added.
  • web-platform-tests/css/css-contain/contain-size-027-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-027.html: Added.
  • web-platform-tests/css/css-contain/contain-size-041-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-041.html: Added.
  • web-platform-tests/css/css-contain/contain-size-042-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-042.html: Added.
  • web-platform-tests/css/css-contain/contain-size-051-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-051.html: Added.
  • web-platform-tests/css/css-contain/contain-size-052-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-052.html: Added.
  • web-platform-tests/css/css-contain/contain-size-056-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-056.html: Added.
  • web-platform-tests/css/css-contain/contain-size-061-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-061.html: Added.
  • web-platform-tests/css/css-contain/contain-size-062-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-062.html: Added.
  • web-platform-tests/css/css-contain/contain-size-063-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-063.html: Added.
  • web-platform-tests/css/css-contain/contain-size-064-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-064.html: Added.
  • web-platform-tests/css/css-contain/contain-size-baseline-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-baseline-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-block-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-block-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-block-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-block-002.html: Added.
  • web-platform-tests/css/css-contain/contain-size-block-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-block-003.html: Added.
  • web-platform-tests/css/css-contain/contain-size-block-004-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-block-004.html: Added.
  • web-platform-tests/css/css-contain/contain-size-borders-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-size-borders.html: Added.
  • web-platform-tests/css/css-contain/contain-size-breaks-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-breaks-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-button-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-button-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-button-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-button-002.html: Added.
  • web-platform-tests/css/css-contain/contain-size-fieldset-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-fieldset-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-fieldset-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-fieldset-002.html: Added.
  • web-platform-tests/css/css-contain/contain-size-fieldset-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-fieldset-003.html: Added.
  • web-platform-tests/css/css-contain/contain-size-fieldset-004-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-fieldset-004.html: Added.
  • web-platform-tests/css/css-contain/contain-size-flex-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-flex-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-flexbox-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-flexbox-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-flexbox-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-flexbox-002.html: Added.
  • web-platform-tests/css/css-contain/contain-size-grid-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-grid-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-grid-002-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-size-grid-002.html: Added.
  • web-platform-tests/css/css-contain/contain-size-grid-003-expected.txt: Added.
  • web-platform-tests/css/css-contain/contain-size-grid-003.html: Added.
  • web-platform-tests/css/css-contain/contain-size-grid-004-expected.txt: Added.
  • web-platform-tests/css/css-contain/contain-size-grid-004.html: Added.
  • web-platform-tests/css/css-contain/contain-size-grid-005-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-grid-005.html: Added.
  • web-platform-tests/css/css-contain/contain-size-inline-block-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-inline-block-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-inline-block-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-inline-block-002.html: Added.
  • web-platform-tests/css/css-contain/contain-size-inline-block-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-inline-block-003.html: Added.
  • web-platform-tests/css/css-contain/contain-size-inline-block-004-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-inline-block-004.html: Added.
  • web-platform-tests/css/css-contain/contain-size-inline-flex-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-inline-flex-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-monolithic-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-monolithic-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-monolithic-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-monolithic-002.html: Added.
  • web-platform-tests/css/css-contain/contain-size-multicol-001-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-size-multicol-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-multicol-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-multicol-002.html: Added.
  • web-platform-tests/css/css-contain/contain-size-multicol-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-multicol-003.html: Added.
  • web-platform-tests/css/css-contain/contain-size-multicol-004-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-multicol-004.html: Added.
  • web-platform-tests/css/css-contain/contain-size-multicol-as-flex-item-expected.txt: Added.
  • web-platform-tests/css/css-contain/contain-size-multicol-as-flex-item.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-001-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-002-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-002.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-003a-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-003a.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-003b-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-003b.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-003c-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-003c.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-004-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-004.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-005-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-005.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-006-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-006.html: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-007-expected.xht: Added.
  • web-platform-tests/css/css-contain/contain-size-replaced-007.html: Added.
  • web-platform-tests/css/css-contain/contain-size-scrollbars-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-scrollbars-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-scrollbars-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-scrollbars-002.html: Added.
  • web-platform-tests/css/css-contain/contain-size-scrollbars-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-scrollbars-003.html: Added.
  • web-platform-tests/css/css-contain/contain-size-scrollbars-004-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-scrollbars-004.html: Added.
  • web-platform-tests/css/css-contain/contain-size-select-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-select-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-select-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-select-002.html: Added.
  • web-platform-tests/css/css-contain/contain-size-select-elem-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-select-elem-001.html: Added.
  • web-platform-tests/css/css-contain/contain-size-select-elem-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-select-elem-002.html: Added.
  • web-platform-tests/css/css-contain/contain-size-select-elem-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-select-elem-003.html: Added.
  • web-platform-tests/css/css-contain/contain-size-select-elem-004-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-select-elem-004.html: Added.
  • web-platform-tests/css/css-contain/contain-size-select-elem-005-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-select-elem-005.html: Added.
  • web-platform-tests/css/css-contain/contain-size-table-caption-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-size-table-caption-001.html: Added.
  • web-platform-tests/css/css-contain/contain-strict-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-strict-001.html: Added.
  • web-platform-tests/css/css-contain/contain-strict-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-strict-002.html: Added.
  • web-platform-tests/css/css-contain/contain-strict-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-strict-003.html: Added.
  • web-platform-tests/css/css-contain/contain-strict-011-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-strict-011.html: Added.
  • web-platform-tests/css/css-contain/contain-style-baseline-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-style-baseline-001.html: Added.
  • web-platform-tests/css/css-contain/contain-style-breaks-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-style-breaks-001.html: Added.
  • web-platform-tests/css/css-contain/contain-style-breaks-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-style-breaks-002.html: Added.
  • web-platform-tests/css/css-contain/contain-style-breaks-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-style-breaks-003.html: Added.
  • web-platform-tests/css/css-contain/contain-style-breaks-004-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-style-breaks-004.html: Added.
  • web-platform-tests/css/css-contain/contain-style-breaks-005-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-style-breaks-005.html: Added.
  • web-platform-tests/css/css-contain/contain-style-counters-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-style-counters-001.html: Added.
  • web-platform-tests/css/css-contain/contain-style-counters-002-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-style-counters-002.html: Added.
  • web-platform-tests/css/css-contain/contain-style-counters-003-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-style-counters-003.html: Added.
  • web-platform-tests/css/css-contain/contain-style-counters-004-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-style-counters-004.html: Added.
  • web-platform-tests/css/css-contain/contain-subgrid-001-expected.html: Added.
  • web-platform-tests/css/css-contain/contain-subgrid-001.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-001-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-001.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-002-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-002.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-003-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-003.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-004-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-004.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-005-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-005.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-006-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-006.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-007-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-007.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-008-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-008.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-009-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-009.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-010-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-010.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-011-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-011.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-012-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-012.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-013-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-013.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-014-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-014.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-015-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-015.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-016-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-016.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-017-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-017.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-018-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-018.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-019.sub.https-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-019.sub.https.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-020-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-020.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-021-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-021.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-022-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-022.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-023-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-023.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-024-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-024.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-025-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-025.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-026-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-026.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-027-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-027.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-028-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-028.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-029-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-029.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-030-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-030.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-031-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-031.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-032-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-032.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-033.sub.https-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-033.sub.https.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-034-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-034.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-035-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-035.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-036-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-036.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-037-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-037.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-038-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-038.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-039-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-039.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-040-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-040.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-041-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-041.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-042-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-042.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-043-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-043.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-044-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-044.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-045-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-045.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-046-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-046.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-047-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-047.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-048-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-048.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-049-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-049.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-050-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-050.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-051-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-051.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-052-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-052.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-053-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-053.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-054-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-054.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-055-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-055.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-056-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-056.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-057-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-057.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-058-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-058.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-059-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-059.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-060-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-060.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-061-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-061.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-062-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-062.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-063-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-063.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-064-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-064.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-065-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-065.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-066-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-066.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-067-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-067.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-068-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-068.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-069-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-069.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-070-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-070.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-071-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-071.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-072-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-072.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-073-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-073.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-074-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-074.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-075-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-075.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-076-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-076.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-077-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-077.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-078-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-078.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-079-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-079.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-080-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-080.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-081-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-081.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-form-controls-crash.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/inheritance-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/inheritance.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/parsing/content-visibility-computed-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/parsing/content-visibility-computed.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/parsing/content-visibility-invalid-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/parsing/content-visibility-invalid.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/parsing/content-visibility-valid-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/parsing/content-visibility-valid.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/parsing/w3c-import.log: Added.
  • web-platform-tests/css/css-contain/content-visibility/resources/circles.svg: Added.
  • web-platform-tests/css/css-contain/content-visibility/resources/dice.png: Added.
  • web-platform-tests/css/css-contain/content-visibility/resources/frame.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/resources/text-fragment-target-auto.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/resources/w3c-import.log: Added.
  • web-platform-tests/css/css-contain/content-visibility/w3c-import.log: Added.
  • web-platform-tests/css/css-contain/counter-scoping-001-expected.html: Added.
  • web-platform-tests/css/css-contain/counter-scoping-001.html: Added.
  • web-platform-tests/css/css-contain/counter-scoping-002-expected.html: Added.
  • web-platform-tests/css/css-contain/counter-scoping-002.html: Added.
  • web-platform-tests/css/css-contain/counter-scoping-003-expected.html: Added.
  • web-platform-tests/css/css-contain/counter-scoping-003.html: Added.
  • web-platform-tests/css/css-contain/inheritance-expected.txt: Added.
  • web-platform-tests/css/css-contain/inheritance.html: Added.
  • web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt: Added.
  • web-platform-tests/css/css-contain/parsing/contain-computed.html: Added.
  • web-platform-tests/css/css-contain/parsing/contain-invalid-expected.txt: Added.
  • web-platform-tests/css/css-contain/parsing/contain-invalid.html: Added.
  • web-platform-tests/css/css-contain/parsing/contain-valid-expected.txt: Added.
  • web-platform-tests/css/css-contain/parsing/contain-valid.html: Added.
  • web-platform-tests/css/css-contain/parsing/w3c-import.log: Added.
  • web-platform-tests/css/css-contain/quote-scoping-001-expected.html: Added.
  • web-platform-tests/css/css-contain/quote-scoping-001.html: Added.
  • web-platform-tests/css/css-contain/quote-scoping-002-expected.html: Added.
  • web-platform-tests/css/css-contain/quote-scoping-002.html: Added.
  • web-platform-tests/css/css-contain/quote-scoping-003-expected.html: Added.
  • web-platform-tests/css/css-contain/quote-scoping-003.html: Added.
  • web-platform-tests/css/css-contain/quote-scoping-004-expected.html: Added.
  • web-platform-tests/css/css-contain/quote-scoping-004.html: Added.
  • web-platform-tests/css/css-contain/support/60x60-green.png: Added.
  • web-platform-tests/css/css-contain/support/blue-100x100.png: Added.
  • web-platform-tests/css/css-contain/support/blue50wBy25h.png: Added.
  • web-platform-tests/css/css-contain/support/blue50wBy46h.png: Added.
  • web-platform-tests/css/css-contain/support/pattern-gg-gr-100x100.png: Added.
  • web-platform-tests/css/css-contain/support/swatch-blue.png: Added.
  • web-platform-tests/css/css-contain/support/swatch-orange.png: Added.
  • web-platform-tests/css/css-contain/support/swatch-red.png: Added.
  • web-platform-tests/css/css-contain/support/swatch-yellow.png: Added.
  • web-platform-tests/css/css-contain/support/w3c-import.log: Added.
  • web-platform-tests/css/css-contain/support/white.webm: Added.
  • web-platform-tests/css/css-contain/w3c-import.log: Added.

LayoutTests:

12:32 AM Changeset in webkit [274619] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

WebGL conformance test update script does not use min_version and max_version in all cases
​https://bugs.webkit.org/show_bug.cgi?id=223376

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-03-18
Reviewed by Kenneth Russell.

Make the update script respect min_version and max_version when the version is specified
per test.

  • Scripts/webkitpy/update_webgl_conformance_tests_lib/main.py:

(_parse_webgl_tests):

12:21 AM Changeset in webkit [274618] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

[iOS] Web process sometimes crashes under WebPage::positionInformation() after r274031
​https://bugs.webkit.org/show_bug.cgi?id=223417
<rdar://problem/75540178>

Reviewed by Devin Rousso.

Add a null check to guard against the case where the hit-tested node is null, but the element responding to
click events exists.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::elementPositionInformation):

Mar 17, 2021:

11:06 PM Changeset in webkit [274617] by sbarati@apple.com
  • 2 edits in trunk/Source/WTF

Make sure we only set HAVE_VM_FLAGS_PERMANENT to 1 when targeting macOS >= 11.0
​https://bugs.webkit.org/show_bug.cgi?id=223408

Reviewed by Alexey Proskuryakov.

  • wtf/PlatformHave.h:
10:40 PM Changeset in webkit [274616] by Devin Rousso
  • 2 edits in trunk/Source/WebCore

don't copy imageOverlay.css or meterElementShadow.css
​https://bugs.webkit.org/show_bug.cgi?id=223411

Reviewed by Wenson Hsieh.

These files are already parsed into imageOverlayUserAgentStyleSheet and meterElementShadowUserAgentStyleSheet respectively.

  • WebCore.xcodeproj/project.pbxproj:
10:30 PM Changeset in webkit [274615] by commit-queue@webkit.org
  • 8 edits in trunk

Make fast/images/missing-content-image-crash.html results consistent with internal build
​https://bugs.webkit.org/show_bug.cgi?id=223399
<rdar://75443811>

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-03-17
Reviewed by Darin Adler.

Source/WebCore:

webkit.org is in the internal upgrade list. Add it to the open source list and make our test expectations consistent.

  • contentextensions/ContentExtensionsBackend.cpp:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:

(TestWebKitAPI::TEST):

LayoutTests:

  • fast/images/missing-content-image-crash-expected.txt:
  • http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher-expected.txt:
  • platform/mac-wk1/http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher-expected.txt:
10:20 PM Changeset in webkit [274614] by Peng Liu
  • 6 edits in trunk

[GPUP] WebGL2RenderingContext::texImage2D() does not work with a video as the image source
​https://bugs.webkit.org/show_bug.cgi?id=223294

Reviewed by Eric Carlson.

Source/WebKit:

No new tests. Fix a test failure.

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::updateCachedState):
Add a missing piece to implement MediaPlayerPrivateRemote::videoPlaybackQualityMetrics().

LayoutTests:

  • platform/mac/TestExpectations:
  • platform/mac/media/media-source/videoplaybackquality-decompressionsession-expected.txt:
  • platform/mac/media/media-source/videoplaybackquality-decompressionsession.html:
9:38 PM Changeset in webkit [274613] by ysuzuki@apple.com
  • 8 edits in trunk/Source/WebCore

modern-media-controls css should not allocate heap memory
​https://bugs.webkit.org/show_bug.cgi?id=223410

Reviewed by Devin Rousso.

This is CSS version of <​https://commits.webkit.org/235444@main>. We should not allocate heap memory for
modern-media-controls.css. This patch leverages UserAgentStyleSheets mechanism to include this style
sheet in constant DATA.

  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • css/make-css-file-arrays.pl:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::modernMediaControlsStyleSheet):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::modernMediaControlsStyleSheet):

9:17 PM Changeset in webkit [274612] by Darin Adler
  • 4 edits in trunk

"multile" typo in website and one other place
​https://bugs.webkit.org/show_bug.cgi?id=223213

Reviewed by Alex Christensen.

Source/WebCore:

  • features.json: Fix spelling.

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm: Fix spelling.
9:03 PM Changeset in webkit [274611] by Lauro Moura
  • 4 edits
    4 adds in trunk/LayoutTests

[GLIB] Gardening more consistent failures

Unreviewed test gardening.

Added some WPE baselines for tests that just check if no crash
happens.

  • platform/glib/TestExpectations:
  • platform/wpe/TestExpectations:
  • platform/wpe/css1/text_properties/vertical_align-expected.txt: After r271110
  • platform/wpe/fast/editing/mutation-with-display-contents-container-crash-expected.txt: Added.
  • platform/wpe/fast/editing/paste-and-match-style-with-table-crash-expected.txt: Added.
  • platform/wpe/fast/editing/replace-selection-and-apply-style-crash-expected.txt: Added.
7:51 PM Changeset in webkit [274610] by Wenson Hsieh
  • 7 edits in trunk/Source/WebKit

[iOS] Refactor some gesture deferral logic to account for image extraction
​https://bugs.webkit.org/show_bug.cgi?id=223400
<rdar://problem/75502285>

Reviewed by Tim Horton.

Refactor some logic around deferring gestures. See below for more details.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setUpInteraction]):

Rename a few existing deferring gestures, to better reflect that the names are deferral reasons (i.e. touch
start, touch end, or image extraction), rather than the names of the things being deferred.

(-[WKContentView deferringGestures]):
(-[WKContentView _doneDeferringTouchStart:]):
(-[WKContentView _doneDeferringTouchEnd:]):
(-[WKContentView hasSelectablePositionAtPoint:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
(-[WKContentView deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):
(-[WKContentView _endImageExtractionGestureDeferral:]):

  • UIProcess/ios/WKDeferringGestureRecognizer.h:

Add a property to indicate that the deferring gesture recognizer should immediately fail upon touchend.

  • UIProcess/ios/WKDeferringGestureRecognizer.mm:

(-[WKDeferringGestureRecognizer touchesEnded:withEvent:]):
(-[WKDeferringGestureRecognizer endDeferral:]):
(-[WKDeferringGestureRecognizer setDefaultPrevented:]): Deleted.

Rename -setDefaultPrevented: to -endDeferral: to decouple this terminology from Event.preventDefault() in
bindings (which is important, now that we have a new deferrer that is not associated with touch events).
Additionally, change this take an enum class instead of a BOOL to help clarify the intent of the given flag.

  • UIProcess/ios/WKImageExtractionGestureRecognizer.h:
  • UIProcess/ios/WKImageExtractionGestureRecognizer.mm:

(-[WKImageExtractionGestureRecognizer setState:]):

Add support for a new image extraction gesture delegate method which informs the client that the gesture has
transitioned to Failed state.

7:45 PM Changeset in webkit [274609] by Ross Kirsling
  • 22 edits in trunk

[JSC] Error#cause should apply to WebAssembly error constructors too
​https://bugs.webkit.org/show_bug.cgi?id=223404

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/error-cause.js:

Run tests on WebAssembly errors too.

  • wasm/js-api/test_basic_api.js:

Fix test. This behavior was inconsistent with all other error types (and divergent from all other engines).

Source/JavaScriptCore:

Per ​https://www.w3.org/TR/wasm-js-api-1/#error-objects:

The constructor and properties of WebAssembly errors is as specified for NativeError.

So Error#cause should "just work" for WebAssembly.{CompileError, LinkError, RuntimeError} too.

In the process:

  • Eliminate JSWebAssemblyCompileError and kin since they add no functionality on top of ErrorInstance.
  • Add an on-by-default feature flag (belated from the last patch).
  • API/JSObjectRef.cpp:

(JSObjectMakeError):

  • runtime/AggregateErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/ErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/JSGlobalObject.h:
  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor<errorType>::constructImpl):
(JSC::NativeErrorConstructor<errorType>::callImpl):

  • runtime/OptionsList.h:
  • wasm/WasmOperations.cpp:

(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):

  • wasm/js/JSWebAssemblyCompileError.cpp:

(JSC::createJSWebAssemblyCompileError):
(JSC::JSWebAssemblyCompileError::create): Deleted.
(JSC::JSWebAssemblyCompileError::JSWebAssemblyCompileError): Deleted.

  • wasm/js/JSWebAssemblyCompileError.h:

(): Deleted.

  • wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::finalizeCreation):

  • wasm/js/JSWebAssemblyLinkError.cpp:

(JSC::createJSWebAssemblyLinkError):
(JSC::JSWebAssemblyLinkError::create): Deleted.
(JSC::JSWebAssemblyLinkError::JSWebAssemblyLinkError): Deleted.

  • wasm/js/JSWebAssemblyLinkError.h:

(): Deleted.

  • wasm/js/JSWebAssemblyModule.cpp:

(JSC::JSWebAssemblyModule::createStub):

  • wasm/js/JSWebAssemblyRuntimeError.cpp:

(JSC::createJSWebAssemblyRuntimeError):
(JSC::JSWebAssemblyRuntimeError::create): Deleted.
(JSC::JSWebAssemblyRuntimeError::JSWebAssemblyRuntimeError): Deleted.

  • wasm/js/JSWebAssemblyRuntimeError.h:

(): Deleted.

  • wasm/js/WebAssemblyCompileErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyLinkErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

7:40 PM Changeset in webkit [274608] by mark.lam@apple.com
  • 4 edits
    1 add in trunk

Fix race condition in ConcurrentPtrHashSet.
​https://bugs.webkit.org/show_bug.cgi?id=223241
rdar://74637896

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/race-to-add-opaque-roots-in-ConcurrentPtrHashSet.js: Added.

Source/WTF:

There exists a race condition where ConcurrentPtrHashSet::resizeIfNecessary() may
not capture an entry added by ConcurrentPtrHashSet::addSlow() concurrently.

ConcurrentPtrHashSet::addSlow() currently does the following:

{

if (table->load.exchangeAdd(1) >= table->maxLoad()) (a1)

return resizeAndAdd(ptr); (a2)


for (;;) {

void* oldEntry = table->array[index].compareExchangeStrong(nullptr, ptr); (a3)
if (!oldEntry) {

if (m_table.load() != table) { (a4)

We added an entry to an old table! We need to reexecute the add on the new table.
return add(ptr); (a5)

}
return true; (a6)

}
if (oldEntry == ptr)

return false;

... set index to next entry slot to try.

}

}

ConcurrentPtrHashSet::resizeIfNecessary() currently does the following:

{

auto locker = holdLock(m_lock); (r1)
Table* table = m_table.loadRelaxed();
if (table->load.loadRelaxed() < table->maxLoad())

return;

(r2)

std::unique_ptr<Table> newTable = Table::create(table->size * 2);
...
for (unsigned i = 0; i < table->size; ++i) { (r3)

void* ptr = table->array[i].loadRelaxed();
if (!ptr)

continue;


... copy ptr to newTable. (r4)

}


...
m_table.store(newTable.get()); (r5)
...

}

Let's say thread T1 is executing addSlow(), and thread T2 is concurrently executing
resizeIfNecessary().

Consider the following scenario (in chronological order):

  1. T2 has arrived at just before (r5) i.e. it is already done copying the entries in the old m_table.
  2. T1 executes (a3) and writes a new entry into m_table.
  3. T1 checks that the table hasn't been replaced at (a4), and sees that it has not.
  4. T1 returns at (a6), thinking that its new entry is committed.
  5. T2 sets the new m_table at (r5), thereby discarding the new entry that T1 has just written.

The fix is to set m_table to a newly introduced m_stubTable at (r2). m_stubTable
is set up with a size of 0, and load value of 10. This means it is always full.
With this, the following scenarios can play out:

Scenario 1: T2 installs m_stubTable before T1 reaches (a1)

  1. At (a1), T1 sees that m_table (which is m_stubTable) is full.
  2. T1 calls resizeAndAdd() at (a2), which ends up calling resizeIfNecessary() and blocking on the lock at (r1).

Scenario 2: T2 installs m_stubTable after T1 reaches just before (a3)

  1. T1 writes the new entry at (a3).
  2. T1 checks m_table at (a4), and sees that it has changed (now pointing to m_stubTable).
  3. T1 calls add() again at (a5) to redo the operation, and ends with scenario 1.

Scenario 3: T2 installs m_stubTable after T1 reaches (a3), but before (a4)

  1. The new entry has already been added, but we don't know if it made the cut off for T2 to copy it or not. But, it doesn't matter because ...
  2. T1 checks m_table at (a4), and sees that it has changed (now pointing to m_stubTable).
  3. T1 calls add() again at (a5) to redo the operation, and ends with scenario 1.

Scenario 4: T2 installs m_stubTable after T1 reaches (a4)

  1. The new entry has already been added.
  2. T1 checks m_table at (a4), and sees that it has NOT changed (because T2 hasn't installed m_stubTable yet). This means T2's copy loop is guaranteed to not have started yet i.e. the new entry will definitely be picked up by the copy loop.
  3. T1 returns at (a6), and all is well.
  • wtf/ConcurrentPtrHashSet.cpp:

(WTF::ConcurrentPtrHashSet::deleteOldTables):
(WTF::ConcurrentPtrHashSet::initialize):
(WTF::ConcurrentPtrHashSet::containsImplSlow const):
(WTF::ConcurrentPtrHashSet::sizeSlow const):
(WTF::ConcurrentPtrHashSet::resizeIfNecessary):
(WTF::ConcurrentPtrHashSet::Table::initializeStub):

  • wtf/ConcurrentPtrHashSet.h:
7:00 PM Changeset in webkit [274607] by ysuzuki@apple.com
  • 18 edits in trunk/Source

modern-media-controls script should not be allocated in heap
​https://bugs.webkit.org/show_bug.cgi?id=223309

Reviewed by Devin Rousso.

Source/JavaScriptCore:

Add --fail-if-non-ascii flag to ensure that input files do not include non-ASCII characters.

  • Scripts/make-js-file-arrays.py:

(main):

Source/WebCore:

Previously, we are concatenating several modern-media-controls scripts into one.
But this causes significant memory overhead (~600KB). Using NSBundle's data still
allocates memory since WTF::String(CFString) allocates heap memory.

Let's use existing mechanism designed for this purpose. We serialize modern-media-controls.js into const C array in
UserAgentScriptData.cpp. UserAgentScript is a mechanism for having user-agent specific script source, and this matches
to our purpose. (for example, UserAgentStyleSheets (CSS version of that) have html.css etc.).

We also InjectedScript_*.js name for these ModernMediaControls.js scripts while this is not directly related to the
heap usage reduction of this patch.

This patch does not do the same thing for CSS of modern-media-controls since this patch's focus is script files first.

  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::quickTimePluginReplacementScript):

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::mediaControlsScripts):
(WebCore::RenderTheme::mediaControlsScript): Deleted.

  • rendering/RenderThemeAdwaita.cpp:

(WebCore::RenderThemeAdwaita::mediaControlsScripts):
(WebCore::RenderThemeAdwaita::mediaControlsScript): Deleted.

  • rendering/RenderThemeAdwaita.h:
  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::purgeCaches):
(WebCore::RenderThemeIOS::mediaControlsScripts):
(WebCore::RenderThemeIOS::mediaControlsScript): Deleted.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::purgeCaches):
(WebCore::RenderThemeMac::mediaControlsScripts):
(WebCore::RenderThemeMac::mediaControlsScript): Deleted.

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::mediaControlsScripts):
(WebCore::RenderThemeWin::mediaControlsScript): Deleted.

  • rendering/RenderThemeWin.h:
5:30 PM Changeset in webkit [274606] by Russell Epstein
  • 1 copy in tags/Safari-611.1.21.0.9

Tag Safari-611.1.21.0.9.

5:27 PM Changeset in webkit [274605] by Robert Jenner
  • 2 edits in trunk/LayoutTests

REGRESSION (r274264): [ macOS wk2 ] compositing/video/video-border-radius.html is a flakey image failure
​https://bugs.webkit.org/show_bug.cgi?id=223383

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Updating expectations to Pass ImageOnlyFailure while test is being reviewed.
5:25 PM Changeset in webkit [274604] by Russell Epstein
  • 8 edits in branches/safari-611.1.21.0-branch/Source

Versioning.

WebKit-7611.1.21.0.9

5:15 PM Changeset in webkit [274603] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Reduce maximum HashTable entry size to 250 bytes
​https://bugs.webkit.org/show_bug.cgi?id=223398

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-03-17
Reviewed by Yusuke Suzuki.

Source/WebCore:

This reduces memory use at runtime.

  • platform/graphics/SourceBufferPrivate.cpp:

(WebCore::SourceBufferPrivate::resetTimestampOffsetInTrackBuffers):
(WebCore::SourceBufferPrivate::resetTrackBuffers):
(WebCore::SourceBufferPrivate::updateHighestPresentationTimestamp):
(WebCore::SourceBufferPrivate::updateBufferedFromTrackBuffers):
(WebCore::SourceBufferPrivate::reenqueSamples):
(WebCore::SourceBufferPrivate::clearTrackBuffers):
(WebCore::SourceBufferPrivate::bufferedSamplesForTrackId):
(WebCore::SourceBufferPrivate::fastSeekTimeForMediaTime):
(WebCore::SourceBufferPrivate::totalTrackBufferSizeInBytes const):
(WebCore::SourceBufferPrivate::addTrackBuffer):
(WebCore::SourceBufferPrivate::updateTrackIds):
(WebCore::SourceBufferPrivate::setAllTrackBuffersNeedRandomAccess):
(WebCore::SourceBufferPrivate::didReceiveSample):

  • platform/graphics/SourceBufferPrivate.h:

Source/WTF:

  • wtf/HashTable.h:

(WTF::KeyTraits>::inlineLookup):

5:07 PM Changeset in webkit [274602] by sbarati@apple.com
  • 9 edits in trunk/Source

Determine if we have useFastJITPermissions on arm64e at runtime instead of hardcoding it as always enabled
​https://bugs.webkit.org/show_bug.cgi?id=223388
<rdar://74819266>

Reviewed by Mark Lam.

Source/JavaScriptCore:

  • assembler/FastJITPermissions.h:

(threadSelfRestrictRWXToRW):
(threadSelfRestrictRWXToRX):
(useFastJITPermissions): Deleted.
(fastJITPermissionsIsSupported): Deleted.

  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::copyCompactAndLinkCode):

  • jit/ExecutableAllocator.cpp:

(JSC::initializeJITPageReservation):

  • jit/ExecutableAllocator.h:

(JSC::performJITMemcpy):

  • runtime/JSCConfig.h:

Source/WTF:

  • wtf/PlatformEnableCocoa.h:
  • wtf/PlatformUse.h:
5:03 PM Changeset in webkit [274601] by mark.lam@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Enhance --verboseVerifyGC=true to make it easier to debug GC verifier errors.
​https://bugs.webkit.org/show_bug.cgi?id=223401

Reviewed by Saam Barati.

Previously, --verboseVerifyGC=true only dumps the stack trace of the immediate code
path (in the verifier GC) that marked the object that the real GC did not. With
this patch, we'll also dump the trace of the marking chain all the way back to a
GC root. This patch also adds support for tracing the marking chain through opaque
roots.

The marking chain provided is the one that the verifier GC walked. To debug the
error, we use this info and check where the real GC deviates.

Here's an example of the new dump of a GC verifier error:

GC Verifier: ERROR cell 0x12c570500 was not marked
Object: 0x12c570500 with butterfly 0x0 (Structure 0x108eb6d10:[0x3ba8, ArrayBuffer, {}, NonArray, Proto:0x108ed7d90, Leaf]), StructureID: 15272
Cell 0x12c570500 was visited via opaque root 0x10e4b52c0 at:

1 0x100acccdc JSC::VerifierSlotVisitor::appendUnbarriered(JSC::JSCell*)
2 0x100ad0c2f void JSC::WeakBlock::specializedVisit<JSC::MarkedBlock, JSC::AbstractSlotVisitor>(JSC::MarkedBlock&, JSC::AbstractSlotVisitor&)
3 0x100abec2b void JSC::MarkedSpace::visitWeakSets<JSC::AbstractSlotVisitor>(JSC::AbstractSlotVisitor&)
4 0x100aa5167 WTF::Detail::CallableWrapper<JSC::Heap::addCoreConstraints()::$_38, void, JSC::AbstractSlotVisitor&>::call(JSC::AbstractSlotVisitor&)
5 0x100ac1411 JSC::MarkingConstraintSet::executeAllSynchronously(JSC::AbstractSlotVisitor&)
6 0x100a9bd7b JSC::Heap::verifyGC()
7 0x100a9b2f7 JSC::Heap::runEndPhase(JSC::GCConductor)
8 0x100a99434 JSC::Heap::runCurrentPhase(JSC::GCConductor, JSC::CurrentThreadState*)
9 0x100aa332d WTF::ScopedLambdaFunctor<void (JSC::CurrentThreadState&), JSC::Heap::collectInMutatorThread()::$_0>::implFunction(void*, JSC::CurrentThreadState&)
10 0x100ab8794 JSC::callWithCurrentThreadState(WTF::ScopedLambda<void (JSC::CurrentThreadState&)> const&)
11 0x100a9d2cd JSC::Heap::collectInMutatorThread()
12 0x100a99217 JSC::Heap::waitForCollection(unsigned long long)
13 0x100a98cb1 JSC::Heap::collectNow(JSC::Synchronousness, JSC::GCRequest)
14 0x100ab7b4d JSC::LocalAllocator::allocateSlowCase(JSC::Heap&, JSC::GCDeferralContext*, JSC::AllocationFailureMode)
15 0x100ec0785 void* JSC::allocateCell<JSC::JSDataView>(JSC::Heap&, unsigned long)
16 0x100ec0629 JSC::JSDataView::create(JSC::JSGlobalObject*, JSC::Structure*, WTF::RefPtr<JSC::ArrayBuffer, WTF::RawPtrTraits<JSC::ArrayBuffer>, WTF::DefaultRefDerefTraits<JSC::ArrayBuffer> >&&, unsigned int, unsigned int)
17 0x100f893d6 JSC::JSObject* JSC::constructGenericTypedArrayViewWithArguments<JSC::JSDataView>(JSC::JSGlobalObject*, JSC::Structure*, long long, unsigned int, WTF::Optional<unsigned int>)
18 0x100f731dc JSC::constructDataView(JSC::JSGlobalObject*, JSC::CallFrame*)
19 0x5e4a38a010c7
20 0x5e4a38a02095
21 0x1004888d6 vmEntryToJavaScript
22 0x100b83690 JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*)
23 0x100e39a82 JSC::evaluate(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
24 0x100007606 jscmain(int, char)
25 0x10000644b main

In the real GC, opaque root0x10e4b52c0 was NOT added to the heap's opaque roots.
Opaque root 0x10e4b52c0 was added via cell 0x12c577720 at:

1 0x100ea4fc9 JSC::JSArrayBufferView::visitChildren(JSC::JSCell*, JSC::AbstractSlotVisitor&)
2 0x100acd4e9 JSC::VerifierSlotVisitor::drain()
3 0x100a9bd48 JSC::Heap::verifyGC()
4 0x100a9b2f7 JSC::Heap::runEndPhase(JSC::GCConductor)
5 0x100a99434 JSC::Heap::runCurrentPhase(JSC::GCConductor, JSC::CurrentThreadState*)
6 0x100aa332d WTF::ScopedLambdaFunctor<void (JSC::CurrentThreadState&), JSC::Heap::collectInMutatorThread()::$_0>::implFunction(void*, JSC::CurrentThreadState&)
7 0x100ab8794 JSC::callWithCurrentThreadState(WTF::ScopedLambda<void (JSC::CurrentThreadState&)> const&)
8 0x100a9d2cd JSC::Heap::collectInMutatorThread()
9 0x100a99217 JSC::Heap::waitForCollection(unsigned long long)
10 0x100a98cb1 JSC::Heap::collectNow(JSC::Synchronousness, JSC::GCRequest)
11 0x100ab7b4d JSC::LocalAllocator::allocateSlowCase(JSC::Heap&, JSC::GCDeferralContext*, JSC::AllocationFailureMode)
12 0x100ec0785 void* JSC::allocateCell<JSC::JSDataView>(JSC::Heap&, unsigned long)
13 0x100ec0629 JSC::JSDataView::create(JSC::JSGlobalObject*, JSC::Structure*, WTF::RefPtr<JSC::ArrayBuffer, WTF::RawPtrTraits<JSC::ArrayBuffer>, WTF::DefaultRefDerefTraits<JSC::ArrayBuffer> >&&, unsigned int, unsigned int)
14 0x100f893d6 JSC::JSObject* JSC::constructGenericTypedArrayViewWithArguments<JSC::JSDataView>(JSC::JSGlobalObject*, JSC::Structure*, long long, unsigned int, WTF::Optional<unsigned int>)
15 0x100f731dc JSC::constructDataView(JSC::JSGlobalObject*, JSC::CallFrame*)
16 0x5e4a38a010c7
17 0x5e4a38a02095
18 0x1004888d6 vmEntryToJavaScript
19 0x100b83690 JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*)
20 0x100e39a82 JSC::evaluate(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
21 0x100007606 jscmain(int, char)
22 0x10000644b main
23 0x7fff203b4f3d start

Object: 0x12c577720 with butterfly 0x0 (Structure 0x108eb6e60:[0xe135, DataView, {}, NonArray, Proto:0x108ed7da0, Leaf]), StructureID: 57653
Cell 0x12c577720 was visited via cell 0x108b528e8 at:

1 0x100acccdc JSC::VerifierSlotVisitor::appendUnbarriered(JSC::JSCell*)
2 0x100f1623c JSC::JSObject::visitChildren(JSC::JSCell*, JSC::AbstractSlotVisitor&)
3 0x100acd4e9 JSC::VerifierSlotVisitor::drain()
4 0x100a9bd48 JSC::Heap::verifyGC()
5 0x100a9b2f7 JSC::Heap::runEndPhase(JSC::GCConductor)
6 0x100a99434 JSC::Heap::runCurrentPhase(JSC::GCConductor, JSC::CurrentThreadState*)
7 0x100aa332d WTF::ScopedLambdaFunctor<void (JSC::CurrentThreadState&), JSC::Heap::collectInMutatorThread()::$_0>::implFunction(void*, JSC::CurrentThreadState&)
8 0x100ab8794 JSC::callWithCurrentThreadState(WTF::ScopedLambda<void (JSC::CurrentThreadState&)> const&)
9 0x100a9d2cd JSC::Heap::collectInMutatorThread()
10 0x100a99217 JSC::Heap::waitForCollection(unsigned long long)
11 0x100a98cb1 JSC::Heap::collectNow(JSC::Synchronousness, JSC::GCRequest)
12 0x100ab7b4d JSC::LocalAllocator::allocateSlowCase(JSC::Heap&, JSC::GCDeferralContext*, JSC::AllocationFailureMode)
13 0x100ec0785 void* JSC::allocateCell<JSC::JSDataView>(JSC::Heap&, unsigned long)
14 0x100ec0629 JSC::JSDataView::create(JSC::JSGlobalObject*, JSC::Structure*, WTF::RefPtr<JSC::ArrayBuffer, WTF::RawPtrTraits<JSC::ArrayBuffer>, WTF::DefaultRefDerefTraits<JSC::ArrayBuffer> >&&, unsigned int, unsigned int)
15 0x100f893d6 JSC::JSObject* JSC::constructGenericTypedArrayViewWithArguments<JSC::JSDataView>(JSC::JSGlobalObject*, JSC::Structure*, long long, unsigned int, WTF::Optional<unsigned int>)
16 0x100f731dc JSC::constructDataView(JSC::JSGlobalObject*, JSC::CallFrame*)
17 0x5e4a38a010c7
18 0x5e4a38a02095
19 0x1004888d6 vmEntryToJavaScript
20 0x100b83690 JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*)
21 0x100e39a82 JSC::evaluate(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
22 0x100007606 jscmain(int, char)
23 0x10000644b main

Object: 0x108b528e8 with butterfly 0x1806e93070 (Structure 0x108efb090:[0xde87, Array, {}, ArrayWithContiguous, Proto:0x108baf5e8]), StructureID: 56967
Cell 0x108b528e8 was visited via cell 0x108e8fcc0 at:

1 0x100accdd8 JSC::VerifierSlotVisitor::appendUnbarriered(JSC::JSCell*)
2 0x10070634e void JSC::CodeBlock::stronglyVisitWeakReferences<JSC::AbstractSlotVisitor>(JSC::ConcurrentJSLocker const&, JSC::AbstractSlotVisitor&)
3 0x1006eacd7 JSC::CodeBlock::visitChildren(JSC::JSCell*, JSC::AbstractSlotVisitor&)
4 0x100acd4e9 JSC::VerifierSlotVisitor::drain()
5 0x100a9bd48 JSC::Heap::verifyGC()
6 0x100a9b2f7 JSC::Heap::runEndPhase(JSC::GCConductor)
7 0x100a99434 JSC::Heap::runCurrentPhase(JSC::GCConductor, JSC::CurrentThreadState*)
8 0x100aa332d WTF::ScopedLambdaFunctor<void (JSC::CurrentThreadState&), JSC::Heap::collectInMutatorThread()::$_0>::implFunction(void*, JSC::CurrentThreadState&)
9 0x100ab8794 JSC::callWithCurrentThreadState(WTF::ScopedLambda<void (JSC::CurrentThreadState&)> const&)
10 0x100a9d2cd JSC::Heap::collectInMutatorThread()
11 0x100a99217 JSC::Heap::waitForCollection(unsigned long long)
12 0x100a98cb1 JSC::Heap::collectNow(JSC::Synchronousness, JSC::GCRequest)
13 0x100ab7b4d JSC::LocalAllocator::allocateSlowCase(JSC::Heap&, JSC::GCDeferralContext*, JSC::AllocationFailureMode)
14 0x100ec0785 void* JSC::allocateCell<JSC::JSDataView>(JSC::Heap&, unsigned long)
15 0x100ec0629 JSC::JSDataView::create(JSC::JSGlobalObject*, JSC::Structure*, WTF::RefPtr<JSC::ArrayBuffer, WTF::RawPtrTraits<JSC::ArrayBuffer>, WTF::DefaultRefDerefTraits<JSC::ArrayBuffer> >&&, unsigned int, unsigned int)
16 0x100f893d6 JSC::JSObject* JSC::constructGenericTypedArrayViewWithArguments<JSC::JSDataView>(JSC::JSGlobalObject*, JSC::Structure*, long long, unsigned int, WTF::Optional<unsigned int>)
17 0x100f731dc JSC::constructDataView(JSC::JSGlobalObject*, JSC::CallFrame*)
18 0x5e4a38a010c7
19 0x5e4a38a02095
20 0x1004888d6 vmEntryToJavaScript
21 0x100b83690 JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*)
22 0x100e39a82 JSC::evaluate(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
23 0x100007606 jscmain(int, char)
24 0x10000644b main

Cell: 0x108e8fcc0 (0x108ef8c40:[0xc0e7, ProgramCodeBlock, {}, NonArray, Leaf]), StructureID: 49383
Cell 0x108e8fcc0 was visited from scan of ConservativeScan roots at:

1 0x100accaf8 JSC::VerifierSlotVisitor::append(JSC::ConservativeRoots const&)
2 0x100aa42a2 WTF::Detail::CallableWrapper<JSC::Heap::addCoreConstraints()::$_31, void, JSC::SlotVisitor&>::call(JSC::SlotVisitor&)
3 0x100ac1db2 JSC::MarkingConstraintSolver::runExecutionThread(JSC::SlotVisitor&, JSC::MarkingConstraintSolver::SchedulerPreference, WTF::ScopedLambda<WTF::Optional<unsigned int> ()>)
4 0x100a9f2de JSC::Heap::runTaskInParallel(WTF::RefPtr<WTF::SharedTask<void (JSC::SlotVisitor&)>, WTF::RawPtrTraits<WTF::SharedTask<void (JSC::SlotVisitor&)> >, WTF::DefaultRefDerefTraits<WTF::SharedTask<void (JSC::SlotVisitor&)> > >)
5 0x100ac188f JSC::MarkingConstraintSolver::execute(JSC::MarkingConstraintSolver::SchedulerPreference, WTF::ScopedLambda<WTF::Optional<unsigned int> ()>)
6 0x100ac125c JSC::MarkingConstraintSet::executeConvergenceImpl(JSC::SlotVisitor&)
7 0x100ac0f9b JSC::MarkingConstraintSet::executeConvergence(JSC::SlotVisitor&)
8 0x100a99f24 JSC::Heap::runFixpointPhase(JSC::GCConductor)
9 0x100a99418 JSC::Heap::runCurrentPhase(JSC::GCConductor, JSC::CurrentThreadState*)
10 0x100aa332d WTF::ScopedLambdaFunctor<void (JSC::CurrentThreadState&), JSC::Heap::collectInMutatorThread()::$_0>::implFunction(void*, JSC::CurrentThreadState&)
11 0x100ab8794 JSC::callWithCurrentThreadState(WTF::ScopedLambda<void (JSC::CurrentThreadState&)> const&)
12 0x100a9d2cd JSC::Heap::collectInMutatorThread()
13 0x100a99217 JSC::Heap::waitForCollection(unsigned long long)
14 0x100a98cb1 JSC::Heap::collectNow(JSC::Synchronousness, JSC::GCRequest)
15 0x100ab7b4d JSC::LocalAllocator::allocateSlowCase(JSC::Heap&, JSC::GCDeferralContext*, JSC::AllocationFailureMode)
16 0x100ec0785 void* JSC::allocateCell<JSC::JSDataView>(JSC::Heap&, unsigned long)
17 0x100ec0629 JSC::JSDataView::create(JSC::JSGlobalObject*, JSC::Structure*, WTF::RefPtr<JSC::ArrayBuffer, WTF::RawPtrTraits<JSC::ArrayBuffer>, WTF::DefaultRefDerefTraits<JSC::ArrayBuffer> >&&, unsigned int, unsigned int)
18 0x100f893d6 JSC::JSObject* JSC::constructGenericTypedArrayViewWithArguments<JSC::JSDataView>(JSC::JSGlobalObject*, JSC::Structure*, long long, unsigned int, WTF::Optional<unsigned int>)
19 0x100f731dc JSC::constructDataView(JSC::JSGlobalObject*, JSC::CallFrame*)
20 0x5e4a38a010c7
21 0x5e4a38a02095
22 0x1004888d6 vmEntryToJavaScript
23 0x100b83690 JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*)
24 0x100e39a82 JSC::evaluate(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
25 0x100007606 jscmain(int, char)
26 0x10000644b main

Note that in this example, the 2nd stack trace was for an opaque root. The verifier
also noted that the opaque root (which was added for the verifier GC) was not added
for the real GC. This pointed to the bug that caused the error (this bug was fixed
in ​https://bugs.webkit.org/show_bug.cgi?id=223241).

Additional changes in this patch:

  1. Renamed AbstractSlotVisitor::Context to ReferrerContext.
  1. Introduced AbstractSlotVisitor::ReferrerToken, which is an abstraction for either a HeapCell*, an opaque root, or a GC root. ReferrerContext now tracks a ReferrerToken instead of a HeapCell*.
  • heap/AbstractSlotVisitor.h:

(JSC::AbstractSlotVisitor::ReferrerToken::ReferrerToken):
(JSC::AbstractSlotVisitor::ReferrerToken::operator bool const):
(JSC::AbstractSlotVisitor::ReferrerToken::operator! const):
(JSC::AbstractSlotVisitor::ReferrerToken::isHeapCell const):
(JSC::AbstractSlotVisitor::ReferrerToken::isOpaqueRoot const):
(JSC::AbstractSlotVisitor::ReferrerToken::isRootMarkReason const):
(JSC::AbstractSlotVisitor::ReferrerContext::referrer const):
(JSC::AbstractSlotVisitor::ReferrerContext::setReferrer):
(JSC::AbstractSlotVisitor::ReferrerContext::isOpaqueRootContext const):
(JSC::AbstractSlotVisitor::didAddOpaqueRoot):
(JSC::AbstractSlotVisitor::didFindOpaqueRoot):
(JSC::SetRootMarkReasonScope::SetRootMarkReasonScope):
(JSC::AbstractSlotVisitor::Context::cell const): Deleted.

  • heap/AbstractSlotVisitorInlines.h:

(JSC::ReferrerToken::ReferrerToken):
(JSC::ReferrerToken::asCell const):
(JSC::ReferrerToken::asOpaqueRoot const):
(JSC::ReferrerToken::asRootMarkReason const):
(JSC::AbstractSlotVisitor::ReferrerContext::ReferrerContext):
(JSC::AbstractSlotVisitor::ReferrerContext::~ReferrerContext):
(JSC::AbstractSlotVisitor::addOpaqueRoot):
(JSC::AbstractSlotVisitor::containsOpaqueRoot const):
(JSC::AbstractSlotVisitor::referrer const):
(JSC::AbstractSlotVisitor::Context::Context): Deleted.
(JSC::AbstractSlotVisitor::Context::~Context): Deleted.
(JSC::AbstractSlotVisitor::parentCell const): Deleted.

  • heap/Heap.cpp:

(JSC::Heap::addCoreConstraints):

  • heap/Heap.h:
  • heap/SlotVisitor.h:
  • heap/SlotVisitorMacros.h:
  • heap/VerifierSlotVisitor.cpp:

(JSC::MarkerData::MarkerData):
(JSC::VerifierSlotVisitor::MarkedBlockData::markerData const):
(JSC::VerifierSlotVisitor::PreciseAllocationData::markerData const):
(JSC::VerifierSlotVisitor::OpaqueRootData::markerData const):
(JSC::VerifierSlotVisitor::OpaqueRootData::addMarkerData):
(JSC::VerifierSlotVisitor::VerifierSlotVisitor):
(JSC::VerifierSlotVisitor::didAddOpaqueRoot):
(JSC::VerifierSlotVisitor::didFindOpaqueRoot):
(JSC::VerifierSlotVisitor::dump const):
(JSC::VerifierSlotVisitor::dumpMarkerData):
(JSC::VerifierSlotVisitor::testAndSetMarked):

  • heap/VerifierSlotVisitor.h:

(JSC::VerifierSlotVisitor::MarkerData::referrer const):
(JSC::VerifierSlotVisitor::MarkerData::stack const):

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::specializedVisit):

4:47 PM Changeset in webkit [274600] by Aditya Keerthi
  • 276 edits in trunk

[iOS][FCR] Use system colors for the new appearance
​https://bugs.webkit.org/show_bug.cgi?id=223303
<rdar://problem/75508598>

Reviewed by Tim Horton.

Source/WebCore:

Use system colors when painting the new controls to ensure consistency
with the rest of the system.

This patch exposes additional system colors in CSS, so that they may be
used by the UA stylesheet. Note that exposing these colors does not
increase the fingerprintable surface since, we already expose other
system colors that have the same traits.

Additionally, HAVE(OS_DARK_MODE_SUPPORT) is removed from these colors
since they are available on all PLATFORM(IOS_FAMILY).

  • css/CSSValueKeywords.in:
  • css/html.css:
  • rendering/RenderThemeIOS.mm:

(WebCore::cssValueIDSelectorList):
(WebCore::RenderThemeIOS::paintCheckbox):
(WebCore::RenderThemeIOS::paintRadio):
(WebCore::RenderThemeIOS::paintProgressBarWithFormControlRefresh):
(WebCore::RenderThemeIOS::paintMeter):
(WebCore::RenderThemeIOS::paintSliderTicks):
(WebCore::RenderThemeIOS::paintSliderTrackWithFormControlRefresh):
(WebCore::RenderThemeIOS::paintMenuListButtonDecorationsWithFormControlRefresh):

Source/WebCore/PAL:

  • pal/spi/ios/UIKitSPI.h:

Add additional system colors declarations for watchOS and tvOS.

LayoutTests:

Rebaselined tests to account for changes in color.

  • fast/forms/date/date-input-rendering-basic-expected.txt:
  • fast/forms/date/date-pseudo-elements-expected.txt:
  • fast/forms/time/time-input-rendering-basic-expected.txt:
  • platform/ios-simulator/fast/forms/auto-fill-button/hide-auto-fill-strong-password-viewable-treatment-when-form-is-reset-expected.txt:
  • platform/ios-simulator/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt:
  • platform/ios-simulator/fast/forms/auto-fill-button/input-strong-password-viewable-expected.txt:
  • platform/ios-simulator/fast/forms/datalist/datalist-searchinput-appearance-expected.txt:
  • platform/ios-simulator/fast/forms/datalist/datalist-textinput-appearance-expected.txt:
  • platform/ios-wk2/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/ios-wk2/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/ios-wk2/editing/inserting/4960120-1-expected.txt:
  • platform/ios-wk2/editing/inserting/before-after-input-element-expected.txt:
  • platform/ios-wk2/editing/pasteboard/4641033-expected.txt:
  • platform/ios-wk2/editing/pasteboard/4944770-1-expected.txt:
  • platform/ios-wk2/editing/pasteboard/4944770-2-expected.txt:
  • platform/ios-wk2/editing/pasteboard/input-field-1-expected.txt:
  • platform/ios-wk2/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/ios-wk2/editing/selection/4895428-3-expected.txt:
  • platform/ios-wk2/editing/selection/caret-before-select-expected.txt:
  • platform/ios-wk2/editing/selection/drag-select-1-expected.txt:
  • platform/ios-wk2/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/ios-wk2/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/ios-wk2/fast/block/margin-collapse/103-expected.txt:
  • platform/ios-wk2/fast/dynamic/008-expected.txt:
  • platform/ios-wk2/fast/forms/basic-buttons-expected.txt:
  • platform/ios-wk2/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/ios-wk2/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/ios-wk2/fast/forms/input-text-click-outside-expected.txt:
  • platform/ios-wk2/fast/forms/input-text-double-click-expected.txt:
  • platform/ios-wk2/fast/forms/input-text-drag-down-expected.txt:
  • platform/ios-wk2/fast/forms/input-text-option-delete-expected.txt:
  • platform/ios-wk2/fast/forms/targeted-frame-submission-expected.txt:
  • platform/ios-wk2/fast/forms/textAreaLineHeight-expected.txt:
  • platform/ios-wk2/fast/forms/textarea-align-expected.txt:
  • platform/ios-wk2/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/ios-wk2/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/ios-wk2/fast/forms/textarea-scroll-height-expected.txt:
  • platform/ios-wk2/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/ios-wk2/fast/hidpi/resize-corner-hidpi-expected.txt:
  • platform/ios-wk2/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/ios-wk2/fast/overflow/scrollRevealButton-expected.txt:
  • platform/ios-wk2/fast/parser/document-write-option-expected.txt:
  • platform/ios-wk2/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/ios-wk2/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/ios-wk2/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt:
  • platform/ios-wk2/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/ios-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/ios-wk2/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/css/css-pseudo/file-chooser-button-display-toggle-crash.tentative-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/select-wrap-no-spill.optional-expected.txt:
  • platform/ios/css3/flexbox/button-expected.txt:
  • platform/ios/editing/pasteboard/4806874-expected.txt:
  • platform/ios/editing/selection/3690703-2-expected.txt:
  • platform/ios/editing/selection/3690703-expected.txt:
  • platform/ios/editing/selection/3690719-expected.txt:
  • platform/ios/editing/selection/4397952-expected.txt:
  • platform/ios/editing/selection/4975120-expected.txt:
  • platform/ios/editing/selection/5240265-expected.txt:
  • platform/ios/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/ios/editing/selection/select-box-expected.txt:
  • platform/ios/editing/selection/select-element-paragraph-boundary-expected.txt:
  • platform/ios/editing/selection/selection-button-text-expected.txt:
  • platform/ios/fast/block/float/032-expected.txt:
  • platform/ios/fast/block/float/float-avoidance-expected.txt:
  • platform/ios/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/ios/fast/css/continuationCrash-expected.txt:
  • platform/ios/fast/css/focus-ring-exists-for-search-field-expected.txt:
  • platform/ios/fast/css/input-search-padding-expected.txt:
  • platform/ios/fast/css/line-height-expected.txt:
  • platform/ios/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/ios/fast/css/rtl-ordering-expected.txt:
  • platform/ios/fast/css/text-overflow-input-expected.txt:
  • platform/ios/fast/css/text-transform-select-expected.txt:
  • platform/ios/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/ios/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/ios/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
  • platform/ios/fast/events/context-no-deselect-expected.txt:
  • platform/ios/fast/forms/001-expected.txt:
  • platform/ios/fast/forms/003-expected.txt:
  • platform/ios/fast/forms/004-expected.txt:
  • platform/ios/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt:
  • platform/ios/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:
  • platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:
  • platform/ios/fast/forms/basic-inputs-expected.txt:
  • platform/ios/fast/forms/basic-selects-expected.txt:
  • platform/ios/fast/forms/basic-textareas-expected.txt:
  • platform/ios/fast/forms/blankbuttons-expected.txt:
  • platform/ios/fast/forms/box-shadow-override-expected.txt:
  • platform/ios/fast/forms/button-align-expected.txt:
  • platform/ios/fast/forms/button-cannot-be-nested-expected.txt:
  • platform/ios/fast/forms/button-generated-content-expected.txt:
  • platform/ios/fast/forms/button-positioned-expected.txt:
  • platform/ios/fast/forms/button-sizes-expected.txt:
  • platform/ios/fast/forms/button-style-color-expected.txt:
  • platform/ios/fast/forms/button-table-styles-expected.txt:
  • platform/ios/fast/forms/button-text-transform-expected.txt:
  • platform/ios/fast/forms/button-white-space-expected.txt:
  • platform/ios/fast/forms/control-clip-expected.txt:
  • platform/ios/fast/forms/control-clip-overflow-expected.txt:
  • platform/ios/fast/forms/control-restrict-line-height-expected.txt:
  • platform/ios/fast/forms/disabled-select-change-index-expected.txt:
  • platform/ios/fast/forms/encoding-test-expected.txt:
  • platform/ios/fast/forms/fieldset-align-expected.txt:
  • platform/ios/fast/forms/file/file-input-direction-expected.txt:
  • platform/ios/fast/forms/file/file-input-disabled-expected.txt:
  • platform/ios/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/ios/fast/forms/form-element-geometry-expected.txt:
  • platform/ios/fast/forms/formmove3-expected.txt:
  • platform/ios/fast/forms/hidden-listbox-expected.txt:
  • platform/ios/fast/forms/input-align-expected.txt:
  • platform/ios/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/ios/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/ios/fast/forms/input-appearance-disabled-expected.txt:
  • platform/ios/fast/forms/input-appearance-focus-expected.txt:
  • platform/ios/fast/forms/input-appearance-height-expected.txt:
  • platform/ios/fast/forms/input-appearance-selection-expected.txt:
  • platform/ios/fast/forms/input-appearance-visibility-expected.txt:
  • platform/ios/fast/forms/input-appearance-width-expected.txt:
  • platform/ios/fast/forms/input-button-sizes-expected.txt:
  • platform/ios/fast/forms/input-disabled-color-expected.txt:
  • platform/ios/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/ios/fast/forms/input-field-text-truncated-expected.txt:
  • platform/ios/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/ios/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/ios/fast/forms/input-spaces-expected.txt:
  • platform/ios/fast/forms/input-table-expected.txt:
  • platform/ios/fast/forms/input-text-click-inside-expected.txt:
  • platform/ios/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/ios/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/ios/fast/forms/input-type-text-min-width-expected.txt:
  • platform/ios/fast/forms/input-value-expected.txt:
  • platform/ios/fast/forms/input-width-expected.txt:
  • platform/ios/fast/forms/listbox-bidi-align-expected.txt:
  • platform/ios/fast/forms/listbox-hit-test-zoomed-expected.txt:
  • platform/ios/fast/forms/listbox-scrollbar-incremental-load-expected.txt:
  • platform/ios/fast/forms/listbox-width-change-expected.txt:
  • platform/ios/fast/forms/menulist-clip-expected.txt:
  • platform/ios/fast/forms/menulist-deselect-update-expected.txt:
  • platform/ios/fast/forms/menulist-narrow-width-expected.txt:
  • platform/ios/fast/forms/menulist-no-overflow-expected.txt:
  • platform/ios/fast/forms/menulist-option-wrap-expected.txt:
  • platform/ios/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/ios/fast/forms/menulist-separator-painting-expected.txt:
  • platform/ios/fast/forms/menulist-style-color-expected.txt:
  • platform/ios/fast/forms/menulist-width-change-expected.txt:
  • platform/ios/fast/forms/minWidthPercent-expected.txt:
  • platform/ios/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/ios/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/ios/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
  • platform/ios/fast/forms/option-script-expected.txt:
  • platform/ios/fast/forms/option-strip-whitespace-expected.txt:
  • platform/ios/fast/forms/option-text-clip-expected.txt:
  • platform/ios/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/ios/fast/forms/plaintext-mode-2-expected.txt:
  • platform/ios/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/ios/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/ios/fast/forms/search-input-rtl-expected.txt:
  • platform/ios/fast/forms/select-align-expected.txt:
  • platform/ios/fast/forms/select-baseline-expected.txt:
  • platform/ios/fast/forms/select-block-background-expected.txt:
  • platform/ios/fast/forms/select-change-listbox-size-expected.txt:
  • platform/ios/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/ios/fast/forms/select-change-popup-to-listbox-expected.txt:
  • platform/ios/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/ios/fast/forms/select-disabled-appearance-expected.txt:
  • platform/ios/fast/forms/select-element-focus-ring-expected.txt:
  • platform/ios/fast/forms/select-empty-option-height-expected.txt:
  • platform/ios/fast/forms/select-initial-position-expected.txt:
  • platform/ios/fast/forms/select-item-background-clip-expected.txt:
  • platform/ios/fast/forms/select-list-box-with-height-expected.txt:
  • platform/ios/fast/forms/select-non-native-rendering-direction-expected.txt:
  • platform/ios/fast/forms/select-selected-expected.txt:
  • platform/ios/fast/forms/select-style-expected.txt:
  • platform/ios/fast/forms/select-visual-hebrew-expected.txt:
  • platform/ios/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/ios/fast/forms/select/optgroup-rendering-expected.txt:
  • platform/ios/fast/forms/selectlist-minsize-expected.txt:
  • platform/ios/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/ios/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/ios/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/ios/fast/forms/textarea-scrollbar-expected.txt:
  • platform/ios/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/ios/fast/forms/textarea-width-expected.txt:
  • platform/ios/fast/forms/textfield-focus-ring-expected.txt:
  • platform/ios/fast/forms/textfield-overflow-expected.txt:
  • platform/ios/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/ios/fast/html/details-no-summary4-expected.txt:
  • platform/ios/fast/html/details-open-javascript-expected.txt:
  • platform/ios/fast/html/details-open2-expected.txt:
  • platform/ios/fast/html/details-open4-expected.txt:
  • platform/ios/fast/html/details-replace-summary-child-expected.txt:
  • platform/ios/fast/html/details-replace-text-expected.txt:
  • platform/ios/fast/html/keygen-expected.txt:
  • platform/ios/fast/invalid/014-expected.txt:
  • platform/ios/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/ios/fast/overflow/overflow-x-y-expected.txt:
  • platform/ios/fast/replaced/replaced-breaking-expected.txt:
  • platform/ios/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/ios/fast/replaced/three-selects-break-expected.txt:
  • platform/ios/fast/replaced/width100percent-button-expected.txt:
  • platform/ios/fast/replaced/width100percent-menulist-expected.txt:
  • platform/ios/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/ios/fast/replaced/width100percent-textarea-expected.txt:
  • platform/ios/fast/replaced/width100percent-textfield-expected.txt:
  • platform/ios/fast/selectors/064-expected.txt:
  • platform/ios/fast/table/append-cells2-expected.txt:
  • platform/ios/fast/table/colspanMinWidth-expected.txt:
  • platform/ios/fast/table/remove-td-display-none-expected.txt:
  • platform/ios/fast/table/spanOverlapRepaint-expected.txt:
  • platform/ios/fast/table/text-field-baseline-expected.txt:
  • platform/ios/fast/text/drawBidiText-expected.txt:
  • platform/ios/fast/text/international/bidi-listbox-atsui-expected.txt:
  • platform/ios/fast/text/international/bidi-listbox-expected.txt:
  • platform/ios/fast/text/international/bidi-menulist-expected.txt:
  • platform/ios/fast/text/international/hindi-spacing-expected.txt:
  • platform/ios/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/ios/imported/w3c/web-platform-tests/selection/selection-select-all-move-input-crash-expected.txt:
  • platform/ios/media/controls-styling-strict-expected.txt:
  • platform/ios/svg/custom/foreign-object-skew-expected.txt:
  • platform/ios/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/ios/svg/hixie/mixed/003-expected.txt:
  • platform/ios/tables/mozilla/bugs/45621-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug194024-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug52506-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug68912-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/ios/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/ios/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/ios/tables/mozilla/core/margins-expected.txt:
  • platform/ios/tables/mozilla/dom/tableDom-expected.txt:
  • platform/ios/tables/mozilla/other/move_row-expected.txt:
  • platform/ios/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/ios/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/ios/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/ios/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/ios/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/ios/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
  • platform/ios/transforms/2d/zoom-menulist-expected.txt:
  • platform/ios/transforms/3d/general/perspective-non-layer-expected.txt:
4:47 PM Changeset in webkit [274599] by Alan Coon
  • 1 copy in tags/Safari-611.1.21.1.12

Tag Safari-611.1.21.1.12.

4:47 PM Changeset in webkit [274598] by Russell Epstein
  • 1 copy in tags/Safari-611.1.21.0.8

Tag Safari-611.1.21.0.8.

4:12 PM Changeset in webkit [274597] by Simon Fraser
  • 8 edits
    2 adds in trunk

Avoid unnecessary repaints when transforms change
​https://bugs.webkit.org/show_bug.cgi?id=223307

Reviewed by Zalan Bujtas.

Source/WebCore:

RenderElement::repaintBeforeStyleChange() issues repaints when transforms, opacity
or filters change because the layer might disappear, but we know that this only happens
if the style changes between having a transform/filter/non-1 opacity and not.

Transform changes in general repaint via layout (the RenderLayer gets setLayerNeedsFullRepaint()
called on it). Opacity and filter changes repaint by virtue of a RepaintLayer style diff.

This reduces some repaint calls in the MotionMark leaves test.

This code is a mess and dates from ancient times (r7675); it doens't know about self-painting
layers, and duplicates work done in RenderLayerModelObject::styleDidChange() when a renderer
loses its layer, but that's too much to change now.

Test: fast/repaint/transform-change-repaint.html

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::repaintBeforeStyleChange):

  • rendering/RenderElement.h:

(WebCore::RenderElement::createsGroupForStyle):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::hasOpacity const):

  • style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjust const):

LayoutTests:

  • fast/repaint/transform-change-repaint-expected.txt: Added.
  • fast/repaint/transform-change-repaint.html: Added.
3:59 PM Changeset in webkit [274596] by commit-queue@webkit.org
  • 7 edits in trunk

[css-grid] Incorrect track sizing when using relative sized items in 'auto' column tracks
​https://bugs.webkit.org/show_bug.cgi?id=191627

Patch by Ziran Sun <Ziran Sun> on 2021-03-17
Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

Updated expectation file for test grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html.
All sub-tests in this test file are now all passed.

  • web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001-expected.txt:

Source/WebCore:

Containing block for a grid item is the grid area it's located in. During the GridTrackSizingAlgorithm,
we determine that this item has a relative size (percent in this case) and that the grid area is still
indefinite. Hence, we set nullopt for the grid area width and mark the item for layout. During the item's
layout, we call this RenderBox::containingBlockLogicalWidthForContent to determine the available height.
However, this method checks the containing block's width if the overridingContentLogicalWidth is nullopt,
which is incorrect for grid items. We should never use the grid container for resolving grid item's size.

This change is to return 0_lu for grid item when overridingContainingBlockContentLogicalHeight() or
overridingContainingBlockContentLogicalWidth() returns nullopt rather than use containing block's width
or height.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockLogicalWidthForContent const):

LayoutTests:

3:40 PM Changeset in webkit [274595] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS wk2 ] media/track/track-cue-css.html is a flakey Image failure
​https://bugs.webkit.org/show_bug.cgi?id=223387

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Updating test results to Pass ImageOnlyFailure while test is reviewed.
3:33 PM Changeset in webkit [274594] by Chris Dumez
  • 2 edits in trunk/Source/WTF

Memory limit per tab shrinks as you open tabs in the same WebContent process (may affect Google Drive, Dropbox, etc.)
​https://bugs.webkit.org/show_bug.cgi?id=223394
<rdar://75499387>

Reviewed by Geoffrey Garen.

Make sure the process memory limit scales with the number of web pages it holds (without cap on the number of
pages).

  • wtf/MemoryPressureHandler.cpp:

(WTF::thresholdForMemoryKillOfInactiveProcess):

2:59 PM Changeset in webkit [274593] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: use native datetime-local picker for changing expires value in cookie popover
​https://bugs.webkit.org/show_bug.cgi?id=209389

Reviewed by BJ Burg.

r259173 already made it so that the <input> for Expires used datetime-local, so nothing
needs to be changed to adopt that. We still want to keep the "input" event listener that
parses and validates the value (or placeholder) of the <input type="datetime-local">
because dates in the past should be considered invalid.

  • UserInterface/Views/CookiePopover.js:

(WI.CookiePopover.prototype.show): Add step = 1 so that the seconds field is shown.
(WI.CookiePopover.prototype.show.formatDate): Added.
(WI.CookiePopover.prototype.show.formatDate.pad): Added.

  • UserInterface/Views/CookiePopover.css: Remove the FIXME comment.
2:37 PM Changeset in webkit [274592] by BJ Burg
  • 6 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: add GridOverlay diagnostic event and related hooks
​https://bugs.webkit.org/show_bug.cgi?id=223256
<rdar://problem/75478239>

Patch by Razvan Caliman <Razvan Caliman> on 2021-03-17
Reviewed by BJ Burg.

Add instrumentation to log telemetry for the CSS Grid Inspector.

We want to answer these questions:

  • How do users prefer to toggle the overlay, in-context from grid badges in the DOM tree or from the aggregated grid node overlay list in Layout sidebar panel?
  • Which overlay options are most used? Did we pick good defaults or do users prefer others?
  • UserInterface/Base/Main.js:

(WI.contentLoaded):

  • UserInterface/Controllers/GridOverlayDiagnosticEventRecorder.js: Added.

(WI.GridOverlayDiagnosticEventRecorder):
(WI.GridOverlayDiagnosticEventRecorder.prototype.setup):
(WI.GridOverlayDiagnosticEventRecorder.prototype.teardown):
(WI.GridOverlayDiagnosticEventRecorder.prototype._handleGridOverlayShown):

  • UserInterface/Controllers/OverlayManager.js:

(WI.OverlayManager.prototype.showGridOverlay):
(WI.OverlayManager.prototype.toggleGridOverlay):
(WI.OverlayManager.prototype._handleGridSettingChanged):

  • UserInterface/Main.html:
  • UserInterface/Views/CSSGridSection.js:

(WI.CSSGridSection.prototype._handleToggleAllCheckboxChanged):
(WI.CSSGridSection.prototype.layout):

  • UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype._gridBadgeClicked):

2:25 PM Changeset in webkit [274591] by Peng Liu
  • 6 edits in trunk

[GPUP] Some media-source tests fail/timeout when media in GPU Process is enabled
​https://bugs.webkit.org/show_bug.cgi?id=221686

Reviewed by Jer Noble.

Source/WebKit:

For a MediaPlayerPrivateRemote, if it is owned by a video element with a reference
to a MediaSource, it needs to use the duration information from the MediaSource.

Covered by existing tests.

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::durationMediaTime const):

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
  • WebProcess/GPU/media/MediaSourcePrivateRemote.h:

LayoutTests:

  • platform/mac/TestExpectations:
2:24 PM Changeset in webkit [274590] by Matt Lewis
  • 3 edits in trunk/Tools

Add AppleSilicon and Debug WK2 Support to EWS
​https://bugs.webkit.org/show_bug.cgi?id=223393

Reviewed by Aakash Jain.

  • CISupport/ews-app/ews/views/statusbubble.py:

(StatusBubble):

  • CISupport/ews-build/config.json:
2:14 PM Changeset in webkit [274589] by eric.carlson@apple.com
  • 6 edits in trunk

[GPUP] media/video-set-rate-from-pause.html fails
​https://bugs.webkit.org/show_bug.cgi?id=223386
<rdar://problem/75533945>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, this fixes an existing test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setPlaybackRate): Remove the m_player->rate() != rate
check before setting player rate, there may be a change in flight and the test
is already done in the player itself.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::invalidateCachedDuration): Drive-by fix:
update logging.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::setPlayerRate): Don't set m_cachedRate,
it is already done in the rateDidChange callback from AVFoundation.
(WebCore::MediaPlayerPrivateAVFoundationObjC::rateDidChange): Drive-by fix: do nothing
when the rate hasn't changed.

LayoutTests:

  • platform/wk2/TestExpectations: Remove test that passes.
2:12 PM Changeset in webkit [274588] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Add logging to FullscreenManager.
​https://bugs.webkit.org/show_bug.cgi?id=223389

Reviewed by Eric Carlson.

  • dom/FullscreenManager.cpp:

(WebCore::logClassName):
(WebCore::logChannel):
(WebCore::m_logIdentifier):
(WebCore::FullscreenManager::requestFullscreenForElement):
(WebCore::FullscreenManager::cancelFullscreen):
(WebCore::FullscreenManager::exitFullscreen):
(WebCore::FullscreenManager::willEnterFullscreen):
(WebCore::FullscreenManager::didEnterFullscreen):
(WebCore::FullscreenManager::willExitFullscreen):
(WebCore::FullscreenManager::didExitFullscreen):
(WebCore::FullscreenManager::adjustFullscreenElementOnNodeRemoval):

  • dom/FullscreenManager.h:
1:47 PM Changeset in webkit [274587] by Jonathan Bedard
  • 7 edits in trunk/Tools

[webkitscmpy] Support git-svn in remote mocks
​https://bugs.webkit.org/show_bug.cgi?id=223397
<rdar://problem/75541426>

Reviewed by Dewei Zhu.

  • Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
  • Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:

(BitBucket.request): Add git-svn tag.

  • Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:

(GitHub._commit_response): Add git-svn tag.

  • Scripts/libraries/webkitscmpy/webkitscmpy/mocks/svn-repo.json: Add hashes to mock svn repo.
  • Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:

(TestGitHub.test_commit_hash):
(TestGitHub.test_commit_revision):
(TestBitBucket.test_commit_hash):
(TestBitBucket.test_commit_revision):

1:46 PM Changeset in webkit [274586] by commit-queue@webkit.org
  • 13 edits
    4 adds in trunk

Show media session image artwork in Now Playing information pane.
​https://bugs.webkit.org/show_bug.cgi?id=223118
<rdar://problem/75360166>

Patch by Jean-Yves Avenard <Jean-Yves Avenard> on 2021-03-17
Reviewed by Eric Carlson.

Source/WebCore:

Test: fast/mediasession/metadata/artworkdownload.html
Manually tested for Now Playing system integration.

  • Modules/mediasession/MediaMetadata.cpp:

(WebCore::ArtworkImageLoader::ArtworkImageLoader): Implementation of new ArtworkImageLoader class.
(WebCore::ArtworkImageLoader::~ArtworkImageLoader):
(WebCore::ArtworkImageLoader::requestImageResource):
(WebCore::ArtworkImageLoader::notifyFinished):
(WebCore::MediaMetadata::setMediaSession):
(WebCore::MediaMetadata::resetMediaSession):
(WebCore::MediaMetadata::setArtwork):
(WebCore::MediaMetadata::refreshArtworkImage):
(WebCore::MediaMetadata::setArtworkImage): Make use of new ArtworkImageLoader class.

  • Modules/mediasession/MediaMetadata.h: Add new ArtworkImageLoader class. Allows to download from a given URL in relation to a given Document.

(WebCore::MediaMetadata::artworkSrc const):
(WebCore::MediaMetadata::artworkImage const):

  • Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::setActionHandler): fix whitespace (automatic).
(WebCore::MediaSession::document const): Add method, used by MediaMetadata

  • Modules/mediasession/MediaSession.h:
  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::wirelessVideoPlaybackDisabled const): fix whitespace (automatic).
(WebCore::MediaElementSession::mediaEngineUpdated): fix whitespace (automatic).
(WebCore::MediaElementSession::didReceiveRemoteControlCommand): fix whitespace (automatic).
(WebCore::MediaElementSession::nowPlayingInfo const): Add artwork to NowPlayingInfo struct.

  • html/MediaElementSession.h: Add method, used by MediaMetadata
  • platform/audio/NowPlayingInfo.h: Add NowPlayingInfoArtwork struct.

(WebCore::NowPlayingInfoArtwork::operator== const):
(WebCore::NowPlayingInfoArtwork::operator!= const):
(WebCore::NowPlayingInfoArtwork::encode const):
(WebCore::NowPlayingInfoArtwork::decode):
(WebCore::NowPlayingInfo::operator== const):
(WebCore::NowPlayingInfo::operator!= const):
(WebCore::NowPlayingInfo::encode const):
(WebCore::NowPlayingInfo::decode):

  • platform/audio/cocoa/MediaSessionManagerCocoa.mm: Add artwork image to CFDictionary

(WebCore::MediaSessionManagerCocoa::setNowPlayingInfo):
(WebCore::MediaSessionManagerCocoa::updateNowPlayingInfo):

  • testing/Internals.cpp: Add private interface to test ArtworkImageLoader class.

(WebCore::Internals::~Internals): Reject pending ArtworkImageLoader promise if any.
(WebCore::Internals::grabNextMediaStreamTrackFrame): Add missing move.
(WebCore::Internals::loadArtworkImage): New method to load an image.

  • testing/Internals.h: New method.
  • testing/Internals.idl: New method.

LayoutTests:

  • fast/mediasession/metadata/artworkdownload-expected.txt: Added.
  • fast/mediasession/metadata/artworkdownload.html: Added.
1:42 PM Changeset in webkit [274585] by dino@apple.com
  • 5 edits in trunk/Source/ThirdParty/ANGLE

ANGLE Metal fixups for program generation, readPixels
​https://bugs.webkit.org/show_bug.cgi?id=223260

Patch by Kyle Piddington <Kyle Piddington> on 2021-03-17
Reviewed by Dean Jackson.

This diff fixes the following tests:
webgl/2.0.0/conformance2/glsl3/texture-offset-uniform-texture-coordinate.html Is fixed by dropping 'thread' qualifiers on our intermediate texture sampling helper functions. Previously, any uniforms used in sampling textures would have had issues with their namespace.
webgl/2.0.0/conformance2/reading/read-pixels-pack-parameters.html is fixed by correcting an issue with reading from outside the framebuffer. ANGLE Metal was previously reading to the start of the output array, rather than a proper offset.
webgl/2.0.0/conformance2/glsl3/array-equality.html is fixed by adding additional equality functions for handling arrays of structs.

  • src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp:

(GetOperatorString):

  • src/compiler/translator/TranslatorMetalDirect/ProgramPrelude.cpp:
  • src/libANGLE/renderer/metal/FrameBufferMtl.mm:

(rx::FramebufferMtl::readPixels):

1:22 PM Changeset in webkit [274584] by Russell Epstein
  • 3 edits in branches/safari-611.1.21.1-branch/Source/WebCore

Cherry-pick r274573. rdar://problem/75538214

Degraded ScriptProcessorNode performance/quality for (14.0.3+ and iOS 14.4.1+)
​https://bugs.webkit.org/show_bug.cgi?id=223380

Reviewed by Geoffrey Garen.

By extending the scope of the lock in ScriptProcessorNode::process(), r273542 essentially
disabled double-buffering and thus negatively impacted rendering quality.

To address the issue, we now have 2 locks, one per rendering buffer (since we're using
double buffering) and only grab the lock we require when interacting with the buffers
for this index. This maintains thread-safety while re-enabling double buffering.

  • Modules/webaudio/ScriptProcessorNode.cpp: (WebCore::ScriptProcessorNode::createInputBufferForJS const): Avoid duplicate call to topologyMatches() since copyTo() already calls it internally and returns false when !topologyMatches().

(WebCore::ScriptProcessorNode::process):

  • Modules/webaudio/ScriptProcessorNode.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:17 PM Changeset in webkit [274583] by Russell Epstein
  • 8 edits in branches/safari-611.1.21.1-branch/Source

Versioning.

WebKit-7611.1.21.1.12

1:11 PM Changeset in webkit [274582] by Russell Epstein
  • 3 edits in branches/safari-611.1.21.0-branch/Source/WebCore

Cherry-pick r274573. rdar://problem/75538213

Degraded ScriptProcessorNode performance/quality for (14.0.3+ and iOS 14.4.1+)
​https://bugs.webkit.org/show_bug.cgi?id=223380

Reviewed by Geoffrey Garen.

By extending the scope of the lock in ScriptProcessorNode::process(), r273542 essentially
disabled double-buffering and thus negatively impacted rendering quality.

To address the issue, we now have 2 locks, one per rendering buffer (since we're using
double buffering) and only grab the lock we require when interacting with the buffers
for this index. This maintains thread-safety while re-enabling double buffering.

  • Modules/webaudio/ScriptProcessorNode.cpp: (WebCore::ScriptProcessorNode::createInputBufferForJS const): Avoid duplicate call to topologyMatches() since copyTo() already calls it internally and returns false when !topologyMatches().

(WebCore::ScriptProcessorNode::process):

  • Modules/webaudio/ScriptProcessorNode.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:10 PM Changeset in webkit [274581] by Aditya Keerthi
  • 15 edits
    2 adds in trunk

[iOS] Refactor WKFileUploadPanel to use UniformTypeIdentifiers
​https://bugs.webkit.org/show_bug.cgi?id=223000
<rdar://problem/75237774>

Reviewed by Tim Horton.

Source/WebKit:

Uniform type identifier APIs in MobileCoreServices were deprecated in
iOS 14. Instead, use the new APIs in the UniformTypeIdentifiers
framework.

This patch also cleans up instances of code duplication when comparing
uniform type idenfifiers and increases the test coverage for
WKFileUploadPanel.

Test: fast/forms/ios/file-upload-panel-accept.html

  • Configurations/WebKit.xcconfig:

Link UniformTypeIdentifiers.framework on watchOS and tvOS.

  • UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:

Expose _filePickerAcceptedTypeIdentifiers to enable testing of accepted
file types.

  • UIProcess/API/ios/WKWebViewTestingIOS.mm:

(-[WKWebView _filePickerAcceptedTypeIdentifiers]):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView filePickerAcceptedTypeIdentifiers]):

  • UIProcess/ios/forms/WKFileUploadPanel.h:
  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(setContainsUTIThatConformsTo):

Modified this helper method to take in an NSSet rather than an NSArray
to avoid unnecessary conversion. Replaced MobileCoreServices API usage
with UniformTypeIdentifiers API.

(-[WKFileUploadPanel presentWithParameters:resultListener:]):

Determine the accepted UTIs and image picker configuration once before
presentation and store them in member variables to reduce code
duplication.

(-[WKFileUploadPanel currentAvailableActionTitles]):
(-[WKFileUploadPanel acceptedTypeIdentifiers]):

Expose the accepted type identifers as a sorted array for testing.

(-[WKFileUploadPanel _mediaTypesForPickerSourceType:]):
(-[WKFileUploadPanel _cameraButtonLabel]):
(-[WKFileUploadPanel contextMenuInteraction:configurationForMenuAtLocation:]):
(-[WKFileUploadPanel showFilePickerMenu]):
(-[WKFileUploadPanel showDocumentPickerMenu]):
(-[WKFileUploadPanel _uploadItemFromMediaInfo:successBlock:failureBlock:]):

Tools:

Added UIScriptController hooks to retrieve the type identifiers for
a presented file upload panel.

  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  • TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::filePickerAcceptedTypeIdentifiers):

  • WebKitTestRunner/ios/UIScriptControllerIOS.h:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::filePickerAcceptedTypeIdentifiers):

LayoutTests:

Added a test to verify that the value of the accept attribute for file
inputs is mapped to the correct set of type identifiers.

  • fast/forms/ios/file-upload-panel-accept-expected.txt: Added.
  • fast/forms/ios/file-upload-panel-accept.html: Added.
  • resources/ui-helper.js:

(window.UIHelper.dismissFilePicker):
(window.UIHelper.filePickerAcceptedTypeIdentifiers):

12:58 PM Changeset in webkit [274580] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Optimize RenderCounter::rendererStyleChanged()
​https://bugs.webkit.org/show_bug.cgi?id=223306

Reviewed by Zalan Bujtas.

Optimize RenderCounter::rendererStyleChanged() for the case of no counters, which is
the most common; inline the check for no counters on old or new styles; this avoid
calling generatingElement() in the common case.

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::rendererStyleChangedSlowCase):
(WebCore::RenderCounter::rendererStyleChanged): Deleted.

  • rendering/RenderCounter.h:

(WebCore::RenderCounter::rendererStyleChanged):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::styleDidChange):

12:55 PM Changeset in webkit [274579] by Russell Epstein
  • 8 edits in branches/safari-611.1.21.0-branch/Source

Versioning.

WebKit-7611.1.21.0.8

12:22 PM Changeset in webkit [274578] by Devin Rousso
  • 5 edits in trunk/Source/WebCore

don't use raw unicode characters in modern media controls JS
​https://bugs.webkit.org/show_bug.cgi?id=223390

Reviewed by Eric Carlson.

  • Modules/modern-media-controls/controls/icon-service.js:
  • Modules/modern-media-controls/controls/time-label.js:

(TimeLabel.prototype.commitProperty):

  • Modules/modern-media-controls/media/placard-support.js:

(PlacardSupport.prototype._updateAirPlayPlacard):

  • en.lproj/modern-media-controls-localized-strings.js:

Drive-by: Add missing strings and remove unused ones.

12:10 PM Changeset in webkit [274577] by Brent Fulgham
  • 6 edits in trunk/Source

[Cocoa] Populate NSURLSession with attributed bundle ID
​https://bugs.webkit.org/show_bug.cgi?id=223382
<rdar://problem/75498230>

Reviewed by Alex Christensen.

Source/WebCore/PAL:

Add forward declarations for attributed bundle ID.

  • pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

Update NSURLSession property with attributed bundle ID when supported by the platform.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
(WebKit::NetworkSessionCocoa::initializeEphemeralStatelessSession):

Source/WTF:

Add new HAVE_CFNETWORK_NSURLSESSION_ATTRIBUTED_BUNDLE_IDENTIFIER macro.

  • wtf/PlatformHave.h:
12:06 PM Changeset in webkit [274576] by Alan Bujtas
  • 5 edits
    2 adds in trunk

Do not collapse ruby's internal anonymous blocks
​https://bugs.webkit.org/show_bug.cgi?id=223296
<rdar://75486993>

Reviewed by Antti Koivisto.

Source/WebCore:

The ruby subtree stucture is as follows:

1 RenderRuby object, corresponding to the whole <ruby> HTML element
1+ RenderRubyRun (anonymous)

0 or 1 RenderRubyText (anonymous)
0 or 1 RenderRubyBase (anonymous)

This patch ensures that we don't collapse those anonymous blocks while destroying inner content.

Test: fast/ruby/crash-when-ruby-base-is-collapsed.html

  • rendering/RenderRubyRun.h:

LayoutTests:

  • fast/ruby/crash-when-ruby-base-is-collapsed-expected.txt: Added.
  • fast/ruby/crash-when-ruby-base-is-collapsed.html: Added.
11:56 AM Changeset in webkit [274575] by Nikita Vasilyev
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: remove experimental setting and enable "grid" badges
​https://bugs.webkit.org/show_bug.cgi?id=223209
<rdar://problem/75442185>

Reviewed by BJ Burg.

  • UserInterface/Base/Setting.js:
  • UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype._updateGridBadge):

  • UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

11:56 AM Changeset in webkit [274574] by Chris Gambrell
  • 30 edits
    36 adds
    34 deletes in trunk/LayoutTests

[LayoutTests] Convert http/tests/cache convert PHP to Python
​https://bugs.webkit.org/show_bug.cgi?id=222935
<rdar://problem/75183314>

Reviewed by Jonathan Bedard.

  • http/tests/cache/cache-redirections.html:
  • http/tests/cache/cached-main-resource.html:
  • http/tests/cache/cachedEntry-waits-for-response-policy.html:
  • http/tests/cache/content-type-ignored-during-revalidation.html:
  • http/tests/cache/disk-cache/disk-cache-redirect-to-data.html:
  • http/tests/cache/disk-cache/disk-cache-remove-several-pending-writes.html:
  • http/tests/cache/disk-cache/redirect-chain-limits.html:
  • http/tests/cache/disk-cache/resources/json.php: Removed.
  • http/tests/cache/disk-cache/resources/json.py: Added.

(send304):

  • http/tests/cache/disk-cache/resources/make-sha1-collision.php: Removed.
  • http/tests/cache/disk-cache/resources/make-sha1-collision.py: Added.
  • http/tests/cache/disk-cache/resources/redirect-chain.php: Removed.
  • http/tests/cache/disk-cache/resources/redirect-chain.py: Added.
  • http/tests/cache/disk-cache/resources/redirect-to-data.php: Removed.
  • http/tests/cache/disk-cache/resources/redirect-to-data.py: Added.
  • http/tests/cache/disk-cache/shattered-deduplication.html:
  • http/tests/cache/disk-cache/speculative-validation/cacheable-redirect.html:
  • http/tests/cache/disk-cache/speculative-validation/http-auth.html:
  • http/tests/cache/disk-cache/speculative-validation/resources/cacheable-redirect-frame.php: Removed.
  • http/tests/cache/disk-cache/speculative-validation/resources/cacheable-redirect-frame.py: Added.
  • http/tests/cache/disk-cache/speculative-validation/resources/css-to-revalidate.php: Removed.
  • http/tests/cache/disk-cache/speculative-validation/resources/css-to-revalidate.py: Added.
  • http/tests/cache/disk-cache/speculative-validation/resources/frame-with-authenticated-resource.php: Removed.
  • http/tests/cache/disk-cache/speculative-validation/resources/frame-with-authenticated-resource.py: Added.
  • http/tests/cache/disk-cache/speculative-validation/resources/redirect-to-css.php: Removed.
  • http/tests/cache/disk-cache/speculative-validation/resources/redirect-to-css.py: Added.
  • http/tests/cache/disk-cache/speculative-validation/resources/request-headers-script.php: Removed.
  • http/tests/cache/disk-cache/speculative-validation/resources/request-headers-script.py: Added.
  • http/tests/cache/disk-cache/speculative-validation/resources/resource-with-auth.php: Removed.
  • http/tests/cache/disk-cache/speculative-validation/resources/resource-with-auth.py: Added.
  • http/tests/cache/disk-cache/speculative-validation/resources/validation-request-frame.php: Removed.
  • http/tests/cache/disk-cache/speculative-validation/resources/validation-request-frame.py: Added.
  • http/tests/cache/disk-cache/speculative-validation/validation-request.html:
  • http/tests/cache/history-navigation-no-resource-revalidation.html:
  • http/tests/cache/iframe-304-crash-expected.txt:
  • http/tests/cache/iframe-304-crash.html:
  • http/tests/cache/iframe-detach.html:
  • http/tests/cache/link-prefetch-main-resource-iframe.html:
  • http/tests/cache/link-prefetch-main-resource.html:
  • http/tests/cache/main-resource-304-reload.html:
  • http/tests/cache/post-redirect-get.php: Removed.
  • http/tests/cache/post-redirect-get.py: Added.
  • http/tests/cache/post-with-cached-subresources.php: Removed.
  • http/tests/cache/post-with-cached-subresources.py: Added.
  • http/tests/cache/recursive-validation.html:
  • http/tests/cache/redirect-referer.html:
  • http/tests/cache/reload-main-resource.php: Removed.
  • http/tests/cache/reload-main-resource.py: Added.
  • http/tests/cache/resources/body.php: Removed.
  • http/tests/cache/resources/body.py: Added.
  • http/tests/cache/resources/cacheable-iframe.php: Removed.
  • http/tests/cache/resources/cacheable-iframe.py: Added.
  • http/tests/cache/resources/cacheable-random-text.php: Removed.
  • http/tests/cache/resources/cacheable-random-text.py: Added.
  • http/tests/cache/resources/iframe304.php: Removed.
  • http/tests/cache/resources/iframe304.py: Added.
  • http/tests/cache/resources/iframe304body.php: Removed.
  • http/tests/cache/resources/iframe304body.py: Added.
  • http/tests/cache/resources/load-and-check-referer.php: Removed.
  • http/tests/cache/resources/load-and-check-referer.py: Added.

(contentType):

  • http/tests/cache/resources/no-cache-main-resource-next.php: Removed.
  • http/tests/cache/resources/no-cache-main-resource-next.py: Added.
  • http/tests/cache/resources/no-cache-main-resource.php: Removed.
  • http/tests/cache/resources/no-cache-main-resource.py: Added.
  • http/tests/cache/resources/no-cache-with-validation.php: Removed.
  • http/tests/cache/resources/no-cache-with-validation.py: Added.
  • http/tests/cache/resources/partitioned-cache-echo-state.php: Removed.
  • http/tests/cache/resources/partitioned-cache-echo-state.py: Added.
  • http/tests/cache/resources/partitioned-cache-loader.html:
  • http/tests/cache/resources/permanent-redirect.py: Added.
  • http/tests/cache/resources/post-image-to-verify.php: Removed.
  • http/tests/cache/resources/post-image-to-verify.py: Added.
  • http/tests/cache/resources/prefetched-main-resource-iframe.php: Removed.
  • http/tests/cache/resources/prefetched-main-resource-iframe.py: Added.
  • http/tests/cache/resources/prefetched-main-resource.php: Removed.
  • http/tests/cache/resources/prefetched-main-resource.py: Added.
  • http/tests/cache/resources/redirect-referer-iframe.html:
  • http/tests/cache/resources/reload-main-resource-iframe.php: Removed.
  • http/tests/cache/resources/reload-main-resource-iframe.py: Added.
  • http/tests/cache/resources/slow-iframe.php: Removed.
  • http/tests/cache/resources/slow-iframe.py: Added.
  • http/tests/cache/resources/stylesheet-html.php: Removed.
  • http/tests/cache/resources/stylesheet-html.py: Added.
  • http/tests/cache/resources/stylesheet304-bad-content-type.php: Removed.
  • http/tests/cache/resources/stylesheet304-bad-content-type.py: Added.
  • http/tests/cache/resources/stylesheet304.php: Removed.
  • http/tests/cache/resources/svg-defs-vary.php: Removed.
  • http/tests/cache/resources/svg-defs-vary.py: Added.
  • http/tests/cache/resources/xhr-vary-header-response.php: Removed.
  • http/tests/cache/resources/xhr-vary-header-response.py: Added.
  • http/tests/cache/resources/xhr-vary-header-subframe.html:
  • http/tests/cache/stylesheet-sharing.html:
  • http/tests/cache/vary-frameless-document.html:
  • http/tests/cache/xhr-body.html:
  • http/tests/cache/xhr-vary-header.html:
  • http/tests/resources/touch-temp-file.py: Added.
  • http/tests/resources/write-temp-file.py: Added.
  • http/tests/xmlhttprequest/cacheable-cross-origin-redirect-crash.html:
  • platform/win/TestExpectations:
11:52 AM Changeset in webkit [274573] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Degraded ScriptProcessorNode performance/quality for (14.0.3+ and iOS 14.4.1+)
​https://bugs.webkit.org/show_bug.cgi?id=223380

Reviewed by Geoffrey Garen.

By extending the scope of the lock in ScriptProcessorNode::process(), r273542 essentially
disabled double-buffering and thus negatively impacted rendering quality.

To address the issue, we now have 2 locks, one per rendering buffer (since we're using
double buffering) and only grab the lock we require when interacting with the buffers
for this index. This maintains thread-safety while re-enabling double buffering.

  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::createInputBufferForJS const):
Avoid duplicate call to topologyMatches() since copyTo() already calls it internally
and returns false when !topologyMatches().

(WebCore::ScriptProcessorNode::process):

  • Modules/webaudio/ScriptProcessorNode.h:
11:21 AM Changeset in webkit [274572] by Amir Mark Jr.
  • 2 edits in trunk/Tools

REGRESSION (r274460): [macOS] TestWebKitAPI.Fullscreen.WKViewDelegate is timing out
​https://bugs.webkit.org/show_bug.cgi?id=223282

Unreviewed test gardening.

  • TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:

(TestWebKitAPI::TEST): Disabling the test until it is resolved

10:40 AM Changeset in webkit [274571] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS wk2 ARM64 ] 2 imported/w3c/web-platform-tests/webrtc are flakey text failures
​https://bugs.webkit.org/show_bug.cgi?id=223385

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Updating test expectations to Pass Failure for Apple Silicon systems, and removing the Mojave test expectation while tests are being reviewed.
10:39 AM Changeset in webkit [274570] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[build.webkit.org] Remove code specific to old Buildbot - part 2
​https://bugs.webkit.org/show_bug.cgi?id=222928

Reviewed by Jonathan Bedard.

  • CISupport/build-webkit-org/steps.py:

(ConfigureBuild.start):

10:37 AM Changeset in webkit [274569] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Derive index EUC-KR from ICU
​https://bugs.webkit.org/show_bug.cgi?id=223103

Reviewed by Yusuke Suzuki.

This decreases the binary size of WebCore by a little under 70kb.

  • platform/text/EncodingTables.cpp:

(WebCore::eucKR):

10:28 AM Changeset in webkit [274568] by achristensen@apple.com
  • 11 edits in trunk

Allow UniqueRef to be the value of a HashMap
​https://bugs.webkit.org/show_bug.cgi?id=223240

Reviewed by Youenn Fablet.

Source/WebKit:

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::populateFromMemoryStore):

  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::pruneResources):
(WebKit::ResourceLoadStatisticsMemoryStore::aggregatedThirdPartyData const):
(WebKit::ResourceLoadStatisticsMemoryStore::classifyPrevalentResources):
(WebKit::ResourceLoadStatisticsMemoryStore::ensureResourceStatisticsForRegistrableDomain):
(WebKit::ResourceLoadStatisticsMemoryStore::mergeStatistics):
(WebKit::ResourceLoadStatisticsMemoryStore::updateCookieBlocking):
(WebKit::ResourceLoadStatisticsMemoryStore::processStatistics const):
(WebKit::ResourceLoadStatisticsMemoryStore::registrableDomainsToDeleteOrRestrictWebsiteDataFor):
(WebKit::ResourceLoadStatisticsMemoryStore::pruneStatisticsIfNeeded):
(WebKit::ResourceLoadStatisticsMemoryStore::insertExpiredStatisticForTesting):

  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::addChallengeToChallengeMap):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):

  • Shared/Authentication/AuthenticationManager.h:

Source/WTF:

This has the advantage over std::unique_ptr of never providing a null value when you iterate HashMap.values

  • wtf/HashIterators.h:

(WTF::HashTableConstValuesIterator::get const):

  • wtf/HashTraits.h:

(WTF::HashTraits<UniqueRef<T>>::emptyValue):
(WTF::HashTraits<UniqueRef<T>>::constructDeletedValue):
(WTF::HashTraits<UniqueRef<T>>::isDeletedValue):
(WTF::HashTraits<UniqueRef<T>>::peek):
(WTF::HashTraits<UniqueRef<T>>::take):

Tools:

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):

10:23 AM Changeset in webkit [274567] by mmaxfield@apple.com
  • 3 edits
    1 add in trunk

Laying out complex text in columns is O(n2)
​https://bugs.webkit.org/show_bug.cgi?id=223363
<rdar://problem/68279075>

Reviewed by Zalan Bujtas.

PerformanceTests:

  • Layout/complex-columns.html: Added.

Source/WebCore:

When we perform line breaking in complex text, we create a persistent TextLayout object for the entire element, and ask
it questions about how wide various substrings are in the element. Our calling pattern is like this:

layout.width(a, b);
layout.width(b, c);
layout.width(c, d);
layout.width(d, e);

The implementation of TextLayout::width() is like this:

m_controller->advance(before);
float beforeWidth = m_controller->runWidthSoFar();
m_controller->advance(after);
float afterWidth = m_controller->runWidthSoFar();

This means that ComplexTextController is getting called twice in a row with the same position. However, the implementation of
ComplexTextController::advance() has:

if (offset <= m_currentCharacter) {

…
m_glyphInCurrentRun = 0;
…

}

The condition is true here, because it's getting called twice in a row with the same condition. However, when the condition
is true, we throw away all the previous work we've done during previous calls to ComplexTextController::advance().

This patch causes an 18x speedup on the performance test.

Performance Test: Layout/complex-columns.html

  • platform/graphics/ComplexTextController.cpp:

(WebCore::ComplexTextController::advance):

10:22 AM Changeset in webkit [274566] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Use ASCIILiteral over String for CSSValue::separatorCSSText() to avoid allocation
​https://bugs.webkit.org/show_bug.cgi?id=223300

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-03-17
Reviewed by Yusuke Suzuki.

Use ASCIILiteral over String for CSSValue::separatorCSSText() to avoid
allocation, since we know this function will always return an
ASCII string. Also rename separatorCssText to separatorCSSText.

These changes were requested in this comment:
​https://bugs.webkit.org/show_bug.cgi?id=223205#c8

  • css/CSSValue.cpp:

(WebCore::CSSValue::separatorCSSText const):
(WebCore::CSSValue::separatorCssText const):
Rename function separatorCssText to separatorCSSText.

  • css/CSSValue.h:

String CSSValue::separatorCssText --> ASCIILiteral CSSValue::separatorCSSText

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::customCSSText const):
Use auto to capture result of separatorCSSText().

  • css/CSSValuePair.cpp:

(WebCore::CSSValuePair::customCSSText const):
Function separatorCssText was renamed to separatorCSSText.

10:09 AM Changeset in webkit [274565] by Chris Dumez
  • 11 edits in trunk

Maybe-regression(STP121): window.open flakily returning null
​https://bugs.webkit.org/show_bug.cgi?id=222590
<rdar://problem/75211786>

Reviewed by Geoffrey Garen.

Source/WebKit:

This was an IPC ordering bug. WebPageProxy::DidCommitLoadForFrame is async and WebPageProxy::CreateNewPage is
sync. As a result, it was possible for the WebPageProxy::CreateNewPage to get processed *BEFORE* the
WebPageProxy::DidCommitLoadForFrame IPC. This was causing trouble because Safari rejects the popup opening if
the main frame is doing a provisional load.

To address the issue, introduce a new IPC::SendSyncOption::MaintainOrderingWithAsyncMessages flag and
use it on WebPageProxy::CreateNewPage sync IPC so that it gets processed in order with surrounding async
messages.

  • Platform/IPC/Connection.cpp:

(IPC::Connection::SyncMessageState::processIncomingMessage):
(IPC::Connection::sendSyncMessage):

  • Platform/IPC/Connection.h:
  • Platform/IPC/Decoder.cpp:

(IPC::Decoder::shouldMaintainOrderingWithAsyncMessages const):

  • Platform/IPC/Decoder.h:
  • Platform/IPC/Encoder.cpp:

(IPC::Encoder::setShouldMaintainOrderingWithAsyncMessages):

  • Platform/IPC/Encoder.h:
  • Platform/IPC/MessageFlags.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:

(TestWebKitAPI::TEST):
(TestWebKitAPI::checkFrameLoadStateAndCreateNewPage):

10:09 AM Changeset in webkit [274564] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION (r272019): Momentum scrolling in proximity css-scroll-snap scroll areas broken
​https://bugs.webkit.org/show_bug.cgi?id=223375

Patch by Martin Robinson <​mrobinson@igalia.com> on 2021-03-17
Reviewed by Simon Fraser.

Selectively revert the problematic refactoring in r272019. It is difficult to revert
the entire change since a non-trivial amount of subsequent changes depend on it.

No new tests. This change is a selective revert and animation for momentum
scrolling is very difficult to test.

  • platform/ScrollSnapAnimatorState.cpp:

(WebCore::ScrollSnapAnimatorState::targetOffsetForStartOffset const): Revert changes
from r272019.

10:06 AM Changeset in webkit [274563] by Peng Liu
  • 9 edits in trunk

[GPUP] Some media-source tests fail/timeout when media in GPU Process is enabled
​https://bugs.webkit.org/show_bug.cgi?id=221686

Reviewed by Eric Carlson.

Source/WebKit:

With "GPU Process: Media" enabled, a video element with a reference to a MediaSource
object will schedule a "resize" event after the source buffer scheduling an "update" event.
The root cause is that the MediaPlayerPrivateRemote does not notify its HTMLMediaElement
to change its ready state to HAVE_METADATA after the source buffer receives the initialization
segment (in SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment()).
The requirement is defined in section 3.5.7.6.2 of the specification:
[Initialization Segment Received](​https://www.w3.org/TR/media-source/#sourcebuffer-init-segment-received).

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::setReadyState):

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
  • WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:

(WebKit::SourceBufferPrivateRemote::setReadyState):

LayoutTests:

Fix the wrong description of a test.

  • media/media-source/media-source-resize-expected.txt:
  • media/media-source/media-source-resize.html:
  • platform/gtk/media/media-source/media-source-resize-expected.txt:
  • platform/mac/TestExpectations:
9:53 AM Changeset in webkit [274562] by Brent Fulgham
  • 6 edits in trunk

[Cocoa] Move loadSimulatedRequest API from Private to Public WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=223279
<rdar://problem/75494316>

Reviewed by Darin Adler.

Source/WebKit:

Just moving from SPI headers to API headers (and implementation).

No new tests, since this just changes the visibility of the functionality. The features are
tested with existing TestWebKitAPI tests.

  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView loadSimulatedRequest:withResponse:responseData:]):
(-[WKWebView loadSimulatedRequest:withResponseHTMLString:]):
(-[WKWebView loadFileRequest:allowingReadAccessToURL:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Tools:

Remove private header now that the declarations are in the standard header.

  • TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm:
9:01 AM Changeset in webkit [274561] by Alexey Shvayka
  • 12 edits in trunk

[WebIDL] Fix convertRecord() to throw on enumerable symbol |key|
​https://bugs.webkit.org/show_bug.cgi?id=223231

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/headers/headers-record-expected.txt:

Source/JavaScriptCore:

Export SymbolCoercionError.

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::toStringSlowCase const):

  • runtime/JSCJSValue.h:

Source/WebCore:

This change removes String type filter from getOwnPropertyNames() call [1] so
GetOwnProperty? is invoked for a symbol |key|, which is observable by Proxy,
and a TypeError is raised (with helpful error message) if it's enumerable.

Instead of throwing right in convertRecord(), identifierToString() is added,
making IdentifierConverter reusable and close to the spec [2], rather than
implicitly dependent on identifier being a string.

Identifier::string() called on a symbol returns it's Description?, which is
very undesirable.

Aligns WebKit with Blink and Gecko.

Tests: imported/w3c/web-platform-tests/fetch/api/headers/headers-record.html

fast/dom/DOMURL/searchparams.html

[1] ​https://heycam.github.io/webidl/#es-record (step 3)
[2] ​https://heycam.github.io/webidl/#es-DOMString (step 2)

  • bindings/js/JSDOMConvertRecord.h:

(WebCore::Detail::IdentifierConverter<IDLDOMString>::convert):

  • bindings/js/JSDOMConvertStrings.cpp:

(WebCore::identifierToString):
(WebCore::identifierToByteString):
(WebCore::identifierToUSVString):

  • bindings/js/JSDOMConvertStrings.h:

LayoutTests:

  • fast/dom/DOMURL/searchparams-expected.txt:
  • fast/dom/DOMURL/searchparams.html:
8:54 AM Changeset in webkit [274560] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Optimize FillLayer::imagesIdentical()
​https://bugs.webkit.org/show_bug.cgi?id=223305

Reviewed by Wenson Hsieh.

Test for pointer equality before deep-comparing the FillLayer linked lists. Pointer
equality is common when RenderStyles are cloned.

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::imagesIdentical):

8:20 AM Changeset in webkit [274559] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Set media elements' networkState to NETWORK_IDLE if the connection is interrupted
​https://bugs.webkit.org/show_bug.cgi?id=223242

Patch by Souju TANAKA <​soujyu.tanaka@access-company.com> on 2021-03-17
Reviewed by Eric Carlson.

Media elements' networkState was set to NETWORK_EMPTY if the connection is interrupted after some
media data has been received. This fix changes the state to NETWORK_IDLE, according to recent spec.

No new tests since there seems no way to disconnect network connection during tests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaLoadingFailedFatally):

6:30 AM Changeset in webkit [274558] by youenn@apple.com
  • 28 edits
    2 deletes in trunk

Align device orientation delegate to getUserMedia/geolocation delegates
​https://bugs.webkit.org/show_bug.cgi?id=223247

Reviewed by Eric Carlson.

Source/WebKit:

Refactor code to move device orientation prompt implementation with other prompts in MediaPermissionUtilities.
Update code to use top level origin for prompt.
Update delegate to provide both top level origin and initiating iframe as parameters.
Update the decision handler to take grant, deny or prompt parameter.

Covered by API tests.

  • UIProcess/API/C/WKFrameInfoRef.cpp:

(WKFrameInfoCopySecurityOrigin):

  • UIProcess/API/C/WKFrameInfoRef.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/C/WKPageUIClient.h:
  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/MediaPermissionUtilities.mm:

(WebKit::alertMessageText):
(WebKit::allowButtonText):
(WebKit::doNotAllowButtonText):
(WebKit::alertForPermission):

  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::shouldAllowDeviceOrientationAndMotionAccess):

  • UIProcess/Cocoa/WKOrientationAccessAlert.h: Removed.
  • UIProcess/Cocoa/WKOrientationAccessAlert.mm: Removed.
  • UIProcess/MediaPermissionUtilities.h:
  • UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.cpp:

(WebKit::WebDeviceOrientationAndMotionAccessController::shouldAllowAccess):

  • WebKit.xcodeproj/project.pbxproj:

Tools:

Update code to print frame info origin and update according additional frame info parameter given to shouldAllowDeviceOrientationAndMotionAccess.
Clear permissions in case test controller changes the device motion permission value.

  • TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:

(-[DeviceOrientationPermissionUIDelegate _webView:requestDeviceOrientationAndMotionPermissionForOrigin:initiatedByFrame:decisionHandler:]):
(-[DeviceOrientationPermissionValidationDelegate setValidationHandler:]):
(-[DeviceOrientationPermissionValidationDelegate _webView:requestDeviceOrientationAndMotionPermissionForOrigin:initiatedByFrame:decisionHandler:]):

  • TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(-[WebsitePoliciesDeviceOrientationUIDelegate _webView:requestDeviceOrientationAndMotionPermissionForOrigin:initiatedByFrame:decisionHandler:]):

  • WebKitTestRunner/TestController.cpp:

(WTR::shouldAllowDeviceOrientationAndMotionAccess):
(WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
(WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):

  • WebKitTestRunner/TestController.h:

LayoutTests:

  • fast/device-orientation/device-motion-request-permission-denied-expected.txt:
  • fast/device-orientation/device-motion-request-permission-granted-expected.txt:
  • fast/device-orientation/device-orientation-request-permission-denied-expected.txt:
  • fast/device-orientation/device-orientation-request-permission-granted-expected.txt:
  • http/tests/device-orientation/device-motion-allowed-in-first-party-only-expected.txt:
  • http/tests/device-orientation/device-motion-third-party-iframe-allowed-by-feature-policy-expected.txt:
  • http/tests/device-orientation/device-orientation-allowed-in-first-party-only-expected.txt:
  • http/tests/device-orientation/device-orientation-permission-granted-in-other-iframes-from-same-origin-expected.txt:
  • http/tests/device-orientation/device-orientation-third-party-iframe-allowed-by-feature-policy-expected.txt:
  • platform/ios/http/tests/events/device-orientation-motion-secure-context-expected.txt:
4:47 AM Changeset in webkit [274557] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk/Source

Shutdown ANGLE on GPU process when last WebGL context is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=223082

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-03-17
Reviewed by Kenneth Russell.

Source/WebCore:

  • CMakeLists.txt:
  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::InitializeEGLDisplay):
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):

  • platform/graphics/opengl/GraphicsContextGLOpenGL.h:

Hold the default EGLDisplay with a scoped holder that counts
the references to the default display.
(WebCore::GraphicsContextGLOpenGL::releaseAllResourcesIfUnused):
Add a call that uninitializes the ANGLE default display if there are no uses of
the default display.

Source/WebKit:

Schedule a check for releasing the ANGLE default display when global
count of remote graphics contexts reach zero. This should decrease the
memory use of sessions where WebGL is not always on.

Dispatch the check 0.2s after hitting zero, so that the optimization still
affects page navigations but maybe does not redundantly deinitialize /
reinitialize ANGLE in the cases where the context #1 is created and destroyed
frequently.

  • GPUProcess/graphics/RemoteGraphicsContextGL.cpp:

(WebKit::dispatchReleaseAllResourcesIfUnused):
(WebKit::RemoteGraphicsContextGL::initialize):
(WebKit::RemoteGraphicsContextGL::stopListeningForIPC):

2:52 AM Changeset in webkit [274556] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

Protect LibWebRTCAudioModule when playing
​https://bugs.webkit.org/show_bug.cgi?id=223243

Reviewed by Alex Christensen.

Make sure to ref LibWebRTCAudioModule when playing.

  • platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:

(WebCore::LibWebRTCAudioModule::StartPlayout):
(WebCore::LibWebRTCAudioModule::pollAudioData):

2:01 AM Changeset in webkit [274555] by commit-queue@webkit.org
  • 3 edits in trunk

[GTK][WPE] Enable CSS scroll snap support by default
​https://bugs.webkit.org/show_bug.cgi?id=222641

Patch by Martin Robinson <​mrobinson@igalia.com> on 2021-03-17
Reviewed by Carlos Garcia Campos.

  • Source/cmake/OptionsGTK.cmake: Enable CSS scroll snap by default.
  • Source/cmake/OptionsWPE.cmake: Ditto.
1:56 AM Changeset in webkit [274554] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WPE] Include cog build artefacts in built product archive
​https://bugs.webkit.org/show_bug.cgi?id=217477

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-03-17
Reviewed by Adrian Perez de Castro.

Include Cog files in the zip file if they're present, so the nightly runner would be able to
start Cog instead of the WPE MiniBrowser.

  • CISupport/built-product-archive:

(createZipFromList):
(archiveBuiltProduct):

1:40 AM Changeset in webkit [274553] by youenn@apple.com
  • 3 edits in trunk/Source/WebKit

Protect RemoteCaptureSampleManager and RemoteAudioSourceProviderManager when hopping to background threads
​https://bugs.webkit.org/show_bug.cgi?id=223245

Reviewed by Alex Christensen.

When hopping to a background thread, take a ref to the manager.
Both managers are thread safe refcounted.

  • WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp:

(WebKit::RemoteAudioSourceProviderManager::addProvider):
(WebKit::RemoteAudioSourceProviderManager::removeProvider):

  • WebProcess/cocoa/RemoteCaptureSampleManager.cpp:

(WebKit::RemoteCaptureSampleManager::addSource):
(WebKit::RemoteCaptureSampleManager::removeSource):

Mar 16, 2021:

11:02 PM Changeset in webkit [274552] by Ross Kirsling
  • 20 edits
    1 add in trunk

[JSC] Implement Error#cause
​https://bugs.webkit.org/show_bug.cgi?id=223302

Reviewed by Yusuke Suzuki.

JSTests:

Add tests. test262 doesn't currently have any, but the spec is exceedingly simple anyway.

  • stress/error-cause.js: Added.

Source/JavaScriptCore:

This patch implements the Error.prototype.cause proposal, which reached Stage 3 at last week's TC39 meeting:
​https://github.com/tc39/proposal-error-cause

This very simple proposal allows to one reference the "error that caused this one" in a cascading scenario.
It does so by adding an options bag parameter to the Error, _NativeError_, and AggregateError constructors.
If it is an object with a cause property, the property will be used; if not, nothing happens at all.

  • API/JSObjectRef.cpp:

(JSObjectMakeError):

  • runtime/AggregateError.cpp:

(JSC::AggregateError::finishCreation):
(JSC::AggregateError::create):

  • runtime/AggregateError.h:
  • runtime/AggregateErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/CommonIdentifiers.h:
  • runtime/Error.cpp:

(JSC::createError):
(JSC::createEvalError):
(JSC::createRangeError):
(JSC::createReferenceError):
(JSC::createSyntaxError):
(JSC::createTypeError):
(JSC::createURIError):
(JSC::createGetterTypeError):

  • runtime/ErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::create):
(JSC::ErrorInstance::finishCreation):

  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::create):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor<errorType>::constructImpl):
(JSC::NativeErrorConstructor<errorType>::callImpl):

  • runtime/NullSetterFunction.cpp:

(JSC::NullSetterFunctionInternal::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/JSWebAssemblyCompileError.cpp:

(JSC::JSWebAssemblyCompileError::create):

  • wasm/js/JSWebAssemblyLinkError.cpp:

(JSC::JSWebAssemblyLinkError::create):

  • wasm/js/JSWebAssemblyRuntimeError.cpp:

(JSC::JSWebAssemblyRuntimeError::create):

  • wasm/js/WebAssemblyCompileErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyLinkErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

9:22 PM Changeset in webkit [274551] by Peng Liu
  • 3 edits in trunk/Source/WebCore

document pictureInPictureElement is null if you Enter Picture in Picture from contextual menu
​https://bugs.webkit.org/show_bug.cgi?id=223125

Reviewed by Darin Adler.

Use HTMLVideoElement's functions to change video presentation mode to ensure that
document.pictureInPictureElement is updated properly and correct events are fired.

Covered by manual tests.

  • html/HTMLVideoElement.cpp:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::enterFullscreenForVideo const):
(WebCore::HitTestResult::toggleEnhancedFullscreenForVideo const):

9:15 PM Changeset in webkit [274550] by Lauro Moura
  • 5 edits
    5 adds in trunk/LayoutTests

[GLIB] Gardening some consistent WPE failures and GTK4 crashes

Unreviewed test gardening.

  • platform/glib/TestExpectations:
  • platform/glib/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt: Rebaselined after r274167.
  • platform/gtk/imported/w3c/web-platform-tests/dom/slot-recalc-expected.txt: Added. Needed after r274167.
  • platform/gtk4/TestExpectations:
  • platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Rebaselined. Needed after somewhere between r273067 (last good) and r273071 (first bad).
  • platform/wpe/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-expected.txt: Added. WPE does not support color popup yet.
  • platform/wpe/imported/w3c/web-platform-tests/css/selectors/focus-visible-004-expected.txt: Ditto.
  • platform/wpe/imported/w3c/web-platform-tests/dom/slot-recalc-expected.txt: Added. Needed fater r274167.
8:41 PM Changeset in webkit [274549] by Diego Pino Garcia
  • 2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Update test expectations after r273539.

  • platform/glib/TestExpectations:
7:34 PM Changeset in webkit [274548] by Russell Epstein
  • 1 copy in tags/Safari-611.1.21.2.3

Tag Safari-611.1.21.2.3.

7:15 PM Changeset in webkit [274547] by commit-queue@webkit.org
  • 55 edits
    4 adds in trunk/Source/ThirdParty/ANGLE

Regressions from ANGLE Metal enablement
​https://bugs.webkit.org/show_bug.cgi?id=222239

This patch addressed several large bits of funcitonality that was missing from the original patch.
1) Introduce support for UBO's. This patch adds a DEQP-conformant implementation for UBO structs. This includes changes to the translator,

Patch by Kyle Piddington <Kyle Piddington> on 2021-03-16

7:12 PM Changeset in webkit [274546] by commit-queue@webkit.org
  • 9 edits
    1 copy
    1 add in trunk/Source/WebCore

Add CSSValuePair.h in preparation for Pair.h refactor
​https://bugs.webkit.org/show_bug.cgi?id=223205

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-03-16
Reviewed by Simon Fraser.

Add new CSSValuePair class, which is intended to replace Pair.h.
Pair.h has some problems, namely:

  1. It's not a sub-class of CSSValue, making it awkward to use.
  2. It can only contain CSSPrimitiveValues.

CSSValuePair will fix both of these shortcomings.

  • Sources.txt:

Add CSSValuePair.cpp.

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText const):
Handle new ValuePairClass value.
(WebCore::CSSValue::separatorCssText const):
Added.
(WebCore::CSSValue::destroy):
Handle new ValuePairClass value.

  • css/CSSValue.h:

(WebCore::CSSValue::isValuePair const):
Added.
(WebCore::CSSValue::CSSValue):
Add new ValuePairClass value. Rename m_valueListSeparator to m_valueSeparator,
ValueListSeparator to ValueSeparator, and
ValueListSeparatorBits to ValueSeparatorBits.

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):
(WebCore::CSSValueList::copy):
(WebCore::CSSValueList::customCSSText const):
Refactor to use new separatorCssText() function.
(WebCore::CSSValueList::equals const):
Rename m_valueListSeparator to m_valueSeparator,
ValueListSeparator to ValueSeparator, and
ValueListSeparatorBits to ValueSeparatorBits.

  • css/CSSValueList.h:

(WebCore::CSSValueList::separator const):
Rename m_valueListSeparator to m_valueSeparator.

  • css/CSSValuePair.cpp:

(WebCore::CSSValuePair::customCSSText const):
(WebCore::CSSValuePair::equals const):
Added.

  • css/CSSValuePair.h:

(WebCore::CSSValuePair::create):
(WebCore::CSSValuePair::first const):
(WebCore::CSSValuePair::second const):
(WebCore::CSSValuePair::CSSValuePair):
Added.

  • css/DeprecatedCSSOMValue.h:
  • css/DeprecatedCSSOMValueList.cpp:

(WebCore::DeprecatedCSSOMValueList::cssText const):

  • css/DeprecatedCSSOMValueList.h:

(WebCore::DeprecatedCSSOMValueList::DeprecatedCSSOMValueList):
Rename m_valueListSeparator to m_valueSeparator,
ValueListSeparator to ValueSeparator, and
ValueListSeparatorBits to ValueSeparatorBits.

6:27 PM Changeset in webkit [274545] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS wk2 ] media/media-fullscreen-return-to-inline.html is a flakey text failure and flakey timeout
​https://bugs.webkit.org/show_bug.cgi?id=223293

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Updating test expectations to Pass Failure Timeout while test is being reviewed.
6:02 PM Changeset in webkit [274544] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS wk2 ARM64 ] fast/table/multiple-captions-crash4.htmlis a flakey Image failure
​https://bugs.webkit.org/show_bug.cgi?id=223292

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Updating test results to PASS IMAGEONLYFAILURE while test is being reviewed.
5:54 PM Changeset in webkit [274543] by wilander@apple.com
  • 2 edits in trunk/Tools

PCM: Use adoptWK in TestInvocation::didReceiveSynchronousMessageFromInjectedBundle()'s handling of "SetPrivateClickMeasurementAttributionReportURLsForTesting"
​https://bugs.webkit.org/show_bug.cgi?id=223286
<rdar://problem/75498336>

Reviewed by Darin Adler.

See Darin's initial comment here: ​https://bugs.webkit.org/show_bug.cgi?id=223238#c9

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

5:53 PM Changeset in webkit [274542] by Jonathan Bedard
  • 15 edits in trunk/Tools

[resultsdbpy] Save identifiers in commit table
​https://bugs.webkit.org/show_bug.cgi?id=223101
<rdar://problem/75338338>

Reviewed by Dewei Zhu.

  • Scripts/libraries/resultsdbpy/resultsdbpy/init.py: Bump version.
  • Scripts/libraries/resultsdbpy/resultsdbpy/controller/commit_controller.py:

(CommitController.register): Accept uploaded new commit objects, continue to return old-style commits.

  • Scripts/libraries/resultsdbpy/resultsdbpy/controller/upload_controller.py:

(UploadController.upload): Register commits using the fast path when uploading results.

  • Scripts/libraries/resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py:

(UploadControllerTest.test_process): Mock safari and WebKit when processing results.
(UploadControllerTest.test_process_commit): Ditto.

  • Scripts/libraries/resultsdbpy/resultsdbpy/model/commit_context.py:

(CommitContext.CommitModelMk2): Add new style commit model base.
(CommitContext.CommitByRef): Sort commits by hash, revision and identifier references.
(CommitContext.CommitByUuidAscendingMk2): New commit style UUID table.
(CommitContext.CommitByUuidDescendingMk2): Ditto.
(CommitContext.init): Create new tables.
(CommitContext.find_commits_by_ref): Search for commits in the new ref table.
(CommitContext.register): Post-process commits to populate identifier field.
(CommitContext.register_commit): Only register new-style commits.
(CommitContext.register_partial_commit): Register new-style commits, allow caller to opt-out of expensive
Identifier computation.
(CommitContext.url): Accept old and new style commits.
(CommitContext.register_commit_with_repo_and_id): Deleted.

  • Scripts/libraries/resultsdbpy/resultsdbpy/model/commit_context_unittest.py:

(CommitContextTest.add_all_commits_to_database): Update commit registration call.
(CommitContextTest.test_commit_from_stash_repo): Ditto.
(CommitContextTest.test_commit_from_svn_repo): Ditto.

  • Scripts/libraries/resultsdbpy/resultsdbpy/model/mock_model_factory.py:

(MockModelFactory.create): Update commit registration call.

  • Scripts/libraries/resultsdbpy/resultsdbpy/model/model.py:

(Model.init): commit_context may now post-process uploads.

  • Scripts/libraries/resultsdbpy/resultsdbpy/model/repository.py:

(Repository.commit): Add call to return new-style commits.
(StashRepository.commit): Ditto.
(WebKitRepository.commit): Ditto.

  • Scripts/libraries/resultsdbpy/resultsdbpy/model/repository_unittest.py:

(RepositoryTest.test_svn):
(RepositoryTest.test_ref_svn):
(RepositoryTest.test_stash):
(RepositoryTest.test_ref_stash):
(RepositoryTest.test_colliding_timestamps_stash):
(RepositoryTest.test_branch_stash):
(RepositoryTest.test_branch_svn): Deleted.

  • Scripts/libraries/resultsdbpy/resultsdbpy/model/upload_context_unittest.py:

(UploadContextTest.test_callback):
(UploadContextTest.test_async_callback):

  • Scripts/libraries/resultsdbpy/setup.py: Bump version.
  • Scripts/libraries/webkitscmpy/webkitscmpy/commit.py:

(Commit): Handle single email passed to contributor.

5:52 PM Changeset in webkit [274541] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Avoid heap allocation under AudioSummingJunction::updateRenderingState()
​https://bugs.webkit.org/show_bug.cgi?id=223230

Reviewed by Darin Adler.

Avoid heap allocation under AudioSummingJunction::updateRenderingState()
since this runs on the audio thread.

  • Modules/webaudio/AudioSummingJunction.cpp:

(WebCore::AudioSummingJunction::addOutput):
(WebCore::AudioSummingJunction::removeOutput):
(WebCore::AudioSummingJunction::updateRenderingState):

  • Modules/webaudio/AudioSummingJunction.h:
5:37 PM Changeset in webkit [274540] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS wk2 ARM 64 ] 2 accessibility/mac/value-change/ layout-tests are flakey text failures
​https://bugs.webkit.org/show_bug.cgi?id=223291

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Updating test expectations as PASS/FAILURE until test can be reviewed.
5:23 PM Changeset in webkit [274539] by sbarati@apple.com
  • 3 edits
    1 add in trunk

Object allocation sinking phase should prioritize materializations with no dependencies before materializations with no reverse dependencies
​https://bugs.webkit.org/show_bug.cgi?id=221069
<rdar://problem/73686589>

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/allocation-sinking-scope-materialization-order.js: Added.

(var3.var2.x):
(var3):

Source/JavaScriptCore:

Suppose we have two scope objects, A and B. Let's say A points to B, so B is
A's parent scope. A then depends on B. B has no dependencies here. When deciding
an order to materialize scope objects, we should always do it in reverse dependency
order. So above, we should materialize B, then A.

Inside object allocation sinking phase, when at an object materialization
site, we do track both dependencies and reverse dependencies. In the above
object graph, we'd attempt to materialize the objects in the right order,
always picking things with no dependencies first (and updating the list of
dependencies as we materialzed objects).

The code was using an std::list to track things to materialize, and it had
notions for materializing something first, and materializing something last.
However, there was a bug in how the code managed to insert things when
it first inserted last followed by inserting first. This patch simplifies
the code and makes it do the right thing.

  • dfg/DFGObjectAllocationSinkingPhase.cpp:
5:10 PM Changeset in webkit [274538] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fixed undefined behavior bug in Const32Value::checkNegConstant().
​https://bugs.webkit.org/show_bug.cgi?id=223284

Reviewed by Darin Adler.

This was causing a failure in testb3 on a release build.
Also do the same for Const64Value::checkNegConstant().

  • b3/B3Const32Value.cpp:

(JSC::B3::Const32Value::checkNegConstant const):

  • b3/B3Const64Value.cpp:

(JSC::B3::Const64Value::checkNegConstant const):

5:08 PM Changeset in webkit [274537] by Alan Coon
  • 1 copy in tags/Safari-611.1.21.1.11

Tag Safari-611.1.21.1.11.

5:03 PM Changeset in webkit [274536] by Alan Coon
  • 2 edits in branches/safari-611.1.21.1-branch/Source/WebKit

Cherry-pick r274504. rdar://problem/75482851

The WebContent process crashes when launching Safari
​https://bugs.webkit.org/show_bug.cgi?id=223264
<rdar://75482851>

Reviewed by Brent Fulgham.

The WebContent process crashes when launching Safari on older OSes, because of unavailable sandbox features.

  • WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:54 PM Changeset in webkit [274535] by Alan Coon
  • 1 copy in tags/Safari-611.1.21.0.7

Tag Safari-611.1.21.0.7.

4:52 PM Changeset in webkit [274534] by Alan Coon
  • 8 edits in branches/safari-611.1.21.1-branch/Source

Versioning.

WebKit-7611.1.21.1.11

4:49 PM Changeset in webkit [274533] by Alan Coon
  • 1 copy in tags/Safari-611.1.21.1.10

Tag Safari-611.1.21.1.10.

4:39 PM Changeset in webkit [274532] by mmaxfield@apple.com
  • 5 edits
    4 adds in trunk

<img> isn't able to render RTL text correctly in ALT text
​https://bugs.webkit.org/show_bug.cgi?id=221833
<rdar://problem/74530491>

Reviewed by Zalan Bujtas.

Source/WebCore:

Simply use the text drawing routine that handles bidi.

Test: fast/text/image-alt-text-bidi.html

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

LayoutTests:

  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
  • fast/text/image-alt-text-bidi-2-expected.html: Added.
  • fast/text/image-alt-text-bidi-2.html: Added.
  • fast/text/image-alt-text-bidi-expected.html: Added.
  • fast/text/image-alt-text-bidi.html: Added.
4:05 PM Changeset in webkit [274531] by mmaxfield@apple.com
  • 3 edits in trunk/Source/WebCore

Be more restrictive about when canvas2d is allowed to update style
​https://bugs.webkit.org/show_bug.cgi?id=222896

Reviewed by Ryosuke Niwa.

We can use the RAII class ScriptDisallowedScope::InMainThread to enforce places where
script is allowed to be run.

This is just a cleanup/clarity patch.

No new tests because there is no behavior change.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):
(WebCore::CanvasRenderingContext2D::setFontWithoutUpdatingStyle):
(WebCore::CanvasRenderingContext2D::toTextDirection const):
(WebCore::CanvasRenderingContext2D::measureText):
(WebCore::CanvasRenderingContext2D::fontProxy const):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • html/canvas/CanvasRenderingContext2D.h:
4:02 PM Changeset in webkit [274530] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, reverting r274473.
​https://bugs.webkit.org/show_bug.cgi?id=223287

Caused assertion failure in API tests

Reverted changeset:

"[iOS][FCR] Add pressed state for button-like controls"
​https://bugs.webkit.org/show_bug.cgi?id=223208
​https://trac.webkit.org/changeset/274473

4:02 PM Changeset in webkit [274529] by Alexey Shvayka
  • 2 edits in trunk/Source/WebCore

[WebIDL] Optimize convertRecord() to avoid double |key| lookup
​https://bugs.webkit.org/show_bug.cgi?id=223219

Reviewed by Darin Adler.

This change replaces getOwnPropertyDescriptor() with more low-level API so
slot.isTaintedByOpaqueObject() can be leveraged to avoid the second |key|
lookup if it's unobservable, while still invoking Proxy's Get? trap [1].

It's a common pattern used in JSC (see ObjectConstructor.cpp), which speeds up
convertRecord() by 20% (microbenchmark: 10 keys / 10k runs).

Also, this patch applies Geoffrey Garen's post-review feedback on r268852
by utilizing AddResult.

No new tests, no behavior change.

Test: imported/w3c/web-platform-tests/fetch/api/headers/headers-record.html

[1] ​https://heycam.github.io/webidl/#es-record (step 4.2.2)

  • bindings/js/JSDOMConvertRecord.h:
4:00 PM Changeset in webkit [274528] by Alexey Shvayka
  • 21 edits
    7 adds in trunk

Cache cross-origin methods / accessors of Window and Location per lexical global object
​https://bugs.webkit.org/show_bug.cgi?id=222739

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-function-caching-expected.txt: Added.
  • web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-function-caching.html: Added.
  • web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-function-common.js: Added.
  • web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-function-length-expected.txt: Added.
  • web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-function-length.html: Added.
  • web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-function-name-expected.txt: Added.
  • web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-function-name.html: Added.

Source/JavaScriptCore:

  1. Introduce WeakGCMap::ensureValue() to clean up JSObject::getOwnPropertyDescriptor() and avoid double hashing. It decorates HashMap::ensure() to guarantee non-null return value.
  2. Assert early that JSCustom{Getter,Setter}Function is created with non-null function pointer.
  3. Rename getCustom{Getter,Setter}Function() to align with newly-added JSDOMGlobalObject methods.
  • runtime/JSCustomGetterFunction.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSCustomGetterFunction::create):

  • runtime/JSCustomSetterFunction.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSCustomSetterFunction::create):

  • runtime/JSObject.cpp:

(JSC::createCustomGetterFunction):
(JSC::createCustomSetterFunction):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::getCustomGetterFunction): Deleted.
(JSC::getCustomSetterFunction): Deleted.

  • runtime/Lookup.h:

(JSC::nonCachingStaticFunctionGetterImpl): Deleted.

  • runtime/WeakGCMap.h:

Source/WebCore:

For cross-origin methods / accessors, Window and Location objects return different JSFunction
instances on every Get?. The intent was to ensure isolation by supplying different Realms with
different function objects. However, within the same callee Realm, this makes subsequent lookups
of a cross-origin method / accessor fail reference equality test, which is rather confusing:

crossOriginWindow.focus === crossOriginWindow.focus // => false

This patch implements CrossOriginPropertyDescriptorMap?, bringing consistent function identity
and aligning WebKit with the spec [1], Blink, and Gecko. For convenience, cache maps are added to
JSDOMGlobalObject (to accommodate RemoteDOMWindow) and cover both Window and Location objects.

As a cache map key, a pair of lexical global object and raw function pointer is used, which guarantees
correctness even if Window and Location would expose cross-origin property of the same name.

This patch removes 9 custom getters, adds runtime lookup for "showModalDialog" (which is rare),
and removes [ForwardDeclareInHeader] extended attribute as it's now unused and non-trivial to generate.

Also, fixes cross-realm postMessage.length to equal 1 as per WebIDL.

[1] ​https://html.spec.whatwg.org/multipage/browsers.html#crossorigingetownpropertyhelper-(-o,-p-)

Tests: imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-function-caching.html

imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-function-length.html
imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-function-name.html

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
(WebCore::JSDOMGlobalObject::createCrossOriginFunction):
(WebCore::JSDOMGlobalObject::createCrossOriginGetterSetter):

  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
(WebCore::JSDOMWindow::getOwnPropertySlot):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::getOwnPropertySlotCommon):
(WebCore::JSC_DEFINE_CUSTOM_GETTER): Deleted.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.json:
  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:
  • page/RemoteDOMWindow.idl:

LayoutTests:

  • http/tests/navigation/process-swap-window-open-expected.txt:
  • http/tests/navigation/process-swap-window-open.html:
3:52 PM Changeset in webkit [274527] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Avoid heap allocation under AudioDestinationCocoa::render()
​https://bugs.webkit.org/show_bug.cgi?id=223272

Reviewed by Sam Weinig.

In the common case where no AudioWorklet is used, AudioDestinationCocoa::render()
would unnecessarily create a WTF::Function to dispatch to the render thread, even
though we are already on the render thread. Constructing a WTF::Function does a
heap allocation so we really want to avoid constructing one on the high priority
audio thread.

In the AudioWorklet case, we still construct a WTF::Function for now. I will follow
up if I find a way to avoid it in this case too.

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::Function<void):

  • platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::AudioDestinationCocoa::render):
(WebCore::AudioDestinationCocoa::renderOnRenderingTheadIfPlaying):

  • platform/audio/cocoa/AudioDestinationCocoa.h:
  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcRenderIteration):

3:45 PM Changeset in webkit [274526] by commit-queue@webkit.org
  • 5 edits in trunk

ASSERTION FAILED: m_state == State::Committed in WebKit::FrameLoadState::didFailLoad()
​https://bugs.webkit.org/show_bug.cgi?id=221783

Patch by Julian Gonzalez <​julian_a_gonzalez@apple.com> on 2021-03-16
Reviewed by Ryosuke Niwa.

Source/WebCore:

Don't attempt to update layout while in the FrameSelection constructor -
otherwise, we can break the order of operations of the loader.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::setCaretVisibility):

  • editing/FrameSelection.h:

(WebCore::FrameSelection::setCaretVisible):

LayoutTests:

Stop skipping loader/change-src-during-iframe-load-crash.html on Debug bots.

  • platform/wk2/TestExpectations:
3:43 PM Changeset in webkit [274525] by Robert Jenner
  • 2 edits in trunk/LayoutTests

REGRESSION (r274461): [ macOS wk1 ]fast/repaint/canvas-object-fit.html is flakey text failing
​https://bugs.webkit.org/show_bug.cgi?id=223283

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations: Updating test expectations while test is being reviewed.
3:26 PM Changeset in webkit [274524] by Simon Fraser
  • 4 edits in trunk/LayoutTests

[BigSur arm64] compositing/z-order/rebuild-sibling-of-layer-with-foreground-layer.html is a flakey image failure
​https://bugs.webkit.org/show_bug.cgi?id=223265

Unreviewed test gardening.

Attempt to make this test pass on AS by avoiding solid-color layers, forcing backing store
with &nbsp;. Also reduce the oddly long 1000ms timeout in the test.

  • compositing/z-order/rebuild-sibling-of-layer-with-foreground-layer-expected.html:
  • compositing/z-order/rebuild-sibling-of-layer-with-foreground-layer.html:
  • platform/mac/TestExpectations:
3:09 PM Changeset in webkit [274523] by Jonathan Bedard
  • 12 edits in trunk/Tools

[resultsdbpy] Allow user to change commit representation
​https://bugs.webkit.org/show_bug.cgi?id=223215
<rdar://problem/75446602>

Reviewed by Dewei Zhu.

  • Scripts/libraries/resultsdbpy/resultsdbpy/init.py: Bump version.
  • Scripts/libraries/resultsdbpy/resultsdbpy/controller/api_routes.py:

(APIRoutes.init): Add commit representations endpoint.

  • Scripts/libraries/resultsdbpy/resultsdbpy/controller/commit_controller.py:

(CommitController.representations): Add commit representations endpoint.

  • Scripts/libraries/resultsdbpy/resultsdbpy/model/repository.py:

(Repository.representations): Return prioritized commit representation.
(StashRepository.representations): Ditto.
(WebKitRepository.representations): Ditto.

  • Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:

(Commit.prototype.label): Change the commit representation based on global settings.
(_CommitBank):
(_CommitBank.prototype.commitRepresentations): Check the commit representation cookie, then
the representation endpoint.
(_CommitBank.prototype.setCommitRepresentation): Set the commit representation cookie.

  • Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js:

(CommitRepresentation): Drawer control allowing user to change commit representation for repositories.

  • Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/commits.html: Add new control.
  • Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/documentation.html: Ditto.
  • Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/search.html: Ditto.
  • Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
  • Scripts/libraries/resultsdbpy/setup.py: Bump version.
2:58 PM Changeset in webkit [274522] by mark.lam@apple.com
  • 6 edits
    1 copy in trunk/Source/JavaScriptCore

Add a RootMarkReason printer and also add a few additional reasons.
​https://bugs.webkit.org/show_bug.cgi?id=223263

Reviewed by Michael Saboff.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • heap/Heap.cpp:

(JSC::Heap::addCoreConstraints):

  • heap/HeapSnapshotBuilder.cpp:

(JSC::HeapSnapshotBuilder::json):
(JSC::rootTypeToString): Deleted.

  • heap/RootMarkReason.cpp: Added.

(JSC::rootMarkReasonDescription):
(WTF::printInternal):

  • heap/RootMarkReason.h:
2:57 PM Changeset in webkit [274521] by Devin Rousso
  • 85 edits
    8 copies
    4 moves
    4 adds
    11 deletes in trunk

[macOS] change for the language/subtitle tracks button to use an NSMenu instead of web content
​https://bugs.webkit.org/show_bug.cgi?id=223239
<rdar://problem/75462340>

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/modern-media-controls/tracks-support/auto-text-track.html

media/modern-media-controls/tracks-support/captions-offset-with-controls-bar.html
media/modern-media-controls/tracks-support/click-track-in-contextmenu.html
media/modern-media-controls/tracks-support/hidden-tracks.html
media/modern-media-controls/tracks-support/no-tracks.html
media/modern-media-controls/tracks-support/off-text-track.html
media/modern-media-controls/tracks-support/show-contextmenu-then-double-click-on-tracks-button.html
media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html

  • Modules/mediacontrols/MediaControlsHost.h:
  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsContextMenuProvider::create): Added.
(WebCore::MediaControlsContextMenuProvider::MediaControlsContextMenuProvider): Added.
(WebCore::MediaControlsContextMenuProvider::~MediaControlsContextMenuProvider): Added.
(WebCore::MediaControlsContextMenuProvider::populateContextMenu): Added.
(WebCore::MediaControlsContextMenuProvider::contextMenuItemSelected): Added.
(WebCore::MediaControlsContextMenuProvider::contextMenuCleared): Added.
(WebCore::MediaControlsContextMenuProvider::contextMenuContextType): Added.
(WebCore::MediaControlsContextMenuEventListener::create): Added.
(WebCore::MediaControlsContextMenuEventListener::operator== const): Added.
(WebCore::MediaControlsContextMenuEventListener::handleEvent): Added.
(WebCore::MediaControlsContextMenuEventListener::MediaControlsContextMenuEventListener): Added.
(WebCore::MediaControlsHost::showMediaControlsContextMenu):
Create platform-agnostic helper functions and types for creating submenus and menu items so
that this logic added for iOS can also be used for macOS.

  • page/ContextMenuContext.h:

(WebCore::ContextMenuContext::type const): Added.

  • page/ContextMenuContext.cpp:

(WebCore::ContextMenuContext::ContextMenuContext):
Move WebKit::ContextMenuContextData::Type to WebCore::ContextmenuContext::Type so that
it can be used in WebCore as well.

  • page/ContextMenuProvider.h:

(WebCore::ContextMenuProvider::contextMenuContextType): Added.

  • page/ContextMenuController.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::handleContextMenuEvent):
(WebCore::ContextMenuController::showContextMenu):
(WebCore::ContextMenuController::maybeCreateContextMenu):
Allow the ContextMenuProvider to further customize the ContextMenu that's created, such
as allowing the hit test to include UA shadow roots and controlling "Inspect Element".

  • platform/ContextMenuItem.h:
  • platform/ContextMenuItem.cpp:

(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::setIndentationLevel): Added.
(WebCore::ContextMenuItem::indentationLevel const): Added.
Provide a way to eventually set the -[NSMenuItem setIndentationLevel:].

  • Modules/modern-media-controls/controls/tracks-panel.js: Removed.
  • Modules/modern-media-controls/controls/tracks-panel.css: Removed.
  • Modules/modern-media-controls/controls/background-click-delegate-notifier.js:

(BackgroundClickDelegateNotifier.prototype.handleEvent):

  • Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:

(.media-controls.mac.fullscreen):

  • Modules/modern-media-controls/controls/media-controls.js:

(MediaControls.prototype.showTracksPanel): Deleted.
(MediaControls.prototype.hideTracksPanel): Deleted.

  • Modules/modern-media-controls/controls/media-controls.css:

(.media-controls.shows-tracks-panel > .controls-bar > *, .media-controls.shows-tracks-panel > button): Deleted.

  • Modules/modern-media-controls/media/tracks-support.js:

(TracksSupport.prototype.buttonWasPressed):
(TracksSupport.prototype.syncControl):
(TracksSupport.prototype._sortedTrackList):
(TracksSupport): Deleted.
(TracksSupport.prototype.tracksPanelNumberOfSections): Deleted.
(TracksSupport.prototype.tracksPanelTitleForSection): Deleted.
(TracksSupport.prototype.tracksPanelNumberOfTracksInSection): Deleted.
(TracksSupport.prototype.tracksPanelTitleForTrackInSection): Deleted.
(TracksSupport.prototype.tracksPanelIsTrackInSectionSelected): Deleted.
(TracksSupport.prototype.tracksPanelSelectionDidChange): Deleted.

  • Modules/modern-media-controls/js-files:

Remove everything related to TracksPanel now that macOS also uses a contextmenu.

  • Modules/modern-media-controls/controls/inline-media-controls.js:

(InlineMediaControls.prototype.layout):
(InlineMediaControls.prototype._rightContainerButtons):
(InlineMediaControls.prototype._droppableButtons):

  • Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:

(MacOSFullscreenMediaControls):
The OverflowButton should be the last right container button to be dropped.

  • Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype.showMediaControlsContextMenu):
Provide a way for callers to provide additional options.

  • page/MediaControlsContextMenuItem.h:

(WebCore::MediaControlsContextMenuItem::encode const):
(WebCore::MediaControlsContextMenuItem::decode):
Drive-by: Rename isChecked to checked to match ContextMenuItem.

  • Modules/modern-media-controls/controls/tracks-button.js:

(TracksButton.prototype.get contextMenuOptions):
Drive-by: Rename object keys for clarity.

  • page/ChromeClient.h:

Be more explicit with compiler flags.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::mediaControlsScript):

  • Modules/modern-media-controls/images/macOS/Overflow.svg:

Rework this "..." icon to be ">>" to match similar icons elsewhere on macOS.

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

  • Shared/ContextMenuContextData.h:
  • Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):
Move WebKit::ContextMenuContextData::Type to WebCore::ContextmenuContext::Type so that
it can be used in WebCore as well.

  • Shared/WebContextMenuItemData.h:
  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::WebContextMenuItemData):
(WebKit::WebContextMenuItemData::core const):
(WebKit::WebContextMenuItemData::encode const):
(WebKit::WebContextMenuItemData::decode):
(WebKit::WebContextMenuItemData::indentationLevel const): Added.
Provide a way to eventually set the -[NSMenuItem setIndentationLevel:].

  • UIProcess/WebContextMenuProxy.h:
  • UIProcess/mac/WebContextMenuProxyMac.h:
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(-[WKMenuDelegate initWithMenuProxy:]): Added.
(-[WKMenuDelegate menuWillOpen:]): Added.
(-[WKMenuDelegate menuDidClose:]): Added.
(WebKit::WebContextMenuProxyMac::getContextMenuItem):
(WebKit::WebContextMenuProxyMac::useContextMenuItems):
(WebKit::WebContextMenuProxyMac::platformMenu const): Added.
(WebKit::contentsOfContextMenuItem): Added.
(WebKit::WebContextMenuProxyMac::platformData const): Added.
Add support for -[NSMenuItem setIndentationLevel:].

  • UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
  • UIProcess/API/Cocoa/WKWebViewTesting.mm:

(-[WKWebView _contentsOfUserInterfaceItem:]):
(-[WKWebView _didShowContextMenu]): Added.
(-[WKWebView _didDismissContextMenu]): Added.

  • UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
  • UIProcess/API/ios/WKWebViewTestingIOS.mm:

(-[WKWebView _didShowContextMenu]): Deleted.
(-[WKWebView _didDismissContextMenu]): Deleted.
Move these methods so they can be used on macOS too.

  • UIProcess/PageClient.h:

(WebKit::PageClient::didShowContextMenu): Added.
(WebKit::PageClient::didDismissContextMenu): Added.

  • UIProcess/mac/PageClientImplMac.h:
  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::didShowContextMenu): Added.
(WebKit::PageClientImpl::didDismissContextMenu): Added.
Add support for didShowContextMenu/didDismissContextMenu for tests.

  • UIProcess/API/mac/WKWebViewTestingMac.mm:

(-[WKWebView _activeMenu]):

  • UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::contentsOfUserInterfaceItem): Added.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::platformActiveContextMenu const): Added.
Add support for contentsOfUserInterfaceItem for tests.

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:
  • UIProcess/ios/WKActionSheetAssistant.h:
  • UIProcess/ios/WKActionSheetAssistant.mm:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.cpp:

Be more explicit with compiler flags.

Source/WTF:

  • wtf/PlatformEnableCocoa.h:

Turn on ENABLE_MEDIA_CONTROLS_CONTEXT_MENUS for macOS.

Tools:

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView _didShowContextMenu]):
(-[TestRunnerWKWebView _didDismissContextMenu]):
(-[TestRunnerWKWebView resetInteractionCallbacks]):

  • WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
  • WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:

(WTR::UIScriptControllerCocoa::setDidShowContextMenuCallback): Added.
(WTR::UIScriptControllerCocoa::setDidDismissContextMenuCallback): Added.
(WTR::UIScriptControllerCocoa::isShowingContextMenu const): Added.

  • WebKitTestRunner/ios/UIScriptControllerIOS.h:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::setDidShowContextMenuCallback): Deleted.
(WTR::UIScriptControllerIOS::setDidDismissContextMenuCallback): Deleted.
(WTR::UIScriptControllerIOS::isShowingContextMenu const): Deleted.
Move these methods so they can be used on macOS too.

LayoutTests:

  • media/modern-media-controls/tracks-support/auto-text-track.html: Added.
  • media/modern-media-controls/tracks-support/auto-text-track-expected.txt: Added.
  • media/modern-media-controls/tracks-support/click-track-in-contextmenu.html: Added.
  • media/modern-media-controls/tracks-support/click-track-in-contextmenu-expected.txt: Added.
  • media/modern-media-controls/tracks-support/hidden-tracks.html: Added.
  • media/modern-media-controls/tracks-support/hidden-tracks-expected.txt: Added.
  • media/modern-media-controls/tracks-support/off-text-track.html: Added.
  • media/modern-media-controls/tracks-support/off-text-track-expected.txt: Added.
  • media/modern-media-controls/tracks-support/show-contextmenu-then-double-click-on-tracks-button.html: Added.
  • media/modern-media-controls/tracks-support/show-contextmenu-then-double-click-on-tracks-button-expected.txt: Added.
  • media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html: Added.
  • media/modern-media-controls/tracks-support/text-track-selected-via-media-api-expected.txt: Added.
  • media/modern-media-controls/tracks-support/ios/tracks-support-auto-text-track.html: Removed.
  • media/modern-media-controls/tracks-support/ios/tracks-support-auto-text-track-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/ios/tracks-support-click-track-in-contextmenu.html: Removed.
  • media/modern-media-controls/tracks-support/ios/tracks-support-click-track-in-contextmenu-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/ios/tracks-support-hidden-tracks.html: Removed.
  • media/modern-media-controls/tracks-support/ios/tracks-support-hidden-tracks-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/ios/tracks-support-off-text-track.html: Removed.
  • media/modern-media-controls/tracks-support/ios/tracks-support-off-text-track-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/ios/tracks-support-show-contextmenu-then-double-click-on-tracks-button.html: Removed.
  • media/modern-media-controls/tracks-support/ios/tracks-support-show-contextmenu-then-double-click-on-tracks-button-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/ios/tracks-support-text-track-selected-via-media-api.html: Removed.
  • media/modern-media-controls/tracks-support/ios/tracks-support-text-track-selected-via-media-api-expected.txt: Removed.

Move the iOS tracks support tests out of an iOS folder since macOS now also uses a contextmenu.

  • media/modern-media-controls/resources/media-controls-loader.js:
  • media/modern-media-controls/resources/media-controls-utils.js:

(showTracksPanel): Deleted.

  • media/modern-media-controls/media-controller/media-controller-click-on-video-background-to-dismiss-tracks-panel-should-not-toggle-playback.html: Removed.
  • media/modern-media-controls/media-controller/media-controller-click-on-video-background-to-dismiss-tracks-panel-should-not-toggle-playback-expected.txt: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel.html: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-expected.txt: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-controls-bar-remains-visible-after-clicking-over-it.html: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-controls-bar-remains-visible-after-clicking-over-it-expected.txt: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-hide.html: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-hide-expected.txt: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-hide-click-outside.html: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-hide-click-outside-expected.txt: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-hide-esc-key.html: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-hide-esc-key-expected.txt: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-population.html: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-population-expected.txt: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-position-and-size-expected.txt: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-prevent-controls-bar-from-fading.html: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-prevent-controls-bar-from-fading-expected.txt: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-prevent-default-on-keydown.html: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-prevent-default-on-keydown-expected.txt: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-right-x.html: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-right-x-expected.txt: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard-expected.txt: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse.html: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse-expected.txt: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-up-click-outside-media-does-not-dimiss-media-controls-when-media-is-paused.html: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-up-click-outside-media-does-not-dimiss-media-controls-when-media-is-paused-expected.txt: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-up-click-over-media-does-not-dimiss-media-controls-when-media-is-playing.html: Removed.
  • media/modern-media-controls/tracks-panel/tracks-panel-up-click-over-media-does-not-dimiss-media-controls-when-media-is-playing-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-auto-text-track.html: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-auto-text-track-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-click-track-in-panel.html: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-click-track-in-panel-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-hidden-tracks.html: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-hidden-tracks-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-off-text-track.html: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-off-text-track-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-show-and-populate-panel.html: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-show-and-populate-panel-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-after-dragging-controls.html: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-after-dragging-controls-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-then-double-click-on-tracks-button.html: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-then-double-click-on-tracks-button-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-text-track-selected-via-media-api.html: Removed.
  • media/modern-media-controls/tracks-support/mac/tracks-support-text-track-selected-via-media-api-expected.txt: Removed.

Remove everything related to TracksPanel now that macOS also uses a contextmenu.

  • media/modern-media-controls/tracks-support/captions-offset-with-controls-bar.html: Renamed from LayoutTests/media/modern-media-controls/tracks-support/tracks-support-captions-offset-with-controls-bar.html.
  • media/modern-media-controls/tracks-support/captions-offset-with-controls-bar-expected.txt: Renamed from LayoutTests/media/modern-media-controls/tracks-support/tracks-support-captions-offset-with-controls-bar-expected.txt.
  • media/modern-media-controls/tracks-support/no-tracks.html: Renamed from LayoutTests/media/modern-media-controls/tracks-support/tracks-support-no-tracks.html.
  • media/modern-media-controls/tracks-support/no-tracks-expected.txt: Renamed from LayoutTests/media/modern-media-controls/tracks-support/tracks-support-no-tracks-expected.txt.

Renamed these tests to remove the redundant "tracks-support".

  • media/modern-media-controls/tracks-support/tracks-support-audio-tracks.html: Removed.
  • media/modern-media-controls/tracks-support/tracks-support-audio-tracks-expected.txt: Removed.
  • media/modern-media-controls/tracks-support/tracks-support-text-tracks.html: Removed.
  • media/modern-media-controls/tracks-support/tracks-support-text-tracks-expected.txt: Removed.

These tests are covered by the other added/renamed tests above.

  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles-expected.txt:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor-expected.txt:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-right-container-margin.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-right-container-margin-expected.txt:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-placard.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-volume-slider-visibility.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-dropping-controls-expected.txt:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-shows-start-button.html:

Update existing tests to accomodate the OverflowButton.

  • resources/ui-helper.js:

(window.UIHelper.chooseMenuAction): Added.
(window.UIHelper.async chooseMenuAction): Deleted.
Use UIScriptController.prototype.chooseMenuAction instead of a combination of
UIScriptController.prototype.rectForMenuAction and UIScriptController.prototype.activateAt
since UIScriptController::chooseMenuAction basically does that anyways.

  • TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/mac-wk2/TestExpectations:
2:40 PM Changeset in webkit [274520] by Simon Fraser
  • 9 edits in trunk

Runtime-disabled CSS features still still appear enabled via two-arg CSS.supports()
​https://bugs.webkit.org/show_bug.cgi?id=223141

Reviewed by Antti Koivisto.

Source/WebCore:

Fix the CSS.supports(property, value) entrypoint to check for runtime-disabled
CSS properties.

Move isPropertyRuntimeDisabled() to CSSParserContext, and call it from the
appropriate DOMCSSNamespace::supports() entrypoint.

Tested by fast/css/overscroll-behavior-invalidate-if-disabled.html

  • css/DOMCSSNamespace.cpp:

(WebCore::DOMCSSNamespace::supports):

  • css/parser/CSSParserContext.cpp:

(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):

  • css/parser/CSSParserContext.h:
  • css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::consumeDeclaration):
(WebCore::CSSParserImpl::isPropertyRuntimeDisabled const): Deleted.

  • css/parser/CSSParserImpl.h:

LayoutTests:

  • fast/css/overscroll-behavior-invalidate-if-disabled-expected.txt:
  • fast/css/overscroll-behavior-invalidate-if-disabled.html:
2:30 PM Changeset in webkit [274519] by Lauro Moura
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix Nicosia build without CSS_SCROLL_SNAP after r274495.

  • page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp:

(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::handleWheelEvent):
Add feature guards.

2:27 PM Changeset in webkit [274518] by commit-queue@webkit.org
  • 3 edits
    1 move
    4 adds
    3 deletes in trunk

Make WebGL conformance test update script more usable and consistent
​https://bugs.webkit.org/show_bug.cgi?id=223112

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-03-16
Reviewed by Kenneth Russell.

Tools:

Moves the script LayoutTests/webgl/generate-webgl-tests over
unused and stale Tools/Scripts/update-webgl-conformance-tests

Fixes the script to:

  • to support generation of the test driver .html files with webglVersion=2
  • copy the webgl conformance test files once to webgl/resources/webgl_test_files. Previously they were copied twice, 1.0.3/resources/.. and 2.0.0/resources
  • to support copying all the tests at the same time. Previously each individual suites (1.0.3, 2.0.0) would be copied in different invocations, leading to errors and omissions to run when something changes, such as the templates.
  • supports generation of the directories from scratch, so that no stale files such as expectations, driver .html files or test suite content is left.
  • automatically filter files that do not need to be copied (deqp/compiler.jar, ...)
  • try to adopt a style somewhat consistent with other WebKit python scripts
  • copy to upcoming 1.0.4 and 2.0.1 instead of old 1.0.3/2.0.0.
  • Scripts/update-webgl-conformance-tests:
  • Scripts/webkitpy/to_be_moved/init.py: Removed.
  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: Removed.
  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py: Removed.
  • Scripts/webkitpy/update_webgl_conformance_tests_lib/main.py: Added.

(_make_ignore_fnmatch_rule_matcher):
(_make_ignore_fnmatch_rule_matcher.match_rules):
(_copy_tree):
(_WebGLTest):
(_parse_webgl_tests):
(_filter_webgl_test_paths_for_suite_version):
(_generate_webkit_webgl_tests):
(_find_expectations_for_removed_tests):
(main):

  • Scripts/webkitpy/update_webgl_conformance_tests_lib/webgl-expectation-template.txt: Renamed from LayoutTests/webgl/resources/webgl-expectation-template.txt.
  • Scripts/webkitpy/update_webgl_conformance_tests_lib/webgl-test-driver-template.html: Renamed from LayoutTests/webgl/resources/webgl-wrapper-template.html.
  • Scripts/webkitpy/update_webgl_conformance_tests_lib/webkit-webgl-test-harness-template.js: Added.

(window.layoutTestController.window.console.log):
(window.layoutTestController.window.console.error):
(list):
(log):
(window.webglTestHarness.reportResults):
(window.webglTestHarness.notifyFinished):

LayoutTests:

Move the script over the existing but unused Tools/Scripts/update-webgl-conformance-tests.

  • webgl/generate-webgl-tests: Removed.
2:21 PM Changeset in webkit [274517] by Amir Mark Jr.
  • 2 edits in trunk/LayoutTests

[BigSur arm64] compositing/z-order/rebuild-sibling-of-layer-with-foreground-layer.html is a flakey image failure
​https://bugs.webkit.org/show_bug.cgi?id=223265

Unreviewed test gardening.

  • platform/mac/TestExpectations:
2:17 PM Changeset in webkit [274516] by Kate Cheney
  • 2 edits in trunk/Source/WebKit

[Swift] Ambiguous use of 'closeAllMediaPresentations'
​https://bugs.webkit.org/show_bug.cgi?id=223275
<rdar://problem/75447989>

Reviewed by Tim Horton.

We added back deprecated media playback control APIs in
​https://trac.webkit.org/changeset/273186/webkit after a name change
to support early adoptors. Importing these methods to Swift causes
a method redefinition error because the completion handler in both
cases is nullable. We should ignore the deprecated APIs for Swift.

  • UIProcess/API/Cocoa/WKWebView.h:
2:11 PM Changeset in webkit [274515] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS debug arm64 ] ASSERTION FAILED: count >= 1 ./rendering/RenderMultiColumnSet.cpp(450) : unsigned int WebCore::RenderMultiColumnSet::columnCount() const
​https://bugs.webkit.org/show_bug.cgi?id=223144

Unreviewed test gardening.

  • platform/mac/TestExpectations: updating expectations to crash while test is being reviewed.
2:01 PM Changeset in webkit [274514] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ BigSur wk2 arm64 ] 4 webrtc/ Layout-tests are consistently timing out
​https://bugs.webkit.org/show_bug.cgi?id=223043

Uneviewed test gadening.

  • platform/mac/TestExpectations: Re-updating expectations for one test that started timing out when marked as Failure.
1:57 PM Changeset in webkit [274513] by wilander@apple.com
  • 31 edits in trunk

PCM: Test infrastructure for sending attribution reports to attribution website too
​https://bugs.webkit.org/show_bug.cgi?id=223238
<rdar://problem/75462031>

Reviewed by Brent Fulgham.

setPrivateClickMeasurementAttributionReportURLForTesting() now is named
setPrivateClickMeasurementAttributionReportURLsForTesting() in the layers that
eventually reach WebKit::PrivateClickMeasurementManager. It takes two URLs
attributionReportSourceURL and attributionReportAttributeOnURL and sets them
in a new struct AttributionReportTestConfig.

Source/WebKit:

No new tests. This patch just adds test infrastructure for a coming patch.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::setPrivateClickMeasurementAttributionReportURLsForTesting):
(WebKit::NetworkProcess::setPrivateClickMeasurementAttributionReportURLForTesting): Deleted.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::setPrivateClickMeasurementAttributionReportURLsForTesting):
(WebKit::NetworkSession::setPrivateClickMeasurementAttributionReportURLForTesting): Deleted.

  • NetworkProcess/NetworkSession.h:
  • NetworkProcess/PrivateClickMeasurementManager.cpp:

(WebKit::PrivateClickMeasurementManager::fireConversionRequestImpl):
(WebKit::PrivateClickMeasurementManager::setAttributionReportURLsForTesting):
(WebKit::PrivateClickMeasurementManager::setAttributionReportURLForTesting): Deleted.

  • NetworkProcess/PrivateClickMeasurementManager.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPrivateClickMeasurementAttributionReportURLsForTesting):
(WKPageSetPrivateClickMeasurementAttributionReportURLForTesting): Deleted.

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
  • UIProcess/API/Cocoa/WKWebViewTesting.mm:

(-[WKWebView _setPrivateClickMeasurementAttributionReportURLsForTesting:attributeOnURL:completionHandler:]):
(-[WKWebView _setPrivateClickMeasurementAttributionReportURLForTesting:completionHandler:]): Deleted.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setPrivateClickMeasurementAttributionReportURLsForTesting):
(WebKit::WebPageProxy::setPrivateClickMeasurementAttributionReportURLForTesting): Deleted.

  • UIProcess/WebPageProxy.h:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:

(TestWebKitAPI::TEST):

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setPrivateClickMeasurementAttributionReportURLsForTesting):
(WTR::TestRunner::setPrivateClickMeasurementAttributionReportURLForTesting): Deleted.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::setPrivateClickMeasurementAttributionReportURLsForTesting):
(WTR::TestController::setPrivateClickMeasurementAttributionReportURLForTesting): Deleted.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

  • http/tests/contentextensions/block-private-click-measurement.html:
  • http/tests/privateClickMeasurement/conversion-disabled-in-ephemeral-session.html:
  • http/tests/privateClickMeasurement/expired-attribution-report-gets-sent-on-session-start.html:
  • http/tests/privateClickMeasurement/resources/getConversionData.php:
  • http/tests/privateClickMeasurement/resources/util.js:

(tearDownAndFinish):

  • http/tests/privateClickMeasurement/send-attribution-conversion-request.html:
  • http/tests/privateClickMeasurement/store-private-click-measurement-with-source-nonce.html:
  • platform/mac-wk2/TestExpectations:

This was marked as an old flaky failure and tracked in rdar://63357481.
I've kept my eye on it and it does not seem flaky anymore. Removed failure
expectation to get better test coverage.

1:51 PM Changeset in webkit [274512] by Jonathan Bedard
  • 4 edits in trunk/Tools

[git-webkit] Showing help instead of raising an exception with no command
​https://bugs.webkit.org/show_bug.cgi?id=223235
<rdar://problem/75480951>

Reviewed by Ryosuke Niwa.

  • Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
  • Scripts/libraries/webkitscmpy/webkitscmpy/program/init.py:

(main):

1:50 PM Changeset in webkit [274511] by Truitt Savell
  • 2 edits in trunk/LayoutTests

Many media/media-fragments/ tests are crashing due to other tests that run before them.
​https://bugs.webkit.org/show_bug.cgi?id=223277

Unreviewed test gardening.

  • platform/mac/TestExpectations:
1:39 PM Changeset in webkit [274510] by Alan Coon
  • 2 edits in branches/safari-611.1.21.1-branch/Source/WebCore/PAL

Cherry-pick r274023. rdar://problem/75052309

[Win] Fix compile error
​https://bugs.webkit.org/show_bug.cgi?id=222802
<rdar://problem/75052309>

Reviewed by Dean Jackson.

Declare CTFontTransformOptions if associated header file has not been included.

  • pal/spi/win/CoreTextSPIWin.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:05 PM Changeset in webkit [274509] by Patrick Angle
  • 2 edits in trunk/Source/WebCore

Web Automation: Web Share menu being open causes hang in Automation.isShowingJavaScriptDialog
​https://bugs.webkit.org/show_bug.cgi?id=223267

Reviewed by BJ Burg.

The Web Share menu should automatically resolve if the page is being controlled by automation and all other
conditions for display are met (we have no reason to reject the promise) in order to prevent hanging an
automation session on a menu that can not be interacted with.

  • page/Navigator.cpp:

(WebCore::Navigator::showShareData):

12:47 PM Changeset in webkit [274508] by Robert Jenner
  • 3 edits in trunk/LayoutTests

[ macOS Debug ] 2 imported/w3c/web-platform-tests/xhr/ are flakey text failures
Nhttps://bugs.webkit.org/show_bug.cgi?id=223271

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations: Updated expectations to Pass Fail for BigSur Debug wk1.
  • platform/mac/TestExpectations: Updated expectations to Pass Fail for BigSur Debug.
12:10 PM Changeset in webkit [274507] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[MacOS wk2] imported/w3c/web-platform-tests/media-source/SourceBuffer-abort-updating.html is a flakey failure
​https://bugs.webkit.org/show_bug.cgi?id=222210

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Removing Debug filter from expectation to cover flakiness on EWS.
12:03 PM Changeset in webkit [274506] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKitLegacy/mac

Unreviewed, reverting r274499.
​https://bugs.webkit.org/show_bug.cgi?id=223268

Not a correct fix

Reverted changeset:

"[WebView _touchEventRegions] needs to take the web lock"
​https://bugs.webkit.org/show_bug.cgi?id=223266
​https://trac.webkit.org/changeset/274499

12:02 PM Changeset in webkit [274505] by commit-queue@webkit.org
  • 3 edits
    1 move
    1 delete in trunk/JSTests

Unreviewed, reverting r274405.
​https://bugs.webkit.org/show_bug.cgi?id=223187

Test is failing now

Reverted changeset:

"[JSC] Run one Mozilla test explicitly under PST since this
test does not work when we are moving from PST to PDT"
​https://bugs.webkit.org/show_bug.cgi?id=223158
​https://trac.webkit.org/changeset/274405

12:00 PM Changeset in webkit [274504] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

The WebContent process crashes when launching Safari
​https://bugs.webkit.org/show_bug.cgi?id=223264
<rdar://75482851>

Reviewed by Brent Fulgham.

The WebContent process crashes when launching Safari on older OSes, because of unavailable sandbox features.

  • WebProcess/com.apple.WebProcess.sb.in:
11:46 AM Changeset in webkit [274503] by Alan Coon
  • 18 edits
    2 deletes in branches/safari-611.1.21.0-branch/Source/WebKit

Cherry-pick r274462. rdar://problem/75485320

Unreviewed, revert r272629 as it caused regressions in some apps
​https://bugs.webkit.org/show_bug.cgi?id=223232
<rdar://75440378>

  • SourcesCocoa.txt:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/Cocoa/PageClientImplCocoa.h:
  • UIProcess/Cocoa/PageClientImplCocoa.mm:
  • UIProcess/Cocoa/WKBlankOverlayView.h: Removed.
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::runJavaScriptAlert): (WebKit::WebPageProxy::runJavaScriptConfirm): (WebKit::WebPageProxy::runJavaScriptPrompt):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::didCommitLayerTree):
  • UIProcess/mac/WebPageProxyMac.mm:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didCommitLoad):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::updateRendering):
  • WebProcess/WebPage/mac/WebPageMac.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:46 AM Changeset in webkit [274502] by Alan Coon
  • 18 edits
    2 deletes in branches/safari-611.1.21.1-branch/Source/WebKit

Cherry-pick r274462. rdar://problem/75485338

Unreviewed, revert r272629 as it caused regressions in some apps
​https://bugs.webkit.org/show_bug.cgi?id=223232
<rdar://75440378>

  • SourcesCocoa.txt:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/Cocoa/PageClientImplCocoa.h:
  • UIProcess/Cocoa/PageClientImplCocoa.mm:
  • UIProcess/Cocoa/WKBlankOverlayView.h: Removed.
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::runJavaScriptAlert): (WebKit::WebPageProxy::runJavaScriptConfirm): (WebKit::WebPageProxy::runJavaScriptPrompt):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::didCommitLayerTree):
  • UIProcess/mac/WebPageProxyMac.mm:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didCommitLoad):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::updateRendering):
  • WebProcess/WebPage/mac/WebPageMac.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:44 AM Changeset in webkit [274501] by Megan Gardner
  • 4 edits in trunk/Source/WebCore

Attempt to restore highlights after paint to account for newly loaded content.
​https://bugs.webkit.org/show_bug.cgi?id=223191
rdar://74722200

Reviewed by Tim Horton.

  • Modules/highlight/AppHighlightStorage.cpp:

(WebCore::AppHighlightStorage::restoreUnrestoredAppHighlights):

  • Modules/highlight/AppHighlightStorage.h:
  • page/Page.cpp:

(WebCore::Page::doAfterUpdateRendering):

11:39 AM Changeset in webkit [274500] by Antti Koivisto
  • 2 edits in trunk/Source/WebKitLegacy/mac

REGRESSION (r272300): [iOS] ASSERTION FAILED: Unsafe to ref/deref from different threads under WebViewLayerFlushScheduler::layerFlushCallback
​https://bugs.webkit.org/show_bug.cgi?id=222712
<rdar://problem/75022845>

Reviewed by Simon Fraser.

We are scheduling a layer flush from a layerFlushCallback and so rescheduling the RunLoopObserver.
This is fine in itself but becomes a problem when the main thread web lock auto-unlock observer
runs before that observer. Then that layer flush runs without the web lock held and messes up
ref/deref main thread asserts (isMainThread() returns false when the web lock is not held).

  • WebView/WebViewData.mm:

(WebViewLayerFlushScheduler::layerFlushCallback):

Fix by explicitly taking the lock.

11:35 AM Changeset in webkit [274499] by Antti Koivisto
  • 2 edits in trunk/Source/WebKitLegacy/mac

[WebView _touchEventRegions] needs to take the web lock
​https://bugs.webkit.org/show_bug.cgi?id=223266

Reviewed by Simon Fraser.

Clicking anything in UIWebView test app in debug build hits thread assert immediately.

  • WebView/WebView.mm:

(-[WebView _touchEventRegions]):

11:22 AM Changeset in webkit [274498] by Alan Coon
  • 1 copy in tags/Safari-612.1.6.3

Tag Safari-612.1.6.3.

11:12 AM Changeset in webkit [274497] by Alan Coon
  • 8 edits in branches/safari-612.1.6-branch/Source

Versioning.

WebKit-7612.1.6.3

11:08 AM Changeset in webkit [274496] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

EWS is not showing filtered errors view
​https://bugs.webkit.org/show_bug.cgi?id=223251

Reviewed by Jonathan Bedard.

  • CISupport/ews-build/steps.py:

(BuildLogLineObserver.outLineReceived): Use for loop instead of map.

11:03 AM Changeset in webkit [274495] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Nicosia] Add support for scroll-snap when handling wheel events
​https://bugs.webkit.org/show_bug.cgi?id=223255

Patch by Martin Robinson <​mrobinson@igalia.com> on 2021-03-16
Reviewed by Žan Doberšek.

No new tests. This fixes css3/scroll-snap/scroll-snap-wheel-event.html
for Nicosia ports.

  • page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp:

(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::handleWheelEvent):
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::pageScaleFactor):

  • page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.h:
10:56 AM Changeset in webkit [274494] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews] Remove old Python 2 related code - part 2
​https://bugs.webkit.org/show_bug.cgi?id=222975

Reviewed by Jonathan Bedard.

  • CISupport/ews-build/steps_unittest.py:
10:55 AM Changeset in webkit [274493] by Peng Liu
  • 2 edits in trunk/LayoutTests

[GPUP] Some web audio WPT tests fail when media in GPU Process is enabled
​https://bugs.webkit.org/show_bug.cgi?id=221696

Unreviewed test gardening.

  • platform/wk2/TestExpectations:
10:43 AM Changeset in webkit [274492] by Peng Liu
  • 2 edits in trunk/LayoutTests

[GPUP] Some modern-media-controls tests are flaky when media in GPU Process is enabled
​https://bugs.webkit.org/show_bug.cgi?id=221685

Unreviewed test gardening.

  • platform/wk2/TestExpectations:
10:41 AM Changeset in webkit [274491] by achristensen@apple.com
  • 6 edits in trunk/Source

Terminate network process when making new WebProcessPool in Lutron App
​https://bugs.webkit.org/show_bug.cgi?id=223194
<rdar://74674915>

Reviewed by Geoff Garen.

Source/WebCore:

  • platform/RuntimeApplicationChecks.h:
  • platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isLutron):

  • platform/cocoa/VersionChecks.h:

Source/WebKit:

The Lutron App uses allocation of a new WKProcessPool as a way to stop using old session cookies.
Since r267763 we keep the session cookies for the lifetime of a WKWebsiteDataStore instead of making a new process for each WKProcessPool.
Add a quirk for this app until they update to use a new WKWebsiteDataStore or use WKHTTPCookieStore API to clear the cookies properly.
I manually verified this causes the logging out to succeed.

  • UIProcess/WebProcessPool.cpp:
10:33 AM Changeset in webkit [274490] by Kate Cheney
  • 2 edits in trunk/Source/WebKit

Add internal additions for WebAuthn compatibility
​https://bugs.webkit.org/show_bug.cgi?id=223168
<rdar://problem/74890060>

Reviewed by Brent Fulgham.

  • UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(shouldUseAlternateQuery):
(alternateQueryForRPID):
(WebKit::LocalAuthenticatorInternal::getExistingCredentials):

10:30 AM Changeset in webkit [274489] by Chris Gambrell
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

[LayoutTests] Convert http/tests/quicklook convert PHP to Python
​https://bugs.webkit.org/show_bug.cgi?id=223212
<rdar://problem/75444850>

Reviewed by Jonathan Bedard.

  • http/tests/quicklook/csp-header-ignored.html:
  • http/tests/quicklook/resources/word-document-with-csp-block-frame-ancestors.php: Removed.
  • http/tests/quicklook/resources/word-document-with-csp-block-frame-ancestors.py: Added.
10:20 AM Changeset in webkit [274488] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS ARM64 ] webgl/2.0.0/conformance2/textures/misc/tex-mipmap-levels.html is constantly text failing
​https://bugs.webkit.org/show_bug.cgi?id=223259

Uneviewed test gardening.

  • platform/mac/TestExpectations: Updating expectations to Failure until test can be reviewed.
10:08 AM Changeset in webkit [274487] by Peng Liu
  • 2 edits in trunk/Source/WebKit

[iOS] Scroll event is fired before webkitfullscreenchange event when an element enters fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=223221

Reviewed by Eric Carlson.

Defer the "scroll" event until the "webkitfullscreenchange" event is fired
when an element enters fullscreen. We have to do that because some sites use
"scroll" event handler to remove elements out of visible area, which may
conflict with the entering fullscreen process.

No new tests. We cannot test this patch with a layout test because
InjectedBundlePageFullScreenClient in WKTR does not support testing the
fullscreen implementation in the UI process, which is related to the "scroll"
event. We cannot add an API test on iOS for it either because the test binary
is not a real "app" (webkit.org/b/212654).

  • UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController enterFullScreen]):
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):

9:57 AM Changeset in webkit [274486] by pvollan@apple.com
  • 6 edits in trunk

Add signpost for injected bundle creation
​https://bugs.webkit.org/show_bug.cgi?id=223068

Reviewed by Alex Christensen.

Source/WebKit:

Emit signposts for creation of injected bundle.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::create):

Source/WTF:

Add trace point codes for start and end of injected bundle creation.

  • wtf/SystemTracing.h:

Tools:

Add injected bundle signposts to .plist file.

  • Tracing/SystemTracePoints.plist:
9:53 AM Changeset in webkit [274485] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

[Cocoa] YouTube audio stalls occasionally
​https://bugs.webkit.org/show_bug.cgi?id=223233
<rdar://75057532>

Reviewed by Eric Carlson.

In r273513, we added support for parsing of audio frames which spanned
appends. But in so doing, left in a bug where the size and starting byte
offset of those audio frames was miscalculated. Previously, the starting
byte offset was reset during each pass through consumeFrameData(), and the
size of the m_packetData was increased by the full packet size each pass
as well, leading to both an incorrect starting point for the frame and an
incorrect overall size of the combined packet data. This lead to a decoding
error when the parser hit the empty frame bytes after the last successful
partial parse.

Now, we will add explicit tracking of the current frame's starting byte
offset as well as the frame's size, reset after each successful full frame
parse.

  • platform/graphics/cocoa/SourceBufferParserWebM.cpp:

(WebCore::SourceBufferParserWebM::AudioTrackData::consumeFrameData):

  • platform/graphics/cocoa/SourceBufferParserWebM.h:
9:44 AM Changeset in webkit [274484] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ BigSur wk2 arm64 ] 4 webrtc/ Layout-tests are consistently timing out
​https://bugs.webkit.org/show_bug.cgi?id=223043

Uneviewed test gadening.

  • platform/mac/TestExpectations: Temporarily updating test expectations for 18 web/rtc tests that only have issues on Apple Silicon Macs, until they can be resolved.
9:34 AM Changeset in webkit [274483] by Jonathan Bedard
  • 5 edits in trunk/Tools

[webkitscmpy] Decode multiple commit representations
​https://bugs.webkit.org/show_bug.cgi?id=223224
<rdar://problem/75455129>

Reviewed by Dewei Zhu.

  • Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
  • Scripts/libraries/webkitscmpy/webkitscmpy/commit.py:

(Commit.from_json): Decode old results database style commit representations.

  • Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py:
9:21 AM Changeset in webkit [274482] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

Protect DOMFileSystem when hopping to a background thread
​https://bugs.webkit.org/show_bug.cgi?id=223246

Reviewed by Chris Dumez.

Make sure to ref when hopping to background thread and hop back to main thread to unref.

  • Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::getParent):
(WebCore::DOMFileSystem::getEntry):

9:05 AM Changeset in webkit [274481] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[prepare-ChangeLog] Assigning a multiline comment to a variable breaks change detection
​https://bugs.webkit.org/show_bug.cgi?id=223225

Patch by Dean Johnson <​dean_johnson@apple.com> on 2021-03-16
Reviewed by Jonathan Bedard.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_python): Remove '' prefix from regex so we match multiline
strings assigned to variables.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py: Add multiline string

variable definition, which previously would cause prepare-ChangeLog to parse the remainder of the file
as a multiline comment. Also add a new test to ensure it's not skipped by multiline logic.
(Class8.init):
(Class9):

8:10 AM Changeset in webkit [274480] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix GTK build with TREE_DEBUGGING enabled after r274216

  • rendering/InlineBox.h: Export several symbols to fix linking failures.
8:05 AM Changeset in webkit [274479] by Carlos Garcia Campos
  • 12 edits in trunk/Source

[GTK][WPE] Stop using g_memdup
​https://bugs.webkit.org/show_bug.cgi?id=223189

Reviewed by Philippe Normand.

Source/WebCore:

Add gstBufferNewWrappedFast() to create a GstBuffer wrapping data allocated with fast malloc and use it when
possible in combination with fastMemDup() instead of g_memdup().

  • platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::gstBufferNewWrappedFast):

  • platform/graphics/gstreamer/GStreamerCommon.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(CachedResourceStreamingClient::dataReceived):

  • platform/mediastream/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.cpp:

(WebCore::RealtimeIncomingAudioSourceLibWebRTC::OnData):

  • platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:

Source/WebKit:

  • UIProcess/API/glib/WebKitWebResource.cpp:

(webkit_web_resource_get_data_finish): Use g_malloc + memcpy instead of g_memdup.

  • UIProcess/API/glib/WebKitWebView.cpp:

(webkit_web_view_save_finish): Use fastMemDup instead g_memdup.

Source/WTF:

Add fastMemDup() to replace g_memdup() that is now deprecated in GLib because of the possibility of overflow
when converting from size_t to unsigned int. There's a replacement in GLib already, but we would need to depend
on very new GLib version, so better use fastMemDup() when possible. In cases where we still need to use GLib
allocator, we can simply call g_malloc() + memcpy().

  • wtf/FastMalloc.cpp:

(WTF::fastMemDup):

  • wtf/FastMalloc.h:
8:04 AM Changeset in webkit [274478] by calvaris@igalia.com
  • 2 edits in trunk/Source/WebCore

[GStreamer][MSE] fix video freeze in NASA TV feed
​https://bugs.webkit.org/show_bug.cgi?id=214625

Reviewed by Alicia Boya Garcia.

Initial seek should not be marked as a real seek as it is not
getting seek-datas from GStreamer and therefore it can mess up
with pipeline branches becoming empty after getting an enough-data
because the need-data is expecting seek-datas to complete that
seek that is never going to happen.

A couple of debug output lines were fixed for the same price.

  • platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

(webKitMediaSrcPrepareInitialSeek):

7:38 AM Changeset in webkit [274477] by commit-queue@webkit.org
  • 9 edits in trunk

[css-grid] Replace the use of -1 with WTF::nullopt
​https://bugs.webkit.org/show_bug.cgi?id=222376

Patch by Ziran Sun <Ziran Sun> on 2021-03-16
Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

Update failed expectations of the failing test.

  • web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001-expected.txt:

Source/WebCore:

This change replaces -1 with nullopt in grid to indicate indefinite for funtions that
return an Optional type. This change has exposed an issue when resolving replaced element
definiteness as a grid-item with respect to aspect-ratio. The fix is that when checking for
hasReplacedLogicalHeight(), for fixed item we should just return true while for percent or
calculated items we keep the check as it is.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::replacedMinMaxLogicalHeightComputesAsNone const):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::placeItemsOnGrid const):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::performGridItemsPreLayout const):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded const):

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::estimatedGridAreaBreadthForChild const):

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild const):

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::minSizeForChild const):

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithmStrategy::minLogicalSizeForChild const):

7:25 AM WebKitGTK/2.28.x edited by clopez@igalia.com
(diff)
7:25 AM WebKitGTK/2.32.x edited by clopez@igalia.com
(diff)
7:22 AM Changeset in webkit [274476] by commit-queue@webkit.org
  • 8 edits in trunk

[CMake] Build fails on RISC-V with GCC 11
​https://bugs.webkit.org/show_bug.cgi?id=222959

Patch by Khem Raj <​raj.khem@gmail.com> on 2021-03-16
Reviewed by Carlos Alberto Lopez Perez.

.:

Check for 1 byte atomic operations along with 64bit ones, some
architevtures (e.g. RISCV) operations on less than 4 bytes are not lock-free

  • Source/cmake/WebKitCompilerFlags.cmake:

Source/JavaScriptCore:

Use renamed variable ATOMICS_REQUIRE_LIBATOMIC instead of ATOMIC_INT64_REQUIRES_LIBATOMIC

  • CMakeLists.txt:

Source/WebKit:

Use renamed ATOMICS_REQUIRE_LIBATOMIC instead of ATOMIC_INT64_REQUIRES_LIBATOMIC.

  • CMakeLists.txt:

Source/WTF:

Link with libatomic if ATOMICS_REQUIRE_LIBATOMIC is set.

  • wtf/CMakeLists.txt:
7:03 AM Changeset in webkit [274475] by clopez@igalia.com
  • 3 edits in trunk/Tools

[EWS] run-layout-tests-without-patch step should only retry the tests that failed on the previous steps.
​https://bugs.webkit.org/show_bug.cgi?id=219500

Reviewed by Aakash Jain.

On the step to retry running the layout tests without patch only
run the subset of tests that failed on the previous steps.
But only do that if the previous steps didn't exceed the test
failure limit and the patch doesn't modify the TestExpectations files.

This helps to speed up the test times on the EWS when the patch
doesn't pass on the first try.

  • CISupport/ews-build/steps.py:

(RunWebKitTests.start):

6:52 AM Changeset in webkit [274474] by Lauro Moura
  • 4 edits
    2 adds in trunk

[GTK] Add GTK4 tests expectations
​https://bugs.webkit.org/show_bug.cgi?id=222907

Reviewed by Carlos Garcia Campos.

Tools:

Check whether we are using a GTK4 build to automatically enable the
platform/gtk4 expectations. This is done checking the
presence of either libwebkit2gtk-4.0.so or libwebkit2gtk-5.0.so, so it
works on binary-only deployments like the testing bots.

  • Scripts/webkitpy/port/gtk.py:

(GtkPort._search_paths):
(GtkPort._is_gtk4_build):

  • Scripts/webkitpy/port/gtk_unittest.py:

(GtkPortTest.test_gtk4_expectations_binary_only):
(GtkPortTest.test_gtk3_expectations_binary_only):
(GtkPortTest.test_gtk_expectations_both_binaries):

LayoutTests:

  • platform/gtk4/TestExpectations: Added.
6:42 AM Changeset in webkit [274473] by Aditya Keerthi
  • 4 edits in trunk/Source/WebCore

[iOS][FCR] Add pressed state for button-like controls
​https://bugs.webkit.org/show_bug.cgi?id=223208
<rdar://problem/72399087>

Reviewed by Wenson Hsieh.

Add a pressed state for buttons, checkboxes, radio buttons, select
elements and date inputs. The pressed state has a 75% opacity level
relative to the default state.

  • css/html.css:

Explicitly set the default active style to opacity: initial to ensure
styles are adjusted when the element is pressed. Note that we do not
set the default to 75% to avoid unexpected application of the new
style.

(input:matches([type="button"], [type="submit"], [type="reset"]):active, input[type="file"]::file-selector-button:active, button:active):
(input:matches([type="checkbox"], [type="radio"]):active):
(select:active):

  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

The style adjustment is only performed if the -webkit-appearance property
is not set to none. This ensures we do not override the opacity for
custom styled form controls.

(WebCore::RenderThemeIOS::adjustPressedStyle const):
(WebCore::RenderThemeIOS::adjustCheckboxStyle const):
(WebCore::RenderThemeIOS::adjustRadioStyle const):
(WebCore::RenderThemeIOS::adjustMenuListButtonStyle const):
(WebCore::RenderThemeIOS::adjustButtonStyle const):

5:20 AM Changeset in webkit [274472] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash in makeBoundaryPoint via ReplaceSelectionCommand::insertedContentRange
​https://bugs.webkit.org/show_bug.cgi?id=221509

Patch by Frederic Wang <​fwang@igalia.com> on 2021-03-16
Reviewed by Ryosuke Niwa.

Source/WebCore:

WebCore::ReplaceSelectionCommand::doApply() saves start/end positions of inserted content
into m_startOfInsertedContent and m_endOfInsertedContent. At the end, it calls
ReplaceSelectionCommand::completeHTMLReplacement() which in turn may deep clone part of the
inserted content, in order to apply style. This then result in the start/end anchor nodes
becoming orphan, causing nullptr dereference later in the code. Ideally, the anchor nodes
should be moved to the cloned nodes but this patch only works around the issue by resetting
the start/end positions.

Test: fast/editing/replace-selection-and-apply-style-crash.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::completeHTMLReplacement): If one of the anchor nodes
became orphan, just clear m_startOfInsertedContent and m_endOfInsertedContent.

LayoutTests:

Add a regression test.

  • fast/editing/replace-selection-and-apply-style-crash-expected.txt: Added.
  • fast/editing/replace-selection-and-apply-style-crash.html: Added.
2:04 AM Changeset in webkit [274471] by Lauro Moura
  • 4 edits in trunk/Source

[SOUP] Fix SOUP3 debug build
​https://bugs.webkit.org/show_bug.cgi?id=223237

Reviewed by Carlos Garcia Campos.

Source/WebCore:

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessageBody const):

Source/WebKit:

  • NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::acceptCertificateCallback):

1:45 AM Changeset in webkit [274470] by imanol
  • 6 edits in trunk/Source/WebCore

Protect this in all PlatformOpenXR queue->dispatch() calls
​https://bugs.webkit.org/show_bug.cgi?id=223211

Reviewed by Chris Dumez.

The OpenXR WorkQueue may outlive OpenXRDevice so queue->dispatch() calls without protecting this are unsafe.

  • Modules/webxr/WebXRSystem.cpp:

(WebCore::WebXRSystem::ensureImmersiveXRDeviceIsSelected):

  • platform/xr/PlatformXR.h:
  • platform/xr/openxr/OpenXRInstance.cpp:

(PlatformXR::Instance::Impl::~Impl):
(PlatformXR::Instance::enumerateImmersiveXRDevices):

  • platform/xr/openxr/PlatformXROpenXR.cpp:

(PlatformXR::OpenXRDevice::create):
(PlatformXR::OpenXRDevice::OpenXRDevice):
(PlatformXR::OpenXRDevice::initialize):
(PlatformXR::OpenXRDevice::initializeTrackingAndRendering):
(PlatformXR::OpenXRDevice::shutDownTrackingAndRendering):
(PlatformXR::OpenXRDevice::requestFrame):
(PlatformXR::OpenXRDevice::waitUntilStopping):

  • platform/xr/openxr/PlatformXROpenXR.h:
1:25 AM Changeset in webkit [274469] by youenn@apple.com
  • 13 edits in trunk

Add a new delegate for geolocation permission
​https://bugs.webkit.org/show_bug.cgi?id=223183

Reviewed by Eric Carlson.

Source/WebCore:

Add strings for a default geolocation prompt.
Covered by API tests.

  • en.lproj/Localizable.strings:

Source/WebKit:

Refactoring to reuse media capture prompt for geolocation with updated prompt strings.
Introduce a new permission delegate for geolocation which provides both the top level origin as well as frame info.
The decision handler can get grant, deny or prompt.
In case of prompt, we use the updated prompt to get grant or deny decision from the user.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/MediaPermissionUtilities.mm:

(WebKit::alertMessageText):
(WebKit::allowButtonText):
(WebKit::doNotAllowButtonText):
(WebKit::alertForPermission):

  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::decidePolicyForGeolocationPermissionRequest):

  • UIProcess/MediaPermissionUtilities.h:
  • UIProcess/SpeechRecognitionPermissionManager.cpp:

(WebKit::SpeechRecognitionPermissionManager::decideByDefaultAction):

  • UIProcess/UserMediaPermissionRequestProxy.cpp:

(WebKit::UserMediaPermissionRequestProxy::prompt):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[GeolocationDelegateNew _webView:requestGeolocationPermissionForOrigin:initiatedByFrame:decisionHandler:]):
(testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript): Deleted.
(tabEvent): Deleted.
(synthesizeTab): Deleted.
(synthesizeWheelEvents): Deleted.

1:07 AM Changeset in webkit [274468] by youenn@apple.com
  • 2 edits in trunk/LayoutTests

[ macOs Wk1 ] http/wpt/filereader/filereader-stop.html is a flakey text failure
​https://bugs.webkit.org/show_bug.cgi?id=222749
<rdar://problem/75045013>

Reviewed by Alex Christensen.

  • http/wpt/filereader/filereader-stop.html:

Update test to register the event handlers for the second load, not the first one.

Mar 15, 2021:

11:55 PM Changeset in webkit [274467] by commit-queue@webkit.org
  • 5 edits in trunk

Fix table-element-001.html
​https://bugs.webkit.org/show_bug.cgi?id=223063

Patch by Rob Buis <​rbuis@igalia.com> on 2021-03-15
Reviewed by Simon Fraser.

Source/WebCore:

The aspect-ratio property should not apply to table boxes [1].
Tables themselves should respect the property.

[1] ​https://drafts.csswg.org/css-sizing-4/#aspect-ratio

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight const):
(WebCore::RenderBox::shouldIgnoreAspectRatio const):
(WebCore::RenderBox::shouldComputeLogicalHeightFromAspectRatio const):
(WebCore::RenderBox::shouldComputeLogicalWidthFromAspectRatio const):

  • rendering/RenderBox.h:

LayoutTests:

Enable test that passes now.

10:55 PM Changeset in webkit [274466] by Nikita Vasilyev
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: remove experimental setting and enable Layout sidebar
​https://bugs.webkit.org/show_bug.cgi?id=221246
<rdar://problem/74130753>

Reviewed by BJ Burg.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/Setting.js:
  • UserInterface/Views/ElementsTabContentView.js:

(WI.ElementsTabContentView):

  • UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

10:08 PM Changeset in webkit [274465] by Patrick Angle
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles sidebar pseudo-class checkboxes appear cramped after resizing window at narrow widths
​https://bugs.webkit.org/show_bug.cgi?id=222990

Reviewed by Devin Rousso.

Fixed two compounding bugs that meant that a sidebar could end up using the base minimum width of 250px
instead of the actual minimum width as reported by the selected panel.

  • UserInterface/Views/MultiSidebar.js:

(WI.MultiSidebar.prototype.didInsertSidebarPanel):
(WI.MultiSidebar.prototype.didRemoveSidebarPanel):
(WI.MultiSidebar.prototype.didSetCollapsed):

  • Drive-by: Remove unused (and always undefined) flag argument.

(WI.MultiSidebar.prototype._updateMinimumWidthForMultipleSidebars):

  • Add logic to make sure we can calculate a valid _minimumWidthForMultipleSidebars, and add a mechanism to

allow ignoring the presence of a cached value to force a recalculation.
(WI.MultiSidebar.prototype.get _hasWidthForMultipleSidebars):

  • Ensure if possible that there is a valid _minimumWidthForMultipleSidebars.

(WI.MultiSidebar.prototype._makeSidebarPanelExclusive):

  • Sets the sidebar as non-collapsible (which sets collapsed to false) before adding the panel and setting it

as the selected panel so that we don't set the selected panel on a collapsed sidebar.

  • UserInterface/Views/SingleSidebar.js:

(WI.SingleSidebar.prototype.didSetCollapsed):

  • Drive-by: Remove always undefined flag argument, use this.collapsed instead.
9:33 PM Changeset in webkit [274464] by Patrick Angle
  • 7 edits in trunk/Source/WebCore

Web Inspector: Grid overlay does not adjust for element inside iframes
​https://bugs.webkit.org/show_bug.cgi?id=222920

Reviewed by Simon Fraser.

Resolves an issue when overlays are applied to grids within iframes, which need to account for the
position/transform of their containing frame, and any other parent frames, to appear correctly in relation to
the root frame. This patch also has the side effect of changing how drawing the grid overlay while the page is
scrolled by allowing localPointToRootPoint to account for the scroll translation instead of explicitly
offsetting drawing by the scroll offset.

Widget, ScrollView, and FrameView are updated to retain floating-point precision where necessary.

  • inspector/InspectorOverlay.cpp:

(WebCore::localPointToRootPoint):

  • Use floating-point precision instead of integer precision.

(WebCore::InspectorOverlay::drawGridOverlay):

  • Use localPointToRootPoint to calculate absolute points relative to a renderGrid's parent hierarchy.
  • Remove graphics context translation, as localPointToRootPoint will account for this translation.
  • page/FrameView.cpp:

(WebCore::FrameView::convertFromRendererToContainingView const):
(WebCore::FrameView::convertToContainingView const):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::contentsToView const):

  • platform/ScrollView.h:

(WebCore::ScrollView::convertChildToSelf const):

  • platform/Widget.cpp:

(WebCore::Widget::convertToContainingView const):

8:54 PM Changeset in webkit [274463] by commit-queue@webkit.org
  • 5 edits in trunk

REGRESSION: (r255611) [ Mac ] 3 lldb tests failing related to HashMap
​https://bugs.webkit.org/show_bug.cgi?id=207204

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-03-15
Reviewed by Simon Fraser.

Source/WTF:

  • wtf/HashTable.h:

Tools:

In r255780 I removed WebKit LLDB support for HashTables because the LLDB python API doesn't have a way to
do the equivalent of reinterpret_cast. With clever use of a union, I can get a pointer to the table and
tell LLDB it is actually a pointer to an unsigned integer array. Then, using pointer->unsigned->pointer
transformations I can dereference a negative index. It's gross, but it works and makes the tests pass again.

  • lldb/lldb_webkit.py:

(lldb_init_module):
(lldb_init_module.lldb_webkit):
(WTFHashTable_SummaryProvider):
(WTFHashMap_SummaryProvider):
(WTFHashSet_SummaryProvider):
(WTFHashMapProvider):
(WTFHashMapProvider.init):
(WTFHashMapProvider.tableSize):
(WTFHashMapProvider.keyCount):
(WTFHashSetProvider):
(WTFHashSetProvider.init):
(WTFHashSetProvider.tableSize):
(WTFHashSetProvider.keyCount):
(WTFHashTableProvider):
(WTFHashTableProvider.init):
(WTFHashTableProvider.metadataWithIndex):
(WTFHashTableProvider.tableSize):
(WTFHashTableProvider.keyCount):
(WTFHashTableProvider.num_children):
(WTFHashTableProvider.get_child_index):
(WTFHashTableProvider.get_child_at_index):
(WTFHashTableProvider.update):
(WTFHashTableProvider.has_children):

  • lldb/lldb_webkit_unittest.py:

(TestSummaryProviders):
(TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
(TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
(TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):

8:24 PM Changeset in webkit [274462] by Chris Dumez
  • 18 edits
    2 deletes in trunk/Source/WebKit

Unreviewed, revert r272629 as it caused regressions in some apps
​https://bugs.webkit.org/show_bug.cgi?id=223232
<rdar://75440378>

  • SourcesCocoa.txt:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/Cocoa/PageClientImplCocoa.h:
  • UIProcess/Cocoa/PageClientImplCocoa.mm:
  • UIProcess/Cocoa/WKBlankOverlayView.h: Removed.
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didCommitLayerTree):

  • UIProcess/mac/WebPageProxyMac.mm:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateRendering):

  • WebProcess/WebPage/mac/WebPageMac.mm:
8:07 PM Changeset in webkit [274461] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Optimize canvas repaints
​https://bugs.webkit.org/show_bug.cgi?id=223056

Reviewed by Said Abou-Hallawa.

Currently many draw operations in a canvas trigger a repaint via the didDraw()
code path which goes to HTMLCanvasElement::didDraw(). HTMLCanvasElement did track
a dirty rect and short-circuited repaints which were already dirty, but we paid
the cost of computing the dirty rect (e.g. getting the bounds of a path), and of
the hash lookup in Document::prepareCanvasesForDisplayIfNeeded() every time.

Optimize this by moving the dirty rect tracking into CanvasRenderingContext2DBase.
If the entire canvas is already dirty, we can avoid all the work (this is common,
since pages often clear the entire canvas at the start of every frame). Otherwise,
accumulate into m_dirtyRect. m_dirtyRect is cleared when we paint the canvas.

It would be nice to share more of the didDraw() code in CanvasRenderingContext2DBase
functions, but we want to be able to compute the dirty rect only if it's used, and
a WTF::function()-based approach benchmarked as slower.

This patch is an up-to-10% progression on some canvas subtests in MotionMark.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::didDraw):
(WebCore::HTMLCanvasElement::paint):

  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext.h:

(WebCore::CanvasRenderingContext::clearAccumulatedDirtyRect):
(WebCore::CanvasRenderingContext::paintRenderingResultsToCanvas):

  • html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::fillInternal):
(WebCore::CanvasRenderingContext2DBase::strokeInternal):
(WebCore::CanvasRenderingContext2DBase::fillRect):
(WebCore::CanvasRenderingContext2DBase::strokeRect):
(WebCore::CanvasRenderingContext2DBase::drawImage):
(WebCore::CanvasRenderingContext2DBase::didDraw):
(WebCore::CanvasRenderingContext2DBase::clearAccumulatedDirtyRect):
(WebCore::CanvasRenderingContext2DBase::isEntireBackingStoreDirty const):
(WebCore::CanvasRenderingContext2DBase::putImageData):
(WebCore::CanvasRenderingContext2DBase::drawTextUnchecked):

  • html/canvas/CanvasRenderingContext2DBase.h:

(WebCore::CanvasRenderingContext2DBase::didDraw):
(WebCore::CanvasRenderingContext2DBase::backingStoreBounds const):

8:03 PM Changeset in webkit [274460] by jer.noble@apple.com
  • 7 edits
    1 add in trunk

[WK2] Can get stuck in fullscreen mode if node is removed prior to receiving willEnterFullscreen()
​https://bugs.webkit.org/show_bug.cgi?id=223218
<rdar://75009548>

Reviewed by Eric Carlson.

Source/WebCore:

Return false from the following functions if a preflight check kept the function
from completing.

  • dom/FullscreenManager.cpp:

(WebCore::FullscreenManager::willEnterFullscreen):
(WebCore::FullscreenManager::didEnterFullscreen):
(WebCore::FullscreenManager::willExitFullscreen):
(WebCore::FullscreenManager::didExitFullscreen):

  • dom/FullscreenManager.h:

Source/WebKit:

There are a number of preflight checks made in each of the listed functions below,
and those preflights can corrupt the state machine of the UIProcess's fullscreen
code. If any of the preflights fail, use the new return value of those methods to
close() the fullscreen presentation.

  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::willEnterFullScreen):
(WebKit::WebFullScreenManager::didEnterFullScreen):
(WebKit::WebFullScreenManager::willExitFullScreen):
(WebKit::WebFullScreenManager::requestExitFullScreen):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/FullscreenRemoveNodeBeforeEnter.mm: Added.

(TestWebKitAPI::TEST):

7:01 PM Changeset in webkit [274459] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Avoid heap allocation in RemoteAudioDestinationProxy::renderQuantum()
​https://bugs.webkit.org/show_bug.cgi?id=223228

Reviewed by Darin Adler.

Avoid heap allocation in RemoteAudioDestinationProxy::renderQuantum() since this runs on the
audio thread.

  • WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:

(WebKit::RemoteAudioDestinationProxy::connectToGPUProcess):
(WebKit::RemoteAudioDestinationProxy::renderQuantum):

6:57 PM Changeset in webkit [274458] by Chris Dumez
  • 3 edits in trunk/Source/WTF

RunLoop::isMain() should not need to do any heap allocations
​https://bugs.webkit.org/show_bug.cgi?id=223227

Reviewed by Darin Adler.

RunLoop::isMain() should not need to do any heap allocations. Before this change,
calling RunLoop::isMain() on a non-main thread would call RunLoop::current() which
would allocate the RunLoop for the current thread. This is inefficient and an issue
for WebAudio since we're not allowed to do heap allocation on the audio rendering
thread.

  • wtf/RunLoop.cpp:

(WTF::RunLoop::runLoopHolder):
(WTF::RunLoop::current):
(WTF::RunLoop::isMain):

  • wtf/RunLoop.h:
6:25 PM Changeset in webkit [274457] by Wenson Hsieh
  • 15 edits
    2 adds in trunk

[iOS] WebPageProxy's EditorState may be stale until the next remote layer tree commit
​https://bugs.webkit.org/show_bug.cgi?id=223207
<rdar://problem/75410700>

Reviewed by Tim Horton.

Source/WebKit:

Fixes a race condition wherein it's possible for the cached EditorState in the UI process (on WebPageProxy)
to be set to a stale (older) value after being set to a newer value. This can happen in the case where:

  1. An editor state update is computed and set on a remote layer tree transaction in the web process, inside

WebPage::willCommitLayerTree. A pending BackingStoreFlusher is created, and we dispatch a task onto a
background queue to flush the layer tree commit.

  1. IPC that updates the selection arrives in the web process (e.g. WebPage::selectTextWithGranularityAtPoint),

and causes us to send an EditorStateChanged message to the UI process with this new selection.

  1. The pending BackingStoreFlusher created in step (1) dispatches on the background queue, and sends its

editor state over to the UI process.

As a result, the UI process receives the EditorStateChanged message in step (2) before it receives the remote
layer tree transaction sent in step (3), which contains the editor state computed prior to step (2); we then set
WebPageProxy::m_editorState from its value computed in step (2) to the value computed in step (1).

To fix this (and any similar issues involving out-of-band editor state updates), we introduce a monotonically
increasing transaction ID on editor state that's similar to the one used for remote layer tree commits; we then
avoid updating the editor state in WebPageProxy if we receive an EditorState whose transaction ID is less
than our current ID.

Test: fast/images/image-extraction/ios/reselect-word-in-image-overlay.html

  • Shared/EditorState.cpp:

(WebKit::EditorState::encode const):
(WebKit::EditorState::decode):

  • Shared/EditorState.h:

Add the TransactionID, and add encoding/decoding support for the new member.

  • UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::updateEditorState):

Refactor this to return a bool, indicating whether the editor state was modified (this only returns false in
the case where the incoming editor state was older than the one we currently have). We also make this method
platform-agnostic, and move the platform-dependent logic previously implemented by individual updateEditorState
implementations into WebPageProxy::didUpdateEditorState instead.

  • UIProcess/WebPageProxy.h:
  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::didUpdateEditorState):
(WebKit::WebPageProxy::updateEditorState): Deleted.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didUpdateEditorState):

Add a new platform method hook that is called when m_editorState is updated due to an incoming EditorState
from the web process. The old and new cached EditorState values are passed into this method; note that even
though only the previous value is necessary as an argument (since m_editorState is already equal to the new
value here), I chose to pass in both to make it clear that both old and new values can be consulted here.

(WebKit::WebPageProxy::updateEditorState): Deleted.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::didUpdateEditorState):
(WebKit::WebPageProxy::updateEditorState): Deleted.

  • UIProcess/playstation/WebPageProxyPlayStation.cpp:

(WebKit::WebPageProxy::didUpdateEditorState):
(WebKit::WebPageProxy::updateEditorState): Deleted.

  • UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::didUpdateEditorState):
(WebKit::WebPageProxy::updateEditorState): Deleted.

  • UIProcess/wpe/WebPageProxyWPE.cpp:

(WebKit::WebPageProxy::didUpdateEditorState):
(WebKit::WebPageProxy::updateEditorState): Deleted.

Rename these method implementations, and adjust them to use oldEditorState and newEditorState.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState const):

  • WebProcess/WebPage/WebPage.h:

LayoutTests:

  • fast/images/image-extraction/ios/reselect-word-in-image-overlay-expected.txt: Added.
  • fast/images/image-extraction/ios/reselect-word-in-image-overlay.html: Added.
5:52 PM Changeset in webkit [274456] by Alan Bujtas
  • 4 edits
    2 adds in trunk

[Multi-column] Ignore line grid offset when the grid line is shorter than 0.5px
​https://bugs.webkit.org/show_bug.cgi?id=223220
<rdar://73192773>

Reviewed by Simon Fraser.

Source/WebCore:

This is a simple check on roundToInt(line box height) to make sure we don't divide by zero.

Test: fast/multicol/crash-when-line-grid-is-shorter-than-half-px.html

  • rendering/RenderLayoutState.cpp:

(WebCore::RenderLayoutState::computeLineGridPaginationOrigin):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::lineBoxHeight const):

LayoutTests:

  • fast/multicol/crash-when-line-grid-is-shorter-than-half-px-expected.txt: Added.
  • fast/multicol/crash-when-line-grid-is-shorter-than-half-px.html: Added.
5:37 PM Changeset in webkit [274455] by commit-queue@webkit.org
  • 10 edits in trunk

REGRESSION(r271642) Another app was relying on DOMWindow reuse
​https://bugs.webkit.org/show_bug.cgi?id=223217
<rdar://75186172>

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-03-15
Reviewed by Geoff Garen.

Source/WebCore:

We already fixed an app in r273817 but in rdar://75186172 we have another broken app.
It's time for a linkedOnOrAfter check.

  • bindings/js/JSWindowProxy.cpp:

(WebCore::JSWindowProxy::setWindow):

  • platform/cocoa/VersionChecks.h:

Source/WebKit:

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(+[WKProcessPool _setLinkedOnOrBeforeEverythingForTesting]):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:

Source/WTF:

  • Scripts/Preferences/WebPreferencesInternal.yaml:

Tools:

  • TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm:

(TestWebKitAPI::TEST):

5:24 PM Changeset in webkit [274454] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS Debug ARM64 ] 2X w3c/svg tests are constantly text failing
​https://bugs.webkit.org/show_bug.cgi?id=223223

Unreviewed test gardening.

  • platform/mac/TestExpectations: Updating test expectations to constantly fail in Apple Silicon while test is being looked at.
4:44 PM Changeset in webkit [274453] by wilander@apple.com
  • 8 edits in trunk

PCM: Split attributionReportURL() into attributionReportSourceURL() and attributionReportAttributeOnURL()
​https://bugs.webkit.org/show_bug.cgi?id=223210
<rdar://problem/75442246>

Reviewed by Brent Fulgham.

This patch splits WebCore::PrivateClickMeasurement::attributionReportURL() into
Source/WebCore:

PrivateClickMeasurement::attributionReportSourceURL() and
PrivateClickMeasurement::attributionReportAttributeOnURL() to
facilitate sending attribution reports to both the click source and destination.

No new tests. This patch doesn't change functionality and the functionality is
covered by existing tests.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

Changed the assertion to check both the attribution URLs.

  • loader/PrivateClickMeasurement.cpp:

(WebCore::attributionReportURL):

Static convenience function to share code between
PrivateClickMeasurement::attributionReportSourceURL() and
PrivateClickMeasurement::attributionReportAttributeOnURL().

(WebCore::PrivateClickMeasurement::attributionReportSourceURL const):

Generates the well-known location for the click source.

(WebCore::PrivateClickMeasurement::attributionReportAttributeOnURL const):

Generates the well-known location for the click destination.

(WebCore::PrivateClickMeasurement::attributionReportURL const): Deleted.

No mostly exists as a static convenience function (see above).

  • loader/PrivateClickMeasurement.h:

Source/WebKit:

WebCore::PrivateClickMeasurement::attributionReportSourceURL() and
WebCore::PrivateClickMeasurement::attributionReportAttributeOnURL() to
facilitate sending attribution reports to both the click source and destination.

  • NetworkProcess/PrivateClickMeasurementManager.cpp:

(WebKit::PrivateClickMeasurementManager::storeUnattributed):

Removed a reference to ads in a log statement.

(WebKit::PrivateClickMeasurementManager::fireConversionRequestImpl):

Now uses WebCore::PrivateClickMeasurement::attributionReportSourceURL().

Tools:

WebCore::PrivateClickMeasurement::attributionReportSourceURL() and
WebCore::PrivateClickMeasurement::attributionReportAttributeOnURL() to
facilitate sending attribution reports to both the click source and destination.

  • TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp:

(TestWebKitAPI::TEST):

Updated to use the new functions and also not repeat tests of static
data.

4:41 PM Changeset in webkit [274452] by Alan Coon
  • 3 edits in branches/safari-611.1.21.2-branch/Source/WebKit

Cherry-pick r274439. rdar://problem/75450678

Enforce subcommand filtering
​https://bugs.webkit.org/show_bug.cgi?id=223192
<rdar://75434409>

Reviewed by Brent Fulgham.

Enforce subcommand filtering in the WebContent process' sandbox.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
  • WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:41 PM Changeset in webkit [274451] by Alan Coon
  • 3 edits in branches/safari-611.1.21.2-branch/Source/WebKit

Cherry-pick r274295. rdar://problem/75450678

[macOS] Add additional telemetry to WebContent sandbox
​https://bugs.webkit.org/show_bug.cgi?id=223080

Reviewed by Brent Fulgham.

Add additional telemetry to WebContent sandbox on macOS.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
  • WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:30 PM Changeset in webkit [274450] by Alan Coon
  • 3 edits in branches/safari-611.1.21.0-branch/Source/WebKit

Cherry-pick r274439. rdar://problem/75450660

Enforce subcommand filtering
​https://bugs.webkit.org/show_bug.cgi?id=223192
<rdar://75434409>

Reviewed by Brent Fulgham.

Enforce subcommand filtering in the WebContent process' sandbox.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
  • WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:30 PM Changeset in webkit [274449] by Alan Coon
  • 3 edits in branches/safari-611.1.21.0-branch/Source/WebKit

Cherry-pick r274295. rdar://problem/75450660

[macOS] Add additional telemetry to WebContent sandbox
​https://bugs.webkit.org/show_bug.cgi?id=223080

Reviewed by Brent Fulgham.

Add additional telemetry to WebContent sandbox on macOS.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
  • WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:29 PM Changeset in webkit [274448] by Alan Coon
  • 8 edits in branches/safari-611.1.21.2-branch/Source

Versioning.

WebKit-7611.1.21.2.3

4:26 PM Changeset in webkit [274447] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ MacOS wk2 ] inspector/debugger/breakpoints/resolved-dump-all-inline-script-pause-locations.html is flakey timing out
​https://bugs.webkit.org/show_bug.cgi?id=221759

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Re-updating test expectations to include release. Prior test expectation update gave us unexpected crashes.
3:53 PM Changeset in webkit [274446] by Alan Coon
  • 8 edits in branches/safari-611.1.21.0-branch/Source

Versioning.

WebKit-7611.1.21.0.7

3:46 PM Changeset in webkit [274445] by Alan Coon
  • 3 edits in branches/safari-611.1.21.1-branch/Source/WebKit

Cherry-pick r274439. rdar://problem/75450672

Enforce subcommand filtering
​https://bugs.webkit.org/show_bug.cgi?id=223192
<rdar://75434409>

Reviewed by Brent Fulgham.

Enforce subcommand filtering in the WebContent process' sandbox.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
  • WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:46 PM Changeset in webkit [274444] by Alan Coon
  • 2 edits in branches/safari-611.1.21.1-branch/Source/WebKit

Cherry-pick r274231. rdar://problem/75450672

Roll back in r274231 to avoid conflicts in r274439.

3:39 PM Changeset in webkit [274443] by Wenson Hsieh
  • 3 edits
    2 adds in trunk

Image overlay creation should be idempotent
​https://bugs.webkit.org/show_bug.cgi?id=223199

Reviewed by Tim Horton.

Source/WebCore:

Make sure that updateWithImageExtractionResult is idempotent given the same results object, and does not
inject redundant styles or DOM elements in the user agent shadow root.

Test: fast/images/image-extraction/image-overlay-creation-is-idempotent.html

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::updateWithImageExtractionResult):

When updating the image overlay, remove the existing overlay container element if needed, and don't bother
re-injecting the style sheet if it has already been created and inserted.

LayoutTests:

  • fast/images/image-extraction/image-overlay-creation-is-idempotent-expected.txt: Added.
  • fast/images/image-extraction/image-overlay-creation-is-idempotent.html: Added.
3:25 PM Changeset in webkit [274442] by Alan Coon
  • 8 edits in branches/safari-611.1.21.1-branch/Source

Versioning.

WebKit-7611.1.21.1.10

3:06 PM Changeset in webkit [274441] by aakash_jain@apple.com
  • 1 edit
    1 delete in trunk/Tools

Delete unused build-launcher-dmg script
​https://bugs.webkit.org/show_bug.cgi?id=222923

Reviewed by Alexey Proskuryakov.

  • CISupport/build-launcher-dmg: Removed.
2:27 PM Changeset in webkit [274440] by Alan Bujtas
  • 3 edits
    2 adds in trunk

RenderStyle::getRoundedInnerBorderFor should never produce a rect with negative width/height
​https://bugs.webkit.org/show_bug.cgi?id=223147

Reviewed by Simon Fraser.

Source/WebCore:

Width/height may get resolved to negative values when the rect goemetry (left/top) is at maximum LayoutUnit.

Test: fast/shapes/assert-when-rounded-rect-overflows.html

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getRoundedInnerBorderFor const):

LayoutTests:

  • fast/shapes/assert-when-rounded-rect-overflows-expected.txt: Added.
  • fast/shapes/assert-when-rounded-rect-overflows.html: Added.
2:22 PM Changeset in webkit [274439] by pvollan@apple.com
  • 3 edits in trunk/Source/WebKit

Enforce subcommand filtering
​https://bugs.webkit.org/show_bug.cgi?id=223192
<rdar://75434409>

Reviewed by Brent Fulgham.

Enforce subcommand filtering in the WebContent process' sandbox.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
  • WebProcess/com.apple.WebProcess.sb.in:
1:49 PM Changeset in webkit [274438] by ysuzuki@apple.com
  • 4 edits
    2 adds in trunk

WebGL should be aware of [AllowShared]
​https://bugs.webkit.org/show_bug.cgi?id=223167

Reviewed by Saam Barati.

Source/WebCore:

This patch attaches [AllowShared] IDL annotations to appropriate WebGL types, so that these functions
can accept array buffers / array buffer views which are created from SharedArrayBuffer.

  • html/canvas/WebGL2RenderingContext.idl:
  • html/canvas/WebGLRenderingContextBase.idl:

LayoutTests:

Test that these functions accept (not throwing a TypeError) array buffers etc. created from SharedArrayBuffer.

  • webgl/webgl-allow-shared-expected.txt: Added.
  • webgl/webgl-allow-shared.html: Added.
1:45 PM Changeset in webkit [274437] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Do not collapse the anonymous block when it is a candidate container for the list marker
​https://bugs.webkit.org/show_bug.cgi?id=223196
<rdar://74574330>

Reviewed by Antti Koivisto.

Do not merge empty anonymous siblings when the callers says "do not collpase anonymous block". Those merge candidate
anonymous blocks may be candidate containers for some other conent (we expand on r238119 here).

  • rendering/updating/RenderTreeBuilderBlock.cpp:

(WebCore::RenderTreeBuilder::Block::detach):

1:43 PM Changeset in webkit [274436] by Simon Fraser
  • 19 edits in trunk/Source/WebCore

Change canvasChanged() to take a Optional<FloatRect>
​https://bugs.webkit.org/show_bug.cgi?id=223203

Reviewed by Said Abou-Hallawa.

As a precursor to webkit.org/b/223056, change the FloatRect argument to
canvasChanged() to be an Optional<FloatRect>. A nullopt value here indicates
that the changed rect is inside the existing dirtied bounds of the canvas backing
store since the last repaint, so clients that are using the callback for repaint
don't need to do anything.

  • Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged):

  • Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
  • Modules/webxr/WebXRWebGLLayer.h:
  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::canvasChanged):

  • css/CSSCanvasValue.h:
  • dom/Document.cpp:

(WebCore::Document::canvasChanged):

  • dom/Document.h:
  • html/CanvasBase.cpp:

(WebCore::CanvasBase::notifyObserversCanvasChanged):

  • html/CanvasBase.h:
  • html/CustomPaintCanvas.h:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::didDraw):

  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::didDrawEntireCanvas):
(WebCore::CanvasRenderingContext2DBase::paintRenderingResultsToCanvas):

  • html/canvas/CanvasRenderingContext2DBase.h:

(WebCore::CanvasRenderingContext2DBase::backingStoreBounds const):

  • inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::canvasChanged):

  • inspector/agents/InspectorCanvasAgent.h:
1:38 PM Changeset in webkit [274435] by jer.noble@apple.com
  • 10 edits in trunk/Source

[Cocoa] Adopt AudioComponentApplyServerRegistrations()
​https://bugs.webkit.org/show_bug.cgi?id=223188
<rdar://75433850>

Reviewed by Eric Carlson.

Source/WebCore/PAL:

  • pal/cf/AudioToolboxSoftLink.cpp:
  • pal/cf/AudioToolboxSoftLink.h:

Source/WebKit:

The WebKit sandbox will block access to the AudioComponent XPC service when the
GPU process is enabled. Adopt new API to fetch the registered component data from
the priviledged UIProcess and consume that registration data in the WebContent
process, making it unnecessary to communicate with the AudioComponent XPC service
to instantiate components.

  • UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::sendAudioComponentRegistrations):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::initializeNewWebProcess):

  • UIProcess/WebProcessProxy.h:
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::consumeAudioComponentRegistrations):

1:11 PM Changeset in webkit [274434] by Said Abou-Hallawa
  • 8 edits in trunk/LayoutTests

Enable the layout test 2d.path.stroke.scale2.html
​https://bugs.webkit.org/show_bug.cgi?id=223176

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

  • web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2-expected.txt:

LayoutTests:

This layout test is now fixed on macOS and iOS after enabling GPUP for
2D canvas rendering. The reason is CGPathAddRect() has a bug which is
tracked by rdar://75419465. Encoding the CGPath converts the rectangle
command to moveTo and lineTo commands. This is unintentional workaround
for the CGPathAddRect() bug.

  • TestExpectations:
  • platform/ios-wk1/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
1:02 PM Changeset in webkit [274433] by commit-queue@webkit.org
  • 30 edits in trunk

WebGL IPC should use shared memory for synchronous messages
​https://bugs.webkit.org/show_bug.cgi?id=220974
<rdar://problem/73876947>

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-03-15
Reviewed by Geoffrey Garen.

Source/WebKit:

Send synchronous messages via the stream shared memory.
Improves MotionMark on iMac1,1 from 5000 to ~5300 pts.

If the message is encodable as a value, try to do so.
If the reply is encodable as a value, try to do so.
A message or a reply is not encodable if an argument in the message
must be passed by reference via the OS specific mechanism
(e.g. a iosurface or a file handle cannot be sent as a value).

Similar to asynchronous messages, if the synchronous message fits to
the stream buffer, the message is sent via the buffer. Same with the
reply.

If the message or reply is not sent via the stream buffer, it is sent via
the normal IPC.

The client protocol is:
1) Write the message to the buffer and release it.
2) Wait until the server releases the whole buffer back to the client.
3) Read the reply from index 0.
4) Continue sending next message from index 0.

The server protocol is upon receiving a message that is synchronous:
1) Read the message from the message position, dispatch it.
2) Write the reply to index 0.
3) Release the whole buffer back to the client.
4) Continue reading next message from index 0.

The client will not know at the send time whether the server will reply
via the stream or via normal IPC message. The client will reserve
a IPC sync request ID for normal IPC reply purposes.

In case a message or a reply does not fit to the stream buffer, the
ProcessOutOfStreamMessage message is written to the buffer instead.
This will make the reader to wait for the normal IPC message.

Changes temporarily so that the creation of the context waits for the
confirmation that the creation was done. This is due to synchrononous
stream send unable to deliver the WasCreated message during
wait for reply, at the moment.

  • GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
  • Platform/IPC/ArgumentCoder.h:
  • Platform/IPC/ArgumentCoders.h:
  • Platform/IPC/Connection.cpp:

(IPC::Connection::createSyncMessageEncoder):
(IPC::Connection::pushPendingSyncRequestID):
(IPC::Connection::popPendingSyncRequestID):
(IPC::Connection::sendSyncMessage):

  • Platform/IPC/Connection.h:

(IPC::Connection::makeSyncRequestID):
Move the code from sendSyncMessage to individual functions so
that the client can reserve a sync request ID for reply purposes.

  • Platform/IPC/StreamClientConnection.h:

(IPC::StreamClientConnection::send):
(IPC::StreamClientConnection::trySendStream):
(IPC::StreamClientConnection::sendSync):
(IPC::StreamClientConnection::trySendSyncStream):
(IPC::StreamClientConnection::tryAcquireAll):

  • Platform/IPC/StreamConnectionBuffer.h:
  • Platform/IPC/StreamServerConnection.cpp:

(IPC::StreamServerConnectionBase::acquireAll):
(IPC::StreamServerConnectionBase::release):
(IPC::StreamServerConnectionBase::releaseAll):

  • Platform/IPC/StreamServerConnection.h:

(IPC::StreamServerConnectionBase::sendSyncReply):
The implementation.

(IPC::StreamServerConnectionBase::tryAcquire):
(IPC::StreamServerConnection<Receiver>::dispatchStreamMessages):
Fix a typo StreamServerConnectionBase::tryAquire

(IPC::StreamServerConnection<Receiver>::dispatchStreamMessage):
If the message comes in as normal IPC message, it must be replied
via normal IPC.

Add a flag m_isDispatchingStreamMessage to indicate whether the
message being processed comes as a normal IPC message or a
stream message. This information must be stateful in the connection
class, as it is not passable as arguments when the execution goes through:

StreamServerConnection<Receiver>::dispatchStreamMessage()
Receiver::didReceiveStreamMessage()
handleMessageSynchronous()
StreamServerConnection<Receiver>::sendSyncReply()

  • Scripts/webkit/messages.py:

Add properties NotStreamEncodable, NotStreamEncodableReply
that indicate if the message parameters are such that they
cannot be encoded into plain data buffer as values.
This is encoded as 'constexpr bool isStreamEncodable' and
'constexpr bool isStreamEncodableReply' for the stream messages.

  • Scripts/webkit/tests/MessageArgumentDescriptions.cpp:

(IPC::jsValueForArguments):
(IPC::messageArgumentDescriptions):

  • Scripts/webkit/tests/MessageNames.cpp:

(IPC::description):
(IPC::receiverName):
(IPC::isValidMessageName):

  • Scripts/webkit/tests/MessageNames.h:
  • Scripts/webkit/tests/TestWithIfMessageMessages.h:
  • Scripts/webkit/tests/TestWithImageDataMessages.h:
  • Scripts/webkit/tests/TestWithLegacyReceiverMessages.h:
  • Scripts/webkit/tests/TestWithSemaphoreMessages.h:
  • Scripts/webkit/tests/TestWithStream.messages.in:
  • Scripts/webkit/tests/TestWithStreamBufferMessages.h:
  • Scripts/webkit/tests/TestWithStreamMessageReceiver.cpp:

(WebKit::TestWithStream::didReceiveStreamMessage):

  • Scripts/webkit/tests/TestWithStreamMessages.h:

(Messages::TestWithStream::SendMachSendRight::name):
(Messages::TestWithStream::SendMachSendRight::SendMachSendRight):
(Messages::TestWithStream::SendMachSendRight::arguments const):
(Messages::TestWithStream::ReceiveMachSendRight::name):
(Messages::TestWithStream::ReceiveMachSendRight::arguments const):
(Messages::TestWithStream::SendAndReceiveMachSendRight::name):
(Messages::TestWithStream::SendAndReceiveMachSendRight::SendAndReceiveMachSendRight):
(Messages::TestWithStream::SendAndReceiveMachSendRight::arguments const):

  • Scripts/webkit/tests/TestWithSuperclassMessages.h:
  • Scripts/webkit/tests/TestWithoutAttributesMessages.h:

Test changes related to NotStreamEncodable, NotStreamEncodableReply.

Other changes indicate an auxiliary change to message structs:
changing 'const bool isSync' to 'constexpr bool isSync'.
This is done for consistency, since 'isStreamEncodable*' properties
are also added as constexpr.

  • Shared/WebCoreArgumentCoders.cpp:
  • Shared/WebCoreArgumentCoders.h:

Make types that are WebGL sync message parameters or reply parameters
now encodable to a stream by making the encoder part a template.
Previously these were sent only by normal IPC, and did not need
to be polymorphic to the encoder.

Tools:

Mark PrepareForDisplay() as "not replyable through the stream"
since it replies with MachSendRight.

  • Scripts/generate-gpup-webgl:
12:51 PM Changeset in webkit [274432] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Avoid doing a heap allocation in AudioParam::calculateFinalValues() on the audio thread
​https://bugs.webkit.org/show_bug.cgi?id=223197
<rdar://60700260>

Reviewed by Jer Noble.

Avoid doing a heap allocation in AudioParam::calculateFinalValues() on the audio thread, for
performance reasons.

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::AudioParam):
(WebCore::AudioParam::calculateFinalValues):

  • Modules/webaudio/AudioParam.h:
12:34 PM Changeset in webkit [274431] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS wk2 ARM64 ] http/tests/local/loading-stylesheet-import-remove.html is a flakey image failure
​https://bugs.webkit.org/show_bug.cgi?id=223206

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Updating test expectations to Pass ImageOnlyFailure while test is being looked at.
12:32 PM WebKitGTK/2.32.x edited by Michael Catanzaro
(diff)
12:28 PM WebKitGTK/2.32.x edited by Michael Catanzaro
(diff)
11:54 AM Changeset in webkit [274430] by youenn@apple.com
  • 11 edits in trunk

Update getUserMedia delegate to expose frame info
​https://bugs.webkit.org/show_bug.cgi?id=223178

Reviewed by Eric Carlson.

Source/WebKit:

Covered by API test.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):
Expose frame information in the permission delegate.

Tools:

  • TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:

(-[UserMediaCaptureUIDelegateForParameters _webView:requestMediaCapturePermissionForOrigin:initiatedByFrame:audio:video:decisionHandler:]):

  • TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:

(-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCapturePermissionForOrigin:initiatedByFrame:audio:video:decisionHandler:]):
(-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCapturePermission:video:decisionHandler:]): Deleted.

  • TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:

(-[SpeechRecognitionUIDelegate _webView:requestMediaCapturePermissionForOrigin:initiatedByFrame:audio:video:decisionHandler:]):
(-[SpeechRecognitionUIDelegate _webView:requestMediaCapturePermission:video:decisionHandler:]): Deleted.

  • TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:

(-[UserMediaUIDelegate _webView:requestMediaCapturePermissionForOrigin:initiatedByFrame:audio:video:decisionHandler:]):
(-[UserMediaUIDelegate _webView:requestMediaCapturePermission:video:decisionHandler:]): Deleted.

  • TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:

(-[SimulateFailedSandboxUIDelegate _webView:requestMediaCapturePermissionForOrigin:initiatedByFrame:audio:video:decisionHandler:]):
(-[SimulateFailedSandboxUIDelegate _webView:requestMediaCapturePermission:video:decisionHandler:]): Deleted.

  • TestWebKitAPI/cocoa/UserMediaCaptureUIDelegate.h:
  • TestWebKitAPI/cocoa/UserMediaCaptureUIDelegate.mm:

(-[UserMediaCaptureUIDelegate _webView:requestMediaCapturePermissionForOrigin:initiatedByFrame:audio:video:decisionHandler:]):
(-[UserMediaCaptureUIDelegate _webView:requestMediaCapturePermission:video:decisionHandler:]): Deleted.

10:41 AM Changeset in webkit [274429] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Stop calling [NSHTTPCookieStorage sharedHTTPCookieStorage] in the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=223186
<rdar://75018105>

Reviewed by Geoffrey Garen.

NetworkStorageSession::nsCookieStorage() was calling [NSHTTPCookieStorage sharedHTTPCookieStorage]
even if cookieStorage() is not nil. I updated the condition so that we do not attempt to call
[NSHTTPCookieStorage sharedHTTPCookieStorage] when the m_isInMemoryCookieStore flag is set. The
WebProcess is using an in-memory cookie store (thus has m_isInMemoryCookieStore flag set) and
is definitely not using the shared HTTP cookie store.

  • platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::NetworkStorageSession::nsCookieStorage const):

10:38 AM Changeset in webkit [274428] by Angelos Oikonomopoulos
  • 2 edits in trunk/Source/JavaScriptCore

postprocess-asm/resolve-asm-file-conflicts.rb build failure after upgrading to F34
​https://bugs.webkit.org/show_bug.cgi?id=223136

Reviewed by Michael Catanzaro.

When parsing .file assembler directives (for the purpose of
deduplicating the file slots), also accept

.file "path/to/CWD" "path/to/include"

that seems to be emitted by GCC in some configurations. This also
uses Pathname.cleanpath on the resulting path to canonicalize the
paths. We could use .realpath, but since we only run this on the
paths in a single compilation unit and the first component is
supposed to be the CWD, this both seems unnecessary and would
complicate our selftests.

  • Scripts/resolve-asm-file-conflicts.rb:
10:34 AM Changeset in webkit [274427] by Alan Coon
  • 1 copy in tags/Safari-612.1.5.5

Tag Safari-612.1.5.5.

10:30 AM Changeset in webkit [274426] by Alan Coon
  • 8 edits in branches/safari-612.1.5-branch/Source

Versioning.

WebKit-7612.1.5.5

10:02 AM Changeset in webkit [274425] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

Add a WebAudio quirk for Zoom
​https://bugs.webkit.org/show_bug.cgi?id=223180
<rdar://75070331>

Reviewed by Eric Carlson.

Manually tested.

  • page/Quirks.cpp:

(WebCore::Quirks::shouldAutoplayWebAudioForArbitraryUserGesture const):
This allows playing audio through web audio even in cases where microphone is not yet granted or denied.

9:44 AM Changeset in webkit [274424] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Turn CSS aspect-ratio on by default
​https://bugs.webkit.org/show_bug.cgi?id=223117

Patch by Rob Buis <​rbuis@igalia.com> on 2021-03-15
Reviewed by Simon Fraser.

Turn CSS aspect-ratio on by default.

  • Scripts/Preferences/WebPreferencesExperimental.yaml:
9:42 AM WebKitGTK/2.32.x edited by Philippe Normand
(diff)
9:39 AM Changeset in webkit [274423] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

REGRESSION(r233845): EME Keysystem permission when MediaStream is disabled
​https://bugs.webkit.org/show_bug.cgi?id=223185

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-03-15
Reviewed by Eric Carlson.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestMediaKeySystemPermissionForFrame): This method is required for
EME build configurations, not MediaStream...

9:08 AM Changeset in webkit [274422] by Peng Liu
  • 7 edits in trunk

[GPUP][MSE] Add an IPC message to implement SourceBufferPrivateRemote::canSwitchToType()
​https://bugs.webkit.org/show_bug.cgi?id=223152

Reviewed by Eric Carlson.

Source/WebKit:

Add a synchronous message to implement SourceBufferPrivateRemote::canSwitchToType().

No new tests. This patch fixes a test failure.

  • GPUProcess/media/RemoteSourceBufferProxy.cpp:

(WebKit::RemoteSourceBufferProxy::canSwitchToType):

  • GPUProcess/media/RemoteSourceBufferProxy.h:
  • GPUProcess/media/RemoteSourceBufferProxy.messages.in:
  • WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:

(WebKit::SourceBufferPrivateRemote::canSwitchToType):

LayoutTests:

  • platform/mac/TestExpectations:
8:52 AM WebKitGTK/2.32.x edited by Philippe Normand
(diff)
8:20 AM Changeset in webkit [274421] by Alan Bujtas
  • 4 edits
    2 adds in trunk

Fit-border-to-line may change the layout constraints between 2 paginated line layouts
​https://bugs.webkit.org/show_bug.cgi?id=223169
<rdar://73147358>

Reviewed by Antti Koivisto.

Source/WebCore:

In paginated context, we keep triggering layout until all the widows/orphans are cleared.
This happens within the same layout frame (in practice this is a recursive call in
RenderBlockFlow::layoutBlock -see relayoutToAvoidWidows).
The constraints for these subsequent/recursive layouts should stay the same in order
to be able to clear any potential widows/orphans
(e.g first layout produces 5 lines but we can only have 3 on this page due to the widow/orphan values.
Now the subsequent/recursive layout is going to break the content at the 3rd line,
but if the constraints change in between and this layout only produces 2 lines, we'll keep trying
until we manage to produce at least 3 lines. Fit-border-to-line implemented in such an intrusive way that
it overrides previously computed logical width (mutates the constraint) -see RenderBlockFlow::fitBorderToLinesIfNeeded)

This patch ensures that we bail out of the recursive re-layout if we fail to produce the same set of lines.

Test: fast/multicol/widow-relayout-with-border-fit.html

  • rendering/ComplexLineLayout.cpp:

(WebCore::ComplexLineLayout::layoutRunsAndFloatsInRange):

LayoutTests:

  • fast/multicol/widow-relayout-with-border-fit-expected.txt: Added.
  • fast/multicol/widow-relayout-with-border-fit.html: Added.
6:36 AM Changeset in webkit [274420] by Wenson Hsieh
  • 5 edits
    5 adds in trunk

[macOS] Selecting text via mouse drag in image documents shouldn't trigger click events
​https://bugs.webkit.org/show_bug.cgi?id=223075
<rdar://problem/75334611>

Reviewed by Tim Horton.

Source/WebCore:

Improve image overlay support in image documents, by setting -webkit-user-select: text; on the image overlay
container and cursor: text; on each of the text children. Additionally, make it so that text selection in
image overlays doesn't trigger a click event, so that attempting to select text doesn't trigger click events.

Tests: fast/images/image-extraction/mac/select-image-overlay-with-mouse-drag-does-not-fire-click.html

fast/images/image-extraction/mac/select-image-overlay-with-mouse-drag.html

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::isImageOverlayText):

Make a slight adjustment here to handle the case where the host element's shadow root is not installed by the
user agent, and also so that we return true for all nodes underneath the image overlay container as well (not
just text nodes). See DragController change below for more details.

(WebCore::HTMLElement::updateWithImageExtractionResult):

  • page/DragController.cpp:

(WebCore::DragController::draggableElement const):

Make another adjustment to DragController::draggableElement, such that we don't initiate image drags when
dragging over text inside the image overlay. Note that this does not prevent drag start when the text is
selected, since that does not result in an image drag (i.e., DragSourceAction::Image).

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateSelectionForMouseDrag):

LayoutTests:

Add a couple of new layout tests to exercise the new behavior.

  • fast/images/image-extraction/mac/select-image-overlay-with-mouse-drag-does-not-fire-click-expected.txt: Added.
  • fast/images/image-extraction/mac/select-image-overlay-with-mouse-drag-does-not-fire-click.html: Added.
  • fast/images/image-extraction/mac/select-image-overlay-with-mouse-drag-expected-mismatch.html: Added.
  • fast/images/image-extraction/mac/select-image-overlay-with-mouse-drag.html: Added.
6:18 AM Changeset in webkit [274419] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Treat min-intrinsic like *-content
​https://bugs.webkit.org/show_bug.cgi?id=222854

Patch by Rob Buis <​rbuis@igalia.com> on 2021-03-15
Reviewed by Sergio Villar Senin.

Source/WebCore:

Treat min-intrinsic like *-content for intrinsic logical
content calculations.

Test: fast/flexbox/indefinite-width-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeIntrinsicLogicalContentHeightUsing const):
(WebCore::RenderBox::computeContentAndScrollbarLogicalHeightUsing const):

LayoutTests:

Add test for this.

  • fast/flexbox/indefinite-width-crash-expected.txt: Added.
  • fast/flexbox/indefinite-width-crash.html: Added.
6:15 AM Changeset in webkit [274418] by Lauro Moura
  • 2 edits in trunk/Tools

[GLIB] Filter cppfilt output when generating crash logs
​https://bugs.webkit.org/show_bug.cgi?id=223171

Reviewed by Carlos Garcia Campos.

Like the output from other external commands, the output of cppfilt
must also be decoded.

This should fix the early exits due to unicode exceptions when
running the GTK4 bot layout tests.

  • Scripts/webkitpy/port/linux_get_crash_log.py:

(GDBCrashLogGenerator.generate_crash_log): Decode cppfilt output.

6:15 AM Changeset in webkit [274417] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[GLIB] Be more selective about bublewrapping libdirs
​https://bugs.webkit.org/show_bug.cgi?id=221709

Patch by Daniel Kolesa <Daniel Kolesa> on 2021-03-15
Reviewed by Carlos Garcia Campos.

On 32-bit systems, bubblewrap lib32 instead of lib64. This unbreaks
sandbox on some distributions that have lib32 (which glibc defaults
its ld cache lookups to) but configure default libdir to lib rather
than lib32.

  • UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::bubblewrapSpawn):

6:00 AM Changeset in webkit [274416] by imanol
  • 12 edits
    1 add in trunk

Split WebXR features into enabledFeatures, supportedFeatures and requestedFeatures
​https://bugs.webkit.org/show_bug.cgi?id=222796

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

Update xrSession_requestReferenceSpace_features expectations.

  • web-platform-tests/webxr/xrSession_requestReferenceSpace_features.https-expected.txt: Added.

Source/WebCore:

Currently enabledFeatures array is used both for checking supported and enabled features. This is causing some tests to fail,
such as "test that reference spaces that aren't default features are rejected when not requested as a feature".

This patchs splits WebXR features into:

  • enabledFeatures: features thas has been granted by the permission system.
  • supportedFeatures: features that the device supports.
  • requestedFeatures: specific features that have been enabled for a specific session.

Tested by xrSession_requestReferenceSpace_features.html

  • Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::create):
(WebCore::WebXRSession::WebXRSession):
(WebCore::WebXRSession::referenceSpaceIsSupported const):

  • Modules/webxr/WebXRSession.h:
  • Modules/webxr/WebXRSystem.cpp:

(WebCore::WebXRSystem::resolveRequestedFeatures const):
(WebCore::WebXRSystem::resolveFeaturePermissions const):
(WebCore::WebXRSystem::requestSession):
(WebCore::WebXRSystem::DummyInlineDevice::DummyInlineDevice):

  • Modules/webxr/WebXRSystem.h:
  • platform/xr/PlatformXR.h:

(PlatformXR::Device::setSupportedFeatures):
(PlatformXR::Device::supportedFeatures const):

  • platform/xr/openxr/PlatformXROpenXR.cpp:

(PlatformXR::OpenXRDevice::collectSupportedFeatures):
(PlatformXR::OpenXRDevice::collectSupportedSessionModes):

  • platform/xr/openxr/PlatformXROpenXR.h:
  • testing/WebXRTest.cpp:

(WebCore::WebXRTest::simulateDeviceConnection):

LayoutTests:

Update xrSession_requestReferenceSpace_features expectations.

  • platform/wpe/TestExpectations:
6:00 AM Changeset in webkit [274415] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

CSS aspect-ratio interpolation
​https://bugs.webkit.org/show_bug.cgi?id=220848

Patch by Rob Buis <​rbuis@igalia.com> on 2021-03-15
Reviewed by Antoine Quint.

LayoutTests/imported/w3c:

Import relevant test.

  • web-platform-tests/css/css-sizing/animation/aspect-ratio-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-sizing/animation/aspect-ratio-interpolation.html: Added.

Source/WebCore:

Implement CSS aspect-ratio interpolation as defined here:
​https://drafts.csswg.org/css-values/#combine-ratio

Test: imported/w3c/web-platform-tests/css/css-sizing/animation/aspect-ratio-interpolation.html

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

5:45 AM Changeset in webkit [274414] by commit-queue@webkit.org
  • 17 edits in trunk/Source

Move vertex array functionality from ExtensionsGL to GraphicsContextGL
​https://bugs.webkit.org/show_bug.cgi?id=221665

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-03-15
Reviewed by Simon Fraser.

Source/WebCore:

There's no benefit in using ExtensionsGL, it is just adding bugs.
This commit is working towards removing ExtensionsGL.

The vertex array functionality already exists in GraphicsContextGL, use
it from there.

In WebGL1 case, the OES extension is used.

In WebGL2 case, all the functions end up calling the same functionality
underneath, regardless if client calls WebGL2 function or WebGL1
extension function.

ANGLE GenVertexArrays is the same function as GenVertexArraysOES except
GenVertexArrays is not enabled for ES 2.0 contexts.

No new tests, tested by WebGL conformance.

  • html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::isVertexArrayOES):
(WebCore::OESVertexArrayObject::bindVertexArrayOES):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::getParameter):

  • html/canvas/WebGLVertexArrayObjectOES.cpp:

(WebCore::WebGLVertexArrayObjectOES::WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::deleteObjectImpl):

  • platform/graphics/ExtensionsGL.h:
  • platform/graphics/GraphicsContextGL.h:
  • platform/graphics/angle/ExtensionsGLANGLE.cpp:
  • platform/graphics/angle/ExtensionsGLANGLE.h:
  • platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::createVertexArray):
(WebCore::GraphicsContextGLOpenGL::deleteVertexArray):
(WebCore::GraphicsContextGLOpenGL::isVertexArray):
(WebCore::GraphicsContextGLOpenGL::bindVertexArray):

  • platform/graphics/opengl/ExtensionsGLOpenGL.cpp:

(WebCore::ExtensionsGLOpenGL::createVertexArrayOES):
(WebCore::ExtensionsGLOpenGL::deleteVertexArrayOES):
(WebCore::ExtensionsGLOpenGL::isVertexArrayOES):
(WebCore::ExtensionsGLOpenGL::bindVertexArrayOES):

  • platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:
  • platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:

(WebCore::GraphicsContextGLOpenGL::createVertexArray):
(WebCore::GraphicsContextGLOpenGL::deleteVertexArray):
(WebCore::GraphicsContextGLOpenGL::isVertexArray):
(WebCore::GraphicsContextGLOpenGL::bindVertexArray):

Source/WebKit:

Generate WebGL GPUP implementation after the change.

  • GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
  • GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:

(getGraphicsResetStatusARB):

  • WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
  • WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:
4:34 AM Changeset in webkit [274413] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

RemoteRenderingBackend commands are not processed in order if GPU process is waiting for replies
​https://bugs.webkit.org/show_bug.cgi?id=222099

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-03-15
Reviewed by Simon Fraser.

Mark all asynchronous message sends with DispatchMessageEvenWhenWaitingForSyncReply.
Otherwise synchronous messages will be dispatched before asynchronous messages.
The messages are temporally dependent.

Consider initial message exchange in canvas-blending-color-over-image.html:
GPUConnectionToWebProcess_CreateRenderingBackend
RemoteRenderingBackend_CreateImageBuffer
RemoteRenderingBackend_DidCreateSharedDisplayListHandle
RemoteRenderingBackend_CreateImageBuffer
RemoteRenderingBackend_WakeUpAndApplyDisplayList
RemoteRenderingBackend_GetDataURLForImageBuffer
RemoteRenderingBackendProxy_DidCreateImageBufferBackend
RemoteRenderingBackendProxy_DidCreateImageBufferBackend

If GPU process is waiting for a sync reply when the sequence up
until GetDataURL.. arrives, then the dispatch order is:

GPUConnectionToWebProcess_CreateRenderingBackend
RemoteRenderingBackend_GetDataURLForImageBuffer

[... rest of the messages]

This is a rare case, affects only the case where:
1) These messages arrive before main thread processes the message queue
2) GPU process has sent a synchronous message and is waiting for a reply

In base case after RenderingBackend has been created and the work queue
receive queue has been installed, all messages are moved to the work
queue thread and dispatched in order of arrival.

No new tests, timing dependent and WebKit code cannot be
unit tested.

  • WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::~RemoteRenderingBackendProxy):
(WebKit::RemoteRenderingBackendProxy::reestablishGPUProcessConnection):
(WebKit::RemoteRenderingBackendProxy::createImageBuffer):
(WebKit::RemoteRenderingBackendProxy::cacheNativeImage):
(WebKit::RemoteRenderingBackendProxy::cacheFont):
(WebKit::RemoteRenderingBackendProxy::deleteAllFonts):
(WebKit::RemoteRenderingBackendProxy::releaseRemoteResource):
(WebKit::RemoteRenderingBackendProxy::sendWakeupMessage):
(WebKit::RemoteRenderingBackendProxy::createItemBuffer):

4:33 AM Changeset in webkit [274412] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit

Simulated WebGL context screen change events should work with GPU process
​https://bugs.webkit.org/show_bug.cgi?id=223121

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-03-15
Reviewed by Darin Adler.

Add a hunk missing from "WebGL context screen change events should work with GPU process"
that implements the context-specific event for simulating the context change.

Fixes

fast/canvas/webgl/webglcontextchangedevent.html

  • GPUProcess/graphics/RemoteGraphicsContextGL.cpp:

(WebKit::RemoteGraphicsContextGL::simulateEventForTesting):

4:27 AM Changeset in webkit [274411] by svillar@igalia.com
  • 6 edits in trunk

Do not shrink radio buttons bellow its size
​https://bugs.webkit.org/show_bug.cgi?id=215575

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-flexbox/radiobutton-min-size-expected.txt: Replaced FAIL by PASS expectations.

Source/WebCore:

A radio button used as a flex item would be invisible by default because it'll compute is
min-size to 0. That's why we should not let them shrink below their size (width/height).

  • platform/Theme.cpp:

(WebCore::Theme::minimumControlSize const): Do not let Radio buttons shrink bellow their size.

  • platform/Theme.h: make minimumControlSize() protected. Add a new non-virtual method with the same parameter

plus another one (the minimum size under which we cannot shrink) which calls the virtual method.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle): Pass the {style.width(),style.height()} as the minimum size under which
we should not shrink the control.

4:15 AM Changeset in webkit [274410] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r270185) [GTK] Some webgl failures after multivalue setter refactor
​https://bugs.webkit.org/show_bug.cgi?id=219340

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-03-15
Reviewed by Simon Fraser.

Construct the simulated vertex attrib 0 buffer GCGLSpan with correct size -- the
pointer is GCGLfloat, so the length should be the count of floats.

No new tests, tested by the regressed tests:
fast/canvas/webgl/gl-bind-attrib-location-test.html
fast/canvas/webgl/gl-bind-attrib-mapped-names.html
webgl/1.0.3/conformance/attribs/gl-disabled-vertex-attrib.html
webgl/1.0.3/conformance/extensions/angle-instanced-arrays-out-of-bounds.html
webgl/1.0.3/conformance/programs/gl-bind-attrib-location-long-names-test.html
webgl/1.0.3/conformance/programs/gl-bind-attrib-location-test.html
webgl/1.0.3/conformance/rendering/draw-elements-out-of-bounds.html

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::simulateVertexAttrib0):

12:36 AM Changeset in webkit [274409] by graouts@webkit.org
  • 2 edits in trunk/Source/WebCore

Improve coding style of CSSPropertyAnimation.cpp
​https://bugs.webkit.org/show_bug.cgi?id=223148

Reviewed by Darin Adler.

As much as possible, do the following:

  1. mark classes as final
  2. mark overridden methods as final
  3. move overridden methods in private sections
  4. failing that, move them to protected sections
  5. stay clear from abbreviated terms
    • prop => property
    • anim => client
    • dst => destination
  6. use from/to as parameter names instead of a/b for any method where the role of the parameters warrant it (eg. blend, canInterpolate)

This should greatly improve the coding style used throughout CSSPropertyAnimation.cpp
and make it cohesive.

  • animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore::blendFilterOperations):
(WebCore::blendFilter):
(WebCore::AnimationPropertyWrapperBase::AnimationPropertyWrapperBase):
(WebCore::AnimationPropertyWrapperBase::property const):
(WebCore::PropertyWrapperGetter::PropertyWrapperGetter):
(WebCore::PropertyWrapperGetter::value const):
(WebCore::PropertyWrapper::PropertyWrapper):
(WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper):
(WebCore::canInterpolateLengths):
(WebCore::canInterpolateLengthVariants):
(WebCore::NonNegativeFloatPropertyWrapper::NonNegativeFloatPropertyWrapper):
(WebCore::CSSPropertyAnimation::blendProperties):
(WebCore::CSSPropertyAnimation::isPropertyAnimatable):
(WebCore::CSSPropertyAnimation::animationOfPropertyIsAccelerated):
(WebCore::CSSPropertyAnimation::propertiesEqual):
(WebCore::CSSPropertyAnimation::canPropertyBeInterpolated):
(WebCore::DiscretePropertyWrapper::DiscretePropertyWrapper): Deleted.
(WebCore::LengthPropertyWrapper::LengthPropertyWrapper): Deleted.
(WebCore::LengthVariantPropertyWrapper::LengthVariantPropertyWrapper): Deleted.
(WebCore::LengthBoxPropertyWrapper::LengthBoxPropertyWrapper): Deleted.
(WebCore::PropertyWrapperClipPath::PropertyWrapperClipPath): Deleted.
(WebCore::PropertyWrapperFontVariationSettings::PropertyWrapperFontVariationSettings): Deleted.
(WebCore::PropertyWrapperShape::PropertyWrapperShape): Deleted.
(WebCore::StyleImagePropertyWrapper::StyleImagePropertyWrapper): Deleted.
(WebCore::AcceleratedPropertyWrapper::AcceleratedPropertyWrapper): Deleted.
(WebCore::PropertyWrapperFilter::PropertyWrapperFilter): Deleted.
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow): Deleted.
(WebCore::PropertyWrapperShadow::blendSimpleOrMatchedShadowLists const): Deleted.
(WebCore::PropertyWrapperShadow::blendMismatchedShadowLists const): Deleted.
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor): Deleted.
(WebCore::PropertyWrapperMaybeInvalidColor::value const): Deleted.
(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor): Deleted.
(WebCore::FillLayerPropertyWrapper::FillLayerPropertyWrapper): Deleted.
(WebCore::FillLayerPositionPropertyWrapper::FillLayerPositionPropertyWrapper): Deleted.
(WebCore::FillLayerStyleImagePropertyWrapper::FillLayerStyleImagePropertyWrapper): Deleted.
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper): Deleted.
(WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper): Deleted.
(WebCore::ShorthandPropertyWrapper:: const): Deleted.
(WebCore::PropertyWrapperFlex::PropertyWrapperFlex): Deleted.
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint): Deleted.
(WebCore::PropertyWrapperFontStyle::PropertyWrapperFontStyle): Deleted.
(WebCore::AutoPropertyWrapper::AutoPropertyWrapper): Deleted.
(WebCore::PerspectiveWrapper::PerspectiveWrapper): Deleted.
(WebCore::CSSPropertyAnimationWrapperMap::singleton): Deleted.
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForProperty): Deleted.
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForIndex): Deleted.
(WebCore::CSSPropertyAnimationWrapperMap::size): Deleted.
(WebCore::CSSPropertyAnimationWrapperMap::indexFromPropertyID): Deleted.

Mar 14, 2021:

11:20 PM Changeset in webkit [274408] by weinig@apple.com
  • 9 edits in trunk

Match other browsers by interpolating colors in floating point space rather than uint8_t space
​https://bugs.webkit.org/show_bug.cgi?id=223165

Reviewed by Antoine Quint.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-backgrounds/animations/background-color-interpolation-expected.txt:
  • web-platform-tests/css/css-backgrounds/animations/box-shadow-interpolation-expected.txt:
  • web-platform-tests/css/css-transitions/animations/text-shadow-interpolation-expected.txt:
  • web-platform-tests/css/css-ui/animation/caret-color-interpolation-expected.txt:
  • web-platform-tests/css/css-ui/outline-017-expected.txt:

Update color interpolation results.

Source/WebCore:

  • platform/graphics/ColorBlending.cpp:

(WebCore::blend):
(WebCore::blendWithoutPremultiply):
Rather than blending the components as uint8_t channels, match other browsers by blending
them as float channels. I have not yet determined if a spec says this, but matching other
browsers makes sense and fixes a bunch of WPT results. I will follow up with the CSS WG to
determine where/if this is/should be specified.

  • platform/graphics/ColorUtilities.cpp:

(WebCore::unpremultiplied):
Avoid division by zero.

5:57 PM Changeset in webkit [274407] by Fujii Hironori
  • 6 edits in trunk

[Win][WK1] Add a new API IWebPreferences::startBatchingUpdates to defer WebPreferencesChangedNotification
​https://bugs.webkit.org/show_bug.cgi?id=223109

Reviewed by Sam Weinig.

Source/WebKitLegacy/win:

Some JS tests are timing out for Windows WebKit1 Debug build since
r274111. Those tests generate very large pages. r274111 resets
WebPreferences to the initial state. Changing a preference causes
relayout. Thus, resetting preferences caused layouts repeatedly.

r274040 (Bug 218024) added _batchUpdatePreferencesInBlock to
WebPreferences for Mac WebKit1 to defer the notification.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferences.cpp:

(WebPreferences::postPreferencesChangesNotification):
(WebPreferences::startBatchingUpdates): Added.
(WebPreferences::stopBatchingUpdates): Added.

  • WebPreferences.h:

Tools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

3:18 PM Changeset in webkit [274406] by Alexey Shvayka
  • 4 edits in trunk/Source/JavaScriptCore

REGRESSION (r274308): Two assertions in JSGlobalObject::defineOwnProperty() are failing
​https://bugs.webkit.org/show_bug.cgi?id=223134

Reviewed by Yusuke Suzuki.

This patch:

  1. Simplifies exception check after validateAndApplyPropertyDescriptor() as it conditionally throws on failure.
  2. Creates new SymbolTableEntry when global variable is redefined as read-only because setAttributes() performs pack(), which doesn't support fat entries.

Due to #2, symbolTableGet() overload is simplified to return fast entry, and
setAttributes() is removed as unused.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::defineOwnProperty):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):

  • runtime/SymbolTable.h:

(JSC::SymbolTableEntry::getAttributes const):
(JSC::SymbolTableEntry::setAttributes): Deleted.

3:12 PM Changeset in webkit [274405] by ysuzuki@apple.com
  • 3 edits
    1 move
    1 add in trunk/JSTests

[JSC] Run one Mozilla test explicitly under PST since this test does not work when we are moving from PST to PDT
​https://bugs.webkit.org/show_bug.cgi?id=223158

Reviewed by Mark Lam.

This mozilla test is broken: it fails when we are close to the point moving from PST to PDT / from PDT to PST.
We should always run this test under PST to avoid this DST related flakiness.

We explicitly set TZ=PST for this test to ensure that this runs under PST (not PDT). TZ environment variable is
recognized by system frameworks and some libraries including tzdata and ICU.

  • complex.yaml:
  • complex/mozilla-ecma-Date-15.9.5.14.js: Renamed from JSTests/mozilla/ecma/Date/15.9.5.14.js.

(test):

  • complex/mozilla-shell.js: Added.

(AddTestCase):
(TestCase):
(startTest):
(test):
(getTestCaseResult):
(writeTestCaseResult):
(writeFormattedResult):
(writeLineToLog):
(writeHeaderToLog):
(stopTest):
(getFailedCases):
(getTimeZoneDiff):
(adjustResultArray):
(Day):
(DaysInYear):
(TimeInYear):
(DayNumber):
(TimeWithinDay):
(YearNumber):
(TimeFromYear):
(DayFromYear):
(InLeapYear):
(YearFromTime):
(MonthFromTime):
(DayWithinYear):
(DateFromTime):
(WeekDay):
(UTC):
(DaylightSavingTA):
(GetFirstSundayInApril):
(GetLastSundayInOctober):
(GetSecondSundayInMarch):
(GetFirstSundayInNovember):
(LocalTime):
(MakeTime):
(MakeDay):
(TimeInMonth):
(TimeClip):
(ToInteger):
(Enumerate):
(GetContext):
(OptLevel):

  • mozilla/mozilla-tests.yaml:
2:19 PM Changeset in webkit [274404] by ysuzuki@apple.com
  • 5 edits
    3 adds in trunk

Prevent dynamic import in service worker
​https://bugs.webkit.org/show_bug.cgi?id=222308

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Covering service-worker case.

  • web-platform-tests/service-workers/service-worker/import-module-scripts.https-expected.txt:

Source/WebCore:

dynamic-import should be always rejected if script is executed in Worklets or ServiceWorkers.
This is recently changed in the spec ​https://github.com/whatwg/html/pull/6395.

  • bindings/js/ScriptModuleLoader.cpp:

(WebCore::isWorkletOrServiceWorker):
(WebCore::ScriptModuleLoader::importModule):

LayoutTests:

Covering worklet case.

  • http/wpt/webaudio/the-audio-api/the-audioworklet-interface/dynamic-import-is-prohibited.https-expected.txt: Added.
  • http/wpt/webaudio/the-audio-api/the-audioworklet-interface/dynamic-import-is-prohibited.https.html: Added.
  • http/wpt/webaudio/the-audio-api/the-audioworklet-interface/processors/dynamic-import-is-prohibited.js: Added.

(DynamicImportIsProhibitedProcessor.prototype.process):
(DynamicImportIsProhibitedProcessor):

1:47 PM Changeset in webkit [274403] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Cancel image loader events after first dispatch
​https://bugs.webkit.org/show_bug.cgi?id=218556

Patch by Rob Buis <​rbuis@igalia.com> on 2021-03-14
Reviewed by Darin Adler.

Address post review comments.

  • dom/EventSender.h:

(WebCore::EventSender<T>::dispatchPendingEvents):

1:26 PM Changeset in webkit [274402] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Big Sur arm64] testb3 crashing
​https://bugs.webkit.org/show_bug.cgi?id=222815

Reviewed by Mark Lam.

Fix dmb ish and dmb ishst's formats.

  • b3/testb3_6.cpp:

(testMemoryFence):
(testStoreFence):
(testLoadFence):

1:22 PM Changeset in webkit [274401] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] ARM64 branchAtomicWeakCAS should not use sign-extension
​https://bugs.webkit.org/show_bug.cgi?id=222813

Reviewed by Mark Lam.

ARM64 branchAtomicWeakCAS implementation should not use sign-extension. Instead, it should use zero-extension.
This is because loadLinkAcq (ldaxr) will load a value with zero-extension. If we use sign-extension, we will
encounter the state where LL/SC never succeeds just because we are comparing sign-extended value and zero-extended
value. This implementation is aligned to how X86 implementation works: X86 only cares the effective bit width of branchAtomicWeakCAS.

This is already tested by stress/atomics-store-result-int52.js.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::zeroExtend):
(JSC::MacroAssemblerARM64::atomicStrongCAS):
(JSC::MacroAssemblerARM64::atomicRelaxedStrongCAS):
(JSC::MacroAssemblerARM64::branchAtomicWeakCAS):
(JSC::MacroAssemblerARM64::branchAtomicRelaxedWeakCAS):
(JSC::MacroAssemblerARM64::signExtend): Deleted.
(JSC::MacroAssemblerARM64::signExtend<8>): Deleted.
(JSC::MacroAssemblerARM64::signExtend<16>): Deleted.

11:46 AM Changeset in webkit [274400] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

GCSegmentedArray's size() and isEmpty() methods should be const.
​https://bugs.webkit.org/show_bug.cgi?id=223156

Reviewed by Keith Miller.

  • heap/GCSegmentedArray.h:
  • heap/GCSegmentedArrayInlines.h:

(JSC::GCSegmentedArray<T>::isEmpty const):
(JSC::GCSegmentedArray<T>::size const):
(JSC::GCSegmentedArray<T>::isEmpty): Deleted.
(JSC::GCSegmentedArray<T>::size): Deleted.

11:19 AM Changeset in webkit [274399] by ysuzuki@apple.com
  • 4 edits
    2 adds in trunk

[JSC] wasm atomic wait offset is not index
​https://bugs.webkit.org/show_bug.cgi?id=223159

Reviewed by Mark Lam.

JSTests:

  • wasm.yaml:
  • wasm/threads-spec-tests/resources/wait-large.wast: Added.
  • wasm/threads-spec-tests/wait-large.wast.js: Added.

Source/JavaScriptCore:

While JS Atomics.wait's argument is "index" in the typed-array, argument of wasm wait and notify is address.
But we are handling it as an index incorrectly.
This patch uses it as an address.

  • wasm/WasmOperations.cpp:

(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):

7:46 AM Changeset in webkit [274398] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

RenderLineBreak should stay inline level box even when display property says otherwise.
​https://bugs.webkit.org/show_bug.cgi?id=223151
<rdar://74339837>

Reviewed by Antti Koivisto.

In this patch we make sure that the RenderLineBreak object always stays inline.

While the display property applies to all elements (​https://drafts.csswg.org/css-display/#the-display-properties), the line
break element (<br>) seems to be an exception and all browsers handle <br style="display: block"> still as an inline level element.

Renderers can (and do see RenderSVGInline::updateFromStyle) diverge from this computed display value and say they always want to
be inline level boxes. This is ensured by RenderObject::setInline/isInline function pair.

Initially there were 2 setInline() calls:
One in RenderObject::setStyle(). It dealt with "block to inline" transition and
one call in RenderBox::setStyle().
In these functions we simply set the renderer's "inInline" bit to the computed style value (setInline(style.isDisplayInlineType)).
However derived renderer classes were able to override it by implementing the ::setStyle function and
explicitly set the "isInline" bit to true/false.

Over the years the second (RenderBox::setStyle) call transitioned to RenderBoxModelObject::updateFromStyle()
and the first (RenderObject::setStyle) call got moved to normalizeTreeAfterStyleChange() and their order got flipped.

Derived renderer classes can still explicitly set the "isInline" bit by implementing the ::updateFromStyle() function
(this is similar to what we had with ::setStyle).
However since the order is flipped, the "setInline()" call in normalizeTreeAfterStyleChange() now runs after
updateFromStyle() and it may re-reset the "isInline" bit back to the computed value (hence the FIXME).

The "setInline" call in normalizeTreeAfterStyleChange() is not needed anymore since the "isInline" bit is already updated by
the time we get here (as opposed to when it was initially introduced in RenderObject::setStyle, see above).

  • rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::updateFromStyle):

  • rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::normalizeTreeAfterStyleChange):

1:16 AM Changeset in webkit [274397] by Lauro Moura
  • 3 edits in trunk

[GLIB] Keep GPUProcess disabled when using experimental features
​https://bugs.webkit.org/show_bug.cgi?id=223155

Reviewed by Philippe Normand.

At least two recent GPUProcess-related revisions caused issues in
GLIB, causing serious regressions in the bots. Disabling it for now
until we improve its support.

Revisions:

r274327 - 2D Canvas enabled by default in GPUProcess
r272842 - Media enabled by default in GPUProcess

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:
Note: See TracTimeline for information about the timeline view.