Changes between Version 1 and Version 2 of CodeReview
- 07/22/10 12:24:19 (3 years ago)
v1 v2 5 5 * Make your patch as small as possible. '''Really, seriously, go out of your way to make sure you've broken down your patch into the smallest self-contained chunks possible.''' 6 6 * Only do/fix one thing per patch. Don't change a behavior and then add a fix for an incidental thing that you noticed while doing the original change. It should be two patches. 7 7 8 * Do style cleanup or other significant refactoring in a separate patch, preferably as a precursor to the patch you want to land. Especially end of line whitespace cleanup as this just adds a lot of visual noise to the review. 8 9 * Add short per function comments in the change log (see any of Darin Adler's changes for a good example). These help reviewers quickly understand why you are doing a change in that function.