Changes between Version 12 and Version 13 of Creating and Submitting Layout Tests and Patches

Timestamp:

Feb 25, 2013 9:36:51 PM (11 years ago)

Author:

glenn@skynav.com

Comment:

add description about using webkit-patch upload instead of svn-create-patch

Creating and Submitting Layout Tests and Patches

@@ -35 +35 @@
  * Run {{{prepare-ChangeLog}}} from a directory that contains all of your changes (to be safe at the expense of speed, you can use the top of your working copy).
  * Examine the output from that script and manually edit any !ChangeLog files it edited. Add bug reference(s) and brief descriptions for each change, following the examples in the file. Be sure to use spaces rather than tabs, just like in source code. 
- * Make the actual patch by running {{{svn-create-patch > patch.txt}}}. Your testcase changes and the lines you added to ChangeLog(s) will show up as part of the patch, which is what you want. (If they don't, probably you either need to {{{svn add}}} the files or you ran {{{svn-create-patch}}} from too deep a directory.)
+ * Make the actual patch by running {{{svn-create-patch > patch.txt}}}. Your testcase changes and the lines you added to ChangeLog(s) will show up as part of the patch, which is what you want. (If they don't, probably you either need to {{{svn add}}} the files or you ran {{{svn-create-patch}}} from too deep a directory.) Alternatively, and preferably, use {{{webkit-patch upload}}} to create and upload the patch to the Bugzilla bug in one step.
 
 === Submit it ===
  
- * Attach your patch to the Bugzilla bug and set {{{review?}}} on it, leaving the requestee field empty. Wait for review.
+ * If you used {{{svn-create-patch}}}, then attach your patch to the Bugzilla bug and set {{{review?}}} on it, leaving the requestee field empty. Wait for review.
+ * If you used {{{webkit-patch upload}}} as described above, then the patch will already have been uploaded as an attachment to the bug. When doing this, a review will automatically be requested unless you add the {{{--no-review}}} option, e.g., by specifying {{{webkit-patch upload --no-review}}}. Note that uploading a new patch will obsolete a previous patch unless you specify the {{{--no-obsolete}}} option. Use {{{webkit-patch help upload}}} to learn about other options.
 
 === Flow chart ===