Changes between Version 77 and Version 78 of QtWebKitContrib


Ignore:
Timestamp:
Jun 28, 2011 1:09:03 PM (10 years ago)
Author:
Ademar Reis
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • QtWebKitContrib

    v77 v78  
    4040== Submitting a patch ==
    4141When using a git repository to access the sources, the steps to submit a patch are roughly as follows. Please see the WebKit project's page about [http://webkit.org/coding/contributing.html contributing] for more information.
    42  * Make your changes
    43  * Add a [http://webkit.org/quality/testwriting.html layout test]
    44  * If you are using Git to create patches , read UsingGitWithWebKit#WebKitScriptsupportforGit
    45  * Run the {{{Tools/Scripts/check-webkit-style}}} script.
    46  * Run the {{{Tools/Scripts/prepare-ChangeLog}}} script to create an entry for your changes in each relevant ChangeLog file.
    47  * Edit the ChangeLog files reported by the prepare-ChangeLog script:
    48    * If you work on a task without bug report on bugs.webkit.org yet, create a bug report. Use the severity "Enhancement" if your patch is an improvement and not related to a bug.
    49    * Add a short description and paste the bug URL below it. Add an extra line and a detailed description if necessary.
    50    * Precede the short description with "[Qt]" if your patch is specific to the Qt port of WebKit.
    51    * The description text should be the same in all ChangeLog files.
    52    * Keep the "Reviewed by NOBODY (OOPS!)." line in the ChangeLog files, it will be edited by the bot or person that will commit your fix.
    53  * Do a {{{git diff > patchname.patch}}} to create your patch (use {{{--cached}}} if you first did a {{{git add}}} to put your changes in the git index). For detailed help, see UsingGitWithWebKit
    54  * Attach the patch to the bug report, set the {{{review}}} flag to '?' and the {{{commit-queue}}} flag to '?'
    55  * Wait :)
     42 * Make your changes;
     43 * Add a [http://webkit.org/quality/testwriting.html layout test];
     44 * If you are using Git to create patches, read UsingGitWithWebKit#WebKitScriptsupportforGit;
     45 * Use the {{{Tools/Scripts/webkit-patch}}} script to automate the patch submission (e.g.: {{{Tools/Scripts/webkit-patch upload--request-commit}}});
     46 * See the section below for instructions on how to fill the changelogs;
     47 * OR
     48   * Run the {{{Tools/Scripts/check-webkit-style}}} script;
     49   * Create a bug for the issue you're fixing: http://webkit.org/new-qtwebkit-bug
     50   * Run the {{{Tools/Scripts/prepare-ChangeLog}}} script to create an entry for your changes in each relevant ChangeLog file. Check --help;
     51   * Edit the ChangeLog files reported by the prepare-ChangeLog script (see section below);
     52   * Do a {{{git diff > patchname.patch}}} to create your patch (use {{{--cached}}} if you first did a {{{git add}}} to put your changes in the git index). For detailed help, see UsingGitWithWebKit;
     53   * Attach the patch to the bug report, set the {{{review}}} flag to '?' and the {{{commit-queue}}} flag to '?';
     54 * Wait for review/approval. :)
     55
     56=== Notes on !ChangeLogs ===
     57 * WebKit has changelog files inside each project module;
     58 * Use {{{Tools/Scripts/prepare-ChangeLog}}} or {{{Tools/Scripts/webkit-patch}}} to fill the basics;
     59 * Changelogs have a short description (usually the bug title), the bug URL, an extra line and an optional detailed description.
     60 * The short description should be preceeded with "[Qt]" if the patch is specific to the Qt port of WebKit.
     61 * Keep the "Reviewed by NOBODY (OOPS!)." line in the ChangeLog files, it will be edited by the bot or person that commits your fix.
    5662
    5763== Hacking on QtWebKit ==