source: webkit/trunk/LayoutTests/fast/forms/script-tests/input-number-keyoperation.js @ 80096

Last change on this file since 80096 was 80096, checked in by tkent@chromium.org, 13 years ago

Support localized numbers in <input type=number>
​https://bugs.webkit.org/show_bug.cgi?id=42484

Reviewed by Dimitri Glazkov.

Source/WebCore:

This change adds support of localized numbers in <input type=number>.
This affects only the UI, and not HTMLInputElement::value.

  • Remove the keyboard input restriction feature because it is hard to retrieve characters usable for localized numbers in ICU.
  • Separate convertFromVisibleValue() from sanitizeValue(). sanitizeValue() is used for not only converting a renderer value to a DOM value.
  • Implement LocalizedNumber functions for ICU and NSNumberFormatter. It is used only in Chromium for now.

Test: manual-tests/input-number-localization.html

  • WebCore.gypi: Use LocalizedNumberICU.cpp.
  • WebCore.xcodeproj/project.pbxproj: Add LocalizedNumberMac.mm and remove LocalizedNumberNone.cpp.
  • dom/InputElement.h: Introduce convertFromVisibleValue().
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::convertFromVisibleValue):

  • html/HTMLInputElement.h:
  • html/InputType.cpp:

(WebCore::InputType::convertFromVisibleValue):

  • html/InputType.h:
  • html/NumberInputType.cpp: Remove isHTMLNumberCharacter(), isNumberCharacter(), and handleBeforeTextInsertedEvent() because we remove the keyboard input restriction feature for type=number.

(WebCore::NumberInputType::convertFromVisibleValue):
(WebCore::NumberInputType::sanitizeValue):

  • html/NumberInputType.h:
  • manual-tests/input-number-localization.html: Add a manual test because the behavior depends on the current locale.
  • platform/text/LocalizedNumber.h: Remove isLocalizedNumberCharacter().
  • platform/text/LocalizedNumberICU.cpp: Implement LocalizedNumber functions with ICU NumberFormat.

(WebCore::createFormatterForCurrentLocale):
(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):

  • platform/text/LocalizedNumberNone.cpp: Remove isLocalizedNumberCharacter().
  • platform/text/mac/LocalizedNumberMac.mm: Implement LocalizedNumber functions with NSNumberFormatter.

(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::subtreeHasChanged):

  • wml/WMLInputElement.h:

(WebCore::WMLInputElement::convertFromVisibleValue):

Implemented as a function doing nothing.

LayoutTests:

Update an existing test because of removing the keyboard input
restriction feature.

  • fast/forms/input-number-keyoperation-expected.txt:
  • fast/forms/script-tests/input-number-keyoperation.js:
File size: 930 bytes
Line 
1description('Test for keyboard operations for &lt;input type=number>');
2var parent = document.createElement('div');
3document.body.appendChild(parent);
4parent.innerHTML = '<input type=number id=number>';
5
6var input = document.getElementById('number');
7input.focus();
8debug('Inserting "ab123cd":');
9document.execCommand('InsertText', false, 'ab123cd');
10shouldBe('input.value', '""');
11
12debug('Press the up arrow key:');
13input.valueAsNumber = 123;
14eventSender.keyDown('upArrow');
15shouldBe('input.value', '"124"');
16
17debug('Press the down arrow key:');
18eventSender.keyDown('downArrow');
19shouldBe('input.value', '"123"');
20
21debug('Disable input element:');
22input.disabled = true;
23eventSender.keyDown('upArrow');
24shouldBe('input.value', '"123"');
25input.removeAttribute('disabled');
26
27debug('Read-only input element:');
28input.readOnly = true;
29eventSender.keyDown('upArrow');
30shouldBe('input.value', '"123"');
31
32var successfullyParsed = true;
Note: See TracBrowser for help on using the repository browser.