Changeset 204250 in webkit


Ignore:
Timestamp:
Aug 7, 2016 10:40:50 PM (17 months ago)
Author:
Carlos Garcia Campos
Message:

[GTK] Bad performance in accelerated compositing mode with the modesetting intel driver and DRI3 enabled
​https://bugs.webkit.org/show_bug.cgi?id=160491

Reviewed by Michael Catanzaro.

This is becoming the default in several linux distributions and it makes WebKitGTK+ unusable in accelerated
compositing mode, which is now always enabled because since we switched to use the threaded compositor. The
problem seems to be an optimization of the intel driver for windows that are offscreen, and our redirected
window is always positioned at ScreenWidth + 1, 0. Using negative coordinates to position the redirected window
offscreen fixes the problem.
See also ​https://bugs.freedesktop.org/show_bug.cgi?id=85064.

  • WebProcess/WebPage/gtk/RedirectedXCompositeWindow.cpp:

(WebKit::RedirectedXCompositeWindow::RedirectedXCompositeWindow): Position the parent window at -1, -1.

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r204249 r204250  
     12016-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GTK] Bad performance in accelerated compositing mode with the modesetting intel driver and DRI3 enabled
     4        https://bugs.webkit.org/show_bug.cgi?id=160491
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        This is becoming the default in several linux distributions and it makes WebKitGTK+ unusable in accelerated
     9        compositing mode, which is now always enabled because since we switched to use the threaded compositor. The
     10        problem seems to be an optimization of the intel driver for windows that are offscreen, and our redirected
     11        window is always positioned at ScreenWidth + 1, 0. Using negative coordinates to position the redirected window
     12        offscreen fixes the problem.
     13        See also https://bugs.freedesktop.org/show_bug.cgi?id=85064.
     14
     15        * WebProcess/WebPage/gtk/RedirectedXCompositeWindow.cpp:
     16        (WebKit::RedirectedXCompositeWindow::RedirectedXCompositeWindow): Position the parent window at -1, -1.
     17
    1182016-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
    219

  • trunk/Source/WebKit2/WebProcess/WebPage/gtk/RedirectedXCompositeWindow.cpp

    r204013 r204250  
    7373    m_parentWindow = XCreateWindow(m_display,
    7474        RootWindowOfScreen(screen),
    75         WidthOfScreen(screen) + 1, 0, 1, 1,
     75        -1, -1, 1, 1,
    7676        0,
    7777        gdk_visual_get_depth(visual),
Note: See TracChangeset for help on using the changeset viewer.