Changeset 268659 in webkit


Ignore:
Timestamp:
Oct 18, 2020 9:11:03 AM (21 months ago)
Author:
emilio
Message:

Serialize aspect ratio with spaces around the slash.
​https://bugs.webkit.org/show_bug.cgi?id=217888

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • web-platform-tests/css/mediaqueries/aspect-ratio-serialization-expected.txt: Annotate progression.

Source/WebCore:

Tests: web-platform-tests/css/mediaqueries/aspect-ratio-serialization-expected.txt

  • css/CSSAspectRatioValue.cpp:

(WebCore::CSSAspectRatioValue::customCSSText const): Add the spaces.

LayoutTests:

  • fast/css/aspect-ratio-inheritance-expected.txt:
  • fast/css/aspect-ratio-inheritance.html:
  • fast/css/aspect-ratio-parsing-tests-expected.txt:
  • fast/css/aspect-ratio-parsing-tests.html:

Adjust tests

Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r268640 r268659  
     12020-10-18  Emilio Cobos Álvarez  <emilio@crisal.io>
     2
     3        Serialize aspect ratio with spaces around the slash.
     4        https://bugs.webkit.org/show_bug.cgi?id=217888
     5
     6        Reviewed by Sam Weinig.
     7
     8        * fast/css/aspect-ratio-inheritance-expected.txt:
     9        * fast/css/aspect-ratio-inheritance.html:
     10        * fast/css/aspect-ratio-parsing-tests-expected.txt:
     11        * fast/css/aspect-ratio-parsing-tests.html:
     12        Adjust tests
     13
    1142020-10-17  Ross Kirsling  <ross.kirsling@sony.com>
    215

  • trunk/LayoutTests/fast/css/aspect-ratio-inheritance-expected.txt

    r163840 r268659  
    1 PASS testComputedValue("aspectRatioTest1", "1 / 4", "-webkit-aspect-ratio") is "1/4"
    2 PASS testComputedValue("aspectRatioTest1", "inherit", "-webkit-aspect-ratio") is "1/2"
     1PASS testComputedValue("aspectRatioTest1", "1 / 4", "-webkit-aspect-ratio") is "1 / 4"
     2PASS testComputedValue("aspectRatioTest1", "inherit", "-webkit-aspect-ratio") is "1 / 2"
    33PASS testComputedValue("aspectRatioTest1", "auto", "-webkit-aspect-ratio") is "auto"
    4 PASS testComputedValue("aspectRatioTest2", "1 / 4", "-webkit-aspect-ratio") is "1/4"
     4PASS testComputedValue("aspectRatioTest2", "1 / 4", "-webkit-aspect-ratio") is "1 / 4"
    55PASS testComputedValue("aspectRatioTest2", "inherit", "-webkit-aspect-ratio") is "from-dimensions"
    6 PASS testComputedValue("aspectRatioTest3", "1 / 4", "-webkit-aspect-ratio") is "1/4"
     6PASS testComputedValue("aspectRatioTest3", "1 / 4", "-webkit-aspect-ratio") is "1 / 4"
    77PASS testComputedValue("aspectRatioTest3", "inherit", "-webkit-aspect-ratio") is "from-intrinsic"
    88PASS successfullyParsed is true

  • trunk/LayoutTests/fast/css/aspect-ratio-inheritance.html

    r163840 r268659  
    1818        return computedValue;
    1919    }
    20     shouldBeEqualToString('testComputedValue("aspectRatioTest1", "1 / 4", "-webkit-aspect-ratio")', '1/4');
    21     shouldBeEqualToString('testComputedValue("aspectRatioTest1", "inherit", "-webkit-aspect-ratio")', '1/2');
     20    shouldBeEqualToString('testComputedValue("aspectRatioTest1", "1 / 4", "-webkit-aspect-ratio")', '1 / 4');
     21    shouldBeEqualToString('testComputedValue("aspectRatioTest1", "inherit", "-webkit-aspect-ratio")', '1 / 2');
    2222    shouldBeEqualToString('testComputedValue("aspectRatioTest1", "auto", "-webkit-aspect-ratio")', 'auto');
    23     shouldBeEqualToString('testComputedValue("aspectRatioTest2", "1 / 4", "-webkit-aspect-ratio")', '1/4');
     23    shouldBeEqualToString('testComputedValue("aspectRatioTest2", "1 / 4", "-webkit-aspect-ratio")', '1 / 4');
    2424    shouldBeEqualToString('testComputedValue("aspectRatioTest2", "inherit", "-webkit-aspect-ratio")', 'from-dimensions');
    25     shouldBeEqualToString('testComputedValue("aspectRatioTest3", "1 / 4", "-webkit-aspect-ratio")', '1/4');
     25    shouldBeEqualToString('testComputedValue("aspectRatioTest3", "1 / 4", "-webkit-aspect-ratio")', '1 / 4');
    2626    shouldBeEqualToString('testComputedValue("aspectRatioTest3", "inherit", "-webkit-aspect-ratio")', 'from-intrinsic');
    2727</script>

  • trunk/LayoutTests/fast/css/aspect-ratio-parsing-tests-expected.txt

    r163840 r268659  
    44
    55
    6 PASS testParsing("aspectRatioTest", "2/1", "-webkit-aspect-ratio") is "2/1"
    7 PASS testParsing("aspectRatioTest", "1/1", "-webkit-aspect-ratio") is "1/1"
    8 PASS testParsing("aspectRatioTest", "1/4", "-webkit-aspect-ratio") is "1/4"
    9 PASS testParsing("aspectRatioTest", "1 / 2", "-webkit-aspect-ratio") is "1/2"
    10 PASS testParsing("aspectRatioTest", "1.2 / 2", "-webkit-aspect-ratio") is "1.2/2"
    11 PASS testParsing("aspectRatioTest", "2 / 0.5", "-webkit-aspect-ratio") is "2/0.5"
     6PASS testParsing("aspectRatioTest", "2/1", "-webkit-aspect-ratio") is "2 / 1"
     7PASS testParsing("aspectRatioTest", "1/1", "-webkit-aspect-ratio") is "1 / 1"
     8PASS testParsing("aspectRatioTest", "1/4", "-webkit-aspect-ratio") is "1 / 4"
     9PASS testParsing("aspectRatioTest", "1 / 2", "-webkit-aspect-ratio") is "1 / 2"
     10PASS testParsing("aspectRatioTest", "1.2 / 2", "-webkit-aspect-ratio") is "1.2 / 2"
     11PASS testParsing("aspectRatioTest", "2 / 0.5", "-webkit-aspect-ratio") is "2 / 0.5"
    1212PASS testParsing("aspectRatioTest", "inherit", "-webkit-aspect-ratio") is "inherit"
    1313PASS testParsing("aspectRatioTest", "from-dimensions", "-webkit-aspect-ratio") is "from-dimensions"

  • trunk/LayoutTests/fast/css/aspect-ratio-parsing-tests.html

    r163840 r268659  
    1717      }
    1818
    19       shouldBeEqualToString('testParsing("aspectRatioTest", "2/1", "-webkit-aspect-ratio")', '2/1');
    20       shouldBeEqualToString('testParsing("aspectRatioTest", "1/1", "-webkit-aspect-ratio")', '1/1');
    21       shouldBeEqualToString('testParsing("aspectRatioTest", "1/4", "-webkit-aspect-ratio")', '1/4');
    22       shouldBeEqualToString('testParsing("aspectRatioTest", "1 / 2", "-webkit-aspect-ratio")', '1/2');
    23       shouldBeEqualToString('testParsing("aspectRatioTest", "1.2 / 2", "-webkit-aspect-ratio")', '1.2/2');
    24       shouldBeEqualToString('testParsing("aspectRatioTest", "2 / 0.5", "-webkit-aspect-ratio")', '2/0.5');
     19      shouldBeEqualToString('testParsing("aspectRatioTest", "2/1", "-webkit-aspect-ratio")', '2 / 1');
     20      shouldBeEqualToString('testParsing("aspectRatioTest", "1/1", "-webkit-aspect-ratio")', '1 / 1');
     21      shouldBeEqualToString('testParsing("aspectRatioTest", "1/4", "-webkit-aspect-ratio")', '1 / 4');
     22      shouldBeEqualToString('testParsing("aspectRatioTest", "1 / 2", "-webkit-aspect-ratio")', '1 / 2');
     23      shouldBeEqualToString('testParsing("aspectRatioTest", "1.2 / 2", "-webkit-aspect-ratio")', '1.2 / 2');
     24      shouldBeEqualToString('testParsing("aspectRatioTest", "2 / 0.5", "-webkit-aspect-ratio")', '2 / 0.5');
    2525      shouldBeEqualToString('testParsing("aspectRatioTest", "inherit", "-webkit-aspect-ratio")', 'inherit');
    2626      shouldBeEqualToString('testParsing("aspectRatioTest", "from-dimensions", "-webkit-aspect-ratio")', 'from-dimensions');

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r268648 r268659  
     12020-10-18  Emilio Cobos Álvarez  <emilio@crisal.io>
     2
     3        Serialize aspect ratio with spaces around the slash.
     4        https://bugs.webkit.org/show_bug.cgi?id=217888
     5
     6        Reviewed by Sam Weinig.
     7
     8        * web-platform-tests/css/mediaqueries/aspect-ratio-serialization-expected.txt: Annotate progression.
     9
    1102020-10-16  Darin Adler  <darin@apple.com>
    211

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/aspect-ratio-serialization-expected.txt

    r264522 r268659  
    11
    2 FAIL <ratio> serializes with spaces around the integer. assert_equals: expected "(aspect-ratio: 1 / 3)" but got "(aspect-ratio: 1/3)"
     2PASS <ratio> serializes with spaces around the integer.
    33

  • trunk/Source/WebCore/ChangeLog

    r268658 r268659  
     12020-10-18  Emilio Cobos Álvarez  <emilio@crisal.io>
     2
     3        Serialize aspect ratio with spaces around the slash.
     4        https://bugs.webkit.org/show_bug.cgi?id=217888
     5
     6        Reviewed by Sam Weinig.
     7
     8        Tests: web-platform-tests/css/mediaqueries/aspect-ratio-serialization-expected.txt
     9
     10        * css/CSSAspectRatioValue.cpp:
     11        (WebCore::CSSAspectRatioValue::customCSSText const): Add the spaces.
     12
    1132020-10-18  Zalan Bujtas  <zalan@apple.com>
    214

  • trunk/Source/WebCore/css/CSSAspectRatioValue.cpp

    r254514 r268659  
    3636String CSSAspectRatioValue::customCSSText() const
    3737{
    38     return makeString(m_numeratorValue, '/', m_denominatorValue);
     38    return makeString(m_numeratorValue, " / ", m_denominatorValue);
    3939}
    4040
Note: See TracChangeset for help on using the changeset viewer.