Changeset 268726 in webkit


Ignore:
Timestamp:
Oct 20, 2020 5:19:27 AM (21 months ago)
Author:
svillar@igalia.com
Message:

[css-flexbox] order property should be animatable
​https://bugs.webkit.org/show_bug.cgi?id=209876

Reviewed by Antoine Quint.

LayoutTests/imported/w3c:

Updated ~150 FAIL expectations to PASS.

  • web-platform-tests/css/css-flexbox/animation/order-interpolation-expected.txt: Updated expectations.
  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt: Ditto.
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt: Ditto.
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt: Ditto.

Source/WebCore:

Make order property animatable as per spec. This allows us to pass ~150 flexbox animation subtests.

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Mark property as animatable.

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r268718 r268726  
     12020-10-20  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        [css-flexbox] order property should be animatable
     4        https://bugs.webkit.org/show_bug.cgi?id=209876
     5
     6        Reviewed by Antoine Quint.
     7
     8        Updated ~150 FAIL expectations to PASS.
     9
     10        * web-platform-tests/css/css-flexbox/animation/order-interpolation-expected.txt: Updated expectations.
     11        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt: Ditto.
     12        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt: Ditto.
     13        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt: Ditto.
     14
    1152020-10-19  Sergio Villar Senin  <svillar@igalia.com>
    216

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/animation/order-interpolation-expected.txt

    r267650 r268726  
    11
    2 FAIL CSS Transitions: property <order> from neutral to [20] at (-3) should be [-20] assert_equals: expected "- 20 " but got "20 "
    3 FAIL CSS Transitions: property <order> from neutral to [20] at (-0.5) should be [5] assert_equals: expected "5 " but got "20 "
    4 FAIL CSS Transitions: property <order> from neutral to [20] at (0) should be [10] assert_equals: expected "10 " but got "20 "
    5 FAIL CSS Transitions: property <order> from neutral to [20] at (0.3) should be [13] assert_equals: expected "13 " but got "20 "
    6 FAIL CSS Transitions: property <order> from neutral to [20] at (0.6) should be [16] assert_equals: expected "16 " but got "20 "
     2PASS CSS Transitions: property <order> from neutral to [20] at (-3) should be [-20]
     3PASS CSS Transitions: property <order> from neutral to [20] at (-0.5) should be [5]
     4PASS CSS Transitions: property <order> from neutral to [20] at (0) should be [10]
     5PASS CSS Transitions: property <order> from neutral to [20] at (0.3) should be [13]
     6PASS CSS Transitions: property <order> from neutral to [20] at (0.6) should be [16]
    77PASS CSS Transitions: property <order> from neutral to [20] at (1) should be [20]
    8 FAIL CSS Transitions: property <order> from neutral to [20] at (1.5) should be [25] assert_equals: expected "25 " but got "20 "
    9 FAIL CSS Transitions with transition: all: property <order> from neutral to [20] at (-3) should be [-20] assert_equals: expected "- 20 " but got "20 "
    10 FAIL CSS Transitions with transition: all: property <order> from neutral to [20] at (-0.5) should be [5] assert_equals: expected "5 " but got "20 "
    11 FAIL CSS Transitions with transition: all: property <order> from neutral to [20] at (0) should be [10] assert_equals: expected "10 " but got "20 "
    12 FAIL CSS Transitions with transition: all: property <order> from neutral to [20] at (0.3) should be [13] assert_equals: expected "13 " but got "20 "
    13 FAIL CSS Transitions with transition: all: property <order> from neutral to [20] at (0.6) should be [16] assert_equals: expected "16 " but got "20 "
     8PASS CSS Transitions: property <order> from neutral to [20] at (1.5) should be [25]
     9PASS CSS Transitions with transition: all: property <order> from neutral to [20] at (-3) should be [-20]
     10PASS CSS Transitions with transition: all: property <order> from neutral to [20] at (-0.5) should be [5]
     11PASS CSS Transitions with transition: all: property <order> from neutral to [20] at (0) should be [10]
     12PASS CSS Transitions with transition: all: property <order> from neutral to [20] at (0.3) should be [13]
     13PASS CSS Transitions with transition: all: property <order> from neutral to [20] at (0.6) should be [16]
    1414PASS CSS Transitions with transition: all: property <order> from neutral to [20] at (1) should be [20]
    15 FAIL CSS Transitions with transition: all: property <order> from neutral to [20] at (1.5) should be [25] assert_equals: expected "25 " but got "20 "
    16 FAIL CSS Animations: property <order> from neutral to [20] at (-3) should be [-20] assert_equals: expected "- 20 " but got "10 "
    17 FAIL CSS Animations: property <order> from neutral to [20] at (-0.5) should be [5] assert_equals: expected "5 " but got "10 "
     15PASS CSS Transitions with transition: all: property <order> from neutral to [20] at (1.5) should be [25]
     16PASS CSS Animations: property <order> from neutral to [20] at (-3) should be [-20]
     17PASS CSS Animations: property <order> from neutral to [20] at (-0.5) should be [5]
    1818PASS CSS Animations: property <order> from neutral to [20] at (0) should be [10]
    19 FAIL CSS Animations: property <order> from neutral to [20] at (0.3) should be [13] assert_equals: expected "13 " but got "10 "
    20 FAIL CSS Animations: property <order> from neutral to [20] at (0.6) should be [16] assert_equals: expected "16 " but got "10 "
    21 FAIL CSS Animations: property <order> from neutral to [20] at (1) should be [20] assert_equals: expected "20 " but got "10 "
    22 FAIL CSS Animations: property <order> from neutral to [20] at (1.5) should be [25] assert_equals: expected "25 " but got "10 "
    23 FAIL Web Animations: property <order> from neutral to [20] at (-3) should be [-20] assert_equals: expected "- 20 " but got "10 "
    24 FAIL Web Animations: property <order> from neutral to [20] at (-0.5) should be [5] assert_equals: expected "5 " but got "10 "
    25 PASS Web Animations: property <order> from neutral to [20] at (0) should be [10]
    26 FAIL Web Animations: property <order> from neutral to [20] at (0.3) should be [13] assert_equals: expected "13 " but got "10 "
    27 FAIL Web Animations: property <order> from neutral to [20] at (0.6) should be [16] assert_equals: expected "16 " but got "10 "
    28 FAIL Web Animations: property <order> from neutral to [20] at (1) should be [20] assert_equals: expected "20 " but got "10 "
    29 FAIL Web Animations: property <order> from neutral to [20] at (1.5) should be [25] assert_equals: expected "25 " but got "10 "
    30 FAIL CSS Transitions: property <order> from [initial] to [20] at (-3) should be [-60] assert_equals: expected "- 60 " but got "20 "
    31 FAIL CSS Transitions: property <order> from [initial] to [20] at (-0.5) should be [-10] assert_equals: expected "- 10 " but got "20 "
    32 FAIL CSS Transitions: property <order> from [initial] to [20] at (0) should be [0] assert_equals: expected "0 " but got "20 "
    33 FAIL CSS Transitions: property <order> from [initial] to [20] at (0.3) should be [6] assert_equals: expected "6 " but got "20 "
    34 FAIL CSS Transitions: property <order> from [initial] to [20] at (0.6) should be [12] assert_equals: expected "12 " but got "20 "
     19PASS CSS Animations: property <order> from neutral to [20] at (0.3) should be [13]
     20PASS CSS Animations: property <order> from neutral to [20] at (0.6) should be [16]
     21PASS CSS Animations: property <order> from neutral to [20] at (1) should be [20]
     22PASS CSS Animations: property <order> from neutral to [20] at (1.5) should be [25]
     23PASS Web Animations: property <order> from neutral to [20] at (-3) should be [-20]
     24FAIL Web Animations: property <order> from neutral to [20] at (-0.5) should be [5] assert_equals: expected "5 " but got "- 40 "
     25FAIL Web Animations: property <order> from neutral to [20] at (0) should be [10] assert_equals: expected "10 " but got "- 40 "
     26FAIL Web Animations: property <order> from neutral to [20] at (0.3) should be [13] assert_equals: expected "13 " but got "- 22 "
     27FAIL Web Animations: property <order> from neutral to [20] at (0.6) should be [16] assert_equals: expected "16 " but got "3 "
     28PASS Web Animations: property <order> from neutral to [20] at (1) should be [20]
     29FAIL Web Animations: property <order> from neutral to [20] at (1.5) should be [25] assert_equals: expected "25 " but got "20 "
     30PASS CSS Transitions: property <order> from [initial] to [20] at (-3) should be [-60]
     31PASS CSS Transitions: property <order> from [initial] to [20] at (-0.5) should be [-10]
     32PASS CSS Transitions: property <order> from [initial] to [20] at (0) should be [0]
     33PASS CSS Transitions: property <order> from [initial] to [20] at (0.3) should be [6]
     34PASS CSS Transitions: property <order> from [initial] to [20] at (0.6) should be [12]
    3535PASS CSS Transitions: property <order> from [initial] to [20] at (1) should be [20]
    36 FAIL CSS Transitions: property <order> from [initial] to [20] at (1.5) should be [30] assert_equals: expected "30 " but got "20 "
    37 FAIL CSS Transitions with transition: all: property <order> from [initial] to [20] at (-3) should be [-60] assert_equals: expected "- 60 " but got "20 "
    38 FAIL CSS Transitions with transition: all: property <order> from [initial] to [20] at (-0.5) should be [-10] assert_equals: expected "- 10 " but got "20 "
    39 FAIL CSS Transitions with transition: all: property <order> from [initial] to [20] at (0) should be [0] assert_equals: expected "0 " but got "20 "
    40 FAIL CSS Transitions with transition: all: property <order> from [initial] to [20] at (0.3) should be [6] assert_equals: expected "6 " but got "20 "
    41 FAIL CSS Transitions with transition: all: property <order> from [initial] to [20] at (0.6) should be [12] assert_equals: expected "12 " but got "20 "
     36PASS CSS Transitions: property <order> from [initial] to [20] at (1.5) should be [30]
     37PASS CSS Transitions with transition: all: property <order> from [initial] to [20] at (-3) should be [-60]
     38PASS CSS Transitions with transition: all: property <order> from [initial] to [20] at (-0.5) should be [-10]
     39PASS CSS Transitions with transition: all: property <order> from [initial] to [20] at (0) should be [0]
     40PASS CSS Transitions with transition: all: property <order> from [initial] to [20] at (0.3) should be [6]
     41PASS CSS Transitions with transition: all: property <order> from [initial] to [20] at (0.6) should be [12]
    4242PASS CSS Transitions with transition: all: property <order> from [initial] to [20] at (1) should be [20]
    43 FAIL CSS Transitions with transition: all: property <order> from [initial] to [20] at (1.5) should be [30] assert_equals: expected "30 " but got "20 "
    44 FAIL CSS Animations: property <order> from [initial] to [20] at (-3) should be [-60] assert_equals: expected "- 60 " but got "10 "
    45 FAIL CSS Animations: property <order> from [initial] to [20] at (-0.5) should be [-10] assert_equals: expected "- 10 " but got "10 "
    46 FAIL CSS Animations: property <order> from [initial] to [20] at (0) should be [0] assert_equals: expected "0 " but got "10 "
    47 FAIL CSS Animations: property <order> from [initial] to [20] at (0.3) should be [6] assert_equals: expected "6 " but got "10 "
    48 FAIL CSS Animations: property <order> from [initial] to [20] at (0.6) should be [12] assert_equals: expected "12 " but got "10 "
    49 FAIL CSS Animations: property <order> from [initial] to [20] at (1) should be [20] assert_equals: expected "20 " but got "10 "
    50 FAIL CSS Animations: property <order> from [initial] to [20] at (1.5) should be [30] assert_equals: expected "30 " but got "10 "
    51 FAIL Web Animations: property <order> from [initial] to [20] at (-3) should be [-60] assert_equals: expected "- 60 " but got "10 "
    52 FAIL Web Animations: property <order> from [initial] to [20] at (-0.5) should be [-10] assert_equals: expected "- 10 " but got "10 "
    53 FAIL Web Animations: property <order> from [initial] to [20] at (0) should be [0] assert_equals: expected "0 " but got "10 "
    54 FAIL Web Animations: property <order> from [initial] to [20] at (0.3) should be [6] assert_equals: expected "6 " but got "10 "
    55 FAIL Web Animations: property <order> from [initial] to [20] at (0.6) should be [12] assert_equals: expected "12 " but got "10 "
    56 FAIL Web Animations: property <order> from [initial] to [20] at (1) should be [20] assert_equals: expected "20 " but got "10 "
    57 FAIL Web Animations: property <order> from [initial] to [20] at (1.5) should be [30] assert_equals: expected "30 " but got "10 "
    58 FAIL CSS Transitions: property <order> from [inherit] to [20] at (-3) should be [60] assert_equals: expected "60 " but got "20 "
    59 FAIL CSS Transitions: property <order> from [inherit] to [20] at (-0.5) should be [35] assert_equals: expected "35 " but got "20 "
    60 FAIL CSS Transitions: property <order> from [inherit] to [20] at (0) should be [30] assert_equals: expected "30 " but got "20 "
    61 FAIL CSS Transitions: property <order> from [inherit] to [20] at (0.3) should be [27] assert_equals: expected "27 " but got "20 "
    62 FAIL CSS Transitions: property <order> from [inherit] to [20] at (0.6) should be [24] assert_equals: expected "24 " but got "20 "
     43PASS CSS Transitions with transition: all: property <order> from [initial] to [20] at (1.5) should be [30]
     44PASS CSS Animations: property <order> from [initial] to [20] at (-3) should be [-60]
     45PASS CSS Animations: property <order> from [initial] to [20] at (-0.5) should be [-10]
     46PASS CSS Animations: property <order> from [initial] to [20] at (0) should be [0]
     47PASS CSS Animations: property <order> from [initial] to [20] at (0.3) should be [6]
     48PASS CSS Animations: property <order> from [initial] to [20] at (0.6) should be [12]
     49PASS CSS Animations: property <order> from [initial] to [20] at (1) should be [20]
     50PASS CSS Animations: property <order> from [initial] to [20] at (1.5) should be [30]
     51PASS Web Animations: property <order> from [initial] to [20] at (-3) should be [-60]
     52PASS Web Animations: property <order> from [initial] to [20] at (-0.5) should be [-10]
     53PASS Web Animations: property <order> from [initial] to [20] at (0) should be [0]
     54PASS Web Animations: property <order> from [initial] to [20] at (0.3) should be [6]
     55PASS Web Animations: property <order> from [initial] to [20] at (0.6) should be [12]
     56PASS Web Animations: property <order> from [initial] to [20] at (1) should be [20]
     57PASS Web Animations: property <order> from [initial] to [20] at (1.5) should be [30]
     58PASS CSS Transitions: property <order> from [inherit] to [20] at (-3) should be [60]
     59PASS CSS Transitions: property <order> from [inherit] to [20] at (-0.5) should be [35]
     60PASS CSS Transitions: property <order> from [inherit] to [20] at (0) should be [30]
     61PASS CSS Transitions: property <order> from [inherit] to [20] at (0.3) should be [27]
     62PASS CSS Transitions: property <order> from [inherit] to [20] at (0.6) should be [24]
    6363PASS CSS Transitions: property <order> from [inherit] to [20] at (1) should be [20]
    64 FAIL CSS Transitions: property <order> from [inherit] to [20] at (1.5) should be [15] assert_equals: expected "15 " but got "20 "
    65 FAIL CSS Transitions with transition: all: property <order> from [inherit] to [20] at (-3) should be [60] assert_equals: expected "60 " but got "20 "
    66 FAIL CSS Transitions with transition: all: property <order> from [inherit] to [20] at (-0.5) should be [35] assert_equals: expected "35 " but got "20 "
    67 FAIL CSS Transitions with transition: all: property <order> from [inherit] to [20] at (0) should be [30] assert_equals: expected "30 " but got "20 "
    68 FAIL CSS Transitions with transition: all: property <order> from [inherit] to [20] at (0.3) should be [27] assert_equals: expected "27 " but got "20 "
    69 FAIL CSS Transitions with transition: all: property <order> from [inherit] to [20] at (0.6) should be [24] assert_equals: expected "24 " but got "20 "
     64PASS CSS Transitions: property <order> from [inherit] to [20] at (1.5) should be [15]
     65PASS CSS Transitions with transition: all: property <order> from [inherit] to [20] at (-3) should be [60]
     66PASS CSS Transitions with transition: all: property <order> from [inherit] to [20] at (-0.5) should be [35]
     67PASS CSS Transitions with transition: all: property <order> from [inherit] to [20] at (0) should be [30]
     68PASS CSS Transitions with transition: all: property <order> from [inherit] to [20] at (0.3) should be [27]
     69PASS CSS Transitions with transition: all: property <order> from [inherit] to [20] at (0.6) should be [24]
    7070PASS CSS Transitions with transition: all: property <order> from [inherit] to [20] at (1) should be [20]
    71 FAIL CSS Transitions with transition: all: property <order> from [inherit] to [20] at (1.5) should be [15] assert_equals: expected "15 " but got "20 "
    72 FAIL CSS Animations: property <order> from [inherit] to [20] at (-3) should be [60] assert_equals: expected "60 " but got "10 "
    73 FAIL CSS Animations: property <order> from [inherit] to [20] at (-0.5) should be [35] assert_equals: expected "35 " but got "10 "
    74 FAIL CSS Animations: property <order> from [inherit] to [20] at (0) should be [30] assert_equals: expected "30 " but got "10 "
    75 FAIL CSS Animations: property <order> from [inherit] to [20] at (0.3) should be [27] assert_equals: expected "27 " but got "10 "
    76 FAIL CSS Animations: property <order> from [inherit] to [20] at (0.6) should be [24] assert_equals: expected "24 " but got "10 "
    77 FAIL CSS Animations: property <order> from [inherit] to [20] at (1) should be [20] assert_equals: expected "20 " but got "10 "
    78 FAIL CSS Animations: property <order> from [inherit] to [20] at (1.5) should be [15] assert_equals: expected "15 " but got "10 "
    79 FAIL Web Animations: property <order> from [inherit] to [20] at (-3) should be [60] assert_equals: expected "60 " but got "10 "
    80 FAIL Web Animations: property <order> from [inherit] to [20] at (-0.5) should be [35] assert_equals: expected "35 " but got "10 "
    81 FAIL Web Animations: property <order> from [inherit] to [20] at (0) should be [30] assert_equals: expected "30 " but got "10 "
    82 FAIL Web Animations: property <order> from [inherit] to [20] at (0.3) should be [27] assert_equals: expected "27 " but got "10 "
    83 FAIL Web Animations: property <order> from [inherit] to [20] at (0.6) should be [24] assert_equals: expected "24 " but got "10 "
    84 FAIL Web Animations: property <order> from [inherit] to [20] at (1) should be [20] assert_equals: expected "20 " but got "10 "
    85 FAIL Web Animations: property <order> from [inherit] to [20] at (1.5) should be [15] assert_equals: expected "15 " but got "10 "
    86 FAIL CSS Transitions: property <order> from [unset] to [20] at (-3) should be [-60] assert_equals: expected "- 60 " but got "20 "
    87 FAIL CSS Transitions: property <order> from [unset] to [20] at (-0.5) should be [-10] assert_equals: expected "- 10 " but got "20 "
    88 FAIL CSS Transitions: property <order> from [unset] to [20] at (0) should be [0] assert_equals: expected "0 " but got "20 "
    89 FAIL CSS Transitions: property <order> from [unset] to [20] at (0.3) should be [6] assert_equals: expected "6 " but got "20 "
    90 FAIL CSS Transitions: property <order> from [unset] to [20] at (0.6) should be [12] assert_equals: expected "12 " but got "20 "
     71PASS CSS Transitions with transition: all: property <order> from [inherit] to [20] at (1.5) should be [15]
     72PASS CSS Animations: property <order> from [inherit] to [20] at (-3) should be [60]
     73PASS CSS Animations: property <order> from [inherit] to [20] at (-0.5) should be [35]
     74PASS CSS Animations: property <order> from [inherit] to [20] at (0) should be [30]
     75PASS CSS Animations: property <order> from [inherit] to [20] at (0.3) should be [27]
     76PASS CSS Animations: property <order> from [inherit] to [20] at (0.6) should be [24]
     77PASS CSS Animations: property <order> from [inherit] to [20] at (1) should be [20]
     78PASS CSS Animations: property <order> from [inherit] to [20] at (1.5) should be [15]
     79FAIL Web Animations: property <order> from [inherit] to [20] at (-3) should be [60] assert_equals: expected "60 " but got "- 20 "
     80FAIL Web Animations: property <order> from [inherit] to [20] at (-0.5) should be [35] assert_equals: expected "35 " but got "- 40 "
     81FAIL Web Animations: property <order> from [inherit] to [20] at (0) should be [30] assert_equals: expected "30 " but got "- 40 "
     82FAIL Web Animations: property <order> from [inherit] to [20] at (0.3) should be [27] assert_equals: expected "27 " but got "- 22 "
     83FAIL Web Animations: property <order> from [inherit] to [20] at (0.6) should be [24] assert_equals: expected "24 " but got "3 "
     84PASS Web Animations: property <order> from [inherit] to [20] at (1) should be [20]
     85FAIL Web Animations: property <order> from [inherit] to [20] at (1.5) should be [15] assert_equals: expected "15 " but got "20 "
     86PASS CSS Transitions: property <order> from [unset] to [20] at (-3) should be [-60]
     87PASS CSS Transitions: property <order> from [unset] to [20] at (-0.5) should be [-10]
     88PASS CSS Transitions: property <order> from [unset] to [20] at (0) should be [0]
     89PASS CSS Transitions: property <order> from [unset] to [20] at (0.3) should be [6]
     90PASS CSS Transitions: property <order> from [unset] to [20] at (0.6) should be [12]
    9191PASS CSS Transitions: property <order> from [unset] to [20] at (1) should be [20]
    92 FAIL CSS Transitions: property <order> from [unset] to [20] at (1.5) should be [30] assert_equals: expected "30 " but got "20 "
    93 FAIL CSS Transitions with transition: all: property <order> from [unset] to [20] at (-3) should be [-60] assert_equals: expected "- 60 " but got "20 "
    94 FAIL CSS Transitions with transition: all: property <order> from [unset] to [20] at (-0.5) should be [-10] assert_equals: expected "- 10 " but got "20 "
    95 FAIL CSS Transitions with transition: all: property <order> from [unset] to [20] at (0) should be [0] assert_equals: expected "0 " but got "20 "
    96 FAIL CSS Transitions with transition: all: property <order> from [unset] to [20] at (0.3) should be [6] assert_equals: expected "6 " but got "20 "
    97 FAIL CSS Transitions with transition: all: property <order> from [unset] to [20] at (0.6) should be [12] assert_equals: expected "12 " but got "20 "
     92PASS CSS Transitions: property <order> from [unset] to [20] at (1.5) should be [30]
     93PASS CSS Transitions with transition: all: property <order> from [unset] to [20] at (-3) should be [-60]
     94PASS CSS Transitions with transition: all: property <order> from [unset] to [20] at (-0.5) should be [-10]
     95PASS CSS Transitions with transition: all: property <order> from [unset] to [20] at (0) should be [0]
     96PASS CSS Transitions with transition: all: property <order> from [unset] to [20] at (0.3) should be [6]
     97PASS CSS Transitions with transition: all: property <order> from [unset] to [20] at (0.6) should be [12]
    9898PASS CSS Transitions with transition: all: property <order> from [unset] to [20] at (1) should be [20]
    99 FAIL CSS Transitions with transition: all: property <order> from [unset] to [20] at (1.5) should be [30] assert_equals: expected "30 " but got "20 "
    100 FAIL CSS Animations: property <order> from [unset] to [20] at (-3) should be [-60] assert_equals: expected "- 60 " but got "10 "
    101 FAIL CSS Animations: property <order> from [unset] to [20] at (-0.5) should be [-10] assert_equals: expected "- 10 " but got "10 "
    102 FAIL CSS Animations: property <order> from [unset] to [20] at (0) should be [0] assert_equals: expected "0 " but got "10 "
    103 FAIL CSS Animations: property <order> from [unset] to [20] at (0.3) should be [6] assert_equals: expected "6 " but got "10 "
    104 FAIL CSS Animations: property <order> from [unset] to [20] at (0.6) should be [12] assert_equals: expected "12 " but got "10 "
    105 FAIL CSS Animations: property <order> from [unset] to [20] at (1) should be [20] assert_equals: expected "20 " but got "10 "
    106 FAIL CSS Animations: property <order> from [unset] to [20] at (1.5) should be [30] assert_equals: expected "30 " but got "10 "
    107 FAIL Web Animations: property <order> from [unset] to [20] at (-3) should be [-60] assert_equals: expected "- 60 " but got "10 "
    108 FAIL Web Animations: property <order> from [unset] to [20] at (-0.5) should be [-10] assert_equals: expected "- 10 " but got "10 "
    109 FAIL Web Animations: property <order> from [unset] to [20] at (0) should be [0] assert_equals: expected "0 " but got "10 "
    110 FAIL Web Animations: property <order> from [unset] to [20] at (0.3) should be [6] assert_equals: expected "6 " but got "10 "
    111 FAIL Web Animations: property <order> from [unset] to [20] at (0.6) should be [12] assert_equals: expected "12 " but got "10 "
    112 FAIL Web Animations: property <order> from [unset] to [20] at (1) should be [20] assert_equals: expected "20 " but got "10 "
    113 FAIL Web Animations: property <order> from [unset] to [20] at (1.5) should be [30] assert_equals: expected "30 " but got "10 "
    114 FAIL CSS Transitions: property <order> from [10] to [20] at (-3) should be [-20] assert_equals: expected "- 20 " but got "20 "
    115 FAIL CSS Transitions: property <order> from [10] to [20] at (-0.5) should be [5] assert_equals: expected "5 " but got "20 "
    116 FAIL CSS Transitions: property <order> from [10] to [20] at (0) should be [10] assert_equals: expected "10 " but got "20 "
    117 FAIL CSS Transitions: property <order> from [10] to [20] at (0.3) should be [13] assert_equals: expected "13 " but got "20 "
    118 FAIL CSS Transitions: property <order> from [10] to [20] at (0.6) should be [16] assert_equals: expected "16 " but got "20 "
     99PASS CSS Transitions with transition: all: property <order> from [unset] to [20] at (1.5) should be [30]
     100PASS CSS Animations: property <order> from [unset] to [20] at (-3) should be [-60]
     101PASS CSS Animations: property <order> from [unset] to [20] at (-0.5) should be [-10]
     102PASS CSS Animations: property <order> from [unset] to [20] at (0) should be [0]
     103PASS CSS Animations: property <order> from [unset] to [20] at (0.3) should be [6]
     104PASS CSS Animations: property <order> from [unset] to [20] at (0.6) should be [12]
     105PASS CSS Animations: property <order> from [unset] to [20] at (1) should be [20]
     106PASS CSS Animations: property <order> from [unset] to [20] at (1.5) should be [30]
     107PASS Web Animations: property <order> from [unset] to [20] at (-3) should be [-60]
     108PASS Web Animations: property <order> from [unset] to [20] at (-0.5) should be [-10]
     109PASS Web Animations: property <order> from [unset] to [20] at (0) should be [0]
     110PASS Web Animations: property <order> from [unset] to [20] at (0.3) should be [6]
     111PASS Web Animations: property <order> from [unset] to [20] at (0.6) should be [12]
     112PASS Web Animations: property <order> from [unset] to [20] at (1) should be [20]
     113PASS Web Animations: property <order> from [unset] to [20] at (1.5) should be [30]
     114PASS CSS Transitions: property <order> from [10] to [20] at (-3) should be [-20]
     115PASS CSS Transitions: property <order> from [10] to [20] at (-0.5) should be [5]
     116PASS CSS Transitions: property <order> from [10] to [20] at (0) should be [10]
     117PASS CSS Transitions: property <order> from [10] to [20] at (0.3) should be [13]
     118PASS CSS Transitions: property <order> from [10] to [20] at (0.6) should be [16]
    119119PASS CSS Transitions: property <order> from [10] to [20] at (1) should be [20]
    120 FAIL CSS Transitions: property <order> from [10] to [20] at (1.5) should be [25] assert_equals: expected "25 " but got "20 "
    121 FAIL CSS Transitions with transition: all: property <order> from [10] to [20] at (-3) should be [-20] assert_equals: expected "- 20 " but got "20 "
    122 FAIL CSS Transitions with transition: all: property <order> from [10] to [20] at (-0.5) should be [5] assert_equals: expected "5 " but got "20 "
    123 FAIL CSS Transitions with transition: all: property <order> from [10] to [20] at (0) should be [10] assert_equals: expected "10 " but got "20 "
    124 FAIL CSS Transitions with transition: all: property <order> from [10] to [20] at (0.3) should be [13] assert_equals: expected "13 " but got "20 "
    125 FAIL CSS Transitions with transition: all: property <order> from [10] to [20] at (0.6) should be [16] assert_equals: expected "16 " but got "20 "
     120PASS CSS Transitions: property <order> from [10] to [20] at (1.5) should be [25]
     121PASS CSS Transitions with transition: all: property <order> from [10] to [20] at (-3) should be [-20]
     122PASS CSS Transitions with transition: all: property <order> from [10] to [20] at (-0.5) should be [5]
     123PASS CSS Transitions with transition: all: property <order> from [10] to [20] at (0) should be [10]
     124PASS CSS Transitions with transition: all: property <order> from [10] to [20] at (0.3) should be [13]
     125PASS CSS Transitions with transition: all: property <order> from [10] to [20] at (0.6) should be [16]
    126126PASS CSS Transitions with transition: all: property <order> from [10] to [20] at (1) should be [20]
    127 FAIL CSS Transitions with transition: all: property <order> from [10] to [20] at (1.5) should be [25] assert_equals: expected "25 " but got "20 "
    128 FAIL CSS Animations: property <order> from [10] to [20] at (-3) should be [-20] assert_equals: expected "- 20 " but got "10 "
    129 FAIL CSS Animations: property <order> from [10] to [20] at (-0.5) should be [5] assert_equals: expected "5 " but got "10 "
     127PASS CSS Transitions with transition: all: property <order> from [10] to [20] at (1.5) should be [25]
     128PASS CSS Animations: property <order> from [10] to [20] at (-3) should be [-20]
     129PASS CSS Animations: property <order> from [10] to [20] at (-0.5) should be [5]
    130130PASS CSS Animations: property <order> from [10] to [20] at (0) should be [10]
    131 FAIL CSS Animations: property <order> from [10] to [20] at (0.3) should be [13] assert_equals: expected "13 " but got "10 "
    132 FAIL CSS Animations: property <order> from [10] to [20] at (0.6) should be [16] assert_equals: expected "16 " but got "10 "
    133 FAIL CSS Animations: property <order> from [10] to [20] at (1) should be [20] assert_equals: expected "20 " but got "10 "
    134 FAIL CSS Animations: property <order> from [10] to [20] at (1.5) should be [25] assert_equals: expected "25 " but got "10 "
    135 FAIL Web Animations: property <order> from [10] to [20] at (-3) should be [-20] assert_equals: expected "- 20 " but got "10 "
    136 FAIL Web Animations: property <order> from [10] to [20] at (-0.5) should be [5] assert_equals: expected "5 " but got "10 "
     131PASS CSS Animations: property <order> from [10] to [20] at (0.3) should be [13]
     132PASS CSS Animations: property <order> from [10] to [20] at (0.6) should be [16]
     133PASS CSS Animations: property <order> from [10] to [20] at (1) should be [20]
     134PASS CSS Animations: property <order> from [10] to [20] at (1.5) should be [25]
     135PASS Web Animations: property <order> from [10] to [20] at (-3) should be [-20]
     136PASS Web Animations: property <order> from [10] to [20] at (-0.5) should be [5]
    137137PASS Web Animations: property <order> from [10] to [20] at (0) should be [10]
    138 FAIL Web Animations: property <order> from [10] to [20] at (0.3) should be [13] assert_equals: expected "13 " but got "10 "
    139 FAIL Web Animations: property <order> from [10] to [20] at (0.6) should be [16] assert_equals: expected "16 " but got "10 "
    140 FAIL Web Animations: property <order> from [10] to [20] at (1) should be [20] assert_equals: expected "20 " but got "10 "
    141 FAIL Web Animations: property <order> from [10] to [20] at (1.5) should be [25] assert_equals: expected "25 " but got "10 "
    142 FAIL CSS Transitions: property <order> from [2] to [4] at (-3) should be [-4] assert_equals: expected "- 4 " but got "4 "
    143 FAIL CSS Transitions: property <order> from [2] to [4] at (-0.5) should be [1] assert_equals: expected "1 " but got "4 "
    144 FAIL CSS Transitions: property <order> from [2] to [4] at (0) should be [2] assert_equals: expected "2 " but got "4 "
    145 FAIL CSS Transitions: property <order> from [2] to [4] at (0.3) should be [3] assert_equals: expected "3 " but got "4 "
    146 FAIL CSS Transitions: property <order> from [2] to [4] at (0.6) should be [3] assert_equals: expected "3 " but got "4 "
     138PASS Web Animations: property <order> from [10] to [20] at (0.3) should be [13]
     139PASS Web Animations: property <order> from [10] to [20] at (0.6) should be [16]
     140PASS Web Animations: property <order> from [10] to [20] at (1) should be [20]
     141PASS Web Animations: property <order> from [10] to [20] at (1.5) should be [25]
     142PASS CSS Transitions: property <order> from [2] to [4] at (-3) should be [-4]
     143PASS CSS Transitions: property <order> from [2] to [4] at (-0.5) should be [1]
     144PASS CSS Transitions: property <order> from [2] to [4] at (0) should be [2]
     145PASS CSS Transitions: property <order> from [2] to [4] at (0.3) should be [3]
     146PASS CSS Transitions: property <order> from [2] to [4] at (0.6) should be [3]
    147147PASS CSS Transitions: property <order> from [2] to [4] at (1) should be [4]
    148 FAIL CSS Transitions: property <order> from [2] to [4] at (1.5) should be [5] assert_equals: expected "5 " but got "4 "
    149 FAIL CSS Transitions with transition: all: property <order> from [2] to [4] at (-3) should be [-4] assert_equals: expected "- 4 " but got "4 "
    150 FAIL CSS Transitions with transition: all: property <order> from [2] to [4] at (-0.5) should be [1] assert_equals: expected "1 " but got "4 "
    151 FAIL CSS Transitions with transition: all: property <order> from [2] to [4] at (0) should be [2] assert_equals: expected "2 " but got "4 "
    152 FAIL CSS Transitions with transition: all: property <order> from [2] to [4] at (0.3) should be [3] assert_equals: expected "3 " but got "4 "
    153 FAIL CSS Transitions with transition: all: property <order> from [2] to [4] at (0.6) should be [3] assert_equals: expected "3 " but got "4 "
     148PASS CSS Transitions: property <order> from [2] to [4] at (1.5) should be [5]
     149PASS CSS Transitions with transition: all: property <order> from [2] to [4] at (-3) should be [-4]
     150PASS CSS Transitions with transition: all: property <order> from [2] to [4] at (-0.5) should be [1]
     151PASS CSS Transitions with transition: all: property <order> from [2] to [4] at (0) should be [2]
     152PASS CSS Transitions with transition: all: property <order> from [2] to [4] at (0.3) should be [3]
     153PASS CSS Transitions with transition: all: property <order> from [2] to [4] at (0.6) should be [3]
    154154PASS CSS Transitions with transition: all: property <order> from [2] to [4] at (1) should be [4]
    155 FAIL CSS Transitions with transition: all: property <order> from [2] to [4] at (1.5) should be [5] assert_equals: expected "5 " but got "4 "
    156 FAIL CSS Animations: property <order> from [2] to [4] at (-3) should be [-4] assert_equals: expected "- 4 " but got "10 "
    157 FAIL CSS Animations: property <order> from [2] to [4] at (-0.5) should be [1] assert_equals: expected "1 " but got "10 "
    158 FAIL CSS Animations: property <order> from [2] to [4] at (0) should be [2] assert_equals: expected "2 " but got "10 "
    159 FAIL CSS Animations: property <order> from [2] to [4] at (0.3) should be [3] assert_equals: expected "3 " but got "10 "
    160 FAIL CSS Animations: property <order> from [2] to [4] at (0.6) should be [3] assert_equals: expected "3 " but got "10 "
    161 FAIL CSS Animations: property <order> from [2] to [4] at (1) should be [4] assert_equals: expected "4 " but got "10 "
    162 FAIL CSS Animations: property <order> from [2] to [4] at (1.5) should be [5] assert_equals: expected "5 " but got "10 "
    163 FAIL Web Animations: property <order> from [2] to [4] at (-3) should be [-4] assert_equals: expected "- 4 " but got "10 "
    164 FAIL Web Animations: property <order> from [2] to [4] at (-0.5) should be [1] assert_equals: expected "1 " but got "10 "
    165 FAIL Web Animations: property <order> from [2] to [4] at (0) should be [2] assert_equals: expected "2 " but got "10 "
    166 FAIL Web Animations: property <order> from [2] to [4] at (0.3) should be [3] assert_equals: expected "3 " but got "10 "
    167 FAIL Web Animations: property <order> from [2] to [4] at (0.6) should be [3] assert_equals: expected "3 " but got "10 "
    168 FAIL Web Animations: property <order> from [2] to [4] at (1) should be [4] assert_equals: expected "4 " but got "10 "
    169 FAIL Web Animations: property <order> from [2] to [4] at (1.5) should be [5] assert_equals: expected "5 " but got "10 "
     155PASS CSS Transitions with transition: all: property <order> from [2] to [4] at (1.5) should be [5]
     156PASS CSS Animations: property <order> from [2] to [4] at (-3) should be [-4]
     157PASS CSS Animations: property <order> from [2] to [4] at (-0.5) should be [1]
     158PASS CSS Animations: property <order> from [2] to [4] at (0) should be [2]
     159PASS CSS Animations: property <order> from [2] to [4] at (0.3) should be [3]
     160PASS CSS Animations: property <order> from [2] to [4] at (0.6) should be [3]
     161PASS CSS Animations: property <order> from [2] to [4] at (1) should be [4]
     162PASS CSS Animations: property <order> from [2] to [4] at (1.5) should be [5]
     163PASS Web Animations: property <order> from [2] to [4] at (-3) should be [-4]
     164PASS Web Animations: property <order> from [2] to [4] at (-0.5) should be [1]
     165PASS Web Animations: property <order> from [2] to [4] at (0) should be [2]
     166PASS Web Animations: property <order> from [2] to [4] at (0.3) should be [3]
     167PASS Web Animations: property <order> from [2] to [4] at (0.6) should be [3]
     168PASS Web Animations: property <order> from [2] to [4] at (1) should be [4]
     169PASS Web Animations: property <order> from [2] to [4] at (1.5) should be [5]
    170170

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt

    r268173 r268726  
    1414PASS list-style-image: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")"
    1515PASS list-style-image: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")"
     16PASS order (type: integer) has testAccumulation function
     17FAIL order: integer assert_equals: The value should be -3 at 0ms expected "-3" but got "-2"
    1618PASS outline-color (type: color) has testAccumulation function
    1719FAIL outline-color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 128) at 0ms expected "rgb(255, 128, 128)" but got "rgb(255, 0, 0)"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt

    r268173 r268726  
    1414PASS list-style-image: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")"
    1515PASS list-style-image: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")"
     16PASS order (type: integer) has testAddition function
     17FAIL order: integer assert_equals: The value should be -3 at 0ms expected "-3" but got "-2"
    1618PASS outline-color (type: color) has testAddition function
    1719FAIL outline-color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 128) at 0ms expected "rgb(255, 128, 128)" but got "rgb(255, 0, 0)"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt

    r268173 r268726  
    1515FAIL list-style-image uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with effect easing assert_equals: The value should be url("http://localhost/test-1") at 940ms expected "url(\"http://localhost/test-1\")" but got "url(\"http://localhost/test-2\")"
    1616FAIL list-style-image uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with keyframe easing assert_equals: The value should be url("http://localhost/test-1") at 940ms expected "url(\"http://localhost/test-1\")" but got "url(\"http://localhost/test-2\")"
     17PASS order (type: integer) has testInterpolation function
     18PASS order supports animating as an integer
    1719PASS outline-color (type: color) has testInterpolation function
    1820PASS outline-color supports animating as color of rgb()

  • trunk/Source/WebCore/ChangeLog

    r268718 r268726  
     12020-10-20  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        [css-flexbox] order property should be animatable
     4        https://bugs.webkit.org/show_bug.cgi?id=209876
     5
     6        Reviewed by Antoine Quint.
     7
     8        Make order property animatable as per spec. This allows us to pass ~150 flexbox animation subtests.
     9
     10        * animation/CSSPropertyAnimation.cpp:
     11        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Mark property as animatable.
     12
    1132020-10-19  Sergio Villar Senin  <svillar@igalia.com>
    214

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r268718 r268726  
    18731873        new PropertyWrapper<float>(CSSPropertyFlexGrow, &RenderStyle::flexGrow, &RenderStyle::setFlexGrow),
    18741874        new PropertyWrapper<float>(CSSPropertyFlexShrink, &RenderStyle::flexShrink, &RenderStyle::setFlexShrink),
     1875        new PropertyWrapper<int>(CSSPropertyOrder, &RenderStyle::order, &RenderStyle::setOrder),
    18751876    };
    18761877    const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);
Note: See TracChangeset for help on using the changeset viewer.