Changeset 268792 in webkit


Ignore:
Timestamp:
Oct 21, 2020 5:26:45 AM (21 months ago)
Author:
svillar@igalia.com
Message:

[css-flexbox] flex-basis not animatable
​https://bugs.webkit.org/show_bug.cgi?id=180435
LayoutTests/imported/w3c:

<rdar://problem/59363784>

Reviewed by Antoine Quint.

  • web-platform-tests/css/css-flexbox/animation/flex-basis-composition-expected.txt: Replaced FAIL expectations with PASS.
  • web-platform-tests/css/css-flexbox/animation/flex-basis-interpolation-expected.txt: Ditto.
  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt: Ditto.
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt: Ditto.
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt: Ditto.

Source/WebCore:

Reviewed by Antoine Quint.

Make flex-basis property animatable as per spec. This allows us to pass ~100 flexbox animation subtests.

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Mark flex-basis as animatable.

Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r268788 r268792  
     12020-10-20  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        [css-flexbox] flex-basis not animatable
     4        https://bugs.webkit.org/show_bug.cgi?id=180435
     5        <rdar://problem/59363784>
     6
     7        Reviewed by Antoine Quint.
     8
     9        * web-platform-tests/css/css-flexbox/animation/flex-basis-composition-expected.txt: Replaced FAIL expectations with PASS.
     10        * web-platform-tests/css/css-flexbox/animation/flex-basis-interpolation-expected.txt: Ditto.
     11        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt: Ditto.
     12        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt: Ditto.
     13        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt: Ditto.
     14
    1152020-10-21  Antti Koivisto  <antti@apple.com>
    216

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/animation/flex-basis-composition-expected.txt

    r261859 r268792  
    11
    2 FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (-0.3) should be [120px] assert_equals: expected "120px " but got "50px "
    3 FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (0) should be [150px] assert_equals: expected "150px " but got "50px "
    4 FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (0.5) should be [200px] assert_equals: expected "200px " but got "50px "
    5 FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (1) should be [250px] assert_equals: expected "250px " but got "50px "
    6 FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (1.5) should be [300px] assert_equals: expected "300px " but got "50px "
    7 FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (-0.5) should be [114px] assert_equals: expected "114px " but got "100px "
    8 FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (0) should be [110px] assert_equals: expected "110px " but got "100px "
    9 FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (0.5) should be [106px] assert_equals: expected "106px " but got "100px "
    10 FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (1) should be [102px] assert_equals: expected "102px " but got "100px "
    11 FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (1.5) should be [98px] assert_equals: expected "98px " but got "100px "
    12 FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (-0.3) should be [calc(130px + 4%)] assert_equals: expected "calc ( 4 % + 130px ) " but got "10 % "
    13 FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (0) should be [calc(100px + 10%)] assert_equals: expected "calc ( 10 % + 100px ) " but got "10 % "
    14 FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (0.5) should be [calc(50px + 20%)] assert_equals: expected "calc ( 20 % + 50px ) " but got "10 % "
    15 FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (1) should be [30%] assert_equals: expected "30 % " but got "10 % "
    16 FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (1.5) should be [calc(-50px + 40%)] assert_equals: expected "calc ( 40 % - 50px ) " but got "10 % "
    17 FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (-0.3) should be [135px] assert_equals: expected "135px " but got "50px "
    18 FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (0) should be [150px] assert_equals: expected "150px " but got "50px "
    19 FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (0.5) should be [175px] assert_equals: expected "175px " but got "50px "
    20 FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (1) should be [200px] assert_equals: expected "200px " but got "50px "
    21 FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (1.5) should be [225px] assert_equals: expected "225px " but got "50px "
     2FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (-0.3) should be [120px] assert_equals: expected "120px " but got "70px "
     3FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (0) should be [150px] assert_equals: expected "150px " but got "100px "
     4FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (0.5) should be [200px] assert_equals: expected "200px " but got "150px "
     5FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (1) should be [250px] assert_equals: expected "250px " but got "200px "
     6FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (1.5) should be [300px] assert_equals: expected "300px " but got "250px "
     7FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (-0.5) should be [114px] assert_equals: expected "114px " but got "14px "
     8FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (0) should be [110px] assert_equals: expected "110px " but got "10px "
     9FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (0.5) should be [106px] assert_equals: expected "106px " but got "6px "
     10FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (1) should be [102px] assert_equals: expected "102px " but got "2px "
     11FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (1.5) should be [98px] assert_equals: expected "98px " but got "- 2px "
     12FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (-0.3) should be [calc(130px + 4%)] assert_equals: expected "calc ( 4 % + 130px ) " but got "100px "
     13FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (0) should be [calc(100px + 10%)] assert_equals: expected "calc ( 10 % + 100px ) " but got "100px "
     14FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (0.5) should be [calc(50px + 20%)] assert_equals: expected "calc ( 20 % + 50px ) " but got "calc ( ( 100px * 0.5 ) + ( 20 % * 0.5 ) ) "
     15FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (1) should be [30%] assert_equals: expected "30 % " but got "20 % "
     16FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (1.5) should be [calc(-50px + 40%)] assert_equals: expected "calc ( 40 % - 50px ) " but got "20 % "
     17FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (-0.3) should be [135px] assert_equals: expected "135px " but got "70px "
     18FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (0) should be [150px] assert_equals: expected "150px " but got "100px "
     19FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (0.5) should be [175px] assert_equals: expected "175px " but got "150px "
     20PASS Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (1) should be [200px]
     21FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (1.5) should be [225px] assert_equals: expected "225px " but got "250px "
    2222FAIL Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (-0.3) should be [200px] assert_equals: expected "200px " but got "100px "
    2323FAIL Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (0) should be [200px] assert_equals: expected "200px " but got "100px "
    24 FAIL Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (0.5) should be [auto] assert_equals: expected "auto " but got "100px "
    25 FAIL Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (1) should be [auto] assert_equals: expected "auto " but got "100px "
    26 FAIL Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (1.5) should be [auto] assert_equals: expected "auto " but got "100px "
     24PASS Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (0.5) should be [auto]
     25PASS Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (1) should be [auto]
     26PASS Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (1.5) should be [auto]
    2727

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/animation/flex-basis-interpolation-expected.txt

    r267650 r268792  
    11
    2 FAIL CSS Transitions: property <flex-basis> from neutral to [2%] at (-0.3) should be [0.7%] assert_equals: expected "0.7 % " but got "2 % "
    3 FAIL CSS Transitions: property <flex-basis> from neutral to [2%] at (0) should be [1%] assert_equals: expected "1 % " but got "2 % "
    4 FAIL CSS Transitions: property <flex-basis> from neutral to [2%] at (0.3) should be [1.3%] assert_equals: expected "1.3 % " but got "2 % "
    5 FAIL CSS Transitions: property <flex-basis> from neutral to [2%] at (0.6) should be [1.6%] assert_equals: expected "1.6 % " but got "2 % "
     2PASS CSS Transitions: property <flex-basis> from neutral to [2%] at (-0.3) should be [0.7%]
     3PASS CSS Transitions: property <flex-basis> from neutral to [2%] at (0) should be [1%]
     4PASS CSS Transitions: property <flex-basis> from neutral to [2%] at (0.3) should be [1.3%]
     5PASS CSS Transitions: property <flex-basis> from neutral to [2%] at (0.6) should be [1.6%]
    66PASS CSS Transitions: property <flex-basis> from neutral to [2%] at (1) should be [2%]
    7 FAIL CSS Transitions: property <flex-basis> from neutral to [2%] at (1.5) should be [2.5%] assert_equals: expected "2.5 % " but got "2 % "
     7PASS CSS Transitions: property <flex-basis> from neutral to [2%] at (1.5) should be [2.5%]
    88PASS CSS Transitions with transition: all: property <flex-basis> from neutral to [2%] at (-0.3) should be [0.7%]
    99PASS CSS Transitions with transition: all: property <flex-basis> from neutral to [2%] at (0) should be [1%]
    … …  
    1212PASS CSS Transitions with transition: all: property <flex-basis> from neutral to [2%] at (1) should be [2%]
    1313PASS CSS Transitions with transition: all: property <flex-basis> from neutral to [2%] at (1.5) should be [2.5%]
    14 FAIL CSS Animations: property <flex-basis> from neutral to [2%] at (-0.3) should be [0.7%] assert_equals: expected "0.7 % " but got "1 % "
     14PASS CSS Animations: property <flex-basis> from neutral to [2%] at (-0.3) should be [0.7%]
    1515PASS CSS Animations: property <flex-basis> from neutral to [2%] at (0) should be [1%]
    16 FAIL CSS Animations: property <flex-basis> from neutral to [2%] at (0.3) should be [1.3%] assert_equals: expected "1.3 % " but got "1 % "
    17 FAIL CSS Animations: property <flex-basis> from neutral to [2%] at (0.6) should be [1.6%] assert_equals: expected "1.6 % " but got "1 % "
    18 FAIL CSS Animations: property <flex-basis> from neutral to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
    19 FAIL CSS Animations: property <flex-basis> from neutral to [2%] at (1.5) should be [2.5%] assert_equals: expected "2.5 % " but got "1 % "
    20 FAIL Web Animations: property <flex-basis> from neutral to [2%] at (-0.3) should be [0.7%] assert_equals: expected "0.7 % " but got "1 % "
    21 PASS Web Animations: property <flex-basis> from neutral to [2%] at (0) should be [1%]
    22 FAIL Web Animations: property <flex-basis> from neutral to [2%] at (0.3) should be [1.3%] assert_equals: expected "1.3 % " but got "1 % "
    23 FAIL Web Animations: property <flex-basis> from neutral to [2%] at (0.6) should be [1.6%] assert_equals: expected "1.6 % " but got "1 % "
    24 FAIL Web Animations: property <flex-basis> from neutral to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
    25 FAIL Web Animations: property <flex-basis> from neutral to [2%] at (1.5) should be [2.5%] assert_equals: expected "2.5 % " but got "1 % "
     16PASS CSS Animations: property <flex-basis> from neutral to [2%] at (0.3) should be [1.3%]
     17PASS CSS Animations: property <flex-basis> from neutral to [2%] at (0.6) should be [1.6%]
     18PASS CSS Animations: property <flex-basis> from neutral to [2%] at (1) should be [2%]
     19PASS CSS Animations: property <flex-basis> from neutral to [2%] at (1.5) should be [2.5%]
     20PASS Web Animations: property <flex-basis> from neutral to [2%] at (-0.3) should be [0.7%]
     21FAIL Web Animations: property <flex-basis> from neutral to [2%] at (0) should be [1%] assert_equals: expected "1 % " but got "0.7 % "
     22FAIL Web Animations: property <flex-basis> from neutral to [2%] at (0.3) should be [1.3%] assert_equals: expected "1.3 % " but got "1.09 % "
     23FAIL Web Animations: property <flex-basis> from neutral to [2%] at (0.6) should be [1.6%] assert_equals: expected "1.6 % " but got "1.64 % "
     24PASS Web Animations: property <flex-basis> from neutral to [2%] at (1) should be [2%]
     25FAIL Web Animations: property <flex-basis> from neutral to [2%] at (1.5) should be [2.5%] assert_equals: expected "2.5 % " but got "2 % "
    2626PASS CSS Transitions: property <flex-basis> from [initial] to [2%] at (-0.3) should be [2%]
    2727PASS CSS Transitions: property <flex-basis> from [initial] to [2%] at (0) should be [2%]
    … …  
    3838PASS CSS Transitions with transition: all: property <flex-basis> from [initial] to [2%] at (1) should be [2%]
    3939PASS CSS Transitions with transition: all: property <flex-basis> from [initial] to [2%] at (1.5) should be [2%]
    40 FAIL CSS Animations: property <flex-basis> from [initial] to [2%] at (-0.3) should be [initial] assert_equals: expected "auto " but got "1 % "
    41 FAIL CSS Animations: property <flex-basis> from [initial] to [2%] at (0) should be [initial] assert_equals: expected "auto " but got "1 % "
    42 FAIL CSS Animations: property <flex-basis> from [initial] to [2%] at (0.3) should be [initial] assert_equals: expected "auto " but got "1 % "
    43 FAIL CSS Animations: property <flex-basis> from [initial] to [2%] at (0.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
    44 FAIL CSS Animations: property <flex-basis> from [initial] to [2%] at (0.6) should be [2%] assert_equals: expected "2 % " but got "1 % "
    45 FAIL CSS Animations: property <flex-basis> from [initial] to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
    46 FAIL CSS Animations: property <flex-basis> from [initial] to [2%] at (1.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
    47 FAIL Web Animations: property <flex-basis> from [initial] to [2%] at (-0.3) should be [initial] assert_equals: expected "auto " but got "1 % "
    48 FAIL Web Animations: property <flex-basis> from [initial] to [2%] at (0) should be [initial] assert_equals: expected "auto " but got "1 % "
    49 FAIL Web Animations: property <flex-basis> from [initial] to [2%] at (0.3) should be [initial] assert_equals: expected "auto " but got "1 % "
    50 FAIL Web Animations: property <flex-basis> from [initial] to [2%] at (0.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
    51 FAIL Web Animations: property <flex-basis> from [initial] to [2%] at (0.6) should be [2%] assert_equals: expected "2 % " but got "1 % "
    52 FAIL Web Animations: property <flex-basis> from [initial] to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
    53 FAIL Web Animations: property <flex-basis> from [initial] to [2%] at (1.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
    54 FAIL CSS Transitions: property <flex-basis> from [inherit] to [2%] at (-0.3) should be [3.3%] assert_equals: expected "3.3 % " but got "2 % "
    55 FAIL CSS Transitions: property <flex-basis> from [inherit] to [2%] at (0) should be [3%] assert_equals: expected "3 % " but got "2 % "
    56 FAIL CSS Transitions: property <flex-basis> from [inherit] to [2%] at (0.3) should be [2.7%] assert_equals: expected "2.7 % " but got "2 % "
    57 FAIL CSS Transitions: property <flex-basis> from [inherit] to [2%] at (0.6) should be [2.4%] assert_equals: expected "2.4 % " but got "2 % "
     40PASS CSS Animations: property <flex-basis> from [initial] to [2%] at (-0.3) should be [initial]
     41PASS CSS Animations: property <flex-basis> from [initial] to [2%] at (0) should be [initial]
     42PASS CSS Animations: property <flex-basis> from [initial] to [2%] at (0.3) should be [initial]
     43PASS CSS Animations: property <flex-basis> from [initial] to [2%] at (0.5) should be [2%]
     44PASS CSS Animations: property <flex-basis> from [initial] to [2%] at (0.6) should be [2%]
     45PASS CSS Animations: property <flex-basis> from [initial] to [2%] at (1) should be [2%]
     46PASS CSS Animations: property <flex-basis> from [initial] to [2%] at (1.5) should be [2%]
     47PASS Web Animations: property <flex-basis> from [initial] to [2%] at (-0.3) should be [initial]
     48PASS Web Animations: property <flex-basis> from [initial] to [2%] at (0) should be [initial]
     49PASS Web Animations: property <flex-basis> from [initial] to [2%] at (0.3) should be [initial]
     50PASS Web Animations: property <flex-basis> from [initial] to [2%] at (0.5) should be [2%]
     51PASS Web Animations: property <flex-basis> from [initial] to [2%] at (0.6) should be [2%]
     52PASS Web Animations: property <flex-basis> from [initial] to [2%] at (1) should be [2%]
     53PASS Web Animations: property <flex-basis> from [initial] to [2%] at (1.5) should be [2%]
     54PASS CSS Transitions: property <flex-basis> from [inherit] to [2%] at (-0.3) should be [3.3%]
     55PASS CSS Transitions: property <flex-basis> from [inherit] to [2%] at (0) should be [3%]
     56PASS CSS Transitions: property <flex-basis> from [inherit] to [2%] at (0.3) should be [2.7%]
     57PASS CSS Transitions: property <flex-basis> from [inherit] to [2%] at (0.6) should be [2.4%]
    5858PASS CSS Transitions: property <flex-basis> from [inherit] to [2%] at (1) should be [2%]
    59 FAIL CSS Transitions: property <flex-basis> from [inherit] to [2%] at (1.5) should be [1.5%] assert_equals: expected "1.5 % " but got "2 % "
     59PASS CSS Transitions: property <flex-basis> from [inherit] to [2%] at (1.5) should be [1.5%]
    6060PASS CSS Transitions with transition: all: property <flex-basis> from [inherit] to [2%] at (-0.3) should be [3.3%]
    6161PASS CSS Transitions with transition: all: property <flex-basis> from [inherit] to [2%] at (0) should be [3%]
    … …  
    6464PASS CSS Transitions with transition: all: property <flex-basis> from [inherit] to [2%] at (1) should be [2%]
    6565PASS CSS Transitions with transition: all: property <flex-basis> from [inherit] to [2%] at (1.5) should be [1.5%]
    66 FAIL CSS Animations: property <flex-basis> from [inherit] to [2%] at (-0.3) should be [3.3%] assert_equals: expected "3.3 % " but got "1 % "
    67 FAIL CSS Animations: property <flex-basis> from [inherit] to [2%] at (0) should be [3%] assert_equals: expected "3 % " but got "1 % "
    68 FAIL CSS Animations: property <flex-basis> from [inherit] to [2%] at (0.3) should be [2.7%] assert_equals: expected "2.7 % " but got "1 % "
    69 FAIL CSS Animations: property <flex-basis> from [inherit] to [2%] at (0.6) should be [2.4%] assert_equals: expected "2.4 % " but got "1 % "
    70 FAIL CSS Animations: property <flex-basis> from [inherit] to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
    71 FAIL CSS Animations: property <flex-basis> from [inherit] to [2%] at (1.5) should be [1.5%] assert_equals: expected "1.5 % " but got "1 % "
    72 FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (-0.3) should be [3.3%] assert_equals: expected "3.3 % " but got "1 % "
    73 FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (0) should be [3%] assert_equals: expected "3 % " but got "1 % "
    74 FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (0.3) should be [2.7%] assert_equals: expected "2.7 % " but got "1 % "
    75 FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (0.6) should be [2.4%] assert_equals: expected "2.4 % " but got "1 % "
    76 FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
    77 FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (1.5) should be [1.5%] assert_equals: expected "1.5 % " but got "1 % "
     66PASS CSS Animations: property <flex-basis> from [inherit] to [2%] at (-0.3) should be [3.3%]
     67PASS CSS Animations: property <flex-basis> from [inherit] to [2%] at (0) should be [3%]
     68PASS CSS Animations: property <flex-basis> from [inherit] to [2%] at (0.3) should be [2.7%]
     69PASS CSS Animations: property <flex-basis> from [inherit] to [2%] at (0.6) should be [2.4%]
     70PASS CSS Animations: property <flex-basis> from [inherit] to [2%] at (1) should be [2%]
     71PASS CSS Animations: property <flex-basis> from [inherit] to [2%] at (1.5) should be [1.5%]
     72FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (-0.3) should be [3.3%] assert_equals: expected "3.3 % " but got "0.7 % "
     73FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (0) should be [3%] assert_equals: expected "3 % " but got "0.7 % "
     74FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (0.3) should be [2.7%] assert_equals: expected "2.7 % " but got "1.09 % "
     75FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (0.6) should be [2.4%] assert_equals: expected "2.4 % " but got "1.64 % "
     76PASS Web Animations: property <flex-basis> from [inherit] to [2%] at (1) should be [2%]
     77FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (1.5) should be [1.5%] assert_equals: expected "1.5 % " but got "2 % "
    7878PASS CSS Transitions: property <flex-basis> from [unset] to [2%] at (-0.3) should be [2%]
    7979PASS CSS Transitions: property <flex-basis> from [unset] to [2%] at (0) should be [2%]
    … …  
    9090PASS CSS Transitions with transition: all: property <flex-basis> from [unset] to [2%] at (1) should be [2%]
    9191PASS CSS Transitions with transition: all: property <flex-basis> from [unset] to [2%] at (1.5) should be [2%]
    92 FAIL CSS Animations: property <flex-basis> from [unset] to [2%] at (-0.3) should be [unset] assert_equals: expected "auto " but got "1 % "
    93 FAIL CSS Animations: property <flex-basis> from [unset] to [2%] at (0) should be [unset] assert_equals: expected "auto " but got "1 % "
    94 FAIL CSS Animations: property <flex-basis> from [unset] to [2%] at (0.3) should be [unset] assert_equals: expected "auto " but got "1 % "
    95 FAIL CSS Animations: property <flex-basis> from [unset] to [2%] at (0.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
    96 FAIL CSS Animations: property <flex-basis> from [unset] to [2%] at (0.6) should be [2%] assert_equals: expected "2 % " but got "1 % "
    97 FAIL CSS Animations: property <flex-basis> from [unset] to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
    98 FAIL CSS Animations: property <flex-basis> from [unset] to [2%] at (1.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
    99 FAIL Web Animations: property <flex-basis> from [unset] to [2%] at (-0.3) should be [unset] assert_equals: expected "auto " but got "1 % "
    100 FAIL Web Animations: property <flex-basis> from [unset] to [2%] at (0) should be [unset] assert_equals: expected "auto " but got "1 % "
    101 FAIL Web Animations: property <flex-basis> from [unset] to [2%] at (0.3) should be [unset] assert_equals: expected "auto " but got "1 % "
    102 FAIL Web Animations: property <flex-basis> from [unset] to [2%] at (0.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
    103 FAIL Web Animations: property <flex-basis> from [unset] to [2%] at (0.6) should be [2%] assert_equals: expected "2 % " but got "1 % "
    104 FAIL Web Animations: property <flex-basis> from [unset] to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
    105 FAIL Web Animations: property <flex-basis> from [unset] to [2%] at (1.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
    106 FAIL CSS Transitions: property <flex-basis> from [0px] to [100px] at (-0.3) should be [0px] assert_equals: expected "0px " but got "100px "
    107 FAIL CSS Transitions: property <flex-basis> from [0px] to [100px] at (0) should be [0px] assert_equals: expected "0px " but got "100px "
    108 FAIL CSS Transitions: property <flex-basis> from [0px] to [100px] at (0.4) should be [40px] assert_equals: expected "40px " but got "100px "
    109 FAIL CSS Transitions: property <flex-basis> from [0px] to [100px] at (0.6) should be [60px] assert_equals: expected "60px " but got "100px "
     92PASS CSS Animations: property <flex-basis> from [unset] to [2%] at (-0.3) should be [unset]
     93PASS CSS Animations: property <flex-basis> from [unset] to [2%] at (0) should be [unset]
     94PASS CSS Animations: property <flex-basis> from [unset] to [2%] at (0.3) should be [unset]
     95PASS CSS Animations: property <flex-basis> from [unset] to [2%] at (0.5) should be [2%]
     96PASS CSS Animations: property <flex-basis> from [unset] to [2%] at (0.6) should be [2%]
     97PASS CSS Animations: property <flex-basis> from [unset] to [2%] at (1) should be [2%]
     98PASS CSS Animations: property <flex-basis> from [unset] to [2%] at (1.5) should be [2%]
     99PASS Web Animations: property <flex-basis> from [unset] to [2%] at (-0.3) should be [unset]
     100PASS Web Animations: property <flex-basis> from [unset] to [2%] at (0) should be [unset]
     101PASS Web Animations: property <flex-basis> from [unset] to [2%] at (0.3) should be [unset]
     102PASS Web Animations: property <flex-basis> from [unset] to [2%] at (0.5) should be [2%]
     103PASS Web Animations: property <flex-basis> from [unset] to [2%] at (0.6) should be [2%]
     104PASS Web Animations: property <flex-basis> from [unset] to [2%] at (1) should be [2%]
     105PASS Web Animations: property <flex-basis> from [unset] to [2%] at (1.5) should be [2%]
     106FAIL CSS Transitions: property <flex-basis> from [0px] to [100px] at (-0.3) should be [0px] assert_equals: expected "0px " but got "- 30px "
     107PASS CSS Transitions: property <flex-basis> from [0px] to [100px] at (0) should be [0px]
     108PASS CSS Transitions: property <flex-basis> from [0px] to [100px] at (0.4) should be [40px]
     109PASS CSS Transitions: property <flex-basis> from [0px] to [100px] at (0.6) should be [60px]
    110110PASS CSS Transitions: property <flex-basis> from [0px] to [100px] at (1) should be [100px]
    111 FAIL CSS Transitions: property <flex-basis> from [0px] to [100px] at (1.5) should be [150px] assert_equals: expected "150px " but got "100px "
     111PASS CSS Transitions: property <flex-basis> from [0px] to [100px] at (1.5) should be [150px]
    112112FAIL CSS Transitions with transition: all: property <flex-basis> from [0px] to [100px] at (-0.3) should be [0px] assert_equals: expected "0px " but got "- 30px "
    113113PASS CSS Transitions with transition: all: property <flex-basis> from [0px] to [100px] at (0) should be [0px]
    … …  
    116116PASS CSS Transitions with transition: all: property <flex-basis> from [0px] to [100px] at (1) should be [100px]
    117117PASS CSS Transitions with transition: all: property <flex-basis> from [0px] to [100px] at (1.5) should be [150px]
    118 FAIL CSS Animations: property <flex-basis> from [0px] to [100px] at (-0.3) should be [0px] assert_equals: expected "0px " but got "1 % "
    119 FAIL CSS Animations: property <flex-basis> from [0px] to [100px] at (0) should be [0px] assert_equals: expected "0px " but got "1 % "
    120 FAIL CSS Animations: property <flex-basis> from [0px] to [100px] at (0.4) should be [40px] assert_equals: expected "40px " but got "1 % "
    121 FAIL CSS Animations: property <flex-basis> from [0px] to [100px] at (0.6) should be [60px] assert_equals: expected "60px " but got "1 % "
    122 FAIL CSS Animations: property <flex-basis> from [0px] to [100px] at (1) should be [100px] assert_equals: expected "100px " but got "1 % "
    123 FAIL CSS Animations: property <flex-basis> from [0px] to [100px] at (1.5) should be [150px] assert_equals: expected "150px " but got "1 % "
    124 FAIL Web Animations: property <flex-basis> from [0px] to [100px] at (-0.3) should be [0px] assert_equals: expected "0px " but got "1 % "
    125 FAIL Web Animations: property <flex-basis> from [0px] to [100px] at (0) should be [0px] assert_equals: expected "0px " but got "1 % "
    126 FAIL Web Animations: property <flex-basis> from [0px] to [100px] at (0.4) should be [40px] assert_equals: expected "40px " but got "1 % "
    127 FAIL Web Animations: property <flex-basis> from [0px] to [100px] at (0.6) should be [60px] assert_equals: expected "60px " but got "1 % "
    128 FAIL Web Animations: property <flex-basis> from [0px] to [100px] at (1) should be [100px] assert_equals: expected "100px " but got "1 % "
    129 FAIL Web Animations: property <flex-basis> from [0px] to [100px] at (1.5) should be [150px] assert_equals: expected "150px " but got "1 % "
    130 FAIL CSS Transitions: property <flex-basis> from [0%] to [100%] at (-0.3) should be [0%] assert_equals: expected "0 % " but got "100 % "
    131 FAIL CSS Transitions: property <flex-basis> from [0%] to [100%] at (0) should be [0%] assert_equals: expected "0 % " but got "100 % "
    132 FAIL CSS Transitions: property <flex-basis> from [0%] to [100%] at (0.4) should be [40%] assert_equals: expected "40 % " but got "100 % "
    133 FAIL CSS Transitions: property <flex-basis> from [0%] to [100%] at (0.6) should be [60%] assert_equals: expected "60 % " but got "100 % "
     118FAIL CSS Animations: property <flex-basis> from [0px] to [100px] at (-0.3) should be [0px] assert_equals: expected "0px " but got "- 30px "
     119PASS CSS Animations: property <flex-basis> from [0px] to [100px] at (0) should be [0px]
     120PASS CSS Animations: property <flex-basis> from [0px] to [100px] at (0.4) should be [40px]
     121PASS CSS Animations: property <flex-basis> from [0px] to [100px] at (0.6) should be [60px]
     122PASS CSS Animations: property <flex-basis> from [0px] to [100px] at (1) should be [100px]
     123PASS CSS Animations: property <flex-basis> from [0px] to [100px] at (1.5) should be [150px]
     124FAIL Web Animations: property <flex-basis> from [0px] to [100px] at (-0.3) should be [0px] assert_equals: expected "0px " but got "- 30px "
     125PASS Web Animations: property <flex-basis> from [0px] to [100px] at (0) should be [0px]
     126PASS Web Animations: property <flex-basis> from [0px] to [100px] at (0.4) should be [40px]
     127PASS Web Animations: property <flex-basis> from [0px] to [100px] at (0.6) should be [60px]
     128PASS Web Animations: property <flex-basis> from [0px] to [100px] at (1) should be [100px]
     129PASS Web Animations: property <flex-basis> from [0px] to [100px] at (1.5) should be [150px]
     130FAIL CSS Transitions: property <flex-basis> from [0%] to [100%] at (-0.3) should be [0%] assert_equals: expected "0 % " but got "- 30 % "
     131PASS CSS Transitions: property <flex-basis> from [0%] to [100%] at (0) should be [0%]
     132PASS CSS Transitions: property <flex-basis> from [0%] to [100%] at (0.4) should be [40%]
     133PASS CSS Transitions: property <flex-basis> from [0%] to [100%] at (0.6) should be [60%]
    134134PASS CSS Transitions: property <flex-basis> from [0%] to [100%] at (1) should be [100%]
    135 FAIL CSS Transitions: property <flex-basis> from [0%] to [100%] at (1.5) should be [150%] assert_equals: expected "150 % " but got "100 % "
     135PASS CSS Transitions: property <flex-basis> from [0%] to [100%] at (1.5) should be [150%]
    136136FAIL CSS Transitions with transition: all: property <flex-basis> from [0%] to [100%] at (-0.3) should be [0%] assert_equals: expected "0 % " but got "- 30 % "
    137137PASS CSS Transitions with transition: all: property <flex-basis> from [0%] to [100%] at (0) should be [0%]
    … …  
    140140PASS CSS Transitions with transition: all: property <flex-basis> from [0%] to [100%] at (1) should be [100%]
    141141PASS CSS Transitions with transition: all: property <flex-basis> from [0%] to [100%] at (1.5) should be [150%]
    142 FAIL CSS Animations: property <flex-basis> from [0%] to [100%] at (-0.3) should be [0%] assert_equals: expected "0 % " but got "1 % "
    143 FAIL CSS Animations: property <flex-basis> from [0%] to [100%] at (0) should be [0%] assert_equals: expected "0 % " but got "1 % "
    144 FAIL CSS Animations: property <flex-basis> from [0%] to [100%] at (0.4) should be [40%] assert_equals: expected "40 % " but got "1 % "
    145 FAIL CSS Animations: property <flex-basis> from [0%] to [100%] at (0.6) should be [60%] assert_equals: expected "60 % " but got "1 % "
    146 FAIL CSS Animations: property <flex-basis> from [0%] to [100%] at (1) should be [100%] assert_equals: expected "100 % " but got "1 % "
    147 FAIL CSS Animations: property <flex-basis> from [0%] to [100%] at (1.5) should be [150%] assert_equals: expected "150 % " but got "1 % "
    148 FAIL Web Animations: property <flex-basis> from [0%] to [100%] at (-0.3) should be [0%] assert_equals: expected "0 % " but got "1 % "
    149 FAIL Web Animations: property <flex-basis> from [0%] to [100%] at (0) should be [0%] assert_equals: expected "0 % " but got "1 % "
    150 FAIL Web Animations: property <flex-basis> from [0%] to [100%] at (0.4) should be [40%] assert_equals: expected "40 % " but got "1 % "
    151 FAIL Web Animations: property <flex-basis> from [0%] to [100%] at (0.6) should be [60%] assert_equals: expected "60 % " but got "1 % "
    152 FAIL Web Animations: property <flex-basis> from [0%] to [100%] at (1) should be [100%] assert_equals: expected "100 % " but got "1 % "
    153 FAIL Web Animations: property <flex-basis> from [0%] to [100%] at (1.5) should be [150%] assert_equals: expected "150 % " but got "1 % "
     142FAIL CSS Animations: property <flex-basis> from [0%] to [100%] at (-0.3) should be [0%] assert_equals: expected "0 % " but got "- 30 % "
     143PASS CSS Animations: property <flex-basis> from [0%] to [100%] at (0) should be [0%]
     144PASS CSS Animations: property <flex-basis> from [0%] to [100%] at (0.4) should be [40%]
     145PASS CSS Animations: property <flex-basis> from [0%] to [100%] at (0.6) should be [60%]
     146PASS CSS Animations: property <flex-basis> from [0%] to [100%] at (1) should be [100%]
     147PASS CSS Animations: property <flex-basis> from [0%] to [100%] at (1.5) should be [150%]
     148FAIL Web Animations: property <flex-basis> from [0%] to [100%] at (-0.3) should be [0%] assert_equals: expected "0 % " but got "- 30 % "
     149PASS Web Animations: property <flex-basis> from [0%] to [100%] at (0) should be [0%]
     150PASS Web Animations: property <flex-basis> from [0%] to [100%] at (0.4) should be [40%]
     151PASS Web Animations: property <flex-basis> from [0%] to [100%] at (0.6) should be [60%]
     152PASS Web Animations: property <flex-basis> from [0%] to [100%] at (1) should be [100%]
     153PASS Web Animations: property <flex-basis> from [0%] to [100%] at (1.5) should be [150%]
    154154

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt

    r268718 r268792  
    113113FAIL filter: same ordered filter functions assert_equals: The value should be blur(30px) brightness(0) at 0ms expected "blur(30px) brightness(0)" but got "blur(20px) brightness(0.1)"
    114114PASS filter: mismatched ordered filter functions
     115PASS flex-basis (type: lengthPercentageOrCalc) has testAccumulation function
     116FAIL flex-basis: length assert_equals: The value should be 20px at 0ms expected "20px" but got "10px"
     117FAIL flex-basis: length of rem assert_equals: The value should be 20px at 0ms expected "20px" but got "10px"
     118FAIL flex-basis: percentage assert_equals: The value should be 130% at 0ms expected "130%" but got "70%"
     119FAIL flex-basis: units "%" onto "px" assert_equals: The value should be calc(10% + 10px) at 0ms expected "calc(10% + 10px)" but got "10%"
     120FAIL flex-basis: units "px" onto "%" assert_equals: The value should be calc(10% + 10px) at 0ms expected "calc(10% + 10px)" but got "10px"
     121FAIL flex-basis: units "rem" onto "%" assert_equals: The value should be calc(10% + 20px) at 0ms expected "calc(10% + 20px)" but got "20px"
     122FAIL flex-basis: units "%" onto "rem" assert_equals: The value should be calc(10% + 20px) at 0ms expected "calc(10% + 20px)" but got "10%"
     123FAIL flex-basis: units "rem" onto "em" assert_equals: The value should be 40px at 0ms expected "40px" but got "20px"
     124FAIL flex-basis: units "em" onto "rem" assert_equals: The value should be 40px at 0ms expected "40px" but got "20px"
     125FAIL flex-basis: units "calc" onto "px" assert_equals: The value should be calc(20% + 30px) at 0ms expected "calc(20% + 30px)" but got "calc(20% + 20px)"
     126FAIL flex-basis: calc assert_equals: The value should be calc(30% + 30px) at 0ms expected "calc(30% + 30px)" but got "calc(20% + 20px)"
     127PASS flex-basis (type: discrete) has testAccumulation function
     128PASS flex-basis: "10px" onto "auto"
     129PASS flex-basis: "auto" onto "10px"
    115130PASS flex-grow (type: positiveNumber) has testAccumulation function
    116131FAIL flex-grow: positive number assert_equals: The value should be 2.2 at 0ms expected "2.2" but got "1.100000023841858"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt

    r268718 r268792  
    113113FAIL filter: blur on blur assert_equals: The value should be blur(10px) blur(20px) at 0ms expected "blur(10px) blur(20px)" but got "blur(20px)"
    114114FAIL filter: different filter functions assert_equals: The value should be blur(10px) brightness(0.8) at 0ms expected "blur(10px) brightness(0.8)" but got "brightness(0.8)"
     115PASS flex-basis (type: lengthPercentageOrCalc) has testAddition function
     116FAIL flex-basis: length assert_equals: The value should be 20px at 0ms expected "20px" but got "10px"
     117FAIL flex-basis: length of rem assert_equals: The value should be 20px at 0ms expected "20px" but got "10px"
     118FAIL flex-basis: percentage assert_equals: The value should be 130% at 0ms expected "130%" but got "70%"
     119FAIL flex-basis: units "%" onto "px" assert_equals: The value should be calc(10% + 10px) at 0ms expected "calc(10% + 10px)" but got "10%"
     120FAIL flex-basis: units "px" onto "%" assert_equals: The value should be calc(10% + 10px) at 0ms expected "calc(10% + 10px)" but got "10px"
     121FAIL flex-basis: units "rem" onto "%" assert_equals: The value should be calc(10% + 20px) at 0ms expected "calc(10% + 20px)" but got "20px"
     122FAIL flex-basis: units "%" onto "rem" assert_equals: The value should be calc(10% + 20px) at 0ms expected "calc(10% + 20px)" but got "10%"
     123FAIL flex-basis: units "rem" onto "em" assert_equals: The value should be 40px at 0ms expected "40px" but got "20px"
     124FAIL flex-basis: units "em" onto "rem" assert_equals: The value should be 40px at 0ms expected "40px" but got "20px"
     125FAIL flex-basis: units "calc" onto "px" assert_equals: The value should be calc(20% + 30px) at 0ms expected "calc(20% + 30px)" but got "calc(20% + 20px)"
     126FAIL flex-basis: calc assert_equals: The value should be calc(30% + 30px) at 0ms expected "calc(30% + 30px)" but got "calc(20% + 20px)"
     127PASS flex-basis (type: discrete) has testAddition function
     128PASS flex-basis: "10px" onto "auto"
     129PASS flex-basis: "auto" onto "10px"
    115130PASS flex-grow (type: positiveNumber) has testAddition function
    116131FAIL flex-grow: positive number assert_equals: The value should be 2.2 at 0ms expected "2.2" but got "1.100000023841858"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt

    r268718 r268792  
    134134PASS filter: interpolate from none
    135135FAIL filter: url function (interpoalte as discrete) assert_equals: The value should be blur(0px) url("#f1") at 499ms expected "blur(0px) url(\"#f1\")" but got "blur(4.989999771118164px) url(\"#f1\")"
     136PASS flex-basis (type: lengthPercentageOrCalc) has testInterpolation function
     137PASS flex-basis supports animating as a length
     138PASS flex-basis supports animating as a length of rem
     139PASS flex-basis supports animating as a percentage
     140FAIL flex-basis supports animating as combination units "px" and "%" assert_equals: The value should be calc(10% + 5px) at 500ms expected "calc(10% + 5px)" but got "calc((10px * 0.5) + (20% * 0.5))"
     141FAIL flex-basis supports animating as combination units "%" and "em" assert_equals: The value should be calc(5% + 10px) at 500ms expected "calc(5% + 10px)" but got "calc((10% * 0.5) + (20px * 0.5))"
     142PASS flex-basis supports animating as combination units "em" and "rem"
     143FAIL flex-basis supports animating as combination units "px" and "calc" assert_equals: The value should be calc(10% + 10px) at 500ms expected "calc(10% + 10px)" but got "calc((10px * 0.5) + ((20% + 10px) * 0.5))"
     144FAIL flex-basis supports animating as a calc assert_equals: The value should be calc(15% + 15px) at 500ms expected "calc(15% + 15px)" but got "calc(((10% + 10px) * 0.5) + ((20% + 10px + 10px) * 0.5))"
     145PASS flex-basis (type: discrete) has testInterpolation function
     146PASS flex-basis uses discrete animation when animating between "auto" and "10px" with linear easing
     147PASS flex-basis uses discrete animation when animating between "auto" and "10px" with effect easing
     148PASS flex-basis uses discrete animation when animating between "auto" and "10px" with keyframe easing
    136149PASS flex-grow (type: positiveNumber) has testInterpolation function
    137150FAIL flex-grow supports animating as a positive number assert_equals: The value should be 1.3 at 500ms expected "1.3" but got "1.2999999523162842"

  • trunk/Source/WebCore/ChangeLog

    r268791 r268792  
     12020-10-20  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        [css-flexbox] flex-basis not animatable
     4        https://bugs.webkit.org/show_bug.cgi?id=180435
     5
     6        Reviewed by Antoine Quint.
     7
     8        Make flex-basis property animatable as per spec. This allows us to pass ~100 flexbox animation subtests.
     9
     10        * animation/CSSPropertyAnimation.cpp:
     11        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Mark flex-basis as animatable.
     12
    1132020-10-21  Youenn Fablet  <youenn@apple.com>
    214

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r268726 r268792  
    18711871        new PropertyWrapper<TextUnderlineOffset>(CSSPropertyTextUnderlineOffset, &RenderStyle::textUnderlineOffset, &RenderStyle::setTextUnderlineOffset),
    18721872
     1873        new LengthPropertyWrapper(CSSPropertyFlexBasis, &RenderStyle::flexBasis, &RenderStyle::setFlexBasis),
    18731874        new PropertyWrapper<float>(CSSPropertyFlexGrow, &RenderStyle::flexGrow, &RenderStyle::setFlexGrow),
    18741875        new PropertyWrapper<float>(CSSPropertyFlexShrink, &RenderStyle::flexShrink, &RenderStyle::setFlexShrink),
Note: See TracChangeset for help on using the changeset viewer.