Changeset 269190 in webkit

Timestamp:

Oct 30, 2020 10:02:47 AM (21 months ago)

Author:

youenn@apple.com

Message:

Increase camera failing timer to 30 seconds
​https://bugs.webkit.org/show_bug.cgi?id=218389

Reviewed by Eric Carlson.

From testing, 3 seconds is not always enough if getUserMedia is quickly called multiple times.
Let's increase to 30 seconds to give room for slow systems while still being able to identify failures.

• platform/mediastream/mac/AVVideoCaptureSource.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/mac/AVVideoCaptureSource.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-10-30  Youenn Fablet  <youenn@apple.com>
+
+        Increase camera failing timer to 30 seconds
+        https://bugs.webkit.org/show_bug.cgi?id=218389
+
+        Reviewed by Eric Carlson.
+
+        From testing, 3 seconds is not always enough if getUserMedia is quickly called multiple times.
+        Let's increase to 30 seconds to give room for slow systems while still being able to identify failures.
+
+        * platform/mediastream/mac/AVVideoCaptureSource.h:
+
 2020-10-30  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h

@@ -140 +140 @@
     bool m_isRunning { false };
 
-    static constexpr Seconds verifyCaptureInterval = 3_s;
+    static constexpr Seconds verifyCaptureInterval = 30_s;
     static const uint64_t framesToDropWhenStarting = 4;