Changeset 269357 in webkit


Ignore:
Timestamp:
Nov 3, 2020 11:34:57 PM (21 months ago)
Author:
graouts@webkit.org
Message:

align-items should be a discrete animatable property
​https://bugs.webkit.org/show_bug.cgi?id=218535
<rdar://problem/71012428>

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • rendering/style/StyleSelfAlignmentData.cpp: Added.

(WebCore::operator<<):

  • rendering/style/StyleSelfAlignmentData.h:
Location:
trunk
Files:
1 added
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r269354 r269357  
     12020-11-03  Antoine Quint  <graouts@webkit.org>
     2
     3        align-items should be a discrete animatable property
     4        https://bugs.webkit.org/show_bug.cgi?id=218535
     5        <rdar://problem/71012428>
     6
     7        Reviewed by Dean Jackson.
     8
     9        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
     10        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
     11        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
     12
    1132020-11-03  Tyler Wilcock  <twilco.o@protonmail.com>
    214

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt

    r269333 r269357  
    44PASS align-content: "flex-end" onto "flex-start"
    55PASS align-content: "flex-start" onto "flex-end"
     6PASS align-items (type: discrete) has testAccumulation function
     7PASS align-items: "flex-end" onto "flex-start"
     8PASS align-items: "flex-start" onto "flex-end"
    69PASS background-color (type: color) has testAccumulation function
    710FAIL background-color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 128) at 0ms expected "rgb(255, 128, 128)" but got "rgb(255, 0, 0)"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt

    r269333 r269357  
    44PASS align-content: "flex-end" onto "flex-start"
    55PASS align-content: "flex-start" onto "flex-end"
     6PASS align-items (type: discrete) has testAddition function
     7PASS align-items: "flex-end" onto "flex-start"
     8PASS align-items: "flex-start" onto "flex-end"
    69PASS background-color (type: color) has testAddition function
    710FAIL background-color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 128) at 0ms expected "rgb(255, 128, 128)" but got "rgb(255, 0, 0)"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt

    r269333 r269357  
    55PASS align-content uses discrete animation when animating between "flex-start" and "flex-end" with effect easing
    66PASS align-content uses discrete animation when animating between "flex-start" and "flex-end" with keyframe easing
     7PASS align-items (type: discrete) has testInterpolation function
     8PASS align-items uses discrete animation when animating between "flex-start" and "flex-end" with linear easing
     9PASS align-items uses discrete animation when animating between "flex-start" and "flex-end" with effect easing
     10PASS align-items uses discrete animation when animating between "flex-start" and "flex-end" with keyframe easing
    711PASS background-color (type: color) has testInterpolation function
    812PASS background-color supports animating as color of rgb()

  • trunk/Source/WebCore/ChangeLog

    r269354 r269357  
     12020-11-03  Antoine Quint  <graouts@webkit.org>
     2
     3        align-items should be a discrete animatable property
     4        https://bugs.webkit.org/show_bug.cgi?id=218535
     5        <rdar://problem/71012428>
     6
     7        Reviewed by Dean Jackson.
     8
     9        * Sources.txt:
     10        * WebCore.xcodeproj/project.pbxproj:
     11        * animation/CSSPropertyAnimation.cpp:
     12        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     13        * rendering/style/StyleSelfAlignmentData.cpp: Added.
     14        (WebCore::operator<<):
     15        * rendering/style/StyleSelfAlignmentData.h:
     16
    1172020-11-03  Tyler Wilcock  <twilco.o@protonmail.com>
    218

  • trunk/Source/WebCore/Sources.txt

    r269348 r269357  
    23122312rendering/style/StyleRareNonInheritedData.cpp
    23132313rendering/style/StyleScrollSnapPoints.cpp
     2314rendering/style/StyleSelfAlignmentData.cpp
    23142315rendering/style/StyleSurroundData.cpp
    23152316rendering/style/StyleTransformData.cpp

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r269348 r269357  
    98909890                718C7F571DD385C500B733C8 /* status-label.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = "status-label.js"; sourceTree = "<group>"; };
    98919891                7199B94A2551F0E100494A57 /* StyleContentAlignmentData.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = StyleContentAlignmentData.cpp; sourceTree = "<group>"; };
     9892                7199B94F2552103E00494A57 /* StyleSelfAlignmentData.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = StyleSelfAlignmentData.cpp; sourceTree = "<group>"; };
    98929893                71A1B6071DEE5A820073BCFB /* en */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.javascript; name = en; path = "en.lproj/modern-media-controls-localized-strings.js"; sourceTree = SOURCE_ROOT; };
    98939894                71A57DEF154BE25C0009D120 /* SVGPathUtilities.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SVGPathUtilities.cpp; sourceTree = "<group>"; };
    … …  
    2685926860                                F47A5E3A195B8C8A00483100 /* StyleScrollSnapPoints.cpp */,
    2686026861                                F47A5E3B195B8C8A00483100 /* StyleScrollSnapPoints.h */,
     26862                                7199B94F2552103E00494A57 /* StyleSelfAlignmentData.cpp */,
    2686126863                                9D63800F1AF16E160031A15C /* StyleSelfAlignmentData.h */,
    2686226864                                BC5EB5E60E81BFEF00B25965 /* StyleSurroundData.cpp */,

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r269333 r269357  
    19021902
    19031903        new DiscretePropertyWrapper<const StyleContentAlignmentData&>(CSSPropertyAlignContent, &RenderStyle::alignContent, &RenderStyle::setAlignContent),
     1904        new DiscretePropertyWrapper<const StyleSelfAlignmentData&>(CSSPropertyAlignItems, &RenderStyle::alignItems, &RenderStyle::setAlignItems),
    19041905    };
    19051906    const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);

  • trunk/Source/WebCore/rendering/style/StyleSelfAlignmentData.h

    r232018 r269357  
    6565};
    6666
     67WTF::TextStream& operator<<(WTF::TextStream&, const StyleSelfAlignmentData&);
     68
    6769} // namespace WebCore
Note: See TracChangeset for help on using the changeset viewer.