Changeset 269527 in webkit

Timestamp:

Nov 6, 2020 11:37:33 AM (21 months ago)

Author:

graouts@webkit.org

Message:

Accelerated animations of individual transform properties should apply rotate before scale
​https://bugs.webkit.org/show_bug.cgi?id=218659

Reviewed by Simon Fraser.

Not that applying scale before rotate makes any difference, but applying the operations in
the order specified in the CSS Transforms spec will make the code easier to understand between
this and RenderStyle::applyTransform().

No test since there is no change of behavior.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateAnimations):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/ca/GraphicsLayerCA.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-06  Antoine Quint  <graouts@webkit.org>
+
+        Accelerated animations of individual transform properties should apply rotate before scale
+        https://bugs.webkit.org/show_bug.cgi?id=218659
+
+        Reviewed by Simon Fraser.
+
+        Not that applying scale before rotate makes any difference, but applying the operations in
+        the order specified in the CSS Transforms spec will make the code easier to understand between
+        this and RenderStyle::applyTransform().
+
+        No test since there is no change of behavior.
+
+        * platform/graphics/ca/GraphicsLayerCA.cpp:
+        (WebCore::GraphicsLayerCA::updateAnimations):
+
 2020-11-06  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

@@ -3002 +3002 @@
             addBaseValueTransformAnimation(AnimatedPropertyTranslate);
 
+        if (rotateAnimation)
+            addAnimation(*rotateAnimation);
+        else
+            addBaseValueTransformAnimation(AnimatedPropertyRotate);
+
         if (scaleAnimation)
             addAnimation(*scaleAnimation);
         else
             addBaseValueTransformAnimation(AnimatedPropertyScale);
-
-        if (rotateAnimation)
-            addAnimation(*rotateAnimation);
-        else
-            addBaseValueTransformAnimation(AnimatedPropertyRotate);
 
         for (auto* animation : transformAnimations)
@@ -3022 +3022 @@
             addBaseValueTransformAnimation(AnimatedPropertyTransform);
 
+        if (scaleAnimation)
+            addAnimation(*scaleAnimation);
+        else
+            addBaseValueTransformAnimation(AnimatedPropertyScale);
+
         if (rotateAnimation)
             addAnimation(*rotateAnimation);
         else
             addBaseValueTransformAnimation(AnimatedPropertyRotate);
-
-        if (scaleAnimation)
-            addAnimation(*scaleAnimation);
-        else
-            addBaseValueTransformAnimation(AnimatedPropertyScale);
 
         if (translateAnimation)