Changeset 269528 in webkit

Timestamp:

Nov 6, 2020 12:17:03 PM (21 months ago)

Author:

commit-queue@webkit.org

Message:

Text gets clobbered when assigning to input.defaultValue
​https://bugs.webkit.org/show_bug.cgi?id=217156

Patch by Joey Arhar <​jarhar@chromium.org> on 2020-11-06
Reviewed by Darin Adler.

This fixes a bug where script assigning to the defaultValue property
of a number or email input causes the text the user entered into the
input to be clobbered when it doesn't perfectly match the sanitized
string returned by the .value property.

Test: LayoutTests/fast/forms/defaultValue-clobbering.html

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute):

Location:

trunk

Files:

• LayoutTests/fast/forms/defaultValue-clobbering-expected.txt (added)
• LayoutTests/fast/forms/defaultValue-clobbering.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLInputElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-06  Joey Arhar  <jarhar@chromium.org>
+
+        Text gets clobbered when assigning to input.defaultValue
+        https://bugs.webkit.org/show_bug.cgi?id=217156
+
+        Reviewed by Darin Adler.
+
+        This fixes a bug where script assigning to the defaultValue property
+        of a number or email input causes the text the user entered into the
+        input to be clobbered when it doesn't perfectly match the sanitized
+        string returned by the .value property.
+
+        Test: LayoutTests/fast/forms/defaultValue-clobbering.html
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::parseAttribute):
+
 2020-11-06  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/html/HTMLInputElement.cpp

@@ -765 +765 @@
             updatePlaceholderVisibility();
             invalidateStyleForSubtree();
+            setFormControlValueMatchesRenderer(false);
         }
-        setFormControlValueMatchesRenderer(false);
         updateValidity();
         m_valueAttributeWasUpdatedAfterParsing = !m_parsingInProgress;