Changeset 269558 in webkit

Timestamp:

Nov 6, 2020 9:34:18 PM (21 months ago)

Author:

Simon Fraser

Message:

Programmatic scrolls need updated scrolling geometry
​https://bugs.webkit.org/show_bug.cgi?id=218676

Reviewed by Tim Horton.

Source/WebCore:

Part of rdar://problem/69599531: Scrolling on netflix.com sometimes jumps to the top.

A programmatic scroll can happen right after content changes affect the scrolled content size,
and need to be committed right away to avoid the scrolling thread continuing to process events
or run rubberbanding based on stale state.

So when we get requestScrollPositionUpdate(), update the scrolling node geometry and
immediately commit the scrolling tree.

Test: fast/scrolling/mac/programmatic-scroll-overrides-rubberband.html

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):

LayoutTests:

• fast/scrolling/mac/programmatic-scroll-overrides-rubberband-expected.txt: Added.
• fast/scrolling/mac/programmatic-scroll-overrides-rubberband.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/scrolling/mac/programmatic-scroll-overrides-rubberband-expected.txt (added)
• LayoutTests/fast/scrolling/mac/programmatic-scroll-overrides-rubberband.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-11-06  Simon Fraser  <simon.fraser@apple.com>
+
+        Programmatic scrolls need updated scrolling geometry
+        https://bugs.webkit.org/show_bug.cgi?id=218676
+
+        Reviewed by Tim Horton.
+
+        * fast/scrolling/mac/programmatic-scroll-overrides-rubberband-expected.txt: Added.
+        * fast/scrolling/mac/programmatic-scroll-overrides-rubberband.html: Added.
+
 2020-11-06  Andres Gonzalez  <andresg_22@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-06  Simon Fraser  <simon.fraser@apple.com>
+
+        Programmatic scrolls need updated scrolling geometry
+        https://bugs.webkit.org/show_bug.cgi?id=218676
+
+        Reviewed by Tim Horton.
+
+        Part of rdar://problem/69599531: Scrolling on netflix.com sometimes jumps to the top.
+
+        A programmatic scroll can happen right after content changes affect the scrolled content size,
+        and need to be committed right away to avoid the scrolling thread continuing to process events
+        or run rubberbanding based on stale state.
+
+        So when we get requestScrollPositionUpdate(), update the scrolling node geometry and
+        immediately commit the scrolling tree.
+
+        Test: fast/scrolling/mac/programmatic-scroll-overrides-rubberband.html
+
+        * page/scrolling/AsyncScrollingCoordinator.cpp:
+        (WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
+
 2020-11-06  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp

@@ -266 +266 @@
         return false;
 
+    setScrollingNodeScrollableAreaGeometry(scrollingNodeID, scrollableArea);
+
     bool inBackForwardCache = frameView->frame().document()->backForwardCacheState() != Document::NotInBackForwardCache;
     bool inProgrammaticScroll = scrollableArea.currentScrollType() == ScrollType::Programmatic;
@@ -288 +290 @@
     }
 #endif
+
     stateNode->setRequestedScrollData({ scrollPosition, scrollType, clamping });
+    commitTreeStateIfNeeded();
     return true;
 }