Changeset 269963 in webkit

Timestamp:

Nov 18, 2020 9:51:39 AM (20 months ago)

Author:

graouts@webkit.org

Message:

[Web Animations] Ensure we don't schedule animation udpates when there are no styles to update
​https://bugs.webkit.org/show_bug.cgi?id=219071

Reviewed by Simon Fraser.

Source/WebCore:

Test: webanimations/scheduling-of-animation-without-keyframes.html

For keyframe effects that don't interpolate any CSS property, run the same logic that we already run
to determine when to schedule the next animation update in the case where we are running accelerated
animations.

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::timeToNextTick const):

LayoutTests:

Add a test that creates animations with various empty keyframes parameters to check that we don't
schedule animation update for them.

• webanimations/scheduling-of-animation-without-keyframes-expected.txt: Added.
• webanimations/scheduling-of-animation-without-keyframes.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webanimations/scheduling-of-animation-without-keyframes-expected.txt (added)
• LayoutTests/webanimations/scheduling-of-animation-without-keyframes.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/animation/KeyframeEffect.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-11-18  Antoine Quint  <graouts@webkit.org>
+
+        [Web Animations] Ensure we don't schedule animation udpates when there are no styles to update
+        https://bugs.webkit.org/show_bug.cgi?id=219071
+
+        Reviewed by Simon Fraser.
+
+        Add a test that creates animations with various empty keyframes parameters to check that we don't
+        schedule animation update for them.
+
+        * webanimations/scheduling-of-animation-without-keyframes-expected.txt: Added.
+        * webanimations/scheduling-of-animation-without-keyframes.html: Added.
+
 2020-11-18  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-18  Antoine Quint  <graouts@webkit.org>
+
+        [Web Animations] Ensure we don't schedule animation udpates when there are no styles to update
+        https://bugs.webkit.org/show_bug.cgi?id=219071
+
+        Reviewed by Simon Fraser.
+
+        Test: webanimations/scheduling-of-animation-without-keyframes.html
+
+        For keyframe effects that don't interpolate any CSS property, run the same logic that we already run
+        to determine when to schedule the next animation update in the case where we are running accelerated
+        animations.
+
+        * animation/KeyframeEffect.cpp:
+        (WebCore::KeyframeEffect::timeToNextTick const):
+
 2020-11-18  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/animation/KeyframeEffect.cpp

@@ -1980 +1980 @@
         // The effect is in its "before" phase, in this case we can wait until it enters its "active" phase.
         return delay() - *timing.localTime;
-    case AnimationEffectPhase::Active:
-        if (isCompletelyAccelerated() && isRunningAccelerated()) {
-            // Fully-accelerated running CSS Animations need to trigger "animationiteration" events, in this case we must wait until the next iteration.
+    case AnimationEffectPhase::Active: {
+        auto doesNotAffectStyles = m_blendingKeyframes.isEmpty() || m_blendingKeyframes.properties().isEmpty();
+        auto completelyAcceleratedAndRunning = isCompletelyAccelerated() && isRunningAccelerated();
+        if (doesNotAffectStyles || completelyAcceleratedAndRunning) {
+            // In the case of fully accelerated running effects and effects that don't actually target any CSS property,
+            // we do not have a need to invalidate styles.
             if (is<CSSAnimation>(animation())) {
+                // However, CSS Animations need to trigger "animationiteration" events, in this case we must wait until the next iteration.
                 if (auto iterationProgress = getComputedTiming().simpleIterationProgress)
                     return iterationDuration() * (1 - *iterationProgress);
             }
-            // Fully-accelerated running effects in the "active" phase can wait until they ended.
+            // Other running effects in the "active" phase can wait until they end.
             return endTime() - *timing.localTime;
         }
@@ -1997 +2001 @@
         // Other effects in the "active" phase will need to update their animated value at the immediate next opportunity.
         return 0_s;
+    }
     case AnimationEffectPhase::After:
         // The effect is in its after phase, which means it will no longer update its value, so it doens't need a tick.