Context Navigation

Changeset 270269 in webkit

Timestamp:

Nov 30, 2020 3:15:10 PM (20 months ago)

Author:

commit-queue@webkit.org

Message:

Patch by Alex Christensen <achristensen@webkit.org> on 2020-11-30
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Source/WebCore:

When fetching blob content, we use the whole blob URL.
In order to match Chrome and Firefox, we need to remove the fragment if there is one.

(WebCore::BlobRegistryImpl::getBlobDataFromURL const):

Location:

trunk

Files:

-                      r270252
+                      r270269
+-11-30  Alex Christensen  <achristensen@webkit.org>
+        Allow blob URLs with fragments
+        https://bugs.webkit.org/show_bug.cgi?id=219361
+        Reviewed by Darin Adler.
+        * web-platform-tests/FileAPI/url/url-with-fetch.any-expected.txt:
+        * web-platform-tests/FileAPI/url/url-with-fetch.any.worker-expected.txt:
+        * web-platform-tests/FileAPI/url/url-with-xhr.any-expected.txt:
+        * web-platform-tests/FileAPI/url/url-with-xhr.any.worker-expected.txt:
 -11-30  Youenn Fablet  <youenn@apple.com>

r267651	r270269
1	1
2	2	PASS Blob URLs can be used in fetch
3		FAIL fetch with a fragment should succeed promise_test: Unhandled rejection with value: object "TypeError: The operation couldn’t be completed. (WebKitBlobResource error 1.)"
	3	PASS fetch with a fragment should succeed
4	4	PASS fetch of a revoked URL should fail
5	5	PASS Only exact matches should revoke URLs, using fetch

r267651	r270269
1	1
2	2	PASS Blob URLs can be used in fetch
3		FAIL fetch with a fragment should succeed promise_test: Unhandled rejection with value: object "TypeError: The operation couldn’t be completed. (WebKitBlobResource error 1.)"
	3	PASS fetch with a fragment should succeed
4	4	PASS fetch of a revoked URL should fail
5	5	PASS Only exact matches should revoke URLs, using fetch

r267651	r270269
1	1
2	2	PASS Blob URLs can be used in XHR
3		FAIL XHR with a fragment should succeed promise_test: Unhandled rejection with value: "Got unexpected error event"
	3	PASS XHR with a fragment should succeed
4	4	PASS XHR of a revoked URL should fail
5	5	PASS Only exact matches should revoke URLs, using XHR

r267651	r270269
1	1
2	2	PASS Blob URLs can be used in XHR
3		FAIL XHR with a fragment should succeed promise_test: Unhandled rejection with value: "Got unexpected error event"
	3	PASS XHR with a fragment should succeed
4	4	PASS XHR of a revoked URL should fail
5	5	PASS Only exact matches should revoke URLs, using XHR

r267658	r270269
1	1
2	2	PASS Blob URLs can be used in fetch
3		FAIL fetch with a fragment should succeed promise_test: Unhandled rejection with value: object "TypeError: Type error"
	3	PASS fetch with a fragment should succeed
4	4	PASS fetch of a revoked URL should fail
5	5	PASS Only exact matches should revoke URLs, using fetch

r267658	r270269
1	1
2	2	PASS Blob URLs can be used in fetch
3		FAIL fetch with a fragment should succeed promise_test: Unhandled rejection with value: object "TypeError: Type error"
	3	PASS fetch with a fragment should succeed
4	4	PASS fetch of a revoked URL should fail
5	5	PASS Only exact matches should revoke URLs, using fetch

-                      r270257
+                      r270269
+-11-30  Alex Christensen  <achristensen@webkit.org>
+        Allow blob URLs with fragments
+        https://bugs.webkit.org/show_bug.cgi?id=219361
+        Reviewed by Darin Adler.
+        When fetching blob content, we use the whole blob URL.
+        In order to match Chrome and Firefox, we need to remove the fragment if there is one.
+        * platform/network/BlobRegistryImpl.cpp:
+        (WebCore::BlobRegistryImpl::getBlobDataFromURL const):
 -11-30  James Darpinian  <jdarpinian@chromium.org>

r264780	r270269
224	224	{
225	225	ASSERT(isMainThread());
	226	if (url.hasFragmentIdentifier())
	227	return m_blobs.get(url.stringWithoutFragmentIdentifier().toStringWithoutCopying());
226	228	return m_blobs.get(url.string());
227	229	}

Note: See TracChangeset for help on using the changeset viewer.