Changeset 270597 in webkit


Ignore:
Timestamp:
Dec 9, 2020 12:55:17 PM (20 months ago)
Author:
graouts@webkit.org
Message:

text-decoration-color animation should not be discrete
​https://bugs.webkit.org/show_bug.cgi?id=219691
<rdar://problem/72138361>

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-transitions/properties-value-003-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

We mistakenly added animation support for text-decoration-color in r269812 as a discrete property.
We now correctly make it a property that supports interpolation of the color type.

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r270589 r270597  
     12020-12-09  Antoine Quint  <graouts@webkit.org>
     2
     3        text-decoration-color animation should not be discrete
     4        https://bugs.webkit.org/show_bug.cgi?id=219691
     5        <rdar://problem/72138361>
     6
     7        Reviewed by Simon Fraser.
     8
     9        * web-platform-tests/css/css-transitions/properties-value-003-expected.txt:
     10        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
     11
    1122020-12-09  Antoine Quint  <graouts@webkit.org>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/properties-value-003-expected.txt

    r270589 r270597  
    4848FAIL marker-offset length(in) / values assert_not_equals: initial and target values may not match got disallowed value ""
    4949FAIL marker-offset length(in) / events assert_equals: Expected TransitionEnd events triggered on .transition expected "marker-offset:2s" but got ""
    50 FAIL text-decoration-color color(rgba) / values assert_not_equals: must not be target value after start got disallowed value "rgba(10, 10, 10, 0.4)"
    51 FAIL text-decoration-color color(rgba) / events assert_equals: Expected TransitionEnd events triggered on .transition expected "text-decoration-color:2s" but got ""
     50PASS text-decoration-color color(rgba) / values
     51PASS text-decoration-color color(rgba) / events
    5252PASS column-count integer(integer) / values
    5353PASS column-count integer(integer) / events

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt

    r269812 r270597  
    144144PASS text-align uses discrete animation when animating between "start" and "end" with keyframe easing
    145145PASS text-decoration-color (type: color) has testInterpolation function
    146 FAIL text-decoration-color supports animating as color of rgb() assert_equals: The value should be rgb(128, 0, 128) at 500ms expected "rgb(128, 0, 128)" but got "rgb(0, 0, 255)"
    147 FAIL text-decoration-color supports animating as color of #RGB assert_equals: The value should be rgb(128, 0, 128) at 500ms expected "rgb(128, 0, 128)" but got "rgb(0, 0, 255)"
    148 FAIL text-decoration-color supports animating as color of hsl() assert_equals: The value should be rgb(128, 0, 128) at 500ms expected "rgb(128, 0, 128)" but got "rgb(0, 0, 255)"
    149 FAIL text-decoration-color supports animating as color of #RGBa assert_equals: The value should be rgba(85, 0, 170, 0.6) at 500ms expected "rgba(85, 0, 170, 0.6)" but got "rgba(0, 0, 255, 0.8)"
    150 FAIL text-decoration-color supports animating as color of rgba() assert_equals: The value should be rgba(85, 0, 170, 0.6) at 500ms expected "rgba(85, 0, 170, 0.6)" but got "rgba(0, 0, 255, 0.8)"
    151 FAIL text-decoration-color supports animating as color of hsla() assert_equals: The value should be rgba(85, 0, 170, 0.6) at 500ms expected "rgba(85, 0, 170, 0.6)" but got "rgba(0, 0, 255, 0.8)"
     146PASS text-decoration-color supports animating as color of rgb()
     147PASS text-decoration-color supports animating as color of #RGB
     148PASS text-decoration-color supports animating as color of hsl()
     149PASS text-decoration-color supports animating as color of #RGBa
     150PASS text-decoration-color supports animating as color of rgba()
     151PASS text-decoration-color supports animating as color of hsla()
    152152PASS text-decoration-line (type: discrete) has testInterpolation function
    153153PASS text-decoration-line uses discrete animation when animating between "underline" and "overline" with linear easing

  • trunk/Source/WebCore/ChangeLog

    r270594 r270597  
     12020-12-09  Antoine Quint  <graouts@webkit.org>
     2
     3        text-decoration-color animation should not be discrete
     4        https://bugs.webkit.org/show_bug.cgi?id=219691
     5        <rdar://problem/72138361>
     6
     7        Reviewed by Simon Fraser.
     8
     9        We mistakenly added animation support for text-decoration-color in r269812 as a discrete property.
     10        We now correctly make it a property that supports interpolation of the color type.
     11
     12        * animation/CSSPropertyAnimation.cpp:
     13        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     14
    1152020-12-09  Ryan Haddad  <ryanhaddad@apple.com>
    216

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r270589 r270597  
    18971897        new PropertyWrapper<TextDecorationThickness>(CSSPropertyTextDecorationThickness, &RenderStyle::textDecorationThickness, &RenderStyle::setTextDecorationThickness),
    18981898        new PropertyWrapper<TextUnderlineOffset>(CSSPropertyTextUnderlineOffset, &RenderStyle::textUnderlineOffset, &RenderStyle::setTextUnderlineOffset),
     1899        new PropertyWrapperVisitedAffectedColor(CSSPropertyTextDecorationColor, &RenderStyle::textDecorationColor, &RenderStyle::setTextDecorationColor, &RenderStyle::visitedLinkTextDecorationColor, &RenderStyle::setVisitedLinkTextDecorationColor),
    18991900
    19001901        new LengthPropertyWrapper(CSSPropertyFlexBasis, &RenderStyle::flexBasis, &RenderStyle::setFlexBasis),
    … …  
    19651966        new DiscretePropertyWrapper<TableLayoutType>(CSSPropertyTableLayout, &RenderStyle::tableLayout, &RenderStyle::setTableLayout),
    19661967        new DiscretePropertyWrapper<TextAlignMode>(CSSPropertyTextAlign, &RenderStyle::textAlign, &RenderStyle::setTextAlign),
    1967         new DiscretePropertyWrapper<const Color&>(CSSPropertyTextDecorationColor, &RenderStyle::textDecorationColor, &RenderStyle::setTextDecorationColor),
    19681968        new DiscretePropertyWrapper<OptionSet<TextDecoration>>(CSSPropertyTextDecorationLine, &RenderStyle::textDecoration, &RenderStyle::setTextDecoration),
    19691969        new DiscretePropertyWrapper<TextDecorationStyle>(CSSPropertyTextDecorationStyle, &RenderStyle::textDecorationStyle, &RenderStyle::setTextDecorationStyle),
Note: See TracChangeset for help on using the changeset viewer.