Changeset 271054 in webkit

Timestamp:

Dec 22, 2020 8:48:30 AM (19 months ago)

Author:

Simon Fraser

Message:

Sibling element wheel event regions can be wrong
​https://bugs.webkit.org/show_bug.cgi?id=220071
Source/WebCore:

<rdar://problem/72435466>

Reviewed by Daniel Bates.

RenderStyle contains eventListenerRegionTypes() data which derive from registered
wheel event handlers, so style sharing needs to avoid sharing style between elements
with different handlers. For now, just disable style sharing for any elements
which event handlers.

Test: fast/scrolling/mac/wheel-event-listener-region-siblings.html

• style/StyleSharingResolver.cpp:

(WebCore::Style::SharingResolver::canShareStyleWithElement const):

LayoutTests:

Reviewed by Daniel Bates.

• fast/scrolling/mac/wheel-event-listener-region-siblings-expected.txt: Added.
• fast/scrolling/mac/wheel-event-listener-region-siblings.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/scrolling/mac/wheel-event-listener-region-siblings-expected.txt (added)
• LayoutTests/fast/scrolling/mac/wheel-event-listener-region-siblings.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/style/StyleSharingResolver.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-12-22  Simon Fraser  <simon.fraser@apple.com>
+
+        Sibling element wheel event regions can be wrong
+        https://bugs.webkit.org/show_bug.cgi?id=220071
+
+        Reviewed by Daniel Bates.
+
+        * fast/scrolling/mac/wheel-event-listener-region-siblings-expected.txt: Added.
+        * fast/scrolling/mac/wheel-event-listener-region-siblings.html: Added.
+
 2020-12-22  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-12-22  Simon Fraser  <simon.fraser@apple.com>
+
+        Sibling element wheel event regions can be wrong
+        https://bugs.webkit.org/show_bug.cgi?id=220071
+        <rdar://problem/72435466>
+
+        Reviewed by Daniel Bates.
+
+        RenderStyle contains eventListenerRegionTypes() data which derive from registered
+        wheel event handlers, so style sharing needs to avoid sharing style between elements
+        with different handlers. For now, just disable style sharing for any elements
+        which event handlers.
+
+        Test: fast/scrolling/mac/wheel-event-listener-region-siblings.html
+
+        * style/StyleSharingResolver.cpp:
+        (WebCore::Style::SharingResolver::canShareStyleWithElement const):
+
 2020-12-22  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/style/StyleSharingResolver.cpp

@@ -301 +301 @@
         return false;
 
+#if ENABLE(WHEEL_EVENT_REGIONS)
+    if (candidateElement.hasEventListeners() || element.hasEventListeners())
+        return false;
+#endif
+
 #if ENABLE(FULLSCREEN_API)
     if (&candidateElement == m_document.fullscreenManager().currentFullscreenElement() || &element == m_document.fullscreenManager().currentFullscreenElement())