Changeset 271129 in webkit

Timestamp:

Jan 4, 2021 3:27:44 AM (19 months ago)

Author:

svillar@igalia.com

Message:

Intrinsic size not correctly stored for SVG images
​https://bugs.webkit.org/show_bug.cgi?id=219981

Reviewed by Darin Adler.

Source/WebCore:

Intrinsic sizes were only stored in case the replaced element had an intrinsic size for both height and width.
However it's pretty common for SVG images to only specify one of them and an aspect ratio. We should store it
in those cases too as it'd be useful for some layout systems like flexbox.

• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox const): Replace isEmpty() by isZero() calls to allow
incomplete intrinsic sizes to be stored.

LayoutTests:

• TestExpectations: Removed two flexbox aspect ratio tests that are now passing.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderReplaced.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-12-17  Sergio Villar Senin  <svillar@igalia.com>
+
+        Intrinsic size not correctly stored for SVG images
+        https://bugs.webkit.org/show_bug.cgi?id=219981
+
+        Reviewed by Darin Adler.
+
+        * TestExpectations: Removed two flexbox aspect ratio tests that are now passing.
+
 2021-01-03  Rob Buis  <rbuis@igalia.com>
 

trunk/LayoutTests/TestExpectations

@@ -3919 +3919 @@
 
 webkit.org/b/219343 imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-012.html [ ImageOnlyFailure ]
-webkit.org/b/219343 imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-013.html [ ImageOnlyFailure ]
 webkit.org/b/219343 imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-015.html [ ImageOnlyFailure ]
 webkit.org/b/219343 imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-017.html [ ImageOnlyFailure ]
 webkit.org/b/219343 imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-007.html [ ImageOnlyFailure ]
-webkit.org/b/219343 imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-009.html [ ImageOnlyFailure ]
 webkit.org/b/219343 imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-010.html [ ImageOnlyFailure ]
 webkit.org/b/219343 imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-013.html [ ImageOnlyFailure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-12-17  Sergio Villar Senin  <svillar@igalia.com>
+
+        Intrinsic size not correctly stored for SVG images
+        https://bugs.webkit.org/show_bug.cgi?id=219981
+
+        Reviewed by Darin Adler.
+
+        Intrinsic sizes were only stored in case the replaced element had an intrinsic size for both height and width.
+        However it's pretty common for SVG images to only specify one of them and an aspect ratio. We should store it
+        in those cases too as it'd be useful for some layout systems like flexbox.
+
+        * rendering/RenderReplaced.cpp:
+        (WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox const): Replace isEmpty() by isZero() calls to allow
+        incomplete intrinsic sizes to be stored.
+
 2021-01-04  Alicia Boya García  <aboya@igalia.com>
 

trunk/Source/WebCore/rendering/RenderReplaced.cpp

@@ -405 +405 @@
         // constrain the size below, the correct intrinsic size will be obtained for comparison against
         // min and max widths.
-        if (intrinsicRatio && !intrinsicSize.isEmpty())
+        if (intrinsicRatio && !intrinsicSize.isZero())
             m_intrinsicSize = LayoutSize(intrinsicSize);
 
@@ -415 +415 @@
     } else {
         computeIntrinsicRatioInformation(intrinsicSize, intrinsicRatio);
-        if (intrinsicRatio && !intrinsicSize.isEmpty())
+        if (intrinsicRatio && !intrinsicSize.isZero())
             m_intrinsicSize = LayoutSize(isHorizontalWritingMode() ? intrinsicSize : intrinsicSize.transposedSize());
     }