Changeset 271166 in webkit

Timestamp:

Jan 5, 2021 12:00:37 PM (19 months ago)

Author:

Chris Fleizach

Message:

AX: aria-orientation is ignored on input[type="range"]
​https://bugs.webkit.org/show_bug.cgi?id=220222
<rdar://problem/72765547>

Reviewed by Zalan Bujtas.

Source/WebCore:

Check aria-orientation on range sliders.

Test: accessibility/mac/range-orientation.html

• accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::orientation const):

LayoutTests:

• accessibility/mac/range-orientation.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/mac/range-orientation-expected.txt (added)
• LayoutTests/accessibility/mac/range-orientation.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilitySlider.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-01-05  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: aria-orientation is ignored on input[type="range"]
+        https://bugs.webkit.org/show_bug.cgi?id=220222
+        <rdar://problem/72765547>
+
+        Reviewed by Zalan Bujtas.
+
+        * accessibility/mac/range-orientation.html: Added.
+
 2021-01-05  Truitt Savell  <tsavell@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-01-05  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: aria-orientation is ignored on input[type="range"]
+        https://bugs.webkit.org/show_bug.cgi?id=220222
+        <rdar://problem/72765547>
+
+        Reviewed by Zalan Bujtas.
+
+        Check aria-orientation on range sliders.
+
+        Test: accessibility/mac/range-orientation.html
+
+        * accessibility/AccessibilitySlider.cpp:
+        (WebCore::AccessibilitySlider::orientation const):
+
 2021-01-05  Alicia Boya García  <aboya@igalia.com>
 

trunk/Source/WebCore/accessibility/AccessibilitySlider.cpp

@@ -56 +56 @@
     if (!m_renderer)
         return AccessibilityOrientation::Horizontal;
+    
+    auto ariaOrientation = getAttribute(aria_orientationAttr);
+    if (equalLettersIgnoringASCIICase(ariaOrientation, "horizontal"))
+        return AccessibilityOrientation::Horizontal;
+    if (equalLettersIgnoringASCIICase(ariaOrientation, "vertical"))
+        return AccessibilityOrientation::Vertical;
+    if (equalLettersIgnoringASCIICase(ariaOrientation, "undefined"))
+        return AccessibilityOrientation::Undefined;
     
     const RenderStyle& style = m_renderer->style();