Changeset 271319 in webkit

Timestamp:

Jan 8, 2021 1:10:45 PM (19 months ago)

Author:

Patrick Angle

Message:

Web Inspector: Promote experimental "Show independent Styles sidebar" setting to "Elements" settings pane and enable by default
​https://bugs.webkit.org/show_bug.cgi?id=218126

Reviewed by Devin Rousso.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Base/Setting.js:
• Remove experimental naming from setting and enable by default.
• UserInterface/Views/RulesStyleDetailsSidebarPanel.js:

(WI.RulesStyleDetailsSidebarPanel.prototype.get allowExclusivePresentation):
(WI.RulesStyleDetailsSidebarPanel):

• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createElementsSettingsView):
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

• Move setting to "Elements" settings pane.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (2 diffs)
• UserInterface/Base/Setting.js (modified) (2 diffs)
• UserInterface/Views/RulesStyleDetailsSidebarPanel.js (modified) (1 diff)
• UserInterface/Views/SettingsTabContentView.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-01-08  Patrick Angle  <pangle@apple.com>
+
+        Web Inspector: Promote experimental "Show independent Styles sidebar" setting to "Elements" settings pane and enable by default
+        https://bugs.webkit.org/show_bug.cgi?id=218126
+
+        Reviewed by Devin Rousso.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Base/Setting.js:
+        - Remove experimental naming from setting and enable by default.
+        * UserInterface/Views/RulesStyleDetailsSidebarPanel.js:
+        (WI.RulesStyleDetailsSidebarPanel.prototype.get allowExclusivePresentation):
+        (WI.RulesStyleDetailsSidebarPanel):
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WI.SettingsTabContentView.prototype._createElementsSettingsView):
+        (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+        - Move setting to "Elements" settings pane.
+
 2021-01-07  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -443 +443 @@
 /* Label for the details sidebar. */
 localizedStrings["Details @ Sidebar"] = "Details";
+/* Category label for detail sidebar settings. */
+localizedStrings["Details Sidebars: @ Settings Elements Pane"] = "Details Sidebars:";
 localizedStrings["Device %d"] = "Device %d";
 localizedStrings["Device Settings"] = "Device Settings";
@@ -1301 +1303 @@
 localizedStrings["Show full certificate"] = "Show full certificate";
 localizedStrings["Show hidden tabs"] = "Show hidden tabs";
-localizedStrings["Show independent Styles sidebar"] = "Show independent Styles sidebar";
+/* Settings tab checkbox label for whether the independent styles sidebar should be shown */
+localizedStrings["Show independent Styles sidebar @ Settings Elements Pane"] = "Show independent Styles sidebar";
 localizedStrings["Show jump to effective property button"] = "Show jump to effective property button";
 localizedStrings["Show jump to variable declaration button"] = "Show jump to variable declaration button";

trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js

@@ -195 +195 @@
     emulateInUserGesture: new WI.Setting("emulate-in-user-gesture", false),
     enableControlFlowProfiler: new WI.Setting("enable-control-flow-profiler", false),
+    enableElementsTabIndependentStylesDetailsSidebarPanel: new WI.Setting("elements-tab-independent-styles-details-panel", true),
     enableLineWrapping: new WI.Setting("enable-line-wrapping", true),
     frontendAppearance: new WI.Setting("frontend-appearance", "system"),
@@ -223 +224 @@
     experimentalEnableStylesJumpToEffective: new WI.Setting("experimental-styles-jump-to-effective", false),
     experimentalEnableStylesJumpToVariableDeclaration: new WI.Setting("experimental-styles-jump-to-variable-declaration", false),
-    experimentalEnableIndependentStylesPanel: new WI.Setting("experimental-independent-styles-panel", false),
     experimentalEnableFontDetailsPanel: new WI.Setting("experimental-font-details-panel", false),
 

trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsSidebarPanel.js

@@ -35 +35 @@
     get allowExclusivePresentation()
     {
-        return WI.settings.experimentalEnableIndependentStylesPanel.value;
+        return WI.settings.enableElementsTabIndependentStylesDetailsSidebarPanel.value;
     }
 };

trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

@@ -286 +286 @@
         }
 
+        elementsSettingsView.addSetting(WI.UIString("Details Sidebars:", "Details Sidebars: @ Settings Elements Pane", "Category label for detail sidebar settings."), WI.settings.enableElementsTabIndependentStylesDetailsSidebarPanel, WI.UIString("Show independent Styles sidebar", "Show independent Styles sidebar @ Settings Elements Pane", "Settings tab checkbox label for whether the independent styles sidebar should be shown"));
+        elementsSettingsView.addSeparator();
+
         elementsSettingsView.addSetting(WI.UIString("CSS Changes:"), WI.settings.cssChangesPerNode, WI.UIString("Show only for selected node"));
 
@@ -401 +404 @@
 
         let elementsGroup = experimentalSettingsView.addGroup(WI.UIString("Elements Tab:", "Elements Tab: @ Experimental Settings", "Category label for experimental settings pertaining to the Elements tab"));
-        elementsGroup.addSetting(WI.settings.experimentalEnableIndependentStylesPanel, WI.UIString("Show independent Styles sidebar"));
         elementsGroup.addSetting(WI.settings.experimentalEnableFontDetailsPanel, WI.UIString("Show Font details sidebar panel"));
         experimentalSettingsView.addSeparator();
@@ -428 +430 @@
         }
 
-        listenForChange(WI.settings.experimentalEnableIndependentStylesPanel);
         listenForChange(WI.settings.experimentalEnableFontDetailsPanel);