Changeset 271377 in webkit


Ignore:
Timestamp:
Jan 11, 2021 1:33:56 PM (18 months ago)
Author:
Peng Liu
Message:

A video element needs to ignore the request to enter/exit fullscreen before the current fullscreen mode change is completed
​https://bugs.webkit.org/show_bug.cgi?id=220466

Reviewed by Jer Noble.

A follow-up patch of r271341 to fix a layout test timeout (and failure, see webkit.org/b/183490).

  • media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-fullscreen-change.html:
  • platform/mac/TestExpectations:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r271373 r271377  
     12021-01-11  Peng Liu  <peng.liu6@apple.com>
     2
     3        A video element needs to ignore the request to enter/exit fullscreen before the current fullscreen mode change is completed
     4        https://bugs.webkit.org/show_bug.cgi?id=220466
     5
     6        Reviewed by Jer Noble.
     7
     8        A follow-up patch of r271341 to fix a layout test timeout (and failure, see webkit.org/b/183490).
     9
     10        * media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt:
     11        * media/modern-media-controls/media-controller/media-controller-fullscreen-change.html:
     12        * platform/mac/TestExpectations:
     13
    1142021-01-11  Devin Rousso  <drousso@apple.com>
    215

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt

    r223176 r271377  
    44
    55
     6PASS internals.isChangingPresentationMode(media) became false
    67Media entered fullscreen
    78PASS mediaController.layoutTraits is LayoutTraits.macOS | LayoutTraits.Fullscreen
    89PASS mediaController.controls instanceof MacOSFullscreenMediaControls is true
    910
     11PASS internals.isChangingPresentationMode(media) became false
    1012Media exited fullscreen
    1113PASS mediaController.layoutTraits is LayoutTraits.macOS | LayoutTraits.Inline

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change.html

    r223176 r271377  
    1616const button = document.body.appendChild(document.createElement("button"));
    1717button.textContent = "Enter Fullscreen";
     18
     19if (window.internals)
     20    internals.setMockVideoPresentationModeEnabled(true);
    1821
    1922function enterFullscreen()
    … …  
    3942}
    4043
    41 media.addEventListener("webkitfullscreenchange", function() {
     44function toggleFullscreen()
     45{
    4246    if (media.webkitDisplayingFullscreen) {
    4347        debug("Media entered fullscreen");
    … …  
    5761        finishJSTest();
    5862    }
     63}
     64
     65media.addEventListener("webkitfullscreenchange", function() {
     66    if (window.internals)
     67        shouldBecomeEqual("internals.isChangingPresentationMode(media)", "false", toggleFullscreen);
     68    else
     69        toggleFullscreen();
    5970});
    6071

  • trunk/LayoutTests/platform/mac/TestExpectations

    r271328 r271377  
    14551455webkit.org/b/183490 media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html [ Failure ]
    14561456webkit.org/b/183490 media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html [ Failure ]
    1457 webkit.org/b/183490 media/modern-media-controls/media-controller/media-controller-fullscreen-change.html [ Failure ]
    14581457webkit.org/b/183490 media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html [ Failure ]
    14591458webkit.org/b/183490 media/modern-media-controls/start-support/start-support-fullscreen.html [ Failure ]
Note: See TracChangeset for help on using the changeset viewer.