Changeset 271388 in webkit

Timestamp:

Jan 11, 2021 6:52:17 PM (18 months ago)

Author:

Simon Fraser

Message:

Safari 14 on 2x display renders NYS DMV page as blurry
​https://bugs.webkit.org/show_bug.cgi?id=220528
<rdar://problem/71440246>

Reviewed by Tim Horton.

Source/WebCore:

Certain combinations of nested perspective and transform cause Core Animation to
rasterize at unit scale, which makes layers blurry on Retina displays.

Enable code that was already used on iOS to set layer rasterization scale.

Test: compositing/contents-scale/hidpi-tests/rasterization-scale.html

• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::setContentsScale):

LayoutTests:

• compositing/contents-scale/hidpi-tests/rasterization-scale-expected.html: Added.
• compositing/contents-scale/hidpi-tests/rasterization-scale.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/contents-scale/hidpi-tests (added)
• LayoutTests/compositing/contents-scale/hidpi-tests/rasterization-scale-expected.html (added)
• LayoutTests/compositing/contents-scale/hidpi-tests/rasterization-scale.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-01-11  Simon Fraser  <simon.fraser@apple.com>
+
+        Safari 14 on 2x display renders NYS DMV page as blurry
+        https://bugs.webkit.org/show_bug.cgi?id=220528
+        <rdar://problem/71440246>
+
+        Reviewed by Tim Horton.
+
+        * compositing/contents-scale/hidpi-tests/rasterization-scale-expected.html: Added.
+        * compositing/contents-scale/hidpi-tests/rasterization-scale.html: Added.
+
 2021-01-11  Megan Gardner  <megan_gardner@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-01-11  Simon Fraser  <simon.fraser@apple.com>
+
+        Safari 14 on 2x display renders NYS DMV page as blurry
+        https://bugs.webkit.org/show_bug.cgi?id=220528
+        <rdar://problem/71440246>
+
+        Reviewed by Tim Horton.
+
+        Certain combinations of nested perspective and transform cause Core Animation to
+        rasterize at unit scale, which makes layers blurry on Retina displays.
+
+        Enable code that was already used on iOS to set layer rasterization scale.
+
+        Test: compositing/contents-scale/hidpi-tests/rasterization-scale.html
+
+        * platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
+        (WebCore::PlatformCALayerCocoa::setContentsScale):
+
 2021-01-11  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm

@@ -916 +916 @@
     BEGIN_BLOCK_OBJC_EXCEPTIONS
     [m_layer setContentsScale:value];
-#if PLATFORM(IOS_FAMILY)
     [m_layer setRasterizationScale:value];
-#endif
     END_BLOCK_OBJC_EXCEPTIONS
 }