Changeset 271470 in webkit

Timestamp:

Jan 13, 2021 3:32:21 PM (18 months ago)

Author:

jer.noble@apple.com

Message:

Facebook pauses video in PiP during scroll
​https://bugs.webkit.org/show_bug.cgi?id=220581
<rdar://67273166>

Reviewed by Eric Carlson.

Add a Quirk which blocks Facebook from pausing videos in Picture-in-Picture mode without that
pause() occurring during a User Gesture. This blocks Facebook from pausing a PiP'd video when
the <video> element hosting that video scrolls out of the viewport, without blocking Facebook's
own custom pause control from working correctly.

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted const):

• page/Quirks.cpp:

(WebCore::Quirks::requiresUserGestureToPauseInPictureInPicture const):

• page/Quirks.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/MediaElementSession.cpp (modified) (1 diff)
• page/Quirks.cpp (modified) (2 diffs)
• page/Quirks.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-01-13  Jer Noble  <jer.noble@apple.com>
+
+        Facebook pauses video in PiP during scroll
+        https://bugs.webkit.org/show_bug.cgi?id=220581
+        <rdar://67273166>
+
+        Reviewed by Eric Carlson.
+
+        Add a Quirk which blocks Facebook from pausing videos in Picture-in-Picture mode without that
+        pause() occurring during a User Gesture. This blocks Facebook from pausing a PiP'd video when
+        the <video> element hosting that video scrolls out of the viewport, without blocking Facebook's
+        own custom pause control from working correctly.
+
+        * html/MediaElementSession.cpp:
+        (WebCore::MediaElementSession::playbackPermitted const):
+        * page/Quirks.cpp:
+        (WebCore::Quirks::requiresUserGestureToPauseInPictureInPicture const):
+        * page/Quirks.h:
+
 2021-01-13  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/html/MediaElementSession.cpp

@@ -316 +316 @@
     // FIXME: Why are we checking top-level document only for PerDocumentAutoplayBehavior?
     const auto& topDocument = document.topDocument();
+    if (topDocument.quirks().requiresUserGestureToPauseInPictureInPicture()
+        && m_element.fullscreenMode() & HTMLMediaElementEnums::VideoFullscreenModePictureInPicture
+        && !m_element.paused()
+        && !document.processingUserGestureForMedia()) {
+        ALWAYS_LOG(LOGIDENTIFIER, "Returning FALSE because a quirk requires a user gesture to pause while in Picture-in-Picture");
+        return MediaPlaybackDenialReason::UserGestureRequired;
+    }
+
     if (topDocument.mediaState() & MediaProducer::HasUserInteractedWithMediaElement && topDocument.quirks().needsPerDocumentAutoplayBehavior())
         return { };

trunk/Source/WebCore/page/Quirks.cpp

@@ -46 +46 @@
 #include "NetworkStorageSession.h"
 #include "PlatformMouseEvent.h"
+#include "RegistrableDomain.h"
 #include "ResourceLoadObserver.h"
 #include "RuntimeEnabledFeatures.h"
@@ -1259 +1260 @@
 }
 
-}
+bool Quirks::requiresUserGestureToPauseInPictureInPicture() const
+{
+    // Facebook will naively pause a <video> element that has scrolled out of the viewport, regardless of whether that element is currently in PiP mode.
+    if (!needsQuirks())
+        return false;
+
+    if (!m_requiresUserGestureToPauseInPictureInPicture) {
+        auto domain = RegistrableDomain(m_document->topDocument().url());
+        m_requiresUserGestureToPauseInPictureInPicture = domain.string() == "facebook.com"_s;
+    }
+
+    return *m_requiresUserGestureToPauseInPictureInPicture;
+}
+
+}

trunk/Source/WebCore/page/Quirks.h

@@ -128 +128 @@
     bool needsBlackFullscreenBackgroundQuirk() const;
 
+    bool requiresUserGestureToPauseInPictureInPicture() const;
+
 #if ENABLE(RESOURCE_LOAD_STATISTICS)
     static bool isMicrosoftTeamsRedirectURL(const URL&);
@@ -168 +170 @@
     mutable Optional<bool> m_needsHDRPixelDepthQuirk;
     mutable Optional<bool> m_needsBlackFullscreenBackgroundQuirk;
+    mutable Optional<bool> m_requiresUserGestureToPauseInPictureInPicture;
 };