Changeset 271485 in webkit

Timestamp:

Jan 14, 2021 9:15:03 AM (18 months ago)

Author:

commit-queue@webkit.org

Message:

Update buttons of media permission prompt on macOS
​https://bugs.webkit.org/show_bug.cgi?id=220613

Patch by Sihui Liu <​sihui_liu@appe.com> on 2021-01-14
Reviewed by Eric Carlson.

Make allow button on the right and not selected to match TCC prompts.

• UIProcess/Cocoa/MediaPermissionUtilities.mm:

(WebKit::alertForPermission):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/MediaPermissionUtilities.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-01-14  Sihui Liu  <sihui_liu@appe.com>
+
+        Update buttons of media permission prompt on macOS
+        https://bugs.webkit.org/show_bug.cgi?id=220613
+
+        Reviewed by Eric Carlson.
+
+        Make allow button on the right and not selected to match TCC prompts.
+
+        * UIProcess/Cocoa/MediaPermissionUtilities.mm:
+        (WebKit::alertForPermission):
+
 2021-01-14  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/UIProcess/Cocoa/MediaPermissionUtilities.mm

@@ -184 +184 @@
     auto alert = adoptNS([NSAlert new]);
     [alert setMessageText:alertTitle];
-    [alert addButtonWithTitle:doNotAllowButtonString];
-    [alert addButtonWithTitle:allowButtonString];
+    NSButton *button = [alert addButtonWithTitle:allowButtonString];
+    button.keyEquivalent = @"";
+    button = [alert addButtonWithTitle:doNotAllowButtonString];
+    button.keyEquivalent = @"\E";
     [alert beginSheetModalForWindow:webView.window completionHandler:[completionBlock](NSModalResponse returnCode) {
-        auto shouldAllow = returnCode == NSAlertSecondButtonReturn;
+        auto shouldAllow = returnCode == NSAlertFirstButtonReturn;
         completionBlock(shouldAllow);
     }];