Changeset 271523 in webkit

Timestamp:

Jan 15, 2021 8:53:46 AM (18 months ago)

Author:

Tomoki Imai

Message:

When non-integer tabindex is set, the behavior of element should be same as the tabindex is omitted.
​https://bugs.webkit.org/show_bug.cgi?id=220648

Reviewed by Antti Koivisto.

Source/WebCore:

When non-integer tabindex is specified, the element should behave the same way as the tabindex is omitted.
​https://html.spec.whatwg.org/multipage/interaction.html#attr-tabindex

WebKit didn't overwrite the internal tabindex value when the new value is non-integer.

Test: LayoutTests\fast\html\tabindex-overwrite-with-non-integer.html

• html/HTMLElement.cpp:

(WebCore::HTMLElement::parseAttribute): If the new value cannot be parsed as the integer, clear the existing tabindex.

LayoutTests:

Add LayoutTest case for tabindex which is overwritten by non-integers.
When non-integer tabindex is specified, the element should behave the same way as the tabindex is omitted.
​https://html.spec.whatwg.org/multipage/interaction.html#attr-tabindex

• fast/html/tabindex-overwrite-with-non-integer-expected.txt: Added.
• fast/html/tabindex-overwrite-with-non-integer.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/html/tabindex-overwrite-with-non-integer-expected.txt (added)
• LayoutTests/fast/html/tabindex-overwrite-with-non-integer.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-01-15  Tomoki Imai  <Tomoki.Imai@sony.com>
+
+        When non-integer tabindex is set, the behavior of element should be same as the tabindex is omitted.
+        https://bugs.webkit.org/show_bug.cgi?id=220648
+
+        Reviewed by Antti Koivisto.
+
+        Add LayoutTest case for tabindex which is overwritten by non-integers.
+        When non-integer tabindex is specified, the element should behave the same way as the tabindex is omitted.
+        https://html.spec.whatwg.org/multipage/interaction.html#attr-tabindex
+
+        * fast/html/tabindex-overwrite-with-non-integer-expected.txt: Added.
+        * fast/html/tabindex-overwrite-with-non-integer.html: Added.
+
 2021-01-15  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-01-15  Tomoki Imai  <Tomoki.Imai@sony.com>
+
+        When non-integer tabindex is set, the behavior of element should be same as the tabindex is omitted.
+        https://bugs.webkit.org/show_bug.cgi?id=220648
+
+        Reviewed by Antti Koivisto.
+
+        When non-integer tabindex is specified, the element should behave the same way as the tabindex is omitted.
+        https://html.spec.whatwg.org/multipage/interaction.html#attr-tabindex
+
+        WebKit didn't overwrite the internal tabindex value when the new value is non-integer.
+
+        Test: LayoutTests\fast\html\tabindex-overwrite-with-non-integer.html
+
+        * html/HTMLElement.cpp:
+        (WebCore::HTMLElement::parseAttribute): If the new value cannot be parsed as the integer, clear the existing tabindex.
+
 2021-01-15  Rob Buis  <rbuis@igalia.com>
 

trunk/Source/WebCore/html/HTMLElement.cpp

@@ -453 +453 @@
 
     if (name == tabindexAttr) {
-        if (value.isEmpty())
+        if (auto optionalTabIndex = parseHTMLInteger(value))
+            setTabIndexExplicitly(optionalTabIndex.value());
+        else
             setTabIndexExplicitly(WTF::nullopt);
-        else if (auto optionalTabIndex = parseHTMLInteger(value))
-            setTabIndexExplicitly(optionalTabIndex.value());
         return;
     }