Changeset 271726 in webkit

Timestamp:

Jan 21, 2021 5:24:44 PM (18 months ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Fix bidi confusion when evaluation result has RTL text
​https://bugs.webkit.org/show_bug.cgi?id=220639

Patch by Ebrahim Byagowi <​ebrahim@gnu.org> on 2021-01-21
Reviewed by BJ Burg.

Apply unicode-bidi: isolate to formatted string and regexp so that
when they contain RTL text the bidi algorithm won't mix
saved variable name ($1, $2, ...) with the content.

• UserInterface/Views/FormattedValue.css:

(.formatted-string, .formatted-regexp):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/FormattedValue.css (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-01-21  Ebrahim Byagowi  <ebrahim@gnu.org>
+
+        Web Inspector: Fix bidi confusion when evaluation result has RTL text
+        https://bugs.webkit.org/show_bug.cgi?id=220639
+
+        Reviewed by BJ Burg.
+
+        Apply `unicode-bidi: isolate` to formatted string and regexp so that
+        when they contain RTL text the bidi algorithm won't mix
+        saved variable name ($1, $2, ...) with the content.
+
+        * UserInterface/Views/FormattedValue.css:
+        (.formatted-string, .formatted-regexp):
+
 2021-01-20  Kenneth Russell  <kbr@chromium.org>
 

trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.css

@@ -45 +45 @@
 .formatted-string, .formatted-regexp {
     white-space: pre;
+    unicode-bidi: isolate;
 }