Changeset 272074 in webkit


Ignore:
Timestamp:
Jan 29, 2021 12:59:35 PM (18 months ago)
Author:
commit-queue@webkit.org
Message:

[WASM-References] Enable reference types by default
​https://bugs.webkit.org/show_bug.cgi?id=220890

Patch by Dmitry Bezhetskov <dbezhetskov> on 2021-01-29
Reviewed by Yusuke Suzuki.

Enable wasm reference types by default.

Source/JavaScriptCore:

  • runtime/OptionsList.h:

Tools:

  • Scripts/run-jsc-stress-tests:
Location:
trunk
Files:
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/constructor-reftypes.tentative.any-expected.txt

    r271774 r272074  
    11
    2 FAIL initialize externref table with default value assert_equals: expected object "[object Object]" but got null
     2PASS initialize externref table with default value
    33PASS initialize table with a wrong element value
    4 FAIL initialize anyfunc table with default value assert_equals: expected (function) function "function 0() {
    5     [native code]
    6 }" but got (object) null
    7 FAIL initialize anyfunc table with a bad default value assert_throws_js: function "() => new WebAssembly.Table(argument, {})" did not throw
     4PASS initialize anyfunc table with default value
     5PASS initialize anyfunc table with a bad default value
    86

  • trunk/LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/constructor.any-expected.txt

    r267649 r272074  
    2323PASS Basic (zero)
    2424PASS Basic (non-zero)
    25 PASS Stray argument
     25FAIL Stray argument WebAssembly.Table.prototype.constructor expects the second argument to be null or an instance of WebAssembly.Function
    2626PASS Proxy descriptor
    2727PASS Type conversion for descriptor.element

  • trunk/LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/constructor.any.worker-expected.txt

    r267649 r272074  
    2323PASS Basic (zero)
    2424PASS Basic (non-zero)
    25 PASS Stray argument
     25FAIL Stray argument WebAssembly.Table.prototype.constructor expects the second argument to be null or an instance of WebAssembly.Function
    2626PASS Proxy descriptor
    2727PASS Type conversion for descriptor.element

  • trunk/LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/get-set.any-expected.txt

    r267649 r272074  
    22PASS Missing arguments: get
    33PASS Branding: get
    4 PASS Missing arguments: set
     4FAIL Missing arguments: set assert_throws_js: function "() => table.set(0)" did not throw
    55PASS Branding: set
    66PASS Basic

  • trunk/LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/get-set.any.worker-expected.txt

    r267649 r272074  
    22PASS Missing arguments: get
    33PASS Branding: get
    4 PASS Missing arguments: set
     4FAIL Missing arguments: set assert_throws_js: function "() => table.set(0)" did not throw
    55PASS Branding: set
    66PASS Basic

  • trunk/LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/grow-reftypes.tentative.any-expected.txt

    r271112 r272074  
    11
    2 FAIL Grow with exported-function argument assert_equals: expected (function) function "function 0() {
    3     [native code]
    4 }" but got (object) null
    5 FAIL Grow with non-function argument assert_throws_js: function "() => table.grow(2, {})" did not throw
    6 FAIL Grow with JS-function argument assert_throws_js: function "() => table.grow(2, () => true)" did not throw
     2PASS Grow with exported-function argument
     3PASS Grow with non-function argument
     4PASS Grow with JS-function argument
    75

  • trunk/LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/set-reftypes.tentative.any-expected.txt

    r271774 r272074  
    11
    2 FAIL Arguments for anyfunc table set assert_equals: expected (function) function "function 0() {
    3     [native code]
    4 }" but got (object) null
    5 FAIL Arguments for externref table set assert_equals: expected object "[object Object]" but got null
     2PASS Arguments for anyfunc table set
     3PASS Arguments for externref table set
    64

  • trunk/Source/JavaScriptCore/ChangeLog

    r272071 r272074  
     12021-01-29  Dmitry Bezhetskov  <dbezhetskov@igalia.com>
     2
     3        [WASM-References] Enable reference types by default
     4        https://bugs.webkit.org/show_bug.cgi?id=220890
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        Enable wasm reference types by default.
     9
     10        * runtime/OptionsList.h:
     11
    1122021-01-29  Dmitry Bezhetskov  <dbezhetskov@igalia.com>
    213

  • trunk/Source/JavaScriptCore/runtime/OptionsList.h

    r271993 r272074  
    484484    v(Bool, useWebAssemblyStreaming, true, Normal, "Allow to run WebAssembly's Streaming API") \
    485485    v(Bool, useEagerWebAssemblyModuleHashing, false, Normal, "Unnamed WebAssembly modules are identified in backtraces through their hash, if available.") \
    486     v(Bool, useWebAssemblyReferences, false, Normal, "Allow types from the wasm references spec.") \
     486    v(Bool, useWebAssemblyReferences, true, Normal, "Allow types from the wasm references spec.") \
    487487    v(Bool, useWebAssemblyMultiValues, true, Normal, "Allow types from the wasm mulit-values spec.") \
    488488    v(Bool, useWebAssemblyThreading, true, Normal, "Allow instructions from the wasm threading spec.") \

  • trunk/Tools/ChangeLog

    r272067 r272074  
     12021-01-29  Dmitry Bezhetskov  <dbezhetskov@igalia.com>
     2
     3        [WASM-References] Enable reference types by default
     4        https://bugs.webkit.org/show_bug.cgi?id=220890
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        Enable wasm reference types by default.
     9
     10        * Scripts/run-jsc-stress-tests:
     11
    1122021-01-29  Andres Gonzalez  <andresg_22@apple.com>
    213

  • trunk/Tools/Scripts/run-jsc-stress-tests

    r272056 r272074  
    12981298
    12991299def runWebAssemblySpecTest(mode)
    1300     runWebAssemblySpecTestBase(mode, "spec-harness")
     1300    runWebAssemblySpecTestBase(mode, "spec-harness", "--useWebAssemblyReferences=false")
    13011301end
    13021302
Note: See TracChangeset for help on using the changeset viewer.