Changeset 272099 in webkit

Timestamp:

Jan 29, 2021 8:57:02 PM (18 months ago)

Author:

ysuzuki@apple.com

Message:

[JSC] Adjust property order of host JSFunction
​https://bugs.webkit.org/show_bug.cgi?id=221168

Reviewed by Darin Adler.

JSTests:

• stress/host-function-property-order.js: Added.

(shouldBe):

Source/JavaScriptCore:

We should first define "length" before "name".
This will be included in upcoming test262 update[1].

[1]: ​https://github.com/tc39/test262/pull/2921

• runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/host-function-property-order.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/JSFunction.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2021-01-29  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Adjust property order of host JSFunction
+        https://bugs.webkit.org/show_bug.cgi?id=221168
+
+        Reviewed by Darin Adler.
+
+        * stress/host-function-property-order.js: Added.
+        (shouldBe):
+
 2021-01-29  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-01-29  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Adjust property order of host JSFunction
+        https://bugs.webkit.org/show_bug.cgi?id=221168
+
+        Reviewed by Darin Adler.
+
+        We should first define "length" before "name".
+        This will be included in upcoming test262 update[1].
+
+        [1]: https://github.com/tc39/test262/pull/2921
+
+        * runtime/JSFunction.cpp:
+        (JSC::JSFunction::finishCreation):
+
 2021-01-29  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSFunction.cpp

@@ -130 +130 @@
     ASSERT(!this->inherits<JSBoundFunction>(vm));
 
+    putDirect(vm, vm.propertyNames->length, jsNumber(length), PropertyAttribute::ReadOnly | PropertyAttribute::DontEnum);
     if (!name.isNull())
         putDirect(vm, vm.propertyNames->name, jsString(vm, name), PropertyAttribute::ReadOnly | PropertyAttribute::DontEnum);
-    putDirect(vm, vm.propertyNames->length, jsNumber(length), PropertyAttribute::ReadOnly | PropertyAttribute::DontEnum);
 }