Changeset 272308 in webkit

Timestamp:

Feb 3, 2021 6:03:54 AM (18 months ago)

Author:

commit-queue@webkit.org

Message:

[css-grid][css-flex] <table> grid item should fill the grid area for 'stretch'/'normal' self alignment
​https://bugs.webkit.org/show_bug.cgi?id=191463

Patch by Ziran Sun <Ziran Sun> on 2021-02-03
Reviewed by Sergio Villar Senin.

Source/WebCore:

Avoid table sizing peculiarities for grid items. Let the grid render algorithm determine
the size of tables that are grid items. Don't let the intrinsic width of table columns
affect the width of the item. This change only deals with widths.

This is an import of Chromium changes at
​https://chromium-review.googlesource.com/c/chromium/src/+/781859/
This issue seems only affect grid-items and not flexbox any more hence only changes from
grid are imported.

Test for this change has already been imported from WPT

• rendering/RenderTable.cpp:

(WebCore::RenderTable::updateLogicalWidth):

LayoutTests:

• TestExpectations: Unskip a tests that is not failing anymore.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderTable.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-02-03  Ziran Sun  <zsun@igalia.com>
+
+        [css-grid][css-flex] <table> grid item should fill the grid area for 'stretch'/'normal' self alignment
+        https://bugs.webkit.org/show_bug.cgi?id=191463
+
+        Reviewed by Sergio Villar Senin.
+
+        * TestExpectations: Unskip a tests that is not failing anymore.
+
 2021-02-03  Rob Buis  <rbuis@igalia.com>
 

trunk/LayoutTests/TestExpectations

@@ -1207 +1207 @@
 webkit.org/b/216145 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-9.html [ ImageOnlyFailure ]
 webkit.org/b/216145 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-10.html [ ImageOnlyFailure ]
-webkit.org/b/191463 imported/w3c/web-platform-tests/css/css-grid/grid-items/explicitly-sized-grid-item-as-table.html [ ImageOnlyFailure ]
 webkit.org/b/191627 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html [ Failure ]
 webkit.org/b/149890 fast/css-grid-layout/grid-shorthands-style-format.html [ Failure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-03  Ziran Sun  <zsun@igalia.com>
+
+        [css-grid][css-flex] <table> grid item should fill the grid area for 'stretch'/'normal' self alignment
+        https://bugs.webkit.org/show_bug.cgi?id=191463
+
+        Reviewed by Sergio Villar Senin.
+
+        Avoid table sizing peculiarities for grid items. Let the grid render algorithm determine
+        the size of tables that are grid items. Don't let the intrinsic width of table columns
+        affect the width of the item. This change only deals with widths.
+
+        This is an import of Chromium changes at
+        https://chromium-review.googlesource.com/c/chromium/src/+/781859/
+        This issue seems only affect grid-items and not flexbox any more hence only changes from
+        grid are imported.
+
+        Test for this change has already been imported from WPT
+
+        * rendering/RenderTable.cpp:
+        (WebCore::RenderTable::updateLogicalWidth):
+
 2021-02-03  Rob Buis  <rbuis@igalia.com>
 

trunk/Source/WebCore/rendering/RenderTable.cpp

@@ -238 +238 @@
 {
     recalcSectionsIfNeeded();
+
+    if (isGridItem()) {
+        // FIXME: Investigate whether the grid layout algorithm provides all the logic
+        // needed and that we're not skipping anything essential due to the early return here.
+        RenderBlock::updateLogicalWidth();
+        return;
+    }
 
     if (isOutOfFlowPositioned()) {