Changeset 272434 in webkit


Ignore:
Timestamp:
Feb 5, 2021 12:27:19 PM (18 months ago)
Author:
youenn@apple.com
Message:

Enable audio capture for speech recognition in GPUProcess
​https://bugs.webkit.org/show_bug.cgi?id=221457

Reviewed by Eric Carlson.

Source/WebCore:

Add fake deviceId to play nice with capture ASSERTs.
Covered by updated tests.

  • Modules/speech/SpeechRecognitionCaptureSource.cpp:

(WebCore::SpeechRecognitionCaptureSource::createRealtimeMediaSource):

Source/WebKit:

Allow to create remote sources without any constraint.
To do so, we serialize through IPC a MediaConstraints with isValid = false and treat it as no constraint in capture process.

Make sure to send sandbox extensions and authorizations for GPUProcess to capture in case of speech recognition audio capture request.

In case of GPUProcess audio capture, send the request to capture to WebProcess like done for iOS.
WebProcess is then responsible to get audio samples from GPUProcess and forward them to UIProcess.
A future refactoring should move speech recognition to GPUProcess.

  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::grantRequest):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createRealtimeMediaSourceForSpeechRecognition):

  • WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp:

(WebKit::SpeechRecognitionRealtimeMediaSourceManager::grantSandboxExtensions):
(WebKit::SpeechRecognitionRealtimeMediaSourceManager::createSource):

  • WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:

(WebKit::RemoteRealtimeMediaSource::create):
(WebKit::RemoteRealtimeMediaSource::RemoteRealtimeMediaSource):
(WebKit::RemoteRealtimeMediaSource::createRemoteMediaSource):
(WebKit::RemoteRealtimeMediaSource::~RemoteRealtimeMediaSource):
(WebKit::RemoteRealtimeMediaSource::cloneVideoSource):
(WebKit::RemoteRealtimeMediaSource::gpuProcessConnectionDidClose):

  • WebProcess/cocoa/RemoteRealtimeMediaSource.h:
  • WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::AudioFactory::createAudioCaptureSource):
(WebKit::UserMediaCaptureManager::VideoFactory::createVideoCaptureSource):
(WebKit::UserMediaCaptureManager::DisplayFactory::createDisplayCaptureSource):

LayoutTests:

  • fast/speechrecognition/ios/restart-recognition-after-stop.html:
  • fast/speechrecognition/ios/start-recognition-then-stop.html:
  • fast/speechrecognition/start-recognition-then-stop.html:
  • fast/speechrecognition/start-second-recognition.html:
Location:
trunk
Files:
15 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r272433 r272434  
     12021-02-05  Youenn Fablet  <youenn@apple.com>
     2
     3        Enable audio capture for speech recognition in GPUProcess
     4        https://bugs.webkit.org/show_bug.cgi?id=221457
     5
     6        Reviewed by Eric Carlson.
     7
     8        * fast/speechrecognition/ios/restart-recognition-after-stop.html:
     9        * fast/speechrecognition/ios/start-recognition-then-stop.html:
     10        * fast/speechrecognition/start-recognition-then-stop.html:
     11        * fast/speechrecognition/start-second-recognition.html:
     12
    1132021-02-05  Patrick Angle  <pangle@apple.com>
    214

  • trunk/LayoutTests/fast/speechrecognition/ios/restart-recognition-after-stop.html

    r272304 r272434  
    1 <!DOCTYPE html><!-- webkit-test-runner [ CaptureAudioInGPUProcessEnabled=false ] -->
     1<!DOCTYPE html>
    22<html>
    33<body>

  • trunk/LayoutTests/fast/speechrecognition/ios/start-recognition-then-stop.html

    r272304 r272434  
    1 <!DOCTYPE html><!-- webkit-test-runner [ CaptureAudioInGPUProcessEnabled=false ] -->
     1<!DOCTYPE html>
    22<html>
    33<body>

  • trunk/LayoutTests/fast/speechrecognition/start-recognition-then-stop.html

    r272053 r272434  
    1 <!DOCTYPE html><!-- webkit-test-runner [ CaptureAudioInGPUProcessEnabled=false ] -->
     1<!DOCTYPE html>
    22<html>
    33<body>

  • trunk/LayoutTests/fast/speechrecognition/start-second-recognition.html

    r272053 r272434  
    1 <!DOCTYPE html><!-- webkit-test-runner [ CaptureAudioInGPUProcessEnabled=false ] -->
     1<!DOCTYPE html>
    22<html>
    33<body>

  • trunk/Source/WebCore/ChangeLog

    r272433 r272434  
     12021-02-05  Youenn Fablet  <youenn@apple.com>
     2
     3        Enable audio capture for speech recognition in GPUProcess
     4        https://bugs.webkit.org/show_bug.cgi?id=221457
     5
     6        Reviewed by Eric Carlson.
     7
     8        Add fake deviceId to play nice with capture ASSERTs.
     9        Covered by updated tests.
     10
     11        * Modules/speech/SpeechRecognitionCaptureSource.cpp:
     12        (WebCore::SpeechRecognitionCaptureSource::createRealtimeMediaSource):
     13
    1142021-02-05  Patrick Angle  <pangle@apple.com>
    215

  • trunk/Source/WebCore/Modules/speech/SpeechRecognitionCaptureSource.cpp

    r271154 r272434  
    6565CaptureSourceOrError SpeechRecognitionCaptureSource::createRealtimeMediaSource(const CaptureDevice& captureDevice)
    6666{
    67     return RealtimeMediaSourceCenter::singleton().audioCaptureFactory().createAudioCaptureSource(captureDevice, { }, { });
     67    return RealtimeMediaSourceCenter::singleton().audioCaptureFactory().createAudioCaptureSource(captureDevice, "SpeechID"_s, { });
    6868}
    6969

  • trunk/Source/WebKit/ChangeLog

    r272425 r272434  
     12021-02-05  Youenn Fablet  <youenn@apple.com>
     2
     3        Enable audio capture for speech recognition in GPUProcess
     4        https://bugs.webkit.org/show_bug.cgi?id=221457
     5
     6        Reviewed by Eric Carlson.
     7
     8        Allow to create remote sources without any constraint.
     9        To do so, we serialize through IPC a MediaConstraints with isValid = false and treat it as no constraint in capture process.
     10
     11        Make sure to send sandbox extensions and authorizations for GPUProcess to capture in case of speech recognition audio capture request.
     12
     13        In case of GPUProcess audio capture, send the request to capture to WebProcess like done for iOS.
     14        WebProcess is then responsible to get audio samples from GPUProcess and forward them to UIProcess.
     15        A future refactoring should move speech recognition to GPUProcess.
     16
     17        * UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
     18        (WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):
     19        * UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
     20        (WebKit::UserMediaPermissionRequestManagerProxy::grantRequest):
     21        * UIProcess/WebPageProxy.cpp:
     22        (WebKit::WebPageProxy::createRealtimeMediaSourceForSpeechRecognition):
     23        * WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp:
     24        (WebKit::SpeechRecognitionRealtimeMediaSourceManager::grantSandboxExtensions):
     25        (WebKit::SpeechRecognitionRealtimeMediaSourceManager::createSource):
     26        * WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:
     27        (WebKit::RemoteRealtimeMediaSource::create):
     28        (WebKit::RemoteRealtimeMediaSource::RemoteRealtimeMediaSource):
     29        (WebKit::RemoteRealtimeMediaSource::createRemoteMediaSource):
     30        (WebKit::RemoteRealtimeMediaSource::~RemoteRealtimeMediaSource):
     31        (WebKit::RemoteRealtimeMediaSource::cloneVideoSource):
     32        (WebKit::RemoteRealtimeMediaSource::gpuProcessConnectionDidClose):
     33        * WebProcess/cocoa/RemoteRealtimeMediaSource.h:
     34        * WebProcess/cocoa/UserMediaCaptureManager.cpp:
     35        (WebKit::UserMediaCaptureManager::AudioFactory::createAudioCaptureSource):
     36        (WebKit::UserMediaCaptureManager::VideoFactory::createVideoCaptureSource):
     37        (WebKit::UserMediaCaptureManager::DisplayFactory::createDisplayCaptureSource):
     38
    1392021-02-05  Kate Cheney  <katherine_cheney@apple.com>
    240

  • trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp

    r270961 r272434  
    239239}
    240240
    241 void UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints(RealtimeMediaSourceIdentifier id, const CaptureDevice& device, String&& hashSalt, const MediaConstraints& constraints, CompletionHandler<void(bool succeeded, String invalidConstraints, WebCore::RealtimeMediaSourceSettings&&, WebCore::RealtimeMediaSourceCapabilities&&)>&& completionHandler)
     241void UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints(RealtimeMediaSourceIdentifier id, const CaptureDevice& device, String&& hashSalt, const MediaConstraints& mediaConstraints, CompletionHandler<void(bool succeeded, String invalidConstraints, WebCore::RealtimeMediaSourceSettings&&, WebCore::RealtimeMediaSourceCapabilities&&)>&& completionHandler)
    242242{
    243243    if (!m_connectionProxy->willStartCapture(device.type()))
    244244        return completionHandler(false, "Request is not allowed"_s, RealtimeMediaSourceSettings { }, { });
     245
     246    auto* constraints = mediaConstraints.isValid ? &mediaConstraints : nullptr;
    245247
    246248    CaptureSourceOrError sourceOrError;
    247249    switch (device.type()) {
    248250    case WebCore::CaptureDevice::DeviceType::Microphone:
    249         sourceOrError = RealtimeMediaSourceCenter::singleton().audioCaptureFactory().createAudioCaptureSource(device, WTFMove(hashSalt), &constraints);
     251        sourceOrError = RealtimeMediaSourceCenter::singleton().audioCaptureFactory().createAudioCaptureSource(device, WTFMove(hashSalt), constraints);
    250252        break;
    251253    case WebCore::CaptureDevice::DeviceType::Camera:
    252         sourceOrError = RealtimeMediaSourceCenter::singleton().videoCaptureFactory().createVideoCaptureSource(device, WTFMove(hashSalt), &constraints);
     254        sourceOrError = RealtimeMediaSourceCenter::singleton().videoCaptureFactory().createVideoCaptureSource(device, WTFMove(hashSalt), constraints);
    253255        if (sourceOrError)
    254256            sourceOrError.captureSource->monitorOrientation(m_orientationNotifier);
    … …  
    256258    case WebCore::CaptureDevice::DeviceType::Screen:
    257259    case WebCore::CaptureDevice::DeviceType::Window:
    258         sourceOrError = RealtimeMediaSourceCenter::singleton().displayCaptureFactory().createDisplayCaptureSource(device, &constraints);
     260        sourceOrError = RealtimeMediaSourceCenter::singleton().displayCaptureFactory().createDisplayCaptureSource(device, constraints);
    259261        break;
    260262    case WebCore::CaptureDevice::DeviceType::Speaker:

  • trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp

    r272165 r272434  
    241241
    242242    if (auto callback = request.decisionCompletionHandler()) {
     243        m_page.willStartCapture(request, [callback = WTFMove(callback)]() mutable {
     244            callback(true);
     245        });
    243246        m_grantedRequests.append(makeRef(request));
    244         callback(true);
    245247        return;
    246248    }

  • trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

    r272417 r272434  
    1044210442WebCore::CaptureSourceOrError WebPageProxy::createRealtimeMediaSourceForSpeechRecognition()
    1044310443{
    10444     if (preferences().captureAudioInGPUProcessEnabled())
    10445         return CaptureSourceOrError { "Not implemented for GPU process" };
    10446 
    1044710444    auto captureDevice = SpeechRecognitionCaptureSource::findCaptureDevice();
    1044810445    if (!captureDevice)
    1044910446        return CaptureSourceOrError { "No device is available for capture" };
     10447
     10448    if (preferences().captureAudioInGPUProcessEnabled())
     10449        return CaptureSourceOrError { SpeechRecognitionRemoteRealtimeMediaSource::create(m_process->ensureSpeechRecognitionRemoteRealtimeMediaSourceManager(), *captureDevice) };
    1045010450
    1045110451#if PLATFORM(IOS_FAMILY)

  • trunk/Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp

    r272408 r272434  
    183183    m_sandboxExtensionForTCCD = SandboxExtension::create(WTFMove(sandboxHandleForTCCD));
    184184    if (!m_sandboxExtensionForTCCD)
    185         LOG_ERROR("Failed to create sandbox extension for tccd");
     185        RELEASE_LOG_ERROR(Media, "Failed to create sandbox extension for tccd");
    186186    else
    187187        m_sandboxExtensionForTCCD->consume();
    … …  
    189189    m_sandboxExtensionForMicrophone = SandboxExtension::create(WTFMove(sandboxHandleForMicrophone));
    190190    if (!m_sandboxExtensionForMicrophone)
    191         LOG_ERROR("Failed to create sandbox extension for microphone");
     191        RELEASE_LOG_ERROR(Media, "Failed to create sandbox extension for microphone");
    192192    else
    193193        m_sandboxExtensionForMicrophone->consume();
    … …  
    213213    auto result = SpeechRecognitionCaptureSource::createRealtimeMediaSource(device);
    214214    if (!result) {
    215         LOG_ERROR("Failed to create realtime source");
     215        RELEASE_LOG_ERROR(Media, "Failed to create realtime source");
    216216        send(Messages::SpeechRecognitionRemoteRealtimeMediaSourceManager::RemoteCaptureFailed(identifier), 0);
    217217        return;

  • trunk/Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp

    r272381 r272434  
    4747using namespace WebCore;
    4848
    49 Ref<RealtimeMediaSource> RemoteRealtimeMediaSource::create(const CaptureDevice& device, const MediaConstraints& constraints, String&& name, String&& hashSalt, UserMediaCaptureManager& manager, bool shouldCaptureInGPUProcess)
    50 {
    51     auto source = adoptRef(*new RemoteRealtimeMediaSource(RealtimeMediaSourceIdentifier::generate(), device.type(), WTFMove(name), WTFMove(hashSalt), manager, shouldCaptureInGPUProcess));
     49Ref<RealtimeMediaSource> RemoteRealtimeMediaSource::create(const CaptureDevice& device, const MediaConstraints* constraints, String&& name, String&& hashSalt, UserMediaCaptureManager& manager, bool shouldCaptureInGPUProcess)
     50{
     51    auto source = adoptRef(*new RemoteRealtimeMediaSource(RealtimeMediaSourceIdentifier::generate(), device, constraints, WTFMove(name), WTFMove(hashSalt), manager, shouldCaptureInGPUProcess));
    5252    manager.addSource(source.copyRef());
    53     source->createRemoteMediaSource(device, constraints);
     53    source->createRemoteMediaSource();
    5454    return source;
    5555}
    … …  
    7171}
    7272
    73 RemoteRealtimeMediaSource::RemoteRealtimeMediaSource(RealtimeMediaSourceIdentifier identifier, CaptureDevice::DeviceType deviceType, String&& name, String&& hashSalt, UserMediaCaptureManager& manager, bool shouldCaptureInGPUProcess)
    74     : RealtimeMediaSource(sourceTypeFromDeviceType(deviceType), WTFMove(name), String::number(identifier.toUInt64()), WTFMove(hashSalt))
     73RemoteRealtimeMediaSource::RemoteRealtimeMediaSource(RealtimeMediaSourceIdentifier identifier, const CaptureDevice& device, const MediaConstraints* constraints, String&& name, String&& hashSalt, UserMediaCaptureManager& manager, bool shouldCaptureInGPUProcess)
     74    : RealtimeMediaSource(sourceTypeFromDeviceType(device.type()), WTFMove(name), String::number(identifier.toUInt64()), WTFMove(hashSalt))
    7575    , m_identifier(identifier)
    7676    , m_manager(manager)
    77     , m_deviceType(deviceType)
     77    , m_device(device)
    7878    , m_shouldCaptureInGPUProcess(shouldCaptureInGPUProcess)
    7979{
    80     switch (m_deviceType) {
     80    if (constraints)
     81        m_constraints = *constraints;
     82
     83    switch (m_device.type()) {
    8184    case CaptureDevice::DeviceType::Microphone:
    8285#if PLATFORM(IOS_FAMILY)
    … …  
    98101}
    99102
    100 void RemoteRealtimeMediaSource::createRemoteMediaSource(const CaptureDevice& device, const MediaConstraints& constraints)
    101 {
    102     if (m_shouldCaptureInGPUProcess) {
    103         m_device = device;
    104         m_constraints = constraints;
    105     }
    106 
    107     connection()->sendWithAsyncReply(Messages::UserMediaCaptureManagerProxy::CreateMediaSourceForCaptureDeviceWithConstraints(identifier(), device, deviceIDHashSalt(), constraints), [this, protectedThis = makeRef(*this)](bool succeeded, auto&& errorMessage, auto&& settings, auto&& capabilities) {
     103void RemoteRealtimeMediaSource::createRemoteMediaSource()
     104{
     105    connection()->sendWithAsyncReply(Messages::UserMediaCaptureManagerProxy::CreateMediaSourceForCaptureDeviceWithConstraints(identifier(), m_device, deviceIDHashSalt(), m_constraints), [this, protectedThis = makeRef(*this)](bool succeeded, auto&& errorMessage, auto&& settings, auto&& capabilities) {
    108106        if (!succeeded) {
    109107            didFail(WTFMove(errorMessage));
    … …  
    124122        WebProcess::singleton().ensureGPUProcessConnection().removeClient(*this);
    125123
    126     switch (m_deviceType) {
     124    switch (m_device.type()) {
    127125    case CaptureDevice::DeviceType::Microphone:
    128126#if PLATFORM(IOS_FAMILY)
    … …  
    185183        return *this;
    186184
    187     auto cloneSource = adoptRef(*new RemoteRealtimeMediaSource(identifier, deviceType(), String { m_settings.label().string() }, deviceIDHashSalt(), m_manager, m_shouldCaptureInGPUProcess));
     185    auto cloneSource = adoptRef(*new RemoteRealtimeMediaSource(identifier, m_device, &m_constraints, String { m_settings.label().string() }, deviceIDHashSalt(), m_manager, m_shouldCaptureInGPUProcess));
    188186    cloneSource->setSettings(RealtimeMediaSourceSettings { m_settings });
    189187    m_manager.addSource(cloneSource.copyRef());
    … …  
    330328
    331329    m_manager.didUpdateSourceConnection(*this);
    332     createRemoteMediaSource(m_device, m_constraints);
     330    createRemoteMediaSource();
    333331    // FIXME: We should update the track according current settings.
    334332    if (isProducingData())

  • trunk/Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.h

    r272381 r272434  
    5555{
    5656public:
    57     static Ref<WebCore::RealtimeMediaSource> create(const WebCore::CaptureDevice&, const WebCore::MediaConstraints&, String&& name, String&& hashSalt, UserMediaCaptureManager&, bool shouldCaptureInGPUProcess);
     57    static Ref<WebCore::RealtimeMediaSource> create(const WebCore::CaptureDevice&, const WebCore::MediaConstraints*, String&& name, String&& hashSalt, UserMediaCaptureManager&, bool shouldCaptureInGPUProcess);
    5858    ~RemoteRealtimeMediaSource();
    5959
    … …  
    7373
    7474private:
    75     RemoteRealtimeMediaSource(WebCore::RealtimeMediaSourceIdentifier, WebCore::CaptureDevice::DeviceType, String&& name, String&& hashSalt, UserMediaCaptureManager&, bool shouldCaptureInGPUProcess);
     75    RemoteRealtimeMediaSource(WebCore::RealtimeMediaSourceIdentifier, const WebCore::CaptureDevice&, const WebCore::MediaConstraints*, String&& name, String&& hashSalt, UserMediaCaptureManager&, bool shouldCaptureInGPUProcess);
    7676
    7777    // RealtimeMediaSource
    … …  
    8989    const WebCore::RealtimeMediaSourceCapabilities& capabilities() final;
    9090    void whenReady(CompletionHandler<void(String)>&&) final;
    91     WebCore::CaptureDevice::DeviceType deviceType() const final { return m_deviceType; }
     91    WebCore::CaptureDevice::DeviceType deviceType() const final { return m_device.type(); }
    9292    Ref<RealtimeMediaSource> clone() final;
    9393
    … …  
    9797#endif
    9898
    99     void createRemoteMediaSource(const WebCore::CaptureDevice&, const WebCore::MediaConstraints&);
     99    void createRemoteMediaSource();
    100100    void didFail(String&& errorMessage);
    101101    void setAsReady();
    … …  
    108108    WebCore::RealtimeMediaSourceSettings m_settings;
    109109
     110    WebCore::CaptureDevice m_device;
     111    WebCore::MediaConstraints m_constraints;
     112
    110113    std::unique_ptr<WebCore::ImageTransferSessionVT> m_imageTransferSession;
    111     WebCore::CaptureDevice::DeviceType m_deviceType { WebCore::CaptureDevice::DeviceType::Unknown };
    112114
    113115    Deque<ApplyConstraintsHandler> m_pendingApplyConstraintsCallbacks;
    … …  
    117119    String m_errorMessage;
    118120    CompletionHandler<void(String)> m_callback;
    119     WebCore::CaptureDevice m_device;
    120     WebCore::MediaConstraints m_constraints;
    121121};
    122122

  • trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp

    r272205 r272434  
    145145CaptureSourceOrError UserMediaCaptureManager::AudioFactory::createAudioCaptureSource(const CaptureDevice& device, String&& hashSalt, const MediaConstraints* constraints)
    146146{
    147     if (!constraints)
    148         return { };
    149 
    150147#if !ENABLE(GPU_PROCESS)
    151148    if (m_shouldCaptureInGPUProcess)
    … …  
    159156#endif
    160157
    161     return RemoteRealtimeMediaSource::create(device, *constraints, { }, WTFMove(hashSalt), m_manager, m_shouldCaptureInGPUProcess);
     158    return RemoteRealtimeMediaSource::create(device, constraints, { }, WTFMove(hashSalt), m_manager, m_shouldCaptureInGPUProcess);
    162159}
    163160
    … …  
    169166CaptureSourceOrError UserMediaCaptureManager::VideoFactory::createVideoCaptureSource(const CaptureDevice& device, String&& hashSalt, const MediaConstraints* constraints)
    170167{
    171     if (!constraints)
    172         return { };
    173 
    174168#if !ENABLE(GPU_PROCESS)
    175169    if (m_shouldCaptureInGPUProcess)
    … …  
    177171#endif
    178172
    179     return RemoteRealtimeMediaSource::create(device, *constraints, { }, WTFMove(hashSalt), m_manager, m_shouldCaptureInGPUProcess);
     173    return RemoteRealtimeMediaSource::create(device, constraints, { }, WTFMove(hashSalt), m_manager, m_shouldCaptureInGPUProcess);
    180174}
    181175
    … …  
    189183CaptureSourceOrError UserMediaCaptureManager::DisplayFactory::createDisplayCaptureSource(const CaptureDevice& device, const MediaConstraints* constraints)
    190184{
    191     if (!constraints)
    192         return { };
    193 
    194     return RemoteRealtimeMediaSource::create(device, *constraints, { }, { }, m_manager, false);
     185    return RemoteRealtimeMediaSource::create(device, constraints, { }, { }, m_manager, false);
    195186}
    196187
Note: See TracChangeset for help on using the changeset viewer.