Changeset 272589 in webkit

Timestamp:

Feb 9, 2021 10:33:24 AM (18 months ago)

Author:

eric.carlson@apple.com

Message:

[Mac] Connect MediaSession with MediaRemote and NowPlaying
​https://bugs.webkit.org/show_bug.cgi?id=221431
<rdar://problem/74000363>

Unreviewed, fix a layout test assert.

• Modules/mediasession/MediaSession.cpp:

(WebCore::platformCommandForMediaSessionAction): Map "skipad" to "nexttrack".
(WebCore::MediaSession::setActionHandler): Don't try to register media session actions
for which there is no platform command.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediasession/MediaSession.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-09  Eric Carlson  <eric.carlson@apple.com>
+
+        [Mac] Connect MediaSession with MediaRemote and NowPlaying
+        https://bugs.webkit.org/show_bug.cgi?id=221431
+        <rdar://problem/74000363>
+
+        Unreviewed, fix a layout test assert.
+
+        * Modules/mediasession/MediaSession.cpp:
+        (WebCore::platformCommandForMediaSessionAction): Map "skipad" to "nexttrack".
+        (WebCore::MediaSession::setActionHandler): Don't try to register media session actions
+        for which there is no platform command.
+
 2021-02-09  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp

@@ -59 +59 @@
             { MediaSessionAction::Stop, PlatformMediaSession::StopCommand },
             { MediaSessionAction::Seekto, PlatformMediaSession::SeekToPlaybackPositionCommand },
+            { MediaSessionAction::Skipad, PlatformMediaSession::NextTrackCommand },
         };
     }());
@@ -117 +118 @@
         ALWAYS_LOG(LOGIDENTIFIER, "adding ", action);
         m_actionHandlers.set(action, handler);
-        PlatformMediaSessionManager::sharedManager().addSupportedCommand(platformCommandForMediaSessionAction(action));
+        auto platformCommand = platformCommandForMediaSessionAction(action);
+        if (platformCommand != PlatformMediaSession::NoCommand)
+            PlatformMediaSessionManager::sharedManager().addSupportedCommand(platformCommand);
     } else {
         if (m_actionHandlers.contains(action)) {