Changeset 272829 in webkit

Timestamp:

Feb 12, 2021 8:36:29 PM (17 months ago)

Author:

jer.noble@apple.com

Message:

[Mac] Sound does not play on YouTube after switching back to foreground
​https://bugs.webkit.org/show_bug.cgi?id=221858
<rdar://70602677>

Reviewed by Eric Carlson.

Source/WebCore:

Test: platform/mac/media/unmute-after-loading.html

Remove a stray, unnecessary reset of a cached muted state which kept mute
state from being changed the first time after loading.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):

• testing/Internals.cpp:

(WebCore::Internals::privatePlayerMuted):

• testing/Internals.h:
• testing/Internals.idl:
• testing/Internals.mm:

(WebCore::Internals::privatePlayerMuted):

LayoutTests:

• platform/mac/media/unmute-after-loading-expected.txt: Added.
• platform/mac/media/unmute-after-loading.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/media/unmute-after-loading-expected.txt (added)
• LayoutTests/platform/mac/media/unmute-after-loading.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (modified) (1 diff)
• Source/WebCore/testing/Internals.cpp (modified) (1 diff)
• Source/WebCore/testing/Internals.h (modified) (1 diff)
• Source/WebCore/testing/Internals.idl (modified) (1 diff)
• Source/WebCore/testing/Internals.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-02-12  Jer Noble  <jer.noble@apple.com>
+
+        [Mac] Sound does not play on YouTube after switching back to foreground
+        https://bugs.webkit.org/show_bug.cgi?id=221858
+        <rdar://70602677>
+
+        Reviewed by Eric Carlson.
+
+        * platform/mac/media/unmute-after-loading-expected.txt: Added.
+        * platform/mac/media/unmute-after-loading.html: Added.
+
 2021-02-12  Chris Gambrell  <cgambrell@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-12  Jer Noble  <jer.noble@apple.com>
+
+        [Mac] Sound does not play on YouTube after switching back to foreground
+        https://bugs.webkit.org/show_bug.cgi?id=221858
+        <rdar://70602677>
+
+        Reviewed by Eric Carlson.
+
+        Test: platform/mac/media/unmute-after-loading.html
+
+        Remove a stray, unnecessary reset of a cached muted state which kept mute
+        state from being changed the first time after loading.
+
+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
+        * testing/Internals.cpp:
+        (WebCore::Internals::privatePlayerMuted):
+        * testing/Internals.h:
+        * testing/Internals.idl:
+        * testing/Internals.mm:
+        (WebCore::Internals::privatePlayerMuted):
+
 2021-02-12  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

@@ -1008 +1008 @@
 
     if (m_muted) {
-        // Clear m_muted so setMuted doesn't return without doing anything.
-        m_muted = false;
         [m_avPlayer.get() setMuted:m_muted];
 

trunk/Source/WebCore/testing/Internals.cpp

@@ -4890 +4890 @@
     return 0;
 }
+
+bool Internals::privatePlayerMuted(const HTMLMediaElement&)
+{
+    return false;
+}
 #endif
 

trunk/Source/WebCore/testing/Internals.h

@@ -632 +632 @@
     String elementBufferingPolicy(HTMLMediaElement&);
     double privatePlayerVolume(const HTMLMediaElement&);
+    bool privatePlayerMuted(const HTMLMediaElement&);
     ExceptionOr<void> setOverridePreferredDynamicRangeMode(HTMLMediaElement&, const String&);
 #endif

trunk/Source/WebCore/testing/Internals.idl

@@ -653 +653 @@
     [Conditional=VIDEO] DOMString elementBufferingPolicy(HTMLMediaElement media);
     [Conditional=VIDEO] double privatePlayerVolume(HTMLMediaElement media);
+    [Conditional=VIDEO] boolean privatePlayerMuted(HTMLMediaElement media);
     [Conditional=VIDEO, MayThrowException] undefined setOverridePreferredDynamicRangeMode(HTMLMediaElement media, DOMString mode);
 

trunk/Source/WebCore/testing/Internals.mm

@@ -104 +104 @@
     return [player volume];
 }
+
+bool Internals::privatePlayerMuted(const HTMLMediaElement& element)
+{
+    auto corePlayer = element.player();
+    if (!corePlayer)
+        return false;
+    auto player = corePlayer->objCAVFoundationAVPlayer();
+    if (!player)
+        return false;
+    return [player isMuted];
+}
 #endif