Changeset 273328 in webkit


Ignore:
Timestamp:
Feb 23, 2021 12:04:05 PM (17 months ago)
Author:
Chris Fleizach
Message:

AX: VoiceOver incorrectly announces groups in ARIA tree instances as empty
​https://bugs.webkit.org/show_bug.cgi?id=221716
<rdar://problem/74205567>

Reviewed by Zalan Bujtas.

Source/WebCore:

ARIA treeitems are allowed to have a child group that can represent the disclosed rows, which are disclosed through aria-owns.

Test: accessibility/mac/treeitem-row-delegation.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::ariaTreeRows):

LayoutTests:

  • accessibility/mac/treeitem-row-delegation-expected.txt: Added.
  • accessibility/mac/treeitem-row-delegation.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r273318 r273328  
     12021-02-23  Chris Fleizach  <cfleizach@apple.com>
     2
     3        AX: VoiceOver incorrectly announces groups in ARIA tree instances as empty
     4        https://bugs.webkit.org/show_bug.cgi?id=221716
     5        <rdar://problem/74205567>
     6
     7        Reviewed by Zalan Bujtas.
     8
     9        * accessibility/mac/treeitem-row-delegation-expected.txt: Added.
     10        * accessibility/mac/treeitem-row-delegation.html: Added.
     11
    1122021-02-22  Ryan Haddad  <ryanhaddad@apple.com>
    213

  • trunk/Source/WebCore/ChangeLog

    r273314 r273328  
     12021-02-23  Chris Fleizach  <cfleizach@apple.com>
     2
     3        AX: VoiceOver incorrectly announces groups in ARIA tree instances as empty
     4        https://bugs.webkit.org/show_bug.cgi?id=221716
     5        <rdar://problem/74205567>
     6
     7        Reviewed by Zalan Bujtas.
     8
     9        ARIA treeitems are allowed to have a child group that can represent the disclosed rows, which are disclosed through aria-owns.
     10
     11        Test: accessibility/mac/treeitem-row-delegation.html
     12
     13        * accessibility/AccessibilityObject.cpp:
     14        (WebCore::AccessibilityObject::ariaTreeRows):
     15
    1162021-02-23  Rob Buis  <rbuis@igalia.com>
    217

  • trunk/Source/WebCore/accessibility/AccessibilityObject.cpp

    r273214 r273328  
    16951695void AccessibilityObject::ariaTreeRows(AccessibilityChildrenVector& result)
    16961696{
     1697    // If the element specifies its tree rows through aria-owns, return that first.
     1698    AccessibilityChildrenVector ariaOwns;
     1699    ariaOwnsElements(ariaOwns);
     1700    if (ariaOwns.size()) {
     1701        result.appendVector(ariaOwns);
     1702        return;
     1703    }
     1704   
    16971705    for (const auto& child : children()) {
    16981706        // Add tree items as the rows.
Note: See TracChangeset for help on using the changeset viewer.