Changeset 273478 in webkit

Timestamp:

Feb 25, 2021 12:31:26 AM (17 months ago)

Author:

graouts@webkit.org

Message:

border-image-outset doesn't handle float values
​https://bugs.webkit.org/show_bug.cgi?id=222389

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Pass an extra 28 WPT tests for border-image-outset.

• web-platform-tests/css/css-backgrounds/animations/border-image-outset-interpolation-expected.txt:

Source/WebCore:

We would get the int values rather than float values for the CSSValue created while parsing
the border-image-outset property.

• css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapNinePieceImageQuad):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/border-image-outset-interpolation-expected.txt (modified) (3 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSToStyleMap.cpp (modified) (4 diffs)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2021-02-25  Antoine Quint  <graouts@webkit.org>
+
+        border-image-outset doesn't handle float values
+        https://bugs.webkit.org/show_bug.cgi?id=222389
+
+        Reviewed by Antti Koivisto.
+
+        Pass an extra 28 WPT tests for border-image-outset.
+
+        * web-platform-tests/css/css-backgrounds/animations/border-image-outset-interpolation-expected.txt:
+
 2021-02-24  Imanol Fernandez  <ifernandez@igalia.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/border-image-outset-interpolation-expected.txt

@@ -26 +26 @@
 FAIL CSS Transitions: property <border-image-outset> from [initial] to [2] at (-0.3) should be [0] assert_equals: expected "0 " but got "- 0.6 "
 PASS CSS Transitions: property <border-image-outset> from [initial] to [2] at (0) should be [0]
-FAIL CSS Transitions: property <border-image-outset> from [initial] to [2] at (0.3) should be [0.6] assert_equals: expected "0 " but got "0.6 "
-FAIL CSS Transitions: property <border-image-outset> from [initial] to [2] at (0.6) should be [1.2] assert_equals: expected "1 " but got "1.2 "
+PASS CSS Transitions: property <border-image-outset> from [initial] to [2] at (0.3) should be [0.6]
+PASS CSS Transitions: property <border-image-outset> from [initial] to [2] at (0.6) should be [1.2]
 PASS CSS Transitions: property <border-image-outset> from [initial] to [2] at (1) should be [2]
 PASS CSS Transitions: property <border-image-outset> from [initial] to [2] at (1.5) should be [3]
 FAIL CSS Transitions with transition: all: property <border-image-outset> from [initial] to [2] at (-0.3) should be [0] assert_equals: expected "0 " but got "- 0.6 "
 PASS CSS Transitions with transition: all: property <border-image-outset> from [initial] to [2] at (0) should be [0]
-FAIL CSS Transitions with transition: all: property <border-image-outset> from [initial] to [2] at (0.3) should be [0.6] assert_equals: expected "0 " but got "0.6 "
-FAIL CSS Transitions with transition: all: property <border-image-outset> from [initial] to [2] at (0.6) should be [1.2] assert_equals: expected "1 " but got "1.2 "
+PASS CSS Transitions with transition: all: property <border-image-outset> from [initial] to [2] at (0.3) should be [0.6]
+PASS CSS Transitions with transition: all: property <border-image-outset> from [initial] to [2] at (0.6) should be [1.2]
 PASS CSS Transitions with transition: all: property <border-image-outset> from [initial] to [2] at (1) should be [2]
 PASS CSS Transitions with transition: all: property <border-image-outset> from [initial] to [2] at (1.5) should be [3]
 FAIL CSS Animations: property <border-image-outset> from [initial] to [2] at (-0.3) should be [0] assert_equals: expected "0 " but got "- 0.6 "
 PASS CSS Animations: property <border-image-outset> from [initial] to [2] at (0) should be [0]
-FAIL CSS Animations: property <border-image-outset> from [initial] to [2] at (0.3) should be [0.6] assert_equals: expected "0 " but got "0.6 "
-FAIL CSS Animations: property <border-image-outset> from [initial] to [2] at (0.6) should be [1.2] assert_equals: expected "1 " but got "1.2 "
+PASS CSS Animations: property <border-image-outset> from [initial] to [2] at (0.3) should be [0.6]
+PASS CSS Animations: property <border-image-outset> from [initial] to [2] at (0.6) should be [1.2]
 PASS CSS Animations: property <border-image-outset> from [initial] to [2] at (1) should be [2]
 PASS CSS Animations: property <border-image-outset> from [initial] to [2] at (1.5) should be [3]
 FAIL Web Animations: property <border-image-outset> from [initial] to [2] at (-0.3) should be [0] assert_equals: expected "0 " but got "- 0.6 "
 PASS Web Animations: property <border-image-outset> from [initial] to [2] at (0) should be [0]
-FAIL Web Animations: property <border-image-outset> from [initial] to [2] at (0.3) should be [0.6] assert_equals: expected "0 " but got "0.6 "
-FAIL Web Animations: property <border-image-outset> from [initial] to [2] at (0.6) should be [1.2] assert_equals: expected "1 " but got "1.2 "
+PASS Web Animations: property <border-image-outset> from [initial] to [2] at (0.3) should be [0.6]
+PASS Web Animations: property <border-image-outset> from [initial] to [2] at (0.6) should be [1.2]
 PASS Web Animations: property <border-image-outset> from [initial] to [2] at (1) should be [2]
 PASS Web Animations: property <border-image-outset> from [initial] to [2] at (1.5) should be [3]
@@ -74 +74 @@
 FAIL CSS Transitions: property <border-image-outset> from [unset] to [2] at (-0.3) should be [0] assert_equals: expected "0 " but got "- 0.6 "
 PASS CSS Transitions: property <border-image-outset> from [unset] to [2] at (0) should be [0]
-FAIL CSS Transitions: property <border-image-outset> from [unset] to [2] at (0.3) should be [0.6] assert_equals: expected "0 " but got "0.6 "
-FAIL CSS Transitions: property <border-image-outset> from [unset] to [2] at (0.6) should be [1.2] assert_equals: expected "1 " but got "1.2 "
+PASS CSS Transitions: property <border-image-outset> from [unset] to [2] at (0.3) should be [0.6]
+PASS CSS Transitions: property <border-image-outset> from [unset] to [2] at (0.6) should be [1.2]
 PASS CSS Transitions: property <border-image-outset> from [unset] to [2] at (1) should be [2]
 PASS CSS Transitions: property <border-image-outset> from [unset] to [2] at (1.5) should be [3]
 FAIL CSS Transitions with transition: all: property <border-image-outset> from [unset] to [2] at (-0.3) should be [0] assert_equals: expected "0 " but got "- 0.6 "
 PASS CSS Transitions with transition: all: property <border-image-outset> from [unset] to [2] at (0) should be [0]
-FAIL CSS Transitions with transition: all: property <border-image-outset> from [unset] to [2] at (0.3) should be [0.6] assert_equals: expected "0 " but got "0.6 "
-FAIL CSS Transitions with transition: all: property <border-image-outset> from [unset] to [2] at (0.6) should be [1.2] assert_equals: expected "1 " but got "1.2 "
+PASS CSS Transitions with transition: all: property <border-image-outset> from [unset] to [2] at (0.3) should be [0.6]
+PASS CSS Transitions with transition: all: property <border-image-outset> from [unset] to [2] at (0.6) should be [1.2]
 PASS CSS Transitions with transition: all: property <border-image-outset> from [unset] to [2] at (1) should be [2]
 PASS CSS Transitions with transition: all: property <border-image-outset> from [unset] to [2] at (1.5) should be [3]
 FAIL CSS Animations: property <border-image-outset> from [unset] to [2] at (-0.3) should be [0] assert_equals: expected "0 " but got "- 0.6 "
 PASS CSS Animations: property <border-image-outset> from [unset] to [2] at (0) should be [0]
-FAIL CSS Animations: property <border-image-outset> from [unset] to [2] at (0.3) should be [0.6] assert_equals: expected "0 " but got "0.6 "
-FAIL CSS Animations: property <border-image-outset> from [unset] to [2] at (0.6) should be [1.2] assert_equals: expected "1 " but got "1.2 "
+PASS CSS Animations: property <border-image-outset> from [unset] to [2] at (0.3) should be [0.6]
+PASS CSS Animations: property <border-image-outset> from [unset] to [2] at (0.6) should be [1.2]
 PASS CSS Animations: property <border-image-outset> from [unset] to [2] at (1) should be [2]
 PASS CSS Animations: property <border-image-outset> from [unset] to [2] at (1.5) should be [3]
 FAIL Web Animations: property <border-image-outset> from [unset] to [2] at (-0.3) should be [0] assert_equals: expected "0 " but got "- 0.6 "
 PASS Web Animations: property <border-image-outset> from [unset] to [2] at (0) should be [0]
-FAIL Web Animations: property <border-image-outset> from [unset] to [2] at (0.3) should be [0.6] assert_equals: expected "0 " but got "0.6 "
-FAIL Web Animations: property <border-image-outset> from [unset] to [2] at (0.6) should be [1.2] assert_equals: expected "1 " but got "1.2 "
+PASS Web Animations: property <border-image-outset> from [unset] to [2] at (0.3) should be [0.6]
+PASS Web Animations: property <border-image-outset> from [unset] to [2] at (0.6) should be [1.2]
 PASS Web Animations: property <border-image-outset> from [unset] to [2] at (1) should be [2]
 PASS Web Animations: property <border-image-outset> from [unset] to [2] at (1.5) should be [3]
@@ -122 +122 @@
 FAIL CSS Transitions: property <border-image-outset> from [0] to [1] at (-0.3) should be [0] assert_equals: expected "0 " but got "- 0.3 "
 PASS CSS Transitions: property <border-image-outset> from [0] to [1] at (0) should be [0]
-FAIL CSS Transitions: property <border-image-outset> from [0] to [1] at (0.3) should be [0.3] assert_equals: expected "0 " but got "0.3 "
-FAIL CSS Transitions: property <border-image-outset> from [0] to [1] at (0.6) should be [0.6] assert_equals: expected "0 " but got "0.6 "
+PASS CSS Transitions: property <border-image-outset> from [0] to [1] at (0.3) should be [0.3]
+PASS CSS Transitions: property <border-image-outset> from [0] to [1] at (0.6) should be [0.6]
 PASS CSS Transitions: property <border-image-outset> from [0] to [1] at (1) should be [1]
-FAIL CSS Transitions: property <border-image-outset> from [0] to [1] at (1.5) should be [1.5] assert_equals: expected "1 " but got "1.5 "
+PASS CSS Transitions: property <border-image-outset> from [0] to [1] at (1.5) should be [1.5]
 FAIL CSS Transitions with transition: all: property <border-image-outset> from [0] to [1] at (-0.3) should be [0] assert_equals: expected "0 " but got "- 0.3 "
 PASS CSS Transitions with transition: all: property <border-image-outset> from [0] to [1] at (0) should be [0]
-FAIL CSS Transitions with transition: all: property <border-image-outset> from [0] to [1] at (0.3) should be [0.3] assert_equals: expected "0 " but got "0.3 "
-FAIL CSS Transitions with transition: all: property <border-image-outset> from [0] to [1] at (0.6) should be [0.6] assert_equals: expected "0 " but got "0.6 "
+PASS CSS Transitions with transition: all: property <border-image-outset> from [0] to [1] at (0.3) should be [0.3]
+PASS CSS Transitions with transition: all: property <border-image-outset> from [0] to [1] at (0.6) should be [0.6]
 PASS CSS Transitions with transition: all: property <border-image-outset> from [0] to [1] at (1) should be [1]
-FAIL CSS Transitions with transition: all: property <border-image-outset> from [0] to [1] at (1.5) should be [1.5] assert_equals: expected "1 " but got "1.5 "
+PASS CSS Transitions with transition: all: property <border-image-outset> from [0] to [1] at (1.5) should be [1.5]
 FAIL CSS Animations: property <border-image-outset> from [0] to [1] at (-0.3) should be [0] assert_equals: expected "0 " but got "- 0.3 "
 PASS CSS Animations: property <border-image-outset> from [0] to [1] at (0) should be [0]
-FAIL CSS Animations: property <border-image-outset> from [0] to [1] at (0.3) should be [0.3] assert_equals: expected "0 " but got "0.3 "
-FAIL CSS Animations: property <border-image-outset> from [0] to [1] at (0.6) should be [0.6] assert_equals: expected "0 " but got "0.6 "
+PASS CSS Animations: property <border-image-outset> from [0] to [1] at (0.3) should be [0.3]
+PASS CSS Animations: property <border-image-outset> from [0] to [1] at (0.6) should be [0.6]
 PASS CSS Animations: property <border-image-outset> from [0] to [1] at (1) should be [1]
-FAIL CSS Animations: property <border-image-outset> from [0] to [1] at (1.5) should be [1.5] assert_equals: expected "1 " but got "1.5 "
+PASS CSS Animations: property <border-image-outset> from [0] to [1] at (1.5) should be [1.5]
 FAIL Web Animations: property <border-image-outset> from [0] to [1] at (-0.3) should be [0] assert_equals: expected "0 " but got "- 0.3 "
 PASS Web Animations: property <border-image-outset> from [0] to [1] at (0) should be [0]
-FAIL Web Animations: property <border-image-outset> from [0] to [1] at (0.3) should be [0.3] assert_equals: expected "0 " but got "0.3 "
-FAIL Web Animations: property <border-image-outset> from [0] to [1] at (0.6) should be [0.6] assert_equals: expected "0 " but got "0.6 "
+PASS Web Animations: property <border-image-outset> from [0] to [1] at (0.3) should be [0.3]
+PASS Web Animations: property <border-image-outset> from [0] to [1] at (0.6) should be [0.6]
 PASS Web Animations: property <border-image-outset> from [0] to [1] at (1) should be [1]
-FAIL Web Animations: property <border-image-outset> from [0] to [1] at (1.5) should be [1.5] assert_equals: expected "1 " but got "1.5 "
+PASS Web Animations: property <border-image-outset> from [0] to [1] at (1.5) should be [1.5]
 FAIL CSS Transitions: property <border-image-outset> from [1 2 3px 4px] to [101 102 103px 104px] at (-0.3) should be [0 0 0px 0px] assert_equals: expected "0 0 0px 0px " but got "- 29 - 28 - 27px - 26px "
 PASS CSS Transitions: property <border-image-outset> from [1 2 3px 4px] to [101 102 103px 104px] at (0) should be [1 2 3px 4px]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-25  Antoine Quint  <graouts@webkit.org>
+
+        border-image-outset doesn't handle float values
+        https://bugs.webkit.org/show_bug.cgi?id=222389
+
+        Reviewed by Antti Koivisto.
+
+        We would get the int values rather than float values for the CSSValue created while parsing
+        the border-image-outset property.
+
+        * css/CSSToStyleMap.cpp:
+        (WebCore::CSSToStyleMap::mapNinePieceImageQuad):
+
 2021-02-25  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/css/CSSToStyleMap.cpp

@@ -594 +594 @@
     Quad* slices = borderWidths.quadValue();
     if (slices->top()->isNumber())
-        box.top() = Length(slices->top()->intValue(), LengthType::Relative);
+        box.top() = Length(slices->top()->floatValue(), LengthType::Relative);
     else if (slices->top()->isPercentage())
         box.top() = Length(slices->top()->doubleValue(CSSUnitType::CSS_PERCENTAGE), LengthType::Percent);
@@ -601 +601 @@
 
     if (slices->right()->isNumber())
-        box.right() = Length(slices->right()->intValue(), LengthType::Relative);
+        box.right() = Length(slices->right()->floatValue(), LengthType::Relative);
     else if (slices->right()->isPercentage())
         box.right() = Length(slices->right()->doubleValue(CSSUnitType::CSS_PERCENTAGE), LengthType::Percent);
@@ -608 +608 @@
 
     if (slices->bottom()->isNumber())
-        box.bottom() = Length(slices->bottom()->intValue(), LengthType::Relative);
+        box.bottom() = Length(slices->bottom()->floatValue(), LengthType::Relative);
     else if (slices->bottom()->isPercentage())
         box.bottom() = Length(slices->bottom()->doubleValue(CSSUnitType::CSS_PERCENTAGE), LengthType::Percent);
@@ -615 +615 @@
 
     if (slices->left()->isNumber())
-        box.left() = Length(slices->left()->intValue(), LengthType::Relative);
+        box.left() = Length(slices->left()->floatValue(), LengthType::Relative);
     else if (slices->left()->isPercentage())
         box.left() = Length(slices->left()->doubleValue(CSSUnitType::CSS_PERCENTAGE), LengthType::Percent);