Changeset 273502 in webkit

Timestamp:

Feb 25, 2021 12:31:01 PM (17 months ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: List of grid nodes is incomplete in Layout sidebar panel
​https://bugs.webkit.org/show_bug.cgi?id=222364
<rdar://problem/74700960>

Patch by Razvan Caliman <Razvan Caliman> on 2021-02-25
Reviewed by Devin Rousso.

Source/JavaScriptCore:

Update inspector protocol description for CSS domain to mention default value for
layoutContextTypeChangedMode ("observed") and clarify behavior of "all" value.

• inspector/protocol/CSS.json:

Source/WebCore:

Ensure default value of layoutContextTypeChangedMode is set for InspectorCSSAgent
to recognize the mode change when switching monitor layout contexts of all nodes.

• inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::reset):

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/inspector/protocol/CSS.json (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/inspector/agents/InspectorCSSAgent.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-02-25  Razvan Caliman  <rcaliman@apple.com>
+
+        Web Inspector: List of grid nodes is incomplete in Layout sidebar panel
+        https://bugs.webkit.org/show_bug.cgi?id=222364
+        <rdar://problem/74700960>
+
+        Reviewed by Devin Rousso.
+
+        Update inspector protocol description for CSS domain to mention default value for
+        `layoutContextTypeChangedMode` ("observed") and clarify behavior of "all" value.
+
+        * inspector/protocol/CSS.json:
+
 2021-02-25  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/JavaScriptCore/inspector/protocol/CSS.json

@@ -264 +264 @@
             "type": "string",
             "enum": ["observed", "all"],
-            "description": "The mode for how layout context type changes are handled. <code>Observed</code> limits handling to those nodes already known to the frontend by other means (generally, this means the node is a visible item in the Elements tab). <code>All</code> informs the frontend of all layout context type changes and."
+            "description": "The mode for how layout context type changes are handled (default: <code>Observed</code>). <code>Observed</code> limits handling to those nodes already known to the frontend by other means (generally, this means the node is a visible item in the Elements tab). <code>All</code> informs the frontend of all layout context type changes and all nodes with a known layout context are sent to the frontend."
         }
     ],

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-25  Razvan Caliman  <rcaliman@apple.com>
+
+        Web Inspector: List of grid nodes is incomplete in Layout sidebar panel
+        https://bugs.webkit.org/show_bug.cgi?id=222364
+        <rdar://problem/74700960>
+
+        Reviewed by Devin Rousso.
+
+        Ensure default value of `layoutContextTypeChangedMode` is set for InspectorCSSAgent
+        to recognize the mode change when switching monitor layout contexts of all nodes.
+
+        * inspector/agents/InspectorCSSAgent.cpp:
+        (WebCore::InspectorCSSAgent::reset):
+
 2021-02-25  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp

@@ -327 +327 @@
     m_documentToInspectorStyleSheet.clear();
     m_documentToKnownCSSStyleSheets.clear();
+    m_layoutContextTypeChangedMode = Protocol::CSS::LayoutContextTypeChangedMode::Observed;
     resetPseudoStates();
 }