Changeset 273637 in webkit

Timestamp:

Feb 28, 2021 11:42:46 AM (17 months ago)

Author:

weinig@apple.com

Message:

Consider removing support for CSS value keywords with the -khtml- prefix
​https://bugs.webkit.org/show_bug.cgi?id=222515

Reviewed by Darin Adler.

Try removing re-writing of the -khtml- prefix to -webkit- for CSS value keywords
and see what breaks.

• css/parser/CSSPropertyParser.cpp:

(WebCore::cssValueKeywordID):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/parser/CSSPropertyParser.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-28  Sam Weinig  <weinig@apple.com>
+
+        Consider removing support for CSS value keywords with the -khtml- prefix
+        https://bugs.webkit.org/show_bug.cgi?id=222515
+
+        Reviewed by Darin Adler.
+
+        Try removing re-writing of the -khtml- prefix to -webkit- for CSS value keywords
+        and see what breaks. 
+
+        * css/parser/CSSPropertyParser.cpp:
+        (WebCore::cssValueKeywordID):
+
 2021-02-28  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp

@@ -176 +176 @@
         // On iOS we don't want to change values starting with -apple-system to -webkit-system.
         // FIXME: Remove this mangling without breaking the web.
-        if (isAppleLegacyCssValueKeyword(buffer, length) || hasPrefix(buffer, length, "-khtml-")) {
+        if (isAppleLegacyCssValueKeyword(buffer, length)) {
             memmove(buffer + 7, buffer + 6, length + 1 - 6);
             memcpy(buffer, "-webkit", 7);