Changeset 273816 in webkit

Timestamp:

Mar 3, 2021 8:37:24 AM (17 months ago)

Author:

Alexey Shvayka

Message:

Add JSModuleNamespaceObject::deletePropertyByIndex() method
​https://bugs.webkit.org/show_bug.cgi?id=222611

Reviewed by Yusuke Suzuki.

JSTests:

• modules/arbitrary-module-names-indexed.js: Added.
• modules/arbitrary-module-names/export-indexed.js: Added.

Source/JavaScriptCore:

r270923 introduced arbitrary module namespace identifiers, enabling indexed identifiers
to be exported. While they were already handled by getOwnPropertySlotByIndex(), indexed
Delete? override was absent, which prevented TypeError from being thrown.

This patch adds the missing method, aligning JSC with the spec [1].

[1]: ​https://tc39.es/ecma262/#sec-module-namespace-exotic-objects-delete-p

• runtime/JSModuleNamespaceObject.cpp:

(JSC::JSModuleNamespaceObject::deleteProperty):
(JSC::JSModuleNamespaceObject::deletePropertyByIndex):

• runtime/JSModuleNamespaceObject.h:

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/modules/arbitrary-module-names-indexed.js (added)
• JSTests/modules/arbitrary-module-names/export-indexed.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/JSModuleNamespaceObject.cpp (modified) (2 diffs)
• Source/JavaScriptCore/runtime/JSModuleNamespaceObject.h (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2021-03-03  Alexey Shvayka  <shvaikalesh@gmail.com>
+
+        Add JSModuleNamespaceObject::deletePropertyByIndex() method
+        https://bugs.webkit.org/show_bug.cgi?id=222611
+
+        Reviewed by Yusuke Suzuki.
+
+        * modules/arbitrary-module-names-indexed.js: Added.
+        * modules/arbitrary-module-names/export-indexed.js: Added.
+
 2021-03-02  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-03-03  Alexey Shvayka  <shvaikalesh@gmail.com>
+
+        Add JSModuleNamespaceObject::deletePropertyByIndex() method
+        https://bugs.webkit.org/show_bug.cgi?id=222611
+
+        Reviewed by Yusuke Suzuki.
+
+        r270923 introduced arbitrary module namespace identifiers, enabling indexed identifiers
+        to be exported. While they were already handled by getOwnPropertySlotByIndex(), indexed
+        [[Delete]] override was absent, which prevented TypeError from being thrown.
+
+        This patch adds the missing method, aligning JSC with the spec [1].
+
+        [1]: https://tc39.es/ecma262/#sec-module-namespace-exotic-objects-delete-p
+
+        * runtime/JSModuleNamespaceObject.cpp:
+        (JSC::JSModuleNamespaceObject::deleteProperty):
+        (JSC::JSModuleNamespaceObject::deletePropertyByIndex):
+        * runtime/JSModuleNamespaceObject.h:
+
 2021-03-03  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Source/JavaScriptCore/runtime/JSModuleNamespaceObject.cpp

@@ -213 +213 @@
 bool JSModuleNamespaceObject::deleteProperty(JSCell* cell, JSGlobalObject* globalObject, PropertyName propertyName, DeletePropertySlot& slot)
 {
-    // http://www.ecma-international.org/ecma-262/6.0/#sec-module-namespace-exotic-objects-delete-p
+    // https://tc39.es/ecma262/#sec-module-namespace-exotic-objects-delete-p
     JSModuleNamespaceObject* thisObject = jsCast<JSModuleNamespaceObject*>(cell);
     if (propertyName.isSymbol())
@@ -219 +219 @@
 
     return !thisObject->m_exports.contains(propertyName.uid());
+}
+
+bool JSModuleNamespaceObject::deletePropertyByIndex(JSCell* cell, JSGlobalObject* globalObject, unsigned propertyName)
+{
+    VM& vm = globalObject->vm();
+    JSModuleNamespaceObject* thisObject = jsCast<JSModuleNamespaceObject*>(cell);
+    return !thisObject->m_exports.contains(Identifier::from(vm, propertyName).impl());
 }
 

trunk/Source/JavaScriptCore/runtime/JSModuleNamespaceObject.h

@@ -58 +58 @@
     JS_EXPORT_PRIVATE static bool putByIndex(JSCell*, JSGlobalObject*, unsigned propertyName, JSValue, bool shouldThrow);
     JS_EXPORT_PRIVATE static bool deleteProperty(JSCell*, JSGlobalObject*, PropertyName, DeletePropertySlot&);
+    JS_EXPORT_PRIVATE static bool deletePropertyByIndex(JSCell*, JSGlobalObject*, unsigned propertyName);
     JS_EXPORT_PRIVATE static void getOwnPropertyNames(JSObject*, JSGlobalObject*, PropertyNameArray&, DontEnumPropertiesMode);
     JS_EXPORT_PRIVATE static bool defineOwnProperty(JSObject*, JSGlobalObject*, PropertyName, const PropertyDescriptor&, bool shouldThrow);