Changeset 273982 in webkit

Timestamp:

Mar 5, 2021 10:51:46 AM (17 months ago)

Author:

Simon Fraser

Message:

sticky position incorrect behavior in table with dir=RTL
​https://bugs.webkit.org/show_bug.cgi?id=221624
<rdar://problem/74403616>

Reviewed by Zalan Bujtas.
Source/WebCore:

We use scroll offsets when computing sticky constraints, so we should also use them
when computing layer positions in the scrolling tree.

Test: fast/css/sticky/sticky-in-rtl-overflow.html

• page/scrolling/cocoa/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):

LayoutTests:

• fast/css/sticky/sticky-in-rtl-overflow-expected.html: Added.
• fast/css/sticky/sticky-in-rtl-overflow.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/sticky/sticky-in-rtl-overflow-expected.html (added)
• LayoutTests/fast/css/sticky/sticky-in-rtl-overflow.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-03-05  Simon Fraser  <simon.fraser@apple.com>
+
+        sticky position incorrect behavior in table with dir=RTL
+        https://bugs.webkit.org/show_bug.cgi?id=221624
+        <rdar://problem/74403616>
+
+        Reviewed by Zalan Bujtas.
+
+        * fast/css/sticky/sticky-in-rtl-overflow-expected.html: Added.
+        * fast/css/sticky/sticky-in-rtl-overflow.html: Added.
+
 2021-03-05  Jon Lee  <jonlee@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-03-05  Simon Fraser  <simon.fraser@apple.com>
+
+        sticky position incorrect behavior in table with dir=RTL
+        https://bugs.webkit.org/show_bug.cgi?id=221624
+        <rdar://problem/74403616>
+
+        Reviewed by Zalan Bujtas.
+        
+        We use scroll offsets when computing sticky constraints, so we should also use them
+        when computing layer positions in the scrolling tree.
+
+        Test: fast/css/sticky/sticky-in-rtl-overflow.html
+
+        * page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
+        (WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
+
 2021-03-04  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm

@@ -77 +77 @@
         } else {
             auto& overflowScrollingNode = downcast<ScrollingTreeOverflowScrollingNode>(scrollingNode);
-            constrainingRect = FloatRect(overflowScrollingNode.currentScrollPosition(), m_constraints.constrainingRectAtLastLayout().size());
+            constrainingRect = FloatRect(overflowScrollingNode.currentScrollOffset(), m_constraints.constrainingRectAtLastLayout().size());
         }
         return m_constraints.layerPositionForConstrainingRect(constrainingRect);