Changeset 274466 in webkit

Timestamp:

Mar 15, 2021 10:55:19 PM (16 months ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: remove experimental setting and enable Layout sidebar
​https://bugs.webkit.org/show_bug.cgi?id=221246
<rdar://problem/74130753>

Reviewed by BJ Burg.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Base/Setting.js:
• UserInterface/Views/ElementsTabContentView.js:

(WI.ElementsTabContentView):

• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (1 diff)
• UserInterface/Base/Setting.js (modified) (1 diff)
• UserInterface/Views/ElementsTabContentView.js (modified) (1 diff)
• UserInterface/Views/SettingsTabContentView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-03-15  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: remove experimental setting and enable Layout sidebar
+        https://bugs.webkit.org/show_bug.cgi?id=221246
+        <rdar://problem/74130753>
+
+        Reviewed by BJ Burg.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Base/Setting.js:
+        * UserInterface/Views/ElementsTabContentView.js:
+        (WI.ElementsTabContentView):
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
 2021-03-15  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -1317 +1317 @@
 localizedStrings["Show Console tab"] = "Show Console tab";
 localizedStrings["Show Elements"] = "Show Elements";
-localizedStrings["Show Layout panel"] = "Show Layout panel";
 localizedStrings["Show Path"] = "Show Path";
 localizedStrings["Show Remaining (%d)"] = "Show Remaining (%d)";

trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js

@@ -229 +229 @@
     experimentalEnableStylesJumpToEffective: new WI.Setting("experimental-styles-jump-to-effective", false),
     experimentalEnableStylesJumpToVariableDeclaration: new WI.Setting("experimental-styles-jump-to-variable-declaration", false),
-    experimentalEnableLayoutPanel: new WI.Setting("experimental-enable-layout-panel", false),
     experimentalEnableGridBadges: new WI.Setting("experimental-enable-grid-badges", false),
     experimentalCollapseBlackboxedCallFrames: new WI.Setting("experimental-collapse-blackboxed-call-frames", false),

trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js

@@ -33 +33 @@
         ];
 
-        if (WI.settings.experimentalEnableLayoutPanel.value)
+        // COMPATIBILITY (iOS 14.5): `DOM.showGridOverlay` did not exist yet.
+        if (InspectorBackend.hasCommand("DOM.showGridOverlay"))
             detailsSidebarPanelConstructors.push(WI.LayoutDetailsSidebarPanel);
 

trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

@@ -399 +399 @@
             stylesGroup.addSetting(WI.settings.experimentalEnableStylesJumpToEffective, WI.UIString("Show jump to effective property button"));
             stylesGroup.addSetting(WI.settings.experimentalEnableStylesJumpToVariableDeclaration, WI.UIString("Show jump to variable declaration button"));
-            stylesGroup.addSetting(WI.settings.experimentalEnableLayoutPanel, WI.UIString("Show Layout panel"));
             stylesGroup.addSetting(WI.settings.experimentalEnableGridBadges, WI.unlocalizedString("Show \"grid\" badges"));
 
@@ -430 +429 @@
 
         if (hasCSSDomain) {
-            listenForChange(WI.settings.experimentalEnableLayoutPanel);
             listenForChange(WI.settings.experimentalEnableGridBadges);
             listenForChange(WI.settings.experimentalEnableStylesJumpToEffective);