Changeset 274575 in webkit

Timestamp:

Mar 17, 2021 11:56:31 AM (16 months ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: remove experimental setting and enable "grid" badges
​https://bugs.webkit.org/show_bug.cgi?id=223209
<rdar://problem/75442185>

Reviewed by BJ Burg.

• UserInterface/Base/Setting.js:
• UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype._updateGridBadge):

• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Setting.js (modified) (1 diff)
• UserInterface/Views/DOMTreeElement.js (modified) (1 diff)
• UserInterface/Views/SettingsTabContentView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-03-17  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: remove experimental setting and enable "grid" badges
+        https://bugs.webkit.org/show_bug.cgi?id=223209
+        <rdar://problem/75442185>
+
+        Reviewed by BJ Burg.
+
+        * UserInterface/Base/Setting.js:
+        * UserInterface/Views/DOMTreeElement.js:
+        (WI.DOMTreeElement.prototype._updateGridBadge):
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
 2021-03-15  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js

@@ -229 +229 @@
     experimentalEnableStylesJumpToEffective: new WI.Setting("experimental-styles-jump-to-effective", false),
     experimentalEnableStylesJumpToVariableDeclaration: new WI.Setting("experimental-styles-jump-to-variable-declaration", false),
-    experimentalEnableGridBadges: new WI.Setting("experimental-enable-grid-badges", false),
     experimentalCollapseBlackboxedCallFrames: new WI.Setting("experimental-collapse-blackboxed-call-frames", false),
 

trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js

@@ -2013 +2013 @@
     _updateGridBadge()
     {
-        if (!WI.settings.experimentalEnableGridBadges.value)
-            return;
-
         if (!this.listItemElement || this._elementCloseTag)
             return;

trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

@@ -399 +399 @@
             stylesGroup.addSetting(WI.settings.experimentalEnableStylesJumpToEffective, WI.UIString("Show jump to effective property button"));
             stylesGroup.addSetting(WI.settings.experimentalEnableStylesJumpToVariableDeclaration, WI.UIString("Show jump to variable declaration button"));
-            stylesGroup.addSetting(WI.settings.experimentalEnableGridBadges, WI.unlocalizedString("Show \"grid\" badges"));
 
             experimentalSettingsView.addSeparator();
@@ -429 +428 @@
 
         if (hasCSSDomain) {
-            listenForChange(WI.settings.experimentalEnableGridBadges);
             listenForChange(WI.settings.experimentalEnableStylesJumpToEffective);
             listenForChange(WI.settings.experimentalEnableStylesJumpToVariableDeclaration);