Changeset 275337 in webkit

Timestamp:

Mar 31, 2021 7:02:47 PM (16 months ago)

Author:

Patrick Angle

Message:

Web Inspector: Regression (r270134) Timeline recordings 2 and beyond do not show a timescale.
​https://bugs.webkit.org/show_bug.cgi?id=222930

Reviewed by Devin Rousso.

When a new TimelineOverview is created, it calls TimelineOverview.prototype._viewModeDidChange inside the
constructor, which in turn called updateLayout. This was problematic in that a TimelineRuler would have
sizeDidChange invoked before it was attached to the DOM, which meant that there was no width to cache. Because
sizeDidChange is only invoked during the first layout and on resize events, the cached width is not updated
when the ruler is attached to the view hierarchy, having already performed an early initial layout.

This patch now checks if the TimelineOverview has performed its initial layout before updating the layout
inside _viewModeDidChange, which means that the initial layout on the child TimelineRuler will be done while
attached, thus producing a valid width value to cache.

• UserInterface/Views/TimelineOverview.js:

(WI.TimelineRuler.prototype._viewModeDidChange):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TimelineOverview.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-03-31  Patrick Angle  <pangle@apple.com>
+
+        Web Inspector: Regression (r270134) Timeline recordings 2 and beyond do not show a timescale.
+        https://bugs.webkit.org/show_bug.cgi?id=222930
+
+        Reviewed by Devin Rousso.
+
+        When a new `TimelineOverview` is created, it calls `TimelineOverview.prototype._viewModeDidChange` inside the
+        constructor, which in turn called `updateLayout`. This was problematic in that a `TimelineRuler` would have
+        `sizeDidChange` invoked before it was attached to the DOM, which meant that there was no width to cache. Because
+        `sizeDidChange` is only invoked during the first layout and on resize events, the cached width is not updated
+        when the ruler is attached to the view hierarchy, having already performed an early initial layout.
+
+        This patch now checks if the `TimelineOverview` has performed its initial layout before updating the layout
+        inside `_viewModeDidChange`, which means that the initial layout on the child `TimelineRuler` will be done while
+        attached, thus producing a valid width value to cache.
+
+        * UserInterface/Views/TimelineOverview.js:
+        (WI.TimelineRuler.prototype._viewModeDidChange):
+
 2021-03-31  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js

@@ -854 +854 @@
         this.element.classList.toggle("frames", isRenderingFramesMode);
 
-        this.updateLayout(WI.View.LayoutReason.Resize);
+        if (this.didInitialLayout)
+            this.updateLayout(WI.View.LayoutReason.Resize);
     }