Changeset 275377 in webkit


Ignore:
Timestamp:
Apr 1, 2021 1:52:40 PM (16 months ago)
Author:
commit-queue@webkit.org
Message:

aspect-ratio not recomputed on hover
​https://bugs.webkit.org/show_bug.cgi?id=224028

Patch by Rob Buis <​rbuis@igalia.com> on 2021-04-01
Reviewed by Zalan Bujtas.

LayoutTests/imported/w3c:

Add test for this.

  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-dynamic-aspect-ratio-expected.xht: Added.
  • web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-dynamic-aspect-ratio.html: Added.

Source/WebCore:

Detect change in aspect-ratio on hover.

Test: imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-dynamic-aspect-ratio.html

  • rendering/style/RenderStyle.cpp:

(WebCore::rareNonInheritedDataChangeRequiresLayout):

Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r275347 r275377  
     12021-04-01  Rob Buis  <rbuis@igalia.com>
     2
     3        aspect-ratio not recomputed on hover
     4        https://bugs.webkit.org/show_bug.cgi?id=224028
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        Add test for this.
     9
     10        * web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-dynamic-aspect-ratio-expected.xht: Added.
     11        * web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-dynamic-aspect-ratio.html: Added.
     12
    1132021-03-31  Antoine Quint  <graouts@webkit.org>
    214

  • trunk/Source/WebCore/ChangeLog

    r275375 r275377  
     12021-04-01  Rob Buis  <rbuis@igalia.com>
     2
     3        aspect-ratio not recomputed on hover
     4        https://bugs.webkit.org/show_bug.cgi?id=224028
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        Detect change in aspect-ratio on hover.
     9
     10        Test: imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-dynamic-aspect-ratio.html
     11
     12        * rendering/style/RenderStyle.cpp:
     13        (WebCore::rareNonInheritedDataChangeRequiresLayout):
     14
    1152021-04-01  Chris Dumez  <cdumez@apple.com>
    216

  • trunk/Source/WebCore/rendering/style/RenderStyle.cpp

    r275199 r275377  
    738738        return true;
    739739#endif
     740
     741    if (first.aspectRatioType != second.aspectRatioType || first.aspectRatioWidth != second.aspectRatioWidth || first.aspectRatioWidth != second.aspectRatioHeight)
     742        return true;
    740743
    741744    return false;
Note: See TracChangeset for help on using the changeset viewer.