Changeset 275545 in webkit

Timestamp:

Apr 6, 2021 1:26:30 PM (16 months ago)

Author:

BJ Burg

Message:

Web Inspector: remove duplicate Box Model section from Layout panel in Elements Tab
​https://bugs.webkit.org/show_bug.cgi?id=224206
<rdar://problem/76235731>

Reviewed by Devin Rousso.

For now, remove it from Layout panel. It may go back there
when it is able to show used values. It currently only shows computed.

• UserInterface/Views/LayoutDetailsSidebarPanel.js:

(WI.LayoutDetailsSidebarPanel.prototype.initialLayout):
(WI.LayoutDetailsSidebarPanel.prototype.layout):
(WI.LayoutDetailsSidebarPanel.prototype.get minimumWidth): Deleted.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/LayoutDetailsSidebarPanel.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-04-06  BJ Burg  <bburg@apple.com>
+
+        Web Inspector: remove duplicate Box Model section from Layout panel in Elements Tab
+        https://bugs.webkit.org/show_bug.cgi?id=224206
+        <rdar://problem/76235731>
+
+        Reviewed by Devin Rousso.
+
+        For now, remove it from Layout panel. It may go back there
+        when it is able to show used values. It currently only shows computed.
+
+        * UserInterface/Views/LayoutDetailsSidebarPanel.js:
+        (WI.LayoutDetailsSidebarPanel.prototype.initialLayout):
+        (WI.LayoutDetailsSidebarPanel.prototype.layout):
+        (WI.LayoutDetailsSidebarPanel.prototype.get minimumWidth): Deleted.
+
 2021-04-06  Razvan Caliman  <rcaliman@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js

@@ -36 +36 @@
 
     // Public
-
-    get minimumWidth()
-    {
-        return this._boxModelDiagramRow?.minimumWidth ?? 0;
-    }
 
     inspect(objects)
@@ -103 +98 @@
     initialLayout()
     {
-        this._boxModelDiagramRow = new WI.BoxModelDetailsSectionRow;
-        let boxModelGroup = new WI.DetailsSectionGroup([this._boxModelDiagramRow]);
-        let boxModelSection = new WI.DetailsSection("layout-box-model", WI.UIString("Box Model"), [boxModelGroup]);
-        this.contentView.element.appendChild(boxModelSection.element);
-
         this._gridDetailsSectionRow = new WI.DetailsSectionRow(WI.UIString("No CSS Grid Contexts", "No CSS Grid Contexts @ Layout Details Sidebar Panel", "Message shown when there are no CSS Grid contexts on the inspected page."));
         let gridGroup = new WI.DetailsSectionGroup([this._gridDetailsSectionRow]);
@@ -135 +125 @@
             this._gridSection.gridNodeSet = this._gridNodeSet;
         }
-
-        if (this._boxModelDiagramRow.nodeStyles !== this._nodeStyles)
-            this._boxModelDiagramRow.nodeStyles = this._nodeStyles;
     }