Changeset 276478 in webkit

Timestamp:

Apr 22, 2021 5:56:56 PM (15 months ago)

Author:

Jean-Yves Avenard

Message:

Fix color gamut in WebRTC when using VPx software decoder.
​https://bugs.webkit.org/show_bug.cgi?id=220972
<rdar://problem/73616455>

Reviewed by Youenn Fablet.

Source/WebCore:

By default, and how libwebrtc is configuring its encoders and decoder, video range levels are used
(16-235). Video range was assumed to use full range instead (0-255), causing blacks to look grey and
whites to appear washed-out.
It is theoretically possible, when using VP9 that full-range level are used. While the information
related to video levels is available at the VP9 codec level; only the color space information is
being made available in libwebrtc's public image data structure, color range isn't.
For now we can assume the default is sufficient, and a follow-up change will be submitted to libwebrtc
later on.

In memory of Dr. Alex. May he rest in peace.
Test: webrtc/video-vp8-videorange.html

• platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:

(WebCore::RealtimeIncomingVideoSourceCocoa::pixelBufferPool):

LayoutTests:

• webrtc/video-vp8-videorange-expected.txt: Added.
• webrtc/video-vp8-videorange.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webrtc/video-vp8-videorange-expected.txt (added)
• LayoutTests/webrtc/video-vp8-videorange.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-04-22  Jean-Yves Avenard  <jya@apple.com>
+
+        Fix color gamut in WebRTC when using VPx software decoder.
+        https://bugs.webkit.org/show_bug.cgi?id=220972
+        <rdar://problem/73616455>
+
+        Reviewed by Youenn Fablet.
+
+        * webrtc/video-vp8-videorange-expected.txt: Added.
+        * webrtc/video-vp8-videorange.html: Added.
+
 2021-04-22  Robert Jenner  <jenner@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-22  Jean-Yves Avenard  <jya@apple.com>
+
+        Fix color gamut in WebRTC when using VPx software decoder.
+        https://bugs.webkit.org/show_bug.cgi?id=220972
+        <rdar://problem/73616455>
+
+        Reviewed by Youenn Fablet.
+
+        By default, and how libwebrtc is configuring its encoders and decoder, video range levels are used
+        (16-235). Video range was assumed to use full range instead (0-255), causing blacks to look grey and
+        whites to appear washed-out.
+        It is theoretically possible, when using VP9 that full-range level are used. While the information
+        related to video levels is available at the VP9 codec level; only the color space information is
+        being made available in libwebrtc's public image data structure, color range isn't.
+        For now we can assume the default is sufficient, and a follow-up change will be submitted to libwebrtc
+        later on.
+
+        In memory of Dr. Alex. May he rest in peace.
+        Test: webrtc/video-vp8-videorange.html
+
+        * platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
+        (WebCore::RealtimeIncomingVideoSourceCocoa::pixelBufferPool):
+
 2021-04-22  Michael Catanzaro  <mcatanzaro@gnome.org>
 

trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm

@@ -95 +95 @@
         switch (bufferType) {
         case webrtc::BufferType::I420:
-            poolBufferType = kCVPixelFormatType_420YpCbCr8BiPlanarFullRange;
+            poolBufferType = kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange;
             break;
         case webrtc::BufferType::I010:
-            poolBufferType = kCVPixelFormatType_420YpCbCr10BiPlanarFullRange;
+            poolBufferType = kCVPixelFormatType_420YpCbCr10BiPlanarVideoRange;
         }
         m_pixelBufferPool = createPixelBufferPool(width, height, poolBufferType);