Changeset 276638 in webkit


Ignore:
Timestamp:
Apr 27, 2021 7:25:59 AM (15 months ago)
Author:
graouts@webkit.org
Message:

Correctly specify interpolation of page-break-* properties
​https://bugs.webkit.org/show_bug.cgi?id=225098

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Mark 15 WPT progressions.

  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

As it turns out the page-break-* properties are shorthands of the break-* properties.

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r276627 r276638  
     12021-04-27  Antoine Quint  <graouts@webkit.org>
     2
     3        Correctly specify interpolation of page-break-* properties
     4        https://bugs.webkit.org/show_bug.cgi?id=225098
     5
     6        Reviewed by Antti Koivisto.
     7
     8        Mark 15 WPT progressions.
     9
     10        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
     11        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
     12        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
     13
    1142021-04-26  Tim Nguyen  <ntim@apple.com>
    215

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt

    r276554 r276638  
    6767PASS page-break-after (type: discrete) has testAccumulation function
    6868PASS page-break-after: "auto" onto "always"
    69 FAIL page-break-after: "always" onto "auto" assert_equals: The value should be always at 0ms expected "always" but got "auto"
     69PASS page-break-after: "always" onto "auto"
    7070PASS page-break-before (type: discrete) has testAccumulation function
    7171PASS page-break-before: "auto" onto "always"
    72 FAIL page-break-before: "always" onto "auto" assert_equals: The value should be always at 0ms expected "always" but got "auto"
     72PASS page-break-before: "always" onto "auto"
    7373PASS page-break-inside (type: discrete) has testAccumulation function
    74 FAIL page-break-inside: "avoid" onto "auto" assert_equals: The value should be avoid at 0ms expected "avoid" but got "auto"
     74PASS page-break-inside: "avoid" onto "auto"
    7575PASS page-break-inside: "auto" onto "avoid"
    7676PASS paint-order (type: discrete) has testAccumulation function

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt

    r276554 r276638  
    6767PASS page-break-after (type: discrete) has testAddition function
    6868PASS page-break-after: "auto" onto "always"
    69 FAIL page-break-after: "always" onto "auto" assert_equals: The value should be always at 0ms expected "always" but got "auto"
     69PASS page-break-after: "always" onto "auto"
    7070PASS page-break-before (type: discrete) has testAddition function
    7171PASS page-break-before: "auto" onto "always"
    72 FAIL page-break-before: "always" onto "auto" assert_equals: The value should be always at 0ms expected "always" but got "auto"
     72PASS page-break-before: "always" onto "auto"
    7373PASS page-break-inside (type: discrete) has testAddition function
    74 FAIL page-break-inside: "avoid" onto "auto" assert_equals: The value should be avoid at 0ms expected "avoid" but got "auto"
     74PASS page-break-inside: "avoid" onto "auto"
    7575PASS page-break-inside: "auto" onto "avoid"
    7676PASS paint-order (type: discrete) has testAddition function

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt

    r276554 r276638  
    7979PASS overflow-y uses discrete animation when animating between "visible" and "hidden" with keyframe easing
    8080PASS page-break-after (type: discrete) has testInterpolation function
    81 FAIL page-break-after uses discrete animation when animating between "always" and "auto" with linear easing assert_equals: The value should be always at 0ms expected "always" but got "auto"
    82 FAIL page-break-after uses discrete animation when animating between "always" and "auto" with effect easing assert_equals: The value should be always at 0ms expected "always" but got "auto"
    83 FAIL page-break-after uses discrete animation when animating between "always" and "auto" with keyframe easing assert_equals: The value should be always at 0ms expected "always" but got "auto"
     81PASS page-break-after uses discrete animation when animating between "always" and "auto" with linear easing
     82PASS page-break-after uses discrete animation when animating between "always" and "auto" with effect easing
     83PASS page-break-after uses discrete animation when animating between "always" and "auto" with keyframe easing
    8484PASS page-break-before (type: discrete) has testInterpolation function
    85 FAIL page-break-before uses discrete animation when animating between "always" and "auto" with linear easing assert_equals: The value should be always at 0ms expected "always" but got "auto"
    86 FAIL page-break-before uses discrete animation when animating between "always" and "auto" with effect easing assert_equals: The value should be always at 0ms expected "always" but got "auto"
    87 FAIL page-break-before uses discrete animation when animating between "always" and "auto" with keyframe easing assert_equals: The value should be always at 0ms expected "always" but got "auto"
     85PASS page-break-before uses discrete animation when animating between "always" and "auto" with linear easing
     86PASS page-break-before uses discrete animation when animating between "always" and "auto" with effect easing
     87PASS page-break-before uses discrete animation when animating between "always" and "auto" with keyframe easing
    8888PASS page-break-inside (type: discrete) has testInterpolation function
    89 FAIL page-break-inside uses discrete animation when animating between "auto" and "avoid" with linear easing assert_equals: The value should be avoid at 500ms expected "avoid" but got "auto"
    90 FAIL page-break-inside uses discrete animation when animating between "auto" and "avoid" with effect easing assert_equals: The value should be avoid at 960ms expected "avoid" but got "auto"
    91 FAIL page-break-inside uses discrete animation when animating between "auto" and "avoid" with keyframe easing assert_equals: The value should be avoid at 960ms expected "avoid" but got "auto"
     89PASS page-break-inside uses discrete animation when animating between "auto" and "avoid" with linear easing
     90PASS page-break-inside uses discrete animation when animating between "auto" and "avoid" with effect easing
     91PASS page-break-inside uses discrete animation when animating between "auto" and "avoid" with keyframe easing
    9292PASS paint-order (type: discrete) has testInterpolation function
    9393PASS paint-order uses discrete animation when animating between "fill" and "stroke" with linear easing

  • trunk/Source/WebCore/ChangeLog

    r276637 r276638  
     12021-04-27  Antoine Quint  <graouts@webkit.org>
     2
     3        Correctly specify interpolation of page-break-* properties
     4        https://bugs.webkit.org/show_bug.cgi?id=225098
     5
     6        Reviewed by Antti Koivisto.
     7
     8        As it turns out the page-break-* properties are shorthands of the break-* properties.
     9
     10        * animation/CSSPropertyAnimation.cpp:
     11        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     12
    1132021-04-27  Zalan Bujtas  <zalan@apple.com>
    214

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r276553 r276638  
    24352435        new DiscretePropertyWrapper<Overflow>(CSSPropertyOverflowX, &RenderStyle::overflowX, &RenderStyle::setOverflowX),
    24362436        new DiscretePropertyWrapper<Overflow>(CSSPropertyOverflowY, &RenderStyle::overflowY, &RenderStyle::setOverflowY),
    2437         new DiscretePropertyWrapper<BreakBetween>(CSSPropertyPageBreakAfter, &RenderStyle::breakAfter, &RenderStyle::setBreakAfter),
    2438         new DiscretePropertyWrapper<BreakBetween>(CSSPropertyPageBreakBefore, &RenderStyle::breakBefore, &RenderStyle::setBreakBefore),
    2439         new DiscretePropertyWrapper<BreakInside>(CSSPropertyPageBreakInside, &RenderStyle::breakInside, &RenderStyle::setBreakInside),
     2437        new DiscretePropertyWrapper<BreakBetween>(CSSPropertyBreakAfter, &RenderStyle::breakAfter, &RenderStyle::setBreakAfter),
     2438        new DiscretePropertyWrapper<BreakBetween>(CSSPropertyBreakBefore, &RenderStyle::breakBefore, &RenderStyle::setBreakBefore),
     2439        new DiscretePropertyWrapper<BreakInside>(CSSPropertyBreakInside, &RenderStyle::breakInside, &RenderStyle::setBreakInside),
    24402440        new DiscretePropertyWrapper<PaintOrder>(CSSPropertyPaintOrder, &RenderStyle::paintOrder, &RenderStyle::setPaintOrder),
    24412441        new DiscretePropertyWrapper<PointerEvents>(CSSPropertyPointerEvents, &RenderStyle::pointerEvents, &RenderStyle::setPointerEvents),
    … …  
    24862486        CSSPropertyOutline,
    24872487        CSSPropertyPadding,
     2488        CSSPropertyPageBreakAfter,
     2489        CSSPropertyPageBreakBefore,
     2490        CSSPropertyPageBreakInside,
    24882491        CSSPropertyWebkitTextStroke,
    24892492        CSSPropertyColumnRule,
Note: See TracChangeset for help on using the changeset viewer.